Doctrine Project

[PHPCR-102] DocumentManager::reorder can not be called multiple times for the same parent

Fri, 19 Apr 2013 11:10:20 +0000

unless i really misread the code in UnitOfWork::scheduleReorder, trying to reorder more than one child of the same parent document will drop the previous reordering.

the whole method is of limited use, as you can also reorder the children in the ChildrenCollection.

[PHPCR-11] Expose transaction API

Sat, 15 Oct 2011 16:13:45 +0000

this requires support in PHPCR/Jackalope

[PHPCR-8] add support for getting node(s) with subnodes at once

Mon, 10 Oct 2011 09:49:59 +0000

this requires support for this in PHPCR/jackalope

[PHPCR-5] test with Midgard2 PHPCR

Wed, 28 Dec 2011 23:29:48 +0000

https://github.com/bergie/phpcr-midgard2

[PHPCR-1] children/child annotation add value later

Fri, 22 Jul 2011 07:40:32 +0000

when using the child annotation, it is not possible to assign a child document with a child of its own after persisting the parent document. to reproduce, take the Functional/FileTest.php and change
$parent->file = new File();
$parent->id = '/functional/filetest';
$parent->file->setFileContentFromFilesystem(dirname(_FILE_) .'/_files/foo.txt');

$this->dm->persist($parent);

to
$parent->id = '/functional/filetest';
$this->dm->persist($parent);

$parent->file = new File();
$parent->file->setFileContentFromFilesystem(dirname(_FILE_) .'/_files/foo.txt');

you will get "mandatory child node

{http://www.jcp.org/jcr/1.0}

content does not exist"

[PHPCR-2] load document with child annotation

Fri, 24 Jun 2011 13:14:55 +0000

if i did not previously load a document of the class of the child, phpcr-odm can not know the alias to load it. it throws an exception.

for example, use $this->documentManager->find('My\Class', '/path/to/document'); where My\Class has an @child annotation for a child that is a File. it has the file alias, but phpcr-odm knows nothing of that alias if i did not previously try to find something with 'Doctrine\...\File' that made it load the meta data.

the workaround is to get the repositories to make phpcr-odm know the alias, but this is no solution.
$this->documentManager->getRepository('Doctrine\ODM\PHPCR\Document\Resource');
$this->documentManager->getRepository('Doctrine\ODM\PHPCR\Document\File');

we could add something to specify the document class in the child annotation, but this sounds stupid.

and getting a document without knowing its document class beforehand would be a nice feature in general. however, the info is currently scattered in annotations over the project. any idea how we could make phpcr-odm know all alias to document class mappings?

[PHPCR-31] add support for metadata caching

Wed, 28 Dec 2011 23:28:05 +0000

add support for metadata caching

[PHPCR-19] Code cleanup and refactoring, align to other odm implementations

Sat, 30 Jul 2011 13:03:05 +0000

Refactor the code to share more code with mongodb and other ODM implementations. Can we extract stuff into common base classes or adjust mongo so we can extend from it? The current code is often copy-paste with some small edits all over which makes it hard to update with new features and bugfixes from mongodb.

Also have a look at the OXM - we probably could profit from collaboration there too, as PHPCR is somewhere between document store and XML database. http://www.doctrine-project.org/blog/doctrine-oxm-intro

Implement ObjectManager interface and maybe add to the common interfaces like findMany suitable for us.

[PHPCR-83] make the test suite run and pass with Doctrine DBAL

Reference — Fri, 11 Jan 2013 15:13:59 +0000

this will likely require some work to disable certain tests relying on features not yet implemented

[PHPCR-79] metadata type for non-property mappings

Mon, 14 Jan 2013 23:13:29 +0000

(this is a follow up of https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/issues/56)

ClassMetadata::mapField does not automatically assign a type except for the id field. we should add them here to have type information for things like nodename so for example sonata admin (or the symfony form builder?) can use that information to decide on the widget to use.

open question: is there a natural type mapping for children/parent? should we use MANY_TO_ONE for parent and ONE_TO_MANY for children? or is that a problem as its not arbitrary relations, should we add new types for this?

[PHPCR-78] Exception "Can't remove the protected property: jcr:created" on persist

Thu, 30 Aug 2012 09:12:46 +0000

When a Document contains a reference field (tested with @ReferenceMany(strategy="hard"), @ReferenceOne(strategy="hard")) and a "jcr:created" field in its metadata, then phpcr-odm try to update the protected field (jcr:created) to NULL on persist.

Jackalope throws the following exception :

[PHPCR\NodeType\ConstraintViolationException]
Can't remove the protected property: jcr:created

[PHPCR-52] lazy loading of ReferenceMany fails

Wed, 22 Feb 2012 14:57:38 +0000

When I have a document with ReferenceMany "Links", Doctrine PHPCR always loads all those referenced documents, even if I just load the main document. This is obviously very bad for performance.

https://gist.github.com/1838831
is a reproducible use-case. Just ran it twice and you'll see that in the second run, there is

one GET request for the initial documents
a REPORT request for every referenced document to resolve the UUID to a path
a POST request for multi-get-ing all the referenced documents

See also this charles-screenshot
https://img.skitch.com/20120215-8572c4s5mc8gt2da5wjd71512w.jpg

I have no idea where to look at to fix this, so any help would be very appreciated

[PHPCR-53] repository::createDocument is never called

Wed, 22 Feb 2012 07:51:06 +0000

i tried using repositories. see

https://github.com/symfony-cmf/ChainRoutingBundle/commit/12515f82b02c4a1ef230b05133ec89e03c1af2e0
https://github.com/symfony-cmf/ChainRoutingBundle/commit/edd9f9544eadedb142fefd3ea9bb0c3b293c59d5

however, from looking at the uow code i have the impression that createDocument is never called on DocumentRepository but directly in UOW. shouldn't the uow fetch the repository and build the document with the repository? effectively moving UOW::createDocument impl. to the base repository?

[PHPCR-51] make it possible to add attributes to type mappings

Thu, 16 Feb 2012 16:48:34 +0000

f.e. make it possible to make a string mapped typed translatable inside an inherited class
this will require modifications to the ClassMetadata class:
https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Mapping/ClassMetadata.php#L578

[PHPCR-50] fix handling of children on update

Thu, 12 Apr 2012 20:40:12 +0000

right now we do not check if individual elements in the collection have been added or removed. furthermore since we can now update the order of children in jackalope, we can implement this in collection persistence as well.

[PHPCR-49] rewrite DocumentRepository::createQuery() to use QOM

Fri, 10 Feb 2012 17:46:43 +0000

https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/DocumentRepository.php#L253

[PHPCR-47] make it possible to disable exceptions for phpcr implementations without versioning support

Reference — Wed, 14 Nov 2012 10:49:45 +0000

so method calls to checkPoint() etc shouldn't fail. full versioning should just set referenceable etc.

[PHPCR-42] sync the xml/yml mapping driver with the annotation driver

Fri, 17 Aug 2012 08:17:16 +0000

especially the locale/version stuff is not yet supported. but also the reference mapping seems to look quite different.

[PHPCR-37] update for latest doctrine common features

Wed, 28 Dec 2011 23:28:15 +0000

see

https://github.com/doctrine/common/pull/71
https://github.com/doctrine/common/pull/75
https://github.com/doctrine/common/pull/83
https://github.com/doctrine/common/commit/07d2f04408534f0870d9873a420e294a4b0db439 (done)

as well as https://github.com/doctrine/couchdb-odm/commit/56f4ce911c9fd7cf32547a9d454141f250c9de54 (done)

[PHPCR-35] referenced documents need to be referenceable

Wed, 28 Dec 2011 23:31:59 +0000

currently documents referenced need to have referenceable=true in their document annotation, otherwise the @ReferenceOne silently fails. (see also https://github.com/symfony-cmf/cmf-sandbox/pull/29 )

either phpcr-odm should complain. or it could just add the mix:referenceable to the target document even though it was not declared referenceable.
we could additionally make referenceable=true the default and offer explicit referenceable=false for optimization.

[PHPCR-34] replacing a document fails

Wed, 22 Feb 2012 15:03:39 +0000

when we have a saved document and remove that, then add a document at the same path without a flush in between, we get an exception. the reason is that persist already adds the phpcr node, but scheduleRemove does not remove the phpcrnode right away.

the fix looks like it should be:
UnitOfWork.php 504 remove phpcr node - 1022 do not remove here as it was removed before.

but this leads to a problem that is either in jackalope or the phpcr-odm about /functional/user/phpcr:class being not found.

1) Doctrine\Tests\ODM\PHPCR\Functional\BasicCrudTest::testRemoveAndInsert
PHPCR\ItemExistsException: This node already has a child named user.

/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/vendor/jackalope/src/Jackalope/Node.php:303
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/Doctrine/ODM/PHPCR/UnitOfWork.php:763
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/Doctrine/ODM/PHPCR/UnitOfWork.php:404
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/Doctrine/ODM/PHPCR/UnitOfWork.php:386
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/Doctrine/ODM/PHPCR/DocumentManager.php:312
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/tests/Doctrine/Tests/ODM/PHPCR/Functional/BasicCrudTest.php:152

[PHPCR-69] persist referrers

Fri, 11 Jan 2013 08:53:40 +0000

phpcr knows reference and referrer (backlink). the reference is a property of a node with a defined name. the referrer is an information on the node without a property name in PHPCR. we have the annotation @Referrers to map this information onto a document field. the annotation can take an optional filter argument to only use references pointing to this node with a specific phpcr name.

we could add something like the cascade option found in the orm to allow assigning a document to a referrer property and automatically persist it. we will need to explicitly specify the reference property name to be used on the source document in this case (orm uses mappedBy for this)

github user mdekrijger started working on this. today, he wrote: Adding the annotations was quite easy, still figuring out the unitofwork where the actual processing must be implemented. Currently I can't spend much more time on it until end of june. If it isn't done yet by that time, I surely will pick it up from there.

[PHPCR-70] ContentDocument Relationships returning NULL in Action

Sat, 21 Jul 2012 14:26:04 +0000

So i have 2 Documents:

Page: http://pastebin.com/b5X32JPc

Category: http://pastebin.com/A1gB6kyg

A Category has many pages.

Now here's my (test) action: http://pastebin.com/ypjxqZPu

As you can see, $contentDocument is a page in this case. If i call $contentDocument->category i get back "null".

If however i tell the document manager to fetch the Page document by it's path, then $contentDocument->category will work...

Our conclusion is that if you take the $contentDocument that is passed to your action, and you try to fetch it's ParentDocument inside the action (mapped to a property) you always get null.
However, what is very weird, is that inside twig it works (page.category would work in twig but page->category would return null inside the action, before the twig render)

[PHPCR-62] avoid dereferencing proxies on save

Tue, 10 Apr 2012 08:47:37 +0000

chregu found in a large project that the odm seems to resolve all unresolved proxy documents during flush, even if the @ReferenceMany or @Referrer was not touched by the code.

we should make sure this does not happen.

[PHPCR-90] referrer delete and cascade delete

Tue, 12 Mar 2013 17:04:17 +0000

currently, removing an entry from the referrer collection has no effect, nothing is deleted.

without cascading, we should delete the value from the referencing property (needs the filter(mappedBy) attribute again), with cascading we should delete the referencing document.

[PHPCR-107] Support for ->sameNode type queries in QueryBuilder/ExpressionBuilder

Thu, 25 Apr 2013 16:40:07 +0000

We should support sameNode operator of the QOMFactory in the QueryBuilder.

An example using the PHPCR QB from the DoctrinePHPCRAdminBundle:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

        $qb = $queryProxy->getQueryBuilder();
        $qmf = $qb->getQOMFactory();

        $constraint = null;
        foreach ($idx as $id) {
            $path = $this->getBackendId($id);
            $condition = $qmf->sameNode($path);
            if ($constraint) {
                $constraint = $qmf->orConstraint($constraint, $condition);
            } else {
                $constraint = $condition;
            }
        }
        $qb->andWhere($constraint);

[PHPCR-28] figure out proper handling of types in DocumentManager::quote()

Wed, 22 Feb 2012 14:58:03 +0000

figure out proper handling of types in DocumentManager::quote()

[PHPCR-13] Implement DocumentManager::merge()

Wed, 9 Jan 2013 14:34:17 +0000

Implement DocumentManager::merge()

[PHPCR-55] Add mapping for maps/associative arrays

Sun, 26 Feb 2012 16:37:36 +0000

Add a mapping for maps or arrays. Either implement as child node or serialize the array to a string. The first approach needs another node being fetched from the repository but allows to search the array.

[PHPCR-72] persist cancels move

Sat, 21 Jul 2012 07:54:08 +0000

If i have a node that i fetch from the repo using $dm->find()

If i change an attribute in it.
Then i call $dm->move() on it

Then i call $dm->flush().

It will work.

However if i call $dm->persist() on the node (that i already fetched from $dm->find()) and then call $dm->flush()
The $dm->move() won't occur, it will be cancelled, but the attribute i changed will still be updated.

[PHPCR-68] Versionable Item completely loses references

Sun, 22 Jul 2012 19:29:02 +0000

I have a post that has a reference to a subcategory

When i made my post versionable="full", the current and old versions of post lost this reference.

So when i call $post->subcategory i get back a Generic ODM document instead of a Subcategory Document

I know that relationships are not versionable, but relationships should at least still exist.

The workaround is to get the parent path and make a JCR-SQL2 query to fetch the subcategory document.

[PHPCR-67] Fetching a node beforehand ruins ordering of collections

Sun, 22 Jul 2012 19:24:30 +0000

Two documents: Category and Subcategory
Category has $subcategories as a PHPCRODM\Children

If Category A has 3 subcategories B1 B2 B3.

If A's subcategories are fetched we would receive them in the following order: B1 B2 B3.

Now if however we fetched the B2 node using the DocumentManager at an earlier line and then fetched the subcategories of A, we would receive them in the following order:
B2 B1 B3