Doctrine Project

[PHPCR-110] getAssociationTargetClass targetDocument not set

Mon, 13 May 2013 20:50:00 +0000

follow up of https://github.com/doctrine/phpcr-odm/pull/279

ClassMetadata

// TODO this may be not set. what happens if we would return null then?
return $this->mappings[$fieldName]['targetDocument'];

investigate and fix once 279 is merged.

[PHPCR-109] Why Generic::getNodename and not camelcase?

Mon, 13 May 2013 20:48:39 +0000

Is there a reason why the get node name method on the generic document is ->getNodename and not ->getNodeName?

[PHPCR-108] suport entity listeners resp document listeners

Sun, 5 May 2013 07:42:37 +0000

see http://docs.doctrine-project.org/en/latest/reference/events.html#entity-listeners

[PHPCR-107] Support for ->sameNode type queries in QueryBuilder/ExpressionBuilder

Thu, 25 Apr 2013 16:40:07 +0000

We should support sameNode operator of the QOMFactory in the QueryBuilder.

An example using the PHPCR QB from the DoctrinePHPCRAdminBundle:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

        $qb = $queryProxy->getQueryBuilder();
        $qmf = $qb->getQOMFactory();

        $constraint = null;
        foreach ($idx as $id) {
            $path = $this->getBackendId($id);
            $condition = $qmf->sameNode($path);
            if ($constraint) {
                $constraint = $qmf->orConstraint($constraint, $condition);
            } else {
                $constraint = $condition;
            }
        }
        $qb->andWhere($constraint);

[PHPCR-106] Make getRefererrs return not-yet-flushed referring documents

Thu, 18 Apr 2013 13:03:25 +0000

Currently the DocumentManager->getReferrers() method returns only referrers that have already been flushed to the database.

It is (I think) desireable for this method to return also those objects which have been added to the UnitOfWork but have not yet been flushed to the database.

[PHPCR-105] ensure xml and yml naming conventions are consistent

Fri, 19 Apr 2013 12:07:23 +0000

for yml, all mappings must use camelCase, while for xml it must be connected-text in all lowercase with the dash between. it seems at least fieldName is wrong.

we should clean this up before the first release to avoid having to deal with inconsistent legacy from the beginning.

[PHPCR-104] implement unitofwork isScheduledDocument

Tue, 19 Mar 2013 12:41:05 +0000

as discussed in https://github.com/doctrine/phpcr-odm/pull/268 we should implement UnitOfWork::isScheduledDocument and isScheduledFor* other than isScheduledForInsert.

[PHPCR-103] map node autoname feature

Thu, 14 Mar 2013 09:30:48 +0000

we should map the Node::addNodeAutonamed as an option for the nodename field to have nodes that generate their own name (i.e. useful in children collection)

[PHPCR-102] DocumentManager::reorder can not be called multiple times for the same parent

Fri, 19 Apr 2013 11:10:20 +0000

unless i really misread the code in UnitOfWork::scheduleReorder, trying to reorder more than one child of the same parent document will drop the previous reordering.

the whole method is of limited use, as you can also reorder the children in the ChildrenCollection.

[PHPCR-101] MissingTranslationException when parent is not translated

Thu, 18 Apr 2013 12:53:58 +0000

Getting a MissingTranslationException when displaying a banner on the frontend. It seems to be caused in the refreshDocumentForProxy method on line 496 of UOW, the parent document does not have a locale and therefore the fallback hint is false. The banner block is not translated and the banner images are (title property).

See for a stacktrace: https://gist.github.com/rmsint/2c6700e00c47c95dc30e

[PHPCR-100] The mixin `jcr:lastModified` is not updated

Fri, 19 Apr 2013 10:29:13 +0000

If the document have `jcr:lastModified`, this attribute is filled on create but not updated when a document is modified.

I tried to set manually this attribute and it is not updated too.

[PHPCR-99] Support configuring mixin node types

Thu, 18 Apr 2013 12:51:38 +0000

we should have a document level mapping to declare arbitrary mixins (like mix:created and mix:lastModified to have autogenerated timestamp fields that then can be mapped)

[PHPCR-98] replace child document

Sat, 2 Mar 2013 11:59:43 +0000

when replacing a mapped child with a new document, we get the cannotMoveByAssignment exception, which imo is a) the wrong message as its not about setting a tracked document to become a child somewhere else but what we should do is delete the existing child document and add the new one.

this happens at https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/UnitOfWork.php#L1912

for multiple children, i am less sure how it should work, if it is possible the same way:
https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/UnitOfWork.php#L935

[PHPCR-97] Allow QB / XB to sepcify objects as targets

Wed, 20 Feb 2013 18:21:46 +0000

Allow the query builder expression to specify an object as a target.

Unable to find source-code formatter for language: querybuilder. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

$qb->where($qb->expr()->eq('someObjectReference', $someObject);

So if the target passed is mapped and it is referenceable then replace the object instance with its UUID.

[PHPCR-96] Clean up event argument classes

Thu, 18 Apr 2013 14:49:25 +0000

clean up the event argument classes to only use specific classes if needed, and base on doctrine commons events

see https://github.com/doctrine/phpcr-odm/pull/246 and https://github.com/doctrine/phpcr-odm/issues/245

[PHPCR-95] Support parameter binding in QueryBuilder (depends Jackalope support)

Tue, 12 Mar 2013 14:18:20 +0000

Parameter binding is not currently implemented in the QueryBuilder, and the comments seem to indicate that this is because jackalope does not support it at the moment.

[PHPCR-94] Implement ->iterate on Query object

Tue, 19 Feb 2013 22:15:30 +0000

Implement the Query->iterate method which will return an IteratableResultSet as per the ORM.

[PHPCR-93] Implement ->clone() method on Query object

Tue, 19 Feb 2013 22:13:45 +0000

As with the ORM query object, implement the ->clone() method.

[PHPCR-92] Join support in QueryBuilder

Tue, 19 Feb 2013 22:14:26 +0000

Joins are currently not supported in the QueryBuilder, the methods are there and some of the logic is partially coded, but they just havn't been implemented.

At time of writing joins are not supported by doctrine-dbal (i think) but they are supported at least by Jackrabbit.

[PHPCR-91] getSIngleResult throws ambiguous Exception

Thu, 18 Apr 2013 13:12:06 +0000

Query->getSingleResult correctly throws an Exception when there are no results (or more than one), but it is an Exception that could also be produced by other things, so not guaranteed to mean that (
(http://docs.doctrine-project.org/projects/doctrine-phpcr-odm/en/latest/reference/query.html#getsingleresult)

[PHPCR-90] referrer delete and cascade delete

Tue, 12 Mar 2013 17:04:17 +0000

currently, removing an entry from the referrer collection has no effect, nothing is deleted.

without cascading, we should delete the value from the referencing property (needs the filter(mappedBy) attribute again), with cascading we should delete the referencing document.

[PHPCR-89] child documents are not translateable?

Thu, 18 Apr 2013 12:58:03 +0000

I just tried the odm on a testproject. but i have a really strange problem with translations. if i add a document which has children - and then try to add a translation to the children documents - the translation will not be saved .... (i tried the same with the symfony cmf - same result )
code:

[PHPCR-88] locales mapping for language fallback: do not repeat language

Thu, 18 Apr 2013 12:49:12 +0000

currently the language fallback is defined like this

locales:
en: [en, de]
de: [de, en]

the first option must be the requested language. this is counterintuitive and error prone. saying "en: [de]" would make english always only try german. we should add the locale itself as first locale i think, i see no use case of defining fallbacks where the requested locale is not the one to be preferred.

[PHPCR-87] the document manager did not return a result for findBy(array('id' => 'some/id')) but does for find('some/id')

Fri, 19 Apr 2013 10:26:14 +0000

the document manager did not return a result for findBy(array('id' => 'some/id')) but does for find('some/id')

[PHPCR-86] QueryBuilder QOMFactory access

Tue, 15 Jan 2013 10:22:42 +0000

There is getQOMFactory method in PHPCR\Util\QOM\QueryBuilder (very useful) but it isn't in Doctrine\ODM\PHPCR\Query\QueryBuilder (it breaks bc).

Is it mistake or there is/will be another method to access QOMFactory instance?

[PHPCR-85] implement querybuilder hydrate array option

Mon, 14 Jan 2013 09:12:13 +0000

the query builder can currently hydrate to documents and to phpcr nodes. it should also be possible to hydrate the result into a plain array to avoid creating documents and get the direct query result. (btw note that '*' in sql2 does not mean all properties of a document, but just the path and some other basic things - you always need to specify all fields you want to retrieve explicitly in this case)

for the query builder base work and discussion see https://github.com/doctrine/phpcr-odm/pull/204

[PHPCR-84] make the query API work with i18n

Tue, 14 May 2013 07:07:33 +0000

when searching there must be some way to ensure that for translateable documents the right fields are filters. f.e. when using the child strategy then for the given columns the node name needs to be checked (nodename = phpcr_locale:fr). for attributes strategy the property name needs to be rewritten ("title" vs "phpcr_locale:fr-title").

it might not be possible to easily automate this.

[PHPCR-83] make the test suite run and pass with Doctrine DBAL

Reference — Fri, 11 Jan 2013 15:13:59 +0000

this will likely require some work to disable certain tests relying on features not yet implemented

[PHPCR-82] add support to check if a multivalue property of type array actually changed or not

Thu, 18 Apr 2013 13:06:16 +0000

right now we only really support checking the dirty state of MultivaluePropertyCollection instances. however in some cases it might be necessary to convert things to an array, even if there are no actual changes. therefore it would be good to also check the dirty state in case of an array

[PHPCR-81] Referrers should not return the frozen node of a version in version storage

Wed, 26 Sep 2012 10:25:58 +0000

In the document of phpcr.github.com (http://phpcr.github.com/doc/html/phpcr/nodeinterface.html#getReferences%28%29), I quote:

"In implementations that support versioning, this method does not return properties that are part of the frozen state of a version in version storage."

But, the referrers returns some versioned node.

[PHPCR-80] ChildrenCollection is not updated after flush although children where added before

Tue, 12 Mar 2013 14:10:07 +0000

If you create children of a document without adding them to the children collection of the parent (with a children annotation) the children collection is not updated after flush, you need to call $dm->clear() to force a reread of the children. The current case was with a parent and its children created in the same flush.

[PHPCR-79] metadata type for non-property mappings

Mon, 14 Jan 2013 23:13:29 +0000

(this is a follow up of https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/issues/56)

ClassMetadata::mapField does not automatically assign a type except for the id field. we should add them here to have type information for things like nodename so for example sonata admin (or the symfony form builder?) can use that information to decide on the widget to use.

open question: is there a natural type mapping for children/parent? should we use MANY_TO_ONE for parent and ONE_TO_MANY for children? or is that a problem as its not arbitrary relations, should we add new types for this?

[PHPCR-78] Exception "Can't remove the protected property: jcr:created" on persist

Thu, 30 Aug 2012 09:12:46 +0000

When a Document contains a reference field (tested with @ReferenceMany(strategy="hard"), @ReferenceOne(strategy="hard")) and a "jcr:created" field in its metadata, then phpcr-odm try to update the protected field (jcr:created) to NULL on persist.

Jackalope throws the following exception :

[PHPCR\NodeType\ConstraintViolationException]
Can't remove the protected property: jcr:created

[PHPCR-77] document level options inheritance

Sun, 5 May 2013 07:54:47 +0000

documents extending other documents should inherit the global attributes unless overwritten explicitly.

for example, having @Document(referenceable=true) should be kept for an extending class unless it explicitly sets it to false. currently, attributes are reset on each new @Document tag. (i assume we have the same issue for xml/yml mapping?)

[PHPCR-76] add support for Selectable in PersistentCollection

Thu, 18 Apr 2013 13:06:48 +0000

add support for Selectable in PersistentCollection

[PHPCR-75] Mapped Superclass cleanup and documentation

Thu, 10 Jan 2013 12:02:42 +0000

this is a follow-up for https://github.com/doctrine/phpcr-odm/pull/144#issuecomment-7096029

we need to check if mapped superclass is working as it should, and then clarify the doc at https://github.com/doctrine/phpcr-odm-documentation/blob/master/en/reference/inheritance-mapping.rst

i still did not understand what exactly the feature means.

[PHPCR-74] [translations] allow detached document with locale propagation to mapped associations

Fri, 1 Feb 2013 10:20:08 +0000

managed documents can only ever exist once per DocumentManager, and thus only in one language. for this reason we did not want to make the language propagate for mapped children and references (as this would change the content of documents in a hard to understand way - and loading anything in a different language again would still lose the language)

thus we should provide a findTranslation variant to get a detached translated document that fetches all associations as detached as well, keeping the locale setting.

there is no way to handle the write case, but this would cover the read case.

[PHPCR-73] add support for custom ID generators

Tue, 12 Mar 2013 14:17:05 +0000

https://github.com/doctrine/doctrine2/pull/206

[PHPCR-72] persist cancels move

Sat, 21 Jul 2012 07:54:08 +0000

If i have a node that i fetch from the repo using $dm->find()

If i change an attribute in it.
Then i call $dm->move() on it

Then i call $dm->flush().

It will work.

However if i call $dm->persist() on the node (that i already fetched from $dm->find()) and then call $dm->flush()
The $dm->move() won't occur, it will be cancelled, but the attribute i changed will still be updated.

[PHPCR-71] refactor exceptions

Thu, 18 Apr 2013 13:09:42 +0000

https://github.com/doctrine/phpcr-odm/pull/144#discussion_r963877 reveiled that we should look into the exception concepts and streamline them.

[PHPCR-70] ContentDocument Relationships returning NULL in Action

Sat, 21 Jul 2012 14:26:04 +0000

So i have 2 Documents:

Page: http://pastebin.com/b5X32JPc

Category: http://pastebin.com/A1gB6kyg

A Category has many pages.

Now here's my (test) action: http://pastebin.com/ypjxqZPu

As you can see, $contentDocument is a page in this case. If i call $contentDocument->category i get back "null".

If however i tell the document manager to fetch the Page document by it's path, then $contentDocument->category will work...

Our conclusion is that if you take the $contentDocument that is passed to your action, and you try to fetch it's ParentDocument inside the action (mapped to a property) you always get null.
However, what is very weird, is that inside twig it works (page.category would work in twig but page->category would return null inside the action, before the twig render)

[PHPCR-69] persist referrers

Fri, 11 Jan 2013 08:53:40 +0000

phpcr knows reference and referrer (backlink). the reference is a property of a node with a defined name. the referrer is an information on the node without a property name in PHPCR. we have the annotation @Referrers to map this information onto a document field. the annotation can take an optional filter argument to only use references pointing to this node with a specific phpcr name.

we could add something like the cascade option found in the orm to allow assigning a document to a referrer property and automatically persist it. we will need to explicitly specify the reference property name to be used on the source document in this case (orm uses mappedBy for this)

github user mdekrijger started working on this. today, he wrote: Adding the annotations was quite easy, still figuring out the unitofwork where the actual processing must be implemented. Currently I can't spend much more time on it until end of june. If it isn't done yet by that time, I surely will pick it up from there.

[PHPCR-68] Versionable Item completely loses references

Sun, 22 Jul 2012 19:29:02 +0000

I have a post that has a reference to a subcategory

When i made my post versionable="full", the current and old versions of post lost this reference.

So when i call $post->subcategory i get back a Generic ODM document instead of a Subcategory Document

I know that relationships are not versionable, but relationships should at least still exist.

The workaround is to get the parent path and make a JCR-SQL2 query to fetch the subcategory document.

[PHPCR-67] Fetching a node beforehand ruins ordering of collections

Sun, 22 Jul 2012 19:24:30 +0000

Two documents: Category and Subcategory
Category has $subcategories as a PHPCRODM\Children

If Category A has 3 subcategories B1 B2 B3.

If A's subcategories are fetched we would receive them in the following order: B1 B2 B3.

Now if however we fetched the B2 node using the DocumentManager at an earlier line and then fetched the subcategories of A, we would receive them in the following order:
B2 B1 B3

[PHPCR-66] handle ParentDocument and Name changes as move operations

Tue, 5 Jun 2012 11:49:54 +0000

changes to the @ParentDocument and @Name should be translated to move operations. they are the most natural way to move a document in a form.

[PHPCR-65] find with uuid creates duplicate of document

Fri, 20 Jul 2012 07:51:56 +0000

i am pretty sure the DocumentManager::find() method creates a duplicate document each time you request the document by uuid. it should not just load the node but convert that node to a path and then do the check if the document is cached. if the node is already cached the lookup by uuid is cheap. if not, it is now cached and the lookup by path is cheap. so no overhead, but eliminate the risk of having several instances of the same document.

https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/DocumentManager.php#L279

[PHPCR-64] add support for child prefetching

Wed, 18 Jul 2012 22:07:48 +0000

https://github.com/jackalope/jackalope/pull/113

the idea would be to set the depth via a mapping on a per model or per collection basis

[PHPCR-63] event system: prePersist and postPersist

Tue, 22 May 2012 11:20:46 +0000

according to http://docs.doctrine-project.org/projects/doctrine-orm/en/2.1/reference/events.html#prepersist the persist event is only triggered when persisting a new entity/document. but currently the phpcr-odm uow triggers it during the flush operation.

we have to go over the event system and clean that up.

[PHPCR-62] avoid dereferencing proxies on save

Tue, 10 Apr 2012 08:47:37 +0000

chregu found in a large project that the odm seems to resolve all unresolved proxy documents during flush, even if the @ReferenceMany or @Referrer was not touched by the code.

we should make sure this does not happen.

[PHPCR-61] review how the ORM and other ODM's initialize collection properties

Thu, 18 Apr 2013 12:47:02 +0000

right now when we for example have a @ReferenceMany but nothing is assigned, then when we read said object from the database that property is set to null. should it rather be initialized as an empty collection?

[PHPCR-60] add finalize step to mapping to calculate and validate

Thu, 4 Oct 2012 21:33:40 +0000

follow up of the discussion in https://github.com/doctrine/phpcr-odm/pull/120

id strategy:

1. if there is an id with a strategy always use that
2. if not and there is a parent and a node name mapping use the parent strategy
3. else use assigned strategy if there is an id field
4. throw an exception that you can't use this document

finalizing the mapping could have the added benefit of combined validation. for example if assigned strategy is parent and name but there is no field mapped to the name, it would tell this is invalid.

think what should be validated at the finalize point.

[PHPCR-59] have a strategy for ReferenceOne/Many PATH to make it relative

Mon, 8 Oct 2012 07:34:03 +0000

this is a follow-up of
https://github.com/doctrine/phpcr-odm/pull/116

i think a user might need to attach his own strategy to the document manager. we could call this path_relative= and provide "max" that string-compares the target path and the node path and puts as few ../ as necessary. but again this does not block this pull request.

[PHPCR-58] figure out how to handle dangling weak/path ReferenceOne/Many properties

Wed, 7 Mar 2012 17:20:35 +0000

this is a follow-up of
https://github.com/doctrine/phpcr-odm/pull/116

the problem is: what happens when a ReferenceOne path or weak reference property points to something non-existing? is the property null? is the currently invalid reference removed on save or kept (which would make sense, in case the node at path appears later). but if it is usually kept, how can we delete it if we want?

[PHPCR-57] do not track the original/unmapped values separately

Sat, 3 Mar 2012 21:30:00 +0000

instead we should just use the current state of the underlying node.

[PHPCR-56] Support Hashmaps in fields

Reference — Mon, 22 Oct 2012 14:57:24 +0000

we should have an annotation to have multivalue properties be hashmaps, that is arrays with custom keys that get preserved. there are 3 options:

two multivalue fields with keys and values respectively. see i.e. https://github.com/symfony-cmf/symfony-cmf/pull/140 (another workaround can be to use the @PostLoad and @PreUpdate hooks to split/merge the arrays)
serialize the array into a string field
child nodes (performance penalty). they would need to be in a special namespace to be identifyable and have a special format. a node for key-value is a lot. if you want a document with a specific name, you should use child documents directly, not a hashmap with document entry.

[PHPCR-55] Add mapping for maps/associative arrays

Sun, 26 Feb 2012 16:37:36 +0000

Add a mapping for maps or arrays. Either implement as child node or serialize the array to a string. The first approach needs another node being fetched from the repository but allows to search the array.

[PHPCR-54] Implement LazyLoad for MANY_TO_ONE referenced docs

Wed, 22 Feb 2012 09:28:54 +0000

MANY_TO_MANY referenced are now only loaded on demand (see ~~PHPCR-52~~) via the ReferenceManyCollection. But MANY_TO_ONE are not yet, to be implemented

[PHPCR-53] repository::createDocument is never called

Wed, 22 Feb 2012 07:51:06 +0000

i tried using repositories. see

https://github.com/symfony-cmf/ChainRoutingBundle/commit/12515f82b02c4a1ef230b05133ec89e03c1af2e0
https://github.com/symfony-cmf/ChainRoutingBundle/commit/edd9f9544eadedb142fefd3ea9bb0c3b293c59d5

however, from looking at the uow code i have the impression that createDocument is never called on DocumentRepository but directly in UOW. shouldn't the uow fetch the repository and build the document with the repository? effectively moving UOW::createDocument impl. to the base repository?

[PHPCR-52] lazy loading of ReferenceMany fails

Wed, 22 Feb 2012 14:57:38 +0000

When I have a document with ReferenceMany "Links", Doctrine PHPCR always loads all those referenced documents, even if I just load the main document. This is obviously very bad for performance.

https://gist.github.com/1838831
is a reproducible use-case. Just ran it twice and you'll see that in the second run, there is

one GET request for the initial documents
a REPORT request for every referenced document to resolve the UUID to a path
a POST request for multi-get-ing all the referenced documents

See also this charles-screenshot
https://img.skitch.com/20120215-8572c4s5mc8gt2da5wjd71512w.jpg

I have no idea where to look at to fix this, so any help would be very appreciated

[PHPCR-51] make it possible to add attributes to type mappings

Thu, 16 Feb 2012 16:48:34 +0000

f.e. make it possible to make a string mapped typed translatable inside an inherited class
this will require modifications to the ClassMetadata class:
https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Mapping/ClassMetadata.php#L578

[PHPCR-50] fix handling of children on update

Thu, 12 Apr 2012 20:40:12 +0000

right now we do not check if individual elements in the collection have been added or removed. furthermore since we can now update the order of children in jackalope, we can implement this in collection persistence as well.

[PHPCR-49] rewrite DocumentRepository::createQuery() to use QOM

Fri, 10 Feb 2012 17:46:43 +0000

https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/DocumentRepository.php#L253

[PHPCR-48] add a way to move() nodes

Mon, 13 Feb 2012 13:45:04 +0000

add a way to move() nodes

[PHPCR-47] make it possible to disable exceptions for phpcr implementations without versioning support

Reference — Wed, 14 Nov 2012 10:49:45 +0000

so method calls to checkPoint() etc shouldn't fail. full versioning should just set referenceable etc.

[PHPCR-46] ensure that parent mappings are populated after flush

Fri, 20 Jul 2012 07:59:34 +0000

https://github.com/doctrine/phpcr-odm/pull/97#r410832

[PHPCR-45] add ability to prime collections

Thu, 18 Apr 2013 13:08:19 +0000

https://github.com/doctrine/mongodb-odm/commit/2da6e9c92d515edae7c63233740349e0d272b19b

[PHPCR-44] implement configurable change tracking

Mon, 8 Oct 2012 07:33:36 +0000

http://www.doctrine-project.org/docs/orm/2.2/en/reference/change-tracking-policies.html

[PHPCR-43] Custom data type

Reference — Thu, 19 Jul 2012 18:27:59 +0000

It will be great to be able to store array as a json in a property. There is no way to define custom mapping type (it is possible with doctrine ORM)

[PHPCR-42] sync the xml/yml mapping driver with the annotation driver

Fri, 17 Aug 2012 08:17:16 +0000

especially the locale/version stuff is not yet supported. but also the reference mapping seems to look quite different.

[PHPCR-41] MappingException: Class Doctrine\ODM\PHPCR\ReferrersCollection is not a valid document or mapped super class.

Sun, 8 Jan 2012 19:43:06 +0000

reported by nacmartin https://github.com/symfony-cmf/symfony-cmf/issues/131

Since this property was introduced

https://github.com/symfony-cmf/symfony-cmf/blob/master/src/Symfony/Cmf/Bundle/ContentBundle/Document/StaticContent.php#L44

I have this error when persisting this kind of document in SAB:

MappingException: Class Doctrine\ODM\PHPCR\ReferrersCollection is not a valid document or mapped super class.

Any clue?

=> phpcr-odm should not try to persist a ReferrersCollection. this is just the inverse of the Reference annotation. as this is directional in phpcr, the ReferrersCollection should be immutable by the client.

[PHPCR-40] implement inheritance inside find()

Mon, 18 Feb 2013 18:11:40 +0000

meaning if B extends A and someone does ->find('A') that it would find instances of B
this will require changes to ClassMetadataFactory::doLoadMetadata()
https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Mapping/ClassMetadataFactory.php#L119

[PHPCR-39] support ArrayCollection with References/Referrers

Fri, 3 Feb 2012 07:31:31 +0000

support ArrayCollection with References/Referrers

[PHPCR-38] make it possible to inject a custom UUID service

Thu, 19 Jul 2012 18:27:11 +0000

right now we have hardcoded \PHPCR\Util\UUIDHelper::generateUUID(), but that is a very simplistic implementation and the spec is much broader ..

[PHPCR-37] update for latest doctrine common features

Wed, 28 Dec 2011 23:28:15 +0000

see

https://github.com/doctrine/common/pull/71
https://github.com/doctrine/common/pull/75
https://github.com/doctrine/common/pull/83
https://github.com/doctrine/common/commit/07d2f04408534f0870d9873a420e294a4b0db439 (done)

as well as https://github.com/doctrine/couchdb-odm/commit/56f4ce911c9fd7cf32547a9d454141f250c9de54 (done)

[PHPCR-36] Provide migrations tool

Reference — Mon, 8 Oct 2012 07:31:08 +0000

when i have existing content and later change the document class to have referenceable=true, this is not updated even on persisting the document again.

uwe: I think there are several other things that fail when you have existing content in the repository - maybe the solution to think about is something like migrations ... that would prevent the performance penalty on ordinary code and still give you the change to change the structure of your documents.

things that come to mind

change document class name
removing fields
change field type
bulk changing the values in some field
everything related to node types (though, as an additional challenge at least jackrabbit does not allow to remove things from node types through the davex remoting we use in jackalope)

[PHPCR-35] referenced documents need to be referenceable

Wed, 28 Dec 2011 23:31:59 +0000

currently documents referenced need to have referenceable=true in their document annotation, otherwise the @ReferenceOne silently fails. (see also https://github.com/symfony-cmf/cmf-sandbox/pull/29 )

either phpcr-odm should complain. or it could just add the mix:referenceable to the target document even though it was not declared referenceable.
we could additionally make referenceable=true the default and offer explicit referenceable=false for optimization.

[PHPCR-34] replacing a document fails

Wed, 22 Feb 2012 15:03:39 +0000

when we have a saved document and remove that, then add a document at the same path without a flush in between, we get an exception. the reason is that persist already adds the phpcr node, but scheduleRemove does not remove the phpcrnode right away.

the fix looks like it should be:
UnitOfWork.php 504 remove phpcr node - 1022 do not remove here as it was removed before.

but this leads to a problem that is either in jackalope or the phpcr-odm about /functional/user/phpcr:class being not found.

1) Doctrine\Tests\ODM\PHPCR\Functional\BasicCrudTest::testRemoveAndInsert
PHPCR\ItemExistsException: This node already has a child named user.

/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/vendor/jackalope/src/Jackalope/Node.php:303
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/Doctrine/ODM/PHPCR/UnitOfWork.php:763
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/Doctrine/ODM/PHPCR/UnitOfWork.php:404
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/Doctrine/ODM/PHPCR/UnitOfWork.php:386
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/lib/Doctrine/ODM/PHPCR/DocumentManager.php:312
/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/vendor/doctrine-phpcr-odm/tests/Doctrine/Tests/ODM/PHPCR/Functional/BasicCrudTest.php:152

[PHPCR-33] ReferenceOne: targetDocument parameter should be optional

Sun, 13 Nov 2011 19:16:57 +0000

the targetDocument describes what class to expect in the reference. as the class is usually determined automatically, this parameter should be optional.

[PHPCR-32] separate the logic to determine the document class for a node

Sun, 13 Nov 2011 19:09:53 +0000

when loading a node from the database, you can either explicitly specify the document class to be used or it is determined programmatically. you can inject your own logic, but the default logic is right in UnitOfWork, and duplicated. this should be moved to a separate class for better reusability.

this would also be a good moment to get rid of phpcr:alias in favor of phpcr:class. we could provide an implementation for the old phpcr:alias as one of the resolvers users can plug in, if somebody really prefers the alias approach.

[PHPCR-31] add support for metadata caching

Wed, 28 Dec 2011 23:28:05 +0000

add support for metadata caching

[PHPCR-30] add support for result caching

Thu, 19 Jul 2012 18:26:54 +0000

add support for result caching

[PHPCR-29] Add support to flush only one document through DocumentManager#flush()

Fri, 3 Feb 2012 09:21:00 +0000

see https://github.com/doctrine/doctrine2/pull/166

[PHPCR-28] figure out proper handling of types in DocumentManager::quote()

Wed, 22 Feb 2012 14:58:03 +0000

figure out proper handling of types in DocumentManager::quote()

[PHPCR-27] adding a generic "node" document

Sat, 22 Oct 2011 13:05:04 +0000

see http://groups.google.com/group/symfony-cmf-devs/browse_thread/thread/914ba1c32d873ed5

[PHPCR-26] Github-PR-56 by uwej711: Fix metadata loading of builtin documents

Sat, 22 Oct 2011 13:04:43 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/phpcr-odm/pull/56

Message:

The wrapped metadata driver ensures that metadata for the builtin
documents is loaded. Still the DoctrineAnnotations need to be registered
with the AnnotationRegistry.

see https://github.com/symfony-cmf/cmf-sandbox/issues/20

[PHPCR-25] Github-PR-59 by starkj: Referrers

Fri, 16 Sep 2011 15:07:35 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/phpcr-odm/pull/59

Message:

first of all: sry, i screwed up the commit history here again

Well this is support for referrers.
This patch provides the new annotation "Referrers".
By default a property of this type stores all referrers (weak and hard) in a collection.
You can specify the option "referenceType" with the values "weak" and "hard" (or null) to only get the one or the other type of referring documents (or both types)
Then there is the option "filterName". It's value is passed to the method "get(Weak)References". Actually the option passed to "get(Weak)References" is called "name" in the spec. I named it "filterName" here as "name" is already assigned.

[PHPCR-22] find('\Foo\Bar', $path) vs find('Foo\Bar', $path)

Thu, 2 Feb 2012 19:27:41 +0000

I just noticed that we have an issue in our metadata loading in case a document name is prefixed with a backslash when calling find

// fails
$dm->find('\Foo\Bar', $path);

// works
$dm->find('Foo\Bar', $path);

Should the first work as well?

I have traced the issue to the DriverChain

public function loadMetadataForClass($className, ClassMetadata $class)
{
foreach ($this->drivers as $namespace => $driver) {
if (strpos($className, $namespace) === 0)

{ $driver->loadMetadataForClass($className, $class); return; }

}

throw MappingException::classIsNotAValidDocument($className);
}

notice the strpos() does not bother to check if a preceding backslash is in the $className var.

[PHPCR-21] converting any existing docs to reST so that it can be added to the site

Mon, 22 Oct 2012 15:02:10 +0000

PHPCR ODM is listed on the Doctrine website:
http://www.doctrine-project.org/projects/phpcr_odm

build doc in this repository:

https://github.com/doctrine/phpcr-odm-documentation

The next step would be to collect all the various documentation flying around and convert them to reST format:
https://github.com/doctrine/phpcr-odm/wiki/_pages
http://melp.nl/2011/07/symfony2-phpcr-doctrine2-jackalope-recipe/ (needs to be made Symfony2 unspecific)
http://www.craftitonline.com/2011/07/first-symfony2-cmf-based-cms-pagesbundle/ (needs to be made Symfony2 unspecific)
http://cmf.symfony.com/slides.html (needs to be made Symfony2 unspecific)

any other articles flying around?

of course we should also reference PHPCR related docs

[PHPCR-20] Quality assurance and testing

Wed, 28 Dec 2011 23:31:50 +0000

Look at test coverage and write more tests if necessary. Focus on the exposed api functional tests so the changes to share code with mongo db ~~PHPCR-19~~ can be tested.

[PHPCR-19] Code cleanup and refactoring, align to other odm implementations

Sat, 30 Jul 2011 13:03:05 +0000

Refactor the code to share more code with mongodb and other ODM implementations. Can we extract stuff into common base classes or adjust mongo so we can extend from it? The current code is often copy-paste with some small edits all over which makes it hard to update with new features and bugfixes from mongodb.

Also have a look at the OXM - we probably could profit from collaboration there too, as PHPCR is somewhere between document store and XML database. http://www.doctrine-project.org/blog/doctrine-oxm-intro

Implement ObjectManager interface and maybe add to the common interfaces like findMany suitable for us.

[PHPCR-18] Documentation

Wed, 3 Aug 2011 10:02:30 +0000

Create better user documentation. The README is far too long, split it.
Create some documents for the doctrine website and do a doctrine-project.org/projects/phpcr_odm

[PHPCR-17] Id generator and failsafe storage

Sat, 22 Oct 2011 13:04:25 +0000

Have an id generator that can build the path (id) from parent node and node name.
(The current setup with the id being the path leaves it to the user to make sure the parent node exists. You get really non-helpful strange error message if the parent does not exist.)

[PHPCR-16] Annotation for referrers

Fri, 2 Sep 2011 13:11:36 +0000

once reference annotation in ~~PHPCR-10~~ is finished, we should also map the inverse, the list of documents referencing this document. this is a read only property.

[PHPCR-15] Node property mappings

Sat, 22 Oct 2011 13:03:55 +0000

Annotation to map node name to a field (read-only except when creating a document). should be NodeName because NAME is one of the property types.
Align the annotations with the PHPCR\PropertyType types and map all types (missing for example the PATH type).

[PHPCR-14] refactor document class detection

Mon, 8 Aug 2011 11:34:29 +0000

make document class detection strategy injected. this is in Doctrine/ODM/PHPCR/UnitOfWork.php createDocument

the default strategy should do the current behaviour in that method, but use the explicit parameter first if specified before looking at the phpcr:class attribute.

[PHPCR-13] Implement DocumentManager::merge()

Wed, 9 Jan 2013 14:34:17 +0000

Implement DocumentManager::merge()

[PHPCR-12] Use PHPCR\FactoryInterface to bootstrap

Mon, 8 Aug 2011 11:23:37 +0000

The phpcr-odm should use the factory implementations to bootstrap the phpcr implementation, instead of using new Repository (and jackalope transport and whatnot)

[PHPCR-11] Expose transaction API

Sat, 15 Oct 2011 16:13:45 +0000

this requires support in PHPCR/Jackalope

[PHPCR-10] add support for (weak)references

Fri, 16 Sep 2011 15:08:34 +0000

creating and removing references

[PHPCR-9] add logging capabilities

Sat, 30 Jul 2011 15:50:06 +0000

[PHPCR-8] add support for getting node(s) with subnodes at once

Mon, 10 Oct 2011 09:49:59 +0000

this requires support for this in PHPCR/jackalope

[PHPCR-7] add support for "eventual migrations"

Reference — Mon, 8 Oct 2012 07:31:08 +0000

https://doctrine-mongodb-odm.readthedocs.org/en/latest/reference/migrating-schemas.html

[PHPCR-6] add mappings to reference parents in document properties

Sat, 22 Oct 2011 13:05:36 +0000

add mappings to reference parents in document properties

[PHPCR-5] test with Midgard2 PHPCR

Wed, 28 Dec 2011 23:29:48 +0000

https://github.com/bergie/phpcr-midgard2

[PHPCR-4] add mappings to reference versions in document properties

Fri, 3 Feb 2012 08:11:01 +0000

add mappings to reference versions in document properties

[PHPCR-3] add support for lazy loading documents

Fri, 2 Sep 2011 13:09:05 +0000

add support for lazy loading documents

[PHPCR-2] load document with child annotation

Fri, 24 Jun 2011 13:14:55 +0000

if i did not previously load a document of the class of the child, phpcr-odm can not know the alias to load it. it throws an exception.

for example, use $this->documentManager->find('My\Class', '/path/to/document'); where My\Class has an @child annotation for a child that is a File. it has the file alias, but phpcr-odm knows nothing of that alias if i did not previously try to find something with 'Doctrine\...\File' that made it load the meta data.

the workaround is to get the repositories to make phpcr-odm know the alias, but this is no solution.
$this->documentManager->getRepository('Doctrine\ODM\PHPCR\Document\Resource');
$this->documentManager->getRepository('Doctrine\ODM\PHPCR\Document\File');

we could add something to specify the document class in the child annotation, but this sounds stupid.

and getting a document without knowing its document class beforehand would be a nice feature in general. however, the info is currently scattered in annotations over the project. any idea how we could make phpcr-odm know all alias to document class mappings?

[PHPCR-1] children/child annotation add value later

Fri, 22 Jul 2011 07:40:32 +0000

when using the child annotation, it is not possible to assign a child document with a child of its own after persisting the parent document. to reproduce, take the Functional/FileTest.php and change
$parent->file = new File();
$parent->id = '/functional/filetest';
$parent->file->setFileContentFromFilesystem(dirname(_FILE_) .'/_files/foo.txt');

$this->dm->persist($parent);

to
$parent->id = '/functional/filetest';
$this->dm->persist($parent);

$parent->file = new File();
$parent->file->setFileContentFromFilesystem(dirname(_FILE_) .'/_files/foo.txt');

you will get "mandatory child node

{http://www.jcp.org/jcr/1.0}

content does not exist"