Doctrine Project

[MODM-70] Updates of documents after read

Duplicate — Wed, 24 Nov 2010 14:48:43 +0000

When I save a document and then read it again updated the document with the initial values.

The following log output when saving Doctrine:

Array
(
    [storing] => 1
    [file] => /app/tests/cases/models/asset/test.swf
    [document] => Array
        (
            [filename] => a3f06b4b882ee28ee8d8c7a5e6ab67e6.swf
            [php] => ass
        )

    [class] => Documents\Assets\Asset
    [db] => test
    [collection] => assets_files
)

Array
(
    [batchInsert] => 1
    [num] => 1
    [data] => Array
        (
            [00000000341a62a40000000001574585] => Array
                (
                    [cS] => 3
                    [rS] => 3
                    [co] => 0
                    [ca] => 0
                    [lvl] => 0
                    [nb] => 0
                    [sex] => 0
                    [na] => Building01
                    [typ] => building
                    [as] => Array
                        (
                            [$ref] => assets_files
                            [$id] => MongoId Object
                                (
                                )

                            [$db] => test
                        )

                )

        )

    [class] => Documents\Assets\MapAsset
    [db] => test
    [collection] => map_assets
)

Then read:

Array
(
    [findOne] => 1
    [query] => Array
        (
            [_id] => MongoId Object
                (
                )

        )

    [fields] => Array
        (
        )

    [class] => Documents\Assets\MapAsset
    [db] => test
    [collection] => map_assets
)

Then check for updates Document:

$this->dm->getUnitOfWork()->computeChangeSets();
$update = $this->dm->getUnitOfWork()->getDocumentPersister('Documents\Assets\MapAsset')->prepareUpdateData($mapAsset);
print_r($update);

Array
(
    [$set] => Array
        (
            [cS] => 3
            [rS] => 3
            [co] => 0
            [ca] => 0
            [lvl] => 0
            [nb] => 0
            [sex] => 0
            [na] => Building01
            [typ] => building
            [as] => Array
                (
                    [$ref] => assets_files
                    [$id] => MongoId Object
                        (
                        )

                    [$db] => test
                )

        )

)

Why is there an update even though it set the initial values? In Mongo are the values set correctly!

Then I run a flush:

Array
(
    [update] => 1
    [criteria] => Array
        (
            [_id] => MongoId Object
                (
                )

        )

    [newObj] => Array
        (
            [$set] => Array
                (
                    [uploadDate] => 0.63800000 1283421657
                    [length] => 4222
                    [chunkSize] => 262144
                    [md5] => 2af70cb102026bde0cf9f181780b642c
                )

        )

    [options] => Array
        (
        )

    [class] => Documents\Assets\Asset
    [db] => test
    [collection] => assets_files
)

Array
(
    [update] => 1
    [criteria] => Array
        (
            [_id] => MongoId Object
                (
                )

        )

    [newObj] => Array
        (
            [$set] => Array
                (
                    [cS] => 3
                    [rS] => 3
                    [co] => 0
                    [ca] => 0
                    [lvl] => 0
                    [nb] => 0
                    [sex] => 0
                    [na] => Building01
                    [typ] => building
                    [as] => Array
                        (
                            [$ref] => assets_files
                            [$id] => MongoId Object
                                (
                                )

                            [$db] => test
                        )

                )

        )

    [options] => Array
        (
        )

    [class] => Documents\Assets\MapAsset
    [db] => test
    [collection] => map_assets
)

1st Doctrine update GridFS file and destroyed it! Wrong value for uploadDate and the file can then be displayed in the browser no longer!

2nd Why did he updatet The Document with the same values that are already there in Mongo and the initial values are?

Here is my test code:

$asset = APP_TEST_CASES . DS . 'models' . DS . 'asset' . DS . 'test.swf';
$assetInfo = pathinfo($asset);
$assetName =  md5($assetInfo['basename'] . time() . mt_rand()) . '.' . $assetInfo['extension'];
$assetFile = new Documents\Assets\Asset($asset, $assetName);

$cSpan = 3;
$rSpan = 3;
$mapAsset = new Documents\Assets\MapAsset('Building01', 'building', $cSpan, $rSpan, null, $assetFile);
$this->assertEqual($mapAsset->getColumnSpan(), $cSpan);
$this->assertEqual($mapAsset->getRowSpan(), $rSpan);
$this->assertEqual($mapAsset->getSpans(), array('columnSpan' => $cSpan, 'rowSpan' => $rSpan));

$this->dm->persist($mapAsset);
$this->dm->flush();
$this->dm->refresh($mapAsset);

$this->dm->getUnitOfWork()->computeChangeSets();
$update = $this->dm->getUnitOfWork()->getDocumentPersister('Documents\Assets\MapAsset')->prepareUpdateData($mapAsset);
debug($update);
$this->dm->flush();

Here is my test Documents:

namespace Documents\Assets;

/**
 * @Document(collection="assets_files")
 */
class Asset {
	/**
	 * @Id
	 * @var string
	 */
	protected $_id;
	/**
	 * @File
	 */
	protected $_file;
	/**
	 * @String(name="filename")
	 */
	protected $_filename;
	/**
	 * @Field(name="uploadDate")
	 * @var int
	 */
	protected $_uploadDate;
	/**
	 * @Field(name="length")
	 * @var int
	 */
	protected $_length;
	/**
	 * @Field(name="chunkSize")
	 * @var int
	 */
	protected $_chunkSize;
	/**
	 * @Field(name="md5")
	 * @var string
	 */
	protected $_md5;
	/**
	 * @Field(name="contentType")
	 * @var string
	 */
	protected $_contentType;
	/**
	 * @Field(name="metadata")
	 * @var string
	 */
	protected $_metadata;

	public function __construct($file, $filename = null) {
		$this->_file = $file;
		$this->_filename = $filename;
	}
	
	// ..
}

namespace Documents\Assets;

/**
 * @Document(collection="map_assets")
 */
class MapAsset {
	/**
	 * @Id
	 * @var string
	 */
	protected $_id;

	/**
	 * @ReferenceOne(
	 *	targetDocument="Documents\Assets\Asset",
	 *	name="as",
	 *	cascade={"persist", "remove"}
	 *	)
	 * @var Documents\Assets\Asset
	 */
	protected $_asset;

	// ..
}

[MODM-67] EmbeddedDocument - no LifecycleCallbacks

Tue, 31 Aug 2010 12:15:17 +0000

LifecycleCallbacks in EmbeddedDocument are not called

/**
 * @EmbeddedDocument
 * @HasLifecycleCallbacks
 */
class SocialNetworkUser {

	/**
	 * @Int(name="id")
	 * @var int
	 */
	protected $id;
	/**
	 * @String(name="fN")
	 * @var string
	 */
	protected $firstName;
	/**
	 * @String(name="lN")
	 * @var string
	 */
	protected $lastName;
	/**
	 * @NotSaved
	 * @var string
	 */
	protected $name;

        // ....

	/**
	 * @PostLoad
	 */
        public function postLoad() {
		$this->name = $this->firstName . ' ' . $this->lastName;
	}
}

/**
 * @Document(collection="users")
 */
class User {
	/**
	 * @Id
	 */
	protected $id;
	/**
	 * @EmbedOne(
	 * 	discriminatorField="php",
	 * 	discriminatorMap={
	 * 		"fbu"="Documents\SocialNetworkUser "
	 * 	},
	 * 	name="snu",
	 * 	cascade={"persist", "remove"}
	 * )
	 */
	protected $socialNetworkUser;
}

$_user = $this->dm->findOne('Documents\User', array('snu.id' => $uid));
print_r($_user->getSocialNetworkUser()->getName())

$name is empty.
postLoad is never called after load

[MODM-90] UnitOfWork incorrectly flushes certain documents with embedded documents on first flush

Wed, 20 Oct 2010 12:52:06 +0000

With documents that have embedded documents, the changeset is sometimes calculated incorrectly so that unmodified documents are flushed unnecessarily. This is similar in spirit to #~~MODM-83~~, but this isn't covered by that fix.

This can be seen when the document has an embedded document that uses a discriminator map. When calculating the changeset, the original value will have the discriminator field and value present while the actual value does not contain the discriminator field.

Covering tests with fixes to follow shortly.

[MODM-83] UnitOfWork incorrectly updates all documents with embedded documents on flush

Tue, 19 Oct 2010 07:01:29 +0000

UnitOfWork incorrectly contains every managed document with embedded documents. All embedded documents are marked as updated. The whole mess will be updated on the next flush, regardless of whether said documents have actually changed.

Branch here: http://github.com/opensky/mongodb-odm/tree/MODM-83

Test case here: http://github.com/opensky/mongodb-odm/commit/af4373b58dd5da0bea5a0f8c4da30dde5ed1f266

Here's what the document changeset looks like in preUpdate and postUpdate:

preUpdate "Doctrine\ODM\MongoDB\Tests\Functional\Ticket\MODM83OtherDocument"

array(1) {
  ["name"]=>
  array(2) {
    [0]=>
    string(8) "Neighbor"
    [1]=>
    string(3) "Bob"
  }
}

postUpdate "Doctrine\ODM\MongoDB\Tests\Functional\Ticket\MODM83OtherDocument"

array(1) {
  ["name"]=>
  array(2) {
    [0]=>
    string(8) "Neighbor"
    [1]=>
    string(3) "Bob"
  }
}

preUpdate "Doctrine\ODM\MongoDB\Tests\Functional\Ticket\MODM83TestDocument"

array(1) {
  ["embedded"]=>
  array(2) {
    [0]=>
    array(1) {
      ["name"]=>
      string(5) "Child"
    }
    [1]=>
    array(2) {
      ["name"]=>
      string(5) "Child"
      ["originalObject"]=>
      object(Doctrine\ODM\MongoDB\Tests\Functional\Ticket\MODM83TestEmbeddedDocument)#86 (1) {
        ["name"]=>
        string(5) "Child"
      }
    }
  }
}

postUpdate "Doctrine\ODM\MongoDB\Tests\Functional\Ticket\MODM83TestDocument"

array(1) {
  ["embedded"]=>
  array(2) {
    [0]=>
    array(1) {
      ["name"]=>
      string(5) "Child"
    }
    [1]=>
    array(2) {
      ["name"]=>
      string(5) "Child"
      ["originalObject"]=>
      object(Doctrine\ODM\MongoDB\Tests\Functional\Ticket\MODM83TestEmbeddedDocument)#86 (1) {
        ["name"]=>
        string(5) "Child"
      }
    }
  }
}

[MODM-73] Neo4j (Graph oriented Database)

Wed, 24 Nov 2010 14:36:41 +0000

MongoDB Object Document Mapper is a particularly nice added value and represent a great interest for integrating into php framework.
MongoDB is one of the most representative actor in the document oriented databse and my suggestion here would be to implement
the same for the most representative graph oriented database which is Neo4J.

Someone tried an overall PHP approach and his choice seems an interesting compromise => http://wiki.neo4j.org/content/PHP.
A more elaborated approach around a doctrine work would be ore than helpful.

[MODM-120] [Configuration] problem with changing the defaultDB

Wed, 16 Feb 2011 16:58:15 +0000

What i want to do is to change the database name of the document manager:

$config = new Configuration();
$dm = new DocumentManager($conn, 'my_db', $config);

$config->setDefaultDB('another_db');
$dm->getDatabase(); // 'my_db' insteadof 'another_db'

Is there another solution to do this ?

[MODM-109] Reference with Inheritance: Proxy error: 'document with identifier .. could not be found'

Fri, 11 Feb 2011 15:26:37 +0000

It's hard to explain this issue,

I have a single table Inheritance, the base class is Block. ContainerBlock is a child class of Block.
I have a document Page who have a one-one with ContainerBlock (child of Block). ContainerBlock as many Block.

Test script:
----------------

I have created a complete test-case (see attachment).
phpunit InheritanceReference/InheritanceReferenceTest.php

Expected result:
-----------------------

no error, no exception.

Actual result:
-------------------

1) InheritanceReference\InheritanceReferenceTest::testMulipleInheritance
Doctrine\ODM\MongoDB\MongoDBException: The "Proxy\DocumentBlockProxy" document with identifier "4d3d08116aba269508000001" could not be found.

src/vendor/symfony/vendor/doctrine-mongodb-odm/lib/Doctrine/ODM/MongoDB/MongoDBException.php:69
src/Bundle/InheritanceReference/Proxy/DocumentBlockProxy.php:25
src/Bundle/InheritanceReference/Proxy/DocumentBlockProxy.php:34
src/Bundle/InheritanceReference/InheritanceReferenceTest.php:65

[MODM-103] @File tag support in xml notation

Mon, 20 Dec 2010 16:08:30 +0000

Please correct me if I'm wrong but it looks like that @File tag (Mongo GridFS indicator) is not supported by xmlDriver.
I could not find anything about this feature neither in unitests for the system nor in documentation (as concerning the code probably I missed something but I also could not find anything related to GrisFS in xmlDriver code) .

[MODM-98] Partial UnitOfWork clear on runtime defaultDb change

Mon, 20 Dec 2010 16:50:15 +0000

Actually I am not sure if this is a bug or just ODM limitation, but there is a use-case for MongoDb which doesn't fit well with current ODM implementation.

Imagine SaaS service, where each client has his own DB. Documents and collections are all the same, except most of them are stored in different DBs, depending on context.

It works pretty well with ODM defaultDB configration setting, until you need to process data from different dbs (e.g. iterate db by db in CLI script). When you try to change default db, repositories and persisters stay there and all keep a reference to initial DB. And they don't get reset on UnitOfWork->clear(). It would be great to have runtime defaultDb switching out of the box, but if that is a problem, maybe you can advice on how this could be handled?

[MODM-96] YamlDriver Symfony Components Namespace Issue

Mon, 20 Dec 2010 16:51:29 +0000

In the YamlDriver.php the namespace is incorrect I pressume. It should be \Symfony\Components\Yaml\Yaml. Its missing a 's' in Component

Current in Master :
protected function loadMappingFile($file)
{
return \Symfony\Component\Yaml\Yaml::load($file);
}

Desired Outcome
protected function loadMappingFile($file)
{
return \Symfony\Components\Yaml\Yaml::load($file);
}

[MODM-95] Persisting a document that had embedded documents prior to being removed results in a document with no embedded documents

Wed, 24 Nov 2010 13:02:52 +0000

1) Persist a document with embedded documents
2) Load document into memory (store in variable)
3) Remove document using ODM
4) Persist loaded document back to DB using ODM
5) Embedded documents are now gone

I have created a new failing test in the ODM and requested a pull

[MODM-31] Cannot use a document against multiple classes

Fri, 30 Jul 2010 13:27:17 +0000

It would be useful to be able to use two classes on one document, in a way that transparently extends the original schema. My use case:

I have a base Application that manages users of the system. A module/plugin to the system wants to extend the User records to include references to one of it's documents:

namespace Application\Model;
class User {
//user properties here
}

...

namespace Organisation\Model;
use Application\Model\User as BaseUser;

class Organisation {
//organisations properties
}

class User extends BaseUser {
/** @ReferenceOne(targetDocument="\Organisation\Model\Organisation") */
protected $organisation
}

It this theoretical scenario, the original \Application\Model\User needs to be used by the base application, but the \Organisation\Model\User can be used by the addon module to transparently add more data to the same user. The base class doesn't need to know it will be used this way.

Current behaviour for the above will ignore the additional properties not available in the parent class, and doesn't throw any exceptions/errors.

Other ways to make it work involve the base class knowing it will be extended via SCI, or using a mappedsuperclass?, which isn't transparent in the base class, it needs to be altered to work with it's children.

[MODM-20] SINGLE_COLLECTION inheritance does not work

Wed, 24 Nov 2010 13:10:19 +0000

It seems that SINGLE_COLLECTION inheritance is not implemented?

Method UnitOfWork::getOrCreateDocument calls Mapping\Metadata::newInstance without taking possible discriminator map into account.

The example in the official documentation (http://www.doctrine-project.org/projects/mongodb_odm/1.0/docs/reference/inheritance-mapping/en) is not a real test: the object is first created as a child-class instance before being queried through the parent class, so the object is returned without hydration, from the UnitOfWork identityMap cache.

The corresponding code from Doctrine\ORM is in Doctrine\ORM\Internal\Hydration\ObjectHydrator::_getEntity (find class name through discriminator map, if any).

[MODM-18] All Document object properties are persisted regardless of mapping instructions.

Tue, 13 Jul 2010 10:42:43 +0000

User Model

class Users_Model_User
{
    public $id;
    public $username;
    public $password;
    public $myRuntimeProperty = 'some value';
}

Document Mapping (in YAML)

Users_Model_User:
db: my_db
collection: users
fields:
    id:
        fieldName: id
        id: true
    username:
        fieldName: username
        type: string
    password:
        fieldName: password
        type: string

My test code

$user = new Users_Model_User;
$user->username = 'hello';
$user->password = 'world';
$this->dm->persist($user);
$this->dm->flush();

The result is "myRuntimeProperty" is saved to the db.
This causes problems for several properties such as "_propertyChangedListeners" which, once saved and later loaded back from the database, overrides the array of object listeners with a string of "Array"

If this is not a bug:
I have search everywhere for an answer. All the docs, mailing list, irc, blogs. If this is not a bug the solution needs to be better documented.

Temporary fix:
Use Docblock Annotations, set the unwanted properties with @NotSaved
(Unless there is also a way to set NotSaved using YAML?)

[MODM-111] Trouble with MappedSuperclass/Single collection inheritance and commit 2e8071a4dc68b027f969

Fri, 11 Feb 2011 14:55:30 +0000

I have the following classes :

@MappedSuperClass
@InheritanceType("SINGLE_COLLECTION")
@DiscriminatorField(fieldName="_class")
@DiscriminatorMap(

{"SuperClass"="SuperClass", "SubClass1"="SubClass1", "SubClass2"="SubClass2"}

)
abstract class SuperClass {}

@Document
class SubClass1 extends SuperClass {}

@MappedSuperClass
abstract class SuperClass2 extends SuperClass {}

@Document
abstract class SubClass2 extends SuperClass2 {}

SubClass2 does not use the single collection.
SubClass1 and SubClass2 do not use the discriminator map.

This broke after commit 2e8071a4dc68b027f969.

Why can't we use MappedSuperclasses in an single collection inheritance strategy ?