Doctrine Project

[MODM-93] YAML and XML mapping drivers ignore discriminatorField and discriminatorMap

Wed, 24 Nov 2010 13:13:32 +0000

The discriminatorField and discriminatorMap options are ignored by both the YAML and XML drivers.

Example:
This mapping fails to store the discriminator in the type field and instead uses _doctrine_class_name as the discriminatorField the mapping also reverts to using class names.

 
<?xml version="1.0" encoding="UTF-8"?>
<doctrine-mongo-mapping>
    <document name="Application\Test\Document\Group" collection="groups">
        <field name="id" fieldName="id" id="true" />
        <field name="name" fieldName="name" type="string" />
        <embed-many field="people" discriminator-field="type">
            <discriminator-map>
                <discriminator-mapping class="Admin" value="Admin" />
                <discriminator-mapping class="User" value="User" />
            </discriminator-map>
        </embed-many>
    </document>
</doctrine-mongo-mapping>

I think that this is also a problem for referenced documents as well, as the code for the two is nearly identical.

I refactored addEmbedMapping and addReferenceMapping to call the same function addDocumentMapping
Commit can be found here http://github.com/dordille/mongodb-odm/commit/41ce2ee126ff7f82610130704dbec451384bfdd3

[MODM-28] xml mapping : embedded-document node is ignored, can't persist

Tue, 27 Jul 2010 10:55:23 +0000

 
//file Doctrine/ODM/MongoDB/Mapping/Driver/XmlDriver.php line 171

protected function _loadMappingFile($file)
    {
        $result = array();
        $xmlElement = simplexml_load_file($file);

        if (isset($xmlElement->document)) {
            foreach ($xmlElement->document as $documentElement) {
                $documentName = (string) $documentElement['name'];
                $result[$documentName] = $documentElement;
            }
        }
        
        return $result;
    }

embedded-document and mapped-superclass are ignored so embed documents are not persisted

[MODM-26] MongoCursor doesn't implement Countable interface

Mon, 19 Jul 2010 13:09:48 +0000

this causes confusion when query returns empty array instead of MongoCursor object, meaning you can't use neither count($result) nor $result->count(), and have to check for the returned type explicitly

[MODM-25] AnnotationDriver.php Line 175

Mon, 19 Jul 2010 14:28:20 +0000

$mapping['fieldName'] should be replace with something else.
Maybe create a whole new metadata property, or map load methods as onLoad lyfecycle events...

[MODM-24] Hydratation of extra fields

Mon, 19 Jul 2010 23:15:39 +0000

I'm working on a project using MongoDB with ODM especially for the schemaless features.
So I have one collection with some default fields in my base class.
Every inherited class add fields but we're still in the same collection.

First, prior to save the document, I add the new mappings (imported from the inherited class) so they will be saved in the database. This part works fine.
The problem is that when the ODM hydrates the documents, it sticks to the $metadata->fieldMappings defined by the base class, and ignore the others.

I've made a quick patch for that, but it doesn't make any type cast, I didn't inspect the code deep enough to make it better.

In the Doctrine\ODM\MongoDB\Hydrator class (line 73) :

    public function hydrate(ClassMetadata $metadata, $document, $data)
    {
        $values = array();

        // Patch
        foreach ($data as $field => $value)
        {
          if(!array_key_exists($field, $metadata->fieldMappings))
          {
            $document->$field = $value;
          }
        }
        // end Patch

        foreach ($metadata->fieldMappings as $mapping) {
[...]

[MODM-22] Document incorrectly scheduled for update

Mon, 19 Jul 2010 23:52:55 +0000

I have the following documents:

Product:
product_id
sellable (dbref)

Sellable:
product (dbref)
seller (dbref)

Seller:
name

If I create a new Sellable for a seller the seller gets scheduled for update even if nothing has changed.The document persister correctly doesn't try to actually execute the update but Lifecycle events still get called. The flow is:

1. Schedule for update
2. Call _executeUpdate
3. Call preUpdate
4. Call BasicDocumentPersister::update(), which does nothing because of no actual changes
5. Call postUpdate.

preUpdate and postUpdate being called when there's no actual changes is causing problems. It seems like the proper course of action would be to either not schedule the document for update or check if there's any actual changes before calling preUpdate and postUpdate.

[MODM-21] AnnotationDriver doesn't allow custom types

Mon, 19 Jul 2010 15:01:15 +0000

Right now AnnotationDriver.php does not allow you to create custom types. You can with YAML and XML but the $types array on line ~142 of AnnotationDriver.php is hard coded so there's no way to get a custom type in there.

[MODM-19] Field annotation missing "name" support

Mon, 19 Jul 2010 15:51:10 +0000

Documentation states that field names can be overriden by using a "name" parameter but Doctrine throws exception.
Also there is a missing comma in the documentation between the type and name params.

From documentation:

http://www.doctrine-project.org/projects/mongodb_odm/1.0/docs/reference/annotations-reference/en#ann_field

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

/**
 * @Field(type="string" name="origin")
 */
protected $country;

My source code:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

    /**
     * @Field(type="string", name="password")
    **/
    protected $_password;

Exception:

BadMethodCallException:
Unknown property 'name' on annotation 'Doctrine\ODM\MongoDB\Mapping\Field'.

[MODM-17] Multiple array / object with same content/properties do not get persisted

Mon, 19 Jul 2010 17:13:16 +0000

If I have a Collection field and try to add 2 values that are the same, the second value never gets saved to the document. Example code:

class User
{
  /** @Id */
  private $id;

  /** @String */
  private $name;

  /** @Collection */
  private $logs = array();

}

    $o = $dm->findOne(':User', array('name' => $arguments['name']));

    $found = true;

    if (!$o) {
      $found = false;
      $o = new User();
    }

    $o->setName($arguments['name']);

    $o->addLog( array('a' => 'b' ));

    $dm->persist($o);

    $dm->flush();

or a EmbeddedMany field, and try to add to add 2 objects with the same content the same thing happens:

class User
{
  /** @Id */
  private $id;

  /** @String */
  private $name;

  /** @EmbedMany(targetDocument="UserLog") */
  private $logs = array();
}

    $o = $dm->findOne(':User', array('name' => $arguments['name']));

    $found = true;

    if (!$o) {
      $found = false;
      $o = new User();
    }

    $o->setName($arguments['name']);

    $l = new UserLog();

    $l->setMsg('Testing');

    $o->addLog($l);

    $dm->persist($o);

    $dm->flush();

If I change $l->setMsg('Testing'.time());

then it adds all the instances.

[MODM-16] loadById failing on custom ids

Thu, 17 Jun 2010 09:11:33 +0000

DocumentManager::loadByID is failing on custom ids right now because it's checking for the custom id flag on the metadata and converting to \MongoID. It should probably be using the new $class->getPHPIdentifierValue method instead.

[MODM-14] Default database when @Document annotation does not contain a db attribute.

Fri, 11 Jun 2010 15:06:46 +0000

When a Document is annotated with @Document(collection="test") and is missing the db attribute the ODM defaults to mongo_dev. What i expected was it defaulted to the database name given when creating a connection.

[MODM-13] Problems with merge()

Thu, 10 Jun 2010 09:00:24 +0000

while doing a merge, I got some PHP errors.
Seems like these steps fix the problem:
1. Change line 1215 of UnitOfWork.php to
$id = $class->getIdentifierValue($document);
it was ValueS before

2. in function _cascadeMerge starting in line 1464 of UnitOfWork.php
change the inner calls from:
$this->_cascadeMerge($relatedDocument, $visited);
To:
$this->_cascadeMerge($relatedDocument, $managedCopy, $visited);

I didn't look deeper into ODM, just tried this to things and it seems to work now, so please excuse if it's bs ...

[MODM-12] Undefined variable error

Wed, 9 Jun 2010 19:55:06 +0000

In UnitOfWork::_computeAssociationChanges there are several references to $document but $document is never declared in that method, or passed into it. From looking at ORM it looks like $entry is the right variable to be using here.