Doctrine Project

[DMIG-25] migrating muliple databases

Sat, 17 Mar 2012 10:46:44 +0000

I have 2 databases db1 and db2 in symfony2 + doctrine2 and both databases are different from each other in terms of tables and their fields.
I need to work on migration. Things work fine as long as there is one database.
But it does not works when there are more than one databases as it tries to migrate from all files [some of which are for db1, and some of them are for db2]
Also, is there any way where I can provide entity manager specific migration settings. Or is there any way through which I can provide connection or entity manager in the migration class.

[DMIG-31] $table->renameColumn() actually drops the column

Tue, 19 Jun 2012 13:23:07 +0000

Tried to use renameColumn() into one of my migration scripts and it dropped the table.

The code does not seem okay as well:

namespace Doctrine\DBAL\Schema;
..
class Table extends AbstractAsset
{
..
  /**
    * Rename Column
    *
    * @param string $oldColumnName
    * @param string $newColumnName
    * @return Table
    */
public function renameColumn($oldColumnName, $newColumnName)
{
    $column = $this->getColumn($oldColumnName);
    $this->dropColumn($oldColumnName);

    $column->_setName($newColumnName);
    return $this;
}
..

[DMIG-15] Drop not null is not working in Postgres

Tue, 16 Nov 2010 07:58:13 +0000

When removing the not null from a column the migration does not change anything in the database. This is due to the following check on line 162 of lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Export/Pgsql.php

if ( ! empty($field['definition']['notnull']))

So if notnull is not there or set to false or '0' or 0 the code does not enter into that if statement and therefore no changes are done to the not null value of the column.

[DMIG-12] createIndexSql and dropIndexSql don't use the same logic to get the index name

Tue, 16 Nov 2010 07:57:59 +0000

In the class Doctrine_Export the functions for creating and dropping indexes do not use the same logic to get the name of the index to be created or dropped.

When creating an index $this->conn->quoteIdentifier() is called on the index name.
When dropping an index $this->conn->quoteIdentifier($this->conn->formatter->getIndexName()) is called on the name, which by default adds '_idx' to the index name. Hence, when an index should be dropped in a migration an index with that name is not found because it was created without the '_idx'.

We use the migrations with a Postgres 8.4 database.

[DMIG-10] Syntax error in migration script

Wed, 8 Dec 2010 02:37:33 +0000

The migration script created a php line like this:

$this->_addSql('ALTER TABLE ... DEFAULT '0'');

Which creates a syntax error in the php file.

[DMIG-9] table "contact_attribute" already exists - with mappedSuperClass

Fri, 26 Nov 2010 04:57:05 +0000

I have a class App_Model_Contact_Attribute:

App_Model_Contact_Attribute:
  type: mappedSuperclass
  inheritanceType: SINGLE_TABLE
  table: contact_attribute
  discriminatorColumn:
    name: type
    type: string
    length: 20
    columnDefinition: "varchar(20) not null"
  discriminatorMap:
      emailAddress: App_Model_Contact_EmailAddress
      twitterAccount: App_Model_Contact_TwitterAccount
  id:
    id:
      type: integer
      columnDefinition: "int unsigned not null auto_increment"
      generator:
        strategy: AUTO
  fields:
    value:
      type: string
      notnull: true
      columnDefinition: "varchar(45)"
  manyToOne:
    contact:
      joinColumn:
        name: contactID
        referencedColumnName: id
        columnDefinition: "int not null unsigned"
      targetEntity: App_Model_Contact
      fetch: EAGER
      cascade: [persist]

and a class App_Model_Contact_EmailAddress and App_Model_Contact_TwitterAccount. Both yml files look similar to this:

App_Model_Contact_TwitterAccount:
  type: entity

Now, when I want to execute migrations:diff it always fails giving me the message: "Table contact_attribute already exists".

This probably has to do with the mappedSuperClass declaration in my models.

[DMIG-23] Doctrine migrations MySQL only?

Thu, 17 Nov 2011 09:55:48 +0000

Today I have started with implemention migrations in my project.
But I found that only MySQL supported.

/**
 * Returns the current migrated version from the versions table.
 *
 * @return bool $currentVersion
 */
  public function getCurrentVersion()
  {
      $this->createMigrationTable();

      $result = $this->connection->fetchColumn("SELECT version FROM " . $this->migrationsTableName . " ORDER BY version DESC LIMIT 1");
      return $result !== false ? (string) $result : '0';
  }

In my project I use MSSQL db.
Do you plan to use platform independent solution?

[DMIG-22] $table->renameColumn doesn't work

Sat, 30 Jun 2012 07:01:30 +0000

In my case $table->renameColumn('old', 'new') resulted only in a "drop column 'old'".

[DMIG-34] Column names not escaped with backticks

Wed, 15 Feb 2012 14:32:20 +0000

Generated from an Entity with a variable named access_key, with a column name of "key".

Generated MySQL table constructor fails, name is not escaped with backticks.

[DMIG-20] migrations try to create an index with name "primary" for ManyToMany associations

Sun, 26 Jun 2011 11:57:28 +0000

For ManyToMany associations, migrations try to create a unique index on (joinColumn, inverseJoinColumn) having name "primary":

CREATE UNIQUE INDEX primary ON join_table (joinColumn, inverseJoinColumn);

Which results in a syntax error on MySQL (primary is also an invalid key name).

[DMIG-7] migrations:diff could not be found

Tue, 15 Feb 2011 15:40:14 +0000

./doctrine list migrations didn't list diff although the diff command is added in doctrine.php.

This could be the problem of configure() in DiffCommand.php. The parent::configure() is called after the the configuration of diff command. So the name etc of the diff command is overwritten by the father class, namely "generate".

[DMIG-5] migrations:generate incorrect version

Tue, 15 Feb 2011 15:37:39 +0000

in Doctrine/DBAL/Migrations/Tools/Console/Command/GenerateCommand.php

$version = date('YmdHms');

must be

$version = date('YmdHis');

[DMIG-4] Case sensitive include

Fri, 18 Jun 2010 12:00:28 +0000

in:
http://github.com/doctrine/migrations/blob/master/lib/Doctrine/DBAL/Migrations/Configuration/Configuration.php

use Doctrine\Dbal\Connection,
Doctrine\DBAL\Migrations\MigrationException,
Doctrine\DBAL\Migrations\Version,
Doctrine\DBAL\Migrations\OutputWriter,
Doctrine\Dbal\Schema\Table,
Doctrine\Dbal\Schema\Column,
Doctrine\DBAL\Types\Type;

This can't be upper/lowercase. DBAL must be in uppercase every time.

[DMIG-3] AbstractCommand depends on ORM Package

Wed, 16 Jun 2010 08:01:41 +0000

The Abstractcommand uses the Entity Manager instead of accessing the DBAL Connection directly through the helperset. This makes it impossible to use migrations without the ORM.

The ORM however is only of any interest in the DiffCommand, the other commands don't need access to any EM related functionality.

[DMIG-2] Creating columns of typ SET fails to set default value

Tue, 8 Jun 2010 13:32:04 +0000

When writing a migration class for a table I wanted to add a new column of the SET type. I've set the notnull option and a default value, but Doctrine fails to generate the correct SQL.

Migration function:
public function up()

{ $options = array( 'type' => 'set', 'notnull' => 1, 'size' => 10, 'values' => array( 'value_a', 'value_b', 'value_c', ), 'default' => 'value_a ); $this->addColumn('my_table', 'new_field', 'set', Null, $options); }

MySQL error (contains the generated SQL):
Error #1 - SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'NOT NULL' at line 1. Failing Query: "ALTER TABLE my_table ADD new_field SET('value_a', 'value_b', 'value_c') DEFAULT NOT NULL"

After a bit of debugging I've found the problem, Doctrine_Formatter::quote() doesn't know how to handle set. Simply adding 'set' to the switch right below 'enum' will make it work as it should.

— lib/Doctrine/Formatter.php
+++ lib/Doctrine/Formatter.php
@@ -186,6 +186,7 @@ class Doctrine_Formatter extends Doctrine_Connection_Module
case 'blob':
case 'clob':
case 'enum':
+ case 'set':
case 'boolean':
return "'" . str_replace("'","''",$input) . "'";
}

[DMIG-39] Issue when using serjal columns in PostgreSQL with Doctrine ORM Identity fields

Wed, 24 Apr 2013 11:30:57 +0000

When using Doctrine ORM mapping fields like this:

    /**
     * @var integer
     *
     * @ORM\Column(name="id", type="integer", nullable=false)
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="IDENTITY")
     * @ORM\SequenceGenerator(sequenceName="schemaname.tablename_id_seq", allocationSize=1, initialValue=1)
     */
    private $id;

It first creates the migration perfectly as a serial column with the correct schema.

However when making a new migration diff it generates DROP statements for every sequence for these id, so we have to remove them manually every time.

[DMIG-40] DBAL Enum fields migration issue / PostgreSQL

Wed, 24 Apr 2013 11:36:09 +0000

When using Custom Doctrine DBAL Enums the migration created using diff

works fine the first time.

However the next time it generates a SQL statement trying to change to field type to INT from integer; (Redundant)
and a truncated statement:

"ALTER schemaname.fieldname SET" .. And that's it.

[DMIG-11] Comparer always detects changes when using columnDefinition in mapping definitions

Tue, 15 Feb 2011 15:34:53 +0000

The migration diff command always thinks that my model definitions have changed, when I use the manual columnDefinition on a timestamp column:

    dateUpdated:
      type: datetime
      columnDefinition: TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL

This always results in a migration script like this:

<?php

namespace SuplifyApiMigrations;

use Doctrine\DBAL\Migrations\AbstractMigration,
    Doctrine\DBAL\Schema\Schema;

class Version20101028121948 extends AbstractMigration
{
    public function up(Schema $schema)
    {
        $this->_addSql('ALTER TABLE ticket CHANGE dateUpdated dateUpdated TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL');
    }

    public function down(Schema $schema)
    {
        $this->_addSql('ALTER TABLE ticket CHANGE dateUpdated dateUpdated DATETIME DEFAULT CURRENT_TIMESTAMP NOT NULL');
    }
}

As you can see, the columns look exactly the same. Doctrine just does not seem to parse the manual columnDefinition and compare its result.

[DMIG-16] incorrect class name

Tue, 15 Feb 2011 15:42:42 +0000

http://www.doctrine-project.org/projects/migrations/2.0/docs/reference/introduction/en#introduction

$helperSet = new \Symfony\Components\Console\Helper\HelperSet(array(
'db' => new \Doctrine\DBAL\Tools\Console\Helper\ConnectionHelper($db),
'dialog' => new \Symfony\Components\Console\Helper\DialogHelper(),
));

bug in "\Symfony\Component_s_\Console\Helper\DialogHelper" => "\Symfony\Component\Console\Helper\DialogHelper()"