Doctrine Project

[DDC-1986] findBy hydration with limit and offset with Oracle database (oci8 driver)

Tue, 8 Jan 2013 09:33:00 +0000

I tried to use the findBy method with limit and offset parameters against an Oracle database using oci8 driver.

The query seems to executed successfully but the hydrator fails when hydrating data as there is a DOCTRINE_ROWNUM column appending the "limit" clause.

Here is the exception thrown : "Notice: Undefined index: DOCTRINE_ROWNUM in [...]/vendor/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/SimpleObjectHydrator.php line 183"

I was thinking about something like this to fix this issue :

add an attribute (platformExtraColumns) to the platform class, storing every column added by methods like doModifyLimitQuery
check in hydrator method hydrateRowData if the column exists among the extra columns attribute of the custom platform
don't use the column if true

Maybe there is a better approach, what are your thoughts?

[DDC-1879] Orphans are neither nulled nor removed when merging a graph of detached entities

Wed, 23 Jan 2013 22:24:05 +0000

When merging a graph of detached entities, the created entitied are created and the updated entities are updated but the non-present entities (which exist in the database but are not in the graph) are neither removed nor have them their association column nullified.

Example :

In my code I have 2 entities : Parent and Child. There is a OneToMany(cascade=

{"all"}

, orphanRemoval=true) relation defined in Parent.

In my database I have a Parent row with an id of 1, which has 3 Children with ids 1,2,3.

When I write the following code, I expect the Parent with id 1 and the Child with id 2 to be updated, a new Child to be created and the Child with id 1 and 3 to be deleted.

$parent = new Parent(); $parent->id = 1  // detached entity
$existing_child = new Child(); $child->id = 2 // detached entity
$new_child = new Child(); // new entity
$dinner->addChild($existing_child);
$dinner->addChild($new_child);

$em->merge($dinner);

$em->flush();

The objects I expect to be created and updated have the correct behaviour but the old children are not touched, they are still present in the database.

[DDC-1803] Paginator usage with a DQL query that is using 2 time the same named binded value failed

Fri, 25 Jan 2013 15:29:52 +0000

I use a dql query where I bind a named parameter 2 time in the same query for different joined fields. The query work but the count query failed saying that there are missing bind variable.

ex:
$qb = $this->getQueryBuilder()
->select('
partial fl.

{id, title, listing_date, abstract}

,
partial fla.

{id},
partial ca.{id}

,
partial ds.

{id}

')
->from('Fo_Listing', 'fl')
->join('fl.listing_properties', 'flp')
->join('flp.property', 'fp')
->leftjoin('fl.listing_assets', 'fla')
->leftjoin('fla.asset', 'ca')
->leftjoin('ca.ds', 'ds')
->where('fp.id = :propertyId')
->setParameter('propertyId', $id)
->andWhere('fl.object_status_id <> :deleted')
->setParameter('deleted', CoRefObjectStatus::DELETE)
->andWhere('fl.publishing_status_id = :published')
->setParameter('published', CoRefPublishingStatus::PUBLISHED)
->andWhere('fp.object_status_id <> :deleted')
->setParameter('deleted', CoRefObjectStatus::DELETE)
->andWhere('fp.publishing_status_id = :published')
->setParameter('published', CoRefPublishingStatus::PUBLISHED)
->add('orderBy', 'fl.listing_date DESC, fl.published_date DESC')
->setMaxResults($onTheMarketLimit);

$onTheMarket = new Paginator($qb, $fetchJoin = true);

To make it work, I've renamed the second usage of the named variable with a 2 at the end. deleted2 and published2.

[DDC-2193] Named native query bug?

Mon, 31 Dec 2012 04:02:50 +0000

@NamedNativeQueries is a useful thing, but I have found some problems during my using.
1、Normal

 /**
 * @NamedNativeQueries({
 *      @NamedNativeQuery(
 *          name            = "fetchMultipleJoinsEntityResults",
 *          resultSetMapping= "mappingMultipleJoinsEntityResults",
 *          query            = "SELECT * FROM test "
 *      )
 * })
 */

2、Error，cannot connect to the server

 /**
 * @NamedNativeQueries({
 *      @NamedNativeQuery(
 *          name            = "fetchMultipleJoinsEntityResults",
 *          resultSetMapping= "mappingMultipleJoinsEntityResults",
 *          query            = "SELECT * 
            FROM test "
 *      )
 * })
 */

3、Cannot use alias.The same problem as the second one.

.......
 query            = "SELECT a as test FROM test "

[DDC-2424] Removing an inherited entity via a delete cascade constraint does not remove the parent row

Mon, 6 May 2013 10:19:39 +0000

For a parent class:

/**
 * @ORM\Entity
 * @ORM\Table(name="Base")
 * @ORM\InheritanceType("JOINED")
 * @ORM\DiscriminatorColumn(name="discr", type="string")
 * @ORM\DiscriminatorMap({"child1" = "Child1", "child2" = "Child2"})
 */

and simple Child1 & Child2 entities.

With another entity (let's call it ExternalEntity) having a bidirectional OneToOne relation owned by Child1:

class Child1 extends Base
{
  /**
   * @ORM\OneToOne(targetEntity="ExternalEntity", inversedBy="xxx")
   * @ORM\JoinColumn(onDelete="CASCADE", nullable=false)
   */
   private theForeignKey;
}

Enough for the context.
The symptoms:

$em->remove(instanceOfExternalEntity);

removes the ExternalEntity row and the Child1 row. But a dangling row in the Base table is still there for the now inexistent Child1 instance.

Though, a manual delete of either the associated Child1 OR Base row and then the ExternalEntity works.

The problem with the cascading deletion of the parent seems to be only present when deleting through a MYSQL cascading delete from another row which has a foreign key on a child. (Not tested with a foreign key on the parent though)

[DDC-2147] Custom annotation in MappedSuperclass

Tue, 7 May 2013 21:24:53 +0000

When you try use custom annotation in mappedsuperclass like here http://pastebin.com/YMxKvcLk and then i try get metadata for class i get this error
Undefined index: fieldName
ClassMetadataInfo.php function addInheritedFieldMapping
Problem is that custom annotation doesnt have fieldName.
Quick fix is add condition to test if fieldName isset.

[DDC-2449] Amazon Redshift Support

Wed, 15 May 2013 23:09:12 +0000

It would be nice to get doctrine compatible with Amazon Redshift. It uses a Postgres connector but there are some differences. I'm currently facing an issue with the primary id, in Redshift the generation of an id is different from Postgres and so I'm getting errors associated with generating an id.

Here are some references that might be useful:
node-orm faced the same issue and seems like they figured it out: https://github.com/dresende/node-orm2/issues/39

Amazon Manual:
http://awsdocs.s3.amazonaws.com/redshift/latest/redshift-dg.pdf

[DDC-2035] XML Mapping : add attribute "length" for tag "id"

Sat, 29 Sep 2012 19:17:03 +0000

XML mapping :

<id name="id" type="string" length="16"/>

Generate SQL :

id varchar(255) not null

It's not possible with XML mapping to have :

 id varchar(16) not null

Because tag "id" doesn't support "length" attribute.
Please add this attribute

[DDC-1630] Get PersistentCollection::getDeleteDiff is empty when collection changes from 1 item to zero items

Sat, 9 Feb 2013 21:52:48 +0000

Get PersistentCollection::getDeleteDiff is empty when collection changes from 1 item to zero items

[DDC-1494] Query results are overwritten by previous query.

Sat, 9 Feb 2013 20:26:53 +0000

I am running a query that JOINs three tables, with a simple WHERE:

$q = $em->createQuery("

SELECT cat, n, c
FROM Project_Model_NoticeCategory cat
JOIN cat.notices n
JOIN n.chapters c
WHERE
c.id = :chapter_id

");

When I do this:

  $q->setParameter('chapter_id', 1);
  $a = $q->getResult();

  $q->setParameter('chapter_id', 2);
  $b = $q->getResult();

$b always has the wrong results. Running the following code:

  $q->setParameter('chapter_id', 1);
  $a = $q->getResult();

  $q->setParameter('chapter_id', 2);
  $b = $q->getResult();
  $z = $q->getArrayResult();

BUG Results: $b != $z (getArrayResult IS CORRECT, it refreshes the results) Note: $a==$b (which is wrong)

Explanation:

There is a chapter table, this has a many-to-many join to notices (these are meta info
about the chapter – a little like tagging a blog post) the notices are grouped into
categories.

Data model:

/**
 * @Entity
 * @Table(name="chapter")
 */
class Project_Model_Chapter
{
    /**
     * @Id @Column(type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    private $id;
 
    /** @Column(type="string") */
    private $title;

	/**
	 * @ManyToMany(targetEntity="Project_Model_Notice", mappedBy="chapters")
	 */
	private $notices;
	
	.... /lots of code snipped/ ....
	
}


/**
 * @Entity
 * @Table(name="notice")
 */
class Project_Model_Notice
{
	/**
     * @Id @Column(type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    private $id;
 
    /** @Column(type="string") */
    private $title;
	
	/**
	 * @ManyToMany(targetEntity="Project_Model_Chapter", inversedBy="notices")
	 * @JoinTable(name="chapter_notice")
	 */
	private $chapters;
	
	/**
	 * @ManyToOne(targetEntity="Project_Model_NoticeCategory", inversedBy="notices")
	 */
	private $notice_category;
	
	.... /lots of code snipped/ ....
	
}

/**
 * @Entity
 * @Table(name="notice_category")
 */
class Project_Model_NoticeCategory
{
    /**
     * @Id @Column(type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    private $id;
	/** @Column(type="string") */
    private $title;
	
	/**
	 * Bidirectional - One-To-Many (INVERSE SIDE)
	 *
	 * @OneToMany(targetEntity="Project_Model_Notice", mappedBy="notice_category", cascade={"persist", "remove"})
	 */
	private $notices;

	.... /lots of code snipped/ ....
	
}

Data fixtures:

$tools = new \Project_Model_NoticeCategory;
$tools->setTitle('Tools');
		
$spanner = new \Project_Model_Notice;
$spanner->setTitle('spanner');
$tools->addNotice($spanner);
		
$drill = new \Project_Model_Notice;
$drill->setTitle('power drill');
$tools->addNotice($drill);
		
$this->em->persist($tools);
$this->em->flush();

$tools = new \Project_Model_NoticeCategory;
$tools->setTitle('Safety');
		
$gloves = new \Project_Model_Notice;
$gloves->setTitle('gloves');
$tools->addNotice($gloves);
		
$goggles = new \Project_Model_Notice;
$goggles->setTitle('goggles');
$tools->addNotice($goggles);
		
$this->em->persist($tools);
$this->em->flush();

$chapter1 = new \Project_Model_Chapter;
$chapter1->setTitle('Chapter 1');
$this->em->persist($chapter1);

$chapter2 = new \Project_Model_Chapter;
$chapter2->setTitle('Chapter 2');
$this->em->persist($chapter2);

$chapter1->addNotice($spanner);
$chapter1->addNotice($gloves);

$chapter2->addNotice($spanner);
$chapter2->addNotice($gloves);
$chapter2->addNotice($drill);
$chapter2->addNotice($goggles);

// now persist and flush everything

Initial investigation:

I think it has something to do with HINT_REFRESH ? Stepping through:

ObjectHydrator->_hydrateRow
ObjectHydrator->_getEntity

when it requests the Project_Model_Category from the unit of work, it
seems that the second query is simply grabbing the cached results from
the first results. This MUST be wrong as the second query uses a
different query (the ID changes) and all the results are wrong.

[DDC-2281] Validation against database-first generated xml requires that the column order within a composite primary key match the order the columns are in in mapping xml

Thu, 9 May 2013 16:30:08 +0000

In using a database-first approach utilizing orm:convert-mapping to generate xml, the validation and schema-tool reports that my composite primary key (ex. Columns A, C, B) be dropped and added in the order in which the mapping appears in the xml (ex. Columns A, B, C).

These columns are not auto-increment and are simply a mixture of int and varchar.

[DDC-1377] Doctrine doesn't understand associations from SINGLE_TABLE inheritances

Duplicate — Thu, 15 Sep 2011 16:14:29 +0000

Doctrine doesn't understand when a query is built from an association to a SINGLE_TABLE parent to get its successors relations.

For example:
Many Lice reside in an Animal (Louse @ManyToOne Animal)
Animals can specialize into Cats or Dogs (SINGLE_TABLE Inheritance)
A Dog can have one Bone (Dog @OneToOne Bone)
A Cat can have one Yarn (Yarn @OneToOne Yarn)

From a specific Louse, Doctrine can't get the Animal's Bone or Yarn.

[DDC-51] Notice: Undefined index: [columnName] in/Doctrine/ORM/Mapping/OneToManyMapping.php on line 129

Thu, 15 Oct 2009 19:28:55 +0000

With the same example as ~~DDC-50~~

i now can not get the ManyToOne association (definitions, proverbs and relations);

i got php notice
Notice: Undefined index: phrase_id in /usr/local/zend/apache2/htdocs/doctrine/lib/Doctrine/ORM/Mapping/OneToManyMapping.php on line 129

if i check the line the variable $joinColumnValues is an empty array, because the PersistentCollection.php at line 233 did not send any joincolumnvalues to the load method. i dont know if this the cause.

i have try to set $entityManager->getConfiguration()->setAllowPartialObjects() to TRUE and make an dql like this
"SELECT p, d FROM ".models\Phrase::CLASS_NAME." p join p.definitions d WHERE p.phrase = '$phrase'"

but the result is still the same

[DDC-50] Call to undefined method Doctrine\ORM\Mapping\OneToManyMapping::getQuotedJoinColumnName()

Thu, 15 Oct 2009 14:41:03 +0000

with the $config->setAllowPartialObjects(false); i make an query to
phrase, and get a phrase object. sofar so good

but as i try to get the type or lexical member like $phrase->getType()
it throws a Fatal error like this:

Fatal error: Call to undefined method
Doctrine\ORM\Mapping\OneToManyMapping::getQuotedJoinColumnName() in
/usr/local/zend/apache2/htdocs/doctrine/lib/Doctrine/ORM/Persisters/StandardEntityPersister.php
on line 599

i read this on doctrine-user groups

http://groups.google.com/group/doctrine-user/browse_thread/thread/a15d430b4ae483b4/dc7665ed137a4e78?lnk=gst&q=getQuotedJoinColumnName#dc7665ed137a4e78

and i take a look if the line

$owningAssoc = $this->_class->associationMappings[$coll->getMapping()->mappedByFieldName];

present on StandardEntityPersister#loadOneToManyCollection.

and yes. its present. but i still got this error.

[DDC-49] Incomplete MySQL Query Generator (MySQL Syntax error)

Thu, 15 Oct 2009 14:40:37 +0000

i checkout the HEAD version. and try to write this DQL

$query = utilities\DataAccess::getEntityManager()->createQuery("SELECT
p, t FROM ".models\Phrase::CLASS_NAME." p join p.type t WHERE p.phrase
= '$phrase'");

i commented out the $config->setAllowPartialObjects(false);

and have PDO error that my MySQL statement sytax is invalid.

i check the Query that the Doctrine create and its like this :
SELECT p0_.phrase_id AS phrase_id0, p0_.phrase_name AS phrase_name1,
p1_.phrase_type_id AS phrase_type_id2, p1_.phrase_type_name AS
phrase_type_name3, p1_.phrase_type_abbreviation AS
phrase_type_abbreviation4 FROM phrase p0_ INNER JOIN phrase_type p1_
ON p0_.phrase_type_id = p1_. WHERE p0_.phrase_name = 'abu'

as you can si at the ON statement it writes p0_.phrase_type_id = p1_.

the p1_. is not completed. i think my DocAnnotation is OK, because i
look at the Doctrine Tests Models that test the OneToMany Function
(the one with the ECommerce models, product and features). I have
followed all the doc annotation writes there.

[DDC-24] text type not portable (works only on MySQL)

Mon, 14 Jun 2010 09:17:43 +0000

The text type is not portable to other RDBMS than MySQL. To support the text type, a platform must implement the method getClobDeclarationSql(array $field). Currently only MySqlPlatform has this method. This means that attempting to use the CLI tool to create a schema with a text column using another RDBMS fails with the following error:

Fatal error: Call to undefined method Doctrine\DBAL\Platforms\SqlitePlatform::getClobDeclarationSql() in D:\Projects\Test\tools\sandbox\lib\Doctrine\DBAL\Types\TextType.php on line 15

I believe at least Sqlite supports the CLOB type.

Either the text type should be supported by all platforms or the documentation should be revised. Currently it says:

"All Doctrine Mapping Types that ship with Doctrine are fully portable between different RDBMS."

This makes easy testing of models using sqlite with minimum configuration impossible with the text type.

[DDC-513] LEFT JOIN on extended entity of associated entity from parent by @OneToOne throw exception "no such column" [testcase included]

Mon, 12 Apr 2010 23:59:49 +0000

Dear Roman ,

Watch testcase please to understand this issue.

Thank you.

[DDC-512] LEFT JOIN of extended null entity cause empty result [testcase included]

Thu, 15 Apr 2010 12:39:53 +0000

Dear developers,

I'm not sure about propriety of my query but what i want to do is left
join entity which is associeted by @OneToOne. Problem occur when
associeted entity is NULL. Then i got empty result. I think it's
because my associeted entity is extended so it cause in final SQL
query inner joins which are not in subselect.

class Shop_Data_Entity_StockItem extends Shop_Data_Entity_Item

{ /** * @OneToOne(targetEntity="Shop_Data_Entity_OrderItem", mappedBy="stockItem") */ protected $orderItem; ... }

So there's my query:

$q = $em->createQuery("select u from Shop_Data_Entity_StockItem u left
join u.orderItem uu");
echo $q->getSql();
$result = $q->getResult();
count($result[0]);

// print 0 even there're Shop_Data_Entity_StockItem in database and
without left join clause prints 2

There's echo $q->getSql():

SELECT s0_.ean AS ean0, s0_.title AS title1, s0_.description AS
description2, s0_.vat AS vat3, s0_.id AS id4, s1_.bestBefore AS
bestBefore5, s0_.discr AS discr6, s0_.price AS price7,
s1_.deliveryInvoice_id AS deliveryInvoice_id8 FROM
Shop_Data_Entity_StockItem s1_ INNER JOIN Shop_Data_Entity_Item s0_ ON
s1_.id = s0_.id LEFT JOIN Shop_Data_Entity_OrderItem s2_ ON s1_.id =
s2_.stockItem_id INNER JOIN Shop_Data_Entity_OfferItem s3_ ON s2_.id =
s3_.id INNER JOIN Shop_Data_Entity_Item s4_ ON s2_.id = s4_.id

[DDC-422] Unable to add entity in @ManyToMany association when owning entity is extended from another entity

Thu, 18 Mar 2010 09:46:56 +0000

Dear developers,

I'm not sure if i extend entities in right way but i found different behaviour in extended entity which won't process add in @ManyToMany association.
My class are defined like this:

/**
 * @Entity
 * @HasLifecycleCallbacks
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="discr", type="string")
 * @DiscriminatorMap({"guest" = "Shop_Data_Entity_Guest", "customer" = "Shop_Data_Entity_Customer"})
 */
class Shop_Data_Entity_Guest extends Shop_Data_Entity_Abstract {
    public function __construct() {
        /* call parent construct with all parameters */
        call_user_func_array(array("parent","__construct"),func_get_args());
    }
}

/**
 * @Entity
 * @HasLifecycleCallbacks
 */
class Shop_Data_Entity_Customer extends Shop_Data_Entity_Guest {
    /**
     * @ManyToMany(targetEntity="Shop_Data_Entity_Contact", cascade={"persist","remove"} )
     * @JoinTable(name="Shop_Data_Entity_Customer__homes",
     *      joinColumns={@JoinColumn(name="customer_id", referencedColumnName="id", onDelete="cascade" )},
     *      inverseJoinColumns={@JoinColumn(name="contact_id", referencedColumnName="id", onDelete="cascade" )}
     *      )
     */
    public $homes;

    public function __construct() {
        /* call parent construct with all parameters */
        call_user_func_array(array("parent","__construct"),func_get_args());

        $this->homes = new Shop_Data_Collection_Standard(); // this class only extends ArrayCollection
    }
}

When i fire this code:

        $q = $em->createQuery("select c from Shop_Data_Entity_Customer c");
        $q->setMaxResults(1);
        $customers = $q->getResult();
        
        $contact = new Shop_Data_Entity_Contact();
        $customers[0]->home->add($contact);
        $em->flush();

There's no change in database.
When i change definition od Guest class like this:

/** @MappedSuperclass */
class Shop_Data_Entity_Guest extends Shop_Data_Entity_Abstract {
    public function __construct() {
        /* call parent construct with all parameters */
        call_user_func_array(array("parent","__construct"),func_get_args());
    }
}

It start work and every firing of my code add one contact and association to my database. It causes problem only when owning entity is quered from database at first.

[DDC-2440] composer.json is wrong

Thu, 9 May 2013 22:06:31 +0000

In composer.json for doctrine/doctrine-orm-module there is the following require:
"doctrine/doctrine-module": "0.8.*"

However "0.8.*" does not exist, it should be "0.8.x-dev" or "dev-master". The later would then use the branch alias. Either way this needs changing, because it's stopping the package from being installed or updated.

[DDC-802] Missing variable $name in XmlExporter

Wed, 15 Sep 2010 13:13:27 +0000

At line 112 http://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Tools/Export/Driver/XmlExporter.php#L112 is required variable $name. This variable should be replaced by $unique['name']. And before this line should be test if(isset($unique['name'])).

[DDC-1352] ErrorException: Undefined index in array

Thu, 1 Sep 2011 02:58:12 +0000

The following query:
"select c.id
from \\Domain
Cuisine c
left join c.nameTranslation t
left join t.translationValues v
left join v.language l
where v.value = :name
and l.id = :languageId"

Results in a PHP ErrorException in \Doctrine\ORM\Query\SqlWalker line 745:
$assoc = ( ! $relation['isOwningSide']) ? $targetClass->associationMappings[$relation['mappedBy']] : $relation;

When I step through the execution, the array entry: $relation['mappedBy'] gets the following value: "Domain\Translation" in the scope where the error occurs.
$targetClass->associationMappings has the following indices: "translation" and "language" and this leads to a "Undefined index" error and the execution breaks. It means that I cannot execute DQL queries, which is critical for the application to run.

<many-to-one field="translation" target-entity="Domain\Translation">
<join-column name="Translation_Id" nullable="false" referenced-column-name="Id" />
</many-to-one>

<many-to-one field="language" target-entity="Domain\Language">
<join-column name="Language_Id" nullable="false" referenced-column-name="Id" />
</many-to-one>
</entity>

[DDC-2036] indexBy breaks cascade remove

Wed, 3 Oct 2012 17:05:04 +0000

Adding the annotation indexBy causes the cascade annotation to be ignored:

/**
*

@var ArrayCollection
@ORM\OneToMany(targetEntity="LocationData", mappedBy="location", indexBy="name", cascade= {"persist", "remove"}
)
*/
protected $data;

Will cause an error when deleting the objects:

An exception occurred while executing 'DELETE FROM location WHERE id = ?' with params

{"1":19306}

SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`symfony`.`location_data`, CONSTRAINT `FK_2DF7462364D218E` FOREIGN KEY (`location_id`) REFERENCES `location` (`id`))

Removing indexBy fixes the issue.

My class structure is:

Location has many LocationData
LocationData extends AbstractData

The name field I am trying to index by comes from the AbstractData class.

[DDC-2285] Repeating the same query with different parameter value returns the same results

Fri, 8 Feb 2013 08:26:18 +0000

$activeAdsCustomers = \Ez\Registry::getDoctrineEntityManager()
    ->createQuery( "SELECT c, a FROM \Spot101\Model\Ad\Customer c JOIN c.ads a WHERE a.status = :status" )
    ->setParameter( "status", \Spot101\Model\Ad\Status::ACTIVE )
    ->getResult();

$inactiveAdsCustomers = \Ez\Registry::getDoctrineEntityManager()
    ->createQuery( "SELECT c, a FROM \Spot101\Model\Ad\Customer c JOIN c.ads a WHERE a.status = :status" )
    ->setParameter( "status", \Spot101\Model\Ad\Status::INACTIVE )
    ->getResult();

Having the code above I am getting the same results for $inactiveAdsCustomers as I get for $activeAdsCustomers. And when I try hydrating the results everything works so fine.

Both queries look the same except the value provided for the "status" parameter.

[DDC-2179] Transactions should sent in group not chunked

Fri, 30 Nov 2012 14:31:16 +0000

In UnitOfWork::commit() it seems that a transaction is done like this:

will send separate queries for transaction start
compute the queries/send them to the db driver
execute the commit statement
optionally execute rollback

The question would be, should my webserver have some issues with resources, wouldn't this part of the code be a pain for the DB?

I don't know how mysql, for example, handles sending the transaction in chunks as opposed to sending it in 2/3 statements ( begin + ops and commit / + revert in case of failure) or in mySQL,l the transaction is evaluated on COMMIT statement only?

If my assumption about how MySQL works, locking everything as soon as the statement is on the server, then shouldn't Doctrine use a internal buffer for sending transactions to the DB driver in order to avoid all sorts of problems that appear in high concurency scenarios?

Best regards.

[DDC-263] YAML and XML Driver do not support cascading options "all", "detach". Also: Improvement of YAML Syntax (Patch attached)

Fri, 22 Jan 2010 15:11:48 +0000

Hi there,

I've attached a small patch which addresses the following issues:

-> YAML did not support cascading options "all" (as described in documentation) and "detach" (as used in AssociationMapping class). The attached patch fixes that.

-> XML does not support these things either, but the attached patch DOES NOT FIX THAT (see below).

Also addressed:

YAML had syntax like cascadeRemove, cascadePersist etc., but the documentation for the annotation driver uses only "persist, remove" etc.

This patch changes the syntax to the following:

cascade: [ persist, remove ]

cascade:

persist
remove

(Both work!)

It is now also possible to use cascade: [all]

The YAML Driver was changed in that way that he must not know about the currently supported cascate actions. This has been pushed towards the AssociationMapping and I strongly believe that this is the right way.

On the other hand, I did not change the XML Driver functionality. It does still know about the cascade actions and does most probably not support the detach and "all" actions. That should be fixed, but won't take too long.

[DDC-193] Remove ClassMetadataInfo#inverseMappings

Sat, 10 Apr 2010 05:18:00 +0000

The ClassMetadataInfo#inverseMappings attribute is an unnecessary complication.

The problem comes down to: "Given an association $assoc, how do I know if the association is bidirectional?".

If $assoc is the inverse side ($assoc->isInverseSide()), its clear, its bidirectional. But if $assoc is the owning side, we dont know.
What we currently do to determine that in such a case looks as follows:

            if (isset($targetClass->inverseMappings[$assoc->sourceEntityName][$assoc->sourceFieldName])) {
                // Bi-directional
            }

So we check whether the target class has an inverse mapping to the source class. This is quite cumbersome. Additionally, we're usually only interested in the sourceFieldName of the inverse association.

Therefore, it would simplify internal code a lot if we simply introduced a "inversedBy" attribute on an association that is used on the owning side and that corresponds to "mappedBy" on the inverse side. Example:

/** @Entity */
class A {
...
   /**
    * @OneToOne(targetEntity="Other", inversedBy="a")
    * @JoinColumn(name="other_id", referencedColumnName="id")
    */
   private $other;
...
}
...
/** @Entity */
class Other {
    /** @OneToOne(targetEntity="A", mappedBy="other") */
    private $a;
}

This breaks BC. However, I think this is really necessary as it simplifies and speeds up the code, together with removing the inverseMappings attribute altogether.

So this should happen before beta.

[DDC-199] collection-valued, polymorphic fetch joins broken (hydration)

Mon, 7 Dec 2009 20:36:12 +0000

Polymorphic fetch-joins of collections are currently broken in the ObjectHydrator.

[DDC-187] JOIN fails with inherited entities

Thu, 3 Dec 2009 13:18:25 +0000

"Entity\User\AbstractUser" is a base entity for user records, "Entity\User\Person" extends AbstractUser (Single Table inheritance in this case).
The "Setting" property is a OneToOne relation with another entity.

Now when I call this DQL:
SELECT u, t FROM Entity\User\AbstractUser u LEFT JOIN u.Setting t

The ObjectHydrator fails in line 276 ("if ( ! $relation->isOneToOne()) {"...) with "PHP Fatal error: Call to a member function isOneToOne() on a non-object in .../lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php".

It works when using the sub class for the query:
SELECT u, t FROM Entity\User\Person u LEFT JOIN u.Setting t

[DDC-171] Cascade persist update foreign key for all unchanged entities

Thu, 10 Dec 2009 22:06:40 +0000

Using cascade persist, linked entities get updated even if there is no change made.

I get an update on the unchanged foreign key even if I don't modify
the entity at all.

UPDATE email SET client_id = ? WHERE id = ?

$query = $qb->getQuery();
$client = $query->getSingleResult();
$em->flush();

[DDC-132] Subclass' columns missing from cached ClassMetadata::$resultColumnNames

Wed, 9 Dec 2009 12:39:08 +0000

I have a Customer with class table inheritance mapping and some fields, and a subclass called SuperCustomer with two fields: bool `isSuper` and string `extra`.

I found that when replacing the usual ArrayCache with a MemcacheCache, everything works fine on the first request, but notices occur on subsequent requests:

Notice: Undefined index: isSuper in X:\...\Doctrine\ORM\Persisters\StandardEntityPersister.php on line 577
Notice: Undefined index: extra in X:\...\Doctrine\ORM\Persisters\StandardEntityPersister.php on line 577

Inspection of ClassMetadata::$resultColumnNames on line 569 showed that the two fields `isSuper` and `extra` were (the only things) missing. The resulting object's `isSuper` and `extra` properties were empty.

I have yet to find the cause of this, but maybe you have an idea.

[DDC-119] Collection change tracking broken with NOTIFY policy

Fri, 16 Jul 2010 05:29:45 +0000

Looks like change tracking of collections together with the NOTIFY policy doesnt work well as collection updates are detected in _computeAssociationChanges. Perhaps the collection itself should inform the UnitOfWork directly?

[DDC-116] array_combine error when using combined Primary Key

Mon, 14 Jun 2010 09:17:44 +0000

I use a combined Primary Key for a User's Phonenumber entity (to match our existing DB model). The key is combined from a "Type" field and a "userId" field that references the User table.

To mark the (referenced!) userId field and the type field as PK, I need to add "userId" to the model (adding @Id to User does not work). This works well when generating Users and Phonenumbers - but the delete command breaks:

PHP Warning: array_combine(): Both parameters should have an equal number of elements in ..../lib/Doctrine/ORM/Persisters/StandardEntityPersister.php on line 274
PHP Catchable fatal error: Argument 2 passed to Doctrine\DBAL\Connection::delete() must be an array, boolean given, called in ..../lib/Doctrine/ORM/Persisters/StandardEntityPersister.php on line 275 and defined in ..../lib/Doctrine/DBAL/Connection.php on line 372

Entities:
http://pastebin.com/d51e021e2

Test code:
http://pastebin.com/m51d1f497

[DDC-113] Cascaded persist avoids LifecycleCallbacks

Fri, 18 Dec 2009 12:30:35 +0000

When an Entity is created by 'cascade=

{"persist"}

', its LifecycleCallbacks (e.g. "PrePersist"!) are not invoked.

When it is persisted explicitly, everything workes fine and the events are called...

[DDC-74] Updates get lost when Lifecycle Events (@PreUpdate) are invoked

Fri, 13 Nov 2009 16:40:19 +0000

When Lifecycle Events are invoked on entity update (@PreUpdate), the entity is not updated properly in the database.

This code creates a User object, sets its name to "Bob" and its value to empty, then updates the object and updates the name to "Alice".

$user = new User;
$user->setName('Bob');
$user->setValue('');
$em->persist($user);
$em->flush();
$user->setName('Alice');
$em->flush();

However, when the User class has a @PreUpdate event that e.g. sets the value to "Hello World", the name change gets lost and only the value is updated by the second flush() call.

This is a critical bug which prevents creation of entities that simulate the "Timestampable" behaviour of Doctrine 1.x...

[DDC-61] OneToOne relation with an entity using Class Table Inheritance fails

Wed, 4 Nov 2009 10:30:32 +0000

The bug occurs when there's a lazy bidirectional one-to-one relation where the inverse side only specifies the root entity. In this case, the final type of the target-entity is not resolved correctly. See the attached file for a failing test case.

[DDC-41] Getting error with lazy loading via createQuery() followed by $em->flush()

Mon, 12 Oct 2009 11:56:40 +0000

Simple O-O relationship between \Entities\User and \Entities\Feed. Seems like there's a problem with not-yet lazy-loaded proxies and $em->flush().

"Entities/User.php"

<?php
namespace Entities;

/** @Entity @Table(name="users_debug") */
class User {
    /**
     * @Id @Column(type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @OneToOne(targetEntity="Feed", mappedBy="User", cascade={"persist"})
     */
    private $Feed;

    public function getID() {
        return $this->id;
    }
    public function getFeed() {
        return $this->Feed;
    }
    public function setFeed($feed) {
        $this->Feed = $feed;
    }
}
?>

"Entities/Feed.php"

<?php
namespace Entities;

/**
 * @Entity @Table(name="feeds_debug")
 */
class Feed {
    /**
     * @Id @Column(type="integer")
     * @GeneratedValue(strategy="AUTO", allocationSize=1)
     */
    private $id;

     /**
     * @OneToOne(targetEntity="User", cascade={"persist"})
     * @JoinColumn(name="user_id", referencedColumnName="id")
     */
    private $User;

    function setID($value) {
        $this->id = $value;
    }
    function getID() {
        return $this->id;
    }
    function getUser() {
        return $this->User;
    }
    function setUser($user) {
        $this->User = $user;
    }
}


?>

Table-data

users_debug:
 id
 361

feeds_debug:
 id  | user_id
 461 |     361

Code:

$user = $em->createQuery("SELECT u FROM Entities\User u WHERE u.id = 361")->getSingleResult();
print $user->getID(); // 361
// uncomment line below and it works
// print $user->getFeed()->getID();
$em->flush();

Error:
Warning: spl_object_hash() expects parameter 1 to be object, null given in /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/UnitOfWork.php on line 1010
Warning: spl_object_hash() expects parameter 1 to be object, null given in /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/UnitOfWork.php on line 566
Warning: ReflectionProperty::setValue() expects parameter 1 to be object, null given in /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/UnitOfWork.php on line 575
Warning: get_class() expects parameter 1 to be object, null given in /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/UnitOfWork.php on line 979
Fatal error: Uncaught exception 'ReflectionException' with message 'Class does not exist' in /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/Mapping/ClassMetadata.php:69
Stack trace:
#0 /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/Mapping/ClassMetadata.php(69): ReflectionClass->__construct(false)
#1 /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php(247): Doctrine\ORM\Mapping\ClassMetadata->__construct(false)
#2 /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php(177): Doctrine\ORM\Mapping\ClassMetadataFactory->_newClassMetadataInstance(false)
#3 /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php(115): Doctrine\ORM\Mapping\ClassMetadataFactory->_loadMetadata(false)
#4 /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/EntityManager.php(212): Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor(false)
#5 /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/UnitOfWork.php(979): Doctrine\ORM\EntityManager->getClassMetadata in /home/crotalus/src/Doctrine2-Dev/lib/Doctrine/ORM/Mapping/ClassMetadata.php on line 69

PostgreSQL log:
2009-10-10 16:32:58 CEST LOGG: execute pdo_stmt_000000000a283af8: SELECT u0_.id AS id0 FROM users_debug u0_ WHERE u0_.id = 361
2009-10-10 16:32:58 CEST LOGG: sats: DEALLOCATE pdo_stmt_000000000a283af8
2009-10-10 16:32:58 CEST LOGG: execute pdo_stmt_000000000a283af8: SELECT NEXTVAL('feeds_debug_id_seq')
2009-10-10 16:32:58 CEST LOGG: sats: DEALLOCATE pdo_stmt_000000000a283af8
2009-10-10 16:32:58 CEST LOGG: execute pdo_stmt_000000000a283af8: SELECT NEXTVAL('users_debug_id_seq')
2009-10-10 16:32:58 CEST LOGG: sats: DEALLOCATE pdo_stmt_000000000a283af8

[DDC-34] schema-tool --create tries to create duplicate associations and exits with exception

Wed, 7 Oct 2009 18:54:06 +0000

I'm getting the error

SchemaTool:Duplicate field mapping ()

when trying to create my database schema. I am pretty sure this worked before. The error occurs on a field defined in a mapped superclass on the first entity that extends this class on the first association.

My entity classes:

namespace Model;

use \Model\User\User;
use \DateTime;

/**
 * @MappedSuperclass
 */
abstract class Blameable
{
	/**
	 *
	 * @var DateTime
	 *
	 * @Column(type="datetime", name="date_created")
	 */
	protected $dateCreated;

	/**
	 *
	 * @var User
	 *
	 * @OneToOne(targetEntity="Model\User\User")
     * @JoinColumn(name="creator_id", referencedColumnName="id", nullable="true")
	 */
	protected $creator;

	/**
	 *
	 * @var DateTime
	 *
	 * @Column(type="datetime", name="date_updated", nullable="true")
	 */
	protected $dateUpdated;

	/**
	 *
	 * @var User
	 *
	 * @OneToOne(targetEntity="Model\User\User")
     * @JoinColumn(name="updater_id", referencedColumnName="id", nullable="true")
	 */
	protected $updater;

	/**
	 *
	 * @var DateTime
	 *
	 * @Column(type="datetime", name="date_deleted", nullable="true")
	 */
	protected $dateDeleted;

	/**
	 *
	 * @var User
	 *
	 * @OneToOne(targetEntity="Model\User\User")
     * @JoinColumn(name="deleter_id", referencedColumnName="id", nullable="true")
	 */
	protected $deleter;
}

namespace Model\User;

use \Zend_Validate_Alnum;
use \Zend_Validate_StringLength;
use \Zend_Validate_Alpha;
use \Zend_Validate_EmailAddress;
use \Zend_Registry;
use \Model\Blameable;
use \Model\ConstraintException;
use \Itoijala_Singletons;
use \Zend_Auth;
use \Itoijala_Password_Hash;

/**
 *
 *
 * @Entity @Table(name="user_users")
 */
class User extends Blameable
{
	/**
	 *
	 * @var int
	 *
	 * @Id @Column(type="integer", name="id")
     * @GeneratedValue(strategy="AUTO")
	 */
	private $id;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="20", name="username")
	 */
	private $username;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="20", name="first_name")
	 */
	private $firstName;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="20", name="last_name")
	 */
	private $lastName;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="255", name="email")
	 */
	private $email;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="20", name="signature")
	 */
	private $signature;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="128", name="password")
	 */
	private $password;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="255", name="role")
	 */
	private $role;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="32", name="session_id", nullable="true")
	 */
	private $sessionId;

	/**
	 *
	 * @var bool
	 *
	 * @Column(type="boolean", name="unlocked")
	 */
	private $unlocked;
}

namespace Model\Article;

use \Closure;
use \Model\Blameable;
use \Doctrine\Common\Collections\Collection;
use \Doctrine\ommon\Collections\ArrayCollection;
use \Model\User\User;
use \Model\Gallery\Gallery;
use \Model\ConstraintException;
use \Zend_Validate_StringLength;

/**
 * @Entity @Table(name="article_articles")
 */
class Article extends Blameable
{
	/**
	 *
	 * @var int
	 *
	 * @Id @Column(type="integer", name="id")
     * @GeneratedValue(strategy="AUTO")
	 */
	private $id;

	/**
	 *
	 * @var Category
	 *
	 * @ManyToOne(targetEntity="Model\Article\Category")
     * @JoinColumn(name="category_id", referencedColumnName="id")
	 */
	private $category;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="255", name="name")
	 */
	private $name;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="text", name="description")
	 */
	private $description;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="string", length="255", name="thumbnail")
	 */
	private $thumbnail;

	/**
	 *
	 * @var string
	 *
	 * @Column(type="text", name="content")
	 */
	private $content;

	/**
	 *
	 * @var int
	 *
	 * @Column(type="integer", name="views")
	 */
	private $views;

	/**
	 *
	 * @var bool
	 *
	 * @Column(type="boolean", name="news")
	 */
	private $news;

	/**
	 *
	 * @var bool
	 *
	 * @Column(type="boolean", name="unlocked")
	 */
	private $unlocked;

	/**
	 *
	 * @var Collection
	 *
	 * @ManyToMany(targetEntity="Model\Gallery\Gallery")
     * @JoinTable(name="article_article_galleries",
     *      joinColumns={@JoinColumn(name="article_id", referencedColumnName="id")},
     *      inverseJoinColumns={@JoinColumn(name="gallery_id", referencedColumnName="id")})
	 */
	private $galleries;

	/**
	 *
	 * @var Collection
	 *
	 * @ManyToMany(targetEntity="Model\User\User")
     * @JoinTable(name="article_article_authors",
     *      joinColumns={@JoinColumn(name="article_id", referencedColumnName="id")},
     *      inverseJoinColumns={@JoinColumn(name="user_id", referencedColumnName="id")})
	 */
	private $authors;

	/**
	 *
	 * @var Collection
	 *
	 * @OneToMany(targetEntity="Model\Article\Attachment", mappedBy="article")
	 */
	private $attachments;
}

[DDC-32] EntityManager#getReference broken

Wed, 7 Oct 2009 12:42:48 +0000

EntityManager#getReference broken

[DDC-33] Remove allowPartialObjects option.

Thu, 15 Oct 2009 14:40:18 +0000

I think this option will cause unnecessary confusion. The best solution is to always disallow partial objects, yet you can force partial objects on individual object queries to increase performance if necessary. This is much simpler for the user than to remember all the details of how the current option affects certain behavior. Also, with the current default behavior of partial objects everywhere, some standard operations can unexpectedly not work, like adding an object to a collection of a managed object (but the collection itself was not fetched yet). As a result the collection will not be wrapped by doctrine with a PersistentCollection and modifications are lost.
There are more of such examples.

I will do this myself and I think this can even be done with full backwards compatibility (though its not strictly necessary since we're still in alpha).

This should be done before entering beta.

[DDC-26] Add support for subdirectories in classdir when using schema-tool --create

Mon, 5 Oct 2009 18:36:22 +0000

Currently when using schema-tool --create, all entity classes have to be in one directory. Subdirectories are not supported and result in errors. The iterator tries to require the subdirectories. This makes it impossible to use schema-tool --create to create the database for models that use namespaces and follow Doctrine rules for placing the files in subdirectories.

The schema-tool should iterate through all of the subdirectories of the classdir to find all of the entity classes. It should also not try to require() any directories.

[DDC-21] Already fetched associations should not be overriden by subsequent queries.

Dependency — Fri, 9 Oct 2009 14:29:19 +0000

The discussion about this was brought up by ~~DC-41~~. After checking the behavior of other ORMs (notably Hibernate), already fetched associations should not be overridden by subsequent queries, just like with other persistent state of already fetched entities. This saves performance and can assure a better integrity of the object model in-memory.

Entities and their associations that are already in-memory should only be refreshed if this is done explicitly either through EntityManager#refresh($entity) or through using the Query::HINT_REFRESH query hint on any query.

[DDC-22] EntityManager#refresh() should also refresh associations.

Dependency — Wed, 28 Oct 2009 11:07:50 +0000

Initially this issue was brought up by ~~DC-41~~ which in turn led to ~~DDC-21~~. The implementation of ~~DDC-21~~ requires a working refresh() implementation that also refreshes associations.

1) For the state of the entity that is refreshed itself this is self-explanatory (simple select on the primary table, this is what already works).

2) For single-valued associations the proper query depends on whether the entity being refreshed represents the owning side or the inverse side of the association. If it is the inverse side, a simple query like this should do:

select addresses.id, ... from addresses where addresses.user_id=?

If it is the owning side, a join may be required:

select addresses.id, ... from addresses inner join users on addresses.id = users.address_id where users.id=?

3) For one-to-many collections, a simple select on the target entity table, similar to the following should do:

select .... from phonenumbers ... where phonenumbers.user_id=?

For many-to-many collections a similar select that joins over the join table is required.

An clever way for collections might be to not trigger this SQL immediately on refresh() but to simply mark the collection as uninitialized again so that the first access would trigger the reload, similar to a lazy-load.

Note that the collection itself is refreshed, not the state of the entities contained therein.
Also note that only associations need to be refreshed that were already initialized. If an associated collection is uninitialized, it does not need to be refreshed. If an associated single-valued proxy is uninitialized, it does not need to be refreshed.

[DDC-604] array_merge in Query::_doExecute causes parameter reordering

Mon, 7 Jun 2010 07:58:08 +0000

Hi all,
I think there is a bug with the doExecute method from the Query class.

foreach ($this->_params as $key => $value) { 
            if ( ! isset($paramMappings[$key])) { 
                throw QueryException::unknownParameter($key); 
            } 
            if (isset($this->_paramTypes[$key])) { 
                foreach ($paramMappings[$key] as $position) { 
                    $types[$position] = $this->_paramTypes[$key]; 
                } 
            } 
            if (is_object($value) && 
$this->_em->getMetadataFactory()->hasMetadataFor(get_class($value))) { 
                $values = 
$this->_em->getUnitOfWork()->getEntityIdentifier($value); 
                $sqlPositions = $paramMappings[$key]; 
                $sqlParams = array_merge($sqlParams, 
array_combine((array)$sqlPositions, $values)); 
            } else { 
                foreach ($paramMappings[$key] as $position) { 
                    $sqlParams[$position] = $value; 
                } 
            } 
        }

When constructing the $sqlParams array, array_merge is used for params wich
are objects. Php documentation says that numeric key are renumbered. So we
loose the position of the parameter.
I solved this problem by replacing the array_merge with that :
$sqlParams = $sqlParams + array_combine((array)$sqlPositions, $values);
But I'm not sure it doesn't have unwanted effects.
I created a fork on github for this bug, hope it could be usefull.

Edit a fail case :

SQL (for postgres):

CREATE TABLE first_class
(
  id serial NOT NULL,
  "text" character varying,
  second_class_id integer,
  CONSTRAINT first_class_pkey PRIMARY KEY (id),
  CONSTRAINT first_class_second_class_id_fkey FOREIGN KEY (second_class_id)
      REFERENCES second_class (id) MATCH SIMPLE
      ON UPDATE NO ACTION ON DELETE NO ACTION
);

CREATE TABLE second_class
(
  id serial NOT NULL,
  CONSTRAINT second_class_pkey PRIMARY KEY (id)
);

INSERT INTO second_class(
            id)
    VALUES (1);

FirstClass.php

/**
 * @Entity
 * @Table(name="first_class")
 */
class FirstClass {
  /**
   * @Id
   * @Column(name="id",type="integer")
   */
  private $id;
  /** @Column(name="text",type="string") */
  private $text;
  /**
   * @OneToOne(targetEntity="SecondClass")
   * @JoinColumn(name="second_class_id", referencedColumnName="id")
   */
  private $secondClassInstance;
}

SecondClass.php

/**
 * @Entity
 * @Table(name="second_class")
 */
class SecondClass {
  /**
   * @Id
   * @Column(name="id",type="integer")
   */
  private $id;
}

Test Case :

$secondClassInstance = $doctrineEntityManager->find('SecondClass',1);

$query = $doctrineEntityManager->createQuery("SELECT f FROM FirstClass f WHERE f.text = :text AND f.secondClassInstance = :instance")->setParameters(array('instance'=>$secondClassInstance,'text'=>'Un texte en francais',));
echo $query->getSQL();
$query->execute();

When you execute this query it fails. When printing the $sqlParams variable from _doExecute you can see the folowing :
Array ( [0] => 1 [1] => Un texte en francais )

[DDC-599] Inheritance breaks cascading

Mon, 7 Jun 2010 07:06:36 +0000

When using inheritance, cascade=

{"delete"} does not work anymore:

This example creates three Entities:
- Item
- SubItem (extends Item)
- Child

The Item has a OneToMany association with Child with cascade={"delete"}

, so if an Item is deleted, its Children are deleted too.

http://pastie.org/965096

However this does not work, the cascade is ignored when the Item is deleted. Without inheritance (e.g. only Item with Children) it works perfectly.

[DDC-593] Subquery parenthesis omitted in generated SQL

Sun, 16 May 2010 07:51:57 +0000

$dQuery = $this->_em->createQuery(
'SELECT p FROM entity\system\Group p WHERE (p.lft >= (SELECT t.lft FROM entity\system\Group t WHERE t.name = :name)) AND (p.rgt <= (SELECT t2.rgt FROM entity\system\Group t2 WHERE t2.name = :name))');

As you see this includes brackets around the subqueries.

var_dump($dQuery->getSQL());

SELECT s0_.level AS level0, s0_.lft AS lft1, s0_.rgt AS rgt2, s0_.id AS id3, s0_.name AS name4, s0_.description AS description5 FROM system_group s0_ WHERE (s0_.lft >= SELECT s1_.lft FROM system_group s1_ WHERE s1_.name = ?) AND (s0_.rgt <= SELECT s2_.rgt FROM system_group s2_ WHERE s2_.name = ?)

Brackets gone, resulting in:

'PDOException' with message 'SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'SELECT s1_.lft FROM system_group s1_ WHERE s1_.name = 'root') AND (s0_.rgt <= SE' at line 1' in /usr/share/php/lib/Doctrine/DBAL/Connection.php:566

Brackets added and executed against database

SELECT s0_.level AS level0, s0_.lft AS lft1, s0_.rgt AS rgt2, s0_.id AS id3, s0_.name AS name4, s0_.description AS description5 FROM system_group s0_ WHERE (s0_.lft >= (SELECT s1_.lft FROM system_group s1_ WHERE s1_.name = "root")) AND (s0_.rgt <= (SELECT s2_.rgt FROM system_group s2_ WHERE s2_.name = "root"))

Works (MySQL).

[DDC-576] New entities must have primary key values right after flushing with IDENTITY strategy

Sat, 8 May 2010 08:11:29 +0000

After insertion of some new entity the primary key must be set. Example code is attached above.

[DDC-561] Metadata caching broken due to incomplete __sleep functions

Fri, 30 Apr 2010 12:29:24 +0000

When using a persistent Metadata cache, the serialized ClassMetadata objects are not complete.

This leads to very strange behavior since not all Metadata is loaded in the next request (which uses cached Metadata). The problem is that the __sleep methods of Doctrine\ORM\Mapping\AssociationMapping and Doctrine\ORM\Mapping\ClassMetadata are note complete (missing "namespace", "fetchMode" properties).

[DDC-531] Collections broken in self-referenced Entities

Sun, 23 May 2010 09:29:29 +0000

When dealing with parent / children entities, the UnitOfWork does not always hydrate all data correctly.

This example generates Group1 and its child Group2. Then Clears the Entity Manager, loads Group2 (so it is in the EM), loads Group1 and then the children of Group1 (Group2 is the child of Group1).
However the children of Group1 cannot be loaded, because $group4->children is not there:

Warning: Invalid argument supplied for foreach() in /Users/nico/Projects/test/test.php on line 20

When calling Debug::dump($group4), I get this:

object(stdClass)#56 (2) {
  ["__CLASS__"]=>
  string(26) "Proxies\EntitiesGroupProxy"
  ["id"]=>
  string(1) "1"
}

test.php
http://pastebin.com/7Q3wwtn6

Group entity:
http://pastebin.com/hBj2Emrf

[DDC-518] Merging an entity with a one to one association to a MANAGED entity with no id throws 'The given entity has no identity.'

Fri, 30 Jul 2010 12:01:46 +0000

Calling merge($entity) where $entity has a one to one association to another entity that has been persisted but not yet flushed (when using auto-generated ids) throws 'The given entity has no identity.'

It looks like it does this because _doMerge in UnitOfWork assumes for one to one associations only that the associated entity has an id and calls registerManaged, which then calls addToIdentityMap)on it.

I think that registeredManaged should only be called if !isset($this->_entityInsertions[spl_object_hash($other)])

Reproduce.php

// This is a new element
$doctor = new \vo\Doctor(); $d1->name = "New doctor";

// This is a detached element which is in the database
$patient = new \vo\Patient(); $p1->name = "Existing patient"; $p1->id = 1;

$doctor->patients->add($patient);
$patient ->doctor = $doctor;

$em->persist($doctor);

// This throws InvalidArgumentException: The given entity has no identity. in D:\Projects\ORM\flextrine2\flextrine\web\lib\Doctrine\ORM\UnitOfWork.php on line 1014
$em->merge($patient);

Doctor.php

class Doctor {

    /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
    public $id;
	
    /** @Column(length=100, type="string") */
    public $name;
	
	/**
     * @OneToMany(targetEntity="Patient", mappedBy="doctor", fetch="EAGER")
     */
	public $patients;
	
	public function __construct() {
		$this->patients = new ArrayCollection();
	}
	
}

Patient.php

class Patient {
	
	var $_explicitType = "vo/Patient";
	
    /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
    public $id;
	
    /** @Column(length=100, type="string") */
    public $name;

	/**
     * @OneToOne(targetEntity="Doctor", inversedBy="patients")
	 * @JoinColumn(name="doctor_id", referencedColumnName="id")
     */
	public $doctor;
	
}

[DDC-500] Single Table Inheritance Selects

Reference — Mon, 26 Apr 2010 08:30:57 +0000

We have a set of models that use Single Table inheritance and we are trying to select all objects of one type:

/**
 * @Entity
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="type", type="string")
 * @DiscriminatorMap({"Child"="Child", "OtherChild"="OtherChild"})
*/
abstract class ParentModel
{
    /**
     * @Id @Column(name="id", type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /** @Column(type="string") */
    public $property;

    function getId() {return $this->id;}
}

abstract class SubParent extends ParentModel
{
}

/**
 * @Entity
 */
class Child extends SubParent
{
    /** @Column(type="string") */
    public $anotherProperty;
}

/**
 * @Entity
 */
class OtherChild extends SubParent
{
    /** @Column(type="string") */
    public $someOtherProperty;
}

Now to query for all of the Child objects we do:

$children = $em->getRepository('Child')->findall();
foreach($children AS $child) {
    echo $child->getId();
}

but we get "Notice: Undefined index: id in ./Doctrine/ORM/UnitOfWork.php on line 1727" on the finAll() call and the objects that aren't of the correct type have their properties nulled out. This is because the query that is being executed doesn't have any conditionals for the type of model it's looking for and the ORM doesn't check to make sure that the object is of the correct type.

This could be solved by having conditionals in the SQL query (chaining a bunch of 'or' statements for all of the child objects) or by pulling back all of the objects and then filtering out what isn't of the correct type. Unfortunately neither solution seems ideal.

I'll try to make a test case for this then.

[DDC-497] find() and findAll() on Repository do not work when SINGLE_TABLE inheritance is used

Reference — Mon, 26 Apr 2010 08:32:21 +0000

 
Class Orm\Models\Car:

	@Entity
	@Table(name="cars")
	@InheritanceType("SINGLE_TABLE")
 	@DiscriminatorColumn(name="discr", type="string")
	@DiscriminatorMap({"car" = "Orm\Models\Car", "bluecar" = "Orm\Models\BlueCar"})

Class Orm\Models\BlueCar extends Orm\Models\Car:
	
	@Entity

Now my Database holds 4 records:
	
	id 	title 		discr
	1 	blue car 	bluecar
	2 	only Car 	car
	5 	blue car2 	bluecar
	6 	only Car2 car

Now querying objects by Repository leads to some errors.

	
	//quering for all BlueCars
	$em->getRepository('Orm\Models\BlueCar')->findAll();
	
	//the result set counts 4 objects
	blue car	: Orm\Models\BlueCar
			: Orm\Models\Car
	blue car2	: Orm\Models\BlueCar
			: Orm\Models\Car

	//The 2 Car Items where the title is missing are to much for this result set, and useless
	// there is also a php notice coming up for each Orm\Models\Car object
	Notice: Undefined index: id in /library/Doctrine/ORM/UnitOfWork.php  on line 1727
	I use mysql as Database and so the sql query looks like this.

	"SELECT c0.id AS id1, c0.title AS title2, discr FROM cars c0"
	
	It seems that the query is missing the where discriminator = "bluecar" part

querying for Car
	$em->getRepository('Orm\Models\Car')->findAll();
	
	blue car: Orm\Models\BlueCar
	only Car: Orm\Models\Car
	blue car2: Orm\Models\BlueCar
	only Car2: Orm\Models\Car

	Is working without errors but i think it is a mere chance if you look at the query
	"SELECT c0.id AS id1, c0.title AS title2, discr FROM cars c0" it is the same.

	I am not shure if it is intended that quering for Cars also returns BlueCars but due to the behavior when using DQL for quering, i guess it is right.
	That means, when using DQL:

	$q = $em->createQuery('select u from Orm\Models\BlueCar u');
	$results = $q->execute();

	everything works as expected, so using a custom EntityRepository and override find, findAll and so on is a workaround. So this is a minor bug ?

[DDC-481] Incorrect table aliasing when using quoting on table names

Mon, 14 Jun 2010 09:17:46 +0000

I need to quote several table names (because of reserved words within MySQL) like so:

 
/**
 * @Entity
 * @Table(name="`Column`")
 */
class Column extends OptionAbstract

Another entity Question is related one-to-many to these entities, however, when trying to fetch the relation I get SQL errors because it seems to use the backtick as the table alias, which is illegal. An example of the query it's generating:

SELECT `0.id AS id1, `0.name AS name2, `0.sequence AS sequence3, `0.question_id AS question_id4 FROM `Column` `0 WHERE question_id = ?

[DDC-448] Cannot select rows from chield table by JoinColumn in @InheritanceType("JOINED") parent table

Tue, 13 Apr 2010 04:20:32 +0000

This bug is connected with http://www.doctrine-project.org/jira/browse/DDC-416
I have this schema.

/**
 * @Entity
 * @InheritanceType("JOINED") 
 * @DiscriminatorColumn(name="discr", type="smallint")
 * @DiscriminatorMap({
 * "0" = "mainTable",
 * "1" = "SubTable"
 * })
 */
class mainTable
{  	
    /**
     * @Id
     * @Column(name="id", type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @ManyToOne(targetEntity="connectedClass",  cascade={"all"}, fetch="EAGER")
     * @JoinColumn(name="connectedClassId", referencedColumnName="id", onDelete="CASCADE", onUpdate="CASCADE", nullable=true)
     */
    private $connectedClassId;
}

/**
 * @Entity
 * @Table(name="connectedClass")
 * @HasLifecycleCallbacks
 */
class connectedClass
{	
    /**
     * @Id
     * @Column(name="id", type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    protected $id; // connected with mainTable
}

/**
 * @Entity
 * @Table(name="SubTable")
 */
class SubTable extends mainTable
{
}


$qb->select(array('b'))
       ->from('SubTable', 'b')
       ->where(
           $qb->expr()->eq('b.connectedClassId', '?1') // select by JoinColumn field does not work
                                                                                          // select by normal column work (after http://www.doctrine-project.org/jira/browse/DDC-416  ) 
       )
       ->setParameter(1, $value); // $value - const or connectedClass object


Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'i1_.connectedClassId' in 'where clause'' in /var/www/shelly/library/Doctrine/DBAL/Connection.php:573
Stack trace:
#0 /var/www/shelly/library/Doctrine/DBAL/Connection.php(573): PDOStatement->execute(Array)
#1 /var/www/shelly/library/Doctrine/ORM/Query/Exec/SingleSelectExecutor.php(42): Doctrine\DBAL\Connection->execute('SELECT p0_.id A...', Array)
#2 /var/www/shelly/library/Doctrine/ORM/Query.php(231): Doctrine\ORM\Query\Exec\SingleSelectExecutor->execute(Object(Doctrine\DBAL\Connection), Array)
#3 /var/www/shelly/library/Doctrine/ORM/AbstractQuery.php(514): Doctrine\ORM\Query->_doExecute(Array)
#4 /var/www/shelly/library/Doctrine/ORM/AbstractQuery.php(391): Doctrine\ORM\AbstractQuery->execute(Array, NULL)

So, we cannot select rows by JoinColumn from Inheritance tables, because doctrine selects SubTable.connectedClassId field, not mainTable.connectedClassId

This bug was fix in http://www.doctrine-project.org/jira/browse/DDC-416 patch, but it was not commited. I may write unit test for this problem

[DDC-419] Problem when I make a INNER JOIN between 2 classes

Dependency — Sun, 8 Aug 2010 07:17:16 +0000

I hae some problems when I make a inner join between 2 classes, one of these classes makes join to others 2 classes in the same time and when I try to make a inner to this class, it's not coming like a object, but object Id...

I don't know why its happening..

I make a test case..there're all the classes and yml that show my problem..it's on ItemPregaoTest.php.. just need to run phpunit in this file..

[DDC-388] Private properties in @MappedSupperclass don't work

Duplicate — Wed, 14 Apr 2010 11:41:40 +0000

All of my entites extend an abstract class Model to inherit the 'id' property and some other functionality. It has the @MappedSuperclass annotation.

If the id property is declared private to the Model class, I'll get the following exception when using entites extending it:

[03-Mar-2010 11:36:29] exception 'ReflectionException' with message 'Property id does not exist' in library/Doctrine/ORM/Mapping/ClassMetadata.php:370
Stack trace:
#0 library/Doctrine/ORM/Mapping/ClassMetadata.php(370): ReflectionClass->getProperty('id')
#1 [internal function]: Doctrine\ORM\Mapping\ClassMetadata->__wakeup()
...

I haven't looked at Doctrine code, but perhaps you should be looking for the property on the class which actually has the @Column annotation?

[DDC-335] Refactor DQL EBNF to use JOIN FETCH as syntax for fetch joins only

Dependency — Fri, 19 Feb 2010 16:33:27 +0000

There are several problems with the current approach on fetch joins:

1. There is no way to determine in the parser already if a join is fetch or not, this makes it much harder to implement things like @OrderBy or @OrderColumn
2. A DQL like "SELECT u, g.name FROM User u JOIN u.group g" currently tries to partially load the group object instead of just returning g.name as scalar. This is very unintuiative.

Solution, change the EBNF too:

Join                                       ::= ["LEFT" ["OUTER"] | "INNER"] "JOIN" [FETCH] JoinAssociationPathExpression 
                                               ["AS"] AliasIdentificationVariable [("ON" | "WITH") ConditionalExpression]

Question would be how to specify partial object selects.

Romans idea was something like:

select u.{name, other, field, stuff}

However my take is this would again put information into the select clause that might be interesting elsewhere, so

SELECT u FROM User u JOIN FETCH u.group PARTIAL id, name

That way we could add both $isFetchJoin and $isPartial flags to the AST/Join Node plus an additional $partialFields array.

[DDC-317] Using a function only in hydration returns only one result

Fri, 19 Feb 2010 16:30:58 +0000

Output of $arg:

array(1) {
  [-1]=>
  array(1) {
    ["namedep"]=>
    string(25) "Jonathan W.Administration"
  }
}

    public function testConcatFunction()
    {
        $this->generateFixture();
        $arg = $this->_em->createQuery('SELECT CONCAT(m.name, m.department) AS namedep FROM Doctrine\Tests\Models\Company\CompanyManager m')
                         ->getArrayResult();

        $this->assertEquals(4, count($arg)); // fails with 1
    }

    protected function generateFixture()
    {
        $manager1 = new CompanyManager();
        $manager1->setName('Roman B.');
        $manager1->setTitle('');
        $manager1->setDepartment('IT');
        $manager1->setSalary(100000);

        $manager2 = new CompanyManager();
        $manager2->setName('Benjamin E.');
        $manager2->setTitle('');
        $manager2->setDepartment('HR');
        $manager2->setSalary(200000);

        $manager3 = new CompanyManager();
        $manager3->setName('Guilherme B.');
        $manager3->setTitle('');
        $manager3->setDepartment('Complaint Department');
        $manager3->setSalary(400000);

        $manager4 = new CompanyManager();
        $manager4->setName('Jonathan W.');
        $manager4->setTitle('');
        $manager4->setDepartment('Administration');
        $manager4->setSalary(800000);

        $this->_em->persist($manager1);
        $this->_em->persist($manager2);
        $this->_em->persist($manager3);
        $this->_em->persist($manager4);
        $this->_em->flush();
        $this->_em->clear();
    }

[DDC-610] Numeric strings are not quoted

Tue, 25 May 2010 15:11:35 +0000

I've been working on a MaterializedPath implementation and hit a roadblock.

This condition:

// $pathInterval = array('00010001', '0001ZZZZ');
$andX->add($expr->between('e.' . $this->getPathFieldName(), $expr->literal($pathInterval[0]), $expr->literal($pathInterval[1])));

results in this SQL:

AND (l0_.path BETWEEN 00010000 AND '0001ZZZZ')

This is clearly not correct. Numeric strings should still be quoted if the field is of type string.

[DDC-168] serialization/unserialization of ClassMetadata lose reflFields order causing insertSql statement to fail

Thu, 17 Dec 2009 13:48:12 +0000

This problem will be difficult to reproduce for you, but I isolated the exact cause of it.

To reproduce

Use any MetadataCache
Create a complex entity with some inheritance. (I may detail in later if your really need it)
Create an element of this entity with persist.
Create an other element of this entity but not on the same php run. (ex: reload the page)
The insert statement will fail because field names will not match parameters.

I narrowed it down to a serialization issue.

When you serialize an MetadataInfo, you don't serialize reflFields.
When you unserizlize you regenerate this value using ReflectionClass
That sound's like a good optimization.

The problem is that somehow, the reflection class can return the fields not in the same order that they were at the initial creation of the MetadataInfo.

Because the insertSql value is not re-generated, it can be out of sync with the new fields order.

The solution :
Call something like MetadataInfoFactory::_generateStaticSql (whish is private but ...) at wakeup time.

[DDC-164] find() not polymoprhic with single table inheritance

Sat, 21 Nov 2009 18:52:22 +0000

find() not polymoprhic with single table inheritance

[DDC-152] Polymorphic queries and fields of subclasses

Sat, 19 Dec 2009 13:39:06 +0000

Currently fields of subclasses are added to the ResultSetMapping under the alias of the queried (parent) class. Later during hydration if the queried (parent) class does not own a field AbstractHydrator#_lookupDeclaringClass looks up the first subclass that defines a field with that name. However, multiple subclasses can define a field with the same name, so this is error-prone.

Fields of subclasses in a polymorphic query should probably be added to the ResultSetMapping with their own alias. The lookup during hydration should be removed and the information which field belongs to which class encoded in the ResultSetMapping.

[DDC-145] Cascaded delete on a lazyloaded persistent collection

Fri, 13 Nov 2009 19:34:48 +0000

It seems that if you call PersistentCollection#unwrap on a lazy loaded collection, you get nothing back (unless you initialize the collection first). Because of this, UnitOfWork#_cascadeRemove is "unwrapping" the collection before transversing it, and nothing gets deleted on the cascade.

[DDC-141] DQL with WHERE queries on Single Table Inheritance Entities fail

Fri, 13 Nov 2009 10:12:43 +0000

The ORM query builder seems to be broken for Single Table Inheritance with discriminator.

When using inheritance like here:
http://www.doctrine-project.org/documentation/manual/2_0/en/inheritance-mapping#single-table-inheritance

Queries with WHERE fail:

SELECT p FROM MyProject\Model\Person p WHERE p.id = 1

This translates to this SQL:

SELECT p0_.id AS id0, p0_.discr AS discr1 FROM person p0_ WHERE p0_.id = 1 p0_.discr IN ('', 'person', 'employee')

(AND is missing after p0_.id = 1)

[DDC-137] Only last relation id updated with multiple one-to-one self-referencing relations

Sun, 15 Nov 2009 11:44:21 +0000

Take this simplified situation:

/** @Entity */
class Entity {
	/** @Id @GeneratedValue(strategy="AUTO") @Column(type="integer") */
	public $id;

	/**
	 * @OneToOne(targetEntity="Entity", cascade={"persist"})
	 * @JoinColumn(name="other1", referencedColumnName="id")
	 */
	public $other1;

	/**
	 * @OneToOne(targetEntity="Entity", cascade={"persist"})
	 * @JoinColumn(name="other2", referencedColumnName="id")
	 */
	public $other2;
}

$entity1 = new Entity();
$em->persist($entity1);
$entity1->other1 = $entity2 = new Entity();
$entity1->other2 = $entity3 = new Entity();
$em->flush();

The entities' ids are now:

Entity 1: 1, Entity 2: 2, Entity 3: 3

However, the other1's relation id is not updated:

id	other1	other2
1  	NULL 	3:	// other1's id is missing
2 	NULL 	NULL
3 	NULL 	NULL

The SQL clarifies:

INSERT INTO Entity (other1, other2) VALUES (?, ?)
array(2) {
  [1]=>
  NULL
  [2]=>
  NULL
}
INSERT INTO Entity (other1, other2) VALUES (?, ?)
array(2) {
  [1]=>
  NULL
  [2]=>
  NULL
}
INSERT INTO Entity (other1, other2) VALUES (?, ?)
array(2) {
  [1]=>
  NULL
  [2]=>
  NULL
}
UPDATE Entity SET other2 = ? WHERE id = ?
array(2) {
  [0]=>
  int(3)
  [1]=>
  int(1)
}

Adding 'other3' proved that only the last relation id is updated, as such:

id	other1	other2	other3
1  	NULL 	NULL	4	// other1 and other2 missing
2 	NULL 	NULL	NULL
3 	NULL 	NULL	NULL
4 	NULL 	NULL	NULL

This is not the case with relations that reference to entities outside the class hierarchy (so the same problem occurs with relations inside the class hierarchy).

[DDC-2] Proxies in UoW::_computeChangeSets

Tue, 6 Oct 2009 10:04:58 +0000

When having a proxy object, say "PhonenumberProxy? extends Phonenumber", and its not yet loaded from the database I think an error occures in the UnitOfWork::_computeChangeSets function since it goes and retrieves that lazy load object value using an instance of "ReflectionProperty?". However with it being lazily loaded the value must be null.

[DDC-875] Merge can sometimes add the same entity twice into a collection

Sun, 11 Mar 2012 20:46:45 +0000

When merging some cascade merge object-graphs, the same entity in a ManyToMany association can be put into a collection twice during doMerge.

The attached patch should stop this from happening.

[DDC-792] CLI run-dql --max-result switch calls undefined method

Wed, 15 Sep 2010 13:26:21 +0000

doctrine orm:run-dql "SELECT a FROM Entity\Foo a" --max-result=1

Result:

PHP Fatal error:  Call to undefined method Doctrine\ORM\Query::setMaxResult() in /var/www/mysite.com/library/Doctrine/ORM/Tools/Console/Command/RunDqlCommand.php on line 117

Fatal error: Call to undefined method Doctrine\ORM\Query::setMaxResult() in /var/www/mysite.com/library/Doctrine/ORM/Tools/Console/Command/RunDqlCommand.php on line 117

Solution:

Update line 117 of Doctrine/ORM/Tools/Console/Command/RunDqlCommand.php to call setMaxResults rather than setMaxResult

[DDC-775] Ability to use IFNULL() function in ORDER BY clause

Sun, 25 Mar 2012 13:19:51 +0000

    $qb = $em->createQueryBuilder(); /* @var $qb Doctrine\ORM\QueryBuilder */
    $roles = $qb->from('App_Model_Role', 'r')
                ->select('r')
                ->orderBy('IFNULL(r.rootId, r.id), r.lft')
                ->getQuery()
                ->getResult();

[Syntax Error] line 0, col 46: Error: Expected end of string, got '('

[DDC-1284] Inheritance fails in JOIN query

Sun, 14 Aug 2011 03:18:40 +0000

Hi!
Sorry for my english, I'm working on that.
I've this code:

/**
 * @Entity
 * @Table(name="entity") 
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="entityTypeId", type="smallint")
 * @DiscriminatorMap({0 = "Bank",  1 = "Dealer", 2 = "Debtor", 3 = "Repo", 4 = "Appraiser", 5 = "Transport"})
 */
class Entities
{
     /**
     * @Id @GeneratedValue
     * @Column(type="integer")
     * @var integer
     */
    protected $id;

   /**
     * @Column(type="string", length=40)
     * @var text
     */
    protected $name;

    ............................................................
    ............................................................
}

------------------------------------------------------------------------------------------------------------------------------------
/** 
 * @Entity(repositoryClass="Model\Entity\Repository\DebtorRepository")
 * @Table(name="debtor") 
 */ 
class Debtor extends Entities{
    
}

------------------------------------------------------------------------------------------------------------------------------------
 
/**
 * @Entity(repositoryClass="Model\Entity\Repository\PlacementRepository")
 * @Table(name="placement")
 */
class Placement
{
      
    /**
     * @Id
     * @Column(type="smallint")
     * @var integer
     */
    protected $id;


       /**
     * @ManyToOne(targetEntity="Debtor", inversedBy="placements")
     * @JoinColumn(name="debtorId", referencedColumnName="id")
     */
    protected $debtor;
 
........................................
.......................................
}

The DQL query:

"SELECT t1 FROM Model\Entity\Placement t1 INNER JOIN t1.debtor d WITH d.name = 'test' "

fails and show the message

"SQLSTATE[42S22]: Column not found: 1054 Unknown column 'e2_.name' in 'on clause'"

I hope somebody know how fix this, I can't fixing this.

[DDC-1234] With class table inheritance, SqlWalker always joins subclass tables even when they are not used

Sun, 16 Oct 2011 03:26:17 +0000

When using class table inheritance, it is not possible to avoid joining subclass tables even if they are not needed. For example, when selecting only scalar fields of the parent class and using array hydration.

Classes:

/**
 * @Entity
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="discr", type="string")
 * @DiscriminatorMap({"employee" = "Employee", "customer" = "Customer"})
 */
class Person
{
    ...
    /** @Column(name="name", type="string") */
    protected $name;
    ...
}

/** @Entity */
class Employee extends Person
{
    ...
}

Test code:

$entityManager->createQueryBuilder()->select('p.name')->from('Person', 'p')->getQuery()->getArrayResult();

The generated SQL includes 'employee' table even though it is not used.

[DDC-1184] ORM\Id\AssignedGenerator try to current() on non-array

Sat, 11 Jun 2011 08:46:49 +0000

// Doctrine\ORM\AssignedGenerator::generate at line 54

$identifier[$idField] = current($em->getUnitOfWork()->getEntityIdentifier($value));

$value may also be new, so getEntityIdentifier returns NULL and current(NULL) generates an E_WARNING.

[DDC-1175] Call chaining for entity manager

Mon, 30 May 2011 06:20:32 +0000

It would be nice to have the entity manager return $this in methods like persist and remove, so instead of having this:

$em = $this->get('doctrine')->getEntityManager();
$user = $em->find('AcmeHelloBundle:User', $id);
$em->remove($user);
$em->flush();

One could do this:

$em = $this->get('doctrine')->getEntityManager();
$user = $em->find('AcmeHelloBundle:User', $id);
$em
->remove($user)
->flush();

It is a small improvement (and perhaps its not the best case to demonstrate it) but it makes using the entity manager more comfortable.

[DDC-1157] Remove Cascade doesn't work on proxy object

Tue, 6 Sep 2011 04:48:29 +0000

Hi all,

I am a beginner with doctrine, so all my apologize if this is not the place, or if this issue was already report. I posted on doctrine user google group(http://tinyurl.com/6gh49yh), but got no response, asked on mirc channel, not response too. I searched into jira for the same issue, but i don't find.

This is my problem: I have a ont-to-one relation between two entities, A and B. A got foreign key to B. I configure delete cascade on A, so i am expected that if A is deleted, B should be too.
I used the Entity Manager getReference method to get an A entity, so this is a proxy object. I did $em->remove($A). After flush, A is remove, but B still alive.
I investigate doctrine source code, and i found in UnitOfWork#cascaseRemove method, line 1705, a TODO comment line, where initialized should call on proxy object. And when remove is called on Proxy object, at this point, $relatedEntities is null.
When i used the Entity Manager find method, i got an object fullfilled, so at this line $relatedEntities is not null.

So this is a forgotten implementation, a bug, or did I make something wrong because what i want to do work perfectly for you ?

Thanks for reading.

[DDC-1142] Cache affecting Doctrine\ORM\Persisters\BasicEntityPersister::_prepareUpdateData()

Thu, 15 Mar 2012 21:50:50 +0000

Doctrine\ORM\Persisters\BasicEntityPersister::_prepareUpdateData()
Differing behaviour on line 460 if (isset($this->_class->associationMappings[$field])) {

Dependand on the prepopulation of $this->_class->associationMappings.
If you are using the \Doctrine\Common\Cache\ArrayCache (every request) or \Doctrine\Common\Cache\MemcacheCache (only on the first request after restart)
$this->_class->associationMappings[ $field] is set.

Subsequent calls when using memcache wil have $this->_class->associationMappings[$field] NOT set & hence differing behaviour.
result: irregular updates of associations

[DDC-1114] Association on a non primary key field - fix the commit order

Reference — Mon, 5 Sep 2011 05:30:12 +0000

We are trying to create an association which referenced column is not a primary key.

The source entity mapping looks like:

The destination entity mapping is:

</entity>

Doctrine will correctly create the tables with the above mapping but the association does not seem to work.

When we try to load some data in the tables:

$showInst = new ShowInstance();
$showInst->setExtid(999);
$manager->persist($showInst);

$teaser = new ShowInstanceTeaser();
$teaser->setShowInstance($showInst);
$manager->persist($teaser);

This will leave the column "teaser.show_instance_extid" null.

Doing the same but using the primary key for the association will work.

In a discussion on the #doctrine-dev channel on freenode beberlei explained:

<beberlei> ah the problem is probably the CommitOrderCalculator does not know of this foreign key
<beberlei> and sorts the inserts in the wrong order

<beberlei> you cannot add foreign keys say through some mapping information in annotations or xml the like
<beberlei> you have to create them manually
<beberlei> and in this case doctrine might end up in troubles depending on the commit order
<beberlei> hibernate solves this by allowing to specifiy additional constraints that are recognized while calculating the commit order, but this is not yet in tdoctrine2. can you open up a ticket for this?

[DDC-1046] Configurable/overridable code generation templates for entities and repositories classes automatic generation

Sun, 11 Mar 2012 20:54:48 +0000

Initial proposal discussed in doctrine-user groups: http://groups.google.com/group/doctrine-user/browse_thread/thread/10ed814339429c3e?hl=en

Required features are:

1. Possibility to override default Doctrine's code generation templates, which are hard-coded for the moment within EntityGenerator & EntityRepositoryGenerator classes
2. Possibility to extend Repository classes from a custom base class. For the moment it is also hard-coded inside EntityRepositoryGenerator class to be extended from Doctrine\ORM\EntityRepository

Attached pull request with possible implementation is here: https://github.com/doctrine/doctrine2/pull/30

[DDC-1020] Do we really need PreUpdateEventArgs::_assertValidField()?

Fri, 11 Feb 2011 13:14:47 +0000

I am not sure why we need this. I have a situation where we have a preUpdate() listener and the field I want to set the value for is not already in the changeset so _assertValidField() throws an exception. Do we really need this?

class Order
{
    private $something;
    private $tax;

    // ...
}

$order = $em->find('Order', 1);
$order->setSomething('test');

$em->flush();

class MyListener
{
    public function preUpdate(PreUpdateEventArgs $args)
    {
        $calculatedTax = 0;
        // _assertValidField() in PreUpdateEventArgs throws an exception because
        // tag is not already in the changeset. If i hack around it and do $this->tax = 1; or something
        // in the contructor of Order then it shows up in the changeset and setNewValue() works
        $args->setNewValue('tax', $calculatedTax);
    }
}

[DDC-1013] Possible issue with multiple levels of Mappedsuperclasses and wrong sql table aliases

Reference — Sun, 14 Aug 2011 16:18:34 +0000

Possible issue with multiple levels of Mappedsuperclasses and wrong sql table aliases

[DDC-949] strange behavior with boolean types when using findOneBy() in a CLI phpunit test

Sun, 2 Jan 2011 07:14:01 +0000

I do not see this behavior when running findByOne() calls via the Apache SAPI. No clue really what could possibly cause this. Not sure how to get the error logger to output something in a phpunit test (never really figured out how phpunit supports debugging). Essentially if I run the tests with SQLite the case with 'false' fails and when I run with PostgreSQL the case with 0 fails. Essentially in the fail case I get an instance of $this, just like when I pass: false.

Tell me if this report is useless in the current state and then I will work on separating it out into a standalone CLI script without Symfony2 and phpunit. But I dont want to spend more time on this if it isnt necessary.

[DDC-1408] DQL parser fails to parse alias in select expression named "count"

Sun, 16 Oct 2011 03:29:38 +0000

When running DQL

SELECT count(u.id) AS count FROM User u

I receive error

  [Doctrine\ORM\Query\QueryException]                                                      
  [Semantical Error] line 0, col 28 near 'FROM User u': Error: Class 'FROM' is not defined.

because of "COUNT" alias being parsed as aggregate function.

Still such alias is valid in MySQL and should be treated as "identifier" following the DQL EBNF (at least I think so).

If not fixing this to allow such names being used as aliases, at least should warn developer about this somehow, because the current error is not self descriptive.

[DDC-1362] Native SQL with addJoinedEntityResult() causes wrong mapping

Thu, 15 Mar 2012 22:32:42 +0000

Order of fields in the native select query and order of result set mapping should be in the same order, otherwise wrong mapping is happening.

I have faced problem with my code. I am explaining the issue with the simple code

$sql ="
SELECT
a.id as aid,
a.city_name,
a.country_name,
u.id as uid,
u.name,
u.age
FROM
user as u
JOIN
address as a
ON
u.address_id=a.id";

$rsm = new ResultSetMapping;

$rsm->addEntityResult('models\User', 'u');
$rsm->addFieldResult('u', 'uid', 'id');
$rsm->addFieldResult('u', 'name', 'name');
$rsm->addFieldResult('u', 'age', 'age');

$rsm->addJoinedEntityResult('models\Address', 'a', 'u', 'address');

$rsm->addFieldResult('a', 'aid', 'id');
$rsm->addFieldResult('a', 'city_name', 'city_name');
$rsm->addFieldResult('a', 'country_name', 'country_name');

$query = $this->_em->createNativeQuery($sql, $rsm);
return $query->getResult();

As in the code, the select clause column ordering and result set mapping orders are reversed. It causes the wrong mapping as follows

The wrong mapping happens as follows

user1 => address2
user2 => address3
user3 => null
[NOTE: address1 missing and see the wrong mapping]

instead of the correct mapping as

user1=>address1
user2=>address2
user3=>address3

[DDC-1303] Adding casts on EntityGenerator's generated setters could improve the Database hitting

Sun, 11 Mar 2012 20:59:46 +0000

As i mentionned here: https://groups.google.com/d/topic/doctrine-dev/ovDQzb9JM74/discussion

Imagine you have some boolean, like "archived", the code that EntityGenerator generated is like:

MyEntity.php

public function setArchived($archived)
{
   $this->archived = $archived;
}

Now, imagine I use some forms logics to archive the object, I'll pass "1" to setArchived.
Doctrine will hit the database even if the flag is already setted to true because the boolean True is different from "1".

So, I think it would be better if Doctrine generates the following:

MyEntity.php

public function setArchived($archived)
{
   $this->archived = (null === $archived) ? null : (bool)$archived;
}

[DDC-2094] [GH-488] Fix DDC-2079

Sun, 21 Oct 2012 03:19:10 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/488

Message:

http://www.doctrine-project.org/jira/browse/DDC-2079

[DDC-2095] [GH-489] Fixed coding standards in the Tools namespace

Sun, 4 Nov 2012 20:25:15 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/doctrine2/pull/489

Message:

This also fixes some command exit code in case of failure and removes an unused private method

[DDC-2092] [GH-487] Fix DDC-2069

Sun, 21 Oct 2012 03:19:38 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/487

Message:

http://www.doctrine-project.org/jira/browse/DDC-2069

[DDC-2074] ManyToManyPersister not found in the chain configured namespaces

Sun, 25 Nov 2012 20:10:52 +0000

The error is: "The class 'Doctrine\ORM\Persisters\ManyToManyPersister' was not found in the chain configured namespaces"

Replicate by making an entity which has a property which is self referencing; e.g. http://docs.doctrine-project.org/en/latest/reference/association-mapping.html#many-to-many-self-referencing .

For example an Album could be related to any other similar albums. An album entity would have a property 'relatedAlbums' which is an ArrayCollection. Similarly, I could be working on a CMS where any piece of content could be related to any other in order to show a "related content" or "related posts" style list on a web page.

Using Symfony 2.1 and a Symfony Form with FormBuilder make sure to use the 'by_reference' => false to call the setter for the property. In the setter for the property: https://gist.github.com/3879169

A similar question has been asked on StackOverflow: http://stackoverflow.com/questions/12077084/doctrine2-manytomany-self-referencing

[DDC-2033] Merge with multiple Associations to the same Entity

Wed, 23 Jan 2013 22:06:58 +0000

Let's say we have 2 Entities. User and Group and there's a ManyToMany Assocication and an additional ManyToOne (User as owning side and no inverse).

So a User can have as many Groups as he likes and one another with the ManyToOne Association which can be also in the ManyToMany Collection. (Could be the MainGroup or something)

I create a User and add a Group(already in DB) and set the same as the ManyToOne and Merge it. Everything works fine as long as the Group in ManyToOne Association is not in the ManyToMany.

If I var_dump the merged entity i can already see that one association is empty.

It looks like doctrine is writing just one association of that Group preferring which one comes first. So if i change the position of the properties in the class the written association changes, but doctrine never writes both.

The reason why I use merge is that I normally store the entity in the session and merge and flush it in another request. But this also happens in the same Request.

In the UnitofWork at Line 2050 and 2053 are the responsible doMerge Calls for as CascadeMerge Tagged Associations. If Doctrine gets there in the first place the doMerge for the Group is running through. In the Second call when the Group is again associated with the user the doMerge already exits at line 1658. That's ok but I think there's something missing so doctrine isn't creating the association.

The Mentioned Entites are attached

[DDC-1985] Call to undefined method ProxyException::proxyDirectoryNotWritable

Fri, 17 Aug 2012 04:51:01 +0000

I think it's fairly self explanatory, didn't supply a patch since I had no idea what text you wanted there

PHP Fatal error:  Call to undefined method Doctrine\ORM\Proxy\ProxyException::proxyDirectoryNotWritable() in .../orm/lib/Doctrine/ORM/Proxy/ProxyFactory.php on line 193

[DDC-1669] [GH-289] by isanosyan: Preserve camelcase when mapping existing database

Wed, 11 Jul 2012 20:00:15 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/doctrine2/pull/289

Message:

CamelCase is now preserved when importing entities from existing database using Symfony's command

php app/console doctrine:mapping:convert xml ./src/Acme/BlogBundle/Resources/config/doctrine/metadata/orm --from-database --force

[DDC-1656] fetch mode EXTRA_LAZY does not do a IN(1, 2, 3, ...) merge type query to fetch OneToMany results

Fri, 17 Feb 2012 21:26:44 +0000

Using the fetch mode EXTRA_LAZY does not produce a SQL query to fetch all OneToMany relationship results via a IN(1, 2, 3, ...) type merged query, instead it does one query per row in the result set.

First query to obtain all the pages

SELECT t0.page_id AS page_id1, t0.name AS name2, t0.text AS text3, t0.url AS url4, t0.revision_id AS revision_id5, t0.owner_id AS owner_id6, t0.is_active AS is_active7 FROM pages t0

then for each row in that result set

SELECT t0.attribute_id AS attribute_id1, t0.page_id AS page_id2, t0.key AS key3, t0.value AS value4, t0.page_id AS page_id5 FROM page_attributes t0 WHERE t0.page_id = ?

What is desired is a query like this,

SELECT t0.attribute_id AS attribute_id1, t0.page_id AS page_id2, t0.key AS key3, t0.value AS value4, t0.page_id AS page_id5 FROM page_attributes t0 WHERE t0.page_id IN(1, 2, 3, ...)

to obtain all the attributes for the pages, after the first original page query.

[DDC-1650] PHP 5.3.2 compatibility

Wed, 11 Jul 2012 18:00:36 +0000

When triggering travis build under PHP 5.3.2, the build fails.

Fatal error: Class '\Doctrine\Tests\DbalTypes\UpperCaseStringType' not found in /home/vagrant/builds/ooflorent/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Types/Type.php on line 144

Call Stack:

1. {main}() /home/vagrant/.phpenv/versions/5.3.2/bin/phpunit:0
2. PHPUnit_TextUI_Command::main() /home/vagrant/.phpenv/versions/5.3.2/bin/phpunit:46
3. PHPUnit_TextUI_Command->run() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/TextUI/Command.php:130
4. PHPUnit_TextUI_TestRunner->doRun() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/TextUI/Command.php:192
5. PHPUnit_Framework_TestSuite->run() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/TextUI/TestRunner.php:325
6. PHPUnit_Framework_TestSuite->run() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/Framework/TestSuite.php:705
7. PHPUnit_Framework_TestSuite->runTest() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/Framework/TestSuite.php:745
8. PHPUnit_Framework_TestCase->run() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/Framework/TestSuite.php:772
9. PHPUnit_Framework_TestResult->run() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/Framework/TestCase.php:751
10. PHPUnit_Framework_TestCase->runBare() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/Framework/TestResult.php:649
11. Doctrine\Tests\ORM\Functional\TypeValueSqlTest->setUp() /home/vagrant/.phpenv/versions/5.3.2/share/pyrus/.pear/php/PHPUnit/Framework/TestCase.php:801
12. Doctrine\Tests\OrmFunctionalTestCase->setUp() /home/vagrant/builds/ooflorent/doctrine2/tests/Doctrine/Tests/ORM/Functional/TypeValueSqlTest.php:
13. Doctrine\ORM\EntityManager->getClassMetadata() /home/vagrant/builds/ooflorent/doctrine2/tests/Doctrine/Tests/OrmFunctionalTestCase.php:272
14. Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor() /home/vagrant/builds/ooflorent/doctrine2/lib/Doctrine/ORM/EntityManager.php:269
15. Doctrine\ORM\Mapping\ClassMetadataFactory->loadMetadata() /home/vagrant/builds/ooflorent/doctrine2/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:178
16. Doctrine\ORM\Mapping\Driver\AnnotationDriver->loadMetadataForClass() /home/vagrant/builds/ooflorent/doctrine2/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:293
17. Doctrine\ORM\Mapping\ClassMetadataInfo->mapField() /home/vagrant/builds/ooflorent/doctrine2/lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php:327
18. Doctrine\ORM\Mapping\ClassMetadataInfo->_validateAndCompleteFieldMapping() /home/vagrant/builds/ooflorent/doctrine2/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php:1735
19. Doctrine\DBAL\Types\Type::getType() /home/vagrant/builds/ooflorent/doctrine2/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php:1074

[DDC-1626] Refreshing an entity after disabling a filter has no effect

Mon, 30 Jan 2012 15:59:45 +0000

The situation:

I have a Person with a 1-to-1 relation to User, fetch mode is EAGER. The user has a deleted flag, which in this case is set to true. The filter automatically adds a "deleted = 0" to the join query

I wish to fetch the user anyway, so I disable the filter and execute a refresh:

$em->getFilters()->disable('soft_delete');
$em->refresh($person);

Unfortunately, this doesn't work as the left join part of the query is saved line 971 through 973 in BasicEntityPersister:

if ($this->_selectColumnListSql !== null) {
return $this->_selectColumnListSql;
}

if I remove these lines, everything works fine...

[DDC-1625] proxy initialized when accessing identifier on extending class

Sun, 5 Feb 2012 10:46:05 +0000

The proxy is always initialized when the entity is extending another class and that parent class has get<IDENTIFIER> method

[DDC-1591] Paginator: ResultVariable cannot be used in HavingClause

Thu, 15 Mar 2012 22:22:50 +0000

Using the QueryBuilder, I'm getting the message

Notice: Undefined index: distance in vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php line 2128

when trying to add a "having" clause for the field "distance", which is defined in the "select" part of the statement:

$queryBuilder
    ->select('myEntity, MY_FUNCTION() AS distance')
    ->having('distance <= 10')
;

[DDC-1948] Lazy Loading on Many To One association does not work

Thu, 21 Feb 2013 10:18:27 +0000

Create a many to one relationship with lazy loading as exposed there :
http://stackoverflow.com/questions/7599007/lazy-loading-properties-not-loading-in-doctrine-2-0

Notice that the relationship does not load while it should.

The problem is always reproducible.

[DDC-1936] [GH-404] DDC-1933 - Fixing cloning of QueryBuilder and adding related tests

Mon, 23 Jul 2012 08:35:25 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/404

Message:

This PR fixes ~~DDC-1933~~ and mimics the behaviour of `Doctrine\ORM\AbstractQuery` in `Doctrine\ORM\QueryBuilder` when dealing with assigned parameters and `__clone`.

[DDC-1930] [GH-401] Add Doctrine\Tests in composer autoload

Tue, 17 Jul 2012 09:10:45 +0000

This issue is created automatically through a Github pull request on behalf of cedriclombardot:

Url: https://github.com/doctrine/doctrine2/pull/401

Message:

[DDC-1933] Problem with parameters when clone Doctrine\ORM\QueryBuilder

Mon, 23 Jul 2012 08:36:42 +0000

Hi, here problem with cloning \Doctrine\ORM\QueryBuilder

Example

$queryBuilder = new QueryBuilder($em);

$queryBuilder->setParameter('parameter1', 'value1');

$copy = clone $queryBuilder;
$copy->setParameter('parameter2', 'value2');


count($queryBuilder->getParameters()) // equals 2
//expects 1

Solution:

QueryBuilder

public function __clone
{
   ......

   $this->parameters = clone $this->parameters;
}

[DDC-1929] [GH-400] Changed commands to use command.name in the help

Mon, 23 Jul 2012 08:33:41 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/doctrine2/pull/400

Message:

The current code does not work for child classes: it gets the name too early as the child has not changed it yet at this point. using ``%command;name%`` replaces it only when the help needs to be displayed.

[DDC-1922] [GH-399] Fix phpdocs

Wed, 11 Jul 2012 23:43:27 +0000

This issue is created automatically through a Github pull request on behalf of Adel-E:

Url: https://github.com/doctrine/doctrine2/pull/399

Message:

[DDC-1919] Doctrine fails to escape entity with reserved name in various situations

Thu, 19 Jul 2012 18:27:21 +0000

I have submitted a PR here, fixing part of this issue: https://github.com/doctrine/dbal/pull/166

However, it fails when UPDATE or INSERT is used. I'm using a very simple, and common, entity name: Group. Doctrine is failing to escape this in various situations, causing queries to fail in MySQL due to reserved keywords.

[DDC-1915] [GH-396] DDC-1893 - Updating configuration to reflect latest Doctrine Common changes

Wed, 11 Jul 2012 23:54:17 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/396

Message:

This PR fixes ~~DDC-1893~~ (http://www.doctrine-project.org/jira/browse/DDC-1893).

The `getDefaultAnnotationDriver` method was changes to stop supporting older incompatible Doctrine Common versions in favour of the newer logic.

Also, changing logic so that the SimpleAnnotationReader is no more the
default one. An additional parameter for the method will allow using it (this is a BC break!)

The CS fixes that were additionally implemented (along with other minor changes
that do not affect BC compatibility are caused by a CS sniff via IDE.

[DDC-1900] Impossibility to override built-in SQL functions

Thu, 5 Jul 2012 19:57:12 +0000

Doctrine doesn't allow to to create own SQL function for DQL if that function is already defined as "built-in". An example could be custom DATE_ADD implementation.
Method FunctionDeclaration() in Doctrine\ORM\Query\Parser gives higher priority to built-in SQL functions, even if they are not
usable for a specific situation, and registering of own datetime function doesn't help. This issue makes it impossible to use some advanced Doctrine extensions,
for example https://github.com/beberlei/DoctrineExtensions that provide fuller implementations.
Considering the fact that someone may want to use ready components provided by the community, and being new to Doctrine can't figure out the way to hack
or workaround this, the issue is a major one.

[DDC-1886] [GH-381] [WIP] [DDC-1637] Collection Filtering API

Wed, 11 Jul 2012 19:57:21 +0000

This issue is created automatically through a Github pull request on behalf of beberlei:

Url: https://github.com/doctrine/doctrine2/pull/381

Message:

This Pull Request implements the new Collection Filtering/Criteria API inside the PErsisters.

Its still heavily WIP and the code is not cleaned up yet. In general i am not yet happy about the problems to get from criteria to SQL, and that is also to complex to use completely internally.

Todo:
1. More tests for Repository impl.
2. Add PersistentCollection impl.
3. Cleanup

[DDC-1843] CLONE -Join columns can't be quoted

Wed, 15 Aug 2012 00:17:24 +0000

Join columns can't be quoted like columns using name="`quoted`". Using annotation driver.

/**
 * @ORM\Table(
 *      name="`category`",
 *      indexes={
 *          @ORM\Index(
 *              name="fk_category_parentId",
 *              columns={"parentId"}
 *          )
 *      },
 *      uniqueConstraints={
 *          @ORM\UniqueConstraint(
 *              name="uq_category_nameParentId",
 *              columns={"name", "parentId"}
 *          )
 *      }
 * )
 */
class Category
{
    /**
     * @ORM\Id
     * @ORM\Column(type="smallint", name="`id`")
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /**
     * @ORM\Column(type="smallint", name="`parentId`", nullable=true)
     */
    protected $parentId;

    /**
     * @ORM\Column(type="string", length=50, name="`name`")
     */
    protected $name;

    /**
     * @ORM\ManyToOne(targetEntity="Category", inversedBy="categories")
     * @ORM\JoinColumn(name="parentId", referencedColumnName="id", onDelete="CASCADE", onUpdate="NO ACTION")
     */
    protected $category;
}

... 


public function load(ObjectManager $manager)
    {
        $parent = new Category();
        $parent->setName('parent');
        $manager->persist($parent);
        $manager->flush();

        $child = new Category();
        $child->setName('parent');
        $child->setParentId($parent->getId());
        $child->setCategory($parent);

        $manager->persist($child);
        $manager->flush();
}

Result: Invalid parameter number: number of bound variables does not match number of tokens

[DDC-1818] ResultSetMapping::addJoinedEntityResult does not work

Tue, 17 Jul 2012 18:25:13 +0000

I'm trying to fetch the data for oneToMany relation, but it failed:

Notice: Undefined index: SomeCompany\SomeBundle\Entity\SomeJoinedEntity in ..../symfony/vendor/doctrine/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php line 382

While trying to debug the issue I came to the conclusion that if I use the FQDN entity name it works, but if using SomeBundle:SomeJoinedEntity does not. I also checked the unit tests and I wasn't able to find which test this behavior - they all use the FQDN and not the short name of the entity.

I wasn't sure whether this should be a Symfony 2.0.13 issue or a Doctrine2 one, but in the end I've the intention that it has to be posted here.

[DDC-1805] [GH-343] Lets make correct data structure

Fri, 4 May 2012 17:54:00 +0000

This issue is created automatically through a Github pull request on behalf of rivaros:

Url: https://github.com/doctrine/doctrine2/pull/343

Message:

Dear all,

As you know Doctine2 supports explicit quoting of identifiers.

This is extremely useful for PostgreSQL where "TableName" and TableName(implicit lowercased) are 2 different things. That's why - please, do support explicit quoting with ` (back-ticks) in future.

Now a problem - you do not support quoting columns which are part of associations. Can you give me a reasonable answer why it should not be supported?

Now comes my first update - i think that keeping "quoted" property inside the fieldMapping array is globally wrong. "Quoted" is a property, related to a column, not field. For example, an association can consist of 2 joined columns, and 1 of them can be quoted (theoretically).

That's why a better choice to store "Quoted/Nonquoted" properties in ClassMetadata level. I made an array quotedColumns for this and rewrote the function getQuotedColumnName to use it.

If you have time for short dispute, I may have a solution to make explicit quoting supported in join columns.

See related thread here:
http://www.doctrine-project.org/jira/browse/DDC-142

Last comment was
"After some discussion support for quoting join column names and discriminator column names has been dropped for the sake of simplicity.
Quoting table names and regular column names will continue to be supported.
The docs have been updated accordingly."

I can argue on this - my solution is even more simple.

[DDC-1797] [GH-341] Added fluent interface to persist

Fri, 4 May 2012 17:57:55 +0000

This issue is created automatically through a Github pull request on behalf of fixe:

Url: https://github.com/doctrine/doctrine2/pull/341

Message:

[DDC-1788] [GH-338] EntityGenerator will typehint core fields where applicable (DateTime)

Fri, 4 May 2012 17:56:55 +0000

This issue is created automatically through a Github pull request on behalf of benlumley:

Url: https://github.com/doctrine/doctrine2/pull/338

Message:

As per other PR (on dbal) - EntityGenerator doesn't currently do this. This PR adds it.

It requires the matching PR on dbal as well for the mapping info.

https://github.com/doctrine/dbal/pull/135

[DDC-1780] Function createEntity does't support DateTime identifier

Sat, 7 Jul 2012 14:31:56 +0000

When I try to get data (as objects, function getResult()) from a table with two indexes (1.Integer, 2.DateTime), Doctrine returns duplicate objects to the first index.
This bug is present only in the function getResult(), getArrayResult work correctly.
The bug is in file UnitOfWork.php, line 2323-2329.

$idHash = implode(' ', $id);

This code does not take into account that identifer may be DateTime object.

[DDC-1773] GRUOP BY table.id in PostgreSQL.

Sun, 22 Apr 2012 15:41:53 +0000

I use in mysql driver this DQL: "GRUOP BY table.id"
But when i shwich to PostgreSQL i have to rewrite it like this: "GRUOP BY table"

[DDC-1749] [GH-318] [WIP] Adding Multiple ID Generators support

Fri, 4 May 2012 18:05:32 +0000

This issue is created automatically through a Github pull request on behalf of guilhermeblanco:

Url: https://github.com/doctrine/doctrine2/pull/318

Message:

[DDC-2278] Invalid arguments to PreFlushEventArgs class

Tue, 5 Feb 2013 08:14:33 +0000

Here https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/UnitOfWork.php#L527 PreFlushEventArgs expects number of arguments to be 2 and the first argument have to be instance of entity manager. But two arguments are passed and the first one is not instanceof em.

[DDC-2259] [GH-557] [DDC 2004] addFilter class name or instance

Sat, 26 Jan 2013 15:57:01 +0000

This issue is created automatically through a Github pull request on behalf of gimler:

Url: https://github.com/doctrine/doctrine2/pull/557

Message:

Make it possible to add filter class name or instance to addFilter. This is useful to use services to inject other dependencies.

[DDC-2255] [Doctrine-Bridge][Console] Entity, Getters and Setters Generating Bug detected in Symfony 2 Framework

Thu, 24 Jan 2013 13:24:22 +0000

Bug found when generation the Entity, Getters and Setters by using the Command:

> php app/console doctrine:generate:entities YourBundleBundle:YourEntity

In the situation you have a OneToMany relation in the Entity and you did implement the __construct(), then the Console Wont generate the ArrayCollection() !
In the case you did not implement the __construct(), then everything will goes fine when generating them,
Example:

/**
 * @ORM\OneToMany(targetEntity=" YourBundleBundle \Entity\ YourEntity ", mappedBy=" YourEntity ")
 */
private $YourAttribut;

public function __construct()
{
  $this-> YourAttribut = new \Doctrine\Common\Collections\ArrayCollection();
} 
// But in the case you did implement the __construct() before using the Command, let say like this:

public function __construct()
{
  $this-> YourOtherAttribut = a_value;
}

In this case, when using the Command to generate Entity, Getters and Setters, the Console Wont generate the ArrayCollection() of the OneToMany relations in the __construct() !

[DDC-2242] [GH-550] Update lib/Doctrine/ORM/UnitOfWork.php

Tue, 15 Jan 2013 09:21:48 +0000

This issue is created automatically through a Github pull request on behalf of cedriclombardot:

Url: https://github.com/doctrine/doctrine2/pull/550

Message:

When the pk contains a DateTime object doctrine fail to create the index, because implode call __toString wich doesn't exists in \DateTime object

[DDC-2244] One-To-Many Cascade saving not working properly

Tue, 15 Jan 2013 16:46:25 +0000

I have the following code:

$new = new InterviewReview();

$question = new InterviewReviewQuestion();
$new->addQuestion($question);

$em->persist($new);
$em->flush();

When i execute this code i have the following error:

An exception occurred while executing 'INSERT INTO interview_review_question (question, tags, created_at, interview_review_id) VALUES (?, ?, ?, ?)' with params {"1":"asdfg","2":"asdfg","3":null,"4":null}:

Column 'interview_review_id' cannot be null

Here are my entities:

/**
 * InterviewReview
 *
 * @ORM\Table(name="interview_review")
 * @ORM\Entity
 */
class InterviewReview
{
    /**
     * @var integer
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @var Doctrine\Common\Collections\ArrayCollection
     *
     * @ORM\OneToMany(targetEntity="Absolvent\AbsolventBundle\Entity\InterviewReviewQuestion", cascade={"persist", "remove"}, mappedBy="interview_review")
     * @ORM\JoinColumn(name="interview_review", referencedColumnName="id")
     */
    private $questions;

    /**
     * Add question
     *
     * @param \Absolvent\AbsolventBundle\Entity\InterviewReviewQuestion $question
     * @return InterviewReview
     */
    public function addQuestion(\Absolvent\AbsolventBundle\Entity\InterviewReviewQuestion $question)
    {
        $this->questions[] = $question;

        return $this;
    }

    /**
     * Remove question
     *
     * @param \Absolvent\AbsolventBundle\Entity\InterviewReviewQuestion $question
     */
    public function removeQuestion(\Absolvent\AbsolventBundle\Entity\InterviewReviewQuestion $question)
    {
        $this->questions->removeElement($question);
    }

    /**
     * Get questions
     *
     * @return \Doctrine\Common\Collections\Collection
     */
    public function getQuestions()
    {
        return $this->questions;
    }
}


/**
 * InterviewReviewQuestion
 *
 * @ORM\Table(name="interview_review_question")
 * @ORM\Entity
 */
class InterviewReviewQuestion
{
    /**
     * @var integer
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @var Absolvent\AbsolventBundle\Entity\InterviewReview
     *
     * @ORM\ManyToOne(targetEntity="Absolvent\AbsolventBundle\Entity\InterviewReview", cascade={"persist", "remove"}, inversedBy="questions")
     * @ORM\JoinColumn(name="interview_review_id", referencedColumnName="id", nullable=false)
     */
    private $interview_review;

    /**
     * Get id
     *
     * @return integer
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * Set interview_review
     *
     * @param \Absolvent\AbsolventBundle\Entity\InterviewReview $interviewReview
     * @return InterviewReviewQuestion
     */
    public function setInterviewReview(\Absolvent\AbsolventBundle\Entity\InterviewReview $interviewReview = null)
    {
        $this->interview_review = $interviewReview;

        return $this;
    }

    /**
     * Get interview_review
     *
     * @return \Absolvent\AbsolventBundle\Entity\InterviewReview
     */
    public function getInterviewReview()
    {
        return $this->interview_review;
    }
}

This problem is causing because the is no $question->setInterviewReview() called anywhere.

I know that i can call it inside addQuestion function, but is should work out of the box - isn't it?

[DDC-2177] WHERE IN not working

Thu, 29 Nov 2012 14:08:43 +0000

I'm going by the docs, trying to get a WHERE IN type of query working with the query builder.

I've got a flat array of IDs, e.g. something like this:

$IDs = array( 228052, 265635, 344498, 391761, 329203, 317911, 305961, 299939, 249429, 344706 );

I've tried the following ways to get this working:

using the Expr class:

$qb->add( 'where', $qb->expr()->in( 'c.id', ':IDs' ));
$qb->setParameter( 'IDs', $IDs );

alternatively:

$qb->add( 'where', $qb->expr()->in( 'c.id', $IDs ));

even direct DQL:

$qb->where( 'c.id IN (:IDs)' );
$qb->setParameter( 'IDs', $IDs );

The generated DQL looks fine:

SELECT c FROM MyEntity c WHERE c.id IN('228052', '265635', '344498', '391761', '329203', '317911', '305961', '299939', '249429', '344706')

But when I call execute() on that query, all these variations give me the following error:

Expected argument of type "Doctrine\ORM\QueryBuilder", "array" given

[DDC-2163] Export entity data to array and create new entity by this array

Tue, 27 Nov 2012 07:00:44 +0000

Entity serialization is really pain operation for doctrine2 entities, but why we need serialization? If we may just get array of table's row for entity and store this array anywhere!

For example, we have Entity:

id, category_id, title

(where category_id is many to one to Category entity)

If we will able to get just array from entity like
array(
'id' => 1,
'category_id' => 2,
'title' => 'Some title'
)
That's all!

I look at code and find a place where table row converted to object: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php#L341

This method is protected, so we can't call it directly. Can we change it to public?

Another question how we can get this raw values array from entity. I found method https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/UnitOfWork.php#L2692 but it return data with related entities.

[DDC-1724] [GH-308] Fix DDC-1697

Sun, 25 Mar 2012 13:24:02 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/308

Message:

[DDC-1711] [GH-306] by r1pp3rj4ck: Fixed fetch mapping in xsd

Sun, 18 Mar 2012 22:02:38 +0000

This issue is created automatically through a Github pull request on behalf of r1pp3rj4ck:

Url: https://github.com/doctrine/doctrine2/pull/306

Message:

It was 'EXTRALAZY' and the constant name in ClassMetadata is 'EXTRA_LAZY'.

It's really annoying that my IDE says it's a wrong attribute.

[DDC-267] CLI does only show last error message and ignores stacked exceptions

Mon, 14 Jun 2010 09:17:34 +0000

If exceptions are stacked, only the last message is shown. The attached patch fixes this.

[DDC-269] CLI throws Exception that table already exists if --dump-sql specified

Dependency — Mon, 25 Jan 2010 13:49:54 +0000

If I execute

./doctrine orm:schema-tool --create --trace --dump-sql

I recieve an Exception stating that one of the tables already exists, but I only want to dump the SQL and not have it executed (in which case this exception would be okay)

[DDC-258] DiscriminatorMap Ordering Affects Mapping

Fri, 5 Mar 2010 11:37:42 +0000

In an inheritance tree, I have a super class with three subclasses. Two of the subclasses have a 'title' and 'description' field, but one of those has an extra field. The third class doesn't share any properties, but demonstrates the reasoning for not having 'title' and 'description' in the super class.

So, the problem I'm getting is that only one of these classes can work at a time, depending on which is first in the DiscriminatorMap. The SQL query performs left joins on all of the tables and uses aliases to keep the common fields separated. The mapper doesn't seem to be using the aliases when it maps the properties to the object. It seems override properties even if they aren't in the correct table.

Example:

/**
 * @Entity
 * @Table(name="Content")
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="type", type="string")
 * @DiscriminatorMap({"class1" = "Class1", "class2" = "Class2", "class3"="Class3"})
 */
abstract class Super
{
    /**
     * @Id @Column(name="id", type="integer")
     * @GeneratedValue(strategy="AUTO")
    */
    protected $id;
}

/**
 * @Entity
 */
class Class1 extends Super
{
    /**
     * @Column(name="title", type="string", length="150")
     */
    protected $title;

    /**
     * @Column(name="content", type="string", length="500")
     */
    protected $description;
}

/**
 * @Entity
 */
class Class2 extends Super
{
    /**
     * @Column(name="title", type="string", length="150")
     */
    protected $title;

    /**
     * @Column(name="content", type="string", length="500")
     */
    protected $description;

    /**
     * @Column(name="text", type="text")
     */
    protected $text;
}

/**
 * An extra class to demonstrate why title and description aren't in Super
 *
 * @Entity
 */
class Class3 extends Super
{
    /**
     * @Column(name="title", type="string", length="150")
     */
    protected $apples;

    /**
     * @Column(name="content", type="string", length="500")
     */
    protected $bananas;
}

The select for a Super of id 2 uses the following query (or similar):

SELECT t0.id, t0.type, t1.title, t1.description, t2.title, t2.description, t2.text, t3.apples, t3.bananas 
FROM Super t0 
LEFT JOIN Class1 t1 ON t0.id = t1.id 
LEFT JOIN Class2 t2 ON t0.id = t2.id 
LEFT JOIN Class3 t3 ON t0.id = t3.id 
WHERE t0.id = 2;

Now, if the DiscriminatorMap is reordered, the joins change order as well, which seems to affect which fields actually get mapped to the object.

[DDC-260] Add additional info to ReflectionException in ClassMetadata

Thu, 21 Jan 2010 19:52:59 +0000

I was thinking about adding an additional exception to the ClassMetadata class. For example when using reflection for recieving an attribute and an exception is raised (for example because the attribute does not exist), the debug information could be improved. I thought one could catch the ReflectionException and throw a DoctrineReflectionException or something like that and add some additional information like what the name of the currently processed class is

[DDC-256] AnnotationExporter does not support inheritanceType

Mon, 8 Mar 2010 22:03:52 +0000

The inheritanceType was simply forgotten when exporting. The attached file does add this functionality!

[DDC-254] Improved MappingException class & usage of these in ManyToManyMapping

Thu, 14 Jan 2010 15:49:10 +0000

I added a new Exception method and changed the way its used in the Many2Many class.

[DDC-251] ArrayCollection::__construct() must be an array, object given

Mon, 18 Jan 2010 19:12:17 +0000

Running index.php in the Doctrine2 sandbox results in a fatal error:
PHP Catchable fatal error: Argument 1 passed to Doctrine\Common\Collections\ArrayCollection::__construct() must be an array, object given, called in /home/bjori/doctrine2/lib/Doctrine/ORM/UnitOfWork.php on line 468 and defined in /home/bjori/doctrine2/lib/Doctrine/Common/Collections/ArrayCollection.php on line 53

Unsure what exactly is going on, but this is the smallest reproduce case I have managed to create.

[DDC-249] QueryBuilder documentation states that select() takes an array, but expects strings

Thu, 14 Jan 2010 16:16:55 +0000

If you try to execute something like

$qb->select(array('u', 'a'))
->from('Entities\User', 'u')
->leftJoin('Entities\Address', 'a')
->where('u.age = 23');

which should be correct if one takes a look at the third example here: http://www.doctrine-project.org/documentation/manual/2_0/en/query-builder#the-querybuilder:working-with-querybuilder:helper-methods

then one will recieve an exception to be thrown, because the ORM\QueryBuilder::select() method makes an internal call for get_func_args() and therefore will pass an array within an array to the ORM\Query\Base class.

In fact, I propose to change the internal of the select() method and check whether an array has been passed and if yes, do not call get_func_args().

By the way, I think that arrays should be supported because it's much easier to dynamically pass an array as an argument than several strings.

Regards
Christian

[DDC-248] Exception is thrown during deserialization of the class 'ClassMetadata' if it contains child type

Fri, 15 Jan 2010 13:34:42 +0000

I have a class hierarchy:
resource (id, type, name)

---> module ()

---> controller (ref to module)
---> action (ref to controller)
It is mapped with inheritamce type = "JOINED"
During the class ClassMetadata deserialization exception belows is thrown:

ReflectionException: Property id does not exist in E:\Projects\portal\library\Doctrine\ORM\Mapping\ClassMetadata.php on line 362

Call Stack:
0.0003 334120 1.

{main}

() E:\Projects\DoctrineTest\index.php:0
0.0291 2124544 2. Doctrine\ORM\EntityManager->find() E:\Projects\DoctrineTest\index.php:24
0.0291 2124544 3. Doctrine\ORM\EntityManager->getRepository() E:\Projects\portal\library\Doctrine\ORM\EntityManager.php:308
0.0291 2124544 4. Doctrine\ORM\EntityManager->getClassMetadata() E:\Projects\portal\library\Doctrine\ORM\EntityManager.php:489
0.0291 2124544 5. Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor() E:\Projects\portal\library\Doctrine\ORM\EntityManager.php:220
0.0291 2124608 6. Doctrine\Common\Cache\AbstractCache->fetch() E:\Projects\portal\library\Doctrine\ORM\Mapping\ClassMetadataFactory.php:133
0.0292 2124608 7. CacheDriver->_doFetch() E:\Projects\portal\library\Doctrine\Common\Cache\AbstractCache.php:89
0.0292 2124608 8. CacheDriver->init() E:\Projects\DoctrineTest\CacheDriver.php:61
0.0293 2127872 9. unserialize() E:\Projects\DoctrineTest\CacheDriver.php:49
0.0336 2609432 10. Doctrine\ORM\Mapping\ClassMetadata->__wakeup() E:\Projects\portal\library\Doctrine\ORM\Mapping\ClassMetadata.php:0
0.0340 2633128 11. ReflectionClass->getProperty() E:\Projects\portal\library\Doctrine\ORM\Mapping\ClassMetadata.php:362
I have attached file with sample code.. I hope it will be helpful

[DDC-243] XML many-to-many mapping broken and xsd incomplete

Wed, 6 Jan 2010 17:21:04 +0000

There is a typo in XML driver - element should be named mapped-by, not mappedBy http://trac.doctrine-project.org/browser/trunk/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php?rev=7007#L319
mapped-by attribute is missing in XSD definition of many-to-many element

[DDC-238] PersistentCollection is not initialized when toArray() is called

Duplicate — Tue, 5 Jan 2010 11:46:08 +0000

When receiving entities from the database, collections are received as PersistentCollection objects.

A PersistentCollectionmay not be initialized (i.e. its elements are not loaded), this is done via "_initialize()" when the elements are accessed for the first time (i.e. forAll() or the corresponding "foreach" call).

However when toArray() is called, the _initialize() call is missing, so the method may return an empty array even if the collection has elements.

Shouldn't PersistentCollection::toArray() look like this?

    public function toArray()
    {
        $this->_initialize();
        return $this->_coll->toArray();
    }

[DDC-242] CLONE - XML Mapping XSD file misses description of element

Wed, 6 Jan 2010 17:20:47 +0000

still not fixed - missing many-to-one in sequence of entity element http://trac.doctrine-project.org/browser/trunk/doctrine-mapping.xsd?rev=6969#L60

XML Mapping XSD file misses description of <many-to-one> element

[DDC-237] Proxies are not initialized during hydration of a fetch-joined assocation.

Tue, 5 Jan 2010 11:46:48 +0000

Proxies are not initialized during hydration of a fetch-joined assocation when the proxy already existed in the identity map (in an uninitialized state).

Ref: http://groups.google.com/group/doctrine-user/browse_thread/thread/ecd5d86580ed3497/022f2b7da2b9b7ff

[DDC-240] PATCH: StandardEntityPersister->delete should use column names instead of field names

Tue, 5 Jan 2010 17:08:37 +0000

PATCH: StandardEntityPersister->delete should use column names instead of field names

[DDC-236] uniqueConstraints annotation is not consistant with indexes annotation

Wed, 6 Jan 2010 13:25:03 +0000

It is not possible to name an unique constraint like we would do for an index.

If you look at ORM/Mapping/Driver/AnnotationDriver:99 in trunk, you will see that improvement done for index have not been ported to uniqueConstraints.

 if ($tableAnnot->indexes !== null) {
                foreach ($tableAnnot->indexes as $indexAnnot) {
                    $primaryTable['indexes'][$indexAnnot->name] = array('columns' => $indexAnnot->columns);
                }
            }
            
            if ($tableAnnot->uniqueConstraints !== null) {
                foreach ($tableAnnot->uniqueConstraints as $uniqueConstraint) {
                    $primaryTable['uniqueConstraints'][] = $uniqueConstraint->columns;
                }
            }

[DDC-234] CLONE -createQueryBuilder does not insert alias into "from" part

Wed, 6 Jan 2010 11:39:02 +0000

When using createQueryBuilder() the dql created throws an error when executed:

Error: Expected Doctrine\ORM\Query\Lexer::T_IDENTIFIER, got 'LEFT'

The dql created is missing the alias after "from".

[DDC-223] Alternative for $globalArguments after CLI refactoring

Mon, 14 Jun 2010 09:17:45 +0000

The previous $globalArguments functionality from the CLI is now missing.

There needs to be an alternative, unless it is intended to drop this functionality entirely.

[DDC-224] CLI examples are incorrect

Wed, 23 Dec 2009 15:59:02 +0000

In the PDF documentation page 10 item 1 of the Mini tutorial it says to run php doctrine schema-tool --create but that gives an error task 'schema tool' doesn't exist in 'Core'. What seems to work is php doctrine orm:schema-tool --create

[DDC-216] PersistentCollection#toArray() should call _initialize()

Duplicate — Tue, 5 Jan 2010 11:45:59 +0000

Calling toArray on a PersistentCollection does not initialize the collection. This means that a not yet initialized collection returns an empty array. This is not expected behavior. The user expects the collection to be initialized and the objects returned. Calling count first is a workaround to initialize the array because count calls _initialize.

A use case is an accessor wanting to return an array to not expose the collection to modification.

[DDC-215] not null is not working using YAML

Sat, 19 Dec 2009 13:52:59 +0000

I've created this:

Test:
type: entity
table: test
fields:
id:
type: integer
id: true
generator:
strategy: auto
sequenceGenerator:
sequenceName: test_id_seq
allocationSize: 1
initialValue: 1
nome:
type: string
length: 300
sigla:
type: string
length: 5
notnull: false

result:
CREATE TABLE test (id INT NOT NULL, nome TEXT NOT NULL, sigla VARCHAR(5) DEFAULT NOT NULL, PRIMARY KEY(id))
CREATE SEQUENCE test_id_seq INCREMENT BY 1 START 1

I debuged doctrine's code and saw in the
lib/Doctrine/ORM/Tools/SchemaTool.php on _gatherColumn method
that is tested
$column['notnull'] = isset($mapping['nullable']) ? ! $mapping['nullable'] : true;
on line 266

but in lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php there's not any check for 'nullable', just 'notnull'...
on line 193 there's this validation:
if (isset($fieldMapping['notnull'])) {;
$mapping['notnull'] = $fieldMapping['notnull'];
}

if I insert this validation:
if (isset($fieldMapping['nullable'])) {;
$mapping['nullable'] = $fieldMapping['nullable'];
}

it's gonna work just fine...

[DDC-211] Exception is thrown after many calls to flush()

Tue, 15 Dec 2009 18:41:55 +0000

Two classes having a many-to-many association:

namespace Entity;

/**
 * @Entity
 * @Table(name="user")
*/
class User
{
    /**
     * @Id
     * @Column(name="id", type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /**
     * @Column(name="name", type="string")
     */
    protected $name;

    /**
    * @ManyToMany(targetEntity="Group")
    *   @JoinTable(name="user_groups",
    *       joinColumns={@JoinColumn(name="user_id", referencedColumnName="id")},
    *       inverseJoinColumns={@JoinColumn(name="group_id", referencedColumnName="id")}
    *   )
    */
    protected $groups;

    public function __construct() {
        $this->groups = new \Doctrine\Common\Collections\ArrayCollection();
    }

    public function setName($name) { $this->name = $name; }

    public function getGroups() { return $this->groups; }
}

namespace Entity;

/**
 * @Entity
 * @Table(name="groups")
 */
class Group
{
    /**
     * @Id
     * @Column(name="id", type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /**
     * @Column(name="name", type="string")
     */
    protected $name;

    /**
    * @ManyToMany(targetEntity="User", mappedBy="groups")
    */
    protected $users;

    public function __construct() {
        $this->users = new \Doctrine\Common\Collections\ArrayCollection();
    }

    public function setName($name) { $this->name = $name; }

    public function getUsers() { return $this->users; }
}

Fill the database with some data:

$em = EntityManager::create($connectionOptions, $config);

$user = new \Entity\User();
$user->setName('John Doe');

$em->persist($user);
$em->flush();

$groupNames = array('group 1', 'group 2', 'group 3', 'group 4');
foreach ($groupNames as $name) {

    $group = new \Entity\Group();
    $group->setName($name);
    $em->persist($group);
    $em->flush();

    if (!$user->getGroups()->contains($group)) {
        $user->getGroups()->add($group);
        $group->getUsers()->add($user);
        $em->flush();
    }
}

After the user was added to the third group, an exception is thrown:

PHP Fatal error:  Uncaught exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1-1' for key 'PRIMARY'' in /lib/Doctrine/DBAL/Connection.php:623
Stack trace:
#0 /lib/Doctrine/DBAL/Connection.php(623): PDOStatement->execute(Array)
#1 /lib/Doctrine/ORM/Persisters/AbstractCollectionPersister.php(121): Doctrine\DBAL\Connection->executeUpdate('INSERT INTO use...', Array)
#2 /lib/Doctrine/ORM/Persisters/AbstractCollectionPersister.php(101): Doctrine\ORM\Persisters\AbstractCollectionPersister->insertRows(Object(Doctrine\ORM\PersistentCollection))
#3 /lib/Doctrine/ORM/UnitOfWork.php(306): Doctrine\ORM\Persisters\AbstractCollectionPersister->update(Object(Doctrine\ORM\PersistentCollection))
#4 /lib/Doctrine/ORM/EntityManager.php(288): Doctrine\ORM\UnitOfWork->commit()
#5 [...] in /lib/Doctrine/DBAL/Connection.php on line 623

Using the EchoSqlLogger a strange SQL statement becomes visible (after the user was added to "group 3"):

INSERT INTO groups (name) VALUES (?)
array(1) {
  [1]=>
  string(7) "group 4"
}
DELETE FROM user_groups WHERE user_id = ? AND group_id = ?
array(2) {
  [0]=>
  int(1)
  [1]=>
  int(3)
}
INSERT INTO user_groups (user_id, group_id) VALUES (?, ?)
array(2) {
  [0]=>
  int(1)
  [1]=>
  int(1)
}

Where does the delete statement come from? There is none of that in the code.

Interestingly the example works fine if the user is just added to three groups. If flush() is just called once at the end of the script, everything is fine too.

Many calls to flush() are expected to slow down execution time and/or increase memory consumption, but should work properly.

[DDC-207] XML Mapping XSD file misses description of element

Sat, 19 Dec 2009 14:06:30 +0000

XML Mapping XSD file misses description of <many-to-one> element

[DDC-208] AbstractQuery::getSingleResult() should throw exception if no row is found

Fri, 18 Dec 2009 13:20:29 +0000

AbstractQuery::getSingleResult() should throw exception if no row is found.

This is also what JPA does, it throws a NoResultException, so we should add a Doctrine\ORM\NoResultException for this.

[DDC-203] Detached entities are recognized as new ones

Reference — Tue, 6 Jul 2010 06:03:30 +0000

From
http://www.doctrine-project.org/documentation/manual/2_0/en/working-with-objects
on using persist() on an entity X:

If X is a detached entity, an InvalidArgumentException will be thrown.

So I do this:
$picard = $this->_getUser('Picard');
$this->_em->persist($picard);
$this->_em->flush();
$this->_em->detach($picard);
$this->_em->persist($picard);
$this->_howMany("Picard", 1);
Result:
1) NakedPhp\Storage\DoctrineTest::testSavesUpdatedEntities
There are 2 instances of Picard saved instead of 1.
Failed asserting that <string:2> matches expected <integer:1>.
The entity is recognized as new instead of detached, so no error is thrown and it is duplicated in the database.

[DDC-202] Left Joining on an empty previous join results spl_object_hash warning

Wed, 9 Dec 2009 13:51:26 +0000

I've marked this as minor because it does not seem to affect anything, other than raising a PHP warning, but that in itself suggests something is amiss somewhere.

When joining twice (or more), all the joins must return some rows, else the warning:

 
Warning: spl_object_hash() expects parameter 1 to be object, array given in... /etc/etc/.../ObjectHydrator.php line 269

is raised.

In my particular example, I am simulating a ManyToMany relationship via a join table, so have relations set up either side as OneToMany and ManyToOne. In order to retrieve the "many" records, I need to first join the link table, then join the records that the link table specifies.

If the link table join returns some rows then everything passes without incident, however if the link join returns no rows, then the above warning is raised.

[DDC-198] createQueryBuilder does not insert alias into "from" part

Tue, 8 Dec 2009 18:02:34 +0000

When using createQueryBuilder() the dql created throws an error when executed:

Error: Expected Doctrine\ORM\Query\Lexer::T_IDENTIFIER, got 'LEFT'

The dql created is missing the alias after "from".

[DDC-189] Implement SqlWalker::walkSingleValuedAssociationPathExpression()

Reference — Mon, 22 Feb 2010 06:36:28 +0000

Doctrine\ORM\Query\SqlWalker::walkSingleValuedAssociationPathExpression() needs to be implemented.

This function is not found when trying to execute a query which references relations.

[DDC-186] addIndex is borken in trunk since this morning update

Mon, 14 Jun 2010 09:17:45 +0000

Warning: Illegal offset type in isset or empty in /home/eric/Zend/workspaces/DefaultWorkspace7/fna/lib/Doctrine/DBAL/Schema/Table.php on line 183

Call Stack:
    0.0003     328176   1. {main}() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/application/scripts/tool.php:0
    0.0046     708968   2. Kronos\Common\ToolRunner->run() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/application/scripts/tool.php:31
    0.0094     990020   3. Kronos\Common\Tool->run() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/lib/Kronos/Common/ToolRunner.php:92
    0.0094     990020   4. Kronos\FNA\Tool\CreateDatabase->runTool() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/lib/Kronos/Common/Tool.php:223
    0.0094     990020   5. Kronos\FNA\Tool\CreateDatabase::CreateDatabase() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/application/Kronos/FNA/Tool/CreateDatabase.php:18
    0.7140   10032764   6. Doctrine\ORM\Tools\SchemaTool->createSchema() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/application/Kronos/FNA/Tool/CreateDatabase.php:45
    0.7140   10032764   7. Doctrine\ORM\Tools\SchemaTool->getCreateSchemaSql() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/lib/Doctrine/ORM/Tools/SchemaTool.php:81
    0.7140   10032764   8. Doctrine\ORM\Tools\SchemaTool->getSchemaFromMetadata() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/lib/Doctrine/ORM/Tools/SchemaTool.php:98
    0.7184   10339688   9. Doctrine\DBAL\Schema\Table->addIndex() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/lib/Doctrine/ORM/Tools/SchemaTool.php:197
    0.7184   10339744  10. Doctrine\DBAL\Schema\Table->_createIndex() /home/eric/Zend/workspaces/DefaultWorkspace7/fna/lib/Doctrine/DBAL/Schema/Table.php:150

[DDC-184] Infinite recursion on toArray() with manyToMany bidirectional relationships

Wed, 9 Dec 2009 02:55:01 +0000

When specifying a bidirectional @manyToMany relationship, the Doctrine ActiveRecord locks up on toArray(). Line 154 ($array[$name] = $this->toArray($value) is run thousands of times, presumably because the relations are constantly loading each other.

Everything works fine when I comment out that line, but that will surely break something else somewhere!

Hydrating these objects as arrays also works fine.

[DDC-183] Annotation parser barfs on "@something at."

Mon, 14 Jun 2010 09:17:34 +0000

Here's an odd one: The annotations parser has some quirk where it barfs if the comment contains a line that starts with any tag and ends with "at.":

/**
 * @Entity
 * @test at.
 */
class A
{
}

$a = new A;
$em->persist($a);

The result is:

PHP Fatal error:  Uncaught exception 'Doctrine\Common\Annotations\AnnotationException'
    with message '[Syntax Error] Expected Doctrine\Common\Annotations\Lexer::T_IDENTIFIER, got '.' at position 19 in class A.'
    in Doctrine\Common\Annotations\AnnotationException.php:39
Stack trace:
#0  Doctrine\Common\Annotations\Parser.php(182): Doctrine\Common\Annotations\AnnotationException::syntaxError('Expected Doctri...')
#1  Doctrine\Common\Annotations\Parser.php(150): Doctrine\Common\Annotations\Parser->syntaxError('Doctrine\Common...')
#2  Doctrine\Common\Annotations\Parser.php(229): Doctrine\Common\Annotations\Parser->match(2)
#3  Doctrine\Common\Annotations\Parser.php(204): Doctrine\Common\Annotations\Parser->Annotation()
#4  Doctrine\Common\Annotations\Parser.php(134): Doctrine\Common\Annotations\Parser->Annotations()
#5  Doctrine\Common\Annotations\AnnotationReader.php(102): Doctrine\Common\Annotations\Parser->parse('/**? * @Entity?...', 'class A')
#6  Doctrine\ORM\Mapping\Driver\AnnotationDriver.php(73): Doctrine\Common\Annotations\AnnotationReader->getClassAnnotations(Object(ReflectionClass))
#7  Doctrine\ORM\Mapping\ClassMetadataFactory.php(196): Doctrine\ORM\Mapping\Driver\AnnotationDriver->loadMetadataForClass('A', Object(Doctrine\ORM\Mapping\ClassMetadata))
#8  Doctrine\ORM\Mapping\ClassMetadataFactory.php(111): Doctrine\ORM\Mapping\ClassMetadataFactory->_loadMetadata('A')
#9  Doctrine\ORM\EntityManager.php(214): Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor('A')
#10 Doctrine\ORM\UnitOfWork.php(1182): Doctrine\ORM\EntityManager->getClassMetadata('A')
#11 Doctrine\ORM\UnitOfWork.php(1160): Doctrine\ORM\UnitOfWork->_doPersist(Object(A), Array)
#12 Doctrine\ORM\EntityManager.php(393): Doctrine\ORM\UnitOfWork->persist(Object(A))
#13 test.php(40): Doctrine\ORM\EntityManager->persist(Object(A))
#14 {main}

[DDC-185] 2 Test failures on Oracle OCI8

Wed, 9 Dec 2009 12:38:42 +0000

1) Doctrine\Tests\ORM\Functional\SingleTableInheritanceTest::testPolymorphicFind
Exception: [PHPUnit_Framework_Error_Notice] Undefined index: number

With queries:
1. SQL: 'CREATE TABLE ParentEntity (id NUMBER(10) NOT NULL, DATA VARCHAR2(255) NOT NULL, discr VARCHAR2(255) NOT NULL, "number" NUMBER(10) DEFAULT NULL, related_entity_id NUMBER(10) DEFAULT NULL, PRIMARY KEY(id))' Params: 
2. SQL: 'INSERT INTO ParentEntity (id, DATA, "number", related_entity_id, discr) VALUES (?, ?, ?, ?, ?)' Params: '5', 'thedata', '1234', '', 'child'

Trace:
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/Persisters/StandardEntityPersister.php:733
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/Persisters/SingleTablePersister.php:82
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/Persisters/StandardEntityPersister.php:565
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/Persisters/StandardEntityPersister.php:413
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/EntityRepository.php:96
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/EntityManager.php:302
/home/benny/code/php/wsnetbeans/Doctrine/trunk/tests/Doctrine/Tests/ORM/Functional/SingleTableInheritanceTest.php:152


/home/benny/code/php/wsnetbeans/Doctrine/trunk/tests/Doctrine/Tests/OrmFunctionalTestCase.php:235

2) Doctrine\Tests\ORM\Functional\LifecycleCallbackTest::testChangesDontGetLost
Exception: [PHPUnit_Framework_Error_Warning] oci_execute(): ORA-01400: cannot insert NULL into ("DOCTRINE_TESTS"."LIFECYCLECALLBACKTESTUSER"."VALUE")

With queries:
1. SQL: 'CREATE TABLE lc_cb_test_entity (id NUMBER(10) NOT NULL, value VARCHAR2(255) NOT NULL, PRIMARY KEY(id))' Params: 
2. SQL: 'SELECT LifecycleCallbackTestUser_id_s.nextval FROM DUAL' Params: 
3. SQL: 'INSERT INTO LifecycleCallbackTestUser (id, value, name) VALUES (?, ?, ?)' Params: '1', '', 'Bob'

Trace:
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php:140
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/Persisters/StandardEntityPersister.php:151
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/UnitOfWork.php:698
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/UnitOfWork.php:283
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/EntityManager.php:288
/home/benny/code/php/wsnetbeans/Doctrine/trunk/tests/Doctrine/Tests/ORM/Functional/LifecycleCallbackTest.php:50


/home/benny/code/php/wsnetbeans/Doctrine/trunk/tests/Doctrine/Tests/OrmFunctionalTestCase.php:235

[DDC-180] [patch] The SmallIntType does not extend the default Type class

Mon, 14 Jun 2010 09:17:44 +0000

The schematool has a check to see if a field is a string value, this check throws a small error because it passes an object into strtolower instead of a string value. The attached patch calls the method Type->getName() to check if the field is a string.

[DDC-175] Drop and create database should use postgres user for pgsql connections

Mon, 14 Jun 2010 09:17:44 +0000

When dropping or creating a postgres database, Doctrine attempts to use the "database name" linked to the connection, however this is impossible when creating a database, and since postgres requires the dbname parameter to be set - it should be set to "postgres".

Previous versions of Doctrine used a temp connection with a temp connection name "postgres" - the attached patch applies a similar logic.

[DDC-174] Missing DoctrineException use statement in Doctrine\ORM\UnitOfWork

Dependency — Wed, 2 Dec 2009 20:34:07 +0000

UnitOfWork throws a "DoctrineException" in several places, which resolves to "\Doctrine\ORM\DoctrineException" (instead of
Doctrine\Common\DoctrineException).

This should either be ORMException, or "use"d in the header.

[DDC-136] Usage of spl_object_hash in UnitOfWork is dangerous

Tue, 27 Dec 2011 10:07:27 +0000

UnitOfWork uses spl_object_hash to identify objects. This breaks horribly as spl_object_hash is not unique when using it in different scopes.

See this example:
http://pastebin.com/d5e4825b0

When creating and destroying (persisting and removing) objects in sub functions, UnitOfWork gets confused.
I don't think this is a special case, so I consider this as a Blocker...

[DDC-133] Complete implementation for schema support.

Sun, 8 Aug 2010 09:09:04 +0000

Complete implementation for schema support.

[DDC-123] PDO throws an exception when parameters are missing or mismatch, DC throws php warnings

Sat, 21 Nov 2009 21:50:04 +0000

PDO throws exceptions if you try to execute a query with a wrong parameter count or parameters named incorrect.

Doctrine\ORM\Query does nothing of such kind and only throws php warnings when wrong php array keys are accessed. Attached is a patch that corrects this behaviour to give a developer more feedback on this kind of errors.

Performance wise, on each _doExecute() 1 count check of params against set parameter mappings aswell as one additional check if each passed param really exists.

[DDC-120] Create oci8 driver

Dependency — Mon, 14 Jun 2010 09:17:44 +0000

The pdo_oci driver is sometimes problematic. Even the test suite results in segfaults already when using pdo_oci.

[DDC-122] Not specifying a Metadata Cache at all leads to fatal error in EM

Wed, 16 Dec 2009 09:50:47 +0000

If for development purposes you dont follow the recommendation to use a Metadata Cache you end up with a fatal error, because the EntityManager sets the null value of the metadata cache to the ClassMetadataFactory which issues a command on it.

Solutions

1. in ORM Configuration create and return an array cache.
2. Throw an exception if getMetadataCacheDriverImpl() would return null.

[DDC-121] Persisting added children to parent in a one-to-many relationship fails

Mon, 9 Nov 2009 08:26:20 +0000

Affects Doctrine 2.0 at revision 6679 (trunk).

Persisting children that were added to a parent retrieved from the database in (at least) a one-to-many relationship fails when the children array was not initialized before adding. A simple demonstration:

/** @Entity */
class Customer {
	/** @Id @Column(type="integer") @GeneratedValue(strategy="AUTO") */
	public $id;
	/** @OneToMany(targetEntity="User", mappedBy="customer", cascade={"persist"}) */
	public $users = array();
}

/** @Entity */
class User {
	/** @Id @Column(type="integer") @GeneratedValue(strategy="AUTO") */
	public $id;
	/** @ManyToOne(targetEntity="Customer") @JoinColumn(name="customerId", referencedColumnName="id") */
	public $customer;
}

Let's retrieve our existing customer and add a user to it.

$customer = $em->find('Customer', 1);
$user = new User();
$user->customer = $customer;
$customer->users[] = $user;
$em->persist($customer);
$em->flush();

At this point the user has not been persisted.
When initializing the users collection by e.g.:

$customer = $em->find('Customer', 1);
sizeof($customer->users);
$user = new User();

... this is not the case.

[DDC-108] Transitive persistence broken

Tue, 3 Nov 2009 18:31:44 +0000

When cascading 'persist' operations, the object which was not persisted implicitly is being written to the DB with wrong parameters, broken SQL:

INSERT INTO email (email, userId) VALUES (?, ?)
array(3) {
  [1]=>
  NULL
  [2]=>
  string(16) "user@example.com"
  [3]=>
  int(1)
}

See the attached example for details... When I uncomment the "$em->persist($email);" line, everything works as expected (but I'd like this persist to be done automatically...)

[DDC-104] Junk annotation code generated using convert mapping

Wed, 11 Nov 2009 19:37:32 +0000

When generating annotation from yaml
./doctrine convert-mapping --from=./yaml/ --to=annotation --dest=.

with one already generated yaml file and one new yaml file

annotation of first yaml is appended to the new annotations.

Cause of the problem is in AnnotationExporter. ($this->_currentCode is not cleared.)

public function exportClassMetadata(ClassMetadataInfo $metadata)
{
if (file_exists($this->_outputPath))

{ $this->_currentCode = file_get_contents($this->_outputPath); }

Solution :

if (file_exists($this->_outputPath))

{ $this->_currentCode = file_get_contents($this->_outputPath); }

else

{ $this->_currentCode = ''; }

[DDC-94] Queries executed through StandardEntityPersister load(), loadAll(), etc. are not logged.

Reference — Wed, 2 Dec 2009 20:49:45 +0000

In Doctrine\DBAL\Connection, execute() and executeUpdate() methods both call:
$this->_config->getSqlLogger()->logSql($query, $params)

But when you use the Doctrine\ORM\Persisters\StandardEntityPersister (which is the case with all magic repository methods in Symfony, such as Models\User::findAll() for example), it only calls the prepare() method of the Connection, so the query is not logged (and does not appear in the Debug Panel in Symfony for instance).

I added the following line in Doctrine\DBAL\Connection.php, in method prepare():
if ($this->_config->getSqlLogger()) {
$this->_config->getSqlLogger()->logSql($statement);
}
which seem to solve the problem in this case.

[DDC-97] \Doctrine\ORM\Mapping\Driver\Driver::preload($force=false) is missing

Duplicate — Tue, 15 Dec 2009 21:08:01 +0000

Every driver implementation has a preload() method, however it is not present on the interface.

It should however be on the interface to consistently call preload on the CLI tasks which require all the metadata.

[DDC-98] SchemaToolTask's use of Driver\preload() is not "deterministic"

Reference — Tue, 15 Dec 2009 21:08:18 +0000

\Doctrine\ORM\Mapping\Driver\Driver::preload() only returns the diff of loaded entities, however for example ClassMetadataFactory::setCacheDriver() already calls preload() which may make the SchemaToolTask find zero entities.

preload() should be executed, however it should be done from a new preload() method on ClassMetadataFactory() and then all the loaded classes should be fetched from the ClassMetadataFactory by calling getLoadedMetadata().

[DDC-92] Remove DoctrineException and introduce Doctrine\ORM\ORMException and Doctrine\DBAL\DBALException instead

Dependency — Fri, 5 Mar 2010 11:39:23 +0000

DoctrineException in the Common package currently serves as a base exception for DBAL and ORM. This is not optimal and the __callStatic handling already showed some issues where the real exception was hidden (var_export issue).

Therefore it makes much more sense to introdude ORMException and DBALException as the base exception classes of the respective packages.

[DDC-88] SchemaTool/Platform DDL does not escape column names

Sun, 1 Nov 2009 11:06:06 +0000

The column identifiers are not quoted in the SchemaTool/Platform.

Funny is Doctrine\Tests\ORM\Functional\SchemaTool\MysqlSchemaToolTest::testGetCreateSchemaSql2() suffers from this "problem" by asserting mysql invalid syntax as correct creation code.

All identifiers should be escaped by the Platform.

[DDC-82] ConvertMapping is broken in latest svn

Sun, 1 Nov 2009 18:08:55 +0000

The ConvertMapping class tries to call "parent::validate()", but the parent class is abstract, so this fails.

[DDC-81] Wrong class names when using sub-namespaces

Wed, 11 Nov 2009 21:18:42 +0000

When using sub-namespaces, e.g. an entity is named "Entity\User\Permission", the annontated PHP file has the wrong class:

- - - 8< - - - -
namespace Entity\User;
...
class User\Permission
{
...
- - - 8< - - - -

The namespace is correct, but the class should be "class Permission"...

The attaches patch should fix this in AnnotationExporter

[DDC-83] Tests segfault under oracle

Dependency — Wed, 11 Nov 2009 21:20:50 +0000

In \Doctrine\Tests\ORM\Functional\AdvancedAssociationTest::testIssue() lines 87, 97 and 98 cause PHP to segfault when running the test suite under PHp 5.3 and oracle. Has something to do with what Doctrine does with lazy loading..Not quite sure but this is all I have figured out up until now.

[DDC-79] Allow constructor arguments in persistable models

Dependency — Wed, 10 Feb 2010 05:49:01 +0000

Currently, at the reconstitution phase, models are created using the 'new' keyword. This implies a requirement that one must be able to create the model without any arguments to it's constructor. Actually this is the only requirement for the models implied by Doctrine. This requirement makes it impossible to use constructor-based dependency injection for example.

At least two project's that I know of (php-object-freezer and FLOW3) solve this by using a trick which creates an object without running it's constructor:

$object = unserialize(sprintf('O:%d:"%s":0:{}', strlen($className), $className));

[DDC-73] Lifecycle Events only work with undocumented @HasLifecycleCallbacks in Annonation classes

Sun, 8 Nov 2009 09:03:55 +0000

When using Docblock Annotations, Lifecycle Events don't work as described here:
http://www.doctrine-project.org/documentation/manual/2_0/en/events

Functions with e.g. "@PrePersist" annonations are not called unless the class has "@HasLifecycleCallbacks" annotation in its class header docblock.

This behavior should be either documented or changed (no need for the @HasLifecycleCallbacks annotation)

[DDC-71] Method Doctrine\ORM\Tools\Export\Driver\AnnotationExporter::getClassToExtend() does not exist

Wed, 11 Nov 2009 19:39:54 +0000

In Doctrine\ORM\Tools\Export\Driver\AnnotationExporter, on line 191 & 197, method getClassToExtend() is called, whereas the actual name of the method is _getClassToExtend().
It generates a fatal error when using command line tool symfony doctrine:build --all.

[DDC-72] column alias not recognized in ConvertDoctrine1Schema

Wed, 11 Nov 2009 21:15:52 +0000

The syntax for column aliases used in D1 is not recognized "column_name as field_name". This produces fatal errors when converting D1 YAML -> D2 YAML -> D2 Annotations.

D1 yaml:

xcoord as x:
        type: integer(3)
        unsigned: true
        notnull: true

converted D2 yaml:

xcoord as x:
        type: integer(3)
        unsigned: true
        notnull: true

expected output:

x:
      columnName: xcoord
      type: integer(3)
      notnull: true

patch attached.

[DDC-64] missing column type "clob"

Wed, 11 Nov 2009 20:44:27 +0000

The legacy column type "clob" is not recognized by "Doctrine\ORM\Tools\ConvertDoctrine1Schema". It should be correctly mapped to "text".

Patch attached.

[DDC-66] missing column type "timestamp"

Mon, 14 Jun 2010 09:17:44 +0000

The former supported column type "timestamp" is not defined in Doctrine\DBAL\Types\Type.

Patches and suggestions follow.

[DDC-59] Add Caching chapter to the manual

Mon, 14 Jun 2010 09:17:34 +0000

This chapter should cover the use of the cache drivers in the Common package with all their features. Examples should show how to use these cache drivers together with query, result and metadata caches. It should also warn of cache slams especially when letting the cache driver manage the cache keys.

[DDC-57] ManyToMany PDOException MySQL Syntax Error

Mon, 26 Oct 2009 13:19:21 +0000

For ManyToMany Relation I have an MySQL Sytax Error from the StandardEntityPersister.php

Hier is my error code:

2009-10-22T09:39:31+02:00 ERR (3): exception 'PDOException' with message 'SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= lemma_type.type_id WHERE lemma_type.lemma_id = NULL' at line 1' in /usr/local/zend/apache2/htdocs/doctrine/lib/Doctrine/ORM/Persisters/StandardEntityPersister.php:475
Stack trace:
#0 /usr/local/zend/apache2/htdocs/doctrine/lib/Doctrine/ORM/Persisters/StandardEntityPersister.php(475): PDOStatement->execute(Array)
#1 /usr/local/zend/apache2/htdocs/doctrine/lib/Doctrine/ORM/Mapping/ManyToManyMapping.php(186): Doctrine\ORM\Persisters\StandardEntityPersister->loadManyToManyCollection(Object(Doctrine\ORM\Mapping\ManyToManyMapping), Array, Object(Doctrine\ORM\PersistentCollection))
#2 /usr/local/zend/apache2/htdocs/doctrine/lib/Doctrine/ORM/PersistentCollection.php(233): Doctrine\ORM\Mapping\ManyToManyMapping->load(Object(kateglo\application\models\Lemma), Object(Doctrine\ORM\PersistentCollection), Object(Doctrine\ORM\EntityManager))
#3 /usr/local/zend/apache2/htdocs/doctrine/lib/Doctrine/ORM/PersistentCollection.php(495): Doctrine\ORM\PersistentCollection->_initialize()
#4 /usr/local/zend/apache2/htdocs/kateglo/application/views/scripts/search/index.phtml(24): Doctrine\ORM\PersistentCollection->getIterator()

@roman: i send you the new database structure and the php code (models etc..)

[DDC-58] Getting "undefined index" notices from fields in subentities which are foreign indices.

Thu, 22 Oct 2009 19:13:38 +0000

I have a class with subclasses. One of the subclasses has fields which are foreign indices
If i do

$em->find('MyParentEntity', 1)

I get notices
Notice: Undefined index: somefieldwhichisforeignindex in /Doctrine/ORM/UnitOfWork.php on line 1708

[DDC-56] ManyToMany mapping does not take difference between field name and column name into account

Sun, 18 Oct 2009 20:36:38 +0000

The fields of my entities are prefixed with an underscore since they are private variables. Since I don't like my database schema that way I've named all the columns without the underscore, thus far no problems. Now when you create a ManyToMany mapping a problem occurs. The column name in the database is "fieldname" but the fieldname = "_fieldname". We need an annotation in the form of @referencedFieldName to specify the relevant field name.

[DDC-55] Query paramater mapping error

Wed, 28 Oct 2009 11:30:54 +0000

It seems as though the query parameters start from '1' (?0 throws an exception), whereas the Query#_prepareParams function starts counting from 0.

Code:
$query = $this->em->createQuery('SELECT s FROM Session s WHERE s.id = ?1');

echo $query->getSQL();

$session = $query->execute(array($id));
print_r($session);

Output:
SELECT s0_.id AS id0, s0_.data AS data1, s0_.created AS created2, s0_.accessed AS accessed3 FROM Session s0_ WHERE s0_.id = ?

Warning: Invalid argument supplied for foreach() in Doctrine/ORM/Query.php on line 222

Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?' at line 1' in Doctrine/DBAL/Connection.php:602
Stack trace:
#0 Doctrine/DBAL/Connection.php(602): PDO->query('SELECT s0_.id A...')
#1 Doctrine/ORM/Query/Exec/SingleSelectExecutor.php(42): Doctrine\DBAL\Connection->execute('SELECT s0_.id A...', Array)
#2 Doctrine/ORM/Query.php(198): Doctrine\ORM\Query\Exec\SingleSelectExecutor->execute(Object(Doctrine\DBAL\Connection), Array)
#3 Doctrine/ORM/AbstractQuery.php(461): Doctrine\ORM\Query->_doExecute(Array)
#4 classes/SessionManager.php(35): Doctrine\ORM\AbstractQuery->execute(A in /var/www/tec-expo.com/development/libraries/Doctrine/DBAL/Connection.php on line 602

[DDC-48] Cache Namespaces

Reference — Mon, 14 Jun 2010 09:17:34 +0000

For users who run multiple doctrine 2 installations on a single machine, it is possible for APC/Memcache cache collisions to occur. One possible solution would allow the user to specify a namespace when creating the cache instance. I have attached such a solution. However, after reviewing ~~DDC-47~~, there might be a better solution that addresses both requirements.

[DDC-47] Improve query resultset cache control

Reference — Thu, 22 Oct 2009 22:39:55 +0000

We need better control for setting the hash/key for resultset cache entries. Then provide a way to clear these cache entries.

http://trac.doctrine-project.org/ticket/2042

$temp = Doctrine_Query::create() 
->from('Profile p') 
->where('p.id=?', $o) 
->setHydrationMode(Doctrine::HYDRATE_ARRAY) 
->useResultCache(true, 3600, 'product_cache') // custom tag 
->execute(); 

$temp = Doctrine_Query::create() 
->from('Model m') 
->setHydrationMode(Doctrine::HYDRATE_ARRAY) 
->useResultCache(true, 3600, 'product_cache') // custom tag 
->execute(); 

$temp = Doctrine_Query::create() 
->from('News n') 
->setHydrationMode(Doctrine::HYDRATE_ARRAY) 
->useResultCache(true, 3600, 'news_cache') // custom tag 
->execute();

and now

$conn  = Doctrine_Manager::getConnection('sqlite_cache_connection'); 
$cacheDriver = new Doctrine_Cache_Db(array('connection' => $conn, 
'tableName' => 'cache')); 

$cacheDriver->deleteByTag('product_cache');

[DDC-42] the DQL parser does not support boolean literal values

Tue, 13 Oct 2009 10:48:59 +0000

The parser does not support boolean literal values. This means that comparisons like e.unlocked = true result in a syntax error. This is not what is intended, since both documentation and comments in the code Doctrine\ORM\Query\Parser.php line 1870 say that boolean literals are supported.

I have a possible fix. I don't know if it is the best way to fix this.

OLD:

/**
     * Literal ::= string | char | integer | float | boolean
     *
     * @return string
     */
    public function Literal()
    {
        switch ($this->_lexer->lookahead['type']) {
            case Lexer::T_STRING:
            case Lexer::T_INTEGER:
            case Lexer::T_FLOAT:
				$this->match($this->_lexer->lookahead['value']);
				return $this->_lexer->token['value'];
            default:
                $this->syntaxError('Literal');
        }
    }

NEW:

/**
     * Literal ::= string | char | integer | float | boolean
     *
     * @return string
     */
    public function Literal()
    {
        switch ($this->_lexer->lookahead['type']) {
            case Lexer::T_STRING:
            case Lexer::T_INTEGER:
            case Lexer::T_FLOAT:
				$this->match($this->_lexer->lookahead['value']);
				return $this->_lexer->token['value'];
			case Lexer::T_TRUE:
			case Lexer::T_FALSE:
                $this->match($this->_lexer->lookahead['value']);
                return $this->_em->getConnection()->getDatabasePlatform()->convertBooleans(strtolower($this->_lexer->token['value']) == 'true' ? true : false);
            default:
                $this->syntaxError('Literal');
        }
    }

Using convertBooleans is important. Otherwise the sql will have 'true' or 'false'.

Cases T_TRUE and T_FALSE should also be added to ArithmeticPrimary(). (line 2048)

[DDC-43] offset and limit are in the wrong order (at least SQLite)

Mon, 12 Oct 2009 19:10:52 +0000

The following code creates an error:

Code:

$query = Itoijala_Singletons::getDoctrine()->createQueryBuilder();
$query->select('e')->from('Model\Guestbook\Entry e');
$query->andWhere('e.dateDeleted IS NULL')->andWhere('e.unlocked = TRUE');
$query->orderBy('e.dateCreated', 'DESC')->setFirstResult(($this->_getParam('page') - 1) * 15);
$query->setMaxResults(15);

$this->view->entries = $query->getQuery()->getResult();

Error:
SQLSTATE[HY000]: General error: 1 near "OFFSET": syntax error

The DQL:
SELECT e FROM Model\Guestbook\Entry e WHERE (e.dateDeleted IS NULL) AND (e.unlocked = TRUE) ORDER BY e.dateCreated DESC

The SQL:
SELECT g0_.id AS id0, g0_.name AS name1, g0_.email AS email2, g0_.homepage AS homepage3, g0_.content AS content4, g0_.comment AS comment5, g0_.unlocked AS unlocked6, g0_.date_created AS date_created7, g0_.date_updated AS date_updated8, g0_.date_deleted AS date_deleted9, g0_.creator_id AS creator_id10, g0_.updater_id AS updater_id11, g0_.deleter_id AS deleter_id12 FROM guestbook_entries g0_ WHERE (g0_.date_deleted IS NULL) AND (g0_.unlocked = 1) ORDER BY g0_.date_created DESC OFFSET 0 LIMIT 15

SQLite expects offset to come after limit. writeLimitClause in AbstractPlatform works correctly and is not overriden by SqlitePlatform. This means that the bug is somewhere else. writeLimitClause is not called.

[DDC-38] associations that are null should not create a prox object

Wed, 28 Oct 2009 11:14:47 +0000

Associations that are nullable do not work as expected. When the association is null, i.e. the id in the database is null, the association is not null when loaded from the database. Doctrine creates a proxy object for the association that, when loaded, has no values for any fields. Doctrine should check during object hydration if the association is null. If true then no proxy object should be created. Please see ~~DDC-34~~ for my schema.

[DDC-39] Proxy definition files doesn't get updated when changing Entity

Wed, 14 Oct 2009 20:22:21 +0000

Proxy definitions are generated in /tmp but not accordingly updated when their respective Entitiy-objects gets new methods, therefore _load() is never called on these new methods.

[DDC-35] [patch] The cli configuration maps the convert-mapping task to the wrong file name for the class

Thu, 8 Oct 2009 16:23:38 +0000

Currently the Cli class maps the convert-mapping task to the class with file name MappingTask but this should be ConvertMappingTask since that is the name of the class. I've attached ~~two patch files~~ (svn diff doesn't add the renamed file) one patch file. The first one renames the name of the class. ~~The second one renames the file to ConvertMappingTask~~.

[DDC-27] schema-tool --create creates a table for a mapped superclass

Sat, 3 Oct 2009 22:08:00 +0000

Using the schema-tool to create the database creates a table for a mapped superclass. I think this behaviour is not desired, since the fields of the superclass also exist in the subclass tables. Running php doctrine schema-tool --create --dump-sql --classdir="<...>" generates the following output (MySql):

CREATE TABLE Blameable (date_created DATETIME NOT NULL, date_updated DATETIME DEFAULT NULL,
date_deleted DATETIME DEFAULT NULL, creator_id INT DEFAULT NULL, updater_id INT DEFAULT NULL,
deleter_id INT DEFAULT NULL) ENGINE = InnoDB
ALTER TABLE Blameable ADD FOREIGN KEY (creator_id) REFERENCES user_users(id)
ALTER TABLE Blameable ADD FOREIGN KEY (updater_id) REFERENCES user_users(id)
ALTER TABLE Blameable ADD FOREIGN KEY (deleter_id) REFERENCES user_users(id)

Only the mapped superclass exists in the classdir. I think it should not create any tables.