Doctrine Project

[DDC-1972] Throw an exception when setting cascade options which do not exist

Wed, 8 Aug 2012 15:20:03 +0000

I made the assumption that the way to define a cascading delete is to do (in YAML):

cascade: [delete]

When it is actually:

cascade: [remove]

It would be nice if Doctrine would throw an exception when the user sets a cascade option which does not exist.

[DDC-1765] SchemaTool Commands should accept both --force and --dump-sql

Sat, 17 Nov 2012 15:21:38 +0000

When running SchemaTool for schema operations you can get either a --dump-sql or make the changes using --force

When you run with --force you get a generic "1 query executed" response, there should be a way to execute it receiving feedback of the queries and making the changes.

This is good for example for my automated test env builder, as the return of this command would be logged. But i see no reason why the script can't take both options.

[DDC-1761] Small error on DQL documentation page

Tue, 3 Apr 2012 23:28:41 +0000

On this document page:
http://docs.doctrine-project.org/projects/doctrine-orm/en/2.0.x/reference/dql-doctrine-query-language.html#dql-select-examples

The following lines are present:
$query = $em->createQuery('SELECT u.username, u.name FROM CmsUser u');
$users = $query->getResults(); // array of CmsUser username and name values
echo $users[0]['username'];

There is an error in:
$query->getResults();

It should read
$query->getResult();

[DDC-1614] On OneToOne mappings with Primary Key same as Foreign Key, using @Id in the foreign association does not carry over when running "generate-entities" with --generate-annotations=1

Wed, 23 Jan 2013 22:32:41 +0000

When having a OneToOne mapping that has a primary key that is the same as the foreign key, using the @Id attribute does not carry over when generating entities.

Example code:

class User
{
/**

@Id @Column(type="integer", nullable=false, columnDefinition="INT UNSIGNED NOT NULL AUTO_INCREMENT")
@GeneratedValue(strategy="AUTO")
*/
private $id;

/**

@OneToOne(targetEntity="User_ExtraAttrs", cascade= {"persist","remove","detach","merge","refresh"}
, mappedBy="User")
@JoinColumn(name="id", referencedColumnName="id")
*/
private $UserAttrs;
}

class User_ExtraAttrs
{
/**

@OneToOne(targetEntity="User", cascade= {"all"}
, inversedBy="UserAttrs")
@Id
@JoinColumn(name="VehicleID", referencedColumnName="VehicleID")
*/
private $User;
}

When running "doctrine orm:generate-entities --regenerate-entities=1 --generate-annotations=1", the @Id in User_ExtraAttrs does not carry over. It must be manually inserted.

[DDC-1611] Tools Reference example is apparently wrong

Fri, 20 Jan 2012 09:19:14 +0000

I was reading http://www.doctrine-project.org/docs/orm/2.1/en/reference/tools.html
In 24.2.2. Configuration (Non-PEAR)

The example seems to be wrong.

use Doctrine\DBAL\Tools\Console\Helper\EntityManagerHelper;
should be
use Doctrine\ORM\Tools\Console\Helper\EntityManagerHelper;

That's all.

[DDC-1466] Entity ID hash generation improvement in UnitOfWork

Thu, 3 Nov 2011 10:23:14 +0000

Currently ID hash is generated using implode function with space character. I would like to point out that problems may raise if the ID column values are allowed to contain the space themselves - different objects could return equal ID hash values.

The trivial one-line solution would be to serialize the array instead. Cheaper solution from performance perspective would be escaping the space character for ID values.

[DDC-1169] Entities outside of drivers' namespaces only give 'is not a valid entity'

Wed, 25 May 2011 17:41:12 +0000

Hi,
in a situation where entity, that EM is to work with, is not inside of any namespace (that should be specified in $chainDriverImpl->addDriver($metadataDriver, 'someNamespace'); )
-> gives error message 'Entity # is not a valid entity or mapped superclass' instead of notifying that the entity's namespace is not added

[DDC-1076] It should be possible to supply EntityManager with a custom ProxyFactory

Fri, 25 Mar 2011 10:27:07 +0000

It is plausible that one might want to handle the loading of proxy classes in their own way, perhaps not using the filename/class scheme doctrine currently comes with.

Currently the only way to provide your own implementation of ProxyFactory is to subclass EntityManager. Even this is not clean since one also must copy/paste the EntityManager::create factory method to get identical behavior.

It would be nice if there was a ProxyFactory interface and one could provide an instance of it to Doctrine\ORM\Configuration when creating an EntityManager.

[DDC-1004] Option for mapping:import to not write Entity Files if they exist

Thu, 27 Jan 2011 07:06:41 +0000

There should be an option to omit the creation of allready existing entities:

Use Case:

if you develop your model in the database and create the entities with the cli and then go on with development and create new tables you would build the entities again with the cli. This will kill your allready existing and possible extended entities.

Best would be if you have to set the option when you want the existing entities overwritten. so you cant accidently overwrite them

[DDC-1003] Documentation refers to EAGER loading as FETCH

Wed, 26 Jan 2011 20:13:14 +0000

Throughout the documentation found in the following link (http://www.doctrine-project.org/docs/orm/2.0/en/reference/xml-mapping.html) when mentioning eager or lazy loading the documentation says FETCH instead of EAGER.

E.G. content says "fetch - Either LAZY or FETCH" which should read "fetch - Either LAZY or EAGER"

This occurs in a few different areas on this page.

[DDC-940] Entities can / can not have private properties

Wed, 15 Dec 2010 13:53:15 +0000

In the note in
http://www.doctrine-project.org/docs/orm/2.0/en/reference/working-with-objects.html#merging-entities
It appears to state that private variables are not serialized for child objects

If this is the only reason entities can't have private properties, then this restriction is no longer valid, or possibly be reconsidered.

<?php

class A {
    private $a = null;

    public function setValue($value) {
        $this->a = $value;
    }
}

class B extends A {}

$b = new B();
$b->setValue("B");
var_dump($b);

$c = unserialize(serialize($b));
var_dump($c);

The output suggests private variables are serialized, and are restored fine

[DDC-823] Errors in 2.0 Cookbook Documentation

Mon, 11 Jul 2011 17:38:41 +0000

http://www.doctrine-project.org/projects/orm/2.0/docs/cookbook/getting-started-xml-edition/en#getting-started-xml-edition

Paragraph 1:
The benefit of Doctrine for the programmer is the possibility ~~can~~ to focus ~~soley~~ solely on the business and worry about persistence only as a secondary task. This doesn't mean persistence is not important to Doctrine 2, however it is our belief that there are considerable benefits for object-oriented programming, if persistence and entities are kept perfectly ~~seperated~~ separated.

Paragraph 2:
Entities are ~~leightweight~~ lightweight PHP Objects that don't need to extend any abstract base class or interface. An entity class must not be final or contain final methods. Additionally it must not implement __clone nor __wakeup or it should do so safely.

What would be the best way to note other errors?

[DDC-605] Include Fowards Compatible Support for Scalar Type Hints Patch in ProxyFactory

Sun, 8 Aug 2010 09:20:23 +0000

ProxyFactory needs foward compatible support for the scalar type hint patch:

http://ilia.ws/archives/217-Scalar-Type-Hints-are-Here!.html

[DDC-567] Foreign Key to Unique Field Update Failure

Mon, 8 Oct 2012 14:56:08 +0000

I am getting an error: 'Notice: Undefined index: sysname in ./libraries/Doctrine/ORM/Persisters/BasicEntityPersister.php on line 434' when I try to flush a change to a property that references a unique field on another object.

From poking around in the _prepareUpdateData function, it seems that it only allows you to use identifier fields:

$newValId = $uow->getEntityIdentifier($newVal);

..

$result[$owningTable][$sourceColumn] = $newValId[$targetClass->fieldNames[$targetColumn]];

I'll see if I can get a test case for this set up.