Doctrine Project

[DDC-1774] [GH-334] Command fixes

Fri, 4 May 2012 18:02:40 +0000

This issue is created automatically through a Github pull request on behalf of hhamon:

Url: https://github.com/doctrine/doctrine2/pull/334

Message:

This patch can be backported on all branches.

[DDC-1598] ProxyFactory makes assumptions on identifier getter code

Mon, 16 Jan 2012 09:56:15 +0000

As of
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L214
and
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L237
the current ProxyFactory isn't actually checking if the identifier getter has logic in it.
Current checks aren't enough/valid.

In my opinion the check should be matching following:

(public|protected)\s+function\s+getFieldname\s*(\s*)\s+

{\s*\$this\s*->Fieldname\s*;\s*}

Not really experienced with regex, but currently cannot come up with a more secure check.

[DDC-1521] No way reuse parameters in custom function twice

Mon, 16 Jan 2012 03:20:15 +0000

There is custom function:

class DistanceFunction extends FunctionNode
{
	protected $fromLat;
	protected $fromLng;
	protected $toLat;
	protected $toLng;

	public function parse(\Doctrine\ORM\Query\Parser $parser)
	{
		$parser->match(Lexer::T_IDENTIFIER);
		$parser->match(Lexer::T_OPEN_PARENTHESIS);

		$this->fromLat = $parser->ArithmeticPrimary();
		$parser->match(Lexer::T_COMMA);

		$this->fromLng = $parser->ArithmeticPrimary();
		$parser->match(Lexer::T_COMMA);

		$this->toLat = $parser->ArithmeticPrimary();
		$parser->match(Lexer::T_COMMA);

		$this->toLng = $parser->ArithmeticPrimary();

		$parser->match(Lexer::T_CLOSE_PARENTHESIS);
	}

	public function getSql(\Doctrine\ORM\Query\SqlWalker $sqlWalker)
	{
		$fromLat = $this->fromLat->dispatch($sqlWalker);
		$fromLng = $this->fromLng->dispatch($sqlWalker);
		$toLat = $this->toLat->dispatch($sqlWalker);
		$toLng = $this->toLng->dispatch($sqlWalker);

		$earthDiameterInKM = 1.609344 * 3956 * 2;

		$sql = "($earthDiameterInKM * ASIN(SQRT(POWER(" .
			"SIN(($fromLat - ABS($toLat)) * PI() / 180 / 2), 2) + " .
			"COS($fromLat * PI() / 180) * COS(ABS($toLat) * PI() / 180) * " .
			"POWER(SIN(($fromLng - $toLng) * PI() / 180 / 2), 2) " .
			")))";

//echo $sql;

		return $sql;
	}

and the usage of it

$em
	->createQuery('SELECT DISTANCE(a.latitude, a.longitude, :lat, :lng) FROM Ololo:AbstractArea a WHERE a = 2')
	->setParameter('lat', 1)
	->setParameter('lng', 2)
	->getResult();

what this function generate:

(12733.129728 * ASIN(SQRT(POWER(SIN((t0_.latitude - ABS(?)) * PI() / 180 / 2), 2) + COS(t0_.latitude * PI() / 180) * COS
(ABS(?) * PI() / 180) * POWER(SIN((t0_.longitude - ?) * PI() / 180 / 2), 2) )))

and exception raised: "SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens"

Don't know, does it affects on master branch (does they support native named parameters?).

[DDC-1505] EntityManager->find returning null for entity on the inverse side of a OneToOne association

Sun, 18 Dec 2011 21:19:50 +0000

BasicEntityPersister.getJoinSQLForJoinColumns treats joinColumn nullable setting as defaulting to false:

if(isset($joinColumn['nullable']) && $joinColumn['nullable'])

{ return 'LEFT JOIN'; }

I think it should be:

if(!isset($joinColumn['nullable']) || $joinColumn['nullable']){ return 'LEFT JOIN'; }

[DDC-1265] Evaluate skip operations / loading through events

Tue, 6 Sep 2011 18:10:37 +0000

Evaluate skip operations / loading through events

[DDC-745] DateTime with SQLite

Fri, 13 Aug 2010 05:19:10 +0000

I was using 2.0.0-Beta3 no problems found.
Then upgraded to Beta4 and the following:

Fatal error: Uncaught exception 'Doctrine\DBAL\Types\ConversionException' with message 'Could not convert database value "2010-08-07 00:00:00.000" to Doctrine Type datetime' in

I guess it's an ORM's problem.

I've traced to:
call stack:
Doctrine\DBAL\Types\DateTimeType->convertToPHPValue()
Doctrine\ORM\Persisters\BasicEntityPersister->_processSQLResult()
Doctrine\ORM\Persisters\BasicEntityPersister->_createEntity()
Doctrine\ORM\Persisters\BasicEntityPersister->load()
Doctrine\ORM\Persisters\BasicEntityPersister->findOneBy()

in Doctrine\DBAL\Types\DateTimeType->convertToPHPValue() i receive the values:
$value = "2010-08-07 00:00:00.000"
$platform->getDateTimeFormatString() = "Y-m-d H:i:s"

I'm new to Doctrine, maybe is my problem but it was working before i've upgraded everything.
I'll also try to find out what is going on, but just to let you guys know.

=================0
System:
Windows 7 - Portuguese Regional Settings
XAMPP
SQLite database