Doctrine Project

[DDC-2182] [GH-529] Options join columns

Tue, 4 Dec 2012 21:00:27 +0000

This issue is created automatically through a Github pull request on behalf of francisbesset:

Url: https://github.com/doctrine/doctrine2/pull/529

Message:

When a columns as the options with unsigned at true, this options is not passed to the joinColumn.
This PR fix this.

[DDC-2174] [GH-526] [DDC-2172] Fix EntityGenerator get literal type

Tue, 27 Nov 2012 23:04:06 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/526

Message:

http://www.doctrine-project.org/jira/browse/DDC-2172

[DDC-2172] GENERATOR_TYPE_UUID missing in EntityGenerator.php

Tue, 27 Nov 2012 23:04:23 +0000

Hey guys!

In my model I used UUID as the generator strategy for my id:
@GeneratedValue(strategy="UUID")
It works for creating my UUID but when I add some changes to my model and run
orm:generate-entities --generate-annotations="true" models/
it throws the following exception:
"[InvalidArgumentException]
Invalid provided IdGeneratorType: 6 "

Looking at the EntityGenerator.php I saw that the UUID type is not (yet?) in there. When I add it to the function getIdGeneratorTypeString() everything works fine...
I'm new to Doctrine so I'm not sure if this is actually a bug, but it seems weird to me

[DDC-2168] [GH-523] [DDC-2074] Bugfix regarding clearing cloned PersistentCollections

Sun, 25 Nov 2012 19:17:41 +0000

This issue is created automatically through a Github pull request on behalf of jankramer:

Url: https://github.com/doctrine/doctrine2/pull/523

Message:

When calling clear on a PC that has no owner (e.g. because it was cloned), it can't be deleted as there is no metadata available (that's essentially the exception mentioned in the ticket). In these cases, I think it shouldn't be scheduled for deletion, but please have a look as my knowledge of the ORM internals is limited.

[DDC-2158] [GH-518] regression fix for left joins (double ON)

Sun, 25 Nov 2012 11:36:28 +0000

This issue is created automatically through a Github pull request on behalf of Fran6co:

Url: https://github.com/doctrine/doctrine2/pull/518

Message:

[DDC-2144] PersistentCollection Criteria IS NULL not behaving as expected

Wed, 14 Nov 2012 16:56:46 +0000

When using the matching method of a persistentCollection with a Criteria that contains a call to isNull, the SQL generated contains "field = null" instead of "field IS null"

[DDC-2129] [GH-508] Fix and test for DDC-2073

Mon, 12 Nov 2012 14:07:17 +0000

This issue is created automatically through a Github pull request on behalf of mnapoli:

Url: https://github.com/doctrine/doctrine2/pull/508

Message:

Fix and test for ~~DDC-2073~~(http://www.doctrine-project.org/jira/browse/DDC-2073).

Ticket extract:

> PersistentCollection::matching() always returns empty collection, when passed criteria's expression is created using ExpressionBuilder::isNull()
> This happens because expression created by ExpressionBuilder::isNull() is wrongly translated to SQL using '=' operator instead of 'IS NULL'.
> If the collection is already loaded, result is as expected.

[DDC-2126] [GH-505] Fix errors in JoinClassPathExpression and SqlWalker

Fri, 9 Nov 2012 20:27:00 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/doctrine2/pull/505

Message:

Fixes a typo in a variable name in JoinClassPathExpression::dispatch()
Fixes an exception throw: QueryException::invalidPathExpression() expects a PathExpression, not a string
Removes two references to an undefined class AST\ArithmeticPrimary

[DDC-2123] [GH-502] Fix for invalid 'double-ON' SQL generation with entity inheritance type JOINED.

Fri, 9 Nov 2012 21:25:07 +0000

This issue is created automatically through a Github pull request on behalf of gwis:

Url: https://github.com/doctrine/doctrine2/pull/502

Message:

In SqlWalker::walkJoin(), SqlWalker::walkRangeVariableDeclaration() can be
called which may produce an 'ON' clause if the entity inheritance type is
JOINED. As walkJoin() may then produce another ON clause, this results in
invalid SQL (e.g. '... ON foo = bar ON (baz = quux) ...' when the inheritance
type is JOINED.

This adds a test and a fix for the problem, by checking for an inheritance type
of JOINED in walkJoin() and using AND instead of ON in the appropriate place.

It seems like this part of the code is begging to be refactored. This is my
first foray into Doctrine internals and can't see a way to do this without
stomping all over the rest of the code, but this section seems ripe for cleanup
by somebody who is familiar.

[DDC-2122] [GH-501] Allow 0 id for Entity

Fri, 9 Nov 2012 20:42:20 +0000

This issue is created automatically through a Github pull request on behalf of jeremymarc:

Url: https://github.com/doctrine/doctrine2/pull/501

Message:

When using a 0 id, it's throwing InvalidArgumentException (Binding entities to query parameters only allowed for entities that have an identifier.)��

[DDC-2121] EntityGenerator generates bad type hint (missing \)

Fri, 9 Nov 2012 19:58:53 +0000

Having an Entity class with this property declaration :

/**
 * @ORM\OneToMany(targetEntity="Plan", mappedBy="Dossier")
 * @var Plan[]
 **/
protected $Plans;

Getter & Setter are generated this way :

/**
 * Add Plans
 *
 * @param se\JpsBundle\Entity\Plan $plans
 * @return Dossier
 */
public function addPlan(\se\JpsBundle\Entity\Plan $plans)
{
  $this->Plans[] = $plans;
  return $this;
}

Problem lies in the

@param se\JpsBundle\Entity\Plan $plans

Should be :

\se\JpsBundle\Entity\Plan $plans

Same thing for Doctrine Collection class.

[DDC-2116] [GH-498] Improve DocBlock annotations of generated entities

Fri, 9 Nov 2012 21:24:42 +0000

This issue is created automatically through a Github pull request on behalf of lanthaler:

Url: https://github.com/doctrine/doctrine2/pull/498

Message:

Currently, the DocBlock annotations for member variables contain the variable name as description which is redundant and should be removed. Furthermore the class is annotated with the FQN instead of just the name. This makes automatically generated documentation quite ugly.

These changes will result in entities that as follows

```
/**

User
*
@ORM\Table()
@ORM\Entity
*/
class User
{
/**
@var string
*
@ORM\Column(name="name", type="string", length=255)
*/
private $name;
```

instead of this:

```
/**

Some\Completely\Random\Namespace\User <--- FQN is not needed here
*
@ORM\Table()
@ORM\Entity
*/
class User
{
/**
@var string $name <--- description is better left blank instead of using variable name
*
@ORM\Column(name="name", type="string", length=255)
*/
private $name;
```

[DDC-2115] [GH-496] Testing for key existance in basicEntityPersister / getIndividualValue

Fri, 9 Nov 2012 20:54:38 +0000

This issue is created automatically through a Github pull request on behalf of arse:

Url: https://github.com/doctrine/doctrine2/pull/496

Message:

wrapping the setting of value with an array_key_exists to prevent a notice from being thrown

[DDC-2113] SQLFilter incorrect results when WHERE clause contains OR expression

Fri, 9 Nov 2012 20:57:58 +0000

When using an SQLFilter, if applied to a query that contains only OR expressions in the WHERE clause, the generated SQL is incorrect.

Example:

SQLFilter returns a constraint like "{$tableAlias}.accountid={$accountId}"
Query: "SELECT u FROM User u WHERE u.fname='bob' OR u.lname='bob'"

Resulting SQL:
"SELECT u FROM User u WHERE u.fname='bob' OR u.lname='bob' AND u.accountid=2"

Expected:
"SELECT u FROM User u WHERE (u.fname='bob' OR u.lname='bob') AND u.accountid=2"

The problem is that the order of operations is wrong. I'm getting users who aren't in account 2, making SQLFilter unreliable.

[DDC-2109] Duplicate joinTableColumns mapping for ManyToMany with resolve target entity

Mon, 12 Nov 2012 14:50:16 +0000

I use the resolve target entity listener quite often for generic code. However I found an issue with ManyToMany relationships, when the target entity is modified by the listener.

The problem is that the _validateAndCompleteManyToManyMapping in PersistentCollection duplicate the joinTableColumns, so this means that when creating an entity, Doctrine send twice the number of parameters, which of course fail.

Here is a test that reproduce the problem.

public function testAssertTableColumnsAreNotAddedInManyToMany()
    {
        $evm = $this->em->getEventManager();
        $this->listener->addResolveTargetEntity(
            'Doctrine\Tests\ORM\Tools\ResolveTargetInterface',
            'Doctrine\Tests\ORM\Tools\ResolveTargetEntity',
            array()
        );
        $this->listener->addResolveTargetEntity(
            'Doctrine\Tests\ORM\Tools\TargetInterface',
            'Doctrine\Tests\ORM\Tools\TargetEntity',
            array()
        );
        $evm->addEventListener(Events::loadClassMetadata, $this->listener);
        $cm = $this->factory->getMetadataFor('Doctrine\Tests\ORM\Tools\ResolveTargetEntity');
        $meta = $cm->associationMappings['manyToMany'];

        $this->assertSame('Doctrine\Tests\ORM\Tools\TargetEntity', $meta['targetEntity']);
        $this->assertEquals(array('resolvetargetentity_id', 'targetinterface_id'), $meta['joinTableColumns']);
    }

[DDC-2086] [GH-484] Prevented "Undefined index" notice when updating

Fri, 9 Nov 2012 21:10:25 +0000

This issue is created automatically through a Github pull request on behalf of jappie:

Url: https://github.com/doctrine/doctrine2/pull/484

Message:

While executing updates on an entity scheduled for update without a change-set, an "Undefined index" notice is raised.

This issue will occur when you manually call $em()->getUnitOfWork()->scheduleForUpdate() on an entity that hasn't changed. The entity will be included in UnitOfWork::$entityUpdates, but because there are no changes, its oid will not be included in UnitOfWork::$entityChangeSets.

I know I'm misusing scheduleForUpdate() a bit in this case, but the notice can easily be prevented with a !empty().

[DDC-2082] [GH-481] check for false as a return value from get_parent_class(), not null

Fri, 9 Nov 2012 21:01:32 +0000

This issue is created automatically through a Github pull request on behalf of beejeebus:

Url: https://github.com/doctrine/doctrine2/pull/481

Message:

MappingException::identifierRequired() and MappingException::classIsNotAValidEntityOrMappedSuperClass() both check for null, when they should check for false from get_parent_class().

[DDC-2080] Entity's association changes after first call

Mon, 15 Oct 2012 15:02:55 +0000

i am using the latest version of doctrine: 2.3

when you call a generated association function, the first time everything is fine:

$authors = $book->getBookToAuthors();
//$authors = array(5)
but the second time instead of returning the array of all associations it returns the last hydrated entity:

$authors = $book->getBookToAuthors();
//$authors = BookToAuthor entity
that happens even when there is nothing else happening:

$authors = $book->getBookToAuthors(); //will work
$authors = $book->getBookToAuthors(); //won't work
the function of getBookToAuthors() is:

public function getBookToAuthors()

{ return $this->bookToAuthors; }

and the mapping is as follows:

/**

@var BookToAuthor[]
*
@OneToMany(targetEntity="BookToAuthor", mappedBy="book", cascade= {"persist"}
)
@JoinColumn(name="id", referencedColumnName="book_id", onDelete="cascade")
*/
private $bookToAuthors;
please advise. i don't know what to do...

[DDC-2079] Error in build entities using yml with several inversedJoinColumns

Fri, 9 Nov 2012 21:18:00 +0000

Hello guys, sorry for the bad English found the error during a necessity and would like to post the solution.

Below is an example of my yml relationamento a many to many.

manyToMany:
centroCustos:
targetEntity: Album\Entity\CentroCusto
cascade: ["persist", "merge"]
inversedBy: unidades
joinTable:
name: unidade_centro_custo
joinColumns:
idunidade:
referencedColumnName: idunidade
onDelete: cascade
inverseJoinColumns:
idcentrocusto:
referencedColumnName: idcentrocusto
idpais:
referencedColumnName: idpais
idmundo:
referencedColumnName: idmundo
onDelete: cascade

Well this example is generating this code.

/**

@var \Doctrine\Common\Collections\ArrayCollection
*
@ORM\ManyToMany(targetEntity="Album\Entity\CentroCusto", inversedBy="unidades", cascade= {"persist","merge"}
)
@ORM\JoinTable(name="unidade_centro_custo",
joinColumns= { * @ORM\JoinColumn(name="idunidade", referencedColumnName="idunidade", onDelete="cascade") * }
,
inverseJoinColumns= { * @ORM\JoinColumn(name="idcentrocusto", referencedColumnName="idcentrocusto") * @ORM\JoinColumn(name="idpais", referencedColumnName="idpais") * @ORM\JoinColumn(name="idmundo", referencedColumnName="idmundo", onDelete="cascade") * }
)
*/

Notice that Doctrine 2 is not putting commas to separate JoinColumns.

So looking at the source code I found the following code and put it solved my problem.

The changes was performed in EntityGenerator.php line 1090.

$arrJoins = array();
foreach ($associationMapping['joinTable']['joinColumns'] as $joinColumn)

{ $arrJoins[] = $this->spaces . ' * ' . $this->generateJoinColumnAnnotation($joinColumn); }

$lines[] = implode(",". PHP_EOL, $arrJoins);
$lines[] = $this->spaces . ' * },';
$lines[] = $this->spaces . ' * inverseJoinColumns={';

$arrJoinsInverse = array();
foreach ($associationMapping['joinTable']['inverseJoinColumns'] as $joinColumn)

{ $arrJoinsInverse[] = $this->spaces . ' * ' . $this->generateJoinColumnAnnotation($joinColumn); }

$lines[] = implode(",". PHP_EOL, $arrJoinsInverse);
$lines[] = $this->spaces . ' * }';
$lines[] = $this->spaces . ' * )'; }

I hope you understand what I'm trying to say, for you do not know if this error occurred, but if there ocorrei is one possible solution.

Thank you.

[DDC-2074] ManyToManyPersister not found in the chain configured namespaces

Sun, 25 Nov 2012 20:10:52 +0000

The error is: "The class 'Doctrine\ORM\Persisters\ManyToManyPersister' was not found in the chain configured namespaces"

Replicate by making an entity which has a property which is self referencing; e.g. http://docs.doctrine-project.org/en/latest/reference/association-mapping.html#many-to-many-self-referencing .

For example an Album could be related to any other similar albums. An album entity would have a property 'relatedAlbums' which is an ArrayCollection. Similarly, I could be working on a CMS where any piece of content could be related to any other in order to show a "related content" or "related posts" style list on a web page.

Using Symfony 2.1 and a Symfony Form with FormBuilder make sure to use the 'by_reference' => false to call the setter for the property. In the setter for the property: https://gist.github.com/3879169

A similar question has been asked on StackOverflow: http://stackoverflow.com/questions/12077084/doctrine2-manytomany-self-referencing

[DDC-2073] PersistentCollection::matching() always returns empty collection, when passed criteria's expression is created using ExpressionBuilder::isNull()

Mon, 12 Nov 2012 14:07:01 +0000

This happens because expression created by ExpressionBuilder::isNull() is wrongly translated to SQL using '=' operator instead of 'IS NULL'.

If the collection is already loaded, result is as expected.

[DDC-2072] [GH-477] fixed typo

Fri, 12 Oct 2012 18:31:33 +0000

This issue is created automatically through a Github pull request on behalf of jakoch:

Url: https://github.com/doctrine/doctrine2/pull/477

Message:

[DDC-2071] [GH-476] Replaced the setting of Ids to the whereInQuery with a more performant implementation

Mon, 12 Nov 2012 11:33:14 +0000

This issue is created automatically through a Github pull request on behalf of HarmenM:

Url: https://github.com/doctrine/doctrine2/pull/476

Message:

While working with large datasets in combination with pagination (ie. a pagination window of 100 or more), the performance drastically decreased.

I tracked the problem down to the setting of the parameters. In the old implementation, the parameters are set individually. This pull request sets the parameter as an array to the Query and Walker.

Testing results (# of entities, original performance, improved performance):
32 0,036 0,033
64 0,043 0,037
128 0,065 0,043
256 0,133 0,057
512 0,360 0,088
1024 1,212 0,157
2048 4,462 0,332
4096 17,203 0,818

[DDC-2069] Spaces are not ignored in the "column" list of a uniqueConstraints

Fri, 9 Nov 2012 21:12:38 +0000

In a YAML configuration file

Behavior correct for this:

  uniqueConstraints:
    myConstraint:
      columns: column1,column2

However, if I add a space in the "columns" list:

  uniqueConstraints:
    myConstraint:
      columns: column1, column2

I end up with the following exception:

exception 'Doctrine\DBAL\Schema\SchemaException' with message 'There is no column with name ' column2' on table 'myTable'.

This can be very confusing, especially if (by any chance) you have a line return just on the space in the command line: you never see the space in the exception message.

It seems that YAML allows spaces in lists (http://en.wikipedia.org/wiki/YAML#Lists), but this line doesn't seem to be a YAML list. If it is parsed by Doctrine (split on ","), spaces should be ignored (or trimmed).

[DDC-2068] [GH-474] Fixed bug with comment option not being added to column.

Fri, 12 Oct 2012 18:37:20 +0000

This issue is created automatically through a Github pull request on behalf of okovalov:

Url: https://github.com/doctrine/doctrine2/pull/474

Message:

Title explains everything... =)

[DDC-2067] [GH-473] Fixes bug whereby orphan-removal value in XMLDriver is incorrectly parsed as true

Fri, 12 Oct 2012 19:50:00 +0000

This issue is created automatically through a Github pull request on behalf of mjphaynes:

Url: https://github.com/doctrine/doctrine2/pull/473

Message:

I realise this is very hand wavy and if you require some more information or test cases then I can see about that.

However, just to get the issue logged, as I just spent 3 hours reverse engineering the doctrine code to find this, and it may help someone else.

Basically when reading the XML mapping data from generated XML files the orphan-removal value was being incorrectly parse as 'true' when it was set to 'false' in the mapping file.

I think this is because the XML parser was parsing the attribute as an object and when it was casted a boolean this meant the value became true. To overcome this I first cast the value as a string, and then to a bool.

Let me know if you need more information.

Thanks.

[DDC-2059] Property perceived as dumplicate in composite foreign key

Fri, 5 Oct 2012 18:08:12 +0000

I have the following schema:

CREATE TABLE `user` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  PRIMARY KEY (`id`)
);

CREATE TABLE `project` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `user_id` int(10) unsigned NOT NULL,
  PRIMARY KEY (`id`),
);

CREATE TABLE `project_conversation` (
  `project_id` int(10) unsigned NOT NULL,
  `user_id` int(10) unsigned NOT NULL,
  PRIMARY KEY (`project_id`,`user_id`)
)

I have ommitted the foreign key definitions for better readability. When I execute doctrine:mapping:convert (in Symfony2, but it seems it's a Doctrine2 issue), I get the following error:

[Doctrine\ORM\Mapping\MappingException]                                               
Property "user" in "Project" was already declared, but it must be declared only once

I have tracked down the issue to be caused by the existence of `user_id` in the project table. So basically, because `project_conversation` references `project` which in turn references `user`, `project_conversation` reference to `user` is perceived as duplicate.

I don't think that this should be the expected behavior though. user_id in `project` references the creator of the project while user_id in `project_conversation` references the creator of the conversation and thus I think the schema is valid.

[DDC-2050] [GH-459] Fix DDC-2012

Wed, 3 Oct 2012 10:53:20 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/459

Message:

http://www.doctrine-project.org/jira/browse/DDC-2012

[DDC-2044] [GH-455] Fixed unique-constraint name in XML Exporter

Fri, 5 Oct 2012 18:24:16 +0000

This issue is created automatically through a Github pull request on behalf of radmar:

Url: https://github.com/doctrine/doctrine2/pull/455

Message:

[DDC-2028] [GH-444] Fixed some tyo error in XML Exporter

Fri, 5 Oct 2012 21:17:21 +0000

This issue is created automatically through a Github pull request on behalf of goetas:

Url: https://github.com/doctrine/doctrine2/pull/444

Message:

[DDC-2012] Inserting a new entity with a custom mapping type does not call convertToDatabaseValueSQL() when using InheritanceType("JOINED")

Wed, 3 Oct 2012 11:57:09 +0000

When using class type inheritance - @InheritanceType("JOINED") and inserting new entity with a custom mapping type, custom type method convertToDatabaseValueSQL() is never called.

Here is sample class mapping:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

 
/**
 * @Table(name="item")
 * @Entity
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="type_id", type="smallint")
 * @DiscriminatorMap({1 = "ItemPerson"})
 */
class Item {

	/**
	 * @Column(name="tsv", type="tsvector", nullable=true)
	 */
	protected $tsv;
}

/**
 * @Table(name="item_person")
 * @Entity
 */
class ItemPerson extends Item
{
}

I am using the same custom TsvectorType with simple entities and even Mapped Superclasses and it works perfectly, however on InheritanceType("JOINED") method convertToDatabaseValueSQL() is never called :/
Hope someone knows how to fix this.
Thank you.

[DDC-1958] pager produces wrong results on postgresql

Tue, 9 Apr 2013 20:22:45 +0000

The query build by pager to get the subset of PKs to fetch produces wrong results on potgresql (and probably any database), that conforms to the SQL standard. The standard says, that if you wish to have the results in specific order, then you have to specify that by using an ORDER BY clause. If such a clause is not present the database can return the results in whatever order it sees fit.

Testcase fixtures:

CREATE TABLE test (
    id integer,
    name text
);

INSERT INTO test VALUES (1, 'c');
INSERT INTO test VALUES (2, 'a');
INSERT INTO test VALUES (3, 'e');
INSERT INTO test VALUES (4, 'b');
INSERT INTO test VALUES (5, 'd');
INSERT INTO test VALUES (6, 'a');
INSERT INTO test VALUES (7, 'g');
INSERT INTO test VALUES (8, 'h');
INSERT INTO test VALUES (9, 'e');
INSERT INTO test VALUES (10, 'j');

Passing f.e.

$qb = $this->repository
    ->createQueryBuilder('t')
    ->select('t')
    ->setFirstResult(0)
    ->setMaxResults(5)
    ->addOrderBy('t.name', 'ASC')

to pager produces SQL like this modified for readability

SELECT DISTINCT id FROM (
    SELECT id, name FROM test ORDER BY name
  ) dctrn_result
  LIMIT 5 OFFSET 0

Now there is nothing wrong with this modified query per se, but there is no ORDER BY clause in the outer query so according to the standard the DB can choose whatever order it seems fit. Now mysql chooses the same order, but postgresql does not and it's probably not the only DB doing so.

If you are interested in the results, this is the output I'm seeing:

postgresql: 8,4,1,5,3
mysql : 2,6,4,1,5

I and my coworker came to the standard compliant solution it was also tested on the dataset above on both postgresql and mysql and it produced equal results. We have found only one corner case this won't work and IMHO that can't be fixed. The problem is when you do a sort on a field from a table that is in 1:n relation to the main table.. e.g tables posts and tags, where one post can have a multiple tags and you want your results sorted by a tag.

Recipe for a correct query is:

remember the ORDER BY fields from original query and then remove them
wrap the original query with a DISTINCT query, but add the fields from ORDER BY to the SELECT part of that query and add the whole ORDER BY to the end of it, also add the PK to the order by clause, and add the LIMIT clause
wrap the resulting query into another query and select just the id.

so if I take the example from above the SQL should look like this:

SELECT id FROM (
  SELECT DISTINCT id, name FROM (
    SELECT id, name FROM test
  ) dctrn_result_inner
  ORDER BY name, id LIMIT 5 OFFSET 0
) dctrn_result

[DDC-1241] Additional parameters for EntityRepository::findAll() and EntityRepository::findOneBy()

Fri, 9 Nov 2012 20:34:28 +0000

In the Doctrine 2.1 versions the method EntityRepository::findBy() accepts additional parameters for ordering, limit and offset.
Great feature! (While waiting for it I extended the EntityRepository class and implemented these parameters myself using a QueryBuilder.)

It would be nice for the method EntityRepository::findOneBy() to accept an additional parameter for ordering as well. It could use the following signature:
public function findOneBy(array $criteria, array $orderBy = null);
This would be useful for various cases, for example: finding the newest blog-post.

And maybe update EntityRepository::findAll() as well with the signature:
public function findAll(array $orderBy = null);

Looking forward to your thoughts.