Doctrine Project

[DDC-1800] Paginator results is wrong if your query use order by clause

Tue, 9 Apr 2013 20:03:37 +0000

NOTE: I didn't try this on other database, I'm using Oracle.

if my original fetchJoin query use an order by clause, the results is not keeping the provided order by clause and re-order them by id.

here is my generated query to get the distinct records that get generated:

SELECT distinct ID0
FROM
(
SELECT f0_.id AS ID0, f0_.deal_type_id AS DEAL_TYPE_ID1, f0_.title AS TITLE2, f0_.deal_date AS DEAL_DATE3, f0_.amount AS AMOUNT4,
f0_.abstract AS ABSTRACT5, f0_.created_date AS CREATED_DATE6, f0_.last_updated_date AS LAST_UPDATED_DATE7,
f0_.object_status_id AS OBJECT_STATUS_ID8, f0_.published_date AS PUBLISHED_DATE9, f0_.publishing_status_id AS PUBLISHING_STATUS_ID10,
f1_.id AS ID11, f1_.role_id AS ROLE_ID12, f1_.role_type_id AS ROLE_TYPE_ID13, f2_.id AS ID14, f3_.id AS ID15, f4_.id AS ID16, f5_.id AS ID17,
c6_.id AS ID18, d7_.id AS ID19
FROM fo_deal f0_
INNER JOIN fo_deal_role f1_ ON f0_.id = f1_.deal_id
INNER JOIN fo_people f2_ ON f1_.people_id = f2_.id
INNER JOIN fo_property_deal f3_ ON f0_.id = f3_.deal_id
INNER JOIN fo_property f4_ ON f3_.property_id = f4_.id
LEFT JOIN fo_property_asset f5_ ON f4_.id = f5_.property_id
LEFT JOIN co_asset c6_ ON f5_.asset_id = c6_.id
LEFT JOIN ds_record d7_ ON c6_.ds_id = d7_.id
WHERE f1_.people_id = 2
AND f0_.object_status_id <> 3
AND f0_.publishing_status_id = 2
ORDER BY f0_.deal_date DESC, f0_.published_date DESC
)

running this query I get the id 30, 44 when the inner query return 44, 30

here is the query that should get generated to take care of the order by clause:
SELECT distinct ID0, rownum+
FROM
(
SELECT f0_.id AS ID0, f0_.deal_type_id AS DEAL_TYPE_ID1, f0_.title AS TITLE2, f0_.deal_date AS DEAL_DATE3, f0_.amount AS AMOUNT4,
f0_.abstract AS ABSTRACT5, f0_.created_date AS CREATED_DATE6, f0_.last_updated_date AS LAST_UPDATED_DATE7,
f0_.object_status_id AS OBJECT_STATUS_ID8, f0_.published_date AS PUBLISHED_DATE9, f0_.publishing_status_id AS PUBLISHING_STATUS_ID10,
f1_.id AS ID11, f1_.role_id AS ROLE_ID12, f1_.role_type_id AS ROLE_TYPE_ID13, f2_.id AS ID14, f3_.id AS ID15, f4_.id AS ID16, f5_.id AS ID17,
c6_.id AS ID18, d7_.id AS ID19
FROM fo_deal f0_
INNER JOIN fo_deal_role f1_ ON f0_.id = f1_.deal_id
INNER JOIN fo_people f2_ ON f1_.people_id = f2_.id
INNER JOIN fo_property_deal f3_ ON f0_.id = f3_.deal_id
INNER JOIN fo_property f4_ ON f3_.property_id = f4_.id
LEFT JOIN fo_property_asset f5_ ON f4_.id = f5_.property_id
LEFT JOIN co_asset c6_ ON f5_.asset_id = c6_.id
LEFT JOIN ds_record d7_ ON c6_.ds_id = d7_.id
WHERE f1_.people_id = 2
AND f0_.object_status_id <> 3
AND f0_.publishing_status_id = 2
ORDER BY f0_.deal_date DESC, f0_.published_date DESC
) ORDER BY rownum ASC

To fix this on the Paginator code:

file: ORM/Tools/Pagination/LimitSubqueryOutputWalker.php
method: walkSelectStatement

change:
$sql = sprintf('SELECT b.*, rownum as rn FROM (SELECT DISTINCT %s FROM (%s)) b', // AS _dctrn_result',
implode(', ', $sqlIdentifier), $sql);

for:
$sql = sprintf('SELECT b.*, rownum as rn FROM (SELECT DISTINCT %s, numrow FROM (%s) ORDER BY numrow ASC) b', // AS _dctrn_result',
implode(', ', $sqlIdentifier), $sql);

[DDC-1579] MappedSuperClass and inheritance problem with console generate:entities command

Dependency — Mon, 10 Dec 2012 10:07:12 +0000

I have two classes.

One extends from another. I'm using the annotation @MappedSuperclass
and operates correctly, but when he did the entities generation
through the command console, doctrine adds the property and the
methods of the "father" class in the subclass.

This is a bug of the command console?

Really you should not copy them if you do not extend them. When you
run the update of the database schema, i must delete these fields and
methods added to obtain the desired result.

What happens?

Im usign Symfony 2.

Thanks!!!!

Code:

Father class:

/********************************************************************

/**

@ORM\MappedSuperclass
*/
abstract class ConfigBase
{

/**

@ORM\Column(name="enabled", type="boolean")
*/
protected $enabled;

/**

Set enabled
*
@param boolean $enabled
*/
public function setEnabled($enabled) { $this->enabled = $enabled; }

/**
* Get enabled
*
* @return boolean
*/
public function getEnabled()
{ return $this->enabled; }

}

/********************************************************************

SubClass

/********************************************************************

/**
* @ORM\Entity
*
*/
class UserConfig extends ConfigBase
{
/**
* @var integer $id
*
* @ORM\Column(name="id", type="integer")
* @ORM\Id
* @ORM\GeneratedValue(strategy="AUTO")
*/
protected $id;

/**
* Get id
*
* @return integer
*/
public function getId()
{ return $this->id; }

/************************************************/
/* Auto generated and non desired values */
/************************************************/
/**
* @var boolean $enabled
*/
private $enabled;

/**
* Set enabled
*
* @param boolean $enabled
*/
public function setEnabled($enabled)
{ $this->enabled = $enabled; }

/**

Get enabled
*
@return boolean
*/
public function getEnabled() { return $this->enabled; }

[DDC-2080] Entity's association changes after first call

Mon, 15 Oct 2012 15:02:55 +0000

i am using the latest version of doctrine: 2.3

when you call a generated association function, the first time everything is fine:

$authors = $book->getBookToAuthors();
//$authors = array(5)
but the second time instead of returning the array of all associations it returns the last hydrated entity:

$authors = $book->getBookToAuthors();
//$authors = BookToAuthor entity
that happens even when there is nothing else happening:

$authors = $book->getBookToAuthors(); //will work
$authors = $book->getBookToAuthors(); //won't work
the function of getBookToAuthors() is:

public function getBookToAuthors()

{ return $this->bookToAuthors; }

and the mapping is as follows:

/**

@var BookToAuthor[]
*
@OneToMany(targetEntity="BookToAuthor", mappedBy="book", cascade= {"persist"}
)
@JoinColumn(name="id", referencedColumnName="book_id", onDelete="cascade")
*/
private $bookToAuthors;
please advise. i don't know what to do...

[DDC-2003] DateTime conditions in Criteria objects result in errors

Mon, 17 Sep 2012 11:35:45 +0000

When using DateTime conditions in Criteria objects an error is thrown because of DateTime to string conversion. This is because the `matching` method doesn't use the same functionality as the `findBy` method.

[DDC-2005] [GH-433] DDC-2003 - DateTime conditions in Criteria objects result in errors

Mon, 17 Sep 2012 10:53:20 +0000

This issue is created automatically through a Github pull request on behalf of Josiah:

Url: https://github.com/doctrine/doctrine2/pull/433

Message:

[DDC-2015] [GH-437] Fixes PersistentCollection::matching() when collection is not initialize...

Mon, 17 Sep 2012 10:50:39 +0000

This issue is created automatically through a Github pull request on behalf of sroddy:

Url: https://github.com/doctrine/doctrine2/pull/437

Message:

...d and there are NEW entities in the collection.

If you have a PersistentCollection not already initialized and you add something to it and if you call matching() on it, that method doesn't return the elements you have just added even if they match the criteria.

This fixes the behaviour checking for any matching element that is NEW and merging it in the returned ArrayCollection.

[DDC-2014] [GH-436] Comment fixes

Mon, 17 Sep 2012 10:47:43 +0000

This issue is created automatically through a Github pull request on behalf of Powerhamster:

Url: https://github.com/doctrine/doctrine2/pull/436

Message:

This will update method comments in UnitOfWork and fixes a typo in isCollectionScheduledForDeletion.
It also add a missing use statement in getQuotedIdentifierColumnNames of ClassMetadateInfo.

[DDC-2026] [GH-442] Remove unused code

Mon, 17 Sep 2012 10:34:29 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/442

Message:

This patch remove some unused code.
Sorry, I added this code by mistake, it was part of a old implementation.

@beberlei please backported it to 2.3

[DDC-2027] [GH-443] Allow 'nullable' attribute to be used during XML export

Mon, 17 Sep 2012 10:32:46 +0000

This issue is created automatically through a Github pull request on behalf of cas87:

Url: https://github.com/doctrine/doctrine2/pull/443

Message:

Allows 'nullable' attribute to be used during XML export, something which already worked for me in YamlExport. This addition saved me a lot of time during development; one less difference to deal with between the YAML and XML approach.

Don't know why this was missing, maybe it's me who is missing something, so let me know

[DDC-1977] Undefined index in ParameterTypeInferer

Wed, 29 Aug 2012 12:30:38 +0000

Trying to bind an empty array as a parameter to a raw SQL query results in an undefined index error on line 59.

https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query/ParameterTypeInferer.php#L59

[DDC-1990] [GH-427] Fix ORMInvalidArgumentException factory methods with return instead of throw

Wed, 29 Aug 2012 12:29:03 +0000

This issue is created automatically through a Github pull request on behalf of chEbba:

Url: https://github.com/doctrine/doctrine2/pull/427

Message:

Exception factories should not throw exception but just return them

[DDC-1985] Call to undefined method ProxyException::proxyDirectoryNotWritable

Fri, 17 Aug 2012 04:51:01 +0000

I think it's fairly self explanatory, didn't supply a patch since I had no idea what text you wanted there

PHP Fatal error:  Call to undefined method Doctrine\ORM\Proxy\ProxyException::proxyDirectoryNotWritable() in .../orm/lib/Doctrine/ORM/Proxy/ProxyFactory.php on line 193

[DDC-1843] CLONE -Join columns can't be quoted

Wed, 15 Aug 2012 00:17:24 +0000

Join columns can't be quoted like columns using name="`quoted`". Using annotation driver.

/**
 * @ORM\Table(
 *      name="`category`",
 *      indexes={
 *          @ORM\Index(
 *              name="fk_category_parentId",
 *              columns={"parentId"}
 *          )
 *      },
 *      uniqueConstraints={
 *          @ORM\UniqueConstraint(
 *              name="uq_category_nameParentId",
 *              columns={"name", "parentId"}
 *          )
 *      }
 * )
 */
class Category
{
    /**
     * @ORM\Id
     * @ORM\Column(type="smallint", name="`id`")
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /**
     * @ORM\Column(type="smallint", name="`parentId`", nullable=true)
     */
    protected $parentId;

    /**
     * @ORM\Column(type="string", length=50, name="`name`")
     */
    protected $name;

    /**
     * @ORM\ManyToOne(targetEntity="Category", inversedBy="categories")
     * @ORM\JoinColumn(name="parentId", referencedColumnName="id", onDelete="CASCADE", onUpdate="NO ACTION")
     */
    protected $category;
}

... 


public function load(ObjectManager $manager)
    {
        $parent = new Category();
        $parent->setName('parent');
        $manager->persist($parent);
        $manager->flush();

        $child = new Category();
        $child->setName('parent');
        $child->setParentId($parent->getId());
        $child->setCategory($parent);

        $manager->persist($child);
        $manager->flush();
}

Result: Invalid parameter number: number of bound variables does not match number of tokens

[DDC-1964] [GH-417] Remove unused use statement

Tue, 14 Aug 2012 21:53:35 +0000

This issue is created automatically through a Github pull request on behalf of jonathaningram:

Url: https://github.com/doctrine/doctrine2/pull/417

Message:

[DDC-1982] [GH-424] Create the setCustomHydrationMode function

Tue, 14 Aug 2012 20:49:23 +0000

This issue is created automatically through a Github pull request on behalf of Mezzle:

Url: https://github.com/doctrine/doctrine2/pull/424

Message:

This allows multiple hydrators to be set at once, and also allows for
the customHydrationMode options to be set via DoctrineORMModule

[DDC-451] Add GUID/UUID Id Generator

Mon, 13 Aug 2012 20:27:11 +0000

We should add an IdGenerator that facilitates the DB Vendors UUID()/GUID() generation facilities.

Although these IdGenerators take more space compared to other Generators there are use-cases which can be only solved with this kind of Id Generator.

[DDC-1473] GH-181: make merge copy non persisted properties too

Mon, 6 Aug 2012 23:44:30 +0000

Pull-Request was automatically synchronized

The behavior of merging should be to return a managed object with exactly the same values than the detached one.

The problem was that it only copies persistable properties.

[DDC-1962] [GH-416] [DDC-1961] Fixed parameter type support in Parameter

Tue, 31 Jul 2012 20:45:06 +0000

This issue is created automatically through a Github pull request on behalf of Majkl578:

Url: https://github.com/doctrine/doctrine2/pull/416

Message:

[DDC-1961] BC Break: Explicit parameter type definitions are discarded when using AbstractQuery::setParameter

Tue, 31 Jul 2012 20:44:33 +0000

In 2.2.x it was possible to explicitly specify a type of a parameter in query. In code below, I used a Type::DATE to explicitly say that it should be converted to date type rather than datetime. In 2.3-RC1, it is completely ignored.

// $query instanceof AbstractQuery
$query->setParameter('day', $date, Type::DATE)

Pull request: https://github.com/doctrine/doctrine2/pull/416

[DDC-1718] types generated by Doctrine\ORM\Tools\EntityGenerator (in docblock) are sometimes wrong

Sun, 29 Jul 2012 14:45:22 +0000

"@return smallint" instead of "@return integer"... same for date... etc...

BTW it could be really great to have issues handled by github... (no need to create another account)

[DDC-1925] Bug in UnitOfWork and ManyToMany relations

Sun, 29 Jul 2012 10:12:07 +0000

Lets say, I have entity Forum with ManyToMany relations with User.
I need to validate user changes and I use code like

$uow = $this->getDoctrine()~~>getEntityManager()~~>getUnitOfWork();
$uow->computeChangeSets();
$changeSet = $uow->getEntityChangeSet($forum);
if (.... bla-bla-bla....)

{ $em = $this->getDoctrine()->getEntityManager(); $em->persist($forum); $em->flush(); }

Unfortunately, whenever I try to change manyToMany relations - I got error
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '4-4' for key 'PRIMARY'

If I comment uow code - everything works just great.

It looks like bug in UnitOfWork implementation.

Let me know if you need more details from me.

[DDC-1937] [GH-405] Add possibility to cache annotations wih APC

Sun, 29 Jul 2012 10:00:36 +0000

This issue is created automatically through a Github pull request on behalf of zim32:

Url: https://github.com/doctrine/doctrine2/pull/405

Message:

APC has a bug - after apc_fetch is made, arrays loose their cursors. That is why is_numeric(key(...)) is not working

[DDC-1946] [GH-409] added failing test for refresh with eager fetching

Sun, 29 Jul 2012 09:29:37 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/doctrine2/pull/409

Message:

This is just a failing test case to demonstrate the problem.

[DDC-1941] [GH-407] DDC-1939 - Removing references to non-existing AssociationMapping class

Sun, 29 Jul 2012 07:33:15 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/407

Message:

This fixes ~~DDC-1939~~, which is caused by an overlooked usage of `Doctrine\ORM\Mapping\AssociationMapping`, which was removed.

[DDC-1939] Trying to save ManyToMany relatrionship

Sun, 29 Jul 2012 07:32:46 +0000

When i try to save a many to many relationship i have to following error

Fatal error: Call to a member function getOwner() on a non-object in Doctrine/ORM/Persisters/ManyToManyPersister.php on line 181

It tries to call getOwner on the following array ($mapping)

array(19) {
["fieldName"] => string(10) "privileges"
["joinTable"] => array(4) {
["name"] => string(36) "fsbackend.user_mch_account_privilege"
["schema"] => NULL
["joinColumns"] => array(2) {
[0] => array(6)

{ ["name"] => string(13) "mch_accountid" ["referencedColumnName"] => string(13) "mch_accountid" ["unique"] => bool(false) ["nullable"] => bool(true) ["onDelete"] => NULL ["columnDefinition"] => NULL }

[1] => array(6)

{ ["name"] => string(3) "uid" ["referencedColumnName"] => string(3) "uid" ["unique"] => bool(false) ["nullable"] => bool(true) ["onDelete"] => NULL ["columnDefinition"] => NULL }

}
["inverseJoinColumns"] => array(1) {
[0] => array(6)

{ ["name"] => string(10) "resourceid" ["referencedColumnName"] => string(10) "resourceid" ["unique"] => bool(false) ["nullable"] => bool(true) ["onDelete"] => NULL ["columnDefinition"] => NULL }

}
}
["targetEntity"] => string(21) "Entity\User\Privilege"
["mappedBy"] => NULL
["inversedBy"] => NULL
["cascade"] => array(0) {
}
["indexBy"] => string(10) "resourceid"
["fetch"] => int(2)
["type"] => int(8)
["isOwningSide"] => bool(true)
["sourceEntity"] => string(26) "Entity\Merchant\Membership"
["isCascadeRemove"] => bool(false)
["isCascadePersist"] => bool(false)
["isCascadeRefresh"] => bool(false)
["isCascadeMerge"] => bool(false)
["isCascadeDetach"] => bool(false)
["relationToSourceKeyColumns"] => array(2)

{ ["mch_accountid"] => string(13) "mch_accountid" ["uid"] => string(3) "uid" }

["joinTableColumns"] => array(3)

{ [0] => string(13) "mch_accountid" [1] => string(3) "uid" [2] => string(10) "resourceid" }

["relationToTargetKeyColumns"] => array(1)

{ ["resourceid"] => string(10) "resourceid" }

}

[DDC-1951] [GH-411] Added the new DBAL 2.3 types in the EntityGenerator typehint map

Sun, 29 Jul 2012 07:05:07 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/doctrine2/pull/411

Message:

This fixes the generated typehint for these new types.

@beberlei please backport it in 2.3 too

[DDC-1931] Cache $oid and $className through method calls in UoW internals

Tue, 24 Jul 2012 09:47:32 +0000

As suggested by Johannes Schmitt, calls in UoW can re-use $oid and $className by passing them to the various methods of UoW internals

[DDC-1919] Doctrine fails to escape entity with reserved name in various situations

Thu, 19 Jul 2012 18:27:21 +0000

I have submitted a PR here, fixing part of this issue: https://github.com/doctrine/dbal/pull/166

However, it fails when UPDATE or INSERT is used. I'm using a very simple, and common, entity name: Group. Doctrine is failing to escape this in various situations, causing queries to fail in MySQL due to reserved keywords.

[DDC-1917] [GH-397] Cleanup/removing deprecated metadata drivers

Thu, 12 Jul 2012 07:30:10 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/397

Message:

Removing deprecated drivers that are already available in Doctrine\Common.
This PR depends on doctrine/common#164 and is a BC Break. For now it fails since the referenced git submodule for Doctrine\Common points to a commit that isn't yet in the common repository.

[![Build Status](https://secure.travis-ci.org/Ocramius/doctrine2.png?branch=cleanup/removing-deprecated-metadata-drivers)](http://travis-ci.org/Ocramius/doctrine2)

[DDC-1915] [GH-396] DDC-1893 - Updating configuration to reflect latest Doctrine Common changes

Wed, 11 Jul 2012 23:54:17 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/396

Message:

This PR fixes ~~DDC-1893~~ (http://www.doctrine-project.org/jira/browse/DDC-1893).

The `getDefaultAnnotationDriver` method was changes to stop supporting older incompatible Doctrine Common versions in favour of the newer logic.

Also, changing logic so that the SimpleAnnotationReader is no more the
default one. An additional parameter for the method will allow using it (this is a BC break!)

The CS fixes that were additionally implemented (along with other minor changes
that do not affect BC compatibility are caused by a CS sniff via IDE.

[DDC-1637] Linq-like Filter API for collections

Mon, 9 Jul 2012 15:17:03 +0000

We want an API that allows users to filter collections to subsets on the SQL level during the runtime (not using DQL).

Example:

class Post
{
   private $comments;
   public function getRecentComments()
   {
       return $this->comments->select(Expression::lessThan("commentDate", new \DateTime("-7 days")));
   }
}

The language of this Expressions for selecting entities out of a collection has to be so simple that it works on both arrays and any persistence backed data-source.

The Collection#select() method would return a new collection that is not equal the invoked collection.

[DDC-1848] "QueryException: Invalid parameter number: number of bound variables does not match number of tokens" with "dev-master" of Doctrine\ORM + Pagerfanta.

Sun, 8 Jul 2012 16:35:22 +0000

Using Symfony2 master with Doctrine\ORM master & Pagerfanta paginator (which uses Doctrine paginator internally) causes this exception.

"QueryException: Invalid parameter number: number of bound variables does not match number of tokens". Works fine with the master of Symfony & same version of Pagerfanta, but with 2.2 of Doctrine ORM.

Full app to see it is available here: http://github.com/Sylius/Sylius-Sandbox.

Full trace (without twig and Symfony part)

[1/2] QueryException: Invalid parameter number: number of bound variables does not match number of tokens
in /home/pjedrzejewski/Sylius.org/workspace/Sandbox/vendor/doctrine/orm/lib/Doctrine/ORM/Query/QueryException.php at line 72
at QueryException ::invalidParameterNumber ()
in /home/pjedrzejewski/Sylius.org/workspace/Sandbox/vendor/doctrine/orm/lib/Doctrine/ORM/Query.php at line 255
at Query ->_doExecute ()
in /home/pjedrzejewski/Sylius.org/workspace/Sandbox/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php at line 737
at AbstractQuery ->execute (null, '3')
in /home/pjedrzejewski/Sylius.org/workspace/Sandbox/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php at line 562
at AbstractQuery ->getScalarResult ()
in /home/pjedrzejewski/Sylius.org/workspace/Sandbox/vendor/doctrine/orm/lib/Doctrine/ORM/Tools/Pagination/Paginator.php at line 144
at Paginator ->count ()
at count (object(Paginator))
in /home/pjedrzejewski/Sylius.org/workspace/Sandbox/vendor/pagerfanta/pagerfanta/src/Pagerfanta/Adapter/DoctrineORMAdapter.php at line 75
at DoctrineORMAdapter ->getNbResults ()
in /home/pjedrzejewski/Sylius.org/workspace/Sandbox/vendor/pagerfanta/pagerfanta/src/Pagerfanta/Pagerfanta.php at line 167
at Pagerfanta ->getNbResults ()
in /home/pjedrzejewski/Sylius.org/workspace/Sandbox/vendor/pagerfanta/pagerfanta/src/Pagerfanta/Pagerfanta.php at line 190
at Pagerfanta ->haveToPaginate ()

[DDC-1911] [GH-392] Replaced a shallow-copy with a deep-copy to avoid side effects.

Sun, 8 Jul 2012 16:34:34 +0000

This issue is created automatically through a Github pull request on behalf of egeloen:

Url: https://github.com/doctrine/doctrine2/pull/392

Message:

Hey!

I'm currently using Symfony 2.1 + Doctrine master branch + Pager fanta master branch.

I'm facing a very vicious issue.

The doctrine paginator is able to clone a query with his `cloneQuery` method. This method will only clone the query without this parameters & hints. The issue is the parameters is setted with the `setParameters` method which will only affect the ArrayCollection reference to the new query builder and so, shared the reference between the two queries.

This PR will make a deep-copy of the ArrayCollection instead of a simple shallow-copy.

I'm not sure if this fix is the best solution.

Let me know if you need more information.

[DDC-1893] Doctrine\ORM\Mapping\Driver\AnnotationDriver::create() not updated for new annotation readers

Sun, 8 Jul 2012 16:26:42 +0000

After refactoring of annotation readers, there are new defaults and the current implementation calls undefined method, because Doctrine\Common\Annotations\AnnotationReader has been refactored too. The new way should be probably requiring Doctrine\Common\Annotations\Reader interface as $reader parameter and if not present constructing the default as in Doctrine\ORM\Configuration::create :

AnnotationRegistry::registerFile(_DIR_ . '/Mapping/Driver/DoctrineAnnotations.php');

$reader = new \Doctrine\Common\Annotations\SimpleAnnotationReader();
$reader->addNamespace('Doctrine\ORM\Mapping');
$reader = new \Doctrine\Common\Annotations\CachedReader($reader, new ArrayCache());

[DDC-1657] The Doctrine cli tool does not handle schema correctly.

Sun, 8 Jul 2012 16:22:02 +0000

At first time, sorry for my english and I will be short and brief, the problem is clearly explained in the title and the test is very simple.

The entity

/**
 * Short description.
 *
 * @Entity(repositoryClass="Stonewood\Model\Entity\Repository\Screen")
 * @Table(name="stonewood.screen")
 */
class Screen extends Entity
{

    /**
     * Identifier
     * @var integer
     *
     * @Id
     * @GeneratedValue(strategy="IDENTITY")
     * @Column(name="pk", type="integer", nullable=false)
     */
    private $pk;

    /**
     * Title
     * @var string
     *
     * @Column(name="title", type="string", length=255, nullable=false)
     */
    private $title;

    /**
     * Path
     * @var string
     *
     * @Column(name="path", type="string", length=255, nullable=false)
     */
    private $path;

    /**
     * Register date
     * @var Date
     *
     * @Column(name="ddate", type="date", nullable=false)
     */
    private $ddate;

    /**
     * Avatar
     * @var Stonewood\Model\Entity\Avatar
     *
     * @ManyToOne(targetEntity="Stonewood\Model\Entity\Avatar")
     * @JoinColumn(name="pk_avatar", referencedColumnName="pk", nullable=true, onDelete="CASCADE")
     */
    private $avatar;

    /**
     *
     */
    public function __construct($pk = null, $title = null, $path = null, $ddate = null, $avatar = null) {
        $this->setPk($pk);
        $this->setTitle($title);
        $this->setPath($path);
        $this->setDdate($ddate);
        $this->setAvatar($avatar);
    }

    [...]

}

Before the first deployment

./doctrine orm:schema-tool:update --dump-sql
CREATE TABLE stonewood.screen (pk SERIAL NOT NULL, pk_avatar INT DEFAULT NULL, title VARCHAR(255) NOT NULL, path VARCHAR(255) NOT NULL, ddate DATE NOT NULL, PRIMARY KEY(pk));
CREATE INDEX IDX_D91A7FB3E9032144 ON stonewood.screen (pk_avatar);

During the first deployement

 
./doctrine orm:schema-tool:update --force
Updating database schema...
Database schema updated successfully! "100" queries were executed

I test the application and all work correctly

After this test

 
./doctrine orm:schema-tool:update --dump-sql
ALTER TABLE screen ADD pk SERIAL NOT NULL;
ALTER TABLE screen ADD pk_avatar INT DEFAULT NULL;
ALTER TABLE screen ADD title VARCHAR(255) NOT NULL;
ALTER TABLE screen ADD path VARCHAR(255) NOT NULL;
ALTER TABLE screen ADD ddate DATE NOT NULL;
ALTER TABLE screen ADD CONSTRAINT FK_D91A7FB3E9032144 FOREIGN KEY (pk_avatar) REFERENCES stonewood.avatar (pk) ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE;
CREATE INDEX IDX_D91A7FB3E9032144 ON screen (pk_avatar);
ALTER TABLE screen ADD PRIMARY KEY (pk);

The result is false. I should see Nothing to update - your database is already in sync with the current entity metadata.
In addition, the schema name does not appear, except for foreign key, what must be causing the problem.

[DDC-1912] [GH-393] Updated the classmetadata factory for Common 2.3

Sat, 7 Jul 2012 14:23:19 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/doctrine2/pull/393

Message:

This adds the new method introduced in doctrine/common#162

[DDC-1831] Problem while implement a relation many to many with columns names starting with caps

Fri, 6 Jul 2012 12:41:38 +0000

Hi, In my team we are implementing a solution that involves make a relation many to many.

The problem is that the columns names of the middle table start with caps.

we make correction to ORM to solve this problem. I attach to you the files modify.

[DDC-852] An easy way of generally setting the default id name/foreign key name suffix doctrine uses

Thu, 5 Jul 2012 22:14:31 +0000

Doctrine 2 is currently using "id" as the default name for identifier columns, and "_id" as suffix for corresponding foreign key columns. I think this is quite reasonable in most cases.

Now, assuming that for any reason I wanted to change this to something else for all relationships, currently there does not seem to be any easy way to do it.
You will have to give a complete JoinColumn definition on every single relationship declaration, like (assuming that I want the new ID name to be "dbID"):

/**

@ManyToOne(targetEntity="persistentData\model\import\Whatever", inversedBy="someReferenceThatPointsHere")
@JoinColumn(name="whatever_dbid", referencedColumnName="dbId")
*/

The reason why I am doing this is that I am doing a 1:1 data import based on a data model that is already defined, and it just happens to contain properties named "id",
which unfortunately even have a problem-domain meaning. So instead of mapping those problem-domain properties to something else (breaking my 1:1 convention), or
using something that does have a problem-domain-meaning as a primary key (which I consider bad practice), I thought I might just use purely technical ids and instruct
doctrine to choose a different name for those. This is, fortunately, possible. But unless I am missing something here, it needs to be specified on every single relationship.

It would be great to have a less redundant way of configuring Doctrine to use a different name/suffix generally, e.g. by calling a setter method on the configuration object, like
$configuration->setDefaultIdColumnName().

[DDC-1735] [GH-312] Removed LOCK_EX for writing Proxy class file

Thu, 5 Jul 2012 20:26:50 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/doctrine2/pull/312

Message:

LOCK_EX will not work on NFS and many other networked file systems.

Replaces #307

[DDC-1895] update an entity with an ID column which is a relation instead of a normal field

Thu, 5 Jul 2012 20:00:50 +0000

I got this error when trying to update an entity with an ID column which is a relation instead of a normal field: https://gist.github.com/3399c0ad5e0a44a29f98

Here is the relevant mapping:

<?php

namespace Roompot\TRSBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use Samson\Bundle\TRSBundle\Entity\Registrar;

/**
 * @ORM\Entity
 */
class RegistrarDepartmentMapping
{
    /**
     * @ORM\ManyToOne(targetEntity="RoompotRegistrar")
     * @ORM\JoinColumn(referencedColumnName="person_id")
     * @ORM\Id
     */
    private $registrar;

    /**
     * @ORM\ManyToOne(targetEntity="Department")
     * @ORM\Id
     */
    private $department;

    /**
     * @ORM\Column(type="boolean")
     */
    private $head = false;

    public function getRegistrar()
    {
        return $this->registrar;
    }

    public function setRegistrar(Registrar $registrar)
    {
        if (null !== $this->registrar) {
            throw new \RuntimeException('Cannot change registrar! Remove this entity and create a new one');
        }
        $this->registrar = $registrar;
    }

    public function getDepartment()
    {
        if (null !== $this->registrar) {
            throw new \RuntimeException('Cannot change department! Remove this entity and create a new one');
        }
        return $this->department;
    }

    public function setDepartment(Department $department)
    {
        $this->department = $department;
    }

    public function isHead()
    {
        return $this->head;
    }

    public function setHead($head)
    {
        $this->head = $head;
    }
}

<?php

namespace Roompot\TRSBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use Samson\Bundle\TRSBundle\Entity\Registrar;

/**
 * @ORM\Entity
 */
class RoompotRegistrar extends Registrar
{
    [...]
}

<?php

namespace Samson\Bundle\TRSBundle\Entity;

use Samson\Bundle\AddressBookBundle\Entity\Person;
use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Entity 
 * @ORM\InheritanceType("SINGLE_TABLE")
 * @ORM\DiscriminatorColumn(name="discr", type="string")
 */
abstract class Registrar
{
    /**
     * @ORM\Id
     * @ORM\OneToOne(targetEntity="Samson\Bundle\AddressBookBundle\Entity\Person", cascade={"persist"})
     * @ORM\JoinColumn(nullable=false, onDelete="CASCADE")
     */
    private $person;

    [...]
}

<?php

namespace Samson\Bundle\AddressBookBundle\Entity;

use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Entity(repositoryClass="Samson\Bundle\AddressBookBundle\Entity\PersonRepository")
 */
class Person implements [...]
{
    /**
     * @ORM\Column(type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue
     */
    private $id;

    [...]
}

I was able to fix the error by updating BasicEntityPersister: https://github.com/SamsonIT/doctrine2/compare/fetching_id_column_if_relation

[DDC-1900] Impossibility to override built-in SQL functions

Thu, 5 Jul 2012 19:57:12 +0000

Doctrine doesn't allow to to create own SQL function for DQL if that function is already defined as "built-in". An example could be custom DATE_ADD implementation.
Method FunctionDeclaration() in Doctrine\ORM\Query\Parser gives higher priority to built-in SQL functions, even if they are not
usable for a specific situation, and registering of own datetime function doesn't help. This issue makes it impossible to use some advanced Doctrine extensions,
for example https://github.com/beberlei/DoctrineExtensions that provide fuller implementations.
Considering the fact that someone may want to use ready components provided by the community, and being new to Doctrine can't figure out the way to hack
or workaround this, the issue is a major one.

[DDC-1885] Problem with column quoting on Delete

Wed, 4 Jul 2012 23:24:40 +0000

delete($entity) from BasicEntityPersiter is not considering that the columns might be quoted.

public function delete($entity) {
	$identifier = $this->_em->getUnitOfWork()->getEntityIdentifier($entity);
        $this->deleteJoinTableRecords($identifier);

        $id = array_combine($this->_class->getIdentifierColumnNames(), $identifier);
        $this->_conn->delete($this->_class->getQuotedTableName($this->_platform), $id);
}

The third line:

        $id = array_combine($this->_class->getIdentifierColumnNames(), $identifier);
        // might be fixed in this way (as example):
        foreach ($identifier as $columnName => $value) {
                $id[$this->_class->getQuotedColumnName($columnName, $this->_platform)] = $value;
        }

[DDC-1897] [GH-384] [DDC-1885] Fix quotes in many to many persisters

Wed, 4 Jul 2012 21:57:43 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/384

Message:

http://www.doctrine-project.org/jira/browse/DDC-1885

[DDC-1870] [GH-372] [DDC-1845] QuoteStrategy

Wed, 4 Jul 2012 21:40:00 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/372

Message:

1. 1. QuoteStrategy

http://www.doctrine-project.org/jira/browse/DDC-1845

This patch fix some quote problems using a default quote strategy and allows users find solutions themselves for weird quote cases.

This DBAL PR shoud be merged to fix sqlite tests in : https://github.com/doctrine/dbal/pull/158

There is a lote of new method calls, the performance tests in sqlite are the following :

1. 1. 1. My branch :
```
. testSimpleQueryScalarHydrationPerformance10000Rows - 0.37292098999023 seconds
. testSimpleQueryArrayHydrationPerformance10000Rows - 0.50411009788513 seconds
. testMixedQueryFetchJoinArrayHydrationPerformance10000Rows - 1.1323919296265 seconds
. testSimpleQueryPartialObjectHydrationPerformance10000Rows - 1.0243051052094 seconds
. testSimpleQueryFullObjectHydrationPerformance10000Rows - 4.1673181056976 seconds
. testMixedQueryFetchJoinPartialObjectHydrationPerformance2000Rows - 0.40403699874878 seconds
. testMixedQueryFetchJoinFullObjectHydrationPerformance2000Rows - 0.873291015625 seconds
. 99 CompanyContract: 0.023395
. 99 CompanyContract: 0.019528
. Memory usage before: 111715.53125 KB
. Memory usage after: 110282.875 KB
. Inserted 10000 objects in 5.5240259170532 seconds
. 100 CmsArticle findAll(): 0.018410
. 100 CmsArticle findAll(): 0.014157
. 100 CmsArticle find(): 0.043304
. 100 CmsArticle find(): 0.041451
. 100 CmsGroup: 0.009315
. 100 CmsGroup: 0.009239
. 100 CmsUser: 0.024051
. 100 CmsUser: 0.023655
. Compute ChangeSet 100 objects in 0.040482997894287 seconds

. Time: 19 seconds, Memory: 261.50Mb

```

1. 1. 1. Doctrine Master :
```
. testSimpleQueryScalarHydrationPerformance10000Rows - 0.37668490409851 seconds
. testSimpleQueryArrayHydrationPerformance10000Rows - 0.5009880065918 seconds
. testMixedQueryFetchJoinArrayHydrationPerformance10000Rows - 1.131824016571 seconds
. testSimpleQueryPartialObjectHydrationPerformance10000Rows - 1.037791967392 seconds
. testSimpleQueryFullObjectHydrationPerformance10000Rows - 4.1992859840393 seconds
. testMixedQueryFetchJoinPartialObjectHydrationPerformance2000Rows - 0.41158103942871 seconds
. testMixedQueryFetchJoinFullObjectHydrationPerformance2000Rows - 0.86575293540955 seconds
. 99 CompanyContract: 0.023206
. 99 CompanyContract: 0.020555
. Inserted 10000 objects in 5.4995818138123 seconds
. 100 CmsArticle findAll(): 0.018785
. 100 CmsArticle findAll(): 0.014160
. 100 CmsArticle find(): 0.042067
. 100 CmsArticle find(): 0.041076
. 100 CmsGroup: 0.009478
. 100 CmsGroup: 0.010591
. 100 CmsUser: 0.023727
. 100 CmsUser: 0.023073
. Compute ChangeSet 100 objects in 0.040009021759033 seconds

. Time: 19 seconds, Memory: 260.50Mb
```

[DDC-1877] [GH-376] De-deprecate transaction handling methods

Wed, 4 Jul 2012 19:43:14 +0000

This issue is created automatically through a Github pull request on behalf of lstrojny:

Url: https://github.com/doctrine/doctrine2/pull/376

Message:

As discussed with @beberlei over IRC, deprecating transaction handling methods make the API cleaner but testing of Entity Manager dependent components much messier. Also suggesting to use `$em->getConnection()->beginTransaction()` feels like a violation of the law of demeter.

Therefore this pull request would remove the deprecation warnings from `EntityManager::beginTransaction()`, `EntityManager::commit()`, `EntityManager::rollback()`.

[DDC-1904] [GH-388] Added an empty line feed preceding the return statement

Wed, 4 Jul 2012 19:34:07 +0000

This issue is created automatically through a Github pull request on behalf of fixe:

Url: https://github.com/doctrine/doctrine2/pull/388

Message:

[DDC-1902] [GH-387] fixed typo in command help text

Wed, 4 Jul 2012 19:33:24 +0000

This issue is created automatically through a Github pull request on behalf of shieldo:

Url: https://github.com/doctrine/doctrine2/pull/387

Message:

[DDC-1719] When tablename or field name contains an hyphen it generates an error

Mon, 25 Jun 2012 13:00:31 +0000

In my database I have a table with '-' (hyphen) in the names of the tables and fields. But when mapping using annotations you get a mysql error because it generates a query that is not conform the mysql syntax. When using a hyphen in field or tablename (or others) you have to place it between quotes.

The name of the table can be resolved using quotes in the table name, in code it means:

@Table(name="directory-file") to @Table(name="`directory-file`"), you can't use this solution with the in the fields because the alias (AS in mysql syntax) also contains a '-' . Which results in a mysql error.

Failing code:

/**

@author Laurens
@Entity
@Table(name="directory-file")
*/
class Directory_File {

/** @Id @Column(name="liddirectory-file",type="bigint") @GeneratedValue * */
protected $liddirectory_file;
}

[DDC-1845] Implements a QuoteStrategy to fix quote problems

Mon, 25 Jun 2012 12:59:58 +0000

As discussed to fix http://www.doctrine-project.org/jira/browse/DDC-1719
and other quote problems we need a quote strategy.

The QuoteStrategy should implements methods like :

function getColumnName($fieldName, ClassMetadata $class)
function getTableName(ClassMetadata $class)
function getJoinTableName($relation, ClassMetadata $class)
function getIdentifierColumnNames(ClassMetadata $class)
function getColumnAlias($columnName, $counter, ClassMetadata $class = null)

All current quotes will be replaced by one default QuoteStrategy.
That allows users find solutions themselves for weird quote cases.

Related Tickets :

http://www.doctrine-project.org/jira/browse/DDC-1719
http://www.doctrine-project.org/jira/browse/DDC-142
http://www.doctrine-project.org/jira/browse/DDC-1843
http://www.doctrine-project.org/jira/browse/DDC-1831

[DDC-937] doctrine-mapping.xsd sequence relation-entities

Sat, 23 Jun 2012 04:31:23 +0000

I noticed some problems with
the doctrine-mapping.xsd (which apparently is not used to validate the
mapping, but only provided to support code completion in your xml-
editor)

The order in which you define the elements like cascade and join-
column(s) for the relation-entities is currently important since it is
a sequence, but is this really desired? Why force this order? defining
cascade before join-column would make perfect sense as well, doesn't
it.

[DDC-1862] [GH-365] DDC-1860 - Composer arbitrary for CLI and composer/autoload.php in different paths

Fri, 22 Jun 2012 06:12:10 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/365

Message:

DDC-1860 - Composer became a requirement to run CLI some time ago. This patch:

1. Makes composer optional if the user defines his own autoloaders in `cli-config.php`
2. Makes the CLI look for `vendor/composer.php` in various parent paths of the `bin` directory.

[DDC-1849] Paginator: The Parameter Types are not set in Function cloneQuery

Fri, 22 Jun 2012 06:07:47 +0000

The Parameter-Types are not set in the Function cloneQuery in the Paginator-Class (Doctrine/ORM/Tools/Pagination/Paginator.php line 172):

$cloneQuery->setParameters($query->getParameters());

But it should be:

$cloneQuery->setParameters($query->getParameters(), $query->getParameterTypes());

[DDC-1873] [GH-373] Grammar fix for composer.json file

Fri, 22 Jun 2012 05:55:25 +0000

This issue is created automatically through a Github pull request on behalf of bschaeffer:

Url: https://github.com/doctrine/doctrine2/pull/373

Message:

[DDC-1869] [GH-371] set permissions as expected by composer.phar update

Fri, 22 Jun 2012 05:54:25 +0000

This issue is created automatically through a Github pull request on behalf of robocoder:

Url: https://github.com/doctrine/doctrine2/pull/371

Message:

I'm guessing the executable permissions were removed from these files recently.

composer.json copies the following scripts (i.e., "bin": ["bin/doctrine", "bin/doctrine.php"], ) to the vendor/bin folder.

When running composer.phar update, and doctrine/orm is to be updated, composer fails because these two scripts have been chmod'd to be executable.

[DDC-1868] [GH-370] Some PHP-CS fixes

Fri, 22 Jun 2012 05:54:06 +0000

This issue is created automatically through a Github pull request on behalf of Ph3nol:

Url: https://github.com/doctrine/doctrine2/pull/370

Message:

[DDC-1855] [GH-363] Entities generator: constructor's template docblock

Fri, 22 Jun 2012 05:53:47 +0000

This issue is created automatically through a Github pull request on behalf of gajdaw:

Url: https://github.com/doctrine/doctrine2/pull/363

Message:

Missing constructor's docblock.

[DDC-1854] [GH-362] Correct some mistakes (tabs & trailing spaces)

Fri, 22 Jun 2012 05:53:16 +0000

This issue is created automatically through a Github pull request on behalf of odolbeau:

Url: https://github.com/doctrine/doctrine2/pull/362

Message:

[DDC-1865] [GH-368] Join poc

Fri, 22 Jun 2012 05:52:45 +0000

This issue is created automatically through a Github pull request on behalf of guilhermeblanco:

Url: https://github.com/doctrine/doctrine2/pull/368

Message:

[DDC-1883] [GH-380] remove svn markers

Fri, 22 Jun 2012 05:52:16 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/380

Message:

[DDC-1881] [GH-379] Fix join-poc merge

Fri, 22 Jun 2012 05:51:02 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/379

Message:

[DDC-1876] [GH-375] Allow passing any callable instead of only closures

Fri, 22 Jun 2012 05:50:31 +0000

This issue is created automatically through a Github pull request on behalf of lstrojny:

Url: https://github.com/doctrine/doctrine2/pull/375

Message:

This patch allows passing any callable to transactional(), not just closures.

[DDC-1866] [GH-369] Show the advice only when relevant.

Fri, 22 Jun 2012 05:50:06 +0000

This issue is created automatically through a Github pull request on behalf of greg0ire:

Url: https://github.com/doctrine/doctrine2/pull/369

Message:

This is indeed a good advice, but people who
already have implemented __toString() might
get confused about it.

[DDC-1878] [GH-377] Fix the documentation link in the README

Fri, 22 Jun 2012 05:49:47 +0000

This issue is created automatically through a Github pull request on behalf of Dinduks:

Url: https://github.com/doctrine/doctrine2/pull/377

Message:

[DDC-1880] Named Queries not processed correctly in XML

Fri, 22 Jun 2012 05:49:00 +0000

When attempting to define named queries in XML mapping, they are not correctly passed through to the ClassMetadataInfo instance.

This is because the attribute syntax ($xmlRoot['named-queries']) is used instead of the child element syntax ({{$xmlRoot->

{'named-queries'}

}}).

[DDC-1497] Orm:generate-entities generates incorrect code when it has multiple relations with the same entity

Sun, 27 May 2012 18:31:27 +0000

Using the same entities, as in the cookbook, when you generate the entities, the add* methods on User, or generally, on the inverse for many type relations are incorrect, and overwrite each other, so you end up with only one add method, that is incorrectly named.

Rework\Model\User:
    type: entity
    table: user
    id:
        id:
            type: integer
            generator:
                strategy: AUTO
    fields:
        name:
            type: string
    oneToMany:
        reportedBugs:
            targetEntity: Bug
            mappedBy: reporter
        assignedBugs:
            targetEntity: Bug
            mappedBy: engineer

Rework\Model\Bug:
    type: entity
    table: bug
    id:
        id:
            type: integer
            generator:
                strategy: AUTO
    fields:
        name:
            type: string
    manyToOne:
        reporter:
            targetEntity: User
            inversedBy: reportedBugs
        engineer:
            targetEntity: User
            inversedBy: assignedBugs

The generated method on User.php

    /**
     * Add reportedBugs
     *
     * @param Rework\Model\Bug $reportedBugs
     */
    public function addBug(\Rework\Model\Bug $reportedBugs)
    {
        $this->reportedBugs[] = $reportedBugs;
    }

What I expected:
The method should be named addReportedBugs, eg. it should be named after the relation, and not the entity's classname.
There should also be two add* methods, instead there is only one.

[DDC-1757] DQL exception when building query with multiple from and join parts

Sun, 27 May 2012 18:02:18 +0000

Query builder creates bad DQL if multiple FROM and JOIN parts are used.

As example such query builder code

$qb->from('A', 'a')
  ->from('B', 'b')
  ->join('b.c', 'c')
  ->join('c.d', 'd');

will generate DQL

...
  FROM A a 
    INNER JOIN c.d d, 
  B b 
    INNER JOIN b.c c
...

but should generate this instead

...
  FROM A a,
  B b 
    INNER JOIN b.c c 
    INNER JOIN c.d d
...

The DQL parser raises exception

Doctrine\ORM\Query\QueryException: [Semantical Error] line 0, col 61 near '.d d, B': Error: Identification Variable c used in join path expression but was not defined before.

[DDC-1784] Error on generate entities: 'Attribute "allocationSize" of @ORM\SequenceGenerator'

Sun, 27 May 2012 17:14:22 +0000

When I generated my entities on version 2.2.2 through "orm:convert-mapping", the sequence has a value ' allocationSize="1", initialValue="1" ' with quotes.

So I received an error:

Attribute "allocationSize" of @ORM\SequenceGenerator declared on property entities\Test::$id expects a integer, but got string.

To fix, I removed the quotes. is It a bug?

Part of entity generated:

/**

@var integer $id
*
@ORM\Column(name="id", type="integer", precision=0, scale=0, nullable=false, unique=false)
@ORM\Id
@ORM\GeneratedValue(strategy="SEQUENCE")
@ORM\SequenceGenerator(sequenceName="test_id_seq", allocationSize="1", initialValue="1") /* SEE QUOTES ON allocationSize="1", initialValue="1" */
*/
private $id;

[DDC-1798] [GH-342] Fix identifier generator strategy for composite identifier

Sun, 27 May 2012 16:47:15 +0000

This issue is created automatically through a Github pull request on behalf of jeanmonod:

Url: https://github.com/doctrine/doctrine2/pull/342

Message:

When using the ConvertMappingCommand on a schema that contain a table with a composite key, we got the exception:

Single id is not allowed on composite primary key in entity CollectionFields

This can be fix by setting the identifier strategy to NONE for composite identifier fields

[DDC-1685] Using the CountWalker on an entity with ID on OneToOne field fails

Sun, 27 May 2012 16:34:04 +0000

When using the CountWalker on an entity which has @Id not on a column, but on a @OneToOne property, a fatal error occurs:

Notice: Undefined index: person in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Mapping\ClassMetadataInfo.php line 2301

In this case I'm using the Paginator by KnpLabs. Here is the trace:

Trace

Notice: Undefined index: person in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Mapping\ClassMetadataInfo.php line 2301
500 Internal Server Error - ErrorException

Stack Trace
in D:\workspace9\roompot\vendor\symfony\src\Symfony\Component\HttpKernel\Debug\ErrorHandler.php at line 65   
        }
        if (error_reporting() & $level && $this->level & $level) {
            throw new \ErrorException(sprintf('%s: %s in %s line %d', isset($this->levels[$level]) ? $this->levels[$level] : $level, $message, $file, $line));
        }
        return false;
at ErrorHandler ->handle ('8', 'Undefined index: person', 'D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Mapping\ClassMetadataInfo.php', '2301', array('field' => 'person', 'platform' => object(MySqlPlatform))) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Mapping\ClassMetadataInfo.php at line 2301    
at ClassMetadataInfo ->getQuotedColumnName ('person', object(MySqlPlatform)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 548    
at SqlWalker ->walkPathExpression (object(PathExpression)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\AST\PathExpression.php at line 56    
at PathExpression ->dispatch (object(SqlWalker)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 2126    
at SqlWalker ->walkArithmeticPrimary (object(PathExpression)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 2105    
at SqlWalker ->walkArithmeticFactor (object(PathExpression)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 2084    
at SqlWalker ->walkArithmeticTerm (object(PathExpression)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 2061    
at SqlWalker ->walkSimpleArithmeticExpression (object(PathExpression)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 1408    
at SqlWalker ->walkAggregateExpression (object(AggregateExpression)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\AST\AggregateExpression.php at line 50    
at AggregateExpression ->dispatch (object(SqlWalker)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 1139    
at SqlWalker ->walkSelectExpression (object(SelectExpression)) 
at array_map (array(object(SqlWalker), 'walkSelectExpression'), array(object(SelectExpression))) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 596    
at SqlWalker ->walkSelectClause (object(SelectClause)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 417    
at SqlWalker ->walkSelectStatement (object(SelectStatement)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\Exec\SingleSelectExecutor.php at line 38    
at SingleSelectExecutor ->__construct (object(SelectStatement), object(SqlWalker)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php at line 192    
at SqlWalker ->getExecutor (object(SelectStatement)) 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query\Parser.php at line 325    
at Parser ->parse () 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query.php at line 230    
at Query ->_parse () 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\Query.php at line 241    
at Query ->_doExecute () 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\AbstractQuery.php at line 643    
at AbstractQuery ->execute (array(), '2') 
in D:\workspace9\roompot\vendor\doctrine\lib\Doctrine\ORM\AbstractQuery.php at line 468    
at AbstractQuery ->getResult ('2') 
in D:\workspace9\roompot\vendor\knp-components\src\Knp\Component\Pager\Event\Subscriber\Paginate\Doctrine\ORM\QuerySubscriber.php at line 45    
at QuerySubscriber ->items (object(ItemsEvent)) 
at call_user_func (array(object(QuerySubscriber), 'items'), object(ItemsEvent)) 
in D:\workspace9\roompot\vendor\symfony\src\Symfony\Bundle\FrameworkBundle\Debug\TraceableEventDispatcher.php at line 124    
at TraceableEventDispatcher ->doDispatch (array(array(object(QueryBuilderSubscriber), 'items'), array(object(QueryBuilderSubscriber), 'items'), array(object(QuerySubscriber), 'items'), array(object(QuerySubscriber), 'items'), array(object(QuerySubscriber), 'items'), array(object(QuerySubscriber), 'items'), array(object(CollectionSubscriber), 'items'), array(object(PropelQuerySubscriber), 'items'), array(object(SolariumQuerySubscriber), 'items'), array(object(ArraySubscriber), 'items')), 'knp_pager.items', object(ItemsEvent)) 
in D:\workspace9\roompot\app\cache\sitwst05_roompot\classes.php at line 3996    
at EventDispatcher ->dispatch ('knp_pager.items', object(ItemsEvent)) 
in D:\workspace9\roompot\app\cache\sitwst05_roompot\classes.php at line 5125    
at ContainerAwareEventDispatcher ->dispatch ('knp_pager.items', object(ItemsEvent)) 
in D:\workspace9\roompot\vendor\symfony\src\Symfony\Bundle\FrameworkBundle\Debug\TraceableEventDispatcher.php at line 72    
at TraceableEventDispatcher ->dispatch ('knp_pager.items', object(ItemsEvent)) 
in D:\workspace9\roompot\vendor\knp-components\src\Knp\Component\Pager\Paginator.php at line 76    
at Paginator ->paginate (object(Query), '1', '25') 
in D:\workspace9\roompot\src\Samson\TRSBundle\Controller\RegistrarController.php at line 34    
at RegistrarController ->indexAction () 
at call_user_func_array (array(object(RegistrarController), 'indexAction'), array()) 
in D:\workspace9\roompot\app\cache\sitwst05_roompot\classes.php at line 4241    
at HttpKernel ->handleRaw (object(Request), '1') 
in D:\workspace9\roompot\app\cache\sitwst05_roompot\classes.php at line 4205    
at HttpKernel ->handle (object(Request), '1', true) 
in D:\workspace9\roompot\app\cache\sitwst05_roompot\classes.php at line 5192    
at HttpKernel ->handle (object(Request), '1', true) 
in D:\workspace9\roompot\app\bootstrap.php.cache at line 564    
at Kernel ->handle (object(Request)) 
in D:\workspace9\roompot\web\app_dev.php at line 30

And the entity:

Entity

<?php

namespace Samson\TRSBundle\Entity;

use Samson\AddressBookBundle\Entity\Person;
use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Entity
 */
class Registrar
{
    /**
     * @ORM\Id
     * @ORM\OneToOne(targetEntity="Samson\AddressBookBundle\Entity\Person", cascade={"persist"})
     * @ORM\JoinColumn(nullable=false)
     */
    private $person;

    public function getId()
    {
        return $this->person->getId();
    }

    public function getPerson()
    {
        return $this->person;
    }

    public function setPerson($person)
    {
        $this->person = $person;
    }
}

[DDC-1823] Error with IN and UPPER in the same line

Sun, 27 May 2012 14:47:54 +0000

I have a problem making a DQL query

SELECT c.id, c.name
FROM BrandBundle:Brand c
WHERE UPPER(c.name) IN (:values)

:values is an array of possible names of brands.

The error shown is

[Syntax Error] line 0, col 109: Error: Expected Doctrine\ORM\Query\Lexer::T_IN, got '('

[DDC-1791] Paginator query doesn't work using Oracle

Sun, 27 May 2012 11:25:54 +0000

Ive build a dql query using the queryBuilder and I've passed the queryBuilder to the Paginator object. The sql query failed.

here is the sql query that get executed:

SELECT a.*
FROM
(
SELECT DISTINCT ID0
FROM
(
SELECT
f0_.id AS ID0, f0_.title AS TITLE1,
f1_.id AS ID2,
f2_.id AS ID3, f2_.first_name AS FIRST_NAME4, f2_.middle_name AS MIDDLE_NAME5, f2_.last_name AS LAST_NAME6, f2_.phone AS PHONE7, f2_.url AS URL8,
f2_.email AS EMAIL9, f2_.profile AS PROFILE10, f2_.created_date AS CREATED_DATE11, f2_.last_updated_date AS LAST_UPDATED_DATE12,
f2_.object_status_id AS OBJECT_STATUS_ID13, f2_.published_date AS PUBLISHED_DATE14, f2_.publishing_status_id AS PUBLISHING_STATUS_ID15,
f3_.id AS ID16, f3_.title AS TITLE17, f3_.start_date AS START_DATE18, f3_.end_date AS END_DATE19,
f4_.id AS ID20, f4_.name AS NAME21,
f5_.id AS ID22,
c6_.id AS ID23,
d7_.id AS ID24
FROM fo_deal f0_
INNER JOIN fo_deal_role f1_ ON f0_.id = f1_.deal_id
INNER JOIN fo_people f2_ ON f1_.people_id = f2_.id
INNER JOIN fo_position f3_ ON f2_.id = f3_.people_id
INNER JOIN fo_company f4_ ON f3_.company_id = f4_.id
LEFT JOIN fo_people_asset f5_ ON f2_.id = f5_.people_id
LEFT JOIN co_asset c6_ ON f5_.asset_id = c6_.id
LEFT JOIN ds_record d7_ ON c6_.ds_id = d7_.id
WHERE f2_.object_status_id <> 3
AND f2_.publishing_status_id = 2
ORDER BY f0_.published_date DESC
) AS _dctrn_result
) a
WHERE ROWNUM <= 3

It seems that oracle doesn't accept the AS _dctrn_result. if I remove the AS _dctrn_result in the query, the query works and I get the proper information.

[DDC-1839] [GH-358] Update license for Composer

Sun, 27 May 2012 08:04:02 +0000

This issue is created automatically through a Github pull request on behalf of jalliot:

Url: https://github.com/doctrine/doctrine2/pull/358

Message:

[DDC-1708] [GH-304] by jwage: Allow flushing of many entities by passing an array of entities.

Wed, 23 May 2012 05:04:55 +0000

This issue is created automatically through a Github pull request on behalf of jwage:

Url: https://github.com/doctrine/doctrine2/pull/304

Message:

[DDC-954] Look into deferring foreign key checks until flush finished

Dependency — Wed, 23 May 2012 04:07:56 +0000

There are several timing issues that will be complicated to fix which relate to foreign key checks.

If we could optionally allow people to defer the foreign key checks until flush has fully completed we could simply solve them all, maybe even across all vendors?

[DDC-369] Bulk-Delete on Self-Referencing CTI fails with FK Error

Wed, 23 May 2012 04:07:03 +0000

    public function testDeleteAs()
    {
        $dql = 'DELETE Doctrine\Tests\Models\Company\CompanyEmployee AS p';
        $this->_em->createQuery($dql)->getResult();

        $this->assertEquals(0, count($this->_em->createQuery(
            'SELECT count(p) FROM Doctrine\Tests\Models\Company\CompanyEmployee p')->getResult()));
    }

fails with:

Doctrine\Tests\ORM\Functional\AdvancedDqlQueryTest::testDeleteAs()
Exception: [PDOException] SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`doctrine_tests`.`company_persons`, CONSTRAINT `company_persons_ibfk_1` FOREIGN KEY (`spouse_id`) REFERENCES `company_persons` (`id`))
With queries:
25. SQL: 'DELETE FROM company_persons WHERE (id) IN (SELECT id FROM company_persons_id_tmp)' Params:
24. SQL: 'DELETE FROM company_employees WHERE (id) IN (SELECT id FROM company_persons_id_tmp)' Params:
23. SQL: 'DELETE FROM company_managers WHERE (id) IN (SELECT id FROM company_persons_id_tmp)' Params:
22. SQL: 'INSERT INTO company_persons_id_tmp (id) SELECT t0.id FROM company_employees t0 INNER JOIN company_persons c0_ ON t0.id = c0_.id LEFT JOIN company_managers c1_ ON t0.id = c1_.id' Params:
21. SQL: 'CREATE TEMPORARY TABLE company_persons_id_tmp (id INT NOT NULL, PRIMARY KEY(id))' Params:
20. SQL: 'INSERT INTO company_persons_friends (person_id, friend_id) VALUES (?, ?)' Params: '15', '14'
19. SQL: 'INSERT INTO company_persons_friends (person_id, friend_id) VALUES (?, ?)' Params: '15', '13'
18. SQL: 'INSERT INTO company_persons_friends (person_id, friend_id) VALUES (?, ?)' Params: '15', '16'
17. SQL: 'INSERT INTO company_persons_friends (person_id, friend_id) VALUES (?, ?)' Params: '14', '15'
16. SQL: 'INSERT INTO company_persons_friends (person_id, friend_id) VALUES (?, ?)' Params: '14', '13'
15. SQL: 'INSERT INTO company_persons_friends (person_id, friend_id) VALUES (?, ?)' Params: '13', '15'
14. SQL: 'INSERT INTO company_persons_friends (person_id, friend_id) VALUES (?, ?)' Params: '13', '14'
13. SQL: 'INSERT INTO company_persons_friends (person_id, friend_id) VALUES (?, ?)' Params: '16', '15'
12. SQL: 'UPDATE company_persons SET spouse_id = ? WHERE id = ?' Params: '13', '14'
11. SQL: 'UPDATE company_persons SET spouse_id = ? WHERE id = ?' Params: '14', '13'
10. SQL: 'INSERT INTO company_employees (id, salary, department) VALUES (?, ?, ?)' Params: '16', '100000', 'IT'
9. SQL: 'INSERT INTO company_managers (id, title, car_id) VALUES (?, ?, ?)' Params: '16', 'Foo', '4'
8. SQL: 'INSERT INTO company_persons (name, spouse_id, discr) VALUES (?, ?, ?)' Params: 'Roman B.', '', 'manager'
7. SQL: 'INSERT INTO company_cars (brand) VALUES (?)' Params: 'BMW'
6. SQL: 'INSERT INTO company_employees (id, salary, department) VALUES (?, ?, ?)' Params: '15', '800000', 'IT2'
5. SQL: 'INSERT INTO company_persons (name, spouse_id, discr) VALUES (?, ?, ?)' Params: 'Jonathan W.', '', 'employee'
4. SQL: 'INSERT INTO company_employees (id, salary, department) VALUES (?, ?, ?)' Params: '14', '400000', 'IT2'
3. SQL: 'INSERT INTO company_persons (name, spouse_id, discr) VALUES (?, ?, ?)' Params: 'Guilherme B.', '', 'employee'
2. SQL: 'INSERT INTO company_employees (id, salary, department) VALUES (?, ?, ?)' Params: '13', '200000', 'IT'
Trace:
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/DBAL/Connection.php:630
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/Query/Exec/MultiTableDeleteExecutor.php:123
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/Query.php:198
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/AbstractQuery.php:511
/home/benny/code/php/wsnetbeans/Doctrine/trunk/lib/Doctrine/ORM/AbstractQuery.php:349
/home/benny/code/php/wsnetbeans/Doctrine/trunk/tests/Doctrine/Tests/ORM/Functional/AdvancedDqlQueryTest.php:93
/home/benny/code/php/wsnetbeans/Doctrine/trunk/tests/Doctrine/Tests/OrmFunctionalTestCase.php:253

fixture is:

    public function generateFixture()
    {
        $car = new CompanyCar('BMW');

        $manager1 = new CompanyManager();
        $manager1->setName('Roman B.');
        $manager1->setTitle('Foo');
        $manager1->setDepartment('IT');
        $manager1->setSalary(100000);
        $manager1->setCar($car);

        $person2 = new CompanyEmployee();
        $person2->setName('Benjamin E.');
        $person2->setDepartment('IT');
        $person2->setSalary(200000);

        $person3 = new CompanyEmployee();
        $person3->setName('Guilherme B.');
        $person3->setDepartment('IT2');
        $person3->setSalary(400000);

        $person4 = new CompanyEmployee();
        $person4->setName('Jonathan W.');
        $person4->setDepartment('IT2');
        $person4->setSalary(800000);

        $person2->setSpouse($person3);

        $manager1->addFriend($person4);
        $person2->addFriend($person3);
        $person2->addFriend($person4);
        $person3->addFriend($person4);

        $this->_em->persist($car);
        $this->_em->persist($manager1);
        $this->_em->persist($person2);
        $this->_em->persist($person3);
        $this->_em->persist($person4);
        $this->_em->flush();
        $this->_em->clear();
    }

[DDC-890] Association mapping 'One-To-Many, Self-referencing' with cascade and removes fk onDelete=restrict

Wed, 23 May 2012 03:57:44 +0000

By using the association mapping 'One-To-Many, Self-referencing' removes the cascade.

How to follow the example below, and removed the first parent entity after the children entities.

And if you use foreign key onDelete=restrict the referential integrity error

A possible solution in the patch attached below

Category.php

<?php
/** @Table(name="category") */
class Category
{
    /**
     * @Id
     * @Column(name="id")
     */
    public $id;

    /**
     * @OneToMany(targetEntity="Category", mappedBy="parent", cascade={"remove"})
     */
    public $children;

    /**
     * @ManyToOne(targetEntity="Category", inversedBy="children")
     * @JoinColumn(name="parent_id", referencedColumnName="id")
     */
    public $parent;

    public function __construct() {
        $this->children = new \Doctrine\Common\Collections\ArrayCollection();
    }
}
?>

CREATE TABLE `category` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `parent_id` int(10) unsigned DEFAULT NULL,
  `name` varchar(50) NOT NULL,
  PRIMARY KEY (`id`),
  KEY `fk_id_parent_id` (`parent_id`),
  CONSTRAINT `fk_id_parent_id` FOREIGN KEY (`parent_id`) REFERENCES `category` (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=18 DEFAULT CHARSET=utf8 ROW_FORMAT=DYNAMIC

[DDC-1737] MEDIUMTEXT field

Wed, 23 May 2012 03:42:32 +0000

I have a field which I want to be mysql mediumtext
/**

@var string $description
@ORM\Column(name="description", type="string", length=65536)
*/
private $description;

Everything is fine, field created as 'mediumtext'
but whenever I run
php app/console doctrine:schema:update --dump-sql

I get
ALTER TABLE table CHANGE description description MEDIUMTEXT NOT NULL;
though description is MEDIUMTEXT already.

[DDC-1807] [GH-344] Composer modify

Tue, 22 May 2012 18:26:50 +0000

This issue is created automatically through a Github pull request on behalf of Hounddog:

Url: https://github.com/doctrine/doctrine2/pull/344

Message:

Included Bin file into composer
Modified bin dependencies to inclue the Composer Autoload.php
Added Missing Symfony/Console Dependency

[DDC-1826] [GH-349] Fix DDC-1822

Tue, 22 May 2012 17:45:35 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/349

Message:

http://www.doctrine-project.org/jira/browse/DDC-1822

[DDC-1827] [GH-350] Added the branch-alias in the composer.json

Tue, 22 May 2012 17:13:02 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/doctrine2/pull/350

Message:

depends on doctrine/dbal#151

[DDC-1822] Intermediary parent for NoResult and NonUnique Exceptions

Sun, 20 May 2012 05:10:32 +0000

I would like to propose a intermediary parent for the NoResult and NonUnique Exceptions, that is not as high level as ORMEXception, something in between.

The reasoning for this is that sometime si want to get a single object out of the DB, and in case its not there i want to just get a null and carry on. For this I usually need to catch both exceptions as both results might trigger me to do something else, like abort. In some cases i do need to treat each of these in its own way, but in some cases it does not matter to which side the error went, it only matters that its not the expected SingleResult. Catching a ORMException is not adequate as it may include other error which would need to be treated differently.

My proposal would be like:

ORMException -> NotExpectedResultException ->

{NoResult, NonUnique}

Just a more detailed grouping of exceptions. Does this sound like something possible, or am I just nuts?

[DDC-1694] Entity Generator uses wrong DataTypes for docBlocks

Sat, 5 May 2012 11:47:19 +0000

When using the Doctrine\ORM\Tools\EntityGenerator, largely used by Symfony, the wrong data types are used in the docblocks. For example:

@param text $description

Text needs to be converted to "string" in this case. So there needs to be proper Doctrine Data Type to php type as well as the conversion to DBAL that is already done.

Examples:
smallint => int
bigint => int
text => string
datetime => \DateTime,
datetimetz, => \DateTime
etc...

[DDC-1748] [GH-317] Fix DDC-1694

Sat, 5 May 2012 11:45:34 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/317

Message:

http://www.doctrine-project.org/jira/browse/DDC-1694

if I understand right
Probably this code will be replaced by Benjamin's Code Generator.

Any way, for now I think this is a valid issue..

[DDC-1542] GH-221: [Inheritance] Joined: Default discriminator map

Fri, 4 May 2012 21:21:57 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/221

Hi all,

I know this topic was discussed a lot of times, but I wanted to give it a try anyway.

I want the discriminator map to be configured dynamically by doctrine instead of having to manually configure it myself. So I've digged into the code and the only place I've found (yet) to put the necessary code to make this happen is in the Drivers, just when they're loading the mapping information. So far, I've put a very simple piece of code in the AnnotationDriver to give it a try and I wrote a test for it. But before going on I wanted to ask you if it looks ok for you.

I've tested it in an application I'm working on and, so far, it works.

Two things come to mind though:

1) Is there any special case this would cause problems that I don't know of?
2) If not then, Is there a better place to put this code so I don't have to implement it in all drivers? I've been looking at the ClassMetadataFactory class but I didn't find a place to put this code because it seems it's too late to calculate the discriminator map at the time this class is used. So, in case there is no other place, where should I refactor the logic? It feels uncomfortable to create a class just to put this simple logic on, but as drivers don't inherit from any class, I don't see another option.

Thanks!

[DDC-1808] [GH-345] Fixed DDC-1802

Fri, 4 May 2012 20:09:33 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/doctrine2/pull/345

Message:

[DDC-1802] DQL parser issue when using FunctionsReturningStrings(...) NOT LIKE

Fri, 4 May 2012 20:09:10 +0000

If you create a query like the following, you will get an exception:

$em->createQuery( "SELECT e FROM MyEntity e WHERE CONCAT(e.name, e.name2) NOT LIKE '%abc%'" );

The variable $token['type'] is Lexer::T_NOT - https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query/Parser.php#L2238

[DDC-1743] [GH-315] [WIP] Allowing proxies to be passed to ORM public API

Fri, 4 May 2012 18:03:47 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/315

Message:

Basically, following happens:

```php
$proxy = some_unserialization();
$em->persist($proxy); // exception because the class name is not recognized
```

Fortunately, just some replacements of `get_class($entity)` with `Doctrine\Common\Util\ClassUtils::getClass($entity)` fix the issue.

I wanted to leave this as [WIP] because I need some feedback on the test cases. All three tests fail without the patch, while [![Build Status](https://secure.travis-ci.org/Ocramius/doctrine2.png?branch=getclass-on-proxies-refactoring)](http://travis-ci.org/Ocramius/doctrine2) with it applied.

What is a bit tricky is the status of the proxies.

Cases where `$_initialized_ = false;` && `$_identifier = array();` and others fail because of notices and weird issues that are very difficult to hunt down. That is because of the strange nature of proxies obviously. I just wanted to know if this should be somehow fixed in here.

Another issue is probably performance, as there is some minor overhead introduced. What I'd like to know is if https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Util/ClassUtils.php#L56 could be reduced to a `if ($object instanceof Proxy)

{ ... }

[DDC-1768] [GH-330] improved exception message

Fri, 4 May 2012 18:03:02 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/doctrine2/pull/330

Message:

This makes the exception message more helpful. Before you were basically searching a needle in a haystack.

Note that I haven't been able to run the tests because I don't have PHPUnit 3.6 atm, so please check before merging.

[DDC-964] Implement @AssociationOverride and @FieldOverride for MappedSuperclasses

Wed, 2 May 2012 12:35:44 +0000

We should allow to override certain attributes of associations and fields that are defined in a mapped superclass:

1. Fields should allow the Column Name to be different.
2. Associations should allow join columns and join table.

[DDC-1663] Implement @NamedNativeQuery and @SqlResultSetMapping

Wed, 18 Apr 2012 23:47:44 +0000

You may also express queries in the native SQL dialect of your database.
This is useful if you want to utilize database specific features.

The NamedNativeQuery is used to specify a native SQL named query.
The SqlResultSetMapping is used to specify the mapping of the result of a native SQL query.
The NamedNativeQuery and SqlResultSetMapping annotations/xml/yml can be applied to an entity or mapped superclass.

[DDC-1781] [GH-337] Removed dependency on common as required by dbal anyway

Tue, 17 Apr 2012 13:06:18 +0000

This issue is created automatically through a Github pull request on behalf of richardmiller:

Url: https://github.com/doctrine/doctrine2/pull/337

Message:

Not sure if this is the way to resolve this problem or not but I just tried to install dev-master using composer, doctrine/dbal and doctrine/common are both required in the "dev-master" versions but doctrine/dbal requires doctrine/common: >=2.2.0,<=2.2.99 which causes a conflict. Removing the dependency on doctrine/common would allow doctrine/dbal to install the version it requires. If this is not an ok solution then is there an alternative one?

[DDC-1763] Fixing a bug when calling setDiscriminatorMap from multiple sources (ie: from Events::loadClassMetadata and annotation).

Sat, 7 Apr 2012 07:48:16 +0000

We tried to set discriminator map in https://github.com/Netpositive/NetpositiveDiscriminatorMapBundle both from Events::loadClassMetadata and annotation.

Pull request created on 2.1.x, 2.2, master branches.

[DDC-1764] [GH-326] 2.1.x setDiscriminatorMap fix

Sat, 7 Apr 2012 07:47:42 +0000

This issue is created automatically through a Github pull request on behalf of smatyas:

Url: https://github.com/doctrine/doctrine2/pull/326

Message:

Fixing a bug when calling setDiscriminatorMap from multiple sources (ie: from Events::loadClassMetadata and annotation).

http://www.doctrine-project.org/jira/browse/DDC-1763

[DDC-1752] [GH-321] Addition for new cache driver

Sat, 7 Apr 2012 07:24:32 +0000

This issue is created automatically through a Github pull request on behalf of import:

Url: https://github.com/doctrine/doctrine2/pull/321

Message:

New cache driver addition for Doctrine running in ```non-dev``` mode and cache driver is not set.
This cache driver (Redis) was added with doctrine/common#109

[DDC-1766] Reintroduce old result cache as hydration cache

Sat, 7 Apr 2012 07:12:52 +0000

The old result cache should be reintroduced as hydration cache, since it obviously is much faster than just result caching by avoiding hydration.

        $users = $this->_em->createQuery($dql)
                      ->setHydrationCacheProfile(new QueryCacheProfile(null, null, $cache))
                      ->getResult();

[DDC-1746] Throw Exception when setting unknown cascade option

Sun, 1 Apr 2012 09:02:19 +0000

See ~~DDC-1742~~

[DDC-1725] [GH-309] Fix DDC-1686

Fri, 30 Mar 2012 19:57:39 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/309

Message:

[DDC-1726] [GH-310] [DDC-889] Mention parent class for debugging purposes.

Fri, 30 Mar 2012 19:56:28 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/310

Message:

@beberlei I tried to use ClassMetadata#parentClasses but is not loaded at this point.

[DDC-889] Not a mapped superclass or id not found exceptions should mention parent classes

Fri, 30 Mar 2012 19:56:13 +0000

When either the "not an entity or mapped superclass" or the "no id/primary key found" exceptions are thrown the Mapped Parent classes of $cm->parentClasses should be mentioned for debugging purposes.

[DDC-1736] [GH-313] Fixed tests on Windows

Fri, 30 Mar 2012 19:53:12 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/doctrine2/pull/313

Message:

[DDC-1686] Query/Expr/Join getAlias & getJoin

Mon, 26 Mar 2012 12:23:58 +0000

It would be helpfull if we could get the alias and the join properties, much like we can get the alias and from properties from Query/Expr/From

[DDC-1697] DQL Query with key=>value array in parameter

Sun, 25 Mar 2012 03:38:24 +0000

In he method "processParameterValue" in the class Doctrine\ORM\Query line 303, a "for" loop is use for construct the parameter query.

But if in the query parameter we pass a key=>value array, the method throw an error.

A little example :
$aId = array(0 => "Paris", 3 => "Canne", 9 => "St Julien");

$dql = $this->_em->createQueryBuilder();
$dql->select('c.ID')
->from('BOD\ModelBundle\Entity\City', 'c')
->where('c.IC IN (:cityIDs)')
->setParameter('cityIDs', $aId);

return $dql->getQuery()->execute();

The method "processParameterValue" throw an error because he don't found the index 1.

But if we replace the "for" loop by a foreach in Doctrine\ORM\Query::processParameterValue() :
foreach ($value as $keyValue => $oneValue) {
$paramValue = $this->processParameterValue($oneValue);

// TODO: What about Entities that have composite primary key?
$value[$keyValue] = is_array($paramValue) ? $paramValue[key($paramValue)] : $paramValue;
}

It work really fine.

I remain at your disposal for any further information.

Thanks for all!

[DDC-1470] Bad discrimator value give imprecise error exception

Fri, 16 Mar 2012 02:37:21 +0000

When you define a wrong discriminator field in the mapping configuration, doctrine will return the following ErrorException when trying to get an instance of the object:

ErrorException: Notice: Undefined index: in /Users/fmaz/Site/vendor/doctrine/lib/Doctrine/ORM/Internal/Hydration/SimpleObjectHydrator.php line 92

This is not precise enough, an error giving hint on the mapping configuration that is concerned, and on the bad field should be given.

Hope this will help improving the "userfriendlyness"

[DDC-1591] Paginator: ResultVariable cannot be used in HavingClause

Thu, 15 Mar 2012 22:22:50 +0000

Using the QueryBuilder, I'm getting the message

Notice: Undefined index: distance in vendor\doctrine\lib\Doctrine\ORM\Query\SqlWalker.php line 2128

when trying to add a "having" clause for the field "distance", which is defined in the "select" part of the statement:

$queryBuilder
    ->select('myEntity, MY_FUNCTION() AS distance')
    ->having('distance <= 10')
;

[DDC-1687] [GH-298] by sandermarechal: Pagination using SQL walkers

Mon, 12 Mar 2012 08:05:08 +0000

This issue is created automatically through a Github pull request on behalf of sandermarechal:

Url: https://github.com/doctrine/doctrine2/pull/298

Message:

A CountSqlWalker and LimitSubquerySqlWalker have been implemented. By
default the Paginator will use these SQL walkers. When a query already
uses custom SQL walkers, the Paginator will fall back to the existing
TreeWalker implementations. Improvements:

Support for more complex DQL queries using named mixed results with
GROUP BY and HAVING. For example:

SELECT g, u, COUNT(u.id) AS userCount
FROM Entity\Group g LEFT JOIN g.users u
GROUP BY g.id
HAVING userCount > 0

Support for entities with composite primary keys in the CountSqlWalker
and LimitSubquerySqlWalker. Only the WhereInWalker still needs to be
updated for full composite primary key support. But someone smarter
than me needs to look at that and figure out how to build a WHERE IN
query that can select rows based on multiple columns.

[DDC-1696] String support in THEN and ELSE part of CASE expression is broken

Mon, 12 Mar 2012 01:15:12 +0000

The SQL generated when using strings in the THEN and ELSE parts of the CASE expression are not valid.

This testcase will fail:
$this->assertSqlGeneration(
"SELECT g.id, CASE WHEN ((g.id / 2) > 18) THEN 'Foo' ELSE 'Bar' END AS test FROM Doctrine\Tests\Models\CMS\CmsGroup g",
"SELECT c0_.id AS id0, CASE WHEN (c0_.id / 2 > 18) THEN 'Foo' ELSE 'Bar' END AS sclr1 FROM cms_groups c0_"
);

Noticed by a user at github:
https://github.com/doctrine/doctrine2/pull/277
https://github.com/doctrine/doctrine2/pull/278

[DDC-1689] [GH-299] by patrick-mcdougle: Fixed comment for createQuery to include the variable name.

Sun, 11 Mar 2012 21:49:53 +0000

This issue is created automatically through a Github pull request on behalf of patrick-mcdougle:

Url: https://github.com/doctrine/doctrine2/pull/299

Message:

[DDC-1426] Github-PR-115 by mpdeimos: findByXXX does not accept orderBy/limit/offset

Sun, 11 Mar 2012 21:37:45 +0000

Our modification to pass findByXXX functions orderBy/limit/offset params for entity repositories like one is used from normal findBy function.

We're using an if cascade in favor of the call_user_function_array since the latter is considered as slow.

PS: If i need to target this pull request to your master, I'll resubmit - it's just that we're building against a stable codebase.

Reference link: https://github.com/doctrine/doctrine2/pull/115

[DDC-1679] [GH-296] by brikou: According to "Doctrine's implicit CS" and "Symfony's implicit CS" an emp...

Mon, 5 Mar 2012 06:55:34 +0000

This issue is created automatically through a Github pull request on behalf of brikou:

Url: https://github.com/doctrine/doctrine2/pull/296

Message:

...ty line added to the end of the file (...same tweaks like the one pushed for the entity generator)

[DDC-1673] ProxyFactory method generateProxyClasses argument $toDir does not affect anything

Sat, 3 Mar 2012 18:45:04 +0000

See my note in the github changeset - https://github.com/doctrine/doctrine2/commit/a029b284234065a03dab4241b29f0325975eeac6#L1L116.

Full method code on the master - https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L116.

[DDC-1677] [GH-295] by brikou: According to "Doctrine's implicit CS" and "Symfony's implicit CS" an emp...

Sat, 3 Mar 2012 12:24:03 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/doctrine2/pull/295

Message:

...ty line added to the end of the file

[DDC-1616] SchemaTool - CreateCommand should dump "valid" SQL and omit ATTENTION line

Wed, 22 Feb 2012 06:19:20 +0000

When running "doctrine orm:schema-tool:create --dump-sql" it should not omit the semicolon of the last SQL statement (though the current SQL output is also valid and executable) and it should omit the ATTENTION line (or output it as an SQL commented line) as the schema isn't applied/created anyways.

This would make it much easier to write for e.g. the SQL schema to a file for further processing; but might also break systems (e.g. buildsystems) which have a workaround for the above mentioned shortcoming.

[DDC-807] Adding columnDefinition for @DiscriminatorColumn

Tue, 14 Feb 2012 18:28:31 +0000

Current @DiscriminatorColumn does not allow to use a specific column definition. However, in the MySQL world it is quite common to use the ENUM or TINYINT datatype for efficient discriminator columns. It would be great if something like this would be possible:

@DiscriminatorColumn(name="member_type",type="string",columnDefinition="ENUM('ANONYMOUS','FREE','PREMIUM')")

[DDC-1412] DriverChain defaultDriver

Sun, 29 Jan 2012 00:50:05 +0000

The \Doctrine\ORM\Mapping\Driver\DriverChain is a good thing, but a default driver should be a another great thing.

Actually, to use DoctrineExtension Translatable I have to use the DriveChain to add a specific driver for Gedmo\Translatable.
The problem is, that I have to define the same EntityDriver on all my entity in this driver.

$driverChain->addDriver ($entityDriver, 'EntityA');
...
$driverChain->addDriver ($entityDriver, 'EntityB');
$driverChain->addDriver ($translatableDriver, 'Gedmo\Translatable');

It would be really friendly to do
$driverChain->setDefaultDriver ($entityDriver);
$driverChain->addDriver ($translatableDriver, 'Gedmo\Translatable');

I have attach a fix (SVN) for the DriveChain class.

[DDC-1606] Added fix for collection->contains with many-to-many extra lazy fetchMode

Sun, 22 Jan 2012 17:35:27 +0000

That case previously triggered a PHP error along the lines of:

Notice: Undefined index: 0000000062a3a7690000000033c91b26 in doctrine/lib/Doctrine/ORM/UnitOfWork.php line 2202
#0 doctrine/lib/Doctrine/ORM/Persisters/ManyToManyPersister.php(267): Doctrine\ORM\UnitOfWork->getEntityIdentifier(Object(Item))
#1 doctrine/lib/Doctrine/ORM/PersistentCollection.php(411): Doctrine\ORM\Persisters\ManyToManyPersister->contains(Object(Doctrine\ORM\PersistentCollection), Object(Item))
#2 Test.php(71): Doctrine\ORM\PersistentCollection->contains(Object(Item))

Associated PR: https://github.com/doctrine/doctrine2/pull/259

[DDC-1603] Unique key name isn't correctly set

Sun, 22 Jan 2012 17:34:28 +0000

Example :

<unique-constraints>
<unique-constraint columns="permalink" />
<unique-constraint columns="code" />
</unique-constraints>

This will create :
CREATE UNIQUE INDEX UNIQ_6C3BF144F286BC32 ON shows (permalink);
CREATE UNIQUE INDEX 1 ON shows (code);

instead of :
CREATE UNIQUE INDEX UNIQ_6C3BF144F286BC32 ON shows (permalink);
CREATE UNIQUE INDEX UNIQ_6C3BF14477153098 ON shows (code);

The problem comme from SchemaTool, and the first key is a valid result because of "==" instead of "===" inside Table.php.

I have create a PR on Github.

[DDC-1529] Multiple FROM Entities and inheritance

Thu, 19 Jan 2012 04:49:40 +0000

I got a single table inheritance on an object Content (Program, Article, etc...)

when try a simple :

$query = $this->_em->createQuery('
SELECT a, p
FROM SG\CmsBundle\Entity\Article a, SG\ProgramBundle\Entity\Program p');
$query->getResult();

The generated sql is :

SELECT s0_.id AS id0, s0_.title AS title1, s0_.description AS description2, s0_.tags AS tags3, s0_.keywords AS keywords4, s0_.robots AS robots5, s0_.author_name AS author_name6, s0_.fb_description AS fb_description7, s0_.type AS type8, s0_.is_active AS is_active9, s0_.is_deleted AS is_deleted10, s0_.is_published AS is_published11, s0_.published_at AS published_at12, s0_.unpublished_at AS unpublished_at13, s0_.slug AS slug14, s0_.created_at AS created_at15, s0_.updated_at AS updated_at16, s0_.lft AS lft17, s0_.rgt AS rgt18, s0_.root AS root19, s0_.lvl AS lvl20, s1_.id AS id21, s1_.title AS title22, s1_.description AS description23, s1_.tags AS tags24, s1_.keywords AS keywords25, s1_.robots AS robots26, s1_.author_name AS author_name27, s1_.fb_description AS fb_description28, s1_.type AS type29, s1_.is_active AS is_active30, s1_.is_deleted AS is_deleted31, s1_.is_published AS is_published32, s1_.published_at AS published_at33, s1_.unpublished_at AS unpublished_at34, s1_.slug AS slug35, s1_.created_at AS created_at36, s1_.updated_at AS updated_at37, s1_.lft AS lft38, s1_.rgt AS rgt39, s1_.root AS root40, s1_.lvl AS lvl41, s0_.kind AS kind42, s0_.parent_id AS parent_id43, s0_.template_article_id AS template_article_id44, s0_.template_page_id AS template_page_id45, s0_.author_id AS author_id46, s1_.kind AS kind47, s1_.parent_id AS parent_id48, s1_.template_article_id AS template_article_id49, s1_.template_page_id AS template_page_id50, s1_.author_id AS author_id51 FROM sg_content s0_, sg_content s1_ WHERE (s0_.kind IN ('Article') AND AND s1_.kind IN ('Program'))

The only problem is, we got an extra AND at the end of the query, the query should look smthin like this :

SELECT ... WHERE (s0_.kind IN ('Article') AND s1_.kind IN ('Program'))

[DDC-1608] Lazy load more restrict when consuming PersistentCollection trigger actions to *Persisters

Wed, 18 Jan 2012 19:18:35 +0000

Since https://github.com/doctrine/doctrine2/pull/259 we identified an issue with the Persisters that are failing to check for entities that exist in UoW (managed and sched for insert) and are now being checked is they are part of Collection.
Also it missed some tests. It should be easy, just ->persist the entity then triggers Collection actions.

[DDC-1598] ProxyFactory makes assumptions on identifier getter code

Mon, 16 Jan 2012 09:56:15 +0000

As of
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L214
and
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L237
the current ProxyFactory isn't actually checking if the identifier getter has logic in it.
Current checks aren't enough/valid.

In my opinion the check should be matching following:

(public|protected)\s+function\s+getFieldname\s*(\s*)\s+

{\s*\$this\s*->Fieldname\s*;\s*}

Not really experienced with regex, but currently cannot come up with a more secure check.

[DDC-657] DateTime objects casted to string in query results

Sat, 14 Jan 2012 14:59:35 +0000

As we read in the documentation, 'datetime' fields are casted by Doctrine to PHP DateTime class objects. However, when we want to get only certain fields from a table using DQL, Doctrine casts the datetime value to ordinary string. Consider the following example:

Column definition

/**
 * @var DateTime $active
 *
 * @Column(name="registered", type="datetime")
 */
private $registered;

Query

var_dump($em->createQuery('SELECT u.id, u.registered FROM Entities\\User u')->getResult());

Expected result:

The returned row contains DateTime object for 'registered' column.

Actual result:

The returned row contains string for 'registered' column.

If this is an intended feature, first of all, it should be clearly pointed in the documentation that Doctrine types do not apply in such situations, and secondly, I think it is a very bad practice. I use Doctrine and tell him I have a datetime field in order to get Datetime objects automatically, not to deal with manual conversions.

[DDC-1596] Discriminator column has no table alias

Fri, 13 Jan 2012 04:56:41 +0000

Some single table inheritance

Resource.php

/**
 * @Orm\Entity
 * @Orm\Table(name="resource")
 * @Orm\InheritanceType("SINGLE_TABLE")
 * @Orm\DiscriminatorColumn(name="type", type="string")
 * @Orm\DiscriminatorMap({"Container" = "Container", "News"="News"})
 */
abstract class Resource
{
}

$em->getRepository('News')->find($id)
/**
* generate SQL like this: 
* SELECT t0.id AS id1, t0.name AS name2, type FROM resource t0 WHERE t0.id = ? AND t0.type IN ('News')
*/

Column type has no table alias.
I expected SQL like this:

SELECT t0.id AS id1, t0.name AS name2, t0.type FROM resource t0 WHERE t0.id = ? AND t0.type IN ('News')

Proposed patch attached

[DDC-1379] Entity Generator Bug with extended classes

Mon, 9 Jan 2012 14:11:41 +0000

I'm presently using Doctrine 2 in conjunction with Symfony 2 and have come across a bug with the Entity Generator when I'm extending an abstract class. Here's a minor example to demonstrate (please note, any annotations problems or typos are a result of my typing in this ticket. This isn't an actual example, but does accurately show how to reproduce the issue)

Foo.php

abstract class Foo
{
    /**
     * @Column(name="first_name")
     */
    protected $firstName;

     /**
     * @Column(name="last_name")
     */
    protected $lastName;
    /**
     * @ORM\Column(name="is_active", type="boolean")
     */
    protected $isActive;
}

Bar.php

/**
 * @Entity
 */
class Bar extends Foo
{
    /**
     * @Id
     * @Column(type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /**
     * @Column(name="created_at", type="datetime")
     */
    protected $createdAt;
}

Using a setup similar to the above, where Bar extends Foo, there is an issue with the Generator.

1) The generator is redeclaring Foo's properties, as private variables, in Bar

So, opening Bar after running the generator, shows the getters and setters, but shows:
private $firstName;
private $lastName;
private $isActive;

This causes issues because the properties are being recreated as local versions, and their scope is set to private, conflicted with the more open protected version in the abstract class. To me, they shouldn't be placed in Bar because they're declared as protected in Foo and thus Bar has access to them. Also, when they are placed in Bar, the file formatting is messed up around them, suggesting that they were mis-placed in the file.

2) This may or may not be a bug (it may be intended behavior), but... I would think that when running the generator, the getters and setters for the protected properties declared in Foo would be placed in Foo, and not placed in the class(es) that extend Foo (in this case, Bar). If I also have a class Baz that extends Foo, then Bar and Baz will now have copies of the same getFirstName(), getLastName(), and getIsActive() methods, which is unneeded. They can be placed in the parent class, and overridden in the subclasses if more/different functionality/behavior is needed by the subclass.

Hopefully this is a clear example. Please feel free to hit me up for more info!
--mark

[DDC-1561] GH-239: Fix $qb->expr() PHPDoc @return type.

Tue, 3 Jan 2012 21:53:35 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/239

The autocompletion was missing so i was sad.

But hey, it's open source!

[DDC-1572] LIKE expressions doesn't allow the matching pattern to be a string function

Sat, 31 Dec 2011 10:28:29 +0000

Like expressions doesn't allow the matching apttern to be a function returning string like LOWER(column) LIKE LOWER(:param)

Query parsers is returning exception like this:

[Syntax Error] line 0, col 82: Error: Expected Doctrine\ORM\Query\Lexer::T_STRING, got 'LOWER'

It is not possible to construct queries like this:

SELECT u.name FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE UPPER(u.name) LIKE UPPER(:str)

I'll create a pull request on github for this issue.

[DDC-1557] SimpleSelectExpression does not accept DQL functions

Thu, 29 Dec 2011 19:23:20 +0000

SELECT m 
FROM MealBundle:Meal m 
WHERE m.user = :user OR m.user IN (
    SELECT IDENTITY(s.to) 
    FROM SubscriptionBundle:Subscription s 
    WHERE s.from = :user
)

[Syntax Error] line 0, col 82: Error: Expected Doctrine\ORM\Query\Lexer::T_FROM, got '('

[DDC-1185] Make default column naming strategy configurable

Thu, 29 Dec 2011 17:14:41 +0000

Right now, the property name is simply taken as column name. It would be nice if this default naming strategy were made configurable, so that you could plugin for example a camel-cased underscored naming strategy.

[DDC-1550] GH-234: Fix QueryTest#testJoinQueries order

Wed, 28 Dec 2011 07:52:23 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/234

I don't know why, but sometimes postgres change the order by column default.

http://travis-ci.org/#!/doctrine/doctrine2/jobs/428335

I just add ORDER BY, I think that fix the problem.

[DDC-1562] GH-240: fix QueryDqlFunctionTest#testFunctionSubstring order

Wed, 28 Dec 2011 07:48:56 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/240

Hello,

I got the same problem of #234

http://travis-ci.org/#!/FabioBatSilva/doctrine2/jobs/441187

[DDC-1567] GH-242: [UnderscoreNamingStrategy] fix docblock

Wed, 28 Dec 2011 07:46:49 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/242

[DDC-559] Allow table name and column names to be modified by a user-supplied inflector

Sat, 24 Dec 2011 16:46:28 +0000

With the annotation mapping driver, table names default to the same as the class name, and table columns default to the same name as the field (class property) name.

/** @Entity */
class MyEntity // db table will by default be "MyEntity"
{
    // ...

    /**
     * @Column(type="string")
     */
    protected $myProperty; // defaults to table column "myProperty" 
}

It would be great if we could override this behavior by passing in a custom inflector. So for example you could default all camelCase fields to be underscore_separated as column names in the database without needing to manually specify this in the annotations.

[DDC-1065] Exception message unclear when persisting a null object

Thu, 22 Dec 2011 15:33:39 +0000

When persisting a null object in the entity manager, the exception message says "NULL", which is not very helpful. The problem lies at the beginning of Doctrine/ORM/EntityManager::persist(), where the exception should be replaced by:

if ( ! is_object($entity)) {
throw new \InvalidArgumentException(sprintf('Cannot persist variable of type %s. persist() expects an Entity object.', gettype($entity)));
}