Doctrine Project

[DDC-1771] CLI generation of proxies for abstract STI base classes

Sat, 7 Apr 2012 16:17:09 +0000

When I use the CLI tool to generate proxies manually (orm:generate-proxies), a proxy is generated for the abstract entity below, but this proxy is not declared abstract itself. The entity contains abstract methods, and the proxy obviously does not implement these methods, so it, too, must be declared abstract. Because it is not, the next time I try to generate proxies in this manner, I receive a PHP Fatal error:

Class Proxies_CG_\Ranking\AbstractRule contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Ranking\AbstractRule::myAbstractMethod)

My workaround is to delete this proxy first and then regenerate. While a minor inconvenience at this point, it would be great if the proxy generation code could mark proxies as abstract when necessary to avoid these errors.

Thank you.

– Entity

/**

@Entity
@InheritanceType("SINGLE_TABLE")
@DiscriminatorColumn(name="ranking_rule_type_id", type="integer")
@DiscriminatorMap( { * 1 = "ConcreteRuleOne", * 2 = "ConcreteRuleTwo", * 3 = "ConcreteRuleThree" * }
)
@Table(name="ranking_rules")
*/
abstract class AbstractRule
{

– Generated proxy

/**

THIS CLASS WAS GENERATED BY THE DOCTRINE ORM. DO NOT EDIT THIS FILE.
*/
class AbstractRule extends \Ranking\AbstractRule implements \Doctrine\ORM\Proxy\Proxy
{

[DDC-1766] Reintroduce old result cache as hydration cache

Sat, 7 Apr 2012 07:12:52 +0000

The old result cache should be reintroduced as hydration cache, since it obviously is much faster than just result caching by avoiding hydration.

        $users = $this->_em->createQuery($dql)
                      ->setHydrationCacheProfile(new QueryCacheProfile(null, null, $cache))
                      ->getResult();

[DDC-1764] [GH-326] 2.1.x setDiscriminatorMap fix

Sat, 7 Apr 2012 07:47:42 +0000

This issue is created automatically through a Github pull request on behalf of smatyas:

Url: https://github.com/doctrine/doctrine2/pull/326

Message:

Fixing a bug when calling setDiscriminatorMap from multiple sources (ie: from Events::loadClassMetadata and annotation).

http://www.doctrine-project.org/jira/browse/DDC-1763

[DDC-1763] Fixing a bug when calling setDiscriminatorMap from multiple sources (ie: from Events::loadClassMetadata and annotation).

Sat, 7 Apr 2012 07:48:16 +0000

We tried to set discriminator map in https://github.com/Netpositive/NetpositiveDiscriminatorMapBundle both from Events::loadClassMetadata and annotation.

Pull request created on 2.1.x, 2.2, master branches.

[DDC-1705] BasicEntityPersister throws error undefined index

Sun, 1 Apr 2012 10:52:07 +0000

In the BasicEntityPersister in the _getInsertSQL function when you are foreaching the columns you make a check

if (isset($this->_columnTypes[$column]) &&
                        isset($this->_class->fieldMappings[$this->_class->fieldNames[$column]]['requireSQLConversion'])) {
                        $type = Type::getType($this->_columnTypes[$column]);
                        $placeholder = $type->convertToDatabaseValueSQL('?', $this->_platform);
                    }

the problem is in

  isset($this->_class->fieldMappings[$this->_class->fieldNames[$column]]['requireSQLConversion'])

because you are not checking if it is set

$this->_class->fieldNames[$column]

i got that problem when was saving ManyToOne association

[DDC-1698] Inconsistent proxy file name & namespace result in __PHP_Incomplete_Class when unserializing entities

Sun, 6 Jan 2013 13:18:41 +0000

Starting with Doctrine 2.2, the Proxy classes have inconsistent naming with their file name, which raises problems with class autoloading.
For example, a class named Application\Model\User creates the following proxy class:

Application\Proxy\__CG__\Application\Model\User

This class is located in the following file:

Application/Proxy/__CG__ApplicationModelUser.php

But whe we serialize such an entity, then unserialize it in another session, the framework autoloader expects the class to be located in:

Application/Proxy/__CG__/Application/Model/User.php

But it is not.
As a result, a __PHP_Incomplete_Class is created instead of the expected proxy class.

I'm not sure whether this is an intended behavior, but I would assume this is a bug.

[DDC-1695] SQLs for PostgreSQL case sensite tables/fields are wrongly generated

Sun, 11 Mar 2012 22:34:37 +0000

The SQLs for case sensitive schemas in postgreSQL are wronly generated.

Example:
Schema:

CREATE TABLE "News" (
  "IdNews" serial NOT NULL,
  "IdUser" bigint NOT NULL,
  "IdLanguage" integer NOT NULL,
  "IdCondition" integer,
  "IdHealthProvider" integer,
  "IdSpeciality" integer,
  "IdMedicineType" integer,
  "IdTreatment" integer,
  "Title" character varying,
  "SmallText" character varying,
  "LongText" character varying,
  "PublishDate" timestamp with time zone,
  "IdxNews" tsvector,
  "Highlight" boolean NOT NULL DEFAULT false,
  "Order" integer NOT NULL DEFAULT 0,
  "Deleted" boolean NOT NULL DEFAULT false,
  "Active" boolean NOT NULL DEFAULT false,
  "UpdateToHighlighted" boolean DEFAULT false,
  CONSTRAINT "News_pkey" PRIMARY KEY ("IdNews" ));

Object (I added quotes trying to generate the SQLs quoted.:

<?php

namespace GlobalTreatments\ApplicationBundle\Entity;

use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Table(name="""News""")
 * @ORM\Entity
 */
class News
{
    /**
     * @var integer $idNews
     *
     * @ORM\Column(name="""IdNews""", type="integer", nullable=false)
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="SEQUENCE")
     * @ORM\SequenceGenerator(sequenceName="""News_IdNews_seq""", allocationSize="1", initialValue="1")
     */
    private $idNews;

    /**
     * @var bigint $iduser
     *
     * @ORM\Column(name="""IdUser""", type="bigint", nullable=false)
     */
    private $idUser;

    /**
     * @var integer $idLanguage
     *
     * @ORM\Column(name="""IdLanguage""", type="integer", nullable=false)
     */
    private $idLanguage;

    /**
     * @var integer $idCondition
     *
     * @ORM\Column(name="""IdCondition""", type="integer", nullable=true)
     */
    private $idCondition;

    /**
     * @var integer $idHealthProvider
     *
     * @ORM\Column(name="""IdHealthProvider""", type="integer", nullable=true)
     */
    private $idHealthProvider;

    /**
     * @var integer $idSpeciality
     *
     * @ORM\Column(name="""IdSpeciality""", type="integer", nullable=true)
     */
    private $idSpeciality;

    /**
     * @var integer $idMedicineType
     *
     * @ORM\Column(name="""IdMedicineType""", type="integer", nullable=true)
     */
    private $idMedicineType;

    /**
     * @var integer $idTreatment
     *
     * @ORM\Column(name="""IdTreatment""", type="integer", nullable=true)
     */
    private $idTreatment;

    /**
     * @var string $title
     *
     * @ORM\Column(name="""Title""", type="string", nullable=true)
     */
    private $title;

    /**
     * @var string $smallText
     *
     * @ORM\Column(name="""SmallText""", type="string", nullable=true)
     */
    private $smallText;

    /**
     * @var string $longText
     *
     * @ORM\Column(name="""LongText""", type="string", nullable=true)
     */
    private $longText;

    /**
     * @var datetimetz $publishDate
     *
     * @ORM\Column(name="""PublishDate""", type="datetimetz", nullable=true)
     */
    private $publishDate;

    /**
     * @var tsvector $idxNews
     *
     * @ORM\Column(name="""IdxNews""", type="tsvector", nullable=true)
     */
    private $idxNews;

    /**
     * @var boolean $highlight
     *
     * @ORM\Column(name="""Highlight""", type="boolean", nullable=false)
     */
    private $highlight;

    /**
     * @var integer $order
     *
     * @ORM\Column(name="""Order""", type="integer", nullable=false)
     */
    private $order;

    /**
     * @var boolean $deleted
     *
     * @ORM\Column(name="""Deleted""", type="boolean", nullable=false)
     */
    private $deleted;

    /**
     * @var boolean $active
     *
     * @ORM\Column(name="""Active""", type="boolean", nullable=false)
     */
    private $active;

    /**
     * @var boolean $updateToHighlighted
     *
     * @ORM\Column(name="""UpdateToHighlighted""", type="boolean", nullable=true)
     */
    private $updateToHighlighted;

    /**
     * @var condition
     *
     * @ORM\ManyToOne(targetEntity="Condition")
     * @ORM\JoinColumns({
     *   @ORM\JoinColumn(name="""IdCondition""", referencedColumnName="""IdCondition""")
     * })
     */
    private $condition;

    /**
     * @var healthProvider
     *
     * @ORM\ManyToOne(targetEntity="HealthProvider")
     * @ORM\JoinColumns({
     *   @ORM\JoinColumn(name="""IdHealthProvider""", referencedColumnName="""IdHealthProvider""")
     * })
     */
    private $healthProvider;

    /**
     * @var language
     *
     * @ORM\ManyToOne(targetEntity="Language")
     * @ORM\JoinColumns({
     *   @ORM\JoinColumn(name="""IdLanguage""", referencedColumnName="""IdLanguage""")
     * })
     */
    private $language;

    /**
     * @var medicineType
     *
     * @ORM\ManyToOne(targetEntity="MedicineType")
     * @ORM\JoinColumns({
     *   @ORM\JoinColumn(name="""IdMedicineType""", referencedColumnName="""IdMedicineType""")
     * })
     */
    private $medicineType;

    /**
     * @var speciality
     *
     * @ORM\ManyToOne(targetEntity="Speciality")
     * @ORM\JoinColumns({
     *   @ORM\JoinColumn(name="""IdSpeciality""", referencedColumnName="""IdSpeciality""")
     * })
     */
    private $speciality;

    /**
     * @var treatment
     *
     * @ORM\ManyToOne(targetEntity="Treatment")
     * @ORM\JoinColumns({
     *   @ORM\JoinColumn(name="""IdTreatment""", referencedColumnName="""IdTreatment""")
     * })
     */
    private $treatment;

    /**
     * @var user
     *
     * @ORM\ManyToOne(targetEntity="User")
     * @ORM\JoinColumns({
     *   @ORM\JoinColumn(name="""IdUser""", referencedColumnName="""IdUser""")
     * })
     */
    private $user;

    ....

}

DQL:

'SELECT n.smallText, n.publishDate ' .
'FROM News n ' .
	'INNER JOIN n.language la ' .
'WHERE la.languageCode = :languageCode ' .
'ORDER BY n.publishDate DESC'

Generated SQL:

SELECT "0_."SmallText" AS "SmallText"0, "0_."PublishDate" AS "PublishDate"1 FROM "News" "0_ INNER JOIN "Language" "1_ ON "0_."IdLanguage" = "1_."IdLanguage" WHERE "1_."LanguageCode" = ? ORDER BY "0_."PublishDate" DESC LIMIT 6

Notice there are unmattched " in the SQL.

[DDC-1693] SqlWalker doesn't handle LockMode correctly

Sun, 11 Mar 2012 21:30:42 +0000

Both issues are in SqlWalker::walkSelectStatement().
First is a typo on line 443 in master where LockMode::PESSIMISTIC_OPTIMISTIC is used instead of LockMode::OPTIMISTIC. This results in a fatal undefined class constant error.
Additionally, LockMode::NONE is not handled and results in an exception. An empty case will solve that issue.

[DDC-1692] doctrine:mapping:convert on entities without primary key

Wed, 14 Mar 2012 20:11:13 +0000

It issn't possible to use some of the Doctrine tools on entities without primary key.
Following error appears:

PHP Fatal error: Call to a member function getColumns() on a non-object in /media/sf_webdev-shared/Symfony/vendor/doctrine/lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php on line 133

DatabaseDriver tries to get primary key columns without checking if there is any primary key.

[DDC-1683] Doctrine\ORM\Query\Expr\Comparison Doesn't handle boolean values properly

Wed, 14 Mar 2012 19:52:05 +0000

Expected behaviour - Using boolean types in Query Builder

The following works

$qb = $this->getDoctrine()->getEntityManager()->createQueryBuilder();

$qb
    ->select('entity')
    ->from('FooBundle:Entity', 'entity')
    ->where($qb->expr()->eq('entity.visible', true))
;

$query = $qb->getQuery();

return $query->getResult();

The following throws an Doctrine/ORM/Query/QueryException error [Syntax Error] line 0, col -1: Error: Expected Literal, got end of string.

$qb = $this->getDoctrine()->getEntityManager()->createQueryBuilder();

$qb
    ->select('entity')
    ->from('FooBundle:Entity', 'entity')
    ->where($qb->expr()->eq('entity.visible', false))
;

$query = $qb->getQuery();

return $query->getResult();

This is due to Doctrine\ORM\Query\Expr\Comparison::_toString()

public function __toString()
{
    return $this->_leftExpr . ' ' . $this->_operator . ' ' . $this->_rightExpr;
}

When $this->_rightExpr === true type coercion results in 1, but for false it results in an empty string, thus
resulting in invalid SQL.

The following in Doctrine\ORM\Query\Expr\Comparison::__construct() resolves the problem (https://github.com/doctrine/doctrine2/pull/297)

public function __construct($leftExpr, $operator, $rightExpr)
{
    $this->_leftExpr  = $leftExpr;
    $this->_operator  = $operator;
    $this->_rightExpr = $rightExpr === false ? (int) $rightExpr : $rightExpr;
}

[DDC-1648] Primary Keys as Foreign Keys - still not working in Reverse Engineering in 2.1.6

Wed, 14 Mar 2012 20:40:35 +0000

Please, read this old thread - looks like this problem still is not solved

http://comments.gmane.org/gmane.comp.php.symfony.symfony2/1398

>>The primary key as foreign key limitation is from the 2.0 manual. You are using 2.1 with symfony, which supports this. Please use the correct manual.

>> The only problem is that the reverse engineering does not support this. You have to reverse engineer yourself, or write a patch to have Doctrine support this. I would really appreciate it

As I understand it is supported in the "core", but some reverse engineer script is still not using that possibility.
Could you at least point where this can fixed?

[DDC-1629] short namespace in targetEntity dont work

Sat, 3 Mar 2012 21:40:30 +0000

in 2.1.x this work

/**

@ManyToOne(targetEntity="\Db:Cliente", cascade= {"ALL"})
* @JoinColumn(name="cliente", referencedColumnName="telefono", nullable=false)
* @var Db\modelo\Cliente
*/

in 2.2 crash!

PHP Fatal error: Uncaught exception 'Doctrine\\ORM\\Mapping
MappingException' with message 'The target-entity Db:Cliente cannot be found in 'Lanzadora\\modelo
Servicios#cliente'.' ....

to use 2.2, i need update all Entities to this:

/**
* @ManyToOne(targetEntity="\Db\modelo\Cliente", cascade={"ALL"}
)
@JoinColumn(name="cliente", referencedColumnName="telefono", nullable=false)
@var Db\modelo\Cliente
*/

why it change?, is bug or planned?

see ~~DDC-1585~~ !!!

[DDC-1534] ManyToMany Bidirectional Relationships require a defined "joinTable"

Sat, 7 Apr 2012 08:44:27 +0000

In the Mapping when defining a ManyToMany Bi-Directional Association the inversedBy is required on the owning side. Without a joinTable defined, the inversedBy attribute is never read. The joinTable attribute should not be required if using the Mapping Defaults.

A quick glance at the code showed this in Annotations/XML/YML mappings