Doctrine Project

[DDC-1655] PostLoad not getting fired

Wed, 14 Mar 2012 11:03:32 +0000

It appears that @PostLoad is not getting fired in 2.2.0. I have an entity with a list of OneToMany objects. The objects in the one-to-many list have @PostLoad method defined. Using the find method on EntityManager, I can pull in the entity:

$object = EntityManager->find('entity\path\', $id);

then:

$list = $object->getList();
foreach($list as $item) {

}

Each "item" has a @PostLoad method defined. This PostLoad method on each $item gets called successfully in 2.1.5, but it doesn't appear to be getting called in 2.2.0.

This is my first time submitting a bug, so let me know if you need anything else.

[DDC-1668] bug with reading cached annotations in Annotation driver

Sat, 3 Mar 2012 21:25:54 +0000

I had a problem with Class Table Inheritance on first call of a child entity it was working but if call another child in another instance it was not joining with the parent class. After some debugging i found the problem it was not detecting the annotation that is a parent entity to be joined in Doctrine\ORM\Mapping\Driver\AnnotationDriver when the function on line 479 isTransient($className) is called. So after more debugging i found the problem it is in

is_int(key($classAnnotations))

Looks like that after it is cached in and then the cache is read when it returns the array of annotations for the entity class the keys are returned as strings not as integer and if the key is '0' the the value that is_int returns is NULL so the check

 if ($classAnnotations && is_int(key($classAnnotations)))

fails and it does not foreach the the array of annotations.
Also i found that you are making that check in a couple of places so I maid a quick fix for my self in the Doctrine\Common\Annotations\CachedReader which is if annotations are found that are cached before returning them i call array_values

// Attempt to grab data from cache
        if (($data = $this->cache->fetch($cacheKey)) !== false) {
            if (!$this->debug || $this->isCacheFresh($cacheKey, $class)) {
                return array_values($data);
            }
        }

I am using APC cache.

[DDC-1678] When many to many changes but no fields, listeners don't get notified about update.

Sat, 3 Mar 2012 21:19:21 +0000

See https://github.com/doctrine/doctrine2/pull/256

[DDC-1660] Annotation @version is not allowed to be declared on class

Sat, 3 Mar 2012 20:54:07 +0000

I upgraded to Doctrine 2.2 and got following exception:

"Doctrine\Common\Annotations\AnnotationException [Semantical Error] Annotation @version is not allowed to be declared on class SomeEntityClass. You may only use this annotation on these code elements: PROPERTY."

In Doctrine 2.1 no such exception has been thrown. I use following annotation for all my classes in my projects:

@version $Id: SomeEntityClass.php 509 2012-02-03 09:38:48Z mf $

Thus I cannot upgrade to Doctrine 2.2 for now.

[DDC-1652] ArrayHydrator with composite primary key

Sat, 3 Mar 2012 20:11:53 +0000

Hi.

Problem with ArrayHydrator and composite primary key.

Given the following data (PRIMARY KEY (`ancestor_id`,`descendant_id`))

ancestor_id	descendant_id	depth
1	1	0
1	2	1

$query = $em->createQuery("SELECT c,d FROM ResourceClosure c JOIN c.descendant d WHERE c.ancestor = 1");

echo 'ObjectHydrator result count = '.count($query->getResult()).PHP_EOL;
echo 'ArrayHydrator result count = '.count($query->getArrayResult()).PHP_EOL;

Output

ObjectHydrator result count = 2 
ArrayHydrator result count = 1

Expected both counts are equals 2.
In case getArrayResult() in result only first record hydrated, second record are ommited

Below examples model and insertion in db

ResourceClosure

/**
 * @Entity
 */
class ResourceClosure
{
    /**
     * @Id
     * @ManyToOne(targetEntity="Resource")
     * @JoinColumn(name="ancestor_id", referencedColumnName="id")
     *
     */
    private $ancestor;

    /**
     * @Id
     * @ManyToOne(targetEntity="Resource")
     * @JoinColumn(name="descendant_id", referencedColumnName="id")
     * @var Resource
     */
    private $descendant;

    /**
     * @Column(name="depth", type="integer")
     * @var integer
     */
    private $depth;
}

Insertion

$resource1 = new Entity\Resource('resource1');
$em->persist($resource1);

$resource2 = new Entity\Resource('resource2');
$em->persist($resource2);

$em->flush();

$closure1 = new Entity\ResourceClosure();
$closure1->setAncestor($resource1)
                ->setDescendant($resource1)
                ->setDepth(0);

$em->persist($closure1);


$closure2= new Entity\ResourceClosure();
$closure2->setAncestor($resource1)
                ->setDescendant($resource2)
                ->setDepth(1);

$em->persist($closure2);


$em->flush();

P.S.
Its work like expected in case entity ResourceClosure has simple primary key.

[DDC-1667] UniqueConstraint without a 'name' attribute generates Syntax error under postgre

Sat, 3 Mar 2012 18:45:21 +0000

UniqueConstraints without a 'name' attribute generates syntax error on PGSQL ( no error on MSQL )

got a " Syntax error: 7 ERROR: syntax error at or near "ON" "

took me little time to figure out ...

Edit: That was using anotations.

[DDC-1673] ProxyFactory method generateProxyClasses argument $toDir does not affect anything

Sat, 3 Mar 2012 18:45:04 +0000

See my note in the github changeset - https://github.com/doctrine/doctrine2/commit/a029b284234065a03dab4241b29f0325975eeac6#L1L116.

Full method code on the master - https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L116.

[DDC-1661] No unique join column fields for Single Table inheritance type.

Mon, 20 Feb 2012 14:56:47 +0000

https://github.com/doctrine/doctrine2/pull/273

[DDC-1654] OrphanRemoval does not work with One-To-Many, Unidirectional with Join Table

Mon, 20 Feb 2012 09:34:56 +0000

OrphanRemoval is only allowed for one-to-one and one-to-many mappings. But using One-To-Many, Unidirectional with Join Table, the relation will be declared as Many-To-Many with a unique contraint, but the orphan removal flag doesn't work in this case (but should).

[DDC-1658] EntityGenerator allows to null ids associations.

Mon, 20 Feb 2012 08:46:15 +0000

https://github.com/doctrine/doctrine2/pull/287/commits

[DDC-1659] Clear read only entities

Mon, 20 Feb 2012 08:43:20 +0000

https://github.com/doctrine/doctrine2/pull/286

[DDC-1651] APC query caching fails when an entity is bound to a query parameter.

Sat, 18 Feb 2012 15:13:11 +0000

When an entity is bound as a query parameter, query caching with APC fails with error message:

Catchable fatal error: Object of class XXX could not be converted to string in /libs/doctrine-orm/Doctrine/DBAL/Connection.php on line 1081

If I bind with entity's primary key field, everything works fine.

[DDC-1643] PersistentCollection should support clone

Fri, 17 Feb 2012 23:49:12 +0000

I'm trying to clone a PersistentCollection and expect to get a stable snapshot. But the class does not implement __clone, thus both objects refer to the same internal ArrayCollection.

I can't use takeSnapshot because I'm writing generic code that should work with any implementation of Traversable/ArrayAccess.

[DDC-1640] Actual classMetadata is not used when entity with DiscriminatorMap is hydrated, instead AbstractClass metaData is used.

Fri, 17 Feb 2012 22:29:34 +0000

Because the className changes in ObjectHydrator:226 it might be that the ClassMetadata has not been loaded yet.
When the classMetadata has not been loaded the PostLoad events are not executed.

adding the following after the className has changed solves the issue.

$this->_getClassMetadata($className);

example:

Class Session {
    /**
     * @access private
     * @var ArrayCollection
     * @ORM\OneToMany(targetEntity="AbstractService", mappedBy="session")
     */
    public $services;
}

/**
 * @ORM\Entity
 * @ORM\HasLifecycleCallbacks
 * @ORM\InheritanceType("SINGLE_TABLE")
 * @ORM\DiscriminatorColumn(name="type", type="string")
 * @ORM\DiscriminatorMap({
 * 		"A" = "ServiceA",
 * 		"B" = "ServiceB"
 * })
 */
abstract class AbstractService 
{
    /**
     * @access private
     * @var string
     * @ORM\Column()
     */
    private $_status;

    public $status;

    /**
     * @access public
     * @internal Do not use; this is for Doctrine only
     * @ORM\PostLoad
     * @return void
     */
    public function _reconstituteValueObjects()
    {
        $this->status = new Status($this->_status);
    }
}

When I would do now:

foreach ( $session->services as $service ) {
    $service->status->stop();
}

$service would be a concrete class ServceA or ServiceB, but these ClassMetadata's might not be loaded yet. If this is the cause then $service->status will be null as the @PostLoad has not been executed.

[DDC-1556] @PostLoad hook being executed more than once for the same entity when loaded through relationship

Fri, 17 Feb 2012 22:29:19 +0000

Scenario:

Entity mapping: A manytomany B
Hooks: a @PostLoad hook on B
Persisted entities: two instances of A related to the same instance of B

When I load both A's using the EntityManager, and access the instance of B (internally from each A), the @PostLoad hook is being triggered twice instead of once (as there is only one instance of A).

I left an attachment with the code ready to run (please read the README.md to setup the environment).

[DDC-1625] proxy initialized when accessing identifier on extending class

Sun, 5 Feb 2012 10:46:05 +0000

The proxy is always initialized when the entity is extending another class and that parent class has get<IDENTIFIER> method

[DDC-1634] Lazy Proxy ID Method on Inheritance Entities not working

Sun, 5 Feb 2012 10:15:50 +0000

Lazy Proxy ID Method on Inheritance Entities not working