Doctrine Project

[DDC-2148] Many-to-many not working with interface

Thu, 22 Nov 2012 14:28:35 +0000

First off, here's a pastie with all the code and mappings involved, and a stacktrace: http://pastie.org/5372087

Not sure if this a bug or not, but I think that according to the docs this should work - in a vendor bundle I have an entity defining a unidirectional many-to-many relation to an interface: the entity is Group and defines a many-to-many relation to a UserInterface, which is resolved correctly in the app configuration (as the many-to-one relations using it in the other entities of this vendor bundle work fine).

I'm going by these docs:

http://symfony.com/doc/master/cookbook/doctrine/resolve_target_entity.html

However, when adding a user to a group, I'm getting a weird error:

An exception occurred while executing 'INSERT INTO acme_group_user (group_id, user_id) VALUES (?, ?)' with params

{"1":2,"2":1,"3":2,"4":1}

SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens

For some reason it's adding 4 parameters to the statement instead of 2.

Oddly enough, the query generation works perfectly fine when I replace the interface in the mapping with the actual final entity. But that wasn't the point of the exercise... I need to use the interface there.

Also, in other entities in that GroupBundle which are referencing the UserInterface using a different relation type, i.e. many-to-one, the relations work perfectly fine.

The schema validates as well, using doctrine:schema:validate in the console.

[DDC-1653] command line cache clear commands clear everything from caches including non Doctrine related caches

Sat, 3 Mar 2012 17:07:55 +0000

When I run doctrine orm:clear-cache:metadata I noticed that it clears everything within the cache, even items which have nothing to do with Doctrine at all.

In looking into the various driver implementations it seems that the AbstractCache->deleteAll() depends on getIds of each cache driver, yet the getIds of XcacheCache and MemcacheCache drivers seem to just get every single item within the cache.

This has several implications:

clearing metadata cache actually clears query cache and any other Doctrine cache using the same cache driver
clearing Doctrine cache of one project actually clears caches of every project using the same cache container
clearing Doctrine cache clears every object cached within that container, leading to increased risk of cache stampeding

In looking at the stored cache data it seems possible to fix #2 by using the Namespace of that project when executing a cache clear. it also seems possible to use the cache driver's deleteByRegex() to solve #1 by deleting only items listed as metadata cache vs query cache. Fixing #1 and #2 automatically fixes concern #3

Or, as an alternative, I could suggest that deleteAll() in MetaDataCommand should be replaced by:

$cacheIds = $cacheDriver->deleteBySuffix('METADATA');

[DDC-1641] [Tests] Wrong tearDown() in UnitOfWorkTest

Fri, 10 Feb 2012 20:40:28 +0000

root@ubuntu-server-1110:/home/zerkms/src/doctrine2# phpunit
PHPUnit 3.6.10 by Sebastian Bergmann.

Configuration read from /home/zerkms/src/doctrine2/phpunit.xml.dist

.SSSSSS.........................EEEEEEEEEEEEEEEEEEEEEEEEEEEEE 61 / 1472 ( 4%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE.EEESE...SSSEEEEEEEEEEEEEE 122 / 1472 ( 8%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 183 / 1472 ( 12%)
.EEEEEEESSESESEESESEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEFEEEEE 244 / 1472 ( 16%)
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEESE 305 / 1472 ( 20%)
SSSEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEFFFEEEEEEEEEEEEEEEEEE 366 / 1472 ( 24%)
EEEEEEEEEEESSSEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEESSSSSSSSS 427 / 1472 ( 29%)
SSSS...........SEEEEEEEEEEEEEEEEEEEEEEEEEESEEESEEEEEEEEEEEEEE 488 / 1472 ( 33%)
EEEEEEEEEEEEEEEEEEEEEEEEESEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 549 / 1472 ( 37%)
EEEEEEEEEEEEEEEEEEEEEE.EEEEEEEEEEEEE.EEEEEEEEEEESSEEEEEEEEEEE 610 / 1472 ( 41%)
EEEEEEEEEEEEEEEEEEEEEEEEEE................................... 671 / 1472 ( 45%)
............................................................. 732 / 1472 ( 49%)
............................................................. 793 / 1472 ( 53%)
.............................................S............... 854 / 1472 ( 58%)
......S...................................................... 915 / 1472 ( 62%)
............................................................. 976 / 1472 ( 66%)
............................................................. 1037 / 1472 ( 70%)
............................................................. 1098 / 1472 ( 74%)
............................................................. 1159 / 1472 ( 78%)
............................................................. 1220 / 1472 ( 82%)
............................................................. 1281 / 1472 ( 87%)
............................................................. 1342 / 1472 ( 91%)
...........................S............S.................... 1403 / 1472 ( 95%)
.................................SSSSSSSS.PHP Fatal error: Class 'Doctrine\Tests\Mocks\EntityPersisterMock' not found in /home/zerkms/src/doctrine2/tests/Doctrine/Tests/ORM/UnitOfWorkTest.php on line 55

This (the fatal error) happens because of in ORM/Tools/SetupTest there is a condition in setUp() that marks test as skipped, but tearDown() is being invoked anyway (that is how phpunit works).

So tearDown() should run only in case if setUp() hasn't skipped the test, otherwise tearDown() deletes registered autoloaders

PS: other tests failed because I haven't set up any database

[DDC-1620] Partial merge of PR261

Wed, 25 Jan 2012 22:29:59 +0000

The PR261 [1] has two commits, but only one (the first one) was merged to 2.1 and 2.2

[1] - https://github.com/doctrine/doctrine2/pull/261

[DDC-1619] Missing QueryBuilder::distinct() method

Wed, 25 Jan 2012 09:29:40 +0000

The QueryBuilder misses a way to make a query distinct.

[DDC-1618] Query::Iterate() with fetch join exception but no associaiton selected

Tue, 24 Jan 2012 23:04:55 +0000

Iterate with fetch join in class Application\Sonata\NewsBundle\Entity\Post using association tags not allowed.

SELECT o FROM Application\Sonata\NewsBundle\Entity\Post o LEFT JOIN o.tags s_tags LEFT JOIN o.author s_author WHERE ( o.id = :field_4f1f118cf04ff_id_0 OR o.id = :field_4f1f118cf04ff_id_1 OR o.id = :field_4f1f118cf04ff_id_2 )

The SqlWalker.php (line 742) does not check if the association is selected ...

The PR : https://github.com/doctrine/doctrine2/pull/271

[DDC-1617] EntityGenerator does not create uniqueConstraints annotations

Sat, 28 Jan 2012 10:17:42 +0000

I have add some uniqueConstraints in ClassMetadataInfo but the EntityGenerator does not create the annotations for this.

private function _generateTableAnnotation($metadata)
{
    $table = array();

    if (isset($metadata->table['schema'])) {
         $table[] = 'schema="' . $metadata->table['schema'] . '"';
    }

    if (isset($metadata->table['name'])) {
        $table[] = 'name="' . $metadata->table['name'] . '"';
    }

    return '@' . $this->_annotationsPrefix . 'Table(' . implode(', ', $table) . ')';
}

[DDC-1613] Add Pagination Tools

Sun, 22 Jan 2012 17:34:18 +0000

We should add pagination tools to the Doctrine\ORM\Tools\Pagination namespace. There are already 3 libraries out there that share the same code-base:

We should merge the currently best one of this into the code soon, as the cost of maintaining them is very high and their code is pretty stable by now.

[DDC-1612] Cannot call entityManager->flush($entity) with new entity

Sun, 22 Jan 2012 17:34:38 +0000

Following works:
$entity = $em->find('Entity', 1);
$entity->setName('newName');
$em->persist($entity);
$em->flush($entity);

Following does NOT work:
$entity = new Entity();
$entity->setName('newName');
$em->persist($entity);
$em->flush($entity);

[DDC-1610] Associations loaded in 'loadClassMetadata' event are not well initialized inside ClassMetadata

Sat, 21 Jan 2012 12:59:56 +0000

Reproduce
---------------

I have an entity
I'm loading an association (named 'myfield') inside a `LoadClassMetadata` event.

Error
------

Then i get this error : Notice: Undefined index: myfield in /vendor/doctrine/lib/Doctrine/ORM/UnitOfWork.php line 2473

Problem
-----------

It seems that here https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php#L294 we call the method 'wakeupReflection' before the loadClassMetadata event is dispatched.

A solution
-------------

I've created a patch (all tests pass) here https://github.com/gordonslondon/doctrine2/commit/0823cd54d0b2720f5e72aa9a29d16271904d99f0 that fixed the issue. Do you want a PR ?

Here's the PR : https://github.com/doctrine/doctrine2/pull/264

[DDC-1609] Weird testerror on PostgreSQL

Sun, 22 Jan 2012 17:34:46 +0000

https://github.com/doctrine/doctrine2/commit/3bb803fd697d92d661f5b8cea473f75f46c34857

Git Bisect found this commit to lead to the following error:

$ phpunit -c postgresql.phpunit.xml --filter DDC-742
PHPUnit 3.6.5 by Sebastian Bergmann.

Configuration read from /home/benny/code/php/wsnetbeans/doctrine2/postgresql.phpunit.xml

E

Time: 12 seconds, Memory: 36.00Mb

There was 1 error:

1) Doctrine\Tests\ORM\Functional\Ticket\DDC742Test::testIssue
Exception: [PHPUnit_Framework_Error_Notice] Undefined index: 0000000016f5d67f000000001fa7794e

With queries:
11. SQL: 'INSERT INTO comments (content) VALUES (?)' Params: 'baz'
10. SQL: 'INSERT INTO comments (content) VALUES (?)' Params: 'bar'
9. SQL: 'INSERT INTO comments (content) VALUES (?)' Params: 'foo'
8. SQL: 'ALTER TABLE user_comments ADD CONSTRAINT FK_BF13722AF8697D13 FOREIGN KEY (comment_id) REFERENCES comments (id) NOT DEFERRABLE INITIALLY IMMEDIATE' Params: 
7. SQL: 'ALTER TABLE user_comments ADD CONSTRAINT FK_BF13722AA76ED395 FOREIGN KEY (user_id) REFERENCES users (id) NOT DEFERRABLE INITIALLY IMMEDIATE' Params: 
6. SQL: 'CREATE TABLE comments (id SERIAL NOT NULL, content VARCHAR(100) NOT NULL, PRIMARY KEY(id))' Params: 
5. SQL: 'CREATE INDEX IDX_BF13722AF8697D13 ON user_comments (comment_id)' Params: 
4. SQL: 'CREATE INDEX IDX_BF13722AA76ED395 ON user_comments (user_id)' Params: 
3. SQL: 'CREATE TABLE user_comments (user_id INT NOT NULL, comment_id INT NOT NULL, PRIMARY KEY(user_id, comment_id))' Params: 
2. SQL: 'CREATE TABLE users (id SERIAL NOT NULL, title VARCHAR(100) NOT NULL, PRIMARY KEY(id))' Params: 

Trace:
/home/benny/code/php/wsnetbeans/doctrine2/lib/Doctrine/ORM/UnitOfWork.php:2171
/home/benny/code/php/wsnetbeans/doctrine2/lib/Doctrine/ORM/Persisters/ManyToManyPersister.php:113
/home/benny/code/php/wsnetbeans/doctrine2/lib/Doctrine/ORM/Persisters/ManyToManyPersister.php:95
/home/benny/code/php/wsnetbeans/doctrine2/lib/Doctrine/ORM/Persisters/AbstractCollectionPersister.php:130
/home/benny/code/php/wsnetbeans/doctrine2/lib/Doctrine/ORM/Persisters/AbstractCollectionPersister.php:108
/home/benny/code/php/wsnetbeans/doctrine2/lib/Doctrine/ORM/UnitOfWork.php:310
/home/benny/code/php/wsnetbeans/doctrine2/lib/Doctrine/ORM/EntityManager.php:334
/home/benny/code/php/wsnetbeans/doctrine2/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC742Test.php:63


/home/benny/code/php/wsnetbeans/doctrine2/tests/Doctrine/Tests/OrmFunctionalTestCase.php:359

[DDC-1608] Lazy load more restrict when consuming PersistentCollection trigger actions to *Persisters

Wed, 18 Jan 2012 19:18:35 +0000

Since https://github.com/doctrine/doctrine2/pull/259 we identified an issue with the Persisters that are failing to check for entities that exist in UoW (managed and sched for insert) and are now being checked is they are part of Collection.
Also it missed some tests. It should be easy, just ->persist the entity then triggers Collection actions.

[DDC-1606] Added fix for collection->contains with many-to-many extra lazy fetchMode

Sun, 22 Jan 2012 17:35:27 +0000

That case previously triggered a PHP error along the lines of:

Notice: Undefined index: 0000000062a3a7690000000033c91b26 in doctrine/lib/Doctrine/ORM/UnitOfWork.php line 2202
#0 doctrine/lib/Doctrine/ORM/Persisters/ManyToManyPersister.php(267): Doctrine\ORM\UnitOfWork->getEntityIdentifier(Object(Item))
#1 doctrine/lib/Doctrine/ORM/PersistentCollection.php(411): Doctrine\ORM\Persisters\ManyToManyPersister->contains(Object(Doctrine\ORM\PersistentCollection), Object(Item))
#2 Test.php(71): Doctrine\ORM\PersistentCollection->contains(Object(Item))

Associated PR: https://github.com/doctrine/doctrine2/pull/259

[DDC-1604] Implement Common Proxy

Sun, 22 Jan 2012 17:35:03 +0000

Implement Common Proxy

[DDC-1603] Unique key name isn't correctly set

Sun, 22 Jan 2012 17:34:28 +0000

Example :

<unique-constraints>
<unique-constraint columns="permalink" />
<unique-constraint columns="code" />
</unique-constraints>

This will create :
CREATE UNIQUE INDEX UNIQ_6C3BF144F286BC32 ON shows (permalink);
CREATE UNIQUE INDEX 1 ON shows (code);

instead of :
CREATE UNIQUE INDEX UNIQ_6C3BF144F286BC32 ON shows (permalink);
CREATE UNIQUE INDEX UNIQ_6C3BF14477153098 ON shows (code);

The problem comme from SchemaTool, and the first key is a valid result because of "==" instead of "===" inside Table.php.

I have create a PR on Github.

[DDC-1601] Schema Validator wrong on entities with pk as fk

Sun, 15 Jan 2012 11:13:11 +0000

Schema Validator wrong on entities with pk as fk

[DDC-1598] ProxyFactory makes assumptions on identifier getter code

Mon, 16 Jan 2012 09:56:15 +0000

As of
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L214
and
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L237
the current ProxyFactory isn't actually checking if the identifier getter has logic in it.
Current checks aren't enough/valid.

In my opinion the check should be matching following:

(public|protected)\s+function\s+getFieldname\s*(\s*)\s+

{\s*\$this\s*->Fieldname\s*;\s*}

Not really experienced with regex, but currently cannot come up with a more secure check.

[DDC-1594] Merging serialized entity back to the UnitOfWork

Sun, 15 Jan 2012 16:47:20 +0000

(I'm using doctrine 2.1.4.)

I'm trying to merge an Entity back to the UnitOfWork.
The Entity is created from a serialized object (The deserialzed Entity is a valid Entity Object. The only difference
is that it is not managed by Doctrine yet) and I'm using the merge
method of the EntityManager to get it in managed state again.

This results in a call of the Method doMerge() in the UnitOfWork
class.
This method takes the id of my deserialized Entity, that I want to
merge, and looks if an Entity with that id is already in doctrine
cache. If that is the case my deserialized Entity is merged with the
one in the cache. So far so good. But I've got the Problem, that the
Entity, which is in cache, is not initialized yet. It is not initialized because
this Entity has a relation to another Entity that a used earlier in code.
It's there but in uninitialized stat, because I did not access it yet.
So when my deserialized Entity and the one from cache gets merged, some field are
uninitialized (the id field, for example).

I fixed the problem by adding this piece of code in line 1446 in the
UnitOfWork class:
if(! $managedCopy->_isInitialized_)

{ $managedCopy->__load(); }

[DDC-1588] There is no way to get the Query's result cache impl without going to EM

Mon, 9 Jan 2012 09:44:01 +0000

Ok, my problem is this:

I have created a Query object. Now I'd like to get it's result cache driver.

My options:
1) Ask QueryCacheProfile for the driver. I can, but it's never populated by default so I always get just NULL.
2) Ask Query with getResultCacheDriver(), but wait, I can't, that's now deprecated
3) Ask from EM's configuration the result cache driver. This always works.

I propose that either the QueryCacheProfile is always populated with the Query's default result cache impl unless specifically overridden for the QueryCacheProfile

Make getResultCacheDriver() not deprecated. Like the other two related methods, they are not deprecated, why should this one. Calling this could populate the QueryCacheProfile for future use like all the other (get cache ttl, id) methods.

My problem with with option 3) is "leaving the context of my method and the Query" (mentally of course). Why should I have to go poke around in EM's configuration when the result cache IS (or is easily obtainable behind the scenes) in the query object anyways?

[DDC-1585] Doctrine2 doesn't check for the correct entity type on @ManyToOne relations

Duplicate — Sun, 15 Jan 2012 14:01:33 +0000

I made a mistake when creating a @ManyToOne entity:

/**

@ManyToOne(targetEntity="Entities\EntityA")
*/
private $test;

However, I was setting Entities\EntityB into $test.

Doctrine2 doesn't check for this, resulting in a hard-to-find issue.

[DDC-1577] Remove static Reflection dependency from ClassMetadata

Reference — Tue, 3 Jan 2012 21:56:55 +0000

See ~~DCOM-93~~ for more information

[DDC-1561] GH-239: Fix $qb->expr() PHPDoc @return type.

Tue, 3 Jan 2012 21:53:35 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/239

The autocompletion was missing so i was sad.

But hey, it's open source!

[DDC-1554] GH-235: Allow ExporterDrivers that implement the exportClassMetadata() function to return false

Tue, 3 Jan 2012 21:52:59 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/235

Allow ExporterDrivers that implement the exportClassMetadata() function to return FALSE when no content is available/needs to be written to a file by the AbstractExporter, preventing empty files to be generated foreach processed ClassMetadataInfo instance.

I'm currently generating Data Transfer Object class for my Entities, but not all Entities require it. Based on an Annotation I determine which DTO's will be generated and return FALSE otherwise. Currently this 'negative' return is not respected and a lot of empty files are created.

[DDC-1548] One to one entity badly populated

Mon, 19 Dec 2011 18:33:46 +0000

One to one entity over populated

[DDC-1547] GH-228: Fixed testsuite

Tue, 3 Jan 2012 21:53:17 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/228

[DDC-1546] another incorrect mapping not detected by orm:validate-schema

Mon, 19 Dec 2011 09:11:48 +0000

Several lines like this one:

Were not flagged by orm:validate-schema as incorrect. Updating a related entity revealed the problem ("int" not being a proper type) at runtime.

Bug: orm:validate-schema should throw an error on incorrect column type.

[DDC-1545] Update on loaded association not detected upon flush()

Mon, 19 Dec 2011 18:33:30 +0000

If an association is joined during fetching and then updated in-memory, the update is not detected during flushing. I made the following test cases:

Association is joined:

change NULL → entity: does not work
change entity → NULL: works
change entity1 → entity2: does not work

Assocation is not joined:

change NULL → entity: works
change entity → NULL: works
change entity1 → entity2: works

[DDC-1544] Interfaces as target entity + event to resolve them to an implementation

Sat, 17 Dec 2011 22:05:25 +0000

Idea is:

/**
 * @ManyToOne(targetEntity="UserInterface")
 */

Would fire "onResolveTargetEntity" which is supposed to return details for resolving the interface to an actual implementation.

[DDC-1541] ClassMetadataBuilder has some name discrepancy in calls to AssociationBuilder methods

Sat, 17 Dec 2011 11:40:05 +0000

ClassMetadataBuilder class has some methods defined that call methods on AssociationBuilder class by different names, specifically the (set) part . e.g.

ClassMetadataBuilder method addManyToOne, calls setInversedBy, but is defined in AssociationBuilder as inversedBy. This trows a call to undefined method.

Which one is it ?

[DDC-1539] QueryException occurs when parentheses exist on the left-hand of comparison

Tue, 20 Dec 2011 16:37:04 +0000

When I executed the following DQL, I get an error.

 
> php scripts/doctrine.php orm:run-dql "select o from OrderDetail o where (o.price + o.tax) * o.count > 10000"

  [Doctrine\ORM\Query\QueryException]
  [Syntax Error] line 0, col 69: Error: Expected =, <, <=, <>, >, >=, !=, got ')'

When I swap the left-hand expression and right-hand one, no error occurs.

> php scripts/doctrine.php orm:run-dql "select o from OrderDetail o where 10000 < (o.price + o.tax) * o.count"

array
  empty

[DDC-1537] GH-214: Fixed typo in the XmlDriver

Wed, 14 Dec 2011 04:40:00 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/214

[DDC-1536] GH-213: QueryBuilder::getQuery

Wed, 14 Dec 2011 04:40:46 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/213

Hi there,
I'm wondering myself if the QueryBuilder::getQuery is a good method name.
Actually, a getMethodObject makes me think that I can use many times the getMethodObject and work with the same object.
e.g :

```php
$qb->getQuery()->useResultCache (true);
$qb->getQuery()->execute();
```
In my code, the problem is that getQuery return a new instance of Query each time that I call getQuery.
Furthermore, the getQuery method invoke a createQuery method.

So, maybe the QueryBuiler::getQuery can store a reference to the created Query instance, and if the QueryBuilder::getQuery is call many times without any change return the stored instance.
If the QueryBuilder::getQuery have to generate a new Query, throw an exception or something like that.

Because of a change to QueryBuilder::createQuery is a major change, I don't think that It could be the solution, but it's a reflexion around this.

What do you think about that ?

[DDC-1531] Documentation references no-longer available constant Lexer::T_ABS

Wed, 14 Dec 2011 04:04:42 +0000

Line 645 of https://github.com/doctrine/orm-documentation/blob/master/en/reference/dql-doctrine-query-language.rst

Best i can tell this has been re-named to Lexar::T_IDENTIFIER by looking at other functions in the distribution

[DDC-1526] Unecessary queries with LEFT JOIN

Duplicate — Tue, 23 Oct 2012 11:41:45 +0000

After upgrading to 2.1.4 (from 2.1.2), the following dql started creating way more queries than necessary :
SELECT m, p, s, c, o
FROM FERMainBundle:Menu m
LEFT JOIN m.page p
LEFT JOIN m.section s
LEFT JOIN m.children c
LEFT JOIN s.position o
ORDER BY m.lft

Details to the code here:
http://pastie.textmate.org/private/z9gtgqe1odwenxcmudywqa
The model looks like that:
http://pastie.textmate.org/private/przxzfimsfyua02cxqcv9a

http://pastie.textmate.org/private/ob1jqiekv89e4xj9bq06q
First query is executed, it should in fact retrieve everything there is about the menu, but then it runs the second query for every menu element I have, generating a lot of queries that didn't occur before.

[DDC-1524] NamedQueries annotation doesn't work with just one NamedQuery

Sat, 17 Dec 2011 11:35:51 +0000

NamedQueries annotation doesn't work with just one NamedQuery

the problem is locale in the class Doctrine\ORM\Mapping\Driver\AnnotationDriver line 179.

Is needed validate if var $namedQueriesAnnot->value is an array before try perform foreach statement.

Please I'm sorry for my bad English.

Thank you

[DDC-1523] Coalesce() does not work with functions

Sat, 10 Dec 2011 03:32:54 +0000

I wanted to use COALESCE in DQL with a function (e.g. CURRENT_TIMESTAMP()). If I run this DQL, I receive a syntax error exception like this one:

montbook:marlow mprebio$ php scripts/doctrine.php orm:run-dql "select COALESCE(CURRENT_TIMESTAMP()) from Project\Entity\User user"

[Doctrine\ORM\Query\QueryException]
[Syntax Error] line 0, col 33: Error: Expected Doctrine\ORM\Query\Lexer::T_CLOSE_PARENTHESIS, got '('

I've traced this error to Doctrine\ORM\Parser::ScalarExpression() which tries to interpret the current_timestamp function as a SimpleArithmeticExpression or as a StateFieldPathExpression (first if). As far as I understand this part of the parser, the function call should lead to the if part with $this->_isFunction(). Therefore I added a "and !$this->_isFunction()" to the first if clause. After this change everything works as expected: The above query returns the current timestamp (many times because of the from since DQL needs a from part).

Reordering the ifs should work too.

[DDC-1517] find/getReference break on invalid or missing identifier fields

Thu, 1 Dec 2011 20:42:58 +0000

find/getReference break on invalid or missing identifier fields

[DDC-1508] ClassMetadataBuilder only accepts ClassMetadata not *Info

Fri, 9 Dec 2011 05:05:04 +0000

ClassMetadataBuilder only accepts ClassMetadata not *Info

[DDC-1503] Add support for executing custom SQL functions on custom types

Duplicate — Fri, 9 Mar 2012 16:27:00 +0000

I have created a custom type called point but need a way to have a function called on columns of this type when fetching / updating / inserting entities.

For example:

Consider I have an entity which has a column called the_geom

This is associated with my custom type point

A basic select statement for this entity is as follows:

SELECT id, name, the_geom FROM points where id = 1

The problem is the_geom is encoded and on the PHP side I want it in human readable form. I would like a way to specify custom functions on SELECT / INSERT / UPDATE for columns of this custom type.

When selecting my entity I would like to execute the function ST_AsText(the_geom)

SELECT id, ST_AsText(the_geom) FROM points where id = 1

The same goes for updates and inserts. I would like to surround the column SQL with other custom functions, to encode my human readable text back to the encoded value for the DB.

Possibly this could be integrated into Doctrine\DBAL\Types\Type ?

// Modify the column SQL for insert
public function getSqlInsertColumn(....)

// Modify the column SQL for update
public function getSqlUpdateColumn(....)

// Modify the column SQL for select
public function getSqlSelectColumn(....)

// A possible example of getSqlSelectColumn(...)
public function getSqlSelectColumn($doctrineSql)
{
    // $doctrineSql == "p0_.the_geom"
    return 'ST_AsText(' . $doctrineSql . ')';
}

[DDC-1502] SQLite should eat prefixed tables (since they dont exist)

Mon, 21 Nov 2011 21:08:06 +0000

People use schema or many databases, however SQLite does not support the foo.bar syntax, so there is no way to run the tests in sqlite memory against these setups.

[DDC-1492] Fatall error: Cannot use object as array in ORM\Internal\Hydration\ObjectHydrator.php on line 314

Tue, 15 Nov 2011 03:10:16 +0000

My entities

event
eveht.event_area_id=event_area.id (1:1)
event_area.event_id=event.id (1:1)
event_area.area.id=area.id (one area has many event_area's)
area.parent_id=area_id (hierarchial)
event.author_id=user.id (one user has many events)

area - STI: District/City/Region/Country/etc.

SELECT
	r, ra, a, ap, au, DATE(r.eventTime) AS event_date
FROM OloloEventsBundle:Event r
	LEFT JOIN r.eventArea ra
		LEFT JOIN ra.area a
			LEFT JOIN a.parent ap
	INNER JOIN r.author au WHERE r.eventTime <= :r_eventtime AND ra.area IN(:ra_area)
GROUP BY r
ORDER BY event_date DESC

This DQL caused an error "Cannot use object of type District as array in ORM\Internal\Hydration\ObjectHydrator.php on line 314". When I'm removing `ap` friom fetching - it works. Mapping are correct - there are many other places where it works correctly.

[DDC-1491] Bug in SchemaValidator diffing join columns

Sun, 13 Nov 2011 14:48:02 +0000

Bug in SchemaValidator diffing join columns

[DDC-1490] Generated Ids with Sequence/Auto Increment Generators not always casted to int

Sun, 13 Nov 2011 14:48:28 +0000

The Id Generators don't necessarily cast ids to integer values when generating them.

[DDC-1482] GH-160: Allow to unset one-to-one relation with generated class

Thu, 7 Jun 2012 13:54:18 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/160

Added <variableDefault> on generated class.
This generate methods like:
```function setGroup(Group $group = null){
}
```

that allow to remove "Group" association if the relation is one-to-one.

Plus some indentation issue

[DDC-1481] GH-158: Collapsed cascade elements, if cascade-all.

Wed, 6 Jun 2012 14:39:15 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/158

Collapsed cascade elements, if cascade-all.
(better readability for generated xml)

[DDC-1479] GH-169: preFlush event and lifecycle callback

Tue, 10 Jul 2012 03:41:48 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/169

For now, we have `@PrePersist`, `@PreUpdate` and `@PreRemove` callbacks. But it's not enough, cuz in some cases we need to run some entity method just before *every* `EntityManager#flush()` call (examples - translatable behavior and file uploading routines).

I've added and tested new `@PreFlush` event, which occurs during the start of the `EntityManager#flush()`, before any changeset gets calculated. This gives users ability to hook into flush process and prepare their entities to save even if they were not changed.

[DDC-1478] GH-175: added EntityRepository::getClassName()

Sun, 13 Nov 2011 15:58:15 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/175

added EntityRepository::getClassName() to fullfill the ObjectRepository interface

see https://github.com/doctrine/common/pull/70

[DDC-1476] Yaml Driver doesn't default field types to string

Mon, 14 Nov 2011 18:31:39 +0000

Doctrine documentation states that a field default value is a string.
The annotation driver behaves so but the Yaml driver doesn't.

The Yaml driver requires that a field is set a type explicitly.

Why is this different among drivers and what is the actual default behaviour?

[DDC-1472] WHERE <> IN ... doesn't work

Sun, 4 Dec 2011 07:43:12 +0000

I have a query which is supposed to compare a result of a user defined function with a set of possible results
SELECT ... WHERE YEAR(w.date) IN (.......)

But I get the error:
[Syntax Error] line 0, col 49: Error: Expected Doctrine\ORM\Query\Lexer::T_IN, got '('

If I only compare the result of the function with a single value everything works as aspected:
SELECT ... WHERE YEAR(w.date) = 2011
.. works!

I also testet it with other functions like DATE_DIFF, etc. but always get the same error.

[DDC-1468] Exception verbose: Id in a mapped-superclass

Mon, 19 Dec 2011 03:21:22 +0000

Some exception could/should be more precise (I've lost a lot of time figuring out why I was having an error)

When you have an id field inside a mapped-superclass, you get the following exception:

[ErrorException]
Notice: Undefined index: IdealTech\OnlineSystem\GeoBundle\Entity\AbsAddress in /Users/fmazerolle/Sites/it/os/vendor/doctrine/lib/Doctrine/ORM/Mapping/Driver/AbstractFileDriver.php line 121

The exception should be more verbose and tell the real cause of the error.

[DDC-1463] Inner join eagerly loaded entities if possible

Mon, 31 Oct 2011 21:25:09 +0000

Inner join eagerly loaded entities if possible

[DDC-1461] Possible Regression with OneToOne relation

Sun, 13 Nov 2011 22:15:35 +0000

I have the following relations:

namespace Model;

use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Entity(repositoryClass="Model\Repository\UserRepository")
 * @ORM\ChangeTrackingPolicy("DEFERRED_EXPLICIT")
 * @ORM\HasLifecycleCallbacks
 * @ORM\Table(name="users")
 */
class User
{
    /**
     * @ORM\OneToOne(targetEntity="Model\TwitterAccount", orphanRemoval=true, fetch="EAGER", cascade = {"persist"}, inversedBy="user")
     * @var TwitterAccount
     */
    private $twitterAccount;
}

/**
 * @ORM\Entity(repositoryClass = "Model\Repository\TwitterAccountRepository")
 * @ORM\Table(name = "twitter_accounts")
 * @ORM\ChangeTrackingPolicy("DEFERRED_EXPLICIT")
 */
class TwitterAccount
{
    /**
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     * @ORM\Column(type="integer")
     */
    private $id;

    /**
     * @ORM\OneToOne(targetEntity="Model\User", fetch="EAGER")
     */
    private $user;
}

now when I add a new account, the user-side is not updated with the id of the account, but the account is still saved to the database.

$twitterAccount = new TwitterAccount();
$user->setTwitterAccount($twitterAccount);
$em->persist($user);
$em->flush();

The twitterAccount_id of the users table is empty, but the new account is added to the "twitter_accounts" table with the correct user_id.

[DDC-1458] Issue with tracking entity changes

Fri, 11 Nov 2011 07:20:15 +0000

Flushing at point #2 has no effect (outputs int(1)), flushing at point #1 works as expected (outputs int(5)).
this issue comes only when i trying to set boolean value on managed assotiated entity

upd. same issue with datetime properties

/**
 * @ORM\Entity
 */
class TestEntity
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    protected $id;
    /**
     * @ORM\Column(type="integer")
     */
    protected $value;
    /**
     * @ORM\OneToOne(targetEntity="TestAdditionalEntity", inversedBy="entity", orphanRemoval="true", cascade={"persist", "remove"})
     */
    protected $additional;
}

/**
 * @ORM\Entity
 */
class TestAdditionalEntity
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    protected $id;
    /**
     * @ORM\OneToOne(targetEntity="TestEntity", mappedBy="additional")
     */
    protected $entity;
    /**
     * @ORM\Column(type="boolean")
     */
    protected $bool;
    
    public function __construct()
    {
        $this->bool = false;
    }
}

$test = new \TestEntity();
$test->setValue(1);
$test->setAdditional(new \TestAdditionalEntity());

$em->persist($test);
$em->flush();
$em->clear();

$test = $em->getRepository('Bundle:TestEntity')->find(1);
$test->setValue(5);

// point #1
$test->getAdditional()->setBool(true);
// point #2

$em->flush();

var_dump($test->getValue());

[DDC-1457] Wrong return annotation for UnitOfWork::getEntityPersister() method

Sun, 4 Dec 2011 07:15:33 +0000

It is

@return Doctrine\ORM\Persisters\AbstractEntityPersister

should be (I suppose)

@return \Doctrine\ORM\Persisters\BasicEntityPersister

@return Persisters\BasicEntityPersister

[DDC-1456] Sequence doesn't work correctly when sequence is defined second in a composite key

Sat, 17 Dec 2011 23:33:31 +0000

When using a sequence in Oracle as part of a composite key and the sequence is defined second, Doctrine retrieves from the sequence correctly but incorrectly assigns to the first key (which in this case is not the correct column)

Example:

/Entity/ItemModel.php

/**
 * @Column(name="submission_id", type="integer")
 * @Id
 */
private $submissionId;

/**
 * @Column(name="model_id", type="integer")
 * @Id
 * @GeneratedValue(strategy="AUTO")
 * @SequenceGenerator(sequenceName="model_id_seq", initialValue=1, allocationSize=1)
 */
private $modelId;

Doctrine correctly retrieves the sequence, however it then attempts to set the first identifier field (in this case submission_id) instead of the sequence key.

The problem appears in /Doctrine/ORM/UnitOfWork.php line 613.
$class->indentifier is hard coded to item 0.

$this->entityIdentifiers[$oid] = array($class->identifier[0] => $idValue);

You can workaround this issue by defining the sequence first in the entity.

[DDC-1455] Selecting association id (FK) without join

Mon, 7 Nov 2011 13:11:21 +0000

It might be a missing feature or I might be doing something wrong. I need to select an association (FK) without the need of a join.

I'm trying something like this:

select i.client.id , count(i) as total 
from \Invoice i 
GROUP BY i.client

But I get this error:
Error: Expected Doctrine\ORM\Query\Lexer::T_FROM, got '.'

[DDC-1452] ObjectHydrator bug: hydration of entity with self (cyclic) relation through ref entity

Tue, 15 Nov 2011 17:48:23 +0000

ObjectHydrator has bug in hydrate entities with relation to entity of this same class throught reference entity. Example Model:

EntityA

id
title (string)
entitiesB (annotation: @ORM\OneToMany(targetEntity="EntityB", mappedBy="entityAFrom"))

EntityB

id
entityAFrom (annotation: @ORM\ManyToOne(targetEntity="EntityA", inversedBy="entitiesB"))
entityATo (annotation: @ORM\ManyToOne(targetEntity="EntityA"))
type (string)

Scenario:

Execution of dql query 'SELECT a, b, ba FROM EntityA AS a LEFT JOIN a.entitiesB AS b LEFT JOIN b.entityATo AS ba' with max results set to "1" and data in database:

EntityATable:
id | title
1 | a
2 | b

Resume:

I expected collection of EntityA object (size=1 becouse I set max results to 1) with hydrated entitiesB collection (size=1 becouse in db is only 1 record) and hydrated entityTo object. entitiesB property of entityTo object should be empty PersistCollection (ready to lazy load) but is null...

I can provide TestCase for this issue.

[DDC-1449] Create postFlush event

Sun, 23 Oct 2011 10:07:40 +0000

Create postFlush event

[DDC-1448] Add a base entity to allow users to skip writing boilerplate code

Sat, 19 Nov 2011 11:52:14 +0000

For forward compatibility with https://gist.github.com/1034079 we want to add a "BaseEntity" into the core that handles boilerplate code through implementing "__call" and using the metadata to generate getter/setter/adder/is methods on the fly.

[DDC-1447] BC?

Tue, 15 Nov 2011 21:40:47 +0000

BC?

[DDC-1446] Evaluate to configure default "persist cascade" for all enties.

Mon, 14 Nov 2011 03:28:03 +0000

Evaluate to configure default "persist cascade" for all enties.

[DDC-1442] SimpleObject hydratation mode with inheritance

Fri, 18 Nov 2011 19:48:05 +0000

SimpleObject hydratation mode with inheritance, it appear that it's not working.

The problem start in SimpleObjectHydrator.php line 129 when calling UnitOfWork->createEntity(NULL, Array, Array).

[DDC-1439] Saving many to many association with composed keys.

Mon, 31 Oct 2011 20:12:21 +0000

I have a problem with saving many to many realtion. My entities are.

calss Entity1 {
		
	/**
	 * @Id @column
	 */
	protected $key1;

	/**
	 * @Id @column
	 */
	protected $key2;
	
	/**
	 * @ManyToMany (targetEntity="Entity2")
	 * @JoinTable (name="Entity1Entity2",
	 *      joinColumns={@JoinColumn(name="key1", referencedColumnName="key1")},
	 *      inverseJoinColumns={@JoinColumn(name="key3", referencedColumnName="key3")}
	 *      )
	 */
	protected $entity2;
}

class Entity2 {
	
	/**
	 * @Id @column
         * @GeneratedValue(strategy="AUTO")
	 */
	protected $key3
}

So in the middle table that i keep the keys from the other 2 i need to save only key1 and key3. And key2 need to be ignored.
But when i try to save instead of saving the proper values it try to save the value for key2 instead of the value of key1 in the middle table.
After some debuging i found that in Doctrine\ORM\Persisters\ManyToManyPersister in the private function _collectJoinTableColumnParameters lies the problem.
Instead of taking the key by the name you are doing array_pop. And you are making a check for composite keys but you presume that bouth of the keys will be
in the middle table, but that is not the case for me.
The quick fix that i did was to remove the current check for isComposite and get the keys like we are in the isComposite case always.

Tanks in advance for the great work.

Have a nice day!

[DDC-1437] Strange behavior with proxied classes,expected to get entity, but returned identifier.

Wed, 19 Oct 2011 09:59:16 +0000

I have the following xml mapping:

 
User:
  <entity name="User" table="user">
    <id name="id" type="integer" column="id">
      <generator strategy="SEQUENCE"/>
    </id>
    <field name="name" type="string" column="name"/>
   </entity>

SuperUser:
  <entity name="SuperUser" table="superuser">

    <id name="user" type="integer" column="user_id" association-key="true"/>

    <one-to-one field="user" target-entity="User">
      <join-columns>
        <join-column name="user_id" referenced-column-name="id"/>
      </join-columns>
    </one-to-one>

  </entity>

From this mapping i have generated the php classes.

In my application, when the SuperUser class is proxied, SuperUser::getUser() method looks like this:

 
public function getUser(){

        if ($this->__isInitialized__ === false) {
            return $this->_identifier["user"];
        }
        $this->__load();
        return parent::getUser();
}

When i call $usperuser->getUser() the expected return value is the User class instance; but the current implementation returns only user id (contained in $this->_identifier["user"]).

In this behavior is also involved private function ProxyFactory::isShortIdentifierGetter($method, $class)

Some solutions proposed by me, can be:

remove this behavior
during proxy generation, add in this case a method called getUserId, and this method can return user id (but in this case, the behavior continues to be strange because is available only for proxied classes).

(sorry for my english)

[DDC-1430] GROUP BY $alias in Oracle

Fri, 18 Nov 2011 14:46:48 +0000

When creating a query with the QueryBuilder, the groupBy with only the alias doesn't work as expected.

It creates the group by with the ID only, but Oracle need all the fields to work.

The ORA-00979: not a GROUP BY expression error is returned.

From my SlotRepository I do:

$query = $this->createQueryBuilder('s')
    ->select('s, COUNT(a.id) AS agendas_count')
    ->leftJoin('s.agenda_slots', 'l')
    ->leftJoin('l.agenda', 'a')
    ->groupBy('s')
;

The SQL generated is:

SELECT s0_.id AS id0, s0_.hour_start AS hour_start1, s0_.hour_end AS hour_end2, s0_.active AS active3, COUNT(a1_.id) AS sclr4 FROM slot s0_ LEFT JOIN agenda_slot a2_ ON s0_.id = a2_.slot_id LEFT JOIN agenda a1_ ON a2_.agenda_id = a1_.id GROUP BY s0_.id

The SQL expected is:

SELECT s0_.id AS id0, s0_.hour_start AS hour_start1, s0_.hour_end AS hour_end2, s0_.active AS active3, COUNT(a1_.id) AS sclr4 FROM slot s0_ LEFT JOIN agenda_slot a2_ ON s0_.id = a2_.slot_id LEFT JOIN agenda a1_ ON a2_.agenda_id = a1_.id GROUP BY s0_.id, s0_.hour_start, s0_.hour_end, s0_.active

As workaround I include all fields manually.

Thank you,
Juan Manuel

[DDC-1427] Fix for columns

Tue, 8 Nov 2011 10:03:56 +0000

Fix for generating sql with columns that are exactly MAX IDENTIFIER SIZE long.

[DDC-1424] Make order in DQL SELECT clause matter for hydration

Reference — Mon, 14 Nov 2011 03:35:44 +0000

The order of the DQL Select clause should matter for the result hydration:

SELECT u.id, u, u.name FROM User u => result keys: id, 1, name
SELECT u.id, u.id FROM User u => result keys: id, or numerical hydration 0, 1
SELECT u.id, u AS user FROM User u => result keys: id, user

[DDC-1422] Do not load entities when an identifier is retrieved from a proxy

Sat, 15 Oct 2011 18:23:47 +0000

Do not load entities when an identifier is retrieved from a proxy

[DDC-1418] Integrate Simplified XML/YML Drivers from Symfony

Thu, 13 Oct 2011 21:40:27 +0000

Integrate Simplified XML/YML Drivers from Symfony

[DDC-1417] entity generator does not support nullable relationship

Fri, 18 Nov 2011 19:45:55 +0000

With a nullable relationship, e.g.

  manyToOne:
    bar:
      targetEntity: Bar
      joinColumns:
        bar_id:
          referencedColumnName: id
          nullable: true

the setter generated for the relationship

   public function setBar(\Acme\FooBarBundle\Entity\Bar $bar)
    {
        $this->bar = $bar;
    }

can not take null as an argument.

It should generate

    public function setBar(\Acme\FooBarBundle\Entity\Bar $bar = null)
    {
        $this->bar = $bar;
    }

[DDC-1416] bug in simple test with sub query

Sun, 4 Dec 2011 07:42:53 +0000

For exemple :

$query = $em->createQuery("SELECT * FROM address WHERE :aValue IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 10)");
$query->getQuery()->getSQL();

Doctrine throw that error : Doctrine\ORM\Query\QueryException: [Semantical Error] line 0, col xxx near ':aValue': Error: ':aValue' is not defined.

But in SQL this type of request is posible.

[DDC-1411] onCascade property gets wrong value when entities are generated

Sat, 15 Oct 2011 15:54:02 +0000

I'm using this cmd to generate entities "/path/to/php path/to/doctrine orm:generate-entities --generate-annotations="1" ~/some/path".

The CASCADE option for ONDELETE columns is being wrongly generated, the right would be: onDelete="CASCADE" but it is being generated as onDelete=true

[DDC-1404] Named Queries not inherited in JOINED Inheritance

Mon, 14 Nov 2011 18:32:43 +0000

When using the JOINED Inheritance (@ORM\InheritanceType("JOINED")) any Named Queries defined in the parent entity are not recognized by the repositories of the children.

So if we have ParentEntity as the parent and ChildEntity a class that extends ParentEntity in table inheritance also. Accessing the ChildEntityRepository and asking for a named query defined via annotation in ParentEntity results in "query does not exist"

[DDC-1396] [APC Cache] "clear-cache" commands do not work with cli

Mon, 3 Oct 2011 04:24:31 +0000

Commands for clear-cache:result, clear-cache:query, clear-cache:metadata do not work with cli and APC Cache

Revert some correction not tested by guilhermeblanco by adding

if ($cacheDriver instanceof \Doctrine\Common\Cache\ApcCache)
{
    throw new \LogicException("Cannot clear APC Cache from Console, its shared in the Webserver memory and not accessible from the CLI.");
}

[DDC-1395] [Doctrine cache clear-result] - wrong function is used

Mon, 3 Oct 2011 04:20:52 +0000

lib\Doctrine\ORM\Tools\Console\Command\ClearCache\ResultCommand.php

Fixing

 
$cacheDriver = $em->getConfiguration()->getQueryCacheImpl();
by
$cacheDriver = $em->getConfiguration()->getResultCacheImpl();

Fixing

 
output->write('Clearing ALL Query cache entries' . PHP_EOL);
by
output->write('Clearing ALL Result cache entries' . PHP_EOL);

[DDC-1385] INDEX BY doesn't work for selects with scalars only

Sun, 1 Apr 2012 13:30:53 +0000

By scalars-only-selects I mean this:

SELECT c.id, c.name FROM GLocalityBundle:Country c  INDEX by c.id

The result won't be indexed by c.id, as opposites to this:

SELECT c FROM GLocalityBundle:Country c  INDEX by c.id

Assuming that GLocalityBundle:Country has several hunders of fields, and you need only two of them, this is very disappointing

After diving in the code, due to rigorous separation of entities on objects and scalars, it looks practically impossible even to implement this feature
What is this? Bad design?

[DDC-1384] ORA-00972: identifier is too long

Sun, 30 Oct 2011 15:48:38 +0000

Hi,

When the query is executed the follow problem occur:
ORA-00972:identifier is too long
The problem occur because a column name has 30 characters and the
Doctrine creates an alias with <column_name>+<position_in_select>
becoming 31 characters, in Oracle the max allowed characters in the name
is 30.
Is there any configuration that disable this mechanism?
How can I solve this issue?
Thanks!
Regards,

Matheus Souza.

[DDC-1383] Inheritance superclass object is created after merging entity referencing to discriminated entity

Sat, 15 Oct 2011 17:16:24 +0000

Problem is that after merging the object with a reference to some other entity with inheritance (is one of the superclass's discriminator map), the referenced object has wrong instance (it is Proxy object). It is instance of the superclass not the extended class.

In my test case I have joined inheritance model with only two entities to make things simple as possible.

First is the base entity (I have even marked it as abstract):

/**
 * @Entity
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="discr", type="integer")
 * @DiscriminatorMap({1 = "Entity"})
 */
abstract class AbstractEntity

and one entity which extends from the first one:

/**
 * @Entity
 */
class Entity extends AbstractEntity {
	/**
	 * @ManyToOne(targetEntity="AbstractEntity")
	 * @var AbstractEntity
	 */
	protected $reference;

In this scheme I've got 2 objects, first referencing to the second. They both are inserted in the database with no problems.

$child = new Entity();
$parent = new Entity();
$child->setReference($parent);

After the flush I try merging the child entity into the entity manager, the parent entity reference is not instance of Entity\Entity anymore.

You can see full test case in the archive attached.

[DDC-1368] incorrect mapping not detected by orm:validate-schema

Sat, 17 Dec 2011 22:28:18 +0000

The following incorrect mapping was not detected by orm:validate-schema, instead running it resulted in:

$ doctrine orm:validate-schema
[Mapping] OK - The mapping files are correct.

<doctrine-mapping>
...
<one-to-many field="duchies" target-entity="Duchy" mapped-by="realm">
<order-by>
<order-by-field name="name" direction="ASC" />
</order-by>
</one-to-many>
...
</doctrine-mapping>

and the inverse side:

<doctrine-mapping>
<one-to-one field="realm" target-entity="Realm" inversed-by="duchies">
<join-column name="Realm" referenced-column-name="ID" />
</one-to-one>
</doctrine-mapping>

obviously, the inverse side should be many-to-one and not one-to-one. Interesting bugs in the code resulted. Obviously a coder mistake, but orm:validate-schema should have detected that the association has incompatible mappings.

[DDC-1365] Use getQuotedTableName() consistently in all SQL

Sun, 25 Sep 2011 13:13:04 +0000

Its missing in some of the persisters/sql walker code.

[DDC-1360] Reserved words escaping fails when using multiple reserved words

Tue, 3 Jan 2012 21:51:56 +0000

Everything works fine when I use the @Table annotation like this: @Table(name="`user`"). But when the user table is in the user schema and I try to use the annotion in this way: @Table(name="`user`.`user`") — everything falls apart.

A quick look into the code showed that it checks if the table name starts with `, and if it does, it sets the quoted parameter to true and removes the ` characters on the both sides. So, if I quote the both words like @Table(name="`user`.`user`"), the table name becomes "user`.`user" and it, of course, fails. If I quote it just like @Table(name="`user.user`"), the table name becomes "user.user", which fails too.

If Doctrine allows to escape the reserved words, it should take into account this kind of usage as well.

[DDC-1358] Native Query hydration ignores empty entity doublons

Sun, 16 Oct 2011 09:18:17 +0000

My case is the follwing :

In a range of dates, I want to know if an entity has been defined for each day. So the raw SQL result would looks like :

DATE              ID NAME
--------- ---------- -------------
19-SEP-11          4 [Entity Name]
20-SEP-11          1 [Entity Name]
21-SEP-11          2 [Entity Name]
22-SEP-11          3 [Entity Name]
23-SEP-11       NULL NULL
24-SEP-11       NULL NULL
25-SEP-11       NULL NULL
26-SEP-11       NULL NULL
27-SEP-11          7 [Entity Name]
28-SEP-11          6 [Entity Name]
29-SEP-11          5 [Entity Name]

11 rows selected.

The range calculation forced me to use Native Query, but I stumbled upon a strange behavior : the Result array showed less records than the raw SQL would provide. After some dirty debugging, I found out that during hydration, an array of previously hydrated object keys was stored ObjectHydrator->_identifierMap. The key of null elements (the gap in the SQL result above) is stored too. The problem is that when there is multiple empty elements, hydration only keeps one, and forget the others, thus reducing the overall size of the output result.

I've already come up with a quick n'dirty fix wich suits my current needs, but it would be better if this issue was addressed at a more global level.

Here's the one-liner fix :

Doctrine/ORM/Internal/Hydration/ObjectHydrator.php line 397 was :

                if ( ! isset($this->_identifierMap[$dqlAlias][$id[$dqlAlias]]) ) {

Doctrine/ORM/Internal/Hydration/ObjectHydrator.php line 397 now :

                if ( ! isset($this->_identifierMap[$dqlAlias][$id[$dqlAlias]]) || str_replace( '|', '', $id[$dqlAlias]) == '') {

[DDC-1351] Github-PR-111 by Gregwar: [Tools] Added entityRepository support in yaml exporter

Tue, 30 Aug 2011 18:43:36 +0000

This issue is created automatically through a Github pull request on behalf of Gregwar:

Url: https://github.com/doctrine/doctrine2/pull/111

Message:

Adds support for custom entity repository class in the yaml exporter

[DDC-1344] Command Tool does not display the directory name when "destination directory" error occurs

Sat, 27 Aug 2011 11:36:43 +0000

When any generate command fails because of the destination directory error, directory name shown on the displayed message is always empty.

This is because realpath() function returns false when directory does not exist.

Taken  from the file GenerateRepositoriesCommand.php

        // Process destination directory
        $destPath = realpath($input->getArgument('dest-path'));

        if ( ! file_exists($destPath)) {
            throw new \InvalidArgumentException(
                sprintf("Entities destination directory '<info>%s</info>' does not exist.", $destPath)
            );
        }

[DDC-1343] Github-PR-105 by domnikl: DDC-1278 - EntityManager::clear($entity) support

Mon, 17 Oct 2011 13:37:04 +0000

domnikl created a pull request on Github:

Url: https://github.com/doctrine/doctrine2/pull/105

added cascade detach operation only for entites with the same name when $entityName on clear() was specified. I am still unsure where to put my tests for that.

[DDC-1339] New DQL function: IDENTITY(SingleValuedAssociationPathExpression)

Thu, 8 Sep 2011 05:06:20 +0000

Suppose the association: User N:1 Group and user wants to be able to retrieve "users.group_id" without joining the Group entity.
This lead us to create a new DQL function:

SELECT IDENTITY(u.Group) AS group_id FROM User u WHERE u.id = ?0

[DDC-1338] @Entity(repositoryClass) could support short namespace support

Fri, 19 Aug 2011 05:43:45 +0000

Like association mapping, we could take advantage of short namespacing of entity repository class.

Example:

namespace Foo\Bar\Red;

/**
 * Used to be "Foo\Bar\Red\WooRepository"
 * @Entity(repositoryClass="WooRepository")
 */
class Woo { ... }

[DDC-1331] Add IN(...) support to INSTANCE OF

Mon, 15 Aug 2011 04:51:22 +0000

Add IN(...) support to INSTANCE OF

[DDC-1330] Doctrine CLI and additional things like Migrations

Sat, 17 Dec 2011 22:57:23 +0000

I'm currently trying out Migrations. However, it seems to me that it is not possible to easily add migrations to a system-wide installed Doctrine2 ORM.

This bug is probably 50% documentation issue and 50% code issue.

What I'm basically trying to do is to add the migrations project.

Problem One: The $cli object

The documentation for both migrations and ORM state about the $cli object. However, it is never explained how the $cli object is instanciated.

It isn't obvious that $cli is either defined by the doctrine command (=doctrine.php which comes with the sandbox and is eventually installed system-wide) or actually needs to be defined by the developer himself. It might be obvious when you read the complete manual first (like a book, which actually nobody does - at least not anybody I know), but this isn't helpful because the manuals are all reference manuals.

So the manuals need to be changed so that it actually explains where $cli comes from.

http://www.doctrine-project.org/docs/orm/2.1/en/reference/tools.html
http://www.doctrine-project.org/projects/migrations/2.0/docs/reference/introduction/en#introduction

Problem Two: Defining a custom doctrine.php file

As there's no code - at least not which I could have found easily - to add CLI commands to system's doctrine.php without modifying it, developers are forced to duplicate the code of doctrine.php and add their own CLI commands.

The problem could be easily avoided by allowing the users to define something like $additionalCommands in their cli-config.php which could then appended via $cli->addCommands() in the master doctrine.php file.

[DDC-1325] Adding @Target to annotations

Sun, 14 Aug 2011 17:22:47 +0000

Now that the annotation parser has support for the @Target annotation, we should also add it to the annotations of the ORM.

I have looked through the mapping file, but I'm not familiar with all the annotations, so someone else is probably better suited to add them.

Usage is as follows:

@Target("CLASS") for a single target
@Target(

{"CLASS", "METHOD", "PROPERTY", "ANNOTATION"}

) for multiple targets (annotation if it can be used as a nested annotation)

[DDC-1295] Sandbox Sample Code which shall go into cli-config.php and index.php for EntityManager working with yaml is wrong

Fri, 9 Dec 2011 04:34:21 +0000

In http://www.doctrine-project.org/docs/orm/2.1/en/tutorials/getting-started-xml-edition.html
in Section: Obtaining the EntityManager
the Code:

//$driverImpl = new Doctrine\ORM\Mapping\Driver\XmlDriver(_DIR_."/config/mappings/xml");
$driverImpl = new Doctrine\ORM\Mapping\Driver\XmlDriver(_DIR_."/config/mappings/yml");
//$driverImpl = $config->newDefaultAnnotationDriver(_DIR_."/entities");

produces:

PHP Fatal error: Class 'Sandbox\Doctrine\ORM\Mapping\Driver\XmlDriver' not found in ..

Should be corrected to:
$driverImpl = new \Doctrine\ORM\Mapping\Driver\XmlDriver(_DIR_."/config/mappings/yml");

produces:

PHP Fatal error: Uncaught exception 'Doctrine\ORM\Mapping\MappingException' with message 'No mapping file found named 'Entities.User.dcm.xml' ..

Should be corrected to:
$driverImpl = new \Doctrine\ORM\Mapping\Driver\YamlDriver(_DIR_."/config/mappings/yml");

and finally, following the xml yaml Entities folder structure in the sandbox, should be corrected to:

$driverImpl = new \Doctrine\ORM\Mapping\Driver\YamlDriver(_DIR_."/yaml");

With this configuration I was able to create Entities from yaml through these commands:

doctrine orm:generate-entities ./
doctrine orm:schema-tool:create

[DDC-1293] Update DQL function signature in documentation

Fri, 9 Dec 2011 04:36:30 +0000

The documentation concerning the new DQL Date functions is outdated, as the 'unit' of the interval is not described.

 
DATE_ADD(date, days) - Add the number of days to a given date.
DATE_SUB(date, days) - Substract the number of days from a given date.

Should be

 
DATE_ADD(date, interval, unitOfInterval)

for example:

 
DATE_ADD(CURRENT_DATE(), 1, 'DAY');
DATE_SUB(CURRENT_DATE(), 4, 'MONTH');

UPDATE: it appears parameters are not injected properly when using the DATE functions:

 
$qb->where("x._lastMutationDateTime < DATE_ADD(CURRENT_DATE(),?1,'day')");
$qb->setParameter(1, 5);

Results in:

//DQL
SELECT x FROM Entity p WHERE x._lastMutationTimestamp < DATE_ADD(CURRENT_DATE(),?1,'day')
//SQL:
SELECT x0_.id AS id0, x0_.last_mutation_timestamp AS last_mutation_timestamp1
WHERE x0_.last_mutation_timestamp < DATE_ADD(CURRENT_DATE, INTERVAL 0 DAY)

[DDC-1290] Version fields do not accept smallint and bigint

Tue, 26 Jul 2011 20:24:42 +0000

In ClassMetadataInfo there is a method called setVersionMapping.

It sets default values for the version fields, but only for integer and datetime.
As I expected that smallint and bigint would be handled the same way, I would consider the fact they are missing as a bug.

So instead of

if ($mapping['type'] == 'integer') {

it should probably be

if (in_array($mapping['type'], array('integer', 'smallint', 'bigint'))) {

[DDC-1288] Column Name

Tue, 16 Aug 2011 05:22:31 +0000

Hello, I am starting development with symfony Doctrine ORM, and I'm one big question: the company where I work, there is a table in a database whose field (column) must be called "call-limit", (I repeat, have to have this name), but I can not for the Doctrine does not allow ... Is there any way to treat this? I've tried using the alias, but to no avail ... If someone can help me ... Hug.

[DDC-1286] Change typo in ORMException

Sun, 14 Aug 2011 03:07:00 +0000

Doctrine\ORM\ORMException, like 42:
"however this entity has no ientity itself. You have to call EntityManager#persist() on the related entity " .

should be:
"however this entity has no identity itself. You have to call EntityManager#persist() on the related entity " .

[DDC-1284] Inheritance fails in JOIN query

Sun, 14 Aug 2011 03:18:40 +0000

Hi!
Sorry for my english, I'm working on that.
I've this code:

/**
 * @Entity
 * @Table(name="entity") 
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="entityTypeId", type="smallint")
 * @DiscriminatorMap({0 = "Bank",  1 = "Dealer", 2 = "Debtor", 3 = "Repo", 4 = "Appraiser", 5 = "Transport"})
 */
class Entities
{
     /**
     * @Id @GeneratedValue
     * @Column(type="integer")
     * @var integer
     */
    protected $id;

   /**
     * @Column(type="string", length=40)
     * @var text
     */
    protected $name;

    ............................................................
    ............................................................
}

------------------------------------------------------------------------------------------------------------------------------------
/** 
 * @Entity(repositoryClass="Model\Entity\Repository\DebtorRepository")
 * @Table(name="debtor") 
 */ 
class Debtor extends Entities{
    
}

------------------------------------------------------------------------------------------------------------------------------------
 
/**
 * @Entity(repositoryClass="Model\Entity\Repository\PlacementRepository")
 * @Table(name="placement")
 */
class Placement
{
      
    /**
     * @Id
     * @Column(type="smallint")
     * @var integer
     */
    protected $id;


       /**
     * @ManyToOne(targetEntity="Debtor", inversedBy="placements")
     * @JoinColumn(name="debtorId", referencedColumnName="id")
     */
    protected $debtor;
 
........................................
.......................................
}

The DQL query:

"SELECT t1 FROM Model\Entity\Placement t1 INNER JOIN t1.debtor d WITH d.name = 'test' "

fails and show the message

"SQLSTATE[42S22]: Column not found: 1054 Unknown column 'e2_.name' in 'on clause'"

I hope somebody know how fix this, I can't fixing this.

[DDC-1278] EntityManager::clear($entity) support

Sun, 16 Oct 2011 20:49:18 +0000

It was originally planned that EntityManager::clear() would also support an optional argument - $entity -, which would remove only the reference to an existent entity (maybe also consider a new cascade to allow graph clearing) from UoW.
Currently, it's win or wall. You can't clear a specific portion of Entities.

[DDC-1277] BasicEntityPersister::expandParameters() will check associations

Sun, 14 Aug 2011 00:27:55 +0000

When executing a EntityRepository::findBy() or EntityRepository::findOnyBy() with criteria that contain a field/value pair where the field is an association-name and the value is an array, some (for me) unexpected behavior occurs.

First an example to make my statement a bit more clear:
I have an entity User and Group where Group has many Users (User many-to-one Group).

When I call UserRepository->findBy( array( 'group' => 1 )), all goes well.
When I call UserRepository->findBy( array( 'group' => array( 1, 2, 3 ))), I get an notice and no results (Notice: Array to string conversion in /opt/local/www/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php on line 613)

I've tracked the "problem" down to the BasicEntityPersister:

BasicEntityPersister::_getSelectEntitiesSQL(), which uses BasicEntityPersister::_getSelectConditionSQL(), correctly creates a query containing something like WHERE t0.group_id IN ( ? ).
But BasicEntityPersister::expandParameters() doesn't implode the array to some string that can be bound to the query. This is because it doesn't take into account that the field could be an association.

I don't know if this is intended behavior, but I would think not. I've therefor altered the BasicEntityPersister::expandParameters() a bit:

private function expandParameters($criteria)
    {
        $params = $types = array();

        foreach ($criteria AS $field => $value) {
            if ($value === null) {
                continue; // skip null values.
            }

            $type = null;
            if (isset($this->_class->fieldMappings[$field])) {
                $type = Type::getType($this->_class->fieldMappings[$field]['type'])->getBindingType();
            // BEGIN: Jasper N. Brouwer (14-07-2011)
            } else if (isset($this->_class->associationMappings[$field])) {
                if ($this->_class->associationMappings[$field]['isOwningSide']) {
                    $targetClass = $this->_em->getClassMetadata($this->_class->associationMappings[$field]['targetEntity']);
                    $targetField = $this->_class->associationMappings[$field]['joinColumns'][0]['referencedColumnName'];
                    if (isset($targetClass->fieldMappings[$targetField])) {
                        $type = Type::getType($targetClass->fieldMappings[$targetField]['type'])->getBindingType();
                    }
                }
            // END: Jasper N. Brouwer (14-07-2011)
            }
            if (is_array($value)) {
                $type += Connection::ARRAY_PARAM_OFFSET;
            }
            
            $params[] = $value;
            $types[] = $type;
        }
        return array($params, $types);                                                                                  
    }

I hope this bit of code also clarifies what I'm trying to explain a bit more...

[DDC-1272] Ability to choose another column name than ID as automatic record identifier in generate:doctrine:crude

Sun, 14 Aug 2011 03:05:12 +0000

I got a message while crude generating because of my column names in the database model. They are not "id" named. Could be nice to get a parameter for that ?

[DDC-1271] Failing tests for PostgreSQL

Sun, 31 Jul 2011 09:56:40 +0000

The pgsql.phpunit.xml file:

<php>
    <!-- "Real" test database -->
    <var name="db_type" value="pdo_pgsql"/>
    <var name="db_host" value="localhost" />
    <var name="db_username" value="root" />
    <var name="db_password" value="root" />
    <var name="db_name" value="doctrine_tests" />
    <var name="db_port" value="5432"/>

    <!-- Database for temporary connections (i.e. to drop/create the main database) -->
    <var name="tmpdb_type" value="pdo_pgsql"/>
    <var name="tmpdb_host" value="localhost" />
    <var name="tmpdb_username" value="root" />
    <var name="tmpdb_password" value="root" />
    <var name="tmpdb_name" value="doctrine_tests_tmp" />
    <var name="tmpdb_port" value="5432"/>
</php>

root is a user created by me, with SUPERUSER provileges:

ALTER ROLE root WITH SUPERUSER INHERIT NOCREATEROLE CREATEDB LOGIN PASSWORD 'root';

Test output:

PHPUnit 3.5.10 by Sebastian Bergmann.

.SSSSSS......................................F...............   61 / 1137 (  5%)
............................S................................  122 / 1137 ( 10%)
.............................................................  183 / 1137 ( 16%)
.............................................................  244 / 1137 ( 21%)
........................................F....................  305 / 1137 ( 26%)
..........................SSS................................  366 / 1137 ( 32%)
S............................................................  427 / 1137 ( 37%)
....................SS.......................................  488 / 1137 ( 42%)
.............................................................  549 / 1137 ( 48%)
............................................................S  610 / 1137 ( 53%)
..................S..........................................  671 / 1137 ( 59%)
.............................................................  732 / 1137 ( 64%)
.............................................................  793 / 1137 ( 69%)
.............................................................  854 / 1137 ( 75%)
.............................................................  915 / 1137 ( 80%)
.............................................................  976 / 1137 ( 85%)
............................................................. 1037 / 1137 ( 91%)
............................................................. 1098 / 1137 ( 96%)
.................

Time: 57 seconds, Memory: 145.25Mb

There were 2 failures:

1) Doctrine\Tests\ORM\Functional\BasicFunctionalTest::testRemove
Failed asserting that <integer:3> matches expected <integer:2>.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/BasicFunctionalTest.php:161

2) Doctrine\Tests\ORM\Functional\QueryDqlFunctionTest::testDateDiff
Should be roughly -10 (or -9)
Failed asserting that <string:-10 days> matches expected <integer:-10>.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/QueryDqlFunctionTest.php:280

--

Deprecated PHPUnit features are being used

47, ommited by me :)

--

There were 15 skipped tests:

1) Doctrine\Tests\ORM\Query\DqlGenerationTest::testSelect
Not yet implemented.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Criteria/DqlGenerationTest.php:40

2) Doctrine\Tests\ORM\Query\DqlGenerationTest::testSelectDistinct
Not yet implemented.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Criteria/DqlGenerationTest.php:40

3) Doctrine\Tests\ORM\Query\DqlGenerationTest::testSelectJoin
Not yet implemented.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Criteria/DqlGenerationTest.php:40

4) Doctrine\Tests\ORM\Query\DqlGenerationTest::testSelectWhere
Not yet implemented.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Criteria/DqlGenerationTest.php:40

5) Doctrine\Tests\ORM\Query\DqlGenerationTest::testSelectWhereIn
Not yet implemented.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Criteria/DqlGenerationTest.php:40

6) Doctrine\Tests\ORM\Query\DqlGenerationTest::testDelete
Not yet implemented.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Criteria/DqlGenerationTest.php:40

7) Doctrine\Tests\ORM\Functional\CompositePrimaryKeyTest::testCompositeCollectionMemberExpression
How to test this?

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/CompositePrimaryKeyTest.php:83

8) Doctrine\Tests\ORM\Functional\SchemaTool\MySqlSchemaToolTest::testGetCreateSchemaSql
The Doctrine\Tests\ORM\Functional\SchemaTool\MySqlSchemaToolTest requires the use of mysql.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/SchemaTool/MySqlSchemaToolTest.php:15

9) Doctrine\Tests\ORM\Functional\SchemaTool\MySqlSchemaToolTest::testGetCreateSchemaSql2
The Doctrine\Tests\ORM\Functional\SchemaTool\MySqlSchemaToolTest requires the use of mysql.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/SchemaTool/MySqlSchemaToolTest.php:15

10) Doctrine\Tests\ORM\Functional\SchemaTool\MySqlSchemaToolTest::testGetCreateSchemaSql3
The Doctrine\Tests\ORM\Functional\SchemaTool\MySqlSchemaToolTest requires the use of mysql.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/SchemaTool/MySqlSchemaToolTest.php:15

11) Doctrine\Tests\ORM\Functional\Ticket\DDC1050Test::testPerformance
performance skipped

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1050Test.php:15

12) Doctrine\Tests\ORM\Functional\Ticket\DDC758Test::testManyToManyMergeAssociationAdds
Destroys testsuite

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC758Test.php:17

13) Doctrine\Tests\ORM\Functional\Ticket\DDC758Test::testManyToManyMergeAssociationRemoves
Destroys testsuite

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC758Test.php:17

14) Doctrine\Tests\ORM\Mapping\PHPMappingDriverTest::testDiscriminatorColumnDefaults
PHP Mapping Drivers have no defaults.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php:284

15) Doctrine\Tests\ORM\Mapping\StaticPHPMappingDriverTest::testDiscriminatorColumnDefaults
PHP Mapping Drivers have no defaults.

/mnt/fs/doctrine/github/Infranology/doctrine2/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php:284

[DDC-1260] Enable nesting of OR and AND statements in DQL queries

Dependency — Mon, 8 Aug 2011 05:10:29 +0000

Currently it is not allowed to nest AND and OR conditions in themselves. However, this comes in handy if you try to do a dynamic query rewriting, where you want to add some more conditions without knowing the original query before.

The fix is trivial, just allow to add AND in AND. The same needs to be done for OR. Patch will follow in a second...

[DDC-1258] Add Debug Listener for UnitOfWork

Sat, 9 Jul 2011 20:18:00 +0000

Sometimes you need to debug complex scenarios where cascade operations fail or something weird happens in the UnitOfWork. There should be a listener that dumps the state of the identity map in "onFlush" so that you can more easily see whats going on.

[DDC-1257] Duplicate PHP methods generated from XML metadata lifecycle-callbacks

Sat, 9 Jul 2011 13:16:54 +0000

If lifecycle callbacks are added to XML metadata like so:

	<lifecycle-callbacks>
		<lifecycle-callback type="prePersist" method="validate" />
		<lifecycle-callback type="preUpdate" method="validate" />
	</lifecycle-callbacks>

The validate() method will appear twice in an entity generated from this metadata.

[DDC-1251] EntityGenerator uses non-existing constant T_AMPERSAND

Sat, 9 Jul 2011 12:57:33 +0000

As per http://www.php.net/manual/en/tokens.php - the T_AMPERSAND token does not exist. I'm not sure what was the intent, but the entity generator fails on the following code:

            $elems = array_map(function($el) {
                return $el;
            }, $elems);

Due to the way notices are handled in Symfony, this basically stops the execution of the generator entirely. Not so great.

  [ErrorException]                                                                                            
  Notice: Use of undefined constant T_AMPERSAND - assumed 'T_AMPERSAND' in ./vendor/doctrine/lib/Doctrine/ORM/Tools/EntityGenerator.php line 454

Commenting out the offending line makes it work fine though, so I think it's just choking while expecting a function that takes args by reference or something.

[DDC-1236] GROUP BY does not work with functions

Fri, 2 Dec 2011 17:10:54 +0000

The following query fails with Cannot group by undefined identification variable (yes CAST-Function was added). Would be nice to have such a feature,

SELECT ...
FROM Task t
...
WHERE
  ...
GROUP BY
  CAST(t.scheduledDate as date)

[DDC-1225] Invalid SQL generated (extra comma) when joining to entity with composite PK

Mon, 29 Aug 2011 19:56:26 +0000

            $qb->from('Tournaments_Model_StageBracketTeamRegistration', 'r')
               ->innerJoin('r.teamSelection', 'ts')
               ->innerJoin('ts.players', 'tsp')
               ->select('r, ts, tsp')
               ->where('r.stageBracket = ?1')
               ->andWhere('r.opponentIsReserve = false')
               ->orderBy('r.registrationDateTime')
               ->setParameter(1, $bracket);

Generates:

SELECT s0_.id AS id0, s0_.opponent_is_reserve AS opponent_is_reserve1, s0_.opponent_checked_in AS opponent_checked_in2, s0_.registration_date_time AS registration_date_time3, t1_.id AS id4,, s0_.type AS type5, s0_.stage_bracket_id AS stage_bracket_id6, s2_.team_selection_id AS team_selection_id7, t1_.team_id AS team_id8, t3_.team_selection_id AS team_selection_id9, t3_.player_id AS player_id10
FROM stage_bracket_team_registrations s2_
INNER JOIN stage_bracket_registrations s0_ ON s2_.id = s0_.id
INNER JOIN team_selections t1_ ON s2_.team_selection_id = t1_.id
INNER JOIN team_selection_players t3_ ON t1_.id = t3_.team_selection_id
WHERE s0_.stage_bracket_id = 22 AND s0_.opponent_is_reserve = 0
ORDER BY s0_.registration_date_time ASC

Note the 2nd comma after "t1_.id AS id4". TeamSelectionPlayer uses a composite PK. I have attached the relevant entity classes.

[DDC-1213] Make Bit comparsion available

Thu, 9 Feb 2012 13:31:10 +0000

When you go to compare Bit Values in MySQL Database you can do thiy by "&" or "|" If you do this with Doctrine 2 you got an exception like following:
Message: [Syntax Error] line 0, col 161: Error: Expected =, <, <=, <>, >, >=, != got '&'

So i fixed this problem for me:

Doctrine\ORM\Query\Parser:
Line 2633

    /**
     * ComparisonOperator ::= "=" | "<" | "<=" | "<>" | ">" | ">=" | "!=" | "&" | "|"
     *
     * @return string
     */
    public function ComparisonOperator()
    {
        switch ($this->_lexer->lookahead['value']) {
            case '=':
                $this->match(Lexer::T_EQUALS);

                return '=';

            case '<':
                $this->match(Lexer::T_LOWER_THAN);
                $operator = '<';

                if ($this->_lexer->isNextToken(Lexer::T_EQUALS)) {
                    $this->match(Lexer::T_EQUALS);
                    $operator .= '=';
                } else if ($this->_lexer->isNextToken(Lexer::T_GREATER_THAN)) {
                    $this->match(Lexer::T_GREATER_THAN);
                    $operator .= '>';
                }

                return $operator;

            case '>':
                $this->match(Lexer::T_GREATER_THAN);
                $operator = '>';

                if ($this->_lexer->isNextToken(Lexer::T_EQUALS)) {
                    $this->match(Lexer::T_EQUALS);
                    $operator .= '=';
                }

                return $operator;

            case '!':
                $this->match(Lexer::T_NEGATE);
                $this->match(Lexer::T_EQUALS);

                return '<>';
            /* Changes by SR-RM to make Bit Oprations available */
            case '&':
            	$this->match(LEXER::T_BIT_AND);
            	return '&';
            case '|':
            	$this->match(LEXER::T_BIT_OR);
            	return '|';
            /* Changes by SR-RM End */
            default:
                $this->syntaxError('=, <, <=, <>, >, >=, !=, &, |');
        }
    }

Doctrine\ORM\Query\Lexer:
Line 53

/* Changes SR-RM to make Bit Oprations available */
const T_BIT_AND             = 30;
const T_BIT_OR               = 31;
/* Changes by SR-RM End */

Line 193

/* Changes SR-RM to make Bit Oprations available */
case '&': return self::T_BIT_AND;
case '|': return self::T_BIT_OR;
/* Changes by SR-RM End */

So, maybe you gonna ad this in next Release

Thanks or your good Job

[DDC-1170] XML Mapping : add attribute "column-definition" for tag "id"

Mon, 5 Dec 2011 20:17:07 +0000

XML mapping :

<id name="id" type="integer">
      <generator strategy="IDENTITY"/>
</id>

Generate SQL :

id int auto_increment not null

It's not possible with XML mapping to have :

 id int UNSIGNED not null auto_increment

Because tag "id" doesn't support "column-definition" attribute.
We can have same problem for others types parameters.

I suggest this solution : in file <Doctrine/ORM/Mapping/Driver/XmlDriver.php>

// add this code to line 226 ( in the "Evaluate <id ...>" bloc after the array "mapping" )  :

if(isset($idElement['column-definition'])){
                $mapping['columnDefinition'] = (string)$idElement['column-definition'];
}

New XML mapping :

<id name="id" type="integer" column="id" column-definition="INT unsigned NOT NULL" >
      <generator strategy="IDENTITY"/>
</id>

Warning : "column-definition" must not contains "AUTO_INCREMENT" (added automaticly) :

<id name="id" type="integer" column="id" column-definition="INT unsigned NOT NULL AUTO_INCREMENT" >
      <generator strategy="IDENTITY"/>
</id>

With "AUTO_INCREMENT" in column-definition all foreign keys contain this parameter.

[DDC-1165] [ Proposal] entityMethod#find() for Entity with ForeignKey as PrimaryKey, pass entity object instead of id

Sun, 14 Aug 2011 03:49:05 +0000

Hi all, i am currently using Doctrine 2.1Beta because i have an entity with foreignKey as primaryKey:

class IndividualsStatus
{
/**

@var Individuals
*
@Id
@ManyToOne(targetEntity="Individuals", inversedBy="diagnosers", cascade= {"persist","refresh"})
* @JoinColumns({ * @JoinColumn(name="individuals_id", referencedColumnName="id") * })
*/
private $individuals;

/**
* @var Diagnosers
*
* @Id
* @ManyToOne(targetEntity="Diagnosers", inversedBy="individuals", cascade={"persist","refresh"}
)
@JoinColumns( { * @JoinColumn(name="diagnosers_id", referencedColumnName="id") * }
)
*/
private $diagnosers;

/**

@var smallint $status
*
@Column(name="status_individuals", type="smallint")
*/
private $statusIndividuals;
}

i use the em find method to get an IndividualsStatus entity, i am expecting to do:

$individuals = $em->find('Individuals', 10);
$diagnosers = $em->find('Diagnosers', 15);

$individualsStatus = $em->find('IndividualsStatus', array('individiduals' => $individuals, 'diagnosers' => $diagnosers));

But i have to do:
$individualsStatus = $em->find('IndividualsStatus', array('individiduals' => $individuals->getId(), 'diagnosers' => $diagnosers->getId()));

It's very trivial but maybe another people was expecting that too.

Cheers

[DDC-1161] DQL generate duplicate SQL Alias with CTI + oneToOne self referencing

Sun, 16 Oct 2011 03:44:19 +0000

Hi,

I have a Entity "Content" whith several childs entities like "Page" , "Article" in Joined inheritance.
I make DQL directly on entity "Content", that work perfectly with the discriminator map for return/delete/update appropriates objects.
I use "Page" or "Article" entity only for make a new object and persist.

But now I have add a oneToOne self relation in "Content" :
Content#parent_id => Content#id , no cascade.

And now every DQL return :
SQLSTATE[42000]: Syntax error or access violation: 1066 Not unique table/alias: XX
And yes I see in generated SQL that Content's alias is not unique :

For DQL : SELECT c FROM Content WHERE c.status = 1

SQL Result :

SELECT n0_.id AS id0, n0_.name AS name1, n0_.title AS title2, n0_.author AS author3, n0_.author_update AS author_update4, n0_.status AS status5, n0_.type AS type6, n0_.weight AS weight7, n0_.create_on AS create_on8, n0_.update_on AS update_on9, n0_.url AS url10, n0_.zone AS zone11, n0_.children_sort AS children_sort12, n0_.children_sort_type AS children_sort_type13, n0_.path AS path14, n0_.level AS level15, n1_.meta AS meta16, n2_.content AS content17, n3_.description AS description18, n3_.keywords AS keywords19, n3_.gwt AS gwt20, n3_.analytics AS analytics21, n3_.xiti AS xiti22, n0_.class AS class23 FROM ncms_content n0_ LEFT JOIN ncms_page n1_ ON n0_.id = n1_.id LEFT JOIN ncms_article n2_ ON n0_.id = n2_.id LEFT JOIN ncms_content n0_ ON n0_.id = n0_.id LEFT JOIN ncms_content n0_ ON n0_.id = n0_.id LEFT JOIN ncms_content n0_ ON n0_.id = n0_.id LEFT JOIN ncms_content n0_ ON n0_.id = n0_.id LEFT JOIN ncms_content n0_ ON n0_.id = n0_.id LEFT JOIN ncms_website n3_ ON n0_.id = n3_.id LEFT JOIN ncms_content n0_ ON n0_.id = n0_.id WHERE n0_.status =1

=> SQLSTATE[42000]: Syntax error or access violation: 1066 Not unique table/alias: 'n0_'

But if I use getRepository like this :
$em->getRepository('Content')->findBy(array('status'=>1));
It works, and return appropriates objects.
And I can see that "Content" have several unique alias in the SQL query :

SELECT t0.id AS id1, t0.name AS name2, t0.title AS title3, t0.author AS author4, t0.author_update AS author_update5, t0.status AS status6, t0.type AS type7, t0.weight AS weight8, t0.create_on AS create_on9, t0.update_on AS update_on10, t0.url AS url11, t0.zone AS zone12, t0.children_sort AS children_sort13, t0.children_sort_type AS children_sort_type14, t0.path AS path15, t0.level AS level16, t0.parent_id AS parent_id17, t0.class, t18.meta AS meta19, t20.content AS content21, t27.description AS description28, t27.keywords AS keywords29, t27.gwt AS gwt30, t27.analytics AS analytics31, t27.xiti AS xiti32 FROM ncms_content t0 LEFT JOIN ncms_page t18 ON t0.id = t18.id LEFT JOIN ncms_article t20 ON t0.id = t20.id LEFT JOIN ncms_content t22 ON t0.id = t22.id LEFT JOIN ncms_content t23 ON t0.id = t23.id LEFT JOIN ncms_content t24 ON t0.id = t24.id LEFT JOIN ncms_content t25 ON t0.id = t25.id LEFT JOIN ncms_content t26 ON t0.id = t26.id LEFT JOIN ncms_website t27 ON t0.id = t27.id LEFT JOIN ncms_content t33 ON t0.id = t33.id WHERE t0.status =1

Regards,

[DDC-1150] BasicEntityPersister::expandParameters does not check assiciation mapping when expanding parameters

Sun, 14 Aug 2011 00:26:45 +0000

If you try to find entities, filtering them by field with association mapping (ManyToOne) and use an array as a filter argument it will not work:

    $em->getRepository('EntityBundle:Entity')->findBy(array('child' => array(1,2,3)));
    8 Array to string conversion vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php 595

I fixed method BasicEntityPersister::expandParameters:

Index: ../vendor/doctrine/lib/Doctrine/ORM/Persisters/BasicEntityPersister.php
===================================================================
@@ -1300,6 +1300,9 @@
             if (isset($this->_class->fieldMappings[$field])) {
                 $type = Type::getType($this->_class->fieldMappings[$field]['type'])->getBindingType();
             }
+            if (isset($this->_class->associationMappings[$field])) {
+                $type = $this->_class->associationMappings[$field]['type'];
+            }
             if (is_array($value)) {
                 $type += Connection::ARRAY_PARAM_OFFSET;
             }

[DDC-1131] Couldn't find a class in a subselect

Tue, 16 Aug 2011 05:29:42 +0000

This dql query work fine

From GrrArea a where a.id not in (select code from Customer where code is not null)

But this

From GrrArea a where a.id not in (select c.code from Customer c where c.code is not null)

Generate this error message : Couldn't find class c, I also try the subselect alone

select c.code from Customer c where c.code is not null

which works fine

[DDC-1116] Sort by association id

Sun, 14 Aug 2011 03:43:33 +0000

For now it is not possible to sort a result by an association field.

ie : SELECT * FROM Post as p ORDER BY p.Author

[DDC-1107] Make QueryBuilder's setParameters method mirror the behavior of AbstractQuery's

Sun, 14 Aug 2011 03:54:47 +0000

In ORM/QueryBuilder.php,

public function setParameters(array $params, array $types = array())
{
    $this->_paramTypes = $types;
    $this->_params = $params;
    return $this;
}

Makes it so that in order to use the QueryBuilder to conditionally build up a query you have to hold the parameters to be set in a separate variable and call setParameters when you're done building your query, instead of being able to call setParameters at the spot where it would be apparent what that parameter is to someone reading the code. Compare to the method in ORM/AbstractQuery.php:

public function setParameters(array $params, array $types = array())
{
    foreach ($params as $key => $value) {
        if (isset($types[$key])) {
            $this->setParameter($key, $value, $types[$key]);
        } else {
            $this->setParameter($key, $value);
        }
    }
    return $this;
}

which can be called multiple times safely.

It would be awesome if the QueryBuilder's behavior could be modified to match that of AbstractQueries in this regard, but if there's a good reason for the difference in behavior, a mention in the API/Reference docs would be much appreciated.

[DDC-1100] INSTANCE OF and IN in QueryBuilder

Mon, 15 Aug 2011 04:51:55 +0000

I need to obtain specific entity instances. And I don't know how to write better solution for my problem

$nodes = array('Entities\FooNode', 'Entities\BarNode');

$qb->select('Entities\Node', 'n')->where("n.level = 1"); 
$classes = array(); 
foreach ($nodes as $class) { 
        $classes[] = "n INSTANCE OF " . $class; 
} 

$qb->andWhere(call_user_func_array(array($qb->expr(), 'orx'), $classes)));

[DDC-1073] Refactor SqlWalker::walkGroupByItem not to use PathExpression anymore but accept strings (identification variable) aswell

Reference — Sun, 4 Dec 2011 07:39:34 +0000

Due to ~~DDC-1053~~ the code in SqlWalker::walkGroupByClause and ::walkGroupByItems() is not as nice as it could be. This is because of the PathExpression type hint.

[DDC-1071] CASE expressions do not work as documented in EBNF

Dependency — Mon, 8 Aug 2011 05:08:41 +0000

The EBNF definition of DQL on the website (http://www.doctrine-project.org/docs/orm/2.0/en/reference/dql-doctrine-query-language.html) defines the SELECT expression as follows:

A ScalarExpression, in turn, is defined as follows:

There is already a missing ''|" between "StateFieldPathExpression" and "BooleanPrimary" here.

But ignoring that detail, this definition states that case expressions can show up anywhere in the list of values to be selected in a query, which, of course, would come in handy.

Contrary to this definition, queries like this one will not work:

SELECT someEntity.a, CASE someEntity.b WHEN 1 THEN 'A' ELSE 'B' END FROM \someEntity;

Whereas queries like this one will:

SELECT CASE someEntity.b WHEN 1 THEN 'A' ELSE 'B' END FROM \someEntity;

Both queries should be legitimate, according to the EBNF definition.

In addition, CASE expressions are not allowed in subselects either, although the EBNF definition of the SimpleSelectExpression states that they should be.

[DDC-1057] The methods of ResultSetMapping should return the current object

Wed, 7 Dec 2011 15:26:13 +0000

The ResultSetMapping class methods should return the current object, so that a fluent interface is provided. Its just a minor issues but makes the class more pleasant to use.

[DDC-1028] MsSQL-Server DateTime microseconds issue

Mon, 9 Jan 2012 13:19:12 +0000

The string for the function getDateTimeFormatString() in the MsSqlPlatform class is 'wrong'.
The Microsoft-SQL-Server just uses 3 digits for microseconds and not 6.
So the string 'Y-m-d H:i:s.u' fails and the server states: [SQL Server]Fehler beim Konvertieren einer Zeichenfolge in einen datetime-Wert (Error when converting a string to a datetime-value) .

So this string works, but does not regard the microseconds for those how rely on them: 'Y-m-d H:i:s.000'

See also:
[...] The MS datetime column is documented to have an accuracy of only about .3 seconds anyway [...]
http://bytes.com/topic/sql-server/answers/80150-inserting-datetime-milliseconds-sql-server

http://msdn.microsoft.com/en-gb/library/ms186819.aspx (Section: Remarks)

[DDC-1022] Wakeup behavior difference between proxy and eager-loaded instance

Sat, 9 Jul 2011 12:39:36 +0000

When an object is reconstituted from the persistent storage the unserialize trick is used. That means __wakeup() is called, which is useful to do further initialization as needed.

If the object is lazy loaded a proxy is generated. That proxy is generated with new and thus no _wakeup() is called. When the proxy is eventually initialized still no call to _wakeup() is done, thus initialization code that is "usually" executed is not called when an object is lazy-loaded.

That is a semantical error.

[DDC-1013] Possible issue with multiple levels of Mappedsuperclasses and wrong sql table aliases

Reference — Sun, 14 Aug 2011 16:18:34 +0000

Possible issue with multiple levels of Mappedsuperclasses and wrong sql table aliases

[DDC-979] ArrayHydrator::updateResultPointer() must be an array, string given

Sun, 11 Dec 2011 07:51:06 +0000

I have the following MySQL tables + data

CREATE TABLE `agent` (
  `agentID` bigint(20) NOT NULL AUTO_INCREMENT,
  `company` varchar(255) DEFAULT NULL,
  PRIMARY KEY (`agentID`)
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8 COMMENT='module=agent';

CREATE TABLE `file` (
  `fileID` bigint(20) NOT NULL AUTO_INCREMENT,
  `filename` varchar(100) DEFAULT NULL,
  `mimetype` varchar(100) DEFAULT NULL,
  `extension` varchar(5) DEFAULT NULL,
  `path` varchar(255) DEFAULT NULL,
  PRIMARY KEY (`fileID`)
) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8 COMMENT='module=agent';

CREATE TABLE `agentFile` (
  `agentID` bigint(20) NOT NULL COMMENT 'orderBy=orderNr&order=asc',
  `fileID` bigint(20) NOT NULL,
  `orderNr` int(11) DEFAULT NULL,
  PRIMARY KEY (`agentID`,`fileID`),
  KEY `agentFileAgent` (`agentID`),
  KEY `agentFileFile` (`fileID`),
  CONSTRAINT `agentFileAgent` FOREIGN KEY (`agentID`) REFERENCES `agent` (`agentID`) ON DELETE CASCADE ON UPDATE NO ACTION,
  CONSTRAINT `agentFileFile` FOREIGN KEY (`fileID`) REFERENCES `file` (`fileID`) ON DELETE CASCADE ON UPDATE NO ACTION
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COMMENT='module=agent';


INSERT INTO `agent` (agentID,company) VALUES (1,'Company 1');
INSERT INTO `agent` (agentID,company) VALUES (2,'Company 2');
INSERT INTO `file` (fileID,filename,mimetype,extension,path) VALUES (1,'logoCompany2',NULL,NULL,NULL);
INSERT INTO `agentFile` (agentID,fileID,orderNr) VALUES (2,1,0);

Everything works fine if I do the following:

$query = $em->createQuery('SELECT a, af, f FROM Agent_Model_Agent a LEFT JOIN a._agentFileRefAgent af WITH af._orderNr=0 LEFT JOIN af._file f');
$results = $query->getResult();

But I get an error when I replace getResult with getArrayResult.

$query = $em->createQuery('SELECT a, af, f FROM Agent_Model_Agent a LEFT JOIN a._agentFileRefAgent af WITH af._orderNr=0 LEFT JOIN af._file f');
$results = $query->getArrayResult();

Error:

Catchable fatal error: Argument 1 passed to Doctrine\ORM\Internal\Hydration\ArrayHydrator::updateResultPointer() must be an array, string given, called in /var/www/vhost/issue/htdocs/externals/Doctrine/lib/Doctrine/ORM/Internal/Hydration/ArrayHydrator.php on line 150 and defined in /var/www/vhost/issue/htdocs/externals/Doctrine/lib/Doctrine/ORM/Internal/Hydration/ArrayHydrator.php on line 207
0.2773	12011956	Doctrine\ORM\AbstractQuery->getArrayResult( )	../IndexController.php:18
0.2773	12012164	Doctrine\ORM\AbstractQuery->execute( )	../AbstractQuery.php:378
0.3262	12217064	Doctrine\ORM\Internal\Hydration\AbstractHydrator->hydrateAll( )	../AbstractQuery.php:527
0.3263	12199568	Doctrine\ORM\Internal\Hydration\ArrayHydrator->_hydrateAll( )	../AbstractHydrator.php:99
0.3276	12219368	Doctrine\ORM\Internal\Hydration\ArrayHydrator->_hydrateRow( )	../ArrayHydrator.php:62
0.3277	12223840	Doctrine\ORM\Internal\Hydration\ArrayHydrator->updateResultPointer( )	../ArrayHydrator.php:150

[DDC-934] Parameter binding documentation inconsistency

Mon, 15 Aug 2011 04:51:35 +0000

In http://www.doctrine-project.org/docs/orm/2.0/en/reference/dql-doctrine-query-language.html it is stated that you bind :parameter placeholders including the colon. However, this doesn't seem to be the case.

To find the location in the documentation, search for :groupid.

It would be nice if doctrine would either output a warning/an exception if you try to use ":parameter" instead of "parameter" or simply strip the colon from the input.

This bug should be fixed prior the final release, since it makes new doctrine users scratch their head.

[DDC-766] Parameter not used in OrmTestCase

Sun, 16 Oct 2011 04:11:25 +0000

The param $eventManager in OrmTestCase::_getTestEntityManager is not used and should be removed.

(However, I'm not sure whether this would be a change to API and thus I don't do it myself but file this as an issue)

[DDC-753] RepositoryClass for MappedSuperclass or other global set custom repository

Sun, 13 Nov 2011 21:16:57 +0000

I need global repository class setter for all my entities. Because manualy set on all entity is not DRY.

My idea is two possibilities. First is param for MappedSuperclass:

/**
 * @MappedSuperclass(repositoryClass=MyRepository)
 */
class Foo {}

or config option (same as proxy dir/namespace)

$config = new \Doctrine\ORM\Configuration;
$config->setDefaultRepository('MyRepository');

[DDC-744] invalid onDelete value inside of @JoinColumn annotation throws an exception instead of valueable error message

Sun, 16 Oct 2011 04:14:24 +0000

Invalid onDelete value throws an exception in doctrine cli interface. It would be nice that developer can see what error occured and where fix it. Exception does not have any information about invalid onDelete value or file & line pointer to problem.

[DDC-725] Consider removing onUpdate attribute from join column mappings

Tue, 26 Jul 2011 21:14:50 +0000

If onUpdate is only ever used in cases where a primary key changes, which is bad design and not supported by doctrine anyway, there is no reason to support this attribute.

[DDC-720] Ability to call flush only for a given entity

Sun, 13 Nov 2011 20:44:02 +0000

In a nutshell, this change would mean that flush() can optionally accept an entity as an argument. When that happens, the resulting changeset will be limited to that entity and any entity reachable from it.

The IRC transcript contains more details.

[DDC-659] Programmatic PHP ClassMetadata Builder

Sun, 4 Sep 2011 12:14:03 +0000

Currently using the two existing PHP Metadata Drivers you have a hard time writing the metadata against a plain ClassMetadata instance, because its already so optimiized in the datastruct. It would we cool if we had a class (Doctrine\ORM\Tools\ClassMetadataBuilder) which accepts a ClassMetadata instance in the constructor and has convenience methods to build up this instance.

This way you could use the PHPStatic Driver for example:

class MyEntity
{
  static public function loadClassMetadata(ClassMetadata $metadata)
  {
    $builder = new ClassMetadataBuilder($metadata);
    $builder->setTable('my_entity');
    // ...
  }
}

[DDC-638] Extend SqlWalker

Fri, 9 Dec 2011 05:17:49 +0000

I needed to extend SqlWalker for a custom output walker and all the vars are private instead of protected. Easy fix if it is intended to be extendable and I was supposed to be extending SqlWalker.

[DDC-609] Refactor ComparisonExpression grammar rule

Sat, 10 Dec 2011 22:41:24 +0000

ComparisonExpression has a lot of alternatives to choose from and it is simply difficult to make the decision without backtracking, only lookahead.

[DDC-551] Consider adding ability to specify additional join conditions on a @JoinTable / @JoinColumn

Duplicate — Thu, 22 Dec 2011 20:20:04 +0000

Per discussion with beberlei and romanb in #doctrine-dev yesterday, opening this ticket as a "feature request" to support migrating legacy schemas with a special many-to-many mapping to Doctrine.

Consider the following schema:

CREATE TABLE categories (
    category_id BIGINT UNSIGNED NOT NULL AUTO_INCREMENT,
    content_type ENUM('posts', 'videos'),
    /* ... */
    PRIMARY KEY (category_id)
) ENGINE=InnoDB;

CREATE TABLE content_category_association (
    content_id BIGINT UNSIGNED NOT NULL,
    category_id BIGINT UNSIGNED NOT NULL,
    content_type ENUM('posts', 'videos'),
    PRIMARY KEY (content_id, category_id, content_type),
    FOREIGN KEY (category_id, content_type) REFERENCES categories(category_id, content_type) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB;

CREATE TABLE posts (
    post_id BIGINT UNSIGNED NOT NULL AUTO_INCREMENT,
    /* ... */
    PRIMARY KEY (post_id)
) ENGINE=InnoDB;

CREATE TABLE videos (
    video_id BIGINT UNSIGNED NOT NULL AUTO_INCREMENT,
    /* ... */
) ENGINE=InnoDB;

There is a Many-To-Many relationship between each of the posts and videos table (via the content_category_association table) to the categories table. The difference from a standard many-to-many relationship is there is an extra column in the association table (content_type) which must be included in the join condition to return correct results. Since both the videos and posts table have their own autonumber primary keys, a join against the association table must include an extra condition (i.e. INNER JOIN ... ON ... AND content_category_association.content_type = 'posts').

Perhaps you could allow passing of additional properties to @JoinTable / joinColumns to specify the additional join condition .. i.e.:

/** @Entity */
class Video
{
  /**
   * @ManyToMany(targetEntity="Category")
   * @JoinTable(name="content_category_association",
   *      joinColumns={@JoinColumn(name="content_id", referencedColumnName="video_id")},
   *      inverseJoinColumns={@JoinColumn(name="category_id", referencedColumnName="video_id")},
   *      extraJoinTerms={@JoinTerm(content_type="video")}
   *      )
   */
  private $categories;

  // ...
}

/** @Entity */
class Category
{
    // ...
}

Certainly this schema is not ideal from a pure OO perspective. Class inheritance with a discriminator column may have been a better way to do this, thereby allowing a globally unique "content_id" for all types of content, negating the need for the extra column in the association table. However, it would nonetheless be helpful to have this additional capability within Doctrine to avoid having to re-factor such a legacy schema.

[DDC-509] Documentation for Implementing Event Listeners is incomplete

Tue, 11 Oct 2011 04:28:04 +0000

See: http://www.doctrine-project.org/documentation/manual/2_0/en/events#implementing-event-listeners

I created it as Major due to the following statement "you have to follow this restrictions very carefully since operations in the wrong event may produce lots of different errors, such as inconsistent data and lost updates/persists/removes."

s/this/these/ as well

[DDC-446] Cached resultset do not add Entities in UnitOfWork

Reference — Sun, 30 Oct 2011 13:21:37 +0000

When using resultset cache, when you fetch for these object and attempt to manipulate them, they fail to work giving this message:

Notice:  Undefined index: 000000006f95482300000000384dffac in /srv/app/library/Doctrine/ORM/UnitOfWork.php on line 1901

[DDC-408] accepting array of values per conditions rather than scalar only for find() and findBy() methods

Sun, 14 Aug 2011 00:28:20 +0000

Regarding this post:
http://groups.google.com/group/doctrine-user/browse_thread/thread/ab48be395099dec9

it would be interesting to be able to pass array of values per criteria.

For example:

// retrieve 'user' role : Already works with current implementation of ORM
$em->getRepository('Entities\Role')->findBy(array('name' => 'user'));

// retrieve 'user' and 'moderator' roles : Not implemented yet
$em->getRepository('Entities\Role')->findBy(array('name' => array('user', 'moderator')));

[DDC-217] Result cache should cache the SQL result and not the final objects

Duplicate — Mon, 19 Dec 2011 16:44:04 +0000

When fetching objects and using a result cache, it would probably be better to cache the SQL result array instead of the hydrated objects. That way, when grabbing from the cache managed entities can be returned. Also, caching is more efficient since an SQL result array does not need to be serialized/unserialized when storing in apc or memcached.

[DDC-209] Add the notion of read-only entities

Dependency — Sat, 15 Oct 2011 13:55:06 +0000

This may include:

a doctrine.readOnly query hint
a @ReadOnly annotation or xml/yaml descriptor element

Useful mainly for optimization purposes to tell doctrine to ignore such objects for any change tracking (except the initial creation/insert, of course).

[DDC-3] Support for CASE expressions in DQL

Dependency — Mon, 8 Aug 2011 05:08:05 +0000

CASE expressions should be supported in DQL similarly to the definition found in 4.6.17.3 of the JPA 2.0 specification.

Steps: 1) Adjust the BNF
2) Adjust the Parser according to the changed BNF
3) Adjust the SqlWalker? to produce the correct SQL