Doctrine Project

[DDC-1268] generate:entities creates bad method names with OneToMany

Tue, 4 Dec 2012 09:22:06 +0000

Hi. I noticed a minor bug in the generate:entities console task. I've got a Region entity that had the following property:

/**
 * @ORM\OneToMany(targetEntity="District", mappedBy="region")
 */
private $districts;

public function __construct()
{
    $this->districts = new ArrayCollection();
}

When I ran the generate:entities task it created the following methods:

/**
 * Add districts
 *
 * @param Fenix\StudyBundle\Entity\District $districts
 */
public function addDistricts(\Fenix\StudyBundle\Entity\District $districts)
{
    $this->districts[] = $districts;
}

/**
 * Get districts
 *
 * @return Doctrine\Common\Collections\Collection 
 */
public function getDistricts()
{
    return $this->districts;
}

The second method's name is correct, but what about addDistricts? Since it allows me to add a single District entity it should be as follows:

/**
 * Add district
 *
 * @param Fenix\StudyBundle\Entity\District $district
 */
public function addDistrict(\Fenix\StudyBundle\Entity\District $district)
{
    $this->districts[] = $district;
}

In other words, the term after "add" (as well as the parameter's name) should be the entity's name, not the property's one.

[DDC-1098] Cascading delete is broken for all relationships other than inheritance relationships, at least on MySQL 5.0

Tue, 27 Sep 2011 14:37:45 +0000

The console tools do not generate the proper DDL statements for the constraints declared as part of the relationship annotations.

Take this entity field declaration, e.g. :

     /**
  * @OneToMany(targetEntity="\persistentData\model\core\invoiceCreator\AnalogOrderInvoiceLineItem", mappedBy="partialInvoice", cascade={"persist", "remove", "detach"})
  */

 protected $analogOrderInvoiceLineItems;

This declaration should generate some sort of ON DELETE CASCADE constraint, or at least actually cascade the delete, in whatever way. It does not. I reviewed the generated DDL statements with

doctrine orm:schema-tool:create --dump-sql

And it clearly showed that no "ON DELETE CASCADE" was generated. Neither did Doctrine 2 perform a cascading delete otherwise.

The delete simply does not cascade.

Subsequently, I end up getting errors like:

Exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails
(`invoiceCreatorDB/AnalogOrderInvoiceLineItem`, CONSTRAINT `AnalogOrderInvoiceLineItem_ibfk_1` FOREIGN KEY (`partialInvoice_dbID`) REFERENCES `PartialInvoice` (`dbID`))'

The query that caused the error is:

DELETE FROM PartialInvoice where dbID = '2';

(PartialInvoice is the entity containing the above field declaration).

It seems that the cascading delete feature is fundamentally broken.

[DDC-1333] doctrine-mapping.xsd allows only one element

Sun, 21 Aug 2011 13:07:29 +0000

The metadata XSD at http://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd defines the <id> element on line 66 as <xs:element name="id" type="orm:id" minOccurs="0" maxOccurs="1" />. This allows for no more than one <id> element though the documentation at http://www.doctrine-project.org/docs/orm/2.1/en/reference/xml-mapping.html#defining-identity-and-generator-strategies states that more than one <id> element is allowed.

[DDC-1340] Missing argument 3 for OptimisticLockException::lockFailedVersionMissmatch()

Sun, 21 Aug 2011 13:04:27 +0000

UnitOfWork.php line 1409

throw OptimisticLockException::lockFailedVersionMissmatch($entityVersion, $managedCopyVersion);

OptimisticLockException.php line 54

public static function lockFailedVersionMissmatch($entity, $expectedLockVersion, $actualLockVersion)

No 3rd param in call or default in method declaration.

Warning: Missing argument 3 for Doctrine\ORM\OptimisticLockException::lockFailedVersionMissmatch(), called in /mnt/hgfs/Sites/library/Doctrine2/lib/Doctrine/ORM/UnitOfWork.php on line 1409 and defined in /mnt/hgfs/Sites/library/Doctrine2/lib/Doctrine/ORM/OptimisticLockException.php on line 54

[DDC-1021] Automatically infer type when DateTime is used as parameter in queries

Tue, 16 Aug 2011 05:35:10 +0000

Given $date instanceof \DateTime, instead of this:

$this->entityManager->createQuery(' ... p.date >= :pdate')
  ->setParameters(array('pdate' => $date), array('pdate' => 'datetime'))
  ->execute()

I would love to be able to use this:

$this->entityManager->createQuery(' ... p.date >= :pdate')
  ->execute(array('pdate' => $date))

Even when using setParameters() - which you need to do, e.g. when using getSingleResult(), it would be nice to be able to leave that out for DateTime instances - seems to be about the only thing that is not handled transparently.

[DDC-1300] Can't fetch entities from IdentityMap when using a foreign keys as identifiers

Sat, 6 Aug 2011 18:26:28 +0000

Given the follow SQL structure:

CREATE TABLE `foo` (
  `fooID` int(11) NOT NULL AUTO_INCREMENT,
  `fooReference` varchar(45) DEFAULT NULL,
  PRIMARY KEY (`fooID`)
) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8 COMMENT='module=bug';

CREATE TABLE `fooLocale` (
  `fooID` int(11) NOT NULL,
  `locale` varchar(5) NOT NULL DEFAULT '',
  `title` varchar(150) DEFAULT NULL,
  PRIMARY KEY (`fooID`,`locale`),
  KEY `fk_foo2` (`fooID`),
  CONSTRAINT `fk_table1_foo2` FOREIGN KEY (`fooID`) REFERENCES `foo` (`fooID`) ON DELETE CASCADE ON UPDATE NO ACTION
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COMMENT='module=bug';

INSERT INTO `foo` (`fooID`, `fooReference`)
VALUES
	(1, 'foo1');

INSERT INTO `fooLocale` (`fooID`, `locale`, `title`)
VALUES
	(1, 'en_GB', 'Foo title test');

and the following models:

use Doctrine\ORM\Mapping as ORM;

/**
 * Model for foo
 *
 * @category Application
 * @package Bug
 * @subpackage Model
 * @ORM\Table(name="foo")
 * @ORM\Entity
 */
class Bug_Model_Foo
{
	/**
	 * @var integer fooID
	 * @ORM\Column(name="fooID", type="integer", nullable=false)
	 * @ORM\GeneratedValue(strategy="IDENTITY")
	 * @ORM\Id
	 */
	protected $_fooID = null;

	/**
	 * @var string fooReference
	 * @ORM\Column(name="fooReference", type="string", nullable=true, length=45)
	 */
	protected $_fooReference = null;

	/**
	 * @ORM\OneToMany(targetEntity="Bug_Model_FooLocale", mappedBy="_foo",
	 * cascade={"persist"})
	 */
	protected $_fooLocaleRefFoo = null;

	/**
	 * Constructor
	 *
	 * @param array|Zend_Config|null $options
	 * @return Bug_Model_Foo
	 */
	public function __construct($options = null)
	{
		$this->_fooLocaleRefFoo = new \Doctrine\Common\Collections\ArrayCollection();
	}

}

use Doctrine\ORM\Mapping as ORM;

/**
 * Model for fooLocale
 *
 * @category Application
 * @package Bug
 * @subpackage Model
 * @ORM\Table(name="fooLocale")
 * @ORM\Entity
 */
class Bug_Model_FooLocale
{
	/**
	 * @ORM\ManyToOne(targetEntity="Bug_Model_Foo")
	 * @ORM\JoinColumn(name="fooID", referencedColumnName="fooID")
	 * @ORM\Id
	 */
	protected $_foo = null;

	/**
	 * @var string locale
	 * @ORM\Column(name="locale", type="string", nullable=false, length=5)
	 * @ORM\Id
	 */
	protected $_locale = null;

	/**
	 * @var string title
	 * @ORM\Column(name="title", type="string", nullable=true, length=150)
	 */
	protected $_title = null;

}

Execute the following DQL 2 times:

$query = $entityManager->createQuery('
			SELECT 
				f, fl 
			FROM 
				Bug_Model_Foo f 
			JOIN 
				f._fooLocaleRefFoo fl');
		return $query->getResult();

The first time, you won't have any issues.
The second time, when the data will be fetched from the identityMap, you won't find it because there is something wrong with the identities and you will get the following warning

( ! ) Notice: Undefined index: _foo in /var/www/vhost/core/htdocs/externals/Doctrine/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php on line 217
Call Stack
#	Time	Memory	Function	Location
1	0.0002	337752	{main}( )	../index.php:0
2	0.0848	7268724	Zend_Application->run( )	../index.php:26
3	0.0848	7268724	Zend_Application_Bootstrap_Bootstrap->run( )	../Application.php:366
4	0.0850	7268796	Zend_Controller_Front->dispatch( )	../Bootstrap.php:97
5	0.0908	7900416	Zend_Controller_Dispatcher_Standard->dispatch( )	../Front.php:954
6	0.0967	8209564	Zend_Controller_Action->dispatch( )	../Standard.php:295
7	0.0967	8213912	Bug_IndexController->indexAction( )	../Action.php:513
8	0.1936	11391900	Bug_Service_Bug->getFooLocaleList( )	../IndexController.php:35
9	0.1936	11394088	Doctrine\ORM\AbstractQuery->getResult( )	../Bug.php:41
10	0.1936	11394296	Doctrine\ORM\AbstractQuery->execute( )	../AbstractQuery.php:392
11	0.1945	11397960	Doctrine\ORM\Internal\Hydration\AbstractHydrator->hydrateAll( )	../AbstractQuery.php:594
12	0.1946	11398656	Doctrine\ORM\Internal\Hydration\ObjectHydrator->_hydrateAll( )	../AbstractHydrator.php:99
13	0.1946	11399876	Doctrine\ORM\Internal\Hydration\ObjectHydrator->_hydrateRow( )	../ObjectHydrator.php:140
14	0.1949	11405584	Doctrine\ORM\Internal\Hydration\ObjectHydrator->_getEntityFromIdentityMap( )	../ObjectHydrator.php:326

With the invalid key, it is not possible to get the entity from the identityMap.

[DDC-1313] DriverChain::getAllClassNames() is very inefficient in some scenarios

Mon, 1 Aug 2011 19:47:04 +0000

In Symfony a driver gets registered multiple times. This leads to getAllClassNames() to be invoked multiple times on the same driver.

[DDC-1282] getDateAddDaysExpression() casts $days to integer preventing column based add expressions.

Sun, 31 Jul 2011 10:06:24 +0000

Take the following:

$qb = $this->createQueryBuilder('a');
$qb->select('partial a.

{dsid,rid,activeStartDate}');
$qb->leftJoin('a.clinic', 'c');
$qb->leftJoin('a.patient', 'p');
$qb->where('c.autoAppointmentReminders = 1');
$qb->andWhere('a.enabled = 1');
$qb->andWhere(
$qb->expr()->eq(
'a.activeStartDate',
"DATE_ADD(CURRENT_DATE(), c.appointmentRemindersDaysInAdvance, 'day')"));

Which generates the DQL: SELECT partial a.{dsid,rid,activeStartDate}

FROM VetLogic\Entity\Appointment a LEFT JOIN a.clinic c LEFT JOIN a.patient p WHERE c.autoAppointmentReminders = 1 AND a.enabled = 1 AND a.activeStartDate = DATE_ADD(CURRENT_DATE(), c.appointmentRemindersDaysInAdvance, 'day')

And SQL: SELECT a0_.rid AS rid0, a0_.dsid AS dsid1, a0_.activeStartDate AS activeStartDate2, a0_.dsid AS dsid3, a0_.dsid AS dsid4, a0_.clinicRid AS clinicRid5, a0_.dsid AS dsid6, a0_.patientRid AS patientRid7, a0_.dsid AS dsid8, a0_.rid AS rid9 FROM appointment a0_ LEFT JOIN clinic c1_ ON a0_.dsid = c1_.dsid AND a0_.clinicRid = c1_.rid LEFT JOIN patient p2_ ON a0_.dsid = p2_.dsid AND a0_.patientRid = p2_.rid WHERE c1_.autoAppointmentReminders = 1 AND a0_.enabled = 1 AND a0_.activeStartDate = DATE_ADD(CURRENT_DATE, INTERVAL0 DAY)

The DATE_ADD(CURRENT_DATE, INTERVAL0 DAY) is generated incorrectly because getDateAddDaysExpression($date, $days) casts $days to an integer.

The fix is simply to remove (int) from return 'DATE_ADD(' . $date . ', INTERVAL ' . (int)$days . ' DAY)';

Note: I only checked the MySQL platform so I'm not sure if other platforms are affected.

[DDC-1302] orphan-removal does not work in XML

Sun, 31 Jul 2011 09:38:52 +0000

The check for $oneToManyElement->

{'orphan-removal'}

returns false, the right check would be $oneToManyElement['orphan-removal']

[DDC-1301] EXTRA_LAZY collection count throws exception on OneToMany association

Thu, 28 Jul 2011 21:28:11 +0000

Calling count() on an EXTRA_LAZY collection throws an exception.

Notice: Undefined index: iUserId in /../vendor/doctrine/lib/Doctrine/ORM/Persisters/OneToManyPersister.php line 142

I've found that this is caused by looking up the fieldName for iUserId on the targetEntity, while it should be looked up at the sourceEntity. The current tests pass because all entities have a mapping of `id' -> $id.

Tests + fix coming up.

[DDC-1275] ResultSetMappingBuilder does not set foreign keys

Thu, 28 Jul 2011 21:25:06 +0000

The ResultSetMappingBuilder has a fatal flaw: Its not setting foreign keys as of right now.

[DDC-1298] SqlWalker->walkSelectClause imploding empty strings results in invalid query

Thu, 28 Jul 2011 18:36:51 +0000

Given the following MySQL structure

CREATE TABLE `bar` (
  `barID` int(11) NOT NULL AUTO_INCREMENT,
  `barReference` varchar(45) DEFAULT NULL,
  PRIMARY KEY (`barID`)
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8 COMMENT='module=bug';

CREATE TABLE `foo` (
  `fooID` int(11) NOT NULL AUTO_INCREMENT,
  `fooReference` varchar(45) DEFAULT NULL,
  PRIMARY KEY (`fooID`)
) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8 COMMENT='module=bug';

CREATE TABLE `fooBar` (
  `fooID` int(11) NOT NULL,
  `barID` int(11) NOT NULL,
  PRIMARY KEY (`fooID`,`barID`),
  KEY `fk_foo1` (`fooID`),
  KEY `fk_bar1` (`barID`),
  CONSTRAINT `fk_table1_foo1` FOREIGN KEY (`fooID`) REFERENCES `foo` (`fooID`) ON DELETE CASCADE ON UPDATE NO ACTION,
  CONSTRAINT `fk_table1_bar1` FOREIGN KEY (`barID`) REFERENCES `bar` (`barID`) ON DELETE CASCADE ON UPDATE NO ACTION
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COMMENT='module=bug';

INSERT INTO `bar` (`barID`, `barReference`)
VALUES
	(1, 'bar1'),
	(2, 'bar2');

INSERT INTO `foo` (`fooID`, `fooReference`)
VALUES
	(1, 'foo1');

INSERT INTO `fooBar` (`fooID`, `barID`)
VALUES
	(1, 1);

the following models:

use Doctrine\ORM\Mapping as ORM;

/**
 * Model for foo
 *
 * @category Application
 * @package Bug
 * @subpackage Model
 * @ORM\Table(name="foo")
 * @ORM\Entity
 */
class Bug_Model_Foo
{
	/**
	 * @var integer fooID
	 * @ORM\Column(name="fooID", type="integer", nullable=false)
	 * @ORM\GeneratedValue(strategy="IDENTITY")
	 * @ORM\Id
	 */
	protected $_fooID = null;

	/**
	 * @var string fooReference
	 * @ORM\Column(name="fooReference", type="string", nullable=true, length=45)
	 */
	protected $_fooReference = null;

	/**
	 * @ORM\OneToMany(targetEntity="Bug_Model_FooBar", mappedBy="_foo",
	 * cascade={"persist"})
	 */
	protected $_fooBarRefFoo = null;

	/**
	 * Constructor
	 *
	 * @param array|Zend_Config|null $options
	 * @return Bug_Model_Foo
	 */
	public function __construct($options = null)
	{
		$this->_fooBarRefFoo = new \Doctrine\Common\Collections\ArrayCollection();
		parent::__construct($options);
	}

}

use Doctrine\ORM\Mapping as ORM;

/**
 * Model for bar
 *
 * @category Application
 * @package Bug
 * @subpackage Model
 * @ORM\Table(name="bar")
 * @ORM\Entity
 */
class Bug_Model_Bar
{
	/**
	 * @var integer barID
	 * @ORM\Column(name="barID", type="integer", nullable=false)
	 * @ORM\GeneratedValue(strategy="IDENTITY")
	 * @ORM\Id
	 */
	protected $_barID = null;

	/**
	 * @var string barReference
	 * @ORM\Column(name="barReference", type="string", nullable=true, length=45)
	 */
	protected $_barReference = null;

	/**
	 * @ORM\OneToMany(targetEntity="Bug_Model_FooBar", mappedBy="_bar",
	 * cascade={"persist"})
	 */
	protected $_fooBarRefBar = null;

	/**
	 * Constructor
	 *
	 * @param array|Zend_Config|null $options
	 * @return Bug_Model_Bar
	 */
	public function __construct($options = null)
	{
		$this->_fooBarRefBar = new \Doctrine\Common\Collections\ArrayCollection();
		parent::__construct($options);
	}
}

use Doctrine\ORM\Mapping as ORM;

/**
 * Model for fooBar
 *
 * @category Application
 * @package Bug
 * @subpackage Model
 * @ORM\Table(name="fooBar")
 * @ORM\Entity
 */
class Bug_Model_FooBar
{
	/**
	 * @ORM\ManyToOne(targetEntity="Bug_Model_Foo")
	 * @ORM\JoinColumn(name="fooID", referencedColumnName="fooID")
	 * @ORM\Id
	 */
	protected $_foo = null;

	/**
	 * @ORM\ManyToOne(targetEntity="Bug_Model_Bar")
	 * @ORM\JoinColumn(name="barID", referencedColumnName="barID")
	 * @ORM\Id
	 */
	protected $_bar = null;

}

and using the following DQL:

SELECT 
	f, b, fb 
FROM 
	Bug_Model_Foo f 
JOIN 
	f._fooBarRefFoo fb
JOIN
	fb._bar b

will result in the following sql query:

SELECT f0_.fooID AS fooID0, f0_.fooReference AS fooReference1, , b1_.barID AS barID2, b1_.barReference AS barReference3, f2_.fooID AS fooID4, f2_.barID AS barID5 FROM foo f0_ INNER JOIN fooBar f2_ ON f0_.fooID = f2_.fooID INNER JOIN bar b1_ ON f2_.barID = b1_.barID

there are 2 comma's between "f0_.fooReference AS fooReference1" and "b1_.barID AS barID2" resulting in an invalid query.

The first line of the walkSelectClause function in Doctrine/ORM/Query/SqlWalker.php will implode the result of the array_map.
But you receive an empty result from processing the data for the selectExpression "fb" explaining why you got the extra comma.

This worked in a previous version when 2.1 was still in development.

[DDC-1215] doctrine:generate:entities creates entities incorrect visibility of properties for subclasses

Tue, 26 Jul 2011 21:01:25 +0000

I've created a symfony bundle with an entity that I want to use as a base across mutiple other entities:

/**
* @orm\Entity
* @orm\HasLifecycleCallbacks()
*/
class Base
{
/**
* @orm\Id
* @orm\Column(type="integer")
* @orm\GeneratedValue(strategy="AUTO")
*/
protected $id;
/**
* @orm\Column(type="string", unique="true", length="150")
*/
protected $name;
/**
* @orm\Column(type="string", unique="true", length="150")
*/
protected $username;
...
}

I have another entity in another bundle that extends this:

class Extended extends \Test\Entity\Base

When I run doctrine:generate:entites it incorrectly generates the extended class - it sets all inherited properties as 'private' which then causes PHP to raise an exception because properties on an extended class have more restrictive visibility than from the base class.

It probably shouldn't be auto-generating the properties in the extended class at all, or generating getters/setters since that then overrides my base implementation by default.

[DDC-1280] Generated proxy classes have mixed line endings on Windows

Tue, 26 Jul 2011 20:34:19 +0000

When Doctrine\ORM\Proxy\ProxyFactory generates proxy classes on Windows, it mixes LF an CR/LF line endings. This is causing VCS issues in our mixed Windows/Linux dev team (we keep the proxies under version control for deployment purposes).

This seems to be a regression. It did not happen with Doctrine 2.0.x.

It is caused by the template string in the static property $_proxyClassTemplate using LF, while the string concatenations in the methods use the PHP_EOL constant, which resolves to CR/LF on Windows.

Other code generators like Doctrine\ORM\Tools\EntityGenerator use "\n" instead of PHP_EOL.

I propose to always use "\n" in favour of PHP_EOL. It's easier to implement in this case and every editor/IDE on Windows can handle Unix line endings nowadays.

[DDC-1276] Merging persistent collections broken if managed and merged collection are the same object

Tue, 26 Jul 2011 20:19:35 +0000

When FLOW3 maps request arguments to entities, it works on clones of the changed entities while entities, which are not affected by the request arguments stay the original objects. If the entity has a persistent collection which is not changed and therefore not cloned, the call to $repository->update() (which internally calls $em->merge()) eventually clears the $managedCol in $uow->doMerge() (line 1460 in current master), but if the $mergeCol is the same object, this is obviously wrong behavior as no related entities exist anymore in the entity to merge.

Made up example code (not sure if this simple example works as I have no test setup I could use for it)

/**
 * @entity
 * @scope prototype
 */
class A {}

/**
 * @entity
 * @scope prototype
 */
class B {
    /**
     * @var \Doctrine\Common\Collection\ArrayCollection<A>
     * @ManyToMany
     */
    public $relation;
}

$b = $repository->find(); // assume $b has some A in relation
$anotherB = clone $b;
$em->merge($anotherB);

After this relation of $b is empty

[DDC-1254] EntityGenerator does not respect Class Inheritance properly

Dependency — Thu, 14 Jul 2011 16:31:34 +0000

Hi,
as mentioned here ~~DDC-904~~, https://github.com/symfony/symfony/issues/1550# and https://github.com/stof/StofDoctrineExtensionsBundle/issues/47
The Doctrine2 EntityGenerator does not respect inheritance of Models correctly, especially when inheriting the primary field from an abstract base class as done by Symfony2's StofDoctrineExtensionsBundle.

This is extremly annoying since it renders the generator unusable when aforementioned bundle is active. It always fails with this message:

[Doctrine\ORM\Mapping\MappingException]

No identifier/primary key specified for Entity 'Stof\DoctrineExtensionsBundle\Entity\Translation'. Every Entity must have an
identifier/primary key.

~~DDC-904~~ mentioned this should be fixed, but this is not true: bug is still found in latest Symfony2 git.
The docs only refer to using a single mapping format inside a bundle, but this does not work. Stof... uses xml mappings and it does not matter if i use yml or annotiations in a different bundle - the above error is still present.

[DDC-1244] [regression] Entities generator fails to update entities without any namespace, always append the generated definitions to the end of the class

Tue, 12 Jul 2011 21:50:20 +0000

If Entities have no namespace set (e.g. custom AutoLoader) schema tool fails to find the original methods and properties and always append the definitions to the end of the file, which leads to duplications of class definitions.

This is because in \Doctrine\ORM\Tools\EntitiesGenerator.php at line 441:

441: $lastSeenClass = $lastSeenNamespace . '\\' . $token[1];

$lastSeenClass is always prefixed with "\" when checking for existing definitions

it could be fixed as:

441: $lastSeenClass =  $lastSeenNamespace. ($lastSeenNamespace ? '\\' : '') . $token[1];

I had an environment where the classes without any specified namespace are autoloaded from Entities directory, which makes generate-entities fail to work properly since Doctrine 2.0.4

[DDC-1243] Problem to generate code for subclasses without identifiers.

Dependency — Tue, 12 Jul 2011 21:47:50 +0000

When using inheritance with identifier in the superclass, results in an error trying to generate code.

Example:

/**
 * Demo\TestInheritanceBundle\Entity\TestBase
 *
 * @ORM\Table()
 * @ORM\Entity
 * @ORM\InheritanceType("JOINED")
 * @ORM\DiscriminatorColumn(name="discr", type="string")
 * @ORM\DiscriminatorMap({"test" = "Test"})
 */
class TestBase
{
    /**
     * @var integer $id
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;
}

class Test
{
}

will throw an exception because the DisconnectedClassMetadataFactory disables the code that examines the parent classes.
I've created a simple function that can be used to figure out if a parent has defined an identifier that can be used by the subclass.

Patch attached.

[DDC-1240] Missing exception message

Tue, 12 Jul 2011 21:02:04 +0000

Message in constructor should be assigned to exception message

Index: OptimisticLockException.php
===================================================================
— OptimisticLockException.php (revision 5)
+++ OptimisticLockException.php (working copy)
@@ -33,6 +33,7 @@

public function __construct($msg, $entity)

{ + $this->message = $msg; $this->entity = $entity; }

[DDC-1250] Ambiguous column in query using one-to-one self-referencing bidirectional association

Sat, 9 Jul 2011 20:14:19 +0000

This example worked fine with 2.0.6. I suppose it is related to:
"Furthermore inverse OneToOne associations previously always executed an additional query, which is now replaced with a join."

When I try to get object using EntityRepository I receive following error:
Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'declined_clients_history_id' in where clause is ambiguous' in /usr/share/php/Doctrine/DBAL/Connection.php:613
Stack trace:
#0 /usr/share/php/Doctrine/DBAL/Connection.php(613): PDOStatement->execute()
#1 /usr/share/php/Doctrine/ORM/Persisters/BasicEntityPersister.php(569): Doctrine\DBAL\Connection->executeQuery('SELECT t0.id AS...', Array, Array)
#2 /usr/share/php/Doctrine/ORM/Persisters/BasicEntityPersister.php(644): Doctrine\ORM\Persisters\BasicEntityPersister->load(Array, NULL, Array)
#3 /usr/share/php/Doctrine/ORM/UnitOfWork.php(2015): Doctrine\ORM\Persisters\BasicEntityPersister->loadOneToOneEntity(Array, Object(Entities\ClientsHistory), NULL)
#4 /usr/share/php/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php(208): Doctrine\ORM\UnitOfWork->createEntity('Entities\Client...', Array, Array)
#5 /usr/share/php/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php(398): Doctrine\ORM\Internal\Hydration\Ob in /usr/share/php/Doctrine/DBAL/Connection.php</b> on line 613

Entity YAML:

Entities\ClientsHistory:
type: entity
table: clients_history
fields:
id:
id: true
type: integer
unsigned: false
nullable: false
generator:
strategy: IDENTITY
[...skiped...]
oneToOne:
declinedClientsHistory:
targetEntity: Entities\ClientsHistory
joinColumn:
name: declined_clients_history_id
referencedColumnName: id
inversedBy: declinedBy
declinedBy:
targetEntity: Entities\ClientsHistory
mappedBy: declinedClientsHistory
lifecycleCallbacks: { }
repositoryClass: Entities\ClientsHistoryRepository

Query which lead to error:
SELECT t0.id AS id1, t0.odate AS odate2, t0.oper AS oper3, t0.type AS type4, t0.transaction_sum AS transaction_sum5, t0.sum AS sum6, t0.balance AS balance7, t0.descr AS descr8, t0.admin AS admin9, t0.payment_id AS payment_id10, t0.balance_operation_id AS balance_operation_id11, t0.payment_id AS payment_id12, t0.declined_clients_history_id AS declined_clients_history_id13, t14.id AS id15, t14.odate AS odate16, t14.oper AS oper17, t14.type AS type18, t14.transaction_sum AS transaction_sum19, t14.sum AS sum20, t14.balance AS balance21, t14.descr AS descr22, t14.admin AS admin23, t14.payment_id AS payment_id24, t14.balance_operation_id AS balance_operation_id25, t14.payment_id AS payment_id26, t14.declined_clients_history_id AS declined_clients_history_id27, t14.id_clients AS id_clients28, t14.id_domains AS id_domains29, t0.id_clients AS id_clients30, t0.id_domains AS id_domains31 FROM clients_history t0 LEFT JOIN clients_history t14 ON t14.declined_clients_history_id = t0.id WHERE declined_clients_history_id = ?

[DDC-1257] Duplicate PHP methods generated from XML metadata lifecycle-callbacks

Sat, 9 Jul 2011 13:16:54 +0000

If lifecycle callbacks are added to XML metadata like so:

	<lifecycle-callbacks>
		<lifecycle-callback type="prePersist" method="validate" />
		<lifecycle-callback type="preUpdate" method="validate" />
	</lifecycle-callbacks>

The validate() method will appear twice in an entity generated from this metadata.

[DDC-1251] EntityGenerator uses non-existing constant T_AMPERSAND

Sat, 9 Jul 2011 12:57:33 +0000

As per http://www.php.net/manual/en/tokens.php - the T_AMPERSAND token does not exist. I'm not sure what was the intent, but the entity generator fails on the following code:

            $elems = array_map(function($el) {
                return $el;
            }, $elems);

Due to the way notices are handled in Symfony, this basically stops the execution of the generator entirely. Not so great.

  [ErrorException]                                                                                            
  Notice: Use of undefined constant T_AMPERSAND - assumed 'T_AMPERSAND' in ./vendor/doctrine/lib/Doctrine/ORM/Tools/EntityGenerator.php line 454

Commenting out the offending line makes it work fine though, so I think it's just choking while expecting a function that takes args by reference or something.

[DDC-1022] Wakeup behavior difference between proxy and eager-loaded instance

Sat, 9 Jul 2011 12:39:36 +0000

When an object is reconstituted from the persistent storage the unserialize trick is used. That means __wakeup() is called, which is useful to do further initialization as needed.

If the object is lazy loaded a proxy is generated. That proxy is generated with new and thus no _wakeup() is called. When the proxy is eventually initialized still no call to _wakeup() is done, thus initialization code that is "usually" executed is not called when an object is lazy-loaded.

That is a semantical error.