Doctrine Project

[DDC-1195] The orm:convert-mapping is not configurable enough for Symfony2

Tue, 16 Aug 2011 05:43:59 +0000

see https://github.com/symfony/symfony/issues/1119

fix here https://github.com/doctrine/doctrine2/pull/66

[DDC-1302] orphan-removal does not work in XML

Sun, 31 Jul 2011 09:38:52 +0000

The check for $oneToManyElement->

{'orphan-removal'}

returns false, the right check would be $oneToManyElement['orphan-removal']

[DDC-1276] Merging persistent collections broken if managed and merged collection are the same object

Tue, 26 Jul 2011 20:19:35 +0000

When FLOW3 maps request arguments to entities, it works on clones of the changed entities while entities, which are not affected by the request arguments stay the original objects. If the entity has a persistent collection which is not changed and therefore not cloned, the call to $repository->update() (which internally calls $em->merge()) eventually clears the $managedCol in $uow->doMerge() (line 1460 in current master), but if the $mergeCol is the same object, this is obviously wrong behavior as no related entities exist anymore in the entity to merge.

Made up example code (not sure if this simple example works as I have no test setup I could use for it)

/**
 * @entity
 * @scope prototype
 */
class A {}

/**
 * @entity
 * @scope prototype
 */
class B {
    /**
     * @var \Doctrine\Common\Collection\ArrayCollection<A>
     * @ManyToMany
     */
    public $relation;
}

$b = $repository->find(); // assume $b has some A in relation
$anotherB = clone $b;
$em->merge($anotherB);

After this relation of $b is empty

[DDC-1240] Missing exception message

Tue, 12 Jul 2011 21:02:04 +0000

Message in constructor should be assigned to exception message

Index: OptimisticLockException.php
===================================================================
— OptimisticLockException.php (revision 5)
+++ OptimisticLockException.php (working copy)
@@ -33,6 +33,7 @@

public function __construct($msg, $entity)

{ + $this->message = $msg; $this->entity = $entity; }

[DDC-1257] Duplicate PHP methods generated from XML metadata lifecycle-callbacks

Sat, 9 Jul 2011 13:16:54 +0000

If lifecycle callbacks are added to XML metadata like so:

	<lifecycle-callbacks>
		<lifecycle-callback type="prePersist" method="validate" />
		<lifecycle-callback type="preUpdate" method="validate" />
	</lifecycle-callbacks>

The validate() method will appear twice in an entity generated from this metadata.

[DDC-1251] EntityGenerator uses non-existing constant T_AMPERSAND

Sat, 9 Jul 2011 12:57:33 +0000

As per http://www.php.net/manual/en/tokens.php - the T_AMPERSAND token does not exist. I'm not sure what was the intent, but the entity generator fails on the following code:

            $elems = array_map(function($el) {
                return $el;
            }, $elems);

Due to the way notices are handled in Symfony, this basically stops the execution of the generator entirely. Not so great.

  [ErrorException]                                                                                            
  Notice: Use of undefined constant T_AMPERSAND - assumed 'T_AMPERSAND' in ./vendor/doctrine/lib/Doctrine/ORM/Tools/EntityGenerator.php line 454

Commenting out the offending line makes it work fine though, so I think it's just choking while expecting a function that takes args by reference or something.

[DDC-1022] Wakeup behavior difference between proxy and eager-loaded instance

Sat, 9 Jul 2011 12:39:36 +0000

When an object is reconstituted from the persistent storage the unserialize trick is used. That means __wakeup() is called, which is useful to do further initialization as needed.

If the object is lazy loaded a proxy is generated. That proxy is generated with new and thus no _wakeup() is called. When the proxy is eventually initialized still no call to _wakeup() is done, thus initialization code that is "usually" executed is not called when an object is lazy-loaded.

That is a semantical error.

[DDC-1230] entity state is not set to STATE_REMOVED when removing an entity

Tue, 28 Jun 2011 19:39:28 +0000

The UnitOfWork never sets the state to STATE_REMOVED in the map when scheduling an entity for delete. This means that the UnitOfWork will never tell you that the entity is in STATE_REMOVED when asking for its state but will return STATE_MANAGED

[DDC-1224] QueryBuilder delete issues CREATE TEMPORARY TABLE error on PostgreSQL

Sun, 26 Jun 2011 08:13:31 +0000

When I try to issue a delete an Class Table Inheritance Entity using QueryBuilder and I'm using schemas on tablename (for Postgres), I got the following error from postgres:

SQLSTATE[42P16]: Invalid table definition: 7 ERROR: temporary tables cannot specify a schema name

This occurs because Doctrine\ORM\Mapping\ClassMetadataInfo::getTemporaryIdTableName() returns just "$this->table['name'] . '_id_tmp'", and when my entity is declared with @Table(name="feed.tb_feed"), obviously I will got error.

Temporary tables are created in a special schema in Postgres, and I'm thinking to convert the tablename from the class metadata from feed.tb_feed to feed_tb_feed into the getTemporaryIdTableName method with a single str_replace. That works for Postgres, but I don't mind what can happen in another DBMS.

Any suggestions?

[DDC-1211] Expr::literal problem with numeric value 0

Sun, 19 Jun 2011 08:27:51 +0000

Hi,

I'm using master branch of Doctrine 2. Including an Expr with a numeric 0 value (not a string):

$value = 0;

$qb->expr()->gte($field, $qb->expr()->literal($value));

Expr::literal method will return an empty string ('') instead of '0', which causes that this expression be something like:

entity.myField >=

instead of:

entity.miField >= '0''

This makes the query fail. Tracking the issue down I've found this on Expr\Base::add method:

    public function add($arg)
    {
         if ( ! empty($arg) || ($arg instanceof self && $arg->count() > 0)) {
            // If we decide to keep Expr\Base instances, we can use this check
            if ( ! is_string($arg)) {
                $class = get_class($arg);

                if ( ! in_array($class, $this->_allowedClasses)) {
                    throw new \InvalidArgumentException("Expression of type '$class' not allowed in this context.");
                }
            }

            $this->_parts[] = $arg;
        }
    }

The problem is that empty function returns true if you pass '0', so a call to Expr\Base::add would end on NOT adding '0' to $this->_parts array. That's why it finally returns ''.

I wanted to make the fix for this but I'm having issues running the phing build task. Which are the steps to follow to run the tests? Running phing build task I get on the "test" task:

Could not create task/type: 'nativephpunit'. Make sure that this class has been declared using taskdef / typedef.

Thanks!

[DDC-849] PersistentCollection::clear() doesn't clear the collection

Duplicate — Sun, 19 Jun 2011 08:09:17 +0000

Clearing ManyToMany association doesn't work. I needed to clear the roles of the user (after form submit) and then add the checked roles. Also counting them doesn't work properly.

See the clearRoles method in the attachment.

//EDIT: Don't know if it's important but the association is bidirectional.

[DDC-1189] PersistentCollection::clear() does not cause the collection to be initialized

Duplicate — Sun, 19 Jun 2011 08:09:03 +0000

If clear() is called on an uninitialized PersistentCollection it needs to set the collection to be initialized.

An example of where this can cause problems:

Call clear() on an uninitialized collection
Check if an entity is in that collection using contains($entity)

This can return a false positive if the entity was previously in the collection.