Doctrine Project

[DDC-1136] Prevent backup files to be recognized as valid Entity files

Sat, 14 May 2011 09:59:31 +0000

The Doctrine2 generator backup Entity files when it adds code into them. The files are named after the original file with a ~ prepended.

The problem is that these backup files are valid PHP files, and as such, they are loaded by Doctrine2. A PHP fatal error is then fired: "Cannot redeclare class...".

Instead of prepending _{, why not appending ~, which is a well supported convention? (foo.php} vs ~foo.php)

Patch is here: https://github.com/doctrine/doctrine2/pull/35

[DDC-1151] Table name at reference is not quoted, even if table name in entity has quotation marks.

Sat, 14 May 2011 06:50:47 +0000

Reference for PostgreSQL and MySQL is folloing:

ALTER TABLE "user_group" ADD FOREIGN KEY (user_id) REFERENCES user(id) NOT DEFERRABLE INITIALLY IMMEDIATE;
ALTER TABLE "user_group" ADD FOREIGN KEY (group_id) REFERENCES group(id) NOT DEFERRABLE INITIALLY IMMEDIATE

Entity is quoted:

/**
 * @Entity @Table(name="`user`")
 */

[DDC-1090] API Documentation for Doctrine\DBAL\Logging\SQLLogger::startQuery() is Incorrect

Fri, 13 May 2011 02:57:56 +0000

This page displays contradicting information about the startQuery() interface method: http://www.doctrine-project.org/api/dbal/2.0/doctrine/dbal/logging/sqllogger.html

The $types argument is documented as $executionMS, which is not even in the method declaration.

[DDC-994] YAML parser seems out of date (and references an undefined variable

Sun, 1 May 2011 06:40:12 +0000

line: 158
$merged = array_merge($merge, $parsed);

but $merge is no where defined

when i compared it against current Symfony2 the file seemed quite a bit different.

[DDC-1119] CLONE -Call to undefined method Doctrine\DBAL\Platforms\MySqlPlatform::quote()

Sun, 1 May 2011 06:00:29 +0000

Fatal error: Call to undefined method Doctrine\DBAL\Platforms\MySqlPlatform::quote() in /srv/abf/trunk/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php on line 1181

I think you should use quoteIdentifier instead of quote

[DDC-1129] UnitOfWork consider version field changed as entity changed

Sun, 1 May 2011 05:46:44 +0000

I use @version field and after first save it thinks that versionField was changed.

$Entity = $em->find(...);
$Entity->changeField();
$em->persist($Entity);
$em->flush();
$em->getUnitOfWork()->computeChangeSets();
var_dump($em->getUnitOfWork()->getEntityChangeSet($Entity);

array(1) {
  ["version"]=>
  array(2) {
    [0]=>
    int(183)
    [1]=>
    int(184)
  }
}

I fixed it in method computeChangeSet on lines around 473:

Index: ../vendor/doctrine/lib/Doctrine/ORM/UnitOfWork.php
===================================================================
@@ -448,6 +448,9 @@
             $changeSet = $isChangeTrackingNotify ? $this->entityChangeSets[$oid] : array();
 
             foreach ($actualData as $propName => $actualValue) {
+                if ($class->isVersioned && $propName == $class->versionField) {
+                    continue;
+                }
                 $orgValue = isset($originalData[$propName]) ? $originalData[$propName] : null;
                 if (isset($class->associationMappings[$propName])) {
                     $assoc = $class->associationMappings[$propName];

[DDC-1091] Parser::FunctionsReturningStrings() doesn't check for custom DQL functions.

Sun, 1 May 2011 05:02:40 +0000

I defined a custom DQL FunctionNode that wasn't detected by the Parser.
Problem was in the Parser::FunctionsReturningStrings(), but I suspect the problem is more general.

Here's my (ugly) fix:

public function FunctionsReturningStrings()
{
$funcNameLower = strtolower($this->_lexer->lookahead['value']);
if (isset(self::$_STRING_FUNCTIONS[$funcNameLower]))

{ $funcClass = self::$_STRING_FUNCTIONS[$funcNameLower]; $function = new $funcClass($funcNameLower); $function->parse($this); }

else $function = $this->CustomFunctionsReturningStrings();

return $function;
}

I include the custom DQL FunctionNode created.

[DDC-1111] EntityGenerator duplicates attributes, getters and setters in mapped subclasses

Sun, 1 May 2011 04:09:30 +0000

when I want to generate getters and setters for my entity which subclasses another entity-base-class, my properties are duplicated.

before generating:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

/**
 * @orm:Entity
 */
class User extends BaseUser
{
    /**
     * @orm:Id
     * @orm:Column(type="integer")
     * @orm:generatedValue(strategy="AUTO")
     */
    protected $id;
}

after generating:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

/**
 * @orm:Entity
 */
class User extends BaseUser
{
    /**
     * @orm:Id
     * @orm:Column(type="integer")
     * @orm:generatedValue(strategy="AUTO")
     */
    protected $id;


    /**
     * @var integer $id
     */
    private $id;


    /**
     * Get id
     *
     * @return integer $id
     */
    public function getId()
    {
        return $this->id;
    }
}

SuperSuperClass (there are multiple levels of inheritance...):

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

abstract class User implements UserInterface
{
    protected $id;
   //...
}

[DDC-1121] Doctrine CLI tool produces wrong schema when the id columns of the entities are not named as $id. The annotations block aren't taken into account

Sun, 1 May 2011 04:06:09 +0000

namespace Entities;

//use Doctrine\Common\Collections\ArrayCollection;

/** 
 *@Entity
 *@Table(name="user")
 */
class User
{
	/** 
	*@Id 
	*@Column(type="integer", name="user_id")
	*@GeneratedValue
	* */
    private $userId;
	
	/** @Column(length=255) */
    private $lastName;
	
	/** @Column(length=255, name="user_firstname") */
    private $firstName;
	
	 /**
     * Bidirectional - Many users are geathered within one group (OWNING SIDE)
     *
     * @ManyToOne(targetEntity="\Entities\Group", inversedBy="user")
     */
	private $group;
	
/// ---
}

<?php
namespace Entities;
/** 
 *@Entity
 *@Table(name="group")
 */
class Group
{
	/** 
	*@Id 
	*@Column(type="integer", name="group_id")
	*@GeneratedValue
	* */
    private $groupId;
	
	/** @Column(name="group_name") */
    private $name;
	
    /**
     * @OneToMany(targetEntity="\Entities\User", mappedBy="group")
     */
    private $users;

    public function __construct() {
        $this->users = new \Doctrine\Common\Collections\ArrayCollection();
    }
}

In the following examples the id fields are set to $userId (mapped to user_id) and $groupId (mapped to group_id), but when it comes to generating the schema an error occures. The Doctrine CLI Tool doesn't work properly. When it generates the schema it fails to take into account the annotation blocks and just uses "id" instead of "group_id".

Let me explain it better. If we run the tool it will produce the following code

...

ALTER TABLE user ADD FOREIGN KEY (group_id) REFERENCES group(id)

instead of

ALTER TABLE `user`  ADD  FOREIGN KEY (`group_id`) REFERENCES `groups` (`group_id`);

Moreover using "group" as a name of the entity class will lead to numerous problems, because it's a reserved word in SQL. Even if we specify the quoatation forcibly using backticks it won't work:

 /**@Table(name="`group`")*/
Class Group {

The quoatation won't be taken into account while generation the schema.

I'm enclosing the files I've tried to play with. Just try to generate the schema.

[DDC-1102] Typo in ORM/Tools/EntityGenerator.php

Sun, 1 May 2011 04:02:43 +0000

There is a typo in ORM/Tools/EntityGenerator.php (line 502 in github master): MappedSupperClass instead of MappedSuperClass

[DDC-1134] Entity Generator: Namespace parsing fix

Sun, 1 May 2011 03:53:27 +0000

The entity generator is not able to parse the namespace/class of existing entities in many cases. Here is a simple class that fails:

<?php namespace Foo\Bar; use Foo; class Baz {}

Fix is here: https://github.com/doctrine/doctrine2/pull/49

[DDC-1133] DuckType AnnotationReader in AnnotationDriver

Sat, 30 Apr 2011 08:24:53 +0000

Currently the hint is strict in AnnotationDriver for the AnnotationReader. This should be duck-typed to support usage of https://github.com/schmittjoh/annotations

[DDC-1109] SINGLE_TABLE mapping fails to set the discriminator column value on persist if the mapping classes are specified with fully qualified namespace

Sat, 30 Apr 2011 06:52:52 +0000

If I specify a single inheritance structure with the mapping classes specified with fully qualified namespace in the annotation and then if I create a new mapped entity and try to save it, doctrine specifies the value for the discriminator column as NULL and thus the fush fails with mysql complaining the discriminator column to be NULL. If I specify the mapping classes without fully qualified namespace the persist works as expected

For example this fails:

<?php
namespace Entities;
/**
 * @Entity
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="itemType", type="integer")
 * @DiscriminatorMap({
 * "0"="\Entities\Data\Integer",
 * "5"="\Entities\Data\Text",
 * "6"="\Entities\Data\Form"
 * })
 */
class master {

But this works as expected:

<?php
namespace Entities;
/**
 * @Entity
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="itemType", type="integer")
 * @DiscriminatorMap({
 * "0"="Entities\Data\Integer",
 * "5"="Entities\Data\Text",
 * "6"="Entities\Data\Form"
 * })
 */
class master {

The obivous workaround for now is to not use fully qualified namespaced classes for the discriminator maps, but rather relative.

attached is the doctrine sanbox with the failing setup

[DDC-1108] Parameters name of a single letter don't work

Sat, 30 Apr 2011 06:29:20 +0000

"SELECT c FROM MyBundle\AppBundle\Entity\Cities c WHERE c.nume LIKE :q" throws an Exception in Doctrine\ORM\Query\AST\InputParameter line 46 because strlen return 1.
I don't know the DQL parser deeply but it seems that the value passed to this class does not contain the colon. In this case the exception does not make sense here.

[DDC-1132] Reverse Engeneering Fatal Error

Sat, 30 Apr 2011 05:39:59 +0000

Following this cookbook article
http://symfony.com/doc/2.0/cookbook/doctrine/reverse_engineering.html

When I run the command, I get an error:

php app/console doctrine:mapping:convert xml ./src/Acme/BlogBundle/Resources/config/doctrine/metada/orm --from-database --force
PHP Notice: Undefined variable: otherFk in /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php on line 205
PHP Stack trace:
PHP 1. {main}() /var/www/sn/app/console:0
PHP 2. Symfony\Component\Console\Application->run() /var/www/sn/app/console:16
PHP 3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Application.php:119
PHP 4. Symfony\Component\Console\Application->doRun() /var/www/sn/vendor/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:77
PHP 5. Symfony\Component\Console\Command\Command->run() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Application.php:193
PHP 6. Symfony\Bundle\DoctrineBundle\Command\ConvertMappingDoctrineCommand->execute() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Command/Command.php:188
PHP 7. Doctrine\ORM\Tools\Console\Command\ConvertMappingCommand->execute() /var/www/sn/vendor/symfony/src/Symfony/Bundle/DoctrineBundle/Command/ConvertMappingDoctrineCommand.php:48
PHP 8. Doctrine\ORM\Mapping\ClassMetadataFactory->getAllMetadata() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php:119
PHP 9. Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:123
PHP 10. Doctrine\ORM\Mapping\ClassMetadataFactory->loadMetadata() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:176
PHP 11. Doctrine\ORM\Mapping\Driver\DatabaseDriver->loadMetadataForClass() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:282

Notice: Undefined variable: otherFk in /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php on line 205

Call Stack:
0.0036 328024 1. {main}() /var/www/sn/app/console:0
5.6943 13982540 2. Symfony\Component\Console\Application->run() /var/www/sn/app/console:16
5.7041 14171544 3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Application.php:119
5.7043 14171544 4. Symfony\Component\Console\Application->doRun() /var/www/sn/vendor/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:77
5.7105 14171588 5. Symfony\Component\Console\Command\Command->run() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Application.php:193
5.7140 14172700 6. Symfony\Bundle\DoctrineBundle\Command\ConvertMappingDoctrineCommand->execute() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Command/Command.php:188
5.7980 16246052 7. Doctrine\ORM\Tools\Console\Command\ConvertMappingCommand->execute() /var/www/sn/vendor/symfony/src/Symfony/Bundle/DoctrineBundle/Command/ConvertMappingDoctrineCommand.php:48
5.8131 16613668 8. Doctrine\ORM\Mapping\ClassMetadataFactory->getAllMetadata() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php:119
7.9402 18186692 9. Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:123
7.9402 18186692 10. Doctrine\ORM\Mapping\ClassMetadataFactory->loadMetadata() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:176
7.9489 18458388 11. Doctrine\ORM\Mapping\Driver\DatabaseDriver->loadMetadataForClass() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:282

PHP Fatal error: Call to a member function getColumns() on a non-object in /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php on line 205
PHP Stack trace:
PHP 1. {main}() /var/www/sn/app/console:0
PHP 2. Symfony\Component\Console\Application->run() /var/www/sn/app/console:16
PHP 3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Application.php:119
PHP 4. Symfony\Component\Console\Application->doRun() /var/www/sn/vendor/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:77
PHP 5. Symfony\Component\Console\Command\Command->run() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Application.php:193
PHP 6. Symfony\Bundle\DoctrineBundle\Command\ConvertMappingDoctrineCommand->execute() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Command/Command.php:188
PHP 7. Doctrine\ORM\Tools\Console\Command\ConvertMappingCommand->execute() /var/www/sn/vendor/symfony/src/Symfony/Bundle/DoctrineBundle/Command/ConvertMappingDoctrineCommand.php:48
PHP 8. Doctrine\ORM\Mapping\ClassMetadataFactory->getAllMetadata() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php:119
PHP 9. Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:123
PHP 10. Doctrine\ORM\Mapping\ClassMetadataFactory->loadMetadata() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:176
PHP 11. Doctrine\ORM\Mapping\Driver\DatabaseDriver->loadMetadataForClass() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:282

Fatal error: Call to a member function getColumns() on a non-object in /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php on line 205

Call Stack:
0.0036 328024 1. {main}() /var/www/sn/app/console:0
5.6943 13982540 2. Symfony\Component\Console\Application->run() /var/www/sn/app/console:16
5.7041 14171544 3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Application.php:119
5.7043 14171544 4. Symfony\Component\Console\Application->doRun() /var/www/sn/vendor/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:77
5.7105 14171588 5. Symfony\Component\Console\Command\Command->run() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Application.php:193
5.7140 14172700 6. Symfony\Bundle\DoctrineBundle\Command\ConvertMappingDoctrineCommand->execute() /var/www/sn/vendor/symfony/src/Symfony/Component/Console/Command/Command.php:188
5.7980 16246052 7. Doctrine\ORM\Tools\Console\Command\ConvertMappingCommand->execute() /var/www/sn/vendor/symfony/src/Symfony/Bundle/DoctrineBundle/Command/ConvertMappingDoctrineCommand.php:48
5.8131 16613668 8. Doctrine\ORM\Mapping\ClassMetadataFactory->getAllMetadata() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php:119
7.9402 18186692 9. Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:123
7.9402 18186692 10. Doctrine\ORM\Mapping\ClassMetadataFactory->loadMetadata() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:176
7.9489 18458388 11. Doctrine\ORM\Mapping\Driver\DatabaseDriver->loadMetadataForClass() /var/www/sn/vendor/doctrine/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:282