Doctrine Project

[DDC-727] Proxy instances should be able to get their correspondent ClassMetadata

Sat, 7 Apr 2012 07:21:03 +0000

This should be possible:

$entity = $em->getReference('Foo' , 1); 
$class = $em->getClassMetadata(get_class($entity)); // ClassMetadata if Foo entity

Currently it seems to throw an Exception.

[DDC-841] Generated SQL contains non-existen alias

Reference — Wed, 2 Feb 2011 13:31:44 +0000

Result:

PDOException: SQLSTATE[HY000]: General error: 1 no such column: e2_.owner_id

Generated SQL:

SELECT c0_.id AS id0, c0_.createdAt AS createdAt1, c0_.updatedAt AS updatedAt2, c0_.title AS title3, c0_.color AS color4, c0_.owner_id AS owner_id5 FROM calendar c0_ INNER JOIN user u1_ ON e2_.owner_id = u1_.id WHERE u1_.username = 'bot'

Notice how the table alias "e2" does not existm yet is used in the join clause.

Meta:

/**

@ManyToOne(targetEntity="User")
@JoinColumn(name="owner_id", referencedColumnName="id")
*
@var User
*/

DQL:

SELECT c FROM Calendar c JOIN c.owner u WHERE u.username = 'bot'

A workaround would be appreciated.

Thanks!

[DDC-736] Nasty ordering issue with fetch-joins

Reference — Fri, 10 Dec 2010 14:57:01 +0000

Will not work correctly:

select c, ca from Cart ca join ca.customer c

Works correctly:

select ca, c from Cart ca join ca.customer c

In the first case the ordering of the DQL aliases causes associations to be skipped during hydration.

[DDC-899] Add an unobtrusive way to determine if entity manager is closed

Fri, 3 Dec 2010 11:44:34 +0000

There is no way to unobtrusively determine if an entity manager instance has been closed (due to exceptions/errors during a transaction).

Something like the following would come in handy:

class EntityManager {
public function isOpen()

{ return $this->closed === false; }

}

To determine if the instance is closed or not, this way one could instantiate a new entity manager instance with the same connection and configuration.

[DDC-909] Doctrine 2 AbstractQuery:: _getResultCacheId() fails when an Entity instance is used as a param (recursive references and var_export don't mix)

Fri, 3 Dec 2010 11:37:19 +0000

In the AbstractQuery::_getResultCacheId() function the following line generates the MD5 hash key:

            return md5(implode(";", (array)$sql) . var_export($this->_params, true) .
                var_export($this->_hints, true)."&hydrationMode=".$this->_hydrationMode);

The issue is the use of var_export($this->_params, true); fails when one of the params is an instance of an Entity (which usually have recursive references).

To be honest I really don't know what solution there would be internally, if doctrine were to extend the proxy class to provide a "getIdentifier" or if the _getResultCacheId() could grab the identification of the Entity we could avoid this.

However beyond that potential idea really probably the best thing is to throw a giant warning text in the manual saying "if your'e using entities as parameters manually set your cache ids".

[DDC-897] Make ClassMetadataFactory configurable

Mon, 29 Nov 2010 05:58:12 +0000

It was requested lots of times: ClassMetadataFactory has to be overrideable for some frameworks to operate!

[DDC-818] MSSQL Locking not working in all places

Sat, 27 Nov 2010 16:41:51 +0000

MSSQL locking requires the table name to be hinted with additional information. However in many places there are only ways to append the lock hints to the whole Query.

We have to lock over the code and delegate table name generation to $platform->appendLockHint($tableName) to get this fixed.

[DDC-880] Metadata XSD is out of sync

Sat, 27 Nov 2010 16:35:55 +0000

The XSD file at http://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd is out of sync with the git repository.

[DDC-876] CLI Global namespace forced on all Entity generated TypeHinting

Sat, 27 Nov 2010 16:18:19 +0000

When using the CLI tool to generate your entities Doctrine forces a global namespace on all TypeHints in functions. For example I used the sandbox

See file User.php with function setAddress:

public function setAddress(Address $address)

Remove this function entirely, so that it can be generated. Then run,

./doctrine orm:generate-entities .

Open file User.php and now the function has become:

public function setAddress(\Address $address)

note the prepended \ for global namespace

This behaviour would be fine if all types would be in the global scope, but they're not. If you use another entity such as Address in the same namespace it should just generate the proper
public function setAddress(Address $address)

Or better yet, generate the Fully Qualified Namespace

Code responsible for this:
http://trac.doctrine-project.org/browser/trunk/lib/Doctrine/ORM/Tools/EntityGenerator.php#L609

[DDC-895] Generated XML is not valid (because of order)

Sat, 27 Nov 2010 14:37:16 +0000

The generated XML using the Tool Chain is not valid (because of order of generated elements).

[DDC-888] PHP stars to complain if no joinColumns/inverseJoinColumns provided for JoinTable annotation

Sat, 27 Nov 2010 14:05:44 +0000

The problem is rather trivial - if no joinColumns or inverseJoinColumns provided for the JoinTable annotation declaration, then PHP will complain on lines 215/225 of Doctrine\ORM\Mapping\Driver\AnnotationDriver. The easiest way to eliminate this problem is to simply initialize these fields in the annotation-class:

DoctrineAnnotations.php

final class JoinTable extends Annotation {
    public $name;
    public $schema;
    public $joinColumns = array();
    public $inverseJoinColumns = array();
}

[DDC-855] [patch] EntityGenerator add an extra return line at each call ...

Sat, 27 Nov 2010 13:57:46 +0000

When using the php kooqit/console doctrine:generate:entities command (from the symfony2 framework), the EntityGenerator add an extra return line every time the command is called ....

diff --git a/lib/Doctrine/ORM/Tools/EntityGenerator.php b/lib/Doctrine/ORM/Tools/EntityGenerator.php
index f2fa583..b0c8320 100644
--- a/lib/Doctrine/ORM/Tools/EntityGenerator.php
+++ b/lib/Doctrine/ORM/Tools/EntityGenerator.php
@@ -218,7 +218,7 @@ public function <methodName>()
         $body = str_replace('<spaces>', $this->_spaces, $body);
         $last = strrpos($currentCode, '}');
 
-        return substr($currentCode, 0, $last) . $body . "\n}";
+        return substr($currentCode, 0, $last) . $body . (strlen($body) > 0 ? "\n" : ''). "}";
     }
 
     /**

[DDC-886] Mapped Supperclass composite identifier is ignored in child class

Sat, 27 Nov 2010 11:38:41 +0000

Currently $class->isIdentifierComposite value stays "false" if no new identifiers were added on child class..

patch proposal:
around line 270, file: ClassMetadataFactory.php

add line:
$class->isIdentifierComposite = $parent->isIdentifierComposite;

this way if supperclass had composite identifier and child had none identifiers
the result would be as suspected.

[DDC-882] The constructor type hinting of LoadClassMetadataEventArgs is not good

Thu, 18 Nov 2010 14:46:04 +0000

The constructor type hinting of LoadClassMetadataEventArgs is not good. It should be ClassMetadataInfo and not ClassMetadata.

ClassMetadataInfo is the base class used in the DisconnectedClassMetadataFactory. So when the event is used the argument is ClassMetadataInfo instance and not a ClassMetadata instance. I have this issue with the DoctrineBundle form the symfony2 framework.

[DDC-722] EntityRepository::find(One?)By should also support Associations

Tue, 16 Nov 2010 16:30:15 +0000

We should allow EntityRepository to also support associations fetching (when fetched Entity is the owning side).

$employee = $em->getRepository('Employee')->findByEmployer($em->getReference('Employer', $id));

[DDC-796] Inheritance Discriminator mapping fails when the parent class is after a subclass alphabetically

Tue, 16 Nov 2010 16:04:24 +0000

If I have a class called AbstractPage, with this single table inheritance mapping linking to the folllowing classes (Page, Article, Review), then it works fine:

<discriminator-column name="discr" type="string" />
<discriminator-map>
<discriminator-mapping value="page" class="Page" />
<discriminator-mapping value="article" class="Article" />
<discriminator-mapping value="review" class="Review" />
</discriminator-map>

If however I rename the classes to the Zend framework format, within modules (Default_Model_AbstractPage, Default_Model_Page, Article_Model_Article, Article_Model_Review), then because Article is before Default, then the schema tool gets confused and throws an error - [Doctrine\DBAL\Schema\SchemaException] The table with name 'pages' already exists. Everything else is the same but the class names.

I have attached examples of this both working and nonworking with the different naming schemes. As you can see everything else is the same.

[DDC-511] Schema tool does not support STI - attempts to create a table per subclass

Reference — Tue, 16 Nov 2010 15:55:07 +0000

A recent update broke all support for STI.

Now the following does not work:

/**
 * @MappedSuperclass
 * @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="type", type="string")
 * @DiscriminatorMap({"User" = "User", "Group" = "Group"})
 * @Table(name="user")
 */
abstract class Principal
{}
/**
 * @Entity
 */
class Group extends Principal
{}
/**
 * @Entity
 */
class User extends Principal
{}

Attempting to use orm:schema-tool:create results in the following error:

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Group (user_id INT NOT NULL, username VARCHAR(45) NOT NULL, password VARCHAR(40)' at line 1

The SQL generated is:

CREATE TABLE Group (user_id INT NOT NULL, username VARCHAR(45) NOT NULL, password VARCHAR(40) NOT NULL, status SMALLINT NOT NULL, firstname VARCHAR(45) NOT NULL, lastname VARCHAR(45) NOT NULL, email VARCHAR(60) NOT NULL, phone VARCHAR(20) DEFAULT NULL, pager VARCHAR(20) DEFAULT NULL, reset_code VARCHAR(6) DEFAULT NULL, is_password_expired TINYINT(1) NOT NULL, failed_login_count SMALLINT NOT NULL, is_admin TINYINT(1) NOT NULL, version INT DEFAULT 1 NOT NULL, UNIQUE INDEX Group_username_uniq (username), PRIMARY KEY(user_id)) ENGINE = InnoDB;

CREATE TABLE User (user_id INT NOT NULL, username VARCHAR(45) NOT NULL, password VARCHAR(40) NOT NULL, status SMALLINT NOT NULL, firstname VARCHAR(45) NOT NULL, lastname VARCHAR(45) NOT NULL, email VARCHAR(60) NOT NULL, phone VARCHAR(20) DEFAULT NULL, pager VARCHAR(20) DEFAULT NULL, reset_code VARCHAR(6) DEFAULT NULL, is_password_expired TINYINT(1) NOT NULL, failed_login_count SMALLINT NOT NULL, is_admin TINYINT(1) NOT NULL, version INT DEFAULT 1 NOT NULL, UNIQUE INDEX User_username_uniq (username), PRIMARY KEY(user_id)) ENGINE = InnoDB;

[DDC-853] Mysql: Drop schema for entities doesnt work if Database contains already tables with 'enum' Field

Tue, 16 Nov 2010 15:32:48 +0000

Dropping Entities with:

$tool = new \Doctrine\ORM\Tools\SchemaTool($em);
$classes = array(
  $em->getClassMetadata('Entities\User'),
  $em->getClassMetadata('Entities\Profile')
);
$tool->dropSchema($classes);

throws:
Doctrine\DBAL\DBALException: Unknown database type enum requested, Doctrine\DBAL\Platforms\MySqlPlatform may not support it

The Database already contains some tables with enum fields. But those should not be affected. They have no constraints to the tables managed by the EntityManager

Some debugging brought me to the point that Doctrine2 is trying to drop complete database, even metaclasses where given.

In Doctrine\ORM\Tools\SchemaTool $classes will not be used in any way

    public function dropSchema(array $classes)
    {
        $dropSchemaSql = $this->getDropSchemaSql($classes);
        $conn = $this->_em->getConnection();

        foreach ($dropSchemaSql as $sql) {
            $conn->executeQuery($sql);
        }
    }
// Here $classes will not be used
    public function getDropSchemaSql(array $classes)
    {
        $sm = $this->_em->getConnection()->getSchemaManager();
        $schema = $sm->createSchema();

        $visitor = new \Doctrine\DBAL\Schema\Visitor\DropSchemaSqlCollector($this->_platform);
        /* @var $schema \Doctrine\DBAL\Schema\Schema */
        $schema->visit($visitor);
        return $visitor->getQueries();
    }

Also method SchemaTool::_getDropSchemaTablesDatabaseMode($classes) seems not to be used.

[DDC-629] SchemaTool's method dropSchema, drops all classes instead of those specified in $classes argument

Tue, 16 Nov 2010 15:32:15 +0000

$classes = array(
  $this->_em->getClassMetadata('Models\Acl\Role'),
  $this->_em->getClassMetadata('Models\Acl\Resource\Module'),
  $this->_em->getClassMetadata('Models\Acl\Resource\Controller'),
  $this->_em->getClassMetadata('Models\Acl\Resource\Action')
);

// Delete databases
$tool = new \Doctrine\ORM\Tools\SchemaTool($this->_em);
$tool->dropSchema($classes);

Expected:
Drops just schema specified by $classes

Actual:
Drops all schema, not just that specified in $classes

[DDC-867] QueryBuilder clone only does shallow clone

Mon, 15 Nov 2010 15:32:49 +0000

Cloning a QueryBuilder object only performs a shallow clone. This is problematic as object references in the dqlParts array stay the same in cloned copies of a QueryBuilder object.

For example, say I have a QueryBuilder object with two simple "andWhere" clauses. Now I clone the QueryBuilder instance and add a third "andWhere" clause to the cloned object. The 3rd andWhere clause will also appear in the original QueryBuilder object. The desired behavior is that the original QueryBuilder object is not modified when adding clauses to the cloned copy.

[DDC-866] The EBNF definition for DQL needs to be updated

Mon, 15 Nov 2010 15:00:44 +0000

This is a summary replacing bugs 857, 863 and 864, which I hereby close.

In summary, deep path expressions like

SingleValuedAssociationPathExpression ::= IdentificationVariable "."

{SingleValuedAssociationField "."}

* SingleValuedAssociationField

are not suppored by the current implementation, but are documented to work in the EBNF definition for DQL (http://www.doctrine-project.org/projects/orm/2.0/docs/reference/dql-doctrine-query-language/en#dql-doctrine-query-language). The EBNF definitions need to be fixed, because currently they are factually wrong and thus misleading.

(Obviously, actually having the feature would be preferrable IMO)

[DDC-873] @Version and Single Table

Thu, 11 Nov 2010 15:21:40 +0000

In my previous Bug Report ~~DDC-871~~ I'm using a separate table for versioning copies. However, if one wishes to keep all versions in a single table, this causes some headaches, since the field with @version can't be set by the developer (i.e. Doctrine2 does magic here).

I'll try to describe it with some meta code.

Let's say you have the class SingleTable, which has a property version marked with @version and @id, and also a property id marked with @id. I know this isn't the preferred way since it's a composite primary key, but in theory it would work. I'm managing the ID of the object myself, which works without a problem.

The problem is that once a field is marked with @version, it isn't set during an insert operation. Doctrine2 relies on the field's default value. This causes the following problems:

You can't start with an object version higher than 1.
If you wish to insert an older version (which is possible with my composite primary key example), you can't simply set the version - Doctrine2 does it's own magic, which fails at this point.

No matter if there will be a change to the @version behavior or not, it should be documented a bit better in the documentation. Once I know if it will be changed or not, I can contribute additional documentation for this.

[DDC-856] Boolean discriminator field for single table inheritance does not work as expected with MySQL

Thu, 11 Nov 2010 15:14:05 +0000

Hello,

I have a a single table inheritance, with a boolean discriminator field, see: http://pastie.org/1269467
As MySQL does not have a boolean field, true / false should be translated to 1/0 (as it uses a TINYINT(1) field instead).

If I use 1 / 0 in the annotation instead of true / false it works, but than it's not boolean anymore...

So it should either translate that, or mention this in the documentation (although vendor specific exceptions should be avoided imo).

[DDC-870] @Version causes integer fields to return a string

Tue, 9 Nov 2010 17:16:15 +0000

Here's a small example when using @Version causes the field to return a string and not an integer.

Here's a very simple example:

SimpleTest class

/**
 * @Entity
 */
class SimpleTest {
	 /**
     * @Id
     * @generatedValue(strategy="AUTO")
     * @Column(type="integer")
     */
    private $id;
    /**
     * @Column(type="integer")
     * @version
     */
    private $version;
    /**
     * @Column
     */
    private $content;
    
    public function setContent ($content) {
    	$this->content = $content;
    }
    
    public function getVersion () {
    	return $this->version;
    }
    
    public function getId () {
    	return $this->id;
    }
    
}

Invocation

$test = new SimpleTest();
$test->setContent("V1");
$em->persist($test);
$em->flush();

if (gettype($test->getVersion()) == "string") { die("Version should be an integer, not a string!"); }

The invocation fails because the version property is suddenly a string and not an integer anymore.

[DDC-868] ORM:Schema-tool:create failure -- the result depends on xml files enumeration order of RecursiveDirectoryIterator in context of SINGLE_TABLE inherantence

Tue, 9 Nov 2010 16:13:58 +0000

= Relevant configuration: =
resources.doctrine.driver.class = Doctrine\ORM\Mapping\Driver\XmlDriver
resources.doctrine.driver.dir = APPLICATION_PATH "/../library/Droop/Model/Xml"
resources.doctrine.cache.class = Doctrine\Common\Cache\ArrayCache
resources.doctrine.conn.driver = pdo_mysql

= Models hierarchy =
class Sysbase {}
class Drooplet extends Sysbase {}
class Menu extends Sysbase {}

= Xml driver =
attached

= Error =
While using command line to generate schema [php doctrine.php orm:schema-tool:create --dump-sql], it reports error "The table with name 'system' already exists." on windows however not on linux.

It is because the ClassMetaFactory.php depends on the sequence of result returned by getAllClassNames(). In this scenario, it's in descending order on linux and ascending on windows.
124 foreach ($this->driver->getAllClassNames() as $className)

{ 125 $metadata[] = $this->getMetadataFor($className); 126 }

127
128 return $metadata;
This order populates to SchemaTool::getSchemaFromMetadata(); If the base model is processed before it's descendants, everything is OK. Otherwise, it will complain about the table already exists.

= Fix =
ClassMetaFactory.php
128 return $this->loadedMetadata;

[DDC-861] Improve ProxyFactory to avoid having to use Autoloader

Sat, 6 Nov 2010 07:24:14 +0000

In ProxyFactory::getProxy all the information is necessary to avoid having to configure an autoloader. Why don't we do that already?

[DDC-860] loadClassMetadata event on event listeners

Fri, 5 Nov 2010 17:13:46 +0000

loadClassMetadata event arguments - LoadClassMetadataEventArgs, should contain a reference to metadataCacheDriver used on classMetadataFactory
that is important in order to cache additional metadata which can be read from other annotations during this event. Currently it is not possible to retrieve it during this event.
That concerns only event listeners not livecycle events directly on entity.

[DDC-859] Datetime object changeset computing

Fri, 5 Nov 2010 16:18:47 +0000

The problem is with Datetime value on entity, if I dirrecly modify it, unitOfWork will not add it into change set
// assume loaded entity through dql or repository:

$entity->getStartDate()->modify("+ 1day");
$em->persist($entity);
$em->flush(); // no changes

as far as I understand objects are compared through ($oldObject === $newObject) probably php takes spl_object_hash to do the comparison
copying an object works as expected

[DDC-824] EntityManager::remove($entity), EntityManager::flush() does not remove the entity from DB

Fri, 5 Nov 2010 03:25:03 +0000

Test.php

/* 
 * @Entity
 * @Table(indexes={@Index(name="name", columns={"name"})})
 */
class ProductAttribute
{

    /**
     * ID
     * 
     * @Id @Column(type="integer") @GeneratedValue
     *
     * @var integer
     */
    protected $id;
    /**
     * Name
     *
     * @Column
     *
     * @var string
     */
    protected $name;
    /**
     * Values
     *
     * @OneToMany(targetEntity="ProductAttributeValue", mappedBy="attribute")
     *
     * @var array
     */
    protected $values;

    /**
     * Gets ID
     *
     * @return integer ID
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * Sets ID
     *
     * @param integer $id ID
     *
     * @return void
     */
    public function setId($id = null)
    {
        $this->id = $id;
    }

    /**
     * Gets name
     *
     * @return string Name
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Sets name
     *
     * @param string $name Name
     *
     * @return void
     */
    public function setName($name = null)
    {
        $this->name = $name;
    }

    /**
     * Gets product attribute values
     *
     * @return array Product attribute values
     */
    public function getValues()
    {
        return $this->values;
    }

    /**
     * Adds product attribute value
     *
     * @param ProductAttributeValue $value Product attribute value
     * 
     * @return void
     */
    public function addValue(ProductAttributeValue $value)
    {
        $value->setAttribute($this);
        $this->values[] = $value;
    }

}

$attribute = $em->find('ProductAttribute', 1);
$em->remove($attribute);
$em->flush();

The upper code won't remove the entity from the database.... Corresponding DQL (DELETE ProductAttribute a WHERE a.id = 1) will remove it from the database...

[DDC-812] DQL hydration of joined objects skipped when main instance already present in entity manager

Sun, 31 Oct 2010 06:13:53 +0000

I do the following:

$author1 = $em->find('Author', 1);

$author1again = $em
  ->createQuery(
    'SELECT A, B '.
    'FROM Author A '.
    'INNER JOIN A.Books B '.
   'WHERE A.ID = 1'
  )
  ->getSingleResult();

the Books collection is not hydrated because the author instance was already
hydrated when populating $author1. This means when I call
count($author1->getBooks()) a third query is executed to fetch the Books again.

The result is even more problematic when adding a WITH clause to the
INNER JOIN, in that case one would expect the Books collection to only
contain the books matching matching that criteria.

The result is expected when commenting out the $author1 =... line, thus when
the author does not already exist in the entity manager.

I'm sorry I can't produce a test case right now.

[DDC-274] Class and namespace naming inconsistency

Sun, 31 Oct 2010 05:20:55 +0000

There are inconsistencies with some class and namespace names that include acronyms.

Examples:

Classes with upper-casing:
ORMException, DBALException, OCI8Connection, etc.

Classes with proper-casing:
RunDqlTask, CliException, MySqlPlatform, etc.

Namespaces with upper-casing:
DBAL, ORM, Doctrine\DBAL\Driver\PDOMsSql, etc.

Namespaces with proper-casing:
Doctrine\Common\Cli, Doctrine\DBAL\Tools\Cli\, Doctrine\ORM\Id, etc.

There is more proper-casing than upper-casing. IMHO, proper-casing is better as it's easier to read "SqlException" than it is to read "SQLException" (the "E" looks like part of the acronym), and things like "CLITask" can be avoided.

I discussed this a bit with Benjamin and Guilherme, and they were unsure and said that the whole team needed to reach consensus.

I'm leaving the priority as "Major" because this should probably be fixed sooner rather than later to prevent compatibility breaks.

[DDC-826] Problem with @MappedSuperclass and associations

Reference — Sun, 31 Oct 2010 03:11:40 +0000

I have a project with global entities(Lib\Shared\Main - @MappedSuperclass ) and local entities(Shared\Main) which extends the globals.

The following DQL is returning wrong SQL:

SELECT Horoscope FROM Shared\Main\Horoscope Horoscope JOIN Horoscope.sign Sign WHERE Sign.id = 7

SELECT h0_.id AS id0, h0_.date AS date1, h0_.contents AS contents2, h0_.signId AS signId3 FROM horoscopes h0_ INNER JOIN global.sys_zodiac_signs g1_ ON h2_.signId = g1_.id WHERE g1_.id = 7

The attached zip contains the entity files.

What is the correct way to extends entities and to build JOINed requests

Have a nice day

[DDC-671] Table aliases wrongly computed with YAML + mappedsuperclasses and joins

Reference — Sun, 31 Oct 2010 02:40:37 +0000

Affects only YAML. (Maybe also XML? But works with Annotations!)

If there's a relation specified in a mappedSuperclass (manyToOne, towards entity B) and two Entities A and B using this mappedSuperclass, an error occurs within generating the SQL-Query when using a query a la SELECT * FROM A JOIN B ON A.relation = B.id:

This is due to no table name being specified for the mappedSuperclass. (But this tableName is accessed in SqlWalker.php ll. 718. Be aware that there's the mappedSuperclass in use, NOT the class B!)

I'm not quite sure how this should be handled. At least, not specifying the relation in the mappedSuperclass but moving it to each of the yml-files of A and B solves this problem. (But unneccessarily complicates things?)

I will push a test case to my repo.

[DDC-758] When merging many to many entites back into the repository changes to the associations are not respected

Sun, 31 Oct 2010 02:35:36 +0000

When merging a DETACHED entity into the repository with ManyToMany associations that have changed since the last flush, the join table is not updated with the new associations.

Many Movies have many Artists with cascade merge:

class Movie {
	
	/** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
	public $id;
	
	/** @Column(length=50, type="string") */
	public $title;
	
	/** 
	 * @ManyToMany(targetEntity="Artist", cascade={"merge"})
	 */
	public $artists;
	
	public function __construct() {
		$this->artists = new ArrayCollection();
	}	

}

<?php
class Artist {
	
	/** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
	public $id;
	
	/** @Column(length=50, type="string") */
	public $name;
	
	/** @ManyToMany(targetEntity="Movie", mappedBy="artists", cascade={"merge"}) */
	public $movies;
	
	public function __construct() {
		$this->movies = new ArrayCollection();
	}
	
}

Assume that the database contains:
Movie: id=1, title="Movie 1"
Artist: id=1, name="Artist 1"
Artist: id=2, name="Artist 2"

and that there is a entry (1, 1) in movie_artist so that there is a many-many relationship between Movie 1 and Artist 1.

I now want to merge a detched version of a movie into the repository, with an extra relationship between Movie 1 and Artist 2:

$m1 = new \vo\Movie();
$m1->id = 1;
$m1->title = "Movie 1";

$a1 = new \vo\Artist();
$a1->id = 1;
$a1->name = "Artist 1";

$a2 = new \vo\Artist();
$a2->id = 2;
$a2->name = "Artist 2";

$m1->artists->add($a1); $a1->movies->add($m1);

// Add the new association
$m1->artists->add($a2); $a2->movies->add($m1);

// This is a cascade merge so it will merge the entities down the tree
$m1 = $em->merge($m1);

At this point $m1 should contains merged entities reflecting the same as what is in the database, plus the extra association between Movie 1 and Artist 2, so after a flush() movie_artist should contain (1,1),(1,2)

I now run:

$em->flush();

but movie_artist remains unchanged (still just (1,1)) and $em->getUnitOfWork()->computeChangeSets() is empty before the flush().

The same behaviour is exhibited when merging $m1 after deleting entities from its many-to-many associations; movie_artist does not change.

[DDC-666] @ManyToMany JoinTable defaults - Allow only table name

Sun, 31 Oct 2010 00:42:03 +0000

Currently you cannot only speciify the table name and rely on the mapping to figure out the foreign key names.

The following should be possible:

/**
 * @ManytoMany(targetEntity="Foo")
 * @JoinTable(name="foo_bar_table")
 */

[DDC-832] Not quoted class name when updating entity

Reference — Sat, 30 Oct 2010 13:34:32 +0000

When trying to update an entity which have a reserved name. Doctrine doesn't quoted its name.

On Doctrine\ORM\Persisters\BasicEntityPersister, _updateTable, $tableName is directly used to create the sql. We may use $this->_class->getQuotedTableName($this->_platform) instead ?

I'm going to propose a merge for that on github.

[DDC-732] Class Table Inheritance - wrong table order on insert with more than one level of inheritance

Sat, 30 Oct 2010 12:17:02 +0000

This is the error that i get when i try to create new entity Employee

$newEmployee = new Users_Entity_Model_Employee;
//here i set the data
.....

$em->persist($newEmployee);
$em->flush();

SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (`crm/Employees`, CONSTRAINT `employee_person` FOREIGN KEY (`contactID`) REFERENCES `Persons` (`contactID`) ON DELETE NO ACTION ON UPDATE NO ACTION)

/**
 *
 * @Entity
 * @InheritanceType("JOINED")
 * @Table(name="Contacts")
 * @DiscriminatorColumn(name="contactType", type="string")
 * @DiscriminatorMap({"PERSON" = "Users_Model_Entity_Person", "COMPANY" = "Users_Model_Entity_Company", "EMPLOYEE" = "Users_Model_Entity_Employee", "FIRM" = "Users_Model_Entity_Firm"})
 */
class Users_Model_Entity_Contacts 
{


	/**
	 *  @Id  @Column(name="contactID", type="integer")
	 *  @GeneratedValue(strategy="AUTO")
	 *
	 */
	protected $contactID;

	// ...

}

/**
 *
 * @Table(name="Persons")
 * @entity(repositoryClass="Users_Model_PersonRepo")


 */
class Users_Model_Entity_Person extends Users_Model_Entity_Contacts
{
 // ...
}




/**
 *
 * @Table(name="Employees")
 * @entity
 */
class Users_Model_Entity_Employee extends Users_Model_Entity_Person
{
	// .....
}

[DDC-787] Camelcase tablename lost when creating models based on the database

Sat, 30 Oct 2010 06:35:33 +0000

I have a table articleLocale and I created the model with the doctrine tool using the following command: # doctrine orm:convert-mapping --from-database annotation temp.

The model that was created was Articlelocale instead of ArticleLocale and the annotations were wrong.

<?php
/**
 * Articlelocale
 *
 * @Table(name="articlelocale")
 * @Entity
 */
class Articlelocale
{
//....
}

When trying to fetch some data, I get the following error: Message: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'doctrine.articlelocale' doesn't exist
If i change the annotation so that it reads articleLocale instead of articlelocale it works like it should be working.

<?php
/**
 * Articlelocale
 *
 * @Table(name="articleLocale")
 * @Entity
 */
class Articlelocale
{
//....
}

So there is a problem with camelCase table names.

[DDC-711] Compatibility with Codeigniter 1.7.2

Sat, 30 Oct 2010 06:08:40 +0000

Following the instructions in the website did not succeed with the configuration (Doctrine.php) file. Seems that there is a problem with the namespaces (the Doctrine folder is placed in \application\libraries folder of the Codeigniter structure) and the application cannot find its clases.

[DDC-830] Missing prefix \ to switch to global space in Tools/EntityGenerator

Sat, 30 Oct 2010 03:17:12 +0000

If generated entity isn't in global namespace and extends class, name of extended class has to have prefix \ to switch to global namespace.

Fix: class Doctrine\ORM\Tools\EntityGenerator

Doctrine/ORM/Tools/EntityGenerator.php

private function _getClassToExtendName()
{
    $refl = new \ReflectionClass($this->_getClassToExtend());

    return '\\' . $refl->getName();
}

[DDC-767] Updating many-to-many relations

Duplicate — Sat, 30 Oct 2010 01:48:26 +0000

I have an entity with a many-to-many relation.

When I delete all relations and then flush, add new relations and then flush, all inside one transaction, I get

Fatal error: Call to a member function update() on a non-object in Doctrine/ORM/UnitOfWork.php on line 312

        // Delete old categories
        foreach ($revision->getCategories() as $category) {
            $revision->removeCategory($category);
        }

        $this->entityManager->flush();

        // Add new
        foreach ($categories as $categoryId) {
            $category = $this->entityManager->find('Category', $categoryId);

            if ($category instanceof Category) {
                $revision->addCategory($category);
            }
        }

        $this->entityManager->flush();

Revision::getCategories()

    /**
     * @return ArrayCollection
     */
    public function getCategories()
    {
        return $this->categories;
    }

Revision::addCategory()

    /**
     * @param Category $category
     * @return Revision
     */
    public function addCategory(Category $category)
    {
        $this->categories->add($category);
        return $this;
    }

Revision::removeCategory()

    /**
     * @param Category $category
     * @return Revision
     */
    public function removeCategory(Category $category)
    {
        $this->categories->removeElement($category);
        return $this;
    }

If this is not a bug, I'd like to know which is the most efficient and elegant way to update many-to-many relationships.

[DDC-839] Error when trying to update PersistentCollection

Duplicate — Sat, 30 Oct 2010 01:47:23 +0000

This is the error that i get :
"Argument 1 passed to Doctrine\ORM\UnitOfWork::getCollectionPersister() must be an array, null given, called in /home/vis/projects/CRM/trunk/library/Doctrine/ORM/UnitOfWork.php on line 302 and defined at /home/vis/projects/CRM/trunk/library/Doctrine/ORM/UnitOfWork.php:2149"

This happens when i try to update Entity that have PersistentCollection but when i was creating the entity did not create entities to be attached to it by the PersistentCollection. Later on i called it and and used :

$collectionEntity = $em->getRepository('CollectionEntityName')->findOneBy($data);
$entity                   = $em->getRepository('EntityName')->findOneBy($entityData);
$entity->getCollection()->add($collectionEntity);
$em->presist();
$em->flush();

[DDC-833] Internal Collection of a PersistentCollection is an Entity

Mon, 11 Oct 2010 16:23:53 +0000

The creation of an Associated Collection of a Proxy Class is broken by this line:

$reflField->getValue($entity) ?: new ArrayCollection

$entity is a Proxy Class and the property is the field users. The function ReflectionProperty::getValue() will return an Entity User. This results that the internal collection of the PersistenCollection is an Entity. This results in:

Fatal error: Call to undefined method Entity\User::clear() in \library\Doctrine\ORM\PersistentCollection.php on line 206

This is my Entity Configuration

class Organization {
    /**
     * @OneToMany(targetEntity="User", mappedBy="organization", cascade={"persist", "remove"})
     */
    private $users;    

    public function __constructor() {
      $this->users = new ArrayCollection();
   }
}

class User {
    /**
     * @ManyToOne(targetEntity="Organization", inversedBy="users")
     * @JoinColumn(name="organization_id", referencedColumnName="id")
     */	
 	private $organization; 	
}

[DDC-834] EntityManager::getReference may return proxy for parent class when using class table inheritance

Mon, 11 Oct 2010 14:46:33 +0000

When using class table inheritance, it is possible for a parent class proxy to get saved into the identifier map.

Classes:

/**
 * @Entity
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="discr", type="string")
 * @DiscriminatorMap({"employee" = "Employee", "customer" = "Customer"})
 */
class Person
{
   ...
}

/** @Entity */
class Employee extends Person
{
    ...
    public function getEmployeeNumber()
    ...
}

The following will fail:

$person = $entityManager->getReference('Person', 1);  // the identity map contains a PersonProxy with id 1

...

$employee = $entityManger->getReference('Employee', 1);  // $employee is set to the PersonProxy object in the identity map

...

$employee->getEmployeeNumber();  // error, PersonProxy object does not have a getEmployeeNumber method

[DDC-831] Return value of getAssociationMapping in class Doctrine\ORM\Mapping\ClassMetadataInfo

Sun, 10 Oct 2010 11:13:35 +0000

The problem is in the comment of function return value is Doctrine\ORM\Mapping\AssociationMapping.
My code expected to work with object of this type and normal situation is Fatal error: Call to a member function isOneToOne() on a non-object in /home/vis/projects/crm/trunk/library/Viscomp/Doctrine/Repository.php on line 371.

In my mind I suppose is normal to return object of Doctrine\ORM\Mapping\AssociationMapping, because in comment return value have this type.

I will be grateful if have fast answer because this is blocking issue for my project.

 /**
     * Gets the mapping of an association.
     *
     * @param string $fieldName  The field name that represents the association in
     *                           the object model.
     * @return Doctrine\ORM\Mapping\AssociationMapping  The mapping.
     */
    public function getAssociationMapping($fieldName)
    {
        if ( ! isset($this->associationMappings[$fieldName])) {
            throw MappingException::mappingNotFound($this->name, $fieldName);
        }
        return $this->associationMappings[$fieldName];
    }

[DDC-673] yaml metadata allows integer(X) types but ignores the X

Wed, 6 Oct 2010 16:20:27 +0000

When using the yaml mapping driver, it is possible (and in fact used by the yaml exporter) to have type: integer(X). doctrine never complains, however it always creates mysql int(11) fields regardless of the X. It should either cause an error at some point (like it does in the annotation driver according to romanb) or observe the X when creating the integer size.

[DDC-798] Clarify param term in MEMBER OF example in DQL docs

Thu, 30 Sep 2010 16:14:10 +0000

Current code example reads:

$query = $em->createQuery('SELECT u.id FROM CmsUser u WHERE :param MEMBER OF u.groups');
$ids = $query->getResult();

Maybe it's just me, but it was not immediately apparent that :param is expected to be an identifier value from the CmsGroups entity (group ID number). It may improve the example to rename :param to :groupId or add $query->setParameter(':param', $groupId);

[DDC-797] WHERE EXISTS example code doesn't make sense in docs

Thu, 30 Sep 2010 16:05:57 +0000

Example for "WHERE EXISTS" in DQL section of docs currently reads:

$query = $em->createQuery('SELECT u.id FROM CmsUser u WHERE EXISTS (SELECT p.phonenumber FROM CmsPhonenumber p WHERE p.phonenumber = u.id)');

But, p.phonenumber = u.id doesn't make sense - you're comparing the PK of a CmsPhoneNumber to a PK of a CmsUser. I think it is supposed to be p.user = u.id :

$query = $em->createQuery('SELECT u.id FROM CmsUser u WHERE EXISTS (SELECT p.phonenumber FROM CmsPhonenumber p WHERE p.user = u.id)');

Also consider updating the test at Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php line 466 to match.

[DDC-822] Query with detached Entity as parameter fails to execute

Thu, 30 Sep 2010 16:00:26 +0000

When dealing with detached entities, e.g. with the QueryCache, you cannot use these entities as parameters for other Query.

Example:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

$em->detach($user);
$query = $em->createQuery('SELECT a FROM Address a WHERE a.User = ?1');
$query->setParameter(1, $user); // $user is detached

As $user is detached, the EntityManager does not have its identifier, so Query::_doExecute fails. (There is a "//TODO: Check that $value is MANAGED?" line near the failing line).

[DDC-793] CLI doctrine.php tool should not hard code require_once paths -- leave the include path setup to cli-config.php

Thu, 30 Sep 2010 15:00:56 +0000

The current CLI tool doctrine.php makes assumptions about lib/vendor paths. Consider refactoring to allow cli-config.php to contain any include path/autoloader setup and remove hard coded paths from doctrine.php

[DDC-784] Add Windows CLI command and remove doctrine.php

Thu, 30 Sep 2010 14:57:54 +0000

Add a Windows CLI .bat and remove the annoying doctrine.php that duplicates doctrine binary.

[DDC-820] Nullable associations combined with a column definition generates a notice

Wed, 29 Sep 2010 15:14:28 +0000

When an entity has an optional association on a given field and also a column definition on that field, loading that entity generates a notice in UnitOfWork.php on line 1884. Other than the notice, the code works fine. This is the line:

$joinColumnValue = $data[$srcColumn];

Suggested fix:

$joinColumnValue = isset($data[$srcColumn]) ? $data[$srcColumn] : null;

I have attached a test case which reproduces the issue.

[DDC-815] Identifier quoting does not work with unique columns in PostgreSQL

Mon, 27 Sep 2010 17:29:12 +0000

It seems that Doctrine ORM tries to generate invalid unique index names, when the table name is quoted and one of the columns uses the "unique" annotation:

/**
 * Users\User
 *
 * @Table(name="`User`")
 * @Entity
 */
class User
{
	/**
	 * @var string $login
	 *
	 * @Column(name="login", type="string", length=40, unique=true)
	 */
	protected $login;

Expected result:

The table gets created.

Actual result:

Creating database schema...
Doctrine\DBAL\Schema\SchemaException
Invalid index-name "User"_login_uniq given, has to be [a-zA-Z0-9_]
/.../Doctrine/DBAL/Schema/SchemaException.php
Line 33
Trace:
        0. Doctrine\DBAL\Schema\SchemaException::indexNameInvalid on line 214
        1. Doctrine\DBAL\Schema\Table::_createIndex on line 176
        2. Doctrine\DBAL\Schema\Table::addUniqueIndex on line 341
        3. Doctrine\ORM\Tools\SchemaTool::_gatherColumn on line 273
        4. Doctrine\ORM\Tools\SchemaTool::_gatherColumns on line 193
        5. Doctrine\ORM\Tools\SchemaTool::getSchemaFromMetadata on line 93
        6. Doctrine\ORM\Tools\SchemaTool::getCreateSchemaSql on line 76
        7. Doctrine\ORM\Tools\SchemaTool::createSchema on line 73
        8. Doctrine\ORM\Tools\Console\Command\SchemaTool\CreateCommand::executeSchemaCommand on line 59
        9. Doctrine\ORM\Tools\Console\Command\SchemaTool\AbstractCommand::execute on line 159
        10. Symfony\Component\Console\Command\Command::run on line 205
        11. Symfony\Component\Console\Application::doRun on line 117
        12. Symfony\Component\Console\Application::run on line 72

I don't know whether the problem is caused by ORM which forgets that the table names can be quoted, or by DBAL for the same reason. Anyway, I think this should be fixed. I agree with your argumentation that identifier quoting can be wrong, but you should also remember that Doctrine can be used in cooperation with other ORM libraries or with legacy databases. I am in this particular situation: the database is shared by two different systems written in two different languages and using two different ORM libraries, and this is a big limitation for me.

[DDC-525] STI Fields null vs not null behaviour

Mon, 27 Sep 2010 17:23:35 +0000

What is the expected behaviour for fields on STI sub-classes?

Should they always be DEFAULT NULL?
Should the EntityPersister always write a default value to them?

A user reported on IRC that he had issues with Sqlite inserting null values (failing) vs Mysql which inserted empty strings.

[DDC-533] Cache keys are not limited to word characters

Mon, 27 Sep 2010 16:49:32 +0000

I'm currently working on some glue classes to integrate Doctrine 2 into an existing Zend Framework project.
To be able to re-use our caching classes (which use Zend_Cache), I wrote a \Doctrine\Common\Cache\AbstractCache implementation for Zend_Cache:

http://pastie.org/926891

However Zend_Cache only allows "a-zA-Z0-9_" for cache keys, while Doctrine seems to allow anything, and Doctrine ORM seems to use at lease "\" and "$" for metadata storage ("Entity\Article\Category$CLASSMETADATA").

What do you think is the most elegant way to solve this?

Should Doctrine also limit the cache key characters?
How could _encodeId and _decodeId be implemented?

[DDC-819] Attempting to search a recursive relationship by null results in an error...

Duplicate — Mon, 27 Sep 2010 16:42:00 +0000

I have an entity which has a many to one relationship pointing to itself. This is ultimately set to map parent/child relationships.

Consider the following snippet:

// Start out assuming we are searching for "Pages" with no parent specified (root level).
$parentId = null;

// Check to see if we're fetching pages that are a child of a parent.
if(array_key_exists("parent_id", $_GET))

{ $parentId = $_GET['parent_id']; }

$pages = $this->entityManager->getRepository("MyNamespace\Models\Page")->findByParent($parentId);

When this code is run, PHP tells me:

PHP Fatal error: Uncaught exception 'Doctrine\\ORM
ORMException' with message 'You need to pass a parameter to 'findByParent''

At which point, it's obvious that it's expecting a parameter an receiving none. The problem here however is that I have no way of matching for null. Is there some kind of surrogate null php-class that can be created to represent a model-null?

[DDC-817] Repository Query by associated ID

Duplicate — Mon, 27 Sep 2010 16:41:06 +0000

The ~~DDC-117~~ already has an implementation for this. We need a way to use the EntityRepository to query by foreign key or the related object instance.

This should be in 2.0

[DDC-653] Convert annotation mapping to xml having troubles with discriminator map

Sat, 25 Sep 2010 10:19:39 +0000

Hi,

I wanted to convert Company model from unit test folder in Doctrine 2
project but I get following error:

> doctrine orm:convert-mapping xml /var/www/doctrine-xml/

Entity class 'CompanyPerson' used in the discriminator map of class
'Doctrine\Tests\Models\Company\CompanyPerson' does not exist.

I'm able to convert all other models without any errors and didn't
make any changes to the test models from the current Git version. I
checked the discriminator definitions against documentation and it
seems ok. I have updated Doctrine 2 with all related packages today
form Git. Could you please let me know what am I doing wrong?

Thank you

[DDC-816] orm:schema-tool:create --dump-sql is preceded by invalid sql statements

Sat, 25 Sep 2010 06:12:34 +0000

I used to create the schema dump for non-doctrine users with:

bin/doctrine orm:schema-tool:create --dump-sql > sql/mysql.sql

The output is now preceded by the following warning:

ATTENTION: This operation should not be executed in an production enviroment.

I would suggest to direct this warning to stderr so we can easily create our dumps

[DDC-514] Default for discriminator column

Thu, 23 Sep 2010 17:10:53 +0000

The discriminator column should default to

@DiscriminatorColumn(name="dtype", type="string")

whenever the inheritance type is not NONE and there is no explicit @DiscriminatorColumn specified.

[DDC-630] Column aliases are not properly quoted

Thu, 23 Sep 2010 16:41:35 +0000

Sandbox

xml

<?xml version="1.0" encoding="UTF-8"?>
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping"  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"  xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd">
    <entity name="Entities\User" table="users">
        <id name="id" type="integer">
            <generator strategy="AUTO"/>
        </id>
        <field name="name" type="string" length="50" column="`test-name`"/>
    </entity>
</doctrine-mapping>

code

$user = new User;
$user->setName("tester");
$em->persist($user);
$em->flush();
$user2 = $em->getRepository('Entities\User')->find(1);

Expectected to get valid user entity
Got

Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-name1, t0.id AS id2 FROM users t0 WHERE t0.id = '1'' at line 1' in /Doctrine/DBAL/Connection.php:566
Stack trace:
#0 /lib/Doctrine/DBAL/Connection.php(566): PDOStatement->execute(Array)
#1 /lib/Doctrine/ORM/Persisters/BasicEntityPersister.php(493): Doctrine\DBAL\Connection->executeQuery('SELECT t0.`test...', Array)
#2 /lib/Doctrine/ORM/EntityRepository.php(106): Doctrine\ORM\Persisters\BasicEntityPersister->load(Array)
#3 /index.php(61): Doctrine\ORM\EntityRepository->find(1)

Loks like the problem is in the BasicEntityPersister::_getSelectColumnSQL

[DDC-573] Provide generic resetDQLPart() and resetDQLParts() methods in QueryBuilder

Thu, 23 Sep 2010 16:33:00 +0000

Given an existing instance of QueryBuilder, there appears to be no way to 'reset' most of the DQL parts. Usage example:

// reset single part
$queryBuilder->resetDQLPart('select');

// reset multiple parts
$queryBuilder->resetDQLParts(array('select', 'from'));

// reset all
$queryBuilder->resetDQLParts();

There are probably multiple use cases, but having the ability to reset parts of the DQL in QueryBuilder allows fine grained manipulation of an existing query (i.e. to build a two-part query to accomplish an efficient COUNT() query for pagination).

Suggested addition to QueryBuilder:

    /**
     * Reset DQL parts
     *
     * @param array $parts
     * @return QueryBuilder
     */
    public function resetDQLParts($parts = null)
    {
        if (is_null($parts)) {
            $parts = array_keys($this->_dqlParts);
        }
        foreach ($parts as $part) {
            $this->resetDQLPart($part);
        }
        return $this;
    }

    /**
     * Reset single DQL part
     *
     * @param string $part
     * @return QueryBuilder;
     */
    public function resetDQLPart($part)
    {
        if (is_array($this->_dqlParts[$part])) {
            $this->_dqlParts[$part] = array();
        } else {
            $this->_dqlParts[$part] = null;
        }
        $this->_state = self::STATE_DIRTY;
        return $this;
    }

[DDC-759] More than one many-to-many relations cannot be created using default values

Tue, 21 Sep 2010 13:17:23 +0000

An entity that has two many to many fields that referrence the same entity can't exist on its own, because ClassMetadataInfo uses the actual name of the referrenced entity to define joining table.

When there are for example Product and TextFile entities and you want to assigng the TextFile entitites to the Product entity firstly as descriptions (that are for example displayed on a product page) and secondly as simple text files (that can be downloaded on the product page, but are not displayed), ClassMetadataInfo tries to generate joining table called product_textfile for the descriptions field, then tries to generated joining table called product_textfile for the textfiles, but the latter will fail, because the product_textfile table already exists.

I propose that the table name generation strategy for many to many relations is changed so it will use the actual field name rather than the entity name. In the above example the joining tables would be product_descriptions and product_textFiles. I know that the standard naming conventions for database tables are not to use plurals, but I think it's better to use plurals and have those joining tables created automatically than not use them and have the user set names for the joining tables manually.

This new behaviour can be achieved by changing the file ClassMetadataInfo.php, line 837 from $targetShortName = substr($mapping['targetEntity'], strrpos($mapping['targetEntity'], '
') + 1); to $targetShortName = $mapping['fieldName'];

[DDC-809] ArrayHydrator and ObjectHydrator return different result sets for the same query

Mon, 20 Sep 2010 18:33:23 +0000

I have many to many relation for 2 entities.

ArrayHydrator and ObjectHydrator return different result sets for the same query. Because of some reasons ObjectHydrator mises 2 records.

Code snippet and SQL to create database structure:

CREATE TABLE IF NOT EXISTS `specification_value_test` (
  `specification_value_id` int(11) NOT NULL AUTO_INCREMENT,
  PRIMARY KEY (`specification_value_id`)
) ENGINE=InnoDB  DEFAULT CHARSET=latin1 AUTO_INCREMENT=96058 ;

INSERT INTO `specification_value_test` (`specification_value_id`) VALUES
(94506),
(94526),
(94564),
(94589),
(94593),
(94606),
(94607),
(94609),
(94711),
(94712),
(94780);


CREATE TABLE IF NOT EXISTS `variant_specification_value_test` (
  `variant_id` int(11) NOT NULL,
  `specification_value_id` int(11) NOT NULL,
  PRIMARY KEY (`variant_id`,`specification_value_id`),
  KEY `specification_value_id` (`specification_value_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

INSERT INTO `variant_specification_value_test` (`variant_id`, `specification_value_id`) VALUES
(545208, 94506),
(545209, 94506),
(545208, 94526),
(545209, 94526),
(545208, 94564),
(545209, 94564),
(545209, 94589),
(545209, 94593),
(545208, 94606),
(545209, 94606),
(545208, 94607),
(545209, 94607),
(545208, 94609),
(545209, 94609),
(545208, 94711),
(545208, 94712),
(545208, 94780),
(545209, 94780);

CREATE TABLE IF NOT EXISTS `variant_test` (
  `variant_id` int(11) NOT NULL AUTO_INCREMENT,
  PRIMARY KEY (`variant_id`)
) ENGINE=InnoDB  DEFAULT CHARSET=latin1 ROW_FORMAT=COMPACT AUTO_INCREMENT=545210 ;

INSERT INTO `variant_test` (`variant_id`) VALUES
(545208),
(545209);

/**
 * @Table(name="variant_test")
 * @Entity
 */
class Variant extends Base
{
    /**
     * @Column(name="variant_id", type="integer")
     * @Id
     * @GeneratedValue(strategy="AUTO")
     */
    protected $variantId;
    
    /**
     * @ManyToMany(targetEntity="SpecificationValue", inversedBy="Variants")
     * @JoinTable(name="variant_specification_value_test",
     *   joinColumns={
     *     @JoinColumn(name="variant_id", referencedColumnName="variant_id")
     *   },
     *   inverseJoinColumns={
     *     @JoinColumn(name="specification_value_id", referencedColumnName="specification_value_id")
     *   }
     * )
     */
    protected $SpecificationValues;
}

/**
 * @Table(name="specification_value_test")
 * @Entity
 */
class SpecificationValue
{
    /**
     * @Column(name="specification_value_id", type="integer")
     * @Id
     * @GeneratedValue(strategy="AUTO")
     */
    protected $specificationValueId;
    
    /**
     * @var Variant
     *
     * @ManyToMany(targetEntity="Variant", mappedBy="SpecificationValues")
     */
    protected $Variants;
}



$result = $em->createQueryBuilder()
    ->select('Variant, SpecificationValue')
    ->from('Variant', 'Variant')
    ->leftJoin('Variant.SpecificationValues', 'SpecificationValue')
    ->getQuery()
    ->getResult();
	
// returns 9 specification values for first variant and 7 specification values for second variant
\Doctrine\Common\Util\Debug($result, 4);

$em->createQueryBuilder()
    ->select('Variant, SpecificationValue')
    ->from('Variant', 'Variant')
    ->leftJoin('Variant.SpecificationValues', 'SpecificationValue')
    ->getQuery()
    ->getArrayResult();

// returns 9 specification values for first variant and 9 specification values for second variant
\Doctrine\Common\Util\Debug($result);

[DDC-739] DQL generates wrong SQL if id column has other name

Wed, 15 Sep 2010 16:27:21 +0000

I created many to many relation User <-> Group same as CmsUser and CmsGroup in test.
But by User class has another definition for ID column:

 
class User
{
    /**
     * @Id @Column(name="Id", type="integer")
     * @GeneratedValue
     */
    private $id;
   ...

My DQL is:

 
$queryBuilder->select("g")->from("Group", "g")->join("g.users", "u");

It generates wrong sql:

SELECT g0_.Id AS Id0, g0_.name AS name1 FROM groups g0_ INNER JOIN users_groups u2_ ON g0_. = u2_.group_id INNER JOIN users u1_ ON u1_. = u2_.user_id

As you see g0_. has ho id column.
If I removes name="Id" from id column definition

 
class User
{
    /**
     * @Id @Column(type="integer")
     * @GeneratedValue
     */
    private $id;
   ...

all works fine and generated sql is:

SELECT g0_.id AS id0, g0_.name AS name1 FROM groups g0_ INNER JOIN users_groups u2_ ON g0_.id = u2_.group_id INNER JOIN users u1_ ON u1_.id = u2_.user_id

[DDC-806] XSD requires an id element before the first field element

Wed, 15 Sep 2010 15:52:12 +0000

The entity element in doctrine-mapping.xsd requires an element id in front of the first element field.

This leads to invalid XML files, where a inherited class doesn't need an ID on its own, but inherits one from its parent.

In the examples in the documentation,
http://www.doctrine-project.org/projects/orm/2.0/docs/reference/xml-mapping/en#xml-element-reference:defining-fields
the code, too, has no id element in front of the first field elements.

A minimal example, showing the inheritance problem, too, is attached. The validation error occurs on the field element of the "Cat" entity.

[DDC-802] Missing variable $name in XmlExporter

Wed, 15 Sep 2010 13:13:27 +0000

At line 112 http://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Tools/Export/Driver/XmlExporter.php#L112 is required variable $name. This variable should be replaced by $unique['name']. And before this line should be test if(isset($unique['name'])).

[DDC-749] positional query parameters throwing a QueryException

Wed, 15 Sep 2010 05:02:42 +0000

I get the following exception:
"Invalid parameter number: number of bound variables does not match number of tokens"
when executing the following Doctrine query:

$em = $this->_getEntityManager();
$query = $em->createQuery('select e from Domain_Entity_Country e where e.alpha2Code like ?1');
$query->setParameters(array(1 => 'A%'));

[DDC-762] undefined index errors when the join-column of a relation is NULL

Tue, 14 Sep 2010 09:49:41 +0000

When the value of the join-column of a relation is NULL, "undefined index" errors are thrown in UnitOfWork::createEntity().

The problem is in BasicEntityPersister::_processSQLResult() ; the attached diff fixed the problem for me.

I reproduce the problem with a code like this :
This triggers an error when the value of the column b_id is NULL.

<?php

class A {
  @Column(name="b_id", type="integer")
  private $bId;

  @OneToOne(targetEntity="B")
  @JoinColumn(name="b_id", referencedColumnName="id")
  private $b;
}

$entityManager->find('A', 1);
?>

[DDC-761] Associations between string fields result in mismatched column definitions on owning side

Duplicate — Sun, 12 Sep 2010 16:34:48 +0000

Using the latest master from github, defining a one-to-one or many-to-one relationship where the inverse side is a string of a specific length (i.e. other than the default 255 chars), the owning side column definition becomes a VARCHAR(255) (at least in MySQL) regardless of the length of the column on the other side of the relationship. I would expect the correct behavior would be for the column definitions to match on both sides. For example:

/** @Entity */
class foo {

    /**
     * @Id @Column(type="string", length=5)
     */
    protected $id;
}

/** @Entity */
class bar {
    /**
     * @Id @Column(type="integer")
     */
    protected $id;

    /**
     * @OneToOne(targetEntity="Foo")
     * @JoinColumn(name="foo_id", referencedColumnName="id")
     */
    protected $foo;
}

/** @Entity */
class baz {
    /**
     * @Id @Column(type="integer")
     */
    protected $id;

    /**
     * @ManyToOne(targetEntity="Foo")
     * @JoinColumn(name="foo_id", referencedColumnName="id")
     */
    protected $foo;
}

Resulting SQL from schematool:

CREATE TABLE foo (id VARCHAR(5) NOT NULL, PRIMARY KEY(id)) ENGINE = InnoDB;
CREATE TABLE bar (id INT NOT NULL, foo_id VARCHAR(255) DEFAULT NULL, UNIQUE INDEX bar_foo_id_uniq (foo_id), PRIMARY KEY(id)) ENGINE = InnoDB;
CREATE TABLE baz (id INT NOT NULL, foo_id VARCHAR(255) DEFAULT NULL, PRIMARY KEY(id)) ENGINE = InnoDB;
ALTER TABLE bar ADD FOREIGN KEY (foo_id) REFERENCES foo(id);
ALTER TABLE baz ADD FOREIGN KEY (foo_id) REFERENCES foo(id)

Expected result:

CREATE TABLE foo (id VARCHAR(5) NOT NULL, PRIMARY KEY(id)) ENGINE = InnoDB;
CREATE TABLE bar (id INT NOT NULL, foo_id VARCHAR(5) DEFAULT NULL, UNIQUE INDEX bar_foo_id_uniq (foo_id), PRIMARY KEY(id)) ENGINE = InnoDB;
CREATE TABLE baz (id INT NOT NULL, foo_id VARCHAR(5) DEFAULT NULL, PRIMARY KEY(id)) ENGINE = InnoDB;
ALTER TABLE bar ADD FOREIGN KEY (foo_id) REFERENCES foo(id);
ALTER TABLE baz ADD FOREIGN KEY (foo_id) REFERENCES foo(id)

This bug is possibly related to ~~DDC-755~~ except these associations don't involve integers.

[DDC-748] BasicEntityPersister::refresh() broken with ManyToOne relationships

Sun, 12 Sep 2010 15:44:54 +0000

ManyToOne relationships are defined as an owning side of OneToOne relationships. This makes BasicEntityPersister to believe that it is refreshing a OneToOne relationship, resulting in the inverse end (collection) to be replaced with the entity being refreshed rather than a collection. (in BasicEntityPersister.php:662 in Beta 3)

[DDC-755] Length of String column in a many to many bi-directional is 255 chars

Duplicate — Sun, 12 Sep 2010 12:56:16 +0000

As per discussion with Guilherme, I'm opening a ticket for when a bi-directional many to many relationship is established with one side having a string as its primary key, and the other having an integer.

It appears as though the ORM/DBAL are getting confused as to what the length of the invisible join table column between them should be.

In the case of my example models, when I use SchemaTool to generate the tables, it creates a BlogPost table with the column blog_name with a length of 255 characters (it should be 40). When I use the SchemaTool to generate an update to the table, it tells me it wants to modify the column to be 255 characters in spite the facts that:

1) It already is.
2) It's wrong.