Doctrine Project

[DDC-2519] Unable to DQL SELECT PARTIAL entity with association identifier

Wed, 19 Jun 2013 23:37:45 +0000

Entity\Person: id, name, etc
Entity\User: person, admin, etc (person is the primary and association key)

Trying DQL:
SELECT PARTIAL u.

{person,admin}

FROM Entity\User u
will fail.

[DDC-2518] [GH-704] added badges stable release and total downloads

Wed, 19 Jun 2013 18:38:49 +0000

This issue is created automatically through a Github pull request on behalf of liuggio:

Url: https://github.com/doctrine/doctrine2/pull/704

Message:

you can see the preview here: https://github.com/liuggio/doctrine2/tree/patch-1

[DDC-2517] [GH-703] Clear visitedCollections

Wed, 19 Jun 2013 13:35:15 +0000

This issue is created automatically through a Github pull request on behalf of shulcsm:

Url: https://github.com/doctrine/doctrine2/pull/703

Message:

Visited collections are cleared only in commit(). Commit clears up only if it actually has something to do. Processing large amounts of records without changing them cause visitedCollections to grow without any way of clearing.

[DDC-2516] Undefined offset in ObjectHydrator while working with iterableResult

Wed, 19 Jun 2013 12:20:16 +0000

Following this documentation page http://doctrine-orm.readthedocs.org/en/2.0.x/reference/batch-processing.html#iterating-large-results-for-data-processing I tried to create a batch process on 75k entities. But an error came in the ObjectHydrator on line 511 there's an Undefined offset. Now, i just use the SimpleObjectHydrator and it solve the problem. but i'm wondering if it's a real bug or just a miss use of Doctrine.
Reproduce this error could be hard so ask if you want me to give you more informations about it.

[DDC-2515] Schema tool ignores index names in mapping file and uses generated name

Tue, 18 Jun 2013 12:17:50 +0000

I have defined an index on a foreign key colum in my .dcm.xml mapping file:

<indexes>
      <index name="ix_date_created__client_id" columns="date_created,client_id"/>
      <index name="ix_user_id" columns="user_id"/>
</indexes>

However, the resulting CREATE TABLE statement includes:

    INDEX IDX_4848DD9FA76ED395 (user_id), 
    INDEX IDX_4848DD9F4239E22F (accessgroup_id), 
    INDEX IDX_4848DD9FD2112630 (usergroup_id), 
    INDEX ix_date_created__client_id (date_created, client_id),

So Doctrine seems to be auto-generating indexes for all foreign key columns. I'm assuming this is a feature, even though I'd argue that there are real-life examples where the mere presence of a foreign key constraint does not justify indexing that column.

Anyway, the expected behavior is that Doctrine does not replace existing indexes with generated ones. I will attach a failing test case unless this bug is immediately dismissed as wontfix.

[DDC-2513] [GH-702] ANSI compliant quote strategy

Tue, 18 Jun 2013 02:03:12 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/702

Message:

[DDC-2512] Lifecycle callbacks

Mon, 17 Jun 2013 23:18:32 +0000

Hi,

I would like to know if the only one thing i need to save an entity in a lifecycle listener is the $unitOfWork->scheduleForInsert($entity).

My requirement is to save a log in every action in the DB. So i need to save the old entity and the new entity in the DB. I am making this in the preupdate listener:

$log = $this->util->createLog($entity->serialize(),"Current Object");
$unitOfWork = $this->wrapped->getUnitOfWork();
$unitOfWork->scheduleForInsert($log);

But this log is never saved. Do i need something else to persist this new entity?.

Thanks for your help.

[DDC-2511] [GH-701] list_bugs.php needs to call to getters for protected vars

Mon, 17 Jun 2013 09:41:44 +0000

This issue is created automatically through a Github pull request on behalf of rbroen:

Url: https://github.com/doctrine/doctrine2/pull/701

Message:

list_bugs.php needs to call to getters for protected vars. This was changed in the "getting-started" code repository, but not in the "getting-started" tutorial.

[DDC-2510] [GH-700] Update getting-started.rst

Mon, 17 Jun 2013 08:40:10 +0000

This issue is created automatically through a Github pull request on behalf of rbroen:

Url: https://github.com/doctrine/doctrine2/pull/700

Message:

The tutorial assumes Doctrine 2.4

[DDC-2509] Add CLI detection for the APC check on Console cache commands

Mon, 17 Jun 2013 08:41:24 +0000

There is some instanceof checks on the \Doctrine\ORM\Tools\Console\Command\ClearCache* commands to detect if APC is being used, they were introduced here: https://github.com/doctrine/doctrine2/commit/8efae0b232210b27200f2709e7fcb24c7f02c5de

I would like to know if it's possible to add a CLI check too, something like:

if ($cacheDriver instanceof Cache\ApcCache && PHP_SAPI === 'cli' )

Yeah, I know that those are CLI commands, and so the check looks like unecessary, however, in the particular case that I found it's necessary, I'm running the commands under an WebUI:
Before the modification:

After:

[DDC-2508] [GH-699] commented a change that was ahead of stable; added calls to getters

Sun, 16 Jun 2013 17:51:51 +0000

This issue is created automatically through a Github pull request on behalf of rbroen:

Url: https://github.com/doctrine/doctrine2/pull/699

Message:

CreateHelperSet appears to be a method in 2.4, which is not stable yet and does not correspond with this 2.3 tutorial.
list_bugs.php was trying to get protected vars.

[DDC-2507] [GH-698] Fix for [DDC-2506] CTI JOINs and WITH conditionals

Fri, 14 Jun 2013 16:34:33 +0000

This issue is created automatically through a Github pull request on behalf of mattjanssen:

Url: https://github.com/doctrine/doctrine2/pull/698

Message:

http://www.doctrine-project.org/jira/browse/DDC-2506

Moved the `SqlWalker::walkConditionalExpression()` out of `walkJoin()` and into `walkJoinAssociationDeclaration()` after the base class JOIN but *before* the `_generateClassTableInheritanceJoins()`, thus allowing WITH conditions in Class Table Inheritance joins to apply correctly.

On a side note, I'm not able to get phpunit to run (even on a clean Master) so I'm leaving the testing up to Travis.

[DDC-2506] WITH Conditionals on Class Table Inheritance LEFT JOINs are inserted incorrectly

Fri, 14 Jun 2013 16:46:34 +0000

The following JOIN

JOIN c.ctiRelationship cti WITH cti.id IN (42)

generates unexpected SQL

LEFT JOIN class_base p1_ ON u1_.cti_id = p1_.id 
LEFT JOIN class_child1 p2_ ON p1_.id = p2_.id
LEFT JOIN class_child2 p3_ ON p1_.id = p3_.id AND (p1_.id IN (42))

when it SHOULD be generating

LEFT JOIN class_base p1_ ON u1_.cti_id = p1_.id AND (p1_.id IN (42)) 
LEFT JOIN class_child1 p2_ ON p1_.id = p2_.id
LEFT JOIN class_child2 p3_ ON p1_.id = p3_.id

[DDC-2505] [GH-697] Fix phpDoc syntax in ClassMetadataInfo.php

Fri, 14 Jun 2013 13:57:21 +0000

This issue is created automatically through a Github pull request on behalf of michaelperrin:

Url: https://github.com/doctrine/doctrine2/pull/697

Message:

[DDC-2504] [GH-696] extra lazy joined test

Fri, 14 Jun 2013 07:49:08 +0000

This issue is created automatically through a Github pull request on behalf of Padam87:

Url: https://github.com/doctrine/doctrine2/pull/696

Message:

Hi,

This is just a bug report, not an actual PR, you don't have to merge.

When you have a JOINED inheritance, and you have another class, which is related to the parent class of the inheritance, and you only have an association for one of the child classes, EXTRA_LAZY fetch mode creates a fatal error, because it is not joining the parent table to the count query.

There are many ways around this fortunately, but I thought I should report it anyway.

[DDC-2503] [GH-695] Implemented support for RepositoryFactory.

Tue, 18 Jun 2013 03:14:47 +0000

This issue is created automatically through a Github pull request on behalf of guilhermeblanco:

Url: https://github.com/doctrine/doctrine2/pull/695

Message:

This allows anyone to override the default behavior to load Repositories.

[DDC-2502] [GH-694] [DDC-2478] Support null association comparison

Fri, 14 Jun 2013 04:27:46 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/694

Message:

http://www.doctrine-project.org/jira/browse/DDC-2478

[DDC-2501] [GH-693] Adding failing test for DDC-2214

Wed, 12 Jun 2013 19:00:41 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/693

Message:

Parameters being bound to an SQL query should have the same type as
the identifier of the objects being bound to the placeholders of a
DQL query - this is currently broken with proxies, as this test
demonstrates.

This is a demonstration of ~~DDC-2214~~(http://www.doctrine-project.org/jira/browse/DDC-2214)

[DDC-2500] [GH-692] Query\Parser: support for functions in ORDER BY clause

Wed, 12 Jun 2013 13:13:12 +0000

This issue is created automatically through a Github pull request on behalf of Slamdunk:

Url: https://github.com/doctrine/doctrine2/pull/692

Message:

[DDC-2499] [GH-691] IDENTITY function fix for Joined Inheritance

Wed, 12 Jun 2013 08:03:17 +0000

This issue is created automatically through a Github pull request on behalf of 51systems:

Url: https://github.com/doctrine/doctrine2/pull/691

Message:

In a joined inheritance scenario, the identity function implementation assumed the foreign key column was on the table corresponding to the (sub)class named in the select statement. If the relation was on a super-class incorrect sql was generated.

[DDC-2498] [GH-690] [DDC-2494] Apply type conversion to meta columns

Wed, 12 Jun 2013 18:59:07 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/690

Message:

http://www.doctrine-project.org/jira/browse/DDC-2494

[DDC-2497] When trying to join single-table inheritance classes in DQL or QueryBuilder, Doctrine creates incorrect SQL

Tue, 11 Jun 2013 00:09:10 +0000

When writing a DQL query joining to inherited subclasses, Doctrine incorrectly injects the discriminator in the WHERE clause instead of in the JOIN, where it should be.
Example: 2 classes extend Person via JOINED table inheritance: EmployedPerson and UnemployedPerson. I want to create a query where I pull separate class-specific properties form each class:

SELECT p FROM Person p
LEFT JOIN EmployedPerson ep WITH ep=p
LEFT JOIN UnemployedPerson up WITH up=p

The SQL from this will look something like:
SELECT .... FROM person p
LEFT JOIN person ep ON(ep.id=p.id)
LEFT JOIN person up ON(up.id=p.id)
WHERE ep.discrim IN('employed') AND up.discrim IN('unemployed')

The problem is this query will produce no results if one of the subclasses have no results.

The fix would be putting the discriminator in the JOIN so the sql would be:

SELECT .... FROM person p
LEFT JOIN person ep ON(ep.id=p.id AND ep.discrim IN('employed'))
LEFT JOIN person up ON(up.id=p.id AND up.discrim IN('unemployed'))

I will try to create a unit test based on the current ones and upload it.

[DDC-2496] Unexpected behaviour flushing single entity

Mon, 17 Jun 2013 18:03:51 +0000

The following works as expected:
$existingElement = $repository->find(1);
$existingElement->setSomething('foo');
$newElement = new Element('bar');
$em->persist($newElement);
$em->flush($newElement);
// The new element is added and the existing is not modified

The following does not:
$existingElement = $repository->find(1);
$em->remove(existingElement);
$newElement = new Element('bar');
$em->persist($newElement);
$em->flush($newElement);
// The new element is added and the existing is deleted (i didnt flush THAT element)

The following does not:
$newElement2 = new Element('foo');
$em->persist($newElement2);
$newElement = new Element('bar');
$em->persist($newElement);
$em->flush($newElement);
// Both elements are persisted, even if I only flushed $newElement

[DDC-2495] Partial objects not working with STI

Tue, 11 Jun 2013 09:17:09 +0000

When I try to create a query retrieving partial objects of a root class in single table inheritance hierarchy, the resulting SQL includes all fields from the whole class hierarchy.

DQL:
SELECT partial v.

{id, setupDate, flipDate}

FROM VIB\FliesBundle\Entity\Vial v WHERE v.id IN (1,2,3,4,5,6,7,8,9,10)

SQL:
SELECT v0_.setupDate AS setupDate0, v0_.flipDate AS flipDate1, v0_.id AS id2, v0_.type AS type3, v0_.parent_id AS parent_id4, v0_.position_id AS position_id5, v0_.prevPosition_id AS prevPosition_id6, v0_.incubator_id AS incubator_id7, v0_.stock_id AS stock_id8, v0_.male_id AS male_id9, v0_.virgin_id AS virgin_id10, v0_.targetStock_id AS targetStock_id11, v0_.targetStockVial_id AS targetStockVial_id12 FROM Vial v0_ WHERE (v0_.id IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 10)) AND v0_.type IN ('vial', 'stock', 'cross', 'injection')

[DDC-2494] Proxy getId not invoke convertToPHPValue on custom type

Wed, 12 Jun 2013 19:04:41 +0000

I have a custom type tinyint:
https://gist.github.com/entering/3503d7458e5fbe2f6e02

I was using it a lot and when I updated to doctrine 2.4 beta it break some stuff. At the time i turn all on smallint and solve the problem, now I had time to look into it.

Example, entity Currency:

    /**
     * @var integer
     *
     * @ORM\Column(name="id", type="tinyint", nullable=false, options={"unsigned": true})
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /**
     * @ORM\Column(name="temp", type="tinyint", nullable=false)
     */
    protected $temp;

Entity Campaign:

    /**
     * @var Currency
     *
     * @ORM\ManyToOne(targetEntity="Currency", inversedBy="campaigns")
     * @ORM\JoinColumns({
     *   @ORM\JoinColumn(name="currency_id", referencedColumnName="id", nullable=false)
     * })
     */
    protected $currency;

When i have this piece of code:

var_dump($campaign->getCurrency()->getId());
var_dump($campaign->getCurrency()->getTemp());

I get:
string(1) "1"
int(5)

If I turn id into small int:
int(1)
int(5)

If I switch the order to:

var_dump($campaign->getCurrency()->getTemp());
var_dump($campaign->getCurrency()->getId());

As expected:
int(5)
int(1)

If I place a var_dump on convertToPHPValue I can see that is not being called on getId when getId is lazy.

This looks like a bug introduced when getId started being lazy to save queries.

[DDC-2493] [GH-689] [WIP][DDC-1995 ] Support metadata class as parameter for instance of expression

Fri, 7 Jun 2013 22:02:03 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/689

Message:

Hi guys,

This is a possible solution for ~~DDC-1995~~(http://www.doctrine-project.org/jira/browse/DDC-1995),

I've attempted some diferent ways to fix this problem without success.
Anyway, RSM still looks like the wrong place to parameters mapping.

[DDC-2492] [GH-688] Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration

Wed, 12 Jun 2013 19:05:56 +0000

This issue is created automatically through a Github pull request on behalf of johnbrown:

Url: https://github.com/doctrine/doctrine2/pull/688

Message:

Based on:
http://www.doctrine-project.org/jira/browse/DDC-1845
https://github.com/doctrine/doctrine2/commit/cb72219b118c158c9b5344c4b81ff2b1a9149ab0

[DDC-2491] [GH-687] Fixed rendering

Thu, 6 Jun 2013 08:53:19 +0000

This issue is created automatically through a Github pull request on behalf of mnapoli:

Url: https://github.com/doctrine/doctrine2/pull/687

Message:

Fixed some broken rendering on http://docs.doctrine-project.org/en/latest/reference/yaml-mapping.html

[DDC-2490] EAGER associations are sometimes fetched through a Proxy non-eagerly

Thu, 6 Jun 2013 03:43:24 +0000

In the UOW deferred eager load only works for single identifier classes. But the implementation of deferred eager load uses a Proxy which lazy loads. A boolean condition must be added to only use this deferred approach for non-EAGER relationships.

[DDC-2489] Missing semicolon in schema update tool, using dump-sql argument

Wed, 12 Jun 2013 04:26:25 +0000

When executing the schema-tool update script, using the --dump-sql argument (e.g. "app/console doctrine:schema:update --dump-sql" in a symfony2 project), the semicolon behind the last query is missing.

[DDC-2488] [GH-686] [DDC-2475] Replace OrderBy mapping when OrderByClause is given

Wed, 5 Jun 2013 14:10:44 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/686

Message:

http://www.doctrine-project.org/jira/browse/DDC-2475

[DDC-2487] UnitOfWork::getEntityIdentifier() contains objects when custom mapping types are part of an entity's identity

Tue, 4 Jun 2013 14:42:17 +0000

I'm using a custom mapping type for a LocalDate class (mapped to a DATE field in the MySQL database).

Given the following entity:

/**
 * @Entity
 */
class Timeslot
{
    /**
     * @Id
     * @ManyToOne(targetEntity="Restaurant")
     */
    protected $restaurant;

    /**
     * @Id
     * @Column(type="localdate")
     */
    protected $date;
}

When var_export() -ing the result of UnitOfWork::getEntityIdentifier() on an instance of this class, the result is similar to:

array(
	'restaurant' => '5',
	'date' => LocalDate::__set_state(array('year' => 2013, 'month' => 6, 'day' => 26))
)

This is a bit weird, because as far as I understand it, it should return the identity as it maps to database fields:

array(
	'restaurant' => '5',
	'date' => '2013-06-26'
)

If we take the $restaurant example, it returns the restaurant ID, and not the Restaurant entity, so my opinion is that it should be the same for $date.

Shouldn't the UnitOfWork use Type::convertToDatabaseValue() on custom mapping types to infer their value, when computing the identity of an entity?

[DDC-2486] Getting started does not work with current release

Tue, 11 Jun 2013 17:02:36 +0000

The tutorial states: "This tutorial assumes you work with Doctrine 2.3 and above. Some of the code will not work with lower versions."

I'm using 2.3.4

When running "php vendor/bin/doctrine orm:schema-tool:create"

this happens:

PHP Fatal error: Call to undefined method Doctrine\ORM\Tools\Console\ConsoleRunner::createHelperSet() in /var/www/project/cli-config.php on line 5
PHP Stack trace:
PHP 1.

{main}() /var/www/project/vendor/doctrine/orm/bin/doctrine:0
PHP 2. include() /var/www/project/vendor/doctrine/orm/bin/doctrine:4
PHP 3. require() /var/www/project/vendor/doctrine/orm/bin/doctrine.php:31

Fatal error: Call to undefined method Doctrine\ORM\Tools\Console\ConsoleRunner::createHelperSet() in /var/www/project/cli-config.php on line 5

Call Stack:
0.0001 619840 1. {main}

() /var/www/project/vendor/doctrine/orm/bin/doctrine:0
0.0003 632072 2. include('/var/www/project/vendor/doctrine/orm/bin/doctrine.php') /var/www/project/vendor/doctrine/orm/bin/doctrine:4
0.0012 730208 3. require('/var/www/project/cli-config.php') /var/www/project/vendor/doctrine/orm/bin/doctrine.php:31

This is because some commits are not yet in the release. The current GIT version probably works but is not an option for me.

[DDC-2485] [GH-685] Functional ticket for DDC-2484

Mon, 3 Jun 2013 22:58:57 +0000

This issue is created automatically through a Github pull request on behalf of TomHAnderson:

Url: https://github.com/doctrine/doctrine2/pull/685

Message:

This shows how the postLoad can change an entity but associations are not passed through postLoad

[DDC-2484] Lazy loaded associated entities do not trigger the postLoad event

Thu, 13 Jun 2013 13:55:17 +0000

An entity retrieved with $entity = $em->find will correctly trigger the postLoad event but an entity associated with that entity $association = $entity->association which is lazy loaded will retrieve and return the associated entity without triggering postLoad. Eager loading does follow the lifecycle path of triggering postLoad.

Functional Test:
https://github.com/doctrine/doctrine2/pull/685

[DDC-2483] [GH-684] Cancel load entity exception

Mon, 10 Jun 2013 17:09:23 +0000

This issue is created automatically through a Github pull request on behalf of TomHAnderson:

Url: https://github.com/doctrine/doctrine2/pull/684

Message:

Gives the developer an exception to throw in postLoad which will cancel the loading of the entity into the EntityManager

[DDC-2482] [GH-683] Explicitely state what the problem is

Mon, 3 Jun 2013 10:38:08 +0000

This issue is created automatically through a Github pull request on behalf of greg0ire:

Url: https://github.com/doctrine/doctrine2/pull/683

Message:

People like me think the problem is that there is no association
mapping, when the problem in fact could be that there also is a field
mapping on the property.
This message makes it clearer why we are getting an error message.

[DDC-2481] [GH-682] onLoad Event

Mon, 3 Jun 2013 20:26:27 +0000

This issue is created automatically through a Github pull request on behalf of TomHAnderson:

Url: https://github.com/doctrine/doctrine2/pull/682

Message:

This PR implements the onLoad event which provides a mutable entity and entity load cancellation.

[DDC-2480] Filter stops working after upgrade to Symfony 2.3rc1

Thu, 13 Jun 2013 15:30:32 +0000

In our project we have two associated entities "portal" and "object_data". To get all object_data of an object that belong to a portal, we use filtering code like this since symfony 2.0:

        $object_data = $object->getObjectData()->filter(
            function ($current_object_data) use ($portal) {
                return $current_object_data->getPortal() === $portal;
            }
        )->first();

Up to now, this worked just fine. When upgrading from Symfony 2.2 to 2.3rc1, this code stopped working, the comparison will always be false. I also received a PHP error message in another place about the portal entity not being convertible to a string:

PHP Catchable fatal error:  Object of class ...\\Entity\\Portal 
could not be converted to string in /.../vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php on line 1211

I assume these problems are related. Since the code worked just fine from Symfony 2.0 to 2.2, I assume that this might be a regression. Could you kindly take a look at this and perhaps let me know if I did anything wrong?

We use direct entity comparisons in many places in our code, rather than comparing the ids of the entities directly, and so far it worked just fine.

Thanks a lot!

[DDC-2479] Add possibility to only query for root entities in a class table inheritance

Thu, 30 May 2013 19:32:05 +0000

It is not possible to query for root/topmost class entities (only) in a class table inheritance situation without extra JOINs to the child entities/classes.

E.g.
Person -> root entity/class
Employee -> child entity/class extending Person

The DQL:

SELECT p
FROM Person p;

also joins Employee even though I am not interested in Employee properties.

Person is the base class in this use case and it should be possible to only retrieve those information. Thinking of OOP, if I instanciate Person I do not have any reference to its child either.
This is especially useful for large base tables where you want to only retrieve base information without inferring the childs.

IMO the DQL should be modified to allow selecting root/base information only, similar to the INSTANCE OF operator, that allows selecting specific childs only.

[DDC-2478] PersisterException when matching Criteria expression isNull to ArrayCollection

Fri, 14 Jun 2013 04:26:40 +0000

    /**
     * @ORM\ManyToOne(targetEntity="ClubBoardPost", inversedBy="children")
     * @var ClubBoardPost
     */
    protected $parent;

$criteria = Criteria::create()->where(Criteria::expr()->isNull('parent'));
$this->boardPosts->matching($criteria);

[output]
Cannot match on Fubles\CoreBundle\Entity\ClubBoardPost::parent with a non-object value. Matching objects by id is not compatible with matching on an in-memory collection, which compares objects by reference.

[first analysis]
@SqlExpressionVisitor:69 It seems like this check pretends that the value must be an object, maybe do you need to exclude NULL values only if association is nullable?

[DDC-2477] [GH-681] Sequence generator fix

Wed, 29 May 2013 17:41:46 +0000

This issue is created automatically through a Github pull request on behalf of lighthart:

Url: https://github.com/doctrine/doctrine2/pull/681

Message:

$this->_sequenceName=$em->getClassMetadata(get_class($entity))->sequenceGeneratorDefinition['sequenceName'];

The sequence generator does not read the class metadata, so if there is table remapping via event listeners, any new entity won't have the appropriate changes in table names.

This pull request adds a remap the Sequence Generator to read the class metadata to determine the sequence name if there is an entity passed to the generate function.

Tests: 1854, Assertions: 6224, Skipped: 96.

[DDC-2476] [GH-680] [wip] better reverse engineers the mapping metadata from a database

Wed, 12 Jun 2013 05:56:36 +0000

This issue is created automatically through a Github pull request on behalf of bronze1man:

Url: https://github.com/doctrine/doctrine2/pull/680

Message:

The problem:
1.use symfony2 doctrine:mapping:import from msyql database to annotation
2.use symfony2 doctrine:schema:update will see a lot of sql update about just import database schema.
3.this PR fix eliminate some of those sql update...

has fixed problem:

column default
column unsigned (add test)
column comment
column type decimal with precision and scale
table with simple index
table with unique index

[DDC-2475] ORDER BY on existing column is added, not replaced

Wed, 5 Jun 2013 14:09:12 +0000

It seems that if an entity has an existing ORDER BY clause on a relation that any subsequent ORDER BYs on that field are added instead of replaced.

For example, I have two entities: Person and Membership. Person.Memberships has the following clause specified:

@ORM\OrderBy(

{"createDate" = "DESC"}

)

I also have a repository method that uses this relationship and sets the following DQL:

SELECT person, m
FROM \Company\Person person
JOIN person.memberships m
ORDER BY m.createDate ASC

I would expect this query to replace the existing ORDER BY with ORDER BY m.createDate ASC. Instead, it adds the ORDER BY to the existing one, which makes the end result: ORDER BY m.createDate ASC, m.createDate DESC.

This is obviously causing an issue since you can't sort by the same column in different order. Is this behavior by design? If so, is there a way to override the existing ORDER BY setting?

[DDC-2474] [GH-679] Fix getting started doc to work with current version

Tue, 28 May 2013 07:38:03 +0000

This issue is created automatically through a Github pull request on behalf of ajgarlag:

Url: https://github.com/doctrine/doctrine2/pull/679

Message:

The `cli-config.php` example provided at the getting started tutorial does not work with doctrine 2.4.

[DDC-2473] [GH-678] Fix an instance of doubled words in the docs

Mon, 27 May 2013 15:52:18 +0000

This issue is created automatically through a Github pull request on behalf of jbafford:

Url: https://github.com/doctrine/doctrine2/pull/678

Message:

[DDC-2472] [GH-677] Type fix in ORM\PersistentCollection

Mon, 27 May 2013 15:52:26 +0000

This issue is created automatically through a Github pull request on behalf of michaldudek:

Url: https://github.com/doctrine/doctrine2/pull/677

Message:

The ```ORM\PersistentCollection``` class accepts anything as 3rd argument to its constructor while it should be either array or ```Collection``` object. The ```$this->coll``` phpdoc says that it's a ```Collection``` while the constructor's phpdoc says it's an array.

The class assumes ```Collection``` but there isn't any type check at all. I have added conversion of array into ```ArrayCollection``` in the constructor as in some (very unclear) cases it likes to die with a fatal error:

```Fatal error: Call to a member function add() on a non-object in Doctrine/ORM/PersistentCollection.php on line 169```

[DDC-2471] Incorrect EQ/NEQ null handling of criteria

Sun, 26 May 2013 07:17:03 +0000

Incorrect EQ/NEQ null handling of criteria

[DDC-2470] Sql Server error in createQuery using ORDER BY and setMaxResults

Fri, 7 Jun 2013 21:34:56 +0000

Important: This issue only affect to 2.4.* versions

When executing

$query = $em->createQuery('
SELECT m.nombre
     , m.fechainicio
     , m.fechafin 
  FROM Bundle:Medicion m
  JOIN m.estudio e
  JOIN e.cliente c
  JOIN c.usuarios u
 WHERE u.id = :id
 ORDER BY m.fechainicio DESC
')
->setMaxResults(12);

Get the following error:

An exception occurred while executing '
SELECT * 
  FROM (
           SELECT m0_.NOMBRE AS NOMBRE0
                , m0_.FECHAINICIO AS FECHAINICIO1
                , m0_.FECHAFIN AS FECHAFIN2
                , ROW_NUMBER() OVER (ORDER BY FECHAINICIO1 DESC) AS doctrine_rownum 
             FROM MEDICION m0_ WITH (NOLOCK) 
            INNER JOIN ESTUDIO e1_ 
               ON m0_.ESTUDIO_ID = e1_.ID 
            INNER JOIN CLIENTE c2_ 
               ON e1_.CLIENTE_ID = c2_.ID 
            INNER JOIN USUARIO u3_ 
               ON c2_.ID = u3_.CLIENTE_ID WHERE u3_.ID = ?
       ) AS doctrine_tbl 
 WHERE doctrine_rownum BETWEEN 1 AND 12
' with params [2]:

SQLSTATE[42S22]: [Microsoft][SQL Server Native Client 11.0][SQL Server]El nombre de columna 'FECHAINICIO1' no es válido.

Attached the BD model

Added extra info!

Engine version: Sql server 2008 R2

When executing this SQL (returned by doctrine error) on Management Studio

SELECT * FROM (SELECT m0_.NOMBRE AS NOMBRE0, m0_.FECHAINICIO AS FECHAINICIO1, m0_.FECHAFIN AS FECHAFIN2, ROW_NUMBER() OVER (ORDER BY FECHAINICIO1 DESC) AS doctrine_rownum FROM MEDICION m0_ WITH (NOLOCK) INNER JOIN ESTUDIO e1_ ON m0_.ESTUDIO_ID = e1_.ID INNER JOIN CLIENTE c2_ ON e1_.CLIENTE_ID = c2_.ID INNER JOIN USUARIO u3_ ON c2_.ID = u3_.CLIENTE_ID WHERE u3_.ID = 12) AS doctrine_tbl WHERE doctrine_rownum BETWEEN 1 AND 12

Get the following error:

El nombre de columna 'FECHAINICIO1' no es válido. ('FECHAINICIO1' is invalid)

But if change "FECHAINICIO1"

... OVER (ORDER BY FECHAINICIO1 DESC) AS doctrine_rownum FROM...

by this

... OVER (ORDER BY m0_.FECHAINICIO DESC) AS doctrine_rownum FROM...

Don't get error

regards
Jonnatan Oyarzún

[DDC-2469] SQLite handling for ENUM-Fields

Fri, 24 May 2013 07:35:54 +0000

SQLite doesn't support ENUMS!

But when I try create the schema of the following Entity Doctrine generates this "CREATE TABLE" - Statement:

CREATE TABLE Entity ([...] NOT NULL, taxation ENUM('incl', 'excl'), maxNumbe[...]

class Entity {
...

    /**
     * @var string
     *
     * @ORM\Column(type="string", columnDefinition="ENUM('incl', 'excl')")
     */
    private $taxation = self::TAXATION_INCL;

...
}

Produces this error:

SQLSTATE[HY000]: General error: 1 near "'incl'": syntax error'

[DDC-2468] xml schema incomplete

Sun, 26 May 2013 04:44:59 +0000

while writing the schema for phpcr-odm i noticed that the orm schema seems to miss some things. not sure if they are just missing in the schema but supported by the xml driver or if the xml driver also misses those:

cascade-type is missing

<xs:element name="cascade-detach" type="phpcr:emptyType" minOccurs="0"/>

lifecycle-callback-type is missing a bunch of callbacks:

<xs:enumeration value="onFlush"/>
<xs:enumeration value="postFlush"/>
<xs:enumeration value="onClear"/>
<xs:enumeration value="loadClassMetadata"/>

[DDC-2467] Incorrect work with default values, indexes, autoincrement (patch attached)

Tue, 28 May 2013 17:02:36 +0000

If you use in your MySQL database default values, indexes or string primary key, you get incorrect mapping by mapping generator. For get it - just use in database one or more from listed abilities, generate mapping for that and then try to dump-sql with schema-tool:update.

Hope you fix it. Tnx!

[DDC-2466] [GH-676] Update UnitOfWork.php

Wed, 22 May 2013 00:44:28 +0000

This issue is created automatically through a Github pull request on behalf of Kynareth62:

Url: https://github.com/doctrine/doctrine2/pull/676

Message:

Here, if a field (type date or datetime) is defined as id, I have an error because it's an object and not a string...

Can you please fix this bug ? Thank you.

[DDC-2465] ProxyClass load, and empty ids

Wed, 22 May 2013 15:50:15 +0000

If you have lazy association (example many-to-one) that have empty id (for empty i mean empty string and not null) you (correctly) get EntityNotFoundException.

But i'm working with a system that sometimes put an empty string instead of null in fk fields.

So i've add this little snipped of code __load method in $_proxyClassTemplate, ProxyFactory:

// GT, 2013-05-21 If all identifier are empty you not need to try load

        if (is_array($this->_identifier)) {
            $isEmpty = true;
            foreach($this->_identifier as $iK => $iV) {
                if (!empty($iV))
                    $isEmpty = false;
            }

            if ($isEmpty)
                return;
        }
        // END GT EDIT

[DDC-2464] useless index for the middle table of many-to-many relationship

Tue, 21 May 2013 09:44:10 +0000

I have entity A and B, the relationship between A and B is many-to-many. which means Doctrine2 will generate a middle table called AB for me.

entity A:

class Station {
    /**
     * @ORM\ManyToMany(targetEntity="Fun", mappedBy="stations")
     */
    protected $funs;
}

entity B:

class Fun {
    /**
     * @ORM\ManyToMany(targetEntity="Station", inversedBy="funs")
     * @ORM\JoinTable(name="stations_have_funs")
     */
    protected $stations;
}

the schema of middle table stations_have_funs:

CREATE TABLE `stations_have_funs` (
  `fun_id` int(11) NOT NULL,
  `station_id` int(11) NOT NULL,
  PRIMARY KEY (`fun_id`,`station_id`),
  KEY `IDX_45C921911CA4BE49` (`fun_id`),
  KEY `IDX_45C9219121BDB235` (`station_id`),
  CONSTRAINT `FK_45C921911CA4BE49` FOREIGN KEY (`fun_id`) REFERENCES `funs` (`id`) ON DELETE CASCADE,
  CONSTRAINT `FK_45C9219121BDB235` FOREIGN KEY (`station_id`) REFERENCES `stations` (`id`) ON DELETE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

I noticed that there are 2 useless index(fun_id and station_id). Since fun_id and station_id are the primary key of this table. Do we really need 2 extra/duplicated index ?

[DDC-2463] [GH-675] Implementation for 'IsNot'-Comparison

Sun, 26 May 2013 07:17:57 +0000

This issue is created automatically through a Github pull request on behalf of pmattmann:

Url: https://github.com/doctrine/doctrine2/pull/675

Message:

See PR (https://github.com/doctrine/collections/pull/11)

This is the required implementation for 'IsNotNull'-Filters in Collection-Filtering.

[DDC-2462] [GH-674] Shortcut for force

Mon, 20 May 2013 15:44:48 +0000

This issue is created automatically through a Github pull request on behalf of TorbenBr:

Url: https://github.com/doctrine/doctrine2/pull/674

Message:

[DDC-2461] [GH-673] Namespace based command names

Sun, 26 May 2013 05:00:25 +0000

This issue is created automatically through a Github pull request on behalf of hell0w0rd:

Url: https://github.com/doctrine/doctrine2/pull/673

Message:

Symfony console supports auto completion:
``orm:generate:entities`` could called ``o:g:e``

[DDC-2460] [GH-672] Simplification example

Sun, 26 May 2013 05:01:04 +0000

This issue is created automatically through a Github pull request on behalf of hell0w0rd:

Url: https://github.com/doctrine/doctrine2/pull/672

Message:

Remove doctrine class loader, one bootstrap file

[DDC-2459] ANSI compliant quote strategy.

Fri, 17 May 2013 17:35:45 +0000

In order to simplify and speed up the sql generation
an ANSI quote strategy would be useful.

The implementation would be something like :

<?php
class AnsiQuoteStrategy implements \Doctrine\ORM\Mapping\QuoteStrategy
{
    /**
     * {@inheritdoc}
     */
    public function getColumnName($fieldName, ClassMetadata $class, AbstractPlatform $platform)
    {
        return $class->fieldMappings[$fieldName]['columnName'];
    }

    /**
     * {@inheritdoc}
     */
    public function getTableName(ClassMetadata $class, AbstractPlatform $platform)
    {
        return $class->table['name'];
    }

    /**
     * {@inheritdoc}
     */
    public function getSequenceName(array $definition, ClassMetadata $class, AbstractPlatform $platform)
    {
        return $definition['sequenceName'];
    }

    /**
     * {@inheritdoc}
     */
    public function getJoinColumnName(array $joinColumn, ClassMetadata $class, AbstractPlatform $platform)
    {
        return $joinColumn['name'];
    }

    /**
     * {@inheritdoc}
     */
    public function getReferencedJoinColumnName(array $joinColumn, ClassMetadata $class, AbstractPlatform $platform)
    {
        return $joinColumn['referencedColumnName'];
    }

    /**
     * {@inheritdoc}
     */
    public function getJoinTableName(array $association, ClassMetadata $class, AbstractPlatform $platform)
    {
        return $association['joinTable']['name'];
    }

    /**
     * {@inheritdoc}
     */
    public function getIdentifierColumnNames(ClassMetadata $class, AbstractPlatform $platform)
    {
        return $class->identifier;
    }

    /**
     * {@inheritdoc}
     */
    public function getColumnAlias($columnName, $counter, AbstractPlatform $platform, ClassMetadata $class = null)
    {
        return $platform->getSQLResultCashing($columnName . $counter);
    }
}

[DDC-2458] [GH-671] [DDC-2435] Fix column name with numbers and non alphanumeric characters.

Fri, 17 May 2013 16:41:03 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/671

Message:

http://www.doctrine-project.org/jira/browse/DDC-2435

[DDC-2457] [GH-670] [DDC-2451] Fix entity listeners serialization

Fri, 17 May 2013 15:13:24 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/670

Message:

http://www.doctrine-project.org/jira/browse/DDC-2451

[DDC-2456] [GH-669] Fixed generating column names for self referencing entity.

Sun, 26 May 2013 05:17:06 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/doctrine2/pull/669

Message:

[DDC-2455] Setting classes in the entity manager

Sun, 26 May 2013 05:30:38 +0000

I am creating my own bundle in Sf2 which will be used for third libraries, but I need to provide some simple and complex queries from this.
For simple queries i have no problem because I set the repository with the class from the third library.
Something like this:

$this->repository = $this->em->getRepository($className);
$result = $this->repository
->createQueryBuilder("c")
->select('c, d, e')
->join("c.groups", "d")
->join("d.users", "e")
->where("e.id = :userId")
->setParameter("userId", $userId);

return $result->getQuery()->getResult();

But when I need complex queries i have to work with the Entity Manager instead of working with the Repository. So tables are named as MyBundle (Group), but not how the third library named (sf_group). As a consequence the SQL throws an error saying that my table does not exist.
This is how I am trying to retrieve:

$query = $this->em->createQuery("SELECT p FROM Groups p");

I sent the className as the entity to avoid this. Something like:

$query = $this->em->createQuery("SELECT p FROM ".$this->className." p");

However i need a lot of queries with JOINs, so i would have to change every entity name, which is not convenient.

What another way could I implemment this?

Thanks for your help.

[DDC-2454] To-Many OrderBy mechanism should allow many-to-one associations

Thu, 16 May 2013 17:27:53 +0000

class ProductCategory
{
    /**
     * Store
     *
     * @var Store
     *
     * @ORM\ManyToOne(targetEntity="Store")
     * @ORM\JoinColumn(name="store_id", referencedColumnName="store_id")
     */
    private $Store;

    /**
     * storeId (for ordering in Product::ProductCategories only)
     *
     * @var integer
     *
     * @ORM\Column(name="store_id", type="integer")
     */
    private $storeId;
...

class Product
{
    /**
     * Associated categories
     *
     * @var \Doctrine\Common\Collections\Collection
     *
     * @ORM\OneToMany(targetEntity="ProductCategory", mappedBy="Product")
     * @ORM\OrderBy({"storeId"="ASC"})
     */
    private $ProductCategories;
}
}

If it is possible now to sort the ProductCategories collection by the storeId field, it should also be possible to sort them by the Store association. Currently a set of two fields is required: Store as a regular Many-To-One association and if a need arises to be able to use it to sort the One-To-Many collections then storeId needs to be added to the ProductCategory entity. In that case the ProductCategory entity does not pass the schema validation but is perfectly usable.

This should be allowed:

class Product
{
    /**
     * Associated categories
     *
     * @var \Doctrine\Common\Collections\Collection
     *
     * @ORM\OneToMany(targetEntity="ProductCategory", mappedBy="Product")
     * @ORM\OrderBy({"Store"="ASC"})
     */
    private $ProductCategories;
}

[DDC-2453] [GH-668] [WIP] Adding failing test for DDC-2452

Thu, 16 May 2013 14:36:08 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/668

Message:

DQL joins between JTI entities produce invalid SQL when additional conditions are inserted via WITH clause

Still working on a fix

[DDC-2452] Additional `WITH` condition in joins between JTI roots cause invalid SQL to be produced

Thu, 16 May 2013 16:23:40 +0000

Given a simple Joined Table Inheritance like following:

/**
 * @Entity @Table(name="foo") @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="discr", type="string")
 * @DiscriminatorMap({"foo" = "DDC2452Foo", "bar" = "DDC2452Bar"})
 */
class DDC2452Foo
{
    /** @Id @Column(type="integer") @GeneratedValue */
    public $id;
}

/** @Entity @Table(name="bar") */
class DDC2452Bar extends DDC2452Foo
{
}

Following DQL

SELECT foo1 FROM DDC2452Foo foo1 JOIN DDC2452Foo foo2 WITH 1=1

Will produce broken SQL:

SELECT
    f0_.id AS id0, f0_.discr AS discr1 
FROM 
    foo f0_ 
LEFT JOIN bar b1_ 
    ON f0_.id = b1_.id 
LEFT JOIN foo f2_ 
LEFT JOIN bar b3_ 
    ON f2_.id = b3_.id 
    ON (1 = 1)

(please note the duplicate `ON` in the SQL)

That is caused because of the SQL walker producing the JTI filter with already the `ON` clause in it.

That happens because the JTI join conditions are added in https://github.com/doctrine/doctrine2/blob/2.4.0-BETA2/lib/Doctrine/ORM/Query/SqlWalker.php#L823-L825 (`walkRangeVariableDeclaration`), while the additional defined `WITH` conditions are considered in `walkJoinAssociationDeclaration` later on.

Added a test case and fix at https://github.com/doctrine/doctrine2/pull/668

[DDC-2451] Entity listeners class don't work when metadatas are stored in cache

Fri, 17 May 2013 15:12:12 +0000

I'm using entity listeners class to make PostPersist and PostLoad actions per entity and use memcached as the metadata cache. Before the metadatas are in cache, the methods of the entity listeners are properly called but when the metadatas are in cache, they are no longer called. I've also made the test with APC and the result is the same.

[DDC-2450] Exception throwen when use --dump-sql

Thu, 16 May 2013 11:34:45 +0000

php app/console doctrine:schema:update --dump-sql > a.sql



  [Doctrine\DBAL\Schema\SchemaException]
  The table with name 'xxx.message76' already exists.



doctrine:schema:update [--complete] [--dump-sql] [--force] [--em[="..."]]

[DDC-2449] Amazon Redshift Support

Wed, 15 May 2013 23:09:12 +0000

It would be nice to get doctrine compatible with Amazon Redshift. It uses a Postgres connector but there are some differences. I'm currently facing an issue with the primary id, in Redshift the generation of an id is different from Postgres and so I'm getting errors associated with generating an id.

Here are some references that might be useful:
node-orm faced the same issue and seems like they figured it out: https://github.com/dresende/node-orm2/issues/39

Amazon Manual:
http://awsdocs.s3.amazonaws.com/redshift/latest/redshift-dg.pdf

[DDC-2448] orm:schema-tool:update reports already updated NUMERIC fields

Tue, 14 May 2013 09:09:13 +0000

I have a table defined in this way:

CREATE TABLE `my_table` (
`id` int(10) NOT NULL AUTO_INCREMENT,
`subtotal` decimal(10,2) DEFAULT NULL,
PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=7 DEFAULT CHARSET=utf8;

When I run
php doctrine.php orm:schema-tool:update --dump-sql

I get
ALTER TABLE my_table CHANGE subtotal subtotal NUMERIC(10, 2) DEFAULT NULL;

While of course the field is already updated. The same happens in SQL Server 2008 and Postgres 9.

[DDC-2447] [GH-667] DQL: Allow parameter name to start with any allowed character

Mon, 13 May 2013 20:08:16 +0000

This issue is created automatically through a Github pull request on behalf of juzna:

Url: https://github.com/doctrine/doctrine2/pull/667

Message:

Especially, do not require it to start with a letter. A *number* is good enough as well. Why is was it not enabled anyway?

It's most useful when parameter names are auto generated, e.g. using sha1 or md5.

[DDC-2446] [GH-666] [DDC-2429] Fix xsd definition

Sun, 26 May 2013 06:02:03 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/666

Message:

http://www.doctrine-project.org/jira/browse/DDC-2429

[DDC-2445] [GH-665] oo Add Null in ScalarExpression

Sun, 26 May 2013 04:46:29 +0000

This issue is created automatically through a Github pull request on behalf of vahid-sohrabloo:

Url: https://github.com/doctrine/doctrine2/pull/665

Message:

[DDC-2444] NULL IN CASE WHEN

Wed, 22 May 2013 04:21:59 +0000

Hi
In DQL when i use NULL IN "CASE WHEN" like this
"AVG(CASE WHEN g.speed > 0 THEN g.speed ELSE NULL END)"
Throw this expestion
Unexpected 'NULL'

[DDC-2443] [GH-664] ClassMetadaInfo rename setIdentifierValues() to assignIdentifier()

Fri, 10 May 2013 00:58:15 +0000

This issue is created automatically through a Github pull request on behalf of entering:

Url: https://github.com/doctrine/doctrine2/pull/664

Message:

I saw this @todo so i changed name of method and occurrences on code and documentation.

[DDC-2442] [GH-663] Adding failing test to demonstrate DDC-2432

Fri, 10 May 2013 06:55:52 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/663

Message:

Attempt to fix ~~DDC-2432~~ ( http://www.doctrine-project.org/jira/browse/DDC-2432 )

Loading proxies with invalid identifiers will currently mark them as initialized regardless of the failure

[DDC-2441] Incorrect SQL Query being generated

Fri, 7 Jun 2013 21:36:32 +0000

The following DQL :

SELECT s,ba,c,mno,ss,sws,ccs,cns,cws FROM WLCoreBundle:SIM s INNER JOIN s.billingAccount ba LEFT JOIN s.connection c INNER JOIN s.status ss LEFT JOIN s.workflowStatus sws INNER JOIN c.customerStatus ccs INNER JOIN c.networkStatus cns LEFT JOIN c
.workflowStatus cws INNER JOIN s.mno mno ORDER BY c.msisdn ASC

Produces the following SQL :

SELECT * FROM (SELECT c0_.id AS id0, c0_.iccid AS iccid1, c0_.created AS created2, c0_.updated AS updated3, c0_.spreference AS spreference4, c1_.id ASid5, c1_.account_number AS account_number6, c1_.name AS name7, c1_.address1 AS address18, c1_.address2 AS address29, c1_.address3 AS address310, c1_.address4 AS address411, c1_.address5 AS address512, c1_.address6 AS address613, c1_.email_address AS email_address14, c1_.spreference AS spreference15, c2_.id AS id16, c2_.msisdn AS msisdn17, c2_.local AS local18, c2_.imsi AS imsi19, c2_.data AS data20, c2_.fax AS fax21, c2_.api AS api22, c2_.activation_date AS activation_date23, c2_.contract_end_date AS contract_end_date24, c2_.created AS created25, c2_.updated AS updated26, c2_.spreference AS spreference27, c3_.id AS id28, c3_.ident AS ident29, c3_.label AS label30, c3_.description AS description31, c4_.id AS id32, c4_.ident AS ident33, c4_.label AS label34, c4_.description AS description35, c4_.customer_label AS customer_label36, c4_.customer_description AS customer_description37, c5_.id AS id38, c5_.ident AS ident39, c5_.label AS label40, c5_.description AS description41, c6_.id AS id42, c6_.ident AS ident43, c6_.label AS label44, c6_.description AS description45, c7_.id AS id46, c7_.ident AS ident47, c7_.label AS label48, c7_.description AS description49, c7_.customer_label AS customer_label50, c7_.customer_description AS customer_description51, c8_.id AS id52, c8_.name AS name53, c8_.email_address AS email_address54, c8_.is_active AS is_active55, c8_.spreference AS spreference56, c0_.billing_account AS billing_account57, c0_.customerHierarchy AS customerHierarchy58, c0_.mno AS mno59, c0_.status AS status60, c0_.workflow_status AS workflow_status61, c1_.customer_hierarchy AS customer_hierarchy62, c1_.country AS country63, c1_.tax_rate AS tax_rate64, c1_.currency AS currency65, c1_.status AS status66, c1_.priority AS priority67, c2_.sim AS sim68, c2_.customer_status AS customer_status69, c2_.network_status AS network_status70, c2_.workflow_status AS workflow_status71, ROW_NUMBER() OVER (ORDER BY msisdn17 ASC) AS doctrine_rownum FROM core_sim c0_ WITH (NOLOCK) INNER JOIN core_billing_account c1_ ON c0_.billing_account = c1_.id LEFT JOIN core_connection c2_ ON c0_.id = c2_.sim INNER JOIN core_sim_status c3_ ON c0_.status = c3_.id LEFT JOIN core_sim_workflow_status c4_ ON c0_.workflow_status = c4_.id INNER JOIN core_connection_customer_status c5_ ON c2_.customer_status = c5_.id INNER JOIN core_connection_network_status c6_ ON c2_.network_status = c6_.id LEFT JOIN core_connection_workflow_status c7_ ON c2_.workflow_status = c7_.id INNER JOIN core_mno c8_ ON c0_.mno = c8_.id) AS doctrine_tbl WHERE doctrine_rownum BETWEEN 1 AND 10

Which returns an error :

SQLSTATE[42S22]: [Microsoft][SQL Server Native Client 11.0][SQL Server]Invalid column name 'msisdn17'.

Same query works fine in Doctrine 2.3

[DDC-2440] composer.json is wrong

Thu, 9 May 2013 22:06:31 +0000

In composer.json for doctrine/doctrine-orm-module there is the following require:
"doctrine/doctrine-module": "0.8.*"

However "0.8.*" does not exist, it should be "0.8.x-dev" or "dev-master". The later would then use the branch alias. Either way this needs changing, because it's stopping the package from being installed or updated.

[DDC-2439] [GH-662] Fixed a code block.

Thu, 9 May 2013 14:28:04 +0000

This issue is created automatically through a Github pull request on behalf of jakzal:

Url: https://github.com/doctrine/doctrine2/pull/662

Message:

Last code block in the [Keeping your Modules independent](http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/cookbook/resolve-target-entity-listener.html) cookbook is broken.

Sphinx does not like the way code was indented. Building the documentation raises the following error:

en/cookbook/resolve-target-entity-listener.rst:121: ERROR: Unexpected indentation.

[DDC-2438] [GH-661] Update annotations-reference.rst

Thu, 9 May 2013 12:10:45 +0000

This issue is created automatically through a Github pull request on behalf of HarmenM:

Url: https://github.com/doctrine/doctrine2/pull/661

Message:

Added missing @JoinColumns in the index

[DDC-2437] [GH-660] Fixed critical bug with position indexBy in DQL

Thu, 9 May 2013 09:09:56 +0000

This issue is created automatically through a Github pull request on behalf of vlastv:

Url: https://github.com/doctrine/doctrine2/pull/660

Message:

[DDC-2436] Inheritance on mappedSuperClass

Fri, 10 May 2013 16:55:33 +0000

Sometimes is necessary some associations(many to many) in the mappedSuperClass. This associations should not be lost (inversedBy side and mappedBy ). The only one way to get this, was to implement an abstract class as Single Inheritance Table and then the mappedSuperClass inherit of this. But this is not optimum, because we are losing the OOP, creating classes which should not exist.

I realized of this when i was creating my bundle to be used for some projects, but I needed each project could extends from my class and add some properties or methods according their needs.

This is the link where you can see more details of this:

http://stackoverflow.com/questions/16405556/mapped-super-class-symfony2-2

Thanks for your attention.

[DDC-2435] Column name with number and reserved character creates invalid query

Fri, 17 May 2013 16:40:30 +0000

I have a column name called 1:1 which i map like so
@Column(type="string", name="`1:1`")
Unfortunately, the SQL that get generated does not work in mysql:
SELECT t0.`1:1` AS 112 FROM `table` t0
the problem is with the 'AS 112', if it contained a letter eg. 11a, or was escaped eg. `112` it wound work.

[DDC-2434] Error generating entities using annotation docblock (in php). Attribute "fetch" is not being generated by Class EntityGenerator

Thu, 9 May 2013 08:56:59 +0000

In this part of the code that begins on line 1047 which is generated lines docblock but not being generated attribute fetch.

            $type = null;
            switch ($associationMapping['type']) {
                case ClassMetadataInfo::ONE_TO_ONE:
                    $type = 'OneToOne';
                    break;
                case ClassMetadataInfo::MANY_TO_ONE:
                    $type = 'ManyToOne';
                    break;
                case ClassMetadataInfo::ONE_TO_MANY:
                    $type = 'OneToMany';
                    break;
                case ClassMetadataInfo::MANY_TO_MANY:
                    $type = 'ManyToMany';
                    break;
            }
            $typeOptions = array();

            if (isset($associationMapping['targetEntity'])) {
                $typeOptions[] = 'targetEntity="' . $associationMapping['targetEntity'] . '"';
            }

            if (isset($associationMapping['inversedBy'])) {
                $typeOptions[] = 'inversedBy="' . $associationMapping['inversedBy'] . '"';
            }

            if (isset($associationMapping['mappedBy'])) {
                $typeOptions[] = 'mappedBy="' . $associationMapping['mappedBy'] . '"';
            }

            if ($associationMapping['cascade']) {
                $cascades = array();

                if ($associationMapping['isCascadePersist']) $cascades[] = '"persist"';
                if ($associationMapping['isCascadeRemove']) $cascades[] = '"remove"';
                if ($associationMapping['isCascadeDetach']) $cascades[] = '"detach"';
                if ($associationMapping['isCascadeMerge']) $cascades[] = '"merge"';
                if ($associationMapping['isCascadeRefresh']) $cascades[] = '"refresh"';

                $typeOptions[] = 'cascade={' . implode(',', $cascades) . '}';
            }

            if (isset($associationMapping['orphanRemoval']) && $associationMapping['orphanRemoval']) {
                $typeOptions[] = 'orphanRemoval=' . ($associationMapping['orphanRemoval'] ? 'true' : 'false');
            }

Below is one possible solution.

            $typesFetch = array(
                2 => 'LAZY',
                3 => 'EAGER',
                4 => 'EXTRA_LAZY'
            );

            if(isset($associationMapping['fetch'])) {
                $typeOptions[] = 'fetch="' . $typesFetch[$associationMapping['fetch']] . '"';
            }

Tanks

[DDC-2433] [GH-659] [wip] Pr mapping import

Wed, 12 Jun 2013 04:32:20 +0000

This issue is created automatically through a Github pull request on behalf of bronze1man:

Url: https://github.com/doctrine/doctrine2/pull/659

Message:

fix 5 bug of command 1.doctrine:mapping:import then 2.doctrine:schema:update

column default
column unsigned
column type char
table without auto_increment
column comment

wip -> follow rule of contribute to doctrine

add patch on master
add test

[DDC-2432] Entity can be initialized even if not found

Thu, 9 May 2013 21:38:43 +0000

I have some data in loose consistency, trying to load a field from a certain entity will yield a EntityNotFoundException. Trying it again, for example if the group is reused in a set that gets iterated, will work but provide an empty/dirty Entity.

try {
  echo $item->getGroup()->getName();
} catch (\Doctrine\ORM\EntityNotFoundException $enfe) {
  // meh
}

Thats probably because the proxies internal methods set _isInitialized_ to true on the first try. Without reverting it in case of the exception...

    public function __load()
    {
        if (!$this->__isInitialized__ && $this->_entityPersister) {
            $this->__isInitialized__ = true;

            if ($this->_entityPersister->load($this->_identifier, $this) === null) {
                throw new \Doctrine\ORM\EntityNotFoundException();
            }
            unset($this->_entityPersister, $this->_identifier);
        }
    }

Is there any reason to do that?

[DDC-2431] XML Not parsed

Thu, 9 May 2013 10:13:50 +0000

When i try to generate my entities mapping in Symfony2 using XML I always get the same error:

Element '

{http://doctrine-project.org/schemas/orm/doctrine-mapping}

doctrine-mapping': No matching global declaration avail
able for the validation root

I am not adding any column, because first i need to validate the XML which I can't.

<?xml version="1.0" encoding="UTF-8"?>
<orm:doctrine-mapping
xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'
xmlns:orm='http://doctrine-project.org/schemas/orm/doctrine-mapping'
xsi:schemaLocation='http://doctrine-project.org/schemas/orm/doctrine-mapping http://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd'>

</orm:doctrine-mapping>

As you can figure out, my XML is very simple. I am doing just for the validation testing. After this could be validated, I will map my entities.

Thanks for your help.

Regards,
Peter

[DDC-2430] Incorrect results when using ->matching on PersistentCollection

Thu, 9 May 2013 11:25:38 +0000

When using ->matching() on a PersistentCollection that is already loaded, it returns incorrect results when trying to match by id on a relationship.

// NOTE: the user property is a M:1 relationship of $entity
$c = new Criteria(Criteria::expr()->eq('user', $userId));
$res = $entity->getLikes()->matching($c);

// $res is empty, even if $userId exists

[DDC-2429] Association-Override Problem in XSD Mapping?

Sun, 26 May 2013 06:01:51 +0000

From a mailinglist entry:

I use Doctrine 2.3 in Symfony 2.1.8

I'm using association-overrides in the XML format between several entities. Eclipse shows up several errors.

The first error message is shown in every Doctrine file when I declare the file format as such (for example: https://github.com/thewholelifetolearn/Social-Library/blob/master/src/SocialLibrary/ReadBundle/Resources/config/doctrine/GraphicNovel.orm.xml )

<?xml version="1.0" encoding="UTF-8"?>
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping"
                  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                  xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
                  http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd">

Eclipse shows this error :
White spaces are required between publicId and systemId

The error points to the "doctrine-mapping" line

The second error comes up when I change the doctype to (file example: https://gist.github.com/thewholelifetolearn/5462057 ):

<?xml version="1.0" encoding="UTF-8"?>
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping"
                  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                  xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
                  https://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd">

But then this error is shown:
cvc-complex-type.2.4.b: The content of element 'association-overrides' is not complete. One of '

{"http://doctrine-project.org/schemas/orm/doctrine-mapping":association-override, WC[##other:"http://doctrine-project.org/schemas/orm/doctrine-mapping"]}

' is expected.

The error points on "<association-overrides>" in Novel.orm.xml (line 8)

Could someone explain me the errors that show up? The first error doesn't seem to disturb Symfony2 but the second messes around the console commands. But it still generates the database.

[DDC-2428] [GH-658] UPDATE clause supports ORDER BY and LIMIT

Sun, 5 May 2013 16:32:13 +0000

This issue is created automatically through a Github pull request on behalf of tomglue:

Url: https://github.com/doctrine/doctrine2/pull/658

Message:

Hi there,

I wanted get some feedback on what you thought about supporting ORDER BY and LIMIT for UPDATE statements.

Is there a reason this has not already been implemented?

Thanks

[DDC-2427] Not working orphanRemoval (OneToMany)

Sat, 4 May 2013 10:45:21 +0000

Not working orphanRemoval (OneToMany). The element from target entity deleted but still available. I Not get any error, just not deleted.

Configuration example:

class SecurityForm implements SecurityEntityInterface
{
...

/**
*

@ORM\OneToMany(targetEntity="SecurityFormField", mappedBy="form", cascade= {"persist"}
, orphanRemoval=true)
@ORM\OrderBy( {"order" = "ASC"}
)
*/
private $formFields;

....

}

[DDC-2426] XML Mapping XSD: Missing length attribute for complexType id

Sat, 4 May 2013 11:00:25 +0000

The xsd file for the doctrine XML mapping specification does not allow the complexType id to contain a length property.

This prevents IDEs from giving proper auto-completion for the <id> element.

To fix, simply add the following at line 332 of the xsd:

<xs:attribute name="length" type="xs:NMTOKEN" />

[DDC-2425] Parent entity sometimes fails to load when validating/updating schema.

Fri, 3 May 2013 20:17:09 +0000

Should not have reported, was a stupid mistake on my part.

[DDC-2424] Removing an inherited entity via a delete cascade constraint does not remove the parent row

Mon, 6 May 2013 10:19:39 +0000

For a parent class:

/**
 * @ORM\Entity
 * @ORM\Table(name="Base")
 * @ORM\InheritanceType("JOINED")
 * @ORM\DiscriminatorColumn(name="discr", type="string")
 * @ORM\DiscriminatorMap({"child1" = "Child1", "child2" = "Child2"})
 */

and simple Child1 & Child2 entities.

With another entity (let's call it ExternalEntity) having a bidirectional OneToOne relation owned by Child1:

class Child1 extends Base
{
  /**
   * @ORM\OneToOne(targetEntity="ExternalEntity", inversedBy="xxx")
   * @ORM\JoinColumn(onDelete="CASCADE", nullable=false)
   */
   private theForeignKey;
}

Enough for the context.
The symptoms:

$em->remove(instanceOfExternalEntity);

removes the ExternalEntity row and the Child1 row. But a dangling row in the Base table is still there for the now inexistent Child1 instance.

Though, a manual delete of either the associated Child1 OR Base row and then the ExternalEntity works.

The problem with the cascading deletion of the parent seems to be only present when deleting through a MYSQL cascading delete from another row which has a foreign key on a child. (Not tested with a foreign key on the parent though)

[DDC-2423] [GH-657] DDC-2413

Wed, 1 May 2013 08:18:38 +0000

This issue is created automatically through a Github pull request on behalf of JEDIBC:

Url: https://github.com/doctrine/doctrine2/pull/657

Message:

Fix ~~DDC-2413~~

[DDC-2422] HIDDEN fileds doesn't work in subqueries

Wed, 1 May 2013 19:33:52 +0000

I trying to execute query with subquery, which contains GROUP BY:

$subqueryBuilder = $repository->createQueryBuilder('l2')
    ->select('l2.id, DATE(l2.created) AS HIDDEN created_date')
    ->groupBy('created_date');

$qb = $repository->createQueryBuilder('l');
$qb->andWhere($qb->expr()->in('l.id', $subqueryBuilder->getDQL()));
$result = $qb->getQuery()->getArrayResult();

And got error:

[Syntax Error] line 0, col 80: Error: Expected Doctrine\ORM\Query\Lexer::T_FROM, got ','

If I group simply by "l2.created" without adding it to selected fields, all works fine. But I must use "DATE(l2.created) AS HIDDEN created_date" in selected statement to specify it in GROUP BY statement.

[DDC-2421] Many-To-Many relation creation failed when using non PK entity field

Wed, 1 May 2013 09:03:08 +0000

Given these entities :

/**
 * Class Domain
 *
 * @ORM\Entity
 * @ORM\Table(name="profils_domains")
 */
class Domain
{
    /**
     * @var string
     *
     * @ORM\Id
     * @ORM\Column(type="string", length=22, nullable=false)
     */
    protected $name = '';
}

/**
 * Class Web
 *
 * @ORM\Entity
 * @ORM\Table(name="profils_webs",
 *          uniqueConstraints={@ORM\UniqueConstraint(name="web_unique",columns={"name", "domain"})}
 * )
 */
class Web
{
    /**
     * @var integer
     *
     * @ORM\Id
     * @ORM\GeneratedValue
     * @ORM\Column(type="integer", nullable=false)
     */
    protected $id;

    /**
     * @var string
     *
     * @ORM\Column(type="string", length=22, nullable=false)
     */
    protected $name = '';

    /**
     * @var Domain
     *
     * @ORM\ManyToOne(targetEntity="Domain", fetch="LAZY")
     * @ORM\JoinColumn(name="domain", referencedColumnName="name", nullable=false, onDelete="CASCADE")
     */
    protected $domain;
}

/**
 * Class WebsGroup
 *
 * @ORM\Entity
 * @ORM\Table(name="profils_websgroups",
 *          uniqueConstraints={@ORM\UniqueConstraint(name="websgroup_unique",columns={"name", "domain"})}
 * )
 */
class WebsGroup
{
    /**
     * @var integer
     *
     * @ORM\Id
     * @ORM\GeneratedValue
     * @ORM\Column(type="integer", nullable=false)
     */
    protected $id;

    /**
     * @var string
     *
     * @ORM\Column(type="string", length=22, nullable=false)
     */
    protected $name = '';

    /**
     * @var Domain
     *
     * @ORM\ManyToOne(targetEntity="Domain", fetch="LAZY")
     * @ORM\JoinColumn(name="domain", referencedColumnName="name", nullable=false, onDelete="CASCADE")
     */
    protected $domain;

    /**
     * @var ArrayCollection
     *
     * @ORM\ManyToMany(targetEntity="Web", indexBy="id", fetch="EXTRA_LAZY")
     * @ORM\JoinTable(name="profils_websgroups_webs",
     *      joinColumns={
     * @ORM\JoinColumn(name="websgroup_id", referencedColumnName="id", onDelete="CASCADE"),
     * @ORM\JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE")
     *          },
     *      inverseJoinColumns={
     * @ORM\JoinColumn(name="web_id", referencedColumnName="id", onDelete="CASCADE"),
     * @ORM\JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE")
     *          }
     *      )
     */
    protected $webs;
}

I've got a domain, some web sites per domain and websgroups which group web sites. I want to be sure in my database that a web group from a domain D can contain only web sites from the very same domain but when calling the console tool for creating my schema it raise :

[Doctrine\ORM\ORMException]                                                                                                                                      
  Column name `domain` referenced for relation from Entity\WebsGroup towards Entity\Web does not exist.

It's because domain is already an association to an entity which and is not part of the primary key.

I've quick fixed getDefiningClass from Doctrine\ORM\Tools\SchemaTool to make it work but i really don't know if it's the proper way :

    private function getDefiningClass($class, $referencedColumnName)
    {
        $referencedFieldName = $class->getFieldName($referencedColumnName);

        if ($class->hasField($referencedFieldName)) {
            return array($class, $referencedFieldName);
        } else if (in_array($referencedColumnName, $class->getIdentifierColumnNames())) {
            // it seems to be an entity as foreign key
            foreach ($class->getIdentifierFieldNames() as $fieldName) {
                if ($class->hasAssociation($fieldName) && $class->getSingleAssociationJoinColumnName($fieldName) == $referencedColumnName) {
                    return $this->getDefiningClass(
                        $this->em->getClassMetadata($class->associationMappings[$fieldName]['targetEntity']),
                        $class->getSingleAssociationReferencedJoinColumnName($fieldName)
                    );
                }
            }
        } else if (in_array($referencedColumnName, $class->getAssociationNames())) {
            return $this->getDefiningClass(
                $this->em->getClassMetadata($class->associationMappings[$referencedColumnName]['targetEntity']),
                $class->getSingleAssociationReferencedJoinColumnName($referencedColumnName)
            );
        }

        return null;
    }

[DDC-2420] [GH-656] [DDC-2235] Fix for using a LEFT JOIN onto an entity with single table inheritance

Sun, 28 Apr 2013 23:09:35 +0000

This issue is created automatically through a Github pull request on behalf of tarnfeld:

Url: https://github.com/doctrine/doctrine2/pull/656

Message:

Possible fix for the bug DDC-2235. I'd love to hear some opinions on whether this is the right way to go about this issue. I'm not particularly familiar with the internals of doctrine so there may be a better solution.

------

The issue is when using DQL to perform a left join on an entity using single
table inheritance, doctrine tries to insert an `IN()` predicate into the `WHERE`
clause for all of the discriminator values. That makes sense and is valid, so
it would be wrong to remove that behaviour.

However when using a left join having an `IN()` in the main where clause makes
the `LEFT JOIN` pretty much useless, as it implicitly creates a `WHERE NOT NULL`
clause. This commit attempts to fix that by including an `OR IS NULL` in the
query if the join is a `LEFT JOIN`.

I've added some regression tests to ensure this bug never creeps back in. They fail on master (highlighting the bug) and pass after these commits have been applied. I've also included a couple of other queries as tests to be sure only this one case has been affected.

[DDC-2419] [GH-655] [DDC-2409] Fix merge association UnitOfWork::STATE_NEW

Wed, 1 May 2013 09:02:01 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/655

Message:

http://www.doctrine-project.org/jira/browse/DDC-2409

[DDC-2418] [GH-654] Ilike

Sat, 27 Apr 2013 08:13:42 +0000

This issue is created automatically through a Github pull request on behalf of lighthart:

Url: https://github.com/doctrine/doctrine2/pull/654

Message:

Ilike expression added for postgres support

[DDC-2417] [GH-653] [DDC-2415] Fix CustomIdGenerator inheritance

Sat, 27 Apr 2013 07:50:17 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/653

Message:

http://www.doctrine-project.org/jira/browse/DDC-2415

[DDC-2416] [GH-652] Fixed entities path

Fri, 26 Apr 2013 09:23:51 +0000

This issue is created automatically through a Github pull request on behalf of dannykopping:

Url: https://github.com/doctrine/doctrine2/pull/652

Message:

In the tutorial, the user is told to create a new file in the `/src` folder, and the `/entities` folder is never referenced. Updating the SQLite schema according to the tutorial fails with the 'No Metadata Classes to process.' message. Changing the folder to `/src` fixes this, ostensibly.

[DDC-2415] CustomIdGenerator not inherited from MappedSuperclass

Sat, 27 Apr 2013 13:00:02 +0000

I had a problem with a CUSTOM id generation mapping definition.
I have an abstract class and @MappedSuperclass which defines the id column as:

/**

@ORM\Id
@ORM\Column(name="ID", type="integer")
@ORM\GeneratedValue(strategy="CUSTOM")
@ORM\CustomIdGenerator(class="Infoil\Extensions\ExtensionsBundle\DoctrineIdGenerator\ZafiroIdGenerator")
@var int $id
*/
The problem is that subclasses doesn't inherits the CustomIdGenerator annotation. I have traced the problem up to ClassMetadataFactory::doLoadMetadata.
I had to change the second inner if statement as

if ($parent->isMappedSuperclass)

{ $class->setCustomRepositoryClass($parent->customRepositoryClassName); $class->setCustomGeneratorDefinition($parent->customGeneratorDefinition); <<<<< LINE ADDED }

to allow subclasses inherit the customGenerationdefinition.

Aside, the docblock annotation help doesn't includes the CustomIdGenerator tag.

[DDC-2414] Unable to create One-To-Many relation with composite keys

Wed, 1 May 2013 09:04:07 +0000

Given these entities :

/**
 * Class Domain
 *
 * @Entity
 * @Table(name="profils_domains")
 */
class Domain
{
    /**
     * @var string
     *
     * @Id
     * @Column(type="string", length=22, nullable=false)
     */
    protected $name = '';
}

/**
 * Class User
 *
 * @Entity
 * @Table(name="profils_users")
 */
class User
{
    /**
     * @var string
     *
     * @Id
     * @Column(type="string", length=22, nullable=false)
     */
    protected $name = '';

    /**
     * @var Domain
     *
     * @Id
     * @ManyToOne(targetEntity="Domain", fetch="LAZY")
     * @JoinColumn(name="domain", referencedColumnName="name", onDelete="CASCADE")
     */
    protected $domain;
    
    /**
     * @var Group[]|ArrayCollection
     *
     * @ManyToMany(targetEntity="Group", mappedBy="users")
     */
    protected $groups;
}

/**
 * Class Group
 *
 * @Entity
 * @Table(name="profils_groups")
 */
class Group
{
    /**
     * @var string
     *
     * @Id
     * @Column(type="string", length=22, nullable=false)
     */
    protected $name = '';

    /**
     * @var Domain
     *
     * @Id
     * @ManyToOne(targetEntity="Domain", fetch="LAZY")
     * @JoinColumn(name="domain", referencedColumnName="name", onDelete="CASCADE")
     */
    protected $domain;
    
    /**
     * @var User[]|ArrayCollection
     *
     * @ManyToMany(targetEntity="User", indexBy="name", fetch="EXTRA_LAZY")
     * @JoinTable(name="profils_groups_users",
     *      joinColumns={
     * @JoinColumn(name="group_name", referencedColumnName="name", onDelete="CASCADE"),
     * @JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE")
     *          },
     *      inverseJoinColumns={
     * @JoinColumn(name="user_name", referencedColumnName="name", onDelete="CASCADE"),
     * @JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE")
     *          }
     *      )
     */
    protected $users;
}

I want to link users and groups but only from the same domain.
I also want a user to be in one group only.
The only way with composite keys is to make One-To-Many, Unidirectional with Join Table but I can't put unique=true in the @JoinColumn of my inverseJoinColumns because it will generate a unique index for each field and not one composite. I also can't use @UniqueConstraint as it is not supported in @JoinTable.

[DDC-2413] orm:schema-tool:update want to drop&create PK on join table using composite keys

Wed, 1 May 2013 18:08:16 +0000

Given these entities :

/**
 * Class Domain
 *
 * @Entity
 * @Table(name="profils_domains")
 */
class Domain
{
    /**
     * @var string
     *
     * @Id
     * @Column(type="string", length=22, nullable=false)
     */
    protected $name = '';
}

/**
 * Class User
 *
 * @Entity
 * @Table(name="profils_users")
 */
class User
{
    /**
     * @var string
     *
     * @Id
     * @Column(type="string", length=22, nullable=false)
     */
    protected $name = '';

    /**
     * @var Domain
     *
     * @Id
     * @ManyToOne(targetEntity="Domain", fetch="LAZY")
     * @JoinColumn(name="domain", referencedColumnName="name", onDelete="CASCADE")
     */
    protected $domain;
    
    /**
     * @var Group[]|ArrayCollection
     *
     * @ManyToMany(targetEntity="Group", mappedBy="users")
     */
    protected $groups;
}

/**
 * Class Group
 *
 * @Entity
 * @Table(name="profils_groups")
 */
class Group
{
    /**
     * @var string
     *
     * @Id
     * @Column(type="string", length=22, nullable=false)
     */
    protected $name = '';

    /**
     * @var Domain
     *
     * @Id
     * @ManyToOne(targetEntity="Domain", fetch="LAZY")
     * @JoinColumn(name="domain", referencedColumnName="name", onDelete="CASCADE")
     */
    protected $domain;
    
    /**
     * @var User[]|ArrayCollection
     *
     * @ManyToMany(targetEntity="User", indexBy="name", fetch="EXTRA_LAZY")
     * @JoinTable(name="profils_groups_users",
     *      joinColumns={
     * @JoinColumn(name="group_name", referencedColumnName="name", onDelete="CASCADE"),
     * @JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE")
     *          },
     *      inverseJoinColumns={
     * @JoinColumn(name="user_name", referencedColumnName="name", onDelete="CASCADE"),
     * @JoinColumn(name="domain", referencedColumnName="domain", onDelete="CASCADE")
     *          }
     *      )
     */
    protected $users;
}

I want to link users and groups but only from the same domain.

orm:schema-tool:create generate correct SQL :

CREATE TABLE profils_users (name VARCHAR(22) NOT NULL, domain VARCHAR(22) NOT NULL, INDEX IDX_E75993CFA7A91E0B (domain), PRIMARY KEY(name, domain)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB;
CREATE TABLE profils_domains (name VARCHAR(22) NOT NULL, PRIMARY KEY(name)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB;
CREATE TABLE profils_groups (name VARCHAR(22) NOT NULL, domain VARCHAR(22) NOT NULL, INDEX IDX_229366BBA7A91E0B (domain), PRIMARY KEY(name, domain)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB;
CREATE TABLE profils_groups_users (group_name VARCHAR(22) NOT NULL, domain VARCHAR(22) NOT NULL, user_name VARCHAR(22) NOT NULL, INDEX IDX_6CF8F4EA77792576A7A91E0B (group_name, domain), INDEX IDX_6CF8F4EA24A232CFA7A91E0B (user_name, domain), PRIMARY KEY(group_name, domain, user_name)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB;
ALTER TABLE profils_users ADD CONSTRAINT FK_E75993CFA7A91E0B FOREIGN KEY (domain) REFERENCES profils_domains (name) ON DELETE CASCADE;
ALTER TABLE profils_groups ADD CONSTRAINT FK_229366BBA7A91E0B FOREIGN KEY (domain) REFERENCES profils_domains (name) ON DELETE CASCADE;
ALTER TABLE profils_groups_users ADD CONSTRAINT FK_6CF8F4EA77792576A7A91E0B FOREIGN KEY (group_name, domain) REFERENCES profils_groups (name, domain) ON DELETE CASCADE;
ALTER TABLE profils_groups_users ADD CONSTRAINT FK_6CF8F4EA24A232CFA7A91E0B FOREIGN KEY (user_name, domain) REFERENCES profils_users (name, domain) ON DELETE CASCADE

but I make a orm:schema-too:update it want to drop and recreate the PK of the join table each time, and with a wrong sql query :

ALTER TABLE profils_groups_users DROP PRIMARY KEY;
ALTER TABLE profils_groups_users ADD PRIMARY KEY (group_name, domain, user_name, domain)

To avoid the duplication of the same field in primary key creation, you can modify getIndexFieldDeclarationListSQL from Doctrine\DBAL\Platforms\AbstractPlatform like :

    public function getIndexFieldDeclarationListSQL(array $fields)
    {
        $ret = array();

        foreach ($fields as $field => $definition) {
            if (is_array($definition)) {
                $ret[$field] = true;
            } else {
                $ret[$definition] = true;
            }
        }
        $ret = array_keys($ret);

        return implode(', ', $ret);
    }

But it would also be nice that doctrine don't try to drop the PK on each update.

[DDC-2412] [GH-651] Fixed typo in SQLFilter (use statement ClassMetadata)

Tue, 23 Apr 2013 17:50:21 +0000

This issue is created automatically through a Github pull request on behalf of EuKov:

Url: https://github.com/doctrine/doctrine2/pull/651

Message:

[DDC-2411] Null values get reset when rehydrating an already managed entity

Thu, 9 May 2013 10:31:16 +0000

Scenario:

1) You have an entity with a ManyToOne relation (and probably other kinds too, but this is all I have tested) to another entity which is nullable. For example, let's say you have a Book entity which has an "illustrator" field which refers to a Person entity, representing the person who illustrated the book. If the book is not illustrated then you set the field to null.

2) You fetch a Book (by ID) which has its illustrator set to a particular Person.

3) You set that Book's illustrator to null.

4) Without flushing, you fetch the Book again, using different criteria: for example, by title. Because entities are Identity Mapped, this will run a query but then locate the same instance in memory, and try to hydrate that instance with the old data it just fetched.

5) Any fields on the instance that have modified values retain their new values (for example, if we changed the illustrator to a different Person, this would be retained), BUT any fields on the instance which are null get overwritten with the old data (so if we previously set the illustrator to null, without flushing, it would now be reset to the Person value that it had before).

There seems to be a mistaken assumption here that null values are fields that have not been hydrated, when this is not necessarily the case. Is this the intended behaviour?

The code that causes this behaviour is here: https://github.com/doctrine/doctrine2/blob/e561f47cb2205565eb873f0643637477bfcfc2ff/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php#L471

If you are wondering why anybody would want to fetch the entity again in step 4, my use case for this is the Symfony Validator (but I presume there could be others).

If there are any unique constraints (Symfony ones, not Doctrine ones) on the entity, e.g. if we had a unique constraint on the Book title field, then when validating the Book the Symfony Validator would check if there are already any Book entities with the same title as the Book we're validating. It will find the Book that we are working with, and because entities are identity mapped, it will act upon the same instance, and the situation above occurs.

Code example:

<?php

// Create some entities

$john = new Person();
$john->setName('John Smith');

$jane = new Person();
$jane->setName('Jane Jones');

$joe = new Person();
$joe->setName('Joe Bloggs');

$book = new Book();
$book->setId(123);
$book->setTitle('Book Title');
$book->setIllustrator($john);
$book->setAuthor($jane);

$em->persist($john);
$em->persist($jane);
$em->persist($joe);
$em->persist($book);
$em->flush();

// Now let's try modifying the book

$book = $bookRepository->find(123);
$book->getIllustrator(); // returns Person "John Smith"
$book->getAuthor(); // returns Person "Jane Jones"

// make some changes
$book->setIllustrator(null); // illustrator is now null
$book->setAuthor($joe); // author is now "Joe Bloggs"

// now validate our changes with Symfony Validator
// note: the same effect can also be observed with
// $test = $bookRepository->findBy('title', 'Book Title');
$validator->validate($book);

// what happened to our book??
$book->getIllustrator(); // returns Person "John Smith" <- should be null
$book->getAuthor(); // returns Person "Joe Bloggs" <- correctly retains the new value

[DDC-2410] [GH-650] Fixed typo in SQLFilter addFilterConstraint first param

Tue, 23 Apr 2013 10:05:55 +0000

This issue is created automatically through a Github pull request on behalf of EuKov:

Url: https://github.com/doctrine/doctrine2/pull/650

Message:

Hi,

Description in subj,
the use statement for ClassMetaData is
use Doctrine\ORM\Mapping\ClassMetaData;

But in the abstract method the param named ClassMetadata ("d" char should be in uppercase)

[DDC-2409] Merge operation tries to add new detached entities to indentity map and load them as proxies

Sun, 5 May 2013 14:02:44 +0000

class A
    {
       /**
        *  @ORM\ManyToOne(targetEntity= "B"...
        *  @ORM\JoinColumn(name=" ...
        */
        protected $b;
        
        public function getB()
        {
            return $this->b;
        }
        
        public function setB($b)
        {
            $this->b = $b;
        }
}
    
    class B
	{
       /**
        * As
        *
        * @var \Doctrine\Common\Collections\Collection
        *
        * @ORM\OneToMany(targetEntity="A", mappedBy="B")
        */
		protected $As;
    }
	
	$b = new \B();
	
	$a = $em->find('A', 123);
	
	$a->setB($b);
	
	$em->detach($a);
	
	$em->detach($b);
	
	$b = $em->merge($b); // notice that $b now is merged
	
	$a = $em->merge($a); //  hangs as it creates the proxy for $b and tries to load a though __load even though $b is already managed

Couple of possible issues in the following code from doMerge:

if ($assoc2['type'] & ClassMetadata::TO_ONE) {
                        $other = $prop->getValue($entity);
                        if ($other === null) {
                            $prop->setValue($managedCopy, null);
                        } else if ($other instanceof Proxy && !$other->__isInitialized__) {
                            // do not merge fields marked lazy that have not been fetched.
                            continue;
                        } else if ( ! $assoc2['isCascadeMerge']) {
                            if ($this->getEntityState($other, self::STATE_DETACHED) !== self::STATE_MANAGED) {
                                $targetClass = $this->em->getClassMetadata($assoc2['targetEntity']);
                                $relatedId = $targetClass->getIdentifierValues($other);

                                if ($targetClass->subClasses) {
                                    $other = $this->em->find($targetClass->name, $relatedId);
                                } else {
                                    $other = $this->em->getProxyFactory()->getProxy($assoc2['targetEntity'], $relatedId);
                                    $this->registerManaged($other, $relatedId, array());
                                }
                            }
                            $prop->setValue($managedCopy, $other);
                        }

     $relatedId = $targetClass->getIdentifierValues($other);

$relatedId is emply as the detached $other was never flushed. It should never be used to add this entity to the identityMap ($this->registerManaged($other, $relatedId, array())

$other = $this->em->getProxyFactory()->getProxy($assoc2['targetEntity'], $relatedId);

This should never use the proxy factory for new detached entities as they are already merged back ($b). This method seems to not have any means to find managed $b.

If $b = $em->merge($b); was not called, the method would probably have worked but I think it is not right to rely on that calling or not calling certain methods or their order.

[DDC-2408] [GH-649] Update coding standards

Sun, 21 Apr 2013 19:07:43 +0000

This issue is created automatically through a Github pull request on behalf of calumbrodie:

Url: https://github.com/doctrine/doctrine2/pull/649

Message:

Removing underscores from property/method names and change use statements to PSR-2

[DDC-2407] AbstractExporter _getIdGeneratorTypeString does not know about the UUID generator

Sat, 20 Apr 2013 08:25:57 +0000

Shouldn't the AbstractExporter->_getIdGeneratorTypeString() method also know about the UUID generator ?

[DDC-2406] Merging of new detached entities with PrePersist lifecycle callback breaks

Wed, 1 May 2013 12:24:53 +0000

Merging of new detached entities with PrePersist lifecycle callback breaks:

Code snippet:

    class A
    {
       /**
        *  @ORM\ManyToOne(targetEntity= ...
        *  @ORM\JoinColumn(name=" ...
        */
        protected $b;
        
        public function getB()
        {
            return $this->b;
        }
        
        public function setB($b)
        {
            $this->b = $b;
        }
        
        /**
         *
         * @ORM\PrePersist
         *
         * @return void
         */
        public function onPrePersist()
        {
           if ($this->getB() === null) {
                throw new \Exception('B instance must be defined);
           }
           ....
        }
    }
    
    class B 
    {
    }
    
    $a = new A();
    $b = $em->find('B', 1);
    $a->setB($b);
    $em->persist($a); // works fine as B instance is set
    $em->detach($a);
    
    $a = $em->merge($a) // breaks in onPrePersist

The reason it happens is that the merge operation is trying to persist a new entity created by uow::newInstance($class) without populating its properties first:

 // If there is no ID, it is actually NEW.
    ....
    if ( ! $id) {
        $managedCopy = $this->newInstance($class);

        $this->persistNew($class, $managedCopy);
    } else {
	....

This should happen first for the $managedCopy:

    // Merge state of $entity into existing (managed) entity
    foreach ($class->reflClass->getProperties() as $prop) {
        ....

[DDC-2405] Changing strategy generates bad query.

Sun, 21 Apr 2013 14:50:37 +0000

For (unit, acceptance, functional) testing purpose I need to change the strategy of my GameStuff Entity class.

In previous version is was using php instruction below, but since doctrine orm 2.3, it doesn't work anymore.

$orm->getClassMetaData('Entities\GameStuff')->setIdGeneratorType(\Doctrine\ORM\Mapping\ClassMetadata::GENERATOR_TYPE_NONE);

will trigger:

Doctrine\DBAL\DBALException: An exception occurred while executing 'INSERT INTO vbank_accounts (game_id, updated_at, created_at) VALUES (?, ?, ?)' with params

{"1":1000010, "2":0,"3":"2013-04-19 17:16:05","4":"2013-04-19 17:16:05"}

SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens

[DDC-2404] Filter using join tables

Sun, 21 Apr 2013 18:01:47 +0000

Allow filters to add join tables to sql queries for filtering.

Let's have Brand entity, and BrandText entity. Text is localisation for each Brand. If there is no BrandText with bt.isPublic and bt.web_id = 123 I wanna filter it globally and not even allow to load Brand entity.

This cannot be solved by using DQL, because I need to affect lazily loaded associations, for example in templates

Accessing $product->brand-> in template should resolve to NULL, when there is no BrandText.isPublic = 1.

This could be solved by allowing filters to add joins to queries. Should I prepare a pull request?

[DDC-2403] most projects no longer listed on home page

Sat, 20 Apr 2013 08:00:12 +0000

the homepage of the doctrine project used to list phpcr-odm and some other projects. they recently disapeared. i think they should either all be listed or at least have a link to the projects page at the bottom of that shortlist, saying "all doctrine projects" (see also the discussion on the doctrine-dev mailinglist, i create a ticket here as nothing happened after that discussion)

[DDC-2402] [DOC] warning on serializing private properties: obsolete?

Fri, 19 Apr 2013 09:34:48 +0000

here we warn that when wanting to serialize properties, you should not have private properties as that would not work with proxies.

afaik doctrine commons 2.4 now handles that properly and we can drop that warning, right?

https://github.com/doctrine/doctrine2/blob/master/docs/en/reference/working-with-objects.rst#merging-entities

[DDC-2401] INDEX BY not working on multiple columns

Thu, 18 Apr 2013 20:17:31 +0000

According to the docs on this page:
http://docs.doctrine-project.org/en/latest/reference/dql-doctrine-query-language.html#using-index-by

The following "multi-dimensional index" should be perfectly possible, with a default hydration mode:
SELECT b as business, p as product FROM Businesses b INDEX BY b.id JOIN Products p WITH b.id = p.businessid INDEX BY p.id

However, b.id is completely ignored (it is a numeric primary key).

I tried to go further, giving 2 products a matching barcode and indexing by barcode and then a (unique, numeric) productid. Only the barcode worked as a key and only one of the products with a matching barcode was selected. I used this query to test:
SELECT p FROM Products p INDEX BY p.barcode JOIN p.businessid b INDEX BY p.id

I also flagged the docs, because I don't think a userid should/could be starting from 0.

[DDC-2400] [GH-648] Add a AddParameters method in the QueryBuilder

Sun, 14 Apr 2013 17:21:36 +0000

This issue is created automatically through a Github pull request on behalf of Taluu:

Url: https://github.com/doctrine/doctrine2/pull/648

Message:

Hi,

On doctrine 2.2, when we were calling the method `setParameters` to set a bunch of parameters on the QueryBuilder, each parameters were added or modified if they were already existing.

That is not the case since doctrine 2.3 : each calls to `setParameters` will wipe out the other already setted parameters. I think it is logic, but still is a huge BC break, which is not really mentionned in the UPGRADE file (only the once regarding the use of an ArrayCollection is mentionned).

With this PR, I added a `addParameters` which allows to add several parameters in several calls. Here is a use case :

```php
<?php
// ... A repository
class UserRepository extends EntityRepository
{
public function getUserWithSomething($criteriaA, $criteriaB, DateTime $since = null)
{
$qb = $this->createQueryBuilder('u');
$qb->where($qb->expr()~~>andX($qb~~>expr()->eq('u.criteriaA', ':criteriaA'),
$qb->expr()->eq('u.criteriaB', ':criteriaB')));

// wanna search for objects since a specific date
if (null !== $since)

{ $qb = $this->addSince($qb, $since); }

$qb->addParameters(new ArrayCollection(['criteriaA' => $criteriaA,
'criteriaB' => $criteriaB]));

return $qb->getQuery()->execute();
}

public function addSince(QueryBuilder $qb, DateTime $since)

{ $qb = $qb->andWhere($qb->expr()->gte('u.date', ':since')); return $qb->setParameter('since', $since); }

}
```

So, as I was saying, until 2.2, you could use `setParameters` in the main method (`getUserWithSomething`) which was calling (or not) the submethod `addSince`, which could set parameters before calling the `setParameters` method. Now, you can't do that anymore : either you need to make several calls to `setParameter` :

```php
<?php
// ....
$qb = $qb->setParameter('criteriaA', $criteriaA)
->setParameter('criteraB', $criteriaB);
//...
```

Either, I guess, you need to first retrieve all the parameters and then add them by hand :

```php
<?php
// ....
$parameters = $qb->getParameters();
$parameters->add(new Parameter('criteriaA', $criteriaA);
$parameters->add(new Parameter('criteriaB', $criteriaB);

$qb = $qb->setParameters($parameters);
//...
```

So that's why I propose this new method in the QueryBuilder. if I'm wrong anywhere, or need more information please feel free to comment.

Cheers.

[DDC-2399] unserializing returns proxyclass name with slashes

Fri, 12 Apr 2013 19:23:44 +0000

I serialize a "user"-entity using the following code:

$user->getBusinessid()->getId(); //this is necessary to load the proxy
$em->detach($user);
$_SESSION['user'] = serialize($user);

When I unserialize said entity with this code:

$em = self::getEntityManager();
$user = unserialize($_SESSION['user']);
return $em->merge($user);

I get an error like this:
require(): Failed opening required './core/project/Proxy/_CG_/core/project/Entity/Businesses.php' .

The thing is that everything after _CG_ should not have any forward slashes. In that case the path would be completely correct.

[DDC-2398] Add a "use namespace" like feature to DQL to have short/reusable entity classname

Thu, 11 Apr 2013 10:06:13 +0000

I find not always portable-friendly the use of full class path in DQL.

$query = $em->createQuery('SELECT u FROM \MyProject\Model\User u WHERE u.age > 20');

could be :

$query = $em->createQuery('USE \MyProject\Model SELECT u FROM User u WHERE u.age > 20');

or :

$query = $em->use('\MyProject\Model')->createQuery('SELECT u FROM User u WHERE u.age > 20');

And with a default namespace attached to the entity manager :

$query = $em->use()->createQuery('SELECT u FROM User u WHERE u.age > 20');

[DDC-2397] [GH-647] Bugfix/ddc 1048 cordoval

Fri, 12 Apr 2013 01:11:18 +0000

This issue is created automatically through a Github pull request on behalf of cordoval:

Url: https://github.com/doctrine/doctrine2/pull/647

Message:

[DDC-2396] [GH-646] Oracle Pagination bug when ordering is present

Sun, 14 Apr 2013 08:54:03 +0000

This issue is created automatically through a Github pull request on behalf of raykolbe:

Url: https://github.com/doctrine/doctrine2/pull/646

Message:

Please reference http://www.doctrine-project.org/jira/browse/DDC-1800 and http://www.doctrine-project.org/jira/browse/DDC-1958#comment-19969.

[DDC-2395] [GH-645] Fixes Oracle Pagination bug when ordering is present (e.g. Oracle subquery ordering)

Sun, 14 Apr 2013 09:10:02 +0000

This issue is created automatically through a Github pull request on behalf of raykolbe:

Url: https://github.com/doctrine/doctrine2/pull/645

Message:

See��http://www.doctrine-project.org/jira/browse/DDC-1800 for a full description of the problem.

[DDC-2394] QueryExpressionVisitor has no implementation of Comparison::CONTAINS

Sun, 14 Apr 2013 09:21:21 +0000

Use case

$criteria = Criteria::create();
$criteria
    ->andWhere(
        $criteria->expr()->contains('r.body', 'foo')
    )
;

$entities = $repo->createQueryBuilder()->addCriteria($criteria)->getQuery()->getResult();

Throws the following exception:

RuntimeException: Unknown comparison operator: CONTAINS

I except it to properly handle the CONTAINS comparison and result in a LIKE operator.

-------

I added a failing test case & a fix there: https://github.com/borisguery/doctrine2/tree/DDC-2394

[DDC-2393] Doctrine ORM put null to relation field when write persisting

Sun, 7 Apr 2013 12:31:33 +0000

There is my bundle, for more details:
https://github.com/hell0w0rd/bad-doctrine-entities

[DDC-2392] [GH-644] Fixed typos

Sat, 6 Apr 2013 14:50:28 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/doctrine2/pull/644

Message:

[DDC-2391] [GH-643] DDC-2390: Remove Query dependency in SqlWalker and Parser

Wed, 1 May 2013 09:10:31 +0000

This issue is created automatically through a Github pull request on behalf of beberlei:

Url: https://github.com/doctrine/doctrine2/pull/643

Message:

To prevent future problems with illegal Query parameter access and also to decouple the namespaces by removing bidirectional dependency.

[DDC-2390] Remove Parser and SQLWalker dependency on Query

Thu, 4 Apr 2013 19:35:02 +0000

Query is too powerful to be available in Parser and SQLWalker, because it may lead to accessing data that changes on subsequent runs of a query that is cached.

Idea is to introduce a MetadataBag that contains only the values that are allowed to be accessed.

[DDC-2389] [GH-642] replaced direct class in instance creation

Thu, 4 Apr 2013 14:47:37 +0000

This issue is created automatically through a Github pull request on behalf of dmishh:

Url: https://github.com/doctrine/doctrine2/pull/642

Message:

return new EntityManager() -> return new static() on line 945
made code more reusable

[DDC-2388] Zend Optimizer Plus/opcache have overlap in config settings, annotations reader doesn't identify these properly

Tue, 23 Apr 2013 01:15:55 +0000

Doctrine\Common\Annotations\AnnotationReader.php

A change was recently authored in the AnnotationReader constructor that checked for a properly configured opcode cache (namely saving comments so that Doctrine can parse annotations).

The current open source version of Zend Optimizer+ hosted at GitHub (https://github.com/zend-dev/ZendOptimizerPlus) when loaded registers itself as a module with the name "Zend Optimizer+" but takes configuration directives in the form of "opcache.<parameter>".

The change to the constructor requires that if the module name is Zend Optimizer+, then the configuration directives must be prefixed with "zend_optimizerplus.<parameter>". This is clearly incorrect.

The most recent update now complains of an AnnotationException as a consequence of this change when running Symfony2 (or Doctrine) with the latest opcache because configuration directives aren't detected properly.

I am happy to fix this but could not find a way to report an issue to initiate the process.

I would suggest something like this in the constructor:

if ((extension_loaded('Zend Optimizer+') || extension_loaded('opcache')) && !(ini_get('opcache.save_comments') == 0 XOR ini_get('zend_optimizerplus.save_comments') == 0)) {

What this means is that if either extension is loaded, one of those directives must be true and configured. This is a compromise. The alternative would be to keep the original source and do the following:

if (extension_loaded('Zend Optimizer+') && ini_get('zend_optimizerplus.save_comments') == 0) {
if (ini_get('opcache.save_comments') == 0)

{ throw AnnotationException::optimizerPlusSaveComments(); }

}

if (extension_loaded('opcache') && ini_get('opcache.save_comments') == 0)

{ throw AnnotationException::optimizerPlusSaveComments(); }

I have no idea about the "opcache" module and what it actually equates to or whether it has alternative formats for its configuration directives. I feel like the second suggestion is even smellier than my original suggestion despite probably handling the edge case better.

If you want a pull request, I will send one, just let me know how you want to handle it.

If my PHP is horrible I apologise.

[DDC-2387] convert-mapping not working correctly with composite primary keys/foreign keys in 2.4.0-RC1

Tue, 11 Jun 2013 11:39:19 +0000

(Apologies if this is somehow a Symfony-specific issue)

I updated my application via Composer yesterday, and received Doctrine 2.4.0-RC1. After this update, generating entities has been problematic under certain circumstances.

Here is an example table in MySQL:

CREATE TABLE `user_email` (
  `user_id` int(10) unsigned NOT NULL COMMENT 'FK to user',
  `email` varchar(254) NOT NULL,
  `email_datasource` smallint(1) unsigned NOT NULL COMMENT 'FK to datasource_code',
  `insert_date` datetime NOT NULL,
  PRIMARY KEY (`user_id`,`email`,`email_datasource`),
  KEY `FK_UserEmail_DataSourceCode` (`email_datasource`),
  CONSTRAINT `FK_UserEmail_User` FOREIGN KEY (`user_id`) REFERENCES `user` (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8

In Doctrine 2.3, the mapping works correctly, and you end up with a 3-part primary key, with a user property mapped to the User entity, and a datasourceCode property mapped to the DatasourceCode entity. All good.

In 2.4, the following error is given: Single id is not allowed on composite primary key in entity UserEmail.

Removing one of the foreign keys in the table (either to User or DatasourceCode) but keeping the primary key set to all 3 columns allows the mapping to work. But, if you then remove one of the columns from the primary key (say, email_datasource) it fails again.

[DDC-2386] [GH-641] Added yml example in ordered-associations.rst

Wed, 3 Apr 2013 16:37:26 +0000

This issue is created automatically through a Github pull request on behalf of bksunday:

Url: https://github.com/doctrine/doctrine2/pull/641

Message:

Added missing yaml example of ordered-associations, and put php, xml and yml codes into a configuration-block instead of separate code-blocks

[DDC-2385] [GH-640] [Paginator]Add hidden field ordering for postgresql

Tue, 2 Apr 2013 10:01:27 +0000

This issue is created automatically through a Github pull request on behalf of denkiryokuhatsuden:

Url: https://github.com/doctrine/doctrine2/pull/640

Message:

In postgresql environment, when some hidden fields are used in orderBy clause,
they're not property added because $rsm->scalarMappings don't have information about them.

This change fixes above.

I'm afraid I'm not sure which branch this will be merged, but anyway here's a patch.

[DDC-2384] [GH-639] Added abillity to use metacolumn as indexBy

Fri, 10 May 2013 06:53:44 +0000

This issue is created automatically through a Github pull request on behalf of goetas:

Url: https://github.com/doctrine/doctrine2/pull/639

Message:

Added ability to use meta column as indexBy. Useful if association entities is widely used.
Replace #204 PR

[DDC-2383] Foreign relations on primary keys don't work on more than two entities (like Foo<>Bar<>Baz)

Sun, 14 Apr 2013 10:05:59 +0000

I'm trying to accomplish something like this:
http://docs.doctrine-project.org/en/latest/tutorials/composite-primary-keys.html#use-case-2-simple-derived-identity

For two entities (Foo<>Bar) it works as expected but adding another entity related to Bar (so it's Foo<>Bar<>Baz) ends up with this error:

Fatal error: Uncaught exception 'Doctrine\ORM\Mapping\MappingException' with message 'The column id must be mapped to a field in class Entity\Bar since it is referenced by a join column of another class.' in C:\...\vendor\doctrine\orm\lib\Doctrine\ORM\Mapping\MappingException.php:203
Stack trace:
#0 C:\...\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\BasicEntityPersister.php(734): Doctrine\ORM\Mapping\MappingException::joinColumnMustPointToMappedField('Entity\Bar', 'id')
#1 C:\...\vendor\doctrine\orm\lib\Doctrine\ORM\UnitOfWork.php(2509): Doctrine\ORM\Persisters\BasicEntityPersister->loadOneToOneEntity(Array, Object(Entity\Bar))
#2 C:\...\vendor\doctrine\orm\lib\Doctrine\ORM\Internal\Hydration\ObjectHydrator.php(245): Doctrine\ORM\UnitOfWork->createEntity('Entity\Bar', Array, Array)
#3 C:\...\vendor\doctrine\orm\lib\Doctrine\ORM\Internal\Hydration\ObjectHydrator.php(424): Doctrine\ORM\Internal\Hydration\Ob in C:\...\vendor\doctrine\orm\lib\Doctrine\ORM\Mapping\MappingException.php on line 203

This error appears when there are some records in the database and I want to query for example all Foos.

My entites look like this:

//Entity/Foo.php

/** @Entity @Table(name="foos") */
class Foo
{
    /** @Id @Column(type="integer") @GeneratedValue */
    protected $id;

    /** @OneToOne(targetEntity="Bar", mappedBy="foo") */
    protected $bar;

    public function getId()
    {
        return $this->id;
    }

    public function getBar()
    {
        return $this->bar;
    }

    public function setBar($bar)
    {
        $bar->setFoo($this);
        $this->bar = $bar;
    }
}

//Entity/Bar.php

/** @Entity @Table(name="bars") */
class Bar
{
    /** @Id @OneToOne(targetEntity="Foo", inversedBy="bar")
     * @JoinColumn(name="id", referencedColumnName="id") */
    protected $foo;

    /** @OneToOne(targetEntity="Baz", mappedBy="bar") */
    protected $baz;

    public function __construct($foo)
    {
        $this->foo = $foo;
    }

    public function getId()
    {
        return $this->getFoo()->getId();
    }

    public function getFoo()
    {
        return $this->foo;
    }

    public function setFoo($foo)
    {
        $this->foo = $foo;
    }

    public function getBaz()
    {
        return $this->baz;
    }

    public function setBaz($baz)
    {
        $bar->setBar($this);
        $this->baz = $baz;
    }
}

//Entity/Baz.php

/** @Entity @Table(name="bazes") */
class Baz
{
    /** @Id @OneToOne(targetEntity="Bar", inversedBy="baz")
     * @JoinColumn(name="id", referencedColumnName="id") */
    protected $bar;

    public function __construct($bar)
    {
        $this->bar = $bar;
    }

    public function getId()
    {
        return $this->getBar()->getId();
    }

    public function getBar()
    {
        return $this->bar;
    }

    public function setBar($bar)
    {
        $this->bar = $bar;
    }
}

And fails on

$fooRepository = $em->getRepository('Entity\Foo');
$foos = $fooRepository->findAll();

[DDC-2382] Multiple relations between two same entities breaks cascade operations

Sun, 14 Apr 2013 10:10:53 +0000

/**
 * @Entity
 */

class User
{
/**
 * @Id
 * @Column(type="integer")
 * @GeneratedValue(strategy="AUTO")
 */

protected $id;

/**
 * @OneToMany(targetEntity="Post", cascade={"remove"}, mappedBy="author")
 */

 protected $posts;

/**
 * @OneToOne(targetEntity="Post")
 */

 protected $lastPost;

public function setLastPost( $post )
{
    $this->lastPost = $post;
}

  // ...skipped...

}


/**
 * @Entity
 */

class Post
{
/**
 * @Id
 * @Column(type="integer")
 * @GeneratedValue(strategy="AUTO")
 */

 protected $id;

/**
 *
 * @ManyToOne(targetEntity="User", inversedBy="posts")
 * @JoinColumn(nullable=false)
 */

protected $author;

public function setAuthor( $author )
{
    $this->author = $author;
}

// ...skipped...
}

// Let's create user and post

$user = new User();
$em->persist($user);

$post = new Post();
$em->persist($post);

$post->setUser($user);
$user->setLastPost($post);

$em->flush();

// and now remove user

$user = $em->find('User', 1);
$em->remove($user);

$em->flush(); 
// "The DELETE statement conflicted with the REFERENCE 
// constraint...".
// Doctrine removes record from "User" table, ignoring associated records from "Post" table. If i remove "lastPost" relation 
//from User entity everything goes OK - at first Doctrine removes assiciated posts, then removes user itself.

[DDC-2381] Pagination query can be simplified when simple joins are applied

Mon, 8 Apr 2013 22:32:03 +0000

Hi.
In mysql db table i have > 200,000 items.
I use native doctrine pagination for paging the items list.
But generated query that gets ids for items list in paging works more then 150 sec on my workstation

SELECT DISTINCT id0 FROM (SELECT m0_.id AS id0, m0_.title AS title1, m0_.text AS text2, m0_.price AS price3, m0_.originalPrice AS originalPrice4, m0_.condition_type AS condition_type5, m0_.image_1 AS image_16, m0_.image_2 AS image_27, m0_.image_3 AS image_38, m0_.image_4 AS image_49, m0_.image_5 AS image_510, m0_.video AS video11, m0_.contact_email AS contact_email12, m0_.contact_name AS contact_name13, m0_.contact_phone AS contact_phone14, m0_.contact_type AS contact_type15, m0_.published AS published16, m0_.type AS type17, m0_.status AS status18, m0_.highlight AS highlight19, m0_.urgent AS urgent20, m0_.topads AS topads21, m0_.period AS period22, m0_.hits AS hits23, m0_.ip AS ip24, m0_.created_at AS created_at25, m0_.updated_at AS updated_at26 FROM milla_message m0_ INNER JOIN milla_currency m1_ ON m0_.currency_id = m1_.id INNER JOIN milla_category m2_ ON m0_.category_id = m2_.id INNER JOIN milla_region m3_ ON m0_.region_id = m3_.id INNER JOIN milla_city m4_ ON m0_.city_id = m4_.id WHERE m0_.status = 1 ORDER BY m0_.published DESC) dctrn_result LIMIT 20 OFFSET 0

source code
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php#L141

why SELECT DISTINCT %s FROM (%s) dctrn_result ???
why not SELECT DISTINCT m0_.id AS id0 FROM milla_message m0_ WHERE m0_.status = 1 ORDER BY m0_.published DESC LIMIT 20 OFFSET 0

[DDC-2380] [GH-638] Fixed typos in docblocks.

Mon, 1 Apr 2013 21:40:46 +0000

This issue is created automatically through a Github pull request on behalf of dustinmoorman:

Url: https://github.com/doctrine/doctrine2/pull/638

Message:

Hello again, I'm committing the mini fixes in docblock documentation - swapping 'an SQL' for 'a SQL'.

Thanks!

[DDC-2379] [GH-637] Update association-mapping.rst

Sat, 30 Mar 2013 13:56:28 +0000

This issue is created automatically through a Github pull request on behalf of choomz:

Url: https://github.com/doctrine/doctrine2/pull/637

Message:

[DDC-2378] Efficient count using Selectable

Thu, 28 Mar 2013 23:56:42 +0000

Hi,

I'm currently using intensively the Criteria and Selectable interfaces to provide a generic REST library.

However, I've found a problem when I want to paginate data:

count

return count($this->selectable->matching(new Criteria()));

The problem is that EntityRepository returns an ArrayCollection and, hence, load the whole collection which is inefficient. It would be nice if it could return a PersistentCollection instead with lazy-load and perform an optimized count.

Thanks

[DDC-2377] [GH-636] Fixed typos in documentation.

Thu, 28 Mar 2013 06:46:14 +0000

This issue is created automatically through a Github pull request on behalf of dustinmoorman:

Url: https://github.com/doctrine/doctrine2/pull/636

Message:

Hello again everyone! I went ahead and fixed the rest of the instances in the documentation that used 'an SQL'. I also fixed an instance of 'a alias' to be 'an alias', which is proper since alias begins with a vowel.

[DDC-2376] [GH-635] Function test for addManyToOne database column mapping

Sat, 30 Mar 2013 21:43:42 +0000

This issue is created automatically through a Github pull request on behalf of TomHAnderson:

Url: https://github.com/doctrine/doctrine2/pull/635

Message:

When the PHPDriver is used to create a ManyToOne relationship with a table which has a primary key other than id the primary key is not associated correctly.

[DDC-2375] Join with multiples tables

Wed, 27 Mar 2013 14:39:30 +0000

Dear Friends, I've a question about Join with multiple tables.
I've 3 tables: Country, State, City, and I need get country_name from City Entity.
Any suggestion?

Table City:
city_id
state_id
city_name

Table State
state_id
country_id
state_name

Table Country
country_id
country_name

This is my Entity City:

<?php

namespace System\Entity;

use Doctrine\ORM\Mapping as ORM,
Doctrine\Common\Collections\ArrayCollection;

/**

    SysCity
    *
    @ORM\Table(name="sys_city")
    @ORM\Entity(repositoryClass="System\Entity\SysCityRepository")
    */
    class SysCity
    {
    /*
    Instantiate all methods gets and sets
    */

public function __construct($options = null)
{ Configurator::configure($this, $options); }

/**

    @var integer
    *
    @ORM\Column(name="id_city", type="integer", nullable=false)
    @ORM\Id
    @ORM\GeneratedValue(strategy="IDENTITY")
    */
    private $idCity;

/**

    @var string
    *
    @ORM\Column(name="city", type="string", length=255, nullable=false)
    */
    private $city;

/**

    @var \SysState
    *
    @ORM\ManyToOne(targetEntity="System\Entity\SysState", inversedBy="state")
    @ORM\JoinColumns( { * @ORM\JoinColumn(name="id_state", referencedColumnName="id_state") * }

    )
    */
    private $idState;

/**

    @var \SysCountry
    *
    @ORM\ManyToMany(targetEntity="System\Entity\SysCountry", inversedBy="country")
    @ORM\JoinTable(name="sys_state",
    joinColumns= {@ORM\JoinColumn(name="id_state", referencedColumnName="id_state")}

    ,
    inverseJoinColumns= {@ORM\JoinColumn(name="id_country", referencedColumnName="id_country")}
    )
    */
    private $idCountry;

public function getIdCity()
{ return $this->idCity; }

public function setIdCity($idCity)
{ $this->idCity = $idCity; return $this; }

public function getCity()
{ return $this->city; }

public function setCity($city)
{ $this->city = $city; return $this; }

public function getIdState()
{ return $this->idState; }

public function setIdState($idState)
{ $this->idState = $idState; return $this; }

public function getIdCountry()
{ return $this->idCountry; }

public function setIdCountry($idCountry)
{ $this->idCountry = $idCountry; return $this; }

Thanks a lot!

[DDC-2374] [GH-634] [WIP] Value objects

Reference — Sun, 14 Apr 2013 10:18:46 +0000

This issue is created automatically through a Github pull request on behalf of beberlei:

Url: https://github.com/doctrine/doctrine2/pull/634

Message:

This pull request takes a different approach than GH-265 to implement ValueObjects. Instead of changing most of the code in every layer, we just inline embedded object class metadata into an entities metadata and then use a reflection proxy that looks like "ReflectionProperty" to do the rewiring.

The idea is inspired from Symfony Forms 'property_path' option, where you can write and read values to different parts of an object graph.

This is a WIP, there have been no further tests made about the consequences of this approach. The implementation is up for discussion.

[DDC-2373] [GH-633] [DDC-2042] Added "targetEntity" to AssociationOverride

Wed, 27 Mar 2013 06:40:39 +0000

This issue is created automatically through a Github pull request on behalf of spezifanta:

Url: https://github.com/doctrine/doctrine2/pull/633

Message:

Hey,

I needed to override "targetEntity" so I forked Doctrine and applyed it myself. Just after that I found a Ticket DDC-2042 in your Jira so I added a unit test to and would be more than happy to see this commit get merged in to the main master (at some point ).

Cheers, Alex

I will stick around in the #doctrine-dev on Freenode for any questions. My nick there is "fanta".

Keep up the good work.

/**

@ORM\Entity
@ORM\Table(name="customer")
@ORM\AssociationOverrides( { * @ORM\AssociationOverride(name="products", * targetEntity="MyNewProduct" * ) * }
)
*/

[DDC-2372] [GH-632] entity generator - ignore trait properties and methods

Tue, 26 Mar 2013 19:54:23 +0000

This issue is created automatically through a Github pull request on behalf of Padam87:

Url: https://github.com/doctrine/doctrine2/pull/632

Message:

Fixes:

DDC-1825
DDC-2154

[DDC-2371] [GH-631] Fix typo in one of the orderBy examples.

Wed, 27 Mar 2013 02:19:31 +0000

This issue is created automatically through a Github pull request on behalf of aaronmu:

Url: https://github.com/doctrine/doctrine2/pull/631

Message:

Fix typo in one of the orderBy examples.

[DDC-2370] Subclass annotations not being read, unable to use OneToMany relation with single table inheritance

Wed, 1 May 2013 19:18:25 +0000

Subclasses that override parent class properties and define relations will not work as expected, because AnnotationDriver/Reader will only use the parent class annotation (discarding whatever subclass defined).

The following code will produce error:

[Mapping]  FAIL - The entity-class 'Test\Office' mapping is invalid:
* The mappings Test\Office#employees and Employee#office are incosistent with each other.

Test code:

<?php
namespace Test;
 
use Doctrine\ORM\Mapping as ORM;
 
/**
 * @ORM\Entity
 */
class Office 
{
    /**
     * @ORM\OneToMany(targetEntity="Person", mappedBy="office")
     * @var Person[]|ArrayCollection
     */
    protected $people;
 
    /**
     * @ORM\OneToMany(targetEntity="Employee", mappedBy="office")
     * @var Employee[]|ArrayCollection
     */
    protected $employees;
 
}
 
/**
 * @ORM\Entity
 * @ORM\InheritanceType("SINGLE_TABLE")
 * @ORM\DiscriminatorColumn(name="type", type="string")
 * @ORM\DiscriminatorMap({"employee" = "Employee"})
 */
class Person
{
    /**
     * @ORM\ManyToOne(targetEntity="Office", inversedBy="people")
     * @var Office
     */
    protected $office;
}
 
/**
 * @ORM\Entity
 */
class Employee extends Person
{
    /**
     * @ORM\ManyToOne(targetEntity="Office", inversedBy="employees")
     * @var Office
     */
    protected $office;
}

[DDC-2369] [GH-630] Hotfix for DDC-2359

Sun, 24 Mar 2013 19:23:57 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/630

Message:

`Doctrine\ORM\Mapping\ClassMetadataFactory#wakeupReflection` is called twice as of ~~DDC-2359~~

[DDC-2368] [GH-629] Fixed typos in Doctrine Mapping Types section.

Sun, 24 Mar 2013 17:00:55 +0000

This issue is created automatically through a Github pull request on behalf of dustinmoorman:

Url: https://github.com/doctrine/doctrine2/pull/629

Message:

Hello guys! I am fixing some of the documentation in ``basic-mapping.rst`` that display an incorrect use of 'an' where 'a' should reside. Specifically in regards to instances of 'an SQL'.

[DDC-2367] [GH-628] [Docs] Fix field name in inversedby parameter

Sun, 24 Mar 2013 16:57:09 +0000

This issue is created automatically through a Github pull request on behalf of franmomu:

Url: https://github.com/doctrine/doctrine2/pull/628

Message:

[DDC-2366] [GH-627] update document on Doctrine cache provider

Sun, 24 Mar 2013 20:22:32 +0000

This issue is created automatically through a Github pull request on behalf of chuanma:

Url: https://github.com/doctrine/doctrine2/pull/627

Message:

A number of methods have been deleted long time ago. But they still show up on the document page.

http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/caching.html#deleting

http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/caching.html#counting

I checked source code. Most of the methods don't exist. They are better to be removed from the doc. I tried to use those functions and was surprised that they didn't exist.

[DDC-2365] [GH-626] default discriminator map - full namespace

Sat, 30 Mar 2013 23:08:27 +0000

This issue is created automatically through a Github pull request on behalf of Padam87:

Url: https://github.com/doctrine/doctrine2/pull/626

Message:

Using Symfony2, if you have two entities with the same name in different bundles, automatic discriminator map detection will trow MappingException.

If the namespace is included, there should be no more duplicate key issues.

(In this case, setting the map manually is not an option)

[DDC-2364] [GH-625] [DDC-2363] Duplicated record with orphanRemoval and proxy

Fri, 22 Mar 2013 17:39:26 +0000

This issue is created automatically through a Github pull request on behalf of mmenozzi:

Url: https://github.com/doctrine/doctrine2/pull/625

Message:

See http://www.doctrine-project.org/jira/browse/DDC-2363.

[DDC-2363] Duplicated record with orphanRemoval and proxy

Fri, 22 Mar 2013 15:07:11 +0000

There is a problem that causes duplicate records are created when EntityManager has to remove an entity due to orphanRemoval. The problem occurs only with a double flush and referred object is a proxy.

I'm trying to submit a pull request for this ticket. Please, stand by.

[DDC-2362] [GH-624] Fix getSQLTableAlias for postgre camelized table name

Wed, 1 May 2013 12:43:07 +0000

This issue is created automatically through a Github pull request on behalf of cedriclombardot:

Url: https://github.com/doctrine/doctrine2/pull/624

Message:

In postgreSQL with old databases we can have camelized model names to query on we need to add quote around the table name like :

```

@ORM\Table(name="""someThing""")
```

But when query is built the alias taken will be `"` this fix will find the good alias to use enabling to query camelized tables

[DDC-2361] [GH-623] Related to DDC-2282

Sun, 14 Apr 2013 09:57:22 +0000

This issue is created automatically through a Github pull request on behalf of AaronDDM:

Url: https://github.com/doctrine/doctrine2/pull/623

Message:

This is related to the patch��~~DDC-2282~~, the same patch also needs to be applied here, exact same issue.

[DDC-2360] [GH-622] Import EntityManager from proper namespace

Wed, 1 May 2013 12:43:56 +0000

This issue is created automatically through a Github pull request on behalf of hrubi:

Url: https://github.com/doctrine/doctrine2/pull/622

Message:

[DDC-2359] ClassMetadataFactory::wakeupReflection() is called twice

Sun, 24 Mar 2013 19:24:09 +0000

ClassMetadataFactory::wakeupReflection() is called in Common\...\AbstractClassMetadataFactory::loadMetadata() at the end of the method. A few lines after that ORM\...\ClassMetadatafactory::doLoadMeadata() is called, where wakeupReflection() was already called. I think this has been overlooked during the refactoring of the factories. I think the call in doLoadMetadata() is redundant..

[DDC-2358] [GH-621] [doc] adding some more doc and examples for lifecycle event listeners and subscribers

Sat, 6 Apr 2013 15:05:08 +0000

This issue is created automatically through a Github pull request on behalf of dbu:

Url: https://github.com/doctrine/doctrine2/pull/621

Message:

as requested in https://github.com/symfony/symfony-docs/pull/2301

[DDC-2357] [GH-620] Chaining for EM

Mon, 18 Mar 2013 16:18:58 +0000

This issue is created automatically through a Github pull request on behalf of pomaxa:

Url: https://github.com/doctrine/doctrine2/pull/620

Message:

Chaining for EM methods persist()/flush(), to write more elegant code $em->persist($account)->flush();

[DDC-2356] [GH-619] [DDC-2090] Fix MultiTableUpdateExecutor with query cache

Sun, 17 Mar 2013 20:39:58 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/619

Message:

http://www.doctrine-project.org/jira/browse/DDC-2090

[DDC-2355] [GH-618] [DDC-2188] Fix arithmetic priority

Sat, 6 Apr 2013 14:57:44 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/618

Message:

Hi guys,

This patch fix ~~DDC-2188~~(http://www.doctrine-project.org/jira/browse/DDC-2188),
Not sure if it could be considered a BC break.

Cheers

[DDC-2354] [GH-617] Wrong UnitOfWork::computeChangeSet()

Sat, 16 Mar 2013 16:18:27 +0000

This issue is created automatically through a Github pull request on behalf of fchris82:

Url: https://github.com/doctrine/doctrine2/pull/617

Message:

Sometimes some fields are Proxy when compute "changeSet". If it is Proxy, some listeners - example Gedmo sortable listener - belive the value has changed and this leads to chaos.

I check the $actualValue, if it is Proxy, the value didn't change.

[DDC-2353] [GH-616] [DDC-2252] Fix delete many-to-many composite key

Sat, 6 Apr 2013 17:58:10 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/616

Message:

http://www.doctrine-project.org/jira/browse/DDC-2252

[DDC-2352] [GH-615] Update SqlWalker.php

Fri, 15 Mar 2013 12:53:47 +0000

This issue is created automatically through a Github pull request on behalf of mikemeier:

Url: https://github.com/doctrine/doctrine2/pull/615

Message:

Always be sure that only a-z characters are used for table alias, otherwise use generic "t" for "table"

[DDC-2351] Entity Listener vs. Event Listener

Fri, 15 Mar 2013 08:45:49 +0000

Entity Listener and Event Listener don't get same events. An example is the onFlush event, which Entity Listener doesn't get. Why are both listeners receiving different events and not same events?

For consistency I'd like to see that both get same events - if I understand the purpose of Entity Listener correctly: it should be an alternative to Event Listener with same functionality but is bound to an entity.

[DDC-2350] [GH-614] ObjectHydrator: fix entity namespaces.

Sat, 4 May 2013 11:48:33 +0000

This issue is created automatically through a Github pull request on behalf of jelmersnoeck:

Url: https://github.com/doctrine/doctrine2/pull/614

Message:

Object Hydrator: fix entity namespaces

If you are using Entity Namespace aliases, the ObjectHydrator will throw a notice for an undefined index of your entity namespace.

1. Problem
  The problem lies in the fact that the prepare() method uses the "className", used in the aliasMap (where you use the namespace alias) to store the local ClassMetadata cache. Though, in a later stage the actual namespace is being used to find this same item.

1. Fix
  I've changed the way this ClassMetadata cache is built. It now uses the full Entity namespace.

[DDC-2349] [GH-613] Added ability to eagerly load referenced entities with subclasses

Sat, 6 Apr 2013 15:00:49 +0000

This issue is created automatically through a Github pull request on behalf of stefankleff:

Url: https://github.com/doctrine/doctrine2/pull/613

Message:

This is a rather ugly implementation. But maybe someone knows how to do it in a better way

[DDC-2348] [GH-612] Fixed failing tests

Thu, 14 Mar 2013 21:02:01 +0000

This issue is created automatically through a Github pull request on behalf of norzechowicz:

Url: https://github.com/doctrine/doctrine2/pull/612

Message:

[DDC-2347] Refresh Uniqueidentifier ID from mssql of inserted Entity in doctrine2.3

Wed, 13 Mar 2013 08:11:55 +0000

I don't want you to report something that isn't a bug.
But I read about problems with doctrine2 and mssql uniqueid's.
So First I asked a question at stackoverflow. No one could help me, and the only one who gave me a comment thought the same then me, that it looks like a bug.

If it isn't a bug I'm very sorry for this issue report.

Issue as reported in
http://stackoverflow.com/questions/15368082/refresh-uniqueidentifier-id-from-mssql-of-inserted-entity-in-doctrine2

[DDC-2346] [GH-611] Fixed typo in hints. Caused slow loading of eager entities.

Sun, 14 Apr 2013 07:53:22 +0000

This issue is created automatically through a Github pull request on behalf of stefankleff:

Url: https://github.com/doctrine/doctrine2/pull/611

Message:

This small typo prevents entities from being fetched with the deferred- eager-loading path.

[DDC-2345] convertObjectParameterToScalarValue() raises a notice

Wed, 1 May 2013 17:49:00 +0000

In Doctrine\ORM\AbstractQuery.php, the method convertObjectParameterToScalarValue() can raise a Notice.
This code:

$value = $values[$class->getSingleIdentifierFieldName()];

should be changed in this one:

if (isset($values[$class->getSingleIdentifierFieldName()])) {
    $value = $values[$class->getSingleIdentifierFieldName()];
}

[DDC-2344] [GH-609] Fixed typo.

Mon, 11 Mar 2013 22:42:38 +0000

This issue is created automatically through a Github pull request on behalf of haroldb:

Url: https://github.com/doctrine/doctrine2/pull/609

Message:

[DDC-2343] [GH-608] Fixed typo

Mon, 11 Mar 2013 01:55:52 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/doctrine2/pull/608

Message:

[DDC-2342] [GH-607] Fixed typos

Mon, 11 Mar 2013 01:57:09 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/doctrine2/pull/607

Message:

[DDC-2341] [GH-606] Don't add empty Expr to another one

Tue, 12 Mar 2013 18:20:26 +0000

This issue is created automatically through a Github pull request on behalf of jean-gui:

Url: https://github.com/doctrine/doctrine2/pull/606

Message:

Doctrine should not allow to add an empty Expr to another one. Current code allows that, which can lead to wrong DQL.
Example 1:
```php
$andExpr = $this->_expr->andx();
$andExpr->add($this->_expr->andx());
$andExpr->add($this->_expr->eq(1, 1));
echo $andExpr;
```
will output:
```sql
AND 1 = 1
```
instead of:
```sql
1 = 1
```

Example 2:
```php
echo $andExpr;
```
will output:
```sql
AND AND
```
instead of nothing.

IRC log of the discusion on #doctrine:
```irc
[jeudi 7 mars 2013] [14:36:18] <Jean-Gui> [jeudi 7 mars 2013] [14:36:35] <Jean-Gui> [jeudi 7 mars 2013] [14:37:17] <Jean-Gui> [jeudi 7 mars 2013] [14:37:39] <Jean-Gui> [jeudi 7 mars 2013] [14:39:49] <Jean-Gui> [jeudi 7 mars 2013] [14:41:03] <ocramius> [jeudi 7 mars 2013] [14:41:42] <Jean-Gui> [jeudi 7 mars 2013] [14:43:29] <ocramius> [jeudi 7 mars 2013] [14:43:34] <ocramius> [jeudi 7 mars 2013] [14:45:37] <Jean-Gui> [jeudi 7 mars 2013] [14:45:45] <Ninj> [jeudi 7 mars 2013] [14:46:07] <Jean-Gui> [jeudi 7 mars 2013] [14:46:30] <Ninj> [jeudi 7 mars 2013] [14:47:12] <alcuadradoatwork> [jeudi 7 mars 2013] [14:47:18] <ocramius> [jeudi 7 mars 2013] [14:47:24] <alcuadradoatwork> [jeudi 7 mars 2013] [14:48:07] <Ninj> [jeudi 7 mars 2013] [14:48:20] <Jean-Gui> [jeudi 7 mars 2013] [14:48:31] * Jean-Gui [jeudi 7 mars 2013] [14:48:49] <alcuadradoatwork> [jeudi 7 mars 2013] [14:49:18] <Ninj> [jeudi 7 mars 2013] [14:49:28] <Jean-Gui> [jeudi 7 mars 2013] [14:49:45] <ocramius> [jeudi 7 mars 2013] [14:50:03] <alcuadradoatwork> [jeudi 7 mars 2013] [14:50:32] <alcuadradoatwork> [jeudi 7 mars 2013] [14:51:19] <ocramius> [jeudi 7 mars 2013] [14:51:38] <alcuadradoatwork> [jeudi 7 mars 2013] [14:51:47] <Ninj> [jeudi 7 mars 2013] [14:52:46] <Jean-Gui> [jeudi 7 mars 2013] [14:53:16] <Ninj> [jeudi 7 mars 2013] [14:53:37] <Ninj> [jeudi 7 mars 2013] [14:53:55] <Jean-Gui> [jeudi 7 mars 2013] [14:55:01] <Jean-Gui> [jeudi 7 mars 2013] [14:55:43] <Ninj> ``` hi
I have a question about Doctrine/ORM/Query/Expr/Base.php
looking at the add function (https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query/Expr/Base.php#L89), the first if seems wrong
[[ if ( $arg !== null || ($arg instanceof self && $arg->count() > 0) ) ]]
if $arg is not null, then it will get added even if $arg->count === 0
yes
that doesn't seem right, does it?
why not?
can you elaborate?
that "if" seems to be meaning that the function shouldn't add $arg if $arg->count() equals 0
ocramius: i think Jean-Gui means that the right side of the OR will be called only if the left side is false, which means $arg is null. And if $arg is null it cannot be an object
right
this condition is indeed bugged
I see Jean-Gui's point too
write a test case then
maybe it works right, but it's confusing
this condition will not throw any error because the "instanceof" will prevent the $arg::count function to be called on a null object, but it is still useless
I think [[ if ( $arg Unable to render embedded object: File (== null && () not found.($arg instanceof self) || ($arg instanceof self && $arg->count() > 0)) ) ]] would work better
will look into how to submit bug reports
isn't this enough? if ($arg instanceof self && $arg->count() > 0)
i think it is, alcuadradoatwork
no, because if $arg is not an instance of self, I think we still want to add it
alcuadradoatwork: again... if it is a buggy condition, write a small test and open a PR
ocramius, it depends on your definition of "buggy"
it won't damage the behavior of the software, but it's quality its kind of pour
alcuadradoatwork: yes, still it needs coverage. I didn't say it needs a FAILING test
I see your point
if the logic is : "add any non-null object, but if it's self so add it only if count>0" then it must be rewriten
$args should be added if it's an instance of self or $_allowedClasses
hum
$args should be added if it's an instance of self with count > 0 or any other $_allowedClasse
yes, Ninj
thanks for your help guys, I'll submit a bug report with some test cases
your welcome Jean-Gui

[DDC-2340] Using Criteria matching on non-initialized collections ignore changes made on loaded entities

Tue, 12 Mar 2013 21:54:35 +0000

Given:

you have a non initialized collection (association between entities)
you have loaded some entities that are in that collection and changed some fields (without flushing)

If you do a matching using a Criteria on the collection (http://docs.doctrine-project.org/en/latest/reference/working-with-associations.html#filtering-collections), then the Criteria will be executed through a DB query. But the fields you changed are not updated in the DB, so if you filter/order on those fields, then the result of the filter() will be incorrect.

However, if your collection was initialized, the Criteria matching will be done in memory on the ArrayCollection and the result will be correct.

So we have the problem for Criteria filtering on non-initialized collections.

[DDC-2339] [GH-605] DDC-2338 Added failing test for composite foreign key persistance

Thu, 9 May 2013 15:23:13 +0000

This issue is created automatically through a Github pull request on behalf of alex88:

Url: https://github.com/doctrine/doctrine2/pull/605

Message:

I've added this test regarding ticket DDC-2338

[DDC-2338] Entity with composite foreign keys identifiers should be persisted after related entities without exception

Thu, 7 Mar 2013 09:40:20 +0000

I've seen that when you create an entity with a composite foreign key as identifier it cannot be flushed until the related entities are already flushed to the database and not just persisted.

It would be nice to let the user flush all the entities together and just INSERT first the related entities to get the ID and then use that to INSERT the entity with composite foreign keys.

I'm going to create a pull request with the failing test.

[DDC-2337] Allow an entity to use its own persister to take advantage of DB level features if necessary

Wed, 6 Mar 2013 20:17:54 +0000

I have a situation where I wanted a single table to use INSERT DELAYED. Its an audit log table where I expect each http request to generate many inserts for. In an effort to not over tax the system I implemented a custom Entity Persister so that it would work. This obviously doesn't work with all mapping drivers. However if this is a feature that you think is worth integrating I will fork it on github and complete the implementation alongside any changes/improvements requested...

[DDC-2336] [GH-604] Added support for string functions in OrderBy clause

Tue, 12 Mar 2013 18:28:23 +0000

This issue is created automatically through a Github pull request on behalf of bramstroker:

Url: https://github.com/doctrine/doctrine2/pull/604

Message:

Extended the OrderBy parser to support string functions directly in the

[DDC-2335] [GH-603] Add a filter to the import and convert mapping

Thu, 9 May 2013 14:20:30 +0000

This issue is created automatically through a Github pull request on behalf of nicolasTheodo:

Url: https://github.com/doctrine/doctrine2/pull/603

Message:

Hi,

I needed to import the mapping of an existing database in order to create doctrine2 entities, but when you run the command, it throw an exception on every table without a primary key.

I tried to use the filter option, but the error still occurs because the exception was throw in the method which get all the metadata informations.

I added a method which get the metadata of some tables according to a filter.

What are your thought bout my issue?

[DDC-2334] [GH-602] Added $isIdentifierColumn documentation

Tue, 12 Mar 2013 18:31:15 +0000

This issue is created automatically through a Github pull request on behalf of alex88:

Url: https://github.com/doctrine/doctrine2/pull/602

Message:

I've added the documentation of the argument $isIdentifierColumn since in case of foreign composite keys it doesn't��hydrate more then one row.

[DDC-2333] [GH-601] Add 'contains' comparison

Tue, 12 Mar 2013 18:38:48 +0000

This issue is created automatically through a Github pull request on behalf of jankramer:

Url: https://github.com/doctrine/doctrine2/pull/601

Message:

As mentioned by @stof in doctrine/collections#5, the 'contains' comparison for matching collections should also be added to the ORM.

The first commit is only present in this PR because the doctrine/collections 1.0 release does not contain the recent addition. It should be removed/altered after a new version has been tagged, I think?

[DDC-2332] [UnitOfWork::doPersist()] The spl_objact_hash() generate not unique hash!

Thu, 30 May 2013 05:04:37 +0000

I created fixtures and some data was inserted many times without calling the Task entity PrePersist event listener.

I printed the used and generated hash and I saw a Proxies_CG_\Asitly\ProjectManagementBundle\Entity\User hash equal a Task entity hash!

[DDC-2331] [GH-600] [PreUpdateEventArgs] Allows to add a new value on the entity changeset

Tue, 5 Mar 2013 09:33:16 +0000

This issue is created automatically through a Github pull request on behalf of egeloen:

Url: https://github.com/doctrine/doctrine2/pull/600

Message:

Hey!

I propose to add a `addNewValue` method on the `PreUpdateEventArgs`. This method allows to add a new value on the entity changeset when the entity changeset does not wrap the field.

In one of my app, I need to update a field if an entity is updated but the field is not updated at the beginning.

[DDC-2330] [GH-599] Removed unnecessary "
Mon, 4 Mar 2013 22:39:09 +0000

This issue is created automatically through a Github pull request on behalf of alexcarol:

Url: https://github.com/doctrine/doctrine2/pull/599

Message:

[DDC-2329] [GH-598] adds a new output format

Tue, 5 Mar 2013 00:47:49 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/doctrine2/pull/598

Message:

same as doctrine/dbal#279

[DDC-2328] [GH-597] use the extended proxy interface in the same namespace

Sun, 3 Mar 2013 20:11:16 +0000

This issue is created automatically through a Github pull request on behalf of MDrollette:

Url: https://github.com/doctrine/doctrine2/pull/597

Message:

Fix for this error:

FatalErrorException: Compile Error: Cannot use Doctrine\Common\Proxy\Proxy as Proxy because the name is already in use in .../vendor/doctrine/orm/lib/Doctrine/ORM/Proxy/ProxyFactory.php line 26

[DDC-2327] [GH-596] Missing link to a cookbook in the docs

Mon, 4 Mar 2013 22:18:56 +0000

This issue is created automatically through a Github pull request on behalf of mnapoli:

Url: https://github.com/doctrine/doctrine2/pull/596

Message:

The cookbook existed in the docs but there was no link to it in the docs.

[DDC-2326] [GH-595] Fixed broken code block in documentation

Tue, 12 Mar 2013 18:32:21 +0000

This issue is created automatically through a Github pull request on behalf of mnapoli:

Url: https://github.com/doctrine/doctrine2/pull/595

Message:

[DDC-2325] [GH-594] Use inflector in EntityGenerator

Fri, 1 Mar 2013 00:08:57 +0000

This issue is created automatically through a Github pull request on behalf of v3labs:

Url: https://github.com/doctrine/doctrine2/pull/594

Message:

The way EntityGenerator handles add/edit methods is wrong.

Example:

class SomeEntity

{ /* @ORM\OneToMany(...) */ private $entries; }

In this case the generator creates

addEntrie and removeEntrie methods. They should be be addEntry and removeEntry

This patch fixes that.

[DDC-2324] mapOneToMany not working after upgrade to symfony2.1

Mon, 4 Mar 2013 22:17:57 +0000

After updating to from symfony 2.0 to symfony 2.1, creating a new mapping did not work when using \Doctrine\ORM\Mapping\ClassMetadata::mapOneToMany().

The code used was:

        /** @var $metadata \Doctrine\ORM\Mapping\ClassMetadata */
        $metadata = $this->getDoctrine()->getEntityManager()->getClassMetadata('SecretSecretBundle:Deal');

        if (!array_key_exists('rolap', $metadata->getAssociationMappings())) {
            // use a temporary join mapping
            $metadata->mapOneToMany(array(
                'targetEntity' => 'Secret\SecretBundle\Entity\RolapDealP1m',
                'fieldName' => 'rolap',
                'mappedBy' => 'deal',
            ));
        }

A manyToOne mapping from RolapDealP1m to Deal was already created in the RolapDealP1m entity class.

Then, a query using the queryBuilder was created like this:

$qb=$repo->createQueryBuilder('Deal');
$qb
    ->join('Deal.rolap', 'Rolap')
[additional joins]
    ->select(
        array(
            'Deal.number number',
            'Deal.product productName',
[additional fields]
        )
    )
[additional where and group by]
;

The problem occurs, when doing a simple

$qb->getQuery()->getResult();

On symfony 2.0 using doctrine 2.2.2 it worked fine, the result was returned.
On symfony 2.1 using doctrine 2.3.2 and 2.2.2 an error occurs:

Notice: Undefined index: rolap in /var/www/vendor/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php line 366

As a workaround, we added the OneToMany mapping to the Deal Entity instead of using a temporary mapping. This worked fine with symfony 2.1/doctrine 2.3.2.

We think there has been a regression when trying to create temporary mappings.

[DDC-2323] [GH-593] Fix SimpleObjectHydrator behavior when column not exists in fieldMappings, relationMappings and metaMappings

Thu, 14 Mar 2013 22:00:08 +0000

This issue is created automatically through a Github pull request on behalf of norzechowicz:

Url: https://github.com/doctrine/doctrine2/pull/593

Message:

https://github.com/doctrine/dbal/commit/88c1975dda492f3dd93cddea71ebacb40ed7efa5 change seems to make unable to use ``findOneBy()`` method because of ``doctrine_rownum`` added to query.

``findOneBy()`` throws:

>Notice: Undefined index: doctrine_rownum in
...\vendor\doctrine\orm\lib\Doctrine\ORM\Internal\Hydration\SimpleObjectHydrator.php line 183

[DDC-2322] [GH-592] Added ability to specify INDEX BY when creating a QueryBuilder from a Repository

Tue, 12 Mar 2013 19:45:17 +0000

This issue is created automatically through a Github pull request on behalf of cmenning:

Url: https://github.com/doctrine/doctrine2/pull/592

Message:

This is a handy shortcut when using indexed results.

[DDC-2321] DbDeploy Support

Wed, 27 Feb 2013 17:50:49 +0000

DbDeploy Diff Generation
Schema Serialization
SchemaTool gets new event when diff is applied, then you can update a "stable" schema xml. On Generation new db deploy script, use current schema vs stable schema vom disc.

[DDC-2320] [GH-591] Remove dead code

Tue, 12 Mar 2013 18:52:52 +0000

This issue is created automatically through a Github pull request on behalf of Aitboudad:

Url: https://github.com/doctrine/doctrine2/pull/591

Message:

[DDC-2319] [GH-590] DQL Query: process ArrayCollection values to ease development

Sat, 4 May 2013 12:52:29 +0000

This issue is created automatically through a Github pull request on behalf of michaelperrin:

Url: https://github.com/doctrine/doctrine2/pull/590

Message:

I added some code to ease "where in" parameter binding.

As you know, when a where condition is added, the object itself can be passed as a parameter and it's id is automatically retrieved:

```php
$queryBuilder = $this
->where('model.category = :category')
->setParameter('category', $category)
;
```
Where `$category` is an object.

But it doesn't work for collections:
```php
$queryBuilder = $this
->where('model.category IN (:categories)')
->setParameter('categories', $categories)
;
```

Where categories is an `ArrayCollection` object (retrieved from a many to one relation for instance).

This doesn't work in the current version of Doctrine, and my PR solved that.

So far, the only solution is to do the following:

```php
$categoryIds = array();

foreach ($categories as $category)

{ $categoryIds[] = $category->getId(); }

$queryBuilder = $this
->where('model.category IN (:category_ids)')
->setParameter('category_ids', $categoryIds)
;
```

And this is pretty borring when you have to do it several times for several entities.

Note that I didn't add any unit test for this feature. Can you explain me where I should add the test?

Thanks!

[DDC-2318] Count all element

Mon, 25 Feb 2013 15:27:04 +0000

Hello,

I'm sorry if it is not the right place to ask and suggest but I was not sure where to contact you.

I have been trying to make a pagination of articles without using DQL. For me, it defies the purpose of the ORM to do DQL for things like pagination.

After some research I found the method findBy() which allows me to select X element starting at position Y.
Yet, to know the number of pages, I needed to count the number of elements in my database and I didn't find any count() method in the Entity Repository.

I was wondering why there is no count method ?

Moreover, I did my own entity Repository that extends the default one to have a count method like this :

use Doctrine\ORM\EntityRepository;

class CountableEntityRepository extends EntityRepository {
    
    /**
     * returns the number of entity's rows
     * @return int
     */
    public function count() {
        $query = $this->createQueryBuilder('e')->select('count(e)')->getQuery();
        return $query->getSingleScalarResult();
    }
}

as I am new to Doctrine I don't know if this is a good solution, if it is not, could you add a count method to the repository ?

Thank you very much.

Regards,
Benjamin.

[DDC-2317] [UnitOfWork] Entity in identityMap but not present in entityIdentifiers

Tue, 26 Feb 2013 08:35:23 +0000

I'm using symfony 2.1.8 and sonata/admin-bundle
I have a quite complex entity mapping.

A Competence has many CompetenceAction (superclass)
CompetenceActionBuff is a subclass of CompetenceAction and has exactly one buff (selectable in the form by an 'entity' field).

When i want to edit a Competence, i have the following error message about the Buff entity linked to the CompetenceActionBuff:
"Entities passed to the choice field must be managed. [...]"
The exception is raised in Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php at line 412

I've added some debug code in the EntityManager::contains() method and it shows that my entity is in the entityMap but his oid is not in the keys of entityIdentifiers making the call to UnitOfWork::isInIdentityMap() return false at line 1505.

When submitting the form, there is no problems. All the entities are correctly created in the database. The exception is thrown only when i want to edit the Competence object. Saying that the Buff object is not managed when it was first loaded from the database... strange, no?

Finally, i tried to comment the test

if (!$this->em->contains($entity)))

in EntityChoiceList::getIdentifierValues() and everything seemed to work properly.

[DDC-2316] [GH-588] ClassMetadataInfo: use reflection for creating new instance (on PHP >=5.4)

Sat, 4 May 2013 12:12:14 +0000

This issue is created automatically through a Github pull request on behalf of Majkl578:

Url: https://github.com/doctrine/doctrine2/pull/588

Message:

On PHP >=5.4, use proper way for instantiating classes without invoking constructor.

[DDC-2315] [GH-587] Fixed the license and the added version for NewObjectExpression

Fri, 22 Feb 2013 17:35:01 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/doctrine2/pull/587

Message:

this feature is new in 2.4, not 2.3

[DDC-2314] getResults with numeric indexes for fields

Tue, 26 Feb 2013 08:36:04 +0000

When executing a simple query with field names in SELECT clause, it is not possible to map field to numeric indexes.

This is an example that i would imagine to be useful:

SELECT c.id AS 0, c.name AS 1, l.text AS 2 FROM Category c LEFT JOIN c.label l

Thus, the resulting results could be numeric indexed array. It is useful for many situations: when working with an API which expects such arrays, or when using list to assign result fields to variables directly.

Query::HYDRATE_SCALAR does not achieve this, as one could think at first glance.

[DDC-2313] Deep clone for DBAL QueryBuilder

Duplicate — Tue, 18 Jun 2013 07:10:36 +0000

This is basically a duplicate of another issue I stumbled across lately but cannot find here again. It added a __clone() function to the ORM QueryBuilder to allow this use case:
Create a base query and derive two different queries from it.

I adopted the code for the DBAL QueryBuilder which is suffering the same issue (e.g. expressions were not cloned but shared between instances). The code is tested at least for my limited use case.

    /**
     * Deep clone of all expression objects in the SQL parts.
     *
     * @return void
     */
    public function __clone()
    {
        foreach ($this->sqlParts as $part => $elements) {
            if (is_array($this->sqlParts[$part])) {
                foreach ($this->sqlParts[$part] as $idx => $element) {
                    if (is_object($element)) {
                        $this->sqlParts[$part][$idx] = clone $element;
                    }
                }
            } else if (is_object($elements)) {
                $this->sqlParts[$part] = clone $elements;
            }
        }

        $params = array();

        foreach ($this->params as $param) {
            $params[] = clone $param;
        }

        $this->params = $params;
    }

[DDC-2312] [GH-586] Fix EntityManager doc

Thu, 21 Feb 2013 22:57:34 +0000

This issue is created automatically through a Github pull request on behalf of jsjohns:

Url: https://github.com/doctrine/doctrine2/pull/586

Message:

[DDC-2311] ManyToManyPersister fails to delete when entity uses FK ID

Tue, 16 Apr 2013 18:16:30 +0000

ManyToManyPersister::getDeleteSQLParameters assumes $srcColumn contains a field name; doesn't handle association case.

ManyToManyPerister.php, lines 204-209:

// Composite identifier
$sourceClass = $this->_em->getClassMetadata($mapping['sourceEntity']);
foreach ($mapping['relationToSourceKeyColumns'] as $relColumn => $srcColumn) {
   $params[] = $identifier[$sourceClass->fieldNames[$srcColumn]];
}

[DDC-2310] Recent changes to DBAL SQL Server platform lock hinting breaks ORM SqlWalker in DQL queries with joins

Thu, 21 Feb 2013 19:51:37 +0000

The SQL Server platform throws an error when you try to run DQL with JOIN statements.

The breaking change was in the DBAL SQL Server platform – it was changed to add a ' WITH (NOLOCK)' to the appendLockHint function. Change was in this rev. The change in DBAL is not wrong, it just highlighted the bug in the ORM...

The ORM SqlWalker runs the appendLockHint function against a generated FROM / JOIN clause in the walkFromClause func here. This is actually the wrong place to append lock hints. This is generating the FROM clause like:

 FROM foo f0_ LEFT JOIN foo_bar f1_ ON f0_.id = f1_.foo_id LEFT JOIN bar b2_ ON f1_.bar_id = b2_.id WITH (NOLOCK)

When it should actually generate something like:

 FROM foo f0_ WITH (NOLOCK) LEFT JOIN foo_bar f1_ WITH (NOLOCK) ON f0_.id = f1_.foo_id LEFT JOIN bar b2_ WITH (NOLOCK) ON f1_.bar_id = b2_.id

It should append lock hints after the table alias.

I think the only reason this hasn't shown up before is that the other lock hint types haven't been applied in this way before, if at all.

[DDC-2309] Invalid behaviour to flush only one entity

Duplicate — Wed, 1 May 2013 17:23:01 +0000

Current implementation of $em->flush($entity):

does not flush entity scheduled for delete
flush all entities scheduled for insert

http://www.doctrine-project.org/jira/browse/DDC-720

[DDC-2308] Naming Strategy for Reverse Engeneering

Thu, 21 Feb 2013 14:49:27 +0000

Unfortunately DatabaseDriver::getClassNameForTable() is declared as private method, which makes it quite difficult to change the naming strategy for reverse engeneering.

IMO this sould be declared protected. An even better way would be to extend the interface of the Naming Strategy objects to support the reverse direction:

classToTableName -> tableToClassName
propertyToColumnName -> columnToPropertyName.

This way we would have a consistent name-mapping

[DDC-2307] Fields not wrapped in back ticks when removing entity.

Wed, 1 May 2013 12:44:35 +0000

Field definition:

/** @Id @Column(type="string", name="`key`") */
    private $_key;

When removing entity mysql.log shows this:

36 Query     START TRANSACTION
                   36 Query     DELETE FROM `settings` WHERE section = 'Test123' AND key = 'test12312'
                   36 Query     rollback

It seems that on a remove statement the field names aren't being wrapped in back ticks.

[DDC-2306] Lazy loading associated entity's property causes identity loss when another association is set to fetch="EAGER"

Tue, 26 Feb 2013 08:27:25 +0000

There appears to be a bug in UnitOfWork.php, introduced in Merge pull request #406 from Ocramius/DCOM-96. The relevant section is lines 2479-2495.

In the attached test sandbox, there are 4 entities.

User and Address have a many-many relationship via UserAddress – this more or less duplicates what I have in my actual application. There is another entity that both User and Address refer to in a one-to-many relationship – Zone.

When the Zone relationship on User and Address is set to fetch="LAZY", the problem is absent. When the relationship is set to fetch="EAGER", the problem manifests as such:

When I load a User via $em->find(), and then access properties on a related Address, the identity of the Address is lost. The same is true going in the other direction. I var_dump the Address before accessing its street property, and it shows up properly as an uninitialized proxy with just the id set. After I access the street property of the Address, var_dump shows the proxy is loaded and initialized, with all properties set except the identity, which is now null.

I stepped through the code using XDebug, and found that the referenced lines in UnitOfWork.php are setting the created Address entity's properties incorrectly, removing the identity from the generated entity. It seems to have something to do with the _hints parameter.

I'm not sure what the fix is, because I am not familiar enough with this part of the code and what it is intended to do. I assume that this is not intended behavior.

I've included my test case sandbox, which references ../../../../autoload.php to load Doctrine. This was tested against doctrine2/master as of today.

[DDC-2305] [GH-584] QueryBuilder::addCriteria improvements

Tue, 19 Feb 2013 18:00:03 +0000

This issue is created automatically through a Github pull request on behalf of chEbba:

Url: https://github.com/doctrine/doctrine2/pull/584

Message:

1. Fix problem with different comparisons on the same field in QueryExpressonVisitor (now index value is added).
2. Add criteria field aliasing. Usually oject criteria has "filed = value" notation while DQL has "alias.field = value".
First level fields are added with alias, second+ level fields (object.field, parent.object.field) are truncated to the second level (object.field) without alias. Alias map can be implemented in future.

[DDC-2304] [GH-583] accept more than 2 parameters in CONCAT function

Tue, 12 Mar 2013 19:01:30 +0000

This issue is created automatically through a Github pull request on behalf of broncha:

Url: https://github.com/doctrine/doctrine2/pull/583

Message:

The DBAL Platform supports more then 2 parameters but the ConcatFunction only validates 2 parameters to CONCAT. This commit allows to pass more than 2 parameters to CONCAT. Also this change would require that `getConcatExpression` accept array as a parameter. I have opened a pull request for that as well.

[DDC-2303] @param wrong in Doctrine\ORM\PersistentCollection::__constructor Edit

Tue, 26 Feb 2013 08:47:07 +0000

When i try to generate a new PersistentCollection like this:
###############################################
$collection = new ArrayCollection();
new \Doctrine\ORM\PersistentCollection(
$this->getEntityManager(),
new ClassMetadata(''),
$collection
);
###############################################
i get an typ hinting error like
"Expected array, got "Doctrine\Common\Collections\ArrayCollection"

This could be fixed by changing the type hinting for the Doctrine\ORM\PersistentCollection::__constructor
_From:_
###############################################
/**

Creates a new persistent collection.
*
@param EntityManager $em The EntityManager the collection will be associated with.
@param ClassMetadata $class The class descriptor of the entity type of this collection.
@param array $coll The collection elements.
*/
public function __construct(EntityManager $em, $class, $coll)
{
1. 1. 1. 1. _To:_
        ###############################################
        /**
Creates a new persistent collection.
*
@param EntityManager $em The EntityManager the collection will be associated with.
@param ClassMetadata $class The class descriptor of the entity type of this collection.
@param \ArrayAccess $coll The collection elements.
*/
public function __construct(EntityManager $em, $class, $coll)
{
###############################################

[DDC-2302] entity not updating with existing \Datetime object

Sun, 17 Feb 2013 16:20:49 +0000

Within an entity i have an method to add days to a subscription. For that an datetime object is modified.

But the database is not going to be updated if an already existing datetime-object is modified an set. It's only working when an freshly created datetime object is used.

NOT WORKING EXAMPLE:

    public function addDaysToSubscription($days) {

        if ($this->hasValidSubscription()) {

            $startFromDate = $this->getSubscriptionValidUntil();
        }
        else {

            $startFromDate = new \DateTime('now');
        }

        $this->setSubscriptionValidUntil($startFromDate->modify('+' . $days .' days'));
    }

WORKAROUND:

    public function addDaysToSubscription($days) {

        if ($this->hasValidSubscription()) {

            $validDate = $this->getSubscriptionValidUntil()->format('Y-m-d H:i:s');
            $startFromDate = new \DateTime($validDate);
        }
        else {

            $startFromDate = new \DateTime('now');
        }

        $this->setSubscriptionValidUntil($startFromDate->modify('+' . $days .' days'));
    }

[DDC-2301] Support inheritance in ResultSetMappingBuilder

Sat, 16 Feb 2013 22:34:48 +0000

ResultSetMappingBuilder does not support inherited fields. For example, calling ResultSetMappingBuilder::addRootEntityFromClassMetadata($class, $alias) throws an exception to say this.

I was wondering if there were any reasons as to why this would be difficult to implement? I haven't had an extensive look at Doctrine's source but it feels like this has been not implemented on purpose.

Thanks

[DDC-2300] Xmldriver does not convert the version field to boolean but keeps it as a SimpleXMLElement which breaks serialization

Thu, 14 Mar 2013 22:22:17 +0000

Serialization breaks because the cache driver tries to serialize the ClassMetaData instance containing a simplexml element:

Doctrine\ORM\Mapping\ClassMetadata Object
(
    [fieldMappings] => Array
        (
            [version] => Array
                (
                    [fieldName] => version
                    [type] => integer
                    [columnName] => version
                    [version] => SimpleXMLElement Object
                        (
                            [0] => true
                        )

                    [default] => 1
                    [declared] => path to entity
                )

The fix is simple change in the columnToArray method in the XML driver class:

changing:

$mapping['version'] = $fieldMapping['version'];

to:

$mapping['version'] = $this->evaluateBoolean($fieldMapping['version']);

[DDC-2299] [GH-582] Test for DDC-2106

Tue, 26 Feb 2013 08:49:08 +0000

This issue is created automatically through a Github pull request on behalf of frosas:

Url: https://github.com/doctrine/doctrine2/pull/582

Message:

[DDC-2298] [GH-581] Removing submodules

Fri, 15 Feb 2013 17:45:01 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/581

Message:

Removing submodules (my bad, wasn't done in #570 )

[DDC-2297] Add ConstraintException for parent row

Fri, 15 Feb 2013 08:29:48 +0000

Currently there is no constraint check for entities that depends another one.
I always check the dependencies using repository. Something like this:

$childRepository = $em->getRepository('Child');
$parent = $em->getReference('app:Parent', $id);
$children = $childRepository->findBy(array('parent' => $parent));

if ($children) {
    throw new Exception('You can not delete this record. There are records related');
}
        
$em->remove($parent);
$em->flush();

This exception could be thrown in $em->flush(); or could look like:

 
try {
    $parentEntity = $em->gerReference('ParentEntity', $id);
    $em->remove($parentEntity);
    $em->flush();
catch (SomeORMNamespace\ConstraintException $e) {
    echo $e->getMessage(); //outs: You cannot remove this entity. There is another one related.
}

I think this functionality could be implemented through metadata on any sides of the relationship or on the @Entity mapping.

@Entity(children={'Child'}) //this is not a good attr name =)
class Parent {}

I know that is more app business logic related, but is it possible to implement this feature in next releases?

[DDC-2296] Naming Strategy ORM Entity - plural problem

Thu, 14 Mar 2013 22:25:08 +0000

We are using Doctringe since 2.2.2.

We the follow relation:

manyToMany:
categories:
targetEntity: \Application\Model\Db\Entity\Category
inversedBy: topics
joinTable:
name: finq_topic_category
joinColumns:
topic_id:
referencedColumnName: id
inverseJoinColumns:
category_id:
referencedColumnName: id

As expected the generated methods in our entities were named like:

addCategory()
getCategories()
...

After we updated to 2.3.2 we got the follow method names:

addCategorie()
getCateogires()

I found in the changelog some notes like "changed naming strategy".
Took us several hours too find out that we had to downgrade back to
2.2.2. Is this a bug or "just" a new behavior?

[DDC-2295] [GH-580] Second cache level POC

Thu, 14 Mar 2013 21:36:42 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/doctrine2/pull/580

Message:

Hi guys.

After a look into some implementations I end up with the following solution for the second level cache..

There is lot of work todo before merge it, but i'd like to get your thoughts before i go any further on this approach.
I hope my drafts are good enough to explain the idea :

1. 1. Cache strategies

READ_ONLY (DEFAULT) : ReadOnly cache can do reads, inserts and deletes, cannot perform updates or employ any locks.
NONSTRICT_READ_WRITE : Nonstrict Read Write Cache doesn’t employ any locks but can do reads, inserts , updates and deletes.
NONSTRICT_READ_WRITE : Read Write cache employs locks the entity before update/delete.

1. 1. classes / interfaces

*Region* :
Defines a contract for accessing a entity/collection data cache. (Doesn’t employ any locks)

*ConcurrentRegion* :
Defines contract for concurrently managed data region. (Locks the data before update/delete.)

*RegionAccess* :
Defines a contract to access a cache region

*ConcurrentRegionAccess* :
Defines contract for regions which hold concurrently managed data.

*CacheKey / EntityCacheKey / CollectionCacheKey/ QueryCacheKey*:
Defines entity / collection key to be stored in the cache region.

*EntityEntryStructure / CollectionEntryStructure*
Build cache entries and rebuild entities/colection from cache

*AccessProvider*
Build RegionAccess based on entity / collection cache configuration

Collection Caching

The most common use case is to cache entities. But we can also cache relationships.
A “collection cache” caches the primary keys of entities that are members of a collection (OneToMany/ManyToMany).
and each element will be cached into its region.

Only identifiers will be cached for collection. When a collection is read from the second level cache it will create proxies based on the cached identifiers, if the application needs to access an element, Doctrine will go to the cache to load the element data.

1. 1. OPERATIONS

1. 1. 1. INSERT :

*********************************************************************************************
UnitOfWork#commit
Connection#beginTransaction
Persister#executeInserts
Connection#commit
Persister#afterTransactionComplete
-> EntityRegionAccessStrategy#afterInsert
*********************************************************************************************
METHOD | READ-ONLY | NONSTRICT-READ-WRITE | READ-WRITE |
---------------------------------------------------------------------------------------------
afterInsert | add item to the cache | add item to the cache | add item to the cache |
---------------------------------------------------------------------------------------------

1. 1. 1. UPDATE :

*********************************************************************************************
UnitOfWork#commit
Connection#beginTransaction
Persister#update
-> TransactionalRegionAccess#lockItem
-> execute
Connection#commit
Persister#afterTransactionComplete
-> RegionAccess#afterUpdate
-> TransactionalRegionAccess#unlockItem
*********************************************************************************************
METHOD | READ-ONLY | NONSTRICT-READ-WRITE | READ-WRITE |
---------------------------------------------------------------------------------------------
lockItem | | | lock item |
---------------------------------------------------------------------------------------------
afterUpdate | throws exception | update item cache | update item cache |
---------------------------------------------------------------------------------------------
unlockItem | | | unlock item |
---------------------------------------------------------------------------------------------

1. 1. 1. DELETE :

*********************************************************************************************
UnitOfWork#commit
Connection#beginTransaction
Persister#delete
-> TransactionalRegionAccess#lockItem
-> execute
Connection#commit
Persister#afterTransactionComplete
-> RegionAccess#evict
*********************************************************************************************
METHOD | READ-ONLY | NONSTRICT-READ-WRITE | READ-WRITE |
---------------------------------------------------------------------------------------------
lockItem | | | lock item |
---------------------------------------------------------------------------------------------
evict | remove item cache | remove item cache | remove item cache |
---------------------------------------------------------------------------------------------

1. 1. 1. USAGE :

```php
<?php

/**
 * @Entity
 * @Cache("NONSTRICT_READ_WRITE")
 */
class State
{
    /**
     * @Id
     * @GeneratedValue
     * @Column(type="integer")
     */
    protected $id;
    /**
     * @Column
     */
    protected $name;
    /**
     * @Cache()
     * @ManyToOne(targetEntity="Country")
     * @JoinColumn(name="country_id", referencedColumnName="id")
     */
    protected $country;
    /**
     * @Cache()
     * @OneToMany(targetEntity="City", mappedBy="state")
     */
    protected $cities;
}
```

```php
<?php

$em->persist(new State($name, $country));
$em->flush();                                // Put into cache

$em->clear();                                // Clear entity manager

$state   = $em->find('Entity\State', 1);     // Retreive item from cache
$country = $state->getCountry();             // Retreive item from cache
$cities  = $state->getCities();              // Load from database and put into cache

$state->setName("New Name");
$em->persist($state);
$em->flush();                                // Update item cache

$em->clear();                                // Clear entity manager

$em->find('Entity\State', 1)->getCities();   // Retreive from cache


$em->getCache()->containsEntity('Entity\State', $state->getId())  // Check if the cache exists
$em->getCache()->evictEntity('Entity\State', $state->getId());    // Remove an entity from cache
$em->getCache()->evictEntityRegion('Entity\State');               // Remove all entities from cache

$em->getCache()->containsCollection('Entity\State', 'cities', $state->getId());   // Check if the cache exists        
$em->getCache()->evictCollection('Entity\State', 'cities', $state->getId());      // Remove an entity collection from cache
$em->getCache()->evictCollectionRegion('Entity\State', 'cities');                 // Remove all collections from cache

```

1. 1. 1. TODO :

handle many to many collection
handle inheritance
remove/add colection items on update
improve region tests
improve access strategy tests
implement xml / yml / php drivers
implement transaction region
implement transaction access strategy
.... ????

[DDC-2294] [GH-579] Unit tests: cleanup of outdated / unused / commented out code

Tue, 12 Mar 2013 19:00:56 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/doctrine2/pull/579

Message:

Many methods in unit tests were unused, in particular in mocks, where methods overriding in the past were not overriding anything anymore.

Some commented out code was referring to features that seem to have been removed years ago, so I removed it as well.

`HydratorMockStatement::bindParam()` was adding extra parameter that its parent did not define, and that were never used, so I removed them as well.

[DDC-2293] [GH-578] Fix for wrong return types in documentation.

Tue, 12 Feb 2013 17:09:29 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/doctrine2/pull/578

Message:

Several methods were declaring erroneous / incomplete return types.
This PR fixes them.

[DDC-2292] [GH-577] Allow extending EntityManager and use create method

Mon, 11 Feb 2013 15:48:43 +0000

This issue is created automatically through a Github pull request on behalf of ruian:

Url: https://github.com/doctrine/doctrine2/pull/577

Message:

If you create your own entityManager by extending this one, you can't use ::create method because
it will create an instance of the last one and not our new entityManager

[DDC-2291] [GH-576] Update docs/en/reference/batch-processing.rst

Mon, 11 Feb 2013 15:51:13 +0000

This issue is created automatically through a Github pull request on behalf of acasademont:

Url: https://github.com/doctrine/doctrine2/pull/576

Message:

If you have only $batchSize - 1 rows (amongst other cases), the entities are never flushed, you need a final flush outside the loop.

In the bulk insert you should also need a final flush if the number of entities inserted is not a multiple of the $batchSize.

[DDC-2290] Infer custom Types from the field for query parameters

Fri, 8 Feb 2013 12:54:06 +0000

When using a mapping Type that declares convertToDatabaseValue, the method is not always called in queries.

Example:

SELECT ... WHERE entity.field = ?1

(with entity.field being of custom type 'the_mapping_type')

Type::convertToDatabaseValue() is correctly called when using:

$query->setParameter('1', 'foo', 'the_mapping_type');

But it is not called when using:

$query->setParameter('1', 'foo');

which gives a query that returns invalid results.

Like other mapping types in this situation, there is no reason the type is not inferred automatically from the field.

I have written a failing test case in Doctrine\Tests\ORM\Functional\TypeValueSqlTest:

    public function testQueryParameterWithoutType()
    {
        $entity = new CustomTypeUpperCase();
        $entity->lowerCaseString = 'foo';

        $this->_em->persist($entity);
        $this->_em->flush();

        $id = $entity->id;

        $this->_em->clear();

        $query = $this->_em->createQuery('SELECT c.id from Doctrine\Tests\Models\CustomType\CustomTypeUpperCase c where c.lowerCaseString = ?1');
        $query->setParameter('1', 'foo');

        $result = $query->getResult();

        $this->assertCount(1, $result);
        $this->assertEquals($id, $result[0]['id']);
    }

[DDC-2289] [GH-575] Added YAML configuration example for "Simple Derived Identity" in Docs

Mon, 11 Feb 2013 15:50:26 +0000

This issue is created automatically through a Github pull request on behalf of naitsirch:

Url: https://github.com/doctrine/doctrine2/pull/575

Message:

I have added a missing YAML configuration example to the tutorial. Because I needed it for myself

See http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/composite-primary-keys.html#use-case-2-simple-derived-identity

I hope the YAML definition is correct.

[DDC-2288] Schema Tool doesn't update collation on table level

Fri, 8 Feb 2013 09:50:30 +0000

In Symfony2, when updating the collation option of a table, the schema tool doesn't recognize the change:

Changing from:

 
* @ORM\Table()

To:

 
* @ORM\Table(options={"collate"="utf8_swedish_ci"})

Results in:

 
$ php app/console doctrine:schema:update --dump-sql
Nothing to update - your database is already in sync with the current entity metadata.

[DDC-2287] Getter/Setter: generate "isEnabled()" instead of "getEnabled()" for boolean field in entity classes

Tue, 26 Feb 2013 08:50:40 +0000

It would be better if doctrine generated "isEnabled()" instead of "getEnabled()" for boolean field in entity classes. Because, it is more meaningful.

[DDC-2286] Update documentation for collation

Fri, 8 Feb 2013 09:27:56 +0000

The documentation at http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/faq.html#how-do-i-set-the-charset-and-collation-for-mysql-tables clearly states that the collation should be set at database level and then inherited for all tables created.

Digging through the code and reading this issue http://www.doctrine-project.org/jira/browse/DDC-2139 it's clear that this is no longer the case.

[DDC-2285] Repeating the same query with different parameter value returns the same results

Fri, 8 Feb 2013 08:26:18 +0000

$activeAdsCustomers = \Ez\Registry::getDoctrineEntityManager()
    ->createQuery( "SELECT c, a FROM \Spot101\Model\Ad\Customer c JOIN c.ads a WHERE a.status = :status" )
    ->setParameter( "status", \Spot101\Model\Ad\Status::ACTIVE )
    ->getResult();

$inactiveAdsCustomers = \Ez\Registry::getDoctrineEntityManager()
    ->createQuery( "SELECT c, a FROM \Spot101\Model\Ad\Customer c JOIN c.ads a WHERE a.status = :status" )
    ->setParameter( "status", \Spot101\Model\Ad\Status::INACTIVE )
    ->getResult();

Having the code above I am getting the same results for $inactiveAdsCustomers as I get for $activeAdsCustomers. And when I try hydrating the results everything works so fine.

Both queries look the same except the value provided for the "status" parameter.

[DDC-2284] [GH-573] [Documentation] Noted prePersist event only triggers on first persist

Fri, 8 Feb 2013 08:24:14 +0000

This issue is created automatically through a Github pull request on behalf of EvanK:

Url: https://github.com/doctrine/doctrine2/pull/573

Message:

While probably obvious to a core doctrine developer, a user of doctrine would not necessarily know this without doing some digging or [stack overflowing](http://stackoverflow.com/questions/7934555/doctrine-2-prepersist-doesnt-fire)

[DDC-2283] Paginator with orderBy in joined data retrieve bad result

Tue, 26 Feb 2013 08:52:40 +0000

entity A have many entity B

If DQL is something like "select A, B from A join B order by A.field1, B.field2"
Then Paginator retrieve different Id by a query like :
"select distinct a.id, a.field1, b.field2 from ( ....) order by a.field1 ASC , b.field2 ASC limit 15 offset 0"

so, if a entity A have 20 entity B (and these sub-entity have all a different b.field2) then there's only 1 A retrieved

[DDC-2282] [GH-572] Fixed SQLServer ORDER BY problem in paginator CountOutputWalker

Tue, 12 Mar 2013 18:06:53 +0000

This issue is created automatically through a Github pull request on behalf of norzechowicz:

Url: https://github.com/doctrine/doctrine2/pull/572

Message:

Code explains everything

[DDC-2281] Validation against database-first generated xml requires that the column order within a composite primary key match the order the columns are in in mapping xml

Thu, 9 May 2013 16:30:08 +0000

In using a database-first approach utilizing orm:convert-mapping to generate xml, the validation and schema-tool reports that my composite primary key (ex. Columns A, C, B) be dropped and added in the order in which the mapping appears in the xml (ex. Columns A, B, C).

These columns are not auto-increment and are simply a mixture of int and varchar.

[DDC-2280] Database-first convert-mapping to XML fails to add length to varchar primary key in id tag

Thu, 9 May 2013 16:17:23 +0000

In using orm:convert-mapping xml --from-database the xml that is generated for varchar columns does not receive a length attribute.

Therefore - orm:validate-schema fails and the schema tool reports that the column must change to a varchar(255) when it should be just fine with the varchar that was already there (ex. varchar(10)).

Note: I discovered this on composite keys - unsure whether this is for all or only composite.

[DDC-2279] [GH-571] Update lib/Doctrine/ORM/EntityRepository.php

Tue, 12 Mar 2013 19:04:52 +0000

This issue is created automatically through a Github pull request on behalf of flo-ITN:

Url: https://github.com/doctrine/doctrine2/pull/571

Message:

Add "indexby" missing parameter that permit an "index by" easily.

Ex :��
#Acme\AcmeBundle\Repository
#Before
public function findAllIndexById()

{ �� $qb = $this->_em->createQueryBuilder() �� ->select('root') �� ->from('Acme', 'root', 'root.id'); �� /*...*/ }

#After
public function findAllIndexById()

{ �� $qb = $this->createQueryBuilder('root','root.id'); �� /*...*/ }

[DDC-2278] Invalid arguments to PreFlushEventArgs class

Tue, 5 Feb 2013 08:14:33 +0000

Here https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/UnitOfWork.php#L527 PreFlushEventArgs expects number of arguments to be 2 and the first argument have to be instance of entity manager. But two arguments are passed and the first one is not instanceof em.

[DDC-2277] [GH-570] Deprecation of PEAR/GIT/TAR autoloading

Thu, 14 Feb 2013 09:19:21 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/570

Message:

Updates the test suite to use composer based autoloading

[DDC-2276] [GH-569] Hotfix/pre flush event args params

Tue, 12 Feb 2013 23:40:41 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/doctrine2/pull/569

Message:

As reported by a user on IRC, the `PreFlushEventArgs` object was built with incorrect parameters. this fix solves the problem by typehinting the constructor.

Tests aren't really necessary since a lot of functional tests were simply broken because of this additional typehint.

[DDC-2275] [GH-568] Fixed plural variable names to singular when generating add or remove methods for entities

Mon, 4 Feb 2013 01:47:46 +0000

This issue is created automatically through a Github pull request on behalf of alexcarol:

Url: https://github.com/doctrine/doctrine2/pull/568

Message:

Changed generateEntityStubMethod so that variable names in add or remove methods are singular too

Edited tests for EntityGenerator so that variable names are checked too

[DDC-2274] [GH-567] Removed outdated methods in DatabasePlatformMock

Tue, 5 Feb 2013 15:10:48 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/doctrine2/pull/567

Message:

`DatabasePlatformMock::getNativeDeclaration()` and `getPortableDeclaration()` do not override an existing method in `AbstractPlatform`.
I guess they are leftovers of a previous version, and should be removed.