Doctrine Project

[DCOM-61] Class annotation is not setting annotation properties

Thu, 25 Aug 2011 18:42:50 +0000

My annotations were working fine with v2.0.5. Once I upgraded to v2.1 they stopped working. Using this condensed code based on the v2.1 documentation on Annotations (http://www.doctrine-project.org/docs/common/2.1/en/reference/annotations.html):

require 'c:/dev/library/doctrine-orm/Doctrine/Common/ClassLoader.php';

$classLoader = new \Doctrine\Common\ClassLoader('Doctrine', 'c:/dev/library/doctrine-orm');
$classLoader->register();
$classLoader = new \Doctrine\Common\ClassLoader('Symfony', 'c:/dev/library/doctrine-orm/Doctrine');
$classLoader->register();

$reader = new \Doctrine\Common\Annotations\AnnotationReader();
$reader->setIgnoreNotImportedAnnotations(true);
$reader->setEnableParsePhpImports(false);
$className = 'User';
$reflectionClass = new \ReflectionClass($className);

$classAnnotations = $reader->getClassAnnotations($reflectionClass);
echo "Class Annotations - $className:\n";
print_r($classAnnotations);

/**
* @Annotation
*/
class Foo {
    public $bar;
}

/**
* @Foo(bar="foo")
*/
class User {
    
}

The result is:

Class Annotations - User:
Array
(
    [0] => Foo Object
        (
            [bar] =>
        )

)

Why is bar empty? If I remove the @Foo annotation from the docblock for the User class, then the result is an empty array. So it's clearly detecting the annotation, it's just not setting the annotation property.

[DCOM-84] Improve Proxy Naming

Tue, 13 Dec 2011 20:41:05 +0000

see https://gist.github.com/b493493ecdb22c21590e

[DCOM-173] Add test assets and tests for proxy generators

Thu, 21 Feb 2013 10:01:43 +0000

Need to add tests assets to check __isset __get __set, etc. Currently only code generation for proxies inheriting __sleep is tested.

[DCOM-27] Method Next from ArrayCollection needs to return something!

Sun, 31 Oct 2010 03:48:18 +0000

I think this method needs to return something...

/**

Moves the internal iterator position to the next element.
*
@return mixed
*/
public function next() { next($this->_elements); }

doctrine-common/lib/Doctrine/Common/Collections/ArrayCollection.php

[DCOM-25] method setAutoloadAnnotationClasses-fails

Sun, 31 Oct 2010 03:57:26 +0000

$reader = new Doctrine\Common\Annotations\AnnotationReader();
$reader->setAutoloadAnnotationClasses(true);

above code is trying use default parser's setAutoloadAnnotationClasses-method, which isn't found, instead parser has setAutoloadAnnotations.

[DCOM-69] [APC Cache] doFlush does not clear user cache

Mon, 3 Oct 2011 04:13:30 +0000

lib\Doctrine\Common\Cache\ApcCache.php

The function "doFlush" only clears opcode cache.
The user cache is never cleared.

To correct it, one solution should be :

protected function doFlush()
{
    $res = false;    
    $bool1 = apc_clear_cache();
    $bool2 = apc_clear_cache('user');
    if ($bool1 && $bool2)
    {
        $res = true;
    }
    return $res;
}

[DCOM-194] Creating Proxy class failure for own __get method

Mon, 10 Jun 2013 18:20:54 +0000

Nette framework (http://nette.org) has got own Nette\Object as a base of other objects. It also rewrite the default __get method in PHP object but it uses definition with pointer:

public function &__get($name)

Doctrine Common creates Proxy classes with __get method too but not with reference. It causes an error using strict warning:

Declaration of Proxy\__CG__\MyEntityObject::__get() should be compatible with & Nette\Object::__get($name)

The problem is in ProxyGenerator. Locally I've patched it in my Doctrine repository clone but don't know how to resolve it globally.

[DCOM-31] setAutoloadAnnotationClasses() within AnnotationReader fails

Mon, 15 Nov 2010 13:05:49 +0000

When calling setAutoloadAnnotationClasses() from within AnnotationReader, it fails because setAutoloadAnnotationClasses() is not implemented in Doctrine\Common\Annotations\Parser.

This should be fixed, or at least a FeatureNotImplementedException or such.

[DCOM-57] Doctrine\Common\Cache\AbstractCache::deleteAll() does not take the namespace into account

Thu, 8 Sep 2011 17:16:21 +0000

The deleteAll() function delete all keys with no respect of the namespace.

Using orm:clear-cache:metadata with memcache result in the deletion of all memcache keys. (including keys unrelated to the orm)

[DCOM-56] Remote autoloading from annotations completly, replacing it with its own loading mechanism

Sat, 2 Jul 2011 19:15:15 +0000

This is a mail from me to the symfony-dev mailing-list:

I am sorry it is very late to bring this up again, but given the nasty problems I faced today with the way annotationreader works with autoload = true I have to share them (and blow of some steam). While i guess its to late to change this again before 2.0, we might still have to discuss to go away from autoload = true for 2.1. Now for the reasons:

AnnotationReader with autoload = true (which Symfony2 uses) will not only require a silent autoloader, it requires ALL autoloaders used to be silent. While this is the case for the Symfony Universal loader its not the case for the Doctrine one, and not for many others - and its not even a PSR-0 requirement. For a simple reason: Supporting silent failure means using file_exists, means a file stat, which means apc.stat = 0 is useless. While I don't care so much about it in Doctrine context, because the AnnotationReader default is NOT to autoload annotations this will cause problems for Symfony: Not every library in any Symfony2 app will be included through a silent autoloader. That means given the context users might run into problems using annotations that they have absolutely no way of fixing. And since the AnnotationReader does not know this upfront, potential failures become very real issue.

Example: I use SecurityExtraBundle and happen to have my SuperDuperLibrary XYZ. That library was developed by my company and contains tons of important business logic but unfortunately uses a non-silent autoloader (for whatever reasons). However i use Symfony to secure access to it by generating secure proxies. Now what happens if an annotation reader runs over that library? Because the current namespace is always considered, for every @var _NAMESPACE."
var" is class_exists'ed and then your code fatal errors. I didn't see this problem before, because i don't use annotations myself so much and always in the BC Doctrine 2.0.x way and that slipped my mind. Same goes for Validation with Annotations on external code, or maybe in the future services definitions through annotations.

All this trouble we are getting into with autoloading annotations is just because we wanted to validate that the annotations used actually exist. But since we changed to a use/import approach rather then re-using namespaces we don't even have the clashing problem anymore that got us into the trouble with class_exists before. The autoloading however also got us and users into other problems:

1. We have to maintain a rather large map of "blacklisted" annotations that never throw failure exceptions because they are actually used as doc documentations. As with blacklists this is never a complete list.
2. Users with intensive doc-block usage are punished by Symfony having to maintain their own blacklist of annotations that never throw exceptions so that their code actually works.
3. Libraries have to handle the case that a reader is either using autoloading or not through special code.

While I do think it would have been nice to offer validation for annotation this is a task that should be put on IDEs and developers, since it turns out that its not possible flawlessly within the library itself. The AnnotationReader should always use class_exists($name, false). Docblocks are still comments and the code shouldn't fail because classes are not available that are not even relevant in the context of the current AnnotationReader. Each part of the code that uses an AnnotationReader should require_once the annotations that it can potentially need upfront. That even works for Validation as you can grab the tags from the DIC. That way we have a single mode of operation for the AnnotationReader and not two different ones that are 180 degrees different. OF course one could argue ALWAYS to use class_exists($name, true) instead, but i hope my mail showed why this is not a good idea.

If for some reason we do want autoloading for annotations then it should be a mechanism different from the PHP one, because they are both not compatible. The reader could have hooks for autoloading and validation mechanisms. Nothing we want to add for Doctrine Common 2.1, but something we could easily play around with for Common 3.

Next a mail with implementation details:

I propose to change the following on AnnotationReader:

1. Add a method to register annotation classes:
$reader->registerAnnotation("Symfony\Bridge\Doctrine\Validator\UniqueEntity");
and $reader->registerAnnotations(array(..));
2. Add a method to register files that contain annotations:
$reader->registerAnnotationFile(".."), directly loading them via
require_once;
3. Add a method to register annotation namespaces:
$reader->registerAnnotationNamespace("Symfony\Component\Validator\Constraint",
$dir). This is used to create a silently failing PSR-0 "autoloader" for
this path + directories. It can be automatically populated from data in
the UniversalClassLoader.
4. Change the class_exists check to never use autoload = true. If a
class is part of a registered annotation namespace try load the file based on a silent
PSR-0 autoload for it using an autoloader impl. contained in the
AnnotationReader (not the php autoloading mechanism), before triggering
the class_exists($name, false)

This way for symfony only the UniversalClassLoader data has to be used
to populate the registered annotation namespaces.

[DCOM-55] Ugly problems with default import NAMESPACE when it contains non-annotation classes that are docblock props

Wed, 29 Jun 2011 22:01:14 +0000

Say you have a class "Entity".

Then /** @Entity */ on a class in the same namespace will try to instantiate Entity.

We should avoid this by testing if Entity is a subclass of \Doctrine\Common\Annotations\Annotation

[DCOM-54] ClassLoader protected properties

Sun, 17 Jul 2011 15:13:25 +0000

It would be great if the members of ClassLoader($fileExtension, $namespace, $includePath, $namespaceSeparator) where protected instead of private. In order to work around ~~DCOM-20~~ I was going to extend and override loadClass but the private members mean I need to copy a lot of other code.
Didn't seem worth the overhead of creating a patch - but I can if you prefer.

[DCOM-53] PhpParser doesn't ignore commented keywords

Sun, 4 Sep 2011 08:34:00 +0000

The PhpParser makes a too optimistic assumption about code convention...

If you have the word 'class' or 'interface' in the comment before the class definition, preg_match_all finds wrong slice of code and PHP complains with a Warning about "Unterminated comment". This occurs only once after the cache is cleared.

[DCOM-51] Support parsing of single quotes

Thu, 5 May 2011 04:26:13 +0000

It'd be great to support single quotes, this limitation doesn't make sense from a user point of view and in php context single quotes are so commonly used that it's easy to slip and then get some funny Exception message out of it.

[DCOM-50] Unable to use '@' in combination with a number (example: email@3domain.tld) in comment block

Fri, 13 May 2011 04:13:18 +0000

My tld contains a number at the beginning (8points.de).
I'm not able to use it in the @author section (@author Florian Preusner <florian.preusner@8points.de>) cause after the "@" the next letter is a number.

Exception:
AnnotationException: [Syntax Error] Expected Doctrine\Common\Annotations\Lexer::T_IDENTIFIER, got '8' at position 118 in method Blog\MainBundle\Controller\MainController::indexAction().
n /var/www/floeh/vendor/doctrine-common/lib/Doctrine/Common/Annotations/AnnotationException.php at line 41

I think this is a bug?!

[DCOM-47] When using different class loaders

Tue, 27 Dec 2011 23:21:04 +0000

ClassLoader::classExists($class); will fail if different class loader is used which does not return any boolean value. This includes Symfony2 UniversalClassLoader

I have never used this function before because native PHP method class_exits($class, true) first will try to autoload. But if the class does not exist
and you are using Doctrine\Common::ClassLoader and you call class_exists($class) it will trigger fatal error. This behavior makes it impossible to make code compatible
with different class loading mechanisms for Doctrine2

[DCOM-45] Allow different namespaces for the same alias

Tue, 26 Apr 2011 12:42:18 +0000

Right now, it is only possible to register one namespace per annotation alias. This might lead to problems since we now throw exceptions if an annotation is not found in that namespace (https://github.com/doctrine/common/commit/8967f476ddcdb7b9017a8be7f774979ca4c72247).

This improvement would be a necessary first step in order to overcome the problem we talked about on IRC (FrameworkExtra/SecurityExtra both using the "extra" alias).

[DCOM-46] Make annotation index configurable

Fri, 13 May 2011 04:26:13 +0000

So, this is another improvement that I'd like to make. Right now all annotations are indexed by their name which has the limitation that on the top level annotations with the same name are only gathered once.

/**
 * @param mixed $a
 * @param mixed $a
 * @param mixed $a
 */
function ($a, $b, $c) { }

In the above case the annotation parser would only pick up one "param" annotation. My guess is that this was done for fast lookups, but I think we need to make this configurable (I know you hate this word ) as the workaround here is needlessly bloated.

/**
 * @params({@param, @param, @param})
 */
function($a, $b, $c) {}

This only requires two lines to be changed/made conditional, see
https://github.com/schmittjoh/SecurityExtraBundle/blob/master/Mapping/Driver/AnnotationParser.php#L63
https://github.com/schmittjoh/SecurityExtraBundle/blob/master/Mapping/Driver/AnnotationParser.php#L72

p.s. If you want me to provide a patch for this, just tell me.

[DCOM-44] Throw exception if known namespaced annotation is not found

Wed, 6 Apr 2011 10:15:54 +0000

If we know that an annotation is namespaced and that the namespace exists we should throw an exception if the annotation specified does not exist, currently its just skipped which can be very nasty to debug.

[DCOM-32] Memcache cache relies on deprecated functions

Wed, 28 Mar 2012 15:14:23 +0000

The method getIds() in MemcacheCache relies on the old "cachedump" stat type.

But as you can read here: http://de2.php.net/manual/en/memcache.getextendedstats.php this has been removed due to security reasons.

[DCOM-76] switch license to MIT

Sat, 9 Jun 2012 11:59:05 +0000

since common was mostly written by a small group of people and not based on Doctrine 1.x it seems possible to switch the license which imho would really boost the use cases.

[DCOM-71] Add save get_class() to Debug Util

Sun, 23 Oct 2011 06:36:00 +0000

Add save get_class() to Debug Util

[DCOM-70] [CacheProvider] missing functions

Tue, 6 Mar 2012 18:36:15 +0000

Why delete functions in CacheProvider like deleteByPrefix deleteByPostfix deleteByRegex ?
DeleteAll and FlushAll do not replace them. Please revert for these functions.

[DCOM-68] Add @codeCoverageIgnoreStart and @codeCoverageIgnoreEnd to annotation ignore map

Sun, 25 Sep 2011 14:36:26 +0000

Add @codeCoverageIgnoreStart and @codeCoverageIgnoreEnd to annotation ignore map

[DCOM-66] Github-PR-55 by shesek: Use stream_resolve_include_path

Sun, 28 Aug 2011 03:31:11 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/common/pull/55

Message:

`Doctrine\Common\ClassLoader::fileExistsInIncludePath` behaves the same as `stream_resolve_include_path`, use that instead when available (PHP >= 5.3.2). It should be faster than doing that manually.

[DCOM-62] Github-PR-53 by shawndellysse: ArrayCollection#join

Wed, 14 Sep 2011 16:54:17 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/common/pull/53

Message:

Added the `join` method to `ArrayCollection`.

[DCOM-60] SimpleAnnotationReader get*Annotations

Sun, 28 Aug 2011 14:21:33 +0000

Notice: Undefined variable: class in /usr/home/gym/doctrine2-common/lib/Doctrine/Common/Annotations/SimpleAnnotationReader.php on line 45 
 
Fatal error: Call to a member function getName() on a non-object in /usr/home/gym/doctrine2-common/lib/Doctrine/Common/Annotations/SimpleAnnotationReader.php on line 45

Doctrine/Common/Annotations/SimpleAnnotationReader.php

    public function getMethodAnnotations(\ReflectionMethod $method)
    {
-        return $this->parser->parse($method->getDocComment(), 'method '.$class->getName().'::'.$method->getName().'()');
+        return $this->parser->parse($method->getDocComment(), 'method '.$method->getName().'::'.$method->getName().'()');
    }

    public function getPropertyAnnotations(\ReflectionProperty $property)
    {
-        return $this->parser->parse($property->getDocComment(), 'property '.$class->getName().'::$'.$property->getName());
+        return $this->parser->parse($property->getDocComment(), 'property '.$property->getName().'::$'.$property->getName());
    }

[DCOM-127] [GH-206] Debug::export ArrayIterator dumps the internal storage variable

Mon, 14 Jan 2013 01:41:27 +0000

This issue is created automatically through a Github pull request on behalf of Slamdunk:

Url: https://github.com/doctrine/common/pull/206

Message:

Following my previous PR https://github.com/doctrine/common/pull/191 I found also ArrayIterator needs special behaviour.

[DCOM-126] [GH-205] Fixed a typo in PHPdoc

Mon, 14 Jan 2013 01:40:57 +0000

This issue is created automatically through a Github pull request on behalf of michaelperrin:

Url: https://github.com/doctrine/common/pull/205

Message:

A unnecessary new line was inserted in ClassLoader.php

[DCOM-125] [GH-204] Bad function call in Debug::toString()

Mon, 14 Jan 2013 01:40:44 +0000

This issue is created automatically through a Github pull request on behalf of touki653:

Url: https://github.com/doctrine/common/pull/204

Message:

Fixed an (obviously) over used function which were calling [method_exists](http://php.net/method_exists) function the wrong way.

In `Doctrine\Common\Util\Debug::toString($obj)`
From `method_exists('__toString',$obj)`
To `method_exists($obj,'__toString')`

[DCOM-122] [GH-200] ClassMetadataFactory child classes can now filter the metadata when calling getAllMetadata

Sun, 7 Oct 2012 10:37:41 +0000

This issue is created automatically through a Github pull request on behalf of theUniC:

Url: https://github.com/doctrine/common/pull/200

Message:

This is due mainly, because we have found performance issues when trying to generate a complete schema (annotation based) from a legacy database with tons of tables with the ConvertMapping command.

This will let filter table names to the ```Doctrine\ORM\Mapping\Driver\DatabaseDriver::getAllClassNames``` and ```Doctrine\ORM\Mapping\Driver\DatabaseDriver::loadMetadataForClass``` methods, and extract class metadata from a smaller subset of classes (I'm doing another PR for this in the ORM repository).

[DCOM-116] [GH-193] Optimize autoload prefix in composer.json

Mon, 14 Jan 2013 01:34:42 +0000

This issue is created automatically through a Github pull request on behalf of Slamdunk:

Url: https://github.com/doctrine/common/pull/193

Message:

By having more specific autoload prefixes it is possible to reduce the number of stat calls made.

[DCOM-115] [GH-191] Debug::export ArrayObject dumps the internal storage variable

Mon, 1 Oct 2012 09:20:02 +0000

This issue is created automatically through a Github pull request on behalf of Slamdunk:

Url: https://github.com/doctrine/common/pull/191

Message:

Until now, exporting `ArrayObject` hid the internal storage variable, but `print_r` and `var_dump` show it.

With this PR the `ArrayObject::storage` variable is exported too.

[DCOM-96] Extract a common ProxyFactory

Thu, 10 Jan 2013 22:25:47 +0000

Currently, each Doctrine project implements its own ProxyFactory. But the most part of the logic is simply copy-pasted from the ORM implementation (or from an older version of the ORM implementation). Extracting the common code would be a good idea to avoid having to maintain 4 places (or even more) containing the same logic

[DCOM-93] Add Reflection Abstraction

Reference — Tue, 3 Jan 2012 21:56:55 +0000

The Reflection code in ClassMetadata(Info*)s is getting out of control.

I want to remove the dependency by introducing a ReflectionService interface:

interface ReflectionService
{
    public function getClassShortName($class);
    public function getClassNamespace($class);
    public function getClass($class);
    public function getAccessibleProperty($class, $property);
    public function hasPublicMethod($class, $method);
}

The reflection methods are specifically allowed to return NULL, so that we can create a StaticReflectionService that works without the classes actually existing.

[DCOM-91] GH-87: typos

Mon, 16 Jan 2012 05:52:06 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/common/pull/87

[DCOM-90] GH-86: class_exists is great, use it.

Mon, 16 Jan 2012 05:45:21 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/common/pull/86

[DCOM-89] GH-85: php annotations

Sat, 9 Jun 2012 11:56:17 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/common/pull/85

Hello all,

This patch add support for php annotations, I think that is very useful to collect class metadata.
This patch support just 3 annotations ```@var, @param, @return```. but any annotation could be added.

@schmittjoh can you take a look please ?

Any suggestion are welcome.

Thanks

[DCOM-88] GH-84: Fixed phpdoc for the persistence interfaces

Mon, 16 Jan 2012 06:12:05 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/common/pull/84

[DCOM-87] Add a method to retrieve the identifier values in the Common interfaces

Mon, 2 Jan 2012 14:21:07 +0000

Currently, https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Security/User/EntityUserProvider.php is tied to the ORM, forcing bundle integrating other Doctrine projects to reimplement it.

The only place which is not (or cannot be) implemented using only methods from the Common interfaces is retrieving the current id. `getIdentifierValues` is now implemented by the ClassMetadata in all ORM, MongoDB and CouchDB but not in the interface.

Note that the tricky point about adding it is the fact that the DisconnectedMetadataFactory (used when generating entities) returns a ClassMetadataInfo instead, which does not contain this method (as it relies on the existence of the class) but implements the interface.

[DCOM-85] GH-81: Add Proxy#__load()

Mon, 12 Dec 2011 19:19:46 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/common/pull/81

[DCOM-82] Fix composer.json in 2.1.x releases missing autoloader

Sat, 26 Nov 2011 08:10:34 +0000

Fix composer.json in 2.1.x releases missing autoloader

[DCOM-81] Attempt to create Annotation File Cache directory

Wed, 23 Nov 2011 19:50:38 +0000

Attempt to create Annotation File Cache directory

[DCOM-79] Move Lifecycle Events into Doctrine\Common\Persistence\Events

Mon, 12 Dec 2011 19:21:59 +0000

Move Lifecycle Events into Doctrine\Common\Persistence\Events

[DCOM-78] ZendDataCache, Can't use method return value in write context

Sat, 19 Nov 2011 13:24:50 +0000

On line 70, empty($this->getNamespace()).

empty() works only with variables so you need to assign the namespace to something before using empty().

Fatal error: Can't use method return value in write context in Doctrine/Common/Cache/ZendDataCache.php on line 70

[DCOM-101] Implement FilesystemCache

Mon, 25 Jun 2012 13:01:48 +0000

Implement FilesystemCache, storing var exported pieces that could be loaded on demand.

[DCOM-172] [GH-254] Update lib/Doctrine/Common/Proxy/ProxyGenerator.php

Tue, 19 Feb 2013 09:37:42 +0000

This issue is created automatically through a Github pull request on behalf of mmarksnippety:

Url: https://github.com/doctrine/common/pull/254

Message:

Added missed semicolon

[DCOM-171] [GH-253] Proxy Generation Bug

Sat, 16 Feb 2013 21:17:25 +0000

This issue is created automatically through a Github pull request on behalf of odiaseo:

Url: https://github.com/doctrine/common/pull/253

Message:

Added missing semi colon and removed backslashes previously used to escape function arguments

[DCOM-169] [GH-249] Namespaced the PR246 test case

Tue, 29 Jan 2013 12:53:23 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/common/pull/249

Message:

Sorry, I've forgot the namespace in the test case of my previous PR, which has just been merged.

[DCOM-167] [GH-248] Hotfix/doctrine/common#247 fixes

Sat, 26 Jan 2013 23:52:34 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/common/pull/248

Message:

Includes fixes suggested for #247 (plus a weird fix on a failure with `array_map` on PHP <5.4)

[DCOM-166] [GH-246] Undefined variable fix

Sat, 26 Jan 2013 16:17:46 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/common/pull/246

Message:

[DCOM-159] [GH-241] Minor performance optimization for lookups of `ArrayCollection#contains()`

Tue, 8 Jan 2013 17:30:18 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/common/pull/241

Message:

[DCOM-157] [GH-239] Update lib/Doctrine/Common/Cache/Cache.php

Sun, 6 Jan 2013 22:28:00 +0000

This issue is created automatically through a Github pull request on behalf of lmammino:

Url: https://github.com/doctrine/common/pull/239

Message:

Typo in interface documentation

[DCOM-158] [GH-240] [Cache/CouchbaseCache] Return false instead of null for compat.

Mon, 7 Jan 2013 23:05:04 +0000

This issue is created automatically through a Github pull request on behalf of daschl:

Url: https://github.com/doctrine/common/pull/240

Message:

This changeset fixes and verifies that instead of null, false is returned
from the fetch method. This fixes a bug which causes CouchbaseCache not
to work in combination with the ORM library. Test added.

[DCOM-155] [GH-237] Update tests/Doctrine/Tests/Common/Annotations/Fixtures/NamespaceWithClo...

Thu, 10 Jan 2013 23:27:57 +0000

This issue is created automatically through a Github pull request on behalf of vincequeiroz:

Url: https://github.com/doctrine/common/pull/237

Message:

...sureDeclaration.php

Statement duplicate

$var = 1;
function () use ($var) {};

[DCOM-154] [GH-236] Adding Support for Couchbase as Caching Infrastructure.

Sun, 6 Jan 2013 19:13:22 +0000

This issue is created automatically through a Github pull request on behalf of daschl:

Url: https://github.com/doctrine/common/pull/236

Message:

This changeset brings in support for Couchbase Server 2.0 as
the caching layer. The interface is identical to the memcached
one, but using ext/couchbase allows to take advantage of the
automatic cluster discovery and failover functionality provided.

[DCOM-153] [GH-235] Improve performance of if key exists in the array

Tue, 18 Dec 2012 08:23:24 +0000

This issue is created automatically through a Github pull request on behalf of basico:

Url: https://github.com/doctrine/common/pull/235

Message:

So, here are few indications:
http://php.net/manual/en/function.array-key-exists.php#107786
http://php.net/manual/en/function.array-key-exists.php#104474

[DCOM-149] [GH-231] Fixing CS

Mon, 14 Jan 2013 01:46:39 +0000

This issue is created automatically through a Github pull request on behalf of ruian:

Url: https://github.com/doctrine/common/pull/231

Message:

[DCOM-148] [GH-229] Decorator base class for object manager decorators

Sun, 20 Jan 2013 19:01:12 +0000

This issue is created automatically through a Github pull request on behalf of lstrojny:

Url: https://github.com/doctrine/common/pull/229

Message:

As discussed on IRC, the first PR for decorator base classes. This time for ObjectManager.

[DCOM-147] [GH-227] [DDC-2160] Smart Pluralize/Singularize support for Doctrine/Common/Util/Inflector

Mon, 14 Jan 2013 01:45:37 +0000

This issue is created automatically through a Github pull request on behalf of jbergler:

Url: https://github.com/doctrine/common/pull/227

Message:

Doctrine/ORM/Tools/EntityGenerator should pluralize/signularize correctly.

This PR adds functionality to Doctrine/Common/Util/Inflector to singularize/pluralize. The code is largely borrowed from a similar class in the CakePHP project - I'm not sure if the updates to the class doc covers the requirements for this.

Test coverage also added.

[DCOM-146] [GH-226] Added error suppression to unlink() calls

Thu, 22 Nov 2012 19:55:37 +0000

This issue is created automatically through a Github pull request on behalf of SalmanPK:

Url: https://github.com/doctrine/common/pull/226

Message:

Added error suppression to unlink() calls in the getPropertyAnnotations and getMethodAnnotations methods to be consistent with the getClassAnnotations method.

[DCOM-145] [GH-225] Replace file_exists() calls with is_file() where it is needed

Wed, 21 Nov 2012 00:04:58 +0000

This issue is created automatically through a Github pull request on behalf of fruit:

Url: https://github.com/doctrine/common/pull/225

Message:

The function `file_exists()` checks whether file or directory exists. And `is_file()` checks only files for the existence. All places, where `file_exists()` is replaced with `is_file()` needs only to check for file existence.

[DCOM-144] [GH-224] Use preg_quote() to escape text before inserting into regexp

Wed, 21 Nov 2012 08:42:20 +0000

This issue is created automatically through a Github pull request on behalf of fruit:

Url: https://github.com/doctrine/common/pull/224

Message:

PHP has build-in function `preg_quote()` in order to escape strings witch are dynamically inserted into regular expression.

[DCOM-143] [GH-223] Fix for DCOM-106

Wed, 21 Nov 2012 00:06:09 +0000

This issue is created automatically through a Github pull request on behalf of nemekzg:

Url: https://github.com/doctrine/common/pull/223

Message:

Both fixme and TODO become ignored.

[DCOM-142] [GH-222] make Base LifecycleEventArgs usable in orm and odm

Wed, 5 Dec 2012 12:20:09 +0000

This issue is created automatically through a Github pull request on behalf of docteurklein:

Url: https://github.com/doctrine/common/pull/222

Message:

Pull requests are to come for both orm and odm to make use of this.

The main goal is to make more abstract listeners, compatible with both orm and odm.

[DCOM-141] [GH-221] strip invalid characters

Mon, 14 Jan 2013 01:44:55 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/common/pull/221

Message:

This patch is proposal to fix #180
by replace invalid characters and hashing the filename as sub directories to create a unique path.

[DCOM-136] [GH-216] Adding failing test for silent autoloaders

Thu, 10 Jan 2013 23:26:54 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/common/pull/216

Message:

Fixing support for silent autoloaders

[DCOM-43] Cache Stats

Wed, 21 Sep 2011 14:57:26 +0000

Doctrine should be able to retrieve stats from cache providers, such as Memcache and APC. Stats may list cache hits, cache misses, memory, and so forth.

[DCOM-41] Make annotation parser a bit cleverer

Thu, 7 Apr 2011 14:22:01 +0000

From an initial look that I had at the annotation parser, it simply search for anything starting with an "@" somewhere in the doc comment and assumes that it is an annotation. Now, if someone uses the @ somewhere in his doc comment but not as an annotation, the parser breaks.

An example for this can be found in the Doctrine code base, the following comment will result in a parse error:

    /**
     * Annotation     ::= "@" AnnotationName ["(" [Values] ")"]
     * AnnotationName ::= QualifiedName | SimpleName | AliasedName
     * QualifiedName  ::= NameSpacePart "\" {NameSpacePart "\"}* SimpleName
     * AliasedName    ::= Alias ":" SimpleName
     * NameSpacePart  ::= identifier
     * SimpleName     ::= identifier
     * Alias          ::= identifier
     *
     * @return mixed False if it is not a valid annotation.
     */

Obviously the first @ is not used to refer to an annotation here. I think it makes sense to allow new annotations only to start at a new line, what do you think?

[DCOM-40] Using shared references with the SharedFixtureInterface with the DataFixtures extension will not work.

Wed, 14 Sep 2011 16:48:36 +0000

I did not know where to issue that component, but since this extension using the Doctrine Common namespace I thought it relevant to issue the bug here.

Consider the following shared fixures (as stated on jwage's github repo here: https://github.com/doctrine/data-fixtures)

In case if fixture objects have relations to other fixtures, it is now possible to easily add a reference to that object by name and later reference it to form a relation. Here is an example fixtures for Role and User relation

namespace MyDataFixtures;

use Doctrine\Common\DataFixtures\AbstractFixture;

class LoadUserRoleData extends AbstractFixture
{
    public function load($manager)
    {
        $adminRole = new Role();
        $adminRole->setName('admin');

        $anonymousRole = new Role;
        $anonymousRole->setName('anonymous');

        $manager->persist($adminRole);
        $manager->persist($anonymousRole);
        $manager->flush();

        // store reference to admin role for User relation to Role
        $this->addReference('admin-role', $adminRole);
    }
}

namespace MyDataFixtures;

use Doctrine\Common\DataFixtures\AbstractFixture;

class LoadUserData extends AbstractFixture
{
    public function load($manager)
    {
        $user = new User();
        $user->setUsername('jwage');
        $user->setPassword('test');
        $user->setRole(
            $this->getReference('admin-role') // load the stored reference
        );

        $manager->persist($user);
        $manager->flush();

        // store reference of admin-user for other Fixtures
        $this->addReference('admin-user', $user);
    }
}

This will not use the last reference as a MANAGED entity but whether as a NEW one since the manager gets cleared (thus the unit of work) on each call to load() for the AbstractExecutor and thus marking any new references to the 'admin-user' considered a NEW entity, which should not be the case.

The current workaround is to directly fetch the entity using the EM's find() function, but that completely eliminates the main goal SharedFixtures' references are bringing.

I have provided the small patch that adress this issue, tests still pass.

[DCOM-39] It is not possible to load multiple directories under the same namespace

Fri, 4 Mar 2011 03:31:50 +0000

Consider the following code snippet:

$loader = new ClassLoader('DoctrineExtensions',
   "/path/to/vendor/doctrine2-extensions-beberlei/lib");
$loader->register();

$loader = new ClassLoader('DoctrineExtensions',
   "/path/to/vendor/doctrine2-extensions-srosato/lib");
$loader->register();

The latter will not be able to be loaded since the documentation specifies (with good reason) that class loaders do not fail silently. Is there a workaround for this issue?

[DCOM-98] Fix bug with memcache/memcached and 0 as expire

Fri, 30 Mar 2012 18:48:27 +0000

Fix bug with memcache/memcached and 0 as expire

[DCOM-3] Public value property in Base annotation class

Mon, 14 Jun 2010 09:14:45 +0000

1) If our annotation doesn't need any parameters, it stll can accept one ('value').
2) We can intercept set and get of annotation properties via __set and __get methods which is not final, but not for 'value'.
Example of interception

class Annotation extends \Doctrine\Common\Annotations\Annotation
{

    private $someProperty;
    
    public function __set($name, $value)
    {
        $setMethod = 'set' . ucfirst($name);
        if (method_exists($this, $setMethod)) {
            return $this->{$setMethod}($value);
        }
        return parent::__set($name, $value);
    }
    
    public function __get($name)
    {
        $getMethod = 'get' . ucfirst($name);
        if (method_exists($this, $getMethod)) {
            return $this->{$getMethod}();
        }
        return parent::__get($name);
    }

    public function getSomeProperty()
    {
        //some logic
        return $this->someProperty;
    }

    protected function setSomeProperty($someProperty)
    {
        //some logic
        $this->someProperty = $someProperty;
    }
}

[DCOM-21] Bug with annotations parser and tags that are not annotations (stripped tags)

Wed, 18 Aug 2010 14:34:29 +0000

Bug with annotations parser and tags that are not annotations (stripped tags)

[DCOM-20] ClassLoader should check before require()...

Thu, 12 Aug 2010 14:21:30 +0000

I noticed that prior to the require function call in loadClass(), no attempt is made to see if the file can be loaded, or to trap the result of the require attempt.

This means that when I chain together class loaders on the autoload stack, the first one that specifies a namespace of null effectively terminates the process, preventing any others from being run.

[DCOM-19] Transitive persistence on collections doesn't work when cascade is set to "all"

Wed, 11 Aug 2010 08:22:32 +0000

In documentation it says that cascade needs be set to persist for transitive persistence to work (http://www.doctrine-project.org/projects/orm/2.0/docs/reference/working-with-associations/en#transitive-persistence-/-cascade-operations:persistence-by-reachability:-cascade-persist) , but since "all" setting is a superset of "persist" it should work for that setting as well (but it doesn't )

[DCOM-17] Add Collection::slice($offset, $length)

Fri, 14 Jan 2011 05:39:16 +0000

Since we are still at a point were bc breaks are potentially not so harming:

We need a slice() method on the Collection for forward compatibility, the support for large and very large collections using FETCH_EXTRA would heavily benefit from a method like this.

/**
 * Extract a slice of $length elements starting at position $offset from the Collection.
 * 
 * If $length is null it returns all elements from $offset to the end of the Collection.
 * Keys have to be preserved by this method.
 * 
 * @param int $offset
 * @param int $length
 * @return array
 */
public function slice($offset, $length = null);

The ArrayCollection implement would be:

public function slice($offset, $length = null);
{
    return array_slice($this->_elements, $offset, $length, true); // preserve keys
}

[DCOM-18] ArrayCollection::removeElement() violates Interface Contract

Mon, 9 Aug 2010 15:52:47 +0000

ArrayCollection::removeElement() violates Interface Contract

[DCOM-13] Better flexibility when the Annotation is created by the Parser

Mon, 2 Aug 2010 09:52:58 +0000

The creation of the Annotation class is done at the end in Parser::Annotation(). It assumes that the Annotation class constructor takes an array of values. But if this is not the case, you are out of luck. So, I propose to move the logic of Annotation creation to is own method for better flexibility.

[DCOM-12] Annotation caching causes application instance mixups

Tue, 13 Jul 2010 12:51:29 +0000

Take a look at lib/Doctrine/Common/Annotations/AnnotationReader.php:137

 
    /**
     * Gets the annotations applied to a class.
     * 
     * @param string|ReflectionClass $class The name or ReflectionClass of the class from which
     * the class annotations should be read.
     * @return array An array of Annotations.
     */
    public function getClassAnnotations(ReflectionClass $class)
    {
        $cacheKey = $class->getName() . self::$CACHE_SALT;

        // Attempt to grab data from cache
        if (($data = $this->cache->fetch($cacheKey)) !== false) {
            return $data;
        }
        
        $annotations = $this->parser->parse($class->getDocComment(), 'class ' . $class->getName());
        $this->cache->save($cacheKey, $annotations, null);
        
        return $annotations;
    }

It uses the class name and a static salt to create a cache key. Actually, everything in that class uses a class name to assemble a cache key.

This makes it impossible to have mulitple instances of the same application in different states. Practically: it makes it impossible to have testing and staging, or staging and production versions on the same host if they use the same type of caching (which you sort of need in a staging environment).

[DCOM-6] Non existant namespace alias throws a PHP Notice

Wed, 1 Sep 2010 13:13:34 +0000

@nonalias:Annot results in a php notice.

[DCOM-181] [GH-260] Hotfix/issue #259

Fri, 8 Mar 2013 07:41:05 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/common/pull/260

Message:

Hotfix for doctrine/common#259

[DCOM-183] [GH-262] Fixed travis build

Mon, 11 Mar 2013 01:56:51 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/common/pull/262

Message:

since composer/composer#1005 composer updates --dev by default.

[DCOM-182] [GH-261] Fixed typos

Mon, 11 Mar 2013 01:56:33 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/common/pull/261

Message:

[DCOM-170] [GH-250] Adding export attributes

Tue, 16 Apr 2013 08:00:41 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/common/pull/250

Message:

[DCOM-188] [GH-272] MappingDriverChain: the default driver wasn't called for getAllClassNames()

Tue, 16 Apr 2013 21:52:33 +0000

This issue is created automatically through a Github pull request on behalf of mnapoli:

Url: https://github.com/doctrine/common/pull/272

Message:

`MappingDriverChain::getAllClassNames()` would call and merge sub-drivers `getAllClassNames()` results, but not for the default driver.

I added a test that reproduced the problem, and then fixed it.

[DCOM-192] [GH-274] Improve code on loadMetadata() to verify if class exists

Wed, 8 May 2013 17:45:33 +0000

This issue is created automatically through a Github pull request on behalf of entering:

Url: https://github.com/doctrine/common/pull/274

Message:

Improve code on loadMetadata() to verify if class exists, avoid a later warning when calling class_parents()

Instead throws a \RuntimeException if class doesn't exists.

Before changing code, just after add test:
```
1) Doctrine\Tests\Common\Persistence\Mapping\ClassMetadataFactoryTest::testGetMetadataForAbsentClass
class_parents(): Class Doctrine\Tests\Common\Persistence\Mapping\AbsentClass does not exist and could not be loaded

/home/www/common/lib/Doctrine/Common/Persistence/Mapping/RuntimeReflectionService.php:38
/home/www/common/lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php:257
/home/www/common/lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php:281
/home/www/common/lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php:212
/home/www/common/tests/Doctrine/Tests/Common/Persistence/Mapping/ClassMetadataFactoryTest.php:44
```

[DCOM-193] [GH-275] Improve code to throw exception getting parents class instead of php warning

Thu, 9 May 2013 21:35:40 +0000

This issue is created automatically through a Github pull request on behalf of entering:

Url: https://github.com/doctrine/common/pull/275

Message:

[DCOM-190] [GH-273] Added visibility in the methods Interfaces

Tue, 21 May 2013 03:40:10 +0000

This issue is created automatically through a Github pull request on behalf of ramonornela:

Url: https://github.com/doctrine/common/pull/273

Message:

This adjustment aims to bring to the default PSR2.
I see more alerts and warnings this is only a part.

Thanks,
Ramon

[DCOM-123] [GH-202] Add sqlite cache driver

Thu, 23 May 2013 22:28:23 +0000

This issue is created automatically through a Github pull request on behalf of Baachi:

Url: https://github.com/doctrine/common/pull/202

Message:

[DCOM-201] [GH-284] Adding failing test demonstrating DCOM-175

Wed, 19 Jun 2013 21:24:21 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/common/pull/284

Message:

Private properties of parent classes are not serialized correctly, therefore PHP throws a notice during serialization

[DCOM-49] Debug::dump/export for ODM documents

Mon, 16 Jan 2012 06:10:05 +0000

Doctrine\Common\Util\Debug has code to deal with Proxy objects from the ORM, but nothing for other Doctrine projects.

Maybe the Common package should introduce a base Proxy interface so the Debug class isn't dependant on the ORM? This would also mean standardising Proxy objects, particularly the private property names...

ORM proxy objects have $identifier and $_entityPersister while ODM proxy objects have $identifier_ and $_documentPersister. I think they should both use $identifier_ and $_persister_ and $_isInitialized_.

I suppose the team is wait for Doctrine ODM to become stable before changing this?

[DCOM-37] orm:convert-d1-schema not working

Wed, 14 Sep 2011 16:32:11 +0000

orm:convert-d1-schema ~/schema.yml yml ~/newyml returns The helper "em" is not defined

[DCOM-63] CacheReader does not take in account parent classes

Wed, 14 Sep 2011 16:25:25 +0000

As the title says, Doctrine\Common\Annotations\CachedReaded is buggy.

It takes in account only modification time of file of the class it processes. But it ignores it's parents.

Pull: https://github.com/doctrine/common/pull/54

Shoud I change the commit message or something?

[DCOM-59] ArrayCollection contains function - switch from in_array to foreach

Sun, 28 Aug 2011 03:21:33 +0000

The function contains uses in_array to determine if an element provided as parameter is found in the array $this->_elements, and performs a strict comparison.
There might be a way to improve the performances of this function by using a foreach + if

In attachement you can find a small bench file to show the differences between in_array and foreach on object search.
You might want to run the bench with a doctrine Object to verify if this changes anything to the result.
For simple Objects, foreach is much faster when the array has less than 30k elements. Over 30k the difference flattens, and might revert around 50k (meaning that in_array might start being faster when the array has more than 50k entries).

Maybe we could provide two functions, one for smaller than 40-50k items (using foreach), and one for bigger arrays (using in_array) ?

[DCOM-58] Having class named Entity in the global namespace, interferes with the new annotation reader.

Wed, 7 Sep 2011 22:14:24 +0000

Having a class named Entity in the global namespace, results in exceptions: "Class xxx is not a valid entity or mapped super class."
The problem is not present in 2.0

The problem:

\Doctrine\Common\Annotations\DocParser.php

line 421: $reflClass = new \ReflectionClass($name);

$name is "Entity", and the reflection finds the non-doctrine Entity-class in the global namespace, and so doesn't find the "@Annotation" it's looking for when it examines the class.

If I force it to reflect on \Doctrine\ORM\Mapping\Entity instead, the next problem is instantiation:

\Doctrine\Common\Annotations\DocParser.php

line 435: return new $name($values);

Forcing that to the right class, brings a "Failed opening required 'Doctrine/ORM/Mapping/Doctrine/ORM/Mapping/Id.php' " - I haven't investigated further (yet at least).

/Michael

[DCOM-106] Add @todo and @fixme to AnnotationReader::$globalIgnoredNames

Wed, 21 Nov 2012 00:06:25 +0000

I was wondering if you would consider adding @todo and @fixme

After doing some research, I'm not sure if @fixme is used anywhere other than being in Eclipse's PDT. However, @todo is definitely on the common tags of wiki page about PHPdoc as well as the phpDoc manual.

http://en.wikipedia.org/wiki/PHPDoc#Tags
http://manual.phpdoc.org/HTMLSmartyConverter/PHP/phpDocumentor/tutorial_tags.todo.pkg.html

[DCOM-103] Debug::toString issue with swapped parameters

Fri, 28 Dec 2012 09:24:03 +0000

Debug::toString has an issue with swapped parameters:

method_exists('__toString', $obj)

should be

method_exists($obj, '__toString')

[DCOM-94] Support for constants on annotation reader

Thu, 15 Mar 2012 17:41:02 +0000

Would be nice get support for constants on annotation reader.

Usage :

/**
* @SomeAnnotation(PHP_EOL)
* @SomeAnnotation(SomeClass::SOME_VALUE)
* @SomeAnnotation({SomeClass::VALUE1,SomeClass::VALUE2})
* @SomeAnnotation({SomeClass::SOME_KEY = SomeClass::SOME_VALUE})
*/

[DCOM-83] Rename ComparableInterface

Mon, 12 Dec 2011 19:29:13 +0000

see https://github.com/doctrine/common/commit/fce661a041aa1dc3634bd1c04cacd684619579fc for reasoning

I didn't want to do it myself, don't know what depends on this.

[DCOM-100] bad filename for WincacheCahe

Sat, 9 Jun 2012 11:52:59 +0000

object WincacheCache object resides in file WinCacheCache.php and it confuses autoloading.

[DCOM-15] ClassLoader does not autoload when namespace starts with \

Wed, 1 Sep 2010 13:46:35 +0000

Instantiating a fully qualified namespace (with a prefixed ) will not autoload modules, even while the canLoadClass reports it can and loadClass will load it...

Will NOT work
$classLoader = new \Doctrine\Common\ClassLoader('\Application\Models', '/some/path');
$classLoader->register();
new \Application\Models\SomeClass();

Will work
$classLoader = new \Doctrine\Common\ClassLoader('Application\Models', '/some/path');
$classLoader->register();
new \Application\Models\SomeClass();

Some sanitization or an exception on this would improve things a bit.

[DCOM-11] Impossible to skip annotations

Mon, 2 Aug 2010 17:28:15 +0000

It is currently impossible to skip annotations of the form:
@annotation(

When a doc block comment begins with an "@" and has an open parenthesis it is assumed to be an exist annotation even if the corresponding annotation class doesn't exist or can't be autoloaded. If you are trying to use the AnnotationReader on a file, you have to make sure all annotations are loaded or can be autoloaded - even the ones you don't care about

In a comment to ~~DCOM-2~~, Roman stated that his recommended way to load annotations is to load them manually via a require call. This is done in Doctrine ORM and is absolutely necessary because ORM annotations are stored in an autoloader unfriendly way (multiple classes per file and namespace path different from filesystem path).

So, if I want to add my own annotations and store them in a non-autoloader friendly way as Doctrine ORM does, I need to ensure that every AnnotationReader acting on that file knows about my annotations. This is not always possible or desirable.

Removing the parenthesis check and relying solely on class_exists fixes this problem.

[DCOM-197] [GH-280] Typo in MappingException

Mon, 10 Jun 2013 10:35:32 +0000

This issue is created automatically through a Github pull request on behalf of halaxa:

Url: https://github.com/doctrine/common/pull/280

Message:

[DCOM-26] Notice when using an alias that is not registered

Mon, 1 Nov 2010 20:52:47 +0000

If you have an annotation that uses an alias that is not registered like:

  /**
   * @foo:SomeAnnot
   */
  ...

Then, the Parser will throw a PHP Notice:

Notice: Undefined index: foo in .../lib/Doctrine/Common/Annotations/Parser.php line 317

[DCOM-23] Add interface for ObjectManager

Duplicate — Sun, 31 Oct 2010 03:58:54 +0000

Add a ObjectManager interface so it is possible to write code that supports the EntityManager and DocumentManager at the same time.

Ornicar (Thibault Duplessis) did this gist: http://gist.github.com/545320

[DCOM-52] Doctrine\Common\Util\Debug::dump(): Why strip_tags dumps ?

Sun, 17 Jul 2011 15:03:21 +0000

I use Doctrine\Common\Util\Debug::dump() for debugging my entities, but original method call strip_tags from the output generated by var_dump, so i got a nasty debug which is a very long line not formatted.
I commented the strip_tags call, so my debug is more human readable.
Is it possible to remove the strip_tags call, or let the developper to choose if debug method should call it or not ?

[DCOM-38] Annotation parser plain value types

Thu, 7 Apr 2011 15:37:15 +0000

Hi,

I posted this question in doctrine user group(https://groups.google.com/forum/?fromgroups#!topic/doctrine-user/QhAz-Yr70T0), but with no response, so I'd like to open it up here as the solution is trivial and would save me either a lot of sub-classing or prevent me from changing the doctrine library files.

This annotation

class SomeGrid {
    /**
     *  @GRID:Column(header="Reg. plate", width=80, editable=TRUE, hidden=FALSE, tooltip="Registration plate", align="left", sortable=TRUE)
     */
    public $regPlate;
}

produces the following object:

(object) Grid\Annotations\Column {
    "header"   => (string) "Reg. plate"
    "width"    => (string) "80"
    "editable" => (bool)   true
    "hidden"   => (bool)   false
    "tooltip"  => (string) "Registration plate"
    "align"    => (string) "left"
    "sortable" => (bool)   true
}

You can see the value of the width property is string even I didn't use quotes in the annotation.
The same happens with float values, but true and false values become, correctly, bool.

I found this happens because of the following fragment of code in \Doctrine\Common\Annotations\Parser and could be easily corrected by prefixing the value with the corresponding type cast (marked in red).

    case Lexer::T_STRING:
        $this->match(Lexer::T_STRING);
        return $this->lexer->token['value'];
    case Lexer::T_INTEGER:
        $this->match(Lexer::T_INTEGER);
        return (int)$this->lexer->token['value'];
    case Lexer::T_FLOAT:
        $this->match(Lexer::T_FLOAT);
        return (float)$this->lexer->token['value'];
    case Lexer::T_TRUE:
        $this->match(Lexer::T_TRUE);
        return true;
    case Lexer::T_FALSE:
        $this->match(Lexer::T_FALSE);
        return false;

The point is, in our app, some of the values go directly to browser and are processed by JavaScript. Having those values as strings breaks all kinds of mathematical operations on the client or would require additional (unnecessary) string to int/float conversions.

Doctrine Project

[DCOM-61] Class annotation is not setting annotation properties

[DCOM-84] Improve Proxy Naming

[DCOM-173] Add test assets and tests for proxy generators

[DCOM-27] Method Next from ArrayCollection needs to return something!

[DCOM-25] method setAutoloadAnnotationClasses-fails

[DCOM-69] [APC Cache] doFlush does not clear user cache

[DCOM-194] Creating Proxy class failure for own __get method

[DCOM-31] setAutoloadAnnotationClasses() within AnnotationReader fails

[DCOM-57] Doctrine\Common\Cache\AbstractCache::deleteAll() does not take the namespace into account

[DCOM-56] Remote autoloading from annotations completly, replacing it with its own loading mechanism

[DCOM-55] Ugly problems with default import __NAMESPACE__ when it contains non-annotation classes that are docblock props

[DCOM-54] ClassLoader protected properties

[DCOM-53] PhpParser doesn't ignore commented keywords

[DCOM-51] Support parsing of single quotes

[DCOM-50] Unable to use '@' in combination with a number (example: email@3domain.tld) in comment block

[DCOM-47] When using different class loaders

[DCOM-45] Allow different namespaces for the same alias

[DCOM-46] Make annotation index configurable

[DCOM-44] Throw exception if known namespaced annotation is not found

[DCOM-32] Memcache cache relies on deprecated functions

[DCOM-76] switch license to MIT

[DCOM-71] Add save get_class() to Debug Util

[DCOM-70] [CacheProvider] missing functions

[DCOM-68] Add @codeCoverageIgnoreStart and @codeCoverageIgnoreEnd to annotation ignore map

[DCOM-66] Github-PR-55 by shesek: Use stream_resolve_include_path

[DCOM-62] Github-PR-53 by shawndellysse: ArrayCollection#join

[DCOM-60] SimpleAnnotationReader get*Annotations

[DCOM-127] [GH-206] Debug::export ArrayIterator dumps the internal storage variable

[DCOM-126] [GH-205] Fixed a typo in PHPdoc

[DCOM-125] [GH-204] Bad function call in Debug::toString()

[DCOM-122] [GH-200] ClassMetadataFactory child classes can now filter the metadata when calling getAllMetadata

[DCOM-116] [GH-193] Optimize autoload prefix in composer.json

[DCOM-115] [GH-191] Debug::export ArrayObject dumps the internal storage variable

[DCOM-96] Extract a common ProxyFactory

[DCOM-93] Add Reflection Abstraction

[DCOM-91] GH-87: typos

[DCOM-90] GH-86: class_exists is great, use it.

[DCOM-89] GH-85: php annotations

[DCOM-88] GH-84: Fixed phpdoc for the persistence interfaces

[DCOM-87] Add a method to retrieve the identifier values in the Common interfaces

[DCOM-85] GH-81: Add Proxy#__load()

[DCOM-82] Fix composer.json in 2.1.x releases missing autoloader

[DCOM-81] Attempt to create Annotation File Cache directory

[DCOM-79] Move Lifecycle Events into Doctrine\Common\Persistence\Events

[DCOM-78] ZendDataCache, Can't use method return value in write context

[DCOM-101] Implement FilesystemCache

[DCOM-172] [GH-254] Update lib/Doctrine/Common/Proxy/ProxyGenerator.php

[DCOM-171] [GH-253] Proxy Generation Bug

[DCOM-169] [GH-249] Namespaced the PR246 test case

[DCOM-167] [GH-248] Hotfix/doctrine/common#247 fixes

[DCOM-166] [GH-246] Undefined variable fix

[DCOM-159] [GH-241] Minor performance optimization for lookups of `ArrayCollection#contains()`

[DCOM-157] [GH-239] Update lib/Doctrine/Common/Cache/Cache.php

[DCOM-158] [GH-240] [Cache/CouchbaseCache] Return false instead of null for compat.

[DCOM-155] [GH-237] Update tests/Doctrine/Tests/Common/Annotations/Fixtures/NamespaceWithClo...

[DCOM-154] [GH-236] Adding Support for Couchbase as Caching Infrastructure.

[DCOM-153] [GH-235] Improve performance of if key exists in the array

[DCOM-149] [GH-231] Fixing CS

[DCOM-148] [GH-229] Decorator base class for object manager decorators

[DCOM-147] [GH-227] [DDC-2160] Smart Pluralize/Singularize support for Doctrine/Common/Util/Inflector

[DCOM-146] [GH-226] Added error suppression to unlink() calls

[DCOM-145] [GH-225] Replace file_exists() calls with is_file() where it is needed

[DCOM-144] [GH-224] Use preg_quote() to escape text before inserting into regexp

[DCOM-143] [GH-223] Fix for DCOM-106

[DCOM-142] [GH-222] make Base LifecycleEventArgs usable in orm and odm

[DCOM-141] [GH-221] strip invalid characters

[DCOM-136] [GH-216] Adding failing test for silent autoloaders

[DCOM-43] Cache Stats

[DCOM-41] Make annotation parser a bit cleverer

[DCOM-40] Using shared references with the SharedFixtureInterface with the DataFixtures extension will not work.

[DCOM-39] It is not possible to load multiple directories under the same namespace

[DCOM-98] Fix bug with memcache/memcached and 0 as expire

[DCOM-3] Public value property in Base annotation class

[DCOM-21] Bug with annotations parser and tags that are not annotations (stripped tags)

[DCOM-20] ClassLoader should check before require()...

[DCOM-19] Transitive persistence on collections doesn't work when cascade is set to "all"

[DCOM-17] Add Collection::slice($offset, $length)

[DCOM-18] ArrayCollection::removeElement() violates Interface Contract

[DCOM-13] Better flexibility when the Annotation is created by the Parser

[DCOM-55] Ugly problems with default import NAMESPACE when it contains non-annotation classes that are docblock props