Doctrine Project

[DCOM-74] Ideas for Event Manager Improvements

Wed, 6 Feb 2013 23:25:47 +0000

I have two ideas for improving the event manager.

1. Add a lazy-loading implementation as we discussed on IRC already (helpful for keeping the overhead of post generation schema listener down for example)
2. Providing better debugging information of what is going on (which listeners have been called for which event, similar to Symfony2's event dispatcher)

[DCOM-73] CodeGeneration using Doctrine\Common\Persistence\Mapping\ObjectMetadata

Thu, 16 Feb 2012 19:27:38 +0000

Currently we have tons of code in the ODM/ORMs regarding code generation that are ugly to extend and maintain. We should extract all them into a new component, for example named: doctrine-code-generator

It should be feed by only instances of Doctrine\Common\Persistence\Mapping\ObjectMetadata into a twig template.
A base template for an entity/document is shipped
Maybe ORM/ODM specific child templates or twig traits are necessary to handle writing annotations. This could also be done by adding hooks into the code-generation somehow.
Each entity of the user can provide its own template, for examples from a configurable directory "code_templates/Vendor.ProjectBundle.Entity.User.twig" to extend the base template and add own code.
As a perspective we should aim for 5.4 generating a trait so that you can have your entity "class User { use UserBase; }
"

[DCOM-67] Introduce immutable DateTime with __toString()

Sun, 29 Jan 2012 16:30:23 +0000

Introduce immutable DateTime with __toString()

[DCOM-131] [GH-210] MappingDriverChain::getAllClassNames should load all classes from the defaultDriver

Sat, 27 Oct 2012 23:17:51 +0000

This issue is created automatically through a Github pull request on behalf of rnijveld:

Url: https://github.com/doctrine/common/pull/210

Message:

I actually tried working around this by adding a driver using an empty string as the namespace, only to find out that `strpos()` doesn't accept an empty delimiter.

Anyway, this makes sure that all loadable classes for the defaultDriver are actually returned by MappingDriverChain as well.

[DCOM-121] [GH-198] [DCOM-118] fix for issue #195

Wed, 3 Oct 2012 17:46:24 +0000

This issue is created automatically through a Github pull request on behalf of pscheit:

Url: https://github.com/doctrine/common/pull/198

Message:

I'm sorry, i have no idea why i got here now 23 commits .. i tried but no success.

[DCOM-118] [GH-195] Add failing test to demonstrate parse error when @ is present in the description

Wed, 3 Oct 2012 04:27:17 +0000

This issue is created automatically through a Github pull request on behalf of Seldaek:

Url: https://github.com/doctrine/common/pull/195

Message:

If someone can take this and fix the issue it'd be great. I couldn't figure it out at a quick glance and I don't really have time, but it's a pretty messed up bug and not so trivial to debug if you don't know what happens in the background so I'd say it's pretty important.

[DCOM-104] Dump() has side-effects or is unreliable

Fri, 11 Jan 2013 18:21:57 +0000

after setting a one-to-one bi-directional relationship, I am hunting a bug and trying this:

\Doctrine\Common\Util\Debug::Dump($this->lord, 1);
\Doctrine\Common\Util\Debug::Dump($this, 2);
\Doctrine\Common\Util\Debug::Dump($this->lord, 1);

The first Dump() shows $this->lord as being NULL.
The third Dump() shows it as NOT being null, just like the 2nd one also shows it as having a value.

[DCOM-92] CouchDB, MongoDB caches

Sun, 25 Dec 2011 11:16:49 +0000

Very simple persisntent caches for query/view results now that result cache is actually useful

[DCOM-80] Add common exceptions into Doctrine\Common

Tue, 20 Dec 2011 22:48:42 +0000

Following the ZF and SF2 Standard for Exceptions we should have base exceptions in Common

[DCOM-77] add a method to force removal of any unmapped data on flush for a given object

Wed, 16 Nov 2011 22:28:14 +0000

in order to ensure that any unmapped fields are set to their defaults or removed in the case of nosql right now there is no way to do this except with 2 flush calls: aka remove+flush, persist+flush

there should be some way to do this in one flush

[DCOM-102] Updates for Fedora packaging

Sat, 24 Nov 2012 21:44:22 +0000

I am packaging the DoctrineDBAL PEAR package for Fedora and would like to have the following updates:

package.xml role for LICENSE changed from "data" to "doc"

[DCOM-163] [GH-245] Documentation fixes

Sun, 20 Jan 2013 18:20:09 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/common/pull/245

Message:

Documentation fixes, continuing the work done on [ORM](https://github.com/doctrine/doctrine2/pull/528) and [DBAL](https://github.com/doctrine/dbal/pull/243).

Missing docblocks
Missing / incorrect `@param` / `@return` / `@throws` annotations
Missing newlines between annotations
Incorrect vertical alignment of `@param` annotations
Incorrect doctrine-project.org links
SVN leftovers cleanup
Licensing (LGPL => MIT)

[DCOM-162] [GH-244] return parameter for debug method

Mon, 14 Jan 2013 11:02:12 +0000

This issue is created automatically through a Github pull request on behalf of sethunath:

Url: https://github.com/doctrine/common/pull/244

Message:

Added $return as 4th parameter to specify whether to return the debug text or print it. It works similar to print_r function

[DCOM-161] [GH-243] Update composer.json

Fri, 11 Jan 2013 18:15:12 +0000

This issue is created automatically through a Github pull request on behalf of stloyd:

Url: https://github.com/doctrine/common/pull/243

Message:

Add `provide` part as `doctrine/common` >=2.2,<2.4 has cache in it.

[DCOM-160] [GH-242] adds a simple manager registry

Thu, 10 Jan 2013 09:21:48 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/common/pull/242

Message:

This registry adds some sane defaults and just requires a simple callable to be fully functional.

[DCOM-151] [GH-233] [DocParser] Fix trying include classes if its must be ignored.

Mon, 10 Dec 2012 21:08:11 +0000

This issue is created automatically through a Github pull request on behalf of Stroitel:

Url: https://github.com/doctrine/common/pull/233

Message:

I recreate pull request (add test). Without fix test is failure.

[DCOM-138] [GH-219] BC breaking constant name fix

Fri, 16 Nov 2012 12:07:39 +0000

This issue is created automatically through a Github pull request on behalf of jakoch:

Url: https://github.com/doctrine/common/pull/219

Message:

fixed typo on constant name (STATS_MEMORY_AVAILIABLE => STATS_MEMORY_AVAILABLE)

[DCOM-184] [GH-266] Add a new method to use a filter before extracting the metadata

Tue, 12 Mar 2013 21:36:17 +0000

This issue is created automatically through a Github pull request on behalf of nicolasTheodo:

Url: https://github.com/doctrine/common/pull/266

Message:

I have notice that, when you use the doctrine:mapping:convert and doctrine:mapping:import command in symfony, the filter is added after all the metadata are extracting from the database.
In this case, when you have a table with no primary key for example, you cannot extract the mapping for only one entity.

I have also made a pull-request into the doctrineBundle and doctrine2 to fix this issue.
https://github.com/doctrine/DoctrineBundle/pull/161
https://github.com/doctrine/doctrine2/pull/603

What are your thought about my issue?

[DCOM-185] DQL errors when attempting to use GROUP BY MAX(field)

Tue, 26 Mar 2013 22:41:29 +0000

Attempting to run DQL similar to:
SELECT a FROM ClassName a GROUP BY MAX(a.depth)

Throws error:
[Semantical Error] line 0, col 250 near 'MAX(ao.depth)': Error: Cannot group by undefined identification or result variable.

Per docs, MAX is allowed within GROUP BY: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/dql-doctrine-query-language.html#aggregate-functions

If this error is due to some omission on my part, then perhaps the docs should be extended to show a valid GROUP BY MAX() usage, or the error message expanded for a better hint.

[DCOM-186] [GH-269] ProxyGenerator eval() proxy code when $autoGenerate is true

Thu, 28 Mar 2013 15:51:02 +0000

This issue is created automatically through a Github pull request on behalf of mnapoli:

Url: https://github.com/doctrine/common/pull/269

Message:

ProxyGenerator eval() proxy code instead of writing it to disk when $autoGenerate is true.

The idea of eval() the proxy code was suggested by @ocramius in response to the fact that in dev environment, concurrent file writes create errors.

This would also simplify the setup for a dev environment: no more proxy directory to create and make writeable.

[DCOM-187] [GH-270] Allow empty arrays in annotations

Fri, 29 Mar 2013 22:42:25 +0000

This issue is created automatically through a Github pull request on behalf of kitsunet:

Url: https://github.com/doctrine/common/pull/270

Message:

an empty array so far is impossible as it either results in a parse error if you just do the obvious {} or if you try

{""}

it will create an empty entry which in turn will cause errors depending on the annotation.

[DCOM-175] Proxies return private properties in __sleep, which is not supported by PHP.

Fri, 19 Apr 2013 12:06:43 +0000

__sleep should not return private parent property names (see http://php.net/__sleep) this raises notices, and also results in the value of the property being 'N' (null) instead of keeping its value.

I am unfortunately stuck having to serialize proxies in my revision tracking, as doctrine seems to be currently ignoring the fetch="EAGER" I set on the related properties.

Proxies should use the Serializable interface, and not __sleep, or not return parent property names which are private, it serves no purpose, and is not supported by PHP itself anyway.

Also, if you keep __sleep, but do not return the parent property names, then it will only include the items you return, so it would be better to simply drop the __sleep method, I cannot actually see any useful purpose it serves.

[DCOM-152] [GH-234] Criteria filtering doesn't work with DateTime instance

Tue, 30 Apr 2013 16:46:40 +0000

This issue is created automatically through a Github pull request on behalf of ludekstepan:

Url: https://github.com/doctrine/common/pull/234

Message:

Filtering associations doesn't work with DateTime instance as a comparison value because filtering uses === operator. It works with SQL backed filtering, but not on PHP collection level.

```php
$criteria = Criteria::create()
~~>where(Criteria::expr()~~>eq("birthday", new \DateTime("1982-02-17")))
->orderBy(array("username" => "ASC"))
->setFirstResult(0)
->setMaxResults(20)
;
```

[DCOM-189] Doctrine Proxies may conflict with interfaced constructors

Fri, 3 May 2013 13:05:24 +0000

The Doctrine ProxyGenerator generates for a proxy a constructor. The documentation of Doctrine states that the constructor is never called. For a project, I created a group of entities with a interfaced constructor in order to enforce a common interface. This results in a incompatible proxy and so a fatal error.

[DCOM-28] Extract Common Persistance Interfaces

Duplicate — Sat, 30 Jul 2011 13:03:50 +0000

I discussed this with jwage on symfony day cologne and this also came up during discussions with @dzuelke at IPC yesterday. So i hacked up a first patch for discussion that adds a Doctrine\Common\Persistance namespace and extracts the functionality all our 3 layers implement with regards to EntityManager/EntityRepository (and equivalents).

Additionally i think it might make sense to also add an interface "ObjectMetadata" that has several getters-only that allow access to the field, identifier and association mapping information. This stuff is not necessarly compatible across layers when returned as its "array" representation, but for libraries hooking into the metadata (symfony admin generator) this might not even be necessary.

[DCOM-129] Annotation parser matches colon after annotation

Sun, 21 Oct 2012 15:18:35 +0000

Code

/**
* Removes given $node from the tree and reparents its descendants
*
* @todo may be improved, to issue single query on reparenting
* @param object $node
* @throws RuntimeException - if something fails in transaction
* @return void
*/
public function removeFromTree($node)
{

fails with `[Semantical Error] The annotation "@todo:" in method Gedmo\Tree\Entity\Repository\ClosureTreeRepository::removeFromTree() was never imported. Did you maybe forget to add a "use" statement for this annotation?`.

As you see it tryes find annotation with name "@todo:". Don't know, maybe rtrim($name, ':') would enough.

[DCOM-191] Wrong inflection for "identity"

Tue, 7 May 2013 17:43:28 +0000

console doctrine:generate:entities

For an association named "identities", the code generator creates the two methods
addIdentitie() and removeIdentitie() - apparently the inflector doesn't catch that it should be addIdentity and removeIdentity.

[DCOM-194] Creating Proxy class failure for own __get method

Wed, 22 May 2013 09:49:28 +0000

Nette framework (http://nette.org) has got own Nette\Object as a base of other objects. It also rewrite the default __get method in PHP object but it uses definition with pointer:

public function &__get($name)

Doctrine Common creates Proxy classes with __get method too but not with reference. It causes an error using strict warning:

Declaration of Proxy\__CG__\MyEntityObject::__get() should be compatible with & Nette\Object::__get($name)

The problem is in ProxyGenerator. Locally I've patched it in my Doctrine repository clone but don't know how to resolve it globally.

[DCOM-180] Entity with field $key passes orm:validate but db create will fail

Sun, 3 Mar 2013 23:09:24 +0000

There should be a warning if you name a field $key.