Doctrine Project

[DCOM-97] phpParser.php and 'use' keyword in anonymous functions

Fri, 30 Mar 2012 20:15:04 +0000

When i use the keyword 'use' in anonymous function (like describe in page http://php.net/manual/en/functions.anonymous.php)

Exemple :
...

/**
*

Extract event from all events for this day
@param int $year
@param int $month
@param int $day
@return ArrayCollection
*/
public function getEventsForDate($year, $month, $day)
Unknown macro: { $extractEvents = null; // check if date of item is inside day given $extractEvents = $this->events->filter( function ($item) use ($year, $month, $day) { $leftDate = new \DateTime($year.'-'.$month.'-'.$day.' 00:00'); $rigthDate = new \DateTime($year.'-'.$month.'-'.$day.' +1 day 00:00'); return ( ( $leftDate <= $item->getDateStart() ) && ( $item->getDateStart() < $rigthDate ) ); } ); return $extractEvents; }

...

The phpParser generate error

[ErrorException]
Notice: Undefined offset: -1 in /home/ent/project/Symfony/vendor/doctrine-common/lib/Doctrine/Common/Annotations/PhpParser.php line 117

It try to parse 'use ($year, $month, $day)' as Class

[DCOM-93] Add Reflection Abstraction

Reference — Tue, 3 Jan 2012 21:56:55 +0000

The Reflection code in ClassMetadata(Info*)s is getting out of control.

I want to remove the dependency by introducing a ReflectionService interface:

interface ReflectionService
{
    public function getClassShortName($class);
    public function getClassNamespace($class);
    public function getClass($class);
    public function getAccessibleProperty($class, $property);
    public function hasPublicMethod($class, $method);
}

The reflection methods are specifically allowed to return NULL, so that we can create a StaticReflectionService that works without the classes actually existing.

[DCOM-85] GH-81: Add Proxy#__load()

Mon, 12 Dec 2011 19:19:46 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/common/pull/81

[DCOM-84] Improve Proxy Naming

Tue, 13 Dec 2011 20:41:05 +0000

see https://gist.github.com/b493493ecdb22c21590e

[DCOM-83] Rename ComparableInterface

Mon, 12 Dec 2011 19:29:13 +0000

see https://github.com/doctrine/common/commit/fce661a041aa1dc3634bd1c04cacd684619579fc for reasoning

I didn't want to do it myself, don't know what depends on this.

[DCOM-79] Move Lifecycle Events into Doctrine\Common\Persistence\Events

Mon, 12 Dec 2011 19:21:59 +0000

Move Lifecycle Events into Doctrine\Common\Persistence\Events

[DCOM-78] ZendDataCache, Can't use method return value in write context

Sat, 19 Nov 2011 13:24:50 +0000

On line 70, empty($this->getNamespace()).

empty() works only with variables so you need to assign the namespace to something before using empty().

Fatal error: Can't use method return value in write context in Doctrine/Common/Cache/ZendDataCache.php on line 70

[DCOM-71] Add save get_class() to Debug Util

Sun, 23 Oct 2011 06:36:00 +0000

Add save get_class() to Debug Util

[DCOM-66] Github-PR-55 by shesek: Use stream_resolve_include_path

Sun, 28 Aug 2011 03:31:11 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/common/pull/55

Message:

`Doctrine\Common\ClassLoader::fileExistsInIncludePath` behaves the same as `stream_resolve_include_path`, use that instead when available (PHP >= 5.3.2). It should be faster than doing that manually.

[DCOM-59] ArrayCollection contains function - switch from in_array to foreach

Sun, 28 Aug 2011 03:21:33 +0000

The function contains uses in_array to determine if an element provided as parameter is found in the array $this->_elements, and performs a strict comparison.
There might be a way to improve the performances of this function by using a foreach + if

In attachement you can find a small bench file to show the differences between in_array and foreach on object search.
You might want to run the bench with a doctrine Object to verify if this changes anything to the result.
For simple Objects, foreach is much faster when the array has less than 30k elements. Over 30k the difference flattens, and might revert around 50k (meaning that in_array might start being faster when the array has more than 50k entries).

Maybe we could provide two functions, one for smaller than 40-50k items (using foreach), and one for bigger arrays (using in_array) ?

[DCOM-58] Having class named Entity in the global namespace, interferes with the new annotation reader.

Wed, 7 Sep 2011 22:14:24 +0000

Having a class named Entity in the global namespace, results in exceptions: "Class xxx is not a valid entity or mapped super class."
The problem is not present in 2.0

The problem:

\Doctrine\Common\Annotations\DocParser.php

line 421: $reflClass = new \ReflectionClass($name);

$name is "Entity", and the reflection finds the non-doctrine Entity-class in the global namespace, and so doesn't find the "@Annotation" it's looking for when it examines the class.

If I force it to reflect on \Doctrine\ORM\Mapping\Entity instead, the next problem is instantiation:

\Doctrine\Common\Annotations\DocParser.php

line 435: return new $name($values);

Forcing that to the right class, brings a "Failed opening required 'Doctrine/ORM/Mapping/Doctrine/ORM/Mapping/Id.php' " - I haven't investigated further (yet at least).

/Michael

[DCOM-43] Cache Stats

Wed, 21 Sep 2011 14:57:26 +0000

Doctrine should be able to retrieve stats from cache providers, such as Memcache and APC. Stats may list cache hits, cache misses, memory, and so forth.

[DCOM-32] Memcache cache relies on deprecated functions

Wed, 28 Mar 2012 15:14:23 +0000

The method getIds() in MemcacheCache relies on the old "cachedump" stat type.

But as you can read here: http://de2.php.net/manual/en/memcache.getextendedstats.php this has been removed due to security reasons.