Doctrine Project

[DC-340] Pager does not work with MS SQL Server

Wed, 3 Mar 2010 12:58:00 +0000

Hi,

I can't use a pager. For example :
$q = Doctrine_Query::create()~~>select( "*" )~~>from( "utilisateur" );

$pager = new customDoctrinePager( $q, 1, 10 );
$pager->init();

$results = $pager->getResults();

gives me :
SQLSTATE[HY000]: General error: 10007 Invalid column name 'id'. [10007] (severity 5) [SELECT TOP 10 [inner_tbl].[id] AS [u__id] FROM (SELECT TOP 10 [u].[id] AS [u__id], [u].[utisateurnom] AS [u__utisateurnom] FROM [utilisateur] [u]) AS [inner_tbl]]. Failing Query: "SELECT TOP 10 [inner_tbl].[id] AS [u__id] FROM (SELECT TOP 10 [u].[id] AS [u__id], [u].[utisateurnom] AS [u__utisateurnom] FROM [utilisateur] [u]) AS [inner_tbl]"

The query :
SELECT
TOP 10 [inner_tbl].[id] AS [u__id]
FROM
(
SELECT
TOP 10 [u].[id] AS [u__id], [u].[utisateurnom] AS [u__utisateurnom]
FROM
[utilisateur] [u]
) AS [inner_tbl]

is wrong.

This one would be correct :
SELECT
TOP 10 [inner_tbl].[u__id] AS [u__id]
FROM
(
SELECT
TOP 10 [u].[id] AS [u__id], [u].[utisateurnom] AS [u__utisateurnom]
FROM
[utilisateur] [u]
) AS [inner_tbl]

This code works :
$q = Doctrine_Query::create()
->select( '*' )
->from( 'utilisateur u' );
$this->resultSet = $q->execute();

This one gives the save error :
$q = Doctrine_Query::create()
->select( '*' )
->from( 'utilisateur u' );

$q->limit(10);
$q->offset(1);
$this->resultSet = $q->execute();

This is very blocker for me.

Nb. I am not sure of the Doctrine's version used by symfony 1.4

[DC-300] synchronizeWithArray deletes Entries in RefTable when updating related Entries

Mon, 15 Mar 2010 11:39:23 +0000

You have Users and Groups with a ManyToMany relation (refClass = UserGroup).
Then you do a synchronizeWithArray() on a user:

 
$user->synchronizeWithArray(array(
    'Groups' => array(
        array('name' => 'updated Group')
    )
));

When you update a record with synchronizeWithArray() and you update ManyToMany related entries, the RefTable entries gets deleted.

I think the problem is located near:
Doctrine_Record line 2024:

 
        // Eliminate relationships missing in the $array
        foreach ($this->_references as $name => $relation) {
	        $rel = $this->getTable()->getRelation($name);
	
// PROBLEM: RefClass "UserGroup" will never be set in the sync-Array (just "Groups"), so all entries in UserGroup-Table will be deleted
// only new Groups that are synced will be created with a link in the refTable
		if ( ! isset($array[$name]) && ( ! $rel->isOneToOne() || ! isset($array[$rel->getLocalFieldName()]))) {
                    unset($this->$name);
                }
        }

TestCase follows.

[DC-277] Doctrine_Core::loadModels() is getting class name from file name and not the actual class name

Tue, 24 Nov 2009 19:00:38 +0000

If models has any prefix Doctrine_Core::loadModels() fails as fails all export scripts, because for models:

Model_Test
Model_Test2

it returns:

array(
'Test' => 'Test',
'Test2' => 'Test2'
)

This is incorrect and Doctrine_Core::filterInvalidModels() filters out these classes, hence none of the models become available.

Expected behaviour: classPrefix should be possible to pass to configuration of task (now I need to manually copy/paste/edit all tasks to add required class prefix).

[DC-210] PEAR style models generation produces unusable table classes

Thu, 12 Nov 2009 19:21:47 +0000

When generating models like:

'pearStyle' => true,
'generateTableClasses' => true,
'classPrefix' => 'Model_',
'baseClassPrefix' => 'Base_',
'baseClassesDirectory' => 'Base',
'classPrefixFiles' => true

'pearStyle' => true,
'generateTableClasses' => true,
'classPrefix' => 'Model_',
'baseClassPrefix' => 'Base_',
'baseClassesDirectory' => 'Base',
'classPrefixFiles' => false

Produced files are like this:

Model_ModelName extends Base_ModelName
Base_ModelName extends Doctrine_Record
ModelNameTable extends Doctrine_Table

Problem is ModelNameTable class is not prefixed with "Model_" and thus cannot be autoloaded.

[DC-183] Undefined constant Doctrine_Core::ATTR_DEFAULT_TEXTFLD_LENGTH

Mon, 16 Nov 2009 18:09:58 +0000

File http://trac.doctrine-project.org/browser/branches/1.2/lib/Doctrine/DataDict/Sqlite.php

Contains undefined constant Doctrine_Core::ATTR_DEFAULT_TEXTFLD_LENGTH which breaks generation of sql for sqlite

Proposed fix: use $this->conn->options['default_text_field_length'] ?

[DC-66] Saving "new Doctrine_Expression('NOW()')" to database doesn't work since r6403

Tue, 6 Oct 2009 18:01:08 +0000

Doctrine_Record:1469

} else if ($type == 'timestamp' || $type == 'date') {
return strtotime($old) !== strtotime($new);

These new lines cause inability to save NOW() to "date" field.

Change was commited in r6403 branch 1.2

MySQL error is:

SQLSTATE[HY000]: General error: 1364 Field 'date' doesn't have a default value

[DC-69] Linking between one to one relations with synchronizeWithArray fails

Mon, 2 Nov 2009 20:13:37 +0000

Linking between one to one relations with synchronizeWithArray() ends up in an error message.

Example:
Group has one User
User has one Group

When I have a group-object and do the following:

$group->synchronizeWithArray(array(
	'User' => array(1)
));
$group->save();

I get the message: "Fatal error: Call to a member function identifier() on a non-object in [..]lib/Doctrine/Record.php on line 2327"

Apparantly $this->_references[$alias] should be an collection, but in an one to one relation it is a record (which makes sense in my opinion).

[DC-40] Problems with alias in where section

Thu, 24 Sep 2009 19:57:46 +0000

I'm using a mysql function to calculate the distance between 2 points. When I'm using this funciton in a doctrine query it works. But when I'm using the functions result in a where clause it dont work:

The Query:
$basicQuery = $query->select('id, getGeoDistanceKM(lng, lat, '.$points['lng'].', '.$points['lat'].') AS distance, getGeoDistanceKM(lng, lat, '.$points['lng'].', '.$points['lat'].') AS distance, IF(count(r.id) > 0, AVG(r.rating), 0) as ratingAvg')
->from('ProomsOffer o')
->leftJoin('o.PublicTransports pt')
->leftJoin('o.Unavailabilities ua')
->leftJoin('o.Ratings r')
->leftJoin('o.Bookings b')
->where('distance != 0')
->groupBy('o.id')
->orderBy('distance, ratingAvg');

The Error message:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'm__1' in 'where clause'
#0 /Applications/MAMP/htdocs/prooms/cms/library/Doctrine/Doctrine/Connection.php(1015): Doctrine_Connection->rethrowException(Object(PDOException), Object(Doctrine_Connection_Mysql))
#1 /Applications/MAMP/htdocs/prooms/cms/library/Doctrine/Doctrine/Connection.php(790): Doctrine_Connection->execute('SELECT COUNT...', Array)
#2 /Applications/MAMP/htdocs/prooms/cms/library/Doctrine/Doctrine/Query.php(2037): Doctrine_Connection->fetchAll('SELECT COUNT...', Array)
#3 /Applications/MAMP/htdocs/prooms/cms/application/modules/prooms/controllers/SearchController.php(163): Doctrine_Query->count()
#4 /Applications/MAMP/htdocs/prooms/cms/library/Zend/Controller/Action.php(513): Prooms_SearchController->searchAction()
#5 /Applications/MAMP/htdocs/prooms/cms/library/Zend/Controller/Dispatcher/Standard.php(289): Zend_Controller_Action->dispatch('searchAction')
#6 /Applications/MAMP/htdocs/prooms/cms/library/Zend/Controller/Front.php(946): Zend_Controller_Dispatcher_Standard->dispatch(Object(CMS_Controller_Request), Object(Zend_Controller_Response_Http))
#7 /Applications/MAMP/htdocs/prooms/cms/library/CMS/Application.php(372): Zend_Controller_Front->dispatch()
#8 /Applications/MAMP/htdocs/prooms/cms/library/CMS/Application.php(241): CMS_Application->_dispatch(Object(Zend_Controller_Front))
#9 /Applications/MAMP/htdocs/prooms/cms/public/index.php(50): CMS_Application->run()
#10

{main}

The getSqlQuery:
SELECT `m`.`id` AS `m_id`, getGeoDistanceKM(`m`.`lng`, `m`.`lat`, 48.2092062, 16.3727778) AS `m0`, getGeoDistanceKM(`m`.`lng`, `m`.`lat`, 48.2092062, 16.3727778) AS `m1`, IF(COUNT(`m4`.`id`) > 0, AVG(`m4`.`rating`), 0) AS `m41` FROM `module_prooms_offers` `m` LEFT JOIN `module_prooms_offers_public_transport` `m2` ON `m`.`id` = `m2`.`id_offer` LEFT JOIN `module_prooms_offers_unavailability` `m3` ON `m`.`id` = `m3`.`id_offer` LEFT JOIN `module_prooms_offers_ratings` `m4` ON `m`.`id` = `m4`.`id_offer` LEFT JOIN `module_prooms_bookings` `m5` ON `m`.`id` = `m5`.`id_offer` WHERE `m1` != 0 GROUP BY `m`.`id` ORDER BY `m1`, `m4_1`

[DC-561] Doctrine autoloader tries to load class again and fails with fatal error - with fix

Mon, 15 Mar 2010 15:14:08 +0000

Doctrine_Core::autoload around line 1107
if (strpos($className, 'sfYaml') === 0 || class_exists($className, false)) {

should be changed to

if (strpos($className, 'sfYaml') === 0) {

otherwise you get:
Warning: require(/srv/www/pacs.lan/site/lib/Doctrine/Parser/sfYaml/Doctrine_Query_From.php) [function.require]: failed to open stream: No such file or directory in /srv/www/pacs.lan/site/lib/Doctrine/Core.php on line 1108

Fatal error: require() [function.require]: Failed opening required '/srv/www/pacs.lan/site/lib/Doctrine/Parser/sfYaml/Doctrine_Query_From.php' (include_path='/srv/www/pacs.lan/site/lib/:/srv/www/pacs.lan/site/lib/Dwoo/:.:/usr/local/lib/php') in /srv/www/pacs.lan/site/lib/Doctrine/Core.php on line 1108

[DC-508] All but the first migrations fail with PostgreSQL [patch included]

Mon, 15 Mar 2010 12:12:04 +0000

The problem is in this method:

protected function _createMigrationTable()
{
    if ($this->_migrationTableCreated) {
        return true;
    }

    $this->_migrationTableCreated = true;

    try {
        $this->_connection->export->createTable($this->_migrationTableName, array('version' => array('type' => 'integer', 'size' => 11)));

        return true;
    } catch(Exception $e) {
        return false;
    }
}

When migration_version table doesn't exist, everything works like it should. But subsequent migrations fail, because after failing at creating migration_version table every subsequent queries in that transaction fail.

It works flawlessly with MySQL, but fails with PostgreSQL.

[DC-242] Linking (re-linking) o/m2m relations with array of ids in Doctrine_Record fromArray stopped working

Tue, 17 Nov 2009 21:20:10 +0000

class User extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('username', 'string', 64, array('notnull' => true));
		$this->hasColumn('password', 'string', 128, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasMany('Role as Roles', array('local' => 'id_user', 'foreign' => 'id_role', 'refClass' => 'UserRole'));
		$this->actAs('SoftDelete');
	}
}

class Role extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('name', 'string', 64);
	}
	
	public function setUp()
	{
		$this->hasMany('User as Users', array('local' => 'id_role', 'foreign' => 'id_user', 'refClass' => 'UserRole'));
	}
}

class UserRole extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('id_user', 'integer', null, array('primary' => true));
		$this->hasColumn('id_role', 'integer', null, array('primary' => true));
	}
	
	public function setUp()
	{
		$this->hasOne('User', array('local' => 'id_user', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
		$this->hasOne('Role', array('local' => 'id_role', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
	}
}


$role = new Role();
$role->name = 'publisher';
$role->save();

$role = new Role();
$role->name = 'reviewer';
$role->save();

$role = new Role();
$role->name = 'mod';
$role->save();

$user = new User();
$user->fromArray(array(
	'username' => 'test',
	'password' => 'test',
	'Roles' => array(1, 2, 3),
));
$user->save();

//--------------------- here goes the failure
$user->fromArray(array(
	'Roles' => array(1, 3),
));
$user->save();

After a User is saved once with some roles, it cannot be saved here with another combination of roles, consisting of some roles which was saved to the User before.
In short, ->unlink() in fromArray method does not schedule a deletion of old relations before adding new ones on save, like it was in previous versions of Doctrine.
Hence the primary key constraint is violated and the exception is thrown:

SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '2-1' for key 1
#0 D:\projekty\cms-trunk\cms\library\Doctrine\Doctrine\Connection\Statement.php(269): Doctrine_Connection->rethrowException(Object(PDOException), Object(Doctrine_Connection_Statement))
#1 (...)\library\Doctrine\Doctrine\Connection.php(1032): Doctrine_Connection_Statement->execute(Array)
#2 (...)\library\Doctrine\Doctrine\Connection.php(677): Doctrine_Connection->exec('INSERT INTO `us...', Array)
#3 (...)\library\Doctrine\Doctrine\Connection\UnitOfWork.php(631): Doctrine_Connection->insert(Object(Doctrine_Table), Array)
#4 (...)\library\Doctrine\Doctrine\Connection\UnitOfWork.php(562): Doctrine_Connection_UnitOfWork->processSingleInsert(Object(UserRole))
#5 (...)\library\Doctrine\Doctrine\Connection\UnitOfWork.php(81): Doctrine_Connection_UnitOfWork->insert(Object(UserRole))
#6 (...)\library\Doctrine\Doctrine\Connection\UnitOfWork.php(452): Doctrine_Connection_UnitOfWork->saveGraph(Object(UserRole))
#7 (...)\library\Doctrine\Doctrine\Connection\UnitOfWork.php(137): Doctrine_Connection_UnitOfWork->saveAssociations(Object(User))
#8 (...)\library\Doctrine\Doctrine\Record.php(1690): Doctrine_Connection_UnitOfWork->saveGraph(Object(User))
#9 (...)\test3.php(124): Doctrine_Record->save()
#10

{main}

[DC-241] Count query with join o2m + limit + where throws an exception

Tue, 17 Nov 2009 23:08:51 +0000

class Poll extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->setTableName('module_polls');
		
		$this->hasColumn('id_category', 'integer', null, array('notnull' => true));
		$this->hasColumn('question', 'string', 256);
	}
	
	public function setUp()
	{
		$this->hasMany('PollAnswer as Answers', array('local' => 'id', 'foreign' => 'id_poll', 'orderBy' => 'position'));
	}
}

class PollAnswer extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->setTableName('module_polls_answers');
		
		$this->hasColumn('id_poll', 'integer', null, array('notnull' => true));
		$this->hasColumn('answer', 'string', 256);
		$this->hasColumn('votes', 'integer', null, array('notnull' => true, 'default' => 0));
		$this->hasColumn('position', 'integer');
	}
	
	public function setUp()
	{
		$this->hasOne('Poll', array('local' => 'id_poll', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
	}
}

$query = Doctrine_Query::create()
	->from('Poll p')
	->leftJoin('p.Answers pa')
	->where('id_category = ?', 1)
	->limit(10);

print_r($query->count());

This fails with the following exception being thrown:

SQLSTATE[42000]: Syntax error or access violation: 1064 Something is wrong in your syntax obok '? LIMIT 10' w linii 1. Failing Query: "SELECT DISTINCT `m3`.`id` FROM `module_polls` `m3` LEFT JOIN `module_polls_answers` `m4` ON `m3`.`id` = `m4`.`id_poll` WHERE `m3`.`id_category` = ? LIMIT 10"
#0 (...)\library\Doctrine\Doctrine\Connection.php(1015): Doctrine_Connection->rethrowException(Object(PDOException), Object(Doctrine_Connection_Mysql), 'SELECT DISTINCT...')
#1 (...)\library\Doctrine\Doctrine\Query.php(1246): Doctrine_Connection->execute('SELECT DISTINCT...', Array)
#2 (...)\library\Doctrine\Doctrine\Query.php(1106): Doctrine_Query->buildSqlQuery()
#3 (...)\library\Doctrine\Doctrine\Query\Abstract.php(1126): Doctrine_Query->getSqlQuery(Array)
#4 (...)\library\Doctrine\Doctrine\Query\Abstract.php(1088): Doctrine_Query_Abstract->_getDqlCallbackComponents(Array)
#5 (...)\library\Doctrine\Doctrine\Query.php(1126): Doctrine_Query_Abstract->_preQuery()
#6 (...)\library\Doctrine\Doctrine\Query.php(1106): Doctrine_Query->buildSqlQuery()
#7 (...)\library\Doctrine\Doctrine\Query.php(1995): Doctrine_Query->getSqlQuery()
#8 (...)\library\Doctrine\Doctrine\Query.php(2091): Doctrine_Query->getCountSqlQuery()
#9 (...)\test2.php(123): Doctrine_Query->count()
#10

{main}

You can see the generated query which is wrong, moreover it is passed with an empty params array().
Without either where condition or limit removed, it works. With a combo of both of them it fails.

E.g. without where condition the following query is generated:
SELECT COUNT AS `num_results` FROM (SELECT `m`.`id` FROM `module_polls` `m` LEFT JOIN `module_polls_answers` `m2` ON `m`.`id` = `m2`.`id_poll` GROUP BY `m`.`id`) `dctrn_count_query`

[DC-39] Linking between one to many relations with synchronizeWithArray fails

Mon, 2 Nov 2009 20:14:05 +0000

Linking between one to many relations with synchronizeWithArray() has a strange behavior.

Example (fully example is in the attachment):
Group has many Users
User has one Group

When I have a group-object (id 2) and do the following:

$group->synchronizeWithArray(array(
	'Users' => array(1,2)
));
$group->save();

on the first execute of the script the users with id 1 and 2 are linked to group 2 (with foreign key = group_id in user table) -> right
on the second execute of the script the users with id 1 and 2 are linked to null -> failure
on the third execute of the script the users with id 1 and 2 are linked to group 2 -> right
on the fourth execute of the script the users with id 1 and 2 are linked to null -> failure
and so on

I tried to find the error on my self, but had no luck.
That's what I have found:
On every script-execution the relations to group 2 are first nulled.
If they were allready null für user 1 and 2, the relations are build with an update -> right!; but when this two users had allready this relation they are only nulled and no update is processed.
Thats why there is this strange toggling on the foreign key on every script execution.

Maybe it has something to do with the record_state which is clean, when the relations are allready set in the DB -> no update is executed, but the nulling of all foreign key linked to group 2.

[DC-366] Error with tokenizer for JOINs (comments include proposed solutions)

Tue, 2 Mar 2010 10:30:52 +0000

Using the attached schema.yml works fine with Symfony-1.2 and Doctrine-1.0. It even works when I have tested it with Symfony-1.2 and Doctrine-1.1.

However, when using Symfony-1.3 and Doctrine-1.2 the following happens:

 
> php symfony doctrine:build-all-reload
>> doctrine  Dropping "doctrine" database
>> doctrine  Creating "dev" environment "doctrine" database
>> doctrine  generating model classes
>> file+     C:\Users\XXXXXXXXXXXXXXXX\AppDa...\Temp/doctrine_schema_30398.yml
>> tokens    C:/web/sf_sandbox-1.3/lib/model/doctrine/base/BaseBar.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/model/doctrine/base/BaseFoo.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/model...e/base/BaseJoinFooBar.class.php
>> autoload  Resetting application autoloaders
>> file-     C:/web/sf_sandbox-1.3/cache/fro.../config/config_autoload.yml.php
>> doctrine  generating form classes
>> tokens    C:/web/sf_sandbox-1.3/lib/form/BaseForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/doctrine/BarForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/...rine/base/BaseBarForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/...rine/base/BaseFooForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/...se/BaseJoinFooBarForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/...rine/BaseFormDoctrine.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/doctrine/FooForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/doctrine/JoinFooBarForm.class.php
>> autoload  Resetting application autoloaders
>> file-     C:/web/sf_sandbox-1.3/cache/fro.../config/config_autoload.yml.php
>> doctrine  generating filter form classes
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...octrine/BarFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...ase/BaseBarFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...ase/BaseFooFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...eJoinFooBarFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...aseFormFilterDoctrine.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...octrine/FooFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte.../JoinFooBarFormFilter.class.php
>> autoload  Resetting application autoloaders
>> file-     C:/web/sf_sandbox-1.3/cache/fro.../config/config_autoload.yml.php
>> doctrine  generating sql for models
>> doctrine  Generated SQL successfully for models
>> doctrine  created tables successfully
>> doctrine  Loading data fixtures from "C:\web\sf_sandbox-1.3\data/fixtures"


  Couldn't find class FooBar

The attached schema.yml looks like this:

# /config/doctrine/schema.yml
Foo:
  columns:
    id:
      type:                    integer(8)
      primary:                 true
      autoincrement:           true
    foo_field:                 string(100)
  relations:
    Bars:
      class:                   Bar
      refClass:                JoinFooBar
      local:                   foo_id
      foreign:                 bar_id
Bar:
  columns:
    id:
      type:                    integer(8)
      primary:                 true
      autoincrement:           true
    bar_field:               string(30)
JoinFooBar:
  columns:
    foo_id:
      type:                    integer(8)
      primary:                 true
    bar_id:
      type:                    integer(8)
      primary:                 true

As you can see, there is not meant to be any class called FooBar (the reference class for the many-to-many join is called JoinFooBar) so where is the name "FooBar" being picked up from and why is the code complaining that it cannot be found?

The fixture file is empty so there shouldn't be anything causing problems there.

This bug is making it impossible to upgrade our existing projects to Symfony-1.3 + Doctrine-1.2 so I'd be most grateful if you could look into this.

If the schema is changed from:

...
    bar_field:               string(30)
JoinFooBar:
  columns:
...

To:

...
    bar_field:               string(30)
FooBar:
  columns:
...

it seems to work, (that error disappears - even though the refClass is still set to *Join*FooBar) but we cannot easily justify changing all the classnames of all our Join tables in the projects we want to upgrade!

I hope you can see some simple solution to this and I'm happy to answer any questions you have.

(To reproduce this bug use the symfony sandbox, create a database and then use the attached schema.yml file.)

[DC-337] Doctrine needs support for union all

Wed, 3 Mar 2010 12:56:32 +0000

The following query cannot be retrieved as objects. The following will work with ->fetchAll(). However, the result set will return as an array. I need this to be as an object.

return Doctrine_Manager::getInstance()~~>getCurrentConnection()~~>fetchAll("

SELECT

v1.*

FROM (
SELECT
'song_comment' as user_action,
null as artist_id, user_id, song_id, null as video_id, null as event_id, null as ip_address, null as is_going,
comment, created_at
FROM tbl_user_song_comment
UNION ALL
SELECT
'videocomment' as user_action,
null as artist_id, user_id, null as song_id, video_id, null as event_id, null as ip_address, null as is_going,
comment, created_at
FROM tbl_user_video_comment
UNION ALL
SELECT
'event_comment' as user_action,
null as artist_id, user_id, null as song_id, null as video_id, event_id, null as ip_address, null as is_going,
comment, created_at
FROM tbl_user_event_comment
) AS v1

ORDER BY created_at DESC

");

In summary, what I am trying to do is select all comments from tbl_user_song_comment, tbl_user_video_comment and tbl_user_event_comment and order by date (created_at).

The following ticket at http://trac.doctrine-project.org/ticket/18 should have been implemented!
There is no way in Doctrine to ->select() a view. In this case 'v1', since ->from() only expects a class!

[DC-333] Doctrine_Migration_Diff reuses the same temporary folder on consecutive runs, resulting in collisions between projects

Mon, 7 Dec 2009 21:29:50 +0000

svn co http://svn.symfony-project.com/plugins/pkContextCMSPlugin/sandbox/branches/1.3 cmstest13
cd cmstest13
[edited config/doctrine/schema.yml and added a trivial table so there would be something at the app level]
[successful doctrine:build --all followed]

./symfony doctrine:generate-migrations-diff
>> doctrine generating migration diff
>> file+ /private/var/folders/3H/3Hu3TTyjFt...TI/~~Tmp~~/doctrine_schema_15549.yml

Fatal error: Class 'EventUser' not found in /private/var/folders/3H/3Hu3TTyjFtuvtN3D5tDUxU+++TI/~~Tmp~~/fromprfx_doctrine_tmp_dirs/base/BaseEventGuest.class.php on line 7

I recognize my personal temp folder from my environment in there:

TMPDIR=/var/folders/3H/3Hu3TTyjFtuvtN3D5tDUxU+++TI/~~Tmp~~/

So presumably these tasks are supposed to clean it up after they use it. But none of my attempts to use this task so far have succeeded, so I suspect the problem is that the folder does not get cleaned up in the event of an error. This folder needs to get cleaned up on all errors, or perhaps cleared at the start of a new run (that is probably going to turn out to be a more reliable fix).

I'll manually clear it and move on to the bug I was originally looking to reproduce.

[DC-316] Model classes aren't loaded anymore when migrating to 1.2

Wed, 30 Dec 2009 08:03:47 +0000

When migrating from doctrine 1.1.0 to 1.2 it fails to load the model classes anymore. It complains it cannot find the model class 'Building' when doing a Doctrine::getTable('Building')->findAll(). See attached backtrace. After hours of digging in the code and countless debug statements I found out that the automatic loading of the model classes is removed (for some good reason?) from the doctrine autoloader(). This will off course give exceptions for people depending on this mechanism!

It seems that the solution is to add another spl_autoload_register(array('Doctrine','modelsAutoload')); to the bootstrapper (apart from the normal spl_autoload_register(array('Doctrine','autoload'));

But the strangest thing is: I could not find any information about this, although this is (I would say) VERY critical information for people depending on auto model class loading and would like to keep it working! So I would suggest to put this critical information into the ('migration' or 'what is new') documentation of 1.2 because I could not find it. Yes, there is something about PEAR like model loading, but that is not what I want, I would like to keep my app still working after migrating to 1.2.

[DC-205] Problem with serial fields on PostgreSQL

Tue, 10 Nov 2009 16:18:03 +0000

When a new record is inserted into a table with an autoincrement primary key, the function Doctrine_Connection_UnitOfWork::processSingleInsert is called with the record to insert as parameter.

In Doctrine 1.1.x (http://trac.doctrine-project.org/browser/branches/1.1/lib/Doctrine/Connection/UnitOfWork.php#L590) this method was the responsible for getting the new ID value from the sequence, and with this value, it MODIFIED THE ARRAY OF FIELD VALUES to be inserted into the table.

Now this is done at a protected method named _assignSequence (http://trac.doctrine-project.org/browser/branches/1.2/lib/Doctrine/Connection/UnitOfWork.php#L629) which assigns the identifier to the record, but DOES NOT MODIFY THE ARRAY OF VALUES to be send to the database for the insert so when my db receive a null value for the ID column, generate a new one from the sequence.

The result is that the record gets an identifier which is different from the one that it really has on the database.

An example: on a db with a table 'foo' with two columns, 'id' and 'name', and a sequence called 'foo_id_seq' with a value of 6, when I try to insert a record with a named 'bar', the function $this->conn->insert($table, $fields); at http://trac.doctrine-project.org/browser/branches/1.1/lib/Doctrine/Connection/UnitOfWork.php#L595 receive as parameters 'foo' and array('id' =>7, 'name' =>'bar')

In Doctrine 1.2 the function at http://trac.doctrine-project.org/browser/branches/1.2/lib/Doctrine/Connection/UnitOfWork.php#L630 recevie as parameters 'foo' and array('name' =>'bar')

(Sorry for my poor English)

[DC-189] When applying changes to n:n relations that contain partially same data DELET is not fired

Tue, 17 Nov 2009 21:20:26 +0000

When changing n:n relations in a way that the new dataset contains relations that were present in the previous state (as in adding a relation to existing ones) DELETE is not fired before insert is done. In the example below I simply reapply an existing relation. This is done by Record::synchronizeWithArray().

Result:

Doctrine_Connection_Mysql_Exception: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '4-14' for key 'PRIMARY'

SQL Query pre r6611:
6 Query START TRANSACTION
6 Query UPDATE `structure` SET `user_create_id` = NULL, `user_modify_id` = NULL, `updated_at` = '2009-11-04 23:38:02' WHERE `id` = '4'
6 Query DELETE FROM `structure_category` WHERE (`structure_id` = '4')
6 Query INSERT INTO `structure_category` (`category_id`, `structure_id`) VALUES ('5', '4')
6 Query COMMIT

SQL QUERY with r6611:
5 Query START TRANSACTION
5 Query UPDATE `structure` SET `user_create_id` = NULL, `user_modify_id` = NULL, `updated_at` = '2009-11-04 23:36:33' WHERE `id` = '4'
5 Query INSERT INTO `structure_category` (`category_id`, `structure_id`) VALUES ('5', '4')
5 Query ROLLBACK

[DC-146] GenerateMigrationsDiff task does not use new order of changeColumn()

Fri, 30 Oct 2009 15:46:36 +0000

The GenerateMigrationsDiff task generates migrations which still use the old ordering of parameters of changeColumn().

This is how it gets generated:

$this->changeColumn('my_table', 'my_column', '25', 'timestamp', array(
'notnull' => '1',
));

Why it should be like this

$this->changeColumn('my_table', 'my_column', 'timestamp', '25', array(
'notnull' => '1',
));

I also added a patch to fix this.

[DC-145] Invalid parameter number: number of bound variables does not match number of tokens

Mon, 16 Nov 2009 18:34:21 +0000

Please see description posted on Doctrine's group:
http://groups.google.com/group/doctrine-user/browse_thread/thread/6cc308526e5ab075

[DC-134] Parse error in lib/Doctrine/Cache/Xcache.php (missing ;) and delete() should be deleteCache() (patch included)

Fri, 23 Oct 2009 17:10:28 +0000

Missing ; in saveCache() function and delete method should also be named deleteCache as in other drivers.
This prevents xcache driver from working as well as compiling Doctrine to single PHP file. Patch included to fix the issue.

[DC-103] doctrine 1.0 not getting table correctly - huge bug - not usable

Fri, 30 Oct 2009 17:35:45 +0000

In the method coreSetRelated from Record.php for 1-1 relation the table is not obtained correctly!

if ($value !== self::$_null)

{ $relatedTable = $value->getTable(); $foreignFieldName = $relatedTable->getFieldName($rel->getForeign()); }

instead of

$relatedTable = $value->getTable();

you should put

$relatedTable = $rel->getTable();

This is a huge bug that can be fixed very easily so please fix is asap!

I can not deploy my project until this is fixed!

Thanks a lot!

I do not know if other versions are affected! I use symfony 1.2.9! Should I make a ticket also for Symfony!

You do a great job with doctrine! Great project! I really like it

[DC-93] Calling refreshRelated causes hasOne records to be created in error

Fri, 30 Oct 2009 17:31:23 +0000

Calling save() on a record, then refreshRelated(), then save() again will cause hasOne rows to be generated in error. I've attached a Doctrine sandbox with everything you need to reproduce it. Below is a summary.

schema.yml

schema.yml

 
---
Staff:
  columns:
    username: string(50)
    password: string(255)
    active:
      type: boolean
      default: true
  indexes:
    user_pass_active_idx:
      fields: [username, password, active]


Tickets:
  columns:
    mask:
      unique: true
      type: string(10)
    staff_id: integer(9)
  relations:
    Staff:
      local: staff_id
      foreign: id

Test.php

 
<?php
$ticket = new Tickets();
$ticket->save();
$ticket->refreshRelated();
$ticket->save();

Queries that were run:

root@localhost on doctrine11sandbox
START TRANSACTION
INSERT INTO tickets (id, mask, staff_id) VALUES (NULL, NULL, NULL)
COMMIT
START TRANSACTION
*INSERT INTO staff (active) VALUES ('1')*
UPDATE tickets SET staff_id = '2' WHERE id = '2'
COMMIT

[DC-92] Doctrine_Import_Pgsql::listTableColumns() creates wrong default values for boolean fields

Tue, 13 Oct 2009 03:39:46 +0000

When importing a db table as a model, we see the following for a boolean field:

        $this->hasColumn('is_blocked', 'boolean', 1, array(
             'type' => 'boolean',
             'length' => 1,
             'fixed' => false,
             'unsigned' => false,
             'notnull' => true,
             'default' => 'false',   // <----- this field not 0, 1 or a boolean, but a string literal linstead
             'primary' => false,
             ));

Creating an object and immediately saving it results in two validation errors for this field:

1. The field is not boolean, but string
2. The field is not length 1, but length 5 (string "false")

I applied the following patch to the listTableColumns() function:

            elseif (preg_match("/^'(.*)'::character varying$/", $description['default'], $matches)) {
                $description['default'] = $matches[1];
            }
+           elseif ($description['type'] == 'boolean') {
+               if ($description['default'] === 'true') {
+                   $description['default'] = true;
+               } elseif ($description['default'] === 'false') {
+                   $description['default'] = false;
+               }
+           }

            $columns[$val['field']] = $description;

This makes the import work as expected for us.

[DC-80] Doctrine/Import/Pgsql.php generates wrong default values for varchar fields

Tue, 6 Oct 2009 18:13:42 +0000

We run a postgres database and have generated out base models from the database. In the base models, we see the following issue:

        $this->hasColumn('contractor_type', 'string', 150, array(
             'type' => 'string',
             'length' => '150',
             'fixed' => false,
             'unsigned' => false,
             'notnull' => true,
             'default' => '\'enduser\'::character varying',
             'primary' => false,
             ));

So, the default value is showing some PostgreSQL meta information. We fixed this by changing function listTableColumns():

            if (preg_match("/^nextval\('(.*)'(::.*)?\)$/", $description['default'], $matches)) {

                $description['sequence'] = $this->conn->formatter->fixSequenceName($matches[1]);
                $description['default'] = null;
            }
+           elseif (preg_match("/^'(.*)'::character varying$/", $description['default'], $matches)) {
+               $description['default'] = $matches[1];
+           }

            $columns[$val['field']] = $description;

[DC-73] TestCase framework normally uses identityMap for records created in prepareData() what can cause side effects

Fri, 30 Oct 2009 17:17:02 +0000

All new records are stored in the identityMap during insertion. This default behavior takes place also while executing test cases.

In other words every record created in the prepareData() method gets to the identityMap. Afterwards, in a test method, it is silently retrived from identityMap instead of (expected!) quering from sqlite.

IMHO a testing environment should be as pure as possible and no such side effects are acceptable.

I'm including a test case and patch for Doctrine_UnitTestCase. After putting the patch, I have found that 2 test cases causes fail: 1449 and 736. In the first test IMHO there is a problem in a content test - I'm including appropriate fix.
It seems that the second test, in fact, have never been passing. I think that positive result was caused by the side effect of identityMap.

[DC-573] Invalid SQL generated by Doctrine_Query::getLimitSubquery() when ordering by multiple columns

Mon, 15 Mar 2010 11:36:02 +0000

When attempting to order a query by multiple columns I came across this bug. I've attached a reproduction script which will hopefully illustrate the behaviour, but essentially getLimitSubquery() is parsing the order by column incorrectly, leading to an erroneous comma in the sub-select field select clause, e.g

SELECT [m].[id] AS [m__id], [m].[name] AS [m__name], [m].[date] AS [m__date], [r].[id] AS [r__id], [r].[model_id] AS [r__model_id], [r].[name] AS [r__name] FROM [model] [m] INNER JOIN [relation] [r] ON [m].[id] = [r].[model_id] WHERE [m].[id] IN (SELECT TOP 1 [inner_tbl].[id] FROM (SELECT DISTINCT TOP 1 [m].[id], [r].[name],, [r].[id] FROM [model] [m] INNER JOIN [relation] [r] ON [m].[id] = [r].[model_id] ORDER BY [r].[name], [r].[id]) AS [inner_tbl] ORDER BY [inner_tbl].[name] DESC, [inner_tbl].[id] DESC) ORDER BY [r].[name], [r].[id]

(note [r].[name],, [r].[id] - that's the offender).

I've attached a patch against 1.2 HEAD that strips any commas from the fields before they are added to the select clause; it works for me but I'm not sure of all the use cases across the relevant drivers.

[DC-565] Versionable bugging when used with I18N

Mon, 15 Mar 2010 16:01:29 +0000

The solution was to allow Versionable to skip fields.
I've fixed with this changing:

Doctrine/AuditLog.php
#84:

$skipFields = (isset($this->_options['skipFields']))?$this->_options['skipFields']:array();

#88:

//inside the foreach
if(in_array($column, $skipFields))

Unknown macro: { continue; }

After that the Versionable will accept some parameters.

ps: If possible, let me know about this changes cause my sources are with this fix.

[DC-524] Out Of Range in Template Geographical Calculation using Postgresql

Mon, 1 Mar 2010 16:15:31 +0000

500 | Internal Server Error | Doctrine_Connection_Pgsql_Exception
SQLSTATE[22003]: Numeric value out of range: 7 ERROR: input is out of range

DQL:

at Doctrine_Connection->execute('SELECT h.id AS h_id, h.name AS hname, h.address AS haddress, h.zip AS hzip, h.url AS hurl, h.photo_url AS hphoto_url, h.checkin_from AS hcheckin_from, h.checkin_to AS hcheckin_to, h.checkout_from AS hcheckout_from, h.checkout_to AS hcheckout_to, h.is_published AS his_published, h.class AS hclass, h.currencycode AS hcurrencycode, h.minrate AS hminrate, h.maxrate AS hmaxrate, h.preferred AS hpreferred, h.nr_rooms AS hnr_rooms, h.bookable_direct AS hbookable_direct, h.ranking AS hranking, h.city_id AS hcity_id, h.policygroup_id AS hpolicygroup_id, h.is_closed AS his_closed, h.hoteltype_id AS hhoteltype_id, h.class_is_estimated AS hclass_is_estimated, h.review_nr AS hreview_nr, h.review_score AS hreview_score, h.created_at AS hcreated_at, h.updated_at AS hupdated_at, h.latitude AS hlatitude, h.longitude AS hlongitude, ((ACOS(SIN(45.41244780000000000000 * PI() / 180) * SIN(h.latitude * PI() / 180) + COS(45.41244780000000000000 * PI() / 180) * COS(h.latitude * PI() / 180) * COS((6.63685100000000000000 - h.longitude) * PI() / 180)) * 180 / PI()) * 60 * 1.1515) AS h0, ((ACOS(SIN(45.41244780000000000000 * PI() / 180) * SIN(h.latitude * PI() / 180) + COS(45.41244780000000000000 * PI() / 180) * COS(h.latitude * PI() / 180) * COS((6.63685100000000000000 - h.longitude) * PI() / 180)) * 180 / PI()) * 60 * 1.1515 * 1.609344) AS h1 FROM hotel h WHERE (((ACOS(SIN(45.41244780000000000000 * PI() / 180) * SIN(h.latitude * PI() / 180) + COS(45.41244780000000000000 * PI() / 180) * COS(h.latitude * PI() / 180) * COS((6.63685100000000000000 - h.longitude) * PI() / 180)) * 180 / PI()) * 60 * 1.1515 * 1.609344) < 3 AND h.is_published = ? AND h.id != ?) ORDER BY h_1 asc LIMIT 5', array('true', 189646))

in SF_SYMFONY_LIB_DIR/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Query/Abstract.php line 976

I'm using NUMERIC on column type with precision 10, but the problem is not in the column latitude and longitude, it´s on calculation.
To resolve this bug I made a casting inside of ACOS function calculation, but I don't know how it work on mysql.

- - I've posted a patch file attached here with the change that I made.

Examples of result of h_0, h_1 on sql fixed.

0.132901717706014221300; 0.213884392376139928479590400
0.15938002241913817800; 0.256497124695862251207283200
0.205676327970298764600; 0.331003964361032495016422400
0.205676327970298764600; 0.331003964361032495016422400

[DC-521] Empty records cannot be inserted on PostgreSQL with autoincrement identifiers

Thu, 17 Jun 2010 05:57:33 +0000

If a record does not have any values set, but its identifier is defined as autoincrement, the record cannot be inserted into PostgreSQL.

In Doctrine_Connection_UnitOfWork::processSingleInsert():

 
       $fields = $record->getPrepared();
        $table = $record->getTable();

       // Populate fields with a blank array so that a blank records can be inserted
        if (empty($fields)) {
            foreach ($table->getFieldNames() as $field) {
                $fields[$field] = null;
            }
        }

This code snippet will add null values to all fields, including to the autoincrement identifier.
Then later in Doctrine_Connection_Pgsql::insert():

       // fix #1786 and #2327 (default values when table is just 'id' as PK)
        if(count($fields) === 1 && $table->isIdentifier(key($fields)) && $table->isIdentifierAutoincrement() )
        {
            return $this->exec('INSERT INTO ' . $this->quoteIdentifier($tableName)
                              . ' '
                              . ' VALUES (DEFAULT)');
        }

        foreach ($fields as $fieldName => $value) {
            $cols[] = $this->quoteIdentifier($table->getColumnName($fieldName));
            if ($value instanceof Doctrine_Expression) {
                $a[] = $value->getSql();
                unset($fields[$fieldName]);
            } else {
                $a[] = '?';
            }
        }

The claimed fix for the referenced tickets does not work correctly for 2 reasons:
1. It only works for tables with a single id field
2. It only works correctly if the id field had no value assigned. If there was a value assigned, it silently bypasses it, and inserts with the autoincremented value.

Patch with test case will be attached to the ticket.

References:
http://trac.doctrine-project.org/ticket/2327
http://trac.doctrine-project.org/ticket/1786

[DC-460] Doctrine_Cache_Apc/Core changes in 1.2 cause instability and crashes

Reference — Mon, 1 Mar 2010 15:58:12 +0000

Since upgrading to Doctrine 1.2 my application has begun to get increasingly slower as hours elapse. I've pinpointed the cause to the new doctrine_cache_keys feature.

I've found at least three issues with this new method.

First

The key cache does not track enforce unique entries, thus multiple entries can be in the cache. See:

    protected function _saveKey($key)
    {
        $keys = $this->fetch($this->_cacheKeyIndexKey);
        $keys[] = $key;

        return $this->save($this->_cacheKeyIndexKey, $keys, null, false);
    }

    public function _deleteKey($key)
    {
        $keys = $this->fetch($this->_cacheKeyIndexKey);
        $key = array_search($key, $keys);
        if ($key !== false) {
            unset($keys[$key]);

            return $this->save($this->_cacheKeyIndexKey, $keys, null, false);
        }

        return false;
    }

Second

The doctrine_cache_key is being updated on every cache save or delete. With any caching strategy (APC, Memcached, Xcache) cache writes for the same key are (naturally) serialized. This leads to the "timebomb" situation described here: http://t3.dotgnu.info/blog/php/user-cache-timebomb.html

The problem is exarcerbated by the infinitely increasing size of the doctrine_cache_key array noted above. Depending on the caching engine, the lock time increases as well (APC & XCache free the previous entry inside the lock). This causes the application to spiral out of control, even with relatively trivial loads.

Personally, I don't think the "benefit" of having prefix/regex deletes is worth having this. Jon, you suggested having it disabled by default, but even with it enabled, this problem is reintroduced when someone decides to use it.

Third

For most (maybe all?) cache engines the doctrine_cache_key seems entirely unnecessary.

APC
- apc_cache_info('user') returns the list of cache entries
Memcached
- $memcache->getExtendedStats('cachedump', $slabId) can return the list of cache keys
XCache
- According to the API docs xcache_list() behaves similar to apc_cache_info()
DB
- a simple query can get this
Array
- array_keys() ?

Summary

As this is currently broken for production use I intend to immediately fix both the first and second items above by preventing duplicate entries and disabling the doctrine_cache_keys behavior by default.

With more input/discussion I think the long term solution is to use the tools provided by the engines to get a list of keys, rather than maintain a list. I'd be willing to develop this as long as it is approved.

[DC-240] Automatic ordering through orderBy in many-to-many relation definition issue

Tue, 17 Nov 2009 20:08:07 +0000

I would like to utilize new nice feature in Doctrine 1.2, namely automatic ordering of relations using orderBy property in relation definition. However I see small flaw with m2m relations:

class User extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->setTableName('core_users');
		
		$this->hasColumn('username', 'string', 64, array('notnull' => true));
		$this->hasColumn('password', 'string', 128, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasMany('Role as Roles', array('local' => 'id_user', 'foreign' => 'id_role', 'refClass' => 'UserRole', 'orderBy' => 'position'));
		$this->actAs('SoftDelete');
	}
}

class Role extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->setTableName('core_roles');
		
		$this->hasColumn('name', 'string', 64);
	}
	
	public function setUp()
	{
		$this->hasMany('User as Users', array('local' => 'id_role', 'foreign' => 'id_user', 'refClass' => 'UserRole'));
		$this->hasMany('Role as Parents', array('local' => 'id_role_child', 'foreign' => 'id_role_parent', 'refClass' => 'RoleReference', 'orderBy' => 'position'));
		$this->hasMany('Role as Children', array('local' => 'id_role_parent', 'foreign' => 'id_role_child', 'refClass' => 'RoleReference'));
	}
}

class UserRole extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->setTableName('core_users_roles');
		
		$this->hasColumn('id_user', 'integer', null, array('primary' => true));
		$this->hasColumn('id_role', 'integer', null, array('primary' => true));
		$this->hasColumn('position', 'integer', null, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasOne('User', array('local' => 'id_user', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
		$this->hasOne('Role', array('local' => 'id_role', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
	}
}

class RoleReference extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->setTableName('core_roles_reference');
		
		$this->hasColumn('id_role_parent', 'integer', null, array('primary' => true));
		$this->hasColumn('id_role_child', 'integer', null, array('primary' => true));
		$this->hasColumn('position', 'integer', null, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasOne('Role as Parent', array('local' => 'id_role_parent', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
		$this->hasOne('Role as Child', array('local' => 'id_role_child', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
	}
}

$query = Doctrine_Query::create()
	->from('User u')
	->leftJoin('u.Roles r')
	->orderBy('username ASC')
	->execute();

Results in following query being generated:

SELECT `c`.`id` AS `c__id`, `c`.`username` AS `c__username`, `c`.`password` AS `c__password`, `c`.`deleted_at` AS `c__deleted_at`, `c2`.`id` AS `c2__id`, `c2`.`name` AS `c2__name` FROM `core_users` `c` LEFT JOIN `core_users_roles` `c3` ON (`c`.`id` = `c3`.`id_user`) LEFT JOIN `core_roles` `c2` ON `c2`.`id` = `c3`.`id_role` WHERE (`c`.`deleted_at` IS NULL) ORDER BY `c`.`username` ASC, position

As you can see, 'position' column at the end is not prefixed by an alias (should be `c3` here), which may arise problems when there are more than one column of that name used within tables used in the query.

Same with lazy-loading:

$query = Doctrine_Query::create()
	->from('User u')
	->orderBy('username ASC');
	
$result = $query->execute();
foreach($result as $item)
{
	echo count($item->Roles);
}

SELECT `c`.`id` AS `c__id`, `c`.`name` AS `c__name`, `c2`.`id_user` AS `c2__id_user`, `c2`.`id_role` AS `c2__id_role`, `c2`.`position` AS `c2__position` FROM `core_roles` `c` LEFT JOIN `core_users_roles` `c2` ON `c`.`id` = `c2`.`id_role` WHERE (`c2`.`id_user` IN (?)) ORDER BY position

[DC-238] Doctrine_Query::count() doesn't follow useResultCache

Tue, 17 Nov 2009 21:38:16 +0000

The count method of Doctrine_Query doesn't follow useResultCache option, so I have to make loop away with fetchOne or something like that use "execute()".

So I fixed this issue, see the attachment for details!

[DC-236] Doctrine_Collection->toHierarchy() : __children field doesn't contain correct children

Mon, 16 Nov 2009 18:59:00 +0000

This bug was discovered while using getDescendants with the new toHierarchy function. Rather than containing the correct child elements in the __children field, it contains whatever the next record is. Each record only has a single child, which is the record with the next-highest lft value. You can see this in the following pastebin. Notice that the very bottom element is placed around level 15 in the tree, yet it should be level 4 according to the "level" field.

The line that was used to produce the above pastebin was:
print_r($children = $file->getNode()~~>getDescendants(null, false)~~>toHierarchy()->toArray());
The class used for $file is: http://pastebin.ca/1673706

[DC-223] Cloning a query object re-creates hydrator object and loses hydration mode in the process.

Thu, 12 Nov 2009 18:28:33 +0000

This is obviously wrong since cloning should result in identical object, but why this is such a critical bug is because it breaks setting array hydration for nested set base query, because the query object gets cloned during the fetching of tree. This bug was introduced in revsion 6691 in attempt to fix DC-204. Included is a patch that correctly clones the hydrator instead of resetting its information completely.

[DC-25] Joining the same m2m relation more than one time produces query with duplicated aliases

Thu, 24 Sep 2009 21:39:11 +0000

moved my ticket #1941 from trac

Let's consider an environment:

We have a table "Article" and another table "Tag". There is a many to many relation between those two tables via link table "TagArticle". Schema and fixtures provided in attachments. It is simple.

Now let's consider a situation:

We want to display a list of all articles with on of tags. But we want to display this list also with the rest of tags connected to articles with specified tag:

Article1: tag1, tag2, tag3, tag4
Article2: tag2, tag3
Article3: tag4

We want a list of all articles with "tag2" - so it will be Article1 and Article2, but the same query should also retrieve the rest of tags.

It is really simple to do with one-to-many relation: by just joining two tables with different aliases.

However, it is impossible now to do it with many-to-many relation, because Doctrine generates wrong table aliases in SQL.

$query = Doctrine_Query::create()->select('a.id, tg.*')
    ->from('Article a')
    ->leftJoin('a.Tags tg')
    ->innerJoin('a.Tags tg2 WITH tg2.name = ?', 'tag2')
    ;

Looks logical. But it throws an exception:

"Doctrine_Connection_Mysql_Exception" with message "SQLSTATE[42000]: Syntax error or access violation: 1066 Not unique table/alias: 't2'" in ...doctrine\lib\DoctrineConnection.php:1084

Let's look at our query:

SELECT a.id AS a__id, t.id AS t__id, t.name AS t__name 
FROM article a 
LEFT JOIN tag_article t2 ON a.id = t2.article_id 
LEFT JOIN tag t ON t.id = t2.tag_id 
INNER JOIN tag_article t2 ON a.id = t2.article_id 
INNER JOIN tag t3 ON t3.id = t2.tag_id AND t3.name = ?

As we can see, there is a duplicated alias on "tag_article".

[DC-851] Temporary schema filename is not unique enough

Wed, 1 Sep 2010 14:41:38 +0000

Random filename generation is not sufficiently unique when working with multiple developers on a single development server.

$file = realpath(sys_get_temp_dir()).'/doctrine_schema_'.rand(11111, 99999).'.yml';

Attached patch replaces rand() call with a uniqid() call.

[DC-458] Doctrine_Validator_Ip fails on IPV6 IP addresses.

Mon, 1 Mar 2010 20:11:23 +0000

Doctrine_Validator_Ip->validate() uses ip2long() in order to validate IP addresses.

However, ip2long() only works for IPv4 addresses, and not IPv6 addresses.

Attached is a patch to use filter_var which validates both IPv4 and IPv6 properly.

[DC-446] Doctrine_Record_Generator::createClass with Doctrine_Record_Listener

Tue, 2 Mar 2010 12:21:50 +0000

Doctrine_Record_Generator::initialize first builds the table class and then a "Doctrine_Record" from that. This is surprising, as the result is a "double conversion" from record to table and back.

Furthermore, writing files, no record listeners can be attached (see createClassFromTable)!

I therefore suggest adding the possibility to add listeners - which the builder already does! - to the Record_Generator.

[DC-437] Connection::query() can use wrong connection

Mon, 15 Mar 2010 11:53:16 +0000

As I understand, Doctrine_Connection::query() method is intended to execute DQL queries using precisely this connection.
But here is the code:

894     public function query($query, array $params = array(), $hydrationMode = null)
895     {
896         $parser = Doctrine_Query::create();                                                                                
897         $res = $parser->query($query, $params, $hydrationMode);
898         $parser->free();
899 
900         return $res;
901     }

Doctrine_Query::create() statement will create a query that is using a default connection, not the current one.

[DC-428] Bug on DropDB on Oracle. The sequence isn't not correct

Thu, 11 Mar 2010 10:57:30 +0000

The sequence of drop database is not correct.

I change this in my patch.

Thank's

[DC-419] Sluggable and inheritance

Tue, 6 Sep 2011 08:52:11 +0000

I've the same problem than this post : http://groups.google.com/group/doctrine-user/browse_thread/thread/3737fd293fef5fda/d86a8bc2578e4bac

Then, I've set "uniqueBy: [name, type] ", and my data goes in database BUT they can have the same slug.

So I can't retrieve an objects wich has equal slug with another.

The column aggregation inheritance does'nt take care of others slugs.

[DC-411] Doctrine::Inflector does not handle table names with dashes

Mon, 1 Mar 2010 20:17:19 +0000

I have some tables in my DB with dashes in name, ex. "table-name".
While generating schema.yml with ./doctrine-cli generate-yaml-db it generated model classes with dashes, ex. class Table-name ...

Here's a small patch to treat - in table names same as _.

— library/Doctrine/Inflector.php (wersja 7016)
+++ library/Doctrine/Inflector.php (kopia robocza)
@@ -57,7 +57,7 @@
public static function classify($word)

{ $word = preg_replace('/[$]/', '', $word); - return preg_replace_callback('~(_?)(_)([\w])~', array("Doctrine_Inflector", "classifyCallback"), ucfirst(strtolower($word))); + return preg_replace_callback('~(_?)([-_])([\w])~', array("Doctrine_Inflector", "classifyCallback"), ucfirst(strtolower($word))); }

/**

[DC-404] Allow custom language field name in I18n Behavior

Mon, 1 Mar 2010 20:04:43 +0000

I18n behavior assumes language field name of 'lang'. It would be nice if this was configurable.

This was mentioned and a proposed solution was given here: http://forum.symfony-project.org/index.php/m/85623/

I've attached a patch which implements this solution, it essentially adds an i18nField option to the behaviour. The field defaults to 'lang'.

The patch was made against r7016 of the 1.2 branch.

Note:

Leaving the field name as 'lang' does not cause unit test failures.
Changing the name of the field does cause some unit tests to fail for me. I'm not sure if the dependency on the field name exists in the unit tests or in the doctrine library itself. If dependencies exist in the library, this patch may not be sufficient to add the feature.

Sorry if the patch is incomplete, I'm new to Doctrine in general.

[DC-398] PORTABILITY_EMPTY_TO_NULL doesn't do anything for statements

Mon, 15 Mar 2010 12:15:55 +0000

I found this ticket on the old Trac system, but not on JIRA. It is still broken in the 1.1 branch, as of revision 7004. It is also broken in 1.0.14, 1.1.6, and 1.2.1. (These were the 'stable' releases at the time I reported this bug.) It is likely broken in older releases as well.

When saving to the database, Doctrine ignores the setting of PORTABILITY_EMPTY_TO_NULL. Currently, it will never change empty strings to NULL, no matter what the setting is for ATRR_PORTABILITY. This is because there is an error in the following 'if' statement:

Doctrine_Connection_Statement starting on line: 234

if ($this->_conn->getAttribute(Doctrine::PORTABILITY_EMPTY_TO_NULL)) {
    foreach ($params as $key => $value) {
        if ($value == '') {
            $params[$key] = null;
        }
    }
}

the first test in this block should be (Portability Mode Attributes must be handled this way):

if ($this->_conn->getAttribute(Doctrine::ATTR_PORTABILITY) & Doctrine::PORTABILITY_EMPTY_TO_NULL) {

the second test should be:

if (is_string($value) && $value === '')

In newer versions of php(not sure which), test for empty string must look like '===' not only '=='. It prevents integer and boolean value 0 to be handled as an empty string.

[DC-397] unlinking of associations with aliased local-/foreignKeys is broken

Tue, 2 Mar 2010 12:31:24 +0000

Doctrine_Connection_UnitOfWork->saveAssociations() does not use column-aliases for database-columns but only field-names. The following patch deals with this problem:

Index: lib/Doctrine/Connection/UnitOfWork.php
===================================================================
— lib/Doctrine/Connection/UnitOfWork.php (revision 7004)
+++ lib/Doctrine/Connection/UnitOfWork.php (working copy)
@@ -439,8 +439,8 @@
$assocTable = $rel->getAssociationTable();
foreach ($v->getDeleteDiff() as $r)

{ $query = 'DELETE FROM ' . $assocTable->getTableName() - . ' WHERE ' . $rel->getForeign() . ' = ?' - . ' AND ' . $rel->getLocal() . ' = ?'; + . ' WHERE ' . $rel->getForeignRefColumnName() . ' = ?' + . ' AND ' . $rel->getLocalRefColumnName() . ' = ?'; $this->conn->execute($query, array($r->getIncremented(), $record->getIncremented())); }

[DC-394] Searchable behavior's batchUpdateIndex fails if a table has a composite primary key.

Tue, 2 Mar 2010 12:34:28 +0000

You will get the following error when you try to batchUpdateIndex a table with composite key:

Fatal error: Uncaught exception 'ErrorException' with message 'strpos() expects parameter 1 to be string, array given' in library/Doctrine/Connection.php:725

Here's the full stack trace:

Stack trace:
#0 [internal function]: Bootstrap->errorHandler(2, 'strpos() expect...', '/Users/reko/Sit...', 725, Array)
#1 /Users/reko/Sites/MyProject/library/Doctrine/Connection.php(725): strpos(Array, '.')
#2 /Users/reko/Sites/MyProject/library/Doctrine/Search.php(246): Doctrine_Connection->quoteIdentifier(Array)
#3 /Users/reko/Sites/MyProject/library/Doctrine/Template/Searchable.php(69): Doctrine_Search->batchUpdateIndex(NULL, NULL, NULL)
#4 /Users/reko/Sites/MyProject/library/Doctrine/Template/Searchable.php(81): Doctrine_Template_Searchable->batchUpdateIndex(NULL, NULL, NULL)
#5 [internal function]: Doctrine_Template_Searchable->batchUpdateIndexTableProxy()
#6 /Users/reko/Sites/MyProject/library/Doctrine/Record.php(2622): call_user_func_array(Array, Array)
#7 [internal function]: Doctrine_Record->__call('batchUpdateInde...', Array)
#8 [internal function]: In in /Users/reko/Sites/MyProject/library/Doctrine/Connection.php on line 725

I know that it's recommended that you don't use composite primary keys, but this happens to occur when you stack the I18n and Searchable behaviour together, since the Translation table I18n behavior creates uses a composite key on (id, lang).

Anyways, the bug was quite simple one to fix and I've attached a patch that fixes the issue.

[DC-385] Behavior geographical generates latitude FLOAT(18, 2), longitude FLOAT(18, 2) - it's not exact

Thu, 11 Aug 2011 03:47:27 +0000

The problem was already described by another person at http://trac.symfony-project.org/ticket/7763
the generated field-type is wrong, so the stored lat/long values have lost precision.

[DC-384] Nested set API allows inconsistent trees to be created

Mon, 15 Mar 2010 12:04:13 +0000

First create a tree as follows:

A
B
C
D

That is, C and D are both children of B, and B is a child of A.

At this point our db looks as follows:

mysql> select SLUG, LFT, RGT, LEVEL from pk_context_cms_page;
-----------------------+

SLUG

LFT

RGT

LEVEL

-----------------------+

/	1	12	0
/about	10	11	1
global	NULL	NULL	NULL
/a	2	9	1
/a/b	3	8	2
/a/b/c	4	5	3
/a/b/c/d	6	7	3

-----------------------+
7 rows in set (0.00 sec)

Now, call D->moveAsLastChildOf(C). D is now a child of C.

So far so good:

mysql> select SLUG, LFT, RGT, LEVEL from pk_context_cms_page;
-----------------------+

SLUG

LFT

RGT

LEVEL

-----------------------+

/	1	12	0
/about	10	11	1
global	NULL	NULL	NULL
/a	2	9	1
/a/b	3	8	2
/a/b/c	4	7	3
/a/b/c/d	5	6	4

-----------------------+
7 rows in set (0.00 sec)

Now, call C->moveAsLastChildOf(D). This should pull D out from under C.

Instead the values of LFT and RGT get messed up:

mysql> select SLUG, LFT, RGT, LEVEL from pk_context_cms_page
-> ;
-----------------------+

SLUG

LFT

RGT

LEVEL

-----------------------+

/	1	12	0
/about	10	11	1
global	NULL	NULL	NULL
/a	2	9	1
/a/b	3	8	2
/a/b/c	6	7	5
/a/b/c/d	7	6	4

-----------------------+
7 rows in set (0.00 sec)

moveAsLastChildOf should either (1) implement moving ancestors beneath their children correctly or (2) refuse to do so.

Note: these actions were carried out as separate PHP requests.

This is easy to reproduce by firing up the Apostrophe sandbox project, logging in as admin/admin, creating the page structure described, and then clicking the apostrophe in the upper left and then the Reorganize tool.

Instructions to check out the current sandbox are here:

http://www.apostrophenow.com/home/readme

You'll need to set up databases.yml and do a build --all and a data-load, that's about it.

Be sure to open a second tab so that you can have two views of the tree showing the initial state (C and D both as kids of B) so that you can drag D under C in the first tab and then try to drag C under D in the second tab. Otherwise the tree editor itself will block you from trying to move C under D.

The implementation of pkContextCMS/executeTreeMove is calling moveAsLastChildOf() in both cases and doing so to the right pages. I've added logging to verify this, look for references to TREEMOVE in the frontend_log.dev file.

We are going to add checks at the pkContextCMS level to refuse to attempt to move an ancestor beneath one of its children as a workaround, although in principle that should be possible (at least if the ancestor has no children? Not sure if it always makes sense if it does have children other than the ancestors of the new parent).

[DC-380] Sequence SQL is not generated when exporing sql for postgres - with patch

Mon, 1 Mar 2010 19:58:54 +0000

I spent a couple of hours on Saturday debugging why the heck the sql for sequences doesn't get generated for Postgresql. As it seems somebody forget about that when writing the export driver.

Attached is a patch against 1.2.1 version.
This probably also applies to Doctrine 2!

[DC-374] importing sqlite db with doctrine does not detect autoincrement fields

Mon, 1 Mar 2010 20:09:00 +0000

when importing a sqlite db with doctrine it fails to detect autoincrement fields resulting in exceptions when inserting records, like this one:
Uncaught exception 'Doctrine_Connection_Sqlite_Exception' with message 'SQLSTATE[23000]: Integrity constraint violation: 19 usergroup.group_id may not be NULL' in /Users/aiso/dev/php/cms/mix/lib/ext/doctrine/Doctrine/Connection.php:1083.

This is caused by the fact that there is no check on 'autoincrement' in Import/Sqlite.php. In sqlite3 a field is autoincrement whenever its type is integer and is a primary key.

a patch is included.

[DC-381] Automatic sequence names - with patch

Mon, 1 Mar 2010 19:53:59 +0000

Right now in yaml schema if you write sequence: true all the sequence names are set to 1.
This fixes the class generator in such way that the table name is used for sequence name if sequence === true otherwise it works just like before.

[DC-377] Cannot delete a taggable record (Taggable Extension)

Fri, 10 Aug 2012 01:51:22 +0000

With Taggable extension, when I try to delete a record using Taggable, I get this exception :

SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`sf_sandbox/article_taggable_tag`, CONSTRAINT `article_taggable_tag_id_article_id` FOREIGN KEY (`id`) REFERENCES `article` (`id`))

If I check the sql queries generated by Doctrine, there are not "onDelete CASCADE" for one of relation added by Taggable extension.

I have write some test cases for reproduce this bug (checking if relation has a property onDelete setted to CASCADE) but I can't reproduce the thrown exception in test case because sqlite omits queries with constraint. Also, I found how to fix this bug.

The fix and test cases are available in the file attached to this ticket.

[DC-365] softdelete documentation is outof date

Tue, 2 Mar 2010 14:25:11 +0000

out of date http://www.doctrine-project.org/documentation/manual/1_2/en/behaviors#core-behaviors:softdelete the behavior add a deleted_at column from type timestamp

[DC-351] Moving nodes between trees doesn't work properly

Mon, 1 Mar 2010 21:05:21 +0000

Moving node with children from one tree too another tree is not working properly.

Database schema and fixtrues are attached to this ticket. tree_before.png.

I want move 'Children 2' with descendants to second tree as first child

code:
$treeObject = Doctrine::getTable('Tree')->findOneById(6);

$newParent = Doctrine::getTable('Tree')->findOneById(11);
$treeObject->getNode()->moveAsFirstChildOf($newParent);

This causes a problem. Doctrine inproperly moves 'Child 2' with descendants and 'GrandChild 1 of Child 3'. (picture tree_after_move without_patch.png)

I found why it's working wrong.

It is because in NestesSet.php in function _moveBetweenTrees close gap in old tree is run too fast.
After moving only node which I want, it doesn't move descendants, but it lower values lft, rgt of next old siblings of node.
And this cause that values(lft,rgt)/ranges overlap of descendants of moving node and values of old siblings with their descendants.
And during update lft/rgt/root/level for all descendants from old range of moving node, it updates also some next old siblings.

You can see this at picture tree_before_update without_patch.png, i stop script before "// Update lft/rgt/root/level for all descendants".

I've moved closing gap in old tree.

And after patching, moving node works properly. ( picture tree_after_move with_patch.png)

[DC-342] when a table has multiple relations to an other one, then only the last one will be created in the base models

Tue, 2 Mar 2010 14:18:26 +0000

Amongst many tables, I have these two below. When creating the models, it only creates the "CommentsBy" relation. Even if I move those two
relations into the "Comment" table definition and I make the necessary changes, the result will be the same. However, if I put one relation
into one table and the other into the other one, then it will be created. So, that would be a work-around, but it is still just a work-around,
plus when I also want (and I want) to create realtions pointing from the Comment to the User, I run into the same issue, but now in both of the tables.

I am building a site where I want to list the comments (comment text, comment by (username), comment time) and the users, so the relations are
needed in both ways (user -> comment and comment -> user) for the different pages, and Doctrine knows the trick, but it doesn't let me do it.

I am using Smarty, so for example I could to use something like this:

$smarty->assign('theuser', Doctrine::getTable('User')->find(123456));

{$theuser.username}

{foreach $theuser.CommentsAbout item=onecomment}

{$onecomment.comment} ... {$onecomment.ByUser.username} ... {$onecomment.created}

{/foreach}

User:
tableName: user
columns:
id:
type: integer(8)
unsigned: true
notnull: false
username:
type: string(64)

... and so on ...

relations:
Comment:
alias: CommentsAbout
local: id
foreign: about_user_id
foreignType: one
type: many
Comment:
alias: CommentsBy
local: id
foreign: by_user_id
foreignType: one
type: many
actAs:
Timestampable:
created:
name: created
updated:
name: updated

Comment:
columns:
id:
type: integer(8)
primary: true
notnull: true
autoincrement: true
by_user_id:
type: integer(8)
about_user_id:
type: integer(8)
comment:
type: string
actAs:
Timestampable:
created:
name: created
updated:
name: updated

[DC-332] Doctrine_Migration_Diff doesn't work when plugin schemas are present but there is no app schema

Tue, 2 Mar 2010 12:38:55 +0000

A project with plugin schemas, but no project-level schema, which Symfony is otherwise fine with:

svn co http://svn.symfony-project.com/plugins/pkContextCMSPlugin/sandbox/branches/1.3 cmstest13
cd cmstest13
./symfony doctrine:generate-migrations-diff

>> doctrine generating migration diff
>> file+ /private/var/folders/3H/3Hu3TTyjFt...TI/~~Tmp~~/doctrine_schema_81204.yml

Notice: Undefined variable: extension in /Users/boutell/Sites/cmstest13-jonwagetest/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Migration/Diff.php on line 320

Notice: Undefined variable: extension in /Users/boutell/Sites/cmstest13-jonwagetest/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Migration/Diff.php on line 324

No php or yml files found at path: "/Users/boutell/Sites/cmstest13-jonwagetest/lib/model/doctrine"

[DC-320] Doctrine_Record fails to correctly update columns named data (conflict with getData method)

Fri, 12 Mar 2010 06:50:41 +0000

I have a table with a "data" column (DATE type but the issue is not strictly related to the datatype), when updating/insering a record it fails with this error:

strtotime() expects parameter 1 to be string, array given in /usr/share/pear/Doctrine/lib/Doctrine/Record.php on line 1526

With some debugging I found that the value stored in $old was the internal $data array, and not my value. I assume that there's a conflict with the get/setData methods.

Thanks.

[DC-317] Using NestedSet behavior, createRoot function doesn't behave as expected with string multiple root key

Mon, 7 Dec 2009 20:34:19 +0000

I have defined this model :

 
Page:
  options: { type: InnoDB, collate: utf8_unicode_ci, charset: utf8 }
  columns:
    topic:       { type: string(32), notnull: true }
    title:        { type: string(255), notnull: true }
  actAs:
    NestedSet:      { hasManyRoots: true, rootColumnName: topic }

And use this code (database is empty) :

<?

$page = new Page;
$page->topic = 'my-topic';
$page->title = 'My Title';
$page->save();

print_r( $page->topic );  // OK, here it's perfect

Doctrine::getTable('Page')->getTree()->createRoot( $page );

print_r( $page->topic ); // Now topic == 1 . It's buggy !


Doctrine::getTable('Page')->getTree()->fetchTree( 'my-topic' ); // Buggy : return false !

?>

Let me know if you need more explainations,
julien

[DC-323] when inserting a record into sql server (via odbc) doctrine fails to get last inserted ID

Mon, 15 Mar 2010 21:45:38 +0000

in Doctrine/Sequence/Mssql.php the function lastInsertId() fails to retrieve the last inserted ID when inserting a record. Because the major release of my sql server is bigger than 8, it chooses $query = 'select SCOPY_IDENTITY()' which does not return a number (in fact it does not return anything), although the record IS inserted succesfully. The backtrace is attached.
If, on the other hand, I force doctrine to use 'select @@IDENTITY' the query does return the correct number and everything goes fine!
So I think the conditions which query to choose is incorrect. I tried both queries in SQL server itself and both queries returned the right number. But one of them gets lost somewhere when using it in doctrine.

[DC-318] Doctrine_Table::find(x) fails for odbc/mssql connection due to limit() clause

Duplicate — Mon, 22 Mar 2010 13:15:41 +0000

call that fails is Doctrine::getTable('Building')->find(1). With mysql all is fine, but if I use MSSQL via odbc (SQL Native Client) I get an exception saying:
SQLSTATE[22018]: Invalid character value for cast specification: 206 [Microsoft][SQL Native Client][SQL Server]Er is een conflict met het type operand ontstaan: text is incompatibel met int (SQLExecute[206] at ext\pdo_odbc\odbc_stmt.c:254)
see attached stacktrace.
So find(1) fails but a call to e.g. findAll() works fine.

I found out that if I leave out the limit(1) from the function find() on line 1602 it gives me the correct object and no exception!
So actually what goes wrong is the limit(1) clause in this call:
$object = Doctrine_Query::create()~~>from('Building b')~~>where('b.id = 1')~~>limit(1)~~>fetchOne();
with getSqlquery() this becomes:
SELECT TOP 1 [inner_tbl].[id] AS [b__id] FROM (SELECT TOP 1 [b].[id] AS [b__id], [b].[version] AS [b__version], [b].[name] AS [b__name], [b].[number] AS [b__number], [b].[title_nl] AS [b__title_nl], [b].[title_en] AS [b__title_en], [b].[published] AS [b__published] FROM [building] [b] WHERE ([b].[id] = ?)) AS [inner_tbl]

If executed with sqlcmd.exe this gives an error saying 'no columnname id', what seems to be correct since it should be [inner_tbl].[b__id] iso [inner_table].[id], so I suspect that the modifyLimitQuery() function in Connection/Mssql.php is not correct either.

I can work around this problem by doing a fetchOne() iso find().

[DC-314] length option ignored in addColumn method in Doctrine 1.2 migrations

Wed, 2 Dec 2009 17:12:28 +0000

I am using http://doctrine.mirror.svn.symfony-project.com/branches/1.2/lib and saw this problem with revision 6806.

The 'length' parameter in the options array seems to be
ignored by addColumn in Doctrine 1.2 migrations. No matter what we specified for
'length' we got a bigint in MySQL, resulting in failure later when we
tried to add a foreign key because we needed a 4-byte integer. There
does not seem to be any documentation of what is valid in the options
array when calling addColumn, however I see that length is still used
when passing an apparently identical options array for a particular
column when calling createTable.

That is, this code:

$this->addColumn('pg_event_request', 'event_id', 'integer',
array('length' => 4));

Does not work properly in Doctrine 1.2 (you get a bigint in MySQL).

We were able to work around it by implementing a migrate() method
instead, passing 4 as the final argument (there doesn't seem to be
clear documentation of this final argument but in the example in the
documentation it is the length of a string column, and sure enough it
does the same thing for an integer). Passing 4 here worked, we got a
4-byte integer.

[DC-302] Issues when using automatic relations ordering through 'orderBy' param in m2m relations

Tue, 1 Dec 2009 19:03:23 +0000

Partially related to ~~DC-240~~.

I found some additional problems, mainly with self-referenced relations.
I use ACL system with multiple inheritance, where order of inherited elements matters.
Here we have (Role <- m2m orderBy position - > Role) and (User < - m2m orderBy position -> Role):

class Role extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('name', 'string', 64);
	}
	
	public function setUp()
	{
		$this->hasMany('User as Users', array('local' => 'id_role', 'foreign' => 'id_user', 'refClass' => 'UserRole'));
		$this->hasMany('Role as Parents', array('local' => 'id_role_child', 'foreign' => 'id_role_parent', 'refClass' => 'RoleReference', 'orderBy' => 'position'));
		$this->hasMany('Role as Children', array('local' => 'id_role_parent', 'foreign' => 'id_role_child', 'refClass' => 'RoleReference'));
	}
}

class RoleReference extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('id_role_parent', 'integer', null, array('primary' => true));
		$this->hasColumn('id_role_child', 'integer', null, array('primary' => true));
		$this->hasColumn('position', 'integer', null, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasOne('Role as Parent', array('local' => 'id_role_parent', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
		$this->hasOne('Role as Child', array('local' => 'id_role_child', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
	}
}

class User extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('username', 'string', 64, array('notnull' => true));
		$this->hasColumn('password', 'string', 128, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasMany('Role as Roles', array('local' => 'id_user', 'foreign' => 'id_role', 'refClass' => 'UserRole', 'orderBy' => 'position'));
	}
}

class UserRole extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('id_user', 'integer', null, array('primary' => true));
		$this->hasColumn('id_role', 'integer', null, array('primary' => true));
		$this->hasColumn('position', 'integer', null, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasOne('User', array('local' => 'id_user', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
		$this->hasOne('Role', array('local' => 'id_role', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
	}
}

Sample data:

$role1 = new Role();
$role1->name = 'admin'; // id: 1
$role1->save();

$role2 = new Role();
$role2->name = 'publisher'; // id: 2
$role2->save();

$role3 = new Role();
$role3->name = 'reviewer'; // id: 3
$role3->save();

$role4 = new Role();
$role4->name = 'mod'; // id: 4
$role4->save();

// reviewer inherits from admin, mod, publisher - in that order
$role3->Parents[] = $role1;
$role3->Parents[] = $role4;
$role3->Parents[] = $role2;
$role3->save();

// update positions
$query = Doctrine_Query::create()
	->update('RoleReference')
	->set('position', '?', 0)
	->where('id_role_child = ?', 3)
	->andWhere('id_role_parent = ?', 1)
	->execute();
$query = Doctrine_Query::create()
	->update('RoleReference')
	->set('position', '?', 1)
	->where('id_role_child = ?', 3)
	->andWhere('id_role_parent = ?', 4)
	->execute();
$query = Doctrine_Query::create()
	->update('RoleReference')
	->set('position', '?', 2)
	->where('id_role_child = ?', 3)
	->andWhere('id_role_parent = ?', 2)
	->execute();
	

// add test user
$user = new User();
$user->username = 'test';
$user->password = 'test';
$user->fromArray(array('Roles' => array(4, 2)));
$user->save();
// update positions
$query = Doctrine_Query::create()
	->update('UserRole')
	->set('position', '?', 0)
	->where('id_user = ?', 1)
	->andWhere('id_role = ?', 4)
	->execute();
$query = Doctrine_Query::create()
	->update('UserRole')
	->set('position', '?', 1)
	->where('id_user = ?', 1)
	->andWhere('id_role = ?', 2)
	->execute();

Now, lazy-loading self-referenced m2m relations seems to be the issue (I know lazy-loading is wrong but it's needed to be like that in some parts of our system):

$role = Doctrine::getTable('Role')->find(3);
print_r($role->Parents->toArray());

The query which is created and executed during lazy-load of Parents relations is as follows:

SELECT role.id AS role__id, role.name AS role__name, role_reference.id_role_parent AS role_reference__id_role_parent, role_reference.id_role_child AS role_reference__id_role_child, role_reference.position AS role_reference__position FROM role INNER JOIN role_reference ON role.id = role_reference.id_role_parent WHERE role.id IN (SELECT id_role_parent FROM role_reference WHERE id_role_child = ?) ORDER BY role.id ASC, position

(seems a little strange as there are no automatically generated aliases e.g. r1, r2 etc. but whole table names)
The result is ordered by role.id first, then by position (without any alias and that could be an additional problem in some cases)

The result is: (as you can see the order of roles is 1, 2, 4 (positions: 0, 2, 1) instead of 1, 4, 2)

Array
(
    [0] => Array
        (
            [id] => 1
            [name] => admin
            [RoleReference] => Array
                (
                    [0] => Array
                        (
                            [id_role_parent] => 1
                            [id_role_child] => 3
                            [position] => 0
                            [Parent] => 
                        )

                )

        )

    [1] => Array
        (
            [id] => 2
            [name] => publisher
            [RoleReference] => Array
                (
                    [0] => Array
                        (
                            [id_role_parent] => 2
                            [id_role_child] => 3
                            [position] => 2
                            [Parent] => 
                        )

                )

        )

    [2] => Array
        (
            [id] => 4
            [name] => mod
            [RoleReference] => Array
                (
                    [0] => Array
                        (
                            [id_role_parent] => 4
                            [id_role_child] => 3
                            [position] => 1
                            [Parent] => 
                        )

                )

        )

)

It is NOT an issue with lazy-loading m2m relations between two different models:

$user = Doctrine::getTable('User')->find(1);
print_r($user->Roles->toArray());

The query generated seems to be correct: (well except the lack of an alias in front of position column in ORDER BY clause)

SELECT `r`.`id` AS `r__id`, `r`.`name` AS `r__name`, `u`.`id_user` AS `u__id_user`, `u`.`id_role` AS `u__id_role`, `u`.`position` AS `u__position` FROM `role` `r` LEFT JOIN `user_role` `u` ON `r`.`id` = `u`.`id_role` WHERE (`u`.`id_user` IN (?)) ORDER BY position

It works well for self-referenced relations where relation are defined in DQL e.g.:

$query = Doctrine_Query::create()
	->from('Role r')
	->leftJoin('r.Parents rp')
	->orderBy('r.name ASC')
	->where('r.id = ?', 3);
	
var_dump($query->getSqlQuery());
$result = $query->fetchOne();

print_r($result->Parents->toArray());

To sum up:
1. orderBy in m2m self-referenced relations does not work when they are lazy-loaded
2. lack of table alias for orderBy column when lazy-loading m2m relations between separate models (possibly not an issue?)

I am not sure if the first one could be fixed at all, due to specific query construction? If not, I would be glad to see a possible workaround for this problem.

Thanks in advance.

[DC-305] Oracle adapter statement closeCursor() is not working properly

Tue, 1 Dec 2009 19:09:01 +0000

Close cursor method cleans up non-existing array $bind_params, correct variable name is $bindParams. (comment of $bindParams is wrong to because it also speaks about $bind_params)

Now:

public function closeCursor()
{
$this->bind_params = array();
return oci_free_statement($this->statement);
}

Fix:

public function closeCursor()
{
$this->bindParams = array();
return oci_free_statement($this->statement);
}

[DC-298] Doctrine_Cache_Driver : array_search() expects parameter 2 to be array, boolean given at line 283

Tue, 1 Dec 2009 19:19:27 +0000

Doctrine_Cache_Driver::fetch() is supposed to return a string, but an array_search() is made on it by Doctrine_Cache_Driver::_deleteKey() (at line 283).

[DC-289] Using MSSQL connection the find method for models does not work

Duplicate — Tue, 2 Mar 2010 12:56:35 +0000

using a doctrine generated class's find method produced erroneous SQL such as:

SELECT TOP 1 [inner_tbl].[id] AS [b__id] FROM (SELECT TOP 1 [b].[id] AS [b__id], [b].[name] AS [b__name], [b].[alias] AS [b__alias], [b].[ip] AS [b__ip], [b].[operator_id] AS [b__operator_id], [b].[cell_id] AS [b__cell_id], [b].[latitude] AS [b__latitude], [b].[longtitude] AS [b__longtitude], [b].[community_read] AS [b__community_read], [b].[community_write] AS [b__community_write], [b].[last_found_at] AS [b__last_found_at], [b].[active] AS [b__active], [b].[type] AS [b__type], [b].[poll_mac_behind_sus] AS [b__poll_mac_behind_sus], [b].[created_at] AS [b__created_at] FROM [basestation] [b] WHERE ([b].[id] = '2')) AS [inner_tbl]

commenting out the following line (193) in' function modifyLimitQuery' for lib/Doctrine/Connection/Mssql.php

$query = preg_replace('/^'.$selectRegExp.'/i', $selectReplace . 'TOP ' . ($count + $offset) . ' ', $query);

//$query = 'SELECT TOP ' . $count . ' ' . $this->quoteIdentifier('inner_tbl') . '.' . $key_field . ' FROM (' . $query . ') AS ' . $this->quoteIdentifier('inner_tbl');

if ($orderby !== false) {

It appears to have worked. This method was part of jwage's commit for change set 6795 (http://trac.doctrine-project.org/changeset/6795/branches/1.2/lib/Doctrine/Connection/Mssql.php) so there must be a reason for this change. This is very preliminary. If the change works there is a considerable amount of refactoring that way be done. I will commit a proper patch once I am able to test exhaustively, at the moment this is a show stopper and I need to continue development.

[DC-285] Doctrine_Migration::createForeignKey takes 2 args, documentation says 3 args, code in docs does not work

Wed, 25 Nov 2009 00:27:42 +0000

The documentation here:

http://www.doctrine-project.org/documentation/manual/1_0/en/migrations:writing-migration-classes:available-operations:create-foreign-key

Says that when coding a migration, createForeignKey should take three arguments like so:

this->createForeignKey('table_name', 'email_foreign_key', $definition);

That produces this error:

macintosh-4:pogil boutell$ ./symfony doctrine:migrate
Catchable fatal error: Argument 2 passed to Doctrine_Migration::createForeignKey() must be an array, string given, called in /Users/boutell/Sites/pogil/lib/migration/doctrine/022_eventrequestcreator.class.php on line 17 and defined in /Users/boutell/Sites/pogil/lib/vendor/doctrine/Doctrine/Migration.php on line 487

The source code says:

/**

createForeignKey
*
@param string $tableName
@param string $constraintName
@return void
*/
public function createForeignKey($tableName, array $definition) { $options = get_defined_vars(); $this->addChange('created_fks', $options); }

I grepped for created_fks and found no references to it except in calls to addChange(), so I don't know where it's consumed or how, so... I don't know what the correct code might look like.

Right now it is not possible to add foreign keys in a migration by following the 1.0.x documentation.

[DC-279] Code Corrections For MsSql modifyLimitQuery

Mon, 23 Nov 2009 23:25:38 +0000

Below are some code corrections for the modifyLimitQuery. These fixes should also fix ~~DC-37~~

Code details:

Fixed case on sorting orders to match all other syntax.
Added additional explode to ensure we only get fieldname and not tablename.fieldname.
Added code to determine primary key for use in select statement. There may be a better way of doing this, but not with the input sent to the function I don't think.
Removed the outer table (not sure how this could have ever worked) and switched inner table to return only primary key and not all fields.
Removed outer table order by logic.

Diff - Old To New:

160c160
<                     $sorts[$i] = (stripos($orders[$i], ' desc') !== false) ? 'desc' : 'asc';
---
>                     $sorts[$i] = (stripos($orders[$i], ' desc') !== false) ? 'DESC' : 'ASC';
171a172
>                     $aux2 = explode('.', end($aux2));
185a187,191
>             $fields_string = substr($query, strlen($selectReplace), strpos($query, ' FROM ') - strlen($selectReplace));
>             $field_array = explode(',', $fields_string);
>             $aux2 = explode('.', $field_array[0]);
>             $key_field = trim(end($aux2));
> 
187c193
<             $query = 'SELECT * FROM (SELECT TOP ' . $count . ' * FROM (' . $query . ') AS ' . $this->quoteIdentifier('inner_tbl');
---
>             $query = 'SELECT TOP ' . $count . ' ' . $this->quoteIdentifier('inner_tbl') . '.' . $key_field . ' FROM (' . $query . ') AS ' . $this->quoteIdentifier('inner_tbl');
199,212d204
<                 }
<             }
< 
<             $query .= ') AS ' . $this->quoteIdentifier('outer_tbl');
< 
<             if ($orderby !== false) {
<                 $query .= ' ORDER BY '; 
< 
<                 for ($i = 0, $l = count($orders); $i < $l; $i++) { 
<                     if ($i > 0) { // not first order clause 
<                         $query .= ', '; 
<                     } 
< 
<                     $query .= $this->quoteIdentifier('outer_tbl') . '.' . $aliases[$i] . ' ' . $sorts[$i];

Entire New Function:

    public function modifyLimitQuery($query, $limit = false, $offset = false, $isManip = false)
    {
        if ($limit > 0) {
            $count = intval($limit);
            $offset = intval($offset);

            if ($offset < 0) {
                throw new Doctrine_Connection_Exception("LIMIT argument offset=$offset is not valid");
            }

            $orderby = stristr($query, 'ORDER BY');

            if ($orderby !== false) {
                // Ticket #1835: Fix for ORDER BY alias
                // Ticket #2050: Fix for multiple ORDER BY clause
                $order = str_ireplace('ORDER BY', '', $orderby);
                $orders = explode(',', $order);

                for ($i = 0; $i < count($orders); $i++) {
                    $sorts[$i] = (stripos($orders[$i], ' desc') !== false) ? 'DESC' : 'ASC';
                    $orders[$i] = trim(preg_replace('/\s+(ASC|DESC)$/i', '', $orders[$i]));

                    // find alias in query string
                    $helper_string = stristr($query, $orders[$i]);

                    $from_clause_pos = strpos($helper_string, ' FROM ');
                    $fields_string = substr($helper_string, 0, $from_clause_pos + 1);

                    $field_array = explode(',', $fields_string);
                    $field_array = array_shift($field_array);
                    $aux2 = spliti(' as ', $field_array);
                    $aux2 = explode('.', end($aux2));

                    $aliases[$i] = trim(end($aux2));
                }
            }

            // Ticket #1259: Fix for limit-subquery in MSSQL
            $selectRegExp = 'SELECT\s+';
            $selectReplace = 'SELECT ';

            if (preg_match('/^SELECT(\s+)DISTINCT/i', $query)) {
                $selectRegExp .= 'DISTINCT\s+';
                $selectReplace .= 'DISTINCT ';
            }

            $fields_string = substr($query, strlen($selectReplace), strpos($query, ' FROM ') - strlen($selectReplace));
            $field_array = explode(',', $fields_string);
            $aux2 = explode('.', $field_array[0]);
            $key_field = trim(end($aux2));

            $query = preg_replace('/^'.$selectRegExp.'/i', $selectReplace . 'TOP ' . ($count + $offset) . ' ', $query);
            $query = 'SELECT TOP ' . $count . ' ' . $this->quoteIdentifier('inner_tbl') . '.' . $key_field . ' FROM (' . $query . ') AS ' . $this->quoteIdentifier('inner_tbl');

            if ($orderby !== false) {
                $query .= ' ORDER BY '; 

                for ($i = 0, $l = count($orders); $i < $l; $i++) { 
                    if ($i > 0) { // not first order clause 
                        $query .= ', '; 
                    } 

                    $query .= $this->quoteIdentifier('inner_tbl') . '.' . $aliases[$i] . ' '; 
                    $query .= (stripos($sorts[$i], 'asc') !== false) ? 'DESC' : 'ASC';
                }
            }
        }

        return $query;
    }

[DC-282] Memory Leak in Doctrine_Query_Abstract._getDqlCallbackComponents()

Tue, 24 Nov 2009 19:41:30 +0000

The following iteration shows increasing memory usage:

 $manager = Doctrine_Manager::getInstance();
$manager->setAttribute(Doctrine::ATTR_USE_DQL_CALLBACKS, true);
$manager->....connection....

for($i=0; $i<10;$i++) {
  $tx = Doctrine_Query::create()
    ->from('Some_Entity cot')
    ->andWhere('cot.id = ?', $someid)
     ->fetchOne();
			
  $usage = memory_get_usage();
  echo $i.': '.$usage."\n";
}

This results in an exceed-max-memory-fatal (750 MB) with a more complex application i am running that iterates >20,000 times.
I found out that there is a memory leak in Doctrine_Query_Abstract._getDqlCallbackComponents():

...
$copy->getSqlQuery($params);
$componentsAfter = $copy->getQueryComponents();
$copy->free(); //This is the solution
...

Sincerly,
Markus

[DC-276] HAVING does not parse column aliases

Fri, 8 Jan 2010 16:52:19 +0000

How to reproduce

$query->having('<aggregate_alias> <operator> <column_alias>').

Expected SQL:

 
... HAVING <internal_aggregate_alias> <operator> a<N>__<column_name>...

Produced SQL

... HAVING <internal_aggregate_alias> <operator> <column_alias> ... /* yes, the same <column_alias> as in ->having() call! */

I've prepared this "real-world example".

Please fix it someone since I'm forced to invent weird workarounds to emulate this behaviour.

Thanks in advance.

[DC-207] Masked exception makes it very difficult to debug

Tue, 10 Nov 2009 16:34:31 +0000

When you try to save an object, but the database does not exist, Doctrine throws a Doctrine_Transaction_Exception exception with the message "Rollback failed. There is no active transaction.".

But the real problem is that the database does not exit. The problem is in the Doctrine_Connection_UnitOfWork class around line 146:

        } catch (Exception $e) {
            // Make sure we roll back our internal transaction
            //$record->state($state);
            $conn->rollback();
            throw $e;
        }

The exception occurs because of "$conn->rollback();", and so the "throw $e;" is never reached.

We should probably throws an exception earlier about the fact that the database does not exist.

[DC-213] Doctrine_Import_Schema::parseSchema(): handling of global options in schema definition

Thu, 12 Nov 2009 20:14:40 +0000

Doctrine allows schema files (schema.yml in my case as symfony user) to define global settings that shall be valid for each class (within the same schema file) to be taken as default unless specified otherwise within the class.
However, once an individual class does specify (even only) one single option, none of the global options are being used anymore at all. This is the current implementation as of in Doctrine_Import_Schema::parseSchema(), line 330.
IMHO this implementation makes the feature of rather little benefit for users, particularly because 'options' is an array, even a nested one since symfony 1.3 did introduce their own options therein ('forms' and 'filters').

Following example:

schema.yml

# global settings, as default for all classes
detect_relations:                   false
options:
    type:                           innodb
    collate:                        utf8_unicode_ci
    charset:                        utf8
    symfony:
        form:                       true
        filter:                     true

DocumentSource:
    tableName:                      dk_doc_source
    abstract:                       'Possible sources for documents (code set)'
    options:
        symfony:                    { filter: false }
    actAs:
        Timestampable:              ~
    columns:
        name:                       { type: string(63), notnull: true }
        description:                { type: string(255) }

DocumentType:
    tableName:                      dk_doc_type
    abstract:                       'Allowed types for documents'
    options:
        symfony:                    { form: false, filter: false }
    actAs:
        Timestampable:              ~
    columns:
        name:                       { type: string(63), notnull: true }
        description:                { type: string(255) }

DocumentTag:
    tableName:                      dk_doc_tag
    abstract:                       'Tags for documents'
    actAs:
        Timestampable:              ~
    columns:
        name:                       { type: string(63), notnull: true }
        description:                { type: string(255) }

After an import with the current implementation, the classes end up having the following options:

DocumentSource:

    options:                             # taken from the specific class, no global setting was taken over
        symfony:                    { filter: false }

DocumentType:

    options:                            # taken from the specific class , again no global setting was taken over
        symfony:                    { form: false, filter: false }

DocumentTag:

options:                            # taken from the globals
    type:                           innodb
    collate:                        utf8_unicode_ci
    charset:                        utf8
    symfony:
        form:                       true
        filter:                     true

As a developer I originally understood the feature in that DocumentSource and DocumentType would still get the global option settings like collate, charset etc without having to repeat them again and again.

Like e.g. for DocumentSource:

options:                            # global and class specific options brought together
    type:                           innodb
    collate:                        utf8_unicode_ci
    charset:                        utf8
    symfony:
        form:                       true
        filter:                     false

--> is the effect of the current implementation is intentional?
I.e. I wish to raise the question: shall globals...

only be applicable to an individual class if the latter doesn't specifiy any option at all? (principle of XOR), or
complement the class' individual options, i.e. the developer defines the desired default options as globals, and specifies any difference from that in the individual class? (principle of inheritance).

IMHO as a user of Doctrine & Symfony, I cleary prefer the inheritance principle (2).

A thinkable solution is to use array_replace_recursive() or a similar function instead of a simple assignment:

Doctrine_Import_Schema::parseSchema(); lines 326 - 333

CURRENT:
        // Apply the globals to each table if it does not have a custom value set already
        foreach ($array as $className => $table) {
            foreach ($globals as $key => $value) {
                if ( !isset($array[$className][$key])) {
                    $array[$className][$key] = $value;
                }
            }
        }
PATCH:
        // Apply the globals to each table if it does not have a custom value set already
        foreach ($array as $className => $table) {
            foreach ($globals as $key => $value) {
                   $array[$className][$key] = array_replace_recursive($value, $array[$className][$key]);    // do inherit the global settings
            }
        }

I haven't yet tried out this patch nor even tested it, since anything first depends from a clarification on the common expectations from the feature of globals in schema files.

Cheers, RAPHAEL

PS. update: I created a corresponding issue in Symfony trac.

[DC-204] [patch] Cloning or copying a query object keeps a reference to the previous hydrator

Tue, 10 Nov 2009 16:56:43 +0000

Upon cloning or copying a query object, the hydrator property still points to the original query. Changing it in the child object changes it for the parent object.

thanks to gnat42 for the patch

[DC-199] Combination of Searchable and I18n behaviors

Wed, 18 Nov 2009 21:46:30 +0000

I know, Doctrine allows to inherit behaviors. In my schema.yml i have added Searchable behavior to an I18n behavior.

schema.yml

Screencast:
  tableName: screencast
  actAs:
    Timestampable: ~
    I18n:
      fields:
        - title
        - is_sub_visible
      actAs:
        Searchable:
          fields: [title]
  columns:
    id:
      type: integer
      primary: true
      autoincrement: true
      unsigned: true
    slug: { type: string(127), notnull: true }
    is_visible: boolean(false)
    title: string(255)
    is_sub_visible: boolean(false)
  indexes:
    is_visible: { fields: [is_visible] }
    slug: { fields: [slug], type: unique }

By calling "Doctrine_Table::search" without defining second parameter (custom Doctrine_Query) works fine.
Then, when i pass the second paramter (by calling $q->execute() i got this exception:

Doctrine_Hydrator_Exception: Couldn't hydrate. Found non-unique key mapping named 'lang'. in /usr/lib/symfony/1.3-svn/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Hydrator/Graph.php on line 156

Hire is my test example "test.php"

test.php

<?php

// initializing Screencast and ScreencastTranslation tables
// in other case, will be thrown Doctrine_Exception with message "Couldn't find class ScreencastTranslation"
ScreencastTable::getTable();


$i18nTable = Doctrine::getTable('ScreencastTranslation');

// create query instance and add filter by "is_sub_visible = true" column
$q = $i18nTable->createQuery('st')->addWhere('st.is_sub_visible = ?', true);

// run search query
$q = $i18nTable->search('doctrine', $q);

// prints:
// FROM ScreencastTranslation st WHERE st.is_sub_visible = ? AND st.id IN (SQL:SELECT id FROM screencast_translation_index WHERE keyword = ? GROUP BY id)
print $q->getDql();

$doctrineCollection = $q->execute(); // on this line throws Doctrine_Hydrator_Exception

?>

[DC-202] Alias in InnerJoin-Update-Queries wrong

Mon, 16 Nov 2009 19:27:23 +0000

I tried to do an UPDATE-Operation like the following example:

$query = Doctrine_Query::create()
->update('PickingRequestStatus s')
->innerJoin('s.Request r')
->innerJoin('r.WorkStatus ws')
->set('s.status=?', PickingRequestStatus::$STATUS_WORK_CANCELLED)
->where('s.status = ?', array(PickingRequestStatus::$STATUS_WORK_STARTED))
->andWhere('ws.last_action_at < ?', $threshold);

The created SQL-Statement is wrong:
UPDATE sd_picking_request_status INNER JOIN sd_picking_request s2 ON s.request_id = s2.id INNER JOIN sd_picking_request_work_status s3 ON s2.id = s3.request_id SET status = 16 WHERE status = 8 AND last_action_at < '2009-11-08 11:00'

and you will get the following error-message: SQLSTATE[42S22]: Column not found: 1054 Unknown column 's.request_id' in 'on clause'

If you remove the s. in the JOIN-Statement everthing is fine:

UPDATE sd_picking_request_status INNER JOIN sd_picking_request s2 ON request_id = s2.id INNER JOIN sd_picking_request_work_status s3 ON s2.id = s3.request_id SET status = 16 WHERE status = 8 AND last_action_at < '2009-11-09 11:00'

[DC-201] [PATCH] Level is oracle keyword (reopened #479)

Tue, 10 Nov 2009 17:01:46 +0000

I created this ticket in connection to the http://trac.doctrine-project.org/ticket/479

The resolution was that it's fixed in http://trac.doctrine-project.org/changeset/3183/ - but it seems that it is fixed only in the changelog.

The LEVEL is an oracle keyword and the only way to use the NestedSet with Oracle is enabled quote identifiers.
We used this for about a year or more, but it is not so comfortable and this is the only reason why we are quoting identifiers.

But we started to use Oracle's spatial features and I was surprised that some oracle spatial functions are not able to work on quoted objects, and I started to use synonyms and extra columns with triggers as workaround. But it is so annoying and the patch is so simple

[DC-198] refreshRelated inserts records when One-to-One relationships are used and a related record is deleted

Thu, 19 Nov 2009 20:11:00 +0000

When one-to-one relationship is used and a refreshRelated is performed after a delete a new record is inserted with NULL values.

schema.yml

Email:
columns:
user_id: integer
address: string(150)
relations:
User:
local: user_id
foreign: id
type: one
foreignType: one
foreignAlias: email

User:
columns:
name: string(150)

Sample code

Create.php - create the user/email

$u = new User();
$u->name = 'Test';
$u->email->address = 'foo@bar.com';
$u->save();

Delete.php - remove the email

$u = Doctrine_Query::create()~~>from('User')~~>fetchOne();
$u->name = 'Test2' ;
$u->email->delete();
$u->refreshRelated('email');
$u->save();

The profile (of Delete.php)

connect 0.005211

query 0.000493
SELECT u.id AS u_id, u.name AS u_name FROM user u
prepare 0.000028
SELECT e.id AS e_id, e.user_id AS euser_id, e.address AS e_address FROM email e WHERE e.user_id = ?
execute 0.001086
SELECT e.id AS e_id, e.user_id AS euser_id, e.address AS e_address FROM email e WHERE e.user_id = ?
Array
(
[0] => 1
)
Total time: 0.00681829452515
fetch 0.000024
SELECT e.id AS e_id, e.user_id AS euser_id, e.address AS e_address FROM email e WHERE e.user_id = ?
fetch 0.000016
SELECT e.id AS e_id, e.user_id AS euser_id, e.address AS e_address FROM email e WHERE e.user_id = ?
begin 0.000147

prepare 0.000019
DELETE FROM email WHERE id = ?
execute 0.000253
DELETE FROM email WHERE id = ?
Array
(
[0] => 1
)
Total time: 0.00727772712708
commit 0.001120

prepare 0.000021
SELECT e.id AS e_id, e.user_id AS euser_id, e.address AS e_address FROM email e WHERE e.user_id = ?
execute 0.000333
SELECT e.id AS e_id, e.user_id AS euser_id, e.address AS e_address FROM email e WHERE e.user_id = ?
Array
(
[0] => 1
)
Total time: 0.0087513923645
fetch 0.000017
SELECT e.id AS e_id, e.user_id AS euser_id, e.address AS e_address FROM email e WHERE e.user_id = ?
begin 0.000104

prepare 0.000020
UPDATE user SET name = ? WHERE id = ?
execute 0.000291
UPDATE user SET name = ? WHERE id = ?
Array
(
[0] => Test2
[1] => 1
)
Total time: 0.00918316841125
prepare 0.000021
INSERT INTO email (id, user_id, address) VALUES (?, ?, ?)
execute 0.000193
INSERT INTO email (id, user_id, address) VALUES (?, ?, ?)
Array
(
[0] =>
[1] =>
[2] =>
)
Total time: 0.00939726829529
commit 0.000823

a var_dump of $u->toArray() after refreshRelated shows

array(3) {
["id"]=>
string(1) "1"
["name"]=>
string(7) "Test2"
["email"]=>
array(3)

{ ["id"]=> string(1) "1" ["user_id"]=> string(1) "1" ["address"]=> string(8) "foo@bar.com" }

}

And in the database I have null values for the email record.

This does not happen if I change the relationship to hasMany

[DC-197] [patch] default model orderBy option breaks data-load task

Tue, 10 Nov 2009 17:52:42 +0000

currently the default orderBy clause one can specify for models gets added to all queries, including DELETE and UPDATE.
This breaks data-load because it includes in the orderBy the table alias but currently only SELECT queries support aliases.

For example if I have the following schema:

Mytable:
options:

{ orderBy: name ASC }

columns:
name:

{ type: string(100), notnull: true }

The data-load task does a Doctrine::getTable('Mytable')~~>delete()~~>execute(); to clear the table before loading the fixtures which results in the following SQL:
DELETE FROM mytable ORDER BY m.name ASC

which errors out as the m alias was not defined.

Attached is the patch that makes only SELECT queries get the default orderBy clause from the option.

[DC-194] Oracle dropDatabase does not work

Thu, 12 Nov 2009 20:18:29 +0000

Doctrine_Export_Oracle::dropDatabase does not work, it contains some SQL errors. Here is the patch:

--- Doctrine-1.1.5/lib/Doctrine/Export/Oracle.php	2009-11-03 19:33:04.000000000 +0100
+++ doctrine/Doctrine/Export/Oracle.php	2009-11-06 14:40:46.000000000 +0100
@@ -76,17 +76,19 @@
         $sql[] = "BEGIN
 FOR I IN (select table_name from user_tables)
 LOOP 
-EXECUTE IMMEDIATE 'DROP TABLE '||I.table_name||' CASCADE CONSTRAINTS';
+EXECUTE IMMEDIATE 'DROP TABLE \"'||I.table_name||'\" CASCADE CONSTRAINTS';
 END LOOP;
 END;";
 
         $sql[] = "BEGIN
 FOR I IN (SELECT SEQUENCE_NAME, SEQUENCE_OWNER FROM ALL_SEQUENCES WHERE SEQUENCE_OWNER <> 'SYS')
 LOOP 
-EXECUTE IMMEDIATE 'DROP SEQUENCE '||I.SEQUENCE_OWNER||'.'||I.SEQUENCE_NAME;
+EXECUTE IMMEDIATE 'DROP SEQUENCE \"'||I.SEQUENCE_OWNER||'\".\"'||I.SEQUENCE_NAME||'\"';
 END LOOP;
 END;";

[DC-191] Doctrine_Migration->loadMigrationClassesFromDirectory fail when launched 2 times

Tue, 10 Nov 2009 17:19:08 +0000

When I need to create a Doctrine_Migration twice during a same php processus, the migrations version numbers get wrong.

In Doctrine_Migration->loadMigrationClassesFromDirectory method, I see :

        if (isset(self::$_migrationClassesForDirectories[$directory])) {
            $migrationClasses = (array) self::$_migrationClassesForDirectories[$directory];
            $this->_migrationClasses = array_merge($migrationClasses, $this->_migrationClasses);
        }

The problem is that array_merge loose the array keys. In the $this->_migrationClasses context, array keys are very important because they are the version numbers.

So when if (isset(self::$_migrationClassesForDirectories[$directory])) is true ( ie the second time we use the Doctrine_Migration classs ) all the migrations versions get wrong.

I hope my description is clear enough.

[DC-192] Doctrine_Import_Builder Missing Relation Alias When Using classPrefix

Tue, 10 Nov 2009 17:58:08 +0000

Doctrine_Import_Builder, line 383

$alias = (isset($relation['alias']) && $relation['alias'] !== $relation['class']) ? ' as ' . $relation['alias'] : '';

For example, if both class name and alias is "User" and we make use of classPrefix (i.e "Model_"), the generated class name will actually be "Model_User". The comparison of:

$relation['alias'] !== $relation['class']

does not cover the prefix, which lead to the missing of alias when generating models, i.e

$this->hasOne('Model_User', ...

instead of

$this->hasOne('Model_User as User', ...

Suggested fix:

$alias = (isset($relation['alias']) && $relation['alias'] !== $this->_classPrefix . $relation['class']) ? ' as ' . $relation['alias'] : '';

[DC-190] Fatal error while connecting after an reset of the Doctrine_Manager

Tue, 10 Nov 2009 17:29:49 +0000

Doctrine_Manager::connection('sqlite::memory:');
Doctrine_Manager::resetInstance();
Doctrine_Manager::connection('sqlite::memory:');
Fatal error: Call to a member function onOpen() on a non-object in ...../Doctrine/Connection.php on line 221

which is $this->getAttribute(Doctrine_Core::ATTR_LISTENER)->onOpen($this);

The Doctrine_Core::ATTR_LISTENER attribute is not set in the connection nore in the manager... This is because Doctrine_Manager::resetInstance does remove all attributes but Doctrine_Manager::setDefaultAttributes does not allow to set the default attributes twice.

This method can only run once, because it use a local static $init variable and since Doctrine_Manager is a Singleton the init value should stored within the instance.

What happens :
1. In Doctrine_Manager::setDefaultAttributes() the Doctrine_Core::ATTR_LISTENER is set to new Doctrine_EventListener().
2. A connection get its attributes from the manager when not available in the connection.
3. When Doctrine_Manager::reset() is called the attributes are gone and should be set again...
4. However because the Doctrine_Manager::setDefaultAttibutes method only can run once (a check is set in a static local boolean) the listener is not recreated and thus subsequent connections will fatally fail

patch by
A fix is simple and I have it running locally...

1. add an private $_inited or $_defaultAttributesSet property to Doctrine_Manager, defaults to false;
2. on Doctrine_Manager::reset reset it to its default (false)
3. on Doctrine_Manager::setDefaultAttibutes do nothing when the property equals true, but when the property is false proceed with setting the default attributes...

[DC-187] The Unique does not work correctly when using "SoftDelete"

Thu, 12 Nov 2009 20:49:19 +0000

Scenario:

class User extends Doctrine_Record
{
public function setTableDefinition()

{ $this->hasColumn('username', 'string', 255); $this->hasColumn('email', 'string', 255); $this->unique('username', 'email'); }

public function setUp()

{ $this->actAs('SoftDelete'); }

}

Test:

//create User
$user = new User();
$user->username = 'Fabian';
$user->email = 'fabian@test.com';
$user->save();

...
...
// delete user
$user = Doctrine_Query::create()
->select('*')
->from('User')
->where("id=1")
->fetchOne();
$user->delete(); //this mark as deleted the user (delete_at field)

....
....

//create User with same data
$user = new User();
$user->username = 'Fabian';
$user->email = 'fabian@test.com';
$user->save();

// This throw error by the "unique"

[DC-186] Patch to correct CLI tests

Wed, 4 Nov 2009 20:20:26 +0000

Enclosed is a little patch to correct my CLI tests.

The patch wraps test runs on the CLI in an output buffer to prevent output to the console when the unit tests are run. This output from the CLI could be mistaken for errors, but it's expected and only looks unfriendly - no errors / exceptions are thrown.

[DC-181] Exception thrown - nested query in count query

Reference — Thu, 5 Nov 2009 07:03:25 +0000

My model is:

product: [ id, name]
product_category_ref [product_id, category_id]
product_category: [id, name]

I have a query like this:
$page = 1;
$ids = array(1,2);
$query = Doctrine_Query::create()
->from('Product p')
->innerJoin('p.Categories cat')
->andWhere('p.is_active = 1')
->andWhereIn('p.id', $ids);

$pager = new Doctrine_Pager($query, $page, sfConfig::get('app_eshop_pager_limit', 5));

$pager->execute(array(), Doctrine::HYDRATE_ARRAY);

throws and exception: SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens

Stack trace:

at ()
in SF_ROOT_DIR\plugins\sfDoctrinePlugin\lib\doctrine\Doctrine\Connection.php line 1086 ...
1083.
1084. $name = 'Doctrine_Connection_' . $this->driverName . '_Exception';
1085.
1086. $exc = new $name($e->getMessage(), (int) $e->getCode());
1087. if ( ! isset($e->errorInfo) || ! is_array($e->errorInfo)) { 1088. $e->errorInfo = array(null, null, null, null); 1089. }
at Doctrine_Connection->rethrowException(object('PDOException'), object('Doctrine_Connection_Statement'))
in SF_ROOT_DIR\plugins\sfDoctrinePlugin\lib\doctrine\Doctrine\Connection\Statement.php line 253 ...
250. } catch (Doctrine_Adapter_Exception $e) { 251. }
252.
253. $this->_conn->rethrowException($e, $this);
254.
255. return false;
256. }
at Doctrine_Connection_Statement->execute(array('1', '2', '1', '2'))
in SF_ROOT_DIR\plugins\sfDoctrinePlugin\lib\doctrine\Doctrine\Connection.php line 1014 ...

I found a place in Doctrine/Query.php (line 1155), changed line:

$list = $this->_conn->execute($subquery, $this->getParams($params))->fetchAll(Doctrine::FETCH_COLUMN);

$list = $this->_conn->execute($subquery, $params)->fetchAll(Doctrine::FETCH_COLUMN);

and it works ok, im not sure if that brokes anything

[DC-182] 1.0.13 limit() broke with :

Tue, 1 Dec 2009 05:59:16 +0000

$q = Doctrine_Query::create()
->from('news n')
->leftJoin('n.Translation t')
->Where('n.published = ?', 1)
->limit(10)
->orderBy('n.id DESC');

('SELECT DISTINCT n3.id FROM news n3 LEFT JOIN news_translation n4 ON n3.id = n4.id WHERE n3.published = ? ORDER BY n3.id DESC LIMIT 10', array(1, 1))

The issue is just the transformation from '1' to array...

symfony 1.2.9 with doctrine VERSION = '1.0.13';

The limit seem to be broken.

SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens

I'll submit test case ASAP.

[DC-179] Wrong length estimation in Doctrine_Validator->validateLength() if locale sets decimal point other than "dot"

Wed, 4 Nov 2009 19:50:15 +0000

Test case:
1) set locale: setlocale(LC_ALL, "") (on windows it sets current international control panel settings), in case of Polish locale it changes decimal point to ',' (comma)
2) try to save value "12,12" of decimal type field (mysql type):

{ type: decimal(4), scale: 2 }

,
3) it gives you validation error (length)

Summary:
Doctrine_Validator->validateLength() could not count length properly.

Idea:
I changed dot character in explode function to proper env character:

// changes start
$localeInfo = localeconv();
$e = explode($localeInfo["mon_decimal_point"], $value);
// changes end

It works for me.

Enclosed Validator.php

[DC-180] [PATCH] Unique index name for column aggregation key column

Wed, 4 Nov 2009 19:45:34 +0000

When using column aggregation colum with the same name on multiple models, and exporting schema to database, I have a collisions with names in Oracle (I think others are affected too).

{{
CREATE INDEX "type" ON "nt_organism_property" ("type")
CREATE INDEX "type" ON "nt_property" ("type")
CREATE INDEX "type" ON "st_node" ("type")
}}

I propose to prefix the index name with the table name

[DC-175] New hardDelete() on Soft Delete Template creates blank records

Tue, 3 Nov 2009 17:00:18 +0000

When using the new hardDelete() in the SoftDelete template, the postDelete() listener is saving a blank record because it calls ->save() on the record, even if the record was hard deleted.

    public function postDelete(Doctrine_Event $event)
    {
      $event->getInvoker()->save();
    }

should be

 
    public function postDelete(Doctrine_Event $event)
    {
      if ( ! $this->_options['hardDelete']) {
        $event->getInvoker()->save();
      }
    }

[DC-178] Import Builder doesn't use default table class name

Wed, 4 Nov 2009 19:52:49 +0000

I use Symfony 1.2.9 with Doctrine 1.2 trunk.

I also make use of the new Doctrine's feature to specify custom table class. For that, in the config/ProjectConfiguration.class.php I have the following code:

   public function configureDoctrine(Doctrine_Manager $manager)
   {
      ...
      $manager->setAttribute(Doctrine::ATTR_TABLE_CLASS, 'Platform_DoctrineTable');
      ...
   }

And that works fine. But when I comment out this line and re-generate model classes, I get broken table class definitions like:

class AccountTable extends 
{

}

Notice the lack of base class name.

It seems the problem resides in Doctrine_Import_Builder's constructor:

    public function __construct()
    {
        $this->_baseTableClassName = Doctrine_Manager::getInstance()->getAttribute(Doctrine_Core::ATTR_TABLE_CLASS);
        $this->loadTemplate();
    }

So, the default value of $this->_baseTableClassName always overwrites by Doctrine_Core::ATTR_TABLE_CLASS attribute value.

[DC-171] make it possible to force deletion when using softdelete

Tue, 3 Nov 2009 03:52:06 +0000

it would be nice to be able to force deleting when using softdelete. right now it seems like there is no way to still be able to do a real DELETE.
http://www.doctrine-project.org/documentation/manual/1_1/en/behaviors:core-behaviors:softdelete

something like $record->delete(true);

take for example some undo feature. there might be a point where i want to purge the possibility to do an undo (like at the end of the session).

[DC-172] change 6611 wrong

Mon, 2 Nov 2009 20:50:56 +0000

see line 95 in branches/1.2/lib/Doctrine/Connection/UnitOfWork.php

if ($ids) {
$record->unlinkInDb($alias, array());
} else if ($ids) {
$record->unlinkInDb($alias, array_keys($ids));
}

[DC-169] replace() method does not affect Timestampable fields

Tue, 3 Nov 2009 03:32:42 +0000

I have a Timestampable behavior on a table. If I create or edit an object of this table using the ->replace() method instead of ->save(), the Timestampable fields (created_at and updated_at by default) are not changed.

[DC-165] outdated symfony Yaml parser causes troubles

Tue, 3 Nov 2009 01:10:35 +0000

all doctrine versions use an imported and modified version of sfYaml.
Either that needs to be changed to an external, or bugfixes need to be ported.
see this ticket from symfony trac:
http://trac.symfony-project.org/ticket/7496

I wanted to use some yaml in a fixture to populate data for the "array"-Fieldtype.

In the fixture I used:
items:
  -
    name:           temp_zone_1
    fieldLabel:     Temp. Zone 1 [°C]
    value:          997
    minValue:       0
    maxValue:       3000
...
the resulting serialized array in the table array looked like:
s:5:"items";a:9:{i:0;a:5:{s:4:"name";s:11:"temp_zone_1";s:10:"fieldLabel";s:18:"Temp. Zone 1 [°C]";s:5:"value";s:3:"997";s:8:"minValue";i:0;s:8:"maxValue";s:4:"3000";}...
There you can easily see, that "value" is now a string, "minValue" an integer (why?) and maxValue another string. This went awfully wrong somewhere.

= Workaround and/or solution =
I took the current parser from `lib/yaml/sfYamlParser.php` and copied it into the existing Parser in `lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Parser/YamlSf/Parser.php`. That fixed the problem.

== Additional Information ==

used Version in Symfony 10832 2008-08-13

used Version in sfDoctrinePlugin 8869 2008-05-09

HTH,
Michael

used Version in Symfony	10832 2008-08-13
used Version in sfDoctrinePlugin	8869 2008-05-09

[DC-163] Validator throws out a data type which the schema processing has accepted

Tue, 3 Nov 2009 04:35:14 +0000

Doctrine accepts 'char' in the (yml) schema, and creates the database and model.
Then an attempt to save a record raises a Doctrine_Validator_Exception, which turns out to contain no validation message, but just the cryptic
[_errors:protected] => Array
(
[nickname] => Array
(
[0] => type
)

)

[_validators:protected] => Array
(
)

Only by looking at the source did I discover that what this means is that the validator does not accept the column type 'char' - because it's not hard-coded in Doctrine_Validator::isValidType.

I've vacillated over whether to classify this as 'Major' or Minor': once I've realised what's going on, it's easy to work round; but it is a show-stopper for a Doctrine novice.

[DC-159] No use of Offset in the Limit / Offset Documentation

Fri, 30 Oct 2009 16:33:53 +0000

There is no mentioning how to use the offset funktion in the "LIMIT and OFFSET clauses" chapter in the Doctrine 1.1 Documentation.

Some Example should feature:

->limit(12)
->offset(3)

to show how to use it.

[DC-158] Postgresql Import does not recognize all parts of a composite primary key as primary keys

Tue, 3 Nov 2009 00:42:32 +0000

If a PostgreSQL table has a composite primary key, Doctrine import ("generate-models-db") will only mark the first column of the composite key as primary. This is due to a bug in Doctrine_Import_Pgsql.

I have attached a short patch against the current 1.1 branch (revision 6580). The version 1.2 seems to have the same problem.
I have tested the patch with PostgreSQL 8.3.8.

[DC-151] Doctrine_Collection::loadRelated() issues with empty collection and handling with no name parameter

Fri, 30 Oct 2009 17:04:20 +0000

When no name is passed, the list variable isnt passed to the where() method call. Also in all cases an empty $list variable isnt handled properly.

[DC-153] Some pieces of Doctrine's internal code can't work properly without a default connection

Tue, 3 Nov 2009 02:19:25 +0000

For details see thread in doctrine-dev group.

[DC-152] isModified deep isn't working when only deep objects are modified

Mon, 2 Nov 2009 23:45:13 +0000

Record::isModified(true) isn't working when only a subobject is modified (it returns false).
The attached patch corrects the problem.

[DC-140] _createLimitSubquery generates a query with error ORA-00904

Wed, 18 Nov 2009 01:44:06 +0000

If I create a limited query with Oracle sometimes it generates an invalid query, giving ORA-00904 errror.

A simple DQL query like this:
$q = Doctrine_Query::create()
->select("$i.nome, $s.denominazione")
->from("Istituto $i")
->leftJoin("$i.Sedi $s");

creates this intermediate sql:
SELECT
"i"."id" AS "i__id",
"i"."nome" AS "i__nome",
"s"."id" AS "s__id",
"s"."denominazione" AS "s__denominazione"
FROM "istituto" "i"
LEFT JOIN "sede" "s" ON "i"."id" = "s"."id_istituto"

that passed to Doctrine_Pager generates this query:
SELECT "i"."id" AS "i__id",
"i"."nome" AS "i__nome",
"s"."id" AS "s__id",
"s"."denominazione" AS "s__denominazione"
FROM "istituto" "i"
LEFT JOIN "sede"
"s" ON "i"."id" = "s"."id_istituto"

WHERE "i"."id" IN (SELECT a."id" FROM (SELECT DISTINCT "i2"."id" FROM "istituto" "i") a WHERE ROWNUM <= 10)

The problem is in "i2" referenced in the inner SELECT statement. This inner query hasn't been correctly parsed, while the column has been aliased, the table name has an incorrect alias.

The problem is that the injected sql code necessary to pagination has some space missing inside the parenthesis, thus the tokenizer misses to alias the table name.
Here it follows a simple patch:

--- Oracle.php  2009-10-26 17:04:17.000000000 +0100
+++ Oracle-orig.php     2009-09-25 19:12:10.000000000 +0200
@@ -103,13 +103,13 @@
                 $column = $column === null ? '*' : $this->quoteIdentifier($column);
                 if ($offset > 0) {
                     $min = $offset + 1;
+                    $query = 'SELECT b.'.$column.' FROM ( '.
+                                 'SELECT a.*, ROWNUM AS doctrine_rownum FROM ( '
+                                   . $query . ' ) a '.
+                              ' ) b '.
-                    $query = 'SELECT b.'.$column.' FROM ('.
-                                 'SELECT a.*, ROWNUM AS doctrine_rownum FROM ('
-                                   . $query . ') a '.
-                              ') b '.
                               'WHERE doctrine_rownum BETWEEN ' . $min .  ' AND ' . $max;
                 } else {
+                    $query = 'SELECT a.'.$column.' FROM ( ' . $query .' ) a WHERE ROWNUM <= ' . $max;
-                    $query = 'SELECT a.'.$column.' FROM (' . $query .') a WHERE ROWNUM <= ' . $max;
                 }
             }
         }

[DC-143] php warnings and fatal errors when "package" attribute value is without "." (file config/doctrine/schema.yml)

Wed, 30 Mar 2011 15:29:06 +0000

Bug N1

When i define "package: user" (to store my Comment, Photo and etc. models in 1 directory lib/models/doctrine/user/) and run "doctrine:build-all-reload --no-confirmation" task, it creates unnecessary to me Plugin* models in plugin/ folder and task dies with fatal error:

PHP Fatal error: Class 'PluginCommentTable' not found in /home/username/www/sfpro/dev/playground/lib/model/doctrine/user/CommentTable.class.php on line 4

here is my schema.yml:

schema.yml

Comment:
  tableName: comment
  package: user
  columns:
    id:
      type: integer(4)
      primary: true
      autoincrement: true
    message: varchar(255)

Bug N2

ok, i have changed "package" value to "user.sometext" and runned "doctrine:build-all-reload --no-confirmation" task - it creates all models without errors, but does not create subfolders "user/sometext"

here is my schema.yml

schema.yml

Comment:
  tableName: comment
  package: user.sometext
  package_custom_path: lib/model/doctrine/user/plugin
  columns:
    id:
      type: integer(4)
      primary: true
      autoincrement: true
    message: varchar(255)

Bug N3

my schema.yml is:

schema.yml

Comment:
  tableName: comment
  package: user
  package_custom_path: lib/model/doctrine/user/plugin
  columns:
    id:
      type: integer(4)
      primary: true
      autoincrement: true
    message: varchar(255)

when i run symfony task "doctrine:build-all-reload --no-confirmation"

i got php warning:

PHP Warning: file_get_contents(/home/username/www/sfpro/dev/playground/lib/model/doctrine//base/BaseComment.class.php): failed to open stream: No such file or directory in /usr/lib/symfony/1.3-svn/lib/plugins/sfDoctrinePlugin/lib/task/sfDoctrineBuildModelTask.class.php on line 78

warning message shows "//" where i should have "user" value

[DC-137] Doctrine_Record_Generator does not autoload classes

Wed, 2 Dec 2009 16:55:14 +0000

Using the versionable behavior creates dynamic classes and does not autoload the models that are defined. Removing the false flag from if ($this->_options['generateFiles'] === false && class_exists($this->_options['className']. false )) { line will fix the issue

[DC-138] WHERE LIKE doesn't work on JOIN SELECTs.

Wed, 18 Nov 2009 22:07:55 +0000

WHERE LIKE doesn't work on JOIN SELECTs.
Params are not passed to the query.

Reproduce code:

	public function addSearchTerm(Doctrine_Query $query, array $fields)
	{
		$phrase = $this->getRequest()->getPost('query');
		if(!empty($phrase) && !empty($fields))
		{
			$phrase = '%'. $phrase .'%';
			$searchString = array();
			$searchParams = array();
			foreach($fields As $field)
			{
				$searchString[] = "$field LIKE ?";
				$searchParams[] = $phrase;
			} 
			$searchString = implode(' OR ', $searchString);
			
			$query->andWhere($searchString, $searchParams);
		}	
	}

$this->addSearchTerm($query, array(
			'username',
			'email',
			'last_login_ip',
			'Data.title',
			'Data.first_name',
			'Data.last_name',
			'Data.company',
			'Roles.name'
		));

Result attached as screenshot.

Query produced is correct, however '?' are not replaced with params from the array.

Error message is:
Doctrine_Connection_Mysql_Exception: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '? OR `c8`.`email` LIKE ? OR `c8`.`last_login_ip` LIKE ? OR `c9`.`title` LIKE ? O' at line 1

Query passed to MySQL by Doctrine:
SELECT DISTINCT `c8`.`id` FROM `core_users` `c8` LEFT JOIN `core_users_data` `c9` ON `c8`.`id` = `c9`.`id_user` LEFT JOIN `core_users_roles` `c11` ON (`c8`.`id` = `c11`.`id_user`) LEFT JOIN `core_roles` `c10` ON `c10`.`id` = `c11`.`id_role` LEFT JOIN `core_users_roles` `c13` ON (`c8`.`id` = `c13`.`id_user`) LEFT JOIN `core_roles` `c12` ON `c12`.`id` = `c13`.`id_role` LEFT JOIN `core_users_roles` `c14` ON `c12`.`id` = `c14`.`id_role` WHERE (`c8`.`username` LIKE ? OR `c8`.`email` LIKE ? OR `c8`.`last_login_ip` LIKE ? OR `c9`.`title` LIKE ? OR `c9`.`first_name` LIKE ? OR `c9`.`last_name` LIKE ? OR `c9`.`company` LIKE ? OR `c10`.`name` LIKE ?) ORDER BY `c8`.`username` ASC, `c14`.`position` LIMIT 20

[DC-135] Nested i18n versionable behaviour

Sun, 13 Dec 2009 15:37:50 +0000

Sorry to bring this up again (http://trac.doctrine-project.org/ticket/1708), but the current ALPHA 3 works perfectly on MySQL and fails on PostgreSQL. I tried the simple wiki example on a fresh project. I posted it already on google groups, but it seems this is the right place for that: http://groups.google.com/group/doctrine-user/browse_thread/thread/32208d921dffb8b3/63eb7337015f4415?show_docid=63eb7337015f4415

This is the generated postgresql sql file:

CREATE TABLE wiki_translation_version (id BIGINT, lang CHAR(2), title VARCHAR(255), content TEXT, version BIGINT, PRIMARY KEY(id, lang, version));
CREATE TABLE wiki_translation_index (id BIGINT, lang CHAR(2), keyword VARCHAR(200), field VARCHAR(50), position BIGINT, PRIMARY KEY(id, lang, keyword, field, position));
CREATE TABLE wiki_translation (id BIGINT, title VARCHAR(255), content TEXT, lang CHAR(2), version BIGINT, slug VARCHAR(255), PRIMARY KEY(id, lang));
CREATE TABLE wiki (id BIGSERIAL, created_at TIMESTAMP NOT NULL, updated_at TIMESTAMP NOT NULL, PRIMARY KEY(id));
CREATE UNIQUE INDEX sluggable ON wiki_translation (slug);
ALTER TABLE wiki_translation_version ADD CONSTRAINT wiki_translation_version_id_wiki_translation_id FOREIGN KEY (id) REFERENCES wiki_translation(id) ON UPDATE CASCADE ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE;
ALTER TABLE wiki_translation_index ADD CONSTRAINT wiki_translation_index_id_wiki_translation_id FOREIGN KEY (id) REFERENCES wiki_translation(id) ON UPDATE CASCADE ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE;
ALTER TABLE wiki_translation ADD CONSTRAINT wiki_translation_id_wiki_id FOREIGN KEY (id) REFERENCES wiki(id) ON UPDATE CASCADE ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE;

The error is:

SQLSTATE[42830]: Invalid foreign key: 7 FEHLER: in Tabelle »wiki_translation«, auf die verwiesen wird, gibt es keinen Unique Constraint, der auf die angegebenen Schlüssel passt. Failing Query: ALTER TABLE wiki_translation_version ADD CONSTRAINT wiki_translation_version_id_wiki_translation_id FOREIGN KEY (id) REFERENCES wiki_translation(id) ON UPDATE CASCADE ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE

It is in german but it means something like: there is no unique constraint in table 'wiki_translation' matching the given key.

Michael

[DC-141] Invalid fix [6568] for DC-132

Fri, 30 Oct 2009 16:57:30 +0000

Changeset [6568] looks incorrect, it always binds parameters as if they were positional thus not by name :MYPARAM. Therefore for queries with named parameters a PDO exception will be thrown.

Btw, I wanted to reopen Jira ticket ~~DC-132~~ for this, but how do I do that?

[DC-131] "Fatal error: [] operator not supported for strings" when use Apc Cache Driver with Doctrine 1.2.0 ALPHA 3

Fri, 23 Oct 2009 17:10:17 +0000

Fatal error: [] operator not supported for strings in /opt/httpd/lib/php/Doctrine/Cache/Driver.php on line 244

The fetch function return a string, not a array

I offer following modification :

File: Doctrine/Cache/Apc.php

public function fetch($id, $testCacheValidity = true)

{ $results = apc_fetch($this->_getKey($id)); //$results = (array) $results; // Drop this line //return $results[0]; // Drop this line return $results; // Add this line }

[DC-132] LOB mode not used for BLOB fields that are specified as a file handle

Sat, 24 Oct 2009 00:55:13 +0000

PDO provides us with the (highly desirable) possibility of providing the contents for a blob file through a filehandle resource, so the data can be read directly from a file or another stream source. When retrieving blob data from the database, I already get such file handle back. However, when creating of updating a record with a blob field using a filehandle, this fails. It fails because of two issues:

Doctrine_Validator::isValidType() rejects the resource handle, because blob fields are only checked using is_string().

$sth->execute($params) is used for executing a query after preparing it. The $params are provided straight away to the statement handle, without differentiating between field types by means of explicit bindings. An explicit binding with Doctrine::PARAM_PDO would be needed to allow for field data upload using a filehandle.

I have already been going over the code and I could not find a very good spot for handling this. What functionally should happen is that:

a blob field
for which a stream resource is set
should not be rejected as a valid blob type field and
should be bound as a param to the prepared insert/update query
using the data type Doctrine::PARAM_LOB

In the attached patch, I have updated the code in a way that makes this feature work. What I did feels like a hack, but I couldn't find a good way to implement this cleanly. The type of field that we are handling (blob or not?), the data that we are handling (resource or not?) and the spot where we can use bindParam() are not really tightly interconnected (or maybe they are and I overlooked it).

[DC-128] search is using default connection for query not the indexed table's connection

Mon, 2 Nov 2009 23:41:17 +0000

I'm using two databases with two connections, one of these only in one component of the project.

I used Doctrine_Manager::bindComponent to set the connection for the tables of the second database, and left the main database's connection as default.

The bug happens when I'm using search() in a searchable table of the second database. Doctrine_Search::search function uses the default connection when queries the index table, instead of the connection bound to the searchable table.

I attached a patch, which works for me.

[DC-126] Doctrine_Migration_Diff breaks on inherited class

Mon, 29 Mar 2010 13:29:07 +0000

This ticket is a duplicate of this one http://trac.symfony-project.org/ticket/7272 but it's more a Doctrine bug than a symfony one.

When trying to make a diff on schema with inheritance, the task breaks when trying to load a model inherited from an other one. I think this is because the inherited model might be loaded before his ancestor.

[DC-124] Doctrine_Inflector uses tabs in the class definition

Wed, 21 Oct 2009 14:35:29 +0000

Doctrine_Inflector uses tabs in the class definition

[DC-127] Allow a class prefix to be specified when calling Doctrine_Core::loadModels()

Mon, 2 Nov 2009 23:34:51 +0000

Doctrine allows you to generate class names such as Blog_Model_Post in Post.php, but Doctrine::loadModels() is not able to load these models conservatively, as the class name and file name differ.

I suggest adding a third parameter to Doctrine_Core::loadModels() to specify a class prefix, for example:

Doctrine_Core::loadModels('/modules/blog/models', Doctrine_Core::MODEL_LOADING_CONSERVATIVE, 'Blog_Model_');

Code changes (I think) would be something like this:

public static function loadModels($directory, $modelLoading = null, $classPrefix = null)
{
...
	$className = $e[0];
	
	if ($classPrefix) {
		$className = $classPrefix . $className;
	}
...
}

Since the argument is optional, this change shouldn't break any existing code.

NB: This is not PEAR-style file/class naming.

[DC-125] Searchable: batchUpdateIndex has a memory leak

Tue, 20 Oct 2009 17:45:59 +0000

batchUpdateIndex leaks memory when indexing a table. It holds onto a copy of every row it indexes in memory. I've attached a patch that fixes this issue.

[DC-119] [PATCH] fix timestamp format in documentation

Mon, 19 Oct 2009 20:49:35 +0000

[PATCH] fix timestamp format in documentation

[DC-116] getParent() works as getRoot() in NestedSet behavior

Mon, 2 Nov 2009 22:48:37 +0000

This is current version of getParent()

public function getParent()
    {
        $baseAlias = $this->_tree->getBaseAlias();
        $q = $this->_tree->getBaseQuery();
        $q->addWhere("$baseAlias.lft < ? AND $baseAlias.rgt > ?", array($this->getLeftValue(), $this->getRightValue()))
                ->addOrderBy("$baseAlias.rgt asc");
        $q = $this->_tree->returnQueryWithRootId($q, $this->getRootValue());
        $result = $q->execute();
        if (count($result) <= 0) {
            return false;
        }
               
        if ($result instanceof Doctrine_Collection) {
            $parent = $result->getFirst();
        } else if (is_array($result)) {
            $parent = array_shift($result);
        }
        
        return $parent;
    }

As you can see, this method does not have level limit in where clause. If tree have more than 2 levels in depth, method will return root node of the tree, not parent.

My fix is use level limit:

public function getParent()
    {
        $baseAlias = $this->_tree->getBaseAlias();
        $q = $this->_tree->getBaseQuery();
        $q->addWhere("$baseAlias.lft < ? AND $baseAlias.rgt > ?", array($this->getLeftValue(), $this->getRightValue()))
                ->addOrderBy("$baseAlias.rgt asc");
        $q->addWhere("$baseAlias.level >= ?", $this->record['level'] - 1);
        $q = $this->_tree->returnQueryWithRootId($q, $this->getRootValue());
        $result = $q->execute();
        if (count($result) <= 0) {
            return false;
        }
               
        if ($result instanceof Doctrine_Collection) {
            $parent = $result->getFirst();
        } else if (is_array($result)) {
            $parent = array_shift($result);
        }
        
        return $parent;
    }

PS. Sorry for my english.

[DC-112] Improve result cache

Reference — Fri, 23 Oct 2009 17:12:13 +0000

We need better control for setting the hash/key for resultset cache entries. Then provide a way to clear these cache entries.

http://trac.doctrine-project.org/ticket/2042

$temp = Doctrine_Query::create() 
->from('Profile p') 
->where('p.id=?', $o) 
->setHydrationMode(Doctrine::HYDRATE_ARRAY) 
->useResultCache(true, 3600, 'product_cache') // custom tag 
->execute(); 

$temp = Doctrine_Query::create() 
->from('Model m') 
->setHydrationMode(Doctrine::HYDRATE_ARRAY) 
->useResultCache(true, 3600, 'product_cache') // custom tag 
->execute(); 

$temp = Doctrine_Query::create() 
->from('News n') 
->setHydrationMode(Doctrine::HYDRATE_ARRAY) 
->useResultCache(true, 3600, 'news_cache') // custom tag 
->execute();

and now

$conn  = Doctrine_Manager::getConnection('sqlite_cache_connection'); 
$cacheDriver = new Doctrine_Cache_Db(array('connection' => $conn, 
'tableName' => 'cache')); 

$cacheDriver->deleteByTag('product_cache');

[DC-108] new Doctrine_Expression('NOW()') - now dont work

Wed, 14 Oct 2009 20:18:38 +0000

I always use this counstructions for get mysql current time:

example:
$us = Doctrine::getTable ( "Users" )->find ( 1 );
$us->currentlogin = new Doctrine_Expression('NOW()');
$us->save();

but after update to new version this DONT work!

[DC-105] notnull: false is ignored for integers with the mssql export

Wed, 14 Oct 2009 20:14:15 +0000

The following yml schema will result in a table with the integer field marked as not null

MyTable:
columns:
intfield:
type: integer
notnull: false

I have traced this back to line 244 in the getIntegerDeclaration function in lib/Doctrine/DataDict/Mssql.php

$notnull = (isset($field['notnull']) && $field['notnull']) ? ' NOT NULL' : '';

should be

$notnull = (isset($field['notnull']) && $field['notnull']) ? ' NOT NULL' : ' NULL';

This fixes the issue for us and hasn't created any problems thus far.

[DC-102] Fix issue with model builder and class prefix files still prefixing table class files

Mon, 12 Oct 2009 18:42:37 +0000

Fix issue with model builder and class prefix files still prefixing table class files

[DC-99] Formatting Foreign Key contraint with cross databases

Mon, 12 Oct 2009 19:12:54 +0000

This patch change the sign . to _ into the name of foreignKey because the name isn't valid with dot in the name.

[DC-101] Length of ForeignKey name in constraint parameter

Mon, 12 Oct 2009 21:04:01 +0000

If the name of ForeignKey constraint is too long, the sql insert failed on this.

I tested with this:
ALTER TABLE article_i18n_index ADD CONSTRAINT article_i18n_index_id_article_i18n_id FOREIGN KEY (id) REFERENCES article_i18n(id) ON UPDATE CASCADE ON DELETE CASCADE;

The article_i18n_index_id_article_i18n_id <-- this is too long

MySql 5.086
Doctrine 1.2 (last)

[DC-100] Patch to solve php fatal error bug in Class Table Inheritance code

Mon, 12 Oct 2009 19:01:49 +0000

Although I know the Class Table Inheritance code is unsupported it is somehow working good enough for me to use this feature anyway.

There is however a bug in the code when not defining column values on the parent object, which the attached small patch solves.

Could this be added before the 1.2 release ? Thanks

[DC-96] Add support for the SET datatype

Tue, 3 Nov 2009 05:19:34 +0000

Similar to the ENUM datatype, MySQL also invented the SET datatype. Emulation should be easily doable just like its currently done for ENUM.
http://dev.mysql.com/tech-resources/articles/mysql-set-datatype.html

[DC-95] support PEAR file/class naming conventions when generating model classes with a base class

Mon, 16 Nov 2009 18:01:24 +0000

Currently its not possible to generate base classes that are compatible with the PEAR file/class naming conventions
user -> user.php
base_user -> base/user.php

The following settings do not give the desired results
baseClassPrefix: "base_"
baseClassesDirectory: "base"

This seems like a very surprising, yet critical omission, which forces a symfony style autoloader instead of the Doctrine native autoloader.

[DC-91] Adjust file structure to make Doctrine more compatible with existing autoloaders via svn:externals

Mon, 12 Oct 2009 18:45:31 +0000

The Doctrine.php class makes it very hard to pull in Doctrine via svn:externals in combination with an existing autoloader. The problem is the Doctrine.php this means you usually end up with something like Doctrine/Doctrine.php locally, which means you need to use the Doctrine autoloader or add another include path.

One solution is to simply do two externals:
http://svn.doctrine-project.org/branches/1.2/lib/
http://svn.doctrine-project.org/branches/1.2/lib/Doctrine

And then including Doctrine.php manually.
The issue is of course that I cannot just do an external on the file because those only work on local repos. Svn also does not support sparse checkouts for externals.

I see 2 solutions:
1) Simple solution would be to provide a directory with just Doctrine.php via a separate url
2) Move the code in Doctrine.php to Doctrine/Core.php and just extend that class from Doctrine.php for BC

[DC-90] Proposal: add Doctrine_Record::setColumnOption() method (diff included)

Reference — Fri, 9 Oct 2009 19:42:06 +0000

We are generating our entity classes from the database. By doing so, we get a nicely separated set of base record classes and derived record classes where we can implement our logic. The case is, that we want to add validators to about every field there is. The only way that we can do that right now, is by overriding the setUp() method, calling parent::setUp() and providing new column definitions using addColumn(). By doing so, we do have to include the options that were so nicely automatically determined from the database. If we now update our schema in the db and regenerate the base record classes, we might have to manually update addColumn() calls in derived records.

To make it possible to fully separate the automatic and manual code, we were looking for a method to tweak an already existing table, but we couldn't find such method. Therefore, we implemented one ourselves.

A practial usage example. This is what we had to write in the derived class (not a validator example, but the idea is the same of course: tweak or add a column option):

    // Override the "info" column definition. We want this field to be
    // an object field, so we can store a serialized object in it.
    $this->hasColumn('info', 'object', null, array(
      'type' => 'object',
      'fixed' => false,
      'unsigned' => false,
      'notnull' => true,
      'primary' => false,
    ));

This is what we write now:

    $this->setColumnOption('info', 'type', 'object');

Please, consider adding the proposed change from the attached diff file. Of course, also let me know if there is a better way to handle this.

[DC-87] Import / export does not take into account the connection to the database

Fri, 30 Oct 2009 16:14:56 +0000

The mechanism of imports and exports does not include connection to the database. This creates many problems when we have multiple connections to the database and want to use a command to generate. (generateYamlFromDb or generateYamlFromModels or generateModelsFromDb or generateModelsFromYaml and other related methods)

Possible solution:

The file Doctrine/Import.php between lines 384 and 385 insert:
$definition['connection'] = $connection->getName();
$definition['connectionClassName'] = $definition['className'];

The file Doctrine/Export/Schema.php between lines 71 and 72 insert line:
$table['connection'] = $recordTable->getConnection()->getName();

[DC-86] NOW() doesn't work in Sqlite driver

Tue, 13 Oct 2009 04:45:17 +0000

The problem is concerned about sqlite driver. Currently in every occurence of "NOW()" in where clause PDO substitutes result of PHP time() function. Here is a cause:

            $this->dbh->sqliteCreateFunction('now', 'time', 0);

Unfortunatelly, sqlite expects a datetime value rather then integer timestamp.

In result, every occurence of 'now()' in where clause is treated as '0'.

I have prepared a testcase and patch.

[DC-79] Unexpected exception type when saving a relation with an invalid model in it

Fri, 9 Oct 2009 21:15:56 +0000

When creating two related models and saving the main one to the database, both models get stored in the database. That is expected behavior. Now, when one of the two models has a validation problem and I call save() on it - without first linking it to the other model - I get a Doctrine_Validator_Exception. That is expected behavior. Now (patience, we're getting to the bug now), when one or both of the models has a validation problem and I link them prior to saving them, I don't get a Doctrine_Validator_Exception, but instead a database level exception Doctrine_Connection_Pgsql_Exception. That is unexpected behavior.

One wouldn't notice this issue when doing code like:

  try {
    $object->save();
  } catch (Exception $e) {
    // .. handle the exception
  }

However, code like we are using it in our project more often looks like this:

  try {
    $object->save();
  } catch (Doctrine_Validator_Exception $e) {
    // .. handle the validation exception
  } catch (One_Of_Our_Exception $e) {
    // .. handle our exception
  } catch (Exception $e) {
    throw $e; // unexpected exception, re-throw and pray 
  }

In the attachment you find a test.yml and a test.php that I used for figuring out the behavior. Here's the output from running the test script:

1. OK, got expected exception
2. OK, record A saved
3. OK, got expected exception
4. OK, record B saved
5. OK, record A saved with a linked record B
6. Error: unexpected exception was thrown.
   Type: Doctrine_Connection_Pgsql_Exception
   Message: SQLSTATE[23502]: Not null violation: 7 ERROR:  null value in column "b_id" violates not-null constraint
7. Error: unexpected exception was thrown.
   Type: Doctrine_Connection_Pgsql_Exception
   Message: SQLSTATE[23502]: Not null violation: 7 ERROR:  null value in column "a_id" violates not-null constraint
8. Error: unexpected exception was thrown.
   Type: Doctrine_Connection_Pgsql_Exception
   Message: SQLSTATE[23502]: Not null violation: 7 ERROR:  null value in column "a_id" violates not-null constraint

Inspecting the Connection/UnitOfWork.php code, I see that saveGraph() calls $isValid = $this->insert($record). Now, when insert() sees that the record is invalid, it returns a false value. Somewhat later this results in calling $conn->transaction->addInvalid($record) to register the problem. At the end of the code block, I find (around line 126):

                // save the MANY-TO-MANY associations
                $this->saveAssociations($record);

That is the point where things break. Even when an associated record does not validate, saveAssociations() will be called, resulting in a db level error about a reference id not being set (logical, since the related record was not saved and did not get an id assigned to it).

In my opinion, this shouldn't happen, but I'm only using Doctrine for one day, so if I am missing some important piece of knowledge or documentation here, then please let me know.

[DC-84] Migration automation methods break with tables and fks on the same migration class

Tue, 13 Oct 2009 03:44:14 +0000

Hello,

Currently if within a single migration class one uses the automation methods $this->table() and $this->foreignKey() the process will fail when moving down because the system will execute the down direction in the same order as the up direction. For example:

public function migrate($direction) {
$this->table($direction, 'mytable', ...);
$this->table($direction, 'myrelatedtable', ... );
$this->foreignKey($direction, 'mytable', 'myfkname', ...);
}

Going up, everything is fine. The tables are created and the FK is applied. Going down, however will error out since by the time the FK is going to be removed the table it belons to is gone.

[DC-77] Query-Parameters are not correctly Replaced if you count() a Limited Query with a Many-to-Many join

Reference — Sun, 22 Nov 2009 13:45:28 +0000

The same issue is already was already mentioned in the Trac-Ticket-System (#1579)

I was able to reproduce this issue with the following schema:

schema.yml

sfGuardUser:
  tableName: user
  columns:
    id:
      name: user_id as id
      type: integer(4)
      primary: true
      autoincrement: true
    username:
      name: user_login as username
      type: string(25)
      notnull: true
  relations:
    Permissions:
      class: sfGuardPermission
      local: user_id
      foreign: role_id
      refClass: sfGuardUserPermission
      foreignAlias: Users

sfGuardUserPermission:
  tableName: user_role
  columns:
    user_id:
      type: integer(4)
      notnull: true
      primary: true
    permission_id:
      name: role_id as permission_id
      type: integer(4)
      notnull: true
      primary: true
  relations:
    sfGuardUser:
      local: user_id
    sfGuardPermission:
      local: permission_id

sfGuardPermission:
  tableName: role
  columns:
    id:
      name: role_id as id
      type: integer(4)
      primary: true
      autoincrement: true
    name:
      name: role_token as name
      type: string(255)
      default: ''
      notnull: true
      unique: true;

The failing Query looks like this:

Doctrine_Query::create()->
       from('sfGuardUser u')->
       leftJoin('u.Permissions p')->
       where('u.username LIKE ?', array(3, '%a%'))->
       limit(10)->
       count();

And that's the resulting Error:

Doctrine_Connection_Mysql_Exception: SQLSTATE[42000]: Syntax error or access violation: 1064 
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version 
for the right syntax to use near '? LIMIT 10' at line 1 in 
/home/mkr/Projects/doctrine_count/Doctrine-1.0.12-Sandbox/lib/Doctrine/Connection.php on line 1086

As you can see, the Where-Parameter is not replaced correctly, The SQL-Query is executed in Line 1153 of Query.php, but $params does not contain the Query-Parameters, as it should be.

Query.php

// mysql doesn't support LIMIT in subqueries
$list = $this->_conn->execute($subquery, $params)->fetchAll(Doctrine::FETCH_COLUMN);
$subquery = implode(', ', array_map(array($this->_conn, 'quote'), $list));

You can also check my Post in the symfony-forum for details

[DC-82] Conditional unique validator and index

Tue, 13 Oct 2009 04:56:59 +0000

Doctrine currently doesn't support conditional unique keys. One commonly happening situation is when we have a model with a column (eg. named "deleted") indicates whether the record was deleted and should no longer be treated as active. If we have an unique index on a "name" column, the index should contain only records with deleted = false. It also concerns an unique validation.

I have prepared a patch for Doctrine_Validator_Unique and Doctrine_Export_Pgsql (Postgresql natively supports conditional indexes).

Example of usage:

public function setTableDefinition()
{
  $this->hasColumn('id', 'integer', 4, array('primary' => true, 'autoincrement' => true, 'sequence' => 'model_id_seq'));
  $this->hasColumn('name', 'string', 128, array('notnull', 'unique' => array('where' => 'deleted = false')));
  $this->hasColumn('deleted', 'boolean', 1, array('notnull', 'default' => false));
  $this->index('model_unique_name', array('fields' => array('name'), 'where' => 'deleted = false', 'type' => 'unique' ));
}

[DC-76] [PATCH] The interface Doctrine_Record_Listener_Interface does not define all the required methods to create custom listeners.

Fri, 9 Oct 2009 21:10:01 +0000

The Doctrine_Record_Listener_Interface is no longer up to date with the code base. The code base expects the listener to implement a getOption method which is not available on my listener models... See the patch file.

[DC-74] Condition of STATE_PROXY should be checked dynamically, not as a static state value

Mon, 2 Nov 2009 22:34:10 +0000

This issue is continuation of issue #2488 from Trac. I have prepared Test case showing that the problem is seriously. Below original content.

A record gets STATE_PROXY state at hydration when its properties are not fully loaded. Here is a condition (placed in Doctrine_Record::hydrate()):

if ( ! $this->isModified() && count($this->_values) < $this->_table->getColumnCount()) {
   $this->_state = self::STATE_PROXY;
}

But at first setting a column value (whatever if the column value was loaded or not), the record gets STATE_DIRTY and "forgets" its proxy state.

In effect a call to any not loaded column of the record causes returning null value. It should, of course, load remaining column values and change record state from STATE_PROXY to STATE_DIRTY. It doesn't load because current record state is already STATE_DIRTY.

I'm attaching a patch, which fixes Doctrine_Record::load() in the described situation.

In my opinion usage of STATE_PROXY must be rethinked. STATE_PROXY can mean:
1. STATE_CLEAN + not fully loaded columns (proxy)
2. STATE_DIRTY + not fully loaded columns (proxy)

Currently it only points the first situation so there is not way to identify the second situation (and it is silently ignored).

[DC-72] DQL Auto generated column aliases cause "ORA-00972: identifier is too long" on Oracle

Thu, 18 Nov 2010 10:38:02 +0000

Hi,

I have an existing Oracle DB that has some tables with column names that have 28-30 characters (30 characters is the maximum identifier
length with Oracle).

I have created a YAML schema for the tables I want to query via DQL in this database and generated the models.

When I run a DQL that selects some of the columns whose names are 28-30 characters in length, I receive an "ORA-00972: identifier is too long" error from Oracle.

After some investigation, I found that Doctrine_Query is auto generating aliases for these columns that are more than 30 characters in length. In a nutshell, it appears that Doctrine_Query generates the alias by taking a single character for the table alias, plus two underscores, plus the column name (for example, t__alongerthanusualtablecolumnx).

If the original column name was 28-30 characters in length, then the additional 3 characters exceed the 30 character identifier limit. If more tables are joined in the query, you can end up with longer table aliases (t0, t1, ... t10, etc) and the problem will affect tables with column names less than 28 characters in length as well.

I worked around this problem by patching Doctrine_Query and Doctrine_Hydrator to use the numerical column indexes from the table definition instead of the column name when auto generating aliases.

Attached is a patch for my workaround. I doubt it's the best way to fix this, but it should help to exemplify what is happening.

Thanks,

Jamie

[DC-68] When exporting model to SQL, Doctrine generates erroneous constraint name for table name with schema

Tue, 13 Oct 2009 03:51:55 +0000

For example, for a foreign key from user.group_id -> group.id in a schema "main" - with explicite specified the schema name in the table names (main.user, main.group) - Doctrine generates a constraint name "main.user_group_id_main.group_id". Unfortunately, "." is reserved char and is illegal in a constraint name.

[DC-65] Add documentation for Doctrine::ATTR_HYDRATE_OVERWRITE

Tue, 3 Nov 2009 20:14:55 +0000

Maybe this sould be added somewhere in docs (since there's nothing about that in 1.1's)

$manager->setAttribute(Doctrine::ATTR_HYDRATE_OVERWRITE, false);

[DC-62] decimal fields are rounded to 6 decimal places on save()

Wed, 14 Apr 2010 17:03:42 +0000

Decimal fields with high precision are rounded down to 6 decimal places prior to inserting into database on Doctrine_Record->save()

For example,
if you define a column to represent decimal numbers with 12 digits following the decimal:

MySet:
columns:
p_value:

{ type: decimal(18), scale: 12 }

Then create a new doctrine record object and save:

$record = new MySet();
$record['p_value'] = 5.012345678912;
$record->save();

The value in the database at this point has been rounded down to 6 decimal places:
value = 5.012346000000

print_r($record->toArray()) shows the correct value to 12 decimal places

[DC-59] Setting MYSQL_ATTR_USE_BUFFERED_QUERY forces a connection

Thu, 24 Sep 2009 19:25:51 +0000

Ticket reference: http://trac.doctrine-project.org/ticket/2449

To set this PDO attribute, one needs to use: $masterConn->getDbh()->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);

Forcing a call to getDbh() forces the connection to be established. This isn't desirable from a performance point of view.

The normal mode of operation: $masterConn->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);

can't be used because PDO::MYSQL_ATTR_USE_BUFFERED_QUERY is equal to 1000, and is > than the arbitrary constant check that doctrine has used (doctrine constants are 100-172). Doctrine then calls parent::setAttribute() on Configurable.php

The overuse of setAttribute seems to be at fault here. It seems dangerous to mix the constant space between the PDO constants and Doctrine ones. The quick fix is to add a > 100 && < 1000 in the conditional, which will fix these MySQL constants, but there are PDO constants all over the place. I'm attaching a simple patch to reserve 100-999 for Doctrine, and move 1000+ back into PDO space.

Here's a dump of the PDO constants in my PHP 5.2.4:

Array (

[PARAM_BOOL] => 5 [PARAM_NULL] => 0 [PARAM_INT] => 1 [PARAM_STR] => 2 [PARAM_LOB] => 3 [PARAM_STMT] => 4 [PARAM_INPUT_OUTPUT] => -2147483648 [PARAM_EVT_ALLOC] => 0 [PARAM_EVT_FREE] => 1 [PARAM_EVT_EXEC_PRE] => 2 [PARAM_EVT_EXEC_POST] => 3 [PARAM_EVT_FETCH_PRE] => 4 [PARAM_EVT_FETCH_POST] => 5 [PARAM_EVT_NORMALIZE] => 6 [FETCH_LAZY] => 1 [FETCH_ASSOC] => 2 [FETCH_NUM] => 3 [FETCH_BOTH] => 4 [FETCH_OBJ] => 5 [FETCH_BOUND] => 6 [FETCH_COLUMN] => 7 [FETCH_CLASS] => 8 [FETCH_INTO] => 9 [FETCH_FUNC] => 10 [FETCH_GROUP] => 65536 [FETCH_UNIQUE] => 196608 [FETCH_KEY_PAIR] => 12 [FETCH_CLASSTYPE] => 262144 [FETCH_SERIALIZE] => 524288 [FETCH_PROPS_LATE] => 1048576 [FETCH_NAMED] => 11 [ATTR_AUTOCOMMIT] => 0 [ATTR_PREFETCH] => 1 [ATTR_TIMEOUT] => 2 [ATTR_ERRMODE] => 3 [ATTR_SERVER_VERSION] => 4 [ATTR_CLIENT_VERSION] => 5 [ATTR_SERVER_INFO] => 6 [ATTR_CONNECTION_STATUS] => 7 [ATTR_CASE] => 8 [ATTR_CURSOR_NAME] => 9 [ATTR_CURSOR] => 10 [ATTR_ORACLE_NULLS] => 11 [ATTR_PERSISTENT] => 12 [ATTR_STATEMENT_CLASS] => 13 [ATTR_FETCH_TABLE_NAMES] => 14 [ATTR_FETCH_CATALOG_NAMES] => 15 [ATTR_DRIVER_NAME] => 16 [ATTR_STRINGIFY_FETCHES] => 17 [ATTR_MAX_COLUMN_LEN] => 18 [ATTR_EMULATE_PREPARES] => 20 [ATTR_DEFAULT_FETCH_MODE] => 19 [ERRMODE_SILENT] => 0 [ERRMODE_WARNING] => 1 [ERRMODE_EXCEPTION] => 2 [CASE_NATURAL] => 0 [CASE_LOWER] => 2 [CASE_UPPER] => 1 [NULL_NATURAL] => 0 [NULL_EMPTY_STRING] => 1 [NULL_TO_STRING] => 2 [ERR_NONE] => 00000 [FETCH_ORI_NEXT] => 0 [FETCH_ORI_PRIOR] => 1 [FETCH_ORI_FIRST] => 2 [FETCH_ORI_LAST] => 3 [FETCH_ORI_ABS] => 4 [FETCH_ORI_REL] => 5 [CURSOR_FWDONLY] => 0 [CURSOR_SCROLL] => 1 [MYSQL_ATTR_USE_BUFFERED_QUERY] => 1000 [MYSQL_ATTR_LOCAL_INFILE] => 1001 [MYSQL_ATTR_INIT_COMMAND] => 1002 [MYSQL_ATTR_READ_DEFAULT_FILE] => 1003 [MYSQL_ATTR_READ_DEFAULT_GROUP] => 1004 [MYSQL_ATTR_MAX_BUFFER_SIZE] => 1005 [MYSQL_ATTR_DIRECT_QUERY] => 1006

)

[DC-56] Geographical behavior does not calculate distance

Mon, 1 Mar 2010 16:12:04 +0000

If the fields name of the latitude or longitude invoker aren't 'latitude' or 'longitude', then the getDistanceQuery doesn't not work.

milesSql = sprintf($sql, $invoker->get('latitude'), $invoker->get('latitude'), $invoker->get('longitude'), '1.1515', 'miles');
...
$kilometersSql = sprintf($sql, $invoker->get('latitude'), $invoker->get('latitude'), $invoker->get('longitude'), '1.1515 * 1.609344', 'kilometers');

Replacing latitude by $latName (previously defined line 74 and 75) resolved this problem.

Here's the fix :

milesSql = sprintf($sql, $invoker->get($latName), $invoker->get($latName), $invoker->get($longName), '1.1515', 'miles');
...
$kilometersSql = sprintf($sql, $invoker->get($latName), $invoker->get($latName), $invoker->get($longName), '1.1515 * 1.609344', 'kilometers');

[DC-52] generated models don't call parent setUp() method

Thu, 24 Sep 2009 16:48:53 +0000

When Doctrine Importer is used to generate models from a database, the setUp() methods of the generated models do not always call their parent setUp(). This may not be important when generated models extend Doctrine_Record directly, but it is is important when a baseClassName is specified to generateModelsFromDb() and the custom base class provides a setUp() method.

The attached patch causes parent::setUp() to be called whenever a setUp() method is created in a generated model.

[DC-57] isValueModified returns true for timestamps that appear different but are equal

Mon, 15 Feb 2010 11:20:45 +0000

Doctrine_Record::isValueModified compares timestamps as strings and values that are equal such as 2009-09-02 00:00:00 and 2009-09-02 are treated as modified.

The code should do a second compare on the strtotime value if the strings appear to be unequal.

[DC-53] Type "double" issue with ValidateLenght

Thu, 24 Sep 2009 16:50:27 +0000

LenghtValidator? doesn't check by the same way the "double" type.

Validator.php (line: 95)

} else if ($type == 'decimal' $type == 'float') { By:

} else if ($type == 'decimal' || $type == 'float' || $type == 'double') {

[DC-48] Duplication of join conditions in query when using Doctrine_Pager (or count() and limit() query methods)

Thu, 24 Sep 2009 19:15:58 +0000

When using count() method of some query and then executing this query with limit(), in generated sql appeared duplucated join conditions, what causes
Doctrine_Connection_Mysql_Exception: SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens in /home/test/doctrine/database/doctrine/lib/Doctrine/Connection.php on line 1084

Query should have at least one join with "WITH" clause.
Same problem when using PostgreSQL.

Ticket in TRAC

Attached php script that reproduces error and dump of test db

[DC-54] Unique Validator fails with PK column aliased

Thu, 24 Sep 2009 16:51:27 +0000

Similar to http://trac.doctrine-project.org/ticket/2046, Doctrine_Validator_Unique can fail when the PK for the table is aliased.

The error occurs in the following scenario:

A record has a column with the unique validator (unique:true) and a PK column aliased to a different name
All validation is turned on
An instance of that record is loaded from the database.
The unique field value is modified and isValid is called on the record

The validator will attempt to get the PK value from the record by using the column name rather than the field name, resulting in an 'Unknown record property' exception.

I've attached a patch that offers a resolution for this issue by using the table's getFieldName method with the column name.

[DC-46] Unexpected behavior with whereIn() and empty array

Tue, 5 Oct 2010 05:02:27 +0000

See trac #2064 ( http://trac.doctrine-project.org/ticket/2064 )

Jwage wrote "This is expected behavior. We cannot and will not add a fake invalid condition to the where string. I think we need to make it throw an exception if you try and pass an empty array."

I agree that an exception should be thrown.

But AFAIK this hasn't been implemented yet.

The issue is quite urgent in my opinion. Example:

I had a query where I absolutely had to restrict the result set to allowed objects (IDs) only. I used a whereIn() condition for this restriction.

Problem is: when the user wasn't assigned to any groups, the id-array was empty, and Doctrine removed the WHERE ... IN completely! That resulted in a result set containing all records!

I would expect

either to return no records (correct behavior could be to add "0=1" as a replacement for "... IN ()" expression)
or let the database decide (= submitting the query with an empty list which would result - at least for MySQL - in a database exception)
or Doctrine could throw an exception

Would IMO be way better (as its IMO a more expected behavior) than simply not adding the "... IN ()" to the query.

[DC-569] Duplicate unique indexes on PostgreSQL

Mon, 15 Mar 2010 15:32:01 +0000

Generated by doctrine-cli SQL is:

– this is ok
CREATE TABLE "image" ("id" BIGSERIAL, "alt" VARCHAR(255), "title" VARCHAR(500), "filename" VARCHAR(255), "width" BIGINT, "height" BIGINT, "slug" VARCHAR(255), "createdat" TIMESTAMP NOT NULL, "updatedat" TIMESTAMP NOT NULL, PRIMARY KEY("id"));
CREATE TABLE "news" ("id" BIGSERIAL, "title" VARCHAR(255), "leadmarkup" VARCHAR(500), "leadhtml" VARCHAR(600), "bodymarkup" TEXT, "bodyhtml" TEXT, "slug" VARCHAR(255), "createdat" TIMESTAMP NOT NULL, "updatedat" TIMESTAMP NOT NULL, PRIMARY KEY("id"));
CREATE TABLE "snippet" ("id" BIGSERIAL, "name" VARCHAR(255), "bodymarkup" TEXT, "bodyhtml" TEXT, "slug" VARCHAR(255), "createdat" TIMESTAMP NOT NULL, "updatedat" TIMESTAMP NOT NULL, PRIMARY KEY("id"));
– this causes error
CREATE UNIQUE INDEX "sluggable" ON "image" ("slug");
CREATE UNIQUE INDEX "sluggable" ON "news" ("slug");
CREATE UNIQUE INDEX "sluggable" ON "snippet" ("slug");

After importing this to PostgreSQL, I get 'index already exists' error.

On PostgreSQL unique indexes names must not be the same.
I think the correct form should be:
CREATE UNIQUE INDEX "sluggable-image" ON "image" ("slug");
CREATE UNIQUE INDEX "sluggable-news" ON "news" ("slug");
CREATE UNIQUE INDEX "sluggable-snippet" ON "snippet" ("slug");

Schema file attached.

[DC-568] Make it possible to use microtime as the version value when using Versionable

Mon, 15 Mar 2010 10:47:56 +0000

This patch basically makes it possible to pass in a custom auditlog listener as well as providing a new listener that uses microtime to generate the version value's instead of incrementing an integer value starting at 1. This should provide a much better handling for concurrent inserts and should also be faster, since for all but the first version a complex select is necessary in the current implementation.

Open question is if the accuracy multiplier should be an option or not. Also is there any reason why the column definition doesnt default to an unsigned, not that it matters all that much?

[DC-567] RawSql: getCountSqlQuery does not work correctly with PostgreSQL (patch provided)

Mon, 15 Mar 2010 10:33:14 +0000

Dears,

Line 309 in Doctrine_RawSql:

        $q = 'SELECT COUNT( DISTINCT '.implode(',',$fields).') as num_results';

        $string = $this->getInheritanceCondition($this->getRootAlias());
        if ( ! empty($string)) {
            $this->_sqlParts['where'][] = $string;
        }

        $q .= ( ! empty($this->_sqlParts['from']))?    ' FROM '     . implode(' ', $this->_sqlParts['from']) : '';
        $q .= ( ! empty($this->_sqlParts['where']))?   ' WHERE '    . implode(' AND ', $this->_sqlParts['where']) : '';
        $q .= ( ! empty($this->_sqlParts['groupby']))? ' GROUP BY ' . implode(', ', $this->_sqlParts['groupby']) : '';
        $q .= ( ! empty($this->_sqlParts['having']))?  ' HAVING '   . implode(' AND ', $this->_sqlParts['having']) : '';

produces with PostgreSQL: Undefined function: 7 ERROR: function count(bigint, integer) does not exist

but

        $q = 'SELECT COUNT(*) as num_results FROM (SELECT DISTINCT '.implode(', ',$fields);

        $string = $this->getInheritanceCondition($this->getRootAlias());
        if ( ! empty($string)) {
            $this->_sqlParts['where'][] = $string;
        }

        $q .= ( ! empty($this->_sqlParts['from']))?    ' FROM '     . implode(' ', $this->_sqlParts['from']) : '';
        $q .= ( ! empty($this->_sqlParts['where']))?   ' WHERE '    . implode(' AND ', $this->_sqlParts['where']) : '';
        $q .= ( ! empty($this->_sqlParts['groupby']))? ' GROUP BY ' . implode(', ', $this->_sqlParts['groupby']) : '';
        $q .= ( ! empty($this->_sqlParts['having']))?  ' HAVING '   . implode(' AND ', $this->_sqlParts['having']) : '';

        $q .= ') as results';

works and should work with every database server.

Continue your great work

Regards,

Raphaël Dehousse

[DC-566] Misleading documentation on autoloading models

Mon, 15 Mar 2010 15:56:13 +0000

I think the following lines in "Introduction to Models" on conservative loading (http://www.doctrine-project.org/documentation/manual/1_2/en/introduction-to-models#autoloading-models) are misleading.

When we use the Doctrine_Core::loadModels() functionality all found classes will be cached internally so the autoloader can require them later.

[...]

Instantiating the class above triggers a call to Doctrine_Core::autoload() and the class that was found in the call to Doctrine_Core::loadModels() will be required and made available.

It's not enough to register Doctrine_Core::autoload() as autoload callback, because it does not care about the model classes. I think you should mention that Doctrine::modelsAutload is the right callback method for dealing with model class autoloading.

[DC-564] Postgresql: listSequences: relname badly "formatted" (patch provided)

Mon, 15 Mar 2010 15:13:01 +0000

Dears,

Let's say you create your database first. If you have a serial/bigserial, a sequence is automaticaly created. It's called for example: 'id_seq'
During the cretion of the model, the sequence name is, so, called id_seq.

But in Doctrine_Formatter, line 233, you have getSequenceName that format Doctrine_Core::ATTR_SEQNAME_FORMAT that comes from Doctrine_Manager line 143, you have Doctrine_Core::ATTR_SEQNAME_FORMAT => "%s_seq", so, the sequence name will wrongly be id_seq_seq.

This could be avoid if the sequence_name would not contain the "_seq" suffix coming from the import. WDYT?

This could be possible thanks to a change in Doctrine_Import_Pgsql, line 50:

'listSequences' => "SELECT
        rtrim(relname, '_seq')
    FROM
        pg_class
    WHERE relkind = 'S' AND relnamespace IN
        (SELECT oid FROM pg_namespace
        WHERE nspname NOT LIKE 'pg_%' AND nspname != 'information_schema')",

So, rtrim(relname, '_seq') in place of relname only.
I'm not sure rtrim is the best solution but you got what I meant.

Voilà my 2 cents.

Hope it will help

Best regards,

Raphaël Dehousse

[DC-563] Import/Pgsql: listTableRelations: bad use of strpos search composite foreign keys (patch provided)

Mon, 15 Mar 2010 14:36:59 +0000

Dears,

First, I would like to thank you for your great work.

Second, the bug:

Line ~279 in the function listTableRelations, there is a mistake in the use of strpos : strpos(',', $values[1]) and strpos(',', $values[3]), it should be strpos($values[1], ',') and strpos($values[2], ',')

With this code, strpos always returns false and so, the composite foreign keys are not skipped as desired.

Continue your great job

Regards,

Raphaël Dehousse

[DC-556] Index name error

Mon, 15 Mar 2010 15:29:45 +0000

At this moment, if you have more than one table that is sluggable, it get an error cause tries to set the very same name to ALL sluggable indexes. Here is a fix:

#55: 'indexName' => null

#74: if($this->_options['indexName'] === null)
#75: $this->_options['indexName'] = $this->getTable()- >getTableName().'_sluggable';

[DC-555] infinite recursion happens when saving models with circular reference

Mon, 15 Mar 2010 16:09:54 +0000

After upgrading symfony from 1.2 to 1.4, my website began to have problems saving some models. After some research, I found that it was caused by infinite recursion. Let's say Model A has many B (B belongs to A). Each A also points to one of the B objects it owns. So it's a circular reference. Some ppl might argue that it's not a good pratice to have circular reference in the data model, I agree. But it worked fine in Doctrine 1.0, so I prefer not to change it. In Doctrine 1.2.1, it seems that when A and its related B are both modified (dirty), if I try to save A, Doctrine will try to save B due to cascade update, and when saving B, it will again try to save its related A ...

I compared the source code of Doctrine_Connection_UnitOfWork between 1.0 and 1.2.1, and found out that in Doctrine 1.2.1, the model is no longer locked when saveRelatedLocalKeys is invoked. I don't understand this change. After I changed the line "$this->saveRelatedLocalKeys($record);" to

$record->state($record->exists() ? Doctrine_Record::STATE_LOCKED : Doctrine_Record::STATE_TLOCKED);
$this->saveRelatedLocalKeys($record);
$record->state($state);

my website returned to normal again. And so far i haven't found any problem caused by my change

So I hope someone can look into this and let me know if my change is safe. Or if I'm wrong, is there any way I can get around the infinite recursion problem without changing my database schema? Thanks.

[DC-550] Cannot update record from one large integer to another large integer (severe problem for 32bit systems, due to the low upper limit of the int data type)

Mon, 15 Mar 2010 14:14:20 +0000

From what I understand, doctrine mostly stores integers as strings. To check whether an integer has been modified, the following code in Doctrine_Record is used:

    protected function _isValueModified($type, $old, $new)
    {
        if ($new instanceof Doctrine_Expression) {
            return true;
        }

        if ($type == 'boolean' && (is_bool($old) || is_numeric($old)) && (is_bool($new) || is_numeric($new)) && $old == $new) {
            return false;
        } else if (in_array($type, array('decimal', 'float')) && is_numeric($old) && is_numeric($new)) {
            return $old * 100 != $new * 100;
        } else if (in_array($type, array('integer', 'int')) && is_numeric($old) && is_numeric($new)) {
            return (int) $old !== (int) $new;  # <--- ********** THIS LINE CASTS STRING TO INT **********
        } else if ($type == 'timestamp' || $type == 'date') {
            return strtotime($old) !== strtotime($new);
        } else {
            return $old !== $new;
        }
    }

On the line indicated above an integer, stored as a string, is cast to a PHP integer data type, and compared with the existing value of the field currently stored in the database. For values that fall within the int type range, this works fine. However, when changing a value falling above the range, which on 32bit systems is 2147483647, to another value falling above the range, these casts cause the code to evaluate both as 2147483647 and hence the field is not added to the _IsModified() array, and the value is not updated.

Bearing in mind that validation to confirm whether these strings are in numeric format should already have occurred by this point in the process, is there any need to cast the strings at all? Thus, is the following a possible solution?

            return $old !== $new;

This seems to work fine for me in my limited trials although, admittedly, there may be some consequences about which I am not aware.

Note that this issue is not so evident on 64bit systems, where the upper limit is much higher.

[DC-545] MSSQL Server: Inserting blank records throws exception / Invalid casting of bound query parameters in sub-selects.

Mon, 15 Mar 2010 10:46:14 +0000

I've two issues with saving records with SQL Server.

Firstly, SQL Server does not allow NULL or DEFAULT values to be used against identity columns. When inserting a record without any modified fields, Doctrine_Record_UnitOfWork::processSingleInsert sets all fields to NULL - including the identity columns. This causes this error:

"SQLSTATE[42000]: Syntax error or access violation: 339 [Microsoft][SQL Server Native Client 10.0][SQL Server]DEFAULT or NULL are not allowed as explicit identity values"

Ideally identity columns could be excluded but that would break tables that consist of those columns. Instead I've patched Doctrine_Connnection_MSSQL to, in this 'blank insert' circumstance only, insert default values and then update the inserted row with null values as necessary (the latter may be unnecessary but I wanted to preserve the original behaviour).

Secondly, there exists a bug in (as I understand it) Microsoft's ODBC driver [1], that causes all bound parameters within a sub-select to be cast as strings before being interpreted by SQL Server. This results in the following error:

SQLSTATE[22018]: Invalid character value for cast specification: 206

[1] http://bugs.php.net/36561

When using SQL Server through ODBC all Doctrine queries that use sub-selects are failing, for example the query generated by a Doctrine_Table->find()

SELECT * FROM (SELECT TOP 1 * FROM (SELECT TOP 1 [m].[id] AS [m__id], [m].[name] AS [m__name] FROM [model] [m] WHERE ([m].[id] = ?)) AS [inner_tbl]) AS [outer_tbl]

To combat this I've extended the Doctrine_Connection_Common execute() method in Doctrine_Connection_Mssql to replace bound parameters so they're inline instead. This has its drawbacks, like reduced protection against SQL injection, but since the alternative is the majority of my queries failing I don't see a better option.

I realise this second issue isn't a Doctrine concern per se, but I thought I'd bring it up since I imagine anyone using SQL server will be experiencing it.

A patch against 1.2.1 is attached. This patch also incorporates the latest patch in http://www.doctrine-project.org/jira/browse/DC-289, which has now been committed to trunk; my additions are at the bottom of the file.

[DC-535] Fixtures loaded in the wrong order

Dependency — Tue, 2 Mar 2010 13:01:19 +0000

I can't no more load my fixtures,
it's seem that Doctrine connection->unitOfWork->buildFlushTree() screw up the Model relation ordering, because some of my fixtures are loaded to soon (and I have a constrain fail).
There is nothing strange about my fixtures / models, I even don't change anything for days (and that worked perfectly fine yesterday).

I've tried to use

doctrine http://doctrine.mirror.svn.symfony-project.com/tags/1.2.1/lib/

instead of

doctrine http://doctrine.mirror.svn.symfony-project.com/branches/1.2/lib

in my lib/vendor/symfony/plugins/sfDoctrinePlugin/lib/vendor svn:externals, and the problem disapear.

Perhaps a bug as been introduced in the 1.2 branche ?

[DC-528] CLONE -isValueModified returns true for timestamps that appear different but are equal

Tue, 2 Mar 2010 13:26:59 +0000

This is a copy of DC57:

"Doctrine_Record::isValueModified compares timestamps as strings and values that are equal such as 2009-09-02 00:00:00 and 2009-09-02 are treated as modified.

The code should do a second compare on the strtotime value if the strings appear to be unequal."

The changes made with this ticket causes problems with old timestamps because of strtotimes behaviour with dates before beginning of unix-period. I attached a diff for the original testcase to demonstrate the problem.

[DC-522] Can not use charset and collate in a table basis when using global charset and collate in Doctrine_Manager

Mon, 15 Mar 2010 14:18:56 +0000

Can not use charset and collate in a table basis when using global charset and collate in Doctrine_Manager.

When using + symfony:

ProjectConfiguration.class.php

public function configureDoctrine(Doctrine_Manager $manager)
  {
    $manager->setCharset('utf8');
    $manager->setCollate('utf8_bin');
  }

And some schema like,

schema-page.yml


PageIndex:
  tableName:                           t_page_index
  columns:
    id:                                { type: integer  , length: 20 , primary: true    , autoincrement: true                                                  }
    title:                             { type: string   , length: 200                   , notnull: true                                                        }
  options:
    collate:                           utf8_general_ci

When generating the database, the table will have as collate utf8_bin, not being possible overwriting it at a table level.

This is because:

Table.class.php

public function __construct($name, Doctrine_Connection $conn, $initDefinition = false)
    {
        $this->_conn = $conn;
        $this->_options['name'] = $name;
        
        $this->setParent($this->_conn);           
        $this->_conn->addTable($this);
        
        $this->_parser = new Doctrine_Relation_Parser($this);
        
        if ($initDefinition) {
            $this->record = $this->initDefinition();

            $this->initIdentifier();

            $this->record->setUp();

            // if tree, set up tree
            if ($this->isTree()) {
                $this->getTree()->setUp();
            }
        } else {
            if ( ! isset($this->_options['tableName'])) {
                $this->setTableName(Doctrine_Inflector::tableize($this->_options['name']));
            }
        }
        
        $this->_filters[]  = new Doctrine_Record_Filter_Standard();
        $this->_repository = new Doctrine_Table_Repository($this);

        if ($charset = $this->getAttribute(Doctrine_Core::ATTR_DEFAULT_TABLE_CHARSET)) {
            $this->_options['charset'] = $charset;
        }
        if ($collate = $this->getAttribute(Doctrine_Core::ATTR_DEFAULT_TABLE_COLLATE)) {
            $this->_options['collate'] = $collate;
        }

        $this->construct();
    }

Here the charset and the collate are overwritten (in the last lines of the method) by the global values.

A fix could be something like:

Table.class.php

public function __construct($name, Doctrine_Connection $conn, $initDefinition = false)
    {
        $this->_conn = $conn;
        $this->_options['name'] = $name;
        
        $this->setParent($this->_conn);           
        $this->_conn->addTable($this);
        
        $this->_parser = new Doctrine_Relation_Parser($this);
        

        if ($charset = $this->getAttribute(Doctrine_Core::ATTR_DEFAULT_TABLE_CHARSET)) {
            $this->_options['charset'] = $charset;
        }
        if ($collate = $this->getAttribute(Doctrine_Core::ATTR_DEFAULT_TABLE_COLLATE)) {
            $this->_options['collate'] = $collate;
        }

        if ($initDefinition) {
            $this->record = $this->initDefinition();

            $this->initIdentifier();

            $this->record->setUp();

            // if tree, set up tree
            if ($this->isTree()) {
                $this->getTree()->setUp();
            }
        } else {
            if ( ! isset($this->_options['tableName'])) {
                $this->setTableName(Doctrine_Inflector::tableize($this->_options['name']));
            }
        }
        
        $this->_filters[]  = new Doctrine_Record_Filter_Standard();
        $this->_repository = new Doctrine_Table_Repository($this);

        

        $this->construct();
    }

Now the initDefinition method is called after the setup of the global charset and collate. Then if found a collate option in the table then that collate will be used.

[DC-518] Generated *Table.class.php should contain a getInstance() method

Mon, 15 Mar 2010 17:07:54 +0000

I'm using the symfony framework but assume that the following only affects the classes that were auto generated by Doctrine.

When doctrine generates the model classes for e.g. the sql table "manage_users" it generates:

 
  lib/model/doctrine/ManageUsers.class.php                           <- extends Doctrine_Table
  lib/model/doctrine/ManageUsersTable.class.php                 <- extends BaseManageUsers
  lib/model/doctrine/base/BaseManageUsers.class.php       <- extends sfDoctrineRecord

As far as I understand the ManageUsersTable class is supposed to be autoloaded by Doctrine (cf. ATTR_AUTOLOAD_TABLE_CLASSES) and injected into
the class returned by Doctrine::getTable('ManageUsers').

The first problem is that it is hard to figure out for newbies how to access methods in this class because they try all means to instanciate it or looking for static methods but eventually fail

The second problem is that using it this way, the IDE auto completion feature has no chance to figure out that the returned object offers methods defined in ManageUsersTable.class.php, it can only know that the results is an instance of Doctrine_Table.

The third problem is that one has to repeatingly write Doctrine::getTable("ManageUser") in the source code which is quite error prone - or did you notice that I missed an "s" in the example just given The IDE has again no chance to spot this.

A simple solution to all problems would be an auto generated getInstance method like this:

 
 class ManageUsersTable extends Doctrine_Table {
    /** Returns an instance of this class.
     *
     * @return ManageUsersTable
     */
    public static function getInstance() {
        return Doctrine::getTable('ManageUsers');
    }
 }

This way one could write ManageUs<AUTOCOMPLETION>::getInstance()->get<AUTOCOMPLETION>(); and there would be far less typo bugs!

bye,

~~christian~~

[DC-513] Complex HAVING clause generates incorrect SQL in Doctrine_Query::getCountSqlQuery() and Doctrine_Query::getLimitSubquery() [patch included]

Thu, 11 Mar 2010 10:37:37 +0000

I created a DQL query with a complex having clause, such as:

Doctrine_Query::create()
->from('Record r')
->addSelect('r.*')
->addSelect('((ACOS(SIN( ... AS miles') // Determines miles from lat/longs
->having('(r.location IS NULL) OR (miles <= r.location)');

The query works fine when executed by itself. However, when passed to Doctrine_Query::getCountSqlQuery(), it strips the r.location from the select fields, however this field remains in the having clause, and SQL errors out saying that it can't find the field. Then, when it is passed to Doctrine_Query::buildSqlQuery(true) by Doctrine_Pager->execute() (true designates to use getLimitSubquery()), getLimitSubquery() does the same thing and doesn't include these fields in the subquery.

I built a patch that I am using for my application to get around this. What it does is it searches for anything matching `[a-z0-9_]`.`[a-z0-9_]` in getCountSqlQuery() and getLimitSubquery() in the HAVING clause (for instance, would match `r`.`location`) and adds the field to the select query. This is a patch for Doctrine-1.2.1, and I haven't tested it extensively, so I'm not sure if it breaks anything, however in the quick testing I have done it seems to be working OK.

I greatly appreciate all the work the Doctrine team has done for this amazing ORM - keep up the good work! If I can be of any other assistance, please let me know.

[DC-512] Wrong sorting of migration files

Tue, 2 Mar 2010 11:57:03 +0000

If I name migration files just as 1.php, 2.php, ..., 10.php, then sorting goes wrong and they will be read in this order: 1.php, 10.php, 2.php, ....

I fixed it just by replacing

ksort($classesToLoad);

with

ksort($classesToLoad, SORT_NUMERIC);

[DC-510] setColumnOption(s) doesn't update _identifier when setting column as primary (symfony 1.4.2)

Tue, 2 Mar 2010 13:46:32 +0000

class PlgSlide extends BasePlgSlide
{
public function setTableDefinition()

{ parent::setTableDefinition(); $this->setColumnOptions('domain_id', array('primary' => true)); }

...
doesn't work, domain_id field is not added as part of identifier for PlgSlide table records

class PlgSlide extends BasePlgSlide
{
public function setTableDefinition()

{ parent::setTableDefinition(); $this->hasColumn('domain_id', 'integer', 4, array( .... other field option options here 'primary' => true )); }

do work as expected.

I've made some investigation and found code fragment at Table.php, in function setColumn, line 1373:
if (isset($options['primary']) && $options['primary']) {
...
$this->_identifier = (array) $this->_identifier;

but no such functionality for setColumnOption function, Table.php, line 1235

[DC-507] Expected an error thrown for a column with float type and notnull validation. Tested in Symfony 1.4

Tue, 2 Mar 2010 14:15:05 +0000

./config/doctrine/schema.yml

<?php $units = '[column, module, unit]'; ?>

PaperSize:
  columns:
    x_unit:   { type: enum, values: <?= $units ?> }
    y_unit:   { type: enum, values: <?= $units ?> }
    x_cells:  { type: integer, unsigned: true }
    y_cells:  { type: integer, unsigned: true }
    x_inch:   { type: float, unsigned: true }
    y_inch:   { type: float, unsigned: true }
    width:    { type: float, notnull: true, unsigned: true, range: [0.0001, 24] }
    height:   { type: float, notnull: true, unsigned: true, range: [0.0001, 24] }

./test/unit/model/PaperSizeTest.php

$ps = new PaperSize();
$ps->x_cells = 8;
$ps->height = 14;

try {
	$ps->save();
	$t->fail($ps->width); # <-- fails, save succeeds.
} catch (Exception $e) {
	$t->pass(); 
}
$t->is($ps->width, null);  # <-- fails with '0.00'
$t->is($ps->x_inch, null);

I overloaded the save method to calculate some things: (although from my debugging, none of the if statements are called. But here for reference).

./lib/model/doctrine/PaperSize.class.php

class PaperSize extends BasePaperSize
{
	public function save(Doctrine_Connection $conn = null)
	{			
		if (!$this->x_cells && $this->width && $this->x_inch) {
			$this->x_cells = (int) ($this->width / $this->x_inch);
		} else if (!$this->width && $this->x_cells && $this->x_inch) {
			$this->width = $this->x_cells * $this->x_inch;
		} else if (!$this->x_inch && $this->x_cells && $this->width) {
			$this->x_inch = $this->width / $this->x_cells;
		}
		
		if (!$this->y_cells && $this->height && $this->y_inch) {
			$this->y_cells = (int) ($this->height / $this->y_inch);
		} else if (!$this->height && $this->y_cells && $this->y_inch) {
			$this->height = $this->y_cells * $this->y_inch;
		} else if (!$this->y_inch && $this->y_cells && $this->height) {
			$this->y_inch = $this->height / $this->y_cells;
		}
		return parent::save($conn);
	}
}

[DC-504] toArray not using lazy loading

Wed, 10 Mar 2010 18:53:01 +0000

When selecting specific fields in a doctrine query, and calling toArray, the resulting arrays ignore the selected fields and load all values from the database record.

$phones = Doctrine_Query::create()
        ->select('ph.phone_type')
        ->from('Phone ph')
        ->orderBy('ph.phone_type')
        ->limit(2)
        ->execute()
        ->toArray();

The above query when dumped returns...

Array
(
    [0] => Array
        (
            [id] => 1
            [status] => 
            [phone_type] => business
            [number] => 8003041538
            [current_status_id] => 1
            [created_at] => 2010-01-08 15:08:34
            [updated_at] => 2010-01-08 15:08:34
        )

    [1] => Array
        (
            [id] => 2
            [status] => 
            [phone_type] => business
            [number] => 2052052055
            [current_status_id] => 1
            [created_at] => 2010-02-14 13:07:12
            [updated_at] => 2010-02-14 13:07:12
        )

)

[DC-505] Doctrine_Cache_Db can be much faster

Mon, 15 Mar 2010 17:22:58 +0000

Each Doctrine_Cache_Db->_doFetch() invocation costs about 50 ms on my PC(depending on the data of course). By using built-in pack() function performance can be increased 700x times. Each invocation now costs about 0.07 ms. The change is very considerable for pages with multiple queries.

[DC-503] Migrations task generates wrong diff for long table names

Mon, 15 Mar 2010 12:10:01 +0000

With the attached schema, a migrations diff is generated after an initial setup of the project, although
there are no differences at all. The two models are exactly identical, the only difference is the
lenght of their table names. A diff is detected for model "Institute", but not for the one called "Institut".

The reason is in the generation of the foreign keys (Doctrine_Connection line 1624), which
generates an abbreviated foreign key name for names longer than 64 characters. This
is true in the "to" models of the migration, but not in the "from" models.

[DC-506] Doctrine_Adapter_Statement_Oracle missing fetch statement in fetchAll()

Tue, 2 Mar 2010 13:57:32 +0000

It looks like the developer changed their mind on how to set the flags halfway through coding, as the $flags variable is not used. Critically, if the default FETCH_BOTH is specified, then no fetch is performed. I also did some testing with the OCI_BOTH constant, and could not get it to return the desired results (only enumerated results were returned). I also tried replacing OCI_BOTH with OCI_NUM + OCI_ASSOC with the same results.

I guess this should either throw an exception (not supported) or be fixed to return the appropriate results.

Line 361 in v1.2

        $flags = OCI_FETCHSTATEMENT_BY_ROW + OCI_ASSOC;

        $int = $fetchStyle & Doctrine::FETCH_COLUMN;

        if ($fetchStyle == Doctrine::FETCH_BOTH) {
            $flags = OCI_BOTH;
            $numberOfRows = @oci_fetch_all($this->statement, $data, $skip, $maxrows, OCI_FETCHSTATEMENT_BY_ROW + OCI_ASSOC + OCI_RETURN_LOBS);
        } else if ($fetchStyle == Doctrine::FETCH_ASSOC) {

[DC-500] Duplicate Index for foreign key(MySQL)

Tue, 2 Mar 2010 12:03:42 +0000

If an index with the same as the foreign key field exists and is not an array, and it is not the last in the list, adds it twice

SUGGESTION SOLUTION:

Doctrine/Export/Mysql.php (136): $found = $found || ($local == $definition['fields']);

[DC-493] method bracketExplode when tablename contains "Join"

Mon, 15 Mar 2010 17:31:44 +0000

Hello,
I'm using Symfony 1.4.1 with Doctrine (I imagine that the doctrine's version is 1.2.1), and I have a strange behavior because my table name is "piece_jointe", so it contains "JOIN" keyword inside.
In Doctrine_Query_Tokenizer class, the method bracketExplode explode string with a regular expression "#(JOIN)#i", so the table name is exploded and nothing works after that.

do you think it's possible to write a better regular expression to avoid this behavior ? Maybe add spaces after JOIN : "#(JOIN )#i but if there is a line break... or "#(JOIN[\s \n])#i"
For now, I'll rename the table !

Thanks a lot,
best regards
Etienne

[DC-487] Worng docs: @return docs of some methods in Doctrine_Query_Abstract class are worng.

Mon, 15 Mar 2010 17:39:15 +0000

@return docs of getSqlQueryPart should be mixed.
@return docs of setSqlQueryPart, addSqlQueryPart, removeSqlQueryPart, removeDqlQueryPart, copySubqueryInfo, useResultCache, useQueryCache, expireResultCache, expireQueryCache, setResultCacheLifeSpan and setQueryCacheLifeSpan should be Doctrine_Query.

This issue is also reported in the user ml. http://groups.google.com/group/doctrine-user/browse_thread/thread/ee5d40f03242af8b

[DC-488] Cannot parse table name including 'join'

Mon, 15 Mar 2010 17:35:30 +0000

Cannot parse table name including 'join'.

$q = new Doctrine_Query();
$q->from('MyJoinProblem');

In above code, I want to query like 'SELECT m.id AS m__id FROM MyJoinProplem m'.
But, Doctrine try to find 'My' table and 'Problem' table.
Table name is 'MyJoinProblem'.

[DC-482] $data passed to foreach is wrong

Mon, 15 Mar 2010 17:45:10 +0000

Calling a query that doesn't use all tablecols gives php warnings such as:

Errorcode: E_WARNING [php warning] (2)
Message: Invalid argument supplied for foreach()
File: Record.php
Line: 1151

--------------------------------------------------------------
$data = empty($data) ? $this->getTable()->find($id, Doctrine_Core::HYDRATE_ARRAY) : $data;
foreach ($data as $field => $value) {
--------------------------------------------------------------

$data is empty but not an array.

[DC-472] In the relatedExists method of the Doctrine_Record class the exception is incorrectly thrown imho

Mon, 15 Mar 2010 14:16:38 +0000

When using the result of a:

test.php

$q = Doctrine::createQuery()
        ->from('User u')
        ->leftJoin('Role r');

$users = $q->execute();

now if we want to iterate and know if exists the according role for each user

test.php

foreach ($users as $user)
{
  $role_name = $user->relatedExists('Role') ? $user->getRole()->getName() : '';
}

the exception in the relatedExists method will be thrown:

test.php

public function relatedExists($name)
    {
        $newReference = false;
        if ( ! $this->hasReference($name)) {
            $newReference = true;
        }

        $reference = $this->$name;
        if ( ! $reference instanceof Doctrine_Record) {
            throw new Doctrine_Record_Exception(
                'You can only call relatedExists() on a relationship that '.
                'returns an instance of Doctrine_Record'
            );
        }
        $exists = $reference->exists();

        if ($newReference) {
            $this->clearRelated($name);
        }

        return $exists;
    }

because the according role record does not exist for some users ( a user just could have one record).

it could be better this way:

test.php

public function relatedExists($name)
    {
        $newReference = false;
        if ( ! $this->hasReference($name)) {
            $newReference = true;
        }

        $reference = $this->$name;
        if ( ! $reference && ! $this->getTable()->hasRelation($name)) {
            throw new Doctrine_Record_Exception(
                'You can only call relatedExists() on a relationship that '.
                'returns an instance of Doctrine_Record'
            );
        }

        $exists = $reference ? $reference->exists() : false;

        if ($newReference) {
            $this->clearRelated($name);
        }

        return $exists;
    }

With this change, this method can be used to check newly created user objects or some retrieved from the db (left join with role) smoothly.

[DC-474] Export: exportClassesSql does pollute classes tables with new all-NULL records

Wed, 3 Feb 2010 14:38:23 +0000

Doctrine/Export.php
in
public function exportClassesSql(array $classes)
(around line 1245):

there is:
$record = new $name();
$table = $record->getTable();

This does cause the instance of new record to be added to table's repository, which leads to unexpected results when $connection->flush(); is used.
(like throwing exception because save of record with NULL "notnull" column is not valid, if validation is allowed)

I did replace those two lines with:
$table = $this->conn->getTable( $name );

And it works for me well.

Although this is not equivalent, because the original code while fetching the $table, it also makes sure the desired class "$name" can be instantiated, my code doesn't care about that. (as I'm trying to do TDD with my new project, I don't care about this, because that's the very first unit test I write for every new class anyway, so I'm pretty sure all my model classes are ok)

EDIT: maybe my solution is also bound to certain connection, but at that stage of export execution it's the desired connection anyway? I'm working with single connection right now, so it WFM this way.

In case the instantiation is not a bug, but a desired feature, is it possible to find that record in repository and evict it right away after $table is fetched?
I do believe that ExportClassesSql should not effectively create new records in tables, because that's beyond what the name of method suggests.
Also the documentation of the function doesn't cover this side-effect of execution.

[DC-468] Project directories that have underscores (ie my_project) in the name get replaced with slashes (my/project) when generating models

Mon, 15 Mar 2010 17:49:38 +0000

I have a project name that contains an underscore. When I run the doctrine CLI to create the models from the yaml file, something string replaces all underscores with slashes.

So where I would be expecting the models to be generated in 'my_project/application/models', it is instead being generated in 'my/project/application/models'

[DC-469] getAccessors and getMutators shows notices if they are not set

Mon, 15 Mar 2010 17:48:56 +0000

It's a very minor problem I know that. However when I try to use getAccessors() or getMutators() functions, if nothing is set on the table definitions, it throws some notices on the php (on error_reporting all) that such an index does not exists. As there is no such index to be found it returns null instead of expected array (empty if there is no mutators for that table)

public function getAccessors()
{
$componentName = $this->_table->getComponentName();
if (!isset(self::$_customAccessors[$componentName]))

{ return array(); }

return self::$_customAccessors[$componentName];
}

such a code solves the problem and not notices is thrown and empty array is returned if there is no accessors. Same kind of an improvement is required for getMutators too

I know that this is a minor issue however I wanted to inform you.

[DC-813] Add ability to register a custom hydrator as a class instance instead of a class name

Wed, 11 Aug 2010 14:50:23 +0000

Currently its only possible to register a custom hydrator as a string name. However in order to inject additional attributes it would be beneficial to be able to register an instance of the custom hydrator class.

http://www.doctrine-project.org/documentation/manual/1_2/en/data-hydrators#writing-hydration-method

So instead of:
$manager->registerHydrator('my_hydrator', 'Doctrine_Hydrator_MyHydrator');

One could do:
$manager->registerHydrator('my_hydrator', new Doctrine_Hydrator_MyHydrator());

[DC-274] Doctrine_Parser_Yml: hardcoded require calls for sfYaml

Mon, 23 Nov 2009 22:58:39 +0000

In Doctrine_Parser_Yml the requires calls to sfYaml are hardcoded:
if ( ! class_exists('sfYaml', false)) {
require_once dirname(_FILE_) . '/../../vendor/sfYaml/sfYaml.php';
require_once dirname(_FILE_) . '/../../vendor/sfYaml/sfYamlDumper.php';
require_once dirname(_FILE_) . '/../../vendor/sfYaml/sfYamlInline.php';
require_once dirname(_FILE_) . '/../../vendor/sfYaml/sfYamlParser.php';
}

This causes issues when one has already included sfYaml elsewhere. Either one needs to include the code for sfYaml twice or one needs to always load sfYaml before Doctrine parses any yaml files.

A better approach to handling the fact that sfYaml does not adhere to the standard naming convention is to do these require calls inside the autoloader, but only using "include" in order to allow a fallback autoloader to also be able to load the code.

[DC-275] Mysql Schema Manager does not correctly detect Decimal + bug fix from me

Wed, 25 Nov 2009 08:57:17 +0000

Mysql Schema Manager does not correctly detect Decimal. Lost decimal scale!

bug in file Doctrine/DataDict/Mysql.php

on line 263

 
        if (isset($field['length'])) {
            $length = $field['length'];
            $decimal = '';
        } else {
            $length = strtok('(), ');
            $decimal = strtok('(), ') ? strtok('(), '):null;    // <--- here strtok call 2 times! (line 263)
        }

must be like that

 
        if (isset($field['length'])) {
            $length = $field['length'];
            $decimal = '';
        } else {
            $length = strtok('(), ');
            $decimal = strtok('(), ');
            if ( ! $decimal ) { // or false === $decimal
                $decimal = null;
            }
        }

Please fix it

[DC-270] Implement Doctrine::PORTABILITY_RTRIM for Pgsql

Wed, 3 Mar 2010 13:27:40 +0000

Data returned using Postgres driver is padded with spaces for char columns (like "A " where length is 5).

Setting portability to any of the levels doesn't change it, because it seems that this functionality is not implemented.