Doctrine Project

[DC-1042] submitted form accidentally - PLEASE DELETE

Wed, 30 Nov 2011 21:34:39 +0000

This was accidentally submitted before being complete ... This one can be deleted ... sorry

[DC-1039] Return value of function Doctrine_Tree_NestedSet::fetchRoot($id)

Mon, 31 Oct 2011 07:22:13 +0000

In api documentation about Doctrine_Tree_NestedSet::fetchRoot($id) said - it return void. But this is not true. This function return mixed - bool or model data.

[DC-1032] [PATCH] Doctrine_Collection::isModified() does not support deep like Doctrine_Record but probably should

Tue, 23 Aug 2011 18:24:25 +0000

$record instanceof Doctrine_Record;
$collection instanceof Doctrine_Collection;

Using the $record object I can find out if it has been modified : $record->isModified().
I can also have this check all the relations also by passing true : $record->isModified(true);

However, the $collection object only support the first level and not the relations of its member records,
$collection->isModified() returns false if one of the entry has one its relations modified (as it should).

The improvement would be to allow this method to accept true, like it's $record counterpart, which would return true instead.

See attached patch.

[DC-1029] Extensions of Doctrine_Template_I18n incompatible with Doctrine_Import

Thu, 18 Aug 2011 11:36:19 +0000

Extending Doctrine_Template_I18n class make Doctrine_Import on YAML data with translation fails...

Why ? Just because of this line :

Doctrine_Import.php, line 135 :
if ($table->hasRelation($key) && is_array($value) && ! $table->hasTemplate('Doctrine_Template_I18n')) {

In fact, having a template named "Doctrine_Template_I18n" is not strong enough to be sure that the current object has an I18n behavior.

The bug is very simple to reproduce :

1. Get a classic I18n fixtures like :

Article:
Translation:
en:
title: Lorem Ipsum

2. Then make a simple extension of the I18n template (do not do anything else but extends the Doctrine_Template_I18n class) :

class My_Doctrine_Template_I18n extends Doctrine_Template_I18n {}

3. Load the extension, assign it to your model and try to import your fixtures again. It will not work anymore.

Thanks

[DC-1019] REMOVED SPAM

Tue, 23 Aug 2011 18:08:40 +0000

*REMOVED SPAM*

[DC-915] The PHP code is invalid in the "Create Table" example; there are missing commas in the array definition.

Wed, 7 Sep 2011 18:58:56 +0000

http://www.doctrine-project.org/projects/orm/1.2/docs/manual/migrations/en#writing-migration-classes:available-operations:create-table

The PHP code is invalid in the "Create Table" example; there are missing commas in the array definition.

[DC-909] Add Some Info to Doctrine Query order by Method Documentation

Mon, 1 Nov 2010 14:56:20 +0000

This is very minor, but would have saved me a few minutes. On the Doctrine Query documentation page (V1 - http://www.doctrine-project.org/projects/orm/1.2/docs/manual/dql-doctrine-query-language/en#order-by-clause), it would be useful to note that multiple calls to Doctrine_Query::orderBy() do not stack, and that the later calls will over write the previous ones. I'll propose:

To sort by multiple columns, you must specify them in one call to Doctrine_Query::orderBy(). If you call orderBy a second time, the column from the first call will not be included in the resulting query.

<code>
//works as expected
//results in ORDER BY id ASC, userName DESC
$query->orderBy('id ASC, userName DESC');

//does not work as expected
//results in ORDER BY userName DESC
$query->orderBy('id ASC')
->orderBy('userName DESC');
</code>

[DC-906] Missing retrieval method

Sun, 31 Oct 2010 05:19:18 +0000

This page:
http://www.doctrine-project.org/projects/orm/1.2/docs/manual/getting-started/en#getting-started

only lists svn as a way to check out the doctrine source. It's also available via git.

[DC-840] MSSQL - strange behavior with multiple addWhere conditions and ">" [+patch]

Fri, 27 Aug 2010 11:57:19 +0000

In the first example below the second parameter wasn't replaced by the given value. I tracked it down and i suppose it's because of the ">" sign. It's the same for "<". Equal-Operator (=) works fine.

        $q = Doctrine_Query::create()
            ->select('password, modified_at')
            ->from('Ticket_DCXXX_Model')
            ->andWhere('password = ?', 'abc')
            ->andWhere('modified_at > ?', '2010-01-01')

SELECT [t].[id] AS [t__id], [t].[password] AS [t__password], [t].[modified_at] AS [t__modified_at]
FROM [ticket__d_c_x_x_x__model] [t]
WHERE ([t].[password] =  'abc' AND [t].[modified_at] > ?)

        $q = Doctrine_Query::create()
            ->select('password, modified_at')
            ->from('Ticket_DCXXX_Model')
            ->andWhere('modified_at > ?', '2010-01-01')
            ->andWhere('password = ?', 'abc')

SELECT [t].[id] AS [t__id], [t].[password] AS [t__password], [t].[modified_at] AS [t__modified_at]
FROM [ticket__d_c_x_x_x__model] [t]
WHERE ([t].[modified_at] >  '2010-01-01' AND [t].[password] =  'abc')

[DC-804] Files' date set to epoch

Sat, 31 Jul 2010 06:20:51 +0000

Hi,

The date for all the files in the 1.2.2 tarball is set to 1970-01-01.

Thanks,
Federico

[DC-786] phpdoc comment error

Wed, 14 Jul 2010 15:19:15 +0000

in Doctrine/Core.php on line 881

comment for method generateModelsFromYaml() is:
881: * Generate a yaml schema file from an existing directory of models

should be:
881: * Generates models from a yaml schema file

[DC-784] Removed unuseful code

Tue, 13 Jul 2010 05:38:37 +0000

Self assignments like:

$table = $table;

are unuseful and could be safely removed.

[DC-731] [Source code format] Transform indent tabs into 4 spaces, and trim trailing spaces

Wed, 16 Jun 2010 06:06:01 +0000

I have read that Doctrine source code is wanted not to use tabs for indentation / alignement;
and trailing spaces / tabs are useless and polluting.
I made some funny patch

G.X

[DC-730] "// ?? should this not be $this->_table->getComponentName() ??" in Doctrine/Relation/Parser.php

Wed, 16 Jun 2010 06:07:16 +0000

In class Doctrine_Relation_Parser, in method completeDefinition(), at line 508 (for svn r.7676) there is the code:

php

                foreach ((array) $this->_table->getIdentifierColumnNames() as $id) {
                    // ?? should this not be $this->_table->getComponentName() ??
                    $column = strtolower($table->getComponentName())
                            . '_' . $id;

The comment on line 509 seems right, since $table is a "temporary" variable created in a previous foreach loop a few lines before (l. 472) and not used anywhere else... (I didn't make a test case though, that's why I tagged it as "Task" rather than "Bug")

I attached a patch, just in case.

G.X