Doctrine Project

[DC-1059] Generate Entity From Database

Thu, 27 Sep 2012 17:07:01 +0000

Problem already report here : https://github.com/symfony/symfony/issues/5617#issuecomment-8934524
But the idea is, on generation of entity from database MySQL, Int and Tinyint type are tranform as booelan.

[DC-1047] hardDelete not resetting flag if exception is thrown

Fri, 6 Jan 2012 11:46:54 +0000

To be honest I don't know wich version I have but I believe it to be 1.2.3

The problem is pretty simple, I was trying to do a hardDelete and if it fails I would do a softDelete.
Example

try {
    $record->hardDelete();
}
catch (Exception $e) {
    if ($e instanceof Doctrine_Connection_Mysql_Exception && $e->getPortableCode() == Doctrine_Core::ERR_CONSTRAINT) {
        try {
            $record->delete();
        }
        catch (Exception $e1) {
            throw $e1;
        }
    }
    else {
        throw $e;
    }
}

But when the first exception is thrown from hardDelete() in Doctrine_Template_SoftDelete(line 84) the listener flag for hardDelete is not set to false, so if I try to do the delete, it will still behave as if it was a hardDelete.

The solution would be catch the exception, reset the flag and rethrow it.
Patch attached

Hope this info is enough.

[DC-1044] record Line 2430 Unlink method Warning: Illegal offset type in sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Record.php on line 2459

Mon, 5 Dec 2011 00:01:28 +0000

When you have a new unpersisted object and you call a method to a referenced object - when calling the unlink() method on referenced object the above error is called.

Warning: Illegal offset type in sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Record.php on line 2459

$foo = new foo();

$foo->getBar(); This call will bind a reference of Bar against the foo object.

$foo->unlink('bar');

As no objects are yet persisted, the unlink method tries to match ids on the objects that do not exist.

[DC-1028] Doctrine Migrate functions for current version and for creating the migrations table

Tue, 16 Aug 2011 18:54:25 +0000

I always tend to find myself needing to implement migrations after the fact. It would be really nice to have a method of having doctrine creating the migration_version table as well as a method of setting that value and getting that value.

This would in-turn allow the implementation in a framework such as symfony to allow you insert the table after the fact, allow you to update the migration version without running the migration and to let you know what version you're currently on.

[DC-1018] Circular references to named entities break during data importing

Thu, 14 Jul 2011 10:59:18 +0000

If the schema specifies that records relate to each other in both directions:

{{
Kitten:
columns:
basket_id: integer
relations:
Basket:
local: basket_id

Basket:
columns:
fluffiest_kitten_id: integer
relaitons:
FluffiestKitten:
type: one
class: Kitten
local: fluffiest_kitten_id
}}

Then a data dump for such a schema won't properly load one of the keys, e.g:

{{
Kitten:
Kitten1:
Basket: Basket1

Basket:
Basket1:
FluffiestKitten: Kitten1
}}

Will result in either fluffiest_kitten_id or basket_id being set to 0

[DC-1017] Floats persisted in the database are retrieve as strings.

Tue, 12 Jul 2011 12:11:53 +0000

Someone complained about symfony padding 0's after floats http://stackoverflow.com/questions/6650786/remove-extra-decimal-place-in-float-datatype-on-symfony/6663829 , I think it's a doctrine problem, since the doctrine:dql task seems to have the same problem:

>> doctrine executing dql query
DQL: FROM UcVideoAspect
found 1 results
-
id: '1'
video_id: null
pixel_ratio: '12.50'
width: null
height: null

Here, pixel ratio is defined as a float in the schema.yml file
Getting the property from a transient object returns a float, while getting it from the db returns a string.

[DC-1016] Set method in update query ignores 'false' if passed as boolean

Tue, 5 Jul 2011 10:23:33 +0000

I had to define this function:

public function deactivate($segment_id)

{ $query = $this->createQuery() ->update('Segment s') ->set('s.is_active ', false) //not working // ->set('s.is_active ', (int)false) //works ok // ->set('s.is_active ', true) //works ok ->where('s.id = ?', $segment_id); // var_dump($query->getSqlQuery());die; return $query->execute(); }

Problem is that when setting a column using boolean false you get invalid SQL query like this:
UPDATE segment SET is_active = WHERE (id = ?)

Workaround is to do it like this: set('s.is_active ', (int)false) , but since setting the same column with boolean true works, false should work too.

[DC-1012] Doctrine_core specified twice in documentation Defining Models -> Join Table Associations

Tue, 28 Jun 2011 10:04:44 +0000

$manager->setAttribute(Doctrine_Core::Doctrine_Core::ATTR_QUOTE_IDENTIFIER, true);

should be:

$manager->setAttribute(Doctrine_Core::ATTR_QUOTE_IDENTIFIER, true);

http://www.doctrine-project.org/projects/orm/1.2/docs/manual/defining-models/en#relationships:join-table-associations

[DC-1006] Custom geometric query error with orderBy

Sun, 22 May 2011 19:41:17 +0000

Mi Doctrine_Query with this Geometric Query fails with orderBy , but with where works.

$distance = "glength(linestringfromwkb(linestring(GeomFromText('POINT( ".$object->getLatitude()." ".$object->getLongitude() .")'),l.point))) "

This works:
SomeObjectTable::getInstance()~~>createQuery()~~>where($distance.' < ?',0.05 )

But this one fails at version 1.2.4, with older version was working.
SomeObjectTable::getInstance()~~>createQuery()~~>where($distance.' < ?',0.05 )->orderBy($distance)

Well the problem is at line 74 of OrderBy.php :
$componentAlias = implode('.', $e);

the rendered query in the distance has some ".", for example:
POINT( -34.470829 -58.5286102)

then the after line 74 in OrderBy tries to search por '58' class.

I manually added to DataDict in Mysql.php the POINT datatype (this fix solve me the problem in older versions of Doctrine).

[DC-1005] Schema importer sometimes overwrites relations (instead of adding them) due to issue with bugfix DC-281

Tue, 17 May 2011 11:47:49 +0000

The bugfix for ~~DC-281~~ (r6802) contains an issue:

When between two tables in a MySQL database there are two relations, one on both sides (i.e. both tables have a FK field to each other), one of the two is overwritten with the second by the schema importer. That is, at one class, there seems to be only one relation instead of both.

The issue came in when the decision was made to store all class names in the definition array lower case, as one of the lookups in the array was not updated appropriately.

See Doctrine/Import.php (1.2.4) line 416 - 435. In line 427, you can clearly see the change made in 6802

Old:
$definitions[$relation['class']]['relations'][$alias] = array(
New:
$definitions[strtolower($relation['class'])]['relations'][$alias] = array(

Line 421 however should also have been updated:

if (in_array($relation['class'], $relClasses) || isset($definitions[$relation['class']]['relations'][$className])) {
Proposed fix:
if (in_array($relation['class'], $relClasses) || isset($definitions[strtolower($relation['class'])]['relations'][$className])) {

This error results in relations that already exist sometimes being overwritten.

[DC-1003] _processWhereIn does not allow the use of named query parameters

Fri, 6 May 2011 00:06:42 +0000

When writing a query such as

$query = $query->where('entity.myValue = :value', array(':value'=>5));

you are unable to then

$query = $query->whereIn('entity.otherValue', array(':otherValues'=>array(1,2,3)));

Doctrine complains that you may not mix positional and named query parameters.

The attached patch fixes this by checking if the key of the passed in parameter is non numeric and if so setting the "value" of the parameter place holder to the value of the key.

[DC-1001] Doctrine Caching page does not mention the "prefix" option

Mon, 27 Jun 2011 18:14:37 +0000

http://www.doctrine-project.org/documentation/manual/1_1/en/caching

When not using a prefix with multiple / yet similay projects a mixup of query caching will occur (for example with sfDoctrineGuard queries). This is very easialy fixed with a prefix - but I only realized after two months - that this feature actually existed. There is no mention of this in the documention.

A mention of the feature

$q = Doctrine_Query::create()
->useResultCache(new Doctrine_Cache_Apc(array('prefix'=>'myproject_')));

Would have helped me and I think it will also help others.

[DC-995] Doctrine deprecated in favor of Doctrine_Core - phpdoc

Wed, 6 Apr 2011 13:23:53 +0000

http://www.doctrine-project.org/projects/orm/1.2/docs/whats-new/en clearly states that the Doctrine class is deprecated - e.g. in order to allow for proper autoloading.
To enable IDEs to perform proper autocomplete and to encourage programmers not to use the Doctrine class anymore, it's phpdoc block shuld by changed in order to contain a

@deprecated In favor of Doctrine_Core - this class extends Doctrine_Core for BC

[DC-993] Many-to-many Relation defined one way

Tue, 5 Apr 2011 07:09:51 +0000

When a many-tomany relation has been defined on only one of the end of the relation, and ofcourse in the cross-refClass, things get weird. I'll use the user-groups relation (as found in the documentation) as example.

If in the group model has not defined the hasMany, then a user can be instantiated and saved. When instantiated, the relation groups would return an empty array, groups can ben added like:

$u = new User();
var_dump($u->groups);
$u->groups[] = new Group();
var_dump($u->groups);

This would output an empty array, and subsequently an array containing the new group.

However, if a user would be retrieved from the database, and the relation groups would be called, then the following message will appear (which is not helpfull at alllll, I've spend hours figuring it out!):

Uncaught exception 'Doctrine_Record_UnknownPropertyException' with message 'Unknown record property / related component "groups"' .....

I will never forget this, but it's not described in the documentation and the error is not helping either. So either one of these step hvae to be taken. Or even better, making it work without requiring the hasMany in group, to users.

[DC-990] Values not escaped

Sat, 26 Mar 2011 16:14:15 +0000

When I save inputs from a form, special characters such as single quotes are inserted into the mysql database without being escaped. It's my understanding that doctrine uses PDO and PDO should handle this escaping automatically, but it is not. Is there a configuration setting that I can set with doctrine to enable this?

Thanks
Nick

[DC-987] redundant sql statement in Doctrine_Export_Oracle::_makeAutoincrement()

Mon, 21 Mar 2011 12:35:54 +0000

line 121-128 of Doctrine_Export_Oracle appears to generate redundant code for creating a primary key constraint as primary keys (defined in schema.yml) are already generated during CREATE TABLE statements.

[DC-976] Invalid long constraint name

Sat, 19 Feb 2011 12:47:26 +0000

When the constraint's name is too long, a shorter one is generated using information such as the name of the database. If the database's name begins with a numeric value, the constraint name also begins with a numeric value which results in an invalid constraint name.

[DC-975] Treat sql server error 2601 as Doctrine_Core::ERR_ALREADY_EXISTS

Thu, 17 Feb 2011 11:31:01 +0000

Patch attached to treat sql server error 2601 (Integrity constraint violation) as Doctrine_Core::ERR_ALREADY_EXISTS

[DC-970] Diff Tool doesn't generate the down() method if a field attribute is changed in YAML

Thu, 7 Apr 2011 05:43:56 +0000

Diff Tool doesn't generate the down() method if a field attribute is changed in YAML. Below is an example

scheme.yaml

    email:
      type: string(255)
      fixed: false
      unsigned: false
      primary: false
      notnull: false
      autoincrement: false

scheme2.yaml

    email:
      type: string(160)
      fixed: false
      unsigned: false
      primary: false
      notnull: true
      autoincrement: false

And below is the generated migration class (down() method is missing):

1239898949_Version39.php

class Version39 extends Doctrine_Migration_Base
{
    public function up()
    {
        $this->changeColumn('support_tickets', 'email', 'string', '160', array(
             'fixed' => '0',
             'unsigned' => '',
             'primary' => '',
             'notnull' => '',
             'autoincrement' => '',
             ));
    }

    public function down()
    {

    }
}

[DC-969] When I add a text field to a mysql table the migration code generated fails

Wed, 23 Feb 2011 14:24:35 +0000

I am using a database designed using schema.yml with a MySql Server.

When I add a field of type text the generated code for the migrations (using diff) is as follows:

$this->addColumn('<tableName>', '<fieldName>, 'text', '', array(
'notnull' => '',
));

Which produces a MySQL error like this:

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1. Failing Query: "ALTER TABLE <tableName> ADD <fieldName> text()"

The solution I found was to manipulate manually the generated class to use an addColumn like this:

$this->addColumn('<tableName>', '<fieldName>, 'text', null, array(
'notnull' => '',
));

Which would generate an SQL statement like this:

ALTER TABLE <tableName> ADD <fieldName> text

Which works fine with MySQL, don't know about other RDBMS

[DC-965] Doctrine is passing timestamps to Doctrine_Validator_Unsigned

Fri, 11 Feb 2011 05:57:09 +0000

Since April last year I've been unable to use Doctrine Timestampable functionality because I get errors like this:

Uncaught exception 'Doctrine_Validator_Exception' with message 'Validation failed in class XXX 1 field had validation error: * 1 validator failed on created_at (unsigned) ' in ...

I've tried lots of different configurations for the timestampable functionality (see my Stack Overflow question for details) to no avail.

I've done some further investigation and the reason for the problem is that the timestamps are being sent to Doctrine_Validator_Unsigned for validation; they are then failing the following regexp test:

        if (preg_match('/[^0-9\-\.]/', $value)) {
            return false;
        }

I'm not smart enough to figure out why Doctrine is calling an unsigned validation test for these timestamps, so for now I've fixed the problem by hacking the following into Doctrine_Validator_Unsigned:

        if (preg_match('/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $value)) {
            return true;
        }

Very ugly I know, but when I add this in the rest of the timestamping functionality works perfectly. Would love to get to the bottom of this bug - is particularly strange because nobody else seems to be experiencing it.

[DC-964] Alias name error when using interval(MySQL)

Thu, 3 Feb 2011 07:37:28 +0000

I'm using Doctrine with Symfony and i have some troubles when i'm using the mysql command: interval. Here's a detailed explanation:
Part of the schema:

User:
  columns:
    name: { type: string(255), notnull: true }
    nick: { type: string(255), notnull: true, unique: true }
    email: { type: string(255), notnull: true, unique: true }
    password: { type: string(40), notnull: true }

VirtualConferenceRoom:
  columns:
    adminId: { type: integer, notnull: true }
    name: { type: string(255), notnull: true }
    startDate: { type: timestamp, notnull: true }
    duration: { type: integer, notnull: true }
  relations:
    Admin:
      class: User
      foreign: id
      local: adminId

VirtualConferenceRoomUser:
  columns:
    virtualConferenceRoomId: { type: integer, notnull: true }
    userId: { type: integer, notnull: true }
  relations:
    VirtualConferenceRoom:
      class: VirtualConferenceRoom
      foreign: id
      local: virtualConferenceRoomId
    User:
      class: User
      foreign: id
      local: userId

I've generated my model with symfony's built in command(symfony doctrine:build --model --sql)
When I try to get the conference rooms which are in progress at the moment I try it like this:

// In the project/lib/model/doctrine/VirtualConferenceRoomTable.class.php which is extends from Doctrine_Table
public function getRoomsInProgressByUserId($userId)
{
    return Doctrine_Query::create()
                ->select('vcr.*')
                ->from('VirtualConferenceRoom vcr')
                ->innerJoin('vcr.VirtualConferenceRoomUser vcru')
                ->where('(vcr.StartDate < now()) and (vcr.StartDate + interval vcr.Duration minute > now()) and vcru.UserId = ?', array($userId))
                ->execute();
}

When I try to run my app I get an error message: "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'vcr.Duration' in 'where clause'"
The generated sql command is:

" SELECT v.id AS v__id, v.userid AS v__userid, v.name AS v__name, v.startdate AS v__startdate, v.duration AS v__duration FROM virtual_conference_room v INNER JOIN virtual_conference_room_user v2 ON v.id = v2.virtualconferenceroomid WHERE (v.startdate < NOW() AND v.startdate + interval vcr.Duration minute > NOW() AND v2.userid = ?) - (2)"

The problem is the vcr.Duration section. If I change my function from:

->where('(vcr.StartDate < now()) and (vcr.StartDate + interval vcr.Duration minute > now()) and vcru.UserId = ?', array($userId))

to:

->where('(vcr.StartDate < now()) and (vcr.StartDate + interval v.Duration minute > now()) and vcru.UserId = ?', array($userId))

it works perfectly.

I hope my report is useful and clear and i can help you to improve this great ORM
Best wishes: Tibor Erdész <erdeszt@gmail.com>

[DC-959] DSN style problems in documentation 1.2

Tue, 25 Jan 2011 21:28:26 +0000

This page:

http://www.doctrine-project.org/projects/orm/1.2/docs/manual/introduction-to-connections/en

states the DSN can either be provided as an associative array or as a string, but it's not true, specially if you're doing lazy connection, because this type of connection only accepts doctrine dsn style and it doesn't seem to know how to handle unix socket type connections (is it correct?).

I would suggest the manual clarify that lazy connection will only accept string type dsn and also will not accept socket connections.

[DC-950] Doctrine_Record magic _set() doesn't validate field type for timestamp/datetime/etc..

Mon, 24 Jan 2011 11:36:01 +0000

So I ran into this recently. the magic _set() in Doctrine_Record doesn't check/validate the type of the field. The use case is when you you do something like:
setCreatedAt(time()); This will not work correctly with date/time or timestamp types in Doctrine, even though Propel handles this fine. Also MYSQL will not throw an error with default sql_mode and will put garbage data into the database.

The only way to generate the right date/time value is to always format that string with the "right" format. This should be easier and can be easier if it supported either a timestamp (time() or a DateTime() object (just like Symfony plugin does for setDateTimeObject() function). This is just a few lines of code, let me know if I should attach a patch.

I would love to see the Doctrine_Record implement this functionality. There's a ton of results on frustrated users trying to figure out how to set the date/time values properly using Doctrine.

[DC-948] 3 underscores in my yaml file lead to error

Thu, 9 Dec 2010 11:44:39 +0000

I had this yaml:

OldAppellations:

connection: doctrine

tableName: old_appellations

columns:

appellations___sql:

{ type: text }

appellationsapcode_sql:

{ type: text }

appellationsappellation_sql:

{ type: text }

appellationscolor_sql:

{ type: text }

appellationscountry_sql:

{ type: text }

appellationsregion_sql:

{ type: text }

appellationsregion_for_link_sql:

{ type: text }

appellationssubt_sql:

{ type: text }

appellationstaster_appel_sql:

{ type: text }

appellationstotal_r_sql:

{ type: text }

appellationstype_sql:

{ type: text }

export_record_id_sql:

{ type: text }

I got this error:

Notice: Undefined index: o__appellations in /home/lkrubner/dev/tastingnotes/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Hydrator/Graph.php on line 302
Notice: Undefined index: in /home/lkrubner/dev/tastingnotes/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Hydrator/Graph.php on line 303
Fatal error: Call to a member function getFieldName() on a non-object in /home/lkrubner/dev/tastingnotes/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Hydrator/Graph.php on line 304

Then I changed the 3 underscores to 1:

appellations_sql:

{ type: text }

I rebuilt the model and the error was gone.

More details and screenshots are here:

http://www.symfonyexperts.com/question/show/id/178

[DC-947] getRandom() method for Doctrine_Table

Wed, 8 Dec 2010 05:42:23 +0000

Consider adding this method into Doctrine_Table

public static function getRandom()
{
return
self::getInstance()->createQuery()
->select('*, RANDOM() as rand')
->limit(1)
->orderBy('rand')
->fetchOne();
}

It is portable and very useful.

[DC-945] Doctrine_Query::create()->where('table.field =') unexpectedly returns a result

Tue, 7 Dec 2010 03:16:02 +0000

While firing the following query with Doctrine, I did not expect Doctrine to return me a record, however, even though there is a syntax error (in my opinion) it gave me the first record of the table.

$q = \Doctrine_Query::create()
->from('User u')
->where('u.Id =', $userId);

$r = $q->fetchOne();

Note that the question mark in the where method is ommitted. This will return a User model with an Id of 1.

I would expect this to generate an invalid SQL statement (or even fail to pass the DQL validation).

Giving the first record doesn't seem to be appropriate in my opinion.

[DC-943] Memory leaks in find* magic methods owing to failure to free queries

Fri, 3 Dec 2010 10:30:42 +0000

The following methods on Doctrine_Table create Doctrine_Query objects that are never free()d:
findAll()
findBySql()
findByDql()
findBy()
findOneBy()

[DC-923] Documentation 1.2 #working-with-models error

Wed, 10 Nov 2010 06:27:30 +0000

In documentation

http://www.doctrine-project.org/projects/orm/1.2/docs/manual/working-with-models/en#many-to-many-relations:creating-a-new-link

There's an error in example code:

// test.php

// ...
$user = new User();
$user->username = 'Some User';
$user->Groups[0]->username = 'Some Group';
$user->Groups[1]->username = 'Some Other Group';
$user->save();

The error is on lines:

$user->Groups[0]->username = 
$user->Groups[1]->username =

they shoud be:

$user->Groups[0]->name = 
$user->Groups[1]->name =

as there's no username column in schema.yml definition of Group object.

[DC-905] Fields with foreign key shouldn't require definition

Sun, 31 Oct 2010 03:31:51 +0000

Sample schema attached.

Now, keeping attached schema in mind.

We have core tables that lots of other tables refer via foreign keys to them, like user, company, etc.

We need to explicitly define foreign keys (like user_id) "definitely same as" User.id on each table. By design, this seems unnecessary, and has load on refactoring processes, ie. type change on User.id.

Doctrine is already parsing foreign relations from schema, It can use parent table field definition (User.id) in refering table fields (user_id) and on the schema user_id can be defined as:

user_id: ~

[DC-901] Several test cases using CRLF endings

Sun, 24 Oct 2010 10:09:25 +0000

Hi there. I'm finding several test cases that are using CRLF line endings, instead of the standard UNIX LF line endings as it seems the rest of the codebase uses.

The test case files are as follows:

tests/Ticket/2158TestCase.php
tests/Ticket/2251TestCase.php
tests/Ticket/2334TestCase.php
This is causing my git pull on the doctrine 1 github repository to fail due to so called "unmerged" files, and has rendered my git submodule for doctrine just about useless.

I'd appreciate it if someone would run a fromdos on these files and commit them.

[DC-900] HYDRATE_SINGLE_SCALAR option always returns false

Sat, 23 Oct 2010 18:24:25 +0000

I notice that the fetchone with HYDRATE_SINGLE_SCALAR option always returns false as the return to the $collection object is a string type, this is returned by the hydrateResultSet with driver mode set to 6 (I assume this is for scalar values)

My code is a two table query with which returns a string of "10" (g.id in query below) and returns false because it is not a doctrine collection, I did check the doctrine examples and it seems to be the way its used. Not sure if its the doctrine version issue with symfony, my code or an actual bug

$q = Doctrine_Core::getTable('ClipGroup')
->createQuery('g')
->select('g.id')
->leftJoin('g.sfGuardUser u')
->Where('g.completed_at IS NULL')
->andWhere('g.expires_at > ?', date('Y-m-d H:i:s', time()))
->andWhere('u.id = ?', $userId);
return $q->fetchOne(array(), Doctrine_Core::HYDRATE_SINGLE_SCALAR);

I am using doctrine included in symfony 1.4.3, here is the comment on the Query.php file * @version $Revision: 6792 $,
public function fetchOne($params = array(), $hydrationMode = null)
{
$collection = $this->execute($params, $hydrationMode);

if (count($collection) === 0)

{ return false; }

if ($collection instanceof Doctrine_Collection)

{ return $collection->getFirst(); }

else if (is_array($collection))

{ return array_shift($collection); }

return false;
}

Hydrator.php - returns a string * @version $Revision: 3192 $

public function hydrateResultSet($stmt, $tableAliases)

{ $driver = $this->getHydratorDriver($this->_hydrationMode, $tableAliases); $result = $driver->hydrateResultSet($stmt); return $result; }

[DC-896] MySQL Limit implementation leads to incorrect results if the original where clause contains an "OR" operator

Wed, 20 Oct 2010 08:59:51 +0000

If adding the Where In clause for the subquery "limit" implementation, the original where clause needs to be isolated with parenthesis. In my sample where clause the first character is in fact an opening parenthesis and the last character is in fact a closing parenthesis, however, there are a bunch of conditions and parenthesis between them as well that may contain "OR" operators. When this is combined with the Where In clause generated by the Pager tool's "limit" implementation for MySQL it leads to incorrect results.

Here is my "Before" Where condition:

WHERE c.id IN ('25', '31', '6', '28', '30', '16', '32', '26', '22', '14') AND (a2.data_item_id = ? AND a2.value = ?) AND (a3.data_item_id = ? AND a3.value = ?) OR (a4.data_item_id = ? AND a4.value = ?) AND (a5.data_item_id = ? AND a5.value = ?)

And the "After" Where condition
WHERE c.id IN ('25', '31', '6', '28', '30', '16', '32', '26', '22', '14') AND ((a2.data_item_id = ? AND a2.value = ?) AND (a3.data_item_id = ? AND a3.value = ?) OR (a4.data_item_id = ? AND a4.value = ?) AND (a5.data_item_id = ? AND a5.value = ?))

Fix:

Line 1305 in Query.php:
$where = ($where == '' || (substr($where, 0, 1) === '(' && substr($where, -1) === ')'))
? $where : '(' . $where . ')';

I ended up just adding the following just after the above statement in the code:
if (!empty($limitSubquerySql) && !empty($where))

{ $where = '(' . $where . ')'; }

[DC-894] Typo in Doctrine_Manager::getConnectionDrivers()

Tue, 19 Oct 2010 23:59:44 +0000

Hello.

getConnectionDrivers is returning member variable '_connectionsDrivers' at line 809.
It's probably typo, I think this variable name should be '_connectionDrivers'.

[DC-891] [PATCH] Relation array as the result of Doctrine_Table::bind()

Mon, 18 Oct 2010 05:13:29 +0000

It would be handy to return a relation array as the result of Doctrine_Table::bind(), because the relation parser's bind() already returns this value.

[DC-890] public function detach break the nested set tree [patch attached]

Thu, 14 Oct 2010 12:20:06 +0000

If I detach a node from the tree using $node->detach(); it set the left and right value to zero without shifting, creating a possible tree corruption.
It still work somehow because inserting a new node will shift the value but keep the hole in the tree.

I've looked to the original commit in Trac (http://trac.doctrine-project.org/changeset/4089) and I don't think the original idea of the commit was to leave a hole.
I've added 3 lines of code (that I copied from the delete function which works properly), the coresponding patch is joigned to the bug ticket

[DC-883] Help for Test CLI does not list available test groups

Sun, 10 Oct 2010 18:51:17 +0000

The CLI Test Runner is supposed to print a list of available test groups when used with the --help parameter, but this fails as the Doctrine_Test::run() method erroneously expects php sort() to return an array rather than a boolean.

Fixed by http://github.com/acoulton/doctrine1/tree/DC-883

[DC-879] MSSQL - missing function date_part() in Expression/Mssql.php [+patch]

Tue, 5 Oct 2010 04:50:00 +0000

Missing function date_part() in Expression/Mssql.php. I don't know why the set of expressions is different for each driver. This makes it hard to develop database independent.

[DC-872] 1.2 Documentation on Aggregate Functions Error

Tue, 21 Sep 2010 10:55:55 +0000

In the documentation for using aggregate values with Doctrine Query (link below), there is a code snippet that shows how to access the value of the aggregate field, which does not work.

The code snippet is:

//firstsnippet after header
$q = Doctrine_Query::create()
->select('u.id, COUNT(t.id) AS num_threads')
->from('User u, u.Threads t')
->where('u.id = ?', 1)
->groupBy('u.id');

//second snippet after header
$users = $q->execute();

//fourth snippet after header
echo $users->num_threads . ' threads found';

The code from the last snippet for accessing the count value, $users->num_threads, doesn't seem to work. What does work for me is:

//access count value
echo $users[0]->num_threads

//My exact code is:
$query = Doctrine_Query::create()
->select('COUNT as batchCount')
->from('Batch');
$result = $query->execute();

echo $result->batchCount; //10
echo $result[0]->batchCount; //3 (3 is correct, from direct MySQL command line query)

It's certainly possible I'm doing something wrong, or that there is a Doctrine_Core attribute I need to set. If there is a Doctrine_Core attribute to set to automatically access aggregate values from the Collection, it would be worth noting at the top of the section.

Thanks, and thanks for Doctrine (so awesome).

Link:
http://www.doctrine-project.org/projects/orm/1.2/docs/manual/dql-doctrine-query-language/hu#select-queries:aggregate-values

[DC-868] [Documentation] Column aggregation

Thu, 16 Sep 2010 02:40:45 +0000

The example in the documentation at http://www.doctrine-project.org/documentation/manual/1_2/en/inheritance:column-aggregation suggests that the discriminator (in this case 'type') column does not need to be defined in the parent class 'Entity'.

This did not work for me, I had to declare the discriminator column as shown in the 'Taking advantage of column aggregation inheritance' chapter at http://www.doctrine-project.org/projects/orm/1.2/docs/cookbook/taking-advantage-of-column-aggregation-inheritance/en.

[DC-864] Generating YAML schema from model should pick up also charset, collate and other options

Mon, 10 Jan 2011 09:51:03 +0000

I did change Doctrine/Export/Schema.php to pick up some options from model, then they get exported into YAML schema by current code.

Adding the patch. (sorry, can't run the tests, so I'm not sure whether it does break something, really shouldn't)

In my project it works just as expected (did need it for the way I do migrations).

TODO for Doctrine devs:

run tests with my patch and let me know if there's a problem
consider other option names, which are worth of export, so far I did need "charset" and "collate", and I added "queryParts" as well.

I hope my additions make sense and will help you to improve Doctrine project. (and that you will include it, so I don't have custom modified Doctrine )

[DC-861] Make sure doctrine uses the right connection when creating a query from a table object

Wed, 8 Sep 2010 03:46:07 +0000

Line# 1036
When using Table::createQuery, null is specified as the connection when calling Doctrine_Query::create() which results in using the default connection while the "correct" connection can be know ($this->getConnection())

here is the fix:

— a/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Table.php
+++ b/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Table.php
@@ -1033,7 +1033,7 @@ class Doctrine_Table extends Doctrine_Configurable implements Countable

$class = $this->getAttribute(Doctrine_Core::ATTR_QUERY_CLASS);

return Doctrine_Query::create(null, $class)
+ return Doctrine_Query::create($this->getConnection(), $class)
~~>from($this~~>getComponentName() . $alias);
}

[DC-855] Notify via Exception when a feature is specifically not supported for compatability

Thu, 2 Sep 2010 10:30:13 +0000

For situations like with http://www.doctrine-project.org/jira/browse/DC-646 would it be possible to look at throwing an exception with an explanation of why it does not work, rather than simply let the query fail because of intentionally incorrect query generation?

Granted, the fix is relatively simple (just select and delete the results, instead), but if I don't know why the wrong query is being made, I don't know to change my approach rather than simply assume I'm doing something wrong.

[DC-852] CLONE -Fix returned type value : SQL integers to PHP integers when getting a value from the database.

Thu, 2 Sep 2010 08:11:23 +0000

Hi Jon,

I have a request for you to improve Doctrine. When declaring a column as an integer, it seems that Doctrine returns a string when getting the value of that column. For example, if I have a "status" column, which can take 0, 1 or 2 as its value, Doctrine will return these values as string, which is not really logical and returning the good PHP type is the goal of an ORM. I'm fond of the triple equal symbol to test a value and I did not understand why this did not work at start :

// in my myModel class
class myModel extends Doctrine_Record
{
const STATUS_VALIDATED = 1;

public function isValidated()

{ return self::STATUS_VALIDATED === $this->getStatus(); }

}

That's why getStatus() gives me a string instead of an integer, whereas the column is declared as an integer in my schema. I'm forced to cast myself the returned value of getStatus() in my model.

[DC-846] Provide documentation for connection options

Sun, 29 Aug 2010 15:26:57 +0000

Provide additional information on connection options.

$conn = Doctrine_Manager::connection('mysql://username:password@localhost/test', 'connection 1');

just skims the surface. At least link to PDO docs. Also, what is the second parameter? I can look in API docs, but it would be helpful to have in the reference guide.

Are there any other ways to make a connection, such as through an array of parameters?

[DC-843] MSSQL - Equal-to Operator doesn't work with columns of type text in where condition [+patch]

Thu, 2 Sep 2010 08:21:23 +0000

Example:

Doctrine::getTable('Ticket_DCXXX2_Model')->findByUsernameAndFoo('foo', 'bar');

foo is of type "text". Doctrine generates "where .... foo = 'bar'", but this will throw an mssql exception because you cant use the equal to operator in mssql for text and varchar types. Doctrine should consider this database related behavoir, shouldn't it?

[DC-811] calculateQueryCacheHash causes a fatal error when used in combination with output buffering

Tue, 24 Aug 2010 12:49:21 +0000

When using output buffering in combination with a doctrine caching driver. var_export causes a fatal error as described here:

http://marc.info/?l=phpdoc&m=114122422804066
http://php.net/manual/en/function.var-export.php

Here is the proposed patch.

[DC-808] Doctrine_Connection_Statement->execute() Do not pass failing query to Doctrine_Connection->rethrowException()

Thu, 5 Aug 2010 05:22:47 +0000

When Doctrine_Connection_Statement->execute() fail on a query, Exception is rethrown by Doctrine_Connection.

But the failing query is not passed to rethrowException() as third parameter, which make debug very difficult.

See attached patch file to correct this.

[DC-805] Test fails randomly (race condition?)

Sat, 31 Jul 2010 06:24:01 +0000

Hi,

During one of my test builds, one of the test cases failed, probably because of a race condition:

Doctrine_Ticket_1441_TestCase : method testTest failed on line 60
Value1: array (
0 => 'test',
1 => '2010-07-10 02:21:34',
2 => 'jwage',
)
!=
Value2: array (
0 => 'test',
1 => '2010-07-10 02:21:35',
2 => 'jwage',
)

Thanks,
Federico

[DC-803] Syntax error in MySQL migration to drop constraint (patch supplied)

Thu, 29 Jul 2010 11:58:16 +0000

I have a migration that adds constraints correctly. When migrating down, however, I get a syntax error

ErrorMessage

  Error #1 - SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'CONSTRAINT unique_username_idx' at line 1. Failing Query: "ALTER TABLE conUser DROP CONSTRAINT unique_username_idx"

Here is the down migration:

DownMigration

    public function down() {
        $this->dropConstraint('conUser', 'unique_username_idx');
    }

The SQL generated is "ALTER TABLE conUser DROP CONSTRAINT unique_username_idx". This post (http://forums.mysql.com/read.php?98,70887,70974#msg-70974) suggests that in MySQL the syntax should be "ALTER TABLE conUser DROP INDEX unique_username_idx" as constraints are basically indexes in MySQL (unlike MSSQL and Oracle). Doctrine's lib/Doctrine/Export/MySql.php appears to have a syntax error in the dropConstraint method. I attach a patch for this, but the only change is replacing "$name = 'CONSTRAINT '" with "$name = 'INDEX '" in dropConstraint. The migration then runs as I would expect.

Sorry if this has been fixed elsewhere, I did a search but couldn't find a similar ticket.

[DC-796] Correct way to count all files from a table ?

Thu, 22 Jul 2010 11:57:36 +0000

If I execute this to get the amount of records in a table I get the correct result, but it takes too long and consumes a lot of resources as if I get all the fields from table:

Doctrine::getTable('Recurso')~~>findAll()~~>count();

Am I doing it wrong?, The only other option I've found is to use DSQL and execute a query like "SELECT count from recurso".

Thank you in advance.

Pablo.

[DC-781] Column order in generated SQL is based on relationships, instead of SELECT clause

Sat, 10 Jul 2010 05:14:28 +0000

When executing below query as follows:
$q = Doctrine_Query::create()
->select('bc.id, bbl.printed_name, bbl.rate, bc.name, bc.is_rate_variable')
->from('BillBatchLine bbl, bbl.Bill_Charge bc')
->where('bbl.bill_batch_id = ?', $bill_batch_id);
return $q->execute(array(), Doctrine::HYDRATE_NONE);

SQL generated is:
SELECT b.printed_name AS b_printed_name, b.rate AS brate, b2.id AS b2id, b2.name AS b2name, b2.is_rate_variable AS b2_is_rate_variable FROM Bill_Batch_Lines b LEFT JOIN bill_charges b2 ON b.bill_charge_id = b2.id AND (b2.deleted_at IS NULL) WHERE (b.bill_batch_id = '2' AND b.society_id = '1' AND b2.society_id = '1' AND (b.deleted_at IS NULL))

Basically, columns are ordered based on relationships and not as defined in the SELECT clause

[DC-780] Foreign key creation fails with MySQL 5.0.44

Fri, 9 Jul 2010 04:23:24 +0000

Hi there,

When executing symfony doctrine:build --all --and-load on a machine using Mysql 5.0.44 I get the following error:

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'dimension(id)' at line 1. Failing Query: "ALTER TABLE kpi_dimension ADD CONSTRAINT kpi_dimension_dimension_id_dimension_id FOREIGN KEY (dimension_id) REFERENCES dimension(id)".

The problem can be fixed by adding a space between the table name and the column name that is referenced. So instead of
REFERENCES dimension(id)
it should be
REFERENCES dimension (id)

Since it works fine on MySQL 5.1.37, I normally would file this under Mysql bug. But as the syntax for a foreign key constraint in MySQL mentions this space it should be ok to simply add the space to the script creating the sql for the foreign key. I have not tried any other DBMS though.

The patch for the file Export.php is attached.

Best regards

Claudia

[DC-776] $record->link('Alias', $id) throws an exception because of getIdentifier returns array, not string

Mon, 5 Jul 2010 18:05:14 +0000

I want to bookmark ads on my site. So i have Ads table, users table (sfDoctrineGuard) and a refclass Bookmarks. I've created an ajax link to an action, where i retrieved $ad object, $user_id and
$ad->link('Bookmarks', $user_id, true);
So I expected a record in a database to be created.

Bookmarks:
...
columns:
user_id:

{ type: integer(4), primary: true }

ad_id:

{ type: integer(4), primary: true }

relations:
sfGuardUser:

{ onDelete: CASCADE, local: user_id, foreign: id }

Ads:

{ onDelete: CASCADE, local: ad_id, foreign: ad_id }

As my Bookmarks table has 2 primary keys in the link method

if (count($ids) > 0)

{ $q->whereIn($rel->getTable()->getIdentifier(), array_values($this->identifier())); }

$rel->getTable()->getIdentifier() returned me an array('user_id', 'ad_id') instead of a string. So the query which was generated looked like
UPDATE bookmarks SET ad_id = ? WHERE (Array IN )
And Array is not the name of a column.

My schema:
http://pastie.org/private/2lr9gy1h3mtdwdsiwrwylq

I've solved an issue by creating a new Bookmark instance and saving it, but i presume that issue might distract someone.

[DC-772] Different test results in different debian boxes

Sun, 1 Aug 2010 06:34:11 +0000

Hi,

I have two different debian boxes, in one of them all test pass but in the other (a very basic system with just the essential packages installed) i get:

Doctrine_Search_TestCase........................................................failed

Unexpected Doctrine_Record_UnknownPropertyException thrown in [Doctrine_Search_TestCase] with message [Unknown record property / related component "SearchTestIndex" on "SearchTest"] in /home/fgimenez/doctrine/Doctrine-1.2.2/lib/Doctrine/Record/Filter/Standard.php on line 55

#0 /home/fgimenez/doctrine/Doctrine-1.2.2/lib/Doctrine/Record.php(1382): Doctrine_Record_Filter_Standard->filterGet(Object(SearchTest), 'SearchTestIndex')
#1 /home/fgimenez/doctrine/Doctrine-1.2.2/lib/Doctrine/Record.php(1337): Doctrine_Record->_get('SearchTestIndex', true)
#2 /home/fgimenez/doctrine/Doctrine-1.2.2/lib/Doctrine/Access.php(72): Doctrine_Record->get('SearchTestIndex')
#3 /home/fgimenez/doctrine/Doctrine-1.2.2/tests/SearchTestCase.php(48): Doctrine_Access->__get('SearchTestIndex')
#4 /home/fgimenez/doctrine/Doctrine-1.2.2/tests/DoctrineTest/UnitTestCase.php(158): Doctrine_Search_TestCase->testBuildingOfSearchRecordDefinition()
#5 /home/fgimenez/doctrine/Doctrine-1.2.2/tests/DoctrineTest/GroupTest.php(75): UnitTestCase->run()
#6 /home/fgimenez/doctrine/Doctrine-1.2.2/tests/DoctrineTest.php(183): GroupTest->run(Object(DoctrineTest_Reporter_Cli), '')
#7 /home/fgimenez/doctrine/Doctrine-1.2.2/tests/run.php(320): DoctrineTest->run()
#8

{main}

I've been trying to determine which is the package that is installed in one box but not in the other and that make the Doctrine_Search_TestCase test pass, no luck so far (same php and sqlite configuration in both environments).

Any hint on this is highly appreciated, cheers

Federico

[DC-771] fetchOne return boolean

Tue, 29 Jun 2010 07:10:00 +0000

Doctrine_Query::fetchOne could return false..

It a "get" function, so the function should return "null" or an "object", but a boolean isn't a good value..

[DC-767] Doctrine_Migration_Builder::generateMigrationClass() improperly loads migration class

Fri, 25 Jun 2010 11:03:13 +0000

in function: Doctrine_Migration_Builder::generateMigrationClass() the generated migration class is included (require_once) after creation. A loadMigrationClass call is made following [line 513] as:

$this->migration->loadMigrationClass($className);

I propose this should change to include the optional "$path" argument to Doctrine_Migration::loadMigrationClass() as:

$this->migration->loadMigrationClass($className, $path);

Since the $path variable is available for the loadMigrationClass it should be included. More importantly NOT including $path breaks the certains behaviors. This occurs as a side effect in symfony for instance when creating a new task that chains:

doctrine:generate-migrations-diff
doctrine:migrate

The reason for the problem is because the generate-migrations-diff properly creates the version class and file and then has a require_once that pulls the class into scope. doctrine:migrate then runs Doctrine_Migration::loadMigrationClassesFromDirectory() to find all the migration classes. The task does NOT see the newly created migration class because it is not associated with the directory dirname($path) pointed out above. The function thoroughly scans the migration class directory with require_once and array_diff's to find new classes. But the new migrations class is already within declaration scope so is missed. Thus the doctrine:migrate task always migrates to the version BEFORE the executed doctrine:generate-migration-diff.

[DC-763] Timestamp validation does not fail, when missing time in value

Tue, 31 Aug 2010 15:37:05 +0000

Doctrine_Validator_Timestamp does not validate correctly, when missing time information in value!

2009-01-20 -> validator returns true, should be false because of the missing time

[DC-752] Data type "decimal" can be unsigned in MySQL 5.0

Fri, 18 Jun 2010 10:38:31 +0000

I have found in official docs of MySQL v5.0:

http://dev.mysql.com/doc/refman/5.0/en/numeric-type-overview.html

Decimals can be unsigned: DECIMAL[(M[,D])] [UNSIGNED] [ZEROFILL]

Here above is my "schema.yml" file:

schema.yml

 
Project:
  columns:
    id:
      type: integer(4)
      unsigned: true
      primary: true
      autoincrement: true
    salary_range_from:
      type: decimal(12)
      scale: 2
      unsigned: true

After i run:

./symfony doctrine:build --all

my "schema.sql" is:

schema.sql

 
CREATE TABLE `project` (
  `id` INT AUTO_INCREMENT, 
  `salary_range_from` DECIMAL(12, 2), 
  INDEX `company_id_idx` (`company_id`), PRIMARY KEY(`id`)
) DEFAULT CHARACTER SET utf8 ENGINE = INNODB;

[DC-749] Doctrine_Record#getMutators() triggers PHP notice

Thu, 17 Jun 2010 10:30:57 +0000

When calling getMutators() on an instance of Doctrine_Record (eg. $user = new User();), if it hasn't any defined custom mutator yet, we get a

Notice: Undefined index: User in /[...]/Doctrine/Record.php on line 1312

whereas there's no error with getAccessors() (I suppose it was fixed for the second one but not copied to the first one).

Patch is really simple! please see attachment

Regards

[DC-746] Sluggable canUpdate overridden after subsequent updates

Fri, 21 Jan 2011 11:41:17 +0000

When allowing the user to manually change a slug using 'canUpdate' the slug reverts back to it's default generated value upon subsequent saves. Pre-Update on the Sluggable Listener Template seems to incorrectly decide to regenerate the default value.

Example:

$this->actAs('Sluggable', array('unique'=>true, 'fields'=>array('title'), 'canUpdate'=>true));

$record->description = "An example Item";
$record->title = "Example Title";
$record->save();

echo $record->slug; //"example-title" (Correct)

$record->description = "An example Item";
$record->title = "Example Title";
$record->slug = "custom-slug";
$record->save();

echo $record->slug; //"custom-slug" (Correct - First Save)

$record->description = "An example Item";
$record->title = "Example Title";
$record->slug = "custom-slug";
$record->save();
echo $record->slug; //"example-title" (Incorrect - Subsequent Save. Has regenerated it's default slug and lost the user defined one - even though we have passed the users custom one to the object prior to saving it.).

[DC-738] Missing reference to make code usable

Thu, 17 Jun 2010 09:24:58 +0000

Web page documentation is missing some details on following page: // ...
http://www.doctrine-project.org/documentation/manual/1_0/pl/connections:get-connection-name
http://www.doctrine-project.org/documentation/manual/1_2/pl/connections:get-connection-name

I think they were just taken out of context from a page like:
http://www.doctrine-project.org/projects/orm/1.2/docs/manual/connections/en#get-connection-name
where a previous reference to manager .... oops, that page has no previous reference to '$manager' either!!!

Where does the $manager variable come into this? FWIW, I tried that code to get the connection name in a Symfony/Doctrine CLI Task, and it says, 'using object accessor on non object'. I'll keep working on what it's supposed to look like, but the last page above, and every page of documentation derived from it should be checked for the relevance and accuracy of the $manager variable.

[DC-737] generateModelsFromYaml with (generateTableClasses = true) doesn't generate tables classes if (generateBaseClasses = false)

Tue, 15 Jun 2010 09:27:54 +0000

I can't see the reason why Table classes are only generated if Base classes are... (the same occurs for Package classes, but regarding code comments a Package is required to extend a Base class... but a Table can't and won't...)

Here is some... patch? :s (it doesn't make unit tests to fail)

Best regards

[DC-734] With loading "conservative" or "PEAR", Doctrine_Core::loadModels returns different results for identical calls

Tue, 15 Jun 2010 10:57:00 +0000

Hello,

Edit: sorry I changed issue subject, please have a look at the first comment

[DC-732] "charset" and "collation" column options cause seeking for a validator

Tue, 15 Jun 2010 07:17:10 +0000

If a record has a column defined with 'charset' and/or 'collation' in its options, calling $record->save() triggers exception
PHP Fatal error: Uncaught exception 'Doctrine_Exception' with message 'Validator named 'charset' not available.' in /[...]/lib/vendor/doctrine/Doctrine/Validator.php:56

Fix is trivial, see attached patch

Thank you

[DC-729] Doctrine_Parser_Xml numeric key in array

Sat, 12 Jun 2010 01:47:24 +0000

I convert array with numeric keys to xml and recived error message

Warning: SimpleXMLElement::addChild() [simplexmlelement.addchild]: Element name is required in /home/vital/projects/hino/lib/vendor/symfony-1.4.3/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Parser/Xml.php on line 74

array

array
'id' => string '25' (length=2)
'count' => int 3
'cost' => float 68135.27
'user_id' => string '1' (length=1)
'profile_id' => string '1' (length=1)
'created_at' => string '2010-06-12 14:59:52' (length=19)
'OrderProductList' =>
array
0 =>
array
'id' => string '56' (length=2)
'count' => string '1' (length=1)
'cost' => string '9511.82' (length=7)
'user_id' => string '1' (length=1)
'code_1c' => string '2399' (length=4)
'catalog_number' => string '0446537150' (length=10)
'shot_name' => string 'PAD KIT, DISC BRAKE' (length=19)
'name' => string '' (length=0)
'vin' => string '' (length=0)
'engine_model' => string '' (length=0)
'status_id' => string '1' (length=1)
'transport_id' => string '1' (length=1)
'order_id' => string '25' (length=2)
'Order' => boolean false
1 =>
array
'id' => string '57' (length=2)
'count' => int 1
'cost' => float 55787.49
'user_id' => string '1' (length=1)
'code_1c' => string '2629' (length=4)
'catalog_number' => string '4405037040' (length=10)
'shot_name' => string 'ACTUATOR ASSY, BRAKE' (length=20)
'name' => string '' (length=0)
'vin' => string '' (length=0)
'engine_model' => string '' (length=0)
'status_id' => int 1
'transport_id' => int 1
'order_id' => string '25' (length=2)
'Order' => boolean false
2 =>
array
'id' => string '58' (length=2)
'count' => string '4' (length=1)
'cost' => float 2835.96
'user_id' => string '1' (length=1)
'code_1c' => string '2224' (length=4)
'catalog_number' => string 'S156071562' (length=10)
'shot_name' => string 'ELEMENT SET' (length=11)
'name' => string '' (length=0)
'vin' => string '' (length=0)
'engine_model' => string '' (length=0)
'status_id' => int 1
'transport_id' => int 1
'order_id' => string '25' (length=2)
'Order' => boolean false

in doctrine/Doctrine/Parser/Xml.php on line 74

$key = preg_replace('/[^a-z]/i', '', $key);

if (is_array($value) && ! empty($value)) {
$node = $xml->addChild($key);

$key = preg_replace('/[^a-z]/i', '', $key); from 69 line conver numeric key into empty string

[DC-710] doctrine:build-model does not create phpdoc for doctrine builtin attributes (sluggable, timestampable, id)

Tue, 8 Jun 2010 09:51:21 +0000

When defining a table with actAs attributes (Timestampable, Sluggable, ...) doctrine creates columns in the database and corresponding attributes in the model classes, but the PHPDOC in the model classes does not include getters and setters for these "automatic" attributes.
This is unconvenient when using an IDE as the getter are not present in the auto completion.

The enhancement would be to add the appropriate phpdoc @property tags so that symfony can generate all the @method tags.

see http://trac.symfony-project.org/ticket/8711

Thank you

Kevin Hatry

[DC-686] postHydrate listener isn't called for related records

Sun, 5 Sep 2010 12:22:28 +0000

I have model A which has a one-to-one relationship with model B. They both have a listener on them which does an action on postHydrate. When I load model A, the postHydrate is called successfully. However when I then load the related model B (via $oMyModelA->B; or whatever), the listener is not called. This is the same when using the hook on the model - A::postHydrate() is called but B::postHydrate() is not.

Unit test demonstrating this bug is attached.

[DC-642] import/export Array

Thu, 22 Apr 2010 08:04:15 +0000

Retreive an object "A" and some related object from the database.
Export it into an array.
Create an other instance of "A" and import array from the previous exported array.
Just save the new instance.

Doctrine re-create the object into DB. If you have some integrity constraint like primary key, you will see an SQL error.

In the following example with "video" and "tags", Doctrine want to re-create the video and tag objects.
The reason is that the exported array doesn't include the "_identifier" key.

In my mind, the problem show and other problem, that we are force to use the "identifier" or assignIdentifier on the Model domain object to work with an existing object.
Doctrine know the Primary key of all the model domain objects. Why Doctrine doesn't use the assignIdentifier when the user change the PK of the Model domain object... In this case, assignIdentifier could be into a private scope.

$oVideo = Doctrine_Query::create ()
->select ("video., tags.")
->from ("Model_Video video")
->leftJoin ("video.tags tags")
->where ("video.id_show = 500")
->fetchOne ();
$oVideoArray = $oVideo->toArray();
$oVideo->save ();

$oVideoBis = new Model_Video ();
$oVideoBis->fromArray($oVideoArray, true);
$oVideoArrayBis = $oVideo->toArray();
$oVideoBis->save ();

[DC-607] Doctrine concrete inheritance link between tables

Wed, 21 Jul 2010 03:59:18 +0000

Hi,

I pointed out a strange problem:
I have two tables that are linked with a one to many relation ship.
Each table has some concrete inherited tables.
Here is the schema:

Batch:
  columns:
    code: string
    is_pure: boolean

Flask:
  columns:
    batch_id: integer
    code: string
    quantity: integer
  relations:
    Batch:
      local: batch_id
      foreign: id
      foreignType: many
    
ProducedBatch:
  inheritance:
    type: concrete
    extends: Batch
  columns:
    production_date: date
    
BoughtBatch:
  inheritance:
    type: concrete
    extends: Batch
  columns:
    supplier: string
    
ProducedFlask:
  inheritance:
    type: concrete
    extends: Flask
  columns:
    weight: integer
    
BoughtFlask:
  inheritance:
    type: concrete
    extends: Flask
  columns:
    price: integer

The problem occurs when I try to populate the database.
Here is the data:

ProducedBatch:
  B1:
    code: Batch1

ProducedFlask:
  F1:
    Batch: B1
    code: Flask1

When loading fixtures, I get a

Invalid row key specified: (batch) B1, referred to in (produced_flask) F1

In fact, Doctrine doesn't take into account the primary key inherited from Flask table.
The mapping should be done between parent and child tables.

The only solution to solve this is to set a relationship between each couple of sub-table (ProducedFlask -> ProducedBatch and BoughtFlask -> BoughtFlask).

[DC-597] symfony doctrine:generate-migrations-diff task doesn't take attributes into account

Tue, 8 Jun 2010 16:17:57 +0000

I provided the following bug report on the symfony website and was redirected here. The response I received was:

Ticket #8438 (closed defect: invalid)
03/20/10 12:55:04 changed by Kris.Wallsmith

status changed from new to closed.
resolution set to invalid.

The symfony task is a wrapper for the Doctrine task. Please post issues to their Jira. http://www.doctrine-project.org/jira

------------------
Bug details:
------------------

When running doctrine:generate-migrations-diff, I am receiving foreign key files. However, my schema.yml is defined as such:

attributes:
export: tables
TableOne:
columns:
...
TableTwo:
columns:
...

It would appear that when running doctrine:build it properly ignores the foreign key generation, but that it does not when running doctrine:generate-migrations-diff. This task should be corrected to take this attribute into account. Keep in mind that this may be relevant to the other migration tasks, and they should be updated as well if this is a valid bug.

[DC-560] Object1->Unlink(Relation, Id2) doesn't work, if primary key order in table of m2m reference isnt 1:Object 2: Id to unlink, when relation set to EQUAL= TRUE

Thu, 27 Jan 2011 13:26:33 +0000

Object1->Unlink(Relation, Id2) doesn't work, if primary key order in table of m2m reference isnt 1:Object 2: Id to unlink, when relation set to EQUAL= TRUE

User:
  actAs: 
    Timestampable: ~
  columns:    
    name:         { type: string(255), notnull: false }
    last_name:    { type: string(255), notnull: false }
    picture:      { type: string(255), notnull: false }
    birthday:     { type: timestamp, notnull: false }
    gender:       { type: string(255) }
    rating:       { type: integer, default:0} 
    num_comments: { type: integer, default:0} 
    num_groups:   { type: integer, default:0} 
  inheritance:
    extends: Member
    type: column_aggregation
    keyField: type
    keyValue: 1                    
  relations:
    Friends:    { onDelete: CASCADE, class: User, foreignAlias: Friends, refClass: FriendReference, local: user1, foreign: user2, equal: true }
    Request:    { onDelete: CASCADE, class: User, foreignAlias: Pending, refClass: PendingReference, local: user1, foreign: user2 }
    Blocker:    { onDelete: CASCADE, class: User, foreignAlias: Blocked, refClass: BlockedReference, local: user1, foreign: user2 }

 
			if(isset($refToRemove))
			{
				switch ($refToRemove)
				{
					case 'FriendReference': $references = $currentUser->Friends; $relation = 'Friends';	break;
					case 'PendingReference': $references = $currentUser->Pending; $relation = 'Pending'; break;
					case 'BlockerReference': $references = $currentUser->Blocker; $relation = 'Blocker'; break;
					case 'RequestReference': $references = $currentUser->Request; $relation = 'Request'; break;
				}
				 
				foreach($references as $reference)
				{

					if ($reference->id == $user2->id)
                        $currentUser->unlink($relation, array($user2->id), $now = true);
				}
                
			}

when you count relations from one side and the other it show that when set to EQUAL = TRUE relations are reciprocal, but unlink still minds primary keys order in order to function

[DC-497] A new task to set migration to a certain version

Sat, 13 Feb 2010 01:55:11 +0000

It would be nice to have a task which you could tell to set to the proper version. If the migrations_version table did not exist yet, it would create the table and set the version.

Explanation:
Most times migrations come as an after thought after the code db is already pushed live. Therefore you have to manually create the migrations table and set it to a version just before the newest migration.

It might also be better to just update the migrate task to check if a migration_version table exists, if not to just run the single migration which is specified.

[DC-464] [Inheritance] Couldn't save record with inheritance by a relationship if the record has no column modified (solution proposed)

Wed, 9 Jun 2010 06:50:22 +0000

Please consider the following TestCase

Inheritance with no property setted, saved by relationship

class Doctrine_Ticket_DC464_TestCase extends Doctrine_UnitTestCase
{
    public function prepareTables()
    {
        $this->tables[] = 'Ticket_DC464_Entity';
        $this->tables[] = 'Ticket_DC464_Article';
        $this->tables[] = 'Ticket_DC464_User';
        $this->tables[] = 'Ticket_DC464_Group';
        parent::prepareTables();
    }

    public function testTest()
    {
        $User = new Ticket_DC464_User();

        $Article = new Ticket_DC464_Article();
        $Article->title = 'my first article';
        $Article->Author = $User;

        $Article->save();

        $UserFetched = Doctrine::getTable('Ticket_DC464_User')->find(1);
        $this->assertTrue($UserFetched instanceof Ticket_DC464_User);
       //$this->assertEqual($UserFetched->type, 1);


    }
}



class Ticket_DC464_Entity extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->hasColumn('id', 'integer', 11, array('autoincrement' => true, 'primary' => true));
        $this->hasColumn('facultative_field', 'string', 255);
        $this->hasColumn('type', 'string', 255);

        $this->setSubClasses(array(
             'Ticket_DC464_User' =>  array('type' => 1),
             'Ticket_DC464_Group' => array('type' => 2),
        ));

        $this->option('type', 'InnoDB');
    }

    public function setUp()
    {
    }
}

class Ticket_DC464_User extends Ticket_DC464_Entity { }
class Ticket_DC464_Group extends Ticket_DC464_Entity { }

class Ticket_DC464_Article extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->hasColumn('id', 'integer', 11, array('autoincrement' => true, 'primary' => true));
        $this->hasColumn('title', 'string', 30);
        $this->hasColumn('author_id', 'integer', 11);

        $this->option('type', 'InnoDB');
    }

    public function setUp()
    {
        $this->hasOne('Ticket_DC464_User as Author', array(
             'local' => 'author_id',
             'foreign' => 'id'));
    }
}

Notice that in the test, the $User instance has no property setted (in fact in this test, the "useless_field" in the model is... useless).

This test fails (the $User object is not saved) because the method UnitOfWork->saveRelatedLocalKeys() - called in saveGraph(), itself called by $Article->save() - returns false because no column has been modified (line 395).

To fix this, the Record->assignInheritanceValues() should be executed in top of isModified(), or for each related object in UnitOfWork->saveRelatedLocalKeys() (and probably UnitOfWork->saveRelatedForeignKeys() too).

I've attached the test.

[DC-457] Generating YAML schema from DB breaks on certain table names

Wed, 17 Mar 2010 19:25:09 +0000

When attempting to reverse engineer databases using the generate-yaml-db task (via Symfony's doctrine:build-schema task), I've run into some issues due to table names not being compatible with PHP classnames. It creates the PHP classes in /tmp, setting the class name to the same as the table name, and then attempts to build the YAML files off of those.

I attempted to do this a few months ago and ran into issues because some of the table names began with numbers ("123MyTable" is not a valid PHP class name). My most recent attempt failed because of a table named "List", which is a reserved PHP keyword.

While I'm not sure if this is the ideal solution, I think allowing a way to pre-define a prefix for the generated PHP class names would be great.

[DC-422] Using the ON_DEMAND hydrator a warning a thrown on the last iterator of a foreach

Sun, 5 Dec 2010 07:50:19 +0000

Used in a symfony project code similar to the following throws a warning on the last iteration of the foreach

$currentQuery = Doctrine_Query::create()
->from('article a');

$result = $currentQuery->execute(array(), Doctrine_Core::HYDRATE_ON_DEMAND);

foreach ($result as $article)

{ echo $article->getId(); }

The warnings are located in the connection profiler.

symfony-1.4/lib/plugins/sfDoctrinePlugin/lib/database/sfDoctrineConnectionProfiler.class.php on line 196

Warning: join(): Invalid arguments passed in symfony-1.4/lib/plugins/sfDoctrinePlugin/lib/database/sfDoctrineConnectionProfiler.class.php on line 141

I'm unsure how best to fix it. As far as I can tell there is an issue regarding the call to the iterator rewind at the end of the foreach.

Doctrine_Connection_Statement->execute(???) symfony-1.4/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Collection/OnDemand.php:71

[DC-418] Inherited models creating NOT NULL restrictions on their parents

Mon, 11 Jan 2010 18:19:57 +0000

to reproduce, create the yaml included in sample.yaml (Note the not-null columns in each subclass)

if you try to save an OnlineProduct without setting copyright_year, or if you create a print_product without setting website_branding_id, then you will get a not null error.
Inherited tables should be able to set their own NOT NULL columns without affecting other tables in the inheritance tree (should be handled in the preSave() method? or is there another mechanism?)

[DC-354] Using BETWEEN operator with MySQL fails

Tue, 8 Jun 2010 16:34:36 +0000

When running this bit of code the query fails with the error "Unknown aggregate alias: interval", and calling $q->getSql() doesn't return anything.

{{$q = Doctrine_Query::create()
...
->where('u.birthday BETWEEN date_sub(now(), interval 7 day) AND NOW()');}}

I've tried different variations in the where() clause with no luck. I am using all the other MySQL functions in another query here:
$q->where('date(birthday) = date_sub(curdate(), interval 1 day)')
so I don't believe that they are the problem.

I would expect the BETWEEN operator to be recognized and work appropriately.