[DC-403] Eliminate queries produced by Doctrine_Node_NestedSet::getDescendants() when possible

Fri, 16 Apr 2010 12:18:05 +0000

How to reproduce

fetch a tree with nested set

$root = Doctrine::getTable($model)->getTree()->findRoot($rootId);
$treeObject= Doctrine::getTable($model)->getTree()->fetchTree($root->getId());

issue

$root->getNode()->getChildren();

or there will be a total query mess in a lambda function with a loop getChildren().
...
<?php foreach($root->getChildren() as $child): ?>
   ....
<?php endforeach; ?>
...

Problem is described more verbosely here – http://codeutopia.net/blog/2008/08/30/understanding-doctrines-nestedset-feature/

What behavior is expected

An already fetched record instance is returned, without calling database and without causing query flooding.

Like in propel.

In propel if you are calling ....::retrieveTree($id) it returns the root
with completed, pooled (cached) and linked tree.

What happens

An additional query is issued

This is a big slip in architecture of Doctrine`s nested set implementation.

[DC-278] Invalid qubquery generated if using oracle adapter instead of pdo_oci

Wed, 9 Jun 2010 13:02:31 +0000

Doctrine generates the following invalid subquery if oracle adapter is used (same query is generated corret if pdo_oci is used):

SELECT DISTINCT "s2"."code"
FROM "spend_category" "s2"
INNER JOIN "company_spend_category" "c4" ON ("s2"."code" = "c4"."spendcategory_code")
INNER JOIN "company" "c3" ON "c3"."code" = "c4"."company_code"
WHERE "s2"."code" = '19000000'
AND "c3"."is_deleted" IS NOT NULL
AND "s2"."is_deleted" IS NOT NULL
ORDER BY "c3"."name" desc

The problem is that the order by column is not part of the selected columns.

Sample dql statement to reproduce this error: