Doctrine Project

[DC-1049] error with Timestamp data Validation

Sun, 26 Feb 2012 13:09:02 +0000

The default value for timestamp is "0000-00-00 00:00:00", so
$e = explode('T', trim($value))
should be changed to
$e = explode(' ', trim($value))

public function validate($value)
{
if (is_null($value))

{ return true; }

$e = explode('T', trim($value));
$date = isset($e[0]) ? $e[0]:null;
$time = isset($e[1]) ? $e[1]:null;

$dateValidator = Doctrine_Validator::getValidator('date');
$timeValidator = Doctrine_Validator::getValidator('time');

if ( ! $dateValidator->validate($date))

{ return false; }

if ( ! $timeValidator->validate($time)) { return false; }

return true;
}

[DC-676] Validation exception thrown only if internal nesting level == 1

Tue, 8 Jun 2010 16:20:02 +0000

I wonder why Validation exception is thrown only if internal nesting level of transaction is 1 and the manual nesting level is not considered.

Line 262 - lib/Doctrine/Transaction.php:

if ($this->_internalNestingLevel == 1) {
    $tmp = $this->invalid;
    $this->invalid = array();
    throw new Doctrine_Validator_Exception($tmp);
}

I have a large database with a lot of tables and relationships. At some case the validation exception is not thrown if the validation fails.

If I add $this->_nestingLevel into this condition:

if ($this->_internalNestingLevel == 1 || $this->_nestingLevel == 1) {
    $tmp = $this->invalid;
    $this->invalid = array();
    throw new Doctrine_Validator_Exception($tmp);
}

Then the validation exception is thrown as excepted.

I don't know why you ignore here the nesting level.

It would be great if you could explain me more about these lines.

I ran the unit test with this modification and got the same result.

[DC-629] Doctrine Integer Validator should use intval() rather than round(floatval())

Tue, 8 Jun 2010 17:13:14 +0000

echo PHP_INT_MAX;
echo "\n";
echo strval(round(floatval(PHP_INT_MAX)));

on 64 bit machine, default php install, you get:

9223372036854775807
9.22337203685E+18

float precision is set to 12 by default. setting it higher offers no benefit, with it set to 20+, it still doesn't match up (and is actually not reliably past a certain length, i'd have to dig again to find a reference though), but as you can see, no go:

9223372036854775807
9223372036854775808

as a result, very large #'s do NOT validate as doctrine integers, even though they are.

fix, use intval() instead. as far as I can tell, and as far as our 400+ unit tests in our application show, PHP_INT_MAX is fully supported everywhere else except for in Validator.php@170:

170c170
<                  return (string) $var == strval(round(floatval($var)));
---
>                  return (string) $var == strval(intval($var));

[DC-624] Validator_Readonly fails for new objects

Fri, 9 Apr 2010 13:52:37 +0000

If Readonly validator is on for some field, it fails when you trying to create new object (ie. by loading fixtures).

Fix proposition is in attachment.

[DC-835] Inconsistent record validation on a notnull foreign key when the local relation is set

Tue, 24 Aug 2010 22:14:20 +0000

Doctrine_Validator_ForeignKeys_TestCase#testForeignKeyIsValidIfLocalRelationIsSet()

This test passes fine as is. But it fails if I make the following change:

public function testForeignKeyIsValidIfLocalRelationIsSet()
{
    //$person = new TestPerson();
    $address = new TestAddress();
        
    //$address->Person = $person;    
    $address->Person->first_name = "John";
        
    $table = $address->getTable();
    $errors = $table->validateField('person_id', $address->person_id, $address);
        
    $this->assertEqual(0, $errors->count());
}

The only difference is that instead of explicitly assigning $address->Person, I'm letting it happen automatically when assigning the first name. What is it about the property chaining when creating the related record that screws up doctrine's internal reference tracking?

[DC-965] Doctrine is passing timestamps to Doctrine_Validator_Unsigned

Fri, 11 Feb 2011 05:57:09 +0000

Since April last year I've been unable to use Doctrine Timestampable functionality because I get errors like this:

Uncaught exception 'Doctrine_Validator_Exception' with message 'Validation failed in class XXX 1 field had validation error: * 1 validator failed on created_at (unsigned) ' in ...

I've tried lots of different configurations for the timestampable functionality (see my Stack Overflow question for details) to no avail.

I've done some further investigation and the reason for the problem is that the timestamps are being sent to Doctrine_Validator_Unsigned for validation; they are then failing the following regexp test:

        if (preg_match('/[^0-9\-\.]/', $value)) {
            return false;
        }

I'm not smart enough to figure out why Doctrine is calling an unsigned validation test for these timestamps, so for now I've fixed the problem by hacking the following into Doctrine_Validator_Unsigned:

        if (preg_match('/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $value)) {
            return true;
        }

Very ugly I know, but when I add this in the rest of the timestamping functionality works perfectly. Would love to get to the bottom of this bug - is particularly strange because nobody else seems to be experiencing it.

[DC-763] Timestamp validation does not fail, when missing time in value

Tue, 31 Aug 2010 15:37:05 +0000

Doctrine_Validator_Timestamp does not validate correctly, when missing time information in value!

2009-01-20 -> validator returns true, should be false because of the missing time

[DC-732] "charset" and "collation" column options cause seeking for a validator

Tue, 15 Jun 2010 07:17:10 +0000

If a record has a column defined with 'charset' and/or 'collation' in its options, calling $record->save() triggers exception
PHP Fatal error: Uncaught exception 'Doctrine_Exception' with message 'Validator named 'charset' not available.' in /[...]/lib/vendor/doctrine/Doctrine/Validator.php:56

Fix is trivial, see attached patch

Thank you