Doctrine Project

[DC-640] Slugs aren't created when inserting/updating a table row

Mon, 3 May 2010 08:31:15 +0000

Basically the slug column doesn't get updated in spite of all fields being added correctly, as far as i can tell.
It seems to be related to additional options because when i don't have either of the uniqueBy or canUpdate options specified, it just works.

What's been missing is the 'slug' column value in the sql statements (providing 3 examples):

2400 Query INSERT INTO `custom_category` (`block_id`, `name`) VALUES ('1', 'slug test')
2526 Query INSERT INTO `custom_category` (`name`, `block_id`) VALUES ('please do work..', '1')
2560 Query UPDATE `custom_category` SET `name` = 'still not ok' WHERE `id` = '12'

The generated schema.sql includes the correct create table statement (it's also correctly inserted in the db):

CREATE TABLE `custom_category` (
  `id` INT UNSIGNED AUTO_INCREMENT,
  `name` VARCHAR(255) NOT NULL,
  `block_id` INT UNSIGNED NOT NULL,
  `slug` VARCHAR(255),
  UNIQUE INDEX `custom_category_sluggable_idx` (`slug`, `block_id`, `name`),
  INDEX `block_id_idx` (`block_id`),
  PRIMARY KEY(`id`)
) ENGINE = INNODB;

The schema.yml entry is the following:

CustomCategory:
  connection: removed
  tableName: custom_category
  actAs:
    Sluggable:
      fields: [name]
      uniqueBy: [block_id, name]
      canUpdate: true
  columns:
    id:
      type: integer(4)
      unsigned: true
      notnull: true
      primary: true
      autoincrement: true
    name:
      type: string(255)
      notnull: true
    block_id:
      type: integer(4)
      unsigned: true
      notnull: true
  relations:
    Products:
      class: Product
      foreignAlias: CustomCategories
      refClass: ProductCustomCategory
    Block:
      class: Block
      local: block_id
      foreign: id
      foreignType: many
      foreignAlias: CustomCategories
      type: one

And finally the appropriate auto generated base class (removed doc block):

<?php
// Connection Component Binding
Doctrine_Manager::getInstance()->bindComponent('CustomCategory', 'removed');

abstract class BaseCustomCategory extends aaDoctrineRecord
{
    public function setTableDefinition()
    {
        $this->setTableName('custom_category');
        $this->hasColumn('id', 'integer', 4, array(
             'type' => 'integer',
             'unsigned' => true,
             'primary' => true,
             'autoincrement' => true,
             'length' => '4',
             ));
        $this->hasColumn('name', 'string', 255, array(
             'type' => 'string',
             'notnull' => true,
             'length' => '255',
             ));
        $this->hasColumn('block_id', 'integer', 4, array(
             'type' => 'integer',
             'unsigned' => true,
             'notnull' => true,
             'length' => '4',
             ));
    }

    public function setUp()
    {
        parent::setUp();
        $this->hasMany('Product as Products', array(
             'refClass' => 'ProductCustomCategory',
             'local' => 'custom_category_id',
             'foreign' => 'product_id'));

        $this->hasOne('Block', array(
             'local' => 'block_id',
             'foreign' => 'id'));

        $sluggable0 = new Doctrine_Template_Sluggable(array(
             'fields' =>
             array(
              0 => 'name',
             ),
             'uniqueBy' =>
             array(
              0 => 'block_id',
              1 => 'name',
             ),
             'canUpdate' => true,
             ));
        $this->actAs($sluggable0);
    }
}

[DC-623] Impossible to create non-unique slugs

Tue, 31 Aug 2010 11:51:12 +0000

I want to create a non-unique slug of a title field from my table.

But I've found that when I change unique from 'true' to 'false' the slugs were not created or updated

In lib\Doctrine\Template\Listener\Sluggable.php inside preUpdate() function the first if() statement disables the unique (false) option.

[DC-728] Updating slug in I18N behaviour yields non-unique slug

Tue, 5 Oct 2010 11:28:43 +0000

There seems to be a bug in the way, doctrine tries to find a unique slug for a table that is I18N-enabled and has a slug in it.

Following example:

Problem:
  actAs:
    I18n:
      fields: [name]
      actAs:
        Sluggable: { fields: [name], uniqueBy: [lang, name], canUpdate: true }
  columns:
    name: { type: string(255), notnull: true }

Now, if we insert a new entry, the slug get's created as expected. If we now insert another entry that would yield the same slug, the slug is made unique by adding the postfix as expected - all well so far.

Now, if we try to update the entry with the slug with the postfix, what i think is an error happens (Excerpt from Sluggable.php, lib/Doctrine/Template/Listener/Sluggable.php):

 
public function getUniqueSlug($record, $slugFromFields)
...
if ($record->exists()) {
            $identifier = $record->identifier();
            $whereString .= ' AND r.' . implode(' != ? AND r.', $table->getIdentifierColumnNames()) . ' != ?';
            $whereParams = array_merge($whereParams, array_values($identifier));
        }

        foreach ($this->_options['uniqueBy'] as $uniqueBy) {
            if (is_null($record->$uniqueBy)) {
                $whereString .= ' AND r.'.$uniqueBy.' IS NULL';
            } else {
                $whereString .= ' AND r.'.$uniqueBy.' = ?';
                $value = $record->$uniqueBy;
                if ($value instanceof Doctrine_Record) {
                    $value = current((array) $value->identifier());
                }
                $whereParams[] = $value;
            }
        }
...

So, the $record->exists() check evaluates to true and $table->getIdentifierColumnNames() yields the fields id and lang, so the whereString is something like

 
AND r.id != ? AND r.lang != ?

Now for the problematic part:
uniqueBy is lang and name; so the code adds to the whereString:

 
AND r.lang = ? AND r.name = ?

So the resulting whereString has something like

 
r.lang != ? AND r.lang = ?

which will never yield a result in my eyes, thus, the postfix is never incremented and the slug defaults to the the slug of name without postfix.