Doctrine Project

[DC-952] Non-Equal Nest Relations Not Working - from "Children" side

Thu, 24 Mar 2011 04:59:10 +0000

I've copy & pasted example from http://www.doctrine-project.org/projects/orm/1.2/docs/manual/defining-models/1_0#relationships:join-table-associations:self-referencing-nest-relations:non-equal-nest-relations .
I've created User backend module using doctrine:generate-admin backend User task. On how to reproduce the error:

1. Add 3 User objects (A,B,C)
2. Open generated edit form for User A.
3. Set User B as Children from Children list and Save
4. Set User B and C as Chidren from Children list and Save

As a result you will see only C set as Children, and strange situation in database :

UserReference Table:

parent_id | child_id
pk_B | pk_B (!!!)
pk_A | pk_C

[DC-313] Ordering m2m relationship with column from related table (with orderBy option)

Fri, 18 Feb 2011 03:32:42 +0000

I find no way to define automatic orderBy in m2m relations with column not from reference table, but actual related table.

E.g. BlogPost <= m2m through BlogPostCategory => BlogCategory
I need BlogPost->Categories ordered by BlogCategory.name

class BlogPost extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->hasColumn('title', 'string', 128);
        $this->hasColumn('content', 'string');
    }
    
    public function setUp()
    {
        $this->hasMany('BlogCategory as BlogCategories', array('local' => 'id_blog_post', 'foreign' => 'id_blog_category', 'refClass' => 'BlogPostCategory', 'orderBy' => 'name'));        
    }
}

class BlogCategory extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->hasColumn('name', 'string', 128);
    }
    
    public function setUp()
    {
        $this->hasMany('BlogPost as BlogPosts', array('local' => 'id_blog_category', 'foreign' => 'id_blog_post', 'refClass' => 'BlogPostCategory'));
    }
}

class BlogPostCategory extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->hasColumn('id_blog_post', 'integer', null, array('primary' => true));
        $this->hasColumn('id_blog_category', 'integer', null, array('primary' => true));
    }
    
    public function setUp()
    {
        $this->hasOne('BlogPost', array('local' => 'id_blog_post', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
        $this->hasOne('BlogCategory', array('local' => 'id_blog_category', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
    }
}

The resulting query contains doubled 'name' column in ORDER BY clause, both from reference table and related table, e.g. ORDER BY t2.name, t3.name

I tried putting the following code in BlogCategory::setTableDefinition() instead of attribute in relation definition in BlogPost record:

$this->option('orderBy', 'name');

but the result was the same.

Maybe I'm doing something wrong? Is there a possibility to define an alias, where to get column name from - in orderBy attribute?

Thanks in advance.

[DC-770] Result Cache

Tue, 29 Jun 2010 05:50:36 +0000

Doctrine result cache isn't working properly.

Here a simple example, when I'm calling query->execute (); parentProgram is related to a video.
Into the Doctrine_Query_Abstract.php file

line 1014 : I have just add some code to output data.
[code]
if ($cached === false)

{ // cache miss $stmt = $this->_execute($params); $this->_hydrator->setQueryComponents($this->_queryComponents); $result = $this->_hydrator->hydrateResultSet($stmt, $this->_tableAliasMap); $oVideo = $result[0]; echo "not cached "; var_dump (count ($oVideo->parentProgram->getReferences ())); $cached = $this->getCachedForm($result); $cacheDriver->save($hash, $cached, $this->getResultCacheLifeSpan()); }

else

{ $result = $this->_constructQueryFromCache($cached); $oVideo = $result[0]; echo "cached "; var_dump (count ($oVideo->parentProgram->getReferences ())); exit (0); }

[/code]

The output of a query execution (the first with an empty APC cache) with "useResultCache" is :

not cached int(1)
cached int(0)

The problem is coming from the serialize php function that can't serialize protected properties..
getReferences is a getter to a protected property.. So data result can't work properly.

A solution could be use __sleep function, and a public property that contain all important protected data.

[DC-857] postHydrate not called for One to One relations, when ATTR_HYDRATE_OVERWRITE == false, and the record is cached in the table's identityMap

Sun, 5 Sep 2010 12:41:13 +0000

When objects are hydrated with a join to a one to one relation, if the queried object is stored in the table's cache, and ATTR_HYDRATE_OVERWRITE set to false, then the one to one relation's postHydrate method will never be called.

This is due to this line.

 
} else if ( ! isset($prev[$parent][$relationAlias])) {

...which will always evaluate to false, and postHydrate will ever be called, as the record has been pulled from the table cache here

[DC-371] Lazy loading - doctrine makes extra queries into db

Thu, 23 Dec 2010 20:22:10 +0000

Just downloaded symfony 1.4

First of all I have a query:

$q = \Doctrine_Query::create()
->select('u., ur.')
->from('UserDb u')
->leftJoin('u.RealUserDetailsDb ur')
->leftJoin('u.MockUserDetailsDb um')
->where('u.id = :user_id')
;
$user = $q->fetchOne(array(':user_id' => $uid));

After that I'm accessing the fields of this object:

$userArray = array(
'id' => $this->getUser()->getId(),
'real_user_details_id' => $this->getUser()->getRealUserDetailsId(),
'mock_user_details_id' => $this->getUser()->getMockUserDetailsId(),
'real_user_details' => array(),
'mock_user_details' => array()
);

This is the actual queries into DB:

NR1:
SELECT u.id AS u_id, u.user_real_id AS uuser_real_id, u.user_mock_id AS uuser_mock_id, u2.id AS u2id, u2.nickname AS u2nickname, u2.email AS u2_email FROM user u LEFT JOIN user_real u2 ON u.user_real_id = u2.id LEFT JOIN user_mock u3 ON u.user_mock_id = u3.id WHERE (u.id = :user_id)

NR2:
SELECT u.id AS u_id, u.user_real_id AS uuser_real_id, u.user_mock_id AS u_user_mock_id FROM user u WHERE (u.id = '1') LIMIT 1

As you can see there are TWO queries however there should be only one query. The problem is that u.user_real_id is NULL in database and when I do 'real_user_details_id' => $this->getUser()->getRealUserDetailsId() doctrine does not have enough intelligence to understand that these fields have been already requested in NR1. If I comment this field, everything works well.

SURPRISE!
And now a surprise... if I modify a little bit my first query: "~~>select('u.')" instead of , "~~>select('u., ur.*')" it WON'T make TWO queries. It will make ONLY ONE!

As you understand this a very critical bug and of course our system won't go to production with this bug.

P.S. Is it possible to turn off the lazy loading in doctrine?

[DC-489] Doctrine_Record seems to have a bug with default values when updating

Thu, 20 Jan 2011 08:53:02 +0000

So lets see the table:

User:
tableName: users
columns:
id:
type: integer(1)
fixed: false
unsigned: true
primary: true
autoincrement: true
username:
type: string(32)
fixed: false
unsigned: false
primary: false
notnull: true
autoincrement: false
password:
type: string(48)
fixed: false
unsigned: false
primary: false
notnull: true
autoincrement: false
role:
type: enum
fixed: false
unsigned: false
values:

admin
support
default: support <----- Unable to render embedded object: File (ROOT OF EVIL) not found.
primary: false
notnull: true
autoincrement: false

So lets say we have a user with `role` = 'support' and want to set em
'admin' we wrote

$user = new App_Model_User();
$user->assignIdentifier(1);
$user->role = 'admin';
$user->save();
var_dump($user->toArray());

in debugger we see SQL query been made:

[0.55 ms] UPDATE users SET role = ? WHERE id = ?

bindings: admin
1

array(6)

{ ["id"]=> int(1) ["display_name"]=> string(13) "Administrator" ["username"]=> string(4) "root" ["password"]=> string(40) "45bb0f589525a2f0f2a48620bb59b1b8baef0c1d" ["role"]=> string(5) "admin" ["is_active"]=> bool(true) }

Superb! Works as it should! So lets now set role of this user back to
'support':

$user = new App_Model_User();
$user->assignIdentifier(1);
$user->role = 'support'; // This value defined as default in scheme,
thats why have problems
$user->save();
var_dump($user->toArray());

in debugger we didnot see any UPDATE queries! However object is been
changed, results just has not been flushed to database.

array(6)

I cant overcome this problem right now, unfortunatelly (well I can
just remove all default values from table definitions or use
Doctrine_Query for updating staff.. but I'd like to use models

However if I use Doctrine_Query of even

$user = Doctrine_Core::getTable('App_Model_User')->find(1);

instead of

$user = new App_Model_User();
$user->assignIdentifier(1);

updates works well...

[DC-815] Model's default sorting breaks subqueries

Mon, 14 Mar 2011 18:01:49 +0000

It works except subqueries. Main table's order is added to subquery and vice versa. SQL query looks like this:

{{
SELECT t.id AS t_id FROM ticket_d_c9999_record t WHERE (t.id = (SELECT MAX(t2.id) AS t20 FROM ticket_d_c9999__record t2 ORDER BY t.id ASC, t2.id ASC)) ORDER BY t.id ASC, t2.id ASC
}}

Query fails because there is >>no such column "t.id"<<.

I include a testcase when it is all visible.

BTW. there is nothing about that feature (and relation orderBy) in docs. It is only in UPGRADE file.

[DC-725] Call record->get('RelationManyToManyName', FALSE) corrupt the record and generate a exception when calling record->save()

Wed, 9 Jun 2010 07:55:21 +0000

Imagine a simple case. Contact can have many categories.
Doing thoses calls:

$c = Doctrine::getTable('Contact')->findOneById($id);
$c->get('Categories', false);
$c->save();

Generate the following error

PHP Fatal error:  Call to a member function save() on a non-object in /lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Connection/UnitOfWork.php on line 443
PHP Stack trace:
PHP   1. {main}() /test/doctrine/get_with_no_load_corrupt_many_to_many_assoc_.php:0
PHP   2. Doctrine_Record->save() /test/doctrine/get_with_no_load_corrupt_many_to_many_assoc_.php:51
PHP   3. Doctrine_Connection_UnitOfWork->saveGraph() /lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Record.php:1705
PHP   4. Doctrine_Connection_UnitOfWork->saveAssociations() /lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Connection/UnitOfWork.php:137

[DC-934] One-to-one relationship with cascading deletion and softdelete creates empty records

Tue, 29 Nov 2011 13:48:49 +0000

When using softdelete behaviour with cascading deletion on a one-to-one relationship, Doctrine will create a 'child' record if it doesn't exist already, during the cascading deletion. Eg:

Models Foo, Bar, both SoftDelete
Foo hasOne Bar
$myFoo->delete()

Result is:

$myFoo->deleted_at is set correctly as expected
New Bar record is created & saved in the process (but is not set to deleted)

Is this expected behaviour? I've attached a test case script, tested against export from SVN of Doctrine 1.2.3 that demonstrates this.

[DC-912] A method that can run in a model when the model is autoloaded

Tue, 9 Nov 2010 19:20:06 +0000

For my project I needed to be able to reassign connections to models when they are autoloaded – this had to be able to happen during a conservative model loading process before the models had been instantiated. My solution was to build in a hook to a "autoloadSetUp" method which can be attached to any model (or class that is the base for a model).

I will post my patch after I make a test case for it.

Will Ferrer

[DC-908] Can't save Doctrine Expression AES_ENCRYPT into a utf8_general_ci field

Sun, 31 Oct 2010 08:36:36 +0000

$membre = new Model_TMembre();
$membre->password = new Doctrine_Expression("AES_ENCRYPT(\"".htmlspecialchars($password,ENT_QUOTES)."\",\""._MYSQL_CRYPT."\")");
$membre->save();

Doesn't works id password field is encoded into utf8_general_ci .

Works fine id password field is encoded into latin1 .

[DC-893] Using default value for bigint fields generates an error

Mon, 25 Oct 2010 16:27:06 +0000

A field defined as:
'user_id' => array(
'type' => 'bigint',
'length' => 22,
'default' => 0,
),

Generates an error when create-tables is used:
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' [...] user_id bigint(22) DEFAULT , INDEX schedule_prize_id_idx (schedule_prize_id)[..]

The default value is not accounted for.

[DC-887] disabling deep option with toArray() drops relations in result

Wed, 13 Oct 2010 11:06:39 +0000

Using the toArray() on a Doctrine_Record object with the deep option set to true (default) correctly converts the whole object to an array including the relations.
But when the deep option is disabled the relations are not converted to array's (as expected) but they are lost, I would expect them to still be there in their original form (objects).

I've attached a fix. Another solution would be to add a flag that disables deep array conversion but enables relation persistence.

[DC-884] Doctrine_Collection::loadRelated uses getLocal instead of getLocalFieldName

Mon, 18 Feb 2013 20:52:07 +0000

Having a camelcase fieldname with a lowercase column name causes loadRelated of doctrine collection to throw an unknown property error, fix:

Change

$rel     = $this->_table->getRelation($name);

        if ($rel instanceof Doctrine_Relation_LocalKey || $rel instanceof Doctrine_Relation_ForeignKey) {
            foreach ($this->data as $record) {
                $list[] = $record[$rel->getLocal()];
            }
        }

to:

$rel     = $this->_table->getRelation($name);

        if ($rel instanceof Doctrine_Relation_LocalKey || $rel instanceof Doctrine_Relation_ForeignKey) {
            foreach ($this->data as $record) {
                $list[] = $record[$rel->getLocalFieldName()];
            }
        }

public function populateRelated($name, Doctrine_Collection $coll)
    {
        $rel     = $this->_table->getRelation($name);
        $table   = $rel->getTable();
        $foreign = $rel->getForeign();
        $local   = $rel->getLocal();

public function populateRelated($name, Doctrine_Collection $coll)
    {
        $rel     = $this->_table->getRelation($name);
        $table   = $rel->getTable();
        $foreign = $rel->getForeignFieldName();
        $local   = $rel->getLocalFieldName();

[DC-882] Doctrine Collection FromArray doesn't adhere to KeyColumn

Sat, 9 Oct 2010 11:48:38 +0000

Using the following in the base class:

$this->setAttribute(Doctrine_Core::ATTR_COLL_KEY, 'class');

Then executing a query to array the indexes of the entity are not that of the class field:

example:

array(
 0 => ..
 1 => ...
);

fix:

/**
     * Populate a Doctrine_Collection from an array of data
     *
     * @param string $array 
     * @return void
     */
    public function fromArray($array, $deep = true)
    {
        $data = array();
        foreach ($array as $rowKey => $row) {
            $this[$rowKey]->fromArray($row, $deep);
        }
    }

/**
     * Populate a Doctrine_Collection from an array of data
     *
     * @param string $array 
     * @return void
     */
    public function fromArray($array, $deep = true)
    {
        $data = array();
        $keyColumn = $this->keyColumn;
        foreach ($array as $rowKey => $row) {
            $rowKey = $keyColumn AND isset($row[$keyColumn]) ? $row[$keyColumn] : $rowKey;
            $this[$rowKey]->fromArray($row, $deep);
        }
    }

[DC-845] One of our Foreign Keys is not being inserted/passed

Fri, 27 Aug 2010 12:06:42 +0000

We are working on a symfony/doctrine project and have come to a near halt on development.

We feel that now, it may be a bug/feature in doctrine, regarding foreign keys

Part of our model includes a join table that references three different table. Below is a diagram of what the model looks like, and the relevant portion of our schema.yml is at the bottom.

Image of our schema: http://imgur.com/dfFYI.png

We have a form that contains a set of embedded forms that attempt to create a new Person entry and add rows to the join table, adding items to the PersonName table as needed.

The form attempts to do this by creating and saving PersonName objects with NameType parameters, but are running into the problem of Doctrine not including that column when trying to do an insert into the join table.

Part of the problem seems to be caused by the Doctrine_Connection_UnitOfWork::saveAssociations method:

foreach ($v->getInsertDiff() as $r)

{ $assocRecord = $assocTable->create(); $assocRecord->set($assocTable->getFieldName($rel->getForeign()), $r); $assocRecord->set($assocTable->getFieldName($rel->getLocal()), $record); $this->saveGraph($assocRecord); }

Are we correct in understanding that this means that Doctrine 1.2 does not support tables with multiple foreign keys in this scenario?

Here is the relevant portion of schema.yml:

agPerson:
columns:
id:
primary: true
type: integer(5)
autoincrement: true
relations:
agPersonName:
class: agPersonName
refClass: agPersonMjAgPersonName
local: person_id
foreign: person_name_id
agPersonNameType:
class: agPersonNameType
refClass: agPersonMjAgPersonName
local: person_id
foreign: person_name_type_id
agPersonNameType:
columns:
id:
primary: true
type: integer(2)
autoincrement: true
person_name_type:
unique: true
type: string(30)
notnull: true
app_display:
default: 1
type: boolean
notnull: true
relations:
agPerson:
class: agPerson
refClass: agPersonMjAgPersonName
local: person_name_type_id
foreign: person_id
agPersonName:
class: agPersonName
refClass: agPersonMjAgPersonName
local: person_name_type_id
foreign: person_name_id
agPersonName:
columns:
id:
primary: true
type: integer(5)
autoincrement: true
person_name:
unique: true
type: string(64)
notnull: true
relations:
agPerson:
class: agPerson
refClass: agPersonMjAgPersonName
local: person_name_id
foreign: person_id
agPersonNameType:
class: agPersonNameType
refClass: agPersonMjAgPersonName
local: person_name_id
foreign: person_name_type_id
agPersonMjAgPersonName:
columns:
id:
primary: true
type: integer(5)
autoincrement: true
person_id:
type: integer(5)
notnull: true
person_name_id:
type: integer(5)
notnull: true
person_name_type_id:
type: integer(2)
notnull: true
is_primary:
type: boolean
notnull: true
indexes:
UX_ag_person_mj_ag_person_name:
fields: [person_name_id, person_name_type_id, person_id]
type: unique
relations:
agPerson:
local: person_id
foreign: id
agPersonName:
local: person_name_id
foreign: id
agPersonNameType:
local: person_name_type_id
foreign: id
actAs:
Timestampable:

As a caveat: we've noticed that sfdoctrineguard group table, has such a relationship:

mysql> describe sf_guard_user_group;
---------------------------------------+

Field

Type

Null

Key

Default

Extra

---------------------------------------+

user_id	int(11)	NO	PRI	0
group_id	int(11)	NO	PRI	0
created_at	datetime	NO		NULL
updated_at	datetime	NO		NULL

---------------------------------------+

i.e. IT has two foreign keys taken into account

[DC-1011] wierd behaviour with setTableName - table name doesn't get set

Tue, 28 Jun 2011 13:03:34 +0000

if i create class called Attribute_set that extends Doctrine_Record and setTableName in setUpTableDefinintion like in documentation setting up models section, the table name appears not to be set
getTableName returns "doctrine_record_abstract"

any joins or relations fail.

if i set it in the setUp function the setTableName appear working and returns "attribute_sets" table name. This only happens with this particular class, and relations have no effect.

I attached class example i'm expiriencing problems with, that should help reproducte this issue

[DC-979] Doctrine save() only checks one level deep on one-to-one relations.

Sun, 27 Feb 2011 23:36:08 +0000

Updating/saving an object fails when trying to update the nth-level of an existing object/relation where n is more than one level away from the root node of one-to-one relation chain. For example, with the yaml model below the following does not update the name of the Company object:

Image->Product->Category->Company->name = "Acme".

If "Product" has no changes it appears to stop checking for changes there. If we do a save on a one-to-many relation chain such as the following, it works fine:

Company->Category->Product->Image->name = "image1.jpg"

I was able to fix this issue by modifying the saveRelatedLocalKeys() function in UnitOfWork.php to use isModified() with deep=true:

if ($obj instanceof Doctrine_Record && $obj->isModified(true)) {

This works but I'm not sure if changing this has any repercussions on more complex queries.

—
detect_relations: true
options:
collate: utf8_general_ci
charset: utf8
type: InnoDB

Company:
tableName: Company
columns:
id:
type: integer(4)
primary: true
notnull: true
autoincrement: true
name:
type: string(45)

Category:
tableName: Category
columns:
id:
type: integer(4)
primary: true
notnull: true
autoincrement: true
companyId:
type: integer(4)
notnull: true
name:
type: string(45)
relations:
Company:
class: Company
local: companyId
foreign: id
foreignAlias: categories
onDelete: cascade
onUpdate: cascade
indexes:
fk_Category_Company1:
fields: [companyId]

Product:
tableName: Product
columns:
id:
type: integer(4)
primary: true
notnull: true
autoincrement: true
categoryId:
type: integer(4)
notnull: true
name:
type: string(45)
relations:
Category:
class: Category
local: categoryId
foreign: id
foreignAlias: products
onDelete: cascade
onUpdate: cascade
indexes:
fk_Product_Category1:
fields: [categoryId]

Image:
tableName: Image
columns:
id:
type: integer(4)
primary: true
notnull: true
autoincrement: true
productId:
type: integer(4)
notnull: true
name:
type: string(45)
relations:
Product:
class: Product
local: productId
foreign: id
foreignAlias: images
onDelete: cascade
onUpdate: cascade
indexes:
fk_Image_Product1:
fields: [productId]

[DC-967] Problems with fetchArray() combined with leftJoin() by using aliases of columns

Sun, 13 Feb 2011 18:46:58 +0000

They are some strange problems with hydration to array combined with aliases of columns and JOINS. Let's see this example:

$q = Doctrine_Query::create ()
->select('c.id AS id, c.path AS path, c.name AS name, cbc.product_count')
->from('Category c')
->leftJoin('c.CategoryBrowserCache cbc');

$categories = $q->fetchArray();

This example will throw exception: "The root class of the query (alias lc) must have at least one field selected."

OK. Let's change code a little bit. Let's add alias for cbc.product_count column too:

$q = Doctrine_Query::create ()
->select('c.id AS id, c.path AS path, c.name AS name, cbc.product_count AS product_count')
->from('Category c')
->leftJoin('c.CategoryBrowserCache cbc');

$categories = $q->fetchArray();
print_r($categories);

Now code executed without exception, BUT $q->fetchArray() returned only ONE (first) record hydrated to array. Other results were ignored.

Let's change code one more time:

$q = Doctrine_Query::create ()
->select('c.id, c.path, c.name, cbc.product_count AS product_count')
->from('Category c')
->leftJoin('c.CategoryBrowserCache cbc');
$categories = $q->fetchArray();
print_r($categories);

Like you see I just removed all aliases for columns for Category. Now code will be executed without exceptions, All results will be hydrated into array as expected to be. Actually the same result can be reached by removing at least one alias for any Category column.

[DC-961] Copy uses mutators but does not use accessors

Fri, 28 Jan 2011 15:42:06 +0000

I have a column that contains a serialized string of data. The accessor for that column unserializes the data and the mutator serializes. When calling copy the accessor is not used but the mutator is causing the mutator to fail because it receives a string instead of an object as its value.

The lines of code creating this problem follow:

Record.php

 public function copy($deep = false)
 {
    $data = $this->_data; //does not use accessor
...
    $ret = $this->_table->create($data); // does use mutator
...
}

I have currently patched my copy function with the following:

// $data = $this->_data
$data = $this->toArray(false);

[DC-1056] Doctrine is not compatible with PHP 5.4 due to change in serialize() behaviour.

Mon, 28 Jan 2013 19:45:13 +0000

In PHP 5.4 there is a change in the way the object references are serialized:

Quote:
"Support for object references in recursive serialize() calls
Prior to PHP 5.4, object references where not saved in recursive serialize calls."

This minor change, breaks down serialization of collections when column of type "array" is present - double serialization occurs.
I'm attaching a patch fixing the issue.

[DC-453] Joined records stated as dirty (whereas they are not modified)

Thu, 29 Jul 2010 15:58:54 +0000

When you retrieve records like this:

(Here I have Labels, that have Albums)

$lab = Doctrine::getTable('Label')->createQuery('lab')
->leftJoin('lab.Albums alb')
->select('lab.id, alb.id')
->where('lab.id = ?', 1)
->fetchOne();

$lab->state() is STATE_PROXY : it's ok, properties are not all loaded from the DB and the object is not modified

BUT $lab->Albums[0]->state() is STATE_DIRTY : why ? the object is not modified...

This causes real problems, because this way, joined objects unloaded properties are corrupted : it really behaves like they all are "null", and that's all. Their real values are never loaded from the DB.

[DC-326] Running out of memory while executing single record lookup.

Mon, 7 Dec 2009 21:06:03 +0000

I have the model class as follows:

schema.yml

options:
  collate: utf8_unicode_ci
  charset: utf8
  type: INNODB
Identity:
  tableName: Identity
  columns:
    id:
      type: integer(4)
      fixed: false
      unsigned: false
      primary: true
      autoincrement: true
    username:
      type: string(50)
      fixed: false
      unsigned: false
      primary: false
      notnull: true
      autoincrement: false
    email:
      type: string(50)
      fixed: false
      unsigned: false
      primary: false
      notnull: true
      autoincrement: false
    password:
      type: string(100)
      fixed: false
      unsigned: false
      primary: false
      notnull: true
      autoincrement: false
    created_at:
      name: created_at
      type: timestamp
      # default: CURRENT_TIMESTAMP
      fixed: false
      unsigned: false
      primary: false
      notnull: true
      autoincrement: false
    updated_at:
      name: updated_at
      type: timestamp
      fixed: false
      unsigned: false
      primary: false
      default: null
      notnull: false
      autoincrement: false
  relations:
    Roles:
      class: Role
      local: id
      foreign: ident_id
      type: many
    Token:
      local: id
      foreign: entity_id
      type: many
    Devices:
      class: Device
      local: id
      foreign: account_id
      type: many
    Rides:
      class: Ride
      local: id
      foreign: account_id
      type: many
    OwnGroups:
      class: CoachGroup
      local: id
      foreign: owner_id
      type: many
    GroupMemberships:
      class: GroupMembership
      local: id
      foreign: ident_id
      type: many
  actAs:
    Timestampable:
      created:
        name: created_at
        type: timestamp
        expression: NOW()
      update:
        onInsert: false
Role:
  tableName: Role
  columns:
    identId:
      name: ident_id
      type: integer(4)
      fixed: false
      unsigned: false
      primary: true
      autoincrement: false
    role:
      type: string(50)
      fixed: false
      unsigned: false
      primary: true
      autoincrement: false
  relations:
    Identity:
      onDelete: CASCADE
      onUpdate: CASCADE
      local: ident_id
      foreign: id
      foreignAlias: Roles
Token:
  tableName: Token
  columns:
    entity_id:
      name: entity_id
      type: integer(4)
      fixed: false
      unsigned: false
      notnull: true
      primary: false
      autoincrement: false
    token:
      name: token
      type: string(50)
      fixed: true
      unsigned: false
      primary: true
      default: ''
      notnull: true
      autoincrement: false
    type:
      type: enum(50)
      fixed: false
      unsigned: false
      values:
        - EMAIL_VERIFICATION
        - PASS_RESET
      primary: false
      default: EMAIL_VERIFICATION
      notnull: true
      autoincrement: false
    created_at:
      type: timestamp(25)
      fixed: false
      unsigned: false
      primary: false
      notnull: true
      autoincrement: false
    expires_at:
      type: timestamp(25)
      fixed: false
      unsigned: false
      primary: false
      notnull: false
      autoincrement: false
  indexes:
    entity:
      fields: [entity_id]
  relations:
    Identity:
      onDelete: CASCADE
      onUpdate: CASCADE
      local: entity_id
      foreign: id
      type: one
  actAs:
    Timestampable:
      created:
        name: created_at
        type: timestamp
      updated:
        disabled: true

and my unit test for the model:

TokenModelTest.php

$t = new lime_test(3);
$t->diag("=== Token model test ===");

$t->info('Token creation =>');
$token = new Token();
$token->setEntityId(1);
$token->generateUniqueToken();

$t->info('Set valid token type...');
$token->setType(Token::TYPE_EMAIL_VERIFICATION);
try{
  $t->info('Saving the token...');
  $token->save();
  $t->pass('Token was saved successfully...');
}
catch(Exception $e){
  $t->is(($e instanceof Exception), true, $e->getMessage());
}

$t->isnt($token->getCreatedAt(), null, ' Creation datetime is set to '.$token->getCreatedAt().'...');

$t->info('Get this token from DB...');
$tokenFromDb = Doctrine::getTable('Token')->findOneByToken($token->getToken());

$t->info('Compare the two...');
$t->is($tokenFromDb->getEntityId(), $token->getEntityId(), 'Entity ID...');
$t->is($tokenFromDb->getToken(), $token->getToken(), 'Token string...');
$t->is($tokenFromDb->getType(), $token->getType(), 'Token string...');
$t->is($tokenFromDb->getCreatedAt(), $token->getCreatedAt(), 'Token creation date...');
$t->is($tokenFromDb->getExpiresAt(), $token->getExpiresAt(), 'Token expration date...');
$t->is($tokenFromDb->getExpiresAt(), null, 'Token expration date is null...');

$t->info('Delete token...');
$t->is($token->delete(), true, 'Successful deletion...');

On test execution on this line:

$tokenFromDb = Doctrine::getTable('Token')->findOneByToken($token->getToken());

I'm getting a fatal error:

ERROR

# === Token model test ===
> Token creation =>
> Set valid token type...
> Saving the token...
ok 1 - Token was saved successfully...
ok 2 -  Creation datetime is set to 2009-12-04 01:13:31...
> Get this token from DB...
PHP Fatal error:  Allowed memory size of 268435456 bytes exhausted (tried to allocate 261900 bytes) in /ApacheWebServer/htdocs/Clients/enki/enkiweb/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Core.php on line 550

Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 261900 bytes) in /ApacheWebServer/htdocs/Clients/enki/enkiweb/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Core.php on line 550

[DC-280] Add pre/postHydrateResultSet() events

Tue, 8 Jun 2010 16:09:38 +0000

Over the last several weeks I've been working on streamlining the access control logic in the application I'm working on, and I realized that Doctrine's event listeners might be able to help. For more detailed background information take a look at http://groups.google.com:80/group/dallasphp/browse_thread/thread/91e3f107cd611adf ...but here's the problem in a nutshell:

Since my application's access control logic is all implemented in PHP rather than in the database (i.e., I can't add access control to my queries as a simple WHERE clause), I'm looking for a way to hook into the query process just after the records have been hydrated and actually modify the result set that gets returned, such that only permissible records show up in the final result set.

Unfortunately, although there are several listener methods that look promising for this, none of them seem to have access to the data being returned. For instance, if I run a custom query via Doctrine_Query::execute(), the postQuery() hook definitely runs ...but it doesn't give me access to anything but the query string itself.

Since, in some instances (e.g., hydration listeners), the Doctrine_Event object is assigned arbitrary data that the listener can modify, I'm wondering if the same thing couldn't be done more universally?

[DC-684] After adding a Reference, the ForeignKeys in the DB are not updatet

Tue, 26 Oct 2010 08:13:33 +0000

After query a record from the DB, where a foreign key is null, and changing only the reference belonging to this foreign key, and only these reference no other value of the record, a save of the record doesn't lead to a change in the foreign key field.

For example: I'll save a user record with some data of a regestration and give him the possibillity to add a city where he cames from later in his account settings, if no other user attribute is changed, the state of the user record is still CLEAN. The result is that I can access the user->City property correctly only as long as no refresh from the db is done. So the changing of the foreign key belonging to the city isn't persistent in the DB.

Example Code:
$user = new Model_User();
$user->firstName = md5(rand());
$user->save();

$id = $user->id;
unset($user);
assert(! $user);

$user = Model_UserTable::getInstance()->find($id);
assert(!$user->relatedExists('City'));

$user->City->name = 'Mainz';
$user->save();
unset($user);

$user = Model_UserTable::getInstance()->find($id);
$user->refresh(true);
assert($user->City->name == 'Mainz');

The last assert failse. I realized the problem while updating just a referenz using the fromArray() method like $user->City->fromArray(). The city would be saved correctly in DB but the foreign key in the user table would not be updated. After debugging I recognized that the $user is not replaced in UnitOfWork::saveGraph() because the $user is still in CLEAN state.

Using " $user->coreSetRelated('Country', $user->Country);" or "$user->state(Doctrine_Record::STATE_DIRTY);" after "$user->City->name = 'Mainz'" would fix the prob in this case. As well as creating a new City instance an set $user->City with this instance like:

$city = new Model_City();
$city->name = 'Mainz';
$user->City = $city;

Also $user->isModified(true) is true. So I fixed the issues in my case by changing the state of my records to DIRTY if the "$this->state() == CLEAN && $user->isModified(true) == true" in the preSave() method of an abstract class that my Base classes are extending....

[DC-649] Getting Doctrine_Validator_Exception on Doctrine_Record::replace() when using unique

Mon, 26 Apr 2010 11:41:15 +0000

Using this code:

$user = new User();
$user->mail = 'mail@mail.mail';
$user->save();
$user2 = new User();
$user2->mail = 'mail@mail.mail';
$user2->replace();

I get the following exception:

Fatal error: Uncaught exception 'Doctrine_Validator_Exception' with message 'Validation failed in class User: 1 field had validation error: 1 validator failed on mail (unique)' in D:\Workspace\Doctrine\Doctrine\Transaction.php:265
Stack trace:
#0 D:\Workspace\Doctrine\Doctrine\Connection.php(1395): Doctrine_Transaction->commit(NULL)
#1 D:\Workspace\Doctrine\Doctrine\Connection\UnitOfWork.php(143): Doctrine_Connection->commit()
#2 D:\Workspace\Doctrine\Doctrine\Record.php(1748): Doctrine_Connection_UnitOfWork->saveGraph(Object(User), true)
#3 D:\Workspace\test.php: Doctrine_Record->replace()
#4

{main}

thrown in D:\Workspace\Doctrine\Doctrine\Transaction.php on line 265

[DC-635] synchronizeWithArray and link-table

Fri, 16 Apr 2010 09:07:30 +0000

Tree tables : tags, compo_show_tag, shows

"compo_show_tag" make a link between tags and shows. It's a many-to-many relationship.

Assume that all the Tags / Shows are already create. The max id is 300 for shows and tags.

$itemArray = array ();
$itemArray["_identifier"] = 38;
$itemArray["shows"][0]["_identifier"] = 36;
$itemArray["shows"][1]["_identifier"] = 200;

$item = new Model_Tag ();
$item->synchronizeWithArray($itemArray, true);

echo $item->shows[0]->idShow; //Output : 36
echo $item->shows[1]->idShow; //Output : 200

$item->save ();

Above create two entry into the compo_show_table. Because all element are existing.

$itemArray = array ();
$itemArray["_identifier"] = 38;
$itemArray["shows"][0]["_identifier"] = 36;

$item = new Model_Tag ();
$item->synchronizeWithArray($itemArray, true);

echo $item->shows[0]->idShow; //Output : 36

$item->save ();

Above remove the relation between Show#200 and Tag#38, but keep the relation between Show#36 and Tag#38.

$itemArray = array ();
$itemArray["_identifier"] = 38;
$itemArray["shows"][0]["_identifier"] = 36;
$itemArray["shows"][1]["_identifier"] = 150;
$item = new Model_Tag ();
$item->synchronizeWithArray($itemArray, true);

echo $item->shows[0]->idShow; //Output : 36
echo $item->shows[1]->idShow; //Output : 150

$item->save ();

Above create a new relation, like the first example.

$itemArray = array ();
$itemArray["_identifier"] = 38;
$itemArray["shows"][0]["_identifier"] = 36;
$itemArray["shows"][1]["_identifier"] = 140;

$item = new Model_Tag ();
$item->synchronizeWithArray($itemArray, true);

echo $item->shows[0]->idShow; //Output : 36
echo $item->shows[1]->idShow; //Output : 140

$item->save ();

Bug is above.
We except that Doctrine remove the relation between Show#150 and Tag#38 and add a new one between Show#140 and Tag#38.
Here the bug because Doctrine doesn't change anything.

Thanks.
Armetiz.

[DC-619] preHydrate/postHydrate events do not use proper sub-class component

Mon, 14 Jun 2010 09:28:51 +0000

I am trying to use preHydrate/postHydrate with my models that use inheritance. The problem is that when using the parent table is used to query the records, the preHydrate/postHydrate events are passed to the parent record class instead of the proper sub-class for the current record.

Using the example schema below, if I do a findAll() on the Person table and it contained two Student records and one Professor record... preHydrate would get called on Person instead of Student and Professor. This also applies for any listeners that are registered on Student/Professor and not Person.

Person:
columns:
name:

{ type: string(50) }

Student:
inheritance:
extends: Person
type: column_aggregation
keyField: type
keyType: 1

Professor:
inheritance:
extends: Person
type: column_aggregation
keyField: type
keyValue: 2

[DC-589] refreshRelated() causes an id to be changed from string to int, causing an unnecessary update query.

Mon, 29 Mar 2010 14:51:08 +0000

Here is an example:

class Article extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->hasColumn('title', 'string', 255);
        $this->hasColumn('body', 'string', 4096);
    }

    public function setUp()
    {
        $this->hasMany('Comment as Comments', array(
            'local' => 'id',
            'foreign' => 'articleId',
        ));
    }
}

class Comment extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->hasColumn('comment', 'string', 4096);
        $this->hasColumn('articleId', 'integer');
    }

    public function setUp()
    {
        $this->hasOne('Article', array(
            'local' => 'articleId',
            'foreign' => 'id',
        ));
    }

    public function preUpdate($e)
    {
        throw new Exception('should not get here');
    }

}

$a = new Article();
$a->title = 'Hi';
$a->body = 'There';
$a->save();

$c = new Comment();
$c->comment = '1st comment';
$c->articleId = $a->id;
$c->save();

$a->refreshRelated('Comments');

$a->title = 'Hello';
$a->save();

What happens above is that the call to refreshRelated() causes the 'id' of the comment to change from string:1 to int:1, which causes the last save of the article to try to save the comment. The exception is there just to illustrate that the Comment is being updated (which should not happen). For us - this is an issue not just because of the extra query, but because some entities in the system (like log entries) actually throw when updated.

Tested against latest trunk.

The issue seems to be introduced in r7361.

[DC-541] MSSQL Server: Enabling MARS prevents the saving of records.

Thu, 10 Jun 2010 04:40:57 +0000

This is related to issue #540. In order to circumvent that issue, I enabled MARS (Multiple Active Result Sets) - now when attempting to save any record the following error results:

Fatal error: Uncaught exception 'Doctrine_Transaction_Exception' with message 'Rollback failed. There is no active transaction.' in C:\www\doctrine\lib\Doctrine\Transaction.php on line 319

This is actually caused by the following MSSQL error:

exception 'Doctrine_Transaction_Exception' with message 'SQLSTATE[42000]: Syntax error or access violation: 3997 [Microsoft][SQL Server Native Client 10.0][SQL Server]A transaction that was started in a MARS batch is still active at the end of the batch. The transaction is rolled back. (SQLExecDirect[3997] at ext\pdo_odbc\odbc_driver.c:247)' in C:\www\doctrine\lib\Doctrine\Transaction.php:212 Stack trace: #0 C:\www\doctrine\lib\Doctrine\Transaction.php(511): Doctrine_Transaction->beginTransaction(NULL) #1 C:\www\doctrine\lib\Doctrine\Connection.php(1377): Doctrine_Transaction->beginInternalTransaction(NULL) #2 C:\www\doctrine\lib\Doctrine\Connection\UnitOfWork.php(64): Doctrine_Connection->beginInternalTransaction() #3 C:\www\doctrine\lib\Doctrine\Record.php(1691): Doctrine_Connection_UnitOfWork->saveGraph(Object(Model)) #4 C:\www\doctrine\tools\sandbox\index.php(83): Doctrine_Record->save() #5

{main}

I haven't worked out what's going on yet, but this blog post may shed some light on it:
http://blogs.msdn.com/cbiyikoglu/archive/2006/11/21/mars-transactions-and-sql-error-3997-3988-or-3983.aspx

I've attached a script to reproduce this issue in the sandbox (MARS is enabled in the DSN).

[DC-478] Having a default value in a decimal field in base class forces Doctrine to try to save an instance even if not required.

Thu, 4 Feb 2010 09:49:13 +0000

I have 2 classes. Order and Branch. An Order class can have one or no branch assigned to it. My base class definition for a branch is simple. It just has a name.

The Order class has:
$this->hasColumn('branchId', 'integer');

and

$this->hasOne(
'Fds_Model_Branch as branch',
array(
'local' => 'branchId',
'foreign' => 'id',
)
);

The branch class had this:

$this->hasColumn('name', 'string', 50, array(
'notnull' => true,
'notblank' => true,
));

No hasMany relation back to Orders.

Using this setup, all my tests work.

I added this to the Branch class.
$this->hasColumn(
'localTax', 'decimal', null,
array(
'notnull' => true,
'default' => 0,
)
);

Now my tests fail with a validator error from the branch class for the name property whenever I try to save an order that has no branch associated to it. Pretty weird right? I mean, my order has no branch, and yet Doctrine tries to save one.

But if I change the definition of localTax to this:
$this->hasColumn('localTax', 'decimal');

Then my tests work as expected again. Problem is, I need to assign the default value of 0 to localTax instead of null.

Is this a bug?

[DC-476] PHP's is_subclass_of function causing failure in some contexts

Fri, 30 Apr 2010 11:04:48 +0000

I have a suspicion that this is related to issue: DC-386

The bug manifested its-self by bailing with no php error output when calling Doctrine_Pager::execute() in php 5.2.10 (5.3 appears to work - Mac OS X while 5.2.10 fail on ubuntu and centos).

I traced this down to Doctrine_Record::processPendingFields(), the offending line number is #477.

Interestingly, if I call is_subclass_of() with exactly the same params in my view just prior to calling Doctrine_Pager::execute() in my code, the error does not present its-self , i.e. I'b adding the following code :

is_subclass_of('Doctrine_Hydrator_RecordDriver', 'Doctrine_Hydrator_Graph');

It can also be avoided by calling Doctrine_Pager::getQuery()->getQuerySql(); and no doubt other code paths which change the environment in some way.

[DC-835] Inconsistent record validation on a notnull foreign key when the local relation is set

Tue, 24 Aug 2010 22:14:20 +0000

Doctrine_Validator_ForeignKeys_TestCase#testForeignKeyIsValidIfLocalRelationIsSet()

This test passes fine as is. But it fails if I make the following change:

public function testForeignKeyIsValidIfLocalRelationIsSet()
{
    //$person = new TestPerson();
    $address = new TestAddress();
        
    //$address->Person = $person;    
    $address->Person->first_name = "John";
        
    $table = $address->getTable();
    $errors = $table->validateField('person_id', $address->person_id, $address);
        
    $this->assertEqual(0, $errors->count());
}

The only difference is that instead of explicitly assigning $address->Person, I'm letting it happen automatically when assigning the first name. What is it about the property chaining when creating the related record that screws up doctrine's internal reference tracking?

[DC-814] protected method _isValueModified returns wrong result

Tue, 10 Aug 2010 06:58:58 +0000

    protected function _isValueModified($type, $old, $new)
    {
        if ($new instanceof Doctrine_Expression) {
            return true;
        }

        if ($type == 'boolean' && (is_bool($old) || is_numeric($old)) && (is_bool($new) || is_numeric($new)) && $old == $new) {
            return false;
        } else if (in_array($type, array('decimal', 'float')) && is_numeric($old) && is_numeric($new)) {
            return $old * 100 != $new * 100;
        } else if (in_array($type, array('integer', 'int')) && is_numeric($old) && is_numeric($new)) {
            // getType($old) in many cases is always 'string' so using operator '!=='  is make no sense 
            // the only needed condition is already checked: i mean 'is_numeric'
            return $old !== $new;
        } else if ($type == 'timestamp' || $type == 'date') {
            $oldStrToTime = strtotime($old);
            $newStrToTime = strtotime($new);
            if ($oldStrToTime && $newStrToTime) {
                // the same here: it's make no sense to using '!==' - first and second variable are the same type 
                return $oldStrToTime !== $newStrToTime;
            } else {
                return $old !== $new;
            }
        } else {
            return $old !== $new;
        }
    }

[DC-810] Doctrine relations: Doctrine_Record::fromArray() does not update local field when new linked record is created

Fri, 6 Aug 2010 06:00:47 +0000

Doctrine_Record::fromArray() does not update local field when new linked record is created.

Case:

1. I have a model1 with a hasOne relation to model2.

2. I have a record in model1 with no model2 related

3. Then i try to update model1 adding a new related model2 record using Doctrine_Record::fromArray(), model2 is created (Doctrine_Record::toArray() shows me the new row in model2, created and linked to model1)

4. When I save and refresh model1, relation disappear (local field on model1 who links to model2 is empty).

So it seems that Doctrine_Record::fromArray() doesn't recognize the change on model1 if I link it to a new foreign record. In fact if I modify some other field in model1, create and link a new model2 record, all works good!

Digging in Record.php I found a trick, Doctrine_Record::fromArray() doesn't update the state of the model when relations are touched, so I force record state to Doctrine_Record::STATE_DIRTY.

Diff file is attached, but it's still a workaround.

[DC-797] Records containing a one-to-one relation are hydrated as dirty/modified

Wed, 6 Jul 2011 19:31:56 +0000

Attached is a self-contained 80 line test. In the test, Foo has an one to one relation to Bar. There is a null value in the foreign key column (at least one Foo without a Bar). And the relation is being used via this DQL:

Doctrine_Query::create()->from('Foo f')->leftJoin('f.Bar b')->execute();

At around line 254 of Doctrine_Hydrator_Graph/Graph.php, the hydrator sets the value of the relation column to Doctrine_Null if there is no related record:

$prev[$parent][$relationAlias] = $this->getNullPointer();

This causes Doctrine_Record to check if the value of the foreign key field was updated, which it does by calling Doctrine_Record::_isValueModified(). However, that method considers an update from null to Doctrine_Null as a modification. So, the record (and eventually the entire Collection returned) is marked as Doctrine_Record::STATE_DIRTY, even though it contains no modifications. This occurs during hydration, so the caller never sees the record as being clean.

The workaround I'm using is to subclass Doctrine_Record, and return false from _isValueModified() when moving from null to Doctrine_Null. But I think this could also be fixed in the hydrator.

[DC-774] Cannot fromArray a toArray with many to many records

Thu, 1 Jul 2010 20:04:35 +0000

When working with a many to many record, if you toArray then synchronizeWithArray/fromArray the result - you get an exception.

This appears to be due to the fact that toArray returns collections of array(0 => false) (because a record is in a locked state) and fromArray will attempt to link() the refClass (which has multiple identifiers).

Here's a test that should show this behavior:

class Doctrine_Ticket_DC774_TestCase extends Doctrine_UnitTestCase
{
    public function prepareTables()
    {
        $this->tables[] = 'EntityAddress';
        $this->tables[] = 'Book';
        parent::prepareTables();
    }

    public function prepareData()
    {
        $user = new User();
        $user->name = 'TestUser';

        $address = new Address();
        $address->address = 'TestAddress';

        $user->Addresses[] = $address;
        
        $user->save();
    }

    public function testToArraySynchronizeWithManyToMany() {
        $user = Doctrine_Core::getTable('User')->findOneByName('TestUser');
        $user->refreshRelated();
        $user->synchronizeWithArray($user->toArray());
    }

    public function testToArrayFromManyToMany() {
        $user = Doctrine_Core::getTable('User')->findOneByName('TestUser');
        $user->refreshRelated();
        $user->fromArray($user->toArray());
    }
}

[DC-704] Where fields not escaped properly when deleting associations.

Mon, 14 Jun 2010 08:26:40 +0000

We noticed that in both Doctrine/Record.php and Doctrine/Connection/UnitOfWork.php the fields in the where clause arent being escaped properly. A few of our fields happen to be keywords, but it seems that these queries arent escaping the names of fields that happen to be keywords.

I have verified the field name is in the keywords list for my driver.

This happens near the following code:
Doctrine/Record.php:2465
Doctrine/Record.php:2476
Doctrine/Connection/UnitOfWork.php: 443

[DC-852] CLONE -Fix returned type value : SQL integers to PHP integers when getting a value from the database.

Thu, 2 Sep 2010 08:11:23 +0000

Hi Jon,

I have a request for you to improve Doctrine. When declaring a column as an integer, it seems that Doctrine returns a string when getting the value of that column. For example, if I have a "status" column, which can take 0, 1 or 2 as its value, Doctrine will return these values as string, which is not really logical and returning the good PHP type is the goal of an ORM. I'm fond of the triple equal symbol to test a value and I did not understand why this did not work at start :

// in my myModel class
class myModel extends Doctrine_Record
{
const STATUS_VALIDATED = 1;

public function isValidated()

{ return self::STATUS_VALIDATED === $this->getStatus(); }

}

That's why getStatus() gives me a string instead of an integer, whereas the column is declared as an integer in my schema. I'm forced to cast myself the returned value of getStatus() in my model.

[DC-1018] Circular references to named entities break during data importing

Thu, 14 Jul 2011 10:59:18 +0000

If the schema specifies that records relate to each other in both directions:

{{
Kitten:
columns:
basket_id: integer
relations:
Basket:
local: basket_id

Basket:
columns:
fluffiest_kitten_id: integer
relaitons:
FluffiestKitten:
type: one
class: Kitten
local: fluffiest_kitten_id
}}

Then a data dump for such a schema won't properly load one of the keys, e.g:

{{
Kitten:
Kitten1:
Basket: Basket1

Basket:
Basket1:
FluffiestKitten: Kitten1
}}

Will result in either fluffiest_kitten_id or basket_id being set to 0

[DC-950] Doctrine_Record magic _set() doesn't validate field type for timestamp/datetime/etc..

Mon, 24 Jan 2011 11:36:01 +0000

So I ran into this recently. the magic _set() in Doctrine_Record doesn't check/validate the type of the field. The use case is when you you do something like:
setCreatedAt(time()); This will not work correctly with date/time or timestamp types in Doctrine, even though Propel handles this fine. Also MYSQL will not throw an error with default sql_mode and will put garbage data into the database.

The only way to generate the right date/time value is to always format that string with the "right" format. This should be easier and can be easier if it supported either a timestamp (time() or a DateTime() object (just like Symfony plugin does for setDateTimeObject() function). This is just a few lines of code, let me know if I should attach a patch.

I would love to see the Doctrine_Record implement this functionality. There's a ton of results on frustrated users trying to figure out how to set the date/time values properly using Doctrine.

[DC-1044] record Line 2430 Unlink method Warning: Illegal offset type in sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Record.php on line 2459

Mon, 5 Dec 2011 00:01:28 +0000

When you have a new unpersisted object and you call a method to a referenced object - when calling the unlink() method on referenced object the above error is called.

Warning: Illegal offset type in sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Record.php on line 2459

$foo = new foo();

$foo->getBar(); This call will bind a reference of Bar against the foo object.

$foo->unlink('bar');

As no objects are yet persisted, the unlink method tries to match ids on the objects that do not exist.

[DC-418] Inherited models creating NOT NULL restrictions on their parents

Mon, 11 Jan 2010 18:19:57 +0000

to reproduce, create the yaml included in sample.yaml (Note the not-null columns in each subclass)

if you try to save an OnlineProduct without setting copyright_year, or if you create a print_product without setting website_branding_id, then you will get a not null error.
Inherited tables should be able to set their own NOT NULL columns without affecting other tables in the inheritance tree (should be handled in the preSave() method? or is there another mechanism?)

[DC-686] postHydrate listener isn't called for related records

Sun, 5 Sep 2010 12:22:28 +0000

I have model A which has a one-to-one relationship with model B. They both have a listener on them which does an action on postHydrate. When I load model A, the postHydrate is called successfully. However when I then load the related model B (via $oMyModelA->B; or whatever), the listener is not called. This is the same when using the hook on the model - A::postHydrate() is called but B::postHydrate() is not.

Unit test demonstrating this bug is attached.

[DC-642] import/export Array

Thu, 22 Apr 2010 08:04:15 +0000

Retreive an object "A" and some related object from the database.
Export it into an array.
Create an other instance of "A" and import array from the previous exported array.
Just save the new instance.

Doctrine re-create the object into DB. If you have some integrity constraint like primary key, you will see an SQL error.

In the following example with "video" and "tags", Doctrine want to re-create the video and tag objects.
The reason is that the exported array doesn't include the "_identifier" key.

In my mind, the problem show and other problem, that we are force to use the "identifier" or assignIdentifier on the Model domain object to work with an existing object.
Doctrine know the Primary key of all the model domain objects. Why Doctrine doesn't use the assignIdentifier when the user change the PK of the Model domain object... In this case, assignIdentifier could be into a private scope.

$oVideo = Doctrine_Query::create ()
->select ("video., tags.")
->from ("Model_Video video")
->leftJoin ("video.tags tags")
->where ("video.id_show = 500")
->fetchOne ();
$oVideoArray = $oVideo->toArray();
$oVideo->save ();

$oVideoBis = new Model_Video ();
$oVideoBis->fromArray($oVideoArray, true);
$oVideoArrayBis = $oVideo->toArray();
$oVideoBis->save ();

[DC-776] $record->link('Alias', $id) throws an exception because of getIdentifier returns array, not string

Mon, 5 Jul 2010 18:05:14 +0000

I want to bookmark ads on my site. So i have Ads table, users table (sfDoctrineGuard) and a refclass Bookmarks. I've created an ajax link to an action, where i retrieved $ad object, $user_id and
$ad->link('Bookmarks', $user_id, true);
So I expected a record in a database to be created.

Bookmarks:
...
columns:
user_id:

{ type: integer(4), primary: true }

ad_id:

{ type: integer(4), primary: true }

relations:
sfGuardUser:

{ onDelete: CASCADE, local: user_id, foreign: id }

Ads:

{ onDelete: CASCADE, local: ad_id, foreign: ad_id }

As my Bookmarks table has 2 primary keys in the link method

if (count($ids) > 0)

{ $q->whereIn($rel->getTable()->getIdentifier(), array_values($this->identifier())); }

$rel->getTable()->getIdentifier() returned me an array('user_id', 'ad_id') instead of a string. So the query which was generated looked like
UPDATE bookmarks SET ad_id = ? WHERE (Array IN )
And Array is not the name of a column.

My schema:
http://pastie.org/private/2lr9gy1h3mtdwdsiwrwylq

I've solved an issue by creating a new Bookmark instance and saving it, but i presume that issue might distract someone.

[DC-749] Doctrine_Record#getMutators() triggers PHP notice

Thu, 17 Jun 2010 10:30:57 +0000

When calling getMutators() on an instance of Doctrine_Record (eg. $user = new User();), if it hasn't any defined custom mutator yet, we get a

Notice: Undefined index: User in /[...]/Doctrine/Record.php on line 1312

whereas there's no error with getAccessors() (I suppose it was fixed for the second one but not copied to the first one).

Patch is really simple! please see attachment

Regards