Doctrine Project

[DC-914] Doctrine_Pager ignores custom COUNT query

Mon, 7 Nov 2011 22:54:46 +0000

I found some problem when I tried to define custom query for results counting. Defined custom COUNT query is totally ignored and executed default one. I will give you full description of problem bellow.

We have following source code:

 
$q_select = Doctrine_Query::create ()
->select ( 'DISTINCT p.product_name AS product_name' )
->from ( 'Product p' )
->where( 'p.product_name LIKE ?', '%motorola%');
				
$q_count = Doctrine_Query::create ()
->select ( 'COUNT (DISTINCT p.product_name) num_results' )
->from ( 'Product p' )
->where( 'p.product_name LIKE ?', '%motorola%');
												
$pager = new Doctrine_Pager( $q_select, 1, 25 );										
$pager->setCountQuery($q_count);

Let's check custom query before calling $pager->execute() method:

 
echo $pager->getCountQuery();

Output:

 
SELECT COUNT (DISTINCT p.product_name) num_results FROM Product p WHERE p.product_name LIKE ?

Looks like until now is everything is correct. Let's call $pager->execute() method:

 
$products = $pager->execute();

Let's check executed queries using Symfony SQL queries log panel:

SELECT COUNT(*) AS num_results FROM product p WHERE p.product_name LIKE '%motorola%'
7.27s, "doctrine" connection

SELECT DISTINCT p.product_name AS p__0 FROM product p WHERE (p.product_name LIKE '%motorola%') LIMIT 25
3.25s, "doctrine" connection

Executed COUNT query is not same we set using $pager->setCountQuery($q_count). Our defined custom COUNT query is totally ignored and executed default one:

INSTEAD OF THIS CUSTOM COUNT QUERY:

SELECT COUNT (DISTINCT p.product_name) num_results FROM Product p WHERE p.product_name LIKE '%motorola%'

EXECUTED DEFAULT COUNT QUERY:

SELECT COUNT(*) AS num_results FROM product p WHERE p.product_name LIKE '%motorola%'

[DC-897] Pager ignores default model hasMany ORDER BY statements, caused by getLimitSubquery ignoring same

Wed, 10 Nov 2010 01:41:21 +0000

Our model configuration includes several hasMany statements, for example:

$this->hasMany('Subcategory as Subcategories', array(
'refClass' => 'SubcategoryTone',
'local' => 'tone_id',
'foreign' => 'subcategory_id',
'cascade' => array('delete'),
'orderBy' => 'order_id',
));

We noticed that the ORDER BY directive worked just fine with a normal query, but the order by was being ignored when we fed it into the Pager.

For example:
$aa = $t->execute(array(), Doctrine_Core::HYDRATE_ARRAY);
var_dump($aa[4]);

$pager = new Doctrine_Pager($t, $currentPage, $resultsPerPage);
$bb = $pager->execute(array(), Doctrine_Core::HYDRATE_ARRAY);

var_dump($bb[4]);

These two var_dumps would give different results because the ORDER BY is ignored by the limit subquery in the pager.

[DC-312] Doctrine_Pager query "influences" Doctrine::getTable() query

Wed, 2 Dec 2009 10:20:19 +0000

When I use the same procedure without Doctrine_Pager everything works fine, with Doctrine_Pager the behavior of later queries is strange. Example:
----------------WORKING:
1. I fetch list
Doctrine_Query::create()~~>select('z.,s.,o.*,u.jmeno as Vložil,k.nazev_cs as Kategorie')~~>from('ShopZbozi z,z.Obrazek o,z.Soubor s,z.Uzivatel u,z.ShopKategorie k')~~>orderby('z.nazev_cs ASC')~~>fetchArray();

2. I fetch a row to edit independently on the list above
$object = Doctrine::getTable('ShopZbozi')->find(123);

3. edit properties of the object...

4. $object->replace();
the object is fetched with no related objects like [Uzivatel] or [Soubor], so when I change for example $object->iduzivatel (related Uzivatel object id) and save it is OK

----------------BROKEN:
1. I fetch list in Pager
new Doctrine_Pager(Doctrine_Query::create()~~>select('z.,s.,o.*,u.jmeno as Vložil,k.nazev_cs as Kategorie')~~>from('ShopZbozi z,z.Obrazek o,z.Soubor s,z.Uzivatel u,z.ShopKategorie k')~~>orderby('z.nazev_cs ASC'),$this~~>page,$this->perpage);

2. I fetch a row to edit independently on the list above (in contrast to the first working example this $object is fetched with EMPTY RELATION OBJECTS, which causes inserting empty new rows when calling ->replace())
$object = Doctrine::getTable('ShopZbozi')->find(123);

3. edit properties of the object...

4. $object->replace();
-> the $object has all the related object fetched as it was defined in the list in Pager - like it was used as a template for getTable and when ->replace() - new empty related objects are inserted in DB.

I've been using Doctrine for I guess 2 years now and I believe this bug/strange behavior has always been there.
Maybe I'm wrong and it is not a bug, but the behavior is strange and it took me really long to find where the problem is and I still don't know how to use pager without influencing the later queries.
Thanx John Mathew

[DC-188] Pager breaks when HAVING clause references existing table column

Tue, 20 Jul 2010 01:14:31 +0000

Pager breaks when HAVING clause references any existing table column.

Query used:

$q = Doctrine_Query::create()
->select("u.id, u.first_name, u.last_name, u.is_active")
->addSelect('COUNT(u.id) as rolecount')
->from('User u')
->leftJoin('u.Roles r')
->groupBy('u.id')
->having("rolecount > 2 and u.is_active = 1");

Execution of query by itself works fine (eg via execute(), fetch...)

When putting this query in a Doctrine_Pager, error outputs:

$pager = new Doctrine_Pager(
$q,
$currentPage,
$resultsPerPage
);

$pager->execute();

Error Received:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'u.is_active' in 'having clause'

[DC-544] Doctrine_Pager bug with Oracle. getNumResults doesn't return the correct number of records

Thu, 18 Mar 2010 08:02:39 +0000

The function getNumResults() doesn't work correctly.

This is my model class

class ReviewListTable extends Doctrine_Table
{
 public function getAvailable()
 {
   return $this->createQuery()
   ->select('DISTINCT(to_char(file_date, \'YYYY-MM-DD\')) fdate')
   ->orderBy('fdate DESC');
 }
}

If i execute this fonction, the number of record is 31. If i use the Pager, the result is 5744 records

Controler:

$this->pager = new Doctrine_Pager(
                           Doctrine_Core::getTable('ReviewList')->getAvailable(),
                           $request->getParameter('page', 1),
                           20);

View:

$rs = $this->pager->execute();
echo $pager->getNumResults();

[DC-739] Pager returns incorrect page number when constructed on query with HAVING

Wed, 16 Jun 2010 03:16:39 +0000

//method returns those categories that have any products, it returns 3 records
public function getCategoriesWithProductsQuery()

{ $query = $this->createQuery('z')->select( 'z.*, COUNT(p.id) prod_number' ) ->leftJoin( 'z.AdvertiseProducts p' )->groupBy( 'z.id' )->having('prod_number > 0'); return $query; }

//but when i do count() on created pager it returns 8 records (which is equal to categories in my database):

$doctrinePager = $this->getServiceContainer()
->setParameter('doctrine_pager.model', 'ZwCategory')
->getService('doctrine_pager')
~~>setMaxPerPage($this~~>maxPerPage)
->setQuery($query)
~~>setPage(null === $page ? $this~~>page : $page)
->init();
var_dump(count($doctrinePager));

//pager works, but it "thinks" that there are more pages than in reality. with maxPerPage = 2, it thinks that there are 4 pages, but looking at query result it //should be only 2 pages.