Doctrine Project

[DC-1040] allow queries with table joins across different databases

Thu, 17 Nov 2011 14:42:03 +0000

I'm currently working on a project which relies upon several databases declared in databases.yml in symfony 1.4.8.

I was facing an issue that has already been raised by other people, namely that you can't join tables which reference each other among different mysql databases.

I've dug a bit in the Doctrine_Query class and came to a solution that is acceptable for us, and allows now to make joins accross databases. Description follows :

first change is in the Doctrine_Core class, that gets stuffed with a new constant :
const ATTR_DATABASE_NAME = 0x1DB;

this constant allows us to add a new attribute to the databases.yml file as in :
gesdoc:
class: sfDoctrineDatabase
param:
dsn: mysql:host=127.0.0.1;dbname=gesdoc
username: root
password:
attributes:

************* NEW ATTRIBUTE BELOW ************
database_name: gesdoc
default_table_collate: utf8_general_ci
default_table_charset: utf8

after that, a few changes have been done in the Doctrine_Query class which is attached to this issue for the sake of readability.

This may not be optimal, and probably need some regression testing, but it is currently working fine on our test server.

after this is done, I was able to issue queries like the following :
$x = DocumentTable::getInstance()->createQuery('d')
->distinct()
->leftJoin('d.Travail t')
->leftJoin('t.CdcIndInt ci')
->leftJoin('ci.CdcIndExt ce')
->leftJoin('ce.Cahierdescharge cdc')
->where('cdc.cdc_chro = ?', $cdc_chro)
->addWhere('d.id != ?', $document_id)
->execute();

where the referenced tables are in different databases. The necessary object binding has been done in every model class following the paradigm :

Doctrine_Manager::getInstance()->bindComponent('CdcIndInt ', 'gescdc');
abstract class BaseCdcIndInt extends sfDoctrineRecord
{
...
}

I don't know if this description is clear enough, so let me know if something is missing/wrong.

[DC-1031] CLONE -Multiple connections and i18n (raised as unresolved - original ticket marked as resolved)

Wed, 28 Mar 2012 08:20:53 +0000

I used to work with a single database named "doctrine". The query was working properly.

I then decided to use 2 databases so I got my schema like this:

connection: doctrine

Category:
actAs:
I18n:
actAs:
Sluggable:
fields: [name]
Timestampable: ~
fields: [name, description]
columns:
id: ~
name:
type: string(255)
notnull: true
description: string

User:
connection: second
columns:
id: ~
name:
type: string(255)
notnull: true

I did setup my connections in config/databases.yml this way:

all:
doctrine:
// ....
second:
// ....

build-model, build-forms, build-filters and cc got ran. But now, I got an exception saying the "Translation" relation doesn't exist. The Base Models include correctly the bindComponent line:

Doctrine_Manager::getInstance()->bindComponent('Category', 'doctrine');

For now, I managed to kind of fixing it with simply swapping the databases order in my config/databases.yml and it's now working again perfectly.

I forgot to mention that in the CategoryTable when i call $this->getConnection()->getName(), it outputs "second"

[DC-1004] ATTR_TBLNAME_FORMAT not used when creating models from database

Sun, 8 May 2011 04:34:52 +0000

if you set prefix to "xyz_%s" and have the model "BackgroundColor" it will become the table => "xyz_background_color"
if you have the table "xyz_background_color" with unknown model and create the the model from the table, you will get => "XyzBackgroundColor".

The fix (diff):

368a369,370
> $tablePrefix = $manager->getAttribute(Doctrine_Core::ATTR_TBLNAME_FORMAT);
>
381d382
<
385c386
< $definition['className'] = Doctrine_Inflector::classify(Doctrine_Inflector::tableize($table));
—
> $definition['className'] = Doctrine_Inflector::classify(Doctrine_Inflector::tableize(preg_replace(sprintf('/\A%s\z/', str_replace('%s', '(.*?)', $tablePrefix)), '$1', $table)));
396c397
< $class = Doctrine_Inflector::classify(Doctrine_Inflector::tableize($table));
—
> $class = Doctrine_Inflector::classify(Doctrine_Inflector::tableize(preg_replace(sprintf('/\A%s\z/', str_replace('%s', '(.*?)', $tablePrefix)), '$1', $table)));

[DC-941] Spatial index type for mysql

Mon, 29 Nov 2010 14:43:57 +0000

I'm using doctrine and some of mysql's spatial functions. I need to specify spatial index for my tables.
My declaration looks like:

Geometry:
tableName: geometry
options:
type: MyISAM
collate: utf8_unicode_ci
charset: utf8
columns:
id:
type: integer(4)
primary: true
autoincrement: true
geometry:
type: geometry
notnull: true
indexes:
geometry:
fields:

geometry
type: spatial

Exporting this definitions throws an exception: Unknown type spatial for index geometry_idx

[DC-924] type mismatch for keyfield in column aggregation

Thu, 11 Nov 2010 12:02:12 +0000

This is the doc exemple on column aggregation inheritance :

Entity:
columns:
username: string(20)
password: string(16)
created_at: timestamp
updated_at: timestamp

User:
inheritance:
extends: Entity
type: column_aggregation
keyField: type
keyValue: 1

Group:
inheritance:
extends: Entity
type: column_aggregation
keyField: type
keyValue: 2

But the keyField (type) is created as VARCHAR(255) so PostgreSQL return an error on applying inheritance condition :

SQLSTATE[42883]: Undefined function: 7 ERROR: operator does not exist: character varying = integer
LINE 1: ...D s.application = 'frontend' AND s.lft = 1) AND (s.type = 2)
^
HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts.

I found this with symfony sfFilebasePlugin on sfFilebase:create-root task.

[DC-895] [I18n] Defining languages with locality (eg. en_GB) breaks functionality with SQL Integrity error - fix included

Wed, 20 Oct 2010 04:42:40 +0000

When defining languages as language_COUNTRY codes (supported by symfony by default), the functionality to work with I18n records breaks, resulting in "SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry" errors.

The reason is very simple: Doctrine's I18n language column is defined as a CHAR(2), thus shortening eg. "en_GB" value to "en", thus causing the above SQL error when a "en" translation for a record already exists.

The solution is even simpler: change the column's length to 7 in the Doctrine_I18n class's options: I've tested this and all runs great: the correct SQL is being generated, the models behave correct, ...

[DC-832] PostgreSQL - lastInsertId fails because sequence name on table with column alias on primary key does not work [+patch]

Tue, 24 Aug 2010 12:34:55 +0000

PostgreSQL - lastInsertId fails because sequence name on table with column alias on primary key does not work.

DDL created sequence name: <table>_<column name>
Last Insert ID sequence name: <table>_<identifier> (identifer is the field name which can be different to the column name)

[DC-826] Doctrine_Collection::replace() EASY PATCH!

Tue, 24 Aug 2010 12:54:55 +0000

Record::replace() exists already.

but Doctrine_Collection::replace() does not exist.

I just copied the Doctrine_Collection::save() function, renamed it to replace and replaced
$record->save($conn);
with
$record->replace($conn);

WORKS GREAT!
Please include a replace for Doctrine_Collection.
Its really an easy patch!

By the way ... why is there no component for collection in the above select-field?

[DC-813] Add ability to register a custom hydrator as a class instance instead of a class name

Wed, 11 Aug 2010 14:50:23 +0000

Currently its only possible to register a custom hydrator as a string name. However in order to inject additional attributes it would be beneficial to be able to register an instance of the custom hydrator class.

http://www.doctrine-project.org/documentation/manual/1_2/en/data-hydrators#writing-hydration-method

So instead of:
$manager->registerHydrator('my_hydrator', 'Doctrine_Hydrator_MyHydrator');

One could do:
$manager->registerHydrator('my_hydrator', new Doctrine_Hydrator_MyHydrator());

[DC-800] PostgreSQL does not have LOCATE expressions

Tue, 24 Aug 2010 12:43:52 +0000

Introduction

As it's described in Doctrine documentation: http://www.doctrine-project.org/projects/orm/1.2/docs/manual/dql-doctrine-query-language/en#functional-expressions. In case I have correctly understood this documentation, I can use registered expressions (CONCAT,TRIM,LOCATE etc.) with supported database drivers.

Issue

The problem is with PostgreSQL, - it does not have the string function "LOCATE" since v7.4 (i have no info about previous version)

Here is my example:

  $q = PortalTable::getInstance()
      ->createQuery()
      ->addSelect(
        '(1 <= LOCATE(host, ?) as is_host_matched)',
        array('.google.com')
  );

  $q->execute();

And this code dies with an error:

Doctrine_Connection_Pgsql_Exception: SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near "as" LINE 1: SELECT (1 <= LOCATE("p"."host", $1) as is_host_matched) AS "... ^. Failing Query: "SELECT (1 <= LOCATE("p"."host", ?) as is_host_matched) AS "p__0" FROM "portal" "p"" in /web/vendor/symfony/1.4-svn/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Connection.php on line 1082

In PgSQL you can use POSITION for this needs (I want to mention, MySQL has this function too as an alias for LOCATE)

btw, POSITION is SQL-92 standard http://owen.sj.ca.us/~rk/howto/sql92.html - maybe it is better to rename LOCATE with POSITION?

Patch

Index: Doctrine/Expression/Pgsql.php
===================================================================
--- Doctrine/Expression/Pgsql.php	(revision 7678)
+++ Doctrine/Expression/Pgsql.php	(working copy)
@@ -230,4 +230,31 @@
     	$translate = 'TRANSLATE(' . $string . ', ' . $from . ', ' . $to . ')';
     	return $translate;
     }
-}
\ No newline at end of file
+
+    /**
+     * transform locate to position
+     *
+     * @param string $substr string to find
+     * @param string $str to find where
+     * @return string
+     */
+    public function locate($substr, $str)
+    {
+        return $this->position($substr, $str);
+    }
+
+    /**
+     * position
+     *
+     * @param string $substr string to find
+     * @param string $str to find where
+     * @return string
+     */
+    public function position($substr, $str)
+    {
+        $substr = $this->getIdentifier($substr);
+        $str = $this->getIdentifier($str);
+        
+        return sprintf('POSITION(%s IN %s)', $substr, $str);
+    }
+}

Solution without patch:

  # will work with PgSQL and MySQL (tested)
  $exp = new Doctrine_Expression('POSITION(host IN ?)');

  $q = PortalTable::getInstance()
      ->createQuery()
      ->addSelect(
        "(1 <= {$exp} as is_host_matched)",
        array('.google.com')
  );

  $q->execute();

[DC-794] findBy issue with field names containing "Or"

Wed, 29 Sep 2010 05:35:32 +0000

The problem is in Doctrine_Table::buildFindByWhere, line 2715. I put the code here for clarity:

public function buildFindByWhere($fieldName)
{
$ands = array();
$e = explode('And', $fieldName);
foreach ($e as $k => $v) {
$and = '';
$e2 = explode('Or', $v);<- LINE 2715
$ors = array();
foreach ($e2 as $k2 => $v2) {
if ($v2 = $this->_resolveFindByFieldName($v2))

{ $ors[] = 'dctrn_find.' . $v2 . ' = ?'; }

else

{ throw new Doctrine_Table_Exception('Invalid field name to find by: ' . $v2); }

}
$and .= implode(' OR ', $ors);
$and = count($ors) > 1 ? '(' . $and . ')':$and;
$ands[] = $and;
}
$where = implode(' AND ', $ands);
return $where;
}

In my proyect I have a table called OrigenesOportunidadCliente, which id field name is idOrigenOportunidadCliente. As you have probably noticed, the name contains Or: idOrigenOportunidadCliente. And there is where it fails, it gets as if there where an OR statement, not finding a valid field name in the below foreach as the field is "OrigenOportunidad".

[DC-764] Major->please.....Value of Primary key from sequence in Postgres table NOT being set (although sequence gets incremented)

Fri, 25 Jun 2010 18:00:37 +0000

In the ERD/schema that I have set up, a couple levels down in hierarchal order, a table has 3 composite foreign keys, and one sequence of its own. That sequence does not get get set into the 'Table->sequence variable'. That means when the file 'UnitOfWork' executes the function '_assignSequence()', it finds no sequence name, and skips the assignment of the sequence value.

This of course blows up my inserts.

I have included the following documentation:

A/ An installation and further description README.tx file.
B/ SQL script to generate a anonymous version of my ERD - I.E. the table names and column names have been changed to protect the guilty (and proprietary)
C/ A fixture file to load some data.
D/ A *.png file showing a graphical view of the ERD.
E/ The generated schema.yml file from ./symfony doctrine:build-schema
F/ A modifiled (has certain echo statements for troubleshooting purposes) UnitOfWork.php file.
G/ A task file to run that tries to load the schema with valid values.
H/ An output file from running the Task and modified UnitOfWork.php file showing the exact point of error during insert.

Please let me know what I can do to help get this troubleshot quicly. Thx
E/

[DC-745] Exported foreign keys names are not formatted with attribute FKNAME_FORMAT

Tue, 24 Aug 2010 12:08:28 +0000

Class Doctrine_Formatter formats index names using Doctrine_Core::ATTR_IDXNAME_FORMAT
but for now it does not format foreign key names with Doctrine_Core::ATTR_FKNAME_FORMAT (in function getForeignKeyName).

Attached simple patch (copied from function getIndexName)

[DC-715] Doctrine_Tree_NestedSet::fetchRoots does not return roots with no branches.

Tue, 8 Jun 2010 10:49:31 +0000

Doctrine_Tree_NestedSet::fetchRoots does not return roots with no branches.

[DC-714] Fatal error(Call to a member function quoteIdentifier() on a non-object), on batchUpdateIndex(), file search.php on line 246

Tue, 8 Jun 2010 09:28:40 +0000

I am creating a search in such a way that's:
$tenders = Doctrine::getTable('TableTenders');
$tenders->batchUpdateIndex();

after excute i have fatal error: Fatal error: Call to a member function quoteIdentifier() on a non-object in E:\home\tender.loc\www\engine\class\Doctrine\Doctrine\Search.php on line 246

When i am opened Search.php on 246 line, i saw : $conn->quoteIdentifier($this->_table->getTableName())

var_dump($conn) return NULL

I climbed up the code and saw the error: $conn = $this->_options['connection']; (line 228)
i change this on $conn = $this->_options['table']->getConnection();

now works fine

Sory for my english

[DC-712] [pgsql] missing quoteIdentifier() on "alter table" queries

Tue, 8 Jun 2010 09:47:12 +0000

In Doctrine_Export_Pgsql the table name of query like "ALTER TABLE mytable ..." are not quoted even if ATTR_QUOTE_IDENTIFIER is enabled.
This create failing queries, for example if the table to alter is called 'user'.

Please note in Mysql exporter the table name of ALTER TABLE queries is correctly quoted.

[DC-709] Column comments are not escaped

Tue, 8 Jun 2010 10:21:29 +0000

Following schema.yml causes MySQL error because of the first column comment that contains the reserved ' char.

Client:
  columns:
    serial:    { type: string(50), primary: true, comment: "Seriale dell'hardware" }

The following works (note the double ''), but Doctrine schema should be automatically escaped

Client:
  columns:
    serial:    { type: string(50), primary: true, comment: "Seriale dell''hardware" }

[DC-706] Subqueries do not work in select

Tue, 8 Jun 2010 19:09:33 +0000

Hi All

I have found another bug in Doctrine 1.2.2.

Subqueries are not working in select statements at the moment.

The reason for this is that this line (found in the parseSelect function of the class Doctrine_Query) :

$componentAlias = $this->getExpressionOwner($expression);

Returns an unusable value when passed an $expression which is a subquery.

To fix this problem I have patched my version of the code to use an existing "$componentAlias" instead of the value that would be returned by this function when a subquery is encountered.

My code now reads:

if ($pos !== false && substr($term[0], 0, 1) !== "'" && substr($term[0], 0, $pos) == '') {
	$_queryComponents = $this->_queryComponents;
	reset($components);
	$componentAlias = key($_queryComponents);
} else {
        $componentAlias = $this->getExpressionOwner($expression);
}

I have not rigorously tested this patch yet but it has been working for me in what tests I have done so far.

I have posted several very large bugs into jira over the past few months and haven't heard back regarding them. This leads me to believe that the Doctrine team has moved on from Doctrine 1.2.2 and is focusing only on Doctrine 2 issues at this point. I still love version 1 and haven't had the heart (or the time) to migrate my code over to 2 yet. If this is the case then the job of patching bugs like the ones I have reported in 1.2.2 is probably up to us users at this point. As such I will post my patched version of Doctrine_Query in a comment to this bug (My patched version also fixes another bug I reported: ~~DC-594~~) .

Best Regards

Will Ferrer

[DC-705] synchronizeWithArray does not properly set foreign key validation

Tue, 8 Jun 2010 10:19:23 +0000

I've discovered a variation of the problem tested in tests/Validator/ForeignKeysTestCase.php. This happens when you synchronizeWithArray and a foreign relation is set - isValid will trigger the isnull validator.

This is probably better explained through two new test cases. I've included them below. The first test case passes. However, the second test case (testSynchronizedForeignKeyIsValidIfForeignRelationIsSet) fails.

tests/Validator/ForeignKeysTestCase.php - also attached as patch

// Place in tests/Validator/ForeignKeysTestCase.php
    public function testSynchronizedForeignKeyIsValidIfLocalRelationIsSet()
    {
        $person = new TestPerson();
        $person->synchronizeWithArray(array('Addresses' => array(array())));

        $address = $person->Addresses[0];
        $table = $address->getTable();
        
        $errors = $table->validateField('person_id', $address->person_id, $address);
        $this->assertEqual(0, $errors->count());
    }

    public function testSynchronizedForeignKeyIsValidIfForeignRelationIsSet()
    {
        $address = new TestAddress();
        $address->synchronizeWithArray(array('Person' => array()));

        $table = $address->getTable();
        $errors = $table->validateField('person_id', $address->person_id, $address);
        $this->assertEqual(0, $errors->count());
    }

I've discovered a workaround, if you reassign the value it will work.

$address->synchronizeWithArray(array('Person' => array()));
$address->Person = $address->Person;

A quick and likely terrible (or wrong?) fix is to have the synchronizeWithArray function do it for you. I've attached a patch does just that.

[DC-703] [PATCH] Doctrine_Connection_Oracle unquoted query aliases in _createLimitSubquery

Tue, 8 Jun 2010 10:23:01 +0000

When using identifier quoting with oracle driver, the _createLimitSubquery is giving into the select statement unquoted subquery aliases. That leads to Oracle errors.

Simple patch:
{{
diff --git a/lib/Doctrine/Connection/Oracle.php b/lib/Doctrine/Connection/Oracle.php
index db538fb..6e5f629 100644
— a/lib/Doctrine/Connection/Oracle.php
+++ b/lib/Doctrine/Connection/Oracle.php
@@ -108,8 +108,8 @@ class Doctrine_Connection_Oracle extends Doctrine_Connection_Common
$column = $column === null ? '*' : $this->quoteIdentifier($column);
if ($offset > 0)

{ $min = $offset + 1; - $query = 'SELECT b.'.$column.' FROM ( '. - 'SELECT a.*, ROWNUM AS doctrine_rownum FROM ( ' + $query = 'SELECT '.$this->quoteIdentifier('b').'.'.$column.' FROM ( '. + 'SELECT '.$this->quoteIdentifier('a').'.*, ROWNUM AS doctrine_rownum FROM ( ' . $query . ' ) ' . $this->quoteIdentifier('a') . ' '. ' ) ' . $this->quoteIdentifier('b') . ' '. 'WHERE doctrine_rownum BETWEEN ' . $min . ' AND ' . $max; }

}

[DC-699] DC292 test doesn't pass due to missing 'migrations' directory

Tue, 8 Jun 2010 10:31:39 +0000

After downloading Doctrine 1.2.2 from [1] and unpacking it, when trying to run the tests by:

cd Doctrine-1.2.2/tests
php ./run.php

i get:

Unexpected UnexpectedValueException thrown in [Doctrine_Ticket_DC292_TestCase] with message [RecursiveDirectoryIterator::__construct(/home/fgimenez/alioth/doctrine_test/Doctrine-1.2.2/tests/Ticket/DC292/migrations): failed to open dir: No such file or directory] in /home/fgimenez/alioth/doctrine_test/Doctrine-1.2.2/lib/Doctrine/Migration.php on line 137

If i create a 'migrations' directory under Doctrine-1.2.2/tests/Ticket/DC292 all tests pass.

Cheers,
Federico

[1] http://www.doctrine-project.org/downloads/Doctrine-1.2.2.tgz

[DC-698] Record::link method does not work with setting null one-to-one

Tue, 8 Jun 2010 10:35:04 +0000

I have an Issue model with one owner User (relation Owner). I have this code:

$issue->link( 'Owner', array( $owner_id ) );

At the time of calling this code, the $issue->Owner is null. When this is called, the link fails to assign the new owner to the relation. I've tried to hotfix it changing line around 2516 in Record.php:

$this->get($alias)->add($record);

to this:

if( $c = $this->get($alias) )

{ $c->add($record); }

else

{ $this->set( $alias, $record ); }

In this case the $this->get($alias) returns NULL, so the subsequent add($record) fails.

[DC-697] Doctrine Support of custom enum types in Pgsql

Tue, 8 Jun 2010 10:50:36 +0000

In postgres with existing schema you can have custom enum types. To support this with our current code base (symfony w/ doctrine 1.2.2) I had to make changes to doctrine import and datadict for pgsql driver. The patches attached are from the git tree.

0001-Postgresql-custome-enum-types-as-native-enum.patch
0002-Update-Pgsql-test-case-to-include-enum-changes-to-ta.patch

The patches are formatted from the git tree.

Thanks for an excellent ORM for php!

[DC-696] Sluggable behavior doesn't work properly with french accents in utf8

Tue, 8 Jun 2010 10:50:57 +0000

In UTF8, "Législation 2008" was "slugged" as "legislation-ta-2-8" which is not correct.

It is caused as a bug in the Doctrine_Inflector::unaccent function.

If $string seems to be UTF8, we use the $chars array to replace accents. But the last line of the $chars array (Norwegian characters replacements) is incorrect :

'Å'=>'Aa','Æ'=>'Ae','Ø'=>'O','æ'=>'a','ø'=>'o','å','aa'

should be replaced by

'Å'=>'Aa','Æ'=>'Ae','Ø'=>'O','æ'=>'a','ø'=>'o','å' => 'aa'

[DC-695] Fixtures created badly when primary key is not autonumber

Duplicate — Tue, 8 Jun 2010 11:07:36 +0000

When exporting data where the primary key is not an autonumber the export function will hide the field anyway, merging the keys to the text identifier of the resulting record.

This creates two problems:

the original value is lost due to size limit of the record identifier
the database is unable to generate the primary key when data-loading.

A fix is attached that prevents the export function of hiding the said field from the fixture.

[DC-694] Doctrine_Record::replace() discards Doctrine_Expression values, uses empty value instead

Tue, 8 Jun 2010 11:02:54 +0000

I experienced a bug when working with a datetime field that only rears its head when I use $record->replace()

//  BUG!!
$record->date_created = new Doctrine_Expression('NOW()');
$record->replace();
// date_created will be 0000-00-00 00:00:00, i.e. empty

// WORKS FINE!
$record->date_created = '2022-12-23 14:14:12';
$record->replace();

// WORKS FINE!
$record->date_created = new Doctrine_Expression('NOW()');
$record->insert();

// WORKS FINE!
$record->date_created = '2022-12-23 14:14:12';
$record->insert();

[DC-691] No sequence_id increment after fixtures loaded, while setting their ids

Tue, 8 Jun 2010 17:33:43 +0000

If I force id in fixtures (they are autoincremented in model), the sequence is not set correctly in postgresql.

Model :
T_Company:
actAs:
Timestampable: ~
Searchable:
fields: [name]
columns:
company_id:

{ type: integer, notnull: true, autoincrement: true, primary: true }

dn:

{ type: string(255) }

name:

{ type: string(127), notnull: true}

relations:
RssSettings:

{ local: company_id, foreign: rsssettings_id, foreignAlias: CompanySettings, refClass: J_Company_Rsssettings, class: T_RssSettings }

ParentCompany:

{ local: company_id, foreign: parent_company_id, foreignAlias: ChildCompany, refClass: J_Company_Company, class: T_Company }

ParentLinkType:

{ local: company_id, foreign: parent_company_id, refClass: J_Company_Company, class: S_CompanyLinkType }

Fixtures :
T_Company:
A:
company_id: 1
name: A
dn: A
B:
company_id: 2
name: B
dn: B
C:
company_id: 3
name: C
dn: C

Postgresql :
sl3dev=# select * from t__company;
company_id | dn | name | created_at | updated_at
-------------------------------------------------------------------------------------------------------------------------------------------------------
1 | A | A | 2010-05-18 16:55:12 | 2010-05-18 16:55:12
2 | B | B | 2010-05-18 16:55:12 | 2010-05-18 16:55:12
3 | C | C | 2010-05-18 16:55:12 | 2010-05-18 16:55:12

sl3dev=# select nextval('t__company_company_id_seq'::regclass);
nextval
---------
1
(1 ligne)

1 instead of 4 naturally.

[DC-688] data-load don't work when the primary key is a string

Duplicate — Tue, 8 Jun 2010 11:07:41 +0000

The export/import system don't work if a table have a primary key string.

I have this schema :

 
TypeChampPerso:
  columns:
    id: { type: string(20), primary: true }
    description: { type: string(100), notnull: true }

Here is the result when I extract data with data-dump :

 
TypeChampPerso:
  TypeChampPerso_date:
    description: Date
  TypeChampPerso_numeric:
    description: Numérique
  TypeChampPerso_text:
    description: Texte

Then, I've got an error when I used data-load :
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '' for key 'PRIMARY'

The id column is empty is the DB.

It works if I add manually the id value in the yml file :

 
TypeChampPerso:
  TypeChampPerso_date:
    id: date
    description: Date
  TypeChampPerso_numeric:
    id: numeric
    description: Numérique
  TypeChampPerso_text:
    id: text
    description: Texte

[DC-687] Doctrine_Inflector::unaccent replaces UTF8-Chars - 0 with å, 1 with aa

Tue, 8 Jun 2010 11:08:31 +0000

Changeset 7359 which fixes #~~DC-543~~ [Doctrine_Inflector::unaccent does not replace the norwegian characters æøå] introduces a new bug ... 0 and 1 are now replaced with å and aa

[DC-685] Invalid conditions in Import/Mysql.php

Tue, 8 Jun 2010 11:12:15 +0000

Lines 68 and 190 have the following conditional
if ($this->conn->getAttribute(Doctrine_Core::ATTR_PORTABILITY) & Doctrine_Core::PORTABILITY_FIX_CASE) {

Should read:
if ($this->conn->getAttribute(Doctrine_Core::ATTR_FIELD_CASE) &&
($this->conn->getAttribute(Doctrine_Core::ATTR_PORTABILITY) & Doctrine_Core::PORTABILITY_FIX_CASE)) {

[DC-683] orderBy many field defined in yml files doesnt work

Tue, 8 Jun 2010 11:15:33 +0000

Hi,
When you have defined orderBy table option in yml file, like:

orderBy[ field1 ASC, field2 DESC ]

and models build by doctrine:build --model

Doctrine_Table class reports warnings, when executing select query i.e.:
Warning: array_map() [function.array-map]: Argument #2 should be an array in ....\doctrine\Doctrine\Table.php on line 1134

that's causes no order at all in sql query

quick solution for this problem is change file \doctrine\Doctrine\Table.php, function processOrderBy() - around line 1134

from:

$e1 = explode(',', $orderBy);

to:

if( !is_array($orderBy)){
$e1 = explode(',', $orderBy);
}else{
$e1 = $orderBy;
}

hope it helps to someone

best,
Wojtek

[DC-681] Command-line option rebuild-db is touching the models

Tue, 8 Jun 2010 11:17:42 +0000

The command-line option "rebuild-db" is doing the following tasks: ( from the constructor )

$this->dropDb = new Doctrine_Task_DropDb($this->dispatcher);
$this->buildAll = new Doctrine_Task_BuildAll($this->dispatcher);

But the BuildAll tasks is executing three tasks including one which is regenerating the models. ( from the constructor )
$this->models = new Doctrine_Task_GenerateModelsYaml($this->dispatcher);
$this->createDb = new Doctrine_Task_CreateDb($this->dispatcher);
$this->tables = new Doctrine_Task_CreateTables($this->dispatcher);

My suggestion is to replace the build-all in the rebuild-db task with just the following. This would make more sense.

$this->createDb = new Doctrine_Task_CreateDb($this->dispatcher);
$this->tables = new Doctrine_Task_CreateTables($this->dispatcher);

[DC-678] Need case-insensitive checks for dupes in the $options['indexes'] array

Tue, 8 Jun 2010 11:26:05 +0000

I ran into a bug where there were two duplicate indexes that Doctrine was trying to create.

Not too sure what the cause is yet but this fix took care of the problem for me.

Line 161 of Doctrine/Export/MySQL.php

// Case Insensitive checking for duplicate indexes...
$dupes = array();
foreach ($options['indexes'] as $key => $index) {
if (in_array(strtolower($key), $dupes))

{ unset($options['indexes'][$key]); }

else

{ $dupes[] = strtolower($key); }

}
unset($dupes);

[DC-677] Incorrect property uset before Collection serialize

Tue, 8 Jun 2010 11:27:13 +0000

On line 155 (Doctrine/Collection.php) should unset "referenceFiled" property not "reference_field". It causes problems after Collection unserialize.

[DC-675] Doctrine_Connection_Mssql charset problem

Tue, 8 Jun 2010 11:52:28 +0000

Recently I got problems with converting UTF-8 data to iso ISO-8859-1 while trying to insert/update a Microsoft SQL Server database.
I wrote a task that exports data from an UTF-8 MySQL database to a latin1 Microsoft SQL Server database. When converting the data from UTF-8 to ISO-8859-1 the insert/update fails:

SQLSTATE[HY000]: General error: trying to execute an empty query

As i tracked the error down I realized, that the exception only occurs if I try to insert/update data with special characters like "ü", "ö", "ä", "ß" etc.
The error's origin seems to lie in the Doctrine_Connection_Mssql class, more precisely in the replaceBoundParamsWithInlineValuesInQuery() method.
Debugging this method shows that after replacing a bound param with data containing a special character (see above), the replace action for the next bound param replaces the whole query string with an empty string. Therefore the parent class's method exec() throws an exception as it tries to execute an empty query.

Example:

Task snippet:
// $src is UTF-8 data (MySQL DB)
// $dest ist latin1 data (MSSQL DB)

$dest->setZip($src->getZip());
$dest->setCity(iconv("UTF-8", "ISO-8859-1//TRANSLIT", $src->getCity());
$dest->setStreet(iconv("UTF-8", "ISO-8859-1//TRANSLIT", $src->getStreet());
$dest->save();

RESULTING DQL: UPDATE table SET zip = ?, city = ?, street = ? WHERE id = ?;

Params:
array(
'22307',
'München',
'Dummystreet 18'
'1'
)

After replaceBoundParamsWithInlineValuesInQuery() replaces param 'München', the query string is replaced by an empty string in the following iteration.

The root of the Problem seems to lie in the regex modifier 'u' which treats the pattern as UTF-8 in the param replacements. Removing this modifier solves the problem for me. What purpose has this modifier?

[DC-673] Doctrine_Export::dropForeignKey() doesn't format foreign key names

Tue, 8 Jun 2010 11:54:34 +0000

Doctrine_Export::createForeignKey() formats foreign key names, but Doctrine_Export::dropForeignKey() doesn't. It is a problem.

I tested following:

echo "<?php

class addForeignKey extends Doctrine_Migration_Base
{
public function up()

Unknown macro: { $this->createForeignKey('user', 'dotted.foreign.key', array( 'local' => 'category_id', 'foreign' => 'id', 'foreignTable' => 'category', )); }

}" > migrations/1_add_foreign_key.php

echo "<?php

class removeForeignKey extends Doctrine_Migration_Base
{
public function up()

Unknown macro: { $this->dropForeignKey('user', 'dotted.foreign.key'); }

}" > migrations/2_add_foreign_key.php

./doctrine migrate 1 # successful

./doctrine migrate 2 # failed

1 error(s) encountered during migration
=======================================
Error #1 - SQLSTATE[42000]: Syntax error or access violation: 1103 Incorrect table name 'dotted'. Failing Query: "ALTER TABLE user DROP FOREIGN KEY dotted.foreign"

I have a patch to fix this problem.

[DC-671] Record could be saved, even tough a NotNull column is null

Mon, 10 May 2010 04:09:05 +0000

Strange behavior: The record could be saved without getting validation exception even tough a NotNull column is empty.

If you use Sqlite as mock driver you get validation exception. Test case is added into ticket!

[DC-670] Doctrine/Collection: toHierarchy() accepts not only NestedSet

Tue, 8 Jun 2010 16:43:54 +0000

I've got it after trying to implement NestedSet+AjacencyList behaviour.

[DC-669] listTableIndexes() return an empty array with doctrine-1.2.2

Tue, 8 Jun 2010 11:55:16 +0000

I've a table A with 3 indexes. I would like to retrieve this list of indexes by using listTableIndexes() but I just get an empty array.

I found the problem into listTableIndexes():
The $keyName and $nonUnique are set in lowercase in my case.
But the result of $indexes = $this->conn->fetchAssoc($query); have field names in both lower/upper case, e.g.:
'Non_unique' => string '1' (length=1)
'Key_name' => string 'module' (length=6)

But maybe that's a config problem from my part and the case of $keyName and $nonUnique should not be modified.

[DC-664] PATCH: Docrine_Record _isValueModified should not type check when comparing integers

Tue, 8 Jun 2010 13:35:02 +0000

The _isValueModified function in Record.php does the following for checking whether or not an integral value was modified:

...
} else if (in_array($type, array('integer', 'int')) && is_numeric($old) && is_numeric($new)) {
return $old !== $new;
...
} else {
return $old !== $new;
...

This does not make sense, it implies strict type checking is always done for integers.
I think the first check (line 1533) should be done loosely so that a string '123' is equal to integer 123, and thereby such a field is not considered modified.

[DC-663] Doctrine_Table::createQuery creates a query with the default connection instead of the current connection

Tue, 28 Sep 2010 08:37:12 +0000

If we manually set a connection on the Doctrine_Table instance Doctrine silently ignores it when creating a Doctrine_Query instance through createQuery method

$manager->setConnection($defaultConnection);

$table = Doctrine::getTable('Users')->setConnection($newConnection);
$table->createQuery(); // -> connection to $defaultConnection

The code:

public function createQuery($alias = '')
{
if ( ! empty($alias))

{ $alias = ' ' . trim($alias); }

$class = $this->getAttribute(Doctrine_Core::ATTR_QUERY_CLASS);

return Doctrine_Query::create(null, $class) <-- fix too quick for a patch -~~> return Doctrine_Query::create($this~~>_conn, $class)
~~>from($this~~>getComponentName() . $alias);
}

[DC-662] Obsolete Doctrine::getTable() call in Template_Listener_Sluggable

Tue, 8 Jun 2010 13:35:48 +0000

Subj. Found in Doctrine/Template/Listener/Sluggable.php on line 165th:

          $table = Doctrine::getTable($parentTable[$i]);

Should be replaced with:

          $table = Doctrine_Core::getTable($parentTable[$i]);

[DC-658] _setPage in Doctrine_Pager is set to Private method

Tue, 8 Jun 2010 16:15:37 +0000

The method _setPage is set as private. This will make extending the Doctrine_Pager unnecessary complex.

[DC-657] EXISTS not correctly parsed if there's no space between keyword and the open bracket

Tue, 8 Jun 2010 16:47:04 +0000

Executing a query that has an EXISTS in the WHERE clause without a space before its bracket make Doctrine ignore the EXISTS part and output it as is, this cause problems because, as an example, table aliases are not correctly resolved.

For example this works

SELECT * FROM TableA a WHERE EXISTS (SELECT id FROM TableB b WHERE b.a = a.id)

while this doesn't

SELECT * FROM TableA a WHERE EXISTS(SELECT id FROM TableB b WHERE b.a = a.id)

I found the error could be in Doctrine/Query/Where.php line 49:

        if (count($terms) > 1) {
            if (substr($where, 0, 6) == 'EXISTS') {
                return $this->parseExists($where, true);
            } elseif (substr($where, 0, 10) == 'NOT EXISTS') {
                return $this->parseExists($where, false);
            }
        }

could be modified with:

            if (substr($where, 0, 6) == 'EXISTS') {
                return $this->parseExists($where, true);
            } elseif (substr($where, 0, 10) == 'NOT EXISTS') {
                return $this->parseExists($where, false);
            }

to solve the problem. As a plus, since one could write "NOT EXISTS" (for some reason), I think it's better to write it this way:

        if (substr($where, 0, 6) == 'EXISTS') {
            return $this->parseExists($where, true);
        } elseif (preg_match('/^NOT\s+EXISTS\b/i', $where) !== 0) {
            return $this->parseExists($where, false);
        }

Hope this helps.

PS. Please add php code formatter

[DC-656] Endless loop when using HYDRATE_SINGLE_SCALAR and Oracle OCI adapter Doctrine

Tue, 8 Jun 2010 13:40:09 +0000

Following loop inside Doctrine_Hydrator_SingleScalarDriver never terminates since fetchColumn inside Doctrine_Adapter_Statement_Oracle never returns FALSE.

while (($val = $stmt->fetchColumn()) !== false)

{ $result[] = $val; } Below is the patch for Doctrine_Adapter_Statement_Oracle ---------------------------------------------------------------------------------------------------------------------------------- Index: Oracle.php =================================================================== --- Oracle.php (revision 7546) +++ Oracle.php (working copy) @@ -398,7 +398,7 @@ return false; }

$row = $this->fetch(Doctrine_Core::FETCH_NUM);

return $row[$columnIndex];
+ return ($row===false) ? false : $row[$columnIndex];
}

/**
----------------------------------------------------------------------------------------------------------------------------------

[DC-651] [PATCH] Doctrine_Record::option('orderBy', ...) of join's right side being applied to refTable in m2m relationship

Wed, 31 Aug 2011 12:43:09 +0000

When using the Doctrine_Record::option('orderBy', ...) feature on a table definition, where that table is the target of a many-to-many join, the specified orderBy columns are applied to the relation table's alias. So for example, given the following definitions:

class User extends Doctrine_Record {
  public function setTableDefinition() {
    $this->hasColumn('uid', 'integer', null, array('primary' => true));
    $this->option('orderBy', 'uid');
  }

  public function setUp() {
    $this->hasMany('Group as groups', array('refClass' => 'UserGroup', 'local' => 'user_uid', 'foreign' => 'group_id'));
  }
}

class Group extends Doctrine_Record {
  public function setTableDefinition() {
    $this->hasColumn('gid', 'integer', null, array('primary' => true));
  }

  public function setUp() {
    $this->hasMany('User as users', array('refClass' => 'UserGroup', 'local' => 'group_gid', 'foreign' => 'user_id'));
  }
}

class UserGroup extends Doctrine_Record {
  public function setTableDefinition() {
    $this->hasColumn('user_uid', 'integer', null, array('primary' => true));
    $this->hasColumn('group_gid', 'integer', null, array('primary' => true));
  }

  public function setUp() {
    $this->hasOne('User as user', array('local' => 'user_uid', 'foreign' => 'uid'));
    $this->hasOne('Group as group', array('local' => 'group_gid', 'foreign' => 'gid'));
  }
}

the following queries:

$query = Doctrine_Query::create()
  ->select('u.*')
  ->from('User u')
  ->leftJoin('u.groups g WITH g.gid=?', 1);
echo $query->getSqlQuery() . "\n";

$query = Doctrine_Query::create()
  ->select('g.*')
  ->from('Group g')
  ->leftJoin('g.users u WITH u.uid=?', 1);
echo $query->getSqlQuery() . "\n";

will output the following:

SELECT u.uid AS u__uid FROM user u LEFT JOIN user_group u2 ON (u.uid = u2.user_uid) LEFT JOIN group g ON g.gid = u2.group_id AND (g.gid = ?) ORDER BY u.uid
SELECT g.gid AS g__gid FROM group g LEFT JOIN user_group u2 ON (g.gid = u2.group_gid) LEFT JOIN user u ON u.uid = u2.user_id AND (u.uid = ?) ORDER BY u.uid, u2.uid

The orderBy option() call is applied to the User definition. The SQL for the first query is correct (where User is on the left side of the join). The SQL for the second query (where User is on the right-most side of the join), however, is obviously incorrect (UserGroup doesn't even have a uid column). Basically, User's orderBy option is being applied to both the User table and its respective reference table, UserGroup, when it is the target of a join.

After digging through the source for a while, I believe I've come up with a patch for this issue (which should be checked by someone more knowledgeable of Doctrine's internals). Basically, in the Doctrine_Query::buildSqlQuery() function, a call is made to Doctrine_Relation::getOrderByStatement() with the reference table (UserGroup)'s alias (u2), which in turn makes a call to Doctrine_Table::getOrderByStatement() on the referenced table (User), filling in the ORDER BY clause with User columns using UserGroup's alias. My solution was to reorder the logic so that the test for a reference class is made before the initial call to getOrderByStatement() is made. It seems to work against my test case and the test cases in the repository. I'll post my patch momentarily.

This bug was first mentioned in the comments in DC-313, but the original ticket comes across as more of a feature request for the hasMany() orderBy feature.

[DC-650] SoftDelete sets "default" => null for deleted_at field, causing MSSQL to silently create a Default Constraint which in turns causes Migrations to fail when reverting

Tue, 8 Jun 2010 13:47:08 +0000

When MSSQL receives even just a default value of null it still creates a default constraint. Said constraint prevents doctrine from removing the deleted_at field in migrations (due to the dependency on the constraint).

Removing "default" => null prevents the silent creation of the constraint.

I have no machine to test the effects of this on MySQL. I would imagine that it would not materially affect MySQL as the default values are never used anyways (hence the default value of null).

Attached is a patch to fix the behavior (for rev 7544 in /branches/1.2)

—

If one is running into problems with migrations being unable to move backwards due to default constraints on SoftDelete columns, one can run the following T-SQL script to remove all default value constraints from a database (EVEN THOSE YOU SET MANUALLY, USE WITH CAUTION):

{{
– This script removes ALL default constraints

USE YOURDATABASENAMEHERE;

Declare @name nvarchar(155)
Declare @table nvarchar(155)
Declare @sql nvarchar(1000)

– find constraint names
DECLARE default_constraints CURSOR FOR
SELECT
object.name,
parent.name
FROM
sys.objects AS object
LEFT JOIN sys.objects AS parent ON object.parent_object_id = parent.object_id
WHERE
object.type_desc LIKE '%CONSTRAINT'
AND object.type_desc LIKE 'DEFAULT_CONSTRAINT'

OPEN default_constraints

FETCH NEXT FROM default_constraints INTO @name, @table

WHILE @@FETCH_STATUS = 0
BEGIN
IF NOT @name IS NULL
BEGIN
SELECT @sql = 'ALTER TABLE [' + @table + '] DROP CONSTRAINT [' + @name + '];'
--PRINT @sql
EXECUTE sp_executesql @sql
END

FETCH NEXT FROM default_constraints INTO @name, @table
END
CLOSE default_constraints
DEALLOCATE default_constraints
}}

[DC-647] Error in Doctrine_Manager#_buildDsnPartsArray()

Tue, 8 Jun 2010 13:57:17 +0000

The method Doctrine_Manager#_buildDsnPartsArray() ultimately relies on PHP's native parse_url(). This method, according to the PHP documentation does not parse unix_sockets in the DSN, so the following code will not find the unix_socket because parse_url only finds at most (http://us2.php.net/parse_url)

scheme
host
port
user
pass
path
query - after the question mark ?
fragment - after the hashmark #

// silence any warnings
$parts = @parse_url($dsn);

$names = array('dsn', 'scheme', 'host', 'port', 'user', 'pass', 'path', 'query', 'fragment', 'unix_socket');

foreach ($names as $name) {
if ( ! isset($parts[$name]))

{ $parts[$name] = null; }

}

It would appear that in order to support unix sockets we have to use parsePdoDsn() instead but this is not clear because of parseDsn() which also claims to be able to find the unix_socket. I would suggest removing 'unix_socket' from the $names array so it is clear a unix_socket cannot be represented in the normal Dsn, but only a PdoDsn.

[DC-641] undefined method Doctrine_Manager::getExtensionsClasses()

Tue, 8 Jun 2010 14:07:00 +0000

On line 589 in Doctrine_Core:
public static function getExtensionsClasses()

{ return Doctrine_Manager::getInstance()->getExtensionsClasses(); }

In manager method getExtensionsClasses() doesn't exist.

[DC-626] Subqueries in HAVING

Tue, 8 Jun 2010 15:23:24 +0000

Adds support for subqueries in HAVING.

[DC-621] Doctrine_Inflector :: urlize changed behaviour

Tue, 8 Jun 2010 08:50:15 +0000

before when using the sluggable behavior the Doctrine_Inflector :: urlize function changed "catégorie 1" to "categorie-1"
since doctrine 1.2.2 "catégorie 1" becomes "categorie-aa"

[DC-620] Unserialize does not add entity to the table entitymap

Tue, 8 Jun 2010 16:29:50 +0000

Hello,

Considering this test script:

if (!file_exists("/tmp/serialize.doctrine"))
{
  $a = Address::getById(1);
  $b = Address::getById(2);
  $c = Address::getById(3);
  $d = Address::getById(4);
  print "Serialize using oid=" . $d->getOid() . "\n";
  file_put_contents("/tmp/serialize.doctrine", serialize($d));
}
else
{
  $d = unserialize(file_get_contents("/tmp/serialize.doctrine"));
  print "unserialized oid = " . $d->getOid() . "\n";

  $d2 = Address::getById(4);
  print "new object oid = " . $d2->getOid() . "\n";

  $d->housenumber ++;
  print "{$d->housenumber} versus {$d2->housenumber}\n";
}

Things are going wrong in the unserialization. In this test script, I manage to create two objects holding the same oid, but pointing at different object instances (but for the same database id). The output of this script after running it twice shows me:

$ php test.php
Serialize using oid=5
$ php test.php
unserialized oid = 5
new object oid = 5
24 versus 23

Looking at the unserialize() code in Doctrine_Record, the problem seems to be coming from two issues in there:

$this->_oid is generated before the data unserialization. Because of this, the generated $this->_oid is overwritten with whatever was in the serialized data (this is why in above example, the oid became 5 for the unserialized record)
The unserialized record is not added to the table's identitymap, making it kind of invisible for the table's getRecord() code, resulting in two different objects that both represent the entity with id = 4 (as you can see in the "24 versus 23" output).

See the attached patch for a fix that I did on our code tree to make the test work.

Note that I added some extra code in the unserialize method to cleanup any existing entitymap and table repository entry for the unserialized object. This is of course not the best route, but it helps with some unit testing code where a lot of serialize/unserialize handling is going on and objects got mixed up when not doing this cleanup.
IMO, better would be to add an unserialization method to the Doctrine_Table, which would, like find(), act as a factory for turning unserialized record data into a Doctrine_Record object, possibly making use of already loaded entities that are available in the table's internal caches. With unserialize being handled directly from the Doctrine_Record, there is no way AFAICS to keep up the rule of always having exactly one object in a scope that represents a certain object in the database.

When running above script with this patch applied and with removing the $a, $b and $c assignments (just for making the oid's different between the two script runs), we get the following output:

$ php test.php
Serialize using oid=2
$ php test.php
unserialized oid = 5
new object oid = 5
24 versus 24

So here, unserializing an object and then reloading the object through the table object gives use two times the same object, representing db object with id = 4;

When doing things in a different order, we still can force an issue, but this is due to the things mentioned above: to cleanly handle this, unserialization should be handled from a factory method on Table. This script shows the behavior:

if (!file_exists("/tmp/serialize.doctrine"))
{
  $d = Address::getById(4);
  print "Serialize using oid=" . $d->getOid() . "\n";
  file_put_contents("/tmp/serialize.doctrine", serialize($d));
}
else
{
  $d2 = Address::getById(4);
  print "new object oid = " . $d2->getOid() . "\n";

  $d = unserialize(file_get_contents("/tmp/serialize.doctrine"));
  print "unserialized oid = " . $d->getOid() . "\n";

  $d3 = Address::getById(4);
  print "new object oid = " . $d3->getOid() . "\n";

  $d->housenumber ++;
  print "{$d->housenumber} versus {$d2->housenumber} versus {$d3->housenumber}\n";
}

The output of the second run being:

$php test.php
new object oid = 2
unserialized oid = 5
new object oid = 5
24 versus 23 versus 24

The first object that was created is still different from the unserialized object, but at least the third object that is created, is the object that was unserialized.

I hope that this makes the issue clear and that my input helps in fixing things. This issue provided us with some really unexpected behavior and we're glad that we were able to track it down to here.

[DC-613] Doctrine_Record::copy() ignores IDENTIFIER_SEQUENCE for NULLifying the id field on copy

Tue, 8 Jun 2010 14:51:22 +0000

Doctrine_Record::copy() ignores IDENTIFIER_SEQUENCE for NULLifying the id field on copy. In our environment, it was fixed by adding Doctrine_Core::IDENTIFIER_SEQUENCE to the check at the start of the copy() method:

    public function copy($deep = false)
    {
        $data = $this->_data;
        $idtype = $this->_table->getIdentifierType();
!       if ($idtype === Doctrine_Core::IDENTIFIER_AUTOINC ||
!           $idtype === Doctrine_Core::IDENTIFIER_SEQUENCE) {
            $id = $this->_table->getIdentifier();

            unset($data[$id]);
        }

[DC-594] When using a combination of: a group by field referencing a table in a relation, a join to a different table via a many type relation and a limit clause, doctrine creates a broken query then throws an exception

Tue, 8 Jun 2010 10:26:29 +0000

Hi All

I have run into a very problematic Doctrine 1.2.2 bug which puts me in quite a bit of danger of having to rewrite my whole app in Doctrine 2 (hopefully if this is a bug it isn't present in Doctrine 2).

The problem I am running into seems like something that probably would have been found and rectified however so hopefully there is something wrong in my execution.

The problem I am running into is caused when I have a combination of the following 3 things in my query:
1) A group by field referencing a table in a relation
2) A join to a different table via a many type relation
3) A limit clause

This combination causes Doctrine to create a broken SQL query which it then throws an exception about when I try to execute the query or call getSqlQuery() on it.

Using some sample data I put together some very simple examples to illustrate the problem:

$q = Doctrine_Query::create(); 
$q->from('Customer Customer'); 
$q->leftJoin('Customer.Order Order'); 
$q->leftJoin('Customer.Zip Zip'); 
$q->addGroupBy('Zip.city');
$q->addSelect('Zip.city as city');
$q->addSelect('Customer.customer_id'); 
$q->addSelect('Order.order_id');
$q->offset(0);
$q->limit(5);

This creates the following dql:

SELECT Zip.city as city, Customer.customer_id, Order.order_id FROM Customer Customer LEFT JOIN Customer.Order Order LEFT JOIN Customer.Zip Zip GROUP BY Zip.city LIMIT 5 OFFSET 0

However when I attempt to run $q->getSqlQuery() an exception is thrown:
{"type":"exception","tid":3,"exception":{},"message":"SQLSTATE[42S22]: Column not found: 1054 Unknown column 'z2.city' in 'group statement'. Failing Query: \"SELECT DISTINCT c2.customer_id FROM customers c2 GROUP BY z2.city LIMIT 5\"","where":"#0 C:\\htdocs\\php_library\\Doctrine-1.2.1\\lib\\Doctrine
Connection.php(1025): Doctrine_Connection->rethrowException(Object(PDOException), Object(Doctrine_Connection_Mysql), 'SELECT DISTINCT...')\n#1 C:\\htdocs\\php_library\\Doctrine-1.2.1\\lib\\Doctrine
Query.php(1263): Doctrine_Connection->execute('SELECT DISTINCT...', Array)\n#2 C:\\htdocs\\php_library\\Doctrine-1.2.1\\lib\\Doctrine
Query.php(1122): Doctrine_Query->buildSqlQuery(true)\n#3............

As you can see from the SQL in the exception Doctrine is trying to create a query that groups by a field from the Zip table with out first joining to it (SELECT DISTINCT c2.customer_id FROM customers c2 GROUP BY z2.city LIMIT 5).

I know Doctrine works some magic to get limit statements to work with joins and I suspect that something with in that magic may be broken, but hopefully its something I am doing wrong.

Take out any one of the 3 things I mentioned I above and everything works fine – the following all work:

Remove the limit:

$q = Doctrine_Query::create(); 
$q->from('Customer Customer'); 
$q->leftJoin('Customer.Order Order'); 
$q->leftJoin('Customer.Zip Zip'); 
$q->addGroupBy('Zip.city'); 
$q->addSelect('Zip.city as city');
$q->addSelect('Order.order_id');
$q->addSelect('Customer.customer_id');

Remove the additional join:

$q = Doctrine_Query::create(); 
$q->from('Customer Customer'); 
$q->leftJoin('Customer.Zip Zip'); 
$q->addGroupBy('Zip.city'); 
$q->addSelect('Zip.city as city');
$q->addSelect('Customer.customer_id');
$q->offset(0);
$q->limit(5);

Remove the group by:

$q = Doctrine_Query::create(); 
$q->from('Customer Customer'); 
$q->leftJoin('Customer.Order Order'); 
$q->leftJoin('Customer.Zip Zip'); 
$q->addSelect('Zip.city as city');
$q->addSelect('Customer.customer_id'); 
$q->addSelect('Order.order_id');
$q->offset(0);
$q->limit(5);

Its also worth noting that the following changes also stop the problem from happening:
Changing the relation to the Order table to be a one relation instead of a many relation.
Changing the group by to a field located in the "from" table (such as: $q->addGroupBy('Customer.customer_id')

Here are the relevant parts of my sample data schema:

detect_relations: false
package: Example
options:
  type: INNODB
  charset: utf8
Order:
  tableName: orders
  columns:
    order_id:
      type: integer(4)
      primary: true
      notnull: true
    customer_id:
      type: integer(4)
    order_date: timestamp
  relations:
    OrderItem:
      type: many
      local: order_id
      foreign: order_id
    Customer:
      type: one
      local: customer_id
      foreign: customer_id
  options:
    type: InnoDB
Customer:
  tableName: customers
  columns:
    customer_id:
      type: integer(4)
      primary: true
      notnull: true
      autoincrement: true
    firstname:
      type: string(45)
    lastname:
      type: string(45)
    streetaddress:
      type: string(45)
    city:
      type: string(45)
    state:
      type: string(45)
    postalcode:
      type: string(45)
  relations:
    Order:
      type: many
      local: customer_id
      foreign: customer_id
    Zip:
      type: one
      local: postalcode
      foreign: postalcode
  options:
    type: InnoDB
Zip:
  connection: default_schema
  tableName: zips
  columns:
    postalcode:
      type: varchar(30)
      primary: true
    latitude: 'float(10,6)'
    longitude: 'float(10,6)'
    city: string(50)
    state: string(50)
    country: string(50)
    type: string(50)
  relations:
    Customer:
      type: many
      local: postalcode
      foreign: postalcode

Thank for any advice or information you can give me on this.

Best regards

Will Ferrer

[DC-584] MSSQL Server: Cannot alter / drop columns which have indexes or constraints applied to them

Tue, 8 Jun 2010 14:30:27 +0000

SQL Server will not allow attempts to alter or drop columns with indexes or constraints applied to them, because they are dependent on the column. In addition to this, SQL Server's syntax for altering columns is different for that of adding them in that it does not allow default value constraints to be present in the alter statement.

I've attached a patch which attempts to circumvent this issue by allowing the author of the changeset to provide a name for the default constraint, which SQL Server supports. Giving the constraint a name of our choosing allows us to reference and drop it before running a command against a constrained column.

In the case of an ALTER query the default constraint portion is spliced and subsequently run.

When dropping a column the author need only make sure they name the constraint, or know its name, then drop it before the query is run.

[DC-583] MSSQL Server: No accounting for max varchar size when creating columns.

Tue, 8 Jun 2010 14:16:21 +0000

The Doctrine_Connection_Mysql and Doctrine_Datadict_Mysql classes utilise a connection property max_varchar_size so if the field length of a string column is specified and exceeds 255 chars a 'text' column type is used instead of a 'varchar' one.

This logic is missing for MSSQL; Doctrine will attempt to create varchar columns even if greater than the max size (8000 chars).

I've attached a patch for MSSQL which mirrors the MySQL functionality, would you consider including it please?

Thanks!

[DC-558] CLONE -generate-migrations-diff is producing bogus migrations (drops the whole database)

Tue, 8 Jun 2010 14:36:33 +0000

Replicating the bug:
1. unzip vanilla sandbox.
2. create schema file with entity
3. run ./doctrine build-all
4. modify schema, add column to entity.
5. run ./doctrine generate-migrations-diff

Expected behaviour:
generates migration wich adds column to entity.

Real behaviour:
Drops entity from database

[DC-538] Doctrine_Table::enumIndex() and Doctrine_Table::enumValue() should return easily distinguishable value (e.g. false) when index/value is not found

Tue, 8 Jun 2010 15:00:10 +0000

At the moment:

Doctrine_Table::enumIndex($fieldName, $value) returns $value specified as a parameter if no index for it is found
Doctrine_Table::enumValue($fieldName, $index) returns $index specified as a parameter if no value for it is found

This actually makes writing code which deals with enums a bit difficult as one would like to detect incorrect parameter as soon as possible (e.g. not when Doctrine validation kicks in and checks that enum value is incorrect).

Current algorithm that returns index or value is not sufficient to determine error in situation when index=value, e.g. enum values are [0, 1, 2, 3]. Calling e.g. enumValue('sample', 4) would yield 4 - so it makes difficult to determine whether it's correct value.

I hope this makes sense, let me know if anything is unclear.

The workaround for this is to check whether mapped index/value exists in array returned by Doctrine_Table::getEnumValues(), but this is an extra unnecessary check.

So instead of writing:

$index = 5;
$someTable = Doctrine_Core::getTable('Sample');
$value = $someTable->enumValue('sample', $index);

$values = $someTable->getEnumValues('sample');
if (in_array($value, $values) == false)
{
  throw new UnexpectedValueException('illegal index specified!');
}

I'd like to write:

$index = 5;
$value = Doctrine_Core::getTable('Sample')->enumValue('sample', $index);
if ($value === false)
{
  throw new UnexpectedValueException('illegal index specified!');
}

Simpler, eh?

[DC-470] [PATCH] Search : wrong connection used for some queries when multiples connections are defined

Tue, 6 Jul 2010 10:48:13 +0000

When multiples connections are defined, sometimes the Search behavior use a wrong one.

This happens because the Query::loadRoot() method calls the Manager::getConnectionForComponent(), which returns the bound connection for the root component (like ModelIndex in this case), but the connection for this component is never bound.
The following and attached patch solved the issue for me.

Search / connection patch

Index: lib/Doctrine/Search.php
===================================================================
--- lib/Doctrine/Search.php	(révision 7080)
+++ lib/Doctrine/Search.php	(copie de travail)
@@ -76,7 +76,9 @@
         $result = parent::buildTable();

         if ( ! isset($this->_options['connection'])) {
-            $this->_options['connection'] = $this->_options['table']->getConnection();
+            $manager = Doctrine_Manager::getInstance();
+            $this->_options['connection'] = $manager->getConnectionForComponent($this->_options['table']->getComponentName());
+            $manager->bindComponent($this->_options['className'], $this->_options['connection']->getName());
         }

         return $result;

Note : we can't use directly
$this->_options['connection'] = $this->_options['table']->getConnection();
because I sometimes found the getConnection() returns the wrong connection (I didn't looked why).

[DC-439] Import of table with (silly) name "index"

Thu, 24 Mar 2011 12:51:22 +0000

In Doctrine/Import/Mssql.php are this procedure calls:

92: $sql = 'EXEC sp_primary_keys_rowset @table_name = ' . $this->conn->quoteIdentifier($table, true);
99: $sql = 'EXEC sp_columns @table_name = ' . $this->conn->quoteIdentifier($table, true);
219: $query = 'EXEC sp_statistics @table_name = ' . $table;
222: $query = 'EXEC sp_pkeys @table_name = ' . $table;

which fail with sql "keyword" table names.

Using ...['. $table . ' ]' around the table name worked for me.
I don't know anything about the backend of doctrine.
Should this be done by quoteIdentifier, or is this fix okay?
.. @table_name = [' . $this->conn->quoteIdentifier($table, true) . ']';

Many thanx for all!
Jochen Bayer

[DC-405] isset() via array interface does not "see" virtual property defined inside the model definition

Tue, 8 Jun 2010 16:19:00 +0000

see: http://groups.google.com/group/doctrine-user/browse_thread/thread/0e41373cd46872a9?hl=en#

The issue is caused by isset() returning false if the column is not setup via hasColumn(). The accessor method is however obviously callable on the OO interface. By preventing the isset() call in contains() we got things to work, but its obviously a hack:

class entity extends base_entity 
{ 
    public function setUp() 
    { 
        parent::setUp(); 
        $this->hasAccessor('urlizedname', 'getUrlizedname'); 
    } 
    public function getUrlizedid() 
    { 
        $type = $this->_get('type'); 
        return $this->_get('id') - $type::$idOffset; 
    } 
    /** 
     * FIXME:hackish override of the parent contains method to support array access of urlizedid, remove if possible 
     */ 
    public function contains($fieldName) 
    { 
        if ($fieldName === 'urlizedid') { 
            return true; 
        } 
        return parent::contains($fieldName); 
    } 
}

[DC-399] Doctrine_Record::unlink() causes records to be deleted

Wed, 9 Jun 2010 14:31:34 +0000

Using Doctrine_Record::unlink() with a One-To-Many relationship, and then saving the record will cause the related records to be deleted. Example:

You have a Discount linked to many Customers. When revoking a customer's discount, you unlink the two records. $discount->unlink("Customers", $customer->id); if you $discount->save(); afterwards, the Customer will be deleted.

This seems to be caused due to unlink() not calling the collection's takeSnapshot() after removing the records, which causes the save to delete them. There didn't seem to be a clear indication in the documentation it would do this, and in version 1.0.14 it doesn't seem to do this deletion.

[DC-391] Connection rollback exception hides real exception

Tue, 8 Jun 2010 15:14:00 +0000

Same issue as http://www.doctrine-project.org/jira/browse/DC-207 but also for the 1.1 branch.

This is not only an issue when trying to talk to non-existing databases but for any exception thrown by the connection.

UnitOfWork.php:133

        } catch (Exception $e) {
            // Make sure we roll back our internal transaction
            //$record->state($state);
            $conn->rollback();
            throw $e;
        }

[DC-364] Adding the fieldName to mutator/accessor methods

Tue, 8 Jun 2010 16:49:58 +0000

Would it be possible to add the fieldName to the function variables when a mutator or accessor function is called. This would allow for more generalized accessor / mutator functions that can be reused easily.

example:

public function mutatorFunction($value, $load, $fieldName)
{
$this->_set($fieldName, someValidationFunction($value));
}

Thank you

[DC-363] Multiple connections and i18n

Wed, 28 Mar 2012 08:24:28 +0000

I used to work with a single database named "doctrine". The query was working properly.

I then decided to use 2 databases so I got my schema like this:

connection: doctrine

Category:
actAs:
I18n:
actAs:
Sluggable:
fields: [name]
Timestampable: ~
fields: [name, description]
columns:
id: ~
name:
type: string(255)
notnull: true
description: string

User:
connection: second
columns:
id: ~
name:
type: string(255)
notnull: true

I did setup my connections in config/databases.yml this way:

all:
doctrine:
// ....
second:
// ....

build-model, build-forms, build-filters and cc got ran. But now, I got an exception saying the "Translation" relation doesn't exist. The Base Models include correctly the bindComponent line:

Doctrine_Manager::getInstance()->bindComponent('Category', 'doctrine');

For now, I managed to kind of fixing it with simply swapping the databases order in my config/databases.yml and it's now working again perfectly.

I forgot to mention that in the CategoryTable when i call $this->getConnection()->getName(), it outputs "second"

[DC-349] Issue with quoting of booleans in Oracle

Tue, 8 Jun 2010 15:10:18 +0000

I've run into a problem where I'm unable to set a default value for a boolean field when creating Oracle tables using Doctrine. The summary of this issue is that when Doctrine quotes a '0' or false value for a boolean field, it comes back blank... which doesn't work as an option for the DEFAULT parameter of field definitions in table creation.

Here are the hairy details. I have a schema which looks something like this (simplified for the example):

User:

  tableName: users

  columns:

    id: {type: integer, primary: true, autoincrement: true}

    username: {type: string, length: 255, unique: true, notnull: true}

    disabled: {type: boolean, default: false}

When I export the table, it's generating invalid DDL like this:

CREATE TABLE users (id NUMBER(8), username VARCHAR2(255) NOT NULL UNIQUE, disabled NUMBER(1) DEFAULT , PRIMARY KEY(id))

The important part of this is the DEFAULT parameter on the 'disabled' field definition – it's missing the value. I tracked all this down to an issue in Doctrine_Formatter->quote(), which gets called when the DDL is being created. When passed '0' as its input with a type of boolean, it apparently returns the empty string. This may ultimately be a bug in the PDO_OCI driver, because the quote method is relying on the quote method of the database handle.

I've hacked around this by overriding the behaviour of the quote method in Doctrine_Connection_Oracle. I did this by adding the following method:

    /**
     * Override quote behaviour for boolean to fix issues with quoting of
     * boolean values.
     */
    public function quote($input, $type = null)
    {
        if ($type === 'boolean') {
            if ($input === null) {
                return null;
            } else {
                return (($input) ? 1 : 0);    
            }
      } else {
        return parent::quote($input, $type);  
      }
    }

It seems to work for me, but I'd appreciate it if wiser heads than me would take a look and see if this is a sign of some larger issue, and if the way I've fixed it seems appropriate. I also am unsure of how/if this needs to propogate to newer versions.