Doctrine Project

[DC-1006] Custom geometric query error with orderBy

Sun, 22 May 2011 19:41:17 +0000

Mi Doctrine_Query with this Geometric Query fails with orderBy , but with where works.

$distance = "glength(linestringfromwkb(linestring(GeomFromText('POINT( ".$object->getLatitude()." ".$object->getLongitude() .")'),l.point))) "

This works:
SomeObjectTable::getInstance()~~>createQuery()~~>where($distance.' < ?',0.05 )

But this one fails at version 1.2.4, with older version was working.
SomeObjectTable::getInstance()~~>createQuery()~~>where($distance.' < ?',0.05 )->orderBy($distance)

Well the problem is at line 74 of OrderBy.php :
$componentAlias = implode('.', $e);

the rendered query in the distance has some ".", for example:
POINT( -34.470829 -58.5286102)

then the after line 74 in OrderBy tries to search por '58' class.

I manually added to DataDict in Mysql.php the POINT datatype (this fix solve me the problem in older versions of Doctrine).

[DC-895] [I18n] Defining languages with locality (eg. en_GB) breaks functionality with SQL Integrity error - fix included

Wed, 20 Oct 2010 04:42:40 +0000

When defining languages as language_COUNTRY codes (supported by symfony by default), the functionality to work with I18n records breaks, resulting in "SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry" errors.

The reason is very simple: Doctrine's I18n language column is defined as a CHAR(2), thus shortening eg. "en_GB" value to "en", thus causing the above SQL error when a "en" translation for a record already exists.

The solution is even simpler: change the column's length to 7 in the Doctrine_I18n class's options: I've tested this and all runs great: the correct SQL is being generated, the models behave correct, ...

[DC-803] Syntax error in MySQL migration to drop constraint (patch supplied)

Thu, 29 Jul 2010 11:58:16 +0000

I have a migration that adds constraints correctly. When migrating down, however, I get a syntax error

ErrorMessage

  Error #1 - SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'CONSTRAINT unique_username_idx' at line 1. Failing Query: "ALTER TABLE conUser DROP CONSTRAINT unique_username_idx"

Here is the down migration:

DownMigration

    public function down() {
        $this->dropConstraint('conUser', 'unique_username_idx');
    }

The SQL generated is "ALTER TABLE conUser DROP CONSTRAINT unique_username_idx". This post (http://forums.mysql.com/read.php?98,70887,70974#msg-70974) suggests that in MySQL the syntax should be "ALTER TABLE conUser DROP INDEX unique_username_idx" as constraints are basically indexes in MySQL (unlike MSSQL and Oracle). Doctrine's lib/Doctrine/Export/MySql.php appears to have a syntax error in the dropConstraint method. I attach a patch for this, but the only change is replacing "$name = 'CONSTRAINT '" with "$name = 'INDEX '" in dropConstraint. The migration then runs as I would expect.

Sorry if this has been fixed elsewhere, I did a search but couldn't find a similar ticket.

[DC-799] Doctrine_Query::parseFunctionExpression() produces unexpected results if the expression contains a function

Tue, 27 Jul 2010 16:42:17 +0000

When Doctrine_Query::parseFunctionExpression() is called with the following parameter and $this->_conn->expression is of type Doctrine_Expression_MySql:

$expr = "DATE_FORMAT(datefield,'%Y-%m-%d'),someotherfield"

The expected result from Doctrine_Query::parseFunctionExpressoin() would be

DATE_FORMAT(l.datefield,'%Y-%m-%d'),l.someotherfield

However, the actual result is

DATE_FORMAT(l.datefield,'%Y-%m-%d'),someotherfiel

Note the missing leading "l." and the last character ("d") on "someotherfield".
Obviously this leads to fatal errors.

This example is a result of calling addGroupby("DATE_FORMAT(datefield,'%Y-%m-%d'),someotherfield") on a Doctrine_Query object.

[DC-795] Can't mix Soft and Hard deletes. Fix with patch provided.

Wed, 21 Jul 2010 14:47:10 +0000

I reported this bug on the symfony site, but after investigation i have found that it is actually a doctrine SoftDelete issue. http://trac.symfony-project.org/ticket/8898

I have a sandbox replicating the problem here:
http://dl.dropbox.com/u/8354765/sf_sandbox.zip

Run the test:
./symfony test:unit Contact

The issue is I want to hard delete my M-M link table and soft delete the parents. This fails. I believe it is to do with the fact that the relations to the parent are marked as Doctrine_Record::STATE_TCLEAN which when the SoftDelete calls save on the parent object this flag trys to reinsert the relations that it has deleted. Things go very wrong at this point and the connection is rolled back.

The fix I have is the following, not sure what this would do to other things or not as I am not overly familiar with Doctrine internals...

Index: Doctrine/Template/Listener/SoftDelete.php
===================================================================
--- Doctrine/Template/Listener/SoftDelete.php	(revision 12962)
+++ Doctrine/Template/Listener/SoftDelete.php	(working copy)
@@ -95,6 +95,7 @@
     public function postDelete(Doctrine_Event $event)
     {
         if ( ! $this->_options['hardDelete']) {
+            $event->getInvoker()->clearRelated();
             $event->getInvoker()->save();
         }
     }

This works even if the relations have been marked as SoftDelete.

[DC-769] Variable type different for return value from Doctrine_Record->toArray() depending on whether the object is from a select, or a save.

Tue, 24 Aug 2010 12:55:48 +0000

With a object that is created via a save(), and the record's primary key is a INT fed by a SEQUENCE, the type of the variable is an INT.

With an object that is hydrated from the database via a SELECT, the record's primary key INT will come back in 'toArray()' as a STRING.

That means that checking for type has to know what context it came from, user, INSERT, or SELECT. Not fun.

This also screws up converting arrays to JSON, 'cause the STRINGS get quotation marks and the INTS do not.

As a general rule, everything FROM the database seems to be strings. Yes, I know, everything 'on the wire' or 'through a socket' comes out as text. And it's a lot faster to leave it that way.

But having the type be different depending on the database operation? Not sure I like that.

[DC-764] Major->please.....Value of Primary key from sequence in Postgres table NOT being set (although sequence gets incremented)

Fri, 25 Jun 2010 18:00:37 +0000

In the ERD/schema that I have set up, a couple levels down in hierarchal order, a table has 3 composite foreign keys, and one sequence of its own. That sequence does not get get set into the 'Table->sequence variable'. That means when the file 'UnitOfWork' executes the function '_assignSequence()', it finds no sequence name, and skips the assignment of the sequence value.

This of course blows up my inserts.

I have included the following documentation:

A/ An installation and further description README.tx file.
B/ SQL script to generate a anonymous version of my ERD - I.E. the table names and column names have been changed to protect the guilty (and proprietary)
C/ A fixture file to load some data.
D/ A *.png file showing a graphical view of the ERD.
E/ The generated schema.yml file from ./symfony doctrine:build-schema
F/ A modifiled (has certain echo statements for troubleshooting purposes) UnitOfWork.php file.
G/ A task file to run that tries to load the schema with valid values.
H/ An output file from running the Task and modified UnitOfWork.php file showing the exact point of error during insert.

Please let me know what I can do to help get this troubleshot quicly. Thx
E/

[DC-753] doctrine generate-migrations-diff throws "No php or yml files found at path"

Thu, 27 Jan 2011 13:07:37 +0000

I am trying to generate migrations from the CLI but I get the error mentioned in the title. I did some searching and this seems to have been a known problem and was fixed, however, I'm getting it and the path is correct, and there is even a schema.yml file I just generated, also through CLI.

Here is the error:

D:\wamp\www\project\src\administrator\components\com_project\doctrine>php doctrine generate-migrations-diff
No php or yml files found at path: "D:\wamp\www\project\src\administrator\components\com_project\doctrine\schema"

And here is what I have in my CLI file:

require_once('../../../../libraries/doctrine/lib/Doctrine.php');

spl_autoload_register(array('Doctrine','autoload'));

Doctrine_Manager::connection('mysql://root@localhost/project','default');

//Doctrine_Manager::getInstance()->setAttribute(Doctrine::ATTR_TBLNAME_FORMAT, 'jos_project_%s');
Doctrine_Manager::getInstance()->setAttribute(Doctrine::ATTR_VALIDATE, Doctrine::VALIDATE_ALL);
Doctrine_Manager::getInstance()->setAttribute(Doctrine::ATTR_QUOTE_IDENTIFIER, true);
Doctrine::loadModels('models/generated');
Doctrine::loadModels('models');

$cli = new Doctrine_Cli(array(
'data_fixtures_path' => dirname(_FILE_).DIRECTORY_SEPARATOR.'fixtures',
'models_path' => dirname(_FILE_).DIRECTORY_SEPARATOR.'models',
'migrations_path' => dirname(_FILE_).DIRECTORY_SEPARATOR.'migrations',
'sql_path' => dirname(_FILE_).DIRECTORY_SEPARATOR.'sql',
'yaml_schema_path' => dirname(_FILE_).DIRECTORY_SEPARATOR.'schema'
));

$cli->run($_SERVER['argv']);

I find this very weird because earlier today I was able to make a migration the same way but with Symfony's CLI, however, that is another project.

Regards,

David

[DC-740] issue with multiple connection handling

Tue, 16 Nov 2010 03:08:32 +0000

I've found an issue where doctrine will use the wrong connection for tables under certain conditions.

In a template, I'm doing a $sf_user->hasCredential() - which is causing this to be run in sfGuardSecurityUser,

$this->user = Doctrine::getTable('sfGuardUser')->find($id);

When this execute, the calls find themselves to Doctrine_Manager::getConnectionForComponent($componentName)

This method calls Doctrine_Core::modelsAutoload($componentName);, which fails to load the class, and returns false (no checking is done to see if it should return true).

As this fails to include the sfGuardUser classes wher the component binding goes on, the getTAble call will use the default connection, then create the table fails to use the correct connection

Doctrine_Core::getTable()

return Doctrine_Manager::getInstance()->getConnectionForComponent($componentName)->getTable($componentName);

the binding is done after the call to getConectionForComponent, as it's getTable that will ultimately cause the autoloader to pull in the table classes.

[DC-717] Default value for columns is generated wrong. THe default value becomes the result value in the schema files.

Sun, 6 Jun 2010 10:39:22 +0000

When generating models from db with doctrine 1.2.2, default with functions in database get evaluated and the value goes to the generated schema files thus cousing error on insert/update.

Example:
Table:
CREATE TABLE Usuario (
id SERIAL NOT NULL,
apelido CHARACTER VARYING(50) NOT NULL,
email CHARACTER VARYING(255) NOT NULL,
dtRegistro TIMESTAMP DEFAULT 'now()' NOT NULL,
idUsuarioSituacao INTEGER,
senha CHARACTER(32),
CONSTRAINT PK_Usuario PRIMARY KEY (id),
CONSTRAINT TUC_Usuario_1 UNIQUE (email)
)

Code to generate files:
$dManager = Doctrine_Manager::getInstance();
$dManager->setAttribute(Doctrine::ATTR_MODEL_LOADING,Doctrine::MODEL_LOADING_CONSERVATIVE);
$dManager->setAttribute(Doctrine_Core::ATTR_MODEL_LOADING, Doctrine_Core::MODEL_LOADING_CONSERVATIVE);

$dManager->setAttribute(Doctrine::ATTR_PORTABILITY, Doctrine::PORTABILITY_NONE);
$dManager->setAttribute(Doctrine::ATTR_VALIDATE, Doctrine::VALIDATE_NONE);
$dManager->setAttribute(Doctrine::ATTR_AUTO_ACCESSOR_OVERRIDE, true);
$dManager->setAttribute(Doctrine::ATTR_AUTOLOAD_TABLE_CLASSES, true);
$dManager->setAttribute(Doctrine::ATTR_QUERY_LIMIT, Doctrine::LIMIT_ROWS);

Doctrine_Core::generateModelsFromDb('c:\temp', array('dbcon'), array('generateTableClasses' => true, 'classPrefix' => 'D'));

Resulting file:
abstract class DBaseUsuario extends Doctrine_Record
{
public function setTableDefinition()

{ $this->setTableName('usuario'); $this->hasColumn('id', 'integer', 4, array( 'type' => 'integer', 'length' => 4, 'fixed' => false, 'unsigned' => false, 'primary' => true, 'sequence' => 'usuario_id', )); $this->hasColumn('apelido', 'string', null, array( 'type' => 'string', 'fixed' => false, 'unsigned' => false, 'notnull' => true, 'primary' => false, )); $this->hasColumn('email', 'string', null, array( 'type' => 'string', 'fixed' => false, 'unsigned' => false, 'notnull' => true, 'primary' => false, )); $this->hasColumn('dtregistro', 'timestamp', null, array( 'type' => 'timestamp', 'fixed' => false, 'unsigned' => false, 'notnull' => true, 'default' => '\'2010-06-04 11:10:12.078\'::timestamp without time zone', 'primary' => false, )); $this->hasColumn('idusuariosituacao', 'integer', 4, array( 'type' => 'integer', 'length' => 4, 'fixed' => false, 'unsigned' => false, 'notnull' => false, 'primary' => false, )); $this->hasColumn('senha', 'string', null, array( 'type' => 'string', 'fixed' => true, 'unsigned' => false, 'notnull' => false, 'primary' => false, )); }

}

The function now() for default value gets replaced by 'default' => '\'2010-06-04 11:10:12.078\'::timestamp without time zone',

[DC-708] Wrong definition for MySQL string primary column

Mon, 12 Jul 2010 16:32:44 +0000

If you define a primary column, the attribute notnull is removed from the column definition because Doctrine assumes that primary columns are always not null.

Now suppose you have a schema like this, with a string primary column.

Client:
  columns:
    serial:    { type: string(50), notnull: true, primary: true }
    name:      { type: string(36), notnull: true }

That's fine, but causes problems with MySQL where the column is created with a default value of "" (empty string) and not <none>.

CREATE TABLE client (serial VARCHAR(50), name VARCHAR(36) NOT NULL, PRIMARY KEY(serial)) ENGINE = INNODB;

Note that the 2nd column is well defined and has <none> as default value (as seen from phpMyAdmin).

I attached a quick-workaround to disable the code which removes the notnull attribute from column definition.

After that the SQL code is like this:

CREATE TABLE client (serial VARCHAR(50) NOT NULL, name VARCHAR(36) NOT NULL, PRIMARY KEY(serial)) ENGINE = INNODB;

[DC-674] NULL Dates are translated to '0000-00-00' after upgrading to 1.2.2

Wed, 6 Oct 2010 06:29:40 +0000

Once the upgrade was done from Doctrine 1.2.1 to 1.2.2 we discovered that date related issues started to appear.
With dates that are persisted in DB as NULL are translated to "0000-00-00" when retrieved from DB. This has occurred in multiple places and is quite worrying as there is a lot of dates in our project. This means that everywhere in our codebase where we check a datevalue in our Models is NULL we need also to check for the string literal "0000-00-00".

[DC-651] [PATCH] Doctrine_Record::option('orderBy', ...) of join's right side being applied to refTable in m2m relationship

Wed, 31 Aug 2011 12:43:09 +0000

When using the Doctrine_Record::option('orderBy', ...) feature on a table definition, where that table is the target of a many-to-many join, the specified orderBy columns are applied to the relation table's alias. So for example, given the following definitions:

class User extends Doctrine_Record {
  public function setTableDefinition() {
    $this->hasColumn('uid', 'integer', null, array('primary' => true));
    $this->option('orderBy', 'uid');
  }

  public function setUp() {
    $this->hasMany('Group as groups', array('refClass' => 'UserGroup', 'local' => 'user_uid', 'foreign' => 'group_id'));
  }
}

class Group extends Doctrine_Record {
  public function setTableDefinition() {
    $this->hasColumn('gid', 'integer', null, array('primary' => true));
  }

  public function setUp() {
    $this->hasMany('User as users', array('refClass' => 'UserGroup', 'local' => 'group_gid', 'foreign' => 'user_id'));
  }
}

class UserGroup extends Doctrine_Record {
  public function setTableDefinition() {
    $this->hasColumn('user_uid', 'integer', null, array('primary' => true));
    $this->hasColumn('group_gid', 'integer', null, array('primary' => true));
  }

  public function setUp() {
    $this->hasOne('User as user', array('local' => 'user_uid', 'foreign' => 'uid'));
    $this->hasOne('Group as group', array('local' => 'group_gid', 'foreign' => 'gid'));
  }
}

the following queries:

$query = Doctrine_Query::create()
  ->select('u.*')
  ->from('User u')
  ->leftJoin('u.groups g WITH g.gid=?', 1);
echo $query->getSqlQuery() . "\n";

$query = Doctrine_Query::create()
  ->select('g.*')
  ->from('Group g')
  ->leftJoin('g.users u WITH u.uid=?', 1);
echo $query->getSqlQuery() . "\n";

will output the following:

SELECT u.uid AS u__uid FROM user u LEFT JOIN user_group u2 ON (u.uid = u2.user_uid) LEFT JOIN group g ON g.gid = u2.group_id AND (g.gid = ?) ORDER BY u.uid
SELECT g.gid AS g__gid FROM group g LEFT JOIN user_group u2 ON (g.gid = u2.group_gid) LEFT JOIN user u ON u.uid = u2.user_id AND (u.uid = ?) ORDER BY u.uid, u2.uid

The orderBy option() call is applied to the User definition. The SQL for the first query is correct (where User is on the left side of the join). The SQL for the second query (where User is on the right-most side of the join), however, is obviously incorrect (UserGroup doesn't even have a uid column). Basically, User's orderBy option is being applied to both the User table and its respective reference table, UserGroup, when it is the target of a join.

After digging through the source for a while, I believe I've come up with a patch for this issue (which should be checked by someone more knowledgeable of Doctrine's internals). Basically, in the Doctrine_Query::buildSqlQuery() function, a call is made to Doctrine_Relation::getOrderByStatement() with the reference table (UserGroup)'s alias (u2), which in turn makes a call to Doctrine_Table::getOrderByStatement() on the referenced table (User), filling in the ORDER BY clause with User columns using UserGroup's alias. My solution was to reorder the logic so that the test for a reference class is made before the initial call to getOrderByStatement() is made. It seems to work against my test case and the test cases in the repository. I'll post my patch momentarily.

This bug was first mentioned in the comments in DC-313, but the original ticket comes across as more of a feature request for the hasMany() orderBy feature.

[DC-605] importSchema uses the connection name to identify the schema name

Mon, 29 Mar 2010 14:36:24 +0000

importSchema in Doctrine_Import(l:369) iterates over the connections to check if it matches the passed $databases, however, giving the connection a name anything different than the databasename causes the entire function to malfunction..

So a workaround is to pass connection names as a second argument to `generateModelsFromDb` instead of the database names.

Also, if you wouldnt give a name to a connection, as you would possible do with cache connections since the argument isnt mandatory, then the equation is skipped entirely causing it to run on the cache connection..

[DC-602] Cardinality violation when searching phrase

Mon, 29 Mar 2010 14:42:41 +0000

Im have setup search behaviour for my model.

Searching phrase "foo bar" throws "Doctrine_Connection_Mysql_Exception"

SQLSTATE[21000]: Cardinality violation: 1242 Subquery returns more than 1 row

To fix the issue replace line 208 in file: Doctrine/Search/Query.php

$where .= ' AND (position + ' . $k . ') = (SELECT position FROM ' . $this->_table->getTableName() . ' WHERE ' . $this->parseWord($word) . ')';

with:

$where .= ' AND (position + ' . $k . ') IN (SELECT position FROM ' . $this->_table->getTableName() . ' WHERE ' . $this->parseWord($word) . ')';

[DC-596] make it possible to pass in builderOptions for templates

Mon, 29 Mar 2010 14:00:24 +0000

http://trac.symfony-project.org/ticket/8421

It seems like it just requires to pass in a builderOption array into any class extending Doctrine_Record_Generator. I think it would be a good idea to start adding support for this into all internal behaviors.

and then doing something like the following in the schema:

Foo:
actAs:
Taggable:
builderOptions:
baseClassName: MyBaseRecord

[DC-592] PHP Fatal error: Call to undefined method Doctrine_Connection_Oracle::getDeclaration() in ....\Doctrine\Export\Oracle.php on line 501

Mon, 29 Mar 2010 14:48:50 +0000

When I try to execute a migration of my DB with doctrine CLI migrate, i get this error.
I fixed it changing the following in Export/Oracle.php
#501 : $fields[] = $this->conn->getDeclaration($fieldName, $field); => $fields[] = $this->getDeclaration($fieldName, $field);

#509 : $fields[] = $fieldName. ' ' . $this->conn->getDeclaration('', $field['definition']); => $fields[] = $fieldName. ' ' . $this->getDeclaration('', $field['definition']);

[DC-579] Doctrine_Record->_get() with $load === false generates E_NOTICE (patch)

Mon, 29 Mar 2010 14:24:55 +0000

In Record.php, _get() method called with $load parameter setted to false can generate an E_NOTICE.
Attached patch fix this.

[DC-577] Sluggable can not index slug if using a provider

Tue, 16 Mar 2010 15:18:31 +0000

The Sluggable template does not add an index for the slug if the fields option is empty.

The provider option will not be used if the fields option is not empty.

The Sluggable template does not use the fields option in creating the index for the slug, so removing the requirement for a non-empty fields option seems to be an appropriate fix.

[DC-574] Add support for __toString() in the generator

Mon, 15 Mar 2010 14:20:57 +0000

I noticed that the TaggableTag class does not contain a __toString() method. Looking further I found that the generator does not support this atm, but it was easy to add.

[DC-573] Invalid SQL generated by Doctrine_Query::getLimitSubquery() when ordering by multiple columns

Mon, 15 Mar 2010 11:36:02 +0000

When attempting to order a query by multiple columns I came across this bug. I've attached a reproduction script which will hopefully illustrate the behaviour, but essentially getLimitSubquery() is parsing the order by column incorrectly, leading to an erroneous comma in the sub-select field select clause, e.g

SELECT [m].[id] AS [m__id], [m].[name] AS [m__name], [m].[date] AS [m__date], [r].[id] AS [r__id], [r].[model_id] AS [r__model_id], [r].[name] AS [r__name] FROM [model] [m] INNER JOIN [relation] [r] ON [m].[id] = [r].[model_id] WHERE [m].[id] IN (SELECT TOP 1 [inner_tbl].[id] FROM (SELECT DISTINCT TOP 1 [m].[id], [r].[name],, [r].[id] FROM [model] [m] INNER JOIN [relation] [r] ON [m].[id] = [r].[model_id] ORDER BY [r].[name], [r].[id]) AS [inner_tbl] ORDER BY [inner_tbl].[name] DESC, [inner_tbl].[id] DESC) ORDER BY [r].[name], [r].[id]

(note [r].[name],, [r].[id] - that's the offender).

I've attached a patch against 1.2 HEAD that strips any commas from the fields before they are added to the select clause; it works for me but I'm not sure of all the use cases across the relevant drivers.

[DC-570] Make table classes suffix configurable (with patch)

Mon, 15 Mar 2010 11:16:31 +0000

I follow Zend Framework (PEAR) class naming conventions, and my user table class should be named User_Table instead of UserTable and be placed in User/Table.php instead of UserTable.php. Since Table suffix is hardcoded, it's not possible to do that.

I added ATTR_TABLE_CLASS_SUFFIX attribute and set it to Table by default, so that existing code is not affected. Now, if I want, I can change that prefix to _Table and be happy. The patch is attached.

[DC-569] Duplicate unique indexes on PostgreSQL

Mon, 15 Mar 2010 15:32:01 +0000

Generated by doctrine-cli SQL is:

– this is ok
CREATE TABLE "image" ("id" BIGSERIAL, "alt" VARCHAR(255), "title" VARCHAR(500), "filename" VARCHAR(255), "width" BIGINT, "height" BIGINT, "slug" VARCHAR(255), "createdat" TIMESTAMP NOT NULL, "updatedat" TIMESTAMP NOT NULL, PRIMARY KEY("id"));
CREATE TABLE "news" ("id" BIGSERIAL, "title" VARCHAR(255), "leadmarkup" VARCHAR(500), "leadhtml" VARCHAR(600), "bodymarkup" TEXT, "bodyhtml" TEXT, "slug" VARCHAR(255), "createdat" TIMESTAMP NOT NULL, "updatedat" TIMESTAMP NOT NULL, PRIMARY KEY("id"));
CREATE TABLE "snippet" ("id" BIGSERIAL, "name" VARCHAR(255), "bodymarkup" TEXT, "bodyhtml" TEXT, "slug" VARCHAR(255), "createdat" TIMESTAMP NOT NULL, "updatedat" TIMESTAMP NOT NULL, PRIMARY KEY("id"));
– this causes error
CREATE UNIQUE INDEX "sluggable" ON "image" ("slug");
CREATE UNIQUE INDEX "sluggable" ON "news" ("slug");
CREATE UNIQUE INDEX "sluggable" ON "snippet" ("slug");

After importing this to PostgreSQL, I get 'index already exists' error.

On PostgreSQL unique indexes names must not be the same.
I think the correct form should be:
CREATE UNIQUE INDEX "sluggable-image" ON "image" ("slug");
CREATE UNIQUE INDEX "sluggable-news" ON "news" ("slug");
CREATE UNIQUE INDEX "sluggable-snippet" ON "snippet" ("slug");

Schema file attached.

[DC-568] Make it possible to use microtime as the version value when using Versionable

Mon, 15 Mar 2010 10:47:56 +0000

This patch basically makes it possible to pass in a custom auditlog listener as well as providing a new listener that uses microtime to generate the version value's instead of incrementing an integer value starting at 1. This should provide a much better handling for concurrent inserts and should also be faster, since for all but the first version a complex select is necessary in the current implementation.

Open question is if the accuracy multiplier should be an option or not. Also is there any reason why the column definition doesnt default to an unsigned, not that it matters all that much?

[DC-567] RawSql: getCountSqlQuery does not work correctly with PostgreSQL (patch provided)

Mon, 15 Mar 2010 10:33:14 +0000

Dears,

Line 309 in Doctrine_RawSql:

        $q = 'SELECT COUNT( DISTINCT '.implode(',',$fields).') as num_results';

        $string = $this->getInheritanceCondition($this->getRootAlias());
        if ( ! empty($string)) {
            $this->_sqlParts['where'][] = $string;
        }

        $q .= ( ! empty($this->_sqlParts['from']))?    ' FROM '     . implode(' ', $this->_sqlParts['from']) : '';
        $q .= ( ! empty($this->_sqlParts['where']))?   ' WHERE '    . implode(' AND ', $this->_sqlParts['where']) : '';
        $q .= ( ! empty($this->_sqlParts['groupby']))? ' GROUP BY ' . implode(', ', $this->_sqlParts['groupby']) : '';
        $q .= ( ! empty($this->_sqlParts['having']))?  ' HAVING '   . implode(' AND ', $this->_sqlParts['having']) : '';

produces with PostgreSQL: Undefined function: 7 ERROR: function count(bigint, integer) does not exist

but

        $q = 'SELECT COUNT(*) as num_results FROM (SELECT DISTINCT '.implode(', ',$fields);

        $string = $this->getInheritanceCondition($this->getRootAlias());
        if ( ! empty($string)) {
            $this->_sqlParts['where'][] = $string;
        }

        $q .= ( ! empty($this->_sqlParts['from']))?    ' FROM '     . implode(' ', $this->_sqlParts['from']) : '';
        $q .= ( ! empty($this->_sqlParts['where']))?   ' WHERE '    . implode(' AND ', $this->_sqlParts['where']) : '';
        $q .= ( ! empty($this->_sqlParts['groupby']))? ' GROUP BY ' . implode(', ', $this->_sqlParts['groupby']) : '';
        $q .= ( ! empty($this->_sqlParts['having']))?  ' HAVING '   . implode(' AND ', $this->_sqlParts['having']) : '';

        $q .= ') as results';

works and should work with every database server.

Continue your great work

Regards,

Raphaël Dehousse

[DC-565] Versionable bugging when used with I18N

Mon, 15 Mar 2010 16:01:29 +0000

The solution was to allow Versionable to skip fields.
I've fixed with this changing:

Doctrine/AuditLog.php
#84:

$skipFields = (isset($this->_options['skipFields']))?$this->_options['skipFields']:array();

#88:

//inside the foreach
if(in_array($column, $skipFields))

Unknown macro: { continue; }

After that the Versionable will accept some parameters.

ps: If possible, let me know about this changes cause my sources are with this fix.

[DC-564] Postgresql: listSequences: relname badly "formatted" (patch provided)

Mon, 15 Mar 2010 15:13:01 +0000

Dears,

Let's say you create your database first. If you have a serial/bigserial, a sequence is automaticaly created. It's called for example: 'id_seq'
During the cretion of the model, the sequence name is, so, called id_seq.

But in Doctrine_Formatter, line 233, you have getSequenceName that format Doctrine_Core::ATTR_SEQNAME_FORMAT that comes from Doctrine_Manager line 143, you have Doctrine_Core::ATTR_SEQNAME_FORMAT => "%s_seq", so, the sequence name will wrongly be id_seq_seq.

This could be avoid if the sequence_name would not contain the "_seq" suffix coming from the import. WDYT?

This could be possible thanks to a change in Doctrine_Import_Pgsql, line 50:

'listSequences' => "SELECT
        rtrim(relname, '_seq')
    FROM
        pg_class
    WHERE relkind = 'S' AND relnamespace IN
        (SELECT oid FROM pg_namespace
        WHERE nspname NOT LIKE 'pg_%' AND nspname != 'information_schema')",

So, rtrim(relname, '_seq') in place of relname only.
I'm not sure rtrim is the best solution but you got what I meant.

Voilà my 2 cents.

Hope it will help

Best regards,

Raphaël Dehousse

[DC-563] Import/Pgsql: listTableRelations: bad use of strpos search composite foreign keys (patch provided)

Mon, 15 Mar 2010 14:36:59 +0000

Dears,

First, I would like to thank you for your great work.

Second, the bug:

Line ~279 in the function listTableRelations, there is a mistake in the use of strpos : strpos(',', $values[1]) and strpos(',', $values[3]), it should be strpos($values[1], ',') and strpos($values[2], ',')

With this code, strpos always returns false and so, the composite foreign keys are not skipped as desired.

Continue your great job

Regards,

Raphaël Dehousse

[DC-561] Doctrine autoloader tries to load class again and fails with fatal error - with fix

Mon, 15 Mar 2010 15:14:08 +0000

Doctrine_Core::autoload around line 1107
if (strpos($className, 'sfYaml') === 0 || class_exists($className, false)) {

should be changed to

if (strpos($className, 'sfYaml') === 0) {

otherwise you get:
Warning: require(/srv/www/pacs.lan/site/lib/Doctrine/Parser/sfYaml/Doctrine_Query_From.php) [function.require]: failed to open stream: No such file or directory in /srv/www/pacs.lan/site/lib/Doctrine/Core.php on line 1108

Fatal error: require() [function.require]: Failed opening required '/srv/www/pacs.lan/site/lib/Doctrine/Parser/sfYaml/Doctrine_Query_From.php' (include_path='/srv/www/pacs.lan/site/lib/:/srv/www/pacs.lan/site/lib/Dwoo/:.:/usr/local/lib/php') in /srv/www/pacs.lan/site/lib/Doctrine/Core.php on line 1108

[DC-559] Doctrine_Core::loadModels() caching

Mon, 15 Mar 2010 15:15:43 +0000

Add ability to cache result of Doctrine_Core::loadModels().
My "models" folder contains more than 20 record classes plus more than 20 base classes. I added result caching for conservative model loading and it's reduced application bootstrap time more than 100ms.
Here code that I added to Doctrine_Core::loadModels()
Cache hit check at the beginning of the method

                $models = zend_shm_cache_fetch('doctrine::models_conservative');
                $modelPatch = zend_shm_cache_fetch('doctrine::models_conservative_paths');
                if(false !== $models && false !== $modelPatch){
                    self::$_loadedModelFiles = $modelPatch;
                    return $models;
                }

Result caching before return data

           asort($loadedModels);
            zend_shm_cache_store('doctrine::models_conservative',$loadedModels);
            zend_shm_cache_store('doctrine::models_conservative_paths',self::$_loadedModelFiles);
            return $loadedModels;

Of course zend_shm_cache_* is not proposed as caching solution.
I didn't use agressive model loading, but I think that caching for aggresive modlel loading can be done with compilation of all models to one file

[DC-557] Primary Key Error

Mon, 15 Mar 2010 15:17:28 +0000

All keys are being set as primary key, wich is useless once we have a serial.

Fix: Doctrine/I18n.php
#098: $defaultOptions = array(
#099: 'fixed' => true,
#100: 'primary' => false
#101: )

[DC-556] Index name error

Mon, 15 Mar 2010 15:29:45 +0000

At this moment, if you have more than one table that is sluggable, it get an error cause tries to set the very same name to ALL sluggable indexes. Here is a fix:

#55: 'indexName' => null

#74: if($this->_options['indexName'] === null)
#75: $this->_options['indexName'] = $this->getTable()- >getTableName().'_sluggable';

[DC-555] infinite recursion happens when saving models with circular reference

Mon, 15 Mar 2010 16:09:54 +0000

After upgrading symfony from 1.2 to 1.4, my website began to have problems saving some models. After some research, I found that it was caused by infinite recursion. Let's say Model A has many B (B belongs to A). Each A also points to one of the B objects it owns. So it's a circular reference. Some ppl might argue that it's not a good pratice to have circular reference in the data model, I agree. But it worked fine in Doctrine 1.0, so I prefer not to change it. In Doctrine 1.2.1, it seems that when A and its related B are both modified (dirty), if I try to save A, Doctrine will try to save B due to cascade update, and when saving B, it will again try to save its related A ...

I compared the source code of Doctrine_Connection_UnitOfWork between 1.0 and 1.2.1, and found out that in Doctrine 1.2.1, the model is no longer locked when saveRelatedLocalKeys is invoked. I don't understand this change. After I changed the line "$this->saveRelatedLocalKeys($record);" to

$record->state($record->exists() ? Doctrine_Record::STATE_LOCKED : Doctrine_Record::STATE_TLOCKED);
$this->saveRelatedLocalKeys($record);
$record->state($state);

my website returned to normal again. And so far i haven't found any problem caused by my change

So I hope someone can look into this and let me know if my change is safe. Or if I'm wrong, is there any way I can get around the infinite recursion problem without changing my database schema? Thanks.

[DC-550] Cannot update record from one large integer to another large integer (severe problem for 32bit systems, due to the low upper limit of the int data type)

Mon, 15 Mar 2010 14:14:20 +0000

From what I understand, doctrine mostly stores integers as strings. To check whether an integer has been modified, the following code in Doctrine_Record is used:

    protected function _isValueModified($type, $old, $new)
    {
        if ($new instanceof Doctrine_Expression) {
            return true;
        }

        if ($type == 'boolean' && (is_bool($old) || is_numeric($old)) && (is_bool($new) || is_numeric($new)) && $old == $new) {
            return false;
        } else if (in_array($type, array('decimal', 'float')) && is_numeric($old) && is_numeric($new)) {
            return $old * 100 != $new * 100;
        } else if (in_array($type, array('integer', 'int')) && is_numeric($old) && is_numeric($new)) {
            return (int) $old !== (int) $new;  # <--- ********** THIS LINE CASTS STRING TO INT **********
        } else if ($type == 'timestamp' || $type == 'date') {
            return strtotime($old) !== strtotime($new);
        } else {
            return $old !== $new;
        }
    }

On the line indicated above an integer, stored as a string, is cast to a PHP integer data type, and compared with the existing value of the field currently stored in the database. For values that fall within the int type range, this works fine. However, when changing a value falling above the range, which on 32bit systems is 2147483647, to another value falling above the range, these casts cause the code to evaluate both as 2147483647 and hence the field is not added to the _IsModified() array, and the value is not updated.

Bearing in mind that validation to confirm whether these strings are in numeric format should already have occurred by this point in the process, is there any need to cast the strings at all? Thus, is the following a possible solution?

            return $old !== $new;

This seems to work fine for me in my limited trials although, admittedly, there may be some consequences about which I am not aware.

Note that this issue is not so evident on 64bit systems, where the upper limit is much higher.

[DC-549] Doctrine_DataDict_Oracle TYPO

Mon, 15 Mar 2010 16:18:09 +0000

grep -rn 'lenght' Doctrine/*
Doctrine/DataDict/Oracle.php:197: $lenght = 3;

MEDIUMINT error

} elseif ( ! is_null($length) && (int)$length <= 3) { // TINYINT
    $length = 1;
} elseif ( ! is_null($length) && (int)$length <= 5) { // SMALLINT
    $length = 2;
} elseif ( ! is_null($length) && (int)$length <= 8) { // MEDIUMINT
    $lenght = 3;
} elseif ( ! is_null($length) && (int)$length <= 10) { // INT
    $length = 4;
} elseif ( ! is_null($length) && (int)$length <= 20) { //BIGINT
    $length = 8;
}

[DC-546] [PATCH] Missing $this->_table in Doctrine_Search when Index table not generated on the fly, throws Doctrine_Search_Exception' with message 'Invalid argument type. Expected instance of Doctrine_Table

Thu, 11 Mar 2010 10:48:14 +0000

See http://trac.doctrine-project.org/ticket/896.
Its closed as invalid, but 1.2.1 (stable) throws 'Doctrine_Search_Exception' with message 'Invalid argument type. Expected instance of Doctrine_Table.' if the searchable behavior's index table is not generated on-the-fly, because Doctrine_Search::buildTable() never gets invoked.

It's possible to workaround it by deleting generated classes.

Patch attached.

[DC-545] MSSQL Server: Inserting blank records throws exception / Invalid casting of bound query parameters in sub-selects.

Mon, 15 Mar 2010 10:46:14 +0000

I've two issues with saving records with SQL Server.

Firstly, SQL Server does not allow NULL or DEFAULT values to be used against identity columns. When inserting a record without any modified fields, Doctrine_Record_UnitOfWork::processSingleInsert sets all fields to NULL - including the identity columns. This causes this error:

"SQLSTATE[42000]: Syntax error or access violation: 339 [Microsoft][SQL Server Native Client 10.0][SQL Server]DEFAULT or NULL are not allowed as explicit identity values"

Ideally identity columns could be excluded but that would break tables that consist of those columns. Instead I've patched Doctrine_Connnection_MSSQL to, in this 'blank insert' circumstance only, insert default values and then update the inserted row with null values as necessary (the latter may be unnecessary but I wanted to preserve the original behaviour).

Secondly, there exists a bug in (as I understand it) Microsoft's ODBC driver [1], that causes all bound parameters within a sub-select to be cast as strings before being interpreted by SQL Server. This results in the following error:

SQLSTATE[22018]: Invalid character value for cast specification: 206

[1] http://bugs.php.net/36561

When using SQL Server through ODBC all Doctrine queries that use sub-selects are failing, for example the query generated by a Doctrine_Table->find()

SELECT * FROM (SELECT TOP 1 * FROM (SELECT TOP 1 [m].[id] AS [m__id], [m].[name] AS [m__name] FROM [model] [m] WHERE ([m].[id] = ?)) AS [inner_tbl]) AS [outer_tbl]

To combat this I've extended the Doctrine_Connection_Common execute() method in Doctrine_Connection_Mssql to replace bound parameters so they're inline instead. This has its drawbacks, like reduced protection against SQL injection, but since the alternative is the majority of my queries failing I don't see a better option.

I realise this second issue isn't a Doctrine concern per se, but I thought I'd bring it up since I imagine anyone using SQL server will be experiencing it.

A patch against 1.2.1 is attached. This patch also incorporates the latest patch in http://www.doctrine-project.org/jira/browse/DC-289, which has now been committed to trunk; my additions are at the bottom of the file.

[DC-543] Doctrine_Inflector::unaccent does not replace the norwegian characters æøå

Tue, 16 Mar 2010 13:55:07 +0000

Doctrine_Inflector::unaccent does not know about the norwegian accent characters æøåÆØÅ so when sluggable is making slugs it ends up splitting words

"Møte" is turned into 'm-te' instead of 'mote' which is more apropriate

[DC-537] Timestamp Validator splits on wrong character (from Trac #2018)

Thu, 24 Jun 2010 10:06:18 +0000

To validate data of type 'timestamp', the validator splits the Date/Time using a space, where as, the format created by date('c') specifies a 'T' to split the Date/Time. It seems the simple fix should be to change the space on line 47 of Doctrine/Validator/Timestamp.php to a 'T'

Date generated from gmdate('c') - 2010-03-02T22:08:56+00:00

[DC-529] HYDRATE_SINGLE_SCALAR returns false for fetchOne() correct value for execute()

Mon, 1 Mar 2010 16:34:42 +0000

This simple query:

$vRetVal = Doctrine_Query::create()
->select('id')
->from('LocationCombined')
->where('name = ?', $pRegionName)
->fetchOne(array(), Doctrine_Core::HYDRATE_SINGLE_SCALAR);

returns "false", but if I use
->execute(array(), Doctrine_Core::HYDRATE_SINGLE_SCALAR);

I get the correct result in my variable.

[DC-524] Out Of Range in Template Geographical Calculation using Postgresql

Mon, 1 Mar 2010 16:15:31 +0000

500 | Internal Server Error | Doctrine_Connection_Pgsql_Exception
SQLSTATE[22003]: Numeric value out of range: 7 ERROR: input is out of range

DQL:

at Doctrine_Connection->execute('SELECT h.id AS h_id, h.name AS hname, h.address AS haddress, h.zip AS hzip, h.url AS hurl, h.photo_url AS hphoto_url, h.checkin_from AS hcheckin_from, h.checkin_to AS hcheckin_to, h.checkout_from AS hcheckout_from, h.checkout_to AS hcheckout_to, h.is_published AS his_published, h.class AS hclass, h.currencycode AS hcurrencycode, h.minrate AS hminrate, h.maxrate AS hmaxrate, h.preferred AS hpreferred, h.nr_rooms AS hnr_rooms, h.bookable_direct AS hbookable_direct, h.ranking AS hranking, h.city_id AS hcity_id, h.policygroup_id AS hpolicygroup_id, h.is_closed AS his_closed, h.hoteltype_id AS hhoteltype_id, h.class_is_estimated AS hclass_is_estimated, h.review_nr AS hreview_nr, h.review_score AS hreview_score, h.created_at AS hcreated_at, h.updated_at AS hupdated_at, h.latitude AS hlatitude, h.longitude AS hlongitude, ((ACOS(SIN(45.41244780000000000000 * PI() / 180) * SIN(h.latitude * PI() / 180) + COS(45.41244780000000000000 * PI() / 180) * COS(h.latitude * PI() / 180) * COS((6.63685100000000000000 - h.longitude) * PI() / 180)) * 180 / PI()) * 60 * 1.1515) AS h0, ((ACOS(SIN(45.41244780000000000000 * PI() / 180) * SIN(h.latitude * PI() / 180) + COS(45.41244780000000000000 * PI() / 180) * COS(h.latitude * PI() / 180) * COS((6.63685100000000000000 - h.longitude) * PI() / 180)) * 180 / PI()) * 60 * 1.1515 * 1.609344) AS h1 FROM hotel h WHERE (((ACOS(SIN(45.41244780000000000000 * PI() / 180) * SIN(h.latitude * PI() / 180) + COS(45.41244780000000000000 * PI() / 180) * COS(h.latitude * PI() / 180) * COS((6.63685100000000000000 - h.longitude) * PI() / 180)) * 180 / PI()) * 60 * 1.1515 * 1.609344) < 3 AND h.is_published = ? AND h.id != ?) ORDER BY h_1 asc LIMIT 5', array('true', 189646))

in SF_SYMFONY_LIB_DIR/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Query/Abstract.php line 976

I'm using NUMERIC on column type with precision 10, but the problem is not in the column latitude and longitude, it´s on calculation.
To resolve this bug I made a casting inside of ACOS function calculation, but I don't know how it work on mysql.

- - I've posted a patch file attached here with the change that I made.

Examples of result of h_0, h_1 on sql fixed.

0.132901717706014221300; 0.213884392376139928479590400
0.15938002241913817800; 0.256497124695862251207283200
0.205676327970298764600; 0.331003964361032495016422400
0.205676327970298764600; 0.331003964361032495016422400

[DC-522] Can not use charset and collate in a table basis when using global charset and collate in Doctrine_Manager

Mon, 15 Mar 2010 14:18:56 +0000

Can not use charset and collate in a table basis when using global charset and collate in Doctrine_Manager.

When using + symfony:

ProjectConfiguration.class.php

public function configureDoctrine(Doctrine_Manager $manager)
  {
    $manager->setCharset('utf8');
    $manager->setCollate('utf8_bin');
  }

And some schema like,

schema-page.yml


PageIndex:
  tableName:                           t_page_index
  columns:
    id:                                { type: integer  , length: 20 , primary: true    , autoincrement: true                                                  }
    title:                             { type: string   , length: 200                   , notnull: true                                                        }
  options:
    collate:                           utf8_general_ci

When generating the database, the table will have as collate utf8_bin, not being possible overwriting it at a table level.

This is because:

Table.class.php

public function __construct($name, Doctrine_Connection $conn, $initDefinition = false)
    {
        $this->_conn = $conn;
        $this->_options['name'] = $name;
        
        $this->setParent($this->_conn);           
        $this->_conn->addTable($this);
        
        $this->_parser = new Doctrine_Relation_Parser($this);
        
        if ($initDefinition) {
            $this->record = $this->initDefinition();

            $this->initIdentifier();

            $this->record->setUp();

            // if tree, set up tree
            if ($this->isTree()) {
                $this->getTree()->setUp();
            }
        } else {
            if ( ! isset($this->_options['tableName'])) {
                $this->setTableName(Doctrine_Inflector::tableize($this->_options['name']));
            }
        }
        
        $this->_filters[]  = new Doctrine_Record_Filter_Standard();
        $this->_repository = new Doctrine_Table_Repository($this);

        if ($charset = $this->getAttribute(Doctrine_Core::ATTR_DEFAULT_TABLE_CHARSET)) {
            $this->_options['charset'] = $charset;
        }
        if ($collate = $this->getAttribute(Doctrine_Core::ATTR_DEFAULT_TABLE_COLLATE)) {
            $this->_options['collate'] = $collate;
        }

        $this->construct();
    }

Here the charset and the collate are overwritten (in the last lines of the method) by the global values.

A fix could be something like:

Table.class.php

public function __construct($name, Doctrine_Connection $conn, $initDefinition = false)
    {
        $this->_conn = $conn;
        $this->_options['name'] = $name;
        
        $this->setParent($this->_conn);           
        $this->_conn->addTable($this);
        
        $this->_parser = new Doctrine_Relation_Parser($this);
        

        if ($charset = $this->getAttribute(Doctrine_Core::ATTR_DEFAULT_TABLE_CHARSET)) {
            $this->_options['charset'] = $charset;
        }
        if ($collate = $this->getAttribute(Doctrine_Core::ATTR_DEFAULT_TABLE_COLLATE)) {
            $this->_options['collate'] = $collate;
        }

        if ($initDefinition) {
            $this->record = $this->initDefinition();

            $this->initIdentifier();

            $this->record->setUp();

            // if tree, set up tree
            if ($this->isTree()) {
                $this->getTree()->setUp();
            }
        } else {
            if ( ! isset($this->_options['tableName'])) {
                $this->setTableName(Doctrine_Inflector::tableize($this->_options['name']));
            }
        }
        
        $this->_filters[]  = new Doctrine_Record_Filter_Standard();
        $this->_repository = new Doctrine_Table_Repository($this);

        

        $this->construct();
    }

Now the initDefinition method is called after the setup of the global charset and collate. Then if found a collate option in the table then that collate will be used.

[DC-521] Empty records cannot be inserted on PostgreSQL with autoincrement identifiers

Thu, 17 Jun 2010 05:57:33 +0000

If a record does not have any values set, but its identifier is defined as autoincrement, the record cannot be inserted into PostgreSQL.

In Doctrine_Connection_UnitOfWork::processSingleInsert():

 
       $fields = $record->getPrepared();
        $table = $record->getTable();

       // Populate fields with a blank array so that a blank records can be inserted
        if (empty($fields)) {
            foreach ($table->getFieldNames() as $field) {
                $fields[$field] = null;
            }
        }

This code snippet will add null values to all fields, including to the autoincrement identifier.
Then later in Doctrine_Connection_Pgsql::insert():

       // fix #1786 and #2327 (default values when table is just 'id' as PK)
        if(count($fields) === 1 && $table->isIdentifier(key($fields)) && $table->isIdentifierAutoincrement() )
        {
            return $this->exec('INSERT INTO ' . $this->quoteIdentifier($tableName)
                              . ' '
                              . ' VALUES (DEFAULT)');
        }

        foreach ($fields as $fieldName => $value) {
            $cols[] = $this->quoteIdentifier($table->getColumnName($fieldName));
            if ($value instanceof Doctrine_Expression) {
                $a[] = $value->getSql();
                unset($fields[$fieldName]);
            } else {
                $a[] = '?';
            }
        }

The claimed fix for the referenced tickets does not work correctly for 2 reasons:
1. It only works for tables with a single id field
2. It only works correctly if the id field had no value assigned. If there was a value assigned, it silently bypasses it, and inserts with the autoincremented value.

Patch with test case will be attached to the ticket.

References:
http://trac.doctrine-project.org/ticket/2327
http://trac.doctrine-project.org/ticket/1786

[DC-518] Generated *Table.class.php should contain a getInstance() method

Mon, 15 Mar 2010 17:07:54 +0000

I'm using the symfony framework but assume that the following only affects the classes that were auto generated by Doctrine.

When doctrine generates the model classes for e.g. the sql table "manage_users" it generates:

 
  lib/model/doctrine/ManageUsers.class.php                           <- extends Doctrine_Table
  lib/model/doctrine/ManageUsersTable.class.php                 <- extends BaseManageUsers
  lib/model/doctrine/base/BaseManageUsers.class.php       <- extends sfDoctrineRecord

As far as I understand the ManageUsersTable class is supposed to be autoloaded by Doctrine (cf. ATTR_AUTOLOAD_TABLE_CLASSES) and injected into
the class returned by Doctrine::getTable('ManageUsers').

The first problem is that it is hard to figure out for newbies how to access methods in this class because they try all means to instanciate it or looking for static methods but eventually fail

The second problem is that using it this way, the IDE auto completion feature has no chance to figure out that the returned object offers methods defined in ManageUsersTable.class.php, it can only know that the results is an instance of Doctrine_Table.

The third problem is that one has to repeatingly write Doctrine::getTable("ManageUser") in the source code which is quite error prone - or did you notice that I missed an "s" in the example just given The IDE has again no chance to spot this.

A simple solution to all problems would be an auto generated getInstance method like this:

 
 class ManageUsersTable extends Doctrine_Table {
    /** Returns an instance of this class.
     *
     * @return ManageUsersTable
     */
    public static function getInstance() {
        return Doctrine::getTable('ManageUsers');
    }
 }

This way one could write ManageUs<AUTOCOMPLETION>::getInstance()->get<AUTOCOMPLETION>(); and there would be far less typo bugs!

bye,

~~christian~~

[DC-517] [PATCH] copy() method ignores INDEXBY associations

Mon, 1 Mar 2010 16:45:32 +0000

relations are copied by [] instead of [$key], which will remove any INDEXBY assocations. See attached patch.

[DC-513] Complex HAVING clause generates incorrect SQL in Doctrine_Query::getCountSqlQuery() and Doctrine_Query::getLimitSubquery() [patch included]

Thu, 11 Mar 2010 10:37:37 +0000

I created a DQL query with a complex having clause, such as:

Doctrine_Query::create()
->from('Record r')
->addSelect('r.*')
->addSelect('((ACOS(SIN( ... AS miles') // Determines miles from lat/longs
->having('(r.location IS NULL) OR (miles <= r.location)');

The query works fine when executed by itself. However, when passed to Doctrine_Query::getCountSqlQuery(), it strips the r.location from the select fields, however this field remains in the having clause, and SQL errors out saying that it can't find the field. Then, when it is passed to Doctrine_Query::buildSqlQuery(true) by Doctrine_Pager->execute() (true designates to use getLimitSubquery()), getLimitSubquery() does the same thing and doesn't include these fields in the subquery.

I built a patch that I am using for my application to get around this. What it does is it searches for anything matching `[a-z0-9_]`.`[a-z0-9_]` in getCountSqlQuery() and getLimitSubquery() in the HAVING clause (for instance, would match `r`.`location`) and adds the field to the select query. This is a patch for Doctrine-1.2.1, and I haven't tested it extensively, so I'm not sure if it breaks anything, however in the quick testing I have done it seems to be working OK.

I greatly appreciate all the work the Doctrine team has done for this amazing ORM - keep up the good work! If I can be of any other assistance, please let me know.

[DC-512] Wrong sorting of migration files

Tue, 2 Mar 2010 11:57:03 +0000

If I name migration files just as 1.php, 2.php, ..., 10.php, then sorting goes wrong and they will be read in this order: 1.php, 10.php, 2.php, ....

I fixed it just by replacing

ksort($classesToLoad);

with

ksort($classesToLoad, SORT_NUMERIC);

[DC-511] Inflector::classify is slow

Mon, 1 Mar 2010 16:49:30 +0000

The Doctrine_Inflector::classify is used a lot while doing batch script. The implementation is based on preg_replace_callback method which is slow. By adding a small cache layer this can speed up Doctrine

[DC-510] setColumnOption(s) doesn't update _identifier when setting column as primary (symfony 1.4.2)

Tue, 2 Mar 2010 13:46:32 +0000

class PlgSlide extends BasePlgSlide
{
public function setTableDefinition()

{ parent::setTableDefinition(); $this->setColumnOptions('domain_id', array('primary' => true)); }

...
doesn't work, domain_id field is not added as part of identifier for PlgSlide table records

class PlgSlide extends BasePlgSlide
{
public function setTableDefinition()

{ parent::setTableDefinition(); $this->hasColumn('domain_id', 'integer', 4, array( .... other field option options here 'primary' => true )); }

do work as expected.

I've made some investigation and found code fragment at Table.php, in function setColumn, line 1373:
if (isset($options['primary']) && $options['primary']) {
...
$this->_identifier = (array) $this->_identifier;

but no such functionality for setColumnOption function, Table.php, line 1235

[DC-508] All but the first migrations fail with PostgreSQL [patch included]

Mon, 15 Mar 2010 12:12:04 +0000

The problem is in this method:

protected function _createMigrationTable()
{
    if ($this->_migrationTableCreated) {
        return true;
    }

    $this->_migrationTableCreated = true;

    try {
        $this->_connection->export->createTable($this->_migrationTableName, array('version' => array('type' => 'integer', 'size' => 11)));

        return true;
    } catch(Exception $e) {
        return false;
    }
}

When migration_version table doesn't exist, everything works like it should. But subsequent migrations fail, because after failing at creating migration_version table every subsequent queries in that transaction fail.

It works flawlessly with MySQL, but fails with PostgreSQL.

[DC-506] Doctrine_Adapter_Statement_Oracle missing fetch statement in fetchAll()

Tue, 2 Mar 2010 13:57:32 +0000

It looks like the developer changed their mind on how to set the flags halfway through coding, as the $flags variable is not used. Critically, if the default FETCH_BOTH is specified, then no fetch is performed. I also did some testing with the OCI_BOTH constant, and could not get it to return the desired results (only enumerated results were returned). I also tried replacing OCI_BOTH with OCI_NUM + OCI_ASSOC with the same results.

I guess this should either throw an exception (not supported) or be fixed to return the appropriate results.

Line 361 in v1.2

        $flags = OCI_FETCHSTATEMENT_BY_ROW + OCI_ASSOC;

        $int = $fetchStyle & Doctrine::FETCH_COLUMN;

        if ($fetchStyle == Doctrine::FETCH_BOTH) {
            $flags = OCI_BOTH;
            $numberOfRows = @oci_fetch_all($this->statement, $data, $skip, $maxrows, OCI_FETCHSTATEMENT_BY_ROW + OCI_ASSOC + OCI_RETURN_LOBS);
        } else if ($fetchStyle == Doctrine::FETCH_ASSOC) {

[DC-505] Doctrine_Cache_Db can be much faster

Mon, 15 Mar 2010 17:22:58 +0000

Each Doctrine_Cache_Db->_doFetch() invocation costs about 50 ms on my PC(depending on the data of course). By using built-in pack() function performance can be increased 700x times. Each invocation now costs about 0.07 ms. The change is very considerable for pages with multiple queries.

[DC-504] toArray not using lazy loading

Wed, 10 Mar 2010 18:53:01 +0000

When selecting specific fields in a doctrine query, and calling toArray, the resulting arrays ignore the selected fields and load all values from the database record.

$phones = Doctrine_Query::create()
        ->select('ph.phone_type')
        ->from('Phone ph')
        ->orderBy('ph.phone_type')
        ->limit(2)
        ->execute()
        ->toArray();

The above query when dumped returns...

Array
(
    [0] => Array
        (
            [id] => 1
            [status] => 
            [phone_type] => business
            [number] => 8003041538
            [current_status_id] => 1
            [created_at] => 2010-01-08 15:08:34
            [updated_at] => 2010-01-08 15:08:34
        )

    [1] => Array
        (
            [id] => 2
            [status] => 
            [phone_type] => business
            [number] => 2052052055
            [current_status_id] => 1
            [created_at] => 2010-02-14 13:07:12
            [updated_at] => 2010-02-14 13:07:12
        )

)

[DC-503] Migrations task generates wrong diff for long table names

Mon, 15 Mar 2010 12:10:01 +0000

With the attached schema, a migrations diff is generated after an initial setup of the project, although
there are no differences at all. The two models are exactly identical, the only difference is the
lenght of their table names. A diff is detected for model "Institute", but not for the one called "Institut".

The reason is in the generation of the foreign keys (Doctrine_Connection line 1624), which
generates an abbreviated foreign key name for names longer than 64 characters. This
is true in the "to" models of the migration, but not in the "from" models.

[DC-500] Duplicate Index for foreign key(MySQL)

Tue, 2 Mar 2010 12:03:42 +0000

If an index with the same as the foreign key field exists and is not an array, and it is not the last in the list, adds it twice

SUGGESTION SOLUTION:

Doctrine/Export/Mysql.php (136): $found = $found || ($local == $definition['fields']);

[DC-495] Allow the end of line style to be set in the record builder

Mon, 29 Mar 2010 14:02:32 +0000

When building base models on multiple boxes with different operating systems, the use of PHP_EOL in the model builder is problematic since when you rebuild you basically change every line of every file, leading to huge commits that are impossible to review.

I therefore added an eolStyle option to the Doctrine_Import_Builder class that allows you to specify which EOL markers to use.

It works perfectly fine here and the patch is attached, if the option is not specified the code remains the same as before btw so no performance loss or any possible BC break.

Thanks

[DC-493] method bracketExplode when tablename contains "Join"

Mon, 15 Mar 2010 17:31:44 +0000

Hello,
I'm using Symfony 1.4.1 with Doctrine (I imagine that the doctrine's version is 1.2.1), and I have a strange behavior because my table name is "piece_jointe", so it contains "JOIN" keyword inside.
In Doctrine_Query_Tokenizer class, the method bracketExplode explode string with a regular expression "#(JOIN)#i", so the table name is exploded and nothing works after that.

do you think it's possible to write a better regular expression to avoid this behavior ? Maybe add spaces after JOIN : "#(JOIN )#i but if there is a line break... or "#(JOIN[\s \n])#i"
For now, I'll rename the table !

Thanks a lot,
best regards
Etienne

[DC-492] Nested set behavior not correctly working (Doctrine_Node_NestedSet::shiftRlValues) (Updated)

Mon, 15 Mar 2010 12:22:42 +0000

When using the code:

main.php

    $parent = new Category();
    $parent->setName('Parent');
    $parent->save();
    Doctrine_Core::getTable('Category')->getTree()->createRoot($parent);
    
    $child = new Category();
    $child->setName('Child');
    $child->save();
    
    $child->getNode()->insertAsLastChildOf($parent);

Now it throws an exception with the message:

"Unknown component alias Category" from the Doctrine_Query_Abstract class, line 743.

Tracking down the problem, it seems that in the method shiftRlValues there was a problem:

NestedSet.php

    // shift left columns
        $componentName = $this->_tree->getBaseComponent();

        $qLeft  = Doctrine_Core::getTable($componentName)
            ->createQuery()
            ->update();

        $qRight = Doctrine_Core::getTable($componentName)
            ->createQuery()
            ->update();

        $qLeft = $qLeft->set($componentName . '.lft', $componentName.'.lft + ?', $delta)
                       ->where($componentName . '.lft >= ?', $first);
        $qLeft = $this->_tree->returnQueryWithRootId($qLeft, $rootId);

        $resultLeft = $qLeft->execute();
        
        // shift right columns
        $qRight = $qRight->set($componentName . '.rgt', $componentName.'.rgt + ?', $delta)
                         ->where($componentName . '.rgt >= ?', $first);

        $qRight = $this->_tree->returnQueryWithRootId($qRight, $rootId);

        $resultRight = $qRight->execute();

Making a comparison with the NestedSet class in the 1.0 series, realized that the update methods need the component name resulting in:

NestedSet.php

    // shift left columns
        $componentName = $this->_tree->getBaseComponent();

        $qLeft  = Doctrine_Core::getTable($componentName)
            ->createQuery()
            ->update(<b>$componentName</b>);

        $qRight = Doctrine_Core::getTable($componentName)
            ->createQuery()
            ->update(<b>$componentName</b>);

        $qLeft = $qLeft->set($componentName . '.lft', $componentName.'.lft + ?', $delta)
                       ->where($componentName . '.lft >= ?', $first);
        $qLeft = $this->_tree->returnQueryWithRootId($qLeft, $rootId);

        $resultLeft = $qLeft->execute();
        
        // shift right columns
        $qRight = $qRight->set($componentName . '.rgt', $componentName.'.rgt + ?', $delta)
                         ->where($componentName . '.rgt >= ?', $first);

        $qRight = $this->_tree->returnQueryWithRootId($qRight, $rootId);

        $resultRight = $qRight->execute();

Now the queries work correctly!.

.............

I seems the cause of the problem was the fact of overwriting createQuery method from Doctrine_Table

kcDoctrineTable.class.php

  public function createQuery($alias = '')
  {
    $alias = empty($alias) ? $this->getAlias() : trim($alias);
    $alias = ' '.$alias;
    
    $class = $this->getAttribute(Doctrine_Core::ATTR_QUERY_CLASS);

    return Doctrine_Query::create(null, $class)->from($this->getComponentName().$alias);
  }
  public function getAlias()
  {
    $name  = substr(get_class($this), 0, -5);
    $name  = sfInflector::underscore($name);
    $names = explode('_', $name);
    array_walk($names, create_function('&$v, $k', '$v = $v{0};'));
    $alias = implode('', $names);
    
    return $alias;
  }

I was trying to give and alias always by default:

Category -> c
CategoryAttribute -> ca
CategoryAttributeExtension -> cae

This breaks shiftRlValues method from NestedSet because there, it is used the component name as alias, and when createQuery creates a "from" part with a different alias the whole query crush.

It would be nice to have this feature in a future release.

[DC-488] Cannot parse table name including 'join'

Mon, 15 Mar 2010 17:35:30 +0000

Cannot parse table name including 'join'.

$q = new Doctrine_Query();
$q->from('MyJoinProblem');

In above code, I want to query like 'SELECT m.id AS m__id FROM MyJoinProplem m'.
But, Doctrine try to find 'My' table and 'Problem' table.
Table name is 'MyJoinProblem'.

[DC-487] Worng docs: @return docs of some methods in Doctrine_Query_Abstract class are worng.

Mon, 15 Mar 2010 17:39:15 +0000

@return docs of getSqlQueryPart should be mixed.
@return docs of setSqlQueryPart, addSqlQueryPart, removeSqlQueryPart, removeDqlQueryPart, copySubqueryInfo, useResultCache, useQueryCache, expireResultCache, expireQueryCache, setResultCacheLifeSpan and setQueryCacheLifeSpan should be Doctrine_Query.

This issue is also reported in the user ml. http://groups.google.com/group/doctrine-user/browse_thread/thread/ee5d40f03242af8b

[DC-483] Indentifiers are not quoted in queries build for Nested Relations (patch included)

Mon, 1 Mar 2010 15:40:12 +0000

It was OK using reserved words as column names before I started using Nested Relations: queries started to fail because Doctrine_Core::ATTR_QUOTE_IDENTIFIER is ignored by query builder for Nested Relations.

I solved this problem by wrapping identifiers with Doctrine_Formatter::quoteIdentifier() in several places. I'm providing a patch for your to review and commit.

Thanks.

[DC-482] $data passed to foreach is wrong

Mon, 15 Mar 2010 17:45:10 +0000

Calling a query that doesn't use all tablecols gives php warnings such as:

Errorcode: E_WARNING [php warning] (2)
Message: Invalid argument supplied for foreach()
File: Record.php
Line: 1151

--------------------------------------------------------------
$data = empty($data) ? $this->getTable()->find($id, Doctrine_Core::HYDRATE_ARRAY) : $data;
foreach ($data as $field => $value) {
--------------------------------------------------------------

$data is empty but not an array.

[DC-480] Since 1.2, records can't have columns named "options" anymore

Mon, 1 Mar 2010 16:58:13 +0000

Since Doctrine 1.2, Doctrine_Record_Abstract has a new getOptions() method. This forbids any models to have some columns named "options" (and this breaks compatibility with older versions).

I think this should be mentioned in documentation and release notes. And maybe, an exception should be thrown if a reserved doctrine keyword (options, table...) is defined as column name.

Of course, a better resolution would to not make the word "options" a reserved keyword but I don't know it's really possible in 1.2.x.

[DC-475] generate-migrations-diff is producing bogus migrations (drops the whole database)

Wed, 3 Mar 2010 17:26:26 +0000

Replicating the bug:
1. unzip vanilla sandbox.
2. create schema file with entity
3. run ./doctrine build-all
4. modify schema, add column to entity.
5. run ./doctrine generate-migrations-diff

Expected behaviour:
generates migration wich adds column to entity.

Real behaviour:
Drops entity from database

[DC-472] In the relatedExists method of the Doctrine_Record class the exception is incorrectly thrown imho

Mon, 15 Mar 2010 14:16:38 +0000

When using the result of a:

test.php

$q = Doctrine::createQuery()
        ->from('User u')
        ->leftJoin('Role r');

$users = $q->execute();

now if we want to iterate and know if exists the according role for each user

test.php

foreach ($users as $user)
{
  $role_name = $user->relatedExists('Role') ? $user->getRole()->getName() : '';
}

the exception in the relatedExists method will be thrown:

test.php

public function relatedExists($name)
    {
        $newReference = false;
        if ( ! $this->hasReference($name)) {
            $newReference = true;
        }

        $reference = $this->$name;
        if ( ! $reference instanceof Doctrine_Record) {
            throw new Doctrine_Record_Exception(
                'You can only call relatedExists() on a relationship that '.
                'returns an instance of Doctrine_Record'
            );
        }
        $exists = $reference->exists();

        if ($newReference) {
            $this->clearRelated($name);
        }

        return $exists;
    }

because the according role record does not exist for some users ( a user just could have one record).

it could be better this way:

test.php

public function relatedExists($name)
    {
        $newReference = false;
        if ( ! $this->hasReference($name)) {
            $newReference = true;
        }

        $reference = $this->$name;
        if ( ! $reference && ! $this->getTable()->hasRelation($name)) {
            throw new Doctrine_Record_Exception(
                'You can only call relatedExists() on a relationship that '.
                'returns an instance of Doctrine_Record'
            );
        }

        $exists = $reference ? $reference->exists() : false;

        if ($newReference) {
            $this->clearRelated($name);
        }

        return $exists;
    }

With this change, this method can be used to check newly created user objects or some retrieved from the db (left join with role) smoothly.

[DC-469] getAccessors and getMutators shows notices if they are not set

Mon, 15 Mar 2010 17:48:56 +0000

It's a very minor problem I know that. However when I try to use getAccessors() or getMutators() functions, if nothing is set on the table definitions, it throws some notices on the php (on error_reporting all) that such an index does not exists. As there is no such index to be found it returns null instead of expected array (empty if there is no mutators for that table)

public function getAccessors()
{
$componentName = $this->_table->getComponentName();
if (!isset(self::$_customAccessors[$componentName]))

{ return array(); }

return self::$_customAccessors[$componentName];
}

such a code solves the problem and not notices is thrown and empty array is returned if there is no accessors. Same kind of an improvement is required for getMutators too

I know that this is a minor issue however I wanted to inform you.

[DC-468] Project directories that have underscores (ie my_project) in the name get replaced with slashes (my/project) when generating models

Mon, 15 Mar 2010 17:49:38 +0000

I have a project name that contains an underscore. When I run the doctrine CLI to create the models from the yaml file, something string replaces all underscores with slashes.

So where I would be expecting the models to be generated in 'my_project/application/models', it is instead being generated in 'my/project/application/models'

[DC-460] Doctrine_Cache_Apc/Core changes in 1.2 cause instability and crashes

Reference — Mon, 1 Mar 2010 15:58:12 +0000

Since upgrading to Doctrine 1.2 my application has begun to get increasingly slower as hours elapse. I've pinpointed the cause to the new doctrine_cache_keys feature.

I've found at least three issues with this new method.

First

The key cache does not track enforce unique entries, thus multiple entries can be in the cache. See:

    protected function _saveKey($key)
    {
        $keys = $this->fetch($this->_cacheKeyIndexKey);
        $keys[] = $key;

        return $this->save($this->_cacheKeyIndexKey, $keys, null, false);
    }

    public function _deleteKey($key)
    {
        $keys = $this->fetch($this->_cacheKeyIndexKey);
        $key = array_search($key, $keys);
        if ($key !== false) {
            unset($keys[$key]);

            return $this->save($this->_cacheKeyIndexKey, $keys, null, false);
        }

        return false;
    }

Second

The doctrine_cache_key is being updated on every cache save or delete. With any caching strategy (APC, Memcached, Xcache) cache writes for the same key are (naturally) serialized. This leads to the "timebomb" situation described here: http://t3.dotgnu.info/blog/php/user-cache-timebomb.html

The problem is exarcerbated by the infinitely increasing size of the doctrine_cache_key array noted above. Depending on the caching engine, the lock time increases as well (APC & XCache free the previous entry inside the lock). This causes the application to spiral out of control, even with relatively trivial loads.

Personally, I don't think the "benefit" of having prefix/regex deletes is worth having this. Jon, you suggested having it disabled by default, but even with it enabled, this problem is reintroduced when someone decides to use it.

Third

For most (maybe all?) cache engines the doctrine_cache_key seems entirely unnecessary.

APC
- apc_cache_info('user') returns the list of cache entries
Memcached
- $memcache->getExtendedStats('cachedump', $slabId) can return the list of cache keys
XCache
- According to the API docs xcache_list() behaves similar to apc_cache_info()
DB
- a simple query can get this
Array
- array_keys() ?

Summary

As this is currently broken for production use I intend to immediately fix both the first and second items above by preventing duplicate entries and disabling the doctrine_cache_keys behavior by default.

With more input/discussion I think the long term solution is to use the tools provided by the engines to get a list of keys, rather than maintain a list. I'd be willing to develop this as long as it is approved.

[DC-459] Typo in Doctrine_Validator_Email

Mon, 1 Mar 2010 16:19:57 +0000

Typo in comments for Doctrine_Validator_Email->_checkMx()

Patch attached.

[DC-458] Doctrine_Validator_Ip fails on IPV6 IP addresses.

Mon, 1 Mar 2010 20:11:23 +0000

Doctrine_Validator_Ip->validate() uses ip2long() in order to validate IP addresses.

However, ip2long() only works for IPv4 addresses, and not IPv6 addresses.

Attached is a patch to use filter_var which validates both IPv4 and IPv6 properly.

[DC-446] Doctrine_Record_Generator::createClass with Doctrine_Record_Listener

Tue, 2 Mar 2010 12:21:50 +0000

Doctrine_Record_Generator::initialize first builds the table class and then a "Doctrine_Record" from that. This is surprising, as the result is a "double conversion" from record to table and back.

Furthermore, writing files, no record listeners can be attached (see createClassFromTable)!

I therefore suggest adding the possibility to add listeners - which the builder already does! - to the Record_Generator.

[DC-441] When using PearStyle model loading and a classPrefix, the Doctrine CLI will ignore any SQL operations if model_autoloading is set to conservative

Tue, 16 Mar 2010 15:13:52 +0000

When using PearStyle model loading and a classPrefix, the Doctrine CLI will ignore any SQL operations if model_autoloading is set to conservative . If model_autoloading is set to aggressive, then everything works as expected.

Here's my Doctrine configuration:

doctrine.generate_models_options.pearStyle = true
doctrine.generate_models_options.generateTableClasses = false
doctrine.generate_models_options.generateBaseClasses = true
doctrine.generate_models_options.baseClassPrefix = "Base_"
doctrine.generate_models_options.baseClassesDirectory =
doctrine.generate_models_options.classPrefixFiles = false
doctrine.generate_models_options.classPrefix = "Model_"
; Conservative Model Loading:
doctrine.model_autoloading = 2

and my Doctrine initialization method:
protected function _initDoctrine()

{ $this->getApplication()->getAutoloader() ->pushAutoloader(array('Doctrine', 'autoload')); spl_autoload_register(array('Doctrine', 'modelsAutoload')); $doctrineConfig = $this->getOption('doctrine'); $manager = Doctrine_Manager::getInstance(); $manager->setAttribute(Doctrine::ATTR_AUTO_ACCESSOR_OVERRIDE, true); $manager->setAttribute( Doctrine::ATTR_MODEL_LOADING, $doctrineConfig['model_autoloading'] ); Doctrine::loadModels($doctrineConfig['models_path']); $conn = Doctrine_Manager::connection($doctrineConfig['dsn'],'doctrine'); $conn->setAttribute(Doctrine::ATTR_USE_NATIVE_ENUM, true); return $conn; }

and my doctrine.php CLI file:

require_once 'Zend/Application.php';

// Create application, bootstrap, and run
$application = new Zend_Application(
APPLICATION_ENV,
APPLICATION_PATH . '/configs/application.ini'
);

$application->getBootstrap()->bootstrap('doctrine');

$config = $application->getOption('doctrine');
$cli = new Doctrine_Cli($config);
$cli->run($_SERVER['argv']);

[DC-437] Connection::query() can use wrong connection

Mon, 15 Mar 2010 11:53:16 +0000

As I understand, Doctrine_Connection::query() method is intended to execute DQL queries using precisely this connection.
But here is the code:

894     public function query($query, array $params = array(), $hydrationMode = null)
895     {
896         $parser = Doctrine_Query::create();                                                                                
897         $res = $parser->query($query, $params, $hydrationMode);
898         $parser->free();
899 
900         return $res;
901     }

Doctrine_Query::create() statement will create a query that is using a default connection, not the current one.

[DC-434] setCharset($charset) on mysql/pgsql connections does not set Doctrine_Core::ATTR_DEFAULT_TABLE_CHARSET

Mon, 1 Mar 2010 18:16:04 +0000

When calling setCharset on a connection I expect that getCharset returns the charset which is set before.

That works on sqlite and other Connections, but not on mysql and pgsql.

Doctrine_Connection_Mysql and Doctrine_Connection_Pgsql overwrite setCharset (defined in Doctrine_Configurable) and only execute their SET NAMES query and don't set Doctrine_Core::ATTR_DEFAULT_TABLE_CHARSET which is used by getCharset().

Solution would be to call

parent::setCharset($charset);

in Doctrine_Connection_Mysql::setCharset($charset) and Doctrine_Connection_Pgsql::setCharset($charset).

[DC-428] Bug on DropDB on Oracle. The sequence isn't not correct

Thu, 11 Mar 2010 10:57:30 +0000

The sequence of drop database is not correct.

I change this in my patch.

Thank's

[DC-425] I18n - Can't create lang column as varchar(5)

Tue, 30 Aug 2011 17:54:09 +0000

I need to override the LANG column size on i18n tables, so I can use "pt_BR" language. I'd like the LANG column to be varchar(5) and not char(5) as it happens if I modify the field length to 5.

I've also tried to set the "fixed" option as false, but I noticed that the I18n generator overrides this option (I18n.php - line 98).

The only workaround I could find was setting the length option as null and the type as varchar(5), but at least for me, it doesn't seem to be the most correct way to define it.

I'd suggest modifying the I18n table definition generator to not override this option.

I've attached a patch with the proposed fix.

[DC-419] Sluggable and inheritance

Tue, 6 Sep 2011 08:52:11 +0000

I've the same problem than this post : http://groups.google.com/group/doctrine-user/browse_thread/thread/3737fd293fef5fda/d86a8bc2578e4bac

Then, I've set "uniqueBy: [name, type] ", and my data goes in database BUT they can have the same slug.

So I can't retrieve an objects wich has equal slug with another.

The column aggregation inheritance does'nt take care of others slugs.

[DC-414] Sluggable template fails on case insensitive fields [solution]

Mon, 1 Mar 2010 20:14:29 +0000

Doctrine_Template_Listener_Sluggable performs the following check to see if an existing matching slug exists (line 219):

Sluggable.php

while (in_array($slug, $similarSlugs)) {
  $slug = call_user_func_array($this->_options['builder'], array($proposal.'-'.$i, $record));
  $i++;
}

in_array performs case sensitive string matching, which can cause errors if the sluggable field is case insensitive. This can easily be fixed by calling strtolower when creating the $similarSlugs array and on $slug itself. That is:

Sluggable.php

$similarSlugs = array();
foreach ($similarSlugResult as $key => $value) {
    $similarSlugs[$key] = strtolower($value[$name]);
}

$i = 1;
while (in_array(strtolower($slug), $similarSlugs)) {
    $slug = call_user_func_array($this->_options['builder'], array($proposal.'-'.$i, $record));
    $i++;
}

Even if the sluggable column is BINARY / case sensitive, I think it's an undesired behavior to have multiple slugs with the same case insensitive string.

[DC-413] Validating Spanish Ñ produces "Notice"

Mon, 1 Mar 2010 18:35:47 +0000

Doctrine Version 1.2.1

I am entering a simple string into a text input, and running a validator for non-blank and minimum length.

When I enter a Spanish character such as Ñ (N with squiggle on top), the Validator is producing a notice:

Notice: iconv_strlen() [function.iconv-strlen]: Detected an incomplete multibyte character in input string in D:\wamp\www\doctrine\lib\Doctrine\Validator.php on line 131

One work-around suggested at http://www.php.net/manual/en/function.iconv-strlen.php#62320 is to use
return strlen(utf8_decode($string));
instead - not sure whether that provides the same result, though. I have replaced the line in my own Validator class and it seems to be working fine.

[DC-411] Doctrine::Inflector does not handle table names with dashes

Mon, 1 Mar 2010 20:17:19 +0000

I have some tables in my DB with dashes in name, ex. "table-name".
While generating schema.yml with ./doctrine-cli generate-yaml-db it generated model classes with dashes, ex. class Table-name ...

Here's a small patch to treat - in table names same as _.

— library/Doctrine/Inflector.php (wersja 7016)
+++ library/Doctrine/Inflector.php (kopia robocza)
@@ -57,7 +57,7 @@
public static function classify($word)

{ $word = preg_replace('/[$]/', '', $word); - return preg_replace_callback('~(_?)(_)([\w])~', array("Doctrine_Inflector", "classifyCallback"), ucfirst(strtolower($word))); + return preg_replace_callback('~(_?)([-_])([\w])~', array("Doctrine_Inflector", "classifyCallback"), ucfirst(strtolower($word))); }

/**

[DC-410] Email-validator doesn't work

Tue, 2 Mar 2010 12:29:23 +0000

I'm generating my models from YAML. The email validator is correctly parsed into the model, but it doesn't work. If I try to insert 'a' or something that is not valid, I don't get any error at all and the row is inserted. See attachments for models.

$user = new AppUser();
$user->name = 'Testuser';
$user->password = sha1('lala');
$user->email = 'a';
$user->role = 'ADMIN';
$user->save();

[DC-408] Schema generation on Oracle databases fails due to invalid/unexistant table names

Mon, 1 Mar 2010 18:45:53 +0000

Sometimes the ORACLE engine has object names that are not tables, and the doctrine generator tries to
generate classes for them, the following patch solves the problem.

[Solution found thanks to Vladimir Tamara - vtamara AT pasosdejesus DOT org]

diff -u Doctrine/Import/Oracle.php.orig Doctrine/Import/Oracle.php

--- Doctrine/Import/Oracle.php.orig     2010-01-07 17:08:33.000000000
-0500
+++ Doctrine/Import/Oracle.php  2010-01-07 17:08:54.000000000 -0500
@@ -203,7 +203,7 @@
      */
     public function listTables($database = null)
     {
-        $query = "SELECT * FROM user_objects WHERE object_type =
'TABLE'";
+        $query = "SELECT * FROM user_objects WHERE object_type =
'TABLE' and object_name in (select table_name from user_tables)";
         return $this->conn->fetchColumn($query);
     }

@@ -252,4 +252,4 @@
         $query = 'SELECT view_name FROM sys.user_views';
         return $this->conn->fetchColumn($query);
     }
-}
\ No newline at end of file
+}

[DC-407] Doctrine_Core::HYDRATE_SINGLE_SCALAR improvement

Mon, 15 Mar 2010 11:06:47 +0000

Right now HYDRATE_SINGLE_SCALAR will always return one value, regardless of whether you use execute() or fetchOne(). This limits the usefulness of the hydrator, as it could be expanded to work in situations where you want to hydrate a single column from a result-set. For example think of a scenario where you want to populate a multi option element of a form with IDs from a db model.

Right now if you have this:

$items = Doctrine_Query::create()->select('id')->from('Items')->execute(array(), Doctrine_Core::HYDRATE_SINGLE_SCALAR);

You will end up having just the id of the first item. However I think it should return a flat array of all the ids, like this:

array(1, 3, 4, 5, 8)

Having it work this way would still let you use HYDRATE_SINGLE_SCALAR to hydrate a single value; you would just use fetchOne instead of execute. Changing the implementation won't really have any negative performance impacts either.

I've attached a patch that adds this functionality and updates the unit tests to take it into account.

I realize that this might not be added in 1.2 since it'd break backwards compatibility, but if there's going to be 1.3, this should be in it.

[DC-406] more robust handling for "actAs: [Timstampable]" handling

Tue, 12 Jan 2010 20:44:04 +0000

see: http://trac.symfony-project.org/ticket/8044

This patch ensures that any numeric keys are flipped individually instead of simply peaking into the first element and assuming the rest of the array has the same structure.

[DC-404] Allow custom language field name in I18n Behavior

Mon, 1 Mar 2010 20:04:43 +0000

I18n behavior assumes language field name of 'lang'. It would be nice if this was configurable.

This was mentioned and a proposed solution was given here: http://forum.symfony-project.org/index.php/m/85623/

I've attached a patch which implements this solution, it essentially adds an i18nField option to the behaviour. The field defaults to 'lang'.

The patch was made against r7016 of the 1.2 branch.

Note:

Leaving the field name as 'lang' does not cause unit test failures.
Changing the name of the field does cause some unit tests to fail for me. I'm not sure if the dependency on the field name exists in the unit tests or in the doctrine library itself. If dependencies exist in the library, this patch may not be sufficient to add the feature.

Sorry if the patch is incomplete, I'm new to Doctrine in general.

[DC-398] PORTABILITY_EMPTY_TO_NULL doesn't do anything for statements

Mon, 15 Mar 2010 12:15:55 +0000

I found this ticket on the old Trac system, but not on JIRA. It is still broken in the 1.1 branch, as of revision 7004. It is also broken in 1.0.14, 1.1.6, and 1.2.1. (These were the 'stable' releases at the time I reported this bug.) It is likely broken in older releases as well.

When saving to the database, Doctrine ignores the setting of PORTABILITY_EMPTY_TO_NULL. Currently, it will never change empty strings to NULL, no matter what the setting is for ATRR_PORTABILITY. This is because there is an error in the following 'if' statement:

Doctrine_Connection_Statement starting on line: 234

if ($this->_conn->getAttribute(Doctrine::PORTABILITY_EMPTY_TO_NULL)) {
    foreach ($params as $key => $value) {
        if ($value == '') {
            $params[$key] = null;
        }
    }
}

the first test in this block should be (Portability Mode Attributes must be handled this way):

if ($this->_conn->getAttribute(Doctrine::ATTR_PORTABILITY) & Doctrine::PORTABILITY_EMPTY_TO_NULL) {

the second test should be:

if (is_string($value) && $value === '')

In newer versions of php(not sure which), test for empty string must look like '===' not only '=='. It prevents integer and boolean value 0 to be handled as an empty string.

[DC-397] unlinking of associations with aliased local-/foreignKeys is broken

Tue, 2 Mar 2010 12:31:24 +0000

Doctrine_Connection_UnitOfWork->saveAssociations() does not use column-aliases for database-columns but only field-names. The following patch deals with this problem:

Index: lib/Doctrine/Connection/UnitOfWork.php
===================================================================
— lib/Doctrine/Connection/UnitOfWork.php (revision 7004)
+++ lib/Doctrine/Connection/UnitOfWork.php (working copy)
@@ -439,8 +439,8 @@
$assocTable = $rel->getAssociationTable();
foreach ($v->getDeleteDiff() as $r)

{ $query = 'DELETE FROM ' . $assocTable->getTableName() - . ' WHERE ' . $rel->getForeign() . ' = ?' - . ' AND ' . $rel->getLocal() . ' = ?'; + . ' WHERE ' . $rel->getForeignRefColumnName() . ' = ?' + . ' AND ' . $rel->getLocalRefColumnName() . ' = ?'; $this->conn->execute($query, array($r->getIncremented(), $record->getIncremented())); }

[DC-395] sfYaml library included twice

Tue, 8 Jun 2010 15:11:42 +0000

I don't know if this is important but it seems sfYaml is included twice in Doctrine 1.2.1. Once in vendor/sfYaml and once again in Doctrine/Parser/sfYaml

[DC-394] Searchable behavior's batchUpdateIndex fails if a table has a composite primary key.

Tue, 2 Mar 2010 12:34:28 +0000

You will get the following error when you try to batchUpdateIndex a table with composite key:

Fatal error: Uncaught exception 'ErrorException' with message 'strpos() expects parameter 1 to be string, array given' in library/Doctrine/Connection.php:725

Here's the full stack trace:

Stack trace:
#0 [internal function]: Bootstrap->errorHandler(2, 'strpos() expect...', '/Users/reko/Sit...', 725, Array)
#1 /Users/reko/Sites/MyProject/library/Doctrine/Connection.php(725): strpos(Array, '.')
#2 /Users/reko/Sites/MyProject/library/Doctrine/Search.php(246): Doctrine_Connection->quoteIdentifier(Array)
#3 /Users/reko/Sites/MyProject/library/Doctrine/Template/Searchable.php(69): Doctrine_Search->batchUpdateIndex(NULL, NULL, NULL)
#4 /Users/reko/Sites/MyProject/library/Doctrine/Template/Searchable.php(81): Doctrine_Template_Searchable->batchUpdateIndex(NULL, NULL, NULL)
#5 [internal function]: Doctrine_Template_Searchable->batchUpdateIndexTableProxy()
#6 /Users/reko/Sites/MyProject/library/Doctrine/Record.php(2622): call_user_func_array(Array, Array)
#7 [internal function]: Doctrine_Record->__call('batchUpdateInde...', Array)
#8 [internal function]: In in /Users/reko/Sites/MyProject/library/Doctrine/Connection.php on line 725

I know that it's recommended that you don't use composite primary keys, but this happens to occur when you stack the I18n and Searchable behaviour together, since the Translation table I18n behavior creates uses a composite key on (id, lang).

Anyways, the bug was quite simple one to fix and I've attached a patch that fixes the issue.

[DC-385] Behavior geographical generates latitude FLOAT(18, 2), longitude FLOAT(18, 2) - it's not exact

Thu, 11 Aug 2011 03:47:27 +0000

The problem was already described by another person at http://trac.symfony-project.org/ticket/7763
the generated field-type is wrong, so the stored lat/long values have lost precision.

[DC-384] Nested set API allows inconsistent trees to be created

Mon, 15 Mar 2010 12:04:13 +0000

First create a tree as follows:

A
B
C
D

That is, C and D are both children of B, and B is a child of A.

At this point our db looks as follows:

mysql> select SLUG, LFT, RGT, LEVEL from pk_context_cms_page;
-----------------------+

SLUG

LFT

RGT

LEVEL

-----------------------+

/	1	12	0
/about	10	11	1
global	NULL	NULL	NULL
/a	2	9	1
/a/b	3	8	2
/a/b/c	4	5	3
/a/b/c/d	6	7	3

-----------------------+
7 rows in set (0.00 sec)

Now, call D->moveAsLastChildOf(C). D is now a child of C.

So far so good:

mysql> select SLUG, LFT, RGT, LEVEL from pk_context_cms_page;
-----------------------+

SLUG

LFT

RGT

LEVEL

-----------------------+

/	1	12	0
/about	10	11	1
global	NULL	NULL	NULL
/a	2	9	1
/a/b	3	8	2
/a/b/c	4	7	3
/a/b/c/d	5	6	4

-----------------------+
7 rows in set (0.00 sec)

Now, call C->moveAsLastChildOf(D). This should pull D out from under C.

Instead the values of LFT and RGT get messed up:

mysql> select SLUG, LFT, RGT, LEVEL from pk_context_cms_page
-> ;
-----------------------+

SLUG

LFT

RGT

LEVEL

-----------------------+

/	1	12	0
/about	10	11	1
global	NULL	NULL	NULL
/a	2	9	1
/a/b	3	8	2
/a/b/c	6	7	5
/a/b/c/d	7	6	4

-----------------------+
7 rows in set (0.00 sec)

moveAsLastChildOf should either (1) implement moving ancestors beneath their children correctly or (2) refuse to do so.

Note: these actions were carried out as separate PHP requests.

This is easy to reproduce by firing up the Apostrophe sandbox project, logging in as admin/admin, creating the page structure described, and then clicking the apostrophe in the upper left and then the Reorganize tool.

Instructions to check out the current sandbox are here:

http://www.apostrophenow.com/home/readme

You'll need to set up databases.yml and do a build --all and a data-load, that's about it.

Be sure to open a second tab so that you can have two views of the tree showing the initial state (C and D both as kids of B) so that you can drag D under C in the first tab and then try to drag C under D in the second tab. Otherwise the tree editor itself will block you from trying to move C under D.

The implementation of pkContextCMS/executeTreeMove is calling moveAsLastChildOf() in both cases and doing so to the right pages. I've added logging to verify this, look for references to TREEMOVE in the frontend_log.dev file.

We are going to add checks at the pkContextCMS level to refuse to attempt to move an ancestor beneath one of its children as a workaround, although in principle that should be possible (at least if the ancestor has no children? Not sure if it always makes sense if it does have children other than the ancestors of the new parent).

[DC-381] Automatic sequence names - with patch

Mon, 1 Mar 2010 19:53:59 +0000

Right now in yaml schema if you write sequence: true all the sequence names are set to 1.
This fixes the class generator in such way that the table name is used for sequence name if sequence === true otherwise it works just like before.

[DC-380] Sequence SQL is not generated when exporing sql for postgres - with patch

Mon, 1 Mar 2010 19:58:54 +0000

I spent a couple of hours on Saturday debugging why the heck the sql for sequences doesn't get generated for Postgresql. As it seems somebody forget about that when writing the export driver.

Attached is a patch against 1.2.1 version.
This probably also applies to Doctrine 2!

[DC-378] Typo in documentation for Taggable Extension

Mon, 15 Mar 2010 14:42:39 +0000

There are some typos in your documentation for Taggable extension.

In section related to getPopularTags method, if I use your code, like Doctrine::getTable('BlogPost')->getPopularTags(); I get an exception "Unknown method Doctrine_Table::getPopularTags" (with replacing BlogPost by my model name). In effect, it's not the table for my model that I must use but the table for TaggeableTag.
Besides, in your tests, you use Doctrine::getTable('TaggableTag')

I have write a patch to fix these typos. It's attached to this ticket.

[DC-377] Cannot delete a taggable record (Taggable Extension)

Fri, 10 Aug 2012 01:51:22 +0000

With Taggable extension, when I try to delete a record using Taggable, I get this exception :

SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`sf_sandbox/article_taggable_tag`, CONSTRAINT `article_taggable_tag_id_article_id` FOREIGN KEY (`id`) REFERENCES `article` (`id`))

If I check the sql queries generated by Doctrine, there are not "onDelete CASCADE" for one of relation added by Taggable extension.

I have write some test cases for reproduce this bug (checking if relation has a property onDelete setted to CASCADE) but I can't reproduce the thrown exception in test case because sqlite omits queries with constraint. Also, I found how to fix this bug.

The fix and test cases are available in the file attached to this ticket.

[DC-374] importing sqlite db with doctrine does not detect autoincrement fields

Mon, 1 Mar 2010 20:09:00 +0000

when importing a sqlite db with doctrine it fails to detect autoincrement fields resulting in exceptions when inserting records, like this one:
Uncaught exception 'Doctrine_Connection_Sqlite_Exception' with message 'SQLSTATE[23000]: Integrity constraint violation: 19 usergroup.group_id may not be NULL' in /Users/aiso/dev/php/cms/mix/lib/ext/doctrine/Doctrine/Connection.php:1083.

This is caused by the fact that there is no check on 'autoincrement' in Import/Sqlite.php. In sqlite3 a field is autoincrement whenever its type is integer and is a primary key.

a patch is included.

[DC-366] Error with tokenizer for JOINs (comments include proposed solutions)

Tue, 2 Mar 2010 10:30:52 +0000

Using the attached schema.yml works fine with Symfony-1.2 and Doctrine-1.0. It even works when I have tested it with Symfony-1.2 and Doctrine-1.1.

However, when using Symfony-1.3 and Doctrine-1.2 the following happens:

 
> php symfony doctrine:build-all-reload
>> doctrine  Dropping "doctrine" database
>> doctrine  Creating "dev" environment "doctrine" database
>> doctrine  generating model classes
>> file+     C:\Users\XXXXXXXXXXXXXXXX\AppDa...\Temp/doctrine_schema_30398.yml
>> tokens    C:/web/sf_sandbox-1.3/lib/model/doctrine/base/BaseBar.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/model/doctrine/base/BaseFoo.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/model...e/base/BaseJoinFooBar.class.php
>> autoload  Resetting application autoloaders
>> file-     C:/web/sf_sandbox-1.3/cache/fro.../config/config_autoload.yml.php
>> doctrine  generating form classes
>> tokens    C:/web/sf_sandbox-1.3/lib/form/BaseForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/doctrine/BarForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/...rine/base/BaseBarForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/...rine/base/BaseFooForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/...se/BaseJoinFooBarForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/...rine/BaseFormDoctrine.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/doctrine/FooForm.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/form/doctrine/JoinFooBarForm.class.php
>> autoload  Resetting application autoloaders
>> file-     C:/web/sf_sandbox-1.3/cache/fro.../config/config_autoload.yml.php
>> doctrine  generating filter form classes
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...octrine/BarFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...ase/BaseBarFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...ase/BaseFooFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...eJoinFooBarFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...aseFormFilterDoctrine.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte...octrine/FooFormFilter.class.php
>> tokens    C:/web/sf_sandbox-1.3/lib/filte.../JoinFooBarFormFilter.class.php
>> autoload  Resetting application autoloaders
>> file-     C:/web/sf_sandbox-1.3/cache/fro.../config/config_autoload.yml.php
>> doctrine  generating sql for models
>> doctrine  Generated SQL successfully for models
>> doctrine  created tables successfully
>> doctrine  Loading data fixtures from "C:\web\sf_sandbox-1.3\data/fixtures"


  Couldn't find class FooBar

The attached schema.yml looks like this:

# /config/doctrine/schema.yml
Foo:
  columns:
    id:
      type:                    integer(8)
      primary:                 true
      autoincrement:           true
    foo_field:                 string(100)
  relations:
    Bars:
      class:                   Bar
      refClass:                JoinFooBar
      local:                   foo_id
      foreign:                 bar_id
Bar:
  columns:
    id:
      type:                    integer(8)
      primary:                 true
      autoincrement:           true
    bar_field:               string(30)
JoinFooBar:
  columns:
    foo_id:
      type:                    integer(8)
      primary:                 true
    bar_id:
      type:                    integer(8)
      primary:                 true

As you can see, there is not meant to be any class called FooBar (the reference class for the many-to-many join is called JoinFooBar) so where is the name "FooBar" being picked up from and why is the code complaining that it cannot be found?

The fixture file is empty so there shouldn't be anything causing problems there.

This bug is making it impossible to upgrade our existing projects to Symfony-1.3 + Doctrine-1.2 so I'd be most grateful if you could look into this.

If the schema is changed from:

...
    bar_field:               string(30)
JoinFooBar:
  columns:
...

To:

...
    bar_field:               string(30)
FooBar:
  columns:
...

it seems to work, (that error disappears - even though the refClass is still set to *Join*FooBar) but we cannot easily justify changing all the classnames of all our Join tables in the projects we want to upgrade!

I hope you can see some simple solution to this and I'm happy to answer any questions you have.

(To reproduce this bug use the symfony sandbox, create a database and then use the attached schema.yml file.)

[DC-365] softdelete documentation is outof date

Tue, 2 Mar 2010 14:25:11 +0000

out of date http://www.doctrine-project.org/documentation/manual/1_2/en/behaviors#core-behaviors:softdelete the behavior add a deleted_at column from type timestamp

[DC-352] Doctrine_RawSql/Caching fatal error

Mon, 1 Mar 2010 15:47:38 +0000

Doctrine_RawSql::calculateResultCacheHash tries to call $this->getSql() - an undefined method - on line 444 of RawSql.php.

[DC-350] Problem with Doctrine_Record::link() where $this->$alias is NULL (including possible fix)

Mon, 1 Mar 2010 19:03:29 +0000

Doctrine 1.1 problem

Doctrine_Record::link() was causing problems for me at the following lines:

 
  foreach ($records as $record) {
    $this->$alias->add($record);
  }

After a little digging, the problem was due to the value of

 $this->$alias

being NULL.

Changing the code to this:

 
  foreach ($records as $record) {
    $this->get($alias)->add($record);
  }

Seemed to solve the problem, but I am not sure if this is the correct thing to do!

Could you take a look at this and then either

update this ticket to let me know if this is the right thing to do or
patch the next version of doctrine-1.1 to include this fix if this is sensible (and does not break something else!).

For your reference, the code block (in Symfony) that ended up causing a problem here looks something like this:

 
# /lib/model/doctrine/Foo.class.php

class Foo extends BaseFoo {
  public function save(Doctrine_Connection $conn = null) {
    if ($this->isNew()) {
      $this->createBar();
    }
    return parent::save($conn);
  }

 /**
  * Generate a Bar for this Foo and link to it (does NOT save)
  *
  * @return boolean   true if a new Bar was created, false if not
  */
  public function createBar() {
    if (empty($this->sf_guard_user_id)) {
      $this->Bar = new Bar();
      $this->Bar->setAbc($this->getAbc());
      $this->Bar->save();
      $this->Bar->link('xyz', XyzTable::XYZ_ID_DEFAULT); // This is the line that caused the problems
      return true;
    } else {
      return false;
    }
  }
}

Yours,

Christian

[DC-346] synchronize records based on the primary keys, patch available

Thu, 11 Mar 2010 10:08:14 +0000

If I do a synchronizeWithArray(), the order of the elements in the array has to be the same as they are saved in the database.
Of course this can not be assumed in any situation, where you have reordered form-elements etc.

I would expect, if I add the IDs to the elements in the array, that the update-process is based on them and not on the element-order.

Please take a look at this old ticket: http://trac.doctrine-project.org/ticket/2097

The attached patch works really nice on the actual revision too.

[DC-345] delete reference between OneToOne-Relation with synchronizeWithArray(), patch available

Thu, 11 Mar 2010 10:09:14 +0000

There is no possibility to delete a reference on a OneToOne-Relation with synchronizeWithArray().

If User and Group would be OneToOne related, i would expect that I could do something like the following (like on ManyToMany-Relations), to delete the relation between both.

$user->synchronizeWithArray(array(
    'Group' => array() // no error, but the relation is not deleted
));

or

$user->synchronizeWithArray(array(
    'Group' => array(null) // error, cause doctrine expects an existing ID
));

This fixes the problem:

Index: library/Doctrine/Record.php
===================================================================
--- library/Doctrine/Record.php	(revision 6903)
+++ library/Doctrine/Record.php	(working copy)
@@ -2012,6 +2012,8 @@
                     if (isset($value[0]) && ! is_array($value[0])) {
                         $this->unlink($key, array(), false);
                         $this->link($key, $value, false);
+                    } else if (empty($value) || (null === current($value))) {
+                    	$this->unlink($key, array(), false);
                     } else {
                         $this->$key->synchronizeWithArray($value);
                     }

[DC-343] Doctrine_View_Exception is documented as "Doctrine_Validator_Exception"

Mon, 1 Mar 2010 16:31:58 +0000

Doctrine_View_Exception is documented as "Doctrine_Validator_Exception"

[DC-334] Doctrine_Migration_Diff relies sys_get_tmp_dir in a way that will break with mutliple projects running the command at once

Tue, 8 Dec 2009 17:58:54 +0000

sys_get_temp_dir returns the same value at all times for a given Unix user.

This means that if one attempts to run doctrine:generate_migrations_diff on two projects at once, they will contend for the same temporary folder. Temporary files ought to be specific to an instance of a task, or at least to a project.

A fix would be to append getpid() to sys_get_temp_dir and use that as the temp dir throughout the task. That is completely task-specific:

$tmp = sys_get_temp_dir() . DIRECTORY_SEPARATOR . getpid();
mkdir($tmp);

Another fix would be to use a folder within the data/ folder of the project, which is project-specific:

$tmp = sfConfig::get('sf_data_dir') . DIRECTORY_SEPARATOR . 'doctrine_tmp';

(We use the latter approach in pkToolkitPlugin)

[DC-332] Doctrine_Migration_Diff doesn't work when plugin schemas are present but there is no app schema

Tue, 2 Mar 2010 12:38:55 +0000

A project with plugin schemas, but no project-level schema, which Symfony is otherwise fine with:

svn co http://svn.symfony-project.com/plugins/pkContextCMSPlugin/sandbox/branches/1.3 cmstest13
cd cmstest13
./symfony doctrine:generate-migrations-diff

>> doctrine generating migration diff
>> file+ /private/var/folders/3H/3Hu3TTyjFt...TI/~~Tmp~~/doctrine_schema_81204.yml

Notice: Undefined variable: extension in /Users/boutell/Sites/cmstest13-jonwagetest/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Migration/Diff.php on line 320

Notice: Undefined variable: extension in /Users/boutell/Sites/cmstest13-jonwagetest/lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Migration/Diff.php on line 324

No php or yml files found at path: "/Users/boutell/Sites/cmstest13-jonwagetest/lib/model/doctrine"

[DC-323] when inserting a record into sql server (via odbc) doctrine fails to get last inserted ID

Mon, 15 Mar 2010 21:45:38 +0000

in Doctrine/Sequence/Mssql.php the function lastInsertId() fails to retrieve the last inserted ID when inserting a record. Because the major release of my sql server is bigger than 8, it chooses $query = 'select SCOPY_IDENTITY()' which does not return a number (in fact it does not return anything), although the record IS inserted succesfully. The backtrace is attached.
If, on the other hand, I force doctrine to use 'select @@IDENTITY' the query does return the correct number and everything goes fine!
So I think the conditions which query to choose is incorrect. I tried both queries in SQL server itself and both queries returned the right number. But one of them gets lost somewhere when using it in doctrine.

[DC-320] Doctrine_Record fails to correctly update columns named data (conflict with getData method)

Fri, 12 Mar 2010 06:50:41 +0000

I have a table with a "data" column (DATE type but the issue is not strictly related to the datatype), when updating/insering a record it fails with this error:

strtotime() expects parameter 1 to be string, array given in /usr/share/pear/Doctrine/lib/Doctrine/Record.php on line 1526

With some debugging I found that the value stored in $old was the internal $data array, and not my value. I assume that there's a conflict with the get/setData methods.

Thanks.

[DC-319] getModified() returns object where ids are expected

Tue, 2 Mar 2010 13:50:54 +0000

Assigning a new unsaved relation to an entity confuses getModified() to return records for values such as userId, that are expected to be ints.

Here is a full example to reproduce:

<?php
require_once '_loader.php';

$mgr = Doctrine_Manager::getInstance();
$mgr->openConnection('....');

class User extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->setTableName('t_users');

        $this->hasColumn('name', 'string', 32);
    }
}

class Post extends Doctrine_Record
{
    public function setTableDefinition()
    {
        $this->setTableName('t_posts');

        $this->hasColumn('body', 'string', 256);
        $this->hasColumn('userId', 'integer');
    }

    public function setUp()
    {
        $this->hasOne('User', array(
            'local'   => 'userId',
            'foreign' => 'id'
        ));
    }
}

Doctrine::dropDatabases();
Doctrine::createDatabases();
Doctrine::createTablesFromArray(array('User', 'Post'));

$joe = new User();
$joe->name = 'Joe';
$joe->save();

$post = new Post();
$post->body = 'Hi';
$post->User = $joe;
$post->save();

$bill = new User();
$bill->name = 'Bill';
//$bill->save(); // If this is uncommented everything works fine

$post->User = $bill;

var_dump(' --- New --- ');
var_dump($post->getModified());

And instead of a id for userId I get this

string(13) " --- New --- "
array(1) {
  ["userId"]=>
  object(User)#37 (18) {
    ["_node:protected"]=>
    NULL
    ["_id:protected"]=>
    array(0) {
    }
    ["_data:protected"]=>
    array(2) {
      ["id"]=>
      object(Doctrine_Null)#4 (0) {
      }
      ["name"]=>
      string(4) "Bill"
    }
    ["_values:protected"]=>
    array(0) {
    }
    ["_state:protected"]=>
    int(2)
    ["_lastModified:protected"]=>
    array(0) {
    }
    ["_modified:protected"]=>
    array(1) {
      [0]=>
      string(4) "name"
    }
    ["_oldValues:protected"]=>
    array(1) {
      ["name"]=>
      NULL
    }
    ... trimmed ...

expected

string(13) " --- New --- "
array(1) {
  ["userId"]=>
  string(1) "2"
}

Tested on 1.1 and 1.2 branches from svn. (same result)

[DC-318] Doctrine_Table::find(x) fails for odbc/mssql connection due to limit() clause

Duplicate — Mon, 22 Mar 2010 13:15:41 +0000

call that fails is Doctrine::getTable('Building')->find(1). With mysql all is fine, but if I use MSSQL via odbc (SQL Native Client) I get an exception saying:
SQLSTATE[22018]: Invalid character value for cast specification: 206 [Microsoft][SQL Native Client][SQL Server]Er is een conflict met het type operand ontstaan: text is incompatibel met int (SQLExecute[206] at ext\pdo_odbc\odbc_stmt.c:254)
see attached stacktrace.
So find(1) fails but a call to e.g. findAll() works fine.

I found out that if I leave out the limit(1) from the function find() on line 1602 it gives me the correct object and no exception!
So actually what goes wrong is the limit(1) clause in this call:
$object = Doctrine_Query::create()~~>from('Building b')~~>where('b.id = 1')~~>limit(1)~~>fetchOne();
with getSqlquery() this becomes:
SELECT TOP 1 [inner_tbl].[id] AS [b__id] FROM (SELECT TOP 1 [b].[id] AS [b__id], [b].[version] AS [b__version], [b].[name] AS [b__name], [b].[number] AS [b__number], [b].[title_nl] AS [b__title_nl], [b].[title_en] AS [b__title_en], [b].[published] AS [b__published] FROM [building] [b] WHERE ([b].[id] = ?)) AS [inner_tbl]

If executed with sqlcmd.exe this gives an error saying 'no columnname id', what seems to be correct since it should be [inner_tbl].[b__id] iso [inner_table].[id], so I suspect that the modifyLimitQuery() function in Connection/Mssql.php is not correct either.

I can work around this problem by doing a fetchOne() iso find().

[DC-300] synchronizeWithArray deletes Entries in RefTable when updating related Entries

Mon, 15 Mar 2010 11:39:23 +0000

You have Users and Groups with a ManyToMany relation (refClass = UserGroup).
Then you do a synchronizeWithArray() on a user:

 
$user->synchronizeWithArray(array(
    'Groups' => array(
        array('name' => 'updated Group')
    )
));

When you update a record with synchronizeWithArray() and you update ManyToMany related entries, the RefTable entries gets deleted.

I think the problem is located near:
Doctrine_Record line 2024:

 
        // Eliminate relationships missing in the $array
        foreach ($this->_references as $name => $relation) {
	        $rel = $this->getTable()->getRelation($name);
	
// PROBLEM: RefClass "UserGroup" will never be set in the sync-Array (just "Groups"), so all entries in UserGroup-Table will be deleted
// only new Groups that are synced will be created with a link in the refTable
		if ( ! isset($array[$name]) && ( ! $rel->isOneToOne() || ! isset($array[$rel->getLocalFieldName()]))) {
                    unset($this->$name);
                }
        }

TestCase follows.

[DC-289] Using MSSQL connection the find method for models does not work

Duplicate — Tue, 2 Mar 2010 12:56:35 +0000

using a doctrine generated class's find method produced erroneous SQL such as:

SELECT TOP 1 [inner_tbl].[id] AS [b__id] FROM (SELECT TOP 1 [b].[id] AS [b__id], [b].[name] AS [b__name], [b].[alias] AS [b__alias], [b].[ip] AS [b__ip], [b].[operator_id] AS [b__operator_id], [b].[cell_id] AS [b__cell_id], [b].[latitude] AS [b__latitude], [b].[longtitude] AS [b__longtitude], [b].[community_read] AS [b__community_read], [b].[community_write] AS [b__community_write], [b].[last_found_at] AS [b__last_found_at], [b].[active] AS [b__active], [b].[type] AS [b__type], [b].[poll_mac_behind_sus] AS [b__poll_mac_behind_sus], [b].[created_at] AS [b__created_at] FROM [basestation] [b] WHERE ([b].[id] = '2')) AS [inner_tbl]

commenting out the following line (193) in' function modifyLimitQuery' for lib/Doctrine/Connection/Mssql.php

$query = preg_replace('/^'.$selectRegExp.'/i', $selectReplace . 'TOP ' . ($count + $offset) . ' ', $query);

//$query = 'SELECT TOP ' . $count . ' ' . $this->quoteIdentifier('inner_tbl') . '.' . $key_field . ' FROM (' . $query . ') AS ' . $this->quoteIdentifier('inner_tbl');

if ($orderby !== false) {

It appears to have worked. This method was part of jwage's commit for change set 6795 (http://trac.doctrine-project.org/changeset/6795/branches/1.2/lib/Doctrine/Connection/Mssql.php) so there must be a reason for this change. This is very preliminary. If the change works there is a considerable amount of refactoring that way be done. I will commit a proper patch once I am able to test exhaustively, at the moment this is a show stopper and I need to continue development.

[DC-139] Versionable behavior not use the right connection

Mon, 1 Mar 2010 19:10:57 +0000

I have 2 connections and a table with versionable behavior. The problem is that doctrine use the last connection defined in the database.yml for the article_version table not the connection from the article table.

I think it is also good idea to add a connection option to the behavior.

[DC-104] Fetching a subset of records from the view

Tue, 16 Mar 2010 14:49:09 +0000

As far as I can see, all rows are fetched from a view. There is not much sense to use views if you cannot filter result based on some where conditions, so this would be a great improvement to the View class.