Doctrine Project

[DC-895] [I18n] Defining languages with locality (eg. en_GB) breaks functionality with SQL Integrity error - fix included

Wed, 20 Oct 2010 04:42:40 +0000

When defining languages as language_COUNTRY codes (supported by symfony by default), the functionality to work with I18n records breaks, resulting in "SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry" errors.

The reason is very simple: Doctrine's I18n language column is defined as a CHAR(2), thus shortening eg. "en_GB" value to "en", thus causing the above SQL error when a "en" translation for a record already exists.

The solution is even simpler: change the column's length to 7 in the Doctrine_I18n class's options: I've tested this and all runs great: the correct SQL is being generated, the models behave correct, ...

[DC-769] Variable type different for return value from Doctrine_Record->toArray() depending on whether the object is from a select, or a save.

Tue, 24 Aug 2010 12:55:48 +0000

With a object that is created via a save(), and the record's primary key is a INT fed by a SEQUENCE, the type of the variable is an INT.

With an object that is hydrated from the database via a SELECT, the record's primary key INT will come back in 'toArray()' as a STRING.

That means that checking for type has to know what context it came from, user, INSERT, or SELECT. Not fun.

This also screws up converting arrays to JSON, 'cause the STRINGS get quotation marks and the INTS do not.

As a general rule, everything FROM the database seems to be strings. Yes, I know, everything 'on the wire' or 'through a socket' comes out as text. And it's a lot faster to leave it that way.

But having the type be different depending on the database operation? Not sure I like that.

[DC-764] Major->please.....Value of Primary key from sequence in Postgres table NOT being set (although sequence gets incremented)

Fri, 25 Jun 2010 18:00:37 +0000

In the ERD/schema that I have set up, a couple levels down in hierarchal order, a table has 3 composite foreign keys, and one sequence of its own. That sequence does not get get set into the 'Table->sequence variable'. That means when the file 'UnitOfWork' executes the function '_assignSequence()', it finds no sequence name, and skips the assignment of the sequence value.

This of course blows up my inserts.

I have included the following documentation:

A/ An installation and further description README.tx file.
B/ SQL script to generate a anonymous version of my ERD - I.E. the table names and column names have been changed to protect the guilty (and proprietary)
C/ A fixture file to load some data.
D/ A *.png file showing a graphical view of the ERD.
E/ The generated schema.yml file from ./symfony doctrine:build-schema
F/ A modifiled (has certain echo statements for troubleshooting purposes) UnitOfWork.php file.
G/ A task file to run that tries to load the schema with valid values.
H/ An output file from running the Task and modified UnitOfWork.php file showing the exact point of error during insert.

Please let me know what I can do to help get this troubleshot quicly. Thx
E/

[DC-674] NULL Dates are translated to '0000-00-00' after upgrading to 1.2.2

Wed, 6 Oct 2010 06:29:40 +0000

Once the upgrade was done from Doctrine 1.2.1 to 1.2.2 we discovered that date related issues started to appear.
With dates that are persisted in DB as NULL are translated to "0000-00-00" when retrieved from DB. This has occurred in multiple places and is quite worrying as there is a lot of dates in our project. This means that everywhere in our codebase where we check a datevalue in our Models is NULL we need also to check for the string literal "0000-00-00".

[DC-580] if deleting root with Doctrine_Node_NestedSet::delete() deletes all root nodes

Wed, 17 Mar 2010 23:02:05 +0000

Im using next code
$category = Doctrine_Core::getTable('Mr_DirectoryTreeNodes')->findOneBy('id',$params['id']);
$node = $category->getNode();
$node->delete();

Doctrine_Node_NestedSet::delete() deletes all root nodes;
_____________________

to fix add

$q = $q->addWhere("$baseAlias.id = ?", $this->record->get('id'));

after :

$q = $q->addWhere("$baseAlias.lft >= ? AND $baseAlias.rgt <= ?", array($this->getLeftValue(), $this->getRightValue()));

[DC-553] issue when changing the connection inside Doctrine_Query::preQuery() on a model using a behavior

Mon, 19 Jul 2010 07:45:41 +0000

We were following:
http://www.doctrine-project.org/documentation/cookbook/1_1/en/master-and-slave-connections

class MyQuery extends Doctrine_Query
{
// Since php doesn't support late static binding in 5.2 we need to override
// this method to instantiate a new MyQuery instead of Doctrine_Query
public static function create($conn = null)

{ return new MyQuery($conn); }

public function preQuery()
{
// If this is a select query then set connection to one of the slaves
if ($this->getType() == Doctrine_Query::SELECT)

{ $this->_conn = Doctrine_Manager::getInstance()->getConnection('slave_' . rand(1, 4)); // All other queries are writes so they need to go to the master }

else

{ $this->_conn = Doctrine_Manager::getInstance()->getConnection('master'); }

}
}

However we are actually forcing all queries after the first access to the master to be run against the master (including selects). Note the example should probably be changed to use setConnection(). However even when using setConnection() it seems like changing the connection can cause issues when running a select on a model with a behavior (in our case we were using i18n). Therefore we believe there is some issue that is caused through the event system, because otherwise queries work just fine even when changing the connection as per the above described code.

We managed to fix things, by not setting the connection explicitly and instead simply using setCurrentConnection('master'), so the bug does not affect us anymore. However this seems to indicate some issues deep inside the event-behavior-template code.

[DC-528] CLONE -isValueModified returns true for timestamps that appear different but are equal

Tue, 2 Mar 2010 13:26:59 +0000

This is a copy of DC57:

"Doctrine_Record::isValueModified compares timestamps as strings and values that are equal such as 2009-09-02 00:00:00 and 2009-09-02 are treated as modified.

The code should do a second compare on the strtotime value if the strings appear to be unequal."

The changes made with this ticket causes problems with old timestamps because of strtotimes behaviour with dates before beginning of unix-period. I attached a diff for the original testcase to demonstrate the problem.

[DC-333] Doctrine_Migration_Diff reuses the same temporary folder on consecutive runs, resulting in collisions between projects

Mon, 7 Dec 2009 21:29:50 +0000

svn co http://svn.symfony-project.com/plugins/pkContextCMSPlugin/sandbox/branches/1.3 cmstest13
cd cmstest13
[edited config/doctrine/schema.yml and added a trivial table so there would be something at the app level]
[successful doctrine:build --all followed]

./symfony doctrine:generate-migrations-diff
>> doctrine generating migration diff
>> file+ /private/var/folders/3H/3Hu3TTyjFt...TI/~~Tmp~~/doctrine_schema_15549.yml

Fatal error: Class 'EventUser' not found in /private/var/folders/3H/3Hu3TTyjFtuvtN3D5tDUxU+++TI/~~Tmp~~/fromprfx_doctrine_tmp_dirs/base/BaseEventGuest.class.php on line 7

I recognize my personal temp folder from my environment in there:

TMPDIR=/var/folders/3H/3Hu3TTyjFtuvtN3D5tDUxU+++TI/~~Tmp~~/

So presumably these tasks are supposed to clean it up after they use it. But none of my attempts to use this task so far have succeeded, so I suspect the problem is that the folder does not get cleaned up in the event of an error. This folder needs to get cleaned up on all errors, or perhaps cleared at the start of a new run (that is probably going to turn out to be a more reliable fix).

I'll manually clear it and move on to the bug I was originally looking to reproduce.

[DC-330] Doctrine_Table unshiftFilter() expects method Doctrine_Record_Filter init()

Mon, 7 Dec 2009 18:26:10 +0000

That method is not defined in Doctrine_Record_Filter either as abstract or with empty implementation, only in Doctrine_Record_Filter_Compound.

Doctrine_Record_Filter_Standard seems to get around this by not being registered via unshiftFilter()

[DC-317] Using NestedSet behavior, createRoot function doesn't behave as expected with string multiple root key

Mon, 7 Dec 2009 20:34:19 +0000

I have defined this model :

 
Page:
  options: { type: InnoDB, collate: utf8_unicode_ci, charset: utf8 }
  columns:
    topic:       { type: string(32), notnull: true }
    title:        { type: string(255), notnull: true }
  actAs:
    NestedSet:      { hasManyRoots: true, rootColumnName: topic }

And use this code (database is empty) :

<?

$page = new Page;
$page->topic = 'my-topic';
$page->title = 'My Title';
$page->save();

print_r( $page->topic );  // OK, here it's perfect

Doctrine::getTable('Page')->getTree()->createRoot( $page );

print_r( $page->topic ); // Now topic == 1 . It's buggy !


Doctrine::getTable('Page')->getTree()->fetchTree( 'my-topic' ); // Buggy : return false !

?>

Let me know if you need more explainations,
julien

[DC-314] length option ignored in addColumn method in Doctrine 1.2 migrations

Wed, 2 Dec 2009 17:12:28 +0000

I am using http://doctrine.mirror.svn.symfony-project.com/branches/1.2/lib and saw this problem with revision 6806.

The 'length' parameter in the options array seems to be
ignored by addColumn in Doctrine 1.2 migrations. No matter what we specified for
'length' we got a bigint in MySQL, resulting in failure later when we
tried to add a foreign key because we needed a 4-byte integer. There
does not seem to be any documentation of what is valid in the options
array when calling addColumn, however I see that length is still used
when passing an apparently identical options array for a particular
column when calling createTable.

That is, this code:

$this->addColumn('pg_event_request', 'event_id', 'integer',
array('length' => 4));

Does not work properly in Doctrine 1.2 (you get a bigint in MySQL).

We were able to work around it by implementing a migrate() method
instead, passing 4 as the final argument (there doesn't seem to be
clear documentation of this final argument but in the example in the
documentation it is the length of a string column, and sure enough it
does the same thing for an integer). Passing 4 here worked, we got a
4-byte integer.

[DC-308] Doctrine is throwing base and not project-level Exceptions

Tue, 1 Dec 2009 22:10:34 +0000

Files (without locations, easy to find):

Doctrine_Adapter_Statement_Oracle
replace to Doctrine_Adapter_Exception

Doctrine_Node_NestedSet
replace to Doctrine_Node_Exception

sfYamlInline from Doctrine\Parser\sfYaml
replace with InvalidArgumentException

[DC-307] Oracle adapter statement is not behavin correctly when error mode is Doctrine_Core::ERRMODE_SILENT or Doctrine_Core::ERRMODE_WARNING

Tue, 1 Dec 2009 19:17:17 +0000

Fetch column method looks like this:

public function fetchColumn($columnIndex = 0)
{
if ( ! is_integer($columnIndex)) {
$this->handleError(array('message'=>"columnIndex parameter should be numeric"));
}
$row = $this->fetch(Doctrine_Core::FETCH_NUM);
return $row[$columnIndex];
}

Method handleError() not always throws an exception, and by passing it a string or any other variable type than integer will result in warning.

Fix (depending on what is considered to be required by interface):

if ( ! is_integer($columnIndex)) {
$this->handleError(array('message'=>"columnIndex parameter should be numeric"));
return false;
}

if ( ! is_integer($columnIndex)) {
throw new Doctrine_Adapter_Exception("columnIndex parameter should be numeric");
}

[DC-306] Oracle adapter statement is referencing non-existing constants

Tue, 1 Dec 2009 19:05:15 +0000

Line 316 in Doctrine/Adatper/Statement/Oracle.php has:

case FETCH_OBJ:
return oci_fetch_object($this->statement, OCI_NUM + OCI_RETURN_NULLS + OCI_RETURN_LOBS);
break;

There is no constant FETCH_OBJ, so line should be:

case Doctrine_Core::FETCH_OBJ:
return oci_fetch_object($this->statement, OCI_NUM + OCI_RETURN_NULLS + OCI_RETURN_LOBS);
break;

[DC-305] Oracle adapter statement closeCursor() is not working properly

Tue, 1 Dec 2009 19:09:01 +0000

Close cursor method cleans up non-existing array $bind_params, correct variable name is $bindParams. (comment of $bindParams is wrong to because it also speaks about $bind_params)

Now:

public function closeCursor()
{
$this->bind_params = array();
return oci_free_statement($this->statement);
}

Fix:

public function closeCursor()
{
$this->bindParams = array();
return oci_free_statement($this->statement);
}

[DC-304] Auloader returns false even though sfYaml* class is loaded

Tue, 1 Dec 2009 19:06:46 +0000

Autoloader loads method has lines:

if (0 !== stripos($className, 'Doctrine_') || class_exists($className, false) || interface_exists($className, false)) {
return false;
}

Which for sfYaml classes always are true (0 !== stripos('sfYaml', 'Doctrine_') ==> true) and hence autoloader returns false. This creates problems if there are more than one autoloader in the stack.

Fix:

{qupte}

if (strpos($className, 'sfYaml') === 0)

{ require dirname(__FILE__) . '/Parser/sfYaml/' . $className . '.php'; return true; } {quote}

[DC-302] Issues when using automatic relations ordering through 'orderBy' param in m2m relations

Tue, 1 Dec 2009 19:03:23 +0000

Partially related to ~~DC-240~~.

I found some additional problems, mainly with self-referenced relations.
I use ACL system with multiple inheritance, where order of inherited elements matters.
Here we have (Role <- m2m orderBy position - > Role) and (User < - m2m orderBy position -> Role):

class Role extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('name', 'string', 64);
	}
	
	public function setUp()
	{
		$this->hasMany('User as Users', array('local' => 'id_role', 'foreign' => 'id_user', 'refClass' => 'UserRole'));
		$this->hasMany('Role as Parents', array('local' => 'id_role_child', 'foreign' => 'id_role_parent', 'refClass' => 'RoleReference', 'orderBy' => 'position'));
		$this->hasMany('Role as Children', array('local' => 'id_role_parent', 'foreign' => 'id_role_child', 'refClass' => 'RoleReference'));
	}
}

class RoleReference extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('id_role_parent', 'integer', null, array('primary' => true));
		$this->hasColumn('id_role_child', 'integer', null, array('primary' => true));
		$this->hasColumn('position', 'integer', null, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasOne('Role as Parent', array('local' => 'id_role_parent', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
		$this->hasOne('Role as Child', array('local' => 'id_role_child', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
	}
}

class User extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('username', 'string', 64, array('notnull' => true));
		$this->hasColumn('password', 'string', 128, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasMany('Role as Roles', array('local' => 'id_user', 'foreign' => 'id_role', 'refClass' => 'UserRole', 'orderBy' => 'position'));
	}
}

class UserRole extends Doctrine_Record
{
	public function setTableDefinition()
	{
		$this->hasColumn('id_user', 'integer', null, array('primary' => true));
		$this->hasColumn('id_role', 'integer', null, array('primary' => true));
		$this->hasColumn('position', 'integer', null, array('notnull' => true));
	}
	
	public function setUp()
	{
		$this->hasOne('User', array('local' => 'id_user', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
		$this->hasOne('Role', array('local' => 'id_role', 'foreign' => 'id', 'onDelete' => 'CASCADE'));
	}
}

Sample data:

$role1 = new Role();
$role1->name = 'admin'; // id: 1
$role1->save();

$role2 = new Role();
$role2->name = 'publisher'; // id: 2
$role2->save();

$role3 = new Role();
$role3->name = 'reviewer'; // id: 3
$role3->save();

$role4 = new Role();
$role4->name = 'mod'; // id: 4
$role4->save();

// reviewer inherits from admin, mod, publisher - in that order
$role3->Parents[] = $role1;
$role3->Parents[] = $role4;
$role3->Parents[] = $role2;
$role3->save();

// update positions
$query = Doctrine_Query::create()
	->update('RoleReference')
	->set('position', '?', 0)
	->where('id_role_child = ?', 3)
	->andWhere('id_role_parent = ?', 1)
	->execute();
$query = Doctrine_Query::create()
	->update('RoleReference')
	->set('position', '?', 1)
	->where('id_role_child = ?', 3)
	->andWhere('id_role_parent = ?', 4)
	->execute();
$query = Doctrine_Query::create()
	->update('RoleReference')
	->set('position', '?', 2)
	->where('id_role_child = ?', 3)
	->andWhere('id_role_parent = ?', 2)
	->execute();
	

// add test user
$user = new User();
$user->username = 'test';
$user->password = 'test';
$user->fromArray(array('Roles' => array(4, 2)));
$user->save();
// update positions
$query = Doctrine_Query::create()
	->update('UserRole')
	->set('position', '?', 0)
	->where('id_user = ?', 1)
	->andWhere('id_role = ?', 4)
	->execute();
$query = Doctrine_Query::create()
	->update('UserRole')
	->set('position', '?', 1)
	->where('id_user = ?', 1)
	->andWhere('id_role = ?', 2)
	->execute();

Now, lazy-loading self-referenced m2m relations seems to be the issue (I know lazy-loading is wrong but it's needed to be like that in some parts of our system):

$role = Doctrine::getTable('Role')->find(3);
print_r($role->Parents->toArray());

The query which is created and executed during lazy-load of Parents relations is as follows:

SELECT role.id AS role__id, role.name AS role__name, role_reference.id_role_parent AS role_reference__id_role_parent, role_reference.id_role_child AS role_reference__id_role_child, role_reference.position AS role_reference__position FROM role INNER JOIN role_reference ON role.id = role_reference.id_role_parent WHERE role.id IN (SELECT id_role_parent FROM role_reference WHERE id_role_child = ?) ORDER BY role.id ASC, position

(seems a little strange as there are no automatically generated aliases e.g. r1, r2 etc. but whole table names)
The result is ordered by role.id first, then by position (without any alias and that could be an additional problem in some cases)

The result is: (as you can see the order of roles is 1, 2, 4 (positions: 0, 2, 1) instead of 1, 4, 2)

Array
(
    [0] => Array
        (
            [id] => 1
            [name] => admin
            [RoleReference] => Array
                (
                    [0] => Array
                        (
                            [id_role_parent] => 1
                            [id_role_child] => 3
                            [position] => 0
                            [Parent] => 
                        )

                )

        )

    [1] => Array
        (
            [id] => 2
            [name] => publisher
            [RoleReference] => Array
                (
                    [0] => Array
                        (
                            [id_role_parent] => 2
                            [id_role_child] => 3
                            [position] => 2
                            [Parent] => 
                        )

                )

        )

    [2] => Array
        (
            [id] => 4
            [name] => mod
            [RoleReference] => Array
                (
                    [0] => Array
                        (
                            [id_role_parent] => 4
                            [id_role_child] => 3
                            [position] => 1
                            [Parent] => 
                        )

                )

        )

)

It is NOT an issue with lazy-loading m2m relations between two different models:

$user = Doctrine::getTable('User')->find(1);
print_r($user->Roles->toArray());

The query generated seems to be correct: (well except the lack of an alias in front of position column in ORDER BY clause)

SELECT `r`.`id` AS `r__id`, `r`.`name` AS `r__name`, `u`.`id_user` AS `u__id_user`, `u`.`id_role` AS `u__id_role`, `u`.`position` AS `u__position` FROM `role` `r` LEFT JOIN `user_role` `u` ON `r`.`id` = `u`.`id_role` WHERE (`u`.`id_user` IN (?)) ORDER BY position

It works well for self-referenced relations where relation are defined in DQL e.g.:

$query = Doctrine_Query::create()
	->from('Role r')
	->leftJoin('r.Parents rp')
	->orderBy('r.name ASC')
	->where('r.id = ?', 3);
	
var_dump($query->getSqlQuery());
$result = $query->fetchOne();

print_r($result->Parents->toArray());

To sum up:
1. orderBy in m2m self-referenced relations does not work when they are lazy-loaded
2. lack of table alias for orderBy column when lazy-loading m2m relations between separate models (possibly not an issue?)

I am not sure if the first one could be fixed at all, due to specific query construction? If not, I would be glad to see a possible workaround for this problem.

Thanks in advance.

[DC-298] Doctrine_Cache_Driver : array_search() expects parameter 2 to be array, boolean given at line 283

Tue, 1 Dec 2009 19:19:27 +0000

Doctrine_Cache_Driver::fetch() is supposed to return a string, but an array_search() is made on it by Doctrine_Cache_Driver::_deleteKey() (at line 283).

[DC-126] Doctrine_Migration_Diff breaks on inherited class

Mon, 29 Mar 2010 13:29:07 +0000

This ticket is a duplicate of this one http://trac.symfony-project.org/ticket/7272 but it's more a Doctrine bug than a symfony one.

When trying to make a diff on schema with inheritance, the task breaks when trying to load a model inherited from an other one. I think this is because the inherited model might be loaded before his ancestor.