Doctrine Project

[DC-895] [I18n] Defining languages with locality (eg. en_GB) breaks functionality with SQL Integrity error - fix included

Wed, 20 Oct 2010 04:42:40 +0000

When defining languages as language_COUNTRY codes (supported by symfony by default), the functionality to work with I18n records breaks, resulting in "SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry" errors.

The reason is very simple: Doctrine's I18n language column is defined as a CHAR(2), thus shortening eg. "en_GB" value to "en", thus causing the above SQL error when a "en" translation for a record already exists.

The solution is even simpler: change the column's length to 7 in the Doctrine_I18n class's options: I've tested this and all runs great: the correct SQL is being generated, the models behave correct, ...

[DC-764] Major->please.....Value of Primary key from sequence in Postgres table NOT being set (although sequence gets incremented)

Fri, 25 Jun 2010 18:00:37 +0000

In the ERD/schema that I have set up, a couple levels down in hierarchal order, a table has 3 composite foreign keys, and one sequence of its own. That sequence does not get get set into the 'Table->sequence variable'. That means when the file 'UnitOfWork' executes the function '_assignSequence()', it finds no sequence name, and skips the assignment of the sequence value.

This of course blows up my inserts.

I have included the following documentation:

A/ An installation and further description README.tx file.
B/ SQL script to generate a anonymous version of my ERD - I.E. the table names and column names have been changed to protect the guilty (and proprietary)
C/ A fixture file to load some data.
D/ A *.png file showing a graphical view of the ERD.
E/ The generated schema.yml file from ./symfony doctrine:build-schema
F/ A modifiled (has certain echo statements for troubleshooting purposes) UnitOfWork.php file.
G/ A task file to run that tries to load the schema with valid values.
H/ An output file from running the Task and modified UnitOfWork.php file showing the exact point of error during insert.

Please let me know what I can do to help get this troubleshot quicly. Thx
E/

[DC-403] Eliminate queries produced by Doctrine_Node_NestedSet::getDescendants() when possible

Fri, 16 Apr 2010 12:18:05 +0000

How to reproduce

fetch a tree with nested set

$root = Doctrine::getTable($model)->getTree()->findRoot($rootId);
$treeObject= Doctrine::getTable($model)->getTree()->fetchTree($root->getId());

issue

$root->getNode()->getChildren();

or there will be a total query mess in a lambda function with a loop getChildren().
...
<?php foreach($root->getChildren() as $child): ?>
   ....
<?php endforeach; ?>
...

Problem is described more verbosely here – http://codeutopia.net/blog/2008/08/30/understanding-doctrines-nestedset-feature/

What behavior is expected

An already fetched record instance is returned, without calling database and without causing query flooding.

Like in propel.

In propel if you are calling ....::retrieveTree($id) it returns the root
with completed, pooled (cached) and linked tree.

What happens

An additional query is issued

This is a big slip in architecture of Doctrine`s nested set implementation.

[DC-299] Doctrine::loadModels() returns an incorrect result if there is some models named before "Base"

Mon, 30 Nov 2009 16:07:15 +0000

If there is a model named before "Base" (in the alpabetical order), like "Address", Doctrine::loadModels() returns an incorrect array by including the BaseAddress class :

Array
(
    [Address] => Address
    [BaseAddress] => BaseAddress
)

This happens because in the list of files, Address.class.php (where Address extends BaseAddress) comes before BaseAddress.class.php. So BaseAddress is already loaded when loadModels() checks if the BaseAddress class exists. Then this class is added in the loaded models without check if this is a valid model class.

This can be easily fixed :

// Doctrine/Core.php , line 679:

// replace :

$loadedModels[$className] = $className;

// by :
if (self::isValidModelClass($className)) {
  $loadedModels[$className] = $className;
}

[DC-295] Export_Schema does not properly account for classes that have a prefix.

Mon, 30 Nov 2009 18:18:30 +0000

When trying to run doctrine-cli generate-yaml-models (I think other tasks are affected too), I get a yaml file consisting of { }.
I think this is because on line 48 of Doctrine/Export/Schema.php $classPrefix is not passed to Doctrine_Core::loadModels($directory) even if it is set in the configuration array.
This is causing doctrine to think there are no models to generate the yaml for if I am using the $classPrefix.

I'm just learning Doctrine so it's entirely possibly something else is to blame for my issue, but this is where I was able to trace it to.

[DC-288] Doctrine_Parser_Yml dependany on sfYaml causing issues for non symfony users

Thu, 18 Feb 2010 11:13:49 +0000

I am currently undergoing an integration with the Zend Framework. Unfortunatly we do not use the Symfony framework and have no scope available to include it.

The requirement for sfyaml in its rawest form has caused me to have to rewrite part of your parser to ensure it includes the crrect files which I have now included in our working version of Doctrine.

As Symfony appears to be distributed under an open license surely it would make sense for you to actually include this (or a modified version of this) into your library.

This would make the code much more portable and reusable for people who do not use symfony

My "Quick Fix" just involved dropping all the sfYaml files into the parser folder and doing a straight include untill I can find a more elegant solution

[DC-286] Trailing DIRECTORY_SEPARATOR will cause Doctrine_Core::loadModels in PEAR mode to fail

Mon, 30 Nov 2009 17:55:04 +0000

If I'm using the PEAR model loading in Doctrine, and I try to create the tables from the models as follows.

Doctrine::createTablesFromModels('/path/to/my/models/');

Doctrine doesn't recognise the models and can't create any tables as a result.
However if I remove the trailing slash.

Doctrine::createTablesFromModels('/path/to/my/models');

It works fine. This wasn't a problem is 1.2BETA-3. The problem is caused by changeset 6796, and the code that extracts the class name from the path of the filename not taking into account the trailing DIRECTORY_SEPARATOR.

[DC-283] Unsetting an invalid property

Tue, 24 Nov 2009 19:38:55 +0000

Actually I'm not sure how this issue could implicate on any behavior.
I was debbuging a project and I found this invalid reference:

Relation/Parser.php

public function bind($name, $options = array())
{
//...
    if ($this->hasRelation($alias)) {
        unset($this->relations[$alias]); // Doesn't exist, the right property is $this->_relations
        unset($this->_pending[$alias]);
    }
//...
}

I've started using Doctrine recently, so I think it's better somebody more expert take a look in that.

[DC-282] Memory Leak in Doctrine_Query_Abstract._getDqlCallbackComponents()

Tue, 24 Nov 2009 19:41:30 +0000

The following iteration shows increasing memory usage:

 $manager = Doctrine_Manager::getInstance();
$manager->setAttribute(Doctrine::ATTR_USE_DQL_CALLBACKS, true);
$manager->....connection....

for($i=0; $i<10;$i++) {
  $tx = Doctrine_Query::create()
    ->from('Some_Entity cot')
    ->andWhere('cot.id = ?', $someid)
     ->fetchOne();
			
  $usage = memory_get_usage();
  echo $i.': '.$usage."\n";
}

This results in an exceed-max-memory-fatal (750 MB) with a more complex application i am running that iterates >20,000 times.
I found out that there is a memory leak in Doctrine_Query_Abstract._getDqlCallbackComponents():

...
$copy->getSqlQuery($params);
$componentsAfter = $copy->getQueryComponents();
$copy->free(); //This is the solution
...

Sincerly,
Markus

[DC-281] Generate Models Db changes case in Relationship definition.

Tue, 24 Nov 2009 20:46:02 +0000

Sorry - I'll start again.

So this is the scenario. generate-models-db or generate-yaml-db will not work for attachment: pascal-case-tables.sql but it does work with attachment: lowercase-underscore-tables.sql

The reason that this does not work is due to the builder incorrectly changing the case when you run generate-xxx-db on a database that has been generated with pascal case names (pascal-case-tables.sql).

This could be the reason the exception "Missing Class Name" is thrown when creating relationships due to the class that is physically generated according to the table name (for example BookingStatus). does not match the class name being searched for when creating relationships.

Create databases and run generate-models-db.

[DC-278] Invalid qubquery generated if using oracle adapter instead of pdo_oci

Wed, 9 Jun 2010 13:02:31 +0000

Doctrine generates the following invalid subquery if oracle adapter is used (same query is generated corret if pdo_oci is used):

SELECT DISTINCT "s2"."code"
FROM "spend_category" "s2"
INNER JOIN "company_spend_category" "c4" ON ("s2"."code" = "c4"."spendcategory_code")
INNER JOIN "company" "c3" ON "c3"."code" = "c4"."company_code"
WHERE "s2"."code" = '19000000'
AND "c3"."is_deleted" IS NOT NULL
AND "s2"."is_deleted" IS NOT NULL
ORDER BY "c3"."name" desc

The problem is that the order by column is not part of the selected columns.

Sample dql statement to reproduce this error:

$this->pageAllPager = new Doctrine_Pager(
$q = Doctrine_Query::create()
->select('c.code, c.name, c.is_activated, c.is_deleted, sc.code')
->from('SpendCategory sc')
->innerJoin('sc.Companies c')
->where("sc.code = '$spendcategory'")
->addWhere('c.is_deleted IS NOT NULL')
->addWhere('sc.is_deleted IS NOT NULL')
->orderBy($orderBy)
->setHydrationMode(Doctrine::HYDRATE_ARRAY),
$page,
$resultsPerPage);
}

[DC-275] Mysql Schema Manager does not correctly detect Decimal + bug fix from me

Wed, 25 Nov 2009 08:57:17 +0000

Mysql Schema Manager does not correctly detect Decimal. Lost decimal scale!

bug in file Doctrine/DataDict/Mysql.php

on line 263

 
        if (isset($field['length'])) {
            $length = $field['length'];
            $decimal = '';
        } else {
            $length = strtok('(), ');
            $decimal = strtok('(), ') ? strtok('(), '):null;    // <--- here strtok call 2 times! (line 263)
        }

must be like that

 
        if (isset($field['length'])) {
            $length = $field['length'];
            $decimal = '';
        } else {
            $length = strtok('(), ');
            $decimal = strtok('(), ');
            if ( ! $decimal ) { // or false === $decimal
                $decimal = null;
            }
        }

Please fix it

[DC-272] levelColumnName for nested sets is ignored

Tue, 24 Nov 2009 21:18:45 +0000

Option "levelColumnName" is used to set the name of the level column but the option is ignored

The following code needs to be added in __construct() of Doctrine_Tree_NestedSet

$options['levelColumnName'] = isset($options['levelColumnName']) ? $options['levelColumnName'] : false;

[DC-271] Doctrine_Record link many many

Tue, 24 Nov 2009 21:30:44 +0000

When saving the generated user form of sfGuardDoctrinePlugin 3.0.0 with a related many many object(s), such as groups or permissions, is/are selected, the script dies in Doctrine_Record line 2501 of R6780. Apparently public property access of the relation does not return a Doctrine_Collection object .

Doctrine_Record.php

 
    public function link($alias, $ids, $now = false)
    {
            //... some code
            foreach ($records as $record) {
                if ($this->$alias instanceof Doctrine_Record) {
                    $this->$alias = $record;
                } else {
                    $this->$alias->add($record); //fails here
                }
            }
            //... more code
    }

So I used this workaround as a temporary measure.

ProjectConfiguration.php

 
  public function setup()
  {
    $this->enablePlugins(
      'sfDoctrinePlugin', 
      'sfDoctrineGuardPlugin'
    );
    
    $this->dispatcher->connect('doctrine.filter_model_builder_options', array($this, 'doctrineFilterModelBuilderOptions'));    
  }
  
  public function doctrineFilterModelBuilderOptions(sfEvent $event, $options)
  {
  	$options['baseClassName'] = 'myDoctrineRecord';
  	
    return $options;
  }

Notice that I only changed the access from property access to array access.

myDoctrineRecord.php

 
    public function link($alias, $ids, $now = false)
    {
            //... some code
            foreach ($records as $record) {
                if ($this->$alias instanceof Doctrine_Record) {
                    $this->$alias = $record;
                } else {
                    $this[$alias]->add($record); //works for me
                }
            }
            //... more code
    }

[DC-233] Versionable behavior should specify relation alias

Tue, 24 Nov 2009 20:56:51 +0000

I18n behavior sets a nice name for the relation to the translation table, so why Versionable behavior doesn't do the same?

~~Proposed patch is not only repeats this behavior, but also allows the user to specify custom name for the relation.~~