Doctrine Project

[DBAL-207] RemoveNamespacedAssets: Foreign Key removing does not work correctly

Sun, 22 Jan 2012 17:36:23 +0000

RemoveNamespacedAssets: Foreign Key removing does not work correctly

[DBAL-261] MasterSlaveConnection fails to load ConnectionEventArgs

Sat, 5 May 2012 07:18:09 +0000

Incorrect class referenced at line 164 of Doctrine\DBAL\Connection\MasterSlaveConnection.php:

$eventArgs = new Event\ConnectionEventArgs($this);

Current namespace is Doctrine\DBAL\Connection so class loader fails when looking for Doctrine\DBAL\Connection\Event\ConnectionEventArgs

Work around is to add Doctrine\DBAL\Event\ConnectionEventArgs to use directive and change line to:

$eventArgs = new ConnectionEventArgs($this);

[DBAL-36] Database selection with DSN

Wed, 8 Sep 2010 07:31:09 +0000

When construstring DSN in Doctrine\DBAL\Driver\PDOSqlsrv\Driver it should add selection of database in DSN.

So for example DSN will look like:

$dsn ="sqlsrv:Server=(local) ; Database = AdventureWorks ";

As writen in chm manual which come with Sql server drivers for PHP v2

[DBAL-35] PDO_Sqlsrv bug in _constructPdoDsn()

Tue, 31 Aug 2010 17:51:58 +0000

When connection to mssql server with pdo_sqlsrv driver you get:

 
[PDOException]
SQLSTATE[IMSSP]: The DSN string ended unexpectedly.

Sample $connectionOptions:

$connectionOptions = array(
    'dbname' => 'AdventureWorks',
    'user' => 'sa',
    'password' => 'sa_password',
    'host' => 'local',
    'driver' => 'pdo_sqlsrv'
);

Error is in Doctrine\DBAL\Driver\PDOSqlsrv\Driver in function _constructPdoDsn(array $params).
On line 53 dsn starts with

$dsn = 'sqlsrv:(';

instead of

$dsn = 'sqlsrv:server=(';

as written in offical Microsoft help which come with SQL Server Driver For PHP v2.

[DBAL-496] "Undefined index" errors when using prepared statements

Sun, 21 Apr 2013 12:30:37 +0000

Since a few days we are seeing errors like this in the Jackalope Doctrine DBAL test suite when using prepared statements:
https://travis-ci.org/jackalope/jackalope-doctrine-dbal/jobs/6350278#L117

[DBAL-513] downloading from github

Sun, 12 May 2013 10:07:46 +0000

https://api.github.com/repos/doctrine/dbal/zipball/2.3.4:

500: Internal Server Error

[DBAL-522] BC break : executeQuery with an array containing null value(s).

Tue, 21 May 2013 05:58:01 +0000

Hello, i have got an error with doctrine 2.3.4 when i try to run the following code :

 
    $conn->executeQuery(
        'INSERT INTO FOO (foo, bar) values (:foo, :bar)', 
         array('foo' => 1, 'bar' => null)
     );

Error : Value for :bar not found in params array. Params array key should be "bar"

This code worked with doctrine 2.3.3.

I think the error comes from the function 'extractParam' in SQLParserUtils.php (DBAL)

line 215 : if (isset($paramsOrTypes[$paramName]))

The key exists even if the value is null.
So it should be:

  if (array_key_exists($paramName, $paramsOrTypes))

I am not enough confident to try a PR.
Thanks in advance!

[DBAL-54] Incorrect sequence dropping in PostgreSQL

Tue, 9 Oct 2012 14:55:47 +0000

Currently, DBAL drops the PostgreSQL sequences using the query:

DROP SEQUENCE sequencename

While it is quite correct at the first look, it fails, if the sequence is actually used by a table. Because Doctrine 2 ORM tries to drop the sequences before the tables, it makes impossible to drop a database schema in PostgreSQL due to the following exception:

$ php53 doctrine.php orm:schema-tool:drop
Dropping database schema...
PDOException
SQLSTATE[2BP01]: Dependent objects still exist: 7 ERROR: cannot drop sequence admins_id_seq because other objects depend on it
DETAIL: default for table admins column id depends on sequence admins_id_seq
HINT: Use DROP ... CASCADE to drop the dependent objects too.
/.../Libs/Doctrine/DBAL/Connection.php
Line 570
Trace:
0. PDO::query on line 570
1. Doctrine\DBAL\Connection::executeQuery on line 484
2. Doctrine\ORM\Tools\SchemaTool::dropSchema on line 78
3. Doctrine\ORM\Tools\Console\Command\SchemaTool\DropCommand::executeSchemaCommand on line 59
4. Doctrine\ORM\Tools\Console\Command\SchemaTool\AbstractCommand::execute on line 159
5. Symfony\Component\Console\Command\Command::run on line 205
6. Symfony\Component\Console\Application::doRun on line 117
7. Symfony\Component\Console\Application::run on line 7

A solution is simply to add the "CASCADE" keyword at the end of the query.

Although I encountered this problem on DBAL 2.0-beta4, I checked the most up-to-date code on Git, and the problem is still present there.

[DBAL-52] Schema tools will alter tables with custom column definitions forever

Wed, 15 Sep 2010 16:58:50 +0000

When using custom column definition, schema tool will execute the same update statements over and over. It looks like schema tool can't find out yet, if the custom column definition has already been applied.
As MySQL does full table rebuilds quite often (sometimes for no or at least debatable reasons), this makes the schema tool for large migrations quite hard to use in a production system deployment scenario.

[DBAL-44] nullable is not working for all datatypes

Mon, 30 Aug 2010 05:22:25 +0000

The nullable=true annotation is ignored from at least following Types:

SmallIntType
DecimalType
BooleanType (not sure if nullable makes sense here)

[DBAL-129] Doctrine\ORM\Mapping\ClassMetadataInfo does not properly handle identifier quoting

Fri, 17 Jun 2011 18:41:14 +0000

Several methods in Doctrine\ORM\Mapping\ClassMetadataInfo assume that table names and field names may be quoted. In all places, logic assumes that the quote character will always be ` (backtick). There seems to be no way to properly quote table names with [] (square brackets) when working with SQL Server databases.

[DBAL-114] MsSqlPlatform - getListTablesSQL() get's sysdiagrams table

Mon, 29 Aug 2011 20:12:21 +0000

getListTablesSQL() function in MsSqlPlatform.php list all tables in database.

If you have saved Database Diagrams it returns "sysdiagrams" table too.
This table have field "name" with type "sysname" which have no mapping.

If you run orm:validate-schema you get:
[Doctrine\DBAL\DBALException]
Unknown database type sysname requested, Doctrine\DBAL\Platforms\MsSqlPlatform may not support it.

Best solution is that when getting tables to ignore "sysdiagrams" tables.

[DBAL-111] MySQL Driver possibly subject to sql injections with PDO::quote()

Sat, 14 May 2011 07:24:48 +0000

Prior to 5.3.6, the MySQL PDO driver ignored the character set parameter to options. Due to MySQL's C api (and MySQLND), this is required for the proper function of mysql_real_escape_string() (the C API call). Since PDO uses the mres() C call for PDO::quote(), this means that the quoted string does not take into account the connection character set.

Starting with 5.3.6, that was fixed. So now if you pass the proper character set to PDO via driver options, sql injection is impossible while using the PDO::quote() api call.

PDO proof of concept

$dsn = 'mysql:dbname=INFORMATION_SCHEMA;host=127.0.0.1;charset=GBK;';
$pdo = new PDO($dsn, $user, $pass);
$pdo->exec('SET NAMES GBK');
$string = chr(0xbf) . chr(0x27) . ' OR 1 = 1; /*';
$sql = "SELECT TABLE_NAME
            FROM INFORMATION_SCHEMA.TABLES
            WHERE TABLE_NAME LIKE ".$pdo->quote($string)." LIMIT 1;";
$stmt = $pdo->query($sql);
var_dump($stmt->rowCount());

Expected Result: `int(0)`.
Actual Result: `int(1)`.

There are 2 issues to fix. First, the documentation does not indicate that you can pass the `charset` option to the MySQL Driver. This should be fixed so that users are given the proper option to set character sets.

Secondly, `Connection::setCharset()` should be modified for MySQL to throw an exception, since the character set is only safely setable using the DSN with PDO. This is a limitation of the driver and could be asked as a feature request for the PHP core. Either that, or a big warning should be put on the documentation of the API to indicate the unsafe character set change

[DBAL-80] Connection::_bindTypedValues() error when $types[0] is null

Sat, 1 Jan 2011 16:08:29 +0000

When $types[0] = null (default) then _bindTypedValues starts with the wrong offset and binds the wrong types against the wrong params.

[DBAL-168] orm:schema-tool:update will fail if if public scheme has a domains table (PostgreSQL)

Mon, 14 Nov 2011 19:12:41 +0000

If I create a table 'domains' in the default scheme and execute the update procedure of the schema tool, it will throw a PDOException (SQLSTATE[21000]: Cardinality violation: 7 ERROR: more than one row returned by a subquery used as an expression)

I've traced the error to the following statement, which is created by Doctrine\DBAL\Platforms\PostgreSqlPlatform->getListTableForeignKeysSQL():

SELECT r.conname, pg_catalog.pg_get_constraintdef(r.oid, true) as condef
                  FROM pg_catalog.pg_constraint r
                  WHERE r.conrelid =
                  (
                      SELECT c.oid
                      FROM pg_catalog.pg_class c, pg_catalog.pg_namespace n
                      WHERE c.relname = 'domains'
                        AND n.oid = c.relnamespace
                  )
                  AND r.contype = 'f'

This returns two oids because there are two relations with the name domains. One is my table and the other is a view in the information_scheme scheme.

The same problem should occur with the other information_scheme relations.

[DBAL-434] Incorrect type mapping on Oracle Platform

Sun, 17 Feb 2013 13:55:08 +0000

Hello,

I'm noticed a strange behaviour when I executed a migration for my Oracle database. Doctrine detects changes on all date columns, generating queries like:

ALTER TABLE the_table MODIFY (the_date DATE DEFAULT NULL);

even if the entity property was not modified. Check in out the Doctrine 2 source code I've detected that Doctrine map the DATE Oracle columns as datetime type, but entity date property are mapped as date (as it should be), so Doctrine believes that entity property and column type are different and generate the alter query.

I found the problem on the method Doctrine\DBAL\Platforms\OraclePlatform::initializeDoctrineTypeMappings, when it say 'date' => 'datetime' should say 'date' => 'date', that fix the migration problem and does not break my application.

Was a typo?

Thanks!

[DBAL-244] Shema Tool is not working after DBAL-177 for postgresql (mysql working like before)

Sat, 5 May 2012 08:01:06 +0000

After trying to upgrade 2.2.0 i found that schema tool wasn't working, so I switched back to 2.1.6, same thing with 2.2.1 and no bug report, so this is wats going on.

./doctrine orm:schema-tool:update --dump-sql # this will show full create table for schema even if tables are all ready there.

After git bisectin Doctrine ORM project i found that commit ea5108ea0f35fc0f7ed3a740995a590926045c6e wast to blame, but that was only submodule update so made bisect for Doctrine DBAL:

537de7ea6a34edbcc40bc6ca92e0a3f816b59330 .. 4410e4cec20b0f1f209578320e5b7d111e90c2a0 founding that 1ae87bf3e3ba93cb579a2a092b06b5a09b316542 was the problem.

[margus@laptop doctrine-dbal ((4410e4c...))]$ git reset --hard 1ae87bf3e3ba93cb579a2a092b06b5a09b316542
HEAD is now at 1ae87bf ~~DBAL-177~~ - Make sure schema.table syntax is supported in Assets for quoted assets
[margus@laptop doctrine-dbal ((1ae87bf...))]$ git submodule update --recursive
Submodule path 'lib/vendor/doctrine-common': checked out 'd6e4c8b22af9800db4fd9d679ce98538da028168'

1. shema tool printing full schema

[margus@laptop doctrine-dbal ((1ae87bf...))]$ git reset --hard HEAD^1
HEAD is now at bb84496 ~~DBAL-144~~ - Dont throw exception when no primary key exists
[margus@laptop doctrine-dbal ((bb84496...))]$ git submodule update --recursive

1. works fine

[margus@laptop build (master)]$ ./doctrine orm:schema-tool:update --dump-sql
Nothing to update - your database is already in sync with the current entity metadata.

with commit 1ae87bf3e3ba93cb579a2a092b06b5a09b316542 schema starts with 3 NULL lines, and then schema, with 2.2.0, extra "NULL" lines aren't there anymore.

Using MySQL there isn't any problem, but with PostgreSQL (i have 8.4.11) this issue appears.

[DBAL-228] OCI8Statement' fetchAll method can not do with PDO::FETCH_BOTH

Wed, 14 Mar 2012 21:32:46 +0000

/**

{@inheritdoc}
*/

private static $fetchStyleMap = array(
PDO::FETCH_BOTH => OCI_BOTH,
PDO::FETCH_ASSOC => OCI_ASSOC,
PDO::FETCH_NUM => OCI_NUM
);

public function fetchAll($fetchStyle = PDO::FETCH_BOTH)
{
if ( ! isset(self::$fetchStyleMap[$fetchStyle]))

{ throw new \InvalidArgumentException("Invalid fetch style: " . $fetchStyle); }

$result = array();
oci_fetch_all($this->_sth, $result, 0, -1,
self::$fetchStyleMap[$fetchStyle] | OCI_RETURN_NULLS | OCI_FETCHSTATEMENT_BY_ROW | OCI_RETURN_LOBS);

return $result;
}

oci_fetch_all method　can only surport

OCI_NUM
OCI_ASSOC

in $fetchStyleMap, OCI_BOTH is included!!!!

[DBAL-50] PgSQL driver does not create indexes on foreign key columns

Sat, 11 Sep 2010 19:14:48 +0000

The PostgreSQL database does not create indexes for foreign key columns, the user has to create them by hand. I think that indexes for foreign keys should be created automatically... On my system, an index will not be created automatically for the group_id column in the user table.

/**
 * @Entity
 */
class User {
    /**
     * @ManyToOne(targetEntity="Group", inversedBy="users")
     */
    protected $group;
}

/**
 * @Entity
 */
class Group {
    /**
     * @OneToMany(targetEntity="User", mappedBy="group")
     */
    protected $users;

    public function __construct() {
        $this->users = new \Doctrine\Common\Collections\ArrayCollection();
    }
}

I am using current git clone and PgSQL 8.4.

[DBAL-65] No way to store binary data in PostgreSQL with Doctrine

Tue, 9 Oct 2012 14:51:55 +0000

The type system introduced by Doctrine makes impossible to store binary data in PostgreSQL databases that use Unicode. The `text` type is mapped to `TEXT`, but any trial to place some binary data there ends up with a database error, like this:

SQLSTATE[22021]: Character not in repertoire: 7 ERROR: invalid byte sequence for encoding "UTF8": 0x9c

This is a critical limitation, because Doctrine cannot be used now in projects that for any reasons have to use PostgreSQL, and their databases must store binary data. Even if it cannot be fixed right now, it should be clearly pointed out in the documentation in "Known vendor issues".

A possible solution for this problem is creating an equivalent of 'text' field, called 'binary' or something like that. It must be a simple type that is mapped to the simplest, but large type available in the database engine without any form of data structure validation. For PostgreSQL, this could be 'blob', but other database engines can use different types.

[DBAL-64] Fix identifier quoting in DBAL Schema

Thu, 18 Nov 2010 03:28:37 +0000

Identifier quoting using the Schema component is sort of borked.

The optional or none approach from ClassMetadata should be looked at. Introducing a common quoting identifier `` and sanitizing this from each asset + a new method "getQuotedName()" that optionally quotes the identifier given the platform.

[DBAL-63] Custom Types always detected as changed when orm:schema-tool:update

Tue, 16 Nov 2010 05:10:31 +0000

I defined a custom type for DBAL and used it in an entity annotation. Every time I call doctrine orm:schema-tool:update, even when no changes are been made to the code, DBAL thinks the schema has changed and needs an update. The type declaration is done in cli-config.php, when creating the EntityManager.

See the code and output below:

Project/CustomType.php

namespace Project;

use \Doctrine\DBAL\Platforms\AbstractPlatform,
    \Doctrine\DBAL\Types\Type;

class CustomType extends Type
{
    const TYPE = 'custom';

    public function getSqlDeclaration(array $fieldDeclaration,
                                      AbstractPlatform $platform)
    {
        return $platform->getVarcharTypeDeclarationSQL($fieldDeclaration);
    }

    public function getName()
    {
        return self::TYPE;
    }
}

Project/Entity.php

/**
 * @entity
 */
namespace Project;
class Entity
{
    /**
     * @id
     * @column(type="integer")
     */
    private $id;

    /**
     * @column(type="custom")
     */
    private $custom;
}

cli-config.php

$cache = new \Doctrine\Common\Cache\ApcCache;
$config = new \Doctrine\ORM\Configuration;
$config->setMetadataCacheImpl($cache);
$config->setQueryCacheImpl($cache);

$driverImpl = $config->newDefaultAnnotationDriver(APPLICATION_PATH . '/Project');
$config->setMetadataDriverImpl($driverImpl);

$config->setProxyDir(APPLICATION_PATH . '/Proxies');
$config->setProxyNamespace('Proxies');
$config->setAutoGenerateProxyClasses(true);

$connectionOptions = array(
    'driver'   => 'pdo_mysql',
    'dbname'   => 'project',
    'user'     => '#user#',
    'password' => '#password#',
    'host'     => 'localhost',
);

\Doctrine\DBAL\Types\Type::addType('custom', 'Project\CustomType');
$em = \Doctrine\ORM\EntityManager::create($connectionOptions, $config);

$helperSet = new \Symfony\Component\Console\Helper\HelperSet(array(
    'db' => new \Doctrine\DBAL\Tools\Console\Helper\ConnectionHelper($em->getConnection()),
    'em' => new Doctrine\ORM\Tools\Console\Helper\EntityManagerHelper($em),
));

Console Output

#:~ doctrine orm:schema-tool:create --dump-sql
CREATE TABLE Entity (id INT NOT NULL, custom VARCHAR(255) NOT NULL, PRIMARY KEY(id)) ENGINE = InnoDB

#:~ doctrine orm:schema-tool:create
Creating database schema...
Database schema created successfully!

#:~ doctrine orm:schema-tool:update --dump-sql
ALTER TABLE Entity CHANGE custom custom VARCHAR(255) NOT NULL

#:~ doctrine orm:schema-tool:update --force
Updating database schema...
Database schema updated successfully!

#:~ doctrine orm:schema-tool:update --dump-sql
ALTER TABLE Entity CHANGE custom custom VARCHAR(255) NOT NULL

[DBAL-62] Length of a string column cannot exceed 255

Sat, 27 Nov 2010 13:04:41 +0000

I use the annotation mapping:
here's my mapping informations:

/** 
* @var mixed optionValue
* @orm:Column(nullable="true", name="option_value", length="2000", type="string") 
*/
protected $optionValue;

when i check the mysql column type it's still "varchar(255)".

[DBAL-61] Incompatible transactions in OCI8 driver with other drivers (pdo_oci, pdo_mysql, pdo_pgsql)

Thu, 11 Nov 2010 14:35:49 +0000

When I try to insert some data, it is not saved into database.

$connectionOptions['oci8'] = array(
    'driver' => 'oci8',
    'dbname' => 'BOOK',
    'user' => 'doctrine',
    'password' => 'doctrine',
//    'charset' => 'AL32UTF8',
);

$em = EntityManager::create($connectionOptions['oci8'], $config, $evm);
$conn = $em->getConnection();
$conn->connect();
$conn->insert('my_table', array('my_column' => 'Some value'));

When I invoke the previous code on any other DBAL driver, like pdo_oci, pdo_mysql, pdo_pgsql, the row is inserted.

That's because Oracle is transactional, and everything need to be commited. This behavior prevent's me (and I think in a feature not only me), to use 3rd party code (bundles, models, plugins...) in my applications running oracle. This behavior prevents developers to write portable code with DBAL. The solution is to make OCI8Driver commit everything after invoking oci_execute(), the same way how Doctrine_Adapter_Oracle works in Doctrine1. (https://github.com/doctrine/doctrine1/blob/master/lib/Doctrine/Adapter/Oracle.php)

[DBAL-60] OCI8Connection couldn't connect when charset parameter specified

Sat, 29 Dec 2012 17:43:09 +0000

When I am trying to connect to Oracle instance with another charset then specified in my environment variable NLS_LANG I got an error.

$connectionOptions['oracle'] = array(
    'driver' => 'oci8',
    'dbname' => 'BOOK',
    'user' => 'doctrine',
    'password' => 'doctrine',
    'charset' => 'AL32UTF8',
);

$em = EntityManager::create($connectionOptions['oracle'], $config, $evm);
$em->getConnection()->connect();

Produce error messages:

PHP Warning: oci_error() expects parameter 1 to be resource, boolean given in /www/test/doctrine2/vendor/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php on line 149
PHP Fatal error: Uncaught exception 'Doctrine\DBAL\Driver\OCI8\OCI8Exception' in /www/test/doctrine2/vendor/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php:42

There is bug in OCI8Connection::errorInfo() and ::errorCode(). When oci_connect failed, it returns a boolean - false. but oci_error() accepts only resource as parameter. Therefor it is neccessary to check, whether $this->_dbh is resource.

When I've fixed the error handling, I've got the right error, why I couldn't connect to Oracle:

PHP Fatal error: Uncaught exception 'Doctrine\DBAL\Driver\OCI8\OCI8Exception' with message 'ORA-12154: TNS:could not resolve the connect identifier specified' in /www/test/doctrine2/vendor/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Exception.php:28

That's because oci_connect accepts as connection string only TNS name, or Oracle Connection string. But ;charset=* in TNS name or connection string is invalid. oci_connect has 4th parameter charset for that purpose.

[DBAL-56] Ship a compatibility wrapper like MDB2

Sat, 5 Mar 2011 16:19:21 +0000

Database Portability is expensive but often necessary. We should support the important Compatibility Layer Options that MDB2 has:

http://pear.php.net/manual/en/package.database.mdb2.intro-portability.php

The following I think are doable:

Empty to Nulls
Change Case of Field-Assocs
Oracle RTRIM for Chars
Num Rows "hack" for Oracle
Delete Count (Some vendors rewrite a DELETE tablename into a TRUNCATE and dont report the delete count)

There should be a class extending "Doctrine\DBAL\Connection" making use of the 'wrapperClass' option. Two new classes are necessary:

Doctrine\DBAL\Portability\Connection
Doctrine\DBAL\Portability\Statement

[DBAL-55] Nested transaction emulation doesn't support rollback inside a nested transaction

Fri, 1 Oct 2010 17:56:44 +0000

It seems like beginTransaction() counts transaction nesting levels, but it doesnt set a savepoint when starting a new nesting level, nor does it therefore support rollbacks when rolling back inside a nested transaction. This means that I could call rollback() and it doesnt actually do anything, which imho is a bug.

The feature of using savepoints to emulate nested transactions properly seems to be present in Doctrine1.

[DBAL-53] Missing convertToDatabase-calls when loading and persisting entities

Duplicate — Wed, 15 Sep 2010 17:01:25 +0000

As we use binary encoded UUIDs as primary keys, we sometimes stumbled upon the issue of having incorrect SQL queries executed with unencoded database values. Currently we observed the wrong behavior for the following scenarios:

Deleting entities
OneToOne relations
OneToMany relations

I'm pretty sure this bug also exists for OneToMany relations, but we haven't used them yet.

[DBAL-49] PDOSqlsrv's constructor breaks when using non "local" server host

Thu, 23 Sep 2010 15:43:29 +0000

Problem:

Currently, the _constructPdoDsn() for the PDOSqlsrv driver works fine only if the host provided is: local or localhost.
If using an IP address, this breaks. Reason is because _constructPdoDsn() applies ( and ) around the host.

        $dsn = 'sqlsrv:server=(';
        if (isset($params['host'])) {
            $dsn .= $params['host'];
        }
        $dsn .= ')';

This is fine for when $params['host'] = 'local'; because I believe local is a name pipe (I think) and to properly use it you need to add the brackets around it

However if $params['host'] = '127.0.0.1'; this breaks!

Fix:

Get rid of the forced brackets

        $dsn = 'sqlsrv:server=';
        if (isset($params['host'])) {
            $dsn .= $params['host'];
        }

That way, when supplying local as a host, you have to enter (local) (which makes more sense as that's how you would do it normally in other applications).

[DBAL-47] Incorrect filename -- EchoSqlLogger.php

Thu, 2 Sep 2010 16:17:25 +0000

I've got error:
require(/var/www/betportal/dev.betportal.org/application/libraries/Doctrine/DBAL/Logging/EchoSqlLogger.php) [function.require]: failed to open stream: No such file or directory

Doctrine/DBAL/Logging/EchoSQLLogger.php should be renamed to EchoSqlLogger.php.

[DBAL-46] Fix doctrine-dbal console command

Thu, 2 Sep 2010 16:13:17 +0000

It still uses Symfony\Components with S.

[DBAL-45] Add CLI tool that checks for Reserved Keywords

Reference — Sun, 27 Feb 2011 03:45:40 +0000

Add a CLI tool that checks for reserved keywords in your current schema (for other databases vendors) to support cross vendor portability.

[DBAL-51] "No identifier/primary key specified for Entity" problem, Doctrine Beta 3 cannot find primary key

Sat, 27 Nov 2010 12:40:23 +0000

when execute

php doctrine.php orm:convert-mapping --from-database annotation "Entities"

get error message

No identifier/primary key specified for Entity 'Classname(Tablename)'. Every Entity must have an identifier/primary key.

For resolving this problem
I've replaced the line

public function loadMetadataForClass($className, ClassMetadataInfo $metadata)
{
...
$indexes = $this->tables[$tableName]->getIndexes();
...
}

in function "loadMetadataForClass" in \\Doctrine\ORM\Mapping\Driver\DatabaseDriver.php by

public function loadMetadataForClass($className, ClassMetadataInfo $metadata)
{
...
$indexes = $this->_sm->listTableIndexes($tableName);
...
}

then the beta 3 works for my date base

It is because doctrine look for $indexes['prime'] to construit the primary key in entities. when we use "$this->tables[$tableName]~~>getIndexes()", the keys in $indexes are the real name of indexes of the data base, and in my database, the primary key indexes are named PK_TABLENAME. So I have to use $this~~>_sm->listTableIndexes($tableName) to pre-edit the indexes before get the list

[DBAL-137] Setting empty host in PostgreSQL prevents connection to socket

Sun, 24 Jul 2011 10:47:23 +0000

Reported on https://github.com/symfony/symfony/issues/1788#issuecomment-1640104

[DBAL-136] OCI8 Driver MUST support connections by SERVICE_NAME

Duplicate — Thu, 18 Aug 2011 20:48:51 +0000

The existing oci8 driver connection only supports connections from database name configuraton.
It will be very good if is possible set a connection by service name.

Take a look in this DSN:

(DESCRIPTION= (ADDRESS= (PROTOCOL=TCP) (HOST=192.168.0.1) (PORT=1521) ) (CONNECT_DATA= (SERVICE_NAME=TH01) ) )

More info:
http://stackoverflow.com/questions/43866/how-sid-is-different-from-service-name-in-oracle-tnsnames-ora

[DBAL-135] Index::overrules() does not detect pks overruling unique indexes

Sun, 26 Jun 2011 16:35:26 +0000

Index::overrules() does not detect pks overruling unique indexes

[DBAL-134] Doctrine\DBAL\Connection::query() no logging

Tue, 28 Jun 2011 20:47:37 +0000

Doctrine\DBAL\Connection::query() does not use SqlLogger.

I guess it may be fixed like this:

    public function query()
    {
        $this->connect();

        $args = func_get_args();

        $logger = $this->getConfiguration()->getSQLLogger();
        if ($logger) {
            $logger->startQuery($args[0]);
        }

        $statement = call_user_func_array(array($this->_conn, 'query'), $args);

        if ($logger) {
            $logger->stopQuery();
        }

        return $statement;
    }

[DBAL-132] wrong mysql dump generation for foreign keys

Sun, 31 Jul 2011 12:10:53 +0000

Problem in methods Doctrine\DBAL\Platforms\AbstractPlatform::getDropForeignKeySQL() and Doctrine\DBAL\Platforms\AbstractPlatform::getCreateForeignKeySQL()

This methods do not receive FK name and don't put it in sql dump. While executing dump, mysql autogenerate FK names, but at the migration generation moment doctrine knowns nothing about them.

I think, doctrine must generate this names and put it into the schema.

Autogenerated migrations in mysql with fk are unusable.

Doctrine migrations:migrate in current doctrine version:
up:
ALTER TABLE Catalog_Field ADD CONSTRAINT FOREIGN KEY (groupId) REFERENCES Catalog_FieldGroup(id)
down:
ALTER TABLE Catalog_Field DROP FOREIGN KEY

should be:
up:
ALTER TABLE Catalog_Field ADD CONSTRAINT Catalog_Field_ibfk_2 FOREIGN KEY (groupId) REFERENCES Catalog_FieldGroup(id)
down:
ALTER TABLE Catalog_Field DROP FOREIGN KEY catalog_Field_ibfk_2

see: https://github.com/doctrine/migrations/issues/32

https://github.com/doctrine/migrations/issues/35

[DBAL-130] Add tests for modify limit query functionality

Fri, 17 Jun 2011 21:20:28 +0000

Add tests for modify limit query functionality

[DBAL-128] Additional types are not registered in the platforms when creating a connection

Thu, 16 Jun 2011 20:20:31 +0000

New types have to be registered in the platforms using registerDoctrineMappingType but the driver does not call this for type that are registered using Type::addType
This issue has been reported by some Symfony user here https://github.com/symfony/symfony/issues/1349 but the bug is indeed in DBAL.

Btw, this also affects the master branch but this project does not allow to select it (the ORM project does)

[DBAL-126] schema-tool creates primary keys as unique constraints

Sun, 26 Jun 2011 11:22:54 +0000

The schema tool calls AbstractPlatform::getCreateIndexSQL() to create new indexes. When the index is primary, this creates a unique key instead.

[DBAL-120] MySql platform getAlterTableSQL does not quote existing column names

Duplicate — Sun, 19 Jun 2011 09:46:39 +0000

When creating alter table SQL, the MySqlPlatform class does not quote names for columns of an existing table when building a CHANGE query. This can cause SQL errors.

It creates queries like this:

ALTER TABLE my_table CHANGE key `key` INTVARCHAR(255) DEFAULT '' NOT NULL';

Attached is a patch to fix this.

As an aside, is this the best way to contribute a patch? Or is a GitHub pull request better?

[DBAL-119] Outdated Console component

Sat, 14 May 2011 06:26:41 +0000

The DBAL submodule uses an outdated version of the Console component (before the switch to private properties). But the Migrations project defines its command using the latest interface which means that it cannot be used with the DBAL out-of-the-box as it calls the getApplication method which does not exist in the old version of the component.

[DBAL-118] When speaking about security do not rely on default link in mysql_* function calls

Sat, 14 May 2011 06:20:30 +0000

The documentation about escaping reads:

"Consider the previous query, now parameterized to fetch only a single article by id. Using ext/mysql (still the primary choice of MySQL access for many developers) you had to escape every value passed into the query using mysql_real_escape_string() to avoid SQL injection:

<?php
$sql = "SELECT * FROM articles WHERE id = '" . mysql_real_escape_string($id) . "'";
$rs = mysql_query($sql);",
http://www.doctrine-project.org/docs/dbal/2.0/en/reference/data-retrieval-and-manipulation.html

Please, do not rely on MySQL default links when discussing security issues. One of major differences between the mysql and the later mysqli extension is that mysqli forces users to explicitly specify a connection handle. There is no concept of default links and magical global connection handles in mysqli any more. The convenience of not having to specify a connection handle has been removed from mysqli. This was done to increase security, for example, when escaping strings. Escaping needs to take the current charset of the connection into account. Thus, it is recommended to explicitly specify the connection and so not use default connection.

"string mysql_real_escape_string ( string $unescaped_string [, resource $link_identifier ] )",
http://de.php.net/mysql_real_escape_string

Please, change the example:

<?php
$sql = "SELECT * FROM articles WHERE id = '" . mysql_real_escape_string($id, $link) . "'";
$rs = mysql_query($sql);",

($link added)

Thanks!

[DBAL-115] SchemaManager doesn't quote table names for MySQL

Sun, 19 Jun 2011 09:47:01 +0000

Using a reserved word as a table name only works for schema creation not dropping.

Example Enity:
/**

@Entity
@Table(name="`call`")
*/

class Call {
/**

@Column(name="id", type="integer", nullable=false)
@Id
@GeneratedValue(strategy="IDENTITY")
@var integer $id
*/
private $id;
}

The table name is quoted. creation works, dropping doesn't even after changing the table name to a not reserved word.

[DBAL-112] Sequence alteration does not alter.

Sun, 19 Jun 2011 09:33:42 +0000

When the schema diff decides there are differences between the existing SEQUENCE and the "new" one it alters the SEQUENCE by a DROP and then a CREATE.

The CREATE is done with the fromSchema as a base which results in a no-changed SEQUENCE.

Line 102 in Doctrine/DBAL/Schema/Comparator.php uses fromSchema but shuld have been using toSchema or just $sequence

This will fix the immediate issue but still require the sequence name being the same.

[DBAL-110] No way to get platform specific values from old schema to schema create sql

Wed, 13 Apr 2011 13:12:48 +0000

Even if I create custom types to support non-default types in Mysql (enum,set) I cant get the values from the schema manager to the type object due to encapsulation:

type declaration
<?php
use Doctrine\DBAL\Types\Type;
use Doctrine\DBAL\Platforms\AbstractPlatform;

class EnumType extends Type
{
const MYTYPE = 'Enum'; /
public function getSqlDeclaration(array $fieldDeclaration, AbstractPlatform $platform)

{ return "ENUM(HERE IS THE PROBLEM)"; }

public function getName()

{ return self::MYTYPE; }

}
?>

db connection construction:
<?php
//...

\Doctrine\DBAL\Types\Type::addType('enum', 'CustomTypes\EnumType');
$conn->getDatabasePlatform()->registerDoctrineTypeMapping('enum', 'enum');

There is no way to create even an extension to better support mysql databases, and since its a pretty commonly used rdbms this issue lowers the value of Doctrine2 for mysql (since you get errors by going by the reference guide).

[DBAL-121] Mapping, decimal returns float.

Sat, 14 May 2011 10:23:46 +0000

I have a Doctrine 2 entity and the value is mapped like this (with regular getter/setter):

 
/**
 * @Column(type="decimal", precision=40, scale=30)
 */
protected $someValue;

/**
 * @return decimal
 */
public function getSomeValue()
{
    return $this->someValue;
}

/**
 * @param decimal $someValue
 */
public function setSomeValue($someValue)
{
    $this->someValue = $someValue;
}

When I set that value from my code, the value gets written into the database correctly. But, and that is my problem, when I get the value (via getter or \Doctrine\Common\Util\Debug::dump()), it always gives me a number with maximum 14 digits, and it rounds the value. I read the record with the default findById().

eg: with value 1234567890.012345678901234567890123456789 I have 1234567890.0123
eg: with value 890.0123456789012345678901234567890123456 I have 890.01234567890

I of course want all digits, not just 14. The field in MySQL is declared like this:

 
    someValue decimal(40,30) NOT NULL,

When I get the value with raw PHP and mysql_query(), it returns correctly.

It seems like the problem is that Doctrine returns a float: ["someValue":protected]=> float(234567890.01235)

What's wrong, what should I check next, how to fix, any clues?
(also posted on http://stackoverflow.com/questions/5635500/doctrine-2-decimal-can-only-contain-14-digits)

[DBAL-107] Graphviz Schema Visitor

Thu, 7 Apr 2011 17:32:45 +0000

We should include a Graphviz Schema Visitor.

Features:

Display Tables and Columns
Highlight Primary Keys
Connect tables through foreign keys

[DBAL-92] Timezones of DateTime instances are ignored when persisting dates

Sat, 26 Feb 2011 10:18:59 +0000

When a DateTime instance, e.g. "2011-02-16 00:00:00 America/New_York" is written into the DB, the timezone is ignored and only "2011-02-16" is persisted. When fetching the date, it is written into a DateTime with the server's timezone, resulting in for example "2011-02-16 00:00:00 Europe/Berlin" which is not correct!

To fix this issue, Doctrine should convert dates to the server's timezone (if their own timezone differs) before persisting them or before executing queries containing DateTime instances.

[DBAL-88] MySqlPlatform not escaping table names

Duplicate — Sat, 26 Feb 2011 15:56:34 +0000

Methods in the MySql Platform that use the table name are not escaping the table name. This causes problems when your table name is the same as a reserved word in MySql. Example:

public function getListTableConstraintsSQL($table)

{ return 'SHOW INDEX FROM ' . $table; }

If my table name is User this method will fail and cause a SQL error because the word User is a reserved word in MySql. You need to escape the table name with backticks to prevent these errors. Example:

public function getListTableConstraintsSQL($table)

{ return 'SHOW INDEX FROM `' . $table . '`'; }

I encountered this problem while reverse engineering my existing MySql database. I've attached a fixed version that solved my reverse engineering problems.

[DBAL-89] MySqlPlatform does not handle enum and set data types

Thu, 10 Feb 2011 17:45:05 +0000

If you do a reverse engineer of an existing database that includes enum and set columns the reverse engineer will fail. Ideally there could be a separate Doctrine type for these fields, but at a minimum it seems they should be treated as string values. I solved my reverse engineering problem by modifying the initializeDoctrineTypeMappings in the MySqlPlatform.php file (attached):

protected function initializeDoctrineTypeMappings()

{ $this->doctrineTypeMapping = array( 'tinyint' => 'boolean', 'smallint' => 'smallint', 'mediumint' => 'integer', 'int' => 'integer', 'integer' => 'integer', 'bigint' => 'bigint', 'tinytext' => 'text', 'mediumtext' => 'text', 'longtext' => 'text', 'text' => 'text', 'varchar' => 'string', 'string' => 'string', 'char' => 'string', 'date' => 'date', 'datetime' => 'datetime', 'timestamp' => 'datetime', 'time' => 'time', 'float' => 'float', 'double' => 'float', 'real' => 'float', 'decimal' => 'decimal', 'numeric' => 'decimal', 'year' => 'date', 'enum' => 'string', 'set' => 'string', ); }

[DBAL-85] Illegal quotes in SHOW FULL TABLES WHERE Table_type = "BASE TABLE"

Duplicate — Fri, 11 Feb 2011 16:34:15 +0000

When trying to generate update SQL on MySQL running in ANSI SQL mode you get the error:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'BASE TABLE' in 'where clause'

This is caused by the use of identifier quotes (") instead of literal quotes (') in the query
SHOW FULL TABLES WHERE Table_type = "BASE TABLE"

This is in MySqlPlatform#getListTablesSQL()

[DBAL-84] Long string fields are being silently changed to 255 characters in the schema

Sun, 20 Feb 2011 17:13:00 +0000

I have an entity like this:

/**
 * @orm:Entity
 */
class Product
{
    /**
     * @orm:Id
     * @orm:Column(name="Merchant",type="string",length=50)
     */
    protected $merchant;

    /**
     * @orm:Column(name="Name",type="string",length=500)
     */
    protected $name;
}

When I change the length of $name field to 4000 it updates the schema like it is supposed to:

php.exe -f console doctrine:schema:update --dump-sql
ALTER TABLE product CHANGE Name Name VARCHAR(4000) NOT NULL

But when I change the length to 5000 it just silently without any warning uses value 255 instead:

php.exe -f console doctrine:schema:update --dump-sql
ALTER TABLE product CHANGE Name Name VARCHAR(255) NOT NULL

I had to look into actual table definition using mysql browser to find this issue because doctrine doesn't even warn about it. This could lead to some pretty serious bugs!

[DBAL-83] BigInt Type is returning string instead of integer

Sat, 14 May 2011 07:26:50 +0000

I ran all tests with PostgreSQL and I got an error:

1) Doctrine\Tests\DBAL\Functional\TypeConversionTest::testIdempotentDataConversion with data set #3 ('bigint', 12345678, 'string')
The expected type from the conversion to and back from the database should be string
Failed asserting that <integer:12345678> is of type "string".

/usr/share/php/Doctrine2/dbal/tests/Doctrine/Tests/DBAL/Functional/TypeConversionTest.php:84

FAILURES!
Tests: 367, Assertions: 745, Failures: 1, Skipped: 8.

The BigInt Type is missing convertToPHPValue() method and returns string instead of int. I fixed this and also I fixed the test case for this. Patch will be availabe via github pull request.

[DBAL-82] orderBy(), setFirstResult() bug with MSSQL Server

Sun, 31 Jul 2011 10:20:54 +0000

QueryBuilder

		$query = $this->createQueryBuilder('account')
					  ->select('account')
					  ->orderBy('account.id', 'DESC')
					  ->getQuery();

                $result = $query->setMaxResults($this->resultsPerPage+1)
        							->setFirstResult($this->offset)
        							->getResult();

The above, when using "setFirstResult" and "orderBy" (like that), results in an error like so:

SQLSTATE[42000]: [Microsoft][SQL Server Native Client 10.0][SQL Server]The multi-part identifier "t0_.id" could not be bound.

With a statement that looks something like so:

WITH outer_tbl AS (SELECT ROW_NUMBER() OVER (ORDER BY t0_.id DESC) AS "doctrine_rownum",   ...

The reason the error is occurring is because you apparently need to use the "alias" (e.g, SELECT t0_.id AS id0) "id0" in the "ORDER BY" clause.

So query will run with no problems if t0_.id as id0

WITH outer_tbl AS (SELECT ROW_NUMBER() OVER (ORDER BY id0 DESC) AS "doctrine_rownum",   ...

It looks like this behavior might only occur with Microsoft SQL Server, but it is a bug.

---------------

If you go into:
Doctrine\DBAL\Platforms\MsSqlPlatform

Find:

$over = preg_replace('/\"[^,]*\".\"([^,]*)\"/i', '"inner_tbl"."$1"', $orderby);

Add before:

                    # Get Columns
                    $columns = array();
                    if(preg_match_all('/([a-zA-Z][0-9]+_\.[a-zA-Z0-9\-_]+)\sAS\s([a-zA-Z0-9\-\_]+)/', $query, $matched)) {
                        for($i=0; $i<count($matched[1]); ++$i)
                        {
                            $columns[$matched[1][$i]] = $matched[2][$i];
                        }
                    }
                    
                    # Replace columns with their alias in the "orderby" statement
                    if(preg_match_all('/([a-zA-Z][0-9]+_\.[a-zA-Z0-9\-_]+)\s/i', $orderby, $matches)) {
                        foreach($matches[1] as $column) 
                        {
                            $orderby = preg_replace('/'.$column.'/', $columns[$column], $orderby);
                        }
                    }

Obviously this is a really ugly hack, but this resolves it.

[DBAL-91] orm:convert-mapping SchemaException on Postgres reserved words

Duplicate — Sat, 12 Feb 2011 14:39:41 +0000

While execuiting

doctrine orm:convert-mapping --from-database yml /tmp/test.yml

I get presented an error

[Doctrine\DBAL\Schema\SchemaException]
Invalid index-name tablename_"input"_idx given, has to be [a-zA-Z0-9_]

The index "type" is quoted because this is a reserved word in Postgres. for example see the following definition:

FOREIGN KEY (something) REFERENCES somethings(id) ON UPDATE CASCADE
FOREIGN KEY (another) REFERENCES anothers(id) ON UPDATE CASCADE
FOREIGN KEY ("type") REFERENCES logtypes(id) ON UPDATE CASCADE

Only type will be quoted because it is a reserved word.

[DBAL-79] Add Schema\Table::hasPrimaryKey method

Sat, 26 Feb 2011 16:11:38 +0000

Currently the name of the primary key is internal to the Table instance so there is no way to check if the table has a primary key without getting all the indexes and iterating over them.

[DBAL-78] Native support for parameter lists

Sat, 5 Mar 2011 10:51:22 +0000

Prerequisites:

1. Detection of this mode has to be super-fast. It should not have an auto-detection but should be triggered explicitly.
2. This mode cannot be supported after $conn->prepare(). It is only viable for $conn->executeQuery() or $conn->executeUpdate().

Case 1: Positional

$stmt = $conn->executeQuery("SELECT a.id FROM articles a WHERE a.id IN (?) AND a.foo = ?",
    array($paramList, $foo), array( Connection::PARAM_ARRAY => PDO::PARAM_INT) , PDO:PARAM_STR ),
    Connection::FLAG_EXPAND_ARRAYS
);

Would internally, right before execution, be rewritten to:

$c = count($paramList); // 3!
"SELECT a.id FROM articles a WHERE a.id IN (?, ?, ?) AND a.foo = ?"

Case 2: Named

$stmt = $conn->executeQuery("SELECT a.id FROM articles a WHERE a.id IN (:id) AND a.foo = :bar",
    array('id' => $paramList, 'bar' => $foo),
    array( array(Connection::PARAM_ARRAY => PDO::PARAM_INT), PDO::PARAM_STR ),
    Connection::FLAG_EXPAND_ARRAYS
);

Would internally, right before execution, be rewritten to:

$c = count($paramList); // 3!
"SELECT a.id FROM articles a WHERE a.id IN (:id1, :id2, :id3) AND a.foo = :bar"

[DBAL-74] OracleSchemaManager - incorrectly detected the length of the string columns

Sun, 12 Dec 2010 06:54:32 +0000

When I create a VARCHAR2 column with the length specified in char units (VARCHAR2(10 CHAR)) instead of the default byte, the metadata stored in all_tab_columns -> data_length is not 10, but 40. It is better to use char_length instead of data_length. Char_length is the same wheter the size unit is in CHAR or BYTE.

It is neccessary for me to use CHAR instead of the default BYTE, because I am using unicode charset.

[DBAL-73] Could not convert database value "b:0;" to Doctrine Type object

Sun, 12 Dec 2010 07:00:54 +0000

The following class when value is set to false causes "Could not convert database value "b:0;" to Doctrine Type object" exception when loading the entity.

/** @orm:Entity */
class MyClass
{
/**

@orm:Column(name="value", type="object")
*/
public $value;
}

[DBAL-72] doctrine entities generation has a bug for OneToMany setter type

Sun, 12 Dec 2010 06:54:06 +0000

http://trac.symfony-project.org/ticket/9272

assuming i've this model :

class TaskList

{ /** *@Id *@Column(type="integer") *@GeneratedValue(strategy="AUTO") */ private $id; /** *@Column(type="string", length="255") */ protected $name; /** *@OneToMany(targetEntity="Task", mappedBy="TaskList") */ protected $Tasks; }

AND

class Task{

/**
*@Id
*@Column(type="integer")
*@GeneratedValue?(strategy="AUTO")
*/
protected $id;

/**
*@Column(type="string", length="255")
*@Validation(

{ @NotBlank }

)
*/
protected $name;

/**
*@Column(type="boolean")
*/
protected $done = false;

/**
*@ManyToOne(targetEntity="TaskList", inversedBy="Tasks")
*@JoinColumn(name="task_list_id", referencedColumnName="id")
*/
protected $TaskList;

}

in symfony2

the ./console doctrine:generate:entities will create a setter in each class :

public function setTaskList(\TaskList $taskList) {
$this->TaskList = $taskList;
}

AND

public function addTasks(\Task $tasks) {
$this->Tasks[] = $tasks;
}

the " \ " before the setter function's parameter type is wrong here we should have

public function setTaskList(TaskList $taskList) {
$this->TaskList = $taskList;
}

AND

public function addTasks(Task $tasks) {
$this->Tasks[] = $tasks;
}

this lead ./console doctrine:generate:proxies to throw a hardly understandable error:

[ReflectionException]
Class Bundle\ToDoListBundle\Entity\TaskList does not exist

if you typed

/**
*@OneToMany?(targetEntity="\Bundle\myBundle\Entity\Task", mappedBy="TaskList?")
*/

the doctrine:generate:entities do not create this problem.
(my apologizes for inacurrate english)

[DBAL-70] MySql Platform is missing FloatType mappings

Sun, 12 Dec 2010 06:55:09 +0000

All other platforms are mapping double precission columns to the FloatType type. MySql not...

https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php

[DBAL-67] OCI8: schema-tool:update is modifying not null boolean - NUMBER(1) columns to not null

Mon, 29 Nov 2010 13:56:28 +0000

When I have a boolean column(s) in my entities and I want to update schema with schema tool, I get an exception:

My entity:

/** @Entity @Table(name='st_node') */
class Node
{
    /** @Id @Column(type="integer") @GeneratedValue */
    protected $id;
    
    /** @Column(type="string", length="255") */
    protected $title;
    
    /** @Column(type="boolean", nullable=false) */
    protected $is_published;
    
    /** @Column(type="boolean") */
    protected $is_sticky;
    
    /** @Column(type="integer", length=4) */
    protected $hits;
    
    /** @Column(type="decimal", precision=4, scale=2) */
    protected $score;
}

./doctrine orm:schema-tool:update --force
Entities\Address
Entities\Node
Entities\Article
Entities\User
Entities\Page
Updating database schema...

  [Doctrine\DBAL\Driver\OCI8\OCI8Exception]                         
  ORA-01442: column to be modified to NOT NULL is already NOT NULL

The same with --dump-sql option:

./doctrine orm:schema-tool:update --dump-sql
Entities\Address
Entities\Node
Entities\Article
Entities\User
Entities\Page
ALTER TABLE ST_NODE MODIFY (is_published  NUMBER(1) NOT NULL, is_sticky  NUMBER(1) NOT NULL)

The columns are already not nulls, but schema-tool can't recognize that.

This is the DQL of the table:

CREATE TABLE "DOCTRINE"."ST_NODE"
  (
    "ID"           NUMBER(10,0) NOT NULL ENABLE,
    "TITLE"        VARCHAR2(255 BYTE) NOT NULL ENABLE,
    "DISCR"        VARCHAR2(255 BYTE) NOT NULL ENABLE,
    "IS_PUBLISHED" NUMBER(1,0) NOT NULL ENABLE,
    "HITS"         NUMBER(10,0) NOT NULL ENABLE,
    "SCORE"        NUMBER(4,2) NOT NULL ENABLE,
    "IS_STICKY"    NUMBER(1,0) NOT NULL ENABLE,
    PRIMARY KEY ("ID")
);

[DBAL-177] Have Schema Assets handle "foo.bar" syntax correctly.

Wed, 16 Nov 2011 22:48:41 +0000

Have Schema Assets handle "foo.bar" syntax correctly.

[DBAL-176] DBAL logging doesnt work correctly with Prepared Statements

Sun, 30 Oct 2011 10:43:18 +0000

DBAL logging doesnt work correctly with Prepared Statements

[DBAL-173] PDO Exception 17 database schema has changed

Sun, 29 Jul 2012 07:47:14 +0000

in a script initializing a database (creating tables and inserting rows into) i have this exception :

PHP Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[HY000]: General error: 17 database schema has changed' in /home/mathieu/projects/no-pair/library/vendor/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php:618
Stack trace:
#0 /home/mathieu/projects/no-pair/library/vendor/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php(618): PDO->query('SELECT name FRO...')
#1 /home/mathieu/projects/no-pair/library/vendor/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php(571): Doctrine\DBAL\Connection->executeQuery('SELECT name FRO...', Array)
#2 /home/mathieu/projects/no-pair/library/vendor/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php(198): Doctrine\DBAL\Connection->fetchAll('SELECT name FRO...')
#3 /home/mathieu/projects/no-pair/library/vendor/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php(210): Doctrine\DBAL\Schema\AbstractSchemaManager->listTableNames()
#4 /home/mathieu/projects/no-pa in /home/mathieu/projects/no-pair/library/vendor/doctrine2/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php on line 618

it's working well with mysql or postgresql.

I don't think it's up to the developper using doctrine to take care of this probem.

As I understand it, when this error happend doctrine should "check for this error and re-execute the query as necessary." ( https://bugs.php.net/bug.php?id=43942 )

apparently it could also be solved in pdo_sqlite by using sqlite3_prepare_v2 instead of sqlite3_prepare. maybe I should fill a bug here too

I'll provide a script reproducing the problem asap
but I don't know if it's better to solve it in doctrine or in pdo-sqlite

[DBAL-174] Table without index

Mon, 9 Jan 2012 13:21:08 +0000

The /Doctrine/DBAL/Schema/AbstractSchemaManager->listTableIndexes() method returns SQL, that causes the following error:

PDOException: SQLSTATE[IMSSP]: The active result for the query contains no fields. in C:\wamp\www\pemtic2.0\lib\Doctrine\DBAL\Connection.php on line 571
Call Stack

Time Memory Function Location
1 0.0004 379552 {main}
( ) ..\postInstall.php:0
2 0.0297 3860720 Doctrine\ORM\Mapping\ClassMetadataFactory->getMetadataFor( ) ..\postInstall.php:25
3 0.0297 3860840 Doctrine\ORM\Mapping\ClassMetadataFactory->loadMetadata( ) ..\ClassMetadataFactory.php:177
4 0.0331 4270440 Doctrine\ORM\Mapping\Driver\DatabaseDriver->loadMetadataForClass( ) ..\ClassMetadataFactory.php:281
5 0.0331 4270552 Doctrine\ORM\Mapping\Driver\DatabaseDriver->reverseEngineerMappingFromDatabase( ) ..\DatabaseDriver.php:154
6 5.9540 5021400 Doctrine\DBAL\Schema\AbstractSchemaManager->listTableDetails( ) ..\DatabaseDriver.php:116
7 6.4029 5029072 Doctrine\DBAL\Schema\MsSqlSchemaManager->listTableIndexes( ) ..\AbstractSchemaManager.php:231
8 6.5440 5029360 Doctrine\DBAL\Connection->fetchAll( ) ..\MsSqlSchemaManager.php:182
9 6.6588 5031120 PDOStatement->fetchAll( ) ..\Connection.php:571

[DBAL-170] Add mysqli driver

Mon, 21 Nov 2011 23:11:41 +0000

Add a mysqli driver

[DBAL-172] QueryBuilder joins are omitted if the table alias is not present in the "from" clause

Sun, 30 Oct 2011 18:54:07 +0000

When using the QueryBuilder, joins that refer to table aliases from other joins get omitted. Only those joins that refer to table aliases from the "from" clause get included.

See http://stackoverflow.com/questions/7331117/doctrines-dbal-query-builder-omitts-some-joins

[DBAL-169] PostgreSQL Session init

Sat, 24 Sep 2011 11:53:25 +0000

During PostgreSQL Session init it may be interesting to set the search path to a different value than the default.

[DBAL-166] Table Encoding on generation table creation query

Sun, 1 Apr 2012 11:42:46 +0000

Can not set charset options for table creation.
Now I am fix thix problem in patch.
File: doctrine-dbal/lib/Doctrine/DBAL/Schema/Schema.php

#!/usr/bin/php
<?php
/**

Doctrine DBAL Patch
fix table creation query encode
(c) _Nicolay
*/
system ('cp ./vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/Schema.php ./vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/Schema.php.Orig');

$data = file_get_contents('./vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/Schema.php');
$data = str_replace("new Table(\$tableName);",
"new Table(\$tableName,array(),array(),array(),0,array('charset'=>'utf8','collate'=>'utf8_general_ci'));",
$data);
file_put_contents('./vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/Schema.php', $data);

[DBAL-164] Quoting allows SQL injections

Sun, 25 Sep 2011 19:07:47 +0000

$test = "foo ' bar";
$quoted = $conn->quote( $test );
echo $quoted;

RESULT: 'foo ' bar'
EXPECTED: 'foo \' bar'

[DBAL-171] PARAM_INT_ARRAY / PARAM_STR_ARRAY depends of parameter order

Fri, 18 Nov 2011 16:45:43 +0000

Named parameters appears to be treated as ordered parameters, when using PARAM_INT_ARRAY or PARAM_STR_ARRAY:

$query = $em->createQuery('
SELECT f FROM Foo f
WHERE a = :a
AND b IN (:b)
');

$query->setParameters(array(
    'b' => array(1,2,3),
    'a' => 1,
));

Notice that in the query the parameter :a appears before :b. And I call ->setParameters() with :b before :a.

When running this, I get an error from Doctrine/DBAL/SQLParserUtils::expandListParameters:119 saying that the second parameter of array_merge() is not an array.

When setting the parameters in the same order than they appear in the query, it works:

$query->setParameters(array(
    'a' => 1,
    'b' => array(1,2,3),
));

This is unexpected, as I'm using named parameters; the order should not matter.

[DBAL-161] Character Set of Database not UTF-8

Tue, 20 Nov 2012 06:33:33 +0000

Hi Guys,

I was working with symfony command line and created the database with the app/console doctrine:create:database

Though the characterset I specified was UTF-8 , it created Latin character set .

@elliot was right too, the create database is not using any character set https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php#L328

You can see the issue created at https://github.com/symfony/symfony/issues/2044 and later Fabien confirmed the bug is related to Doctrine .

I am not sure its a Bug or a feature I am asking .

Thanks

[DBAL-160] Github-PR-51 by jheth: OCI8Statement doesn't support first query parameter being null

Tue, 30 Aug 2011 18:15:07 +0000

This issue is created automatically through a Github pull request on behalf of jheth:

Url: https://github.com/doctrine/dbal/pull/51

Message:

Patch for OCI8Statement to support param[0] being null. Switched isset to array_key_exists. Added test that demonstrates the bug and confirms the fix.

[DBAL-158] Sqlite Platform doesn't set a proper mapping for "double precision" to act as float.

Sun, 30 Oct 2011 18:54:26 +0000

I have a column in an entity, defined as "float" type.
When I run my phpunit tests (which are defined to use sqlite, whereas my production and development environment uses mysql), I get the following exception:

Doctrine\DBAL\DBALException: Unknown database type double precision requested, Doctrine\DBAL\Platforms\SqlitePlatform may not support it

Looking at AbstractPlatform.php, line 1972, function "getFloatDeclarationSQL" returns 'DOUBLE PRECISION'.
Where other platforms have in their "initializeDoctrineTypeMappings" method a mapping such as:

'double precision' => 'float',

, SqlitePlatform.php doesn't have such a mapping.

[DBAL-152] Github-PR-49 by juokaz: Ignore sysdiagrams table from a list

Tue, 22 Nov 2011 23:14:48 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/dbal/pull/49

Message:

Fix for the http://www.doctrine-project.org/jira/browse/DBAL-114

[DBAL-151] Github-PR-50 by dteoh: Made custom Oracle NLS_DATE_FORMAT more compatible with Doctrine.

Tue, 22 Nov 2011 23:16:33 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/dbal/pull/50

Message:

[DBAL-148] Foreign key creation fails with MySQL 5.1.54

Thu, 18 Aug 2011 20:16:54 +0000

doctrine orm:schema-tool:create

returns

[PDOException]
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Position(id)' at line 1

The problem seem to be that the create commande creates the following SQL syntax
ALTER TABLE Job ADD FOREIGN KEY (position_id) REFERENCES Position(id);

which doesn't work. If I use the following (added a space between Postion and (id) in the end) it works.
ALTER TABLE Job ADD FOREIGN KEY (position_id) REFERENCES Position (id);

Patch for AbstractPlatform.php attached.

[DBAL-147] PostgreSqlSchemaManager fails to set foreign key onDelete/Update option properly if table has 'SET NULL' or 'SET DEFAULT' foreign key constraints

Sat, 27 Aug 2011 15:32:36 +0000

This table structure:
CREATE TABLE t1 (id INT NOT NULL, PRIMARY KEY(id));
CREATE TABLE t2 (id INT NOT NULL, fk_id INT DEFAULT NULL);
ALTER TABLE t2 ADD FOREIGN KEY (fk_id) REFERENCES t1(id) ON DELETE SET NULL NOT DEFERRABLE INITIALLY IMMEDIATE;

will cause the listTableForeignKeys to produce incorrect results for the onDelete/Update constraints (the 'DEFAULT' or 'NULL' in 'SET DEFAULT' or 'SET NULL' respectively gets cut off).

This looks to be fixed in the main branch.

[DBAL-146] Mssql platform TOP and DISTINCT ordering issue

Mon, 9 Jan 2012 13:30:27 +0000

When doing a limit and a distinct query, DBAL generates an SQL statement in the form of SELECT TOP X DISTINCT, which SqlSrv does not like at all. Simply moving the the DISTINCT back to the start fixes this issue.

As far as I can see this is caused by the preg_replace in doModifyLimitQuery. Attached is a patch that makes it slightly more aware. There may be other phrases to check for, but none that I've come across yet.

Patch attached.

[DBAL-142] Mapping Driver for Oracle does not know what to do with blobs, throws DBAL Exception for types "blob" and "long raw".

Duplicate — Tue, 13 Mar 2012 17:09:59 +0000

When attempting to reverse engineer an existing Oracle 11g database an exception is thrown (by DBAL) complaining that the type blob is unknown. I believe this is coming from AbstractPlatform.php. I attempted to solve the problem by add a type mapping for blob in PDOOracle\Driver.php (blob => text) and it now complains that "long raw" is unknown.

[Doctrine\DBAL\DBALException]
Unknown database type long raw requested, Doctrine\DBAL\Platforms\OraclePlatform may not support it.

[DBAL-141] PDO Connection Failure through TNS - PDOOracle/Driver.php line 56

Duplicate — Sun, 30 Oct 2011 19:21:45 +0000

On line 56 of the file ./vendor/doctrine-dbal/lib/Doctrine/DBAL/Driver/PDOOracle/Driver.php:

The line reads:
$dsn .= '))(CONNECT_DATA=(SID=' . $params['dbname'] . ')))'; should read $dsn .= '))(CONNECT_DATA=(SERVICE_NAME=' . $params['dbname'] . ')))';

If both SID and SERVICE_NAME need to be available for use, then logic should be inserted to determine which method is being used.

[DBAL-144] Oracle tables without indices are not handled during convert - this behavior should be tolerant since Oracle does not require indicies.

Mon, 14 Nov 2011 22:44:07 +0000

While it is good practice to always have at least one index defined on every table, in some cases (such as temporary tables) indices are not necessary. Oracle does not enforce creating indices for every table, and it is common to create some tables without them. The Table.php (line 556) method throws an exception if an index is not found for a given table. It's obvious there are ramifications for findByPK( ) auto-generated methods - these should be generated for every case where PK exists to accommodate Oracle and tolerate variances from accepted best-practices with most other database platforms.

[DBAL-140] Problem with null-length string comparison in Schema

Sun, 31 Jul 2011 11:54:32 +0000

If you compare a column with a string type and length of null to its database value with the default length then Comparator reports a difference. It should automatically convert NULL to 255 (default for all platforms).

[DBAL-138] Connection::quote should convert non PDO types

Sun, 31 Jul 2011 10:21:38 +0000

It currently doesn't so $connection->quote('foo', Type::STRING) doesn't work.

[DBAL-379] [GH-225] Fix SQLServerPlatform adds unique constraint to ADD PRIMARY KEY statement

Mon, 12 Nov 2012 10:41:39 +0000

This issue is created automatically through a Github pull request on behalf of CraigMason:

Url: https://github.com/doctrine/dbal/pull/225

Message:

Currently when executing an ALTER TABLE statement with SQL Server, the query will be:

This will happen when adding primary keys via ALTER TABLE.

`ALTER TABLE foo ADD PRIMARY KEY (id) WHERE id IS NOT NULL`

should be

`ALTER TABLE foo ADD PRIMARY KEY (id)`

[DBAL-380] [GH-226] Fix for decimal fields with precision.

Sun, 23 Dec 2012 19:50:31 +0000

This issue is created automatically through a Github pull request on behalf of bobdenotter:

Url: https://github.com/doctrine/dbal/pull/226

Message:

These fields have no spaces in the length, so the 'explode' fails. Omit the space from the code, and it works. Even if there were a space, it would still work, because of the `array_map("trim", ..)`.

arr(7)
[
"cid" => str(2) "11"
"name" => str(6) "nummer"
"type" => str(7) "DECIMAL"
"notnull" => str(1) "1"
"dflt_value" => str(1) "0"
"pk" => str(1) "0"
"length" => str(4) "18,9"
]

[DBAL-378] [GH-224] default table option not working

Fri, 9 Nov 2012 21:34:28 +0000

This issue is created automatically through a Github pull request on behalf of Steffen-99:

Url: https://github.com/doctrine/dbal/pull/224

Message:

Fixing issue, key name corrected

[DBAL-374] [GH-222] Escape primary field name in create table sql query

Tue, 13 Nov 2012 19:07:49 +0000

This issue is created automatically through a Github pull request on behalf of Genokilller:

Url: https://github.com/doctrine/dbal/pull/222

Message:

Fixes primary fields name in CreateTableSQL for Abstract Platform

[DBAL-370] [GH-220] Added support for alter table, foreign keys and autoincrement detection to Sqlite platform and schema

Wed, 2 Jan 2013 10:29:22 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/220

Message:

[DBAL-365] [GH-217] Remember to close temporary connection in PostgreSqlSchemaManager::dropD...

Fri, 12 Oct 2012 20:02:22 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/217

Message:

...atabase() and PostgreSqlSchemaManager::createDatabase()

Fixes my problem with not to be able to run all tests.

[DBAL-364] [GH-216] Fixed SQL placeholder parsing

Sat, 19 Jan 2013 18:26:56 +0000

This issue is created automatically through a Github pull request on behalf of a-nik:

Url: https://github.com/doctrine/dbal/pull/216

Message:

Fixed comment on 'getPlaceholderPositions' method
Fixed error on escaped quote mark inside an SQL expression

[DBAL-363] [GH-215] Remove unneeded use statement

Mon, 5 Nov 2012 22:49:34 +0000

This issue is created automatically through a Github pull request on behalf of jsjohns:

Url: https://github.com/doctrine/dbal/pull/215

Message:

[DBAL-366] [GH-218] [MySQL] Fixed bug with comments not adding quotes for tables

Sun, 6 Jan 2013 10:41:13 +0000

This issue is created automatically through a Github pull request on behalf of okovalov:

Url: https://github.com/doctrine/dbal/pull/218

Message:

Title describes everything... =)

[DBAL-359] [GH-211] Fix dropping foreign key multiple times with test

Fri, 5 Oct 2012 19:31:12 +0000

This issue is created automatically through a Github pull request on behalf of sdepablos:

Url: https://github.com/doctrine/dbal/pull/211

Message:

In some cases the Comparator class returns multiple drops for the same foreign key.
Specifically, in case you have two tables, A & B, with A having a foreign key FK
referencing B, if you drop table B, the resulting diff shows this FK twice,
once on the diff->orphanedForeignKeys array as we're deleting B, and another on
the diff->changedTables array as table A is also being modified. As a result of this you
get the DROP FOREIGN KEY instruction twice in the final SQL.

I'm not really sure if this change should be done in the Comparator clas or if it's better to
receive the full diff, even with duplicated drops for FK and later, when generating the final
SQL, drop the unnecessary ones

[DBAL-355] [GH-208] Optimize autoload prefix in composer.json

Fri, 5 Oct 2012 19:32:02 +0000

This issue is created automatically through a Github pull request on behalf of Slamdunk:

Url: https://github.com/doctrine/dbal/pull/208

Message:

By having more specific autoload prefixes it is possible to reduce the number of stat calls made.

[DBAL-354] [GH-207] Removed Unsigned Integer Support in SQL Server

Fri, 5 Oct 2012 19:33:53 +0000

This issue is created automatically through a Github pull request on behalf of datiecher:

Url: https://github.com/doctrine/dbal/pull/207

Message:

Removed unsigned integer test as SQL Server doesn't support unsigned integers.

[DBAL-351] [GH-206] Set minimum PHP version to 5.3.6

Fri, 5 Oct 2012 17:11:34 +0000

This issue is created automatically through a Github pull request on behalf of nicolas-grekas:

Url: https://github.com/doctrine/dbal/pull/206

Message:

Since ->setCharset() has been removed, minimum PHP version has to be raised to 5.3.6: the new way of doing charset, throught the DSN, works only after bug https://bugs.php.net/bug.php?id=47802 has been fixed.

[DBAL-349] [GH-203] Delete always content from table master_slave_table between tests.

Fri, 5 Oct 2012 20:22:18 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/203

Message:

Fixes that we are currently failing master slave tests.

[DBAL-350] [GH-205] Added exit code for dbal:reserved-words command

Fri, 5 Oct 2012 20:31:42 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/205

Message:

[DBAL-347] [GH-201] fix some phpdoc

Fri, 5 Oct 2012 20:27:21 +0000

This issue is created automatically through a Github pull request on behalf of KonstantinKuklin:

Url: https://github.com/doctrine/dbal/pull/201

Message:

[DBAL-346] Generated schema fails on MySQL (BLOB/TEXT cant have DEFAULT value)

Thu, 20 Sep 2012 17:29:30 +0000

In my symfony 2.1 project i was including JMSPaymentCoreBundle and did the vanilla installation.

After that i ran

php app/console doctrine:schema:update --dump-sql
php app/console doctrine:schema:update --force

A lot of schema updates were done. I ran it again, and two schema updates were still showing up.
Running the command again, and they still show up.

I then tried to run the two schema updates against my database and MySQL complains with the following error:

Error: 1101 - BLOB/TEXT column 'extended_data' can't have a default value

According to the Documentation BLOB/TEXT indeed cannot have default values. I am not sure why Doctrine thinks it has to set this default value.

The statements look like this:

sascha@debian:/var/www/myproject/Symfony$ php app/console doctrine:schema:update --dump-sql
ALTER TABLE payment_instructions CHANGE extended_data extended_data LONGTEXT NOT NULL COMMENT '(DC2Type:extended_payment_data)';
ALTER TABLE financial_transactions CHANGE extended_data extended_data LONGTEXT DEFAULT NULL COMMENT '(DC2Type:extended_payment_data)'

I already reported this problem in the JMSPaymentCoreBundle Issue Queue where i then was referred to over here.

Also, i am not sure if Doctrine DBAL is the best match for this issue, so if it is wrong please move it to the right project issue queue.

Thank you very much and best of Regards!
Sascha

[DBAL-343] [GH-199] fixed unquoted oldColumnName when changing column definition in MySQL

Thu, 25 Oct 2012 16:30:50 +0000

This issue is created automatically through a Github pull request on behalf of lutzportela:

Url: https://github.com/doctrine/dbal/pull/199

Message:

before:
```ALTER TABLE AlertCondition CHANGE fulltext `fulltext` VARCHAR(255) DEFAULT NULL``` failed.

after:
```ALTER TABLE AlertCondition CHANGE `fulltext` `fulltext` VARCHAR(255) DEFAULT NULL``` passes.

[DBAL-344] [GH-200] params not passed from execute to logger

Mon, 17 Sep 2012 09:36:44 +0000

This issue is created automatically through a Github pull request on behalf of robap:

Url: https://github.com/doctrine/dbal/pull/200

Message:

When parameters are passed to Doctrine\DBAL\Statement::execute, they are not passed to any enabled logger(s).

[DBAL-342] [GH-198] Change default MySQL table collation to utf8_unicode_ci

Mon, 12 Nov 2012 17:00:13 +0000

This issue is created automatically through a Github pull request on behalf of VladanStef:

Url: https://github.com/doctrine/dbal/pull/198

Message:

I think default table collation should be changed to `utf8_unicode_ci`, as it handles properly a much wider array of characters (Cyrillic, for example) at a generally negligible cost of performance.

`utf8_general_ci` simply does not work properly with too many languages and should be avoided as a default.

[DBAL-341] [GH-197] Bugfix for DDC-2013

Mon, 17 Sep 2012 10:26:33 +0000

This issue is created automatically through a Github pull request on behalf of naitsirch:

Url: https://github.com/doctrine/dbal/pull/197

Message:

Bugfix DDC-2013 - Default Session Value ".," for "NLS_NUMERIC_CHARACTERS". This is needed because Oracle uses other characters for decimal separation depending on the servers locale.

See http://www.doctrine-project.org/jira/browse/DDC-2013

[DBAL-340] [GH-196] Fixed mini-typo

Mon, 17 Sep 2012 10:35:54 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/dbal/pull/196

Message:

[DBAL-338] Typo in AbstractPlatform for GUID type declaration

Wed, 5 Sep 2012 16:44:44 +0000

has been fixed in 3f5fda98299acdcda9965e8e797cbcd0490f0dcc, however it's not merged into 2.3.

[DBAL-345] When inserting decimals into Oracle, getting ORA-01722: invalid number

Mon, 17 Sep 2012 10:23:27 +0000

When I insert decimals into database I get the following error message:

ORA-01722: invalid number

Oracle wants decimals (e.g. NUMBER(5,2)) separated by comma instead of a dot. I think the reason is that I use the german version of Windows. I tried to modify the following method of \Doctrine\DBAL\Driver\OCI8\OCI8Statement::bindValue() just for testing of course:

    public function bindValue($param, $value, $type = null)
    {
        if (is_float($value)) {
            $value = str_replace('.', ',', (string) $value); // <--
        }
        return $this->bindParam($param, $value, $type);
    }

With this modification I do not get the error anymore.
It would be great if a solution could be found. The strange thing is, if I query "SELECT * from nls_database_parameters where PARAMETER='NLS_NUMERIC_CHARACTERS'" I get ".," which means that a dot is already used as decimal separator. Maybe Oracle preferes the Locale of the OS?!
Maybe you could provide a setting which defines what separator should be used for decimals.

I found some Links that might be interesting regarding this issue:

[DBAL-337] Column types are truncated when mapping PostGIS types

Fri, 7 Sep 2012 15:33:20 +0000

When performing a doctrine schema update with Symfony2 ('php app/console doctrine:schema:update --force --verbose') using a custom PostGIS type mapping, column type descriptions are truncated.

How to reproduce:

1) add a custom 'point' type to Doctrine's type mapping

in a controller's boot method

$em = $this->container->get('doctrine.orm.default_entity_manager');
$conn = $em->getConnection();
if (!Type::hasType('point')) {
  Type::addType('point', 'Demo\GeoBundle\Lib\Type\PointType');
  $conn->getDatabasePlatform()->registerDoctrineTypeMapping('point', 'point');
}

PointType.php

<?php

namespace Demo\GeoBundle\Lib\Type;

use Demo\GeoBundle\Lib\Point;

use Doctrine\DBAL\Types\Type; 
use Doctrine\DBAL\Platforms\AbstractPlatform;

class PointType extends Type {

  const POINT = 'point';

  /**
   *
   * @param array $fieldDeclaration
   * @param AbstractPlatform $platform
   * @return string 
   */
  public function getSqlDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
  {
    return 'geography(POINT,'.Point::$SRID.')';
  }

  /**
   *
   * @param type $value
   * @param AbstractPlatform $platform
   * @return Point 
   */
  public function convertToPHPValue($value, AbstractPlatform $platform)
  {
    return Point::fromGeoJson($value);
  }

  public function getName()
  {
    return self::POINT;
    //return 'geography(POINT,'.Point::$SRID.')';
  }

  public function convertToDatabaseValue($value, AbstractPlatform $platform)
  {
    return $value->toWKT();
  }

  public function canRequireSQLConversion()
  {
    return true;
  }

  public function convertToPHPValueSQL($sqlExpr, $platform)
  {
    return 'ST_AsGeoJSON('.$sqlExpr.') ';
  }

  public function convertToDatabaseValueSQL($sqlExpr, AbstractPlatform $platform)
  {
    return $sqlExpr;
  }

}

?>

Point.php

<?php

namespace Demo\GeoBundle\Lib;

use Demo\GeoBundle\Lib\GeoException;

class Point {
  private $lat;
  private $lon;
  public static $SRID = '4326';

  private function __construct($lon, $lat) {
    $this->lat = $lat;
    $this->lon = $lon;
  }
  
  public function setLongitude($lon) {
    $this->lon = $lon;
  }
  
  public function getLongitude() {
    return $this->lon;
  }

  public function setLatitude($lat) {
    $this->lat = $lat;
  }

  public function getLatitude() {
    return $this->lat;
  }

  public function toGeoJson(){
    $array = array("type" => "Point", "coordinates" => array ($this->lon, $this->lat));
    return \json_encode($array);
  }

  /**
   *
   * @return string 
   */
  public function toWKT() {
    return 'SRID='.self::$SRID.';POINT('.$this->lon.' '.$this->lat.')';
  }

  /**
   *
   * @param string $geojson
   * @return Point 
   */
  public static function fromGeoJson($geojson) 
  {
    $a = json_decode($geojson);
    //check if the geojson string is correct
    if ($a == null or !isset($a->type) or !isset($a->coordinates)){
      throw GeoException::badJsonString();
    }

    if ($a->type != "Point"){
      throw GeoException::badGeoType();
    } else {
      $lon = $a->coordinates[0];
      $lat = $a->coordinates[1];
      return Point::fromLonLat($lon, $lat);
    }

  }
  
  /**
   *
   * @return string
   */
  public function __toString() {
    return $this->lon . ' ' . $this->lat;
  }

  /**
   *
   * @return array
   */
  public function toArray() {
    return array($this->lon, $this->lat);
  }

  public static function fromLonLat($lon, $lat)
  {
    if (($lon > -180.0 && $lon < 180.0) && ($lat > -90.0 && $lat < 90.0))
    {
      return new Point($lon, $lat);
    } else {
      throw GeoException::badCoordinates($lon, $lat);
    }
  }
}

?>

GeoException.php

<?php

namespace Demo\GeoBundle\Lib;

class GeoException extends \RuntimeException
{
    public function __construct($message = null, \Exception $previous = null, $code = 0)
    {
        parent::__construct($message, $code, $previous);
    }

    public static function badJSonString()
    {
      return new GeoException("Bad JSon string");
    }

    public static function badGeoType()
    {
      return new GeoException("Bad geo type");
    }

    public static function badCoordinates($lon, $lat)
    {
      return new GeoException("Bad coordinates: " . $lon . " " . $lat);
    }
}

2) with Symfony2, create a simple entity using the Point type:

TestPoint.php

<?php

namespace Demo\TestBundle\Entity;

use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Entity
 * @ORM\Table(name="test_points")
 */
class TestPoint
{
  /**
   * @ORM\Id
   * @ORM\Column(type="integer")
   * @ORM\GeneratedValue(strategy="AUTO")
   */
  protected $id;

  /**
   * @ORM\Column(type="point")
   */
  protected $coordinates;

  /**
   * Get id
   *
   * @return integer 
   */
  public function getId()
  {
    return $this->id;
  }

  /**
   * Set coordinates
   *
   * @param point $coordinates
   * @return Partner
   */
  public function setCoordinates($coordinates)
  {
    $this->coordinates = $coordinates;
    return $this;
  }

  /**
   * Get coordinates
   *
   * @return point 
   */
  public function getCoordinates()
  {
    return $this->coordinates;
  }
  
  public function setLongitude($lon)
  {
    if ($this->coordinates == null)
    {
      $this->coordinates = Point::fromLonLat($lon, 0);
    }
    else
    {
      $this->coordinates->setLongitude($lon);
    }
  }
  
  public function getLongitude()
  {
    return $this->coordinates == null ? 0 : $this->coordinates->getLongitude();
  }
  
  public function setLatitude($lat)
  {
    if ($this->coordinates == null)
    {
      $this->coordinates = Point::fromLonLat(0, $lat);
    }
    else
    {
      $this->coordinates->setLatitude($lat);
    }
  }
  
  public function getLatitude()
  {
    return $this->coordinates == null ? 0 : $this->coordinates->getLatitude();
  }
}

3) use the update script to create the table:

php app/console doctrine:schema:update --force --verbose

4) run it again to update:

php app/console doctrine:schema:update --force --verbose

Errors should ensue:

Errors

[Doctrine\DBAL\DBALException]
Unknown database type geography requested, Doctrine\DBAL\Platforms\PostgreSqlPlatform may not support it.

Exception trace:
() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php:261
Doctrine\DBAL\Platforms\AbstractPlatform->getDoctrineTypeMapping() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/PostgreSqlSchemaManager.php:285
Doctrine\DBAL\Schema\PostgreSqlSchemaManager->_getPortableTableColumnDefinition() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:672
Doctrine\DBAL\Schema\AbstractSchemaManager->_getPortableTableColumnList() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:159
Doctrine\DBAL\Schema\AbstractSchemaManager->listTableColumns() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:254
Doctrine\DBAL\Schema\AbstractSchemaManager->listTableDetails() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:242
Doctrine\DBAL\Schema\AbstractSchemaManager->listTables() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:830
Doctrine\DBAL\Schema\AbstractSchemaManager->createSchema() at /.../Symfony/vendor/doctrine/lib/Doctrine/ORM/Tools/SchemaTool.php:689
Doctrine\ORM\Tools\SchemaTool->getUpdateSchemaSql() at /.../Symfony/vendor/doctrine/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/UpdateCommand.php:103
Doctrine\ORM\Tools\Console\Command\SchemaTool\UpdateCommand->executeSchemaCommand() at /.../Symfony/vendor/doctrine/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/AbstractCommand.php:59
Doctrine\ORM\Tools\Console\Command\SchemaTool\AbstractCommand->execute() at /.../Symfony/vendor/symfony/src/Symfony/Bundle/DoctrineBundle/Command/Proxy/UpdateSchemaDoctrineCommand.php:62
Symfony\Bundle\DoctrineBundle\Command\Proxy\UpdateSchemaDoctrineCommand->execute() at /.../Symfony/vendor/symfony/src/Symfony/Component/Console/Command/Command.php:226
Symfony\Component\Console\Command\Command->run() at /.../Symfony/vendor/symfony/src/Symfony/Component/Console/Application.php:194
Symfony\Component\Console\Application->doRun() at /.../Symfony/vendor/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:76
Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /.../Symfony/vendor/symfony/src/Symfony/Component/Console/Application.php:118
Symfony\Component\Console\Application->run() at /.../Symfony/app/console:22

doctrine:schema:update [--complete] [--dump-sql] [--force] [--em[="..."]]

What seems to be happening is that the returned type for the column holding the points is truncated. "Full" type is 'geography(Point,4326)', returned type from Doctrine is 'geography' (missing the specifics).
Adding other custom mappings for PostGIS types, LineString for example, will result with the exact same error although the full type is 'geography(LineString,4326)'. The above test case would still be erroneous with the full type returned as the mapping specifies a 'dbType' known as 'point' or 'linestring' and not 'geography(Point,4326)' or 'geography(LineString,4326)', adjustments should be made there.

[DBAL-339] setFetchMode arguments exception

Wed, 5 Sep 2012 16:52:37 +0000

i have this error in version 2.3.0-RC1

in DBAL/STatement.php on aound line 191 you will find:

public function setFetchMode($fetchMode, $arg2 = null, $arg3 = null)

{ return $this->stmt->setFetchMode($fetchMode, $arg2, $arg3); }

the problem is that php throws me a Exception:
Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[HY000]: General error: fetch mode doesn't allow any extra arguments'

the reason for the exception is that setFetchMode doesnt support null as second/third argument.

somebody also described it in the php issue tracker:
https://bugs.php.net/bug.php?id=54545

[DBAL-336] [GH-195] Removed duplicate table check so that ManyToMany relationships can have two owning entities

Wed, 5 Sep 2012 16:53:34 +0000

This issue is created automatically through a Github pull request on behalf of intrepion:

Url: https://github.com/doctrine/dbal/pull/195

Message:

Whenever there is a ManyToMany relationship with both entities needing ownership, running doctrine:schema:update throws an exception due to a duplicate table definition when, in fact, it is the same table.

[DBAL-335] Is MasterSlaveConnection implemented correctly - seems to overwrite master connection on transaction methods?

Sat, 22 Sep 2012 23:46:31 +0000

Forgive me to doubt, but I think there may be a bug in MasterSlaveConnection.

It's easier to understand what I'm saying by debugging and tracing the flow, but I'll illustrate it with gists.

First, here is a simple service method to create a user. It opens up a transaction, persists the user, commits and returns. On error, if there is an active transaction, rollback. Here is the gist:

https://gist.github.com/3547674

The "$conn->beginTransaction();" line is where we trace through (the remainder of the service method is now irrelevant). Looking into MasterSlaveConnection.php, we see the method tries to connect to the master connection (call this point ###):

https://gist.github.com/3547720

Now looking in the next gist, we see what happens when "$this->connect('master');" is called. At this point it's not that interesting, the internal "$this->_conn" property is set to "master".

https://gist.github.com/3547750

Now here lies the bug I believe. "parent::beginTransaction();" is called. When looking into this method, we see that another call is made to connect but this time without "master" as the argument (i.e. connect to slave). This call to connect is made before incrementing the transaction nesting level.

https://gist.github.com/3547808

Now, I won't do another gist for "MasterSlaveConnection::connect", but if you refer to the file at line 13 https://gist.github.com/3547750#file_master_slave_connection.php, you will see that it checks the transaction nesting level and if it is there, forces master. However, we don't increment the level until after the method returns, so the slave is used. Ultimately, this results in the internal "$this->_conn" property set to the "slave" connection which violates our original action at ### above where we said we want to connect to "master".

Am I missing something here? Here is a gist the is a basic attempt at fixing this one method. It simply copies the code from the parent method except does not connect twice. I believe the same would have to occur for all the other methods unless it can be fixed once at the "MasterSlaveConnection::connect" level.

https://gist.github.com/3547880

I've just fleshed out "beginTransaction", "commit" and "rollBack" in "MasterSlaveConnection" by basically copying and pasting the code from the parent class and for my failing use case, this fixes the issue. However, it did require updating "Connection" slightly so that I had access to some private variables.

[DBAL-334] [GH-194] Small test fixes for PostgreSQL

Wed, 5 Sep 2012 17:25:22 +0000

This issue is created automatically through a Github pull request on behalf of posulliv:

Url: https://github.com/doctrine/dbal/pull/194

Message:

When running the test suite against a clean PostgreSQL install on a 64-bit system I hit 2 issues:

dropDatabase calls fail unless a database is manually created
TypeConversionTest::testIdempotentDataConversion fails expecting bigint type to be converted to a string. PostgreSQL seems to detect 32 vs 64 bit systems and casts correctly for bigint types.

This small patch allows the test suite to run successfully for me against clean MySQL & PostgreSQL installs.

[DBAL-329] [GH-190] Fix DDC-1978

Wed, 29 Aug 2012 09:36:59 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/dbal/pull/190

Message:

Fix ~~DDC-1978~~

http://www.doctrine-project.org/jira/browse/DDC-1978

[DBAL-331] [GH-192] ExpressionBuilder in and notIn methods

Wed, 29 Aug 2012 09:37:50 +0000

This issue is created automatically through a Github pull request on behalf of Xobb:

Url: https://github.com/doctrine/dbal/pull/192

Message:

ExpressionBuilder is missing *in* and *not in* methods to produce these statements.

[DBAL-326] [GH-187] Quote column names during insert, if necessary

Wed, 29 Aug 2012 09:03:15 +0000

This issue is created automatically through a Github pull request on behalf of dobesv:

Url: https://github.com/doctrine/dbal/pull/187

Message:

This fixes an issue I ran into where if I tried to insert something with a column name that required quoting, I would have to manually quote it myself.

[DBAL-323] [GH-185] Add schema changes for length for postgres

Sat, 6 Oct 2012 10:23:13 +0000

This issue is created automatically through a Github pull request on behalf of mvrhov:

Url: https://github.com/doctrine/dbal/pull/185

Message:

[DBAL-322] Change Detection fails when 'unsigned' is used in MySQL Schema

Tue, 14 Aug 2012 21:10:15 +0000

Change Detection fails when 'unsigned' is used in MySQL Schema

[DBAL-316] Incorrect parameter SERVICE_NAME

Sun, 10 Feb 2013 00:00:03 +0000

At line 63, the driver PDOOracle, the parameter SERVICE_NAME is receiving the value of 'dbname' and not 'service'.

Sorry, my English is bad!

[DBAL-315] [GH-182] Added a missing method in the Constraint interface

Tue, 14 Aug 2012 21:33:08 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/182

Message:

This adds a missing method in the Constraint interface. The method is already defined in AbstractAsset which is extended by both classes implementing the interface. the AbstractPlatform is calling this method on objects after checking they are implementing the interface. So either the method should be part of the interface, or all places using the interface as typehint should be refactored to check for the classes (examples can be found [here](https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php#L1029) and [there](https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php#L1254)).

Adding a method in an interface is technically a BC break but this method is not really a public extension point. what do you think @beberlei ?

[DBAL-317] [GH-183] Fix unsigned columns in MySql

Tue, 14 Aug 2012 21:21:05 +0000

This issue is created automatically through a Github pull request on behalf of acasademont:

Url: https://github.com/doctrine/dbal/pull/183

Message:

Unsigned column properties were never set. In consequence all migrations diff were trying to change the column definition when it was already changed. See symfony/symfony#3560

Would it be also nice to add some test to avoid regressions, but i don't know where it would be a nice place to put them.

[DBAL-314] [GH-180] Fixed some phpdoc

Tue, 14 Aug 2012 21:48:41 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/180

Message:

This fixes some phpdoc in the AbstractPlatform and in some child classes. I haven't checked all child classes to ensure that all phpdoc is right now, but the abstract one is now accurate (but a bunch of method are missing their phpdoc altogether)

[DBAL-311] [GH-179] Added missing type mappings for postgres

Tue, 14 Aug 2012 22:05:14 +0000

This issue is created automatically through a Github pull request on behalf of jkrems:

Url: https://github.com/doctrine/dbal/pull/179

Message:

We had problems running the migrations-commands with an existing database. Seems like some type-mappings are just missing. This patch fixed the problem for us.

[DBAL-227] Driver for PostgreSQL: DBAL fails to list foreign keys if multiple tables with the same name exist, each in a different schema

Mon, 5 Mar 2012 09:43:53 +0000

PHP Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[21000]: Cardinality violation: 7 ERROR: more than one row returned by a subquery used as an expression' in /usr/share/php/Doctrine/DBAL/Connection.php:620
Stack trace:
#0 /usr/share/php/Doctrine/DBAL/Connection.php(620): PDO->query('SELECT r.connam...')
#1 /usr/share/php/Doctrine/DBAL/Connection.php(571): Doctrine\DBAL\Connection->executeQuery('SELECT r.connam...', Array)
#2 /usr/share/php/Doctrine/DBAL/Schema/AbstractSchemaManager.php(262): Doctrine\DBAL\Connection->fetchAll('SELECT r.connam...')
#3 /usr/share/php/Doctrine/DBAL/Schema/AbstractSchemaManager.php(229): Doctrine\DBAL\Schema\AbstractSchemaManager->listTableForeignKeys('logs')
#4 /usr/share/php/Doctrine/DBAL/Schema/AbstractSchemaManager.php(214): Doctrine\DBAL\Schema\AbstractSchemaManager->listTableDetails('logs')
#5 /usr/share/php/Doctrine/DBAL/Schema/AbstractSchemaManager.php(764): Doctrine\DBAL\Schema\AbstractSchemaManager->listTables()
#6 /home/phopfgartner/devel/doctrine_tests/conn.php in /usr/share/php/Doctrine/DBAL/Connection.php on line 620

The failing SQL statement is:

SELECT r.conname, pg_catalog.pg_get_constraintdef(r.oid, true) as condef
FROM pg_catalog.pg_constraint r
WHERE r.conrelid =
(
SELECT c.oid
FROM pg_catalog.pg_class c, pg_catalog.pg_namespace n
WHERE n.nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND c.relname = 'logs' AND n.oid = c.relnamespace
)
AND r.contype = 'f'

Indeed, if I execute:

SELECT c.relname, n.nspname
FROM pg_catalog.pg_class c, pg_catalog.pg_namespace n
WHERE n.nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND c.relname = 'logs' AND n.oid = c.relnamespace

I get:

relname | nspname
===============
logs | sbr_stats
logs | public

Regards,

Peter

[DBAL-224] Allow drop index and pk from table instance

Mon, 13 Feb 2012 16:10:26 +0000

Allow drop index and pk from table instance

[DBAL-220] Some platforms require specific index handling

Tue, 29 Jan 2013 03:06:08 +0000

SQL Server/Azure for example requires strict differentiation between CLUSTERED/NON-CLUSTERED indexes.
MySQL can create full text indexes
etcetc.

[DBAL-223] Add DBAL TableGenerator

Dependency — Mon, 13 Feb 2012 14:11:35 +0000

/**
 * Table ID Generator for those poor languages that are missing sequences.
 *
 * WARNING: The Table Id Generator clones a second independent database
 * connection to work correctly. This means using the generator requests that
 * generate IDs will have two open database connections. This is necessary to
 * be safe from transaction failures in the main connection. Make sure to only
 * ever use one TableGenerator otherwise you end up with many connections.
 *
 * TableID Generator does not work with SQLite.
 *
 * The TableGenerator does not take care of creating the SQL Table itself. You
 * should look at the `TableGeneratorSchemaVisitor` to do this for you.
 * Otherwise the schema for a table looks like:
 *
 * CREATE sequences (
 *   sequence_name VARCHAR(255) NOT NULL,
 *   sequence_value INT NOT NULL DEFAULT '1',
 *   sequence_increment_by INT NOT NULL DEFAULT '1',
 *   PRIMARY KEY (table_name)
 * );
 *
 * Technically this generator works as follows:
 *
 * 1. Use a robust transaction serialization level.
 * 2. Open transaction
 * 3. Acquire a read lock on the table row (SELECT .. FOR UPDATE)
 * 4. Increment current value by one and write back to database
 * 5. Commit transaction
 *
 * If you are using a sequence_increment_by value that is larger than one the
 * ID Generator will keep incrementing values until it hits the incrementation
 * gap before issuing another query.
 *
 * If no row is present for a given sequence a new one will be created with the
 * default values 'value' = 1 and 'increment_by' = 1
 *
 * @author Benjamin Eberlei <kontakt@beberlei.de>
 */

[DBAL-222] Add Azure Platform

Mon, 13 Feb 2012 11:47:35 +0000

SQL Azure has some platform specific SQL on top of SQL Server 2008 mainly to support Federations

[DBAL-216] Add ext/sqlsrv support

Mon, 13 Feb 2012 11:21:40 +0000

Currently we only have support for PDO_SQLSRV, however some of the Azure/Advanced functionality strictly needs the sqlsrv extension.

[DBAL-237] schema:update fails when changing from ManyToOne to OneToOne

Wed, 14 Mar 2012 20:28:34 +0000

If a relation is changed from ManyToOne to OneToOne a Mysql exception 1025 is thrown because schema:update attempts to drop the indexes without first dropping the foreign keys. This seems to happen since the foreign keys are not deleted from the entity.. but the indexes change type (from index to unique).

Incorrect output from --dump-sql

DROP INDEX IDX_9AFB9A3755EB82D0 ON tapi_phone;
DROP INDEX IDX_9AFB9A37A6A12EC1 ON tapi_phone;
ALTER TABLE tapi_phone ADD location_id INT DEFAULT NULL, CHANGE extension extension VARCHAR(255) DEFAULT NULL, CHANGE protocol protocol VARCHAR(255) DEFAULT NULL;
ALTER TABLE tapi_phone ADD CONSTRAINT FK_9AFB9A3764D218E FOREIGN KEY (location_id) REFERENCES tapi_location(id);
CREATE UNIQUE INDEX UNIQ_9AFB9A37F85E0677 ON tapi_phone (username);
CREATE UNIQUE INDEX UNIQ_9AFB9A37B728E969 ON tapi_phone (mac_address);
CREATE UNIQUE INDEX UNIQ_9AFB9A3755EB82D0 ON tapi_phone (default_user_id);
CREATE INDEX IDX_9AFB9A3764D218E ON tapi_phone (location_id);
CREATE UNIQUE INDEX UNIQ_9AFB9A37A6A12EC1 ON tapi_phone (registered_user_id)

Expected output from --dump-sql

ALTER TABLE tapi_phone DROP FOREIGN KEY FK_9AFB9A3755EB82D0;
DROP INDEX IDX_9AFB9A3755EB82D0 ON tapi_phone;
ALTER TABLE tapi_phone DROP FOREIGN KEY FK_9AFB9A37A6A12EC1;
DROP INDEX IDX_9AFB9A37A6A12EC1 ON tapi_phone;
ALTER TABLE tapi_phone ADD location_id INT DEFAULT NULL, CHANGE extension extension VARCHAR(255) DEFAULT NULL, CHANGE protocol protocol VARCHAR(255) DEFAULT NULL;
ALTER TABLE tapi_phone ADD CONSTRAINT FK_9AFB9A3764D218E FOREIGN KEY (location_id) REFERENCES tapi_location(id);
ALTER TABLE tapi_phone ADD CONSTRAINT FK_9AFB9A3755EB82D0 FOREIGN KEY (default_user_id) REFERENCES tapi_user (id);
ALTER TABLE tapi_phone ADD CONSTRAINT FK_9AFB9A37A6A12EC1 FOREIGN KEY (registered_user_id) REFERENCES tapi_user (id);
CREATE UNIQUE INDEX UNIQ_9AFB9A37F85E0677 ON tapi_phone (username);
CREATE UNIQUE INDEX UNIQ_9AFB9A37B728E969 ON tapi_phone (mac_address);
CREATE UNIQUE INDEX UNIQ_9AFB9A3755EB82D0 ON tapi_phone (default_user_id);
CREATE INDEX IDX_9AFB9A3764D218E ON tapi_phone (location_id);
CREATE UNIQUE INDEX UNIQ_9AFB9A37A6A12EC1 ON tapi_phone (registered_user_id);

[DBAL-212] Unknown database type longvarchar requested, Doctrine\DBAL\Platforms\SqlitePlatform may not support it.

Sat, 28 Jan 2012 09:31:53 +0000

SqlitePlatform lacks "longvarchar" type mapping which is extensively used by browsers sqlite databases (e.g. places in FF, history in Chrome).
Trying to get a schema ends up with 'Unknown database type longvarchar requested, Doctrine\DBAL\Platforms\SqlitePlatform may not support it.' message.

[DBAL-213] Fatal Error on 2.2 when running SQLServer against ORM Testsuite

Sun, 29 Jan 2012 12:42:38 +0000

Fatal Error on 2.2 when running SQLServer against ORM Testsuite

[DBAL-211] wrong where clause in PostgreSqlPlatform::getTableWhereClause

Sat, 28 Jan 2012 09:55:23 +0000

I have the folowing table structure:

Schema "public": with one table called "users"
Schema "forums": with one table called "users"

methods like PostgreSqlPlatform::getListTableForeignKeysSQL($table, $database = '') should list FK inside $table

the default search path is "public,pg_catalog"

calling PostgreSqlPlatform::getListTableForeignKeysSQL('users') it shuld extract the FK from public.users table, but this is the current result:

[PDOException] SQLSTATE[21000]: Cardinality violation: 7 ERROR: more than one row returned by a subquery used as an expression

this exception is thrown because PostgreSqlPlatform::getTableWhereClause do not cosider the current search path.

i propose the following implementation for PostgreSqlPlatform::getTableWhereClause

 
    private function getTableWhereClause($table, $classAlias = 'c', $namespaceAlias = 'n')
    {
        $whereClause = $namespaceAlias.".nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND ";
        if (strpos($table, ".") !== false) {
            list($schema, $table) = explode(".", $table);
            $whereClause .= "$classAlias.relname = '" . $table . "' AND $namespaceAlias.nspname = '" . $schema . "'";
        } else {
            // $whereClause .= "$classAlias.relname = '" . $table . "'"; // this was the current implementation
            $whereClause .= "$classAlias.relname = '" . $table . "' AND $namespaceAlias.nspname = ANY(string_to_array((select setting from pg_catalog.pg_settings where name = 'search_path'),','))";
        }

        return $whereClause;
    }

this implementation will restrict the search range only to current "search_path".

(sorry for my english)

[DBAL-210] PDOOracle and OCI8 Drivers have a wrong implementation for their getDatabase function

Sat, 28 Jan 2012 09:58:05 +0000

The method getDatabase in both the PDOOracle & OCI8 drivers return the "user" param not the "dbname" as expected and defined in DBAL/Driver interface. Compare their implementation with that of the MySql driver for a proper implementation. This must have been an oversight.

[DBAL-208] Uniqueidentifier MSSQL type is not supported in DBAL

Sat, 24 Mar 2012 09:07:43 +0000

My Symfony2 projects currently use main trunks of the Doctrine projects, the latest release merge into this branch was 2.2.0-BETA2, that's why I mentioned it in"Affected versions". Sorry if mistaken.

I would like to report that MSSQL Driver/Platform still does not support the 'uniquidentifier' field type of MSSQL.

Trying to introspect the database with
php app/console doctrine:mapping:import MMPTestDBBundle annotation
we get the error

[Doctrine\DBAL\DBALException]
  Unknown database type uniqueidentifier requested, Doctrine\DBAL\Platforms\SQLServer2008Platform may not support it.

There is a related issue, opened and fixed in Doctrine1 project
http://www.doctrine-project.org/jira/browse/DC-253

Going to fix this issue in the same way. Any help greatly appreciated.

[DBAL-204] Handling of explicit Schemas is wrong in comparator

Sat, 21 Jan 2012 10:35:51 +0000

if you are on db "foo" and compare table "bar" to "foo.bar". it shouldnt drop one and create the other one. They are the same!

[DBAL-205] MySQL SchemaManager doesn't handle composite foreign keys properly

Sat, 21 Jan 2012 15:18:28 +0000

The MySQL SchemaManager can not properly generate a Schema from the database if a table has a foreign key that spans multiple columns.
Therefore the comparator tries to drop the one index as individual indexes.

That leads to an error if the resulting SQL is executed because these indexes do not exist (i.e. via app/console doctrine:schema:update --force)

symfony2#app/console doctrine:schema:update --dump-sql

...
ALTER TABLE table1 DROP FOREIGN KEY FK_C1B1712387FE737264DE5A5511B8B3E;
DROP INDEX IDX_C1B1712387FE7372 ON table1;
DROP INDEX IDX_C1B1712364DE5A5 ON table1;
DROP INDEX IDX_C1B17123511B8B3E ON table1;
ALTER TABLE table1 ADD CONSTRAINT FK_C1B1712387FE737264DE5A5511B8B3E FOREIGN KEY (column1, column2, column3) REFERENCES table2(column1, column2, column3);
...

[DBAL-202] Preparing Statements outside Transaction

Sat, 5 May 2012 07:37:54 +0000

From the mailing list:

I'm using DBAL 2.1 with Oracle and it appears that if I call prepare() for my SQL and cache the prepared statement for later, if I then start a new transaction and call execute() on the statement, it commits the transaction. Is this behavior intentional? If so, does that mean I have to prepare my statement anew for every transaction?

Note that I'm seeing the aforementioned behavior with code as basic as the following:

$stmt = $dbh->prepare("INSERT INTO test_table (id, description) VALUES
(:my_id, :my_desc)");
$dbh->beginTransaction();
$stmt->execute(array(":my_id" => 1, ":my_desc" => "test"));
$dbh->rollBack();

After executing the above, a record has been committed to the db. If I had a more complex scenario involving a transaction with multiple statements where the entire transaction is inside a loop, this becomes problematic--I can't then prepare my statements outside the loop to improve performance.

When I try the same thing using straight PDO, it works fine. Can anyone else confirm this behavior?

[DBAL-203] Fix SQLServer version mess (2003, 2005, 2008)

Sun, 15 Jan 2012 18:37:43 +0000

The current SqlSrv platform implicitly depends on SQL Server 2008. A differentation between the common versions 2003, 2005 and 2008 is necessary.

[DBAL-198] Custom platform is not taken into account

Mon, 9 Jan 2012 09:55:23 +0000

When defining a custom platform in the configuration of Symfony 2 like below :

config.yml

services:
    my_platform:
        class: Doctrine\DBAL\Platforms\MyPlatform

doctrine:
    dbal:
         options:
               platform: @my_platform

the custom platform MyPlatform is not taken into account and the driver default one is used instead.

[DBAL-196] The function fetchAll(PDO::FETCH_ALL, 'MyClass') doesn't create object of MyClass

Sat, 21 Jan 2012 14:44:19 +0000

The code below doesn't create objects of MyClass when it has to.
Instead it create StdClass objects

$stmt = $db->prepare($sql);
$stmt->execute();

$results = $stmt->fetchAll(
    \PDO::FETCH_CLASS,
    'MyClass'
);

The problem comes from the file Doctrine/DBAL/Statement.php

    /**
     * Returns an array containing all of the result set rows.
     * 
     * @param integer $fetchStyle
     * @param integer $columnIndex
     * @return array An array containing all of the remaining rows in the result set.
     */
    public function fetchAll($fetchStyle = PDO::FETCH_BOTH, $columnIndex = 0)
    {
	if ($columnIndex != 0) {
            return $this->_stmt->fetchAll($fetchStyle, $columnIndex);
        }
        return $this->_stmt->fetchAll($fetchStyle);
    }

The line

if ($columnIndex != 0) {

must be replace by

if ($columnIndex !== 0) {

because the parameter $columnIndex is not always an integer and could be a name of a class : see the example n°4 in php doc http://www.php.net/manual/en/pdostatement.fetchall.php

[DBAL-195] Method AbstractSchemaManager->dropAndCreateSequence() contains erroneous code.

Mon, 9 Jan 2012 07:57:39 +0000

I needed to use the function and looking at the code I found that it seemed partially implemented, cut and pasted from something else or just not ported from an earlier implementation. I'm now submitting a patch that fixes this issue. I didn't modify the AbstractSchemaManager->dropSequence($name) signature to become AbstractSchemaManager->dropSequence($sequence) but it might be a good idea to refactor it (guess that would be another issue though )

[DBAL-197] Cannot drop database schema with blob type

Mon, 9 Jan 2012 08:12:24 +0000

I have an entity with a blob type. When I create the database schema via cli, everthing is okay.
When i try to drop the schema, I receive the following error:
[Doctrine\DBAL\DBALException]
Unknown database type longblob requested, Doctrine\DBAL\Platforms\MySqlPlatform may not support it.

[DBAL-193] GH-87: Added a leading backslash to FQCN in @return and @param PHPDoc

Sat, 31 Dec 2011 10:27:02 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/87

PHPDoc should only contain FQCN with a leading backslash, imported classnames or relative classnames. Doctrine ORM is using this convention in the latest versions, so i updated the DBAL library.

[DBAL-194] BlobType should implement getBindingType()

Tue, 3 Jan 2012 22:03:56 +0000

BlobType should implement getBindingType() and return PDO::PARAM_LOB

Currently (2.2-BETA1) DBAL uses PDO::PARAM_STR and thus stores the data incorrectly.

Working patch is attached.

[DBAL-192] GH-86: Remove a type object if a type is overrided

Tue, 3 Jan 2012 22:04:08 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/86

[DBAL-191] GH-85: [WIP] Drizzle Support

Sat, 22 Sep 2012 14:35:03 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/85

Drizzle platform support
Driver is using pdo_mysql

All DBAL tests complete except PortabilityTest.

[DBAL-190] Column type comment SQL is missing during table creation

Tue, 3 Jan 2012 22:04:19 +0000

Column type comment is generated properly only with MySQL, and is not generated on platforms that support comment on column statements (Oracle, PgSQL).

[DBAL-189] Unable to use CHAR data type

Wed, 21 Dec 2011 09:25:48 +0000

In order to be able to use the CHAR data type, we used to be able to set the field type to string and fixed to true.
I've been struggling to achieve the same thing today, but failed.

It seems the functionality has been preserved on low level, but cannot be used from within the yml adapter. I haven't researched the whole thing as it would consume much time, but as far as my mini-research goes - the SchemaTool::_getDiscriminatorColumnDefinition() method should support the fixed parameter and pass it along with the other options (lenght, notnull, etc).

SchemaTool::_gatherColumn() lacks support for the fixed parameter as well.

Do you plan on getting this functionality back?

[DBAL-188] Make doctrine and sqlite friends

Sun, 18 Dec 2011 16:29:48 +0000

https://github.com/doctrine/dbal/pull/66

Schema processing for SQLite is broken in a number of common situations. These patches fix handling of the following:

String column defaults: For columns with a default value that is a string, SQLite returns them wrapped in single quotes. Doctrine does not strip these, so it would treat a value "foobar" as "'foobar'" (with single quotes as part of the value).
Auto-increment: SQLite handling of auto-increment is unusual. In particular, it supports it only on an integer column which is the sole primary key for a table. In addition, it will automatically increment values of an integer primary key column regardless of whether it has been defined as autoincrement BUT, unlike autoincrement, these values are not guaranteed to be unique.
Most problematically, there is no way (without parsing the "create" statements stored in sqlite_master) to determine whether a column is marked as auto-incrementing. Doctrine was treating SQLite integer primary keys as auto-incrementing, but this is not correct and does not work for composite primary keys.
Composite primary keys: As a side-effect of Doctrine treating integer primary keys in SQLite as auto-incrementing and of how SQLite requires autoincrement and primary keys to be declared, it would generate invalid create statements for composite keys in SQLite.
Special indexes: SQLite sometimes automatically generates indexes, which Doctrine treated the same as any other. Because they are internal, however, their names are reserved, so they could not be used to recreate the same index and, since they are automatic, they aren't actually a part of the defined schema.

I've added to the tests to catch these situations in the future as well.

[DBAL-187] GH-83: Added a LoggerChain

Thu, 15 Dec 2011 18:15:50 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/83

This logger allows registering several loggers in the connection

[DBAL-186] GH-82: Schema events

Mon, 19 Dec 2011 13:16:46 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/82

Trigger schema related events to allow custom create/drop/update queries.

[DBAL-185] GH-81: when using PDO on windows, the DSN required to get the driver working is...

Sat, 17 Dec 2011 11:26:41 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/81

... "mssql". Couldn't test it, but i think this will also work on *nix systems.

[DBAL-184] bigint binding problems in sqlite3

Sun, 11 Dec 2011 15:49:33 +0000

I created a @Column that was type "bigint" and when inserting very large numbers, they were getting capped in SQLite3 at 2147483647.

I switched Doctrine/DBAL/Types/BigIntType.php, line 46 from:

return \PDO::PARAM_INT;

to:

return \PDO::PARAM_STR;

and now it is storing the full numbers. I am unsure, however, whether this is the right change or will affect other database layers. Any thoughts?

Matt

[DBAL-199] MSSQL change column name

Wed, 14 Nov 2012 22:55:36 +0000

Hello,

to create a schema for mssql works ok, but to alter the name of a column, use the SQL command "CHANGE" and Mssql not recognize this command.
to alter the name of a column in MSSQL you should use the store procedure "sp_rename"

http://msdn.microsoft.com/en-us/library/ms188351.aspx

Do not know if I'm doing something the wrong way, but the command "php app \ console doctrine: schema: update" does not work by altering the name of the column

sorry my english it's very poor

[DBAL-181] [Oracle] RAW Type

Mon, 14 Nov 2011 20:24:01 +0000

Missing type raw from OraclePlatform::initializeDoctrineTypeMappings.

The Symfony2 task doctrine:schema:update throws Unknown database type raw requested, Doctrine\DBAL\Platforms\OraclePlatform may not support it..

The attached patch seems to fix it, but I don't know if something more to be done.

[DBAL-310] [GH-178] Pull Request

Tue, 18 Sep 2012 19:53:30 +0000

This issue is created automatically through a Github pull request on behalf of ardemiranda:

Url: https://github.com/doctrine/dbal/pull/178

Message:

Pull Request doctrine/dbal/master

[DBAL-309] MasterSlaveConnection with mysql "charset: "UTF8" forces use of master

Mon, 17 Sep 2012 10:48:27 +0000

In a mysql master/slave environment with "charset:" set to "UTF8" an Event "postConnect" is dispatched after establishing the connection.

MysqlSessionInit->postConnect() uses MasterSlaveConnection->executeUpdate() to submit this information to the current connection. executeUpdate() always connects to the master and the slaves won't be used (as documentated: "3. If master was picked once during the lifetime of the connection it will always get picked afterwards.").

We suggest to use executeQuery() in postConnect() instead.

[DBAL-307] [GH-173] Fixing breaking test provoke by #172

Sun, 29 Jul 2012 07:47:49 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/dbal/pull/173

Message:

[DBAL-306] [GH-172] Fixed typos

Sun, 29 Jul 2012 07:48:08 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/dbal/pull/172

Message:

[DBAL-304] Allow table comments

Thu, 12 Jul 2012 07:22:02 +0000

Implement support for table comments. Most drivers restrict the comments to 60 chars on tables and 255 on columns. Also export this support to ORM.
We already consume some chars for (DC2Type:<type_name>) on columns. Also we need to apply a check to not crash under these circunstances

[DBAL-302] [GH-168] DebugStack should ignore stopQuery when disabled

Tue, 10 Jul 2012 07:32:26 +0000

This issue is created automatically through a Github pull request on behalf of dpb587:

Url: https://github.com/doctrine/dbal/pull/168

Message:

I noticed that DebugStack was adding an empty element when it was disabled. This PR changes it to match startQuery with its behavior.

1) Doctrine\Tests\DBAL\Logging\DebugStackTest::testLoggedQueryDisabled
Failed asserting that two arrays are equal.
— Expected
+++ Actual
@@ @@
Array
(
+ [0] => Array
+ (
+ [executionMS] => 1341871660.9651
+ )
+
)

I've submitted the PR to 2.0.x since that's where the bug is first seen and is still listed as stable on doctrine-project.org. Preferably this could also be applied to newer branches as well, or I can also submit separate PRs.

[DBAL-303] [GH-170] [#DBAL-172] QueryBuilder joins are omitted if the table alias is not present in the "from" clause

Tue, 14 Aug 2012 22:06:06 +0000

This issue is created automatically through a Github pull request on behalf of wimvds:

Url: https://github.com/doctrine/dbal/pull/170

Message:

Apparently that fix has never been included, don't know why exactly. But there are use cases where you want to join multiple tables without selecting any data from the joined tables.

Ie. a query like this one :
SELECT COUNT(DISTINCT news.id) FROM cb_newspages news
INNER JOIN nodeversion nv ON nv.refId = news.id AND nv.refEntityname='Entity
News'
INNER JOIN nodetranslation nt ON nv.nodetranslation = nt.id
INNER JOIN node n ON nt.node = n.id
WHERE nt.lang = 'nl' AND n.deleted != 1

could be written with the querybuilder (using this patch) as follows :

$querybuilder->select('COUNT(DISTINCT news.id)')
->from('cb_newspages', 'news')
->innerJoin('news', 'nodeversion', 'nv', 'nv.refId = news.id AND nv.refEntityname=\'Entity\\\\News\'')
->innerJoin('nv', 'nodetranslation', 'nt', 'nv.nodetranslation = nt.id')
->innerJoin('nt', 'node', 'n', 'nt.node = n.id')
->where('nt.lang = :lang AND n.deleted != 1')
->setParameter('lang', $locale);

When you use an alias that isn't chained or used in a from clause it will still trigger a QueryException (as before).

ie.
$querybuilder->select('COUNT(DISTINCT news.id)')
->from('cb_newspages', 'news')
->innerJoin('news', 'nodeversion', 'nv', 'nv.refId = news.id AND nv.refEntityname=\'Entity\\\\News\'')
->innerJoin('invalid', 'nodetranslation', 'nt', 'nv.nodetranslation = nt.id')
->innerJoin('nt', 'node', 'n', 'nt.node = n.id')
->where('nt.lang = :lang AND n.deleted != 1')
->setParameter('lang', $locale);

Will trigger the following QueryException :

"The given alias 'invalid' is not part of any FROM or JOIN clause table. The currently registered aliases are: news, nv, nt, n."

[DBAL-301] [GH-167] Oracle stored procedures

Sun, 29 Jul 2012 07:53:12 +0000

This issue is created automatically through a Github pull request on behalf of AduroIdea:

Url: https://github.com/doctrine/dbal/pull/167

Message:

driver function
To avoid ORA-03131 error, data length must be passed to oci_bind_by_name function.
This commit fixes it so now pdo_oci can be used with stored procedures and output parameters from sql/plsql.

[DBAL-299] Multiple different interspersed named parameters

Sat, 7 Jul 2012 13:12:53 +0000

For this code

$sql = <<<SQL
SELECT 1 as id
WHERE (:foo = 2)
AND (:bar = 3)
AND (:foo = 2)
SQL;
$rsm = new \Doctrine\Orm\Query\ResultSetMapping();
$rsm->addScalarResult('id', 'id');

$query = $em->createNativeQuery($sql, $rsm);
$query = $query->setParameters(array('foo' => 2, 'bar' => 3));
$result = $query->getResult();

Generates the SQL in DBAL\Connection\executeQuery

SELECT 1 as id
WHERE (? = 2)
AN?bar = 3)
AND (? = 2)

The problem appears to be in DBAL\SQLParserUtils\expandListParameters.

When replacing the named parameters with ?'s an offset is kept to keep track of where to insert the next parameter. This is done per named parameter (all of :foo is replaced then all :bar, etc). This will calculate the incorrect offset if a named parameter(e.g. :bar) is in between instances of another named parameter (e.g. :foo) (i.e. :bar in the sql "(:foo = 2) AND (:bar =3) AND (:foo = 2)") since the offset will be for the TOTAL number of instances of the named parameter (e.g. -6) not the number of instances that occur before the needed replacement (e.g. -3).

This is where the SQL has "AN?bar = 3)" instead of "AND(3 = 3)" the offset is calculated at -6 instead of the proper -3

[DBAL-298] [GH-166] Fixes a bug caused by unquoted reserved table name being referenced during schema creation

Sun, 29 Jul 2012 08:13:48 +0000

This issue is created automatically through a Github pull request on behalf of klaussilveira:

Url: https://github.com/doctrine/dbal/pull/166

Message:

When creating a schema with tables with reserved names and relationships between them, the schema creation tool failed to write valid SQL in MySQL due to unquoted table names. For example:

CREATE TABLE `Group` (id INT AUTO_INCREMENT NOT NULL, name VARCHAR(255) NOT NULL DEFAULT NULL, PRIMARY KEY(id)) ENGINE = InnoDB;
CREATE TABLE User (id INT AUTO_INCREMENT NOT NULL, username VARCHAR(255) NOT NULL PRIMARY KEY(id)) ENGINE = InnoDB;
CREATE TABLE UserHasGroup (user_id INT NOT NULL, group_id INT NOT NULL, INDEX IDX_617A865CA76ED395 (user_id), INDEX IDX_617A865CFE54D947 (group_id), PRIMARY KEY(user_id, group_id)) ENGINE = InnoDB;
ALTER TABLE UserHasGroup ADD CONSTRAINT FK_617A865CA76ED395 FOREIGN KEY (user_id) REFERENCES User (id);
ALTER TABLE UserHasGroup ADD CONSTRAINT FK_617A865CFE54D947 FOREIGN KEY (group_id) REFERENCES Group (id);

This fix creates a small function for creating quoted foreign key table names.

[DBAL-296] [GH-165] interface compatibility

Thu, 5 Jul 2012 19:37:15 +0000

This issue is created automatically through a Github pull request on behalf of Nazin:

Url: https://github.com/doctrine/dbal/pull/165

Message:

[DBAL-295] [GH-164] Getters for AbstractAsset$_quoted and ForeignKeyConstraint$_options

Thu, 5 Jul 2012 19:08:46 +0000

This issue is created automatically through a Github pull request on behalf of tyler-sommer:

Url: https://github.com/doctrine/dbal/pull/164

Message:

Added the necessary getters, re: doctrine/migrations#79

[DBAL-290] Schema\Comparator::diffColumn finds ArrayType and TextType columns different

Thu, 31 May 2012 09:22:42 +0000

If I have an entity with @Column(type="array"), orm:validate-schema always tells me "FAIL - The database schema is not in sync with the current mapping file.".

If I call orm:schema-tool:update --dump-sql, I get "ALTER TABLE bridge ALTER config TYPE TEXT" although this is already how the column in my database looks like. If I execute this query, nothing happens and orm:validate-schema still fails.

There exist two different mapping types - TextType and ArrayType, but they both have the same SQL column type - TEXT.

The $fromSchema is built with TextType column, the $toSchema contains (correctly) ArrayType.

I propose not to generate the ALTER if the both compared columns' Type::getSQLDeclaration() results are the same.

If I got everything okay, I can prepare a pull request.

[DBAL-288] [GH-156] [Platform] Allow a string to be passed as type

Sun, 27 May 2012 15:49:34 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/dbal/pull/156

Message:

[DBAL-287] [GH-155] Update license for Composer

Sun, 27 May 2012 08:07:24 +0000

This issue is created automatically through a Github pull request on behalf of jalliot:

Url: https://github.com/doctrine/dbal/pull/155

Message:

[DBAL-286] [GH-154] Support for access method declaration for indexes

Sun, 27 May 2012 08:11:07 +0000

This issue is created automatically through a Github pull request on behalf of petr-motejlek:

Url: https://github.com/doctrine/dbal/pull/154

Message:

This is still work in progress, but it works. There will be another pull request in doctrine2 that actually depends on this one.

[DBAL-285] Schema generation fails when primary key is quoted

Wed, 4 Jul 2012 21:38:32 +0000

All of our entities are generated with their name quoted with back-ticks, this is to allow RAD.
When Doctrine comes to update the schema it fails to see the primary key is quoted and thus compared an index of PRIMARY(id) to PRIMARY(`id`). Which means it then tries to drop the primary index and recreate it, using a quoted field name.

This fix is to when the primary index is created is to fetch the columns from the table and get their unquoted name, so now when the comparison takes place it looks like this PRIMARY(id) to PRIMARY(id), therefore doesn't register this as a change.

[DBAL-283] [GH-151] Fixed the doctrine/common constraint and added the branch-alias

Tue, 22 May 2012 17:13:37 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/151

Message:

The change in the requirements requires doctrine/common#144 to be merged and parsed by Packagist, otherwise ``2.3.*`` would not match anything.

[DBAL-282] [GH-150] Added missing regex delimiters in the testsuite

Tue, 22 May 2012 17:12:47 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/150

Message:

The AbstractSchemaManager expects getting the regex with its
delimiters since 8beb732fe9 but the tests were not updated.

[DBAL-280] [GH-148] No bug. Respect the case used in the interface

Tue, 22 May 2012 17:47:40 +0000

This issue is created automatically through a Github pull request on behalf of pap-florin:

Url: https://github.com/doctrine/dbal/pull/148

Message:

[DBAL-281] [GH-149] changed some phpdoc's, set correct namespaces and types

Tue, 22 May 2012 17:53:09 +0000

This issue is created automatically through a Github pull request on behalf of Engerim:

Url: https://github.com/doctrine/dbal/pull/149

Message:

[DBAL-278] add support for lastInsertId method on OCI8 Driver

Tue, 22 May 2012 19:21:16 +0000

The method lastInsertId() is not defined for OCI8 Driver in Doctrine\DBAL\Driver\OCI8\OCI8Connection.php :

OCI8Connection.php

public function lastInsertId($name = null)
{
    //TODO: throw exception or support sequences?
}

I propose this method to handle lastInsertId for sequence :

OCI8Connection.php

public function lastInsertId($name = null)
 {
        // For sequence
        if (is_string($name)) {
            // We can check eventually check the presence of the sequence in the table
            // USER_SEQUENCES
            $sql = 'SELECT ' . $name . '.CURRVAL FROM DUAL';
            // will throw an exception if this sequence does not exist
            $stmt = $this->query($sql);
            $result = $stmt->fetch(\PDO::FETCH_ASSOC);
            if ($result !== false && isset($result['CURRVAL'])) {
                return (int) $result['CURRVAL'];
            }
    }
    // OCI8 driver does not provide support of lastInsertId
    return null;
}

Thanks,

[DBAL-279] [GH-147] 2.2 Add lastInsertId() support for OCI8 Driver

Tue, 22 May 2012 19:21:29 +0000

This issue is created automatically through a Github pull request on behalf of franek:

Url: https://github.com/doctrine/dbal/pull/147

Message:

Add lastInsertId() support for Sequence

[DBAL-276] MySQL schema manager should not make assumptions about non-DBAL types

Sun, 27 May 2012 08:58:59 +0000

When using the DBAL MySQL schema manager to create migrations or update the schema directly, it can create conflicts with custom types due to the way it processes some non-DBAL types in _getPortableTableColumnDefinition.

I recently implemented a binary-string type, using the MySQL BINARY/VARBINARY columns (as opposed to blob, which I see has been adopted in 2.2), due to the content for my application always being a 60 byte binary string. Doctrine has been working fine with it, but upon generating my next migration, I discovered that the schema manager wanted to re-set the column's length.
Generated SQL: "ALTER TABLE User CHANGE password password VARBINARY(60) NOT NULL"

It appears that this is caused by lines 138 & 139 of MySqlSchemaManager.php clearing the column's length. There doesn't seem to be any other code pertaining to MySQL and binary/varbinary, so removing these two lines should be safe and save trouble for future users, without causing issues for those who choose to implement it as a blob or similar.

[DBAL-277] [GH-146] auto-quote table and column name in Connection->delete/insert/update()

Tue, 22 May 2012 17:49:05 +0000

This issue is created automatically through a Github pull request on behalf of nicolas-grekas:

Url: https://github.com/doctrine/dbal/pull/146

Message:

I wonder why quoting of table/column names in Connection->delete/insert/update() is left to the developer and not not done internally by the library?

I made a patch to allow the lib to quote table and column names in a backward-compatible way. I believe that if this feature is not already in the lib, there must be some reason, but I can't understand it right now, nor find a reference to any rational.

Would it be possible to elaborate the reason if possible, while accepting / rejecting the pull request at your will of course?

Many thanks.

[DBAL-274] [GH-145] Allow easier overriding of the DateTime class

Sun, 27 May 2012 10:52:48 +0000

This issue is created automatically through a Github pull request on behalf of Seldaek:

Url: https://github.com/doctrine/dbal/pull/145

Message:

If this can be backported to 2.2, it'd be nice.

The goal is that we have to override the Date* Types in our code to support PKs on Date fields, but at the moment that requires duplicating all the code from those classes, which sucks a bit for maintenance.

[DBAL-272] [GH-144] [MYSQLI] Fixed infinite loop in fetchAll()

Wed, 9 May 2012 07:00:08 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/144

Message:

[DBAL-271] [GH-143] added simple_array type

Sun, 27 May 2012 15:49:57 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/dbal/pull/143

Message:

[DBAL-269] [GH-141] Fixed conditional expression

Sun, 27 May 2012 10:09:02 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/141

Message:

[DBAL-268] [GH-140] Dbal 264 dev

Fri, 4 May 2012 17:41:01 +0000

This issue is created automatically through a Github pull request on behalf of rivaros:

Url: https://github.com/doctrine/dbal/pull/140

Message:

Just some small changes taken from 2.3 branch to support guids in 2.2 (backport).
If you think it can be used, pls merge. Had to use it in my projects as really lacked this feature.

[DBAL-270] [GH-142] Dbal 264

Tue, 22 May 2012 17:56:01 +0000

This issue is created automatically through a Github pull request on behalf of rivaros:

Url: https://github.com/doctrine/dbal/pull/142

Message:

added support for Postgres UUID type.

[DBAL-267] DBAL\Connection doesn't escape SQL keywords

Tue, 22 May 2012 17:52:10 +0000

I'm using DBAL Connection's "insert" and "update" methods to manipulate my database.

Both those methods doesn't escape reserved SQL keywords appropriately. See: http://www.doctrine-project.org/api/dbal/2.2/source-class-Doctrine.DBAL.Connection.html#493

For example the following method call will raise an Exception (SQL error):

$Connection->insert('some_table', array(
'from' => 'foo',
'to' => 'bar'
));

Because the "from"-key is a reserved SQL keyword.

Database abstraction layer such as DBAL MUST consider such situations and act appropriately (i.e. escape field names with regulations specified by syntax of used RDBMS).

In MySQL i have to do this manually before calling "insert" or "update":
$key = '`' . $key . '`';
And this is really bad practice, cause it's platform-depended solution (works only for MySQL).

I hope you will find my words reasonable. it's important for developer to be able to use any key names he seems necessary (even if it's reserved by SQL itself). Sometimes developer doesn't even have a choice (e.g. when he receives database from third-party and can't change it's structure).

[DBAL-263] [GH-137] Support OCI8 statements crossing transactions [DBAL-202]

Sat, 5 May 2012 07:37:34 +0000

This issue is created automatically through a Github pull request on behalf of dpb587:

Url: https://github.com/doctrine/dbal/pull/137

Message:

Bug Fix: yes
Feature addition: no
Backwards compatibility break: no
[![Build Status](https://secure.travis-ci.org/dpb587/dbal.png?branch=ticket-dbal-202)](http://travis-ci.org/dpb587/dbal)

Scenario is documented in JIRA ~~DBAL-202~~(http://www.doctrine-project.org/jira/browse/DBAL-202). Basically in oci8 if you prepare a statement outside of a transaction, start a transaction, execute the statement, rollback the transaction - the statement will still have been executed. Whether it's the correct behavior or not, it seems like it should match PDO's behavior.

This implementation affects the API, so it should probably be carefully reviewed.

A separate test script is available at https://gist.github.com/2515100(gist.github.com/2515100).

$ php -v ; php --re oci8 | head -1
PHP 5.3.3-7+squeeze3 with Suhosin-Patch (cli) (built: Jun 28 2011 08:24:40)
Copyright (c) 1997-2009 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies
with Xdebug v2.1.1, Copyright (c) 2002-2011, by Derick Rethans
with Suhosin v0.9.32.1, Copyright (c) 2007-2010, by SektionEins GmbH
Extension [ <persistent> extension #52 oci8 version 1.4.2 ] {
$ phpunit -c oci8.phpunit.xml.dist tests/Doctrine/Tests/DBAL/Driver/OCI8/OCI8StatementTest.php
PHPUnit 3.5.13 by Sebastian Bergmann.

Time: 0 seconds, Memory: 7.50Mb

OK (2 tests, 2 assertions)
$ phpunit -c oci8.phpunit.xml.dist tests/Doctrine/Tests/DBAL/Functional/Ticket/DBAL202Test.php
PHPUnit 3.5.13 by Sebastian Bergmann.

Time: 7 seconds, Memory: 9.50Mb
OK (2 tests, 6 assertions)

I had to drop the the following tests to run through the oracle test suite (seemed like my test user didn't have enough permissions for the temp db tests), but all other tests pass.

$ rm tests/Doctrine/Tests/DBAL/Functional/TemporaryTableTest.php
$ rm tests/Doctrine/Tests/DBAL/Functional/TableGeneratorTest.php # see pull 136
$ rm tests/Doctrine/Tests/DBAL/Functional/Schema/OracleSchemaManagerTest.php
$ phpunit -c oci8.phpunit.xml.dist
PHPUnit 3.5.13 by Sebastian Bergmann.

............................................................... 63 / 747 ( 8%)
.......SSSS.....S........S......................S...........S.. 126 / 747 ( 16%)
.............................SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 189 / 747 ( 25%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 252 / 747 ( 33%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS.............S........ 315 / 747 ( 42%)
...S...S...SSS................................................. 378 / 747 ( 50%)
............................................................... 441 / 747 ( 59%)
.....SSS....................................................... 504 / 747 ( 67%)
............................................................... 567 / 747 ( 75%)
..............S................................................ 630 / 747 ( 84%)
............................................................... 693 / 747 ( 92%)
......................................................

Time: 33 seconds, Memory: 46.00Mb

OK, but incomplete or skipped tests!
Tests: 747, Assertions: 1145, Skipped: 156.

[DBAL-265] [GH-138] Dbal 264

Fri, 4 May 2012 17:49:42 +0000

This issue is created automatically through a Github pull request on behalf of rivaros:

Url: https://github.com/doctrine/dbal/pull/138

Message:

I would appreciate these light changes back-ported to 2.1.x
These are just support of uuids/guids types in dbal.

[DBAL-262] [GH-136] Support oci8 in TableGenerator

Sat, 5 May 2012 07:45:25 +0000

This issue is created automatically through a Github pull request on behalf of dpb587:

Url: https://github.com/doctrine/dbal/pull/136

Message:

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
[![Build Status](https://secure.travis-ci.org/dpb587/dbal.png?branch=bugfix-TableGenerator)](http://travis-ci.org/dpb587/dbal)

This test was breaking when running under `oci8` due to Oracle's deference to upper case column names. I realize Oracle has built-in sequences and `TableGenerator` is unnecessary, in theory, but it seemed like the class should work if possible. I see pgsql is in the same boat.

Tested with:

phpunit -c oci8.phpunit.xml.dist tests/Doctrine/Tests/DBAL/Functional/TableGeneratorTest.php

Before:

PHPUnit 3.5.13 by Sebastian Bergmann.

Time: 0 seconds, Memory: 10.25Mb

There were 2 errors:

1) Doctrine\Tests\DBAL\Functional\TableGeneratorTest::testNextVal
Exception: [Doctrine\DBAL\DBALException] Error occured while generating ID with TableGenerator, aborted generation: Undefined index: sequence_value

2) Doctrine\Tests\DBAL\Functional\TableGeneratorTest::testNextValNotAffectedByOuterTransactions
Exception: [Doctrine\DBAL\DBALException] Error occured while generating ID with TableGenerator, aborted generation: Undefined index: sequence_value

After:

PHPUnit 3.5.13 by Sebastian Bergmann.

Time: 1 second, Memory: 10.25Mb

OK (2 tests, 5 assertions)

[DBAL-266] [GH-139] [Mysql Platform] Added mapping for binary and varbinary.

Fri, 4 May 2012 17:47:36 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/139

Message:

[DBAL-259] [GH-134] Removed Paranthesis to allow for more complex Regex

Sat, 5 May 2012 11:40:38 +0000

This issue is created automatically through a Github pull request on behalf of Hounddog:

Url: https://github.com/doctrine/dbal/pull/134

Message:

Needed to remove the Paranthesis to allow for complex Regular Expressions. e.g Exclusion of tables

[DBAL-255] On SQL SERVER Trying to drop a column throws error because of auto generated Constraints

Sat, 5 May 2012 11:08:06 +0000

Whenever Doctrine tries to drop a column that has some implicit constraints the system the SQL Native Client throws the message:

The Object 'Name_Of_The_Object' is dependent on column 'Column_To_Drop';

This is probably because columns such as Decimal Numbers have an automatice generated constraint that need to be dropped in order to drop a column.

A possible Solution is to add a platform specific getConstratintForTableSQL that queries the database to get all the constraint for the given column, than override the 'alterTable' method in the SQLServer Schema Manager to first drop the constraint than the columns in question by going and checking all the Columns that needs to be dropped in the TableDiff passed.

Something similar to this but better refactored I guess:

Changes in SQLServerPlatform.php

Add a method similar to this:

    /**
     * This function retrieves the constraints for a given column that is going to be droppped 
     */
    public function getColumnConstraintSQL($table, $column)
    {
        return "SELECT SysObjects.[Name]
                From SysObjects Inner Join (Select [Name],[ID] From SysObjects Where XType = 'U') As Tab
                On Tab.[ID] = Sysobjects.[Parent_Obj] 
                Inner Join sysconstraints On sysconstraints.Constid = Sysobjects.[ID] 
                Inner Join SysColumns Col On Col.[ColID] = sysconstraints.[ColID] And Col.[ID] = Tab.[ID]
                Where Col.[Name] = '$column' and Tab.[Name] = '$table'
                order by Col.[Name]";
    }

Changes on SqlServerChemaManager.php

       /**
	* Override
	*/
	public function alterTable(TableDiff $tableDiff)
	{
		if(count($tableDiff->removedColumns) > 0){
			$constraintsSql = array();
			foreach($tableDiff->removedColumns as $col){
				$constraintsSql[] = $this->_platform->getColumnConstraintSQL($tableDiff->name, $col->oldColumnName);
			}
			$constraintsToDrop = array();
			foreach($constraintsSql as $sql){
				 $constraintsToDrop[] = $this->_conn->execute($sql);
			}
			foreach($constraintsToDrop as $constraint){
				$this->_conn->execute("ALTER TABLE $tableDiff->name DROP CONSTRAINT $constraint");
			}
		}
		return parent::alterTable($tableDiff);
	}

Hope this helps

Thx

[DBAL-257] OCI8Statement::fetchColumn() returns null instead of false

Sat, 5 May 2012 09:28:22 +0000

In
public function fetchColumn($columnIndex = 0)
{
$row = oci_fetch_array($this->_sth, OCI_NUM | OCI_RETURN_NULLS | OCI_RETURN_LOBS);
return $row[$columnIndex];
}

there is no control on oci_fetch_array_() returned value.
When it returns false fetchColumn() returns null instead of false.

Solution:
public function fetchColumn($columnIndex = 0)
{
$row = oci_fetch_array($this->_sth, OCI_NUM | OCI_RETURN_NULLS | OCI_RETURN_LOBS);
return isset($row[$columnIndex]) ? $row[$columnIndex] : false;
}

[DBAL-254] SQL Server rename table should use sp_RENAME

Sun, 8 Jul 2012 20:31:44 +0000

Whenever DBAL Schema Manager tries to rename a table in sql server 2008 it should use also the sp_RENAME procedure. Otherwise error is thrown.

Apparently a similar issue was fixed for column ALTER Commands as described in the link below, but also the ALTER TABLE command should use sp_RENAME to avoid crash.

http://www.doctrine-project.org/jira/browse/DBAL-199?page=com.atlassian.jira.plugin.system.issuetabpanels%3Achangehistory-tabpanel

Suggested fix for Latest DBAL 2.2

From Line 283:

$queryParts[] = 'RENAME TO ' . $diff->newName;

To Line 283:

$sql[] = 'sp_RENAME \'' . $diff->name . '\',\'' . $diff->newName.'\'';

This seems to fix the problem.

Hope this helps

Sorry for my bad english.

Fredcallagan

[DBAL-252] [GH-131] [mysqli] Added mysqli driver to travis tests.

Mon, 16 Apr 2012 17:02:02 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/131

Message:

[DBAL-251] [GH-130] [mysqli] Added support for fetchAll(PDO::fetch_column)

Mon, 16 Apr 2012 17:01:56 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/130

Message:

[DBAL-250] [GH-128] [DBAL-249] result cache with fetch type PDO::FETCH_COLUMN

Fri, 4 May 2012 18:04:13 +0000

This issue is created automatically through a Github pull request on behalf of gedrox:

Url: https://github.com/doctrine/dbal/pull/128

Message:

This should enable caching of results retrieved by PDO::FETCH_COLUMN fetch type.
Before this exception "Invalid fetch-style given for caching result" was raised.

Should work now.

(This replaces a previous pull request #126 I failed to make right... sorry)

[DBAL-248] [GH-127] Fix Statement class passing bound objects to SQL logger

Fri, 4 May 2012 18:04:31 +0000

This issue is created automatically through a Github pull request on behalf of jimcottrell:

Url: https://github.com/doctrine/dbal/pull/127

Message:

This commit saves converted parameter values in bindValue() so the later call to the SQL logger in execute() will not pass bound objects without type information.

[DBAL-247] [GH-126] Enable caching of results with fetch type PDO::FETCH_COLUMN

Sat, 7 Apr 2012 08:15:30 +0000

This issue is created automatically through a Github pull request on behalf of gedrox:

Url: https://github.com/doctrine/dbal/pull/126

Message:

This should enable caching of results retrieved by PDO::FETCH_COLUMN fetch type.
Before this exception "Invalid fetch-style given for caching result" was raised.

[DBAL-441] [GH-269] Fix SQLServerPlatform regular expression SQL

Sun, 3 Feb 2013 19:32:37 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/269

Message:

SQL Server has no native support for regular expressions. Furthermore there is no "RLIKE" expression in T-SQL. This PR fixes this.

[DBAL-439] [GH-267] Add SQLServerPlatform supports schemas

Tue, 5 Feb 2013 15:21:50 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/267

Message:

SQL Server supports schemas. This PR modifies SQLServerPlatform to return true when asked for schema support.

[DBAL-440] [GH-268] Remove deprecated getShowDatabasesSQL() from Platforms

Sun, 10 Feb 2013 00:04:34 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/268

Message:

As stated in PR #265 the getShowDatabasesSQL() method is deprecated in the platforms. This PR removes them entirely now.

[DBAL-438] [GH-266] Removed outdated methods in DatabasePlatformMock.

Tue, 5 Feb 2013 15:19:24 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/dbal/pull/266

Message:

Same as https://github.com/doctrine/doctrine2/pull/567

[DBAL-437] [GH-265] fix getShowDatabasesSQL() in SQLServerPlatform

Sun, 10 Feb 2013 00:05:14 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/265

Message:

The getShowDatabasesSQL() in SQLServerPlatform returns invalid SQL. Maybe copy/paste error from MySqlPlatform? This PR fixes this to return the correct statement.

[DBAL-433] [GH-263] Fix wrong class names in SQLAzureFederationsSynchronizer

Wed, 30 Jan 2013 18:38:19 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/dbal/pull/263

Message:

There is a wrong import in this class:

use Doctrine\DBAL\Sharding\SingleDatabaseSynchronizer;

Should be:

use Doctrine\DBAL\Schema\Synchronizer\SingleDatabaseSynchronizer;

The following import is also missing:

use Doctrine\DBAL\Schema\Synchronizer\SchemaSynchronizer;

This PR fixes them.

[DBAL-430] [GH-260] Add SQL Server 2012 platform

Mon, 4 Feb 2013 00:14:09 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/260

Message:

This adds the platform for SQL Server 2012 introducing sequences. I don't exactly know if sequences should be preferred for ID generation or not so I left identity columns preferred for ID generation. Also added new keywords to MsSqlKeywords since SQL Server 2008.

[DBAL-428] [GH-258] Guid type requires SQL typehint comment

Wed, 30 Jan 2013 18:37:43 +0000

This issue is created automatically through a Github pull request on behalf of pkruithof:

Url: https://github.com/doctrine/dbal/pull/258

Message:

Since guid extends the string type, it needs to be type hinted.

[DBAL-427] [GH-257] fix SQLServerPlatform locking hints

Sun, 3 Feb 2013 19:54:20 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/257

Message:

This should completely implement the locking hints of the SQLServerPlatform according to http://msdn.microsoft.com/en-us/library/aa213026%28v=sql.80%29.aspx.

[DBAL-425] [GH-255] fix typo in AbstractPlatform phpDocs

Sat, 26 Jan 2013 16:29:21 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/255

Message:

Fixes typo in AbstractPlatform phpDocs. "ASNI" -> "ANSI"

[DBAL-424] [GH-254] fix SQLServerPlatform GUID expression

Fri, 25 Jan 2013 19:18:58 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/254

Message:

The GUID expression UUID() does not exist in SQLServer. Instead NEWID() is used. This PR fixes this.

[DBAL-421] [GH-253] Added GUID expression to SQLite platform

Fri, 25 Jan 2013 08:43:47 +0000

This issue is created automatically through a Github pull request on behalf of jankramer:

Url: https://github.com/doctrine/dbal/pull/253

Message:

This will add an implementation of getGuidExpression to the SqlitePlatform. It is based on [UUID version 4](http://en.wikipedia.org/wiki/Universally_unique_identifier#Version_4_.28random.29).

Don't know if this is appropriate, but I'm open to suggestions.

[DBAL-419] [GH-252] Sqlserver limit

Wed, 30 Jan 2013 18:39:38 +0000

This issue is created automatically through a Github pull request on behalf of norzechowicz:

Url: https://github.com/doctrine/dbal/pull/252

Message:

Unfortunately fix from my last commit it not enough to handle more complicated queries.
This change should fix points 2 and 3 [from this list](http://www.doctrine-project.org/jira/browse/DDC-1785) but it also removes adding TOP statement if ``$offset`` is not set.
I know it looks realy messy but I can't figure out any other solution to handel queries with subqueries and ordering (such thing is generated after using Doctrine Paginator and ordering).

[DBAL-417] [GH-250] Lightweight export as of doctrine/doctrine2#543

Sat, 19 Jan 2013 23:00:19 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/dbal/pull/250

Message:

see doctrine/doctrine2#543

[DBAL-416] [GH-249] Fixed doModifyLimitQuery for SQLServerPlatform

Sun, 20 Jan 2013 11:50:54 +0000

This issue is created automatically through a Github pull request on behalf of norzechowicz:

Url: https://github.com/doctrine/dbal/pull/249

Message:

It seems that there is a problem in SQLServerPlatform ``doModifyLimitQuery`` method.
I can't use Doctrine ORM Paginator because of wrong position of ``DISTINCT`` statement in final limit subquery, here is the exception message I'm getting.
``SQLSTATE[42000]: [Microsoft][SQL Server Native Client 10.0][SQL Server]Incorrect syntax near the keyword 'DISTINCT'.``

My proposition is to change ``doModifyLimitQuery`` result from:

``SELECT * FROM (SELECT ROW_NUMBER() OVER (ORDER BY username DESC) AS doctrine_rownum, * FROM user) ...``

into:

``SELECT * FROM (SELECT *, ROW_NUMBER() OVER (ORDER BY username DESC) AS doctrine_rownum FROM user) ...``

[DBAL-413] [GH-247] Obtain all informations about a column via Column::toArray()

Tue, 8 Jan 2013 15:33:50 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/247

Message:

[DBAL-410] [GH-246] Fixed sql for creating table with fulltext index

Tue, 8 Jan 2013 15:40:37 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/246

Message:

[DBAL-408] [GH-244] Enable Postgresql plateform to map inet column type

Tue, 8 Jan 2013 15:26:05 +0000

This issue is created automatically through a Github pull request on behalf of cedriclombardot:

Url: https://github.com/doctrine/dbal/pull/244

Message:

http://www.postgresql.org/docs/8.2/static/functions-net.html

[DBAL-405] [GH-241] Added support of key length for text indexes

Sun, 30 Dec 2012 17:26:39 +0000

This issue is created automatically through a Github pull request on behalf of maxlun86:

Url: https://github.com/doctrine/dbal/pull/241

Message:

[DBAL-403] [GH-240] Fix for DBAL-209

Sun, 6 Jan 2013 09:07:04 +0000

This issue is created automatically through a Github pull request on behalf of nemekzg:

Url: https://github.com/doctrine/dbal/pull/240

Message:

Fix for DBAL-209

[DBAL-401] Log connection info with SQL logger

Fri, 28 Dec 2012 14:23:33 +0000

while using MasterSlave connection, it would be nice to see the connection being used ( master or which slave), this will help debug the app, if lots read queries are going to Master

[DBAL-399] [GH-237] Do not treat assignment operator as a parameter DBAL-398

Sat, 22 Dec 2012 11:35:14 +0000

This issue is created automatically through a Github pull request on behalf of roverwolf:

Url: https://github.com/doctrine/dbal/pull/237

Message:

A native (mysql) query should be able to use the assignment operator := but currently the SQLParserUtils method treats that as a missing parameter.

The patch solves the issue, but it looks like a higher-level fix might be desired that also handles the regular expression better.

[DBAL-398] Native query does not allow mysql assignment operator :=

Thu, 3 Jan 2013 22:38:50 +0000

When trying to use the mysql assignment operator in a native query one gets an exception as SqlParserUtils does not qualify the character after the : as being part of a valid parameter value.

Undefined index: in vendor/doctrine/dbal/lib/Doctrine/DBAL/SQLParserUtils.php line 156 (uncaught exception)

A simple example is
$rsm = new ResultSetMapping();
$rsm->addScalarResult('rank', 'rank');
$qry = $em->createNativeQuery("
SELECT (@rank := 1) AS rank
");
$result = $qry->getResult(Query::HYDRATE_ARRAY);

Or a more complicated example is (similar to actual use):

$rsm = new ResultSetMapping();
$rsm->addScalarResult('rank', 'rank');
$qry = $em->createNativeQuery("
SELECT rank FROM
(SELECT (@rank := @rank +1) AS rank FROM (SELECT @rank :=0) rnk2) rnk1
");
$result = $qry->getResult(Query::HYDRATE_ARRAY);

I have attached quick-fix patch, but it looks like the getPlaceholderPositions method is wanting something better overall (due to the TODO comment in it).

[DBAL-397] PostgreSQL - getDateTimeTzFormatString()

Mon, 17 Dec 2012 15:21:20 +0000

In:

vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php

The function:

getDateTimeTzFormatString()

only returns one datetime format:


    /**
     * {@inheritDoc}
     */
    public function getDateTimeTzFormatString()
    {
        //return 'Y-m-d H:i:sO'; // original format
        return 'Y-m-d H:i:s.uO'; // format also needed
    }

Here is the error I get using the original format:

Could not convert database value "2012-12-07 16:01:52.580789-05" to Doctrine Type datetimetz. Expected format: Y-m-d H:i:s.O

If I use this format: 'Y-m-d H:i:s.uO' it works.

[DBAL-396] [GH-236] DBAL-200 Missing docs for 1 parameter in Connection::update

Wed, 12 Dec 2012 13:34:39 +0000

This issue is created automatically through a Github pull request on behalf of posulliv:

Url: https://github.com/doctrine/dbal/pull/236

Message:

Trivial addition of docs for 1 parameter that was missing in Connection::update. Resolves an open issue so figured it was worth a pull request.

[DBAL-395] [GH-235] Update links in Readme

Mon, 3 Dec 2012 19:48:02 +0000

This issue is created automatically through a Github pull request on behalf of joshuajabbour:

Url: https://github.com/doctrine/dbal/pull/235

Message:

Just updating some broken and old links in the Readme file.

[DBAL-393] PEAR install broken

Sun, 25 Nov 2012 12:05:50 +0000

When using PEAR install, the "doctrine-dbal" command does not work.

$ pear install doctrine/DoctrineDBAL
downloading DoctrineDBAL-2.3.0.tgz ...
Starting to download DoctrineDBAL-2.3.0.tgz (143,996 bytes)
................................done: 143,996 bytes
install ok: channel://pear.doctrine-project.org/DoctrineDBAL-2.3.0

$ which doctrine-dbal
/usr/bin/doctrine-dbal

$ /usr/bin/doctrine-dbal
PHP Warning: require(Doctrine/Symfony/Component/Console/Helper/HelperSet.php): failed to open stream: No such file or directory in /usr/share/pear/Doctrine/Common/ClassLoader.php on line 164
PHP Stack trace:
PHP 1. {main}() /usr/bin/doctrine-dbal:0
PHP 2. include() /usr/bin/doctrine-dbal:4
PHP 3. Doctrine\Common\ClassLoader->loadClass() /usr/bin/doctrine-dbal:0
PHP Fatal error: require(): Failed opening required 'Doctrine/Symfony/Component/Console/Helper/HelperSet.php' (include_path='.:/usr/share/pear:/usr/share/php') in /usr/share/pear/Doctrine/Common/ClassLoader.php on line 164
PHP Stack trace:
PHP 1. {main}() /usr/bin/doctrine-dbal:0
PHP 2. include() /usr/bin/doctrine-dbal:4
PHP 3. Doctrine\Common\ClassLoader->loadClass() /usr/bin/doctrine-dbal:0

The issue can be fixed by updating file doctrine-dbal.php from:
$classLoader = new \Doctrine\Common\ClassLoader('Symfony', 'Doctrine');
to:
$classLoader = new \Doctrine\Common\ClassLoader('Symfony');
so the Symfony Console package can be used like the PEAR package.xml requires.

NOTE: I did not want to submit a GitHub pull request for this because it seems like it would break your Git and Composer installs

[DBAL-392] Moving entity relationship doesn't move foreign key in mysql table

Reference — Sun, 23 Dec 2012 20:31:22 +0000

This is the copy of bug http://www.doctrine-project.org/jira/browse/DDC-2161 that I've moved here since it's related to the dbal and not the orm.

Basically when you update just the foreign table of a foreign key the constrain doesn't gets updated.

[DBAL-389] [GH-232] Problem with sequence names, PostgreSQL and MixedCased schemas

Thu, 22 Nov 2012 15:46:51 +0000

This issue is created automatically through a Github pull request on behalf of ajgarlag:

Url: https://github.com/doctrine/dbal/pull/232

Message:

I''m having problems with a doctrine migration in a pgsql database that has a mixed case schema name.

After some investigation I've found the origin of the problem: when the schema manager is going to list sequences it executes a SQL statement to find the minimun sequence value.

This SQL statement is not quoting the sequence name, so the SQL fails with mixed cased schemas.

This trivial commit resolves this problem. I think it could be backported to stable versions of DBAL.

[DBAL-387] [GH-230] Fixed SQL Server Platform NULL declaration

Sun, 25 Nov 2012 18:07:30 +0000

This issue is created automatically through a Github pull request on behalf of Lusitanian:

Url: https://github.com/doctrine/dbal/pull/230

Message:

Per previous pull request but based on master. SQL server does not use 'DEFAULT NULL' for marking columns as nullable, only 'NULL'.

[DBAL-386] [GH-229] Fixed SQL Server Platform NULL declaration

Sun, 25 Nov 2012 12:01:19 +0000

This issue is created automatically through a Github pull request on behalf of Lusitanian:

Url: https://github.com/doctrine/dbal/pull/229

Message:

In SQL Server, 'DEFAULT NULL' is invalid for allowing a column to be null – the 'NULL' keyword is the only required indicator of nullability.

[DBAL-385] Null need set to NULL in array type

Sun, 25 Nov 2012 15:44:45 +0000

When use Array type and NULL value

set null give in database 'N;' (serialise(null))
need NULL

[DBAL-383] [GH-228] fixed typo for enabling DEFERRED support

Thu, 22 Nov 2012 17:51:44 +0000

This issue is created automatically through a Github pull request on behalf of lsmith77:

Url: https://github.com/doctrine/dbal/pull/228

Message:

old spelling still supported for BC

[DBAL-382] add foreign key support to the SQLite platform

Mon, 7 Jan 2013 10:50:01 +0000

SQLite supports foreign keys since version 3.6.19:
http://www.sqlite.org/foreignkeys.html

note when implementing this it also makes sense to look into fixing this typo (likely keeping the current version in place for BC):
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php#L325

[DBAL-105] Schema Comparator produces invalid SQL

Wed, 6 Apr 2011 14:21:17 +0000

Before:

/**
 * @orm:Entity
 * @orm:Table(name="twitter_users")
 */
class TwitterUser implements UserInterface
{
    const ROLE_DEFAULT = 'ROLE_TWITTER_USER';

    /**
     * @orm:Id
     * @orm:GeneratedValue(strategy="AUTO")
     * @orm:Column(type="integer")
     */
    private $id;

    /**
     * @orm:Column(type="integer", unique=true, nullable=false)
     */
    private $twitterId;

    /**
     * @orm:Column(type="string", unique=true, nullable=false)
     */
    private $displayName;
}

After:

/**
 * @orm:Entity
 * @orm:Table(name="twitter_users")
 */
class TwitterUser implements UserInterface
{
    const ROLE_DEFAULT = 'ROLE_TWITTER_USER';

    /**
     * @orm:Id
     * @orm:GeneratedValue(strategy="AUTO")
     * @orm:Column(type="integer")
     */
    private $id;

    /**
     * @orm:Column(type="integer", unique=true, nullable=false, name="twitter_id")
     */
    private $twitterId;

    /**
     * @orm:Column(type="string", unique=true, nullable=false, name="display_name")
     */
    private $displayName;

    /**
     * @orm:Column(type="datetime", name="last_logged_in_at", nullable=true)
     */
    private $lastLoggedInAt;
}

Bugs in the generated SQL:

last_logged_in_at column is not added
displayName is dropped, and at the same time the column name "displayName" is changed to "display_name"
twitterId same as above

[DBAL-106] Doctrine\DBAL\Schema\Comparator false positives

Wed, 6 Apr 2011 17:19:17 +0000

I am using the model class annotations for my Doctrine schema definition and a MySQL database for my target. When testing code that uses Doctrine\DBAL\Schema\Comparator, either by using $schemaTool->updateSchema($classes) which is defined in the core functionality or by running doctrine migrations:diff from the Doctrine Migrations project, a set of bugs are revealed. The symptoms of this are that immediately after calling $schemaTool->createSchema($classes) any call that uses the Comparator class to calculate the diffs between the real database and the schema definition produce a large set of false positives. Most of these false positives can be traced back to the logic in Doctrine\DBAL\Schema\Comparator::diffColumn(Column $column1, Column $column2). There are two issues here I can see right away:

One is that if the model annotations rely on defaults rather than explicitly defining certain attributes, this function sees them as different. For example, if I have a column defined like this: @Column(type="decimal", scale=2, nullable=true) then the Comparator believes it is different from the real database because precision is 10 in the real data and 0 in my schema. If I change the line to this: if (($column1->getPrecision() ?: 10) != ($column2->getPrecision() ?: 10)) then it works, but I am sure a real solution needs to determine what the defaults actually are.

The second issue is when I use the 'columnDefinition' attribute with a custom type to declare an enum or set, for instance. Since this function does not actually check what the columnDefinition field is set to at all, it has no way to know if I have actually made a change to the list of values, or anything else about that columnDefinition. I have been reading that using the comments field might be another way to do this, but I am not yet clear on what the best practice really is here. I know that http://www.doctrine-project.org/jira/browse/DBAL-42 touches on this with regard to storing Array type metadata in the comments field. I need more direction on how this should work in custom field types.

In addition, I am getting this strange set of diffs on the index for a ManyToMany association's join table:

        $this->addSql("CREATE INDEX IDX_44B8C6D89AF7860 ON firm_firm (firm_id)");
        $this->addSql("DROP INDEX primary ON firm_firm");
        $this->addSql("CREATE UNIQUE INDEX primary ON firm_firm (firm_id, firm_id)");

I am not sure why this only happens on this one table and not others, but it seems to be another case of the Comparator getting a false positive for some reason this time in Comparator::diffIndex(Index $index1, Index $index2). The model annotations for this association are:

  /**
   * @var Firm
   * @ManyToMany(targetEntity="Firm")
   */
  protected $Children = array();

I will add more to this as I learn more details about the issues, but hopefully this is enough to start grokking the issues in Comparator. Getting the Comparator class in the core Doctrine\DBAL library working properly for calculating diffs will go a long way toward making well defined migrations a reality for Doctrine2 projects running in production. Hopefully, someone will also be able to address this minor issue in the Doctrine Migrations (http://www.doctrine-project.org/jira/browse/DMIG-21) so that it can be deployed without needing a patch.

Thanks to everyone for Doctrine2, and I am looking forward to being among the first to put this new library into production on a real world project in a few months.

[DBAL-103] Quoting is not supported in pdo_odbc driver

Sun, 19 Jun 2011 09:53:50 +0000

trying to execute this dql:

SELECT p FROM my\namespace\entities\PQR p WHERE p.razon = 'TEL'

it built this native sql (iseries)

SELECT t0_.SGNUMÑ AS SGNUMÑ0, t0_.SGCAUS AS SGCAUS1, t0_.SGREAS AS SGREAS2 FROM SGMASTL7 t0_ WHERE t0_.SGCAUS =

because pdo is created with odbc[1], quote method[2] is not supported, and Doctrine/DBAL/Connection.php#quote()[3] method returns an empty value for <'TEL'> expression, so Database throws a Syntax error. It should be support for drivers which doesn't have implemented quote() method.

[1] with odbc: $pdo = new PDO("odbc:MY_ODBC_NAME", "USER", "PASSWORD");
[2] http://php.net/manual/en/pdo.quote.php
[3] https://github.com/doctrine/dbal/blob/2.0.3/lib/Doctrine/DBAL/Connection.php#L520

[DBAL-101] Undefined index "length" in SqliteSchemaManager

Wed, 6 Apr 2011 15:19:05 +0000

If not giving length for numeric columns when using SQLite, I got an undefined index error around line 155 in SqliteSchemaManager. I fixed it with this:

             case 'numeric':
-                list($precision, $scale) = array_map('trim', explode(', ', $tableColumn['length']));
+                if (array_key_exists('length', $tableColumn)) {
+                    list($precision, $scale) = array_map('trim', explode(', ', $tableColumn['length']));
+                } else {
+                    $precision = $scale = null;
+                }
                 $length = null;
                 break;

Git patch attached.

[DBAL-99] Proposal for better params-binding

Mon, 7 Mar 2011 04:55:26 +0000

Currently we have something like

    $count = $conn->executeUpdate('UPDATE user SET username = ? WHERE id = ?', array('jwage', 1));

I propose add prefixes to placeholders: i (toInt), f (toFloat), e (escape), q (quote), c (qouteIdent), j (join with comma).
eq - escape and quote. Arrays also can be escaped/quoted/converted to int (each element of array processed).

Examples:

    $count = $conn->executeUpdate('UPDATE user SET username = eq:0 WHERE id = i:1', array('jwage', 1)); // 0, 1 - keys of binded data
    $users = $conn->fetchAll('SELECT cj:cols FROM user WHERE id IN (ij:ids)', array('cols' => array('column1', 'column2'), 'ids' => array(1, 5, 9)));

[DBAL-98] BUG in Table.php or AbstractAsset

Fri, 4 Mar 2011 17:16:59 +0000

In Class Table in method _addForeignKeyConstraint is written

// add an explicit index on the foreign key columns. If there is already an index that fullfils this requirements drop the request.
// In the case of __construct calling this method during hydration from schema-details all the explicitly added indexes
// lead to duplicates. This creates compuation overhead in this case, however no duplicate indexes are ever added (based on columns).

It is false, because duplicate indexes are added (based on columns) the cause of that is strange _generateIdentifierName method in AbstractAsset class.

Algorith for genereting indexes base on substring is causing that

for example
tablename: communications.out_emails
columnname: internal_contact_channel_id

generates: communications_out_emails_rnal_email_contact_channel_id_idx

and

tablename: communications.out_emails
columnname: external_contact_channel_id

generates: communications_out_emails_rnal_email_contact_channel_id_idx

Suprise!!!?? It's the same.

I think the better way was to use md5 or sha (I'm ceeding).

[DBAL-245] [GH-124] Connection quote() ignores returned value from getBindingInfo()

Fri, 30 Mar 2012 19:48:00 +0000

This issue is created automatically through a Github pull request on behalf of jimcottrell:

Url: https://github.com/doctrine/dbal/pull/124

Message:

Maybe I'm missing something here, but this simple change seems to be necessary to allow for proper type management in quote(). For example, without this change passing a DateTime object as $input with $type = 'date' will resolve the proper string value in getBindingInfo, but then still attempt to pass the DateTime to PDO, which of course doesn't work.

[DBAL-241] Add fetchAll(PDO::FETCH_COLUMN) support to OCI8 driver

Sat, 24 Mar 2012 09:05:21 +0000

See https://github.com/doctrine/dbal/pull/52

[DBAL-243] setCharset raises an error when using pdo_sqlite

Thu, 5 Jul 2012 21:02:37 +0000

When I attempt to use setCharset("utf8") with pdo_sqlite, this fails.

I know that pdo_sqlite doesn't support SET NAMES utf8, however, this should be caught by the driver (like: throwing a NotSupportedException) or simply ignore setCharset (mainly because if you allow the user to choose their backend, developers don't need to introduce special cases for driver handling).

[DBAL-240] SQL Parser Utils trigger error when uing with Type instances

Sat, 24 Mar 2012 07:55:50 +0000

https://github.com/doctrine/dbal/pull/120

[DBAL-238] Disable MultipleActiveResultSets in SQL Server (pdo_sqlsrv) not possible

Sat, 5 May 2012 11:46:40 +0000

http://msdn.microsoft.com/en-us/library/ee376925%28v=sql.90%29.aspx

[DBAL-233] Signed / unsigned types are ignored by Comparator for MySQL schemas

Thu, 15 Mar 2012 11:25:51 +0000

E.g. one schema has an column1 which is unsigned tinyint, another schema doesn't.
The sql that is generated is the following:

ALTER TABLE table1 ADD column1 TINYINT(1) NOT NULL DEFAULT '1'

And it should be:

ALTER TABLE table1 ADD column1 TINYINT(1) UNSIGNED NOT NULL DEFAULT '1'

If in one schema there is an unsigned column and in the other it is signed (that being the only difference), the difference is not noticed at all.

[DBAL-230] Custom types not taken into account when running $ doctrine orm:validate-schema

Wed, 14 Mar 2012 19:54:01 +0000

Hi,

I created a class to handle PostgreSQL "inet" type and setup bootstape in order to register this new type.

PostgresInetType.php

namespace Doctrine\DBAL\Types;

class PostgresInetType extends Type {

    const INET = 'inet'; // modify to match your type name

    public function getSqlDeclaration(array $fieldDeclaration, AbstractPlatform $platform) {
        return 'Inet';
    }

    public function convertToPHPValue($value, AbstractPlatform $platform) {
        return new $value;
    }

    public function convertToDatabaseValue($value, AbstractPlatform $platform) {
        if (null === $value) {
            return null;
        } elseif (preg_match("/^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?).(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?).(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?).(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?))|((([0-9A-Fa-f]{1,4}:){7}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){6}:[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){5}:([0-9A-Fa-f]{1,4}:)?[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){4}:([0-9A-Fa-f]{1,4}:){0,2}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){3}:([0-9A-Fa-f]{1,4}:){0,3}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){2}:([0-9A-Fa-f]{1,4}:){0,4}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){6}((b((25[0-5])|(1d{2})|(2[0-4]d)|(d{1,2}))b).){3}(b((25[0-5])|(1d{2})|(2[0-4]d)|(d{1,2}))b))|(([0-9A-Fa-f]{1,4}:){0,5}:((b((25[0-5])|(1d{2})|(2[0-4]d)|(d{1,2}))b).){3}(b((25[0-5])|(1d{2})|(2[0-4]d)|(d{1,2}))b))|(::([0-9A-Fa-f]{1,4}:){0,5}((b((25[0-5])|(1d{2})|(2[0-4]d)|(d{1,2}))b).){3}(b((25[0-5])|(1d{2})|(2[0-4]d)|(d{1,2}))b))|([0-9A-Fa-f]{1,4}::([0-9A-Fa-f]{1,4}:){0,5}[0-9A-Fa-f]{1,4})|(::([0-9A-Fa-f]{1,4}:){0,6}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){1,7}:))$/", $value)) {
            return $value;
        } else {
            throw new PostgresInetTypeException($value);
        }
    }

    public function getName() {
        return self::INET;
    }

}

bootstrap.php

// ... other Doctrine setup stuff

// Define Database driver
$objDBALConfig = new \Doctrine\DBAL\Configuration();

$arrConnectionOptions = array(
    'dbname' => 'my_pg_database',
    'user' => 'itsme',
    'host' => '127.0.0.1',
    'driver' => 'pdo_pgsql',
);

$objDBALConnection = DriverManager::getConnection($arrConnectionOptions, $objDBALConfig);

// Add special PostgresType INET
Type::addType('inet', 'Doctrine\DBAL\Types\PostgresInetType');
$objDBALConnection->getDatabasePlatform()->registerDoctrineTypeMapping('Inet', 'inet');

// Instanciate EntityManager

$objDoctEntityManager = EntityManager::create($objDBALConnection, $objDoctConfig);

// ...

When running

php doctrine.php orm:validate-schema --verbose

I get the following:

[Mapping]  OK - The mapping files are correct.


                                                                                                        
  [Doctrine\DBAL\DBALException]                                                                         
  Unknown database type inet requested, Doctrine\DBAL\Platforms\PostgreSqlPlatform may not support it.  
                                                                                                        


Exception trace:
 () at /var/www/vhosts/workflow/project/Doctrine/DBAL/Platforms/AbstractPlatform.php:261
 Doctrine\DBAL\Platforms\AbstractPlatform->getDoctrineTypeMapping() at /var/www/vhosts/workflow/project/Doctrine/DBAL/Schema/PostgreSqlSchemaManager.php:285
 Doctrine\DBAL\Schema\PostgreSqlSchemaManager->_getPortableTableColumnDefinition() at /var/www/vhosts/workflow/project/Doctrine/DBAL/Schema/AbstractSchemaManager.php:672
 Doctrine\DBAL\Schema\AbstractSchemaManager->_getPortableTableColumnList() at /var/www/vhosts/workflow/project/Doctrine/DBAL/Schema/AbstractSchemaManager.php:159
 Doctrine\DBAL\Schema\AbstractSchemaManager->listTableColumns() at /var/www/vhosts/workflow/project/Doctrine/DBAL/Schema/AbstractSchemaManager.php:254
 Doctrine\DBAL\Schema\AbstractSchemaManager->listTableDetails() at /var/www/vhosts/workflow/project/Doctrine/DBAL/Schema/AbstractSchemaManager.php:242
 Doctrine\DBAL\Schema\AbstractSchemaManager->listTables() at /var/www/vhosts/workflow/project/Doctrine/DBAL/Schema/AbstractSchemaManager.php:830
 Doctrine\DBAL\Schema\AbstractSchemaManager->createSchema() at /var/www/vhosts/workflow/project/Doctrine/ORM/Tools/SchemaTool.php:689
 Doctrine\ORM\Tools\SchemaTool->getUpdateSchemaSql() at /var/www/vhosts/workflow/project/Doctrine/ORM/Tools/SchemaValidator.php:258
 Doctrine\ORM\Tools\SchemaValidator->schemaInSyncWithMetadata() at /var/www/vhosts/workflow/project/Doctrine/ORM/Tools/Console/Command/ValidateSchemaCommand.php:80
 Doctrine\ORM\Tools\Console\Command\ValidateSchemaCommand->execute() at /var/www/vhosts/workflow/project/Doctrine/Symfony/Component/Console/Command/Command.php:187
 Symfony\Component\Console\Command\Command->run() at /var/www/vhosts/workflow/project/Doctrine/Symfony/Component/Console/Application.php:194
 Symfony\Component\Console\Application->doRun() at /var/www/vhosts/workflow/project/Doctrine/Symfony/Component/Console/Application.php:118
 Symfony\Component\Console\Application->run() at /var/www/vhosts/workflow/project/Doctrine/ORM/Tools/Console/ConsoleRunner.php:39
 Doctrine\ORM\Tools\Console\ConsoleRunner::run() at /var/www/vhosts/workflow/project/doctrine.php:36


orm:validate-schema

I throw an eye to DBAL/Platforms/AbstractPlatform.php abstract class and DBAL/Platforms/PostgresSqlPlatform.php implementation. It appears initializeDoctrineTypeMappings() does not care about user custom types that might be declared.

[DBAL-231] Doctrine\DBAL\SQLParserUtils::getPlaceholderPositions() - regex

Sat, 19 Jan 2013 18:27:29 +0000

Running the following SQL (note the named parameter ":account_id"):
===================
SELECT count('*') as cnt FROM feed f INNER JOIN orders_accounts oa ON oa.order_id = f.feed_id INNER JOIN users u ON u.id = f.user_id WHERE oa.account_id = :account_id AND f.feed_type='order' ORDER BY f.create_date DESC
===================

ends up in a thrown exception.
This SQL was generated by using the Query Builder

$qb = $this->_em->getConnection()->createQueryBuilder();
$qb->select('count(\'*\') as cnt');//I know this is bad
$qb->from('feed', 'f');
$qb->innerJoin('f', 'orders_accounts', 'oa', 'oa.order_id = f.feed_id');
$qb->innerJoin('f', 'users', 'u', 'u.id = f.user_id');
$qb->where('oa.account_id = :account_id AND f.feed_type=\'order\'');
$qb->setParameter('account_id', $accountId, \PDO::PARAM_INT);

$stmt = $qb->execute();
$res = $stmt->fetchAll(\PDO::FETCH_COLUMN);

===================
string(82) "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'NULL_id' in 'where clause'"
string(3168) "#0 /var/www/cake_to_zf/library/Doctrine/DBAL/Connection.php(628): PDOStatement->execute()
#1 /var/www/cake_to_zf/library/Doctrine/DBAL/Query/QueryBuilder.php(185): Doctrine\DBAL\Connection->executeQuery('SELECT count('*...', Array, Array)
#2 /var/www/cake_to_zf/library/of/doctrine/SqlQueryBuilderPaginatorAdapter.php(69): Doctrine\DBAL\Query\QueryBuilder->execute()
#3 /var/www/cake_to_zf/library/Zend/Paginator.php(1060): of\doctrine\SqlQueryBuilderPaginatorAdapter->count()
.......

Suggested Fix:

Regex on line 64 in preg_match becomes '#([:a-zA-Z0-9_]

{1}

)#'
Added was an "_" ...

===================

[DBAL-41] missing column type "float"

Sun, 31 Oct 2010 10:10:59 +0000

The former supported column type "float" is not defined in Doctrine\DBAL\Types\Type.

I noticed that floats are mapped like numerics/decimals within mysq right nowl:

protected function _getPortableTableColumnDefinition($tableColumn)
    {
       ...
        // Map db type to Doctrine mapping type
        switch ($dbType) {
            ...
            case 'float':
            case 'double':
            case 'real':
            case 'numeric':
                $type = 'decimal';
                break;

I suggest to map them to a "true" float and double as available in mysql, since they use less storage space compared to numerics with fixed decimals in certain cirtumstances (-> performance issue). http://dev.mysql.com/doc/refman/5.0/en/storage-requirements.html

[DBAL-2] Schema Comparator - Changes of only Identifier Strategy are not detected

Duplicate — Sun, 13 Jun 2010 14:24:48 +0000

When changing metdata from a NONE to an IDENTITY generator only for example on MySQL, SchemaComparator does not pick up the changes.

[DBAL-1] PostgreSQL driver doesn't support date type TIMESTAMP WITHOUT TIME ZONE

Sun, 20 Jun 2010 10:56:46 +0000

Doctrine PostgreSqlPlatform driver supports only TIMESTAMP(0) WITH TIME ZONE, but I think TIMESTAMP WITHOUT TIME ZONE is also often used so Doctrine should support it.

[DBAL-10] Implement PDO SqlSrv

Sun, 13 Jun 2010 08:10:04 +0000

Implement PDO SqlSrv

[DBAL-5] Generalize SchemaManager Db Column to Doctrine Type Detection

Dependency — Sun, 13 Jun 2010 06:39:15 +0000

Currrently the Transformation from each Database Column to a Doctrine Type is hardcoded in the SchemaManager. This code has to be generalized and moved to the Platform so that people supplying custom doctrine types can overwrite this. The API for this sould look like:

$platform->registerDoctrineType($doctrineTypeName, $dbColumnType)

This way we could supply all the defaults using this API and give users the ability to overwrite or extend it based on their needs.

[DBAL-6] MySQL BLOB datatypes throw DoctrineException::unknownColumnType() exception

Dependency — Sun, 30 Oct 2011 22:25:41 +0000

MySQL BLOB datatype appears to be breaking ClassMetadataExporter. Very new to Doctrine so hopefully I've isolated this correctly.

CREATE TABLE foo (
    id      BIGINT UNSIGNED NOT NULL AUTO_INCREMENT,
    bar   BLOB,
    PRIMARY KEY (id)
) ENGINE=InnoDB;

// ... setup entitymanager ....

$cme = new \Doctrine\ORM\Tools\Export\ClassMetadataExporter();
$sm = $em->getConnection()->getSchemaManager();
$cme->addMappingSource($sm, 'database');
$metadatas = $cme->getMetadatasForMappingSources();
$exporter = $cme->getExporter('annotation', '/path/to/annotations');
$exporter->setMetadatas($metadatas);
$exporter->export();

php -f doctrine Orm:convert-mapping --from-database --to=annotation --dest C:\www\app\models

Fatal error: Uncaught exception 'Doctrine\Common\DoctrineException' with message 'Unknown column type' in C:\www\app\lib\Doctrine\Common\DoctrineException.php:112

Stack trace:
#0 [internal function]: Doctrine\Common\DoctrineException::__callStatic('unknownColumnTy...', Array)
#1 C:\www\app\lib\Doctrine\DBAL\Types\Type.php(125): Doctrine\Common\DoctrineException::unknownColumnType('blob')
#2 C:\www\app\lib\Doctrine\DBAL\Schema\MySqlSchemaManager.php(262): Doctrine\DBAL\Types\Type::getType('blob')
#3 C:\www\app\lib\Doctrine\DBAL\Schema\AbstractSchemaManager.php(802): Doctrine\DBAL\Schema\MySqlSchemaManager->_getPortableTableColumnDefinition(Array)
#4 C:\www\app\lib\Doctrine\DBAL\Schema\AbstractSchemaManager.php(221): Doctrine\DBAL\Schema\AbstractSchemaManager->_getPortableTableColumnList(Array)
#5 C:\www\app in C:\www\app\lib\Doctrine\Common\DoctrineException.php on line 112

[DBAL-12] Add Doctrine\DBAL\SQLQuery package with simple Query Objects

Sun, 15 May 2011 17:23:13 +0000

We should add a Query Objects package to Doctrine\DBAL. This won't necessarily be used with Doctrine\ORM, however it could be really helpful to people that only plan to use Doctrine\DBAL and not the ORM.

Requirements:

Add Query Objects for all types of SELECT, INSERT, UPDATE, DELETE
Fluent Interface
Make use of Platform to abstract limit subquery and expressions
Add factory method on Doctrine\DBAL\Connection

API Ideas:

For the INSERT, UPDATE, DELETE I like the approach taken by eZ Components: http://www.ezcomponents.org/docs/api/trunk/introduction_Database.html#query-abstraction
For the SELECT I find Zend_Db_Select much more usable: http://framework.zend.com/manual/en/zend.db.select.html

Are there query objects in other languages that could help here?

[DBAL-43] Doctrine\DBAL\Platforms\MsSqlPlatform Generates invalid T-SQL

Sat, 27 Nov 2010 12:40:02 +0000

MsSqlPlatform::getAlterTableSQL generates a reasonable quantity of invalid T-SQL (to my knowledge, I'd happily be corrected if wrong).

Unfortunately SqlSrv (to my knowledge) only accepts "ALTER old_old_name column_definition" and renames of tables and columns are only capable using a stored procedure.

I'm happy to produce a patch but I think I need a bit of guidance to do so more quickly

The major one is that getAlterTableSQL will need to produce multiple SQL statements, but in my testing I'm not able to get this to do so without some additional problems, and I've not yet had the opportunity to dive into the bowels of the rest of the schema bits and bobs to understand why. If anyone could point me in the vague direction that would be really handy

[DBAL-42] Use column comments for further Doctrine Type Inference

Duplicate — Sun, 20 Feb 2011 04:39:12 +0000

Any custom type could use vendors column comment functionalities to allow more details on the specific type of a column that can be used inside the "listTableColumns()" method.

[DBAL-39] SQL Logger should log the last failed query

Sun, 15 Aug 2010 14:57:22 +0000

The SQL Logger is only called after a query has been executed (this was changed to allow profiling of the queries). This makes it difficult to determine which query has failed.

The commit that changed the functionality is at: http://github.com/doctrine/dbal/commit/fe0f0e4b8c6c5308cab3d683c552f61317de7067

It seems that the logger interface needs to be changed to two functions, a pre-query function and a post-query function. Profiling should be handled by the logger if it chooses and not by the connection class.

[DBAL-37] auto increment can not be added to a column, when postgresql is used.

Sun, 25 Jul 2010 17:32:01 +0000

To add auto increment to on column using the following code in the
migration class:

$systemSettingsTable->changeColumn('setting_id',
array('autoincrement' => true));
or
$settingIdColumn = $systemSettingsTable->getColumn('setting_id');
$settingIdColumn->setAutoincrement(true);

This works fine when MySQL is used. But when PostGreSQL is used, this
statement doesn't create any SQL statement.

The patch in attachment could perhaps resolve this problem some way.

[DBAL-34] MySql getListTableForeignKeysSQL doesn't work for 5.0.xx

Mon, 15 Aug 2011 10:00:48 +0000

The sql contains mysql specific code. And for the mysql 5.0.xxx the sql statement has syntax error.

in /Doctrine/DBAL/Platforms/MySqlPlatform.php:
public function getListTableForeignKeysSQL($table, $database = null)
{
$sql = "SELECT DISTINCT k.`CONSTRAINT_NAME`, k.`COLUMN_NAME`, k.`REFERENCED_TABLE_NAME`, ".
"k.`REFERENCED_COLUMN_NAME` /*!50116 , c.update_rule, c.delete_rule */ ".
"FROM information_schema.key_column_usage k /*!50116 ".
"INNER JOIN information_schema.referential_constraints c ON ".
" c.constraint_name = k.constraint_name AND ".
" c.table_name = '$table' */ WHERE k.table_name = '$table'";

if ($database)

{ $sql .= " AND k.table_schema = '$database' AND c.constraint_schema = '$database'"; }

$sql .= " AND `REFERENCED_COLUMN_NAME` is not NULL";

return $sql;
}

For the mysql lower as 5.1.16 the SQL could be as the following:

SELECT DISTINCT k.`CONSTRAINT_NAME`, k.`COLUMN_NAME`, k.`REFERENCED_TABLE_NAME`, k.`REFERENCED_COLUMN_NAME` FROM information_schema.key_column_usage k WHERE k.table_name = 'some_table' AND k.table_schema = 'some database' AND c.constraint_schema = 'some database' AND `REFERENCED_COLUMN_NAME` is not NULL

In this statement there is no reference of c

[DBAL-33] Doctrine2 fails handling microseconds from PostgreSQL record

Sat, 24 Jul 2010 18:56:40 +0000

A column in database may be defined as both TIMESTAMP WITH TIMEZONE and TIMESTAMP WITHOUT TIMEZONE. If I insert a new value directly to the database through NOW() function, the value is stored including microseconds.

But then, when I am trying to load the record to Doctrine entity, following exception is thrown:

—

Doctrine\DBAL\Types\ConversionException

Could not convert database value "2010-07-17 15:29:57.762+02" to Doctrine Type datetimetz

File: C:\dev\etrener\library\Doctrine\DBAL\Types\ConversionException.php Line: 46

—

The same with both datetime and datetimetz columns.

The problem is probably in PostgreSqlPlatform::getDateTimeTzFormatString(), where is the following row:
public function getDateTimeTzFormatString()

{ return 'Y-m-d H:i:sO'; }

But PostgreSQL stores timestamps with microseconds, so format should be maybe something like:

{ return 'Y-m-d H:i:s.uO'; }

The problem is already posted in http://www.doctrine-project.org/jira/browse/DBAL-22?focusedCommentId=13574&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_13574, but that issue is already closed so maybe it was overlooked already then.

Thank you for fix!

[DBAL-30] Doctrine\DBAL\Connection::query() method does not connect automatically to the database

Wed, 30 Jun 2010 14:08:05 +0000

The database access methods in Doctrine\DBAL\Connection automatically connect to the database, if the connection has not been created yet. This is not true in case of Doctrine\DBAL\Connection::query() - if we forget to connect manually, we get:

Warning: call_user_func_array() expects parameter 1 to be a valid callback, first array member is not a valid class name or object in /.../Doctrine/DBAL/Connection.php on line 608

The problem is caused by the lack of

$this->connect();

line within the method body.

[DBAL-29] Comparator: Changing one column name and dropping one leads to changing both into the new name.

Wed, 30 Jun 2010 14:29:42 +0000

If you have a table and in a new version rename one and drop another column both of exactly the same definition, the comparator will errorusly optimize the one to rename both columns to the new one.

In these cases where it is not detectable which is the renamed and which the dropped it should drop both columns and create the new one. The user has to optimize this himself.

[DBAL-26] DateTime type column can't be nullable

Sun, 27 Jun 2010 13:05:27 +0000

After upgrade from B1 to B2 my app stopped working, throwing ConversionException on nullable DateTime field, value of which is null.
There is part of DateTimeType.php which causes it - if (!$val) matches even the valid null value.

public function convertToPHPValue($value, AbstractPlatform $platform)
{
$val = ($value !== null)
? \DateTime::createFromFormat($platform->getDateTimeFormatString(), $value) : null;
if (!$val)

{ throw ConversionException::conversionFailed($value, $this->getName()); }

return $val;
}

[DBAL-24] Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S02]: Base table or view not found: 1109 Unknown table

Sat, 27 Nov 2010 13:07:34 +0000

The /Doctrine/DBAL/Platforms/MySqlPlatform->getListTableForeignKeysSQL() method returns SQL, that causes the following error:

exception 'PDOException' with message 'SQLSTATE[42S02]: Base table or view not found: 1109 Unknown table 'variables' in information_schema' in X:\home\localhost\www\incubator\doctrine2\libraries\Doctrine\DBAL\Connection.php:568
Stack trace:
#0 X:\home\localhost\www\incubator\doctrine2\libraries\Doctrine\DBAL\Connection.php(568): PDO->query('SELECT DISTINCT...')
#1 X:\home\localhost\www\incubator\doctrine2\libraries\Doctrine\DBAL\Connection.php(524): Doctrine\DBAL\Connection->executeQuery('SELECT DISTINCT...', Array)
#2 X:\home\localhost\www\incubator\doctrine2\libraries\Doctrine\DBAL\Schema\AbstractSchemaManager.php(254): Doctrine\DBAL\Connection->fetchAll('SELECT DISTINCT...')
#3 X:\home\localhost\www\incubator\doctrine2\libraries\Doctrine\DBAL\Schema\AbstractSchemaManager.php(214): Doctrine\DBAL\Schema\AbstractSchemaManager->listTableForeignKeys('variables')
#4 X:\home\localhost\www\incubator\doctrine2\libraries\Doctrine\DBAL\Schema\AbstractSchemaManager.php(199): Doctrine\DBAL\Schema\AbstractSchemaManager->listTableDetails('variables')
#5 X:\home\localhost\www\incubator\doctrine2\libraries\Doctrine\ORM\Mapping\Driver\DatabaseDriver.php(155): Doctrine\DBAL\Schema\AbstractSchemaManager->listTables()
#6 X:\home\localhost\www\incubator\doctrine2\libraries\Doctrine\ORM\Mapping\ClassMetadataFactory.php(103): Doctrine\ORM\Mapping\Driver\DatabaseDriver->getAllClassNames()
#7 X:\home\localhost\www\incubator\doctrine2\index.php(53): Doctrine\ORM\Mapping\ClassMetadataFactory->getAllMetadata()
#8 {main}

The sessions table looks like:

CREATE TABLE `sessions` (
  `id` char(32) NOT NULL DEFAULT '',
  `modified` int(11) DEFAULT NULL,
  `lifetime` int(11) DEFAULT NULL,
  `data` text,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 |

[DBAL-22] Saving UTC Offset in Postgres DATETIME messes with PHP DateTime and Timezones

Tue, 13 Jul 2010 07:42:05 +0000

The DateTime type is currently unusable in PostgreSQL due to a wrong parsing format.

PostgreSqlPlatform::getDateTimeFormatString() should be changed from:

Y-m-d H:i:sO

Y-m-d H:i:s.uO

According to http://twitter.com/auroraeosrose/statuses/16154268629

Also, there's no way to check if a convert From and To PHP/Database worked correctly. Maybe we should introduce an exception when a DBAL\Type conversion fails, otherwise, there's no way to figure it out what happened.