Doctrine Project

[DBAL-522] BC break : executeQuery with an array containing null value(s).

Tue, 21 May 2013 05:58:01 +0000

Hello, i have got an error with doctrine 2.3.4 when i try to run the following code :

 
    $conn->executeQuery(
        'INSERT INTO FOO (foo, bar) values (:foo, :bar)', 
         array('foo' => 1, 'bar' => null)
     );

Error : Value for :bar not found in params array. Params array key should be "bar"

This code worked with doctrine 2.3.3.

I think the error comes from the function 'extractParam' in SQLParserUtils.php (DBAL)

line 215 : if (isset($paramsOrTypes[$paramName]))

The key exists even if the value is null.
So it should be:

  if (array_key_exists($paramName, $paramsOrTypes))

I am not enough confident to try a PR.
Thanks in advance!

[DBAL-524] [GH-322] DBAL-522

Tue, 21 May 2013 05:54:38 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/dbal/pull/322

Message:

Hotfix for ~~DBAL-522~~(http://www.doctrine-project.org/jira/browse/DBAL-522)

Demonstrates that NULL parameters are handled incorrectly by `Doctrine\DBAL\SqlParserUtils` as of 2.3.4.

Basically, following usage always throws an exception:

$conn->executeQuery(
    'INSERT INTO FOO (foo, bar) values (:foo, :bar)', 
    array('foo' => 1, 'bar' => null)
);

[DBAL-523] [GH-321] Changed property visibility to protected

Mon, 20 May 2013 15:25:34 +0000

This issue is created automatically through a Github pull request on behalf of barnabywalters:

Url: https://github.com/doctrine/dbal/pull/321

Message:

The main reason being to allow QueryBuilder to be subclassed �� for example so that we can fix issues like problematic shallow cloning locally and use them without having to wait for a pull request to be merged.

[DBAL-518] [GH-318] Update Type.php

Fri, 17 May 2013 07:12:35 +0000

This issue is created automatically through a Github pull request on behalf of vincequeiroz:

Url: https://github.com/doctrine/dbal/pull/318

Message:

Camel case methods names.