Doctrine Project

[DBAL-81] Add support for auto-commit = NO accross databases

Thu, 20 Sep 2012 06:19:57 +0000

Currently all databases are running in AUTO-COMMIT = Yes Mode. This means that you have to explicitly open a transaction to be able to use transactional features.

There should be support to run in auto-commit = no mode, which means after connect and after each commit a new transaction is opened automatically.

[DBAL-76] PostgreSQL Platform list* SQL code is in need of serious love

Wed, 8 Jun 2011 17:05:08 +0000

The Postgres Schema code is very hard to read and inconsistent across the board. Some use pg_class, some pg_tables. Namespaces /Schema are not always properly checked for. There should be a really unified way on how to approach schema query issues.

[DBAL-69] Varchar definition should automatically switch to CLOB for sizes larger than max varchar length.

Thu, 20 Sep 2012 06:19:57 +0000

In the future we would probably allow arbitrary large sizes here and switch to a CLOB definition automatically if the specifed string length is larger than max length.

[DBAL-163] Upsert support in DBAL

Thu, 20 Sep 2012 06:19:57 +0000

Upsert support in DBAL (replace, insert into usw..)

[DBAL-155] Github-PR-46 by gnomii: 2.1.x PgSql - Same problem with the master

Sun, 21 Aug 2011 14:46:20 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/dbal/pull/46

Message:

Hi,

Sorry, I was not able to merge the branchs with the master I try some methods

Best regards,
Maxime

[DBAL-153] Github-PR-48 by phekmat: Added a regression test case for recently fixed PostgreSQLSchemaManager bug

Sat, 24 Mar 2012 08:10:47 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/dbal/pull/48

Message:

Regression test for the following change: https://github.com/doctrine/dbal/commit/2434d95aab231273eea8fb555155e9e9c195bcc9

[DBAL-156] Github-PR-44 by richardfullmer: [PostgresPlatform] Fixing change detection when a default is removed

Sun, 21 Aug 2011 14:46:22 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/dbal/pull/44

Message:

Change detection when the default value is removed from a field is presently broken and produces invalid SQL.

This patch checks to see if a new default value actually exists before adding the SET DEFAULT '';

Uses DROP DEFAULT when the new default value does not exist

[DBAL-154] Github-PR-47 by gnomii: 2.0.x PgSql - Same problem with the master

Sun, 21 Aug 2011 14:46:19 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/dbal/pull/47

Message:

Hi,

Sorry, I was not able to merge the branchs with the master I try some methods

Best regards,
Maxime

[DBAL-369] [GH-219] Fix storage of binary data for array and object types

Fri, 19 Oct 2012 11:54:02 +0000

This issue is created automatically through a Github pull request on behalf of kdambekalns:

Url: https://github.com/doctrine/dbal/pull/219

Message:

serialize() returns binary data (NUL bytes) and not all platforms
handle that in CLOB fields (e.g. PostgreSQL).

This change uses base64 encoding to work around that, and transparently
reads (old) non-base64 data as well.

Fixes ~~DBAL-368~~

[DBAL-348] [GH-202] Fixed DBAL-139 Oracle's sequences with NOCACHE

Sun, 6 Jan 2013 18:56:59 +0000

This issue is created automatically through a Github pull request on behalf of AduroIdea:

Url: https://github.com/doctrine/dbal/pull/202

Message:

[DBAL-333] [GH-193] Add DBAL\TypeAwareObject.

Wed, 5 Sep 2012 17:21:13 +0000

This issue is created automatically through a Github pull request on behalf of Romain-Geissler:

Url: https://github.com/doctrine/dbal/pull/193

Message:

This PR adds a common interface for custom object values that requires some PHP <-> SQL conversions, which allows to specify what DBAL type must be used for conversion.

[DBAL-327] [GH-188] Akiban driver

Wed, 29 Aug 2012 08:37:39 +0000

This issue is created automatically through a Github pull request on behalf of posulliv:

Url: https://github.com/doctrine/dbal/pull/188

Message:

An initial implementation of a driver for the [Akiban Server](http://www.akiban.com/akiban-server). You will notice in the diff there are some features Akiban does not yet support in its latest release but are planned for future releases.

I wasn't sure if pull request was the best way to start a dialog to get this work accepted or whether the mailing list is more appropriate. Please let me know and I will do as suggested.

I am an engineer at Akiban and am very willing to maintain/improve this driver.

[DBAL-325] [GH-186] Added third an optional argument `types` to use prepared statement

Wed, 29 Aug 2012 09:04:44 +0000

This issue is created automatically through a Github pull request on behalf of timoshenko:

Url: https://github.com/doctrine/dbal/pull/186

Message:

[DBAL-320] allow SQL QueryBuilder to do INSERTS

Mon, 13 Aug 2012 13:12:47 +0000

With

$db = \Doctrine\DBAL\DriverManager::getConnection($connectionParams, $config);
$qb = $db->createQueryBuilder();

this QueryBuilder I'm able to do SELECT, UPDATE and DELETE. However, INSERT is not possible. Are there any good reasons for this?

Attached you find a patch that until now works fine for me. I don't know, however, if there are any side effects.

[DBAL-321] [GH-184] Added INSERT support to dbal QueryBuilder

Tue, 14 Aug 2012 20:49:18 +0000

This issue is created automatically through a Github pull request on behalf of Tim-Erwin:

Url: https://github.com/doctrine/dbal/pull/184

Message:

See also http://www.doctrine-project.org/jira/browse/DBAL-320
Please review and commit as fits.

[DBAL-225] Add events for onBeginTransaction, onCommit, onCommitFailure

Thu, 20 Sep 2012 06:19:57 +0000

Allow to switch a CommitFailure into a successful event.

This could be done by saving all insert/update/delete statements starting from begin transaction and then replaying them N-times until success is achieved.

[DBAL-221] Schema toSQL() and toDropSQL() both need to delegete creation/drop of schema-level elements

Thu, 20 Sep 2012 06:19:57 +0000

The following schema-level changes have to be done before tables are created:

create Schema (PGSQL, MySQL, ...)
Create Federations (Azure)
Create Types (PGSQL, Oracle, ...)
Create Views, Stored Procedures, Triggers

We should add the following APIs:

array $sql AbstractPlatform::getCreateSchemaAdditionalStatements(Schema $schema);
$object = new SQLObject($sqlUpCommand, $sqlDropCommand);
$schema->addSQLObject($object);

[DBAL-217] Introduction Interface for Connection

Thu, 20 Sep 2012 06:19:57 +0000

Introduction Interface for Connection

[DBAL-218] Add Object for BulkInsert Abstraction

Thu, 20 Sep 2012 06:19:57 +0000

Add Object for BulkInsert Abstraction

[DBAL-215] DoctrineBundle Configuration File

Fri, 3 Feb 2012 20:49:37 +0000

In the DoctrineBundle, there is no support for "master" or "slave", yet the "MasterSlaveConnection" in the new DBAL branch wants both of them in the connection.

[DBAL-182] Insert and Merge Query Objects

Thu, 20 Sep 2012 06:19:57 +0000

We are missing Insert and Merge Query Objects.

See Drupal DBTNG:

Merge: http://drupal.org/node/310085
Insert: http://drupal.org/node/310079

[DBAL-305] [GH-171] provide transactional interface for EntityManager and Connection

Sun, 29 Jul 2012 08:50:02 +0000

This issue is created automatically through a Github pull request on behalf of dfreudenberger:

Url: https://github.com/doctrine/dbal/pull/171

Message:

[DBAL-300] Updates for Fedora packaging

Sat, 24 Nov 2012 02:20:36 +0000

I am packaging the DoctrineDBAL PEAR package for Fedora and RHEL (EPEL) and would like to have the following updates:

package.xml role for LICENSE changed from "data" to "doc"

package.xml role for Doctrine/DBAL/README.markdown changed from "data" to "doc"

add some content to Doctrine/DBAL/README.markdown (when building RPM this file throws a warning because it is empty)

[DBAL-294] [GH-163] [WIP] Upsert support protoype.

Wed, 4 Jul 2012 19:32:56 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/163

Message:

[DBAL-291] [GH-157] interface compatibility

Wed, 4 Jul 2012 20:25:43 +0000

This issue is created automatically through a Github pull request on behalf of Nazin:

Url: https://github.com/doctrine/dbal/pull/157

Message:

[DBAL-284] [GH-152] add ComparatorInterface to allow custom Comparator implementation

Tue, 22 May 2012 17:12:30 +0000

This issue is created automatically through a Github pull request on behalf of catacgc:

Url: https://github.com/doctrine/dbal/pull/152

Message:

[DBAL-273] Allow MasterSlave Connection to switch back to slave

Fri, 11 May 2012 19:23:04 +0000

Allow MasterSlave Connection to switch back to slave

[DBAL-249] Enable caching for fetch type FETCH_COLUMN

Thu, 5 Apr 2012 08:45:51 +0000

If results are requested using fetch method FETCH_COLUMN, and the cache is used, the exception is raised:

Invalid fetch-style given for caching result

[DBAL-449] [GH-274] Support column charset/collation on capable platforms

Tue, 19 Feb 2013 00:28:10 +0000

This issue is created automatically through a Github pull request on behalf of adrienbrault:

Url: https://github.com/doctrine/dbal/pull/274

Message:

Basically the same feature wanted as in #245

[DBAL-415] [GH-248] Enable multiple postgresql datetime formats

Mon, 14 Jan 2013 13:23:11 +0000

This issue is created automatically through a Github pull request on behalf of cedriclombardot:

Url: https://github.com/doctrine/dbal/pull/248

Message:

Postgre use ISO 8601 date formats so some times can be Y-m-d H:i:s or sometime Y-m-d H:i:s.u

[DBAL-390] Wrap SQL for Selects in an Object for Metadata?

Fri, 23 Nov 2012 12:48:05 +0000

Wrap SQL for Selects in an Object for Metadata?

[DBAL-100] Add Drizzle Support

Thu, 22 Dec 2011 21:10:27 +0000

Drizzle is out, we should add support for the Dialect.

http://docs.drizzle.org/mysql_differences.html

[DBAL-242] Catch and re-throw exceptions with common messages + codes

Thu, 20 Sep 2012 06:19:57 +0000

Catch and re-throw exceptions with common messages + codes

[DBAL-40] Transparent table&column names escaping

Reference — Sat, 2 Feb 2013 08:45:10 +0000

Hello, I would like to re-open the discussion about automatic transparent escaping of all table/column names sent from DBAL to database. It was already discussed in http://www.doctrine-project.org/jira/browse/DDC-88 without any satisfactory result.

Why do I have to quote any reserved word used in table or column name? Why Doctrine doesn't do this automatically for all table and column
names used in generated SQL queries?

Before you start to explain how complicated it is and what problems you will be faced with, try to look at excellent DIBI database layer - how it acts in this way - it's behaviour is very cool. Unfortunally at the moment the full documentation is in czech only, but here is a brief automatic google-translation to english - http://dibiphp.com/en/quick-start.

My suggestion to Doctrine 2 ORM/DBAL solution is:

1. Developer should never care about any escaping or avoiding any reserved words - it is not his business, the DBAL shoult solve it transparently and safely.

2. So there should be no need and even no possibility to add any quotation chars in @column or @table annotations as well as in DQL queries. ORM layer has nothing to do with escaping, it is all a business of the DBAL layer. Current possibility for manual escaping the names in mentioned annotations is totally wrong and should be discontinued.

3. DBAL should escape ALL table and column names transparently and automatically. There should be ne option to enable or disable the escaping, there is no reason for disabling it.

4. The escaping should be performed just in the final translation of DBAL queries to native SQL query, not earlier. This is the right place to do that.

So what do you think about that?

[DBAL-31] Move Schema related Creation code from AbstractPlatform to AbstractSchemaManager

Fri, 24 Dec 2010 05:23:51 +0000

Move Schema related Creation code from AbstractPlatform to AbstractSchemaManager

[DBAL-463] [GH-285] Add IBM iSeries Driver

Thu, 14 Mar 2013 21:49:22 +0000

This issue is created automatically through a Github pull request on behalf of spicajames:

Url: https://github.com/doctrine/dbal/pull/285

Message:

Added driver pdo_ibmi to support to db2 iSeries using pdo_odbc

[DBAL-275] Automatically attempt to reconnect a dropped persistent MySQL-connection (MySQL server has gone away)

Wed, 21 Nov 2012 11:39:50 +0000

For php-scripts that run for a long time (a.o. daemons) persistent connections will almost always be dropped by the MySQL-server after a set timeout (depending on wait_timeout). This will have Doctrine throw an exception and have the php-script terminate if not catched. It is not practical to catch the same Exception with a try-catch around every query.

I have fixed this for DBAL 2.1.6 by adding a custom layer of Statement-, Connection- and Driver classes.
Key functionalities:

The custom layer will transparently catch dropped connections and attempt a number of times (configurable) to reconnect.
The behaviour will not be triggered in a transaction (in that case it will revert to throwing an exception just like before).
The reconnect behaviour is not MySQL specific per se. It can be triggered by any Exception for any Driver-type if a Driver provides a method 'getReconnectExceptions'.
Minimal performance-impact. Only when an Exception is thrown will it be searched for a matching Exception to possibly trigger the behaviour. (also the reason a single stringmatch is used)

Why this functionality?

It is often not possible to change settings of a database-server.
In a production environment the MySQL wait_timeout is often set to mere seconds
Doctrine's use of persistent connections will become a little more persistent
More reliable and robust php-scripts built on top of the DBAL

See files in attached archive to get an idea of the code. Enabling the layer is currently done like this (Symfony2 yml):
doctrine:
dbal:
wrapper_class: DoP\DoPBundle\Doctrine\DBAL\Connection
driver_class: DoP\DoPBundle\Doctrine\DBAL\Driver\PDOMySql\Driver
options:
x_reconnect_attempts: 2

Maybe I overlook something, but I only see pro's, no cons, to this improvement. I have created this issue to poll if you think this is a welcome feature and are interested to have me rework the code into DBAL itself? Reworking it into DBAL itself would certainly greatly reduce my code.

If agreed I'll create a github pull request when finished with the code and take comments/improvements from there.

(Also, I have glanced over http://www.doctrine-project.org/contribute.html but did not find any coding/testing-guidelines. Can you point me in the right direction?)

Regards,

Dieter

[DBAL-95] Interbase/Firebird support

Tue, 12 Mar 2013 05:33:10 +0000

Implemented support for Interbase/Firebird dialects

[DBAL-468] [GH-288] Fix fetchColumn not caching

Wed, 20 Mar 2013 20:40:20 +0000

This issue is created automatically through a Github pull request on behalf of Alan01252:

Url: https://github.com/doctrine/dbal/pull/288

Message:

Column cache wasn't working because the emptied flag is only set
when fetch no longer returns a row. With fetch column the code
only calls fetch once and so emptied flag never got set.

Created two test cases, one to test fetchColumn, and one to test
that the return value is false if the data doesn't get saved in the cache.

[DBAL-470] [GH-291] Optimize abstract platform

Sun, 24 Mar 2013 13:54:44 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/291

Message:

This PR optimizes the <code>AbstractPlatform</code> class in the following ways:

Add dedicated use statemtent for each class import
Add missing class imports
Add missing phpDoc blocks for methods
Fix existing phpDocs (parameters, return types, @throws tags, FQDN types, indentation etc.)
"Normalize" phpDocs (consistent verbs for what a method does, reuse of certain phrases for similar method types etc.)
Fix CS
Improve certain code portions

I hope this is a welcomed improvement. It reads much better now and feels somewhat cleaner to me.

[DBAL-475] [GH-293] Add SAP SQL Anywhere database vendor

Sun, 14 Apr 2013 09:57:46 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/293

Message:

This PR adds the driver and DBAL for SAP SQL Anywhere databases. It distinguishes between versions 10 and below (base <code>SQLAnywherePlatform</code>), 11 (<code>SQLAnywhere11Platform</code>) and 12 (<code>SQLAnywherer12Platform</code>), similar to Microsoft SQL Server.
Most of the functional tests pass but there are some exceptions:

<code>DataAccessTest::testFetchAllWithTypes</code>
<pre>
Failed asserting that two strings are equal.
- - Expected
    +++ Actual
    @@ @@
    -'2010-01-01 10:10:10'
    +'2010-01-01 10:10:10.000'
    </pre>
    The test is not aware of the datetime format string of the platform, which differs in SQL Anywhere. Therefore it fails. In SQL Anywhere a datetime is stored with second fractions by default.
    IMO I have two options here. Changing the default timestamp format for data output in the driver on every connection so that it fits <code>Y-m-d H:i:s</code> and changing the date format strings in the platforms or modifying the test to be aware of the platform specific datetime format.

<code>MasterSlaveConnectionTest::testKeepSlaveBeginTransactionStaysOnMaster</code>
The test simply hangs up here and I don't exactly know why. When I change the value for insert in line 95 to some other value than 30 it perfectly works. Any help would be appreciated here.

<code>ModifyLimitQueryTest::testModifyLimitQueryGroupBy</code>
<pre>
Failed asserting that two arrays are equal.
- - Expected
    +++ Actual
    @@ @@
    Array (
- 0 => 1
- 1 => 2
  ++ 0 => 2
  ++ 1 => 1
  )
  </pre>
  The test does not tell the SELECT statement to order the result, thus the result is not deterministic and returns the results in wrong order.
  IMO the test should be fixed so that the result is ordered correctly. Then the test will pass for SQL Anywhere.

<code>TemporaryTableTest</code>
<pre>Exception: [Doctrine\DBAL\DBALException] An exception occurred while executing 'CREATE GLOBAL TEMPORARY TABLE temporary (id INT NOT NULL)':
SQLSTATE [42W04] [-131] Syntaxfehler bei 'temporary' in Zeile 1
With queries:
SQL: 'DROP TABLE temporary' Params:
SQL: 'CREATE GLOBAL TEMPORARY TABLE temporary (id INT NOT NULL)' Params:
SQL: 'DROP TABLE nontemporary' Params:</pre>
The tests use the unquoted keyword "temporary" reserved by SQL Anywhere for the temporary table name to create.
I cannot quote the name of the temporary table in the platform as the method <code>getTemporaryTableName</code> expects a string and not an instance of <code>Doctrine\DBAL\Schema\Table</code> as parameter.
Either the tests should use a non reserved keyword as temporary table name or the temporary table name has to be quoted in the platform (but I don't know exactly how).

<code>TemporaryTableTest::testDropTemporaryTableNotAutoCommitTransaction</code>
<pre>In an event of an error this result has one row, because of an implicit commit.
Failed asserting that two arrays are equal.
- - Expected
    +++ Actual
    @@ @@
    Array (
    ++ 0 => Array (...)
    )
    </pre>
    The test fails because of an implicit commit during the transaction (drop temporary table) which inserts the first value. I couldn't find a solution for this problem. Seems to be the same problem as reported in ~~DDC-1337~~(http://www.doctrine-project.org/jira/browse/DDC-1337).

<code>WriteTest::testLastInsertIdNoSequenceGiven</code>
<pre>Failed asserting that 14 is false.</pre>
I don't exactly know why the test expects the lastInsertId to be false here. Using the same connection for 14 inserts into a newly created autoincrement table should result in lastInsertId = 14 IMO. Is this a bug in the test? How do other vendors behave here?

I hope this addition is appreciated and any feedback/help on the above issues would be welcomed.

[DBAL-489] [GH-302] [DBAL-374] Fix asset identfier quotation

Wed, 1 May 2013 09:09:18 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/302

Message:

This PR introduces a real solution for the issues discussed in ~~DBAL-374~~(http://www.doctrine-project.org/jira/browse/DBAL-374).
It adds the possibility to retrieve quoted column names from <code>Index</code> and <code>ForeignKeyConstraint</code> assets if it is necessary (e.g. column name is a keyword reserved by the platform).
In general column names are wrapped into an abstraction class <code>Identifier</code> which inherits from <code>AbstractAsset</code> inside <code>Index</code> and <code>ForeignKeyConstraint</code>. This allows to get a quoted representation of each column name via the <code>AbstractAsset::getQuotedName</code>.
All platforms are updated to make use of the new functionality.

[DBAL-409] [GH-245] Added support for column collation

Sat, 4 May 2013 13:07:13 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/245

Message:

[DBAL-512] Update schema not working on MsSql due to no support for alter identity

Mon, 6 May 2013 12:36:03 +0000

When running: php app/console doctrine:schema:update --force

[Doctrine\DBAL\DBALException]
An exception occurred while executing 'ALTER TABLE tableName ALTER COLUMN id INT IDENTITY NOT NULL':

SQLSTATE[42000]: [Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near the keyword 'IDENTITY'.

According to this stackoverflow http://stackoverflow.com/a/1049305/1833322 MSSQL does not support this query.

[DBAL-517] [GH-317] Conditionaly upgrade utf8 to utf8mb4 for MySQL 5.5.3

Wed, 15 May 2013 09:20:59 +0000

This issue is created automatically through a Github pull request on behalf of nicolas-grekas:

Url: https://github.com/doctrine/dbal/pull/317

Message:

See http://dev.mysql.com/doc/refman/5.5/en/charset-unicode-utf8mb4.html

As utf8mb4 is a superset of utf8, this should be transparent and backward compatible.
For those really requiring the "utf8" meant by MySQL, they can use explicitely the utf8mb3 charset.
But IMHO by default, Doctrine should really use utf8mb4, which is what everybody expect from a charset named "utf8".

[DBAL-519] MasterSlave connection does not keep Slave connections when there is a transaction

Wed, 15 May 2013 18:01:26 +0000

while doing a transaction (as a result of ORM persist),
the connect function sets the forceMasterAsSlave which result on setting
slave to master,

on future selects, even if keepSlave is set to true
and connecting to 'slave' as ->connect('slave')
we will get master connections

I assume we need to check keepSlave when forcing slaves to master

[DBAL-324] SchemaManager should first look into comment instead of infer the type first.

Tue, 14 May 2013 20:50:07 +0000

When using schema tool, Doctrine tries to infer the Doctrine type via the mapped types in Platform.
It should first try to read from the comment; if found, ignore the Database type inference.

[DBAL-520] [GH-319] Delete unnecessary "use PDO" statement

Thu, 16 May 2013 15:08:21 +0000

This issue is created automatically through a Github pull request on behalf of alexpods:

Url: https://github.com/doctrine/dbal/pull/319

Message:

[DBAL-521] [GH-320] Fixed calculation of differences of columns

Fri, 17 May 2013 08:06:09 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/320

Message:

[DBAL-526] Doctrine\DBAL\Connection::executeQuery changes passed clause

Wed, 22 May 2013 13:24:22 +0000

>> var_dump(get_class($db));

string(24) "Doctrine\DBAL\Connection"

>> var_dump($params);

array(2)

{ [0] => int(18) [1] => int(0) }

>> $stmt = $db->executeQuery('SELECT l0_.id AS id0 FROM link l0_ WHERE l0_.user_id = ? AND l0_.is_deleted = ?', array($params), array(\Doctrine\DBAL\Connection::PARAM_INT_ARRAY));

An exception occurred while executing 'SELECT l0_.id AS id0 FROM link l0_ WHERE l0_.user_id = ?, ? AND l0_.is_deleted = ?' with params [18, 0]: SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens

>> $stmt = $db->executeQuery('SELECT l0_.id AS id0 FROM link l0_ WHERE l0_.user_id = ? AND l0_.is_deleted = ?', $params, array(\PDO::PARAM_INT, \PDO::PARAM_INT));
>> var_dump($stmt->fetchAll());

array(0) {
}

[DBAL-527] [GH-323] Update MasterSlaveConnection.php

Wed, 22 May 2013 14:51:17 +0000

This issue is created automatically through a Github pull request on behalf of ananda-agrawal:

Url: https://github.com/doctrine/dbal/pull/323

Message:

check $this->keepSlave before enforcing master as slave

[DBAL-528] [GH-324] Update SQLServer2008Platform.php (support MS SQL Server type datetimeoffset(6))

Thu, 23 May 2013 09:40:54 +0000

This issue is created automatically through a Github pull request on behalf of valerio8787:

Url: https://github.com/doctrine/dbal/pull/324

Message:

Added support of maps a Doctrine datetimetz type to a MS SQL SERVER type datetimeoffset(6)

[DBAL-529] databasenames including dashes not correctly supported

Fri, 24 May 2013 11:05:27 +0000

I'm having a legacy Database including a dash in its name:

"my-db"

which includes tables I want to work with.

The EntityMapping would be the following:

yml

My\TestBundle\Entity\Stuff:
    type: entity
    table: my-db.stuff
    fields:
        id:
...

annotation

/**
 * @ORM\Entity()
 * @ORM\Table(name="my-db.stuff")
 */

Both concludes in a Query (SELECT, INSERT etc.) which won't work:
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-db.stuff t0 WHERE[...]

I found a simple fix by trial and Error. Just put a "`" in front of the databasename:

yml

My\TestBundle\Entity\Stuff:
    type: entity
    table: `my-db.stuff
    fields:
        id:
...

annotation

/**
 * @ORM\Entity()
 * @ORM\Table(name="`my-db.stuff")
 */

Although this fix works, it feels wrong.
Moreover, to prevent confusing other developers, this should be fixed to one the following styles.

annotation

/**
 * @ORM\Entity()
 * @ORM\Table(name="`my-db`.stuff")
 */

annotation

/**
 * @ORM\Entity()
 * @ORM\Table(name="my-db.stuff")
 */

[DBAL-530] sqlite: foreignKey - definition wrong when tables has databasename as prefix

Fri, 24 May 2013 11:54:14 +0000

Because of the fact that SQLite doesn't support multiple databases in one file, Doctrine handles definitions like that:

/**
 * @ORM\Entity()
 * @ORM\Table(name="database.table")
 */

in this way:

CREATE TABLE database__table[...]

But when another Tabele references a table defined like the one above, the foreignkey definition is generated wrong:

[...]FOREIGN KEY (table_id) REFERENCES database.table (id) NOT DEFER[...]

SQLSTATE[HY000]: General error: 1 near ".": syntax error

I guess this would be the right query:

[...]FOREIGN KEY (table_id) REFERENCES database__table (id) NOT DEFER[...]

[DBAL-59] Add support for PDO_CUBRID driver when stable

Mon, 22 Aug 2011 02:50:07 +0000

CUBRID is a relational database focused on high performance web-apps. If the PDO_CUBRID http://pecl.php.net/package/PDO_CUBRID gets stable or betaish anytime we should think about support it.

[DBAL-179] SQLLogger API improvement: log rows affected

Thu, 10 Nov 2011 11:20:25 +0000

A small suggestion. It is useful in our application to log the affected rows in queries in order to make it easier to trace what queries did what. I think a simple way to enable this in the SQLLogger is to modify the stopQuery() interface to receive an option rowcount parameter.

[DBAL-150] noSQL Shema Management

Sun, 21 Aug 2011 10:03:45 +0000

I have a few ideas to improve DBAL and ORM management for php:
1. Reading if needed ORM schemas definitions from YAML(existing plugin)
2. Then migration it into the one of NoSQL databases(such as MongoDB or Memcache/MemcacheDB)
3. Creating transactional temporary-changes data layer in NoSQL for a current-changes due the webapp launch and running for each run
4. Periodically migrations of a current changes with migration script into RDB(for example by cron)

So we get:
Fast automatic shemas management(Symphony users - I say you "haha" because you have to do some unuseful things like "doctrine:build-schema" etc)
All advantages of RDB (like JOINS) in a data extraction
Full-independence in data changing due to webapp launch(and no transactions are needed) in the current NoSQL data-layer
Low load to the server because after extration we have a lazy return data into the RDB
In feature a simple caching any fast-changed data into NoSQL

What do you thinking about it?

[DBAL-372] Add SQL parser

Thu, 25 Oct 2012 12:52:51 +0000

It is useful for create sql highlighter. See https://github.com/doctrine/DoctrineBundle/pull/117 or https://github.com/doctrine/DoctrineBundle/issues/107

[DBAL-319] Doctrine\DBAL\Types\Type

Sun, 12 Aug 2012 18:34:28 +0000

The API could be improved in the next major release:

Type::add() instead of addType()
Type::isRegistered() instead of hasType() (has sounds weird)

Etc.. I think the 'type' in the methods is redundant since Type is already the object I am dealing with.

I'd also like a remove() method to unregister a type at runtime. Would make testing a little easier and I don't have to check with hasType() etc..

[DBAL-318] getSQLDeclaration

Sun, 19 Aug 2012 22:36:37 +0000

https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Types/Type.php#L119-L125

Should define a @return type. Otherwise you have to step through other types to figure this out.

[DBAL-209] fetchAll should include $types array for executeQuery

Sat, 29 Dec 2012 17:31:21 +0000

The fetchAll function should include a $types parameter since it is utilizing executeQuery.

[DBAL-180] Documentation states that Doctrine 'decimal' (DecimalType) is mapped to PHP 'double', however, string is returned

Thu, 20 Dec 2012 00:31:46 +0000

At http://www.doctrine-project.org/docs/orm/2.1/en/reference/basic-mapping.html#doctrine-mapping-types, it is stated that:

"decimal: Type that maps an SQL DECIMAL to a PHP double."

However, in the commit history, we can see that the casting to a float is removed: https://github.com/doctrine/dbal/commits/master/lib/Doctrine/DBAL/Types/DecimalType.php. Casting to a double is not possible in PHP?This seems to result in a float as well, that is probably why it was removed.

I found this out when using PHP's 'is_double()' function (alias of is_float()) to check whether a decimal property was set or not.

Suggestion is to either:

cast to a double (which seems not possible)
cast to a float (why was this removed?)
do nothing to the code, update documentation that string is returned.

In my check function I guess I will use the is_numeric() function.

[DBAL-292] Multiple use of named parameter doesn't work

Wed, 23 Jan 2013 22:56:54 +0000

In the example in the documentation http://doctrine-dbal.readthedocs.org/en/2.0.x/reference/data-retrieval-and-manipulation.html#dynamic-parameters-and-prepared-statements there is the following example:

$sql = "SELECT * FROM users WHERE name = :name OR username = :name";
$stmt = $conn->prepare($sql);
$stmt->bindValue("name", $name);
$stmt->execute();

When I try this example using pdo_sqlsrv I get the following error:
PDOException: SQLSTATE[07002]: [Microsoft][SQL Server Native Client 11.0]COUNT field incorrect or syntax error

When I use instead the parameters name1 and name2 the query works as expected.

[DBAL-423] Type GUID = VARCHAR(255) on platforms that don't have a native GUID support

Fri, 25 Jan 2013 11:03:03 +0000

I'm using MySQL with entities that have GUID ids. Therefore I'm using @ORM\Column(type="guid") for the ORM mapping. As MySQL does not have a native GUID data type, it gets mapped to type="string" with a default length of 255 -> VARCHAR(255). I don't really understand why we don't limit the length to 36, which is the fixed length for GUIDs. You could even think about using CHAR(36) for MySQL.

-> see Doctrine\DBAL\Platforms\AbstractPlatform -> getGuidTypeDeclarationSQL()

[DBAL-464] MySQL fails when try to drop a primary index with Auto Increment

Thu, 14 Mar 2013 14:52:14 +0000

When an update of schema tries to drop a primary key with "auto increment" property (example : @ORM\GeneratedValue(strategy="AUTO")), the execution will fail : it say :
[Doctrine\DBAL\DBALException]
An exception occurred while executing 'ALTER TABLE odesadicola DROP PRIMARY KEY':

SQLSTATE[42000]: Syntax error or access violation: 1075 Incorrect table definition; there can be only one auto column and it must be defined as a key

Apparently, this error occurs because Doctrine try to execute a "drop primary key" on a table and the resulting column of old primary key will be "auto increment".

The answer is to remove "auto increment" attribut of primary key column juste before try to drop the primary key itself.

[DBAL-200] Connection::update()

Tue, 11 Dec 2012 16:46:40 +0000

missing @param array $data in docblock