Doctrine Project

[DBAL-322] Change Detection fails when 'unsigned' is used in MySQL Schema

Tue, 14 Aug 2012 21:10:15 +0000

Change Detection fails when 'unsigned' is used in MySQL Schema

[DBAL-212] Unknown database type longvarchar requested, Doctrine\DBAL\Platforms\SqlitePlatform may not support it.

Sat, 28 Jan 2012 09:31:53 +0000

SqlitePlatform lacks "longvarchar" type mapping which is extensively used by browsers sqlite databases (e.g. places in FF, history in Chrome).
Trying to get a schema ends up with 'Unknown database type longvarchar requested, Doctrine\DBAL\Platforms\SqlitePlatform may not support it.' message.

[DBAL-211] wrong where clause in PostgreSqlPlatform::getTableWhereClause

Sat, 28 Jan 2012 09:55:23 +0000

I have the folowing table structure:

Schema "public": with one table called "users"
Schema "forums": with one table called "users"

methods like PostgreSqlPlatform::getListTableForeignKeysSQL($table, $database = '') should list FK inside $table

the default search path is "public,pg_catalog"

calling PostgreSqlPlatform::getListTableForeignKeysSQL('users') it shuld extract the FK from public.users table, but this is the current result:

[PDOException] SQLSTATE[21000]: Cardinality violation: 7 ERROR: more than one row returned by a subquery used as an expression

this exception is thrown because PostgreSqlPlatform::getTableWhereClause do not cosider the current search path.

i propose the following implementation for PostgreSqlPlatform::getTableWhereClause

 
    private function getTableWhereClause($table, $classAlias = 'c', $namespaceAlias = 'n')
    {
        $whereClause = $namespaceAlias.".nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND ";
        if (strpos($table, ".") !== false) {
            list($schema, $table) = explode(".", $table);
            $whereClause .= "$classAlias.relname = '" . $table . "' AND $namespaceAlias.nspname = '" . $schema . "'";
        } else {
            // $whereClause .= "$classAlias.relname = '" . $table . "'"; // this was the current implementation
            $whereClause .= "$classAlias.relname = '" . $table . "' AND $namespaceAlias.nspname = ANY(string_to_array((select setting from pg_catalog.pg_settings where name = 'search_path'),','))";
        }

        return $whereClause;
    }

this implementation will restrict the search range only to current "search_path".

(sorry for my english)

[DBAL-207] RemoveNamespacedAssets: Foreign Key removing does not work correctly

Sun, 22 Jan 2012 17:36:23 +0000

RemoveNamespacedAssets: Foreign Key removing does not work correctly

[DBAL-206] OraclePlatform causes problems with more schemas with same table names

Sat, 21 Jan 2012 14:11:54 +0000

OraclePlatform is using the ALL_* tables to fetch schema information but is only supplying the table name in the where condition. This causes problems when you have multiple schemas with tables that have the same name. Their columns/FK get mixed up.

My colleague and I have traced the problem down to the OraclePlatform class and replaced the ALL_* tables with USER_*. The fix for that is on github https://github.com/FranPregernik/dbal/commit/c70bc462b49a168105304cdff0086dcd15cc347d.

As mentioned in the comment message the other fix would be to fetch the schema name (user) of the table and add it to the where part of the queries. Something like this:

t.owner = user

A pull request has been made on github for this.

[DBAL-205] MySQL SchemaManager doesn't handle composite foreign keys properly

Sat, 21 Jan 2012 15:18:28 +0000

The MySQL SchemaManager can not properly generate a Schema from the database if a table has a foreign key that spans multiple columns.
Therefore the comparator tries to drop the one index as individual indexes.

That leads to an error if the resulting SQL is executed because these indexes do not exist (i.e. via app/console doctrine:schema:update --force)

symfony2#app/console doctrine:schema:update --dump-sql

...
ALTER TABLE table1 DROP FOREIGN KEY FK_C1B1712387FE737264DE5A5511B8B3E;
DROP INDEX IDX_C1B1712387FE7372 ON table1;
DROP INDEX IDX_C1B1712364DE5A5 ON table1;
DROP INDEX IDX_C1B17123511B8B3E ON table1;
ALTER TABLE table1 ADD CONSTRAINT FK_C1B1712387FE737264DE5A5511B8B3E FOREIGN KEY (column1, column2, column3) REFERENCES table2(column1, column2, column3);
...

[DBAL-204] Handling of explicit Schemas is wrong in comparator

Sat, 21 Jan 2012 10:35:51 +0000

if you are on db "foo" and compare table "bar" to "foo.bar". it shouldnt drop one and create the other one. They are the same!

[DBAL-203] Fix SQLServer version mess (2003, 2005, 2008)

Sun, 15 Jan 2012 18:37:43 +0000

The current SqlSrv platform implicitly depends on SQL Server 2008. A differentation between the common versions 2003, 2005 and 2008 is necessary.

[DBAL-201] Remote IBM DB2 connection needs protocol specified

Sat, 21 Jan 2012 13:47:39 +0000

Thanks so much for adding DB2 support to Doctrine2, it's awesome!

I'm using it to connect to a remote DB2 database, and in db2driver.php, it is expecting the 'protocol' parameter to be set. I tried the obvious, adding a database_protocol to my parameters.ini file (to match the other database things in there), but that didn't work.

I did a temporary fix of hardcoding it in the db2driver.php to be PROTOCOL=TCPIP , and it works.

So i think the proper fix would be to add the code so that database_protocol in parameters.ini is picked up.

[DBAL-197] Cannot drop database schema with blob type

Mon, 9 Jan 2012 08:12:24 +0000

I have an entity with a blob type. When I create the database schema via cli, everthing is okay.
When i try to drop the schema, I receive the following error:
[Doctrine\DBAL\DBALException]
Unknown database type longblob requested, Doctrine\DBAL\Platforms\MySqlPlatform may not support it.

[DBAL-196] The function fetchAll(PDO::FETCH_ALL, 'MyClass') doesn't create object of MyClass

Sat, 21 Jan 2012 14:44:19 +0000

The code below doesn't create objects of MyClass when it has to.
Instead it create StdClass objects

$stmt = $db->prepare($sql);
$stmt->execute();

$results = $stmt->fetchAll(
    \PDO::FETCH_CLASS,
    'MyClass'
);

The problem comes from the file Doctrine/DBAL/Statement.php

    /**
     * Returns an array containing all of the result set rows.
     * 
     * @param integer $fetchStyle
     * @param integer $columnIndex
     * @return array An array containing all of the remaining rows in the result set.
     */
    public function fetchAll($fetchStyle = PDO::FETCH_BOTH, $columnIndex = 0)
    {
	if ($columnIndex != 0) {
            return $this->_stmt->fetchAll($fetchStyle, $columnIndex);
        }
        return $this->_stmt->fetchAll($fetchStyle);
    }

The line

if ($columnIndex != 0) {

must be replace by

if ($columnIndex !== 0) {

because the parameter $columnIndex is not always an integer and could be a name of a class : see the example n°4 in php doc http://www.php.net/manual/en/pdostatement.fetchall.php

[DBAL-195] Method AbstractSchemaManager->dropAndCreateSequence() contains erroneous code.

Mon, 9 Jan 2012 07:57:39 +0000

I needed to use the function and looking at the code I found that it seemed partially implemented, cut and pasted from something else or just not ported from an earlier implementation. I'm now submitting a patch that fixes this issue. I didn't modify the AbstractSchemaManager->dropSequence($name) signature to become AbstractSchemaManager->dropSequence($sequence) but it might be a good idea to refactor it (guess that would be another issue though )

[DBAL-194] BlobType should implement getBindingType()

Tue, 3 Jan 2012 22:03:56 +0000

BlobType should implement getBindingType() and return PDO::PARAM_LOB

Currently (2.2-BETA1) DBAL uses PDO::PARAM_STR and thus stores the data incorrectly.

Working patch is attached.

[DBAL-192] GH-86: Remove a type object if a type is overrided

Tue, 3 Jan 2012 22:04:08 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/86

[DBAL-190] Column type comment SQL is missing during table creation

Tue, 3 Jan 2012 22:04:19 +0000

Column type comment is generated properly only with MySQL, and is not generated on platforms that support comment on column statements (Oracle, PgSQL).

[DBAL-188] Make doctrine and sqlite friends

Sun, 18 Dec 2011 16:29:48 +0000

https://github.com/doctrine/dbal/pull/66

Schema processing for SQLite is broken in a number of common situations. These patches fix handling of the following:

String column defaults: For columns with a default value that is a string, SQLite returns them wrapped in single quotes. Doctrine does not strip these, so it would treat a value "foobar" as "'foobar'" (with single quotes as part of the value).
Auto-increment: SQLite handling of auto-increment is unusual. In particular, it supports it only on an integer column which is the sole primary key for a table. In addition, it will automatically increment values of an integer primary key column regardless of whether it has been defined as autoincrement BUT, unlike autoincrement, these values are not guaranteed to be unique.
Most problematically, there is no way (without parsing the "create" statements stored in sqlite_master) to determine whether a column is marked as auto-incrementing. Doctrine was treating SQLite integer primary keys as auto-incrementing, but this is not correct and does not work for composite primary keys.
Composite primary keys: As a side-effect of Doctrine treating integer primary keys in SQLite as auto-incrementing and of how SQLite requires autoincrement and primary keys to be declared, it would generate invalid create statements for composite keys in SQLite.
Special indexes: SQLite sometimes automatically generates indexes, which Doctrine treated the same as any other. Because they are internal, however, their names are reserved, so they could not be used to recreate the same index and, since they are automatic, they aren't actually a part of the defined schema.

I've added to the tests to catch these situations in the future as well.

[DBAL-187] GH-83: Added a LoggerChain

Thu, 15 Dec 2011 18:15:50 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/83

This logger allows registering several loggers in the connection

[DBAL-186] GH-82: Schema events

Mon, 19 Dec 2011 13:16:46 +0000

Pull-Request was automatically synchronized: https://github.com/doctrine/dbal/pull/82

Trigger schema related events to allow custom create/drop/update queries.

[DBAL-177] Have Schema Assets handle "foo.bar" syntax correctly.

Wed, 16 Nov 2011 22:48:41 +0000

Have Schema Assets handle "foo.bar" syntax correctly.

[DBAL-176] DBAL logging doesnt work correctly with Prepared Statements

Sun, 30 Oct 2011 10:43:18 +0000

DBAL logging doesnt work correctly with Prepared Statements

[DBAL-170] Add mysqli driver

Mon, 21 Nov 2011 23:11:41 +0000

Add a mysqli driver

[DBAL-169] PostgreSQL Session init

Sat, 24 Sep 2011 11:53:25 +0000

During PostgreSQL Session init it may be interesting to set the search path to a different value than the default.

[DBAL-152] Github-PR-49 by juokaz: Ignore sysdiagrams table from a list

Tue, 22 Nov 2011 23:14:48 +0000

This issue is created automatically through a Github pull request on behalf of

{username}

Url: https://github.com/doctrine/dbal/pull/49

Message:

Fix for the http://www.doctrine-project.org/jira/browse/DBAL-114

[DBAL-146] Mssql platform TOP and DISTINCT ordering issue

Mon, 9 Jan 2012 13:30:27 +0000

When doing a limit and a distinct query, DBAL generates an SQL statement in the form of SELECT TOP X DISTINCT, which SqlSrv does not like at all. Simply moving the the DISTINCT back to the start fixes this issue.

As far as I can see this is caused by the preg_replace in doModifyLimitQuery. Attached is a patch that makes it slightly more aware. There may be other phrases to check for, but none that I've come across yet.

Patch attached.

[DBAL-142] Mapping Driver for Oracle does not know what to do with blobs, throws DBAL Exception for types "blob" and "long raw".

Duplicate — Tue, 13 Mar 2012 17:09:59 +0000

When attempting to reverse engineer an existing Oracle 11g database an exception is thrown (by DBAL) complaining that the type blob is unknown. I believe this is coming from AbstractPlatform.php. I attempted to solve the problem by add a type mapping for blob in PDOOracle\Driver.php (blob => text) and it now complains that "long raw" is unknown.

[Doctrine\DBAL\DBALException]
Unknown database type long raw requested, Doctrine\DBAL\Platforms\OraclePlatform may not support it.

[DBAL-141] PDO Connection Failure through TNS - PDOOracle/Driver.php line 56

Duplicate — Sun, 30 Oct 2011 19:21:45 +0000

On line 56 of the file ./vendor/doctrine-dbal/lib/Doctrine/DBAL/Driver/PDOOracle/Driver.php:

The line reads:
$dsn .= '))(CONNECT_DATA=(SID=' . $params['dbname'] . ')))'; should read $dsn .= '))(CONNECT_DATA=(SERVICE_NAME=' . $params['dbname'] . ')))';

If both SID and SERVICE_NAME need to be available for use, then logic should be inserted to determine which method is being used.

[DBAL-138] Connection::quote should convert non PDO types

Sun, 31 Jul 2011 10:21:38 +0000

It currently doesn't so $connection->quote('foo', Type::STRING) doesn't work.

[DBAL-114] MsSqlPlatform - getListTablesSQL() get's sysdiagrams table

Mon, 29 Aug 2011 20:12:21 +0000

getListTablesSQL() function in MsSqlPlatform.php list all tables in database.

If you have saved Database Diagrams it returns "sysdiagrams" table too.
This table have field "name" with type "sysname" which have no mapping.

If you run orm:validate-schema you get:
[Doctrine\DBAL\DBALException]
Unknown database type sysname requested, Doctrine\DBAL\Platforms\MsSqlPlatform may not support it.

Best solution is that when getting tables to ignore "sysdiagrams" tables.

[DBAL-20] Add Connection Resolver

Sun, 1 Apr 2012 16:10:21 +0000

There should be an additional, optional "connectionResolver" which returns a driver instance for differentation between different drivers in Doctrine\DBAL\Connection instead of using $this->_conn (which stays the default case)

This is useful for master/slave, master/master or failover strategies inside the application

[DBAL-6] MySQL BLOB datatypes throw DoctrineException::unknownColumnType() exception

Dependency — Sun, 30 Oct 2011 22:25:41 +0000

MySQL BLOB datatype appears to be breaking ClassMetadataExporter. Very new to Doctrine so hopefully I've isolated this correctly.

CREATE TABLE foo (
    id      BIGINT UNSIGNED NOT NULL AUTO_INCREMENT,
    bar   BLOB,
    PRIMARY KEY (id)
) ENGINE=InnoDB;

// ... setup entitymanager ....

$cme = new \Doctrine\ORM\Tools\Export\ClassMetadataExporter();
$sm = $em->getConnection()->getSchemaManager();
$cme->addMappingSource($sm, 'database');
$metadatas = $cme->getMetadatasForMappingSources();
$exporter = $cme->getExporter('annotation', '/path/to/annotations');
$exporter->setMetadatas($metadatas);
$exporter->export();

php -f doctrine Orm:convert-mapping --from-database --to=annotation --dest C:\www\app\models

Fatal error: Uncaught exception 'Doctrine\Common\DoctrineException' with message 'Unknown column type' in C:\www\app\lib\Doctrine\Common\DoctrineException.php:112

Stack trace:
#0 [internal function]: Doctrine\Common\DoctrineException::__callStatic('unknownColumnTy...', Array)
#1 C:\www\app\lib\Doctrine\DBAL\Types\Type.php(125): Doctrine\Common\DoctrineException::unknownColumnType('blob')
#2 C:\www\app\lib\Doctrine\DBAL\Schema\MySqlSchemaManager.php(262): Doctrine\DBAL\Types\Type::getType('blob')
#3 C:\www\app\lib\Doctrine\DBAL\Schema\AbstractSchemaManager.php(802): Doctrine\DBAL\Schema\MySqlSchemaManager->_getPortableTableColumnDefinition(Array)
#4 C:\www\app\lib\Doctrine\DBAL\Schema\AbstractSchemaManager.php(221): Doctrine\DBAL\Schema\AbstractSchemaManager->_getPortableTableColumnList(Array)
#5 C:\www\app in C:\www\app\lib\Doctrine\Common\DoctrineException.php on line 112