Doctrine Project

[DBAL-136] OCI8 Driver MUST support connections by SERVICE_NAME

Duplicate — Thu, 18 Aug 2011 20:48:51 +0000

The existing oci8 driver connection only supports connections from database name configuraton.
It will be very good if is possible set a connection by service name.

Take a look in this DSN:

(DESCRIPTION= (ADDRESS= (PROTOCOL=TCP) (HOST=192.168.0.1) (PORT=1521) ) (CONNECT_DATA= (SERVICE_NAME=TH01) ) )

More info:
http://stackoverflow.com/questions/43866/how-sid-is-different-from-service-name-in-oracle-tnsnames-ora

[DBAL-148] Foreign key creation fails with MySQL 5.1.54

Thu, 18 Aug 2011 20:16:54 +0000

doctrine orm:schema-tool:create

returns

[PDOException]
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Position(id)' at line 1

The problem seem to be that the create commande creates the following SQL syntax
ALTER TABLE Job ADD FOREIGN KEY (position_id) REFERENCES Position(id);

which doesn't work. If I use the following (added a space between Postion and (id) in the end) it works.
ALTER TABLE Job ADD FOREIGN KEY (position_id) REFERENCES Position (id);

Patch for AbstractPlatform.php attached.

[DBAL-134] Doctrine\DBAL\Connection::query() no logging

Tue, 28 Jun 2011 20:47:37 +0000

Doctrine\DBAL\Connection::query() does not use SqlLogger.

I guess it may be fixed like this:

    public function query()
    {
        $this->connect();

        $args = func_get_args();

        $logger = $this->getConfiguration()->getSQLLogger();
        if ($logger) {
            $logger->startQuery($args[0]);
        }

        $statement = call_user_func_array(array($this->_conn, 'query'), $args);

        if ($logger) {
            $logger->stopQuery();
        }

        return $statement;
    }

[DBAL-135] Index::overrules() does not detect pks overruling unique indexes

Sun, 26 Jun 2011 16:35:26 +0000

Index::overrules() does not detect pks overruling unique indexes

[DBAL-126] schema-tool creates primary keys as unique constraints

Sun, 26 Jun 2011 11:22:54 +0000

The schema tool calls AbstractPlatform::getCreateIndexSQL() to create new indexes. When the index is primary, this creates a unique key instead.

[DBAL-123] Add Ability to Unset SQL Logger in Configuration

Sun, 19 Jun 2011 09:47:56 +0000

Add the ability to remove the SQL logger after it has been set on the configuration.

public function setSQLLogger(SQLLogger $logger)

could be changed to

public function setSQLLogger(SQLLogger $logger = null)

or another function could be added to disable the logger.

[DBAL-113] The Sequence class lacks last value / start value

Sun, 19 Jun 2011 09:34:14 +0000

The Sequence class only has _initalValue which means that when a sequence is altered (by DROP and CREATE) the existing last_value, aka existing sequence ID is lost and the first attempt on flushing a new record results in a pkey exception.

This result in the sequence counter starting all over.

This can be handled by setting _initalValue to whatever is the last sequence value but since it is also used for setting MINVALUE this may not be a good idea. They should be split.

Not sure what name to use, last_value is from postgresql but I'm sure others use different names.

[DBAL-112] Sequence alteration does not alter.

Sun, 19 Jun 2011 09:33:42 +0000

When the schema diff decides there are differences between the existing SEQUENCE and the "new" one it alters the SEQUENCE by a DROP and then a CREATE.

The CREATE is done with the fromSchema as a base which results in a no-changed SEQUENCE.

Line 102 in Doctrine/DBAL/Schema/Comparator.php uses fromSchema but shuld have been using toSchema or just $sequence

This will fix the immediate issue but still require the sequence name being the same.

[DBAL-130] Add tests for modify limit query functionality

Fri, 17 Jun 2011 21:20:28 +0000

Add tests for modify limit query functionality

[DBAL-93] [ORACLE] Speed improvement of mechanism for limiting query results

Fri, 17 Jun 2011 21:20:15 +0000

Currently the mechanism for limiting query results in Oracle is suboptimal.

Doctrine uses the following pseudo SQL statement to limit query results:

SELECT b.* FROM (
   SELECT a.*, ROWNUM AS doctrine_rownum FROM (
      $query
  ) a
) b
WHERE doctrine_rownum BETWEEN $min AND $max

It's much faster to use the following:

SELECT * FROM (
  SELECT a.*, rownum AS doctrine_rownum FROM {
    $query
  ) a WHERE rownum <= $max
) WHERE doctrine_rownum >= $min

The updated code in DBAL/Platforms/OraclePlatform.php would look like this:

public function modifyLimitQuery($query, $limit, $offset = null)
{
	$limit = (int) $limit;
	$offset = (int) $offset;
	if (preg_match('/^\s*SELECT/i', $query)) {
		if ( ! preg_match('/\sFROM\s/i', $query)) {
			$query .= " FROM dual";
		}
		if ($limit > 0) {
			$max = $offset + $limit;
			$column = '*';
			if ($offset > 0) {
				$min = $offset + 1;
				$query = 'SELECT * FROM (SELECT a.' . $column . ', rownum AS doctrine_rownum FROM (' . 
						 $query . 
						 ') a WHERE rownum <= ' . $max . ') WHERE doctrine_rownum >= ' . $min;
			} else {
				$query = 'SELECT a.'.$column.' FROM (' . $query .') a WHERE ROWNUM <= ' . $max;
			}
		}
	}
	return $query;
}

With the current implementation the request for fairly complicated query selecting data from multiple tables one of which reaches 2 million rows takes 5.98 seconds comparing to 1.64 with the proposed one.

In addition It would be nice to have the min and max values as SQL query parameters so that Oracle's internal caching mechanisms could take part, but I'm aware of the fact that it would not be so easy to implement.

[DBAL-12] Add Doctrine\DBAL\SQLQuery package with simple Query Objects

Sun, 15 May 2011 17:23:13 +0000

We should add a Query Objects package to Doctrine\DBAL. This won't necessarily be used with Doctrine\ORM, however it could be really helpful to people that only plan to use Doctrine\DBAL and not the ORM.

Requirements:

Add Query Objects for all types of SELECT, INSERT, UPDATE, DELETE
Fluent Interface
Make use of Platform to abstract limit subquery and expressions
Add factory method on Doctrine\DBAL\Connection

API Ideas:

For the INSERT, UPDATE, DELETE I like the approach taken by eZ Components: http://www.ezcomponents.org/docs/api/trunk/introduction_Database.html#query-abstraction
For the SELECT I find Zend_Db_Select much more usable: http://framework.zend.com/manual/en/zend.db.select.html

Are there query objects in other languages that could help here?

[DBAL-111] MySQL Driver possibly subject to sql injections with PDO::quote()

Sat, 14 May 2011 07:24:48 +0000

Prior to 5.3.6, the MySQL PDO driver ignored the character set parameter to options. Due to MySQL's C api (and MySQLND), this is required for the proper function of mysql_real_escape_string() (the C API call). Since PDO uses the mres() C call for PDO::quote(), this means that the quoted string does not take into account the connection character set.

Starting with 5.3.6, that was fixed. So now if you pass the proper character set to PDO via driver options, sql injection is impossible while using the PDO::quote() api call.

PDO proof of concept

$dsn = 'mysql:dbname=INFORMATION_SCHEMA;host=127.0.0.1;charset=GBK;';
$pdo = new PDO($dsn, $user, $pass);
$pdo->exec('SET NAMES GBK');
$string = chr(0xbf) . chr(0x27) . ' OR 1 = 1; /*';
$sql = "SELECT TABLE_NAME
            FROM INFORMATION_SCHEMA.TABLES
            WHERE TABLE_NAME LIKE ".$pdo->quote($string)." LIMIT 1;";
$stmt = $pdo->query($sql);
var_dump($stmt->rowCount());

Expected Result: `int(0)`.
Actual Result: `int(1)`.

There are 2 issues to fix. First, the documentation does not indicate that you can pass the `charset` option to the MySQL Driver. This should be fixed so that users are given the proper option to set character sets.

Secondly, `Connection::setCharset()` should be modified for MySQL to throw an exception, since the character set is only safely setable using the DSN with PDO. This is a limitation of the driver and could be asked as a feature request for the PHP core. Either that, or a big warning should be put on the documentation of the API to indicate the unsafe character set change

[DBAL-107] Graphviz Schema Visitor

Thu, 7 Apr 2011 17:32:45 +0000

We should include a Graphviz Schema Visitor.

Features:

Display Tables and Columns
Highlight Primary Keys
Connect tables through foreign keys

[DBAL-56] Ship a compatibility wrapper like MDB2

Sat, 5 Mar 2011 16:19:21 +0000

Database Portability is expensive but often necessary. We should support the important Compatibility Layer Options that MDB2 has:

http://pear.php.net/manual/en/package.database.mdb2.intro-portability.php

The following I think are doable:

Empty to Nulls
Change Case of Field-Assocs
Oracle RTRIM for Chars
Num Rows "hack" for Oracle
Delete Count (Some vendors rewrite a DELETE tablename into a TRUNCATE and dont report the delete count)

There should be a class extending "Doctrine\DBAL\Connection" making use of the 'wrapperClass' option. Two new classes are necessary:

Doctrine\DBAL\Portability\Connection
Doctrine\DBAL\Portability\Statement

[DBAL-78] Native support for parameter lists

Sat, 5 Mar 2011 10:51:22 +0000

Prerequisites:

1. Detection of this mode has to be super-fast. It should not have an auto-detection but should be triggered explicitly.
2. This mode cannot be supported after $conn->prepare(). It is only viable for $conn->executeQuery() or $conn->executeUpdate().

Case 1: Positional

$stmt = $conn->executeQuery("SELECT a.id FROM articles a WHERE a.id IN (?) AND a.foo = ?",
    array($paramList, $foo), array( Connection::PARAM_ARRAY => PDO::PARAM_INT) , PDO:PARAM_STR ),
    Connection::FLAG_EXPAND_ARRAYS
);

Would internally, right before execution, be rewritten to:

$c = count($paramList); // 3!
"SELECT a.id FROM articles a WHERE a.id IN (?, ?, ?) AND a.foo = ?"

Case 2: Named

$stmt = $conn->executeQuery("SELECT a.id FROM articles a WHERE a.id IN (:id) AND a.foo = :bar",
    array('id' => $paramList, 'bar' => $foo),
    array( array(Connection::PARAM_ARRAY => PDO::PARAM_INT), PDO::PARAM_STR ),
    Connection::FLAG_EXPAND_ARRAYS
);

Would internally, right before execution, be rewritten to:

$c = count($paramList); // 3!
"SELECT a.id FROM articles a WHERE a.id IN (:id1, :id2, :id3) AND a.foo = :bar"

[DBAL-45] Add CLI tool that checks for Reserved Keywords

Reference — Sun, 27 Feb 2011 03:45:40 +0000

Add a CLI tool that checks for reserved keywords in your current schema (for other databases vendors) to support cross vendor portability.

[DBAL-79] Add Schema\Table::hasPrimaryKey method

Sat, 26 Feb 2011 16:11:38 +0000

Currently the name of the primary key is internal to the Table instance so there is no way to check if the table has a primary key without getting all the indexes and iterating over them.

[DBAL-88] MySqlPlatform not escaping table names

Duplicate — Sat, 26 Feb 2011 15:56:34 +0000

Methods in the MySql Platform that use the table name are not escaping the table name. This causes problems when your table name is the same as a reserved word in MySql. Example:

public function getListTableConstraintsSQL($table)

{ return 'SHOW INDEX FROM ' . $table; }

If my table name is User this method will fail and cause a SQL error because the word User is a reserved word in MySql. You need to escape the table name with backticks to prevent these errors. Example:

public function getListTableConstraintsSQL($table)

{ return 'SHOW INDEX FROM `' . $table . '`'; }

I encountered this problem while reverse engineering my existing MySql database. I've attached a fixed version that solved my reverse engineering problems.

[DBAL-84] Long string fields are being silently changed to 255 characters in the schema

Sun, 20 Feb 2011 17:13:00 +0000

I have an entity like this:

/**
 * @orm:Entity
 */
class Product
{
    /**
     * @orm:Id
     * @orm:Column(name="Merchant",type="string",length=50)
     */
    protected $merchant;

    /**
     * @orm:Column(name="Name",type="string",length=500)
     */
    protected $name;
}

When I change the length of $name field to 4000 it updates the schema like it is supposed to:

php.exe -f console doctrine:schema:update --dump-sql
ALTER TABLE product CHANGE Name Name VARCHAR(4000) NOT NULL

But when I change the length to 5000 it just silently without any warning uses value 255 instead:

php.exe -f console doctrine:schema:update --dump-sql
ALTER TABLE product CHANGE Name Name VARCHAR(255) NOT NULL

I had to look into actual table definition using mysql browser to find this issue because doctrine doesn't even warn about it. This could lead to some pretty serious bugs!

[DBAL-42] Use column comments for further Doctrine Type Inference

Duplicate — Sun, 20 Feb 2011 04:39:12 +0000

Any custom type could use vendors column comment functionalities to allow more details on the specific type of a column that can be used inside the "listTableColumns()" method.

[DBAL-91] orm:convert-mapping SchemaException on Postgres reserved words

Duplicate — Sat, 12 Feb 2011 14:39:41 +0000

While execuiting

doctrine orm:convert-mapping --from-database yml /tmp/test.yml

I get presented an error

[Doctrine\DBAL\Schema\SchemaException]
Invalid index-name tablename_"input"_idx given, has to be [a-zA-Z0-9_]

The index "type" is quoted because this is a reserved word in Postgres. for example see the following definition:

FOREIGN KEY (something) REFERENCES somethings(id) ON UPDATE CASCADE
FOREIGN KEY (another) REFERENCES anothers(id) ON UPDATE CASCADE
FOREIGN KEY ("type") REFERENCES logtypes(id) ON UPDATE CASCADE

Only type will be quoted because it is a reserved word.

[DBAL-80] Connection::_bindTypedValues() error when $types[0] is null

Sat, 1 Jan 2011 16:08:29 +0000

When $types[0] = null (default) then _bindTypedValues starts with the wrong offset and binds the wrong types against the wrong params.