Doctrine Project

[DBAL-521] [GH-320] Fixed calculation of differences of columns

Fri, 17 May 2013 08:06:09 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/320

Message:

[DBAL-520] [GH-319] Delete unnecessary "use PDO" statement

Thu, 16 May 2013 15:08:21 +0000

This issue is created automatically through a Github pull request on behalf of alexpods:

Url: https://github.com/doctrine/dbal/pull/319

Message:

[DBAL-519] MasterSlave connection does not keep Slave connections when there is a transaction

Wed, 15 May 2013 18:01:26 +0000

while doing a transaction (as a result of ORM persist),
the connect function sets the forceMasterAsSlave which result on setting
slave to master,

on future selects, even if keepSlave is set to true
and connecting to 'slave' as ->connect('slave')
we will get master connections

I assume we need to check keepSlave when forcing slaves to master

[DBAL-518] [GH-318] Update Type.php

Fri, 17 May 2013 07:12:35 +0000

This issue is created automatically through a Github pull request on behalf of vincequeiroz:

Url: https://github.com/doctrine/dbal/pull/318

Message:

Camel case methods names.

[DBAL-517] [GH-317] Conditionaly upgrade utf8 to utf8mb4 for MySQL 5.5.3

Wed, 15 May 2013 09:20:59 +0000

This issue is created automatically through a Github pull request on behalf of nicolas-grekas:

Url: https://github.com/doctrine/dbal/pull/317

Message:

See http://dev.mysql.com/doc/refman/5.5/en/charset-unicode-utf8mb4.html

As utf8mb4 is a superset of utf8, this should be transparent and backward compatible.
For those really requiring the "utf8" meant by MySQL, they can use explicitely the utf8mb3 charset.
But IMHO by default, Doctrine should really use utf8mb4, which is what everybody expect from a charset named "utf8".

[DBAL-516] [GH-316] Fixed generated sql for postgres substring function

Wed, 15 May 2013 16:48:06 +0000

This issue is created automatically through a Github pull request on behalf of stefk:

Url: https://github.com/doctrine/dbal/pull/316

Message:

Currently, the postgres dbal platform generates the following sql code for the substring function : `SUBSTR('foo', 1, 2)`
where in postgres, it should be :
`SUBSTRING('foo' FROM 1 FOR 2)`
This pull request simply fixes that issue.

[DBAL-515] [GH-315] Shard description requires an 'id' not 'name'

Tue, 14 May 2013 13:32:50 +0000

This issue is created automatically through a Github pull request on behalf of johannes:

Url: https://github.com/doctrine/dbal/pull/315

Message:

[DBAL-514] [GH-314] Remove unnecessary code from Connection::insert

Tue, 14 May 2013 18:40:29 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/314

Message:

This is a tiny optimization in the <code>Connection::insert</code> method that remove an unnecessary <code>foreach</code> loop an some unneeded variable assignments.
If this is not desired, just close this PR

[DBAL-513] downloading from github

Sun, 12 May 2013 10:07:46 +0000

https://api.github.com/repos/doctrine/dbal/zipball/2.3.4:

500: Internal Server Error

[DBAL-512] Update schema not working on MsSql due to no support for alter identity

Mon, 6 May 2013 12:36:03 +0000

When running: php app/console doctrine:schema:update --force

[Doctrine\DBAL\DBALException]
An exception occurred while executing 'ALTER TABLE tableName ALTER COLUMN id INT IDENTITY NOT NULL':

SQLSTATE[42000]: [Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near the keyword 'IDENTITY'.

According to this stackoverflow http://stackoverflow.com/a/1049305/1833322 MSSQL does not support this query.

[DBAL-511] Schema\ColumnDiff incorrect with default varchar value and postgresql

Sat, 4 May 2013 11:15:53 +0000

I have a Schema\Table with a column:

$usersTable->addColumn("lastip", "string", array("length" => 32, "default" => ""));

When I use Schema\Comparator on this table I get a ColumnDiff:

object(Doctrine\DBAL\Schema\ColumnDiff)[554]
  public 'oldColumnName' => string 'lastip' (length=6)
  public 'column' => 
    object(Doctrine\DBAL\Schema\Column)[481]
      protected '_type' => 
        object(Doctrine\DBAL\Types\StringType)[278]
      protected '_length' => int 32
      protected '_precision' => int 10
      protected '_scale' => int 0
      protected '_unsigned' => boolean false
      protected '_fixed' => boolean false
      protected '_notnull' => boolean true
      protected '_default' => string '' (length=0)
      protected '_autoincrement' => boolean false
      protected '_platformOptions' => 
        array
          empty
      protected '_columnDefinition' => null
      protected '_comment' => null
      protected '_customSchemaOptions' => 
        array
          empty
      protected '_name' => string 'lastip' (length=6)
      protected '_namespace' => null
      protected '_quoted' => boolean false
  public 'changedProperties' => 
    array
      0 => string 'default' (length=7)
  public 'fromColumn' => 
    object(Doctrine\DBAL\Schema\Column)[293]
      protected '_type' => 
        object(Doctrine\DBAL\Types\StringType)[278]
      protected '_length' => int 32
      protected '_precision' => int 10
      protected '_scale' => int 0
      protected '_unsigned' => boolean false
      protected '_fixed' => boolean false
      protected '_notnull' => boolean true
      protected '_default' => string '''::character varying' (length=21)
      protected '_autoincrement' => boolean false
      protected '_platformOptions' => 
        array
          empty
      protected '_columnDefinition' => null
      protected '_comment' => string '' (length=0)
      protected '_customSchemaOptions' => 
        array
          empty
      protected '_name' => string 'lastip' (length=6)
      protected '_namespace' => null
      protected '_quoted' => boolean false

With "default" postgresql adds "::character varying" when it's a varchar.

This gives a alter sql query:

ALTER TABLE bolt_users ALTER lastip SET  DEFAULT ''

After executing this, the next time it's the ColumnDiff again. Should the "::character varying" part be ignored by doctrine? Because then the schema will be valid.

Using Doctrine 2.4.0-BETA1 (38b1a340c5ec7c58be1883696c1f956bed5b7f0c)

[DBAL-510] Schema tool does not recognize existing columns

Wed, 1 May 2013 12:22:31 +0000

I'm using doctrine with symfony. The first schema update is working, the table exists with all defined columns.
When i now run the schema update a second time (without code changes), doctrine tries to create the columns - but they already exists:

$ php app/console doctrine:schema:update --dump-sql
CREATE SEQUENCE users_id_seq INCREMENT BY 1 MINVALUE 1 START 1;
CREATE TABLE users (id INT NOT NULL, email VARCHAR(255) NOT NULL, password VARCHAR(255) DEFAULT NULL, salt VARCHAR(255) DEFAULT NULL, realname VARCHAR(255) NOT NULL, roles TEXT NOT NULL, PRIMARY KEY(id))
$ php app/console doctrine:schema:update --force
Updating database schema...
Database schema updated successfully! "2" queries were executed
$ php app/console doctrine:schema:update --dump-sql
ALTER TABLE users ADD id INT NOT NULL;
ALTER TABLE users ADD email VARCHAR(255) NOT NULL;
ALTER TABLE users ADD password VARCHAR(255) DEFAULT NULL;
ALTER TABLE users ADD salt VARCHAR(255) DEFAULT NULL;
ALTER TABLE users ADD realname VARCHAR(255) NOT NULL;
ALTER TABLE users ADD roles TEXT NOT NULL;
ALTER TABLE users ADD PRIMARY KEY (id)

Doctrine seems to ignore existing columns.

PHPUnit segfaults because of a backslash prepended to a FQCN and has a failure in the tests run so far (see attached PHPUnit output).

[DBAL-508] MySqlSchemaManager accessing undefined index tableColumn[comment]

Thu, 9 May 2013 16:08:45 +0000

in the method Doctrine\DBAL\Schema\MySqlSchemaManager::_getPortableTableColumnDefinition the index "comment" in the array $tableColumn is accessed without ensuring that this index is set. This leads to an Undefined index: comment warning in E_ALL-environments.

This method is triggered e.g. by the Doctrine\ORM\Tools\SchemaTool getUpdateSchemaSql method.

[DBAL-507] [GH-313] Enhanced Master-Slave Connection

Sat, 27 Apr 2013 08:12:43 +0000

This issue is created automatically through a Github pull request on behalf of andrejhudec:

Url: https://github.com/doctrine/dbal/pull/313

Message:

Q	A
-------------	—
Bug fix?	no
New feature?	yes
BC breaks?	no?
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT

Current implementation of MasterSlaveConnection is very restrictive. The slave is picked up only when `executeQuery` is used. If appliacation uses `prepare` method in queries, every `SELECT` is done on master and this is bad for performance of master.

This PR changes how and when it picks the slave or master:

1. Slave if master was never picked before and ONLY if `getWrappedConnection`, `query`, `prepare`, or `executeQuery` is used and the query begins with `SELECT` (case insensitive) string.

2. Master picked when `exec`, `executeUpdate`, `insert`, `delete`, `update`, `createSavepoint`, `releaseSavepoint`, `beginTransaction`, `rollback`, `commit` is called.

3. Master picked when `query`, `prepare` or `executeQuery` is called and the query doesn't begin with `SELECT` (case insensitive) string.

4. If master was picked once during the lifetime of the connection it will always get picked afterwards.

5. One slave connection is randomly picked ONCE during a request.

[DBAL-506] [GH-312] [DBAL-264] Support for UIDs in PostgreSQL

Sat, 27 Apr 2013 08:15:41 +0000

This issue is created automatically through a Github pull request on behalf of mbadolato:

Url: https://github.com/doctrine/dbal/pull/312

Message:

Add getGuidExpression() to PostgreSqlPlatform so that UUID support
works properly

[DBAL-505] Issue whenusing serial columns in PostgreSQL

Wed, 24 Apr 2013 20:02:08 +0000

When using Doctrine ORM mapping fields like this:

/**

@var integer
*
@ORM\Column(name="id", type="integer", nullable=false)
@ORM\Id
@ORM\GeneratedValue(strategy="IDENTITY")
@ORM\SequenceGenerator(sequenceName="schemaname.tablename_id_seq", allocationSize=1, initialValue=1)
*/
private $id;

It first creates the migration perfectly as a serial column with the correct schema.

However when making a new migration diff it generates DROP statements for every sequence for these id, so we have to remove them manually every time.

[DBAL-504] DBAL Enum fields migration issue / PostgreSQL

Duplicate — Mon, 6 May 2013 08:32:44 +0000

When using Custom Doctrine DBAL Enums the migration created using diff

works fine the first time.

However the next time it generates a SQL statement trying to change to field type to INT from integer; (Redundant)
and a truncated statement:

"ALTER schemaname.fieldname SET" .. And that's it.

[DBAL-503] [GH-311] [WIP] Fixed CS

Sat, 27 Apr 2013 08:17:23 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/311

Message:

[DBAL-502] [GH-310] fix function name in exception text

Tue, 23 Apr 2013 08:25:05 +0000

This issue is created automatically through a Github pull request on behalf of pscheit:

Url: https://github.com/doctrine/dbal/pull/310

Message:

[DBAL-501] [GH-309] Parameter parsing fixes

Thu, 9 May 2013 10:49:08 +0000

This issue is created automatically through a Github pull request on behalf of lstrojny:

Url: https://github.com/doctrine/dbal/pull/309

Message:

Fix for #301 has been reverted to address http://www.doctrine-project.org/jira/browse/DBAL-496. This fix addresses both issues in a consistent manner and ads a few more tests.

[DBAL-500] [GH-308] added index flags to schema table

Wed, 1 May 2013 12:33:31 +0000

This issue is created automatically through a Github pull request on behalf of bamarni:

Url: https://github.com/doctrine/dbal/pull/308

Message:

This would allow, for example, to create some fulltext indexes with the MysqlPlatform, by passing the "fulltext" flag.

[DBAL-499] [GH-307] Postgres fix for a possible unavailable dbname

Sat, 4 May 2013 11:58:05 +0000

This issue is created automatically through a Github pull request on behalf of antonioribeiro:

Url: https://github.com/doctrine/dbal/pull/307

Message:

[DBAL-498] [GH-306] [DBAL-497] Fixed SQL Server platform replacing 'FROM' in column names during limit

Sat, 20 Apr 2013 07:58:03 +0000

This issue is created automatically through a Github pull request on behalf of shaneneuerburg:

Url: https://github.com/doctrine/dbal/pull/306

Message:

The regex used to replace the FROM clause was in a "starts with" form, which also matched column names that start with the word "FROM". This resulted in column names being replaced with the logic used for limiting, breaking the query once pagination is used. I added a whitespace requirement after "FROM' in the regex as well as a trailing whitespace in the replacement.

[DBAL-497] SQLServerPlatform modifies limit query incorrectly when column names start with "from"

Sat, 20 Apr 2013 07:57:51 +0000

I am working with a table that has columns that start with the word "from" (fromNumber, fromCity, etc). When SQLServerPlatform->doModifyLimitQuery is called, "from" in the names are incorrectly replaced. I suggest adding a whitespace requirement after FROM in the preg_replace on this line:
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php#L848

So this:

$query = preg_replace('/\sFROM/i', ", ROW_NUMBER() OVER ($over) AS doctrine_rownum FROM", $query);

Becomes this:

$query = preg_replace('/\sFROM\s/i', ", ROW_NUMBER() OVER ($over) AS doctrine_rownum FROM ", $query);

[DBAL-496] "Undefined index" errors when using prepared statements

Sun, 21 Apr 2013 12:30:37 +0000

Since a few days we are seeing errors like this in the Jackalope Doctrine DBAL test suite when using prepared statements:
https://travis-ci.org/jackalope/jackalope-doctrine-dbal/jobs/6350278#L117

[DBAL-495] [GH-305] [DDC-2110] fixed problem with existing columns (postgresql)

Wed, 1 May 2013 12:22:49 +0000

This issue is created automatically through a Github pull request on behalf of MatthiasLohr:

Url: https://github.com/doctrine/dbal/pull/305

Message:

Fixed http://www.doctrine-project.org/jira/browse/DDC-2110. While selecting the configured search_path, ```"$user"``` is not replaced with the name of the current user. This commit will do the replacing.

[DBAL-494] [GH-304] Fix for DBAL-442

Sun, 14 Apr 2013 16:30:59 +0000

This issue is created automatically through a Github pull request on behalf of yethee:

Url: https://github.com/doctrine/dbal/pull/304

Message:

[DBAL-493] Schema\Comparator incorrect diff with sqlite and unsigned integer

Sun, 14 Apr 2013 08:40:08 +0000

Using the Schema\Comparator to diff a table in sqlite with a unsigned integer. When creating the table and comparing it with the same definition it gives a diff which is not expected:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

 
$schema = new \Doctrine\DBAL\Schema\Schema();
$usersTable = $schema->createTable("test_users");
$usersTable->addColumn("id", "integer", array("unsigned" => true, 'autoincrement' => true));
$usersTable->setPrimaryKey(array("id"));
$usersTable->addColumn("username", "string", array("length" => 32));
$usersTable->addIndex( array( 'username' ) );
$usersTable->addColumn("password", "string", array("length" => 64));

$platform = new \Doctrine\DBAL\Platforms\SqlitePlatform();
$queries = $platform->getCreateTableSQL($usersTable);
foreach($queries as $query) {
    $conn->query($query);
}

$tableDetail = $sm->listTableDetails($usersTable->getName());
$comparator = new \Doctrine\DBAL\Schema\Comparator();
$diff = $comparator->diffTable($tableDetail, $usersTable);
if ($diff) {
    print(implode("\n",$platform->getAlterTableSQL($diff)));
} else {
    print("no diff");
}

Expect result:

 
no diff

Actual result:

 
DROP INDEX IDX_1F5D03E2F85E0677
CREATE TEMPORARY TABLE __temp__test_users AS SELECT id, username, password FROM test_users
DROP TABLE test_users
CREATE TABLE test_users (id INTEGER NOT NULL, username VARCHAR(32) NOT NULL, password VARCHAR(64) NOT NULL, PRIMARY KEY(id))
INSERT INTO test_users (id, username, password) SELECT id, username, password FROM __temp__test_users
DROP TABLE __temp__test_users
CREATE INDEX IDX_1F5D03E2F85E0677 ON test_users (username)

When setting unsigned to false everything works. Shouldn't Doctrine know unsigned is not supported in sqlite?

[DBAL-492] Foreign keys always changed with postgres non standard schema.

Sun, 14 Apr 2013 08:26:47 +0000

Starting with this https://github.com/doctrine/dbal/commit/b84cda24335207d4e60afc88fa161317d94b6370#diff-0 all foreign keys in non standard schema all always different, because table1 doesn't contain a schema name in it but table2 does.

[DBAL-491] Oracle platform should not support dropping database

Sun, 14 Apr 2013 09:08:59 +0000

It appears that attempting to run the Doctrine ORM test suite against an Oracle database causes the following exception:

[root@raymond-kolbe-1 orm]# /usr/local/zend/bin/phpunit -c oracle.xml
PHPUnit 3.7.19 by Sebastian Bergmann.

Configuration read from /home/rkolbe/sites/trainingv2/vendor/doctrine/orm/oracle.xml

......................SSSSSS...........................E

Time: 1 second, Memory: 68.75Mb

There was 1 error:

1) Doctrine\Tests\ORM\Functional\AdvancedAssociationTest::testIssue
Doctrine\DBAL\DBALException: An exception occurred while executing 'DROP USER rkolbe CASCADE':

ORA-01940: cannot drop a user that is currently connected

/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:47
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php:189
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php:112
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:791
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:816
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:306
/home/rkolbe/sites/trainingv2/vendor/doctrine/orm/tests/Doctrine/Tests/TestUtil.php:66
/home/rkolbe/sites/trainingv2/vendor/doctrine/orm/tests/Doctrine/Tests/OrmFunctionalTestCase.php:315
/home/rkolbe/sites/trainingv2/vendor/doctrine/orm/tests/Doctrine/Tests/ORM/Functional/AdvancedAssociationTest.php:17

Caused by
Doctrine\DBAL\Driver\OCI8\OCI8Exception: ORA-01940: cannot drop a user that is currently connected

/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Exception.php:28
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php:189
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php:112
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:791
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:816
/home/rkolbe/sites/trainingv2/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:306
/home/rkolbe/sites/trainingv2/vendor/doctrine/orm/tests/Doctrine/Tests/TestUtil.php:66
/home/rkolbe/sites/trainingv2/vendor/doctrine/orm/tests/Doctrine/Tests/OrmFunctionalTestCase.php:315
/home/rkolbe/sites/trainingv2/vendor/doctrine/orm/tests/Doctrine/Tests/ORM/Functional/AdvancedAssociationTest.php:17

FAILURES!
Tests: 56, Assertions: 98, Errors: 1, Skipped: 6.

After investigating, I asked myself "Should Doctrine support dropping a "database"?" It should not, and here is why.

1) Oracle does not consider a "database" the same way MySQL and other vendors do. A "schema" is the database and this is the "user". Dropping a "database" drops the user. How would we recreate the database for testing purposes (read: DBAL drops and recreates the database)?

2) Oracle platform in DBAL does not support creating a database. Is this something we wish to support? I'm not sure how we would recreate a schema, since creating a schema is the same as creating a user. This is something we don't support on any platform. Also note, the return value of supportsCreateDropDatabase() is misleading as it says Oracle does support this feature.

Although this issue originated in Doctrine ORM, the root cause is the Oracle platform implementation in DBAL. I propose we remove support for dropping "databases" in Oracle since there is no way to create them.

[DBAL-490] [GH-303] Fixed a PHP warning in DBALException::driverExceptionDuringQuery()

Wed, 1 May 2013 12:40:11 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/dbal/pull/303

Message:

When a query parameter contains binary data, `driverExceptionDuringQuery()` generates a PHP warning. This is because it internally uses `json_encode()`, which expects valid UTF-8 strings (at least in PHP 5.4.13).

This PR removes the warning with the `@` operator. `json_encode()` will still return a string representation, replacing the binary data with `null`.

I added a test that fails before the fix.

[DBAL-489] [GH-302] [DBAL-374] Fix asset identfier quotation

Wed, 1 May 2013 09:09:18 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/302

Message:

This PR introduces a real solution for the issues discussed in ~~DBAL-374~~(http://www.doctrine-project.org/jira/browse/DBAL-374).
It adds the possibility to retrieve quoted column names from <code>Index</code> and <code>ForeignKeyConstraint</code> assets if it is necessary (e.g. column name is a keyword reserved by the platform).
In general column names are wrapped into an abstraction class <code>Identifier</code> which inherits from <code>AbstractAsset</code> inside <code>Index</code> and <code>ForeignKeyConstraint</code>. This allows to get a quoted representation of each column name via the <code>AbstractAsset::getQuotedName</code>.
All platforms are updated to make use of the new functionality.

[DBAL-488] [GH-301] Fixing issue when number of positional parameters != number of given types

Sun, 14 Apr 2013 09:20:06 +0000

This issue is created automatically through a Github pull request on behalf of lstrojny:

Url: https://github.com/doctrine/dbal/pull/301

Message:

When passing incomplete type information to `Connection::query()`, `SQLParserUtils` currently behaves the wrong way as it ignores all typing information instead falling back to a default (`PDO::PARAM_STR`). I don��t know this place very well, so please review carefully.

[DBAL-487] DBAL's SqlitePlatform does not allow for fields of type 'integer unsigned'. Whether they exist already or not.

Sat, 20 Apr 2013 08:34:04 +0000

I'm getting the following error when I'm merely requesting schemaManager->listTables() on an SQLite DB with several columns set to 'integer unsigned'.

PHP Fatal error: Uncaught exception 'Doctrine\DBAL\DBALException' with message 'Unknown database type integer unsigned requested, Doctrine\DBAL\Platforms\SqlitePlatform may not support it.' in /..~~snip~~../vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php:321

$ sqlite3 --version
3.7.14.1

[DBAL-486] [GH-300] Improve list SQL Server table indexes

Sat, 6 Apr 2013 13:11:00 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/300

Message:

This PR improves listing table indexes in SQL Server. Currently table indexes are retrieved in the platform via a stored procedure <code>sp_helpindex</code> which causes problems with some SQL Server drivers like ODBC that cannot retrieve information from stored procedure calls. Table indexes are retrieved via native system tables now, which seems cleaner and is more flexible concerning which information to retrieve.
Additionally code duplication in <code>SQLServerSchemaManager::_getPortableTableIndexesList</code> is removed and simplified by this PR.

[DBAL-485] [GH-299] Fix list SQL Server composite foreign keys

Sat, 6 Apr 2013 09:16:06 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/299

Message:

This PR fixes listing composite foreign keys in <code>SQLServerSchemaManager</code>. Currently the schema manager creates a foreign key object for each column in a foreign key constraint returned by the platform's <code>listTableForeignKeysSQL</code>, This is ok for foreign keys consisting of only one column but fails for composite foreign key constraints. The test <code>testListForeignKeysComposite</code> in <code>SQLServerSchemaManagerTest</code> currently fails but is fixed with this PR.

[DBAL-484] [GH-298] Fix SQL Server default constraints

Sat, 6 Apr 2013 09:20:22 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/298

Message:

This PR fixes altering column default values. In SQL Server column default values are stored in constraints. <code>CREATE TABLE</code> statements with column declarations like <code>some_column NVARCHAR(50) NOT NULL DEFAULT 'default value'</code> internally creates a default constraint with an automatically generated name in the the system table `sys.default_constraints`. <code>ALTER TABLE</code> statements do not support the <code>DEFAULT</code> clause in column alteration declarations, leading in SQL syntax errors. Thus changing a column's default value is currently not possible.
To alter a column's default value, the old column's default constraint hast to be dropped and recreated again. As a default constraint has to be referenced by name to be dropped, we need to create each default constraint with an own unique name. This PR generates separate statements for default constraint declarations. It generates a unique name consisting of the table name and the column name the default constraint is created for.
<code>DF_TABLE_NAME_HASH%_%COLUMN_NAME_HASH%</code>

[DBAL-483] default values make orm:validate-schema fail

Wed, 1 May 2013 08:45:46 +0000

% ./bin/doctrine.php --env=development orm:schema-tool:update --dump-sql                                                                                                  
ALTER TABLE groups CHANGE active active TINYINT(1) DEFAULT '1' NOT NULL;
ALTER TABLE module ADD root_order INT DEFAULT 0 NOT NULL
% ./bin/doctrine.php --env=development orm:schema-tool:update --force
Updating database schema...
Database schema updated successfully! "2" queries were executed
% ./bin/doctrine.php --env=development orm:schema-tool:update --dump-sql                                                                                                  ALTER TABLE groups CHANGE active active TINYINT(1) DEFAULT '1' NOT NULL;
ALTER TABLE module CHANGE root_order root_order INT DEFAULT 0 NOT NULL

My entities define these columns like this:

Group

    /**
     * @ORM\Column(name="active", type="boolean", options={"default":true})
     */
    private $active = true;

Module

    /**
     * @ORM\Column(name="root_order", type="integer", options={"default":0})
     */
    private $rootOrder = 0;

[DBAL-482] SQL Server Schema Manager returns incorrect value for autoincrement on IDENTITY columns

Wed, 1 May 2013 13:09:45 +0000

When calculating table diffs, SQLServerSchemaManager returns column definitions for identity columns with _autoincrement set to FALSE.

This causes the schema update SQL generation to pump out a
ALTER TABLE x ALTER COLUMN id INT IDENTITY NOT NULL
for every single identity column in the schema.

The culprit is in DBAL\Schema\SQLServerSchemaManager, starting at line 43:

        $dbType = strtolower($tableColumn['TYPE_NAME']);
        $dbType = strtok($dbType, '(), ');

        $autoincrement = false;
        if (stripos($dbType, 'identity')) {
            $dbType = trim(str_ireplace('identity', '', $dbType));
            $autoincrement = true;
        }

When the column in question is an identity int column, the TYPE_NAME is "int identity". The second line of the snippet drops the "identity" signifier, causing the following lines that determine autoincrement to do nothing.

I simply moved the second line to below the autoincrement block ie:

        $dbType = strtolower($tableColumn['TYPE_NAME']);

        $autoincrement = false;
        if (stripos($dbType, 'identity')) {
            $dbType = trim(str_ireplace('identity', '', $dbType));
            $autoincrement = true;
        }

        $dbType = strtok($dbType, '(), ');

This change solves this issue for me, and as far as I can tell, has no other consequences.

[DBAL-481] [GH-297] check for proper type when formatting dates

Tue, 2 Apr 2013 14:07:54 +0000

This issue is created automatically through a Github pull request on behalf of mprzytulski:

Url: https://github.com/doctrine/dbal/pull/297

Message:

[DBAL-480] [GH-296] PDO bug workaround

Thu, 9 May 2013 22:02:26 +0000

This issue is created automatically through a Github pull request on behalf of dasmfm:

Url: https://github.com/doctrine/dbal/pull/296

Message:

In combination of PHP 5.4 and Doctrine 2 (upto 2.4Beta1) there's a bug with "boolean" type of field.
Ref link:��http://stackoverflow.com/questions/10242312/pdo-bindvalue-with-pdoparam-bool-causes-statement-execute-to-fail-silently

This patch binds int instead of bool and everything goes working fine.

[DBAL-479] Doctrine2 schema-tool:update doesn't re-create foreign keys on entity change

Duplicate — Mon, 1 Apr 2013 16:47:29 +0000

I have changed a @ManyToOne relation to another entity. My workflow was this:

Having @ManyToOne(targetEntity="Entity\EntityA") in the source
Creating the database schema
Changing @ManyToOne(targetEntity="Entity\EntityA") to @ManyToOne(targetEntity="Entity\EntityB")
Calling doctrine orm:schema-tool:update

orm:schema-tool:update doesn't notice that and doesn't re-create the FK on MySQL and PostgreSQL (haven't tested others).

[DBAL-478] [GH-295] Fix ModifyLimitQueryTest

Mon, 1 Apr 2013 21:23:17 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/295

Message:

The functional <code>ModifyLimitQueryTest</code> makes false expectations about the query results. <code>LIMIT</code> queries without <code>ORDER BY</code> clause return non-deterministic results, therefore the test cannot make any expectations about which values are returned and in which order. You can only expect a certain number of results.
The test might still work on platforms like mysql when you assume results to be in an ascending order, because the database might put the results of a non-deterministic query in an ascending order by default. Still this is not reliable and not all vendors do that.
This PR changes the tests to have an ordered, deterministic results by default to have more reliable expectations. Also one test about a non-deterministic query was added, which just asserts the number of results returned.

[DBAL-477] Just doublequote all schema names and field names in PostgreSQL sql command generation, and the same for MySQL

Thu, 28 Mar 2013 22:11:56 +0000

Generation of any SQL command to the database (From entities or migration versions) does not quote all the reserved keywords (For example a fieldname `right`.

Simple fix that always works: double-quote dbname, schemaname and fieldname

e.g "dbsecurity"."userschema"."users" or "tblusers"

MySQL : use the ` sign.

e.g `security`.`users` or `tblusers` (No support for schemas since I last checked some time ago)

[DBAL-476] [GH-294] Allow removing column comment on some platforms

Mon, 1 Apr 2013 21:25:50 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/294

Message:

Some platforms currently do not remove a comment on a column on table alteration.
This PR fixes this. Also updated platform and functional schema tests for this.
Besides that <code>OraclePlatform</code> now does not generate a useless <code>ALTER TABLE MODIFY</code> SQL snippet when only the column comment has changed, as this is handled seperately through <code>COMMENT ON COLUMN</code> SQL statement.

[DBAL-475] [GH-293] Add SAP SQL Anywhere database vendor

Sun, 14 Apr 2013 09:57:46 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/293

Message:

This PR adds the driver and DBAL for SAP SQL Anywhere databases. It distinguishes between versions 10 and below (base <code>SQLAnywherePlatform</code>), 11 (<code>SQLAnywhere11Platform</code>) and 12 (<code>SQLAnywherer12Platform</code>), similar to Microsoft SQL Server.
Most of the functional tests pass but there are some exceptions:

<code>DataAccessTest::testFetchAllWithTypes</code>
<pre>
Failed asserting that two strings are equal.
- - Expected
    +++ Actual
    @@ @@
    -'2010-01-01 10:10:10'
    +'2010-01-01 10:10:10.000'
    </pre>
    The test is not aware of the datetime format string of the platform, which differs in SQL Anywhere. Therefore it fails. In SQL Anywhere a datetime is stored with second fractions by default.
    IMO I have two options here. Changing the default timestamp format for data output in the driver on every connection so that it fits <code>Y-m-d H:i:s</code> and changing the date format strings in the platforms or modifying the test to be aware of the platform specific datetime format.

<code>MasterSlaveConnectionTest::testKeepSlaveBeginTransactionStaysOnMaster</code>
The test simply hangs up here and I don't exactly know why. When I change the value for insert in line 95 to some other value than 30 it perfectly works. Any help would be appreciated here.

<code>ModifyLimitQueryTest::testModifyLimitQueryGroupBy</code>
<pre>
Failed asserting that two arrays are equal.
- - Expected
    +++ Actual
    @@ @@
    Array (
- 0 => 1
- 1 => 2
  ++ 0 => 2
  ++ 1 => 1
  )
  </pre>
  The test does not tell the SELECT statement to order the result, thus the result is not deterministic and returns the results in wrong order.
  IMO the test should be fixed so that the result is ordered correctly. Then the test will pass for SQL Anywhere.

<code>TemporaryTableTest</code>
<pre>Exception: [Doctrine\DBAL\DBALException] An exception occurred while executing 'CREATE GLOBAL TEMPORARY TABLE temporary (id INT NOT NULL)':
SQLSTATE [42W04] [-131] Syntaxfehler bei 'temporary' in Zeile 1
With queries:
SQL: 'DROP TABLE temporary' Params:
SQL: 'CREATE GLOBAL TEMPORARY TABLE temporary (id INT NOT NULL)' Params:
SQL: 'DROP TABLE nontemporary' Params:</pre>
The tests use the unquoted keyword "temporary" reserved by SQL Anywhere for the temporary table name to create.
I cannot quote the name of the temporary table in the platform as the method <code>getTemporaryTableName</code> expects a string and not an instance of <code>Doctrine\DBAL\Schema\Table</code> as parameter.
Either the tests should use a non reserved keyword as temporary table name or the temporary table name has to be quoted in the platform (but I don't know exactly how).

<code>TemporaryTableTest::testDropTemporaryTableNotAutoCommitTransaction</code>
<pre>In an event of an error this result has one row, because of an implicit commit.
Failed asserting that two arrays are equal.
- - Expected
    +++ Actual
    @@ @@
    Array (
    ++ 0 => Array (...)
    )
    </pre>
    The test fails because of an implicit commit during the transaction (drop temporary table) which inserts the first value. I couldn't find a solution for this problem. Seems to be the same problem as reported in ~~DDC-1337~~(http://www.doctrine-project.org/jira/browse/DDC-1337).

<code>WriteTest::testLastInsertIdNoSequenceGiven</code>
<pre>Failed asserting that 14 is false.</pre>
I don't exactly know why the test expects the lastInsertId to be false here. Using the same connection for 14 inserts into a newly created autoincrement table should result in lastInsertId = 14 IMO. Is this a bug in the test? How do other vendors behave here?

I hope this addition is appreciated and any feedback/help on the above issues would be welcomed.

[DBAL-474] SchemaManager / Connection on PostgreSQL platform does not respect filterExpression for sequences

Wed, 24 Apr 2013 20:05:59 +0000

Dear Symfony team,

the filterExpression on AbstractSchemaManager seems not to work for sequences.

This only happens under postgres.

It seems the way the sequences are handled are the culprit: It tries to get min_value etc of sequences without matching sequence names to the filter expression in advance.

If for example access to the sequences is denied, (Different schema without permissions for the current entity manager), any higher-level ORM operations like generating migration versions fail.

--------------------- UPDATE

the context is when using migrations. Positive regexp expressions do not limit the migration to a single schema. eg ^schemaname.$
Instead, all sequences on the current database are returned.
When trying to limit a migration to a single schema consecutively this doesn't work.
We are using a per-schema connection, so this results in a lot of hassle for us.

[DBAL-473] [GH-292] Add length in the OCI8 bindParam

Tue, 26 Mar 2013 19:49:21 +0000

This issue is created automatically through a Github pull request on behalf of Juliens:

Url: https://github.com/doctrine/dbal/pull/292

Message:

[DBAL-472] Oracle schema modification - incorrect SQL to change the nullable status of column

Thu, 4 Apr 2013 21:36:22 +0000

When updating the nullable status of a column the sql generated is

ALTER TABLE MET MODIFY (METAR VARCHAR2(2000) DEFAULT NULL)

This will set the default column value to null but does not modify the nullable status of the column. The correct sql would be

ALTER TABLE MET MODIFY (METAR VARCHAR2(2000) NULL)

The field definition changed from

metar:
type: string
length: 2000
nullable: false
column: METAR

metar:
type: string
length: 2000
nullable: true
column: METAR

[DBAL-471] when persisting objects to Doctrine2 and one of the tables are named the same as a MySQL reserved word

Sun, 24 Mar 2013 16:05:48 +0000

I am not sure this is a correct posting to your issue tracker, as I am a beginner at development, at least in the sense of doctrine.

I have an entity named Trigger in my Symfony2 project. I had set the table name to be "trigger", and this did not work. However, the entities were created without any problems, I first discovered the problem when attempting to persist a Trigger entity. The solution was to rename the table to "mtrigger" or something else, but I think the error message could be better somehow. Now it throws an exception with the MySQL error, which only says there's an error in the syntax, and to check the manual. The manual is quite huge and it was a horror for me before I started thinking in the field of reserved words.

Note that this is just a proposal to an improvement. It might be that it is hard to implement it for you. In that case, please just close the issue.

[DBAL-470] [GH-291] Optimize abstract platform

Sun, 24 Mar 2013 13:54:44 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/291

Message:

This PR optimizes the <code>AbstractPlatform</code> class in the following ways:

Add dedicated use statemtent for each class import
Add missing class imports
Add missing phpDoc blocks for methods
Fix existing phpDocs (parameters, return types, @throws tags, FQDN types, indentation etc.)
"Normalize" phpDocs (consistent verbs for what a method does, reuse of certain phrases for similar method types etc.)
Fix CS
Improve certain code portions

I hope this is a welcomed improvement. It reads much better now and feels somewhat cleaner to me.

[DBAL-469] [GH-290] Quote sequence name in PostgreSQL before grabbing information about it

Sat, 4 May 2013 11:55:55 +0000

This issue is created automatically through a Github pull request on behalf of mrkrstphr:

Url: https://github.com/doctrine/dbal/pull/290

Message:

[DBAL-468] [GH-288] Fix fetchColumn not caching

Wed, 20 Mar 2013 20:40:20 +0000

This issue is created automatically through a Github pull request on behalf of Alan01252:

Url: https://github.com/doctrine/dbal/pull/288

Message:

Column cache wasn't working because the emptied flag is only set
when fetch no longer returns a row. With fetch column the code
only calls fetch once and so emptied flag never got set.

Created two test cases, one to test fetchColumn, and one to test
that the return value is false if the data doesn't get saved in the cache.

[DBAL-467] DateTime handling in sqlsrv 2005 not quite right

Mon, 1 Apr 2013 13:24:57 +0000

The problem I am having is with how the DateTimeType converts the DateTime field from sql svr. It seems to need different formats in the ::getDateTimeFormatString() depending in if you are converting from the database to PHP or the other way.

The method format 'Y-m-d H:i:s.000' that is there now works if the database is only written to with PHP, and not anything else.

In my case I am sharing access with other technologies. So basically when converting from the Database to PHP the format needs to be 'Y-m-d H:i:s.u' and 'Y-m-d H:i:s.000' when converting the other way.

If there functions convertToDatabaseValue() and convertToPHPValue() where in the Platform, then I could override these with my own custom platform and I would be right.

Otherwise to do this right we need to split this up getDateTimeFormatString() into 2 different methods, 1 for the database, and 1 for php.

[DBAL-466] [GH-287] Fix platform create constraint foreign table name quotation

Tue, 19 Mar 2013 23:46:17 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/287

Message:

Creating foreign key constraints via <code>getCreateConstraintSQL</code> in the platform doesn't quote the foreign table name leading to invalid SQL when the foreign table name is a reserved keyword. This PR fixes this issue.

[DBAL-465] [GH-286] Fix data not being cached in ResultCache

Wed, 20 Mar 2013 22:27:56 +0000

This issue is created automatically through a Github pull request on behalf of Alan01252:

Url: https://github.com/doctrine/dbal/pull/286

Message:

The ResultCacheStatement has a small logic error, it tested for emptied
being true when it should have tested for emptied being false. The
comments also statement that the function returns a boolean, however the
function didn't return a boolean.

This is my first time committing to a larger open source project like dbal. Very worried I'll of done something wrong, please go easy / teach me.

[DBAL-464] MySQL fails when try to drop a primary index with Auto Increment

Thu, 14 Mar 2013 14:52:14 +0000

When an update of schema tries to drop a primary key with "auto increment" property (example : @ORM\GeneratedValue(strategy="AUTO")), the execution will fail : it say :
[Doctrine\DBAL\DBALException]
An exception occurred while executing 'ALTER TABLE odesadicola DROP PRIMARY KEY':

SQLSTATE[42000]: Syntax error or access violation: 1075 Incorrect table definition; there can be only one auto column and it must be defined as a key

Apparently, this error occurs because Doctrine try to execute a "drop primary key" on a table and the resulting column of old primary key will be "auto increment".

The answer is to remove "auto increment" attribut of primary key column juste before try to drop the primary key itself.

[DBAL-463] [GH-285] Add IBM iSeries Driver

Thu, 14 Mar 2013 21:49:22 +0000

This issue is created automatically through a Github pull request on behalf of spicajames:

Url: https://github.com/doctrine/dbal/pull/285

Message:

Added driver pdo_ibmi to support to db2 iSeries using pdo_odbc

[DBAL-462] [GH-284] Correcting code example

Sun, 10 Mar 2013 08:01:44 +0000

This issue is created automatically through a Github pull request on behalf of intel352:

Url: https://github.com/doctrine/dbal/pull/284

Message:

Doc incorrectly makes a call to close(), when it should be calling closeCursor()

[DBAL-461] Numeric() syntax in columns fails on SQL Server

Thu, 14 Mar 2013 21:30:44 +0000

This issue occurred when I tried to create entities from existing MSSQL Database. My database have several fields that are defined as "numeric" data types. When I tried to reverse engineer this data base, doctrine threw an error mentioning that doctrine numeric data types are not supported. I have attached code that I used to create entities. And error that was generated. Hope this Helps narrow down the process. One thing that ca in to notice was that the "SQLServerSchemaManager" class does not have any specific mechanism to handle "numeric" as compared to "MySqlSchemaManager".

[DBAL-460] [GH-283] Fix SchemaManagerFunctionalTestCase composite foreign keys test

Tue, 12 Mar 2013 20:00:29 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/283

Message:

This PR fixes a bug in the <code>SchemaManagerFunctionalTestCase</code> composite foreign keys test I encountered today. In SQL Server the test case fails because both <code>testListForeignKeys</code> and <code>testListForeignKeysComposite</code> tests create a foreign key with the same name which is not possible for one single DB in SQL Server.
I don't know if this applies to other RDBMS also but this should also fix the others.

[DBAL-459] [GH-282] Add column collation support for SQL Server

Tue, 12 Mar 2013 20:01:44 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/282

Message:

This PR contributes to PR #274 and adds the missing SQL Server driver support for column collations. It's fully functional tested on my own SQL Server database.

[DBAL-458] [GH-281] Upgrading doctrine/common 2.4 (via composer)

Mon, 4 Mar 2013 22:38:23 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/dbal/pull/281

Message:

This PR introduces changes necessary to make the DBAL recognize `"doctrine/common": "2.4"` as compatible as discussed in https://groups.google.com/d/topic/doctrine-dev/8WjzboENQgg/discussion

Ping @dbu

[DBAL-457] [GH-280] Use int values instead of strings for PostgreSQL booleans

Mon, 4 Mar 2013 22:48:40 +0000

This issue is created automatically through a Github pull request on behalf of chEbba:

Url: https://github.com/doctrine/dbal/pull/280

Message:

1. The Problem:
  The current implementation for PostgreSQL uses strings 'true' and 'false' which are not working with PDO::ATTR_EMULATE_PREPARES.

1. Solution:
  Use ints like in the default platform implementation.

1. Comments

Tested only on my local php 5.4.9
Fixed NamedParametersTest to use int columns instead of strings (does not work with PDO::ATTR_EMULATE_PREPARES when compare string column IN array of ints)
Fixed DbalFunctionalTestCase sql parameters dumping (found while fixing NamedParametersTest)
Added support for driver options configuration via phpunit config globals

[DBAL-456] [GH-279] adds new output format

Tue, 5 Mar 2013 00:47:09 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/dbal/pull/279

Message:

The output of the ::dump command is very unstable (depends on platform/PHP version/installed extensions).

This pull request adds a new format which is more suitable for machine consumption.

[DBAL-455] [GH-278] OraclePlatform sequence naming for primary keys

Tue, 12 Mar 2013 20:03:23 +0000

This issue is created automatically through a Github pull request on behalf of jrjohnson:

Url: https://github.com/doctrine/dbal/pull/278

Message:

Change Oracle sequence generation to match what is being created by ORM and other platforms in the form of $table_$column_SQL instead of $table_SEQ

This is a solution for https://github.com/doctrine/migrations/issues/112

[DBAL-454] [GH-277] Remove duplicate SQL parts in query generation

Sun, 3 Mar 2013 01:53:39 +0000

This issue is created automatically through a Github pull request on behalf of gigablah:

Url: https://github.com/doctrine/dbal/pull/277

Message:

Presently, it's possible to do this using QueryBuilder:

```php
$qb->select('u.*')
->from('users', 'u')
->addOrderBy('u.name', 'ASC')
->addOrderBy('u.name', 'ASC'); // duplicate
```
Which produces:
```sql
SELECT u.* FROM users u ORDER BY u.name ASC, u.name ASC
```

This patch removes duplicates from the `SELECT`, `SET`, `ORDER BY` and `GROUP BY` parts during SQL generation (there's already logic that removes duplicate `FROM` parts).

I've added test cases for each affected keyword as well.

[DBAL-453] PostgreSqlSchemaManager::getSchemaSearchPaths does not work for secondary schemas

Wed, 1 May 2013 17:16:44 +0000

PostgreSqlSchemaManager::getSchemaSearchPaths() uses "SHOW search_path" to get the current search path for the connection and explodes it using a comma delimiter. On my installation Postgresql 9.1 on Ubuntu 12.04 "SHOW search__path" returns the schemas in the search path separated by ", " (i.e. a comma followed by a space). This means that the array of schemas returned by getSchemaSearchPaths() will including a leading space on the schema names for the second and subsequent schemas in the search list.

This is a particular problem if you call PostgreSqlSchemaManager::getExistingSchemaSearchPaths() because that calls determineExistingSchemaSearchPaths() which filters the list from getSchemaSearchPaths() to make sure they are in the list of schemas in the database (as returned from getSchemaNames(). The second and subsequent schemas in the search path still have a leading space when they are compared to the array of schema names, and consequently they do not match and are not included in the array returned by getExistingSchemaSearchPaths().

I think that getSchemaSearchPaths should trim the leading space from the schemas.

[DBAL-452] range is a reserved word in several platforms

Fri, 15 Mar 2013 03:02:01 +0000

'range' is a reserved word for MySQL, Oracle, and on future reserved list for SQL Server as well so should really be added for escaping. Working on a new project using Doctrine accessing an external API which used it as a field and got an error when running orm:schema-tool:create on my entity with MySQL.

[DBAL-451] [GH-276] DBAL-446

Sat, 6 Apr 2013 14:41:18 +0000

This issue is created automatically through a Github pull request on behalf of nemekzg:

Url: https://github.com/doctrine/dbal/pull/276

Message:

Fix for ~~DBAL-446~~ with a proper test case and two general test cases.

[DBAL-450] [GH-275] accept array as parameter in getConcatExpression

Tue, 12 Mar 2013 20:04:12 +0000

This issue is created automatically through a Github pull request on behalf of broncha:

Url: https://github.com/doctrine/dbal/pull/275

Message:

The function `getConcatExpression` accepts strings, but as there can be any number of parameters passed to this and while calling from `ConcatFunction` sqlwalker has to walk all the parameters. So it would be better if `getConcatExpression` accepts array. Infact even better if it only accepts array. It would be much cleaner. Also I am opening a pull request in ORM for `ConcatFunction` as it only validates 2 primaryStrings. It should support more than two. SO for that to happen, `getConcatExpression` should accept array as parameter.

[DBAL-449] [GH-274] Support column charset/collation on capable platforms

Tue, 19 Feb 2013 00:28:10 +0000

This issue is created automatically through a Github pull request on behalf of adrienbrault:

Url: https://github.com/doctrine/dbal/pull/274

Message:

Basically the same feature wanted as in #245

[DBAL-448] [GH-273] Use BLOB for Object mapping type

Tue, 12 Mar 2013 20:13:06 +0000

This issue is created automatically through a Github pull request on behalf of ludekstepan:

Url: https://github.com/doctrine/dbal/pull/273

Message:

http://php.net/manual/en/function.serialize.php
> Note that this is a binary string which may include null bytes, and needs to be stored and handled as such. For example, serialize() output should generally be stored in a BLOB field in a database, rather than a CHAR or TEXT field.

[DBAL-447] [GH-272] Refactor SQL Server keyword dictionaries and MsSQL leftovers

Tue, 12 Mar 2013 20:12:35 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/272

Message:

Each Microsoft SQL Server version has its own specific reserved keyword dictionary. Therefore each platform version should implement the correct dictionary. This PR adds dedicated dictionaries for Microsoft SQL Server 2000 (base), 2005, 2008 and 2012. Moreover all the "mssql" leftovers are refactored to fit the "sqlserver" term.

[DBAL-446] Type json_array can't be null

Mon, 1 Apr 2013 21:48:49 +0000

Column type json_array can be set to nullable, but if there's null in the database, it is returned as an empty array to PHP.

Null should be returned instead, as that's how the other types behave too.

[DBAL-445] [GH-271] added the possibility to use column names as keys for the types in Connection::insert()

Sun, 14 Apr 2013 12:23:38 +0000

This issue is created automatically through a Github pull request on behalf of fabpot:

Url: https://github.com/doctrine/dbal/pull/271

Message:

The Connection::insert() method takes an array of types as its third argument:

$conn->insert('foo', array('foo' => 'foo', 'date' => new \DateTime()), array(2 => 'datetime'));

But without looking at the implementation, I'm sure you would have written the following instead:

$conn->insert('foo', array('foo' => 'foo', 'date' => new \DateTime()), array('date' => 'datetime'));

But unfortunately, that's does not work. This commit add support for this, and of course, the old way still works.

[DBAL-444] OraclePlatform getSequenceNextValSQL not handling case/quoting properly on 11g

Thu, 4 Apr 2013 21:22:17 +0000

I have an installer script that uses ORM SchemaTool to create the entities in the DB and then populates with basic data using basic EM->persist calls via ORM.

Sequence objects are created, and when using the 10g Instant Client everything worked correctly, however, upon upgrade to latest version of the Instant Client Oracle seems to be expecting consistent case for these schema objects. It appears as if they are being created with a quoted name as they are created in lowercase. OraclePlatform::getSequenceNextValSQL, however, generates "SELECT entity_id_seq.nextval FROM DUAL" and this fails with error "General error: 2289 OCIStmtExecute: ORA-02289: sequence does not exist".

Executing "SELECT "entity_id_seq".nextval FROM DUAL" directly on the DB returns the correct value.

I believe this may also impact the code in http://www.doctrine-project.org/jira/browse/DBAL-278

[DBAL-443] [GH-270] Fix for DBAL-442

Sun, 14 Apr 2013 10:31:12 +0000

This issue is created automatically through a Github pull request on behalf of yethee:

Url: https://github.com/doctrine/dbal/pull/270

Message:

[DBAL-442] Break the query building with multiple from parts

Mon, 22 Apr 2013 14:51:48 +0000

For example:

$queryBuilder
    ->select('DISTINCT c.id')
    ->from('Campaigns', 'c')
    ->leftJoin('c', 'CampaignOperations', 'od', 'od.campaignId = c.id AND od.operation = :operation')
    ->from('BannerGroups', 'bg')
    ->innerJoin('bg', 'BannerGroupStrategies', 'bgs', 'bgs.groupId = bg.id AND bgs.advSystem = :system')
    ->where('bg.campaignId = c.id');

Builded the query:

SELECT DISTINCT c.id FROM Campaigns s 
  LEFT JOIN CampaignOperations od ON (od.campaignId = c.id AND od.operation = :operation)
  INNER JOIN BannerGroupStrategies bgs ON (bgs.groupId = bg.id AND bgs.advSystem = :system), 
  BannerGroups bg
  WHERE (bg.campaignId = c.id)

If this query execute on mysql, we get error:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'bg.id' in 'on clause'

Expected result:

SELECT DISTINCT c.id FROM Campaigns s 
  LEFT JOIN CampaignOperations od ON (od.campaignId = c.id AND od.operation = :operation),
  BannerGroups bg
  INNER JOIN BannerGroupStrategies bgs ON (bgs.groupId = bg.id AND bgs.advSystem = :system)
  WHERE (bg.campaignId = c.id)

Regression after patch https://github.com/doctrine/dbal/pull/175

[DBAL-441] [GH-269] Fix SQLServerPlatform regular expression SQL

Sun, 3 Feb 2013 19:32:37 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/269

Message:

SQL Server has no native support for regular expressions. Furthermore there is no "RLIKE" expression in T-SQL. This PR fixes this.

[DBAL-440] [GH-268] Remove deprecated getShowDatabasesSQL() from Platforms

Sun, 10 Feb 2013 00:04:34 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/268

Message:

As stated in PR #265 the getShowDatabasesSQL() method is deprecated in the platforms. This PR removes them entirely now.

[DBAL-439] [GH-267] Add SQLServerPlatform supports schemas

Tue, 5 Feb 2013 15:21:50 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/267

Message:

SQL Server supports schemas. This PR modifies SQLServerPlatform to return true when asked for schema support.

[DBAL-438] [GH-266] Removed outdated methods in DatabasePlatformMock.

Tue, 5 Feb 2013 15:19:24 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/dbal/pull/266

Message:

Same as https://github.com/doctrine/doctrine2/pull/567

[DBAL-437] [GH-265] fix getShowDatabasesSQL() in SQLServerPlatform

Sun, 10 Feb 2013 00:05:14 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/265

Message:

The getShowDatabasesSQL() in SQLServerPlatform returns invalid SQL. Maybe copy/paste error from MySqlPlatform? This PR fixes this to return the correct statement.

[DBAL-436] Logger should specify connection used in a master/slave situation

Mon, 1 Apr 2013 16:34:12 +0000

Suppose there is a master connection with four slaves specified. Connections are being handled by the Doctrine\DBAL\Connections\MasterSlaveConnection class. Under the current implementation, all queries are logged under the "master" connection, even queries that are routed to the slaves by the Doctrine\DBAL\Connections\MasterSlaveConnection class.

Since slave connections are separate, distinct connections, queries should be logged appropriately under their respective connections.

[DBAL-435] [GH-264] Allow passing empty arrays as parameters

Mon, 1 Apr 2013 13:45:44 +0000

This issue is created automatically through a Github pull request on behalf of frosas:

Url: https://github.com/doctrine/dbal/pull/264

Message:

Right now something like

```php
$entityManager
->createQuery("SELECT e FROM Entity e WHERE e IN (:entities)")
->execute(array('entities' => array()));
```

produces a `Warning: array_fill(): Number of elements must be positive`

[DBAL-434] Incorrect type mapping on Oracle Platform

Sun, 17 Feb 2013 13:55:08 +0000

Hello,

I'm noticed a strange behaviour when I executed a migration for my Oracle database. Doctrine detects changes on all date columns, generating queries like:

ALTER TABLE the_table MODIFY (the_date DATE DEFAULT NULL);

even if the entity property was not modified. Check in out the Doctrine 2 source code I've detected that Doctrine map the DATE Oracle columns as datetime type, but entity date property are mapped as date (as it should be), so Doctrine believes that entity property and column type are different and generate the alter query.

I found the problem on the method Doctrine\DBAL\Platforms\OraclePlatform::initializeDoctrineTypeMappings, when it say 'date' => 'datetime' should say 'date' => 'date', that fix the migration problem and does not break my application.

Was a typo?

Thanks!

[DBAL-433] [GH-263] Fix wrong class names in SQLAzureFederationsSynchronizer

Wed, 30 Jan 2013 18:38:19 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/dbal/pull/263

Message:

There is a wrong import in this class:

use Doctrine\DBAL\Sharding\SingleDatabaseSynchronizer;

Should be:

use Doctrine\DBAL\Schema\Synchronizer\SingleDatabaseSynchronizer;

The following import is also missing:

use Doctrine\DBAL\Schema\Synchronizer\SchemaSynchronizer;

This PR fixes them.

[DBAL-432] [GH-262] Add Symfony Console dependency to composer.json

Sun, 14 Apr 2013 12:24:51 +0000

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: https://github.com/doctrine/dbal/pull/262

Message:

The DBAL component offers a command-line tool based on Symfony Console, but this one is not present as a dependency in `composer.json`.

This PR adds the dependency.

[DBAL-431] [GH-261] Fix OFFSET without LIMIT cause MySQL syntax error.

Sun, 14 Apr 2013 12:42:21 +0000

This issue is created automatically through a Github pull request on behalf of Everus:

Url: https://github.com/doctrine/dbal/pull/261

Message:

MySQL OFFSET require LIMIT.
So fixed it to use the biggest limit possible as it recommended in http://dev.mysql.com/doc/refman/5.0/en/select.html#id4651990

[DBAL-430] [GH-260] Add SQL Server 2012 platform

Mon, 4 Feb 2013 00:14:09 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/260

Message:

This adds the platform for SQL Server 2012 introducing sequences. I don't exactly know if sequences should be preferred for ID generation or not so I left identity columns preferred for ID generation. Also added new keywords to MsSqlKeywords since SQL Server 2008.

[DBAL-429] [GH-259] fix named_token

Sun, 14 Apr 2013 12:27:11 +0000

This issue is created automatically through a Github pull request on behalf of dready:

Url: https://github.com/doctrine/dbal/pull/259

Message:

Regex Token Pattern for NAMED_TOKEN does not support sql cast operator ::

For example a query like this:
Select mydate::date from mytable;

will return a place holder ':date' instead of ignoring this.

fixed by adjusting the regex to ignore the operator.

[DBAL-428] [GH-258] Guid type requires SQL typehint comment

Wed, 30 Jan 2013 18:37:43 +0000

This issue is created automatically through a Github pull request on behalf of pkruithof:

Url: https://github.com/doctrine/dbal/pull/258

Message:

Since guid extends the string type, it needs to be type hinted.

[DBAL-427] [GH-257] fix SQLServerPlatform locking hints

Sun, 3 Feb 2013 19:54:20 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/257

Message:

This should completely implement the locking hints of the SQLServerPlatform according to http://msdn.microsoft.com/en-us/library/aa213026%28v=sql.80%29.aspx.

[DBAL-426] [GH-256] Create queryBuilder from parts.

Sat, 26 Jan 2013 16:24:46 +0000

This issue is created automatically through a Github pull request on behalf of NoUseFreak:

Url: https://github.com/doctrine/dbal/pull/256

Message:

Add a feature that can create a queryBuilder from queryBuilder parts.

This can be used when a query is build and needs to be stored somehow and restore it later.

[DBAL-425] [GH-255] fix typo in AbstractPlatform phpDocs

Sat, 26 Jan 2013 16:29:21 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/255

Message:

Fixes typo in AbstractPlatform phpDocs. "ASNI" -> "ANSI"

[DBAL-424] [GH-254] fix SQLServerPlatform GUID expression

Fri, 25 Jan 2013 19:18:58 +0000

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/254

Message:

The GUID expression UUID() does not exist in SQLServer. Instead NEWID() is used. This PR fixes this.

[DBAL-423] Type GUID = VARCHAR(255) on platforms that don't have a native GUID support

Fri, 25 Jan 2013 11:03:03 +0000

I'm using MySQL with entities that have GUID ids. Therefore I'm using @ORM\Column(type="guid") for the ORM mapping. As MySQL does not have a native GUID data type, it gets mapped to type="string" with a default length of 255 -> VARCHAR(255). I don't really understand why we don't limit the length to 36, which is the fixed length for GUIDs. You could even think about using CHAR(36) for MySQL.

-> see Doctrine\DBAL\Platforms\AbstractPlatform -> getGuidTypeDeclarationSQL()

[DBAL-422] Wrong VARCHAR default length in SQLServerPlatform

Thu, 24 Jan 2013 01:25:45 +0000

In SQLServerPlatform the default length for a VARCHAR declaration is set to "255". But according to the SQLServer documentation from Microsoft the default length is "1", if omitted in the declaration.
See remarks: http://msdn.microsoft.com/en-us/library/ms186939.aspx
Also the default length is hardcoded in the "getVarcharTypeDeclarationSQLSnippet" method which in my opinion should be evaluated through "getVarcharDefaultLength".

I don't exactly know if the current implementation is intended, otherwise it should be fixed. I would then create an PR if desired.

[DBAL-421] [GH-253] Added GUID expression to SQLite platform

Fri, 25 Jan 2013 08:43:47 +0000

This issue is created automatically through a Github pull request on behalf of jankramer:

Url: https://github.com/doctrine/dbal/pull/253

Message:

This will add an implementation of getGuidExpression to the SqlitePlatform. It is based on [UUID version 4](http://en.wikipedia.org/wiki/Universally_unique_identifier#Version_4_.28random.29).

Don't know if this is appropriate, but I'm open to suggestions.

[DBAL-420] Schema Drop SQL incorrect on PostgreSQL with entities with GeneratedValue(strategy="IDENTITY")

Sun, 14 Apr 2013 12:37:30 +0000

This problem is probably related to #~~DBAL-54~~. However that was closed by the raiser as he changed his Entity model and it went away.

When schema drop is run the following error occurs:
Doctrine\DBAL\DBALException: An exception occurred while executing 'DROP SEQUENCE radacct_radacctid_seq':

SQLSTATE[2BP01]: Dependent objects still exist: 7 ERROR: cannot drop sequence radacct_radacctid_seq because other objects depend on it
DETAIL: default for table radacct column radacctid depends on sequence radacct_radacctid_seq
HINT: Use DROP ... CASCADE to drop the dependent objects too.

The source of this problem is the difference between strategy="IDENTITY" and strategy="SEQUENCE"

With SEQUENCE doctrine creates the table schema with field type BIGINT and no specified. It then creates a seperate sequence and as far as I can tell takes care of getting and inserting the next id number itself.

With IDENTITY doctrine creates the table schema with field type BIGSERIAL and no specified default. Now postgres automatically creates a sequence and creates the column with type BIGINT and sets the DEFAULT to the pgpsql statement required to get the nextval from the sequence.

At this point the two differently configured tables will work successfully and identically, except SEQUENCE tables will only get a correct new ID when run through the doctrine code while IDENTITY tables will get the correct new ID whenever an insert is done to the table.

Because in the case of an IDENTITY field postgresql creates the field with a default value refering to the sequence the sequence can not be deleted before the table reference is removed.

For my case I need the IDENTITY fields to work as we have a RADIUS server that needs to insert into one table which is managed and mapped to an entity in Doctrine.

Swapping the order of DROP TABLE and DROP SEQUENCE commands in Doctrine/DBAL/Schema/Visitor/DropSchemaSqlCollector.php in getQueries() line 159. Does not work as a quick fix. The following error occurs as the sequence is quite correctly be dropped along with the table.

Doctrine\DBAL\DBALException: An exception occurred while executing 'DROP SEQUENCE radacct_radacctid_seq':

SQLSTATE[42P01]: Undefined table: 7 ERROR: sequence "radacct_radacctid_seq" does not exist

[DBAL-419] [GH-252] Sqlserver limit

Wed, 30 Jan 2013 18:39:38 +0000

This issue is created automatically through a Github pull request on behalf of norzechowicz:

Url: https://github.com/doctrine/dbal/pull/252

Message:

Unfortunately fix from my last commit it not enough to handle more complicated queries.
This change should fix points 2 and 3 [from this list](http://www.doctrine-project.org/jira/browse/DDC-1785) but it also removes adding TOP statement if ``$offset`` is not set.
I know it looks realy messy but I can't figure out any other solution to handel queries with subqueries and ordering (such thing is generated after using Doctrine Paginator and ordering).

[DBAL-418] [GH-251] Escape identifier names in MySQL ALTER queries

Mon, 1 Apr 2013 16:38:40 +0000

This issue is created automatically through a Github pull request on behalf of Xowap:

Url: https://github.com/doctrine/dbal/pull/251

Message:

The generated MySQL queries did not properly escape the identifier, thus
making it impossible to use SQL keywords as field/index/table name.

Although this is indeed a quite unwise design choice, this is required
for many legacy applications.

The submitted modifications do cover MySQL only, because it is the one that I need to use. However, I think that all the platforms are flawed with this issue and that a general re-work should be done here.

[DBAL-417] [GH-250] Lightweight export as of doctrine/doctrine2#543

Sat, 19 Jan 2013 23:00:19 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/dbal/pull/250

Message:

see doctrine/doctrine2#543

[DBAL-416] [GH-249] Fixed doModifyLimitQuery for SQLServerPlatform

Sun, 20 Jan 2013 11:50:54 +0000

This issue is created automatically through a Github pull request on behalf of norzechowicz:

Url: https://github.com/doctrine/dbal/pull/249

Message:

It seems that there is a problem in SQLServerPlatform ``doModifyLimitQuery`` method.
I can't use Doctrine ORM Paginator because of wrong position of ``DISTINCT`` statement in final limit subquery, here is the exception message I'm getting.
``SQLSTATE[42000]: [Microsoft][SQL Server Native Client 10.0][SQL Server]Incorrect syntax near the keyword 'DISTINCT'.``

My proposition is to change ``doModifyLimitQuery`` result from:

``SELECT * FROM (SELECT ROW_NUMBER() OVER (ORDER BY username DESC) AS doctrine_rownum, * FROM user) ...``

into:

``SELECT * FROM (SELECT *, ROW_NUMBER() OVER (ORDER BY username DESC) AS doctrine_rownum FROM user) ...``

[DBAL-415] [GH-248] Enable multiple postgresql datetime formats

Mon, 14 Jan 2013 13:23:11 +0000

This issue is created automatically through a Github pull request on behalf of cedriclombardot:

Url: https://github.com/doctrine/dbal/pull/248

Message:

Postgre use ISO 8601 date formats so some times can be Y-m-d H:i:s or sometime Y-m-d H:i:s.u

[DBAL-414] zaza

Wed, 9 Jan 2013 18:30:19 +0000

[DBAL-413] [GH-247] Obtain all informations about a column via Column::toArray()

Tue, 8 Jan 2013 15:33:50 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/247

Message:

[DBAL-412] PostgreSqlSchemaManager::listTableColumns() fails if there are columns defined by domains in multiple schemas

Wed, 1 May 2013 12:53:32 +0000

We use Postgresql Domains to ensure consistent column definitions across multiple tables. We also have multiple schemas in a database. Therefore we can have two domains defined in the same database with the same name, but in different schemas.

In this situation, PostgreSqlSchemaManager::listTableColumns() fails when called for a table with a column defined by one of those domains. This means that PostgreSqlSchemaManager::createSchema() also fails for a schema containing such a table.

```
SQLSTATE[21000]: Cardinality violation: 7 ERROR: more than one row returned by a subquery used as an expression
```

This happens because of an error in the query definition in PostgreSqlPlatform::getListTableColumnsSQL(). The domain_complete_type column in the query is defined by matching the name only, without reference to the schema:

(SELECT format_type(t2.typbasetype, t2.typtypmod) FROM   
  pg_catalog.pg_type t2                                                        
                       WHERE t2.typtype = 'd' AND t2.typname = format_type(a.atttypid, a.atttypmod)) AS domain_complete_type,

The error can be corrected by making sure that the correct domain is matched by using the OID instead of the name to match:

(SELECT format_type(t2.typbasetype, t2.typtypmod) FROM   
  pg_catalog.pg_type t2                                                        
                       WHERE t2.typtype = 'd' AND t2.oid = a.atttypid) AS domain_complete_type

I can create a GitHub PR if it helps.

[DBAL-411] Schema updater breaks when using backticks in tablenames.

Tue, 8 Jan 2013 11:24:46 +0000

When using backticks around table-names (for example "`Order`"), the Doctrine schema update tool wants to recreate all foreign keys on every run.

This error was introduced in commit cb3ec49cb4401bd1c8be6ba9671f651802586eaf

[DBAL-410] [GH-246] Fixed sql for creating table with fulltext index

Tue, 8 Jan 2013 15:40:37 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/246

Message:

[DBAL-409] [GH-245] Added support for column collation

Sat, 4 May 2013 13:07:13 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/245

Message:

[DBAL-408] [GH-244] Enable Postgresql plateform to map inet column type

Tue, 8 Jan 2013 15:26:05 +0000

This issue is created automatically through a Github pull request on behalf of cedriclombardot:

Url: https://github.com/doctrine/dbal/pull/244

Message:

http://www.postgresql.org/docs/8.2/static/functions-net.html

[DBAL-407] Refactor exceptions

Mon, 6 May 2013 06:10:18 +0000

It's currently rather hard to figure out what went wrong when for example a DBALException was thrown. You have to actually match the message in it, or read the status code of the ->getPrevious() exception, which can be different for all drivers (as https://github.com/jackalope/jackalope-doctrine-dbal/issues/80 shows).

I'd suggest creating new exception classes for all situations and throwing them instead. If they extend the DBAL Exception and pass the message to it as it is right now, there will be no BC break.

If this were to be done, on which branch should this be applied?

[DBAL-406] PostgreSqlSchemaManager::tablesExist() misses schema-qualified table names if they exist in the first schema on the search path

Mon, 7 Jan 2013 08:33:41 +0000

Please see https://github.com/doctrine/migrations/issues/99 for additional background.

To reproduce:

CREATE SCHEMA test_schema;
CREATE TABLE test_schema.test_table (test_column TEXT);

Then in Doctrine:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

$connection->executeUpdate('SET search_path=test_schema;');
$result = $connection->getSchemaManager()->tablesExist(array('test_schema.test_table'));

$result is false when it should be true.

The error occurs because PostgreSqlSchemaManager returns the bare table name from getPortableTablesList() if the schema is the first one in the search path.

The full explanation is...

AbstractSchemaManager::tablesExist() calls $this->getPortableTablesList() before checking if the tables exist.

PostgreSqlSchemaManager overrides this in _getPortableTableDefinition() by comparing the schema for the table with the search path for the connection. If the table schema is the first one in the search path, then it returns the bare table name, if it isn't then it returns the schema-qualified table name (i.e. schema.table).

tablesExist() does an array_intersect to check that all the tables in the search array exist in the database.

If one of the tables in the search array was schema-qualified but also in the first schema on the search path, then you end up checking:

array_intersect(array('test_schema.test_table'), array('test_table'))

which fails.

One way to fix it would be to override tablesExist() in PostgreSqlSchemaManager so that it passes the search array through getPortableTableDefinition() before doing the array_intersect:

Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

    /**
     * Return true if all the given tables exist.
     *
     * @param array $tableNames
     * @return bool
     */
    public function tablesExist($tableNames)
    {
        foreach ($tableNames as $key => $tableName) {
            if (strpos($tableName, '.') !== false) {
                $tableName = explode('.', $tableName, 2);
                $tableNames[$key] = $this->_getPortableTableDefinition(array('schema_name'=>$tableName[0], 'table_name'=>$tableName[1]));
            }
        }
        return parent::tablesExist($tableNames);
    }

I'm happy to provide a PR on GitHub if you want.

[DBAL-405] [GH-241] Added support of key length for text indexes

Sun, 30 Dec 2012 17:26:39 +0000

This issue is created automatically through a Github pull request on behalf of maxlun86:

Url: https://github.com/doctrine/dbal/pull/241

Message:

[DBAL-404] Support of index length for text fields

Sat, 29 Dec 2012 20:31:53 +0000

For table with text field description with index on it generated query is:

CREATE TABLE t (id INT UNSIGNED AUTO_INCREMENT NOT NULL, description LONGTEXT DEFAULT NULL, number INT DEFAULT NULL, INDEX index2 (description), INDEX index3 (description, number), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB

This query lead to error, because for index on text field absented key length.

[DBAL-403] [GH-240] Fix for DBAL-209

Sun, 6 Jan 2013 09:07:04 +0000

This issue is created automatically through a Github pull request on behalf of nemekzg:

Url: https://github.com/doctrine/dbal/pull/240

Message:

Fix for DBAL-209

[DBAL-402] Fatal error: Uncaught exception

Mon, 8 Apr 2013 18:23:52 +0000

Fatal error: Uncaught exception 'Doctrine\DBAL\Driver\OCI8\OCI8Exception' with message 'ORA-00904: "T0"."ID": invalid identifier' in /var/www/doctrine/doctrine/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Exception.php on line 28 Doctrine\DBAL\Driver\OCI8\OCI8Exception: ORA-00904: "T0"."ID": invalid identifier in /var/www/doctrine/doctrine/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Exception.php on line 28

Call Stack: 0.0002 665368
1. {main}() /var/www/doctrine/doctrine/tools/sandbox/index.php:0 0.3389 6023864
2. Doctrine\ORM\EntityManager->find() /var/www/doctrine/doctrine/tools/sandbox/index.php:71 0.3514 8264024
3. Doctrine\ORM\Persisters\BasicEntityPersister->load() /var/www/doctrine/doctrine/lib/Doctrine/ORM/EntityManager.php:444 0.3521 8413576 
4. Doctrine\DBAL\Connection->executeQuery() /var/www/doctrine/doctrine/lib/Doctrine/ORM/Persisters/BasicEntityPersister.php:725 0.3532 8625920
5. Doctrine\DBAL\Driver\OCI8\OCI8Statement->execute() /var/www/doctrine/doctrine/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php:635 Variables in local scope (#5): $hasZeroIndex = *uninitialized* $key = *uninitialized* $params = NULL $ret = FALSE $val = *uninitialized*

[DBAL-401] Log connection info with SQL logger

Fri, 28 Dec 2012 14:23:33 +0000

while using MasterSlave connection, it would be nice to see the connection being used ( master or which slave), this will help debug the app, if lots read queries are going to Master

[DBAL-400] can't add primary key to mysql table after the table is created

Thu, 20 Dec 2012 07:08:06 +0000

A table in this application had no primary keys. I created an entity
so i could attempt to use the doctrine:schema:update command to fix it up.

When i attempted to add this:

@ORM\Id
@ORM\GeneratedValue(strategy="NONE")

to this:

@ORM\Column(name="session_id", type="string", length=128,
nullable=false)

it generates SQL like this:

ALTER TABLE whos_online DROP INDEX idx_session_id_zen, ADD UNIQUE INDEX primary (session_id);
ALTER TABLE whos_online CHANGE ip_address ip_address VARCHAR(45) NOT NULL, CHANGE host_address host_address VARCHAR(512) NOT NULL;

and says this:

An exception occurred while executing 'ALTER TABLE whos_online DROP INDEX idx_session_id_zen, ADD UNIQUE INDEX primary (session_id );
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to
your MySQL server version for the right syntax to use near 'primary (session_id)' at line 1

[DBAL-399] [GH-237] Do not treat assignment operator as a parameter DBAL-398

Sat, 22 Dec 2012 11:35:14 +0000

This issue is created automatically through a Github pull request on behalf of roverwolf:

Url: https://github.com/doctrine/dbal/pull/237

Message:

A native (mysql) query should be able to use the assignment operator := but currently the SQLParserUtils method treats that as a missing parameter.

The patch solves the issue, but it looks like a higher-level fix might be desired that also handles the regular expression better.

[DBAL-398] Native query does not allow mysql assignment operator :=

Thu, 3 Jan 2013 22:38:50 +0000

When trying to use the mysql assignment operator in a native query one gets an exception as SqlParserUtils does not qualify the character after the : as being part of a valid parameter value.

Undefined index: in vendor/doctrine/dbal/lib/Doctrine/DBAL/SQLParserUtils.php line 156 (uncaught exception)

A simple example is
$rsm = new ResultSetMapping();
$rsm->addScalarResult('rank', 'rank');
$qry = $em->createNativeQuery("
SELECT (@rank := 1) AS rank
");
$result = $qry->getResult(Query::HYDRATE_ARRAY);

Or a more complicated example is (similar to actual use):

$rsm = new ResultSetMapping();
$rsm->addScalarResult('rank', 'rank');
$qry = $em->createNativeQuery("
SELECT rank FROM
(SELECT (@rank := @rank +1) AS rank FROM (SELECT @rank :=0) rnk2) rnk1
");
$result = $qry->getResult(Query::HYDRATE_ARRAY);

I have attached quick-fix patch, but it looks like the getPlaceholderPositions method is wanting something better overall (due to the TODO comment in it).

[DBAL-397] PostgreSQL - getDateTimeTzFormatString()

Mon, 17 Dec 2012 15:21:20 +0000

In:

vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php

The function:

getDateTimeTzFormatString()

only returns one datetime format:


    /**
     * {@inheritDoc}
     */
    public function getDateTimeTzFormatString()
    {
        //return 'Y-m-d H:i:sO'; // original format
        return 'Y-m-d H:i:s.uO'; // format also needed
    }

Here is the error I get using the original format:

Could not convert database value "2012-12-07 16:01:52.580789-05" to Doctrine Type datetimetz. Expected format: Y-m-d H:i:s.O

If I use this format: 'Y-m-d H:i:s.uO' it works.

[DBAL-396] [GH-236] DBAL-200 Missing docs for 1 parameter in Connection::update

Wed, 12 Dec 2012 13:34:39 +0000

This issue is created automatically through a Github pull request on behalf of posulliv:

Url: https://github.com/doctrine/dbal/pull/236

Message:

Trivial addition of docs for 1 parameter that was missing in Connection::update. Resolves an open issue so figured it was worth a pull request.

[DBAL-395] [GH-235] Update links in Readme

Mon, 3 Dec 2012 19:48:02 +0000

This issue is created automatically through a Github pull request on behalf of joshuajabbour:

Url: https://github.com/doctrine/dbal/pull/235

Message:

Just updating some broken and old links in the Readme file.

[DBAL-394] Unsigned integers are not respected by the schema tool for assocations

Fri, 3 May 2013 14:37:41 +0000

Before commenting, I've done so much debugging and searching into this issue and if I missed something major, I apologise.

From what I understand, the ORM doesn't care about unsigned. That's fair enough. That leaves it to DBAL to handle it.

However, it's not possible to successfully use something like the following table without having the schema manager complain.

CREATE TABLE `account` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT COMMENT '(DC2Type:unsigned_integer)',
  `user_id` int(10) unsigned DEFAULT NULL COMMENT '(DC2Type:unsigned_integer)',
  PRIMARY KEY (`id`),
  KEY `IDX_7D3656A461220EA6` (`user_id`)
) ENGINE=InnoDB

In that code, I'm using a custom type "unsigned_integer" that extends the DBAL integer type with this:

    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
    {
        $fieldDeclaration['unsigned'] = true;

        return $platform->getIntegerTypeDeclarationSQL($fieldDeclaration);
    }

The reason for this is because the ORM won't map unsigned ints for me. Combined with this is an event listener for the class metadata. Something like this:

    /**
     * Maps additional metadata.
     *
     * Specifically, if there exist an unsigned integer field, attach the
     * "unsigned" option to it. This is required because the Doctrine ORM does
     * not do this and we are using "UNSIGNED INT"s in our MySQL columns.
     * Without this. the Doctrine Schema Tool will complain about column
     * differences.
     *
     * Note: there is no performance impact in doing this because the class
     * metadata should be cached after the first request.
     *
     * @param LoadClassMetadataEventArgs $eventArgs
     */
    public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs)
    {
        foreach ($eventArgs->getClassMetadata()->fieldMappings as &$mapping) {
            if (isset($mapping['type']) && UnsignedIntegerType::UNSIGNED_INTEGER === $mapping['type']) {
                if (!isset($mapping['options'])) {
                    $mapping['options'] = array();
                }

                $mapping['options']['unsigned'] = true;
            }
        }
    }

Now, in the example table above, the schema tool will honour the "id" column, however it won't honour the association join column no matter what I do. My attempts include adding an event listener for class meta data as above (basically tricking the ORM) and also adding an event listener for the schema events.

The other day on GitHub there was a commit (https://github.com/doctrine/doctrine2/commit/a27be2fab61b1cfde4d2ecbc729a4a68816fca76) to help with this, but it's still not all working.

Also, comments and issues on the Jira tracker have said how there's legacy code related to "unsigned" and "default", but I can't tell what's legacy and what's allowed, especially when there's a commit like that one above.

By the way, I have found that the simple unsigned field mapping works. E.g.:

    fields:
        counter:
            type: integer
            column: counter
            options:
                unsigned: true

If it helps at all, here's the YAML mapping file for the above table/entity:

Account:
    type: entity
    table: account
    id:
        id:
            type: unsigned_integer
            generator:
                strategy: AUTO
    manyToOne:
        creator:
            targetEntity: User
            joinColumn:
                name: user_id
                referencedColumnName: id # Note: user table id is also unsigned_integer

Is it possible to 1) fix this or 2) let me know if I'm just doing something wrong?

Note: as I said above, I know that Doctrine DBAL and ORM does not care so much for unsigned ints because of portability, etc. but it seems that because of that commit above (24 days ago), there's a half-implememented/legacy solution going on here.

Cheers,
Jon

[DBAL-393] PEAR install broken

Sun, 25 Nov 2012 12:05:50 +0000

When using PEAR install, the "doctrine-dbal" command does not work.

$ pear install doctrine/DoctrineDBAL
downloading DoctrineDBAL-2.3.0.tgz ...
Starting to download DoctrineDBAL-2.3.0.tgz (143,996 bytes)
................................done: 143,996 bytes
install ok: channel://pear.doctrine-project.org/DoctrineDBAL-2.3.0

$ which doctrine-dbal
/usr/bin/doctrine-dbal

$ /usr/bin/doctrine-dbal
PHP Warning: require(Doctrine/Symfony/Component/Console/Helper/HelperSet.php): failed to open stream: No such file or directory in /usr/share/pear/Doctrine/Common/ClassLoader.php on line 164
PHP Stack trace:
PHP 1. {main}() /usr/bin/doctrine-dbal:0
PHP 2. include() /usr/bin/doctrine-dbal:4
PHP 3. Doctrine\Common\ClassLoader->loadClass() /usr/bin/doctrine-dbal:0
PHP Fatal error: require(): Failed opening required 'Doctrine/Symfony/Component/Console/Helper/HelperSet.php' (include_path='.:/usr/share/pear:/usr/share/php') in /usr/share/pear/Doctrine/Common/ClassLoader.php on line 164
PHP Stack trace:
PHP 1. {main}() /usr/bin/doctrine-dbal:0
PHP 2. include() /usr/bin/doctrine-dbal:4
PHP 3. Doctrine\Common\ClassLoader->loadClass() /usr/bin/doctrine-dbal:0

The issue can be fixed by updating file doctrine-dbal.php from:
$classLoader = new \Doctrine\Common\ClassLoader('Symfony', 'Doctrine');
to:
$classLoader = new \Doctrine\Common\ClassLoader('Symfony');
so the Symfony Console package can be used like the PEAR package.xml requires.

NOTE: I did not want to submit a GitHub pull request for this because it seems like it would break your Git and Composer installs

[DBAL-392] Moving entity relationship doesn't move foreign key in mysql table

Reference — Sun, 23 Dec 2012 20:31:22 +0000

This is the copy of bug http://www.doctrine-project.org/jira/browse/DDC-2161 that I've moved here since it's related to the dbal and not the orm.

Basically when you update just the foreign table of a foreign key the constrain doesn't gets updated.

[DBAL-391] [GH-233] convertToPHPValue should match convertToDatabaseValue

Mon, 26 Nov 2012 16:40:50 +0000

This issue is created automatically through a Github pull request on behalf of zyjohn:

Url: https://github.com/doctrine/dbal/pull/233

Message:

convertToPHPValue return resource which is not match default convertToDatabaseValue that not make and change. Change to return content of the resource.

[DBAL-390] Wrap SQL for Selects in an Object for Metadata?

Fri, 23 Nov 2012 12:48:05 +0000

Wrap SQL for Selects in an Object for Metadata?

[DBAL-389] [GH-232] Problem with sequence names, PostgreSQL and MixedCased schemas

Thu, 22 Nov 2012 15:46:51 +0000

This issue is created automatically through a Github pull request on behalf of ajgarlag:

Url: https://github.com/doctrine/dbal/pull/232

Message:

I''m having problems with a doctrine migration in a pgsql database that has a mixed case schema name.

After some investigation I've found the origin of the problem: when the schema manager is going to list sequences it executes a SQL statement to find the minimun sequence value.

This SQL statement is not quoting the sequence name, so the SQL fails with mixed cased schemas.

This trivial commit resolves this problem. I think it could be backported to stable versions of DBAL.

[DBAL-388] [GH-231] Update lib/Doctrine/DBAL/Types/BlobType.php

Thu, 9 May 2013 14:05:04 +0000

This issue is created automatically through a Github pull request on behalf of mikemeier:

Url: https://github.com/doctrine/dbal/pull/231

Message:

If allow_url_fopen isnt enabled, fopen will return false.

[DBAL-387] [GH-230] Fixed SQL Server Platform NULL declaration

Sun, 25 Nov 2012 18:07:30 +0000

This issue is created automatically through a Github pull request on behalf of Lusitanian:

Url: https://github.com/doctrine/dbal/pull/230

Message:

Per previous pull request but based on master. SQL server does not use 'DEFAULT NULL' for marking columns as nullable, only 'NULL'.

[DBAL-386] [GH-229] Fixed SQL Server Platform NULL declaration

Sun, 25 Nov 2012 12:01:19 +0000

This issue is created automatically through a Github pull request on behalf of Lusitanian:

Url: https://github.com/doctrine/dbal/pull/229

Message:

In SQL Server, 'DEFAULT NULL' is invalid for allowing a column to be null – the 'NULL' keyword is the only required indicator of nullability.

[DBAL-385] Null need set to NULL in array type

Sun, 25 Nov 2012 15:44:45 +0000

When use Array type and NULL value

set null give in database 'N;' (serialise(null))
need NULL

[DBAL-384] Missing TIMESTAMP support

Sat, 27 Apr 2013 07:49:59 +0000

Here's a fix to add support for a TIMESTAMP field in the database.

[DBAL-383] [GH-228] fixed typo for enabling DEFERRED support

Thu, 22 Nov 2012 17:51:44 +0000

This issue is created automatically through a Github pull request on behalf of lsmith77:

Url: https://github.com/doctrine/dbal/pull/228

Message:

old spelling still supported for BC

[DBAL-382] add foreign key support to the SQLite platform

Mon, 7 Jan 2013 10:50:01 +0000

SQLite supports foreign keys since version 3.6.19:
http://www.sqlite.org/foreignkeys.html

note when implementing this it also makes sense to look into fixing this typo (likely keeping the current version in place for BC):
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php#L325

[DBAL-381] [GH-227] MySql TEXT and BLOB type declarations

Sat, 9 Feb 2013 23:33:19 +0000

This issue is created automatically through a Github pull request on behalf of jappie:

Url: https://github.com/doctrine/dbal/pull/227

Message:

Fixed maximum length of MySql TEXT type declaration, this should be 65535 (2 ^ 16 - 1) in stead of 65532.

Added support for TINYBLOB, BLOB, MEDIUMBLOB and LONGBLOB based on the length of the field, the same way as the clob type declarations are determined.

Added tests to prevent regression.

[DBAL-380] [GH-226] Fix for decimal fields with precision.

Sun, 23 Dec 2012 19:50:31 +0000

This issue is created automatically through a Github pull request on behalf of bobdenotter:

Url: https://github.com/doctrine/dbal/pull/226

Message:

These fields have no spaces in the length, so the 'explode' fails. Omit the space from the code, and it works. Even if there were a space, it would still work, because of the `array_map("trim", ..)`.

arr(7)
[
"cid" => str(2) "11"
"name" => str(6) "nummer"
"type" => str(7) "DECIMAL"
"notnull" => str(1) "1"
"dflt_value" => str(1) "0"
"pk" => str(1) "0"
"length" => str(4) "18,9"
]

[DBAL-379] [GH-225] Fix SQLServerPlatform adds unique constraint to ADD PRIMARY KEY statement

Mon, 12 Nov 2012 10:41:39 +0000

This issue is created automatically through a Github pull request on behalf of CraigMason:

Url: https://github.com/doctrine/dbal/pull/225

Message:

Currently when executing an ALTER TABLE statement with SQL Server, the query will be:

This will happen when adding primary keys via ALTER TABLE.

`ALTER TABLE foo ADD PRIMARY KEY (id) WHERE id IS NOT NULL`

should be

`ALTER TABLE foo ADD PRIMARY KEY (id)`

[DBAL-378] [GH-224] default table option not working

Fri, 9 Nov 2012 21:34:28 +0000

This issue is created automatically through a Github pull request on behalf of Steffen-99:

Url: https://github.com/doctrine/dbal/pull/224

Message:

Fixing issue, key name corrected

[DBAL-377] Rename Table foreignkey not changed

Wed, 21 Nov 2012 15:08:08 +0000

if i want to change a tablename the foreign key doesnt change and i get an error

$config = new Doctrine\DBAL\Configuration();
$conn = Doctrine\DBAL\DriverManager::getConnection($conn, $config);
$sm = $conn->getSchemaManager();
foreach ($sm->listTables() as $table) {
$fromSchema = $sm->createSchema();
$toSchema = clone $fromSchema;
$toSchema->renameTable($table->getName(), str_replace("_new", "", $table->getName()));
$sql = $fromSchema->getMigrateToSql($toSchema, $conn->getDatabasePlatform());
foreach ($sql as $query)

{ $conn->query($query); }

}

##################################################
CREATE TABLE doc_consultant_practice (consultant_id INT NOT NULL, practice_id INT NOT NULL, INDEX IDX_60C69DE344F779A2 (consultant_id), INDEX IDX_60C69DE3ED33821 (practice_id), PRIMARY KEY(consultant_id, practice_id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB
ALTER TABLE doc_consultant_practice ADD CONSTRAINT FK_60C69DE3ED33821 FOREIGN KEY (practice_id) REFERENCES doc_xml_practice_new (id) ON DELETE CASCADE
ALTER TABLE doc_consultant_practice ADD CONSTRAINT FK_60C69DE344F779A2 FOREIGN KEY (consultant_id) REFERENCES doc_xml_consultant_new (id) ON DELETE CASCADE
DROP TABLE doc_consultant_practice_new
##################################################
Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'doc_xml_consultant_new' already exists' in /Applications/MAMP/bin/php/php5.3.14/lib/php/Doctrine/ORM/Tools/ToolsException.php on line 33

PDOException: SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'doc_xml_consultant_new' already exists in /Applications/MAMP/bin/php/php5.3.14/lib/php/Doctrine/DBAL/Connection.php on line 646

Call Stack:
0.0178 766208 1.

{main}() /PATH/TO/jobs/import.php:0
0.0430 771936 2. require_once('/PATH/TO/jobs/config.php') /PATH/TO/jobs/import.php:7
0.0528 775448 3. require_once('/PATH/TO/jobs/bootstrap.php') /PATH/TO/jobs/config.php:3
0.0623 812680 4. require_once('/PATH/TO/jobs/bootstrap_doctrine.php') /PATH/TO/jobs/bootstrap.php:5
16.7866 16304048 5. Doctrine\ORM\Tools\SchemaTool->createSchema() /PATH/TO/jobs/bootstrap_doctrine.php:70
16.8798 16562624 6. Doctrine\DBAL\Connection->executeQuery() /Applications/MAMP/bin/php/php5.3.14/lib/php/Doctrine/ORM/Tools/SchemaTool.php:90
16.8804 16564080 7. PDO->query() /Applications/MAMP/bin/php/php5.3.14/lib/php/Doctrine/DBAL/Connection.php:646

Doctrine\DBAL\DBALException: An exception occurred while executing 'CREATE TABLE doc_xml_consultant_new (id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, email VARCHAR(255) DEFAULT NULL, lastCommaFirstName VARCHAR(255) DEFAULT NULL, education LONGTEXT DEFAULT NULL, workHistory LONGTEXT DEFAULT NULL, imageStandard VARCHAR(255) DEFAULT NULL, imageWide VARCHAR(255) DEFAULT NULL, PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB':

SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'doc_xml_consultant_new' already exists in /Applications/MAMP/bin/php/php5.3.14/lib/php/Doctrine/DBAL/DBALException.php on line 47

Call Stack:
0.0178 766208 1. {main}

() /PATH/TO/jobs/import.php:0
0.0430 771936 2. require_once('/PATH/TO/jobs/config.php') /PATH/TO/jobs/import.php:7
0.0528 775448 3. require_once('/PATH/TO/jobs/bootstrap.php') /PATH/TO/jobs/config.php:3
0.0623 812680 4. require_once('/PATH/TO/jobs/bootstrap_doctrine.php') /PATH/TO/jobs/bootstrap.php:5
16.7866 16304048 5. Doctrine\ORM\Tools\SchemaTool->createSchema() /PATH/TO/jobs/bootstrap_doctrine.php:70
16.8798 16562624 6. Doctrine\DBAL\Connection->executeQuery() /Applications/MAMP/bin/php/php5.3.14/lib/php/Doctrine/ORM/Tools/SchemaTool.php:90

Doctrine\ORM\Tools\ToolsException: Schema-Tool failed with Error 'An exception occurred while executing 'CREATE TABLE doc_xml_consultant_new (id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, email VARCHAR(255) DEFAULT NULL, lastCommaFirstName VARCHAR(255) DEFAULT NULL, education LONGTEXT DEFAULT NULL, workHistory LONGTEXT DEFAULT NULL, imageStandard VARCHAR(255) DEFAULT NULL, imageWide VARCHAR(255) DEFAULT NULL, PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB':

SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'doc_xml_consultant_new' already exists' while executing DDL: CREATE TABLE doc_xml_consultant_new (id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, email VARCHAR(255) DEFAULT NULL, lastCommaFirstName VARCHAR(255) DEFAULT NULL, education LONGTEXT DEFAULT NULL, workHistory LONGTEXT DEFAULT NULL, imageStandard VARCHAR(255) DEFAULT NULL, imageWide VARCHAR(255) DEFAULT NULL, PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB in /Applications/MAMP/bin/php/php5.3.14/lib/php/Doctrine/ORM/Tools/ToolsException.php on line 33

Call Stack:
0.0178 766208 1.

{main}

[DBAL-376] [GH-223] Include customSchemaOptions in column mapping

Mon, 14 Jan 2013 15:38:44 +0000

This issue is created automatically through a Github pull request on behalf of djlambert:

Url: https://github.com/doctrine/dbal/pull/223

Message:

This PR adds the customSchemaOptions in the array passed to the type.

[DBAL-375] Warning "Udefined index dbname" while creating database with oci8 driver

Sat, 20 Apr 2013 08:48:22 +0000

In config specified:

doctrine:
dbal:
driver: "oci8"
host: "localhost"
port: "1521"
dbname: "orcl50"
user: "SYSTEM"
password: "123456"
charset: UTF8

When i create database (with symfony 2, doctrine:database:create), got that error:

=====================================
Could not create database for connection named orcl50
Notice: Undefined index: dbname in /path/to/symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Driver/OCI8/Driver.php line 67
=====================================

If i comment "unset($params['dbname'])" in CreateDatabaseDoctrineCommand.php:54 all works fine.

[DBAL-374] [GH-222] Escape primary field name in create table sql query

Tue, 13 Nov 2012 19:07:49 +0000

This issue is created automatically through a Github pull request on behalf of Genokilller:

Url: https://github.com/doctrine/dbal/pull/222

Message:

Fixes primary fields name in CreateTableSQL for Abstract Platform

[DBAL-373] Indexes and uniqueConstraints has been ignored

Sat, 20 Apr 2013 09:53:26 +0000

I using the Doctrine Migrations and when I declared my entity with the indexes section, the index name has been ignored. It's like this:

indexes:
IDX_ADDRESS_CITY:
columns: city_id

but, the diff tools ignore it and give me this code:
$this->addSql("CREATE INDEX IDX_7299B5238BAC62AF ON tb_address (city_id)");

and it should be:
$this->addSql("CREATE INDEX IDX_ADDRESS_CITY ON tb_address (city_id)");

Notice: I open the same bug on the migrations repository in github and @kimhemsoe told me to open here, since this is generated by DBAL component.

[DBAL-372] Add SQL parser

Thu, 25 Oct 2012 12:52:51 +0000

It is useful for create sql highlighter. See https://github.com/doctrine/DoctrineBundle/pull/117 or https://github.com/doctrine/DoctrineBundle/issues/107

[DBAL-371] DBALException doesn't forward the SQL exception code

Thu, 9 May 2013 15:12:24 +0000

PDO exceptions carry the SQL error code. However DBALException doesn't forward any error code from the SQL exception.

Here is a (really poor/quick) example of usage:

try {
    $em->flush();
} catch (DBALException $e) {
    if ($e->getCode() === 23000) {
        echo '';
    } else {
        throw $e;
    }
}

I think I found where the problem is:

public static function driverExceptionDuringQuery(\Exception $driverEx, $sql, array $params = array())
{
    $msg = "An exception occurred while executing '".$sql."'";
    if ($params) {
        $msg .= " with params ".json_encode($params);
    }
    $msg .= ":\n\n".$driverEx->getMessage();

    return new self($msg, 0, $driverEx);
}

In return new self($msg, 0, $driverEx);, the exception is created with an error code of 0.

Is there a reason for this: is that that the driver exception may not always have a defined error code? (for example if the sql driver is not PDO or the SQL system doesn't support that, but in this case then the error code would be 0 would that be a problem?)

[DBAL-370] [GH-220] Added support for alter table, foreign keys and autoincrement detection to Sqlite platform and schema

Wed, 2 Jan 2013 10:29:22 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/220

Message:

[DBAL-369] [GH-219] Fix storage of binary data for array and object types

Fri, 19 Oct 2012 11:54:02 +0000

This issue is created automatically through a Github pull request on behalf of kdambekalns:

Url: https://github.com/doctrine/dbal/pull/219

Message:

serialize() returns binary data (NUL bytes) and not all platforms
handle that in CLOB fields (e.g. PostgreSQL).

This change uses base64 encoding to work around that, and transparently
reads (old) non-base64 data as well.

Fixes ~~DBAL-368~~

[DBAL-368] array and object types should use BLOB, not CLOB, to store serialized data

Wed, 23 Jan 2013 21:54:22 +0000

When using array or object types, PHP's serialize() is used. Since that can return NUL bytes, using a text type will fail at least on PostgreSQL (just search the web for issues of that kind…).

So ArrayType and ObjectType should return a BLOB definition instead of a CLOB definition to be binary-safe.

[DBAL-367] Reverse engnering do not work with Oracle DB

Wed, 23 Jan 2013 21:55:55 +0000

$ doctrine orm:convert-mapping --filter="ms$ions" xml .

  [Doctrine\DBAL\DBALException]
  Unknown database type binary_float requested, Doctrine\DBAL\Platforms\OraclePlatform may not support it.

cli-config.php:


use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Common\Annotations\AnnotationRegistry;

require_once 'Doctrine/Common/ClassLoader.php';

define('APPLICATION_ENV', "development");
error_reporting(E_ALL);

$classLoader = new \Doctrine\Common\ClassLoader('Doctrine');
$classLoader->register();

$config = new \Doctrine\ORM\Configuration();
$config->setProxyDir(__DIR__);
$config->setProxyNamespace('Proxies');

$config->setAutoGenerateProxyClasses((APPLICATION_ENV == "development"));

AnnotationRegistry::registerFile("Doctrine/ORM/Mapping/Driver/DoctrineAnnotations.php");
$reader = new AnnotationReader();
$driverImpl = new \Doctrine\ORM\Mapping\Driver\AnnotationDriver($reader, array(__DIR__ . "/../php/ru/niifhm/bioinformatics/biodb/model"));
$config->setMetadataDriverImpl($driverImpl);

if (APPLICATION_ENV == "development") {
    $cache = new \Doctrine\Common\Cache\ArrayCache();
} else {
    $cache = new \Doctrine\Common\Cache\ApcCache();
}

$config->setMetadataCacheImpl($cache);
$config->setQueryCacheImpl($cache);

$connectionOptions = array(
    'driver'   => 'oci8',
    'host'     => 'host.name',
    'dbname'   => 'db.name',
    'user'     => 'user.name',
    'password' => 'user.password'
);

$em = \Doctrine\ORM\EntityManager::create($connectionOptions, $config);
$platform = $em->getConnection()->getDatabasePlatform();
$platform->registerDoctrineTypeMapping('enum', 'string');

$em->getConfiguration()->setMetadataDriverImpl(
    new \Doctrine\ORM\Mapping\Driver\DatabaseDriver(
        $em->getConnection()->getSchemaManager()
    )
);

$helperSet = new \Symfony\Component\Console\Helper\HelperSet(array(
    'db' => new \Doctrine\DBAL\Tools\Console\Helper\ConnectionHelper($em->getConnection()),
    'em' => new \Doctrine\ORM\Tools\Console\Helper\EntityManagerHelper($em)
));

[DBAL-366] [GH-218] [MySQL] Fixed bug with comments not adding quotes for tables

Sun, 6 Jan 2013 10:41:13 +0000

This issue is created automatically through a Github pull request on behalf of okovalov:

Url: https://github.com/doctrine/dbal/pull/218

Message:

Title describes everything... =)

[DBAL-365] [GH-217] Remember to close temporary connection in PostgreSqlSchemaManager::dropD...

Fri, 12 Oct 2012 20:02:22 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/217

Message:

...atabase() and PostgreSqlSchemaManager::createDatabase()

Fixes my problem with not to be able to run all tests.

[DBAL-364] [GH-216] Fixed SQL placeholder parsing

Sat, 19 Jan 2013 18:26:56 +0000

This issue is created automatically through a Github pull request on behalf of a-nik:

Url: https://github.com/doctrine/dbal/pull/216

Message:

Fixed comment on 'getPlaceholderPositions' method
Fixed error on escaped quote mark inside an SQL expression

[DBAL-363] [GH-215] Remove unneeded use statement

Mon, 5 Nov 2012 22:49:34 +0000

This issue is created automatically through a Github pull request on behalf of jsjohns:

Url: https://github.com/doctrine/dbal/pull/215

Message:

[DBAL-362] [GH-214] The "bindParam" method of OCI8Statement is not using the "length" parameter

Thu, 9 May 2013 15:36:48 +0000

This issue is created automatically through a Github pull request on behalf of theUniC:

Url: https://github.com/doctrine/dbal/pull/214

Message:

I've fixed the ```OCI8Statement::bindParam``` method in order to pass the "length" parameter when the type is not a LOB

https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php#L112

As noted on the description of the function on the PHP manual (for the IN binds), this is leading to a truncation of the values to the size of the PHP variable.

http://www.php.net/manual/en/function.oci-bind-by-name.php

[DBAL-361] [GH-213] fixed bug on schema comparator, prevent multiple rename candidates for a single original field

Wed, 1 May 2013 12:26:39 +0000

This issue is created automatically through a Github pull request on behalf of leedavis81:

Url: https://github.com/doctrine/dbal/pull/213

Message:

Starting with the following Entity
```
/**

@Table(name="user")
@Entity
*/
class User { /** * @var integer $id * @Column(name="id", type="integer", length=4) * @Id * @GeneratedValue(strategy="IDENTITY") */ private $id; /** * @var \DateTime $date_alerted_email * @Column(name="date_alerted", type="datetime", nullable=true) */ private $date_alerted; }
```
Upon making the following alterations (remove date_alerted, and add two additional columns of the same type but different names):
```
/**
@Table(name="user")
@Entity
*/
class User { /** * @var integer $id * @Column(name="id", type="integer", length=4) * @Id * @GeneratedValue(strategy="IDENTITY") */ private $id; /** * @var \DateTime $date_alerted_email * @Column(name="date_alerted_email", type="datetime", nullable=true) */ private $date_alerted_email; /** * @var \DateTime $date_alerted_js * @Column(name="date_alerted_js", type="datetime", nullable=true) */ private $date_alerted_js; }
```
The doctrine cli schema tool used to run the update (dump sql) produces the following result:
```
ALTER TABLE user CHANGE date_alerted date_alerted_js DATETIME DEFAULT NULL
```
Expected result:
```
ALTER TABLE message ADD date_alerted_js DATETIME DEFAULT NULL, CHANGE date_alerted date_alerted_email DATETIME DEFAULT NULL
```

1. What went wrong

Upon running diffTable($from, $to) in \Doctrine\DBAL\Schema\Comparator.php line 69 both new columns are added to the "addedColumns" array, and the one removed column is correctly present in the removedColumns array.

The first iteration on detectColumnRenamings (line 272) puts the two NEW columns up as rename candidates as expected, however they share the original field name.

When iterating over the rename candidates no further checks are done and these entries are added to the renamedColumns array. The last overwrites the original as they share the same array key and the original gets ignored.

My change checks the renamedColumns array for the existence of the old column name. It only becomes a rename candidate if the original field hasn't already used previously. Otherwise it remains in the addedColumns array.

In the example above these changes will produce 1 change column and 1 add column as expected.

[DBAL-360] [GH-212] Fix dropping foreign key multiple times with test

Fri, 5 Oct 2012 19:26:59 +0000

This issue is created automatically through a Github pull request on behalf of sdepablos:

Url: https://github.com/doctrine/dbal/pull/212

Message:

In some cases the Comparator class returns multiple drops for the same foreign key.
Specifically, in case you have two tables, A & B, with A having a foreign key FK
referencing B, if you drop table B, the resulting diff shows this FK twice,
once on the diff->orphanedForeignKeys array as we're deleting B, and another on
the diff->changedTables array as table A is also being modified. As a result of this you
get the DROP FOREIGN KEY instruction twice in the final SQL.

[DBAL-359] [GH-211] Fix dropping foreign key multiple times with test

Fri, 5 Oct 2012 19:31:12 +0000

This issue is created automatically through a Github pull request on behalf of sdepablos:

Url: https://github.com/doctrine/dbal/pull/211

Message:

I'm not really sure if this change should be done in the Comparator clas or if it's better to
receive the full diff, even with duplicated drops for FK and later, when generating the final
SQL, drop the unnecessary ones

[DBAL-358] This issue should be removed. Wrong merge on github.

Wed, 23 Jan 2013 23:01:19 +0000

This issue should be removed. Wrong merge on github.

[DBAL-357] Missing way to set types for CAST declaration

Thu, 4 Oct 2012 07:50:35 +0000

For a query such as

x = CASE WHEN id=$1 THEN CAST($2 AS int)

there doesn't seem to be a way to correctly assign the type across multiple platforms. E.g. Postgres required "int" but mysql just requires "unsigned". Attempting to use "int" here with mysql will fail.

The method Doctrine\DBAL\Platforms method getIntegerTypeDeclarationSQL will return something like "INT unsigned" for sql, which also fails.

[DBAL-356] [GH-209] Added query micro-optimization

Wed, 1 May 2013 17:26:54 +0000

This issue is created automatically through a Github pull request on behalf of dlsniper:

Url: https://github.com/doctrine/dbal/pull/209

Message:

This adds a micro-optimization to the query and also exposes better the function calls to the profilers like XDebug or XHProf.

[DBAL-355] [GH-208] Optimize autoload prefix in composer.json

Fri, 5 Oct 2012 19:32:02 +0000

This issue is created automatically through a Github pull request on behalf of Slamdunk:

Url: https://github.com/doctrine/dbal/pull/208

Message:

By having more specific autoload prefixes it is possible to reduce the number of stat calls made.

[DBAL-354] [GH-207] Removed Unsigned Integer Support in SQL Server

Fri, 5 Oct 2012 19:33:53 +0000

This issue is created automatically through a Github pull request on behalf of datiecher:

Url: https://github.com/doctrine/dbal/pull/207

Message:

Removed unsigned integer test as SQL Server doesn't support unsigned integers.

[DBAL-353] doctrine:schema:update doesn't understand it doesn't need to run again

Wed, 23 Jan 2013 22:48:55 +0000

doctrine:schema:update keeps thinking there is more to do:

$ php app/console doctrine:schema:update --dump-sql
ALTER TABLE Account CHANGE guid guid VARCHAR(255) NOT NULL;
ALTER TABLE Customer CHANGE guid guid VARCHAR(255) NOT NULL, CHANGE authGuid authGuid VARCHAR(255) NOT NULL

$ php app/console doctrine:schema:update --force   
Updating database schema...
Database schema updated successfully! "2" queries were executed

$ php app/console doctrine:schema:update --dump-sql
ALTER TABLE Account CHANGE guid guid VARCHAR(255) NOT NULL;
ALTER TABLE Customer CHANGE guid guid VARCHAR(255) NOT NULL, CHANGE authGuid authGuid VARCHAR(255) NOT NULL

[DBAL-352] Running doctrine:schema:update throws an exception the first time, succeeds the second time.

Tue, 25 Sep 2012 14:35:32 +0000

Shell output from my symfony project:
$ app/console doctrine:schema:update --force
Updating database schema...

[Doctrine\DBAL\DBALException]
An exception occurred while executing 'ALTER TABLE Tn ADD CONSTRAINT FK_3504C6F07D3656A4 FOREIGN KEY (account) REFERENCES Account (id)':

SQLSTATE[42000]: Syntax error or access violation: 1072 Key column 'account' doesn't exist in table

[PDOException]
SQLSTATE[42000]: Syntax error or access violation: 1072 Key column 'account' doesn't exist in table

doctrine:schema:update [--complete] [--dump-sql] [--force] [--em[="..."]]

$ app/console doctrine:schema:update --force
Updating database schema...
Database schema updated successfully! "7" queries were executed
$

[DBAL-351] [GH-206] Set minimum PHP version to 5.3.6

Fri, 5 Oct 2012 17:11:34 +0000

This issue is created automatically through a Github pull request on behalf of nicolas-grekas:

Url: https://github.com/doctrine/dbal/pull/206

Message:

Since ->setCharset() has been removed, minimum PHP version has to be raised to 5.3.6: the new way of doing charset, throught the DSN, works only after bug https://bugs.php.net/bug.php?id=47802 has been fixed.

[DBAL-350] [GH-205] Added exit code for dbal:reserved-words command

Fri, 5 Oct 2012 20:31:42 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/205

Message:

[DBAL-349] [GH-203] Delete always content from table master_slave_table between tests.

Fri, 5 Oct 2012 20:22:18 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/203

Message:

Fixes that we are currently failing master slave tests.

[DBAL-348] [GH-202] Fixed DBAL-139 Oracle's sequences with NOCACHE

Sun, 6 Jan 2013 18:56:59 +0000

This issue is created automatically through a Github pull request on behalf of AduroIdea:

Url: https://github.com/doctrine/dbal/pull/202

Message:

[DBAL-347] [GH-201] fix some phpdoc

Fri, 5 Oct 2012 20:27:21 +0000

This issue is created automatically through a Github pull request on behalf of KonstantinKuklin:

Url: https://github.com/doctrine/dbal/pull/201

Message:

[DBAL-346] Generated schema fails on MySQL (BLOB/TEXT cant have DEFAULT value)

Thu, 20 Sep 2012 17:29:30 +0000

In my symfony 2.1 project i was including JMSPaymentCoreBundle and did the vanilla installation.

After that i ran

php app/console doctrine:schema:update --dump-sql
php app/console doctrine:schema:update --force

A lot of schema updates were done. I ran it again, and two schema updates were still showing up.
Running the command again, and they still show up.

I then tried to run the two schema updates against my database and MySQL complains with the following error:

Error: 1101 - BLOB/TEXT column 'extended_data' can't have a default value

According to the Documentation BLOB/TEXT indeed cannot have default values. I am not sure why Doctrine thinks it has to set this default value.

The statements look like this:

sascha@debian:/var/www/myproject/Symfony$ php app/console doctrine:schema:update --dump-sql
ALTER TABLE payment_instructions CHANGE extended_data extended_data LONGTEXT NOT NULL COMMENT '(DC2Type:extended_payment_data)';
ALTER TABLE financial_transactions CHANGE extended_data extended_data LONGTEXT DEFAULT NULL COMMENT '(DC2Type:extended_payment_data)'

I already reported this problem in the JMSPaymentCoreBundle Issue Queue where i then was referred to over here.

Also, i am not sure if Doctrine DBAL is the best match for this issue, so if it is wrong please move it to the right project issue queue.

Thank you very much and best of Regards!
Sascha

[DBAL-345] When inserting decimals into Oracle, getting ORA-01722: invalid number

Mon, 17 Sep 2012 10:23:27 +0000

When I insert decimals into database I get the following error message:

ORA-01722: invalid number

Oracle wants decimals (e.g. NUMBER(5,2)) separated by comma instead of a dot. I think the reason is that I use the german version of Windows. I tried to modify the following method of \Doctrine\DBAL\Driver\OCI8\OCI8Statement::bindValue() just for testing of course:

    public function bindValue($param, $value, $type = null)
    {
        if (is_float($value)) {
            $value = str_replace('.', ',', (string) $value); // <--
        }
        return $this->bindParam($param, $value, $type);
    }

With this modification I do not get the error anymore.
It would be great if a solution could be found. The strange thing is, if I query "SELECT * from nls_database_parameters where PARAMETER='NLS_NUMERIC_CHARACTERS'" I get ".," which means that a dot is already used as decimal separator. Maybe Oracle preferes the Locale of the OS?!
Maybe you could provide a setting which defines what separator should be used for decimals.

I found some Links that might be interesting regarding this issue:

[DBAL-344] [GH-200] params not passed from execute to logger

Mon, 17 Sep 2012 09:36:44 +0000

This issue is created automatically through a Github pull request on behalf of robap:

Url: https://github.com/doctrine/dbal/pull/200

Message:

When parameters are passed to Doctrine\DBAL\Statement::execute, they are not passed to any enabled logger(s).

[DBAL-343] [GH-199] fixed unquoted oldColumnName when changing column definition in MySQL

Thu, 25 Oct 2012 16:30:50 +0000

This issue is created automatically through a Github pull request on behalf of lutzportela:

Url: https://github.com/doctrine/dbal/pull/199

Message:

before:
```ALTER TABLE AlertCondition CHANGE fulltext `fulltext` VARCHAR(255) DEFAULT NULL``` failed.

after:
```ALTER TABLE AlertCondition CHANGE `fulltext` `fulltext` VARCHAR(255) DEFAULT NULL``` passes.

[DBAL-342] [GH-198] Change default MySQL table collation to utf8_unicode_ci

Mon, 12 Nov 2012 17:00:13 +0000

This issue is created automatically through a Github pull request on behalf of VladanStef:

Url: https://github.com/doctrine/dbal/pull/198

Message:

I think default table collation should be changed to `utf8_unicode_ci`, as it handles properly a much wider array of characters (Cyrillic, for example) at a generally negligible cost of performance.

`utf8_general_ci` simply does not work properly with too many languages and should be avoided as a default.

[DBAL-341] [GH-197] Bugfix for DDC-2013

Mon, 17 Sep 2012 10:26:33 +0000

This issue is created automatically through a Github pull request on behalf of naitsirch:

Url: https://github.com/doctrine/dbal/pull/197

Message:

Bugfix DDC-2013 - Default Session Value ".," for "NLS_NUMERIC_CHARACTERS". This is needed because Oracle uses other characters for decimal separation depending on the servers locale.

See http://www.doctrine-project.org/jira/browse/DDC-2013

[DBAL-340] [GH-196] Fixed mini-typo

Mon, 17 Sep 2012 10:35:54 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/dbal/pull/196

Message:

[DBAL-339] setFetchMode arguments exception

Wed, 5 Sep 2012 16:52:37 +0000

i have this error in version 2.3.0-RC1

in DBAL/STatement.php on aound line 191 you will find:

public function setFetchMode($fetchMode, $arg2 = null, $arg3 = null)

{ return $this->stmt->setFetchMode($fetchMode, $arg2, $arg3); }

the problem is that php throws me a Exception:
Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[HY000]: General error: fetch mode doesn't allow any extra arguments'

the reason for the exception is that setFetchMode doesnt support null as second/third argument.

somebody also described it in the php issue tracker:
https://bugs.php.net/bug.php?id=54545

[DBAL-338] Typo in AbstractPlatform for GUID type declaration

Wed, 5 Sep 2012 16:44:44 +0000

has been fixed in 3f5fda98299acdcda9965e8e797cbcd0490f0dcc, however it's not merged into 2.3.

[DBAL-337] Column types are truncated when mapping PostGIS types

Fri, 7 Sep 2012 15:33:20 +0000

When performing a doctrine schema update with Symfony2 ('php app/console doctrine:schema:update --force --verbose') using a custom PostGIS type mapping, column type descriptions are truncated.

How to reproduce:

1) add a custom 'point' type to Doctrine's type mapping

in a controller's boot method

$em = $this->container->get('doctrine.orm.default_entity_manager');
$conn = $em->getConnection();
if (!Type::hasType('point')) {
  Type::addType('point', 'Demo\GeoBundle\Lib\Type\PointType');
  $conn->getDatabasePlatform()->registerDoctrineTypeMapping('point', 'point');
}

PointType.php

<?php

namespace Demo\GeoBundle\Lib\Type;

use Demo\GeoBundle\Lib\Point;

use Doctrine\DBAL\Types\Type; 
use Doctrine\DBAL\Platforms\AbstractPlatform;

class PointType extends Type {

  const POINT = 'point';

  /**
   *
   * @param array $fieldDeclaration
   * @param AbstractPlatform $platform
   * @return string 
   */
  public function getSqlDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
  {
    return 'geography(POINT,'.Point::$SRID.')';
  }

  /**
   *
   * @param type $value
   * @param AbstractPlatform $platform
   * @return Point 
   */
  public function convertToPHPValue($value, AbstractPlatform $platform)
  {
    return Point::fromGeoJson($value);
  }

  public function getName()
  {
    return self::POINT;
    //return 'geography(POINT,'.Point::$SRID.')';
  }

  public function convertToDatabaseValue($value, AbstractPlatform $platform)
  {
    return $value->toWKT();
  }

  public function canRequireSQLConversion()
  {
    return true;
  }

  public function convertToPHPValueSQL($sqlExpr, $platform)
  {
    return 'ST_AsGeoJSON('.$sqlExpr.') ';
  }

  public function convertToDatabaseValueSQL($sqlExpr, AbstractPlatform $platform)
  {
    return $sqlExpr;
  }

}

?>

Point.php

<?php

namespace Demo\GeoBundle\Lib;

use Demo\GeoBundle\Lib\GeoException;

class Point {
  private $lat;
  private $lon;
  public static $SRID = '4326';

  private function __construct($lon, $lat) {
    $this->lat = $lat;
    $this->lon = $lon;
  }
  
  public function setLongitude($lon) {
    $this->lon = $lon;
  }
  
  public function getLongitude() {
    return $this->lon;
  }

  public function setLatitude($lat) {
    $this->lat = $lat;
  }

  public function getLatitude() {
    return $this->lat;
  }

  public function toGeoJson(){
    $array = array("type" => "Point", "coordinates" => array ($this->lon, $this->lat));
    return \json_encode($array);
  }

  /**
   *
   * @return string 
   */
  public function toWKT() {
    return 'SRID='.self::$SRID.';POINT('.$this->lon.' '.$this->lat.')';
  }

  /**
   *
   * @param string $geojson
   * @return Point 
   */
  public static function fromGeoJson($geojson) 
  {
    $a = json_decode($geojson);
    //check if the geojson string is correct
    if ($a == null or !isset($a->type) or !isset($a->coordinates)){
      throw GeoException::badJsonString();
    }

    if ($a->type != "Point"){
      throw GeoException::badGeoType();
    } else {
      $lon = $a->coordinates[0];
      $lat = $a->coordinates[1];
      return Point::fromLonLat($lon, $lat);
    }

  }
  
  /**
   *
   * @return string
   */
  public function __toString() {
    return $this->lon . ' ' . $this->lat;
  }

  /**
   *
   * @return array
   */
  public function toArray() {
    return array($this->lon, $this->lat);
  }

  public static function fromLonLat($lon, $lat)
  {
    if (($lon > -180.0 && $lon < 180.0) && ($lat > -90.0 && $lat < 90.0))
    {
      return new Point($lon, $lat);
    } else {
      throw GeoException::badCoordinates($lon, $lat);
    }
  }
}

?>

GeoException.php

<?php

namespace Demo\GeoBundle\Lib;

class GeoException extends \RuntimeException
{
    public function __construct($message = null, \Exception $previous = null, $code = 0)
    {
        parent::__construct($message, $code, $previous);
    }

    public static function badJSonString()
    {
      return new GeoException("Bad JSon string");
    }

    public static function badGeoType()
    {
      return new GeoException("Bad geo type");
    }

    public static function badCoordinates($lon, $lat)
    {
      return new GeoException("Bad coordinates: " . $lon . " " . $lat);
    }
}

2) with Symfony2, create a simple entity using the Point type:

TestPoint.php

<?php

namespace Demo\TestBundle\Entity;

use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Entity
 * @ORM\Table(name="test_points")
 */
class TestPoint
{
  /**
   * @ORM\Id
   * @ORM\Column(type="integer")
   * @ORM\GeneratedValue(strategy="AUTO")
   */
  protected $id;

  /**
   * @ORM\Column(type="point")
   */
  protected $coordinates;

  /**
   * Get id
   *
   * @return integer 
   */
  public function getId()
  {
    return $this->id;
  }

  /**
   * Set coordinates
   *
   * @param point $coordinates
   * @return Partner
   */
  public function setCoordinates($coordinates)
  {
    $this->coordinates = $coordinates;
    return $this;
  }

  /**
   * Get coordinates
   *
   * @return point 
   */
  public function getCoordinates()
  {
    return $this->coordinates;
  }
  
  public function setLongitude($lon)
  {
    if ($this->coordinates == null)
    {
      $this->coordinates = Point::fromLonLat($lon, 0);
    }
    else
    {
      $this->coordinates->setLongitude($lon);
    }
  }
  
  public function getLongitude()
  {
    return $this->coordinates == null ? 0 : $this->coordinates->getLongitude();
  }
  
  public function setLatitude($lat)
  {
    if ($this->coordinates == null)
    {
      $this->coordinates = Point::fromLonLat(0, $lat);
    }
    else
    {
      $this->coordinates->setLatitude($lat);
    }
  }
  
  public function getLatitude()
  {
    return $this->coordinates == null ? 0 : $this->coordinates->getLatitude();
  }
}

3) use the update script to create the table:

php app/console doctrine:schema:update --force --verbose

4) run it again to update:

php app/console doctrine:schema:update --force --verbose

Errors should ensue:

Errors

[Doctrine\DBAL\DBALException]
Unknown database type geography requested, Doctrine\DBAL\Platforms\PostgreSqlPlatform may not support it.

Exception trace:
() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php:261
Doctrine\DBAL\Platforms\AbstractPlatform->getDoctrineTypeMapping() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/PostgreSqlSchemaManager.php:285
Doctrine\DBAL\Schema\PostgreSqlSchemaManager->_getPortableTableColumnDefinition() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:672
Doctrine\DBAL\Schema\AbstractSchemaManager->_getPortableTableColumnList() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:159
Doctrine\DBAL\Schema\AbstractSchemaManager->listTableColumns() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:254
Doctrine\DBAL\Schema\AbstractSchemaManager->listTableDetails() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:242
Doctrine\DBAL\Schema\AbstractSchemaManager->listTables() at /.../Symfony/vendor/doctrine-dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:830
Doctrine\DBAL\Schema\AbstractSchemaManager->createSchema() at /.../Symfony/vendor/doctrine/lib/Doctrine/ORM/Tools/SchemaTool.php:689
Doctrine\ORM\Tools\SchemaTool->getUpdateSchemaSql() at /.../Symfony/vendor/doctrine/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/UpdateCommand.php:103
Doctrine\ORM\Tools\Console\Command\SchemaTool\UpdateCommand->executeSchemaCommand() at /.../Symfony/vendor/doctrine/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/AbstractCommand.php:59
Doctrine\ORM\Tools\Console\Command\SchemaTool\AbstractCommand->execute() at /.../Symfony/vendor/symfony/src/Symfony/Bundle/DoctrineBundle/Command/Proxy/UpdateSchemaDoctrineCommand.php:62
Symfony\Bundle\DoctrineBundle\Command\Proxy\UpdateSchemaDoctrineCommand->execute() at /.../Symfony/vendor/symfony/src/Symfony/Component/Console/Command/Command.php:226
Symfony\Component\Console\Command\Command->run() at /.../Symfony/vendor/symfony/src/Symfony/Component/Console/Application.php:194
Symfony\Component\Console\Application->doRun() at /.../Symfony/vendor/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:76
Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /.../Symfony/vendor/symfony/src/Symfony/Component/Console/Application.php:118
Symfony\Component\Console\Application->run() at /.../Symfony/app/console:22

doctrine:schema:update [--complete] [--dump-sql] [--force] [--em[="..."]]

What seems to be happening is that the returned type for the column holding the points is truncated. "Full" type is 'geography(Point,4326)', returned type from Doctrine is 'geography' (missing the specifics).
Adding other custom mappings for PostGIS types, LineString for example, will result with the exact same error although the full type is 'geography(LineString,4326)'. The above test case would still be erroneous with the full type returned as the mapping specifies a 'dbType' known as 'point' or 'linestring' and not 'geography(Point,4326)' or 'geography(LineString,4326)', adjustments should be made there.

[DBAL-336] [GH-195] Removed duplicate table check so that ManyToMany relationships can have two owning entities

Wed, 5 Sep 2012 16:53:34 +0000

This issue is created automatically through a Github pull request on behalf of intrepion:

Url: https://github.com/doctrine/dbal/pull/195

Message:

Whenever there is a ManyToMany relationship with both entities needing ownership, running doctrine:schema:update throws an exception due to a duplicate table definition when, in fact, it is the same table.

[DBAL-335] Is MasterSlaveConnection implemented correctly - seems to overwrite master connection on transaction methods?

Sat, 22 Sep 2012 23:46:31 +0000

Forgive me to doubt, but I think there may be a bug in MasterSlaveConnection.

It's easier to understand what I'm saying by debugging and tracing the flow, but I'll illustrate it with gists.

First, here is a simple service method to create a user. It opens up a transaction, persists the user, commits and returns. On error, if there is an active transaction, rollback. Here is the gist:

https://gist.github.com/3547674

The "$conn->beginTransaction();" line is where we trace through (the remainder of the service method is now irrelevant). Looking into MasterSlaveConnection.php, we see the method tries to connect to the master connection (call this point ###):

https://gist.github.com/3547720

Now looking in the next gist, we see what happens when "$this->connect('master');" is called. At this point it's not that interesting, the internal "$this->_conn" property is set to "master".

https://gist.github.com/3547750

Now here lies the bug I believe. "parent::beginTransaction();" is called. When looking into this method, we see that another call is made to connect but this time without "master" as the argument (i.e. connect to slave). This call to connect is made before incrementing the transaction nesting level.

https://gist.github.com/3547808

Now, I won't do another gist for "MasterSlaveConnection::connect", but if you refer to the file at line 13 https://gist.github.com/3547750#file_master_slave_connection.php, you will see that it checks the transaction nesting level and if it is there, forces master. However, we don't increment the level until after the method returns, so the slave is used. Ultimately, this results in the internal "$this->_conn" property set to the "slave" connection which violates our original action at ### above where we said we want to connect to "master".

Am I missing something here? Here is a gist the is a basic attempt at fixing this one method. It simply copies the code from the parent method except does not connect twice. I believe the same would have to occur for all the other methods unless it can be fixed once at the "MasterSlaveConnection::connect" level.

https://gist.github.com/3547880

I've just fleshed out "beginTransaction", "commit" and "rollBack" in "MasterSlaveConnection" by basically copying and pasting the code from the parent class and for my failing use case, this fixes the issue. However, it did require updating "Connection" slightly so that I had access to some private variables.

[DBAL-334] [GH-194] Small test fixes for PostgreSQL

Wed, 5 Sep 2012 17:25:22 +0000

This issue is created automatically through a Github pull request on behalf of posulliv:

Url: https://github.com/doctrine/dbal/pull/194

Message:

When running the test suite against a clean PostgreSQL install on a 64-bit system I hit 2 issues:

dropDatabase calls fail unless a database is manually created
TypeConversionTest::testIdempotentDataConversion fails expecting bigint type to be converted to a string. PostgreSQL seems to detect 32 vs 64 bit systems and casts correctly for bigint types.

This small patch allows the test suite to run successfully for me against clean MySQL & PostgreSQL installs.

[DBAL-333] [GH-193] Add DBAL\TypeAwareObject.

Wed, 5 Sep 2012 17:21:13 +0000

This issue is created automatically through a Github pull request on behalf of Romain-Geissler:

Url: https://github.com/doctrine/dbal/pull/193

Message:

This PR adds a common interface for custom object values that requires some PHP <-> SQL conversions, which allows to specify what DBAL type must be used for conversion.

[DBAL-332] Memory option for Sqlite driver does nothing

Mon, 17 Sep 2012 11:01:35 +0000

I'm trying to configure a "memory" sqlite database, as described here: http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#pdo-sqlite

So here is my configuration (config_test.yml) :

Unable to find source-code formatter for language: yml. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

 
doctrine:
    dbal:
        driver:    pdo_sqlite
        memory:    true
        user:      db_user
        password:  db_pwd
        charset:   UTF8

I'm then running

./app/console doctrine:database:create --env=test

and the result is a "myBdName" db file (the filename contains the quote!!) in my root folder.

I don't understand why the file http://www.doctrine-project.org/api/dbal/2.3/source-class-Doctrine.DBAL.Schema.SqliteSchemaManager.html#46 is creating a path option with my DB name, if I comment the line 57, everything seems fine (no more file created).

I have seen some memory related options in the Doctrine test suite so maybe I'm doing it wrong, and in that case that's a documentation issue I can work on.

Thx,
Damien

[DBAL-331] [GH-192] ExpressionBuilder in and notIn methods

Wed, 29 Aug 2012 09:37:50 +0000

This issue is created automatically through a Github pull request on behalf of Xobb:

Url: https://github.com/doctrine/dbal/pull/192

Message:

ExpressionBuilder is missing *in* and *not in* methods to produce these statements.

[DBAL-330] [GH-191] Akiban Driver Implementation that Uses PDO

Tue, 11 Dec 2012 15:55:56 +0000

This issue is created automatically through a Github pull request on behalf of posulliv:

Url: https://github.com/doctrine/dbal/pull/191

Message:

Based on discussion in pull request 188 with @stof, I decided to modify the implementation for Akiban to use the PostgreSQL PDO driver instead of the native PHP client for PostgreSQL.

One piece of functionality that does not work with current version of Akiban is lastInsertId. This is because the implementation of CURRVAL for Akiban requires both schema name and sequence name be provided whereas PostgreSQL only requires sequence name ([relevant source](https://github.com/php/php-src/blob/master/ext/pdo_pgsql/pgsql_driver.c#L360)). I will attempt to get CURRVAL in Akiban implemented to have the same parameters as PostgreSQL.

This causes a few tests to fail in the test suite right now. Is there a way to mark a test as expected to fail for a specific database driver with the test suite? What I did in this pull request is skip any tests that use lastInsertId when testing against the Akiban platform. I'll update these tests to not be skipped when CURRVAL works as expected. Let me know if there is a better way to do that.

[DBAL-329] [GH-190] Fix DDC-1978

Wed, 29 Aug 2012 09:36:59 +0000

This issue is created automatically through a Github pull request on behalf of FabioBatSilva:

Url: https://github.com/doctrine/dbal/pull/190

Message:

Fix ~~DDC-1978~~

http://www.doctrine-project.org/jira/browse/DDC-1978

[DBAL-328] [GH-189] Changed 'implements' by 'extends' on SQLAzureFederationsSynchronizer

Mon, 27 Aug 2012 20:27:51 +0000

This issue is created automatically through a Github pull request on behalf of mdaloia:

Url: https://github.com/doctrine/dbal/pull/189

Message:

This error was introduced with the changes commited on SHA: doctrine/dbal@12f381f1254f756114267e1a1e71d0a783bfaf1c

[DBAL-327] [GH-188] Akiban driver

Wed, 29 Aug 2012 08:37:39 +0000

This issue is created automatically through a Github pull request on behalf of posulliv:

Url: https://github.com/doctrine/dbal/pull/188

Message:

An initial implementation of a driver for the [Akiban Server](http://www.akiban.com/akiban-server). You will notice in the diff there are some features Akiban does not yet support in its latest release but are planned for future releases.

I wasn't sure if pull request was the best way to start a dialog to get this work accepted or whether the mailing list is more appropriate. Please let me know and I will do as suggested.

I am an engineer at Akiban and am very willing to maintain/improve this driver.

[DBAL-326] [GH-187] Quote column names during insert, if necessary

Wed, 29 Aug 2012 09:03:15 +0000

This issue is created automatically through a Github pull request on behalf of dobesv:

Url: https://github.com/doctrine/dbal/pull/187

Message:

This fixes an issue I ran into where if I tried to insert something with a column name that required quoting, I would have to manually quote it myself.

[DBAL-325] [GH-186] Added third an optional argument `types` to use prepared statement

Wed, 29 Aug 2012 09:04:44 +0000

This issue is created automatically through a Github pull request on behalf of timoshenko:

Url: https://github.com/doctrine/dbal/pull/186

Message:

[DBAL-324] SchemaManager should first look into comment instead of infer the type first.

Tue, 14 May 2013 20:50:07 +0000

When using schema tool, Doctrine tries to infer the Doctrine type via the mapped types in Platform.
It should first try to read from the comment; if found, ignore the Database type inference.

[DBAL-323] [GH-185] Add schema changes for length for postgres

Sat, 6 Oct 2012 10:23:13 +0000

This issue is created automatically through a Github pull request on behalf of mvrhov:

Url: https://github.com/doctrine/dbal/pull/185

Message:

[DBAL-322] Change Detection fails when 'unsigned' is used in MySQL Schema

Tue, 14 Aug 2012 21:10:15 +0000

Change Detection fails when 'unsigned' is used in MySQL Schema

[DBAL-321] [GH-184] Added INSERT support to dbal QueryBuilder

Tue, 14 Aug 2012 20:49:18 +0000

This issue is created automatically through a Github pull request on behalf of Tim-Erwin:

Url: https://github.com/doctrine/dbal/pull/184

Message:

See also http://www.doctrine-project.org/jira/browse/DBAL-320
Please review and commit as fits.

[DBAL-320] allow SQL QueryBuilder to do INSERTS

Mon, 13 Aug 2012 13:12:47 +0000

With

$db = \Doctrine\DBAL\DriverManager::getConnection($connectionParams, $config);
$qb = $db->createQueryBuilder();

this QueryBuilder I'm able to do SELECT, UPDATE and DELETE. However, INSERT is not possible. Are there any good reasons for this?

Attached you find a patch that until now works fine for me. I don't know, however, if there are any side effects.

[DBAL-319] Doctrine\DBAL\Types\Type

Sun, 12 Aug 2012 18:34:28 +0000

The API could be improved in the next major release:

Type::add() instead of addType()
Type::isRegistered() instead of hasType() (has sounds weird)

Etc.. I think the 'type' in the methods is redundant since Type is already the object I am dealing with.

I'd also like a remove() method to unregister a type at runtime. Would make testing a little easier and I don't have to check with hasType() etc..

[DBAL-318] getSQLDeclaration

Sun, 19 Aug 2012 22:36:37 +0000

https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Types/Type.php#L119-L125

Should define a @return type. Otherwise you have to step through other types to figure this out.

[DBAL-317] [GH-183] Fix unsigned columns in MySql

Tue, 14 Aug 2012 21:21:05 +0000

This issue is created automatically through a Github pull request on behalf of acasademont:

Url: https://github.com/doctrine/dbal/pull/183

Message:

Unsigned column properties were never set. In consequence all migrations diff were trying to change the column definition when it was already changed. See symfony/symfony#3560

Would it be also nice to add some test to avoid regressions, but i don't know where it would be a nice place to put them.

[DBAL-316] Incorrect parameter SERVICE_NAME

Sun, 10 Feb 2013 00:00:03 +0000

At line 63, the driver PDOOracle, the parameter SERVICE_NAME is receiving the value of 'dbname' and not 'service'.

Sorry, my English is bad!

[DBAL-315] [GH-182] Added a missing method in the Constraint interface

Tue, 14 Aug 2012 21:33:08 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/182

Message:

This adds a missing method in the Constraint interface. The method is already defined in AbstractAsset which is extended by both classes implementing the interface. the AbstractPlatform is calling this method on objects after checking they are implementing the interface. So either the method should be part of the interface, or all places using the interface as typehint should be refactored to check for the classes (examples can be found [here](https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php#L1029) and [there](https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php#L1254)).

Adding a method in an interface is technically a BC break but this method is not really a public extension point. what do you think @beberlei ?

[DBAL-314] [GH-180] Fixed some phpdoc

Tue, 14 Aug 2012 21:48:41 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/180

Message:

This fixes some phpdoc in the AbstractPlatform and in some child classes. I haven't checked all child classes to ensure that all phpdoc is right now, but the abstract one is now accurate (but a bunch of method are missing their phpdoc altogether)

[DBAL-313] When creating foreign key constraints, the AbstractPlatform class does not quote the referenced table.

Wed, 1 May 2013 18:41:40 +0000

I have a table that is using a reserved MySQL keyword (right) and it's quoted in all the generated SQL but not in the foreign key constraint.

When I use doctrine.php orm:schema-tool:create I get this SQL line:
ALTER TABLE website ADD CONSTRAINT FK_476F5DE7B196EE6E FOREIGN KEY (right_id) REFERENCES right (id)

[DBAL-311] [GH-179] Added missing type mappings for postgres

Tue, 14 Aug 2012 22:05:14 +0000

This issue is created automatically through a Github pull request on behalf of jkrems:

Url: https://github.com/doctrine/dbal/pull/179

Message:

We had problems running the migrations-commands with an existing database. Seems like some type-mappings are just missing. This patch fixed the problem for us.

[DBAL-310] [GH-178] Pull Request

Tue, 18 Sep 2012 19:53:30 +0000

This issue is created automatically through a Github pull request on behalf of ardemiranda:

Url: https://github.com/doctrine/dbal/pull/178

Message:

Pull Request doctrine/dbal/master

[DBAL-309] MasterSlaveConnection with mysql "charset: "UTF8" forces use of master

Mon, 17 Sep 2012 10:48:27 +0000

In a mysql master/slave environment with "charset:" set to "UTF8" an Event "postConnect" is dispatched after establishing the connection.

MysqlSessionInit->postConnect() uses MasterSlaveConnection->executeUpdate() to submit this information to the current connection. executeUpdate() always connects to the master and the slaves won't be used (as documentated: "3. If master was picked once during the lifetime of the connection it will always get picked afterwards.").

We suggest to use executeQuery() in postConnect() instead.

[DBAL-308] [GH-174] Used the placeholder in the command help for the name

Mon, 23 Jul 2012 08:31:12 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/174

Message:

This change will allow to keep the original help message in DoctrineBundle even if we rename the command. I will submit the same PR for the ORM.

@beberlei please include it in the 2.3 branch (and ideally in 2.2 if it is not too much to ask for it). My goal is to stop duplicating the help messages in the bundle as outdated help messages are really a pain for users (see doctrine/DoctrineBundle#89)

[DBAL-307] [GH-173] Fixing breaking test provoke by #172

Sun, 29 Jul 2012 07:47:49 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/dbal/pull/173

Message:

[DBAL-306] [GH-172] Fixed typos

Sun, 29 Jul 2012 07:48:08 +0000

This issue is created automatically through a Github pull request on behalf of pborreli:

Url: https://github.com/doctrine/dbal/pull/172

Message:

[DBAL-305] [GH-171] provide transactional interface for EntityManager and Connection

Sun, 29 Jul 2012 08:50:02 +0000

This issue is created automatically through a Github pull request on behalf of dfreudenberger:

Url: https://github.com/doctrine/dbal/pull/171

Message:

[DBAL-304] Allow table comments

Thu, 12 Jul 2012 07:22:02 +0000

Implement support for table comments. Most drivers restrict the comments to 60 chars on tables and 255 on columns. Also export this support to ORM.
We already consume some chars for (DC2Type:<type_name>) on columns. Also we need to apply a check to not crash under these circunstances

[DBAL-303] [GH-170] [#DBAL-172] QueryBuilder joins are omitted if the table alias is not present in the "from" clause

Tue, 14 Aug 2012 22:06:06 +0000

This issue is created automatically through a Github pull request on behalf of wimvds:

Url: https://github.com/doctrine/dbal/pull/170

Message:

Apparently that fix has never been included, don't know why exactly. But there are use cases where you want to join multiple tables without selecting any data from the joined tables.

Ie. a query like this one :
SELECT COUNT(DISTINCT news.id) FROM cb_newspages news
INNER JOIN nodeversion nv ON nv.refId = news.id AND nv.refEntityname='Entity
News'
INNER JOIN nodetranslation nt ON nv.nodetranslation = nt.id
INNER JOIN node n ON nt.node = n.id
WHERE nt.lang = 'nl' AND n.deleted != 1

could be written with the querybuilder (using this patch) as follows :

$querybuilder->select('COUNT(DISTINCT news.id)')
->from('cb_newspages', 'news')
->innerJoin('news', 'nodeversion', 'nv', 'nv.refId = news.id AND nv.refEntityname=\'Entity\\\\News\'')
->innerJoin('nv', 'nodetranslation', 'nt', 'nv.nodetranslation = nt.id')
->innerJoin('nt', 'node', 'n', 'nt.node = n.id')
->where('nt.lang = :lang AND n.deleted != 1')
->setParameter('lang', $locale);

When you use an alias that isn't chained or used in a from clause it will still trigger a QueryException (as before).

ie.
$querybuilder->select('COUNT(DISTINCT news.id)')
->from('cb_newspages', 'news')
->innerJoin('news', 'nodeversion', 'nv', 'nv.refId = news.id AND nv.refEntityname=\'Entity\\\\News\'')
->innerJoin('invalid', 'nodetranslation', 'nt', 'nv.nodetranslation = nt.id')
->innerJoin('nt', 'node', 'n', 'nt.node = n.id')
->where('nt.lang = :lang AND n.deleted != 1')
->setParameter('lang', $locale);

Will trigger the following QueryException :

"The given alias 'invalid' is not part of any FROM or JOIN clause table. The currently registered aliases are: news, nv, nt, n."

[DBAL-302] [GH-168] DebugStack should ignore stopQuery when disabled

Tue, 10 Jul 2012 07:32:26 +0000

This issue is created automatically through a Github pull request on behalf of dpb587:

Url: https://github.com/doctrine/dbal/pull/168

Message:

I noticed that DebugStack was adding an empty element when it was disabled. This PR changes it to match startQuery with its behavior.

1) Doctrine\Tests\DBAL\Logging\DebugStackTest::testLoggedQueryDisabled
Failed asserting that two arrays are equal.
— Expected
+++ Actual
@@ @@
Array
(
+ [0] => Array
+ (
+ [executionMS] => 1341871660.9651
+ )
+
)

I've submitted the PR to 2.0.x since that's where the bug is first seen and is still listed as stable on doctrine-project.org. Preferably this could also be applied to newer branches as well, or I can also submit separate PRs.

[DBAL-301] [GH-167] Oracle stored procedures

Sun, 29 Jul 2012 07:53:12 +0000

This issue is created automatically through a Github pull request on behalf of AduroIdea:

Url: https://github.com/doctrine/dbal/pull/167

Message:

driver function
To avoid ORA-03131 error, data length must be passed to oci_bind_by_name function.
This commit fixes it so now pdo_oci can be used with stored procedures and output parameters from sql/plsql.

[DBAL-300] Updates for Fedora packaging

Sat, 24 Nov 2012 02:20:36 +0000

I am packaging the DoctrineDBAL PEAR package for Fedora and RHEL (EPEL) and would like to have the following updates:

package.xml role for LICENSE changed from "data" to "doc"

package.xml role for Doctrine/DBAL/README.markdown changed from "data" to "doc"

add some content to Doctrine/DBAL/README.markdown (when building RPM this file throws a warning because it is empty)

[DBAL-299] Multiple different interspersed named parameters

Sat, 7 Jul 2012 13:12:53 +0000

For this code

$sql = <<<SQL
SELECT 1 as id
WHERE (:foo = 2)
AND (:bar = 3)
AND (:foo = 2)
SQL;
$rsm = new \Doctrine\Orm\Query\ResultSetMapping();
$rsm->addScalarResult('id', 'id');

$query = $em->createNativeQuery($sql, $rsm);
$query = $query->setParameters(array('foo' => 2, 'bar' => 3));
$result = $query->getResult();

Generates the SQL in DBAL\Connection\executeQuery

SELECT 1 as id
WHERE (? = 2)
AN?bar = 3)
AND (? = 2)

The problem appears to be in DBAL\SQLParserUtils\expandListParameters.

When replacing the named parameters with ?'s an offset is kept to keep track of where to insert the next parameter. This is done per named parameter (all of :foo is replaced then all :bar, etc). This will calculate the incorrect offset if a named parameter(e.g. :bar) is in between instances of another named parameter (e.g. :foo) (i.e. :bar in the sql "(:foo = 2) AND (:bar =3) AND (:foo = 2)") since the offset will be for the TOTAL number of instances of the named parameter (e.g. -6) not the number of instances that occur before the needed replacement (e.g. -3).

This is where the SQL has "AN?bar = 3)" instead of "AND(3 = 3)" the offset is calculated at -6 instead of the proper -3

[DBAL-298] [GH-166] Fixes a bug caused by unquoted reserved table name being referenced during schema creation

Sun, 29 Jul 2012 08:13:48 +0000

This issue is created automatically through a Github pull request on behalf of klaussilveira:

Url: https://github.com/doctrine/dbal/pull/166

Message:

When creating a schema with tables with reserved names and relationships between them, the schema creation tool failed to write valid SQL in MySQL due to unquoted table names. For example:

CREATE TABLE `Group` (id INT AUTO_INCREMENT NOT NULL, name VARCHAR(255) NOT NULL DEFAULT NULL, PRIMARY KEY(id)) ENGINE = InnoDB;
CREATE TABLE User (id INT AUTO_INCREMENT NOT NULL, username VARCHAR(255) NOT NULL PRIMARY KEY(id)) ENGINE = InnoDB;
CREATE TABLE UserHasGroup (user_id INT NOT NULL, group_id INT NOT NULL, INDEX IDX_617A865CA76ED395 (user_id), INDEX IDX_617A865CFE54D947 (group_id), PRIMARY KEY(user_id, group_id)) ENGINE = InnoDB;
ALTER TABLE UserHasGroup ADD CONSTRAINT FK_617A865CA76ED395 FOREIGN KEY (user_id) REFERENCES User (id);
ALTER TABLE UserHasGroup ADD CONSTRAINT FK_617A865CFE54D947 FOREIGN KEY (group_id) REFERENCES Group (id);

This fix creates a small function for creating quoted foreign key table names.

[DBAL-297] PDO::PARAM_LOB (value=3) overlaps with PDO::FETCH_NUM (value=3) in OCI8Statement::$fetchModeMap

Thu, 5 Jul 2012 08:13:31 +0000

Hi,

In OCI8Statement, using PDO::FETCH_NUM does not work because the fetch style mapping is overwritten by PDO::PARAM_LOB since the two has the same value (3);

protected static $fetchModeMap = array(
PDO::FETCH_BOTH => OCI_BOTH,
PDO::FETCH_ASSOC => OCI_ASSOC,
PDO::FETCH_NUM => OCI_NUM,
PDO::PARAM_LOB => OCI_B_BLOB,
PDO::FETCH_COLUMN => OCI_NUM,
);

so PDO::FETCH_NUM is mapped to OCI_B_BLOB

[DBAL-296] [GH-165] interface compatibility

Thu, 5 Jul 2012 19:37:15 +0000

This issue is created automatically through a Github pull request on behalf of Nazin:

Url: https://github.com/doctrine/dbal/pull/165

Message:

[DBAL-295] [GH-164] Getters for AbstractAsset$_quoted and ForeignKeyConstraint$_options

Thu, 5 Jul 2012 19:08:46 +0000

This issue is created automatically through a Github pull request on behalf of tyler-sommer:

Url: https://github.com/doctrine/dbal/pull/164

Message:

Added the necessary getters, re: doctrine/migrations#79

[DBAL-294] [GH-163] [WIP] Upsert support protoype.

Wed, 4 Jul 2012 19:32:56 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/163

Message:

[DBAL-293] mysql platform can not choose text type column

Sat, 8 Sep 2012 19:51:48 +0000

getVarcharMaxLength() in DBAL/Platforms/MySqlPlatform.php returns 65535;
So, it never choose "text", choose "mediumtext".

[DBAL-292] Multiple use of named parameter doesn't work

Wed, 23 Jan 2013 22:56:54 +0000

In the example in the documentation http://doctrine-dbal.readthedocs.org/en/2.0.x/reference/data-retrieval-and-manipulation.html#dynamic-parameters-and-prepared-statements there is the following example:

$sql = "SELECT * FROM users WHERE name = :name OR username = :name";
$stmt = $conn->prepare($sql);
$stmt->bindValue("name", $name);
$stmt->execute();

When I try this example using pdo_sqlsrv I get the following error:
PDOException: SQLSTATE[07002]: [Microsoft][SQL Server Native Client 11.0]COUNT field incorrect or syntax error

When I use instead the parameters name1 and name2 the query works as expected.

[DBAL-291] [GH-157] interface compatibility

Wed, 4 Jul 2012 20:25:43 +0000

This issue is created automatically through a Github pull request on behalf of Nazin:

Url: https://github.com/doctrine/dbal/pull/157

Message:

[DBAL-290] Schema\Comparator::diffColumn finds ArrayType and TextType columns different

Thu, 31 May 2012 09:22:42 +0000

If I have an entity with @Column(type="array"), orm:validate-schema always tells me "FAIL - The database schema is not in sync with the current mapping file.".

If I call orm:schema-tool:update --dump-sql, I get "ALTER TABLE bridge ALTER config TYPE TEXT" although this is already how the column in my database looks like. If I execute this query, nothing happens and orm:validate-schema still fails.

There exist two different mapping types - TextType and ArrayType, but they both have the same SQL column type - TEXT.

The $fromSchema is built with TextType column, the $toSchema contains (correctly) ArrayType.

I propose not to generate the ALTER if the both compared columns' Type::getSQLDeclaration() results are the same.

If I got everything okay, I can prepare a pull request.

[DBAL-289] Wrong diff between Oracle 'Date' type and Metadata 'Date' type

Wed, 22 Aug 2012 10:34:21 +0000

Hi,
I want to update my schema but I am getting the following error message:

[Doctrine\DBAL\Driver\OCI8\OCI8Exception]
ORA-01442: column to be modified to NOT NULL is already NOT NULL

--dump-sql says:

ALTER TABLE CONSIGNMENTS MODIFY (SDGDATE  DATE DEFAULT NULL);

The current table structure looks like that:

Column Name	Data Type	Nullable	Default	Primary Key
SDGDATE	DATE	Yes	NULL

Mapping definition:

/**
 * @ORM\Column(name="SDGDATE",type="date",nullable=true)
 */
private $sdgdate;

I think there is a problem with the comparison between Oracles 'Date' type and the Metadata 'Date' type. I am used to use MySQL as DBMS but our customer uses Oracle. MySQL's 'datetime' and Oracle's 'date' type are store the same data.

I am not sure what should be done here. Because this could lead to confusion for all Oracle user.

Maybe there could be a request to the platform in the Schema Comparator here:

public function diffColumn(Column $column1, Column $column2)
{
    $changedProperties = array();
    if ( $column1->getType() != $column2->getType() ) {
        $changedProperties[] = 'type';
    }
    // ...
}

[DBAL-288] [GH-156] [Platform] Allow a string to be passed as type

Sun, 27 May 2012 15:49:34 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/dbal/pull/156

Message:

[DBAL-287] [GH-155] Update license for Composer

Sun, 27 May 2012 08:07:24 +0000

This issue is created automatically through a Github pull request on behalf of jalliot:

Url: https://github.com/doctrine/dbal/pull/155

Message:

[DBAL-286] [GH-154] Support for access method declaration for indexes

Sun, 27 May 2012 08:11:07 +0000

This issue is created automatically through a Github pull request on behalf of petr-motejlek:

Url: https://github.com/doctrine/dbal/pull/154

Message:

This is still work in progress, but it works. There will be another pull request in doctrine2 that actually depends on this one.

[DBAL-285] Schema generation fails when primary key is quoted

Wed, 4 Jul 2012 21:38:32 +0000

All of our entities are generated with their name quoted with back-ticks, this is to allow RAD.
When Doctrine comes to update the schema it fails to see the primary key is quoted and thus compared an index of PRIMARY(id) to PRIMARY(`id`). Which means it then tries to drop the primary index and recreate it, using a quoted field name.

This fix is to when the primary index is created is to fetch the columns from the table and get their unquoted name, so now when the comparison takes place it looks like this PRIMARY(id) to PRIMARY(id), therefore doesn't register this as a change.

[DBAL-284] [GH-152] add ComparatorInterface to allow custom Comparator implementation

Tue, 22 May 2012 17:12:30 +0000

This issue is created automatically through a Github pull request on behalf of catacgc:

Url: https://github.com/doctrine/dbal/pull/152

Message:

[DBAL-283] [GH-151] Fixed the doctrine/common constraint and added the branch-alias

Tue, 22 May 2012 17:13:37 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/151

Message:

The change in the requirements requires doctrine/common#144 to be merged and parsed by Packagist, otherwise ``2.3.*`` would not match anything.

[DBAL-282] [GH-150] Added missing regex delimiters in the testsuite

Tue, 22 May 2012 17:12:47 +0000

This issue is created automatically through a Github pull request on behalf of stof:

Url: https://github.com/doctrine/dbal/pull/150

Message:

The AbstractSchemaManager expects getting the regex with its
delimiters since 8beb732fe9 but the tests were not updated.

[DBAL-281] [GH-149] changed some phpdoc's, set correct namespaces and types

Tue, 22 May 2012 17:53:09 +0000

This issue is created automatically through a Github pull request on behalf of Engerim:

Url: https://github.com/doctrine/dbal/pull/149

Message:

[DBAL-280] [GH-148] No bug. Respect the case used in the interface

Tue, 22 May 2012 17:47:40 +0000

This issue is created automatically through a Github pull request on behalf of pap-florin:

Url: https://github.com/doctrine/dbal/pull/148

Message:

[DBAL-279] [GH-147] 2.2 Add lastInsertId() support for OCI8 Driver

Tue, 22 May 2012 19:21:29 +0000

This issue is created automatically through a Github pull request on behalf of franek:

Url: https://github.com/doctrine/dbal/pull/147

Message:

Add lastInsertId() support for Sequence

[DBAL-278] add support for lastInsertId method on OCI8 Driver

Tue, 22 May 2012 19:21:16 +0000

The method lastInsertId() is not defined for OCI8 Driver in Doctrine\DBAL\Driver\OCI8\OCI8Connection.php :

OCI8Connection.php

public function lastInsertId($name = null)
{
    //TODO: throw exception or support sequences?
}

I propose this method to handle lastInsertId for sequence :

OCI8Connection.php

public function lastInsertId($name = null)
 {
        // For sequence
        if (is_string($name)) {
            // We can check eventually check the presence of the sequence in the table
            // USER_SEQUENCES
            $sql = 'SELECT ' . $name . '.CURRVAL FROM DUAL';
            // will throw an exception if this sequence does not exist
            $stmt = $this->query($sql);
            $result = $stmt->fetch(\PDO::FETCH_ASSOC);
            if ($result !== false && isset($result['CURRVAL'])) {
                return (int) $result['CURRVAL'];
            }
    }
    // OCI8 driver does not provide support of lastInsertId
    return null;
}

Thanks,

[DBAL-277] [GH-146] auto-quote table and column name in Connection->delete/insert/update()

Tue, 22 May 2012 17:49:05 +0000

This issue is created automatically through a Github pull request on behalf of nicolas-grekas:

Url: https://github.com/doctrine/dbal/pull/146

Message:

I wonder why quoting of table/column names in Connection->delete/insert/update() is left to the developer and not not done internally by the library?

I made a patch to allow the lib to quote table and column names in a backward-compatible way. I believe that if this feature is not already in the lib, there must be some reason, but I can't understand it right now, nor find a reference to any rational.

Would it be possible to elaborate the reason if possible, while accepting / rejecting the pull request at your will of course?

Many thanks.

[DBAL-276] MySQL schema manager should not make assumptions about non-DBAL types

Sun, 27 May 2012 08:58:59 +0000

When using the DBAL MySQL schema manager to create migrations or update the schema directly, it can create conflicts with custom types due to the way it processes some non-DBAL types in _getPortableTableColumnDefinition.

I recently implemented a binary-string type, using the MySQL BINARY/VARBINARY columns (as opposed to blob, which I see has been adopted in 2.2), due to the content for my application always being a 60 byte binary string. Doctrine has been working fine with it, but upon generating my next migration, I discovered that the schema manager wanted to re-set the column's length.
Generated SQL: "ALTER TABLE User CHANGE password password VARBINARY(60) NOT NULL"

It appears that this is caused by lines 138 & 139 of MySqlSchemaManager.php clearing the column's length. There doesn't seem to be any other code pertaining to MySQL and binary/varbinary, so removing these two lines should be safe and save trouble for future users, without causing issues for those who choose to implement it as a blob or similar.

[DBAL-275] Automatically attempt to reconnect a dropped persistent MySQL-connection (MySQL server has gone away)

Wed, 21 Nov 2012 11:39:50 +0000

For php-scripts that run for a long time (a.o. daemons) persistent connections will almost always be dropped by the MySQL-server after a set timeout (depending on wait_timeout). This will have Doctrine throw an exception and have the php-script terminate if not catched. It is not practical to catch the same Exception with a try-catch around every query.

I have fixed this for DBAL 2.1.6 by adding a custom layer of Statement-, Connection- and Driver classes.
Key functionalities:

The custom layer will transparently catch dropped connections and attempt a number of times (configurable) to reconnect.
The behaviour will not be triggered in a transaction (in that case it will revert to throwing an exception just like before).
The reconnect behaviour is not MySQL specific per se. It can be triggered by any Exception for any Driver-type if a Driver provides a method 'getReconnectExceptions'.
Minimal performance-impact. Only when an Exception is thrown will it be searched for a matching Exception to possibly trigger the behaviour. (also the reason a single stringmatch is used)

Why this functionality?

It is often not possible to change settings of a database-server.
In a production environment the MySQL wait_timeout is often set to mere seconds
Doctrine's use of persistent connections will become a little more persistent
More reliable and robust php-scripts built on top of the DBAL

See files in attached archive to get an idea of the code. Enabling the layer is currently done like this (Symfony2 yml):
doctrine:
dbal:
wrapper_class: DoP\DoPBundle\Doctrine\DBAL\Connection
driver_class: DoP\DoPBundle\Doctrine\DBAL\Driver\PDOMySql\Driver
options:
x_reconnect_attempts: 2

Maybe I overlook something, but I only see pro's, no cons, to this improvement. I have created this issue to poll if you think this is a welcome feature and are interested to have me rework the code into DBAL itself? Reworking it into DBAL itself would certainly greatly reduce my code.

If agreed I'll create a github pull request when finished with the code and take comments/improvements from there.

(Also, I have glanced over http://www.doctrine-project.org/contribute.html but did not find any coding/testing-guidelines. Can you point me in the right direction?)

Regards,

Dieter

[DBAL-274] [GH-145] Allow easier overriding of the DateTime class

Sun, 27 May 2012 10:52:48 +0000

This issue is created automatically through a Github pull request on behalf of Seldaek:

Url: https://github.com/doctrine/dbal/pull/145

Message:

If this can be backported to 2.2, it'd be nice.

The goal is that we have to override the Date* Types in our code to support PKs on Date fields, but at the moment that requires duplicating all the code from those classes, which sucks a bit for maintenance.

[DBAL-273] Allow MasterSlave Connection to switch back to slave

Fri, 11 May 2012 19:23:04 +0000

Allow MasterSlave Connection to switch back to slave

[DBAL-272] [GH-144] [MYSQLI] Fixed infinite loop in fetchAll()

Wed, 9 May 2012 07:00:08 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/144

Message:

[DBAL-271] [GH-143] added simple_array type

Sun, 27 May 2012 15:49:57 +0000

This issue is created automatically through a Github pull request on behalf of schmittjoh:

Url: https://github.com/doctrine/dbal/pull/143

Message:

[DBAL-270] [GH-142] Dbal 264

Tue, 22 May 2012 17:56:01 +0000

This issue is created automatically through a Github pull request on behalf of rivaros:

Url: https://github.com/doctrine/dbal/pull/142

Message:

added support for Postgres UUID type.

[DBAL-269] [GH-141] Fixed conditional expression

Sun, 27 May 2012 10:09:02 +0000

This issue is created automatically through a Github pull request on behalf of hason:

Url: https://github.com/doctrine/dbal/pull/141

Message:

[DBAL-268] [GH-140] Dbal 264 dev

Fri, 4 May 2012 17:41:01 +0000

This issue is created automatically through a Github pull request on behalf of rivaros:

Url: https://github.com/doctrine/dbal/pull/140

Message:

Just some small changes taken from 2.3 branch to support guids in 2.2 (backport).
If you think it can be used, pls merge. Had to use it in my projects as really lacked this feature.

[DBAL-267] DBAL\Connection doesn't escape SQL keywords

Tue, 22 May 2012 17:52:10 +0000

I'm using DBAL Connection's "insert" and "update" methods to manipulate my database.

Both those methods doesn't escape reserved SQL keywords appropriately. See: http://www.doctrine-project.org/api/dbal/2.2/source-class-Doctrine.DBAL.Connection.html#493

For example the following method call will raise an Exception (SQL error):

$Connection->insert('some_table', array(
'from' => 'foo',
'to' => 'bar'
));

Because the "from"-key is a reserved SQL keyword.

Database abstraction layer such as DBAL MUST consider such situations and act appropriately (i.e. escape field names with regulations specified by syntax of used RDBMS).

In MySQL i have to do this manually before calling "insert" or "update":
$key = '`' . $key . '`';
And this is really bad practice, cause it's platform-depended solution (works only for MySQL).

I hope you will find my words reasonable. it's important for developer to be able to use any key names he seems necessary (even if it's reserved by SQL itself). Sometimes developer doesn't even have a choice (e.g. when he receives database from third-party and can't change it's structure).

[DBAL-266] [GH-139] [Mysql Platform] Added mapping for binary and varbinary.

Fri, 4 May 2012 17:47:36 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/139

Message:

[DBAL-265] [GH-138] Dbal 264

Fri, 4 May 2012 17:49:42 +0000

This issue is created automatically through a Github pull request on behalf of rivaros:

Url: https://github.com/doctrine/dbal/pull/138

Message:

I would appreciate these light changes back-ported to 2.1.x
These are just support of uuids/guids types in dbal.

[DBAL-264] Support for UIDs in PostgreSQL

Mon, 29 Apr 2013 02:05:11 +0000

Please add support for uuid datatype in PostgreSQL

[DBAL-263] [GH-137] Support OCI8 statements crossing transactions [DBAL-202]

Sat, 5 May 2012 07:37:34 +0000

This issue is created automatically through a Github pull request on behalf of dpb587:

Url: https://github.com/doctrine/dbal/pull/137

Message:

Bug Fix: yes
Feature addition: no
Backwards compatibility break: no
[![Build Status](https://secure.travis-ci.org/dpb587/dbal.png?branch=ticket-dbal-202)](http://travis-ci.org/dpb587/dbal)

Scenario is documented in JIRA ~~DBAL-202~~(http://www.doctrine-project.org/jira/browse/DBAL-202). Basically in oci8 if you prepare a statement outside of a transaction, start a transaction, execute the statement, rollback the transaction - the statement will still have been executed. Whether it's the correct behavior or not, it seems like it should match PDO's behavior.

This implementation affects the API, so it should probably be carefully reviewed.

A separate test script is available at https://gist.github.com/2515100(gist.github.com/2515100).

$ php -v ; php --re oci8 | head -1
PHP 5.3.3-7+squeeze3 with Suhosin-Patch (cli) (built: Jun 28 2011 08:24:40)
Copyright (c) 1997-2009 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies
with Xdebug v2.1.1, Copyright (c) 2002-2011, by Derick Rethans
with Suhosin v0.9.32.1, Copyright (c) 2007-2010, by SektionEins GmbH
Extension [ <persistent> extension #52 oci8 version 1.4.2 ] {
$ phpunit -c oci8.phpunit.xml.dist tests/Doctrine/Tests/DBAL/Driver/OCI8/OCI8StatementTest.php
PHPUnit 3.5.13 by Sebastian Bergmann.

Time: 0 seconds, Memory: 7.50Mb

OK (2 tests, 2 assertions)
$ phpunit -c oci8.phpunit.xml.dist tests/Doctrine/Tests/DBAL/Functional/Ticket/DBAL202Test.php
PHPUnit 3.5.13 by Sebastian Bergmann.

Time: 7 seconds, Memory: 9.50Mb
OK (2 tests, 6 assertions)

I had to drop the the following tests to run through the oracle test suite (seemed like my test user didn't have enough permissions for the temp db tests), but all other tests pass.

$ rm tests/Doctrine/Tests/DBAL/Functional/TemporaryTableTest.php
$ rm tests/Doctrine/Tests/DBAL/Functional/TableGeneratorTest.php # see pull 136
$ rm tests/Doctrine/Tests/DBAL/Functional/Schema/OracleSchemaManagerTest.php
$ phpunit -c oci8.phpunit.xml.dist
PHPUnit 3.5.13 by Sebastian Bergmann.

............................................................... 63 / 747 ( 8%)
.......SSSS.....S........S......................S...........S.. 126 / 747 ( 16%)
.............................SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 189 / 747 ( 25%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 252 / 747 ( 33%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS.............S........ 315 / 747 ( 42%)
...S...S...SSS................................................. 378 / 747 ( 50%)
............................................................... 441 / 747 ( 59%)
.....SSS....................................................... 504 / 747 ( 67%)
............................................................... 567 / 747 ( 75%)
..............S................................................ 630 / 747 ( 84%)
............................................................... 693 / 747 ( 92%)
......................................................

Time: 33 seconds, Memory: 46.00Mb

OK, but incomplete or skipped tests!
Tests: 747, Assertions: 1145, Skipped: 156.

[DBAL-262] [GH-136] Support oci8 in TableGenerator

Sat, 5 May 2012 07:45:25 +0000

This issue is created automatically through a Github pull request on behalf of dpb587:

Url: https://github.com/doctrine/dbal/pull/136

Message:

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
[![Build Status](https://secure.travis-ci.org/dpb587/dbal.png?branch=bugfix-TableGenerator)](http://travis-ci.org/dpb587/dbal)

This test was breaking when running under `oci8` due to Oracle's deference to upper case column names. I realize Oracle has built-in sequences and `TableGenerator` is unnecessary, in theory, but it seemed like the class should work if possible. I see pgsql is in the same boat.

Tested with:

phpunit -c oci8.phpunit.xml.dist tests/Doctrine/Tests/DBAL/Functional/TableGeneratorTest.php

Before:

PHPUnit 3.5.13 by Sebastian Bergmann.

Time: 0 seconds, Memory: 10.25Mb

There were 2 errors:

1) Doctrine\Tests\DBAL\Functional\TableGeneratorTest::testNextVal
Exception: [Doctrine\DBAL\DBALException] Error occured while generating ID with TableGenerator, aborted generation: Undefined index: sequence_value

2) Doctrine\Tests\DBAL\Functional\TableGeneratorTest::testNextValNotAffectedByOuterTransactions
Exception: [Doctrine\DBAL\DBALException] Error occured while generating ID with TableGenerator, aborted generation: Undefined index: sequence_value

After:

PHPUnit 3.5.13 by Sebastian Bergmann.

Time: 1 second, Memory: 10.25Mb

OK (2 tests, 5 assertions)

[DBAL-261] MasterSlaveConnection fails to load ConnectionEventArgs

Sat, 5 May 2012 07:18:09 +0000

Incorrect class referenced at line 164 of Doctrine\DBAL\Connection\MasterSlaveConnection.php:

$eventArgs = new Event\ConnectionEventArgs($this);

Current namespace is Doctrine\DBAL\Connection so class loader fails when looking for Doctrine\DBAL\Connection\Event\ConnectionEventArgs

Work around is to add Doctrine\DBAL\Event\ConnectionEventArgs to use directive and change line to:

$eventArgs = new ConnectionEventArgs($this);

[DBAL-260] [GH-135] Add typehint info to core types for use by entity generator.

Fri, 4 May 2012 17:55:11 +0000

This issue is created automatically through a Github pull request on behalf of benlumley:

Url: https://github.com/doctrine/dbal/pull/135

Message:

So as you probably know, the EntityGenerator doesn't typehint the setters for the DateTime types (datetime, date, datetimetz, time) - which has just caused me to miss an obvious error, and judging from google, plenty of others before me too.

So I've added it - you'll have a pull request in a sec on the doctrine2 repo for that, but it needs this change too - which provides the mapping info.

[DBAL-259] [GH-134] Removed Paranthesis to allow for more complex Regex

Sat, 5 May 2012 11:40:38 +0000

This issue is created automatically through a Github pull request on behalf of Hounddog:

Url: https://github.com/doctrine/dbal/pull/134

Message:

Needed to remove the Paranthesis to allow for complex Regular Expressions. e.g Exclusion of tables

[DBAL-258] [GH-133] Removed Paranthesis to allow for more complex Regex

Fri, 4 May 2012 17:37:35 +0000

This issue is created automatically through a Github pull request on behalf of Hounddog:

Url: https://github.com/doctrine/dbal/pull/133

Message:

Needed to remove the Paranthesis to allow excluding of Tables with more complex Regular Expressions.

[DBAL-257] OCI8Statement::fetchColumn() returns null instead of false

Sat, 5 May 2012 09:28:22 +0000

In
public function fetchColumn($columnIndex = 0)
{
$row = oci_fetch_array($this->_sth, OCI_NUM | OCI_RETURN_NULLS | OCI_RETURN_LOBS);
return $row[$columnIndex];
}

there is no control on oci_fetch_array_() returned value.
When it returns false fetchColumn() returns null instead of false.

Solution:
public function fetchColumn($columnIndex = 0)
{
$row = oci_fetch_array($this->_sth, OCI_NUM | OCI_RETURN_NULLS | OCI_RETURN_LOBS);
return isset($row[$columnIndex]) ? $row[$columnIndex] : false;
}

[DBAL-256] MySQL doesn't allow a query with an offset without a limit

Sun, 8 Jul 2012 07:18:23 +0000

With MySQL, it is not allowed to do a request like this:
select * from table OFFSET 2

It is mandatory to have the LIMIT clause included:
select * from table LIMIT 1000 OFFSET 2

But, in the AbstractPlaform class, there is no check to control if the offset has been set but not the limit:
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php#L2549

So in the jackalope-doctrine-dbal environment (https://github.com/jackalope/jackalope-doctrine-dbal/), it generates an invalid query for MySQL. This occurs if the QueryBuilder is used in this way, which I think is allowed:
$this->query->setOffset(2);
$qr = $this->query->execute();

The MySQL documentation specifies that it can be used by adding some large number in the limit:
http://dev.mysql.com/doc/refman/5.5/en/select.html

Can it be done automatically by Doctrine DBAL?

[DBAL-255] On SQL SERVER Trying to drop a column throws error because of auto generated Constraints

Sat, 5 May 2012 11:08:06 +0000

Whenever Doctrine tries to drop a column that has some implicit constraints the system the SQL Native Client throws the message:

The Object 'Name_Of_The_Object' is dependent on column 'Column_To_Drop';

This is probably because columns such as Decimal Numbers have an automatice generated constraint that need to be dropped in order to drop a column.

A possible Solution is to add a platform specific getConstratintForTableSQL that queries the database to get all the constraint for the given column, than override the 'alterTable' method in the SQLServer Schema Manager to first drop the constraint than the columns in question by going and checking all the Columns that needs to be dropped in the TableDiff passed.

Something similar to this but better refactored I guess:

Changes in SQLServerPlatform.php

Add a method similar to this:

    /**
     * This function retrieves the constraints for a given column that is going to be droppped 
     */
    public function getColumnConstraintSQL($table, $column)
    {
        return "SELECT SysObjects.[Name]
                From SysObjects Inner Join (Select [Name],[ID] From SysObjects Where XType = 'U') As Tab
                On Tab.[ID] = Sysobjects.[Parent_Obj] 
                Inner Join sysconstraints On sysconstraints.Constid = Sysobjects.[ID] 
                Inner Join SysColumns Col On Col.[ColID] = sysconstraints.[ColID] And Col.[ID] = Tab.[ID]
                Where Col.[Name] = '$column' and Tab.[Name] = '$table'
                order by Col.[Name]";
    }

Changes on SqlServerChemaManager.php

       /**
	* Override
	*/
	public function alterTable(TableDiff $tableDiff)
	{
		if(count($tableDiff->removedColumns) > 0){
			$constraintsSql = array();
			foreach($tableDiff->removedColumns as $col){
				$constraintsSql[] = $this->_platform->getColumnConstraintSQL($tableDiff->name, $col->oldColumnName);
			}
			$constraintsToDrop = array();
			foreach($constraintsSql as $sql){
				 $constraintsToDrop[] = $this->_conn->execute($sql);
			}
			foreach($constraintsToDrop as $constraint){
				$this->_conn->execute("ALTER TABLE $tableDiff->name DROP CONSTRAINT $constraint");
			}
		}
		return parent::alterTable($tableDiff);
	}

Hope this helps

Thx

[DBAL-254] SQL Server rename table should use sp_RENAME

Sun, 8 Jul 2012 20:31:44 +0000

Whenever DBAL Schema Manager tries to rename a table in sql server 2008 it should use also the sp_RENAME procedure. Otherwise error is thrown.

Apparently a similar issue was fixed for column ALTER Commands as described in the link below, but also the ALTER TABLE command should use sp_RENAME to avoid crash.

http://www.doctrine-project.org/jira/browse/DBAL-199?page=com.atlassian.jira.plugin.system.issuetabpanels%3Achangehistory-tabpanel

Suggested fix for Latest DBAL 2.2

From Line 283:

$queryParts[] = 'RENAME TO ' . $diff->newName;

To Line 283:

$sql[] = 'sp_RENAME \'' . $diff->name . '\',\'' . $diff->newName.'\'';

This seems to fix the problem.

Hope this helps

Sorry for my bad english.

Fredcallagan

[DBAL-253] [GH-132] Added Support for excluding Tables

Fri, 4 May 2012 18:01:06 +0000

This issue is created automatically through a Github pull request on behalf of doyousoft:

Url: https://github.com/doctrine/dbal/pull/132

Message:

[DBAL-252] [GH-131] [mysqli] Added mysqli driver to travis tests.

Mon, 16 Apr 2012 17:02:02 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/131

Message:

[DBAL-251] [GH-130] [mysqli] Added support for fetchAll(PDO::fetch_column)

Mon, 16 Apr 2012 17:01:56 +0000

This issue is created automatically through a Github pull request on behalf of kimhemsoe:

Url: https://github.com/doctrine/dbal/pull/130

Message:

[DBAL-250] [GH-128] [DBAL-249] result cache with fetch type PDO::FETCH_COLUMN

Fri, 4 May 2012 18:04:13 +0000

This issue is created automatically through a Github pull request on behalf of gedrox:

Url: https://github.com/doctrine/dbal/pull/128

Message:

This should enable caching of results retrieved by PDO::FETCH_COLUMN fetch type.
Before this exception "Invalid fetch-style given for caching result" was raised.

Should work now.

(This replaces a previous pull request #126 I failed to make right... sorry)

[DBAL-249] Enable caching for fetch type FETCH_COLUMN

Thu, 5 Apr 2012 08:45:51 +0000

If results are requested using fetch method FETCH_COLUMN, and the cache is used, the exception is raised:

Invalid fetch-style given for caching result

[DBAL-248] [GH-127] Fix Statement class passing bound objects to SQL logger

Fri, 4 May 2012 18:04:31 +0000

This issue is created automatically through a Github pull request on behalf of jimcottrell:

Url: https://github.com/doctrine/dbal/pull/127

Message:

This commit saves converted parameter values in bindValue() so the later call to the SQL logger in execute() will not pass bound objects without type information.

[DBAL-247] [GH-126] Enable caching of results with fetch type PDO::FETCH_COLUMN

Sat, 7 Apr 2012 08:15:30 +0000

This issue is created automatically through a Github pull request on behalf of gedrox:

Url: https://github.com/doctrine/dbal/pull/126

Message:

This should enable caching of results retrieved by PDO::FETCH_COLUMN fetch type.
Before this exception "Invalid fetch-style given for caching result" was raised.

[DBAL-246] [GH-125] PHPDoc blocks improvments + 1 CS Fix

Fri, 4 May 2012 18:05:02 +0000

This issue is created automatically through a Github pull request on behalf of adrienbrault:

Url: https://github.com/doctrine/dbal/pull/125

Message:

Hey guys,

I started to fix a class type inside Connection and then i went ahead to see what i could also improve!

Adrien

[DBAL-245] [GH-124] Connection quote() ignores returned value from getBindingInfo()

Fri, 30 Mar 2012 19:48:00 +0000

This issue is created automatically through a Github pull request on behalf of jimcottrell:

Url: https://github.com/doctrine/dbal/pull/124

Message:

Maybe I'm missing something here, but this simple change seems to be necessary to allow for proper type management in quote(). For example, without this change passing a DateTime object as $input with $type = 'date' will resolve the proper string value in getBindingInfo, but then still attempt to pass the DateTime to PDO, which of course doesn't work.

[DBAL-244] Shema Tool is not working after DBAL-177 for postgresql (mysql working like before)

Sat, 5 May 2012 08:01:06 +0000

After trying to upgrade 2.2.0 i found that schema tool wasn't working, so I switched back to 2.1.6, same thing with 2.2.1 and no bug report, so this is wats going on.

./doctrine orm:schema-tool:update --dump-sql # this will show full create table for schema even if tables are all ready there.

After git bisectin Doctrine ORM project i found that commit ea5108ea0f35fc0f7ed3a740995a590926045c6e wast to blame, but that was only submodule update so made bisect for Doctrine DBAL:

537de7ea6a34edbcc40bc6ca92e0a3f816b59330 .. 4410e4cec20b0f1f209578320e5b7d111e90c2a0 founding that 1ae87bf3e3ba93cb579a2a092b06b5a09b316542 was the problem.

[margus@laptop doctrine-dbal ((4410e4c...))]$ git reset --hard 1ae87bf3e3ba93cb579a2a092b06b5a09b316542
HEAD is now at 1ae87bf ~~DBAL-177~~ - Make sure schema.table syntax is supported in Assets for quoted assets
[margus@laptop doctrine-dbal ((1ae87bf...))]$ git submodule update --recursive
Submodule path 'lib/vendor/doctrine-common': checked out 'd6e4c8b22af9800db4fd9d679ce98538da028168'

1. shema tool printing full schema

[margus@laptop doctrine-dbal ((1ae87bf...))]$ git reset --hard HEAD^1
HEAD is now at bb84496 ~~DBAL-144~~ - Dont throw exception when no primary key exists
[margus@laptop doctrine-dbal ((bb84496...))]$ git submodule update --recursive

1. works fine

[margus@laptop build (master)]$ ./doctrine orm:schema-tool:update --dump-sql
Nothing to update - your database is already in sync with the current entity metadata.

with commit 1ae87bf3e3ba93cb579a2a092b06b5a09b316542 schema starts with 3 NULL lines, and then schema, with 2.2.0, extra "NULL" lines aren't there anymore.

Using MySQL there isn't any problem, but with PostgreSQL (i have 8.4.11) this issue appears.

[DBAL-243] setCharset raises an error when using pdo_sqlite

Thu, 5 Jul 2012 21:02:37 +0000

When I attempt to use setCharset("utf8") with pdo_sqlite, this fails.

I know that pdo_sqlite doesn't support SET NAMES utf8, however, this should be caught by the driver (like: throwing a NotSupportedException) or simply ignore setCharset (mainly because if you allow the user to choose their backend, developers don't need to introduce special cases for driver handling).

[DBAL-242] Catch and re-throw exceptions with common messages + codes

Thu, 20 Sep 2012 06:19:57 +0000

Catch and re-throw exceptions with common messages + codes

[DBAL-241] Add fetchAll(PDO::FETCH_COLUMN) support to OCI8 driver

Sat, 24 Mar 2012 09:05:21 +0000

See https://github.com/doctrine/dbal/pull/52

[DBAL-240] SQL Parser Utils trigger error when uing with Type instances

Sat, 24 Mar 2012 07:55:50 +0000

https://github.com/doctrine/dbal/pull/120

[DBAL-239] CI 2 + DOCTRINE 2 + SQLSERVER 2005 PDO_SQLSRV.DLL

Wed, 1 May 2013 17:27:54 +0000

Hi, master...

Please help me,
i was integration : ci2+doctrine2+pdo_mysql status is OK http://103.28.148.89/ci2doctrine2
php.ini http://103.28.148.89 ===> phpinfo()

But ci2+doctrine2+pdo_sqlsrv. Show bugs this :

"Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[IMSSP]: This extension requires either the Microsoft SQL Server 2008 Native Client (SP1 or later) or the Microsoft SQL Server 2008 R2 Native Client ODBC Driver to communicate with SQL Server. Neither of those ODBC Drivers are currently installed. Access the following URL to download the Microsoft SQL Server 2008 R2 Native Client ODBC driver for x86: http://go.microsoft.com/fwlink/?LinkId=163712' in C:\xampp\htdocs\sqlserver\application\third_party\doctrine-orm\Doctrine\DBAL\Driver\PDOConnection.php:36 Stack trace: #0 C:\xampp\htdocs\sqlserver\application\third_party\doctrine-orm\Doctrine\DBAL\Driver\PDOConnection.php(36): PDO->_construct('sqlsrv:server=B...', 'sa', 'password', Array) #1 C:\xampp\htdocs\sqlserver\application\third_party\doctrine-orm\Doctrine\DBAL\Driver\PDOSqlsrv\Driver.php(38): Doctrine\DBAL\Driver\PDOConnection->_construct('sqlsrv:server=B...', 'sa', 'password', Array) #2 C:\xampp\htdocs\sqlserver\application\third_party\doct in C:\xampp\htdocs\sqlserver\application\third_party\doctrine-orm\Doctrine\DBAL\Driver\PDOConnection.php on line 36"

Thanks
GBU

[DBAL-238] Disable MultipleActiveResultSets in SQL Server (pdo_sqlsrv) not possible

Sat, 5 May 2012 11:46:40 +0000

http://msdn.microsoft.com/en-us/library/ee376925%28v=sql.90%29.aspx

[DBAL-237] schema:update fails when changing from ManyToOne to OneToOne

Wed, 14 Mar 2012 20:28:34 +0000

If a relation is changed from ManyToOne to OneToOne a Mysql exception 1025 is thrown because schema:update attempts to drop the indexes without first dropping the foreign keys. This seems to happen since the foreign keys are not deleted from the entity.. but the indexes change type (from index to unique).

Incorrect output from --dump-sql

DROP INDEX IDX_9AFB9A3755EB82D0 ON tapi_phone;
DROP INDEX IDX_9AFB9A37A6A12EC1 ON tapi_phone;
ALTER TABLE tapi_phone ADD location_id INT DEFAULT NULL, CHANGE extension extension VARCHAR(255) DEFAULT NULL, CHANGE protocol protocol VARCHAR(255) DEFAULT NULL;
ALTER TABLE tapi_phone ADD CONSTRAINT FK_9AFB9A3764D218E FOREIGN KEY (location_id) REFERENCES tapi_location(id);
CREATE UNIQUE INDEX UNIQ_9AFB9A37F85E0677 ON tapi_phone (username);
CREATE UNIQUE INDEX UNIQ_9AFB9A37B728E969 ON tapi_phone (mac_address);
CREATE UNIQUE INDEX UNIQ_9AFB9A3755EB82D0 ON tapi_phone (default_user_id);
CREATE INDEX IDX_9AFB9A3764D218E ON tapi_phone (location_id);
CREATE UNIQUE INDEX UNIQ_9AFB9A37A6A12EC1 ON tapi_phone (registered_user_id)

Expected output from --dump-sql

ALTER TABLE tapi_phone DROP FOREIGN KEY FK_9AFB9A3755EB82D0;
DROP INDEX IDX_9AFB9A3755EB82D0 ON tapi_phone;
ALTER TABLE tapi_phone DROP FOREIGN KEY FK_9AFB9A37A6A12EC1;
DROP INDEX IDX_9AFB9A37A6A12EC1 ON tapi_phone;
ALTER TABLE tapi_phone ADD location_id INT DEFAULT NULL, CHANGE extension extension VARCHAR(255) DEFAULT NULL, CHANGE protocol protocol VARCHAR(255) DEFAULT NULL;
ALTER TABLE tapi_phone ADD CONSTRAINT FK_9AFB9A3764D218E FOREIGN KEY (location_id) REFERENCES tapi_location(id);
ALTER TABLE tapi_phone ADD CONSTRAINT FK_9AFB9A3755EB82D0 FOREIGN KEY (default_user_id) REFERENCES tapi_user (id);
ALTER TABLE tapi_phone ADD CONSTRAINT FK_9AFB9A37A6A12EC1 FOREIGN KEY (registered_user_id) REFERENCES tapi_user (id);
CREATE UNIQUE INDEX UNIQ_9AFB9A37F85E0677 ON tapi_phone (username);
CREATE UNIQUE INDEX UNIQ_9AFB9A37B728E969 ON tapi_phone (mac_address);
CREATE UNIQUE INDEX UNIQ_9AFB9A3755EB82D0 ON tapi_phone (default_user_id);
CREATE INDEX IDX_9AFB9A3764D218E ON tapi_phone (location_id);
CREATE UNIQUE INDEX UNIQ_9AFB9A37A6A12EC1 ON tapi_phone (registered_user_id);

[DBAL-235] Column order is not synchronized by Comparator

Tue, 3 Apr 2012 06:22:35 +0000

Comparator does not synchronize column order. It would be great if it did.

[DBAL-234] Index names are not synchronized by Comparator

Thu, 8 Mar 2012 15:33:25 +0000

Index and foreign key name change is not synced by Comparator.

This is important since in some complex queries one might use FORCE INDEX (some_index_name), and they will fail if an index name is incorrect.

[DBAL-233] Signed / unsigned types are ignored by Comparator for MySQL schemas

Thu, 15 Mar 2012 11:25:51 +0000

E.g. one schema has an column1 which is unsigned tinyint, another schema doesn't.
The sql that is generated is the following:

ALTER TABLE table1 ADD column1 TINYINT(1) NOT NULL DEFAULT '1'

And it should be:

ALTER TABLE table1 ADD column1 TINYINT(1) UNSIGNED NOT NULL DEFAULT '1'

If in one schema there is an unsigned column and in the other it is signed (that being the only difference), the difference is not noticed at all.

[DBAL-232] Custom commented column type removal causes unknown column type exception

Fri, 9 Mar 2012 10:22:09 +0000

Problem happens when initially, as example, there was commented type "foo" registered and used:

Doctrine\DBAL\Types\Type::addType('foo', 'FooType');
$em->getConnection()
    ->getDatabasePlatform()
    ->markDoctrineTypeCommented(Doctrine\DBAL\Types\Type::getType('foo'));

When the type usage and declaration is removed, the database schema upgrade fails.
This is because DBAL reads the comment from the database and tries to find the type 'foo'.

I suggest ignoring the database column comment and stick to the standard type recognition in case the type is not declared.

[DBAL-231] Doctrine\DBAL\SQLParserUtils::getPlaceholderPositions() - regex

Sat, 19 Jan 2013 18:27:29 +0000

Running the following SQL (note the named parameter ":account_id"):
===================
SELECT count('*') as cnt FROM feed f INNER JOIN orders_accounts oa ON oa.order_id = f.feed_id INNER JOIN users u ON u.id = f.user_id WHERE oa.account_id = :account_id AND f.feed_type='order' ORDER BY f.create_date DESC
===================

ends up in a thrown exception.
This SQL was generated by using the Query Builder

$qb = $this->_em->getConnection()->createQueryBuilder();
$qb->select('count(\'*\') as cnt');//I know this is bad
$qb->from('feed', 'f');
$qb->innerJoin('f', 'orders_accounts', 'oa', 'oa.order_id = f.feed_id');
$qb->innerJoin('f', 'users', 'u', 'u.id = f.user_id');
$qb->where('oa.account_id = :account_id AND f.feed_type=\'order\'');
$qb->setParameter('account_id', $accountId, \PDO::PARAM_INT);

$stmt = $qb->execute();
$res = $stmt->fetchAll(\PDO::FETCH_COLUMN);

===================
string(82) "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'NULL_id' in 'where clause'"
string(3168) "#0 /var/www/cake_to_zf/library/Doctrine/DBAL/Connection.php(628): PDOStatement->execute()
#1 /var/www/cake_to_zf/library/Doctrine/DBAL/Query/QueryBuilder.php(185): Doctrine\DBAL\Connection->executeQuery('SELECT count('*...', Array, Array)
#2 /var/www/cake_to_zf/library/of/doctrine/SqlQueryBuilderPaginatorAdapter.php(69): Doctrine\DBAL\Query\QueryBuilder->execute()
#3 /var/www/cake_to_zf/library/Zend/Paginator.php(1060): of\doctrine\SqlQueryBuilderPaginatorAdapter->count()
.......

Suggested Fix:

Regex on line 64 in preg_match becomes '#([:a-zA-Z0-9_]

{1}

)#'
Added was an "_" ...

===================