http://www.doctrine-project.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+10032+AND+labels+%3D+%22Query%2C%22 An XML representation of a search request en-us 5.2.7 850 21-02-2013 http://www.doctrine-project.org/jira/browse/DDC-2140 Doctrine 2 - ORM <p>This issue is created automatically through a Github pull request on behalf of jappie:</p> <p> Url: <a href="https://github.com/doctrine/doctrine2/pull/512" class="external-link">https://github.com/doctrine/doctrine2/pull/512</a></p> <p>Message:</p> <p>This method behaves like <tt>setParameters()</tt> before version 2.3:<br/> It will add new parameters to the collection, and override any existing positions/names.</p> <p>It can take a <tt>Doctrine\Common\Collections\ArrayCollection</tt> with <tt>Doctrine\ORM\Query\Parameter</tt> objects, as well as a plain <tt>array</tt> with key/value pairs, as argument.</p> <p>This will greatly ease the upgrade to Doctrine 2.3, because you only need to perform a project-wide replace of <tt>setParameters</tt> with <tt>addParameters</tt>, in stead of going into your code and determine if calls to <tt>setParameters</tt> are ok or need refactoring.</p> <p>I've also added unit-tests to maintain integrity.</p> OS X 10.8.2, PHP 5.3.18, Nginx 1.2.4 (php through FPM) DDC-2140

[GH-512] Added addParameters() to Query and QueryBuilder

Improvement Minor Open Unresolved All Benjamin Eberlei Benjamin Eberlei Query, QueryBuilder Tue, 13 Nov 2012 08:51:04 +0000 Tue, 20 Nov 2012 08:06:05 +0000 2.3 Git Master ORM 0 2 <p>A related Github Pull-Request <span class="error">&#91;GH-512&#93;</span> was closed<br/> <a href="https://github.com/doctrine/doctrine2/pull/512" class="external-link">https://github.com/doctrine/doctrine2/pull/512</a></p> <blockquote> <p>I don't feel strong need to have such an API.<br/> If you want to keep track and merge collection of parameters, all you have to do is create an array (or an ArrayCollection), manipulate the instance and then setParameters at the end.<br/> Unless you give me a stronger argument, this code won't be in. Closing for now.</p></blockquote> <p>Hi Guilherme,</p> <p>I agree that such a method makes less sense in <tt>Query</tt>, because when you write a DQL string all parameters are known at once. But when using the <tt>QueryBuilder</tt> you might need different parameters in different cases, so <tt>addParameters()</tt> becomes useful there.</p> <p>I guess it's just a convenience method, like IMHO <tt>setParameter()</tt> is. (You could just do <tt>$qb-&gt;getParameters()-&gt;add()</tt>)</p> <p>The main reason for adding the method was, like I said, upgrading to Doctrine 2.3. I've already upgraded all my projects to Doctrine 2.3, so the method is less useful for me now. But it took me a full day to refactor my repositories, because there is no safe way to automate the process. A simple search-and-replace <tt>setParameters()</tt> to <tt>addParameters()</tt> would have taken me 5 minutes <img class="emoticon" src="http://www.doctrine-project.org/jira/images/icons/emoticons/wink.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p> <p>I'm content with your decision.<br/> If others find <tt>addParameters()</tt> useful, I hope they let us know.</p>