[DDC-2313] Deep clone for DBAL QueryBuilder

Duplicate — Tue, 18 Jun 2013 07:10:36 +0000

This is basically a duplicate of another issue I stumbled across lately but cannot find here again. It added a __clone() function to the ORM QueryBuilder to allow this use case:
Create a base query and derive two different queries from it.

I adopted the code for the DBAL QueryBuilder which is suffering the same issue (e.g. expressions were not cloned but shared between instances). The code is tested at least for my limited use case.

    /**
     * Deep clone of all expression objects in the SQL parts.
     *
     * @return void
     */
    public function __clone()
    {
        foreach ($this->sqlParts as $part => $elements) {
            if (is_array($this->sqlParts[$part])) {
                foreach ($this->sqlParts[$part] as $idx => $element) {
                    if (is_object($element)) {
                        $this->sqlParts[$part][$idx] = clone $element;
                    }
                }
            } else if (is_object($elements)) {
                $this->sqlParts[$part] = clone $elements;
            }
        }

        $params = array();

        foreach ($this->params as $param) {
            $params[] = clone $param;
        }

        $this->params = $params;
    }

[DDC-2478] PersisterException when matching Criteria expression isNull to ArrayCollection

Fri, 14 Jun 2013 04:26:40 +0000

    /**
     * @ORM\ManyToOne(targetEntity="ClubBoardPost", inversedBy="children")
     * @var ClubBoardPost
     */
    protected $parent;

$criteria = Criteria::create()->where(Criteria::expr()->isNull('parent'));
$this->boardPosts->matching($criteria);

[output]
Cannot match on Fubles\CoreBundle\Entity\ClubBoardPost::parent with a non-object value. Matching objects by id is not compatible with matching on an in-memory collection, which compares objects by reference.

[first analysis]
@SqlExpressionVisitor:69 It seems like this check pretends that the value must be an object, maybe do you need to exclude NULL values only if association is nullable?

Doctrine Project

[DDC-2313] Deep clone for DBAL QueryBuilder

[DDC-2478] PersisterException when matching Criteria expression isNull to ArrayCollection