Doctrine Project

[DBAL-461] Numeric() syntax in columns fails on SQL Server

Thu, 14 Mar 2013 21:30:44 +0000

This issue occurred when I tried to create entities from existing MSSQL Database. My database have several fields that are defined as "numeric" data types. When I tried to reverse engineer this data base, doctrine threw an error mentioning that doctrine numeric data types are not supported. I have attached code that I used to create entities. And error that was generated. Hope this Helps narrow down the process. One thing that ca in to notice was that the "SQLServerSchemaManager" class does not have any specific mechanism to handle "numeric" as compared to "MySqlSchemaManager".

[DBAL-458] [GH-281] Upgrading doctrine/common 2.4 (via composer)

Mon, 4 Mar 2013 22:38:23 +0000

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: https://github.com/doctrine/dbal/pull/281

Message:

This PR introduces changes necessary to make the DBAL recognize `"doctrine/common": "2.4"` as compatible as discussed in https://groups.google.com/d/topic/doctrine-dev/8WjzboENQgg/discussion

Ping @dbu

[DBAL-452] range is a reserved word in several platforms

Fri, 15 Mar 2013 03:02:01 +0000

'range' is a reserved word for MySQL, Oracle, and on future reserved list for SQL Server as well so should really be added for escaping. Working on a new project using Doctrine accessing an external API which used it as a field and got an error when running orm:schema-tool:create on my entity with MySQL.

[DBAL-446] Type json_array can't be null

Mon, 1 Apr 2013 21:48:49 +0000

Column type json_array can be set to nullable, but if there's null in the database, it is returned as an empty array to PHP.

Null should be returned instead, as that's how the other types behave too.

[DBAL-436] Logger should specify connection used in a master/slave situation

Mon, 1 Apr 2013 16:34:12 +0000

Suppose there is a master connection with four slaves specified. Connections are being handled by the Doctrine\DBAL\Connections\MasterSlaveConnection class. Under the current implementation, all queries are logged under the "master" connection, even queries that are routed to the slaves by the Doctrine\DBAL\Connections\MasterSlaveConnection class.

Since slave connections are separate, distinct connections, queries should be logged appropriately under their respective connections.

[DBAL-416] [GH-249] Fixed doModifyLimitQuery for SQLServerPlatform

Sun, 20 Jan 2013 11:50:54 +0000

This issue is created automatically through a Github pull request on behalf of norzechowicz:

Url: https://github.com/doctrine/dbal/pull/249

Message:

It seems that there is a problem in SQLServerPlatform ``doModifyLimitQuery`` method.
I can't use Doctrine ORM Paginator because of wrong position of ``DISTINCT`` statement in final limit subquery, here is the exception message I'm getting.
``SQLSTATE[42000]: [Microsoft][SQL Server Native Client 10.0][SQL Server]Incorrect syntax near the keyword 'DISTINCT'.``

My proposition is to change ``doModifyLimitQuery`` result from:

``SELECT * FROM (SELECT ROW_NUMBER() OVER (ORDER BY username DESC) AS doctrine_rownum, * FROM user) ...``

into:

``SELECT * FROM (SELECT *, ROW_NUMBER() OVER (ORDER BY username DESC) AS doctrine_rownum FROM user) ...``

[DBAL-364] [GH-216] Fixed SQL placeholder parsing

Sat, 19 Jan 2013 18:26:56 +0000

This issue is created automatically through a Github pull request on behalf of a-nik:

Url: https://github.com/doctrine/dbal/pull/216

Message:

Fixed comment on 'getPlaceholderPositions' method
Fixed error on escaped quote mark inside an SQL expression

[DBAL-231] Doctrine\DBAL\SQLParserUtils::getPlaceholderPositions() - regex

Sat, 19 Jan 2013 18:27:29 +0000

Running the following SQL (note the named parameter ":account_id"):
===================
SELECT count('*') as cnt FROM feed f INNER JOIN orders_accounts oa ON oa.order_id = f.feed_id INNER JOIN users u ON u.id = f.user_id WHERE oa.account_id = :account_id AND f.feed_type='order' ORDER BY f.create_date DESC
===================

ends up in a thrown exception.
This SQL was generated by using the Query Builder

$qb = $this->_em->getConnection()->createQueryBuilder();
$qb->select('count(\'*\') as cnt');//I know this is bad
$qb->from('feed', 'f');
$qb->innerJoin('f', 'orders_accounts', 'oa', 'oa.order_id = f.feed_id');
$qb->innerJoin('f', 'users', 'u', 'u.id = f.user_id');
$qb->where('oa.account_id = :account_id AND f.feed_type=\'order\'');
$qb->setParameter('account_id', $accountId, \PDO::PARAM_INT);

$stmt = $qb->execute();
$res = $stmt->fetchAll(\PDO::FETCH_COLUMN);

===================
string(82) "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'NULL_id' in 'where clause'"
string(3168) "#0 /var/www/cake_to_zf/library/Doctrine/DBAL/Connection.php(628): PDOStatement->execute()
#1 /var/www/cake_to_zf/library/Doctrine/DBAL/Query/QueryBuilder.php(185): Doctrine\DBAL\Connection->executeQuery('SELECT count('*...', Array, Array)
#2 /var/www/cake_to_zf/library/of/doctrine/SqlQueryBuilderPaginatorAdapter.php(69): Doctrine\DBAL\Query\QueryBuilder->execute()
#3 /var/www/cake_to_zf/library/Zend/Paginator.php(1060): of\doctrine\SqlQueryBuilderPaginatorAdapter->count()
.......

Suggested Fix:

Regex on line 64 in preg_match becomes '#([:a-zA-Z0-9_]

{1}

)#'
Added was an "_" ...

===================