Doctrine Project

[DDC-1056] Using the StaticPHPDriver throws PHP Error Undefined property: Doctrine\ORM\Mapping\Driver\StaticPHPDriver::$_classNames

Fri, 4 Mar 2011 16:23:55 +0000

Using the StaticPHPDriver throws PHP Error Undefined property: Doctrine\ORM\Mapping\Driver\StaticPHPDriver::$_classNames

this is due to the class not having the two required instance variables $this->_classNames and $this->_fileExtension.

[DDC-1041] UnitOfWork tryGetById method is always called with the rootEntityName

Fri, 4 Mar 2011 15:56:45 +0000

My problem : i have a class table inheritance, with only 3 class, one abstract and two concrete.
says AbstractClass, ConcretClassA and ConcreteClassB
All three are declared with @entity

if i already have in my identity map the ConcretClassA with id = 1
when i do an entityManager->find('ConcreteClassB', 1) the identityMap returns me the ConcretClassA with id = 1
that's not correct !
it should return a null value instead

That's because the entityRepository (and all the other doctrine class) call the UnitOfWork tryGetById with the rootEntityName, which in my case is AbstractClass.
See the first line of the entityRepository's find method :

$this->_em->getUnitOfWork()->tryGetById($id, $this->_class->rootEntityName)

if i change this line to :

$this->_em->getUnitOfWork()->tryGetById($id, $this->_class->name)

the find method return the expected null value.

So, why the UnitOfWork tryGetById method is always called with the rootEntityName ?

[DDC-1036] the Aggregate Expressions "AVG" | "MAX" | "MIN" | "SUM", should be followed by SimpleArithmeticExpression

Sun, 20 Feb 2011 03:16:19 +0000

the Aggregate Expressions "AVG" | "MAX" | "MIN" | "SUM", should be not only followed by StateFieldPathExpression , but also SimpleArithmeticExpression,
see http://www.doctrine-project.org/docs/orm/2.0/en/reference/dql-doctrine-query-language.html#aggregate-expressions

i found it can not execute dql like
select sum(c.quantity * c.price) total_price from cart c

i think, this should be a bug

[DDC-1034] Registered lifecycle callbacks of derived classes have unexpected call sequence

Fri, 4 Mar 2011 17:04:55 +0000

Situation:
Create an abstract base class (@InheritanceType("JOINED")) and a derived class, both having the annotation @HasLifecycleCallbacks and both having a method with annotation @PostLoad (different method names). The sequence of methods being called when an object is loaded from the database is not as expected.

Expected output:
Called Che\Tmp\BaseClass::PostLoadBase
Called Che\Tmp\DerivedClass::PostLoadDerived
(base value, derived value)

Actual output:
Called Che\Tmp\BaseClass::PostLoadBase
Called Che\Tmp\DerivedClass::PostLoadDerived
Called Che\Tmp\BaseClass::PostLoadBase
(base value)

Test code:
See attachment for classes

// Assume there is an entity manager $em
// Create object
$newDerived = new \Che\Tmp\DerivedClass();
$em->persist($newDerived);

// Fetch object
$derived = $em->findById('\Che\Tmp\DerivedClass', 1);
$derived->echoList();

Possible problem cause

ClassMetadataInfo::addLifecycleCallback($callback, $event) method has a note 'If the same callback is registered more than once, the old one will be overridden'. We are not sure whether this is the case.

[DDC-1033] Cloned proxies show unexpected behavior when initialized

Sat, 26 Feb 2011 06:50:17 +0000

When a proxy has been loaded and is cloned before being initialized, it will behave unexpectedly.

_load() in the proxy starts a chain of method calls that end up loading the data and putting it into the proxy being in the identity map inside UoW. Now the registered proxy will be updated, but the cloned copy will of course not be changed - except it will behave as if it was initialized. This leads (at least in my case) to changes not being picked up after merge() has been called.

In my case I could work around this if I could ask the proxy to initialize itself (~~DDC-733~~). More transparent would be a __clone() method in the proxy that initializes the proxy. This might also be related to ~~DDC-18~~.

[DDC-1030] Issue with parseTokensInEntityFile() and multiple levels of namespace

Dependency — Sun, 13 Feb 2011 04:03:53 +0000

If you have something like Acme\MainBundle\Document\User, the parser will only popular Acme\User as the key for the parsed information. We have to consider multiple leves of namespace. This concatenates each namespace after the namespace separator is found.

I made the same fix in the odm here. Pull request for ORM on the way.

https://github.com/doctrine/mongodb-odm/commit/b7c72aa7b7b41de97b328a872cc8f7d4141b3143

[DDC-1026] Doctrine Cache

Fri, 25 Feb 2011 18:42:01 +0000

I find a problem with doctrine cache key.

It use a namespace and key to save the value and never use the namespace to get it.

I checked that on AbstractQuery::getResultCacheId().

AbstractCache::save ~~> use $this~~>_getNamespacedId($id)

[DDC-1024] the EntityGenerator generate getters and setters for properties of the parent class

Wed, 4 Jan 2012 11:24:41 +0000

when using the EntityGenerator to generate getters and setters of two classes mapped with annotations, one inheriting from the other, the EntityGenerator generates getters and setters for the properties of the parent class in the child class too. This occurs since the recent EntityGenerator changes (as it did not care about inheritance before).
I suppose this is due to the fact that the getters and setters of the parent class are not yet generated when handling the child class.

I haven't try if it works well when using XML or YAML for the mapping.

[DDC-1023] the EntityGenerator duplicates the property when using annotations

Dependency — Sun, 13 Feb 2011 04:04:00 +0000

When using the EntityGenerator to generate getters and setters of a class mapped with annotations, all properties are duplicated. This occurs at least when the properties were defined protected (not tried with private ones).

It worked fine before the recent EntityGenerator changes.

[DDC-1018] INDEX BY does not work in JOIN clauses

Dependency — Sat, 5 Feb 2011 04:34:15 +0000

It seems INDEX BY only works in the FROM, not in JOIN clauses.

This is a dependency for ~~DDC-250~~

[DDC-1009] Allow using an annotation namespace in the EntityGenerator

Wed, 2 Feb 2011 17:46:54 +0000

The EntityGenerator does not allow to use a namespace for annotations, which is supported by the driver and used by Symfony2 DoctrineBundle.

The pull request https://github.com/doctrine/doctrine2/pull/22 adds this behavior.

[DDC-1008] Entity Generator Stub Method For Id Generator

Wed, 2 Feb 2011 17:32:07 +0000

In the EntityGenerator when the id setting has a generator of NONE it does not add the stub method for setting the id keys value, here's my fix:

around line 478 in the _generateEntityStubMethods function, the first foreach which checks for the id mapping, change:

if ( ! isset($fieldMapping['id']) || ! $fieldMapping['id']) {

if ( ! isset($fieldMapping['id']) || ! $fieldMapping['id'] || ($this->_getIdGeneratorTypeString($metadata->generatorType) == 'NONE')) {

[DDC-1006] Entity Generator Regenerate If Not New

Wed, 2 Feb 2011 17:33:01 +0000

When regenerating entities from xml ( and i am sure all others ) it gives a blank entity class when the file exists and the regenerateIfExists is set to true, the expected result would be a full entity with any removed columns removed from the entity and new columns to be added.

i've come up with a fix that i assume is the correct way
i haven't tested this without the regeneration set to true since my application requires the regeneration, here's my code block i'm using:

$em->getConfiguration()->setMetadataDriverImpl(
new \Doctrine\ORM\Mapping\Driver\SesXmlDriver(
'ext/Doctrine/Entities/xml_metadata/'
)
);

$cmf = new Doctrine\ORM\Tools\DisconnectedClassMetadataFactory();
$cmf->setEntityManager($em);
$metadata = $cmf->getAllMetadata();

$generator = new \Doctrine\ORM\Tools\EntityGenerator();
$generator->setGenerateAnnotations(true);
$generator->setGenerateStubMethods(true);
$generator->setRegenerateEntityIfExists(true);
//$generator->setUpdateEntityIfExists(true);
$generator->generate($metadata, 'ext/');

in the _hasProperty and _hasMethod functions, need to add the below to the inline check:

( ! $this->_isNew && $this->_regenerateEntityIfExists)

[DDC-1002] bug in generate entities with many2many relationships from xml/yml shcemes

Wed, 2 Feb 2011 17:32:38 +0000

I try use many2many relations in my symfony2 learning project https://github.com/symfony/symfony.git
But entities thar generates from yml schemes did not meet entities from doctrine2 guide or entities from beberlei Whitewashing project https://github.com/beberlei/Whitewashing/tree/master/Blog

After that I try generate similar entitries is doctrine2-sandbox. Problem is the same
I attached yml schemes and result entities.

Problem:

Entities\Address does not have relations with Entities\User
In Entities\User property $adresses instance of Entity\Address. But this Doctrine\Common\Collections\ArrayCollection or no?
```
    /**
     * @var Entity\Address
     */
    private $addresses;
```

In Entities\User not at __constructor() method:

    public function __construct()
    {
        $this->addresses = new ArrayCollection();
    }

[DDC-953] CLI tools orm:generate-entities --regenerate-entities=1 flag will generate empty entities 50% of time.

Tue, 8 Feb 2011 09:20:25 +0000

Running the command:
doctrine orm:generate-entities --regenerate-entities=1 --generate-annotations=1 ./

50% of the time my entity will appear as:
<?php

namespace models;

/**

models\Role
*
@Table(name="roles")
@Entity(repositoryClass="models\repositories\RoleRepository")
*/
class Role
{

}

The other 50% everything will be in there. In addition, if the --regenerate-entities=1 argument is removed, if I change the data in my YAML schema file for a column (such as changing length=255 to length=50 on a string), the annotations won't be updated when the updated entity is generated. It seems only new fields are being added to the entity files which is why --regenerate-entities=1 was required in the first place.