Doctrine Project

[DDC-723] Upgrade ORM to depend on DBAL Beta3

Wed, 28 Jul 2010 14:22:09 +0000

We need to raise the dependency of ORM to DBAL BETA 3 before the ORM Beta 3 release.

[DDC-719] Error in SQL subquery for a ManyToMany selfreferencing enitity when using the SIZE() or IS EMPTY dql function

Sat, 7 Aug 2010 06:28:09 +0000

I have an entity (Group) with a self-referencing ManyToMany association (parents, children).
Now im just trying to query all groups without a parent.

My DQL:

SELECT g, c, d FROM Volkszaehler\Model\Group g LEFT JOIN g.children c LEFT JOIN g.channels d  WHERE g.parents IS EMPTY

throws this PDOException:

object(PDOException)#31 (8) {
  ["message":protected]=>
  string(89) "SQLSTATE[42S02]: Base table or view not found: 1146 Table 'volkszaehler.5_' doesn't exist"
  ["string":"Exception":private]=>
  string(0) ""
  ["code":protected]=>
  string(5) "42S02"
  ["file":protected]=>
  string(90) "/home/steffen/workspace/doctrine/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php"
  ["line":protected]=>
  int(568)
  ["trace":"Exception":private]=>
  array(9) {
    [0]=>
    array(6) {
      ["file"]=>
      string(90) "/home/steffen/workspace/doctrine/lib/vendor/doctrine-dbal/lib/Doctrine/DBAL/Connection.php"
      ["line"]=>
      int(568)
      ["function"]=>
      string(5) "query"
      ["class"]=>
      string(3) "PDO"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(1) {
        [0]=>
        string(604) "SELECT g0_.name AS name0, g0_.description AS description1, g0_.id AS id2, g0_.uuid AS uuid3, g1_.name AS name4, g1_.description AS description5, g1_.id AS id6, g1_.uuid AS uuid7, c2_.name AS name8, c2_.description AS description9, c2_.indicator AS indicator10, c2_.resolution AS resolution11, c2_.cost AS cost12, c2_.id AS id13, c2_.uuid AS uuid14 FROM groups g0_ LEFT JOIN groups_groups g3_ ON g0_.id = g3_.parent_id LEFT JOIN groups g1_ ON g1_.id = g3_.child_id LEFT JOIN groups_channel g4_ ON g0_.id = g4_.group_id LEFT JOIN channels c2_ ON c2_.id = g4_.channel_id WHERE (SELECT COUNT(*) FROM  5_) = 0"
      }
    }
    [1]=>
    array(6) {
      ["file"]=>
      string(85) "/home/steffen/workspace/doctrine/lib/Doctrine/ORM/Query/Exec/SingleSelectExecutor.php"
      ["line"]=>
      int(46)
      ["function"]=>
      string(12) "executeQuery"
      ["class"]=>
      string(24) "Doctrine\DBAL\Connection"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(3) {
        [0]=>
        string(604) "SELECT g0_.name AS name0, g0_.description AS description1, g0_.id AS id2, g0_.uuid AS uuid3, g1_.name AS name4, g1_.description AS description5, g1_.id AS id6, g1_.uuid AS uuid7, c2_.name AS name8, c2_.description AS description9, c2_.indicator AS indicator10, c2_.resolution AS resolution11, c2_.cost AS cost12, c2_.id AS id13, c2_.uuid AS uuid14 FROM groups g0_ LEFT JOIN groups_groups g3_ ON g0_.id = g3_.parent_id LEFT JOIN groups g1_ ON g1_.id = g3_.child_id LEFT JOIN groups_channel g4_ ON g0_.id = g4_.group_id LEFT JOIN channels c2_ ON c2_.id = g4_.channel_id WHERE (SELECT COUNT(*) FROM  5_) = 0"
        [1]=>
        array(0) {
        }
        [2]=>
        array(0) {
        }
      }
    }
    [2]=>
    array(6) {
      ["file"]=>
      string(59) "/home/steffen/workspace/doctrine/lib/Doctrine/ORM/Query.php"
      ["line"]=>
      int(265)
      ["function"]=>
      string(7) "execute"
      ["class"]=>
      string(44) "Doctrine\ORM\Query\Exec\SingleSelectExecutor"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(3) {
        [0]=>
        object(Doctrine\DBAL\Connection)#16 (11) {
          ["_conn":protected]=>
          object(Doctrine\DBAL\Driver\PDOConnection)#29 (0) {
          }
          ["_config":protected]=>
          object(Doctrine\ORM\Configuration)#7 (1) {
            ["_attributes":protected]=>
            array(7) {
              ["metadataCacheImpl"]=>
              object(Doctrine\Common\Cache\ApcCache)#8 (2) {
                ["_cacheIdsIndexId":"Doctrine\Common\Cache\AbstractCache":private]=>
                string(18) "doctrine_cache_ids"
                ["_namespace":"Doctrine\Common\Cache\AbstractCache":private]=>
                NULL
              }
              ["queryCacheImpl"]=>
              object(Doctrine\Common\Cache\ApcCache)#8 (2) {
                ["_cacheIdsIndexId":"Doctrine\Common\Cache\AbstractCache":private]=>
                string(18) "doctrine_cache_ids"
                ["_namespace":"Doctrine\Common\Cache\AbstractCache":private]=>
                NULL
              }
              ["metadataDriverImpl"]=>
              object(Doctrine\ORM\Mapping\Driver\AnnotationDriver)#13 (4) {
                ["_reader":"Doctrine\ORM\Mapping\Driver\AnnotationDriver":private]=>
                object(Doctrine\Common\Annotations\AnnotationReader)#9 (2) {
                  ["parser":"Doctrine\Common\Annotations\AnnotationReader":private]=>
                  object(Doctrine\Common\Annotations\Parser)#10 (6) {
                    ["lexer":"Doctrine\Common\Annotations\Parser":private]=>
                    object(Doctrine\Common\Annotations\Lexer)#11 (5) {
                      ["tokens":"Doctrine\Common\Lexer":private]=>
                      array(0) {
                      }
                      ["position":"Doctrine\Common\Lexer":private]=>
                      int(0)
                      ["peek":"Doctrine\Common\Lexer":private]=>
                      int(0)
                      ["lookahead"]=>
                      NULL
                      ["token"]=>
                      NULL
                    }
                    ["isNestedAnnotation":"Doctrine\Common\Annotations\Parser":private]=>
                    bool(false)
                    ["defaultAnnotationNamespace":"Doctrine\Common\Annotations\Parser":private]=>
                    string(21) "Doctrine\ORM\Mapping\"
                    ["namespaceAliases":"Doctrine\Common\Annotations\Parser":private]=>
                    array(0) {
                    }
                    ["context":"Doctrine\Common\Annotations\Parser":private]=>
                    string(0) ""
                    ["autoloadAnnotations":"Doctrine\Common\Annotations\Parser":private]=>
                    bool(false)
                  }
                  ["cache":"Doctrine\Common\Annotations\AnnotationReader":private]=>
                  object(Doctrine\Common\Cache\ArrayCache)#12 (3) {
                    ["data":"Doctrine\Common\Cache\ArrayCache":private]=>
                    array(0) {
                    }
                    ["_cacheIdsIndexId":"Doctrine\Common\Cache\AbstractCache":private]=>
                    string(18) "doctrine_cache_ids"
                    ["_namespace":"Doctrine\Common\Cache\AbstractCache":private]=>
                    NULL
                  }
                }
                ["_paths":protected]=>
                array(1) {
                  [0]=>
                  string(58) "/home/steffen/workspace/volkszaehler.org/backend/lib/Model"
                }
                ["_fileExtension":protected]=>
                string(4) ".php"
                ["_classNames":protected]=>
                NULL
              }
              ["proxyDir"]=>
              string(66) "/home/steffen/workspace/volkszaehler.org/backend/lib/Model/Proxies"
              ["proxyNamespace"]=>
              string(26) "Volkszaehler\Model\Proxies"
              ["autoGenerateProxyClasses"]=>
              bool(true)
              ["sqlLogger"]=>
              object(Volkszaehler\Util\Debug)#22 (5) {
                ["queries":protected]=>
                array(1) {
                  [0]=>
                  array(2) {
                    ["sql"]=>
                    string(604) "SELECT g0_.name AS name0, g0_.description AS description1, g0_.id AS id2, g0_.uuid AS uuid3, g1_.name AS name4, g1_.description AS description5, g1_.id AS id6, g1_.uuid AS uuid7, c2_.name AS name8, c2_.description AS description9, c2_.indicator AS indicator10, c2_.resolution AS resolution11, c2_.cost AS cost12, c2_.id AS id13, c2_.uuid AS uuid14 FROM groups g0_ LEFT JOIN groups_groups g3_ ON g0_.id = g3_.parent_id LEFT JOIN groups g1_ ON g1_.id = g3_.child_id LEFT JOIN groups_channel g4_ ON g0_.id = g4_.group_id LEFT JOIN channels c2_ ON c2_.id = g4_.channel_id WHERE (SELECT COUNT(*) FROM  5_) = 0"
                    ["parameters"]=>
                    array(0) {
                    }
                  }
                }
                ["messages":protected]=>
                array(0) {
                }
                ["started":protected]=>
                NULL
                ["level":protected]=>
                string(1) "1"
                ["created"]=>
                float(1280063214.6367)
              }
            }
          }
          ["_eventManager":protected]=>
          object(Doctrine\Common\EventManager)#14 (1) {
            ["_listeners":"Doctrine\Common\EventManager":private]=>
            array(0) {
            }
          }
          ["_isConnected":"Doctrine\DBAL\Connection":private]=>
          bool(true)
          ["_transactionNestingLevel":"Doctrine\DBAL\Connection":private]=>
          int(0)
          ["_transactionIsolationLevel":"Doctrine\DBAL\Connection":private]=>
          int(2)
          ["_params":"Doctrine\DBAL\Connection":private]=>
          array(5) {
            ["driver"]=>
            string(9) "pdo_mysql"
            ["host"]=>
            string(9) "localhost"
            ["user"]=>
            string(2) "vz"
            ["password"]=>
            string(4) "demo"
            ["dbname"]=>
            string(12) "volkszaehler"
          }
          ["_platform":protected]=>
          object(Doctrine\DBAL\Platforms\MySqlPlatform)#17 (1) {
            ["doctrineTypeMapping":protected]=>
            NULL
          }
          ["_schemaManager":protected]=>
          NULL
          ["_driver":protected]=>
          object(Doctrine\DBAL\Driver\PDOMySql\Driver)#15 (0) {
          }
          ["_isRollbackOnly":"Doctrine\DBAL\Connection":private]=>
          bool(false)
        }
        [1]=>
        array(0) {
        }
        [2]=>
        array(0) {
        }
      }
    }
    [3]=>
    array(6) {
      ["file"]=>
      string(67) "/home/steffen/workspace/doctrine/lib/Doctrine/ORM/AbstractQuery.php"
      ["line"]=>
      int(522)
      ["function"]=>
      string(10) "_doExecute"
      ["class"]=>
      string(18) "Doctrine\ORM\Query"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(0) {
      }
    }
    [4]=>
    array(6) {
      ["file"]=>
      string(67) "/home/steffen/workspace/doctrine/lib/Doctrine/ORM/AbstractQuery.php"
      ["line"]=>
      int(360)
      ["function"]=>
      string(7) "execute"
      ["class"]=>
      string(26) "Doctrine\ORM\AbstractQuery"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(2) {
        [0]=>
        array(0) {
        }
        [1]=>
        int(1)
      }
    }
    [5]=>
    array(6) {
      ["file"]=>
      string(83) "/home/steffen/workspace/volkszaehler.org/backend/lib/Controller/GroupController.php"
      ["line"]=>
      int(57)
      ["function"]=>
      string(9) "getResult"
      ["class"]=>
      string(26) "Doctrine\ORM\AbstractQuery"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(0) {
      }
    }
    [6]=>
    array(6) {
      ["file"]=>
      string(78) "/home/steffen/workspace/volkszaehler.org/backend/lib/Controller/Controller.php"
      ["line"]=>
      int(54)
      ["function"]=>
      string(3) "get"
      ["class"]=>
      string(39) "Volkszaehler\Controller\GroupController"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(0) {
      }
    }
    [7]=>
    array(6) {
      ["file"]=>
      string(67) "/home/steffen/workspace/volkszaehler.org/backend/lib/Dispatcher.php"
      ["line"]=>
      int(149)
      ["function"]=>
      string(3) "run"
      ["class"]=>
      string(34) "Volkszaehler\Controller\Controller"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(1) {
        [0]=>
        string(3) "get"
      }
    }
    [8]=>
    array(6) {
      ["file"]=>
      string(58) "/home/steffen/workspace/volkszaehler.org/backend/index.php"
      ["line"]=>
      int(55)
      ["function"]=>
      string(3) "run"
      ["class"]=>
      string(23) "Volkszaehler\Dispatcher"
      ["type"]=>
      string(2) "->"
      ["args"]=>
      array(0) {
      }
    }
  }
  ["previous":"Exception":private]=>
  NULL
  ["errorInfo"]=>
  array(3) {
    [0]=>
    string(5) "42S02"
    [1]=>
    int(1146)
    [2]=>
    string(37) "Table 'volkszaehler.5_' doesn't exist"
  }
}

Here is my Group Entitiy:

namespace Volkszaehler\Model;

use Doctrine\Common\Collections;

use Doctrine\Common\Collections\ArrayCollection;

/**
 * Group entity
 *
 * @author Steffen Vogel <info@steffenvogel.de>
 * @package default
 *
 * @Entity
 * @Table(name="groups")
 */
class Group extends Entity {
	/** @Column(type="string", nullable=false) */
	protected $name;

	/** @Column(type="string", nullable=true) */
	protected $description;

	/**
	 * @ManyToMany(targetEntity="Channel", inversedBy="groups")
	 * @JoinTable(name="groups_channel",
	 * 		joinColumns={@JoinColumn(name="group_id", referencedColumnName="id")},
	 * 		inverseJoinColumns={@JoinColumn(name="channel_id", referencedColumnName="id")}
	 * )
	 */
	protected $channels = NULL;

	/**
	 * @ManyToMany(targetEntity="Group", inversedBy="parents")
	 * @JoinTable(name="groups_groups",
	 * 		joinColumns={@JoinColumn(name="parent_id", referencedColumnName="id")},
	 * 		inverseJoinColumns={@JoinColumn(name="child_id", referencedColumnName="id")}
	 * )
	 */
	protected $children = NULL;

	/**
	 * @ManyToMany(targetEntity="Group", mappedBy="children")
	 */
	protected $parents = NULL;

	/**
	 * construct
	 */
	public function __construct() {
		parent::__construct();

		$this->channels = new ArrayCollection();
		$this->children = new ArrayCollection();
		$this->parents = new ArrayCollection();
	}

	/**
	 * adds group as new child
	 *
	 * @param Group $child
	 * @todo check against endless recursion
	 * @todo check if the group is already member of the group
	 */
	public function addGroup(Group $child) {
		$this->children->add($child);
	}

	/**
	 * adds channel as new child
	 *
	 * @param Channel $child
	 * @todo check if the channel is already member of the group
	 */
	public function addChannel(Channel $child) {
		$this->channels->add($child);
	}

	/**
	 * getter & setter
	 */
	public function getName() { return $this->name; }
	public function setName($name) { $this->name = $name; }
	public function getDescription() { return $this->description; }
	public function setDescription($description) { $this->description = $description; }
	public function getChildren() { return $this->children; }
	public function getParents() { return $this->parents; }
	public function getChannels() { return $this->channels; }
}

[DDC-716] Proxy autogeneration fails with concurrent requests

Sat, 24 Jul 2010 06:23:09 +0000

When doing concurrent requests with autogeneration of proxies enabled, the proxy file does not exist when ProxyFactory tries to use it:

Doctrine/ORM/Proxy/ProxyFactory.php(92): spl_autoload_call('MyClassProxy'))

I think this is because file_put_contents is not atomic.

[DDC-714] Fix of DDC-167 creates FatalError when persisting a new entity

Sun, 25 Jul 2010 10:35:58 +0000

The resolution of ~~DDC-167~~ introduced a new problem in UnitOfWork on line 612 (function persistNew()) as well - when I try to save an entity, I get an Exception from my error handler (who captues php errors):

ErrorException with Argument 2 passed to Doctrine\ORM\Mapping\ClassMetadata::setIdentifierValues() must be an array, integer given, called in /var/www/svn/cWorld_ZF/branches/devel-trunk/library/Doctrine/ORM/UnitOfWork.php on line 612 and defined
Backtrace: #0: Doctrine\ORM\Mapping\ClassMetadata->setIdentifierValues at /var/www/svn/cWorld_ZF/branches/devel-trunk/library/Doctrine/ORM/UnitOfWork.php:612
#1: Doctrine\ORM\UnitOfWork->persistNew at /var/www/svn/cWorld_ZF/branches/devel-trunk/library/Doctrine/ORM/UnitOfWork.php:1247
#2: Doctrine\ORM\UnitOfWork->doPersist at /var/www/svn/cWorld_ZF/branches/devel-trunk/library/Doctrine/ORM/UnitOfWork.php:1210
#3: Doctrine\ORM\UnitOfWork->persist at /var/www/svn/cWorld_ZF/branches/devel-trunk/library/Doctrine/ORM/EntityManager.php:438

The relevant code in UoW is:

            $idValue = $idGen->generate($this->em, $entity);
            if ( ! $idGen instanceof \Doctrine\ORM\Id\AssignedGenerator) {
                $this->entityIdentifiers[$oid] = array($class->identifier[0] => $idValue);
                $class->setIdentifierValues($entity, $idValue);

We're using the SequenceGenerator

@SequenceGenerator(allocationSize=1,sequenceName="address_id_seq")

which doesn't return an array, so the array typehint fails and generates an error.

The fix, which worked for me, is attached.

[DDC-710] DecimalType - NULL in database should be NULL not 0

Wed, 21 Jul 2010 15:44:39 +0000

DecimalType::convertToPHPValue should return NULL if the value in the database is NULL. This is similar to the issue with IntegerType that was fixed with #~~DDC-571~~.

The fix would be to replace

return (double) $value;

with

return is_null($value) ? null : (double) $value;

[DDC-706] DriverChain::isTransient should return false not throw exception

Wed, 21 Jul 2010 15:23:46 +0000

The isTransient() method has to return false, not throw an exception if the given class is not an entity or mapped superclass. The current behaviour violates the Mapping\Driver contract.

[DDC-697] Support for DateTime in query parameters

Wed, 21 Jul 2010 17:17:22 +0000

Supports native DateTime in query parameters. (for more universal using)

Column definition

/**
 * @var DateTime
 *
 * @Column(type="datetime")
 */
private $published;

Query

$qb = $em->getRepository('Entities\Foo')->createQueryBuilder('f');
$qb->where("f.published <= ?1");
$qb->setParameter(1, new \DateTime('2012-12-21 23:59:59'));

Now display "Object of class DateTime could not be converted to string" error

[DDC-693] NULL values from Postgres boolean columns are loaded as FALSE instead of NULL

Wed, 21 Jul 2010 15:44:23 +0000

I have column in PostgreSQL defined as "BOOLEAN NULL". If I store NULL value to database and then load it back, I get FALSE instead of NULL.

Example entity and test attached.

I am not sure if this issue applies to ORM or DBAL, so posting here.

[DDC-681] PATCH: UnitOfWork#lock locks by column names instead of field names

Reference — Sat, 10 Jul 2010 17:58:05 +0000

On line 1700 of UnitOfWork#lock column names are used instead of field names, I think the line should read:

array_combine($class->getIdentifierFieldNames(), $this->entityIdentifiers[$oid]),

A related question: when I load an instance by relation, e.g. $author = $book->getAuthor(), I cannot specify a lock type at that point, so I have to call $em->lock($author, LockType::PESSIMISTIC_WRITE) afterwards, which results in two database queries for the same record. Is it possible to do this at once, without setting a transaction isolation level?

[DDC-669] order of fields in sql query and parameters to be bound to the dbal's statement is different

Mon, 5 Jul 2010 10:12:25 +0000

Hi guys,

It seems that I found a bug in the Doctrine\ORM\Persisters\BasicEntityPersister. Let me explain.

Put it simply, I have the following entity:

Foo.php

/**
 * @Entity
 */
class Foo
{
    /**
     * @Id
     * @Column(type="integer")
     * @GeneratedValue(strategy="AUTO")
     */
    private $id;
    /**
     * @ManyToOne(targetEntity="Foo", inversedBy="children")
     * @JoinColumn(name="parent_id", referencedColumnName="id")
     */
    private $parent;
    /**
     * @OneToMany(targetEntity="Foo", mappedBy="parent")
     */
    private $children;
    /**
     * @Column(type="integer", nullable=false)
     */
    private $verticalOrder;

    // a bunch of getters/setters

As you can see, there's a mandatory field called "verticalOrder", it is not intended to be managed manually but rather with a listener attached to onFlush event. ( In that listener, after a value for the verticalOrder is set, the uow::recomputeSingleEntityChangeSet() method is invoked, as it was suggested in documentation ).

The thing is that when I persist an instance of this class and then invoke flush ( without providing a value for it, the verticalOrder ), Doctrine dies silently, with no exception being thrown. The easy fix can be done with adding this piece of source code to the BasicEntityPersister on line 218:

Dumb fix

if (!$stmt->execute()) {
    throw new \Exception('Unable to execute query: '.var_export($stmt->errorInfo(), true));
}

That was the first problem I have faced with while trying to find out why my entity is not persisted. After I have delved a bit deeper, I found out
that the problem lies in BasicEntityPersister ::_getInsertColumnList() or in BasicEntityPersister ::_prepareUpdateData(). The thing is that order of columns in the SQL query generated by the BasicEntityPersister::_getInsertColumnList() and values to be bound to the statement and after executed is different. Line 214 in BasicEntityPersister is meant here.

In my case it was reversed, instead of parent_id, a value for verticalOrder was inserted and vice versa.

Array of parameters to be bound to the Doctrine\DBAL\Statement:

Array
(
    [verticalOrder] => 1278334736 // at the moment timestamp is used rather than MAX from the table
    [parent_id] => 
)

And the query that will be executed:

INSERT INTO Foo(parent_id, verticalOrder) VALUES (?, ?)

These snippets clearly illustrate the point.

I hope I was clear in my explanations.

I will try to devote some spare time and write tests to lock this issue, but i'm not able to say at the moment when it happens.

All the best,
Sergei Lissovski

[DDC-662] Missing default value for attribute 'AutoGenerateProxyClasses'

Thu, 1 Jul 2010 18:36:44 +0000

When not setting the attribute 'AutoGenerateProxyClasses' and running orm:ensure-production-settings an exception is thrown:

Notice: Undefined index: autoGenerateProxyClasses in Doctrine/ORM/lib/Doctrine/ORM/Configuration.php on line 332

There should be a default value set or a notice that this attribute is mandatory.

[DDC-660] quoting not-in-values

Thu, 1 Jul 2010 15:43:08 +0000

There seems to be a bug in ORM/Query/expr.php method notIn. All literals should be quoted like:

    /**
     * Creates a NOT IN() expression with the given arguments.
     *
     * @param string $x Field in string format to be restricted by NOT IN() function
     * @param mixed $y Argument to be used in NOT IN() function.
     * @return Expr\Func
     */
    public function notIn($x, $y)
    {
        if (is_array($y)) {
            foreach ($y as &$literal) { 
                if ( ! ($literal instanceof Expr\Literal)) { 
                    $literal = $this->_quoteLiteral($literal);
                }
            }
        }
        return new Expr\Func($x . ' NOT IN', (array) $y);
    }

[DDC-656] UnitOfWork::recomputeSingleEntityChangeSet does not preserve field order

Sun, 4 Jul 2010 02:55:22 +0000

XML

<?xml version="1.0" encoding="utf-8"?>
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping" xsi="http://www.w3.org/2001/XMLSchema-instance" schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd">
    <entity name="Entities\Specification" table="specification">
        <field name="name" type="string" column="name" length="255"/>
        <field name="type" type="string" column="type"/>
        <id name="specificationId" type="integer" column="specification_id">
            <generator strategy="AUTO"/>
        </id>
    </entity>
</doctrine-mapping>

Code

$spec = new \Entities\Specification();
$spec->setName('test1');
$spec->setType('type1');
$em->persist($spec);
$em->getUnitOfWork()->computeChangeSet($em->getClassMetadata(get_class($spec)), $spec);
$data1 = $em->getUnitOfWork()->getEntityChangeset($spec);
$spec->setType('type2');
$em->getUnitOfWork()->recomputeSingleEntityChangeSet($em->getClassMetadata(get_class($spec)), $spec);
$data2 = $em->getUnitOfWork()->getEntityChangeset($spec);
// data1 contains keys in correct order: name, type
var_dump($data1);
// data2 contains keys in reverse order: type, name
var_dump($data2);

I got this issue when was trying to change entity properties using onFlush event

[DDC-649] SQL Error with single table inheritance and findAll method

Sun, 4 Jul 2010 07:46:56 +0000

When selecting all objects of SecondClass and ThirdClass which both inherit from FirstClass with the following code :

$em->getRepository('FirstClass')->findAll();

Postgresql is throwing the following error :
Invalid text representation: 7 ERROR: invalid input syntax for integer: "" LINE 1: ...er_stuff3 FROM "first_class" t0 WHERE t0.type IN ('', '1', '...

I think it's because of the empty string after the IN clause.

There is the fail test case :

Classes :

class FirstClass {

  private $id;
  private $type;
}

class SecondClass extends FirstClass {
  private $otherStuff;
}

class ThirdClass extends FirstClass {
  private $otherStuff;
}

Mapping :

<?xml version="1.0" encoding="UTF-8"?>
  <doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd">

  <entity name="FirstClass" table='"first_class"' inheritance-type="SINGLE_TABLE">
    <id name="id" type="integer" column="id">
      <generator strategy="SEQUENCE"/>
      <sequence-generator sequence-name="first_class_id_seq" allocation-size="1" initial-value="1"/>
    </id>

    <discriminator-column name="type" type="integer" field-name="type" />

    <discriminator-map>
      <discriminator-mapping value="1" class="ThirdClass" />
      <discriminator-mapping value="2" class="SecondClass" />
    </discriminator-map>
  </entity>
  </doctrine-mapping>

<?xml version="1.0" encoding="UTF-8"?>
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd">

  <entity name="SecondClass">
    <field name="otherStuff" column="other_stuff" type="string" />
  </entity>
</doctrine-mapping>

<?xml version="1.0" encoding="UTF-8"?>
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd">

  <entity name="ThirdClass">
    <field name="otherStuff" column="other_stuff" type="string" />
  </entity>
</doctrine-mapping>

The SQL :

CREATE TABLE first_class
(
  id serial NOT NULL,
  "type" integer,
  other_stuff character varying,
  CONSTRAINT first_class_pkey PRIMARY KEY (id)
)
WITH (
  OIDS=FALSE
);

The fail test :

require_once 'class/FirstClass.php';
require_once 'class/SecondClass.php';
require_once 'class/ThirdClass.php';

$entities = $doctrineEntityManager->getRepository('FirstClass')->findAll();

[DDC-647] string length not taken into account on id while using Yaml driver

Mon, 28 Jun 2010 17:08:35 +0000

The string lenght specified in the Yaml file is not respected on id columns.

Sample YAML file

---
# Entities.Stock.dcm.yml
Entities\Stock:
  type: entity
  table: stocks
  id:
    id:
      type: string
      length: 10
      generator:
        strategy: NONE
  fields:
    nature:
      type: string
      length: 10
    name:
      type: string
      length: 40
    creationDate:
      name: creation_date
      type: datetime
    owner:
      type: string
      length: 8

Command used to generate the SQL statements:
./doctrine orm:schema-tool:create --dump-sql

Result:

CREATE TABLE stocks (id VARCHAR(255) NOT NULL, nature VARCHAR(12) NOT
NULL, name VARCHAR(40) NOT NULL, creationDate DATETIME NOT NULL, owner
VARCHAR(8) NOT NULL, PRIMARY KEY(id)) ENGINE = InnoDB

The "id" is generated as VARCHAR(255) instead of VARCHAR(10).

[DDC-646] Missing inclusion of namespace

Sat, 19 Jun 2010 18:28:51 +0000

ORM\Tools\Console\Command\ConvertDoctrine1SchemaCommand.php requires that you include the following namespace

Doctrine\ORM\Tools\EntityGenerator,

else the following error is thrown

PHP Warning:  require(Doctrine/ORM/Tools/Console/Command/EntityGenerator.php): failed to open stream: No such file or directory in /usr/local/zend/share/pear/Doctrine/Common/ClassLoader.php on line 148
PHP Fatal error:  require(): Failed opening required 'Doctrine/ORM/Tools/Console/Command/EntityGenerator.php' (include_path='/Users/antoine/Sites/startaeget-3.3/application/library:.:/usr/local/zend/share/ZendFramework/library:/usr/local/zend/share/pear') in /usr/local/zend/share/pear/Doctrine/Common/ClassLoader.php on line 148

[DDC-644] [ORACLE] setting query maxResults together with firstResult leads to an error

Wed, 28 Jul 2010 15:53:00 +0000

I'm not very skilled in doctrine yet, but I found something that might be worth reporting.

The code below produces "Class does not exist" error, which is quite misleading and just a side effect of a Notice that shows up in AbstractHydrator.php (lines 190 and 191).

		$q = DBConnection::Common()->createQueryBuilder()->select('c')->from('COMPANY', 'c')->getQuery();
		$q->setMaxResults(15);
		$q->setFirstResult(1);
		var_dump($query->getResult());

The query becomes:

SELECT b.* FROM (SELECT a.*, ROWNUM AS doctrine_rownum FROM (SELECT c0_.ID_COMPANY AS ID_COMPANY0, c0_.CONTACT AS CONTACT1, c0_.CONTRACT AS CONTRACT2, c0_.DESCRIPTION AS DESCRIPTION3, c0_.ID_DISPLAY_CASE AS ID_DISPLAY_CASE4, c0_.MAX_OPEN_WIN AS MAX_OPEN_WIN5, c0_.NAME AS NAME6, c0_.REFRESH_TIME AS REFRESH_TIME7, c0_.STATUS AS STATUS8, c0_.TABLESPACE AS TABLESPACE9 FROM COMPANY c0_) a ) b WHERE doctrine_rownum BETWEEN 2 AND 16

The problem occurs when iterating over the list of internal column aliases (ID_COMPANY0,DESCRIPTION3,ID_DISPLAY_CASE4,MAX_OPEN_WIN5,NAME6,REFRESH_TIME7,STATUS8,TABLESPACE9 and
DOCTRINE_ROWNUM). The last one "DOCTRINE_ROWNUM" is missing in both $this->_rsm->metaMappings and $this->_rsm->columnOwnerMap and it's not a matter of case sensitivity, it's missing completely.

Result:

$cache[$key]['dqlAlias'] becomes NULL
$rowData[$dqlAlias][$cache[$key]['fieldName']] = $value;

(line 203) creates a new key (named as empty string) in $rowData and things get screwed up since then in further iterations over $rowData array.

Unfortunately I'm not familiar with the internal code of doctrine at all, and it seems too complex for me to be able to provide a fix (except for an ugly hack).

I've attached the Exception trace (might help).

BTW: Doctrine 2 is the cleanest piece of complex code I've ever seen. You guys rock !!!

[DDC-642] Conversion from annotation to xml mapping doesn't equal (missing inversedBy)

Wed, 16 Jun 2010 11:52:04 +0000

Hi,

I've converted schema from annotations to XML, but after the conversion the association is missing inversedBy parameter:

public $text;
/**
 * @ManyToOne(targetEntity="CmsUser", inversedBy="articles")
 * @JoinColumn(name="user_id", referencedColumnName="id")
*/

converted XML is missing inversedBy attribute:

<many-to-one field="user" target-entity="CmsUser" orphan-removal="">
  <join-columns>
    <join-column name="user_id" referenced-column-name="id" nullable="1"/>
  </join-columns>
</many-to-one>

Thank you.

[DDC-641] Conversion from annotation to xml mapping not matching XML schema (Cascade persist)

Wed, 16 Jun 2010 11:21:04 +0000

Hi,

I'm converting schema from annotations to XML, but the result doesn't match XML schema:

/**
 * @ManyToMany(targetEntity="ECommerceProduct", cascade={"persist"})
 * @JoinTable(name="ecommerce_carts_products",
        joinColumns={@JoinColumn(name="cart_id", referencedColumnName="id")},
        inverseJoinColumns={@JoinColumn(name="product_id", referencedColumnName="id")})
*/

gets converted to:

<many-to-many field="related" target-entity="ECommerceProduct" inversed-by="par-relates">
....
          <cascade>
            <persist/>
          </cascade>
.....

but the XML schema allows only:

<xs:complexType name="cascade-type">
  <xs:sequence>
    <xs:element name="cascade-all" type="orm:emptyType" minOccurs="0"/> 
    <xs:element name="cascade-persist" type="orm:emptyType" minOccurs="0"/> 
    <xs:element name="cascade-merge" type="orm:emptyType" minOccurs="0"/> 
    <xs:element name="cascade-remove" type="orm:emptyType" minOccurs="0"/> 
    <xs:element name="cascade-refresh" type="orm:emptyType" minOccurs="0"/> 
  </xs:sequence>
</xs:complexType>

Thank you.

[DDC-634] Merging an entity with a single valued association that has been set to null has no effect

Fri, 30 Jul 2010 11:59:48 +0000

When merging an owning entity which has NULL as one of its associated properties, merge doesn't realize that it needs to disassociate the entity.

class Doctor {
	
    /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
    public $id;
	
	/**
     * @OneToMany(targetEntity="Patient", mappedBy="doctor", fetch="EAGER")
     */
	public $patients;
	
	public function __construct() {
		$this->patients = new ArrayCollection();
	}
	
}

class Patient {
	
    /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
    public $id;

	/**
     * @OneToOne(targetEntity="Doctor", inversedBy="patients")
	 * @JoinColumn(name="doctor_id", referencedColumnName="id")
     */
	public $doctor;
	
	public function __construct() {
	}
	
}

Assume that in the database there exists a doctor id=1 and a patient id=1. The patient belongs to the doctor, so the patient table has doctor_id = 1;

$p1 = new \vo\Patient();
$p1->id = 1;
$p1->doctor = null;
$em->merge($p1);
$em->flush();

This does not set doctor_id to null as expected.

It can be fixed by changing the block at line 1373 in UnitOfWork.php as follow. Apologies for not providing a patch file, I haven't quite got the hang of git yet

                           if ($other !== null) {
                                $targetClass = $this->_em->getClassMetadata($assoc2->targetEntityName);
                                $id = $targetClass->getIdentifierValues($other);
                                $proxy = $this->_em->getProxyFactory()->getProxy($assoc2->targetEntityName, $id);
                                $prop->setValue($managedCopy, $proxy);
                                $this->registerManaged($proxy, $id, array());
                            } else {
								$prop->setValue($managedCopy, null);
			   }

[DDC-627] Unexpected Duplicate Field Mapping Exception

Reference — Thu, 2 Jun 2011 19:55:08 +0000

Trying to generate entities with annotation mappings using the CLI orm:convert-mapping command will throw an exception.

– Schema to reproduce
CREATE DATABASE IF NOT EXISTS `doctrine_issue`;
USE `doctrine_issue`;
CREATE TABLE `activity` (
`idact` int(10) unsigned NOT NULL AUTO_INCREMENT,
PRIMARY KEY (`idact`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
CREATE TABLE `activity_log` (
`idacl` int(10) unsigned NOT NULL AUTO_INCREMENT,
`idact` int(10) unsigned NOT NULL,
PRIMARY KEY (`idacl`),
CONSTRAINT `fk_activity_data_activity` FOREIGN KEY (`idact`) REFERENCES `activity` (`idact`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

// configure a simple doctrine.php file to connect and run the following CLI command:
C:\>php doctrine.php orm:convert-mapping --from-database annotation .\Entities

Will throw an MappingException::duplicateFieldMapping on ActivityLog::idact, at line 1064 of class Doctrine\ORM\Mapping\ClassMetadataInfo

[DDC-625] orm:schema-tool:update --dump-sql showing SQL when DB is up-to-date

Fri, 9 Jul 2010 17:36:32 +0000

With the following entities ...

<?php

/**
 * @Entity
 * @Table(name="users")
 */
class App_Model_User
{
    /**
     * @Id
     * @GeneratedValue(strategy="IDENTITY")
     * @Column(type="integer")
     */
    private $id;

    /**
     * @ManyToOne(targetEntity="App_Model_Role")
     * @JoinColumn(name="role_id", nullable=false)
     */
    private $role;

    /** @Column(type="string", columnDefinition="CHAR(64) NOT NULL") */
    private $password;
}

<?php

/**
 * @Entity
 * @Table(name="roles")
 */
class App_Model_Role
{
    /**
     * @Id
     * @GeneratedValue(strategy="IDENTITY")
     * @Column(type="smallint")
     */
    private $id;
}

I'm getting this output from orm:schema-tool:update --dump-sql, when the database is already up-to-date:

ALTER TABLE users CHANGE password password CHAR(64) NOT NULL;
ALTER TABLE users DROP FOREIGN KEY users_ibfk_1;
ALTER TABLE users ADD FOREIGN KEY (role_id) REFERENCES roles(id)

[DDC-620] Add support to multiple FROM clauses

Duplicate — Tue, 20 Jul 2010 11:27:17 +0000

We support multiple FROM in EBNF, and also in Hydrators.
But it still misses the support of SqlWalker. We need to support that

[DDC-618] INDEX BY not working

Mon, 28 Jun 2010 18:07:08 +0000

It looks like INDEX BY does not work from DQL queries.
Haven't tested it when using query builder.

[DDC-616] Reverse engineering with Oracle

Reference — Sun, 20 Jun 2010 13:35:02 +0000

I am playing with reverse engineering with Oracle and I have some problems:

My schema:

create table TABLE_TEST1 (
   TEST1_FIRST_COLUMN      NUMBER(4)                       not null,
   TEST1_SECOND_COLUMN     VARCHAR2(50)                    not null,
   TEST1_THIRD_COLUMN      DATE,
   constraint PK_TABLE_TEST1 primary key (TEST1_FIRST_COLUMN)
         using index
       tablespace TBS_INDEX
       storage
       (
           initial 100K
           next 100K
       )
)
storage
(
    initial 100K
    next 100K
)
tablespace TBS_DATA;

create table TABLE_TEST2 (
   TEST2_FIRST_COLUMN      NUMBER(4)                       not null,
   TEST2_SECOND_COLUMN     VARCHAR2(50)                    not null,
   TEST2_THIRD_COLUMN      DATE,
   TEST1_FIRST_COLUMN      NUMBER(4)                       not null,
   constraint PK_TABLE_TEST2 primary key (TEST2_FIRST_COLUMN)
         using index
       tablespace TBS_INDEX
       storage
       (
           initial 100K
           next 100K
       )
)
storage
(
    initial 100K
    next 100K
)
tablespace TBS_DATA;

alter table TABLE_TEST2
   add constraint TABLE_TEST2__TABLE_TEST1 foreign key (TEST1_FIRST_COLUMN)
      references TABLE_TEST1 (TEST1_FIRST_COLUMN);

My reverse engineering code:

ini_set('display_errors', 1);
set_include_path(realpath(__DIR__ . '/../doctrine-orm/lib/'));

require 'Doctrine/Common/ClassLoader.php';
$classLoader = new \Doctrine\Common\ClassLoader('Doctrine', realpath(__DIR__ . '/../doctrine-orm/lib/'));
$classLoader->register();

$config = new \Doctrine\ORM\Configuration;
$cache = new \Doctrine\Common\Cache\ApcCache;
$config->setMetadataCacheImpl($cache);
$driverImpl = $config->newDefaultAnnotationDriver(realpath(__DIR__. '/Infofab/Entities'));
$config->setMetadataDriverImpl($driverImpl);
$config->setQueryCacheImpl($cache);
$config->setProxyDir('Proxies');
$config->setProxyNamespace('Infofab');
$connectionOptions = array(
    'dbname' => 'bddmkk',
    'user' => 'doctrine',
    'password' => 'xxxxxxx',
    'host' => 'localhost',
    'driver' => 'pdo_oci',
    'driverOptions' => array(PDO::ATTR_CASE => PDO::CASE_LOWER)
);

$em = \Doctrine\ORM\EntityManager::create($connectionOptions, $config);

$sm = $em->getConnection()->getSchemaManager();

$em->getConfiguration()->setMetadataDriverImpl(
    new \Doctrine\ORM\Mapping\Driver\DatabaseDriver(
        $em->getConnection()->getSchemaManager()
    )
);

$cmf = new \Doctrine\ORM\Tools\DisconnectedClassMetadataFactory($em);
$metadata = $cmf->getAllMetadata();

$cme = new \Doctrine\ORM\Tools\Export\ClassMetadataExporter();
$exporter = $cme->getExporter('annotation', 'Infofab');
$exporter->setMetadata($metadata);
$etg = new \Doctrine\ORM\Tools\EntityGenerator;
$exporter->setEntityGenerator($etg);
$exporter->export();

If I run this code, I obtain 2 entities:

<?php
/**
 * TableTest1
 *
 * @Table(name="TABLE_TEST1")
 * @Entity
 */
class TableTest1
{
    /**
     * @var integer $test1FirstColumn
     *
     * @Column(name="TEST1_FIRST_COLUMN", type="integer", nullable=false)
     * @Id
     * @GeneratedValue(strategy="SEQUENCE")
     * @SequenceGenerator(sequenceName="TABLE_TEST1_TEST1_FIRST_COLUMN", allocationSize="10", initialValue="1")
     */
    private $test1FirstColumn;

    /**
     * @var string $test1SecondColumn
     *
     * @Column(name="TEST1_SECOND_COLUMN", type="string", length=50, nullable=false)
     */
    private $test1SecondColumn;

    /**
     * @var datetime $test1ThirdColumn
     *
     * @Column(name="TEST1_THIRD_COLUMN", type="datetime", nullable=true)
     */
    private $test1ThirdColumn;
}

and

<?php
/**
 * TableTest2
 *
 * @Table(name="TABLE_TEST2")
 * @Entity
 */
class TableTest2
{
    /**
     * @var integer $test2FirstColumn
     *
     * @Column(name="TEST2_FIRST_COLUMN", type="integer", nullable=false)
     * @Id
     * @GeneratedValue(strategy="SEQUENCE")
     * @SequenceGenerator(sequenceName="TABLE_TEST2_TEST2_FIRST_COLUMN", allocationSize="10", initialValue="1")
     */
    private $test2FirstColumn;

    /**
     * @var integer $test1FirstColumn
     *
     * @Column(name="TEST1_FIRST_COLUMN", type="integer", nullable=false)
     */
    private $test1FirstColumn;

    /**
     * @var string $test2SecondColumn
     *
     * @Column(name="TEST2_SECOND_COLUMN", type="string", length=50, nullable=false)
     */
    private $test2SecondColumn;

    /**
     * @var datetime $test2ThirdColumn
     *
     * @Column(name="TEST2_THIRD_COLUMN", type="datetime", nullable=true)
     */
    private $test2ThirdColumn;

    /**
     * @var TABLETEST1
     *
     * @OneToOne(targetEntity="TABLETEST1")
     * @JoinColumns({
     *   @JoinColumn(name="TEST1_FIRST_COLUMN", referencedColumnName="TEST1_FIRST_COLUMN")
     * })
     */
    private $tEST1FIRSTCOLUMN;
}

As you can see, it declares 2 times the same column: private $test1FirstColumn; and private $tEST1FIRSTCOLUMN;

[DDC-614] Multiple Entities in FROM clause throws exception

Duplicate — Tue, 20 Jul 2010 00:11:32 +0000

When I query,

SELECT k, d FROM OneMind\Domain\Sales\Kendaraan k, OneMind\Domain\Sales\DeliveryOrder d

it raises exception:

SQLSTATE[42P01]: Undefined table: 7 ERROR: missing FROM-clause entry for table "d1_" 
LINE 1: ...gan AS pelanggan8, k0_.keterangan AS keterangan9, d1_.id AS ... ^

then I try to var_dump the sql:

SELECT k0_.id AS id0, k0_.tipe_kendaraan AS tipe_kendaraan1, k0_.warna AS warna2, k0_.no_rangka AS no_rangka3,
 k0_.no_mesin AS no_mesin4, k0_.tahun AS tahun5, k0_.rrn AS rrn6, k0_.salesman AS salesman7, k0_.pelanggan AS 
pelanggan8, k0_.keterangan AS keterangan9, d1_.id AS id10, d1_.nomor AS nomor11, d1_.tanggal AS tanggal12, 
d1_.kode_supplier AS kode_supplier13, d1_.tipe_kendaraan AS tipe_kendaraan14, d1_.warna AS warna15, 
d1_.no_rangka AS no_rangka16, d1_.no_mesin AS no_mesin17, d1_.tahun AS tahun18, d1_.harga_beli AS harga_beli19, 
d1_.no_sap AS no_sap20, d1_.tgl_sap AS tgl_sap21, d1_.dpp AS dpp22, d1_.ppn_masuk AS ppn_masuk23, d1_.bunga 
AS bunga24, d1_.jatuh_tempo AS jatuh_tempo25, d1_.rrn AS rrn26 FROM kendaraan k0_

Only the first entity appears in SQL FROM clause. The second one is missing. It is likely affect JOIN as well.

[DDC-613] QueryBuilder doesn't permit any functions in select()

Wed, 16 Jun 2010 11:55:54 +0000

Example:

        $expr = $qb->expr();
        $qb->select($expr->count('e.id'));

Result:

InvalidArgumentException: Expression of type 'Doctrine\ORM\Query\Expr\Func' not allowed in this context.

[DDC-611] Clearing APC cache is broken

Mon, 28 Jun 2010 17:36:28 +0000

When running ./doctrine orm:clear-cache with the APC cache, it simply won't work because the cache is not shared between the different PHP processes.

So, the php instance run by ./doctrine and the one run by apache are different and won't share their cache. This is an APC feature.

A workaround is needed, other than calling it via apache, or simply remove it. And write it in the documentation.

[DDC-600] Persisting Entities with unmanaged related associations produces ugly notices

Reference — Sat, 24 Jul 2010 03:58:13 +0000

It often happens that you forget to persist related entities during development, producing ugly notices about $object hash not being part of certain arrays, for example in "getEntityIdentifier".

Maybe this can be gracefully intercepted without cluttering the code?

[DDC-596] Add @DiscriminatorMap validation to orm:validate-schema

Sat, 10 Jul 2010 03:13:23 +0000

Assuming that all child classes of an @InheritanceType("SINGLE_TABLE") and @InheritanceType("JOINED") table should be defined in the topmost parent's @DiscriminatorMap, it would be very helpful to add this validation to the CLI orm:valdiate-schema.

At present, if a child table is defined in the topmost table @DiscriminatorMap on a SINGLE_TABLE inheritance, then orm:validate-schema states that the mapping files are correct but then a Doctrine\DBAL\Schema\SchemaException is thrown. The same exception is also thrown for other schema-tool commands (such as 'create').

Haven't tested what happens on a JOINED table..

/**
 * @Entity @InheritanceType("SINGLE_TABLE")
 * @DiscriminatorColumn(name="discr", type="string")
 * @DiscriminatorMap({"employee" = "Employee"})   // note, the second child table was accidentally omitted here
 */
class Person
{
    // ...
}

/**
 * @Entity
 */
class Employee extends Person
{
    // ...
}

/**
 * @Entity
 */
class Customer extends Person
{
    // ....
}

Schema tool commands (create, validate-schema) then throw:

  [Doctrine\DBAL\Schema\SchemaException]
  The table with name 'person' already exists.

... and orm:validate-schema actually says that the mapping is correct (which it obviously isn't) before throwing the exception:

[Mapping]  OK - The mapping files are correct.

  [Doctrine\DBAL\Schema\SchemaException]
  The table with name 'person' already exists.

Not critical since the mapping is obviously wrong here, but having this extra check in the validator could save a lot of debugging time. A duplicate table name error is confusing in this situation, and it seems wrong that the validate-schema command presently reports that the mapping files are correct when in fact the inheritance is broken.

[DDC-591] Support Pessimistic Locks for Entities with a JoinedSubclassPersister

Sun, 4 Jul 2010 08:38:21 +0000

Support Pessimistic Locks for Entities with a JoinedSubclassPersister

[DDC-577] Change default allocationSize from 10 to 1

Thu, 12 Aug 2010 00:09:19 +0000

I propose to change the default value of allocationSize for sequence columns from current 10 to 1. It's defined in $definition['allocationSize'] in Doctrine/ORM/Mapping/ClassMetaFactory.php.

The improvement request is based on detailed discussion on http://www.doctrine-project.org/jira/browse/DDC-569?focusedCommentId=12855&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12855

Current default value for allocationSize=10 is CONFUSING and I am sure it will cause problems and misunderstoods for many people in future.

The core of the problem is that lot of people define table structure manually, separately from entity annotations. And while the default allocationSize is 10, they have to remember (and they have to know they should remember) each time they write new table and new entity, that:

a) They have to define each the sequence in database manually with INCREMENT BY 10
b) OR they have to define in each entity manually the annotation for @SequenceGenerator - allocationSize=1
c) OR they have to manually use strategy="IDENTITY", but it's primarily related to primary keys, not to all sequences at general.

Shortly, in an intuitive way everybody assumes the behaviour as allocationSize would be 1. Current default value 10 is not in accord with this intuitive perception and will cause many questions and misunderstoods.

The "preloading" of 10 values at once is a kind of "advanced optimalization" - it's great it is available and implemented - but it should not be applied automatically, but only after explicit setup.

[DDC-575] Ignoring some annotations

Fri, 9 Jul 2010 17:15:56 +0000

Some placement of handler annotation is ignored.

PrePersist is ignored:

/**
 * @PrePersist
 *
 * Will trigger error.
 */
public function error()
{
	trigger_error('ERROR');
}

PrePersist works fine:

/**
 * @PrePersist
 * @foo
 *
 * Will trigger error.
 */
public function error()
{
	trigger_error('ERROR');
}

[DDC-555] @ManyToMany - curious behaviour - assigned values toggle

Sat, 3 Jul 2010 13:40:34 +0000

BUG:
the entries in M:N table article_categories toggle

SOLUTION:
extra flush entry at [*]

Code:
—

$article = $em->find('Entity\Blog\Article', 1);

printf("-- %s\n", count($article->getCategories()));

$article->getCategories()->clear();
//$em->flush(); // [*]

foreach(array(4) as $id)$article->getCategories()->add(
            $em->getReference('Entity\Blog\Category', $id)
        );

$em->flush();

===

Entities:

class Article
{
/**
     * @ManyToMany(targetEntity="Entity\Blog\Category", inversedBy="articles")
     * @JoinTable(name="article_category",
     *             joinColumns={@JoinColumn(name="fk_article",  referencedColumnName="pk")},
     *      inverseJoinColumns={@JoinColumn(name="fk_category", referencedColumnName="pk")}
     * )
     */
    private $categories;
}

class Category
{
    /**
     * @ManyToMany(targetEntity="Entity\Blog\Article", mappedBy="categories")
     */
    private $articles;
}

tried to apply cascade=

{"all"}

, but has no effect.

[DDC-544] Extract Interface on Doctrine\ORM\Repository

Tue, 9 Apr 2013 18:57:24 +0000

There should be an interface composed of all the methods on the Repository, so that in userland you can do something like:

interface IMyRepository extends Doctrine\ORM\IEntityRepository
{

}

class MyRepository extends Doctrine\ORM\EntityRepository implements IMyRepository
{

}

That way in your code you could type-hint for IMyRepository, or for the EntityRepository Interface even and it would be indefinately easier to mock or replace the implementation.

[DDC-518] Merging an entity with a one to one association to a MANAGED entity with no id throws 'The given entity has no identity.'

Fri, 30 Jul 2010 12:01:46 +0000

Calling merge($entity) where $entity has a one to one association to another entity that has been persisted but not yet flushed (when using auto-generated ids) throws 'The given entity has no identity.'

It looks like it does this because _doMerge in UnitOfWork assumes for one to one associations only that the associated entity has an id and calls registerManaged, which then calls addToIdentityMap)on it.

I think that registeredManaged should only be called if !isset($this->_entityInsertions[spl_object_hash($other)])

Reproduce.php

// This is a new element
$doctor = new \vo\Doctor(); $d1->name = "New doctor";

// This is a detached element which is in the database
$patient = new \vo\Patient(); $p1->name = "Existing patient"; $p1->id = 1;

$doctor->patients->add($patient);
$patient ->doctor = $doctor;

$em->persist($doctor);

// This throws InvalidArgumentException: The given entity has no identity. in D:\Projects\ORM\flextrine2\flextrine\web\lib\Doctrine\ORM\UnitOfWork.php on line 1014
$em->merge($patient);

Doctor.php

class Doctor {

    /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
    public $id;
	
    /** @Column(length=100, type="string") */
    public $name;
	
	/**
     * @OneToMany(targetEntity="Patient", mappedBy="doctor", fetch="EAGER")
     */
	public $patients;
	
	public function __construct() {
		$this->patients = new ArrayCollection();
	}
	
}

Patient.php

class Patient {
	
	var $_explicitType = "vo/Patient";
	
    /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
    public $id;
	
    /** @Column(length=100, type="string") */
    public $name;

	/**
     * @OneToOne(targetEntity="Doctor", inversedBy="patients")
	 * @JoinColumn(name="doctor_id", referencedColumnName="id")
     */
	public $doctor;
	
}

[DDC-501] Merging entities that contained unloaded proxy collections will delete those associations

Thu, 1 Jul 2010 17:50:33 +0000

If loading an entity without its -to-many-collections, detaching and merging it back WITHOUT having touched those associations will result in two strange behaviours:

oneToMany (bidrectional, mapped by loaded entity): After merge the collection remains empty. Flushing EM and reloading entity will reveal associated entities again

manyToMany (bidirectional, mapped by targeted entity): After merge the collection remains empty. Flushing EM will physically delete associations.

----------------- !! NOTE !! --------------------
To reproduce the manyToMany-Bug it's necessary
to cascade "merge" on cmUser::groups
-------------------------------------------------

[DDC-455] E_NOTICE Undefined index when setting field to a property that is not persisted

Reference — Wed, 7 Jul 2010 18:34:30 +0000

Affects trunk.

A and B have a One-To-One mapping, with A being the owning side of the relationship. No cascade persist is set.

// Create entity A
$a = new A();
$em->persist($pt);
$em->flush();

echo "Created A {$b->getId()}\n";

// Create B and add it to A
$b = new B();
$a->setB($b);
//$em->persist($b); // oops, forgot

$em->flush();

echo "Created B {$b->getId()}\n";

Expected: either throw an exception saying that A is attempting to reference an instance of B that is not persisted, or silently ignore the field.

Actual: Cryptic notice:

E_NOTICE (8): Undefined index: 0000000069d80795000000006ebfc57d (Doctrine/ORM/UnitOfWork.php:1903)

[DDC-410] review all sql to ensure that it works with concurrent requests

Reference — Sun, 4 Jul 2010 11:21:11 +0000

this is just a reminder ticket .. it is important that all SQL code in D2 takes concurrent requests into account. this means simply fetching data and then writing data back to the RDBMS needs to take into account that there could be concurrent requests that change the fetched data. this means employing necessary explicit locking or optimistic locking etc.

[DDC-203] Detached entities are recognized as new ones

Reference — Tue, 6 Jul 2010 06:03:30 +0000

From
http://www.doctrine-project.org/documentation/manual/2_0/en/working-with-objects
on using persist() on an entity X:

If X is a detached entity, an InvalidArgumentException will be thrown.

So I do this:
$picard = $this->_getUser('Picard');
$this->_em->persist($picard);
$this->_em->flush();
$this->_em->detach($picard);
$this->_em->persist($picard);
$this->_howMany("Picard", 1);
Result:
1) NakedPhp\Storage\DoctrineTest::testSavesUpdatedEntities
There are 2 instances of Picard saved instead of 1.
Failed asserting that <string:2> matches expected <integer:1>.
The entity is recognized as new instead of detached, so no error is thrown and it is duplicated in the database.

[DDC-178] Query Hint for LOCK mechanisms plus support in $em->find()

Reference — Sun, 4 Jul 2010 08:38:45 +0000

In some scenarios it is necessary to explicitly lock rows for update in a select query. My idea would be to support it twofold:

1. Add a LockMode Class:

final abstract class Lock
{
    const NONE = 0;
    const OPTIMISTIC = 1;
    const PESSIMISTIC_READ = 2;
    const PESSIMISTIC_WRITE = 4;
}

2. Add methods to platforms that can add necessary READ/WRITE Lock query additions like FOR UPDATE/SHARED which afaik are supported by all rmdbs in some way.
3. Add a query hint "lockMode" which takes a Lock constant.
4. Add a query hint "lockVersion" which takes an integer or timestamp versioning value.
5. Change DQL Parser to apply lock mode if set, and if lock_mode = optimistic, add a where clause for the only top-level class (more not supported? Reread Evans DDD / Aggregates)
6. Change the $em->find() method to the following signature:

public function find($class, $identifier, $lockMode=0, $lockVersion=null);

And if the values are set, set the appropriate query hints.

Updated API specification

LockModes

final abstract class LockMode
{
    const NONE = 0;
    const OPTIMISTIC = 1;
    const PESSIMISTIC_READ = 2;
    const PESSIMISTIC_WRITE = 4;
}

Constraints

LockMode::OPTIMISTIC requires entities to be versioned
LockMode::PESSIMISTIC_READ/WRITE works similarly for versioned as well as non-versioned entities. However, lock() after read only works for versioned entities.

API spec

$query->setLockMode(LockMode::OPTIMISTIC)

Effects:

Throw OptimisticLockException if any of the entities fetched (or fetch-joined) by the query are not versioned.
Otherwise proceed normally, SQL is not modified.

$query->setLockMode(LockMode::PESSIMISTIC_READ/WRITE)

Effects:

Throw TransactionRequiredException if there is no running transaction.
Modify the SQL with an appropriate locking clause (i.e. FOR UPDATE) that can be platform-specific, to acquire a pessimistic lock on all read entities.
Throw PessimisticLockException if lock(s) could not be obtained.

$em->find($entity, LockMode::OPTIMISTIC) (or findBy et al)

Effects:

Throw OptimisticLockException if entity is not versioned.
Otherwise proceeed normally.

$em->find($entity, LockMode::OPTIMISTIC, $version) (or findBy et al)

Effects:

Throw OptimisticLockException if entity is not versioned.
find() entity normally, no SQL modification.
Throw OptimisticLockException if there is a version mismatch ($version != $entity->version)
Otherwise proceed normally.

$em->find($entity, LockMode::PESSIMISTIC_READ/WRITE)

Effects:

Throw TransactionRequiredException if there is no active transaction.
Modify the SQL to incude an appropriate platform-specific pessimistic lock (i.e. FOR UPDATE)
throw PessimisticLockException If lock could not be obtained
Otherwise proceed normally
Refresh entity with lock when entity with id exists in identity map already

$em->refresh($entity, LockMode::OPTIMISTIC)

Effects:

Throw OptimisticLockException if entity is not versioned.
Otherwise proceed normally. (What about cascades here? Need to take that into account probably)

$em->refresh($entity, LockMode::PESSIMISTIC_READ/WRITE)

Effects:

Throw TransactionRequiredException if there is no active transaction.
Ensure the SQL used for refreshing is modified accordingly with the platform-specific pessimistic locking clause.
Throw PessimisticLockException if the lock could not be obtained.
Otherwise proceed normally.

$em->lock($entity, LockMode::OPTIMISTIC)

Effects:

Throw OptimisticLockException if entity is not versioned.
Otherwise do nothing (NOOP).

$em->lock($entity, LockMode::PESSIMISTIC_READ/WRITE)

Effects:

Throw TransactionRequiredException if there is no active transaction.
Throw PessimisticLockException if entity is not versioned (this is always a "lock after read")
Issue straight, minimal locking SQL (we probably must include the version column in the select), platform-specific. Note: Probably get the SQL from the persisters to account for different inheritance mapping strategies. The last part of the SQL, the locking clause, is taken from the platforms.
Throw PessimisticLockException if the lock could not be obtained.
Compare the newly read version with the old version. If they dont match throw PessimisticLockException (this means the entity was changed since it was read).
Otherwise proceed normally.

[DDC-167] New method: EntityManager#getPartialReference

Thu, 22 Jul 2010 09:43:58 +0000

Currently, EntityManager#getReference can be used to retrieve cheap references to "persistent" objects without actually loading them. The returned proxies only initialize themselves automatically when one of their methods is invoked. This can lead to unnecessary/unwanted initialization in cases of bidirectional associations where the "association management methods" (setFoo) properly set the other side of the association. Example (one-one, User-Address, User owning side):

class User {
    private $address;
    public function setAddress(Address $address) {
        if ($address !== $this->address) {
            $this->address = $address;
            $address->setUser($this);
        }
    }
}

class Address {
    private $user;
    public function setUser(User $user) {
        if ($user !== $this->user) {
            $this->user = $user;
            $user->setAddress($this);
        }
    }
}

Now, assuming the following code that makes use of getReference to associate a user to an address but actually wants to avoid loading the address.

// assuming $user is already loaded and now we want to associate it to an existing address
// but without actually loading the address

$addressId = 42; // from request, $_POST/$_GET/...
$address = $em->getReference('Address', $addressId);

$user->setAddress($address); // calls $address->setUser which initializes the proxy!
$em->flush();

A possible solution could be to allow obtaining single references to partial objects through the EntityManager. Partial objects can already be fetched through querying with the Query::HINT_FORCE_PARTIAL_LOAD query hint so the possibility to get a single partial object by ID seems to make sense.

A proposed method name is: getPartialReference($className, $id). It would return a managed (partial) instance of $className where only the identifier is populated and that will not initialize itself (hence "partial"). In the example above, usage of a partial reference object would avoid the extra initialization.

[DDC-130] Cascading and @ManyToMany associations is broken

Reference — Sat, 10 Jul 2010 08:11:06 +0000

I have two Entities: Users and Alerts. They are associated with @ManyToMany, the assiciation table should be "user_alert".

Entities:
http://pastebin.com/m7bca724a

Sample code:
http://pastebin.com/m4e530f42

The "remove" command in the sample code deletes the user entry and alert entry, but not the user_alert entry (which was automatically created though). This leaves an orphan entry (or the DBMS will complain because of FK constraints).

INSERT INTO users (name) VALUES (?)
array(1) {
  [1]=>
  string(3) "Bob"
}
INSERT INTO alert (name) VALUES (?)
array(1) {
  [1]=>
  string(9) "Testalert"
}
INSERT INTO user_alert (userId, alertId) VALUES (?, ?)
array(2) {
  [0]=>
  int(1)
  [1]=>
  int(1)
}
DELETE FROM users WHERE id = ?
array(1) {
  [0]=>
  int(1)
}
DELETE FROM alert WHERE id = ?
array(1) {
  [0]=>
  int(1)
}

The user_alert table should be automatically updated (on creation and removal)...

[DDC-119] Collection change tracking broken with NOTIFY policy

Fri, 16 Jul 2010 05:29:45 +0000

Looks like change tracking of collections together with the NOTIFY policy doesnt work well as collection updates are detected in _computeAssociationChanges. Perhaps the collection itself should inform the UnitOfWork directly?

[DDC-13] Enhance DQL chapter

Thu, 15 Jul 2010 10:55:57 +0000

The first half of the chapter "DQL - Doctrine Query Language" needs more examples and detailed explanations about DQL. The explanations need to be understandable and friendly for newcomers with no Doctrine 1.x experience.