follow up of https://github.com/doctrine/phpcr-odm/pull/279

ClassMetadata

// TODO this may be not set. what happens if we would return null then?
return $this->mappings[$fieldName]['targetDocument'];

investigate and fix once 279 is merged.

for yml, all mappings must use camelCase, while for xml it must be connected-text in all lowercase with the dash between. it seems at least fieldName is wrong.

we should clean this up before the first release to avoid having to deal with inconsistent legacy from the beginning.

Query->getSingleResult correctly throws an Exception when there are no results (or more than one), but it is an Exception that could also be produced by other things, so not guaranteed to mean that (
(http://docs.doctrine-project.org/projects/doctrine-phpcr-odm/en/latest/reference/query.html#getsingleresult)

when searching there must be some way to ensure that for translateable documents the right fields are filters. f.e. when using the child strategy then for the given columns the node name needs to be checked (nodename = phpcr_locale:fr). for attributes strategy the property name needs to be rewritten ("title" vs "phpcr_locale:fr-title").

it might not be possible to easily automate this.

documents extending other documents should inherit the global attributes unless overwritten explicitly.

for example, having @Document(referenceable=true) should be kept for an extending class unless it explicitly sets it to false. currently, attributes are reset on each new @Document tag. (i assume we have the same issue for xml/yml mapping?)

https://github.com/doctrine/phpcr-odm/pull/144#discussion_r963877 reveiled that we should look into the exception concepts and streamline them.

right now when we for example have a @ReferenceMany but nothing is assigned, then when we read said object from the database that property is set to null. should it rather be initialized as an empty collection?

Is there a reason why the get node name method on the generic document is ->getNodename and not ->getNodeName?

we should map the Node::addNodeAutonamed as an option for the nodename field to have nodes that generate their own name (i.e. useful in children collection)

Getting a MissingTranslationException when displaying a banner on the frontend. It seems to be caused in the refreshDocumentForProxy method on line 496 of UOW, the parent document does not have a locale and therefore the fallback hint is false. The banner block is not translated and the banner images are (title property).

See for a stacktrace: https://gist.github.com/rmsint/2c6700e00c47c95dc30e

If the document have `jcr:lastModified`, this attribute is filled on create but not updated when a document is modified.

I tried to set manually this attribute and it is not updated too.

Joins are currently not supported in the QueryBuilder, the methods are there and some of the logic is partially coded, but they just havn't been implemented.

At time of writing joins are not supported by doctrine-dbal (i think) but they are supported at least by Jackrabbit.

the query builder can currently hydrate to documents and to phpcr nodes. it should also be possible to hydrate the result into a plain array to avoid creating documents and get the direct query result. (btw note that '*' in sql2 does not mean all properties of a document, but just the path and some other basic things - you always need to specify all fields you want to retrieve explicitly in this case)

for the query builder base work and discussion see https://github.com/doctrine/phpcr-odm/pull/204

In the document of phpcr.github.com (http://phpcr.github.com/doc/html/phpcr/nodeinterface.html#getReferences%28%29), I quote:

"In implementations that support versioning, this method does not return properties that are part of the frozen state of a version in version storage."

But, the referrers returns some versioned node.

If you create children of a document without adding them to the children collection of the parent (with a children annotation) the children collection is not updated after flush, you need to call $dm->clear() to force a reread of the children. The current case was with a parent and its children created in the same flush.

follow up of the discussion in https://github.com/doctrine/phpcr-odm/pull/120

id strategy:

1. if there is an id with a strategy always use that
2. if not and there is a parent and a node name mapping use the parent strategy
3. else use assigned strategy if there is an id field
4. throw an exception that you can't use this document

finalizing the mapping could have the added benefit of combined validation. for example if assigned strategy is parent and name but there is no field mapped to the name, it would tell this is invalid.

think what should be validated at the finalize point.

this is a follow-up of
https://github.com/doctrine/phpcr-odm/pull/116

the problem is: what happens when a ReferenceOne path or weak reference property points to something non-existing? is the property null? is the currently invalid reference removed on save or kept (which would make sense, in case the node at path appears later). but if it is usually kept, how can we delete it if we want?

instead we should just use the current state of the underlying node.

see http://docs.doctrine-project.org/en/latest/reference/events.html#entity-listeners

as discussed in https://github.com/doctrine/phpcr-odm/pull/268 we should implement UnitOfWork::isScheduledDocument and isScheduledFor* other than isScheduledForInsert.

Allow the query builder expression to specify an object as a target.

$qb->where($qb->expr()->eq('someObjectReference', $someObject);

So if the target passed is mapped and it is referenceable then replace the object instance with its UUID.

Parameter binding is not currently implemented in the QueryBuilder, and the comments seem to indicate that this is because jackalope does not support it at the moment.

Implement the Query->iterate method which will return an IteratableResultSet as per the ORM.

As with the ORM query object, implement the ->clone() method.

https://github.com/doctrine/doctrine2/pull/206

this is a follow-up of
https://github.com/doctrine/phpcr-odm/pull/116

i think a user might need to attach his own strategy to the document manager. we could call this path_relative= and provide "max" that string-compares the target path and the node path and puts as few ../ as necessary. but again this does not block this pull request.

http://www.doctrine-project.org/docs/orm/2.2/en/reference/change-tracking-policies.html

It will be great to be able to store array as a json in a property. There is no way to define custom mapping type (it is possible with doctrine ORM)

right now we have hardcoded \PHPCR\Util\UUIDHelper::generateUUID(), but that is a very simplistic implementation and the spec is much broader ..

when i have existing content and later change the document class to have referenceable=true, this is not updated even on persisting the document again.

uwe: I think there are several other things that fail when you have existing content in the repository - maybe the solution to think about is something like migrations ... that would prevent the performance penalty on ordinary code and still give you the change to change the structure of your documents.

things that come to mind

• change document class name
• removing fields
• change field type
• bulk changing the values in some field
• everything related to node types (though, as an additional challenge at least jackrabbit does not allow to remove things from node types through the davex remoting we use in jackalope)

see also http://www.doctrine-project.org/docs/mongodb_odm/1.0/en/reference/logging.html

https://doctrine-mongodb-odm.readthedocs.org/en/latest/reference/migrating-schemas.html

There is getQOMFactory method in PHPCR\Util\QOM\QueryBuilder (very useful) but it isn't in Doctrine\ODM\PHPCR\Query\QueryBuilder (it breaks bc).

Is it mistake or there is/will be another method to access QOMFactory instance?