[PHPCR-109] Why Generic::getNodename and not camelcase? Created: 11/May/13  Updated: 13/May/13

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Daniel Leech Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

Is there a reason why the get node name method on the generic document is ->getNodename and not ->getNodeName?



 Comments   
Comment by David Buchmann [ 13/May/13 ]

because the field is mapped as nodename, not nodeName. its representing $node->getName() - calling it just name seemed to confusing.

i vote against it, but if we want to change the mapping, we should do that right now, as i am breaking everything anyways in https://github.com/doctrine/phpcr-odm/pull/279





[PHPCR-103] map node autoname feature Created: 13/Mar/13  Updated: 14/Mar/13

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: David Buchmann Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

we should map the Node::addNodeAutonamed as an option for the nodename field to have nodes that generate their own name (i.e. useful in children collection)



 Comments   
Comment by David Buchmann [ 14/Mar/13 ]

probably this should be a special id generator strategy like parent and nodename, where nodename is generated. is there a way to pass a parameter to the strategy? or would this need to be a separate option on the "@Id"? addNodeAutoname can accept an optional parameter to control parts of the generated name.
btw, this will be funny as this strategy can not really "generate" an id, it needs to actually create the node to have the name generated. so actually we have no id until we actually flush...

and there is this issue to handle as well
https://github.com/doctrine/phpcr-odm/commit/a4075caadd97312cc53bccf57ff8baf593df65d4





[PHPCR-101] MissingTranslationException when parent is not translated Created: 01/Mar/13  Updated: 18/Apr/13

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Roel Sint Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

Getting a MissingTranslationException when displaying a banner on the frontend. It seems to be caused in the refreshDocumentForProxy method on line 496 of UOW, the parent document does not have a locale and therefore the fallback hint is false. The banner block is not translated and the banner images are (title property).

See for a stacktrace: https://gist.github.com/rmsint/2c6700e00c47c95dc30e



 Comments   
Comment by David Buchmann [ 18/Apr/13 ]

roel, can you please test with the latest phpcr-odm? we think this should be fixed now.





[PHPCR-100] The mixin `jcr:lastModified` is not updated Created: 01/Mar/13  Updated: 19/Apr/13

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Pierre-Louis LAUNAY Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

If the document have `jcr:lastModified`, this attribute is filled on create but not updated when a document is modified.

I tried to set manually this attribute and it is not updated too.



 Comments   
Comment by David Buchmann [ 18/Apr/13 ]

jackrabbit for example does not automatically update this field. but setting it manually should work, so this could be a bug of phpcr-odm

Comment by David Buchmann [ 19/Apr/13 ]

Pierre-Louis LAUNAY could you investigate why manually setting the field does not work? it could be that the phpcr-odm UnitOfWork ignores the field, or also that jackalope ignores changes to the field...





[PHPCR-92] Join support in QueryBuilder Created: 19/Feb/13  Updated: 19/Feb/13

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: New Feature Priority: Major
Reporter: Daniel Leech Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: querybuilder,


 Description   

Joins are currently not supported in the QueryBuilder, the methods are there and some of the logic is partially coded, but they just havn't been implemented.

At time of writing joins are not supported by doctrine-dbal (i think) but they are supported at least by Jackrabbit.






[PHPCR-85] implement querybuilder hydrate array option Created: 14/Jan/13  Updated: 14/Jan/13

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: New Feature Priority: Major
Reporter: David Buchmann Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

the query builder can currently hydrate to documents and to phpcr nodes. it should also be possible to hydrate the result into a plain array to avoid creating documents and get the direct query result. (btw note that '*' in sql2 does not mean all properties of a document, but just the path and some other basic things - you always need to specify all fields you want to retrieve explicitly in this case)

for the query builder base work and discussion see https://github.com/doctrine/phpcr-odm/pull/204






[PHPCR-81] Referrers should not return the frozen node of a version in version storage Created: 26/Sep/12  Updated: 26/Sep/12

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Pierre-Louis LAUNAY Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

In the document of phpcr.github.com (http://phpcr.github.com/doc/html/phpcr/nodeinterface.html#getReferences%28%29), I quote:

"In implementations that support versioning, this method does not return properties that are part of the frozen state of a version in version storage."

But, the referrers returns some versioned node.






[PHPCR-80] ChildrenCollection is not updated after flush although children where added before Created: 07/Sep/12  Updated: 12/Mar/13

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Uwe Jäger Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

If you create children of a document without adding them to the children collection of the parent (with a children annotation) the children collection is not updated after flush, you need to call $dm->clear() to force a reread of the children. The current case was with a parent and its children created in the same flush.



 Comments   
Comment by Uwe Jäger [ 07/Sep/12 ]

Try this code:

$node1 = new Generic();
$node1->setParent($parent);
$node1->setNodename('source');
$this->dm->persist($node1);

$this->childrenNames = array('first', 'second', 'third', 'fourth');
foreach ($this->childrenNames as $childName)

{ $child = new Generic(); $child->setNodename($childName); $child->setParent($node1); $this->dm->persist($child); }

$this->dm->flush();
$this->dm->clear();

$node = $this->dm->find(null, '/functional/source');
$children = $node->getChildren();

// without the clear above $children === NULL, with the clear it works as expected

Comment by David Buchmann [ 14/Jan/13 ]

lukas, is this fixed with the work you did on cascading?

Comment by David Buchmann [ 12/Mar/13 ]

we did a lot of refactoring on cascading lately. uwe, can you check if the problem still exists and do a pull request with a failing test if it exists?





[PHPCR-60] add finalize step to mapping to calculate and validate Created: 09/Mar/12  Updated: 04/Oct/12

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: David Buchmann Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

follow up of the discussion in https://github.com/doctrine/phpcr-odm/pull/120

id strategy:

1. if there is an id with a strategy always use that
2. if not and there is a parent and a node name mapping use the parent strategy
3. else use assigned strategy if there is an id field
4. throw an exception that you can't use this document

finalizing the mapping could have the added benefit of combined validation. for example if assigned strategy is parent and name but there is no field mapped to the name, it would tell this is invalid.

think what should be validated at the finalize point.



 Comments   
Comment by Lukas Kahwe [ 04/Oct/12 ]

added a method for final validation here https://github.com/doctrine/phpcr-odm/pull/180





[PHPCR-58] figure out how to handle dangling weak/path ReferenceOne/Many properties Created: 07/Mar/12  Updated: 07/Mar/12

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: David Buchmann Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

this is a follow-up of
https://github.com/doctrine/phpcr-odm/pull/116

the problem is: what happens when a ReferenceOne path or weak reference property points to something non-existing? is the property null? is the currently invalid reference removed on save or kept (which would make sense, in case the node at path appears later). but if it is usually kept, how can we delete it if we want?






[PHPCR-57] do not track the original/unmapped values separately Created: 29/Feb/12  Updated: 03/Mar/12

Status: Open
Project: Doctrine PHPCR
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Lukas Kahwe Assignee: Lukas Kahwe
Resolution: Unresolved Votes: 0
Labels: None


 Description   

instead we should just use the current state of the underlying node.



 Comments   
Comment by Lukas Kahwe [ 03/Mar/12 ]

https://github.com/doctrine/phpcr-odm/pull/118





Generated at Mon May 20 00:48:36 UTC 2013 using JIRA 5.2.7#850-sha1:b2af0c8dc8537b36121c6a579fabbdf79fc919e5.