### [DDC-274] Class and namespace naming inconsistency Created: 24/Jan/10  Updated: 31/Oct/10

Status: In Progress
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: 2.0-ALPHA4
Fix Version/s: 2.0-RC1
Security Level: All

 Type: Improvement Priority: Critical Reporter: Glen Ainscow Assignee: Roman S. Borschel Resolution: Unresolved Votes: 1 Labels: None

 Description
 There are inconsistencies with some class and namespace names that include acronyms. Examples: Classes with upper-casing: ORMException, DBALException, OCI8Connection, etc. Classes with proper-casing: RunDqlTask, CliException, MySqlPlatform, etc. Namespaces with upper-casing: DBAL, ORM, Doctrine\DBAL\Driver\PDOMsSql, etc. Namespaces with proper-casing: Doctrine\Common\Cli, Doctrine\DBAL\Tools\Cli\, Doctrine\ORM\Id, etc. There is more proper-casing than upper-casing. IMHO, proper-casing is better as it's easier to read "SqlException" than it is to read "SQLException" (the "E" looks like part of the acronym), and things like "CLITask" can be avoided. I discussed this a bit with Benjamin and Guilherme, and they were unsure and said that the whole team needed to reach consensus. I'm leaving the priority as "Major" because this should probably be fixed sooner rather than later to prevent compatibility breaks.

### [DDC-585] Create a coding standards document Created: 13/May/10  Updated: 11/Feb/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0
Security Level: All

 Type: Task Priority: Major Reporter: Roman S. Borschel Assignee: Jonathan H. Wage Resolution: Unresolved Votes: 0 Labels: None

 Description
 We need a new coding standards document for Doctrine 2.

 Comment by Benjamin Morel [ 29/Jan/13 ] Has there been any work on a coding standards document yet? I'm currently working on fixing documentation on this project, and it might be a good time to define a standard. I've started compiling a few recommendations based on various feedbacks I've got in my pull requests, and I can post them here. Please let me know if there have been previous attempts so far! Comment by Marco Pivetta [ 29/Jan/13 ] Benjamin Morel Guilherme Blanco may have a CS ruleset, but it's not ready yet. Perfect timing btw, we really need to automate this to avoid having all these useless CS fix comments in pull requests Comment by Benjamin Morel [ 29/Jan/13 ] Ok, I'll post my document here once ready, and Guilherme Blanco will be able to compare it with his ruleset! Comment by Benjamin Morel [ 30/Jan/13 ] Here is a first draft: https://gist.github.com/4676670 Please comment! Comment by Benjamin Morel [ 11/Feb/13 ] Guilherme Blanco, if you don't have time to compare your ruleset with my draft, maybe you could publish your current ruleset so that others can have a look?

### [DDC-536] Remove the _ prefix from private and protected members Created: 23/Apr/10  Updated: 19/Nov/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0
Security Level: All

 Type: Task Priority: Major Reporter: Roman S. Borschel Assignee: Roman S. Borschel Resolution: Unresolved Votes: 1 Labels: None

 Description

### [DDC-1590] Fix Inheritance in Code-Generation Created: 09/Jan/12  Updated: 10/Dec/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 3 Labels: None

 Dependency is required for DDC-1579 MappedSuperClass and inheritance prob... Resolved

 Comment by Lukas Domnick [ 10/Dec/12 ] (I have no Link Privileges, but this one #DDC-1379 is a duplicate with more extent info.)

### [DDC-1852] Doctrine\ORM\Tools\SchemaValidator should check validity of lifecycle callbacks Created: 04/Jun/12  Updated: 20/Sep/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: Git Master
Fix Version/s: 2.4, 2.x, Git Master
Security Level: All

 Type: Improvement Priority: Major Reporter: Marco Pivetta Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 The schema validator should analyze mapped lifecycle callbacks and: a) if some lifecycle callbacks were defined, but no @HasLifecycleCallbacks annotation/mapping was set, warn the user b) if some lifecycle callbacks were defined, but methods are not public, warn the user

 Comment by Marco Pivetta [ 04/Jun/12 ] Existing PR at https://github.com/doctrine/doctrine2/pull/361

### [DDC-1840] Create ParameterCollection indexed and implement it on AbstractQuery and QueryBuilder Created: 26/May/12  Updated: 20/Sep/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4
Security Level: All

 Type: Improvement Priority: Major Reporter: Guilherme Blanco Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Currently, method setParameters in AbstractQuery and QueryBuilder only appends new parameters to the list. It should actually override the existing ones. To be able to correctly fix this, we need to create a ParameterCollection which we can use/reuse to set/remove/append new parameters. These elements should also support parameter types.

 Comment by Benjamin Eberlei [ 27/May/12 ] Not a bug

### [DDC-2208] CASE WHEN ... WHEN doesn't work Created: 19/Dec/12  Updated: 08/Jan/13

Status: Reopened
Project: Doctrine 2 - ORM
Component/s: DQL
Affects Version/s: 2.3.1
Fix Version/s: 2.4
Security Level: All

 Type: Bug Priority: Major Reporter: Miha Vrhovnik Assignee: Fabio B. Silva Resolution: Unresolved Votes: 0 Labels: None

 Description
 Having the following part in select DQL throws an exception. SUM(CASE WHEN c.startDate <= :start THEN c.endDate - :start WHEN c.endDate >= :end THEN :end - c.startDate ELSE 0 END)  exception: [Syntax Error] line 0, col 124: Error: Expected Doctrine\ORM\Query\Lexer::T_ELSE, got '-'  It seems that it's failing inside the second THEN This one also seems to fail: SUM(CASE WHEN c.startDate <= :start THEN (c.endDate - :start) WHEN c.endDate >= :end THEN (:end - c.startDate) ELSE 0 END)  exception: [Syntax Error] line 0, col 60: Error: Unexpected '('  Another one: SUM(CASE WHEN c.startDate <= :start THEN c.endDate - :start WHEN c.endDate >= :end THEN :end - c.startDate ELSE 0 END) = :result FROM ...  exception: [Syntax Error] line 0, col 60: Error: Expected Doctrine\ORM\Query\Lexer::T_FROM, got '=' 

 Comment by Miha Vrhovnik [ 20/Dec/12 ] I've added two more cases where the parsing fails. Do you want a separate tickets for that? Comment by Fabio B. Silva [ 20/Dec/12 ] Don't worry, I'll spend some time over this... But I'm not sure about the last one. Comment by Miha Vrhovnik [ 20/Dec/12 ] The 3rd case seems work just fine as a part of a HAVING clause. I haven't tried it but It might be that it fails with something simpler like SELECT COUNT( * ) = :foo FROM ... or SELECT COUNT( * ) = 2 FROM ... Comment by Miha Vrhovnik [ 08/Jan/13 ] Fabio I have two more... It doesn't like NULL and subselect after then part  ->addSelect('CASE WHEN po.quantity IS NULL THEN NULL ELSE po.quantity - COALESCE(0, ( SELECT COUNT(rd.product) FROM xxxx rd WHERE (rd.startDate <= :end) AND (rd.endDate >= :start) AND rd.product = c.product))) END AS po.quantity ')  :edit replaced with real query Comment by Miha Vrhovnik [ 08/Jan/13 ] addon: well the subquery part can be full query with joins ....

### [DDC-1738] Allow multiple Generators per class Created: 29/Mar/12  Updated: 20/Sep/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: Mapping Drivers
Affects Version/s: Git Master
Fix Version/s: 2.4
Security Level: All

 Type: Improvement Priority: Major Reporter: Guilherme Blanco Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 We should be able to support multiple generators per class. When doing partition per table, the partitioned column must be part of PK, which may enter in our limitation. Currently we only support 1 generator per class.

### [DDC-1723] Custom ID Generators Created: 22/Mar/12  Updated: 20/Sep/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4
Security Level: All

 Type: New Feature Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Allow specify custom id generators, pull request is GH-206 https://github.com/doctrine/doctrine2/pull/206

### [DDC-2214] extra single quotation in sql when using EntityRepository::findBy Created: 26/Dec/12  Updated: 01/Apr/13

Status: In Progress
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4
Security Level: All

 Type: Bug Priority: Major Reporter: scourgen Assignee: Marco Pivetta Resolution: Unresolved Votes: 0 Labels: None

 Attachments: DDC2214Test.php

 Description
 I'm using symfony 2.1 with mysql. I have following code: $related =$this->getDoctrine()->getRepository('MyWebBundle:LineRelated') ->findBy(array('line' => $lines), array('count' => 'DESC'), 20);  that generate the sql like this: SELECT * FROM line_related t0 WHERE t0.line_id IN ('6059', 126352, '5677', '6058') ORDER BY t0.count DESC LIMIT 20  please notice that the sql has extra single quotation around the number 6059,5677 and 6058. which make the sql very slow. I did a test, when using single quotation,the sql takes 300ms,when using without single quotation,the sql takes 1 ms.  Comments  Comment by Fabio B. Silva [ 26/Dec/12 ] Hi Could you please attach your entities or a failing test case ? Cheers Comment by scourgen [ 27/Dec/12 ] sure LineRelated.php : class LineRelated { /** * @ORM\Id * @ORM\Column(type="integer") * @ORM\GeneratedValue(strategy="AUTO") */ protected$id; /** * @ORM\ManyToOne(targetEntity="Line", inversedBy="line_related") * @ORM\JoinColumn(name="line_id", referencedColumnName="id",nullable=false) */ protected $line; /** * @ORM\Column(name="line_id_related", type="integer") */ protected$line_related; /** * @ORM\Column(type="smallint",nullable=false) */ protected $count = 0; ###### get/set etc....... #######  Line.php class Line { /** * @ORM\Id * @ORM\Column(type="integer") * @ORM\GeneratedValue(strategy="AUTO") */ protected$id; ########## blablabla #############  my action:  public function right_line_relatedAction($line = null,$title='相关线路') { $lines =$l->getByUser($user, array()); //anyway,$lines is an array,It has several elements,each element is an instance of LineEntity. $related =$this->getDoctrine()->getRepository('MyWebBundle:LineRelated')->findBy(array('line' => $lines), array('count' => 'DESC'), 20); //this findBy function generate the sql which is slow. return$related; }  Comment by Fabio B. Silva [ 27/Dec/12 ] Hi, How did you get this query string ? Repository#findBy does not quote the values, It uses PDO:bindParam. so the expected query string should be someting like : WHERE t0.line_id IN (?, ? ,?)  I tried to reproduce but in my tests the generated Query binds the parameters as "PDO::PARAM_INT". I have added a test case. Could you please can try to change it and make fails. Cheers Comment by scourgen [ 28/Dec/12 ] reproduced : SELECT t0.id AS id1, t0.line_id_related AS line_id_related2, t0.count AS count3, t0.line_id AS line_id4 FROM line_related t0 WHERE t0.line_id IN ('6059', 4851, '6068', 126352, '6060', '1000000') ORDER BY t0.count DESC LIMIT 20 Parameters: [['6059', 4851, '6068', 126352, '6060', '1000000']] [Hide runnable query] Time: 234.53 ms [ Explain query ]  let me have a look on what's going on Comment by scourgen [ 28/Dec/12 ] interesting. I've dump(using ladybug_dump) the $lines,and I found out that when the element is a Proxies Object(Object(Proxies_GC_\My\WebBundle\Entity\Line)),then the id of that Object will be with quoted,when the elememt is an Real Entity,then It will be without quote. for example,in my last comment, the parameters is [['6059', 4851, '6068', 126352, '6060', '1000000']] the result of dumping$lines is : array(6) [0]: object(Proxies_CG_\Zuo\WebBundle\Entity\Line) [1]: object(Zuo\WebBundle\Entity\Line) [2]: object(Proxies_CG_\Zuo\WebBundle\Entity\Line) [3]: object(Zuo\WebBundle\Entity\Line) [4]: object(Proxies_CG_\Zuo\WebBundle\Entity\Line) [5]: object(Proxies_CG_\Zuo\WebBundle\Entity\Line) tell me if you need more information. thanks Comment by Marco Pivetta [ 28/Dec/12 ] This may be because $_identifier in proxies ( https://github.com/doctrine/doctrine2/blob/42e83a2716d19eada4f1cd49ece77d5f5229a239/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L383 ) is not necessarily composed by integers. This could be fixed with DCOM-96. I'll add the tests to my development branch and will ping you back tomorrow Comment by scourgen [ 28/Dec/12 ] thanks Comment by Marco Pivetta [ 06/Jan/13 ] I see what is going on here... But this should not be a problem anyway, since they're bound anyway as "PDO::PARAM_INT", as Fabio B. Silva told you. That's only a problem with the logger showing them as string. PDO will handle the conversion before the value hits the DB as far as I know. Comment by scourgen [ 07/Jan/13 ] I can understand your point,but what I don't really get is that the execute time of sql is very long,that explained the quote should be in the sql,not like what you said,that's only a problem with the logger. Comment by Marco Pivetta [ 07/Jan/13 ] scourgen can you profile the difference directly in CLI? What about checking the bound parameter type? Are those values bound as INTs in your case? Comment by scourgen [ 07/Jan/13 ] @ocramius I wish I could, but I was using doctrine2 with symfony2,So It looks like It will takes some time to simulating all environment and settings that could allow me to reproduced the problem. but anyway,I will have a try and tell you what happen when I found something. Comment by Marco Pivetta [ 07/Jan/13 ] scourgen ok, awaiting your reply then Comment by scourgen [ 07/Jan/13 ] I've spent some time on playing with native doctrine2. It took me awhile to setup everything. but I just don't get that how to retrive data with its Proxy ojbect(for example Proxies_CG_\My\WebBundle\Entity\Line). I mean the result of $this->_em->getRepository("something")->findxxx() always return an array of real object. I can't reproduced the situation(#comment-19186) that happens on symfony2+doctrine2. anyway,I can make sure the problem is real exist,Because the execute time of that slow sql from the tool bar of symfony2 is same as I executed it at mysql cli. If the sql shows up on log with quote but running at mysql without quote,the execute time won't be same(actually It will be much more faster,in my case,20x times,from 2xxms to 10ms). Comment by Marco Pivetta [ 07/Jan/13 ] scourgen you can use $em->getReference($className, $identifier) (identifier being a key=>value array) to force proxies. Give it a try Comment by scourgen [ 08/Jan/13 ] looks like I reproduced it.  public function testIssue() {$no_used= $this->_em->getRepository(__NAMESPACE__. '\DDC2214Line')->findOneById(1);$lines=array( //$this->_em->getRepository(__NAMESPACE__. '\DDC2214Line')->findOneById(1),$this->_em->getReference(__NAMESPACE__. '\DDC2214Line',1), $this->_em->getReference(__NAMESPACE__. '\DDC2214Line','2'),$this->_em->getReference(__NAMESPACE__. '\DDC2214Line',3), ); $logger =$this->_em->getConnection()->getConfiguration()->getSQLLogger(); $ids = array_map(function($r){ return $r->id; },$this->relatedList); //$related =$this->_em->getRepository(__NAMESPACE__ . '\DDC2214LineRelated')->findBy(array('line' => $lines), array('count' => 'DESC'), 20);$related = $this->_em->createQuery('select lr from '.__NAMESPACE__ . '\DDC2214LineRelated lr where lr.id in (:ids)')->setParameter('ids',$lines)->getResult(); $query = end($logger->queries); //\Doctrine\Common\Util\Debug::dump($query['params']);$this->assertCount(3, $related);$this->assertEquals($ids,$query['params'][0]); $this->assertEquals(\Doctrine\DBAL\Connection::PARAM_INT_ARRAY,$query['types'][0]); } }  I use MySql Query log to see what's really happen in database(http://dev.mysql.com/doc/refman/5.5/en/query-log.html) this is the log from table mysql.general_log 2013-01-08 12:23:44 [root] @ localhost [127.0.0.1] 59 0 Connect root@localhost on doctrine_tests 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query CREATE TABLE DDC2214Line (id INT AUTO_INCREMENT NOT NULL, PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query CREATE TABLE DDC2214LineRelated (id INT AUTO_INCREMENT NOT NULL, line_id INT NOT NULL, count SMALLINT NOT NULL, line_id_related INT NOT NULL, INDEX IDX_D31307994D7B7542 (line_id), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query ALTER TABLE DDC2214LineRelated ADD CONSTRAINT FK_D31307994D7B7542 FOREIGN KEY (line_id) REFERENCES DDC2214Line (id) 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query START TRANSACTION 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query INSERT INTO DDC2214Line (id) VALUES (null) 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query INSERT INTO DDC2214Line (id) VALUES (null) 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query INSERT INTO DDC2214Line (id) VALUES (null) 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query INSERT INTO DDC2214LineRelated (count, line_id_related, line_id) VALUES (1, 1, 1) 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query INSERT INTO DDC2214LineRelated (count, line_id_related, line_id) VALUES (2, 2, 2) 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query INSERT INTO DDC2214LineRelated (count, line_id_related, line_id) VALUES (3, 3, 3) 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query COMMIT 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query SELECT t0.id AS id1 FROM DDC2214Line t0 WHERE t0.id = 1 LIMIT 1 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Query SELECT d0_.id AS id0, d0_.count AS count1, d0_.line_id_related AS line_id_related2, d0_.line_id AS line_id3 FROM DDC2214LineRelated d0_ WHERE d0_.id IN (1, '2', 3) 2013-01-08 12:23:44 root[root] @ localhost [127.0.0.1] 59 0 Quit  you can see,in database level,the second parameter of last query but two has quote ( (1, '2', 3) ) Comment by Benjamin Eberlei [ 25/Jan/13 ] A related Github Pull-Request [GH-247] was opened https://github.com/doctrine/common/pull/247 Comment by Benjamin Eberlei [ 26/Jan/13 ] A related Github Pull-Request [GH-247] was closed https://github.com/doctrine/common/pull/247

### [DDC-2390] Remove Parser and SQLWalker dependency on Query Created: 04/Apr/13  Updated: 04/Apr/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Query is too powerful to be available in Parser and SQLWalker, because it may lead to accessing data that changes on subsequent runs of a query that is cached. Idea is to introduce a MetadataBag that contains only the values that are allowed to be accessed.

### [DDC-2052] Custom tree walkers are not allowed to add new components to the query Created: 02/Oct/12  Updated: 14/May/13

Status: Reopened
Project: Doctrine 2 - ORM
Component/s: DQL
Affects Version/s: 2.3
Fix Version/s: 2.4

 Type: Improvement Priority: Major Reporter: Łukasz Cybula Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: dql

 Description
 Custom tree walkers have freedom in modifying the AST but when you try to add a new query component (i.e. new join in walkSelectStatement() ) to the AST then the SqlWalker throws an exception because it does not has the new component in its _queryComponents array. I see two possible ways to resolve this: 1. Modify the Parser class in order to allow tree walkers to modify queryComponents and pass changed queryComponents to the SqlWalker 2. Improve SqlWalker so it can extract and prepare needed information about queryComponent based on AST when it does not have them.

 Comment by Benjamin Eberlei [ 06/Oct/12 ] Ok this is much more complicated to allow then i thought. The problem is that the QueryComponents are passed by value, as an array, not by reference. That prevents changing them because this change wouldn't be visible in the output walker. I can add a method to allow this in the OutputWalker for now, but generally this requires a bigger refactoring on the Query Components. Comment by Benjamin Eberlei [ 06/Oct/12 ] Added setQueryComponent() in SQL Walker to allow modification in output walker. Comment by Łukasz Cybula [ 08/Oct/12 ] I'm afraid that this doesn't solve the initial problem at all. I'll try to describe it in more details to show what I mean. Suppose we have two doctrine extensions each of which contain its own tree walker. Each of these tree walkers need to modify AST and add new component to it (joined with some component already existing in the query). The first problem is that each tree walker has its own queryComponents array which is not passed between them, although they not necessary need to use queryComponents - they could use only AST. The second, bigger problem is that the Parser class does not know anything about modifications of queryComponents in tree walkers and cannot pass modified version to the OutputWalker. The goal of submitting this issue was to allow adding new components to the query in tree walkers which is not achievable by your fix. I think it may be the first step in the right direction. Maybe TreeWalkerAdapter should have public method getQueryComponents() which would be used by the Parser to pass modified queryComponents between different tree walkers and finally to the OutputWalker ? This would not break backward compatibility and solve this issue. What do you think about it? Comment by Łukasz Cybula [ 08/Oct/12 ] I've tried to implement the solution mentioned in previous comment but it's also not so clean and easy as I thought. Each tree walker (including TreeWalkerChain) would have to implement getQueryComponents() and setQueryComponent($alias, array$component) methods. The same with SqlWalker, so the TreeWalker interface should have these methods, which would break BC in some way (walkers that do not inherit from SqlWalker or TreeWalkerAdapter will fail to compile). So maybe my first solution (PR #464) is not so bad for now? In the future queryComponents could be replaced by a special object or could be passed by a reference to allow modifications. Comment by Benjamin Eberlei [ 09/May/13 ] Marked as improvement as its not a bug. A solution might probably implement an object holding all the QueryComponent, implementing ArrayAccess. So that way the state can be shared. Comment by Marco Pivetta [ 14/May/13 ] Just hit this while developing an ast walker... Will look into it too since I need it more than soon. Comment by Marco Pivetta [ 14/May/13 ] As a VERY UGLY workaround, I used a static variable and a custom sql walker in combination with my AST walker.  namespace Comcom\Versioning\ORM\Query; use Doctrine\ORM\Query\SqlWalker; class WorkaroundSqlWalker extends SqlWalker { public function __construct($query,$parserResult, array $queryComponents) { parent::__construct($query, $parserResult,$queryComponents); foreach (VersionWalker::$additionalAliases as$alias => $value) {$this->setQueryComponent($alias,$value); } } } 

### [DDC-2452] Additional WITH condition in joins between JTI roots cause invalid SQL to be produced Created: 16/May/13  Updated: 16/May/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: DQL, ORM
Affects Version/s: Git Master
Fix Version/s: 2.4
Security Level: All

 Type: Bug Priority: Major Reporter: Marco Pivetta Assignee: Marco Pivetta Resolution: Unresolved Votes: 0 Labels: dql, sql-walker Environment: irrelevant

 Description

### [DDC-2203] add EntityManager->getFilters()->isEnabled('filterName'') Created: 17/Dec/12  Updated: 01/Apr/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: Git Master
Fix Version/s: 2.4
Security Level: All

 Type: Improvement Priority: Minor Reporter: Enea Bette Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Comment by Paweł Nowak [ 10/Jan/13 ] My pull request (https://github.com/doctrine/doctrine2/pull/548) contains an implementation of the method. Note that no exception is thrown if you query for the state of a non-existing filter - in such a case, false is returned as for disabled filters.

### [DDC-222] Create unit tests for CLI components Created: 22/Dec/09  Updated: 30/Oct/10

Status: Reopened
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.0-ALPHA3
Fix Version/s: 2.x
Security Level: All

 Type: Task Priority: Critical Reporter: Roman S. Borschel Assignee: Guilherme Blanco Resolution: Unresolved Votes: 0 Labels: None

 Reference is referenced by DDC-359 Specified, but empty CLI Options --op... Resolved

 Comment by Roman S. Borschel [ 19/May/10 ] Whats the status here? Do we have any? Comment by Guilherme Blanco [ 19/May/10 ] Since we moved to Symfony Console I don't think this is needed anymore. The purpose of this ticket was actually to test our own CLI support, which was dropped. I'm closing the ticket due to this. Reopen if you have any other comment. Comment by Benjamin Eberlei [ 20/May/10 ] I think we do need some basic functional tests of our Commands, they have been subject to many bugs in the past becaues they are not tested. Comment by Benjamin Eberlei [ 19/Jun/10 ] Fixed another fatal error in the command due to missing namespace dependency. We need tests for all the commands, there have been dozens of issues on these things so far. This commit shows a simple approach on how testing is easily possible for symfony commands: http://github.com/doctrine/doctrine2/commit/51e6681934a7cf4448b85c5670c04045f66c6056 Comment by Roman S. Borschel [ 26/Aug/10 ] Can we expect some more tests for beta4 or is it unlikely that you find the time? Should we move this further back or does someone else want to step in?

### [DDC-821] Consider adding Query-Join as another join method for DQL Created: 29/Sep/10  Updated: 29/Dec/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: New Feature Priority: Major Reporter: Marc Hodgins Assignee: Roman S. Borschel Resolution: Unresolved Votes: 1 Labels: None

 Description
 Some ORM systems support an alternative to fetch-join queries, called a "query-join". See http://www.avaje.org/ebean/introquery_joinquery.html. A query-join accomplishes the same as a fetch-join (hydrating a larger object graph across all associations types) but executes more than one SQL query in sequence in order to hydrate the requested portions of the graph in a result set. The first query retrieves data from the base entity/table and the next queries retrieve the data for the requested associations. In some cases this approach is more efficient to a fetch-join: (1) No data duplication in the SQL result as occurs in a fetch-join on to-many associations. Instead, this data is loaded through a second query. This saves network traffic, memory and general overhead in hydrating the returned results. In the case where large TEXT data is included in result sets, the savings here may be substantial. (2) setFirstResult() and setMaxResult() are again effective (for pagination) and more importantly more efficient on these query-joins. The current DoctrineExtension solution to enable pagination on fetch-joins requires a series of queries to determine the target primary keys of the root entity of the query. The primary key lookup query requires DISTINCT or GROUP BY – which often triggers filesorts, temporary tables, etc (at least on MySQL) and greatly slows down the query. Query joins would not require this. Possible implementation example: // existing fetch-join $query =$em->createQuery('SELECT c, o FROM Customers c JOIN c.orders o'); $query->setFirstResult(10)->setMaxResult(20); // doesn't do what you'd hope it would do, no ability to use this for pagination$customersAndOrders = $query->getResult(); // array of Customer objects with Orders hydrated // proposed query-join$query = $em->createQuery('SELECT c, o FROM Customers c QUERY JOIN c.orders o');$query->setFirstResult(10)->setMaxResult(20); // now works for pagination $customersAndOrders =$query->getResult(); // array of Customer objects with Orders hyrdated // this would execute a series of queries -- i.e. in SQL // SELECT ... FROM customers LIMIT 10, 20 // SELECT ... FROM orders WHERE customer_id IN (.....)  and/or, could there be a way to trigger a "query-join" against an existing array of entities? for example $query =$em->createQuery('SELECT c FROM Customers c'); // single query to fetch customers $customers =$query->getResult(); // array of Customer objects $em->join($customers, 'orders'); // fetch and hydrate the 'orders' association on each Customer using a single query  Perhaps at some point in the future Doctrine/DBAL could even make use of asynchronous queries (i.e. mysqlnd supports this) to allow these query-joins to run in parallel and the result would be more efficient paginated resultsets. Thoughts/feedback?

 Comment by Benjamin Eberlei [ 30/Sep/10 ] There is another approach for this using several subqueries to build an IN clause, the Paginator extension supports this: http://github.com/beberlei/DoctrineExtensions I rather go the extension approach than changing the DQL for this feature. Comment by Benjamin Eberlei [ 30/Sep/10 ] I just saw your second example, that is rather cool though and gets +1 from me. I had the same idea for "not initialized proxies", i.e. $em->getUnitOfWork()->initializeProxies('Customer');  Comment by Marc Hodgins [ 29/Dec/10 ] Second example is a duplicate of DDC-734 ### [DDC-810] Issue with detaching entities and updating when using change notification Created: 17/Sep/10 Updated: 04/Jul/11 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: 2.0-BETA4 Fix Version/s: 2.x Security Level: All  Type: Improvement Priority: Major Reporter: Jonathan H. Wage Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None  Attachments: DDC810Test.php  Description  More information coming soon. Attaching a test case  Comments  Comment by Benjamin Eberlei [ 20/Sep/10 ] From reading the issue i know what the bug is, indeed this sucks. Comment by Roman S. Borschel [ 28/Sep/10 ] @Jon: Any more information coming? @Benjamin: Can you summarize the essence of the issue shortly? Comment by Benjamin Eberlei [ 29/Sep/10 ] @Roman: The UnitOfWork (may) still be pushed as a listener into that entity, and still recieve noticies of update. Which may throw notices because the oid hashes are removed everywhere. Additionally you cant serialize the thing because you still got the UoW inside there. Comment by Jonathan H. Wage [ 04/Oct/10 ] I don't have anymore information currently. The issue was relayed to me. I will try and find some more information and report back. Comment by Benjamin Eberlei [ 03/Apr/11 ] There is no way to "fix" this issue, i am turning it into a feature request. There needs to be a "postDetach" event that is triggered where the developer can detach the change notification objects. ### [DDC-1285] Select by multiple ids Created: 22/Jul/11 Updated: 11/Jan/13 Status: In Progress Project: Doctrine 2 - ORM Component/s: Mapping Drivers, ORM Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: Improvement Priority: Major Reporter: Serge Smertin Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 1 Labels: None  Description  How do you look at adding findByIds(array$ids) to EntityManager and UnitOfWork? This would allow fetching multiple entities from a database at one request and would be very useful for caching - there would be even some kind of IdentityMap kept in memcached or any other caching engine, that supports multiple id retrieval: i've been using such an architecture in multiple projects and it turned out to be very effective. There were two basic methods - findIdsByFilter(array $filter) and findEntitiesByIds(array$ids). The latter one had a caching proxy, replicating entities to a cache storage. If this idea proceeds - I'd be glad to cover it with more details. This topic on StackOverflow could also help: http://stackoverflow.com/questions/276709/design-pattern-for-memcached-data-caching

 Comment by Guilherme Blanco [ 20/Dec/11 ] Updating fix version

### [DDC-1264] Add more math related DQL funcs (trig, round, stuff?) Created: 09/Jul/11  Updated: 09/Jul/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: New Feature Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

### [DDC-1262] Have proxies copy docblocks aswell Created: 09/Jul/11  Updated: 09/Jul/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.0.6, 2.1, Git Master
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Whenever a Proxy is generated it does not copy the docblocks. This means when you do something like "$refl = new ReflectionObject($proxy)" you might be in trouble. However if we add docblocks then we have to make sure that proxies do not magically appear as entities by throwing an exception in the AnnotationDriver.

### [DDC-1229] generate entity interactive dialog: id column Created: 27/Jun/11  Updated: 28/Jun/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: Tools
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: David Buchmann Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 according to Stof, this bug https://github.com/sensio/SensioGeneratorBundle/issues/21 comes from the doctrine tools implementation: in the dialog, i first specified that i want a field id of type integer. the result was [Doctrine\ORM\Mapping\MappingException] Duplicate definition of column 'id' on entity 'Liip\DemoBundle\Entity\Event' in a field or discriminator column mapping. and no file was created. The dialog should tell me i can not create a field named id. (Or better ask first if i want my id column named id or something else.) It would be nice if it would write some file even if its not valid, with a warning on top. As it is, i lost all my work of specifying fields. (Luckily was just playing around)

 Comment by Benjamin Eberlei [ 28/Jun/11 ] not a bug, its a feature (though a dumb one). Improvement in a next version.

### [DDC-1219] Remove dependancy on Collection interface in Domain Objects Created: 21/Jun/11  Updated: 04/Jul/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.1
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: André R. Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description

### [DDC-947] Optmize Code-Generation Strategies Created: 24/Dec/10  Updated: 29/Mar/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Jonathan H. Wage Resolution: Unresolved Votes: 0 Labels: None

 Description
 We should optimize code-generation somehow.

 Comment by Benjamin Eberlei [ 29/Mar/11 ] Descheduled to 2.x

### [DDC-896] Use PDepend for Code-Generation Created: 27/Nov/10  Updated: 27/Nov/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: Tools
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Jonathan H. Wage Resolution: Unresolved Votes: 0 Labels: None

 Description
 Our current code-generation tool has many shortcomings and due to its hard to test nature also many (known and unknown) bugs, as well as high maintenance. Since people are overusing this tool and I am sort of annoyed by how much time goes into this we should rewrite this in a two-step procedure: 1. Move code into Common so we can share it between ORM, Mongo and CouchDB. 2. Use PDepend to read an entities source file (it generates an AST) and modify the AST with the required changes. This gives us the advantage of having to maintaining less code for this stuff.

### [DDC-1450] UnitOfWork Transaction Rollback Support Created: 24/Oct/11  Updated: 20/Dec/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 The UnitOfWork does not handle the case very well where a rollback is necessary. Can this be optimized?

 Comment by Guilherme Blanco [ 20/Dec/11 ] Updating fix version

### [DDC-1445] Improve error messages Created: 22/Oct/11  Updated: 20/Dec/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Error messages throughout ClassMetadata validation and UnitOfWork cycles can be significantly improved. Work is being done on: https://github.com/doctrine/doctrine2/tree/ImproveErrorMessages

 Comment by Guilherme Blanco [ 20/Dec/11 ] Updating fix version

### [DDC-1415] EventListener delegate on entity basis Created: 11/Oct/11  Updated: 20/Dec/11

Status: Reopened
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: New Feature Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Comment by Benjamin Eberlei [ 12/Dec/11 ] Removed from master, as i dont like the api at all Comment by Guilherme Blanco [ 20/Dec/11 ] Updating fix version

### [DDC-1398] loading one item at a time when indexBy and EXTRA_LAZY fetch mode is used on a collection Created: 29/Sep/11  Updated: 10/Mar/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: Reio Piller Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 3 Labels: None

 Description

### [DDC-1729] Translate queries into graphs of value objects (instead of array hydration?) Created: 27/Mar/12  Updated: 09/Jun/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: New Feature Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 In decoupled applications the model layer returns "data-transfer-objects" through the boundary into the controller/view layer. It would make sense to have Doctrine directly generate any data-transfer/value-object from native and dql queries.

 Comment by Benjamin Eberlei [ 09/Jun/12 ] Example: $dql = "SELECT new CustomerAddressView(c.id, c.name, a.id, a.street, a.number, a.city, a.code) FROM Customer c INNER JOIN c.address a WHERE c.id = ?1";  This supersedes DDC-1819. 1. One additional property in ResultSetMapping =>$viewModelClass? 2. Changes to Parser (new ... syntax) 3. Changes to sQL Walker? 4. Changes to Hydration (Only object hydration!)

### [DDC-213] Persist order of collections Created: 15/Dec/09  Updated: 16/Oct/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: 2.0
Fix Version/s: 2.x
Security Level: All

 Type: New Feature Priority: Major Reporter: Roman S. Borschel Assignee: Roman S. Borschel Resolution: Unresolved Votes: 10 Labels: None

 Duplicate is duplicated by DDC-181 Order of many-to-many relationship Resolved Reference is referenced by DDC-250 ArrayCollection Key Column @indexBy Resolved

 Description
 A Collection is like a php array, an ordered map. Hence there should be the possibility to persist this order.

 Comment by Christian Heinrich [ 21/May/10 ] Roman, I'd like to do this one as I have currently a use case for this. Do you have any idea of how to do this? What I'm wondering is whether it is possible to implement this without user intervention. (This would simply mean "store the entities as they were added"). But this would need another column in DB that we'd have to add within oneToMany / manyToMany relationships, but in this case one could save a serialized array holding "entityId => position" key / value pairs. Afterwards, one could easily rebuild / reorder the collection via $collection->set($entity, $order[$entity->identifier]); If you've got another thought about this, please don't hesitate to point me into the right direction! Comment by Benjamin Eberlei [ 22/May/10 ] this won't be implemented until 2.1, since its a pretty complex feature. Changes are probably required in: 1. CollectionPersister - Add a new collection persister that takes the position into account 2. SchemaTool - Add a 'col_position' column to either the many-to-many or the one-to-many tables. 3. EntityPersister - Use and extend current order-by support to make the sorting happen You can implement this already though with some performance hit in update scenarios. If you use the ORDER BY support and implement an API around your entity that abstracts those changes and always sets a "position" field on the many entity that is supposed to be sorted. Comment by Roman S. Borschel [ 22/May/10 ] I don't think we necessarily need a new collection persister. Simply adjusting the ManyToManyPersister to be able to deal with it might be sufficient. For OneToMany, that is always persisted from the "many" side, thus there is no collection persister, we would need to adjust the normal persisters. They key element for the user should be a new annotation (or corresponding xml/yaml element) @OrderColumn. By default the order should not be persistent, only when an @OrderColumn annotation is present. The name of the order column can have a default, i.e. "position". Thus this enhancement of persisting the order should be fully backwards compatible. Comment by Roman S. Borschel [ 22/May/10 ] On another note, the getInsertDiff/getDeleteDiff methods of PersistentCollection should already be "ready" for this. That is, when an element in the collection changed only its position, this is already tracked as a change. However the ManyToManyPersister issues no "UPDATE" queries, it simply deletes and inserts. A position change may be more effectively persisted with an UPDATE. Comment by Benjamin Eberlei [ 30/Sep/10 ] From a mailinglist entry, required check/changepoints: 1. ClassMetadata of Many-To-Many associations have to be extended to publish the required datastructure to the ORM. 2. All Metadata Mapping Drivers have to be extended 3. Persisters\ManyToManyCollectionPersister has to be extended to save the key in the many to many table if desired by the user. 4. Schema-Tool has to be extended to create the additional column. 5. PersistentCollection has to be extended so that lazy loading of collections with additional key works. 6. Array- and ObjectHydrator have to be extended to allow fetch join of collections with key column. 7. Discuss wheather to support this for One-To-Many also with the key-column on the many side. This is much more tricky internally though. Comment by Benjamin Eberlei [ 24/Dec/10 ] Push back to 2.x, we will have support for DDC-250 first and for this at a later release. Comment by Thomas Tourlourat - Armetiz [ 07/Feb/12 ] Hi there, I'm looking for this feature. Benjamin Eberlei said that : "You can implement this already", but I don't understand the "how to". Also, The problem should be solve if RDBMS had a "natural" order. An order based on item position inside table. To get this feature without any change on Doctrine, I have remplace the PK defined by the target & mapped field identifier. The new PK is a new field with type "integer" and with auto-increment enable. In this configuration, Doctrine use the "natural" order of the RDBMS. And I can change order of my item inside Collection and persist it. It's an very bad solution, but It work before an official support. Waiting for advices, and solutions, Thomas. Comment by Thomas Tourlourat - Armetiz [ 08/Feb/12 ] Answering to Benjamin Eberlei on the "7. Discuss wheather to support this for One-To-Many also with the key-column on the many side. This is much more tricky internally though.". I think that for One-To-Many relations, if user want to store the collection order, Doctrine can store the One-To-Many as Many-To-Many with a "model" limitation. In that case, if storing order collection for Many-To-Many work, it should work for One-To-Many. What do you think about it ? Comment by Nicolas [ 29/Feb/12 ] I think that it must be possible to have two keys ordering : the order isn't obligatory reversible. For exemple with user and group : You can order groups for one user : with preference by exemple, or importance. And with a different order, users for a group : rank by example. And maybe more, if you decide to add multi-order : an user show group by his rank in it, if his rank is identical, the order is make by love preference, and after by the importance given by the user (not necessary a number, if we imagine filter on them). So a default order can be choice with parametized fields and could be :  @ManyToMany(targetEntity="Group") ... @JoinFields ( rank: { type: int} , preference:{type:int}, importance:{type: string, length: 40} ) @OrderByJoinFields({"rank" = "ASC", "preference"="ASC", "importance"="ASC" } )  In this case the order must be optional and would be clean if another order appears in the same scope (DQL...). And manytomany became virtual entities act as other entities except they don't appears permetting in the same time a better conception. So if the solution take in DDC-181 will become the only solution. This would a good idea to document this. Because, this seems to me a very important point. My last point is even an unique ordering field created in the join table will be a big and usefull improvement. Thank a lot for your beautiful work. Comment by Thomas Tourlourat - Armetiz [ 29/Feb/12 ] In my point of view, a collection can be order in a single way only. If you want to add more than one order between User & Group, it's a new collection, a new relation. Like : User.memberOf() : Group[] Group.members() : User[] Group.importantMembers() : User[] And it's your role to keep a consistency between members & importantMembers array. Because ManyToMany join table is the reflection of a state of an ArrayCollection. It's not a usefull feature to be able to store all of the state of an ArrayCollection, even the order of this Array. It's just a normal feature that is really missing Thomas. Comment by Nicolas [ 29/Feb/12 ] I don't think: If you have three collection, you duplicate one relation 3 times and it's easy in consequence to lost the data integrity and unicity. By example : Thomas have rank 10 in Admin Thomas think the admin group has importance noted 3 on all of his groups. If a responsable of admin group decide to delete Thomas from it. Thomas, in his ordered list of groups, think always to be in group admin. So in my idea, the many to many relation isn't just an array collection, but should be an virtual entity. In UML or in Merise method this is a common problem to have a parametized relation. I think an orm should just implement this. Comment by Thomas Tourlourat - Armetiz [ 29/Feb/12 ] Hum, I agree with you.. In a SQL Schema, it's a good choice to add many fields in a ManyToMany join table to description "order". Comment by Thomas Tourlourat - Armetiz [ 07/Mar/12 ] I just want to add a piece of Doctrine ORM Document : "When working with collections, keep in mind that a Collection is essentially an ordered map (just like a PHP array). That is why the remove operation accepts an index/key. removeElement is a separate method that has O ( n) complexity using array_search, where n is the size of the map." Comment by Thomas Tourlourat - Armetiz [ 23/Mar/12 ] Hi there, After several discussions. on IRC, I have changed my point of view. Doctrine Documentation says : "When working with collections, keep in mind that a Collection is essentially an ordered map (just like a PHP array)". So, I think that Doctrine have to be able to store or not the order of a Collection. By adding a new field on the Joined table to store the position of each elements. But I not agree with @Nicolas. Because in his case, he's talking about Association Class : http://etutorials.org/Programming/UML/Chapter+6.+Class+Diagrams+Advanced+Concepts/Association+Class/ Because he's talking of a business logic, he's talking of a dedicated Entity class. What do you think about it ? Thomas; Comment by Thomas Tourlourat - Armetiz [ 31/Aug/12 ] Any news ? Comment by Matthieu Napoli [ 16/Oct/12 ] Hi, any news on this? If I may add any info to this feature request, maybe something like JPA/Hibernate could be a good start? The idea in Hibernate is that you persist the order of the list in an extra column. This column is not a field of the entity however.

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.0-ALPHA2
Fix Version/s: 2.x
Security Level: All

 Type: New Feature Priority: Major Reporter: Roman S. Borschel Assignee: Roman S. Borschel Resolution: Unresolved Votes: 1 Labels: None

 Reference is referenced by DDC-546 New fetch mode EXTRA_LAZY for collect... Resolved

 Description

### [DDC-298] Allow Entity to hold a collection of a single primitive type Created: 02/Feb/10  Updated: 24/Dec/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.1
Fix Version/s: 2.x
Security Level: All

 Type: New Feature Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 3 Labels: None

 Description
 Sometimes you want to save arbitrary information for an entity using a key -> value array-structure. JPA supports this by means of the @ElementCollection annotation with allows to specify HashMaps for example. I propose a new AssocationMapping called "ElementMapping" / "ElementCollection" and annotations (options): ElementCollection + elementTable + keyType + keyLength + keyColumnDefinition + valueType + valueLength + valueColumnDefinition  The key and value definitions are necessary for converting and schema generation. The implementation would make use of the PersistentCollection at all times and work as any other persistent collection just with primitive types. Restrictions for a first implementation: Only available as a Lazy-Load Collection, no hydration with the source entity Can't be used in queries alike "entity.colname.key = ?1" Use-Case: $entity->options['foo'] = 'bar';$entity->options['bar'] = 'baz';  This could be done for 2.0 imho, adding the necessary changes and optimizations could then be scheduled for 2.1

 Comment by Benjamin Eberlei [ 02/Feb/10 ] In this implementation Schema-Tool would generate a table: elementTable (entity_id-1, ..., entity_id-n, key, value) and using the Platform Type Generation of keyType and valueType Comment by Benjamin Eberlei [ 02/Feb/10 ] Column Names should be Change-able also since there could be people who name their primary keys "key" and "value" o_O Comment by Benjamin Eberlei [ 02/Feb/10 ] Ordering could be implemented on top of this using the @OrderColumn JPA implementation by adding another column to the table with a numeric order that will be "order by"'d on select time. Comment by Benjamin Eberlei [ 24/Dec/10 ] Pushed back

### [DDC-763] Cascade merge on associated entities can insert too many rows through "Persistence by Reachability" Created: 23/Aug/10  Updated: 04/Jul/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Major Reporter: Dave Keen Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 2 Labels: None

 Description
 I think that the UnitOfWork needs to maintain a map of spl_object_hash($newEntity)->$managedEntity for entities that were persisted via reachability during a merge. doMerge should then only call persistNew if the original entity has not already been persisted (if it has already been persisted it should merge the managed entity from the map). The map should be maintained until a flush() or until the UnitOfWork is cleared. The reasoning is as follows. Imagine we have a simple doctor object with no associations: $doctor = new Doctor();$em->persist($doctor);$em->persist($doctor);$em->flush();  After the first persist() $doctor is MANAGED so the second persist has no effect and this results in a single Doctor row. If we do the same thing using merge and persistence by reachability: $doctor = new Doctor(); $em->merge($doctor); $em->merge($doctor); $em->flush();  we get 2 Doctor rows being added. Obviously in this particular case we should use the return value from the first merge() as the parameter of the second merge which would give correct behaviour. However, now imagine one Doctor has many Patients and many Patients have one Doctor, all the associations have cascade merge enabled, and further assume that$d1 (Doctor id=1) is already in the database. We now attempt to create two patients and assign them to the existing doctor: $d1= new Doctor();$d1->id = 1; // This is a DETACHED entity $p1 = new Patient();$p2 = new Patient(); $d1->patients->add($p1); $p1->doctor =$d1; $d1->patients->add($p2); $p2->doctor =$d1; $em->merge($p1); $em->merge($p2); $em->flush();  This actually results in 4 rows being added to the 'patients' table instead of 2, I think because$p1 and $p2 are getting persisted both as the root objects and then again from the patient->doctor->patients array. Since the cascade merging happens internally we can't replace the array contents with the managed return values without walking through the object graph (in which case there is no point in using cascade merge in the first place). Maintaining a map in UnitOfWork will allow doMerge to ensure it doesn't persist the same entities twice. I'm not sure, but this might be relevant for cascade persist too. P.S. Another bug report on this can be found at http://code.google.com/p/flextrine2/issues/detail?id=32 (it basically says the same thing with different entities).  Comments  Comment by Benjamin Eberlei [ 29/Aug/10 ] @Roman A possible fix for this in my opinion is another map in UnitOfWork$mergedEntities = array(); and a patch like this: diff --git a/lib/Doctrine/ORM/UnitOfWork.php b/lib/Doctrine/ORM/UnitOfWork.php index 242d84b..1d0d8b3 100644 --- a/lib/Doctrine/ORM/UnitOfWork.php +++ b/lib/Doctrine/ORM/UnitOfWork.php @@ -1340,6 +1340,10 @@ class UnitOfWork implements PropertyChangedListener return; // Prevent infinite recursion } + if (isset($this->mergedEntities[$oid])) { + return $this->mergedEntities[$oid]; + } + $visited[$oid] = $entity; // mark visited$class = $this->em->getClassMetadata(get_class($entity)); @@ -1468,6 +1472,8 @@ class UnitOfWork implements PropertyChangedListener $this->cascadeMerge($entity, $managedCopy,$visited); + $this->mergedEntities[$oid] = $managedCopy; + return$managedCopy; }  Comment by Dave Keen [ 29/Aug/10 ] I have tested this patch with my application and it fixes the problem in all my relevant test cases apart from one. The test case that's failing is one that persists a bi-directional many to many relationship, so the associations interweave with each other (if you know what I mean). I wonder if perhaps doMerge need to continue cascading even if it finds an item in $this->mergedEntities This is the Flextrine code that fails - it results in no entries in movie_artist. This might also be related to DDC-758? m1 = new Movie(); m1.title = "Movie 1"; m2 = new Movie(); m2.title = "Movie 2"; a1 = new Artist(); a1.name = "Artist 1"; a2 = new Artist(); a2.name = "Artist 2"; m1.artists.addItem(a1); a1.movies.addItem(m1); m1.artists.addItem(a2); a2.movies.addItem(m1); m2.artists.addItem(a1); a1.movies.addItem(m2); m2.artists.addItem(a2); a2.movies.addItem(m2); // These translate to cascade merges on the server em.persist(m1); em.persist(m2); em.persist(a1); em.persist(a2); // Now flush em.flush(); Comment by Dave Keen [ 29/Aug/10 ] P.S. This test passes if I translate em.persist() to$em->persist() (not cascading) on the server instead of translating it to a cascade merge; not sure if that helps Comment by Roman S. Borschel [ 30/Aug/10 ] I'd really like to avoid introducing an additional instance variable just to solve this issue but I did not find the time yet to really look into it. Does someone have a unit test for this already and can attach it to the issue? Comment by Roman S. Borschel [ 31/Aug/10 ] Rescheduling for RC1. Comment by Dave Keen [ 13/Sep/10 ] Here is a functional test case containing three tests: testMultiMerge tests basic merging of two new entities, checking that only a single entity ends up in the database. This passes with Benjamin's patch. testMultiCascadeMerge tests the more complex case of merging a OneToMany association. This also passes with Benjamin's patch. testManyToManyPersistByReachability tests the ManyToMany case described above and this fails with Benjamin's patch, probably because doMerge doesn't cascade down entities that it has already merged and some ManyToMany associations are being ignored. Its a bit hard to be certain what is causing this as even without Benjamin's patch this test would fail due to DDC-758. Comment by Benjamin Eberlei [ 15/Sep/10 ] @Roman i thought about this issue, its not possible without that additional map of merged entities. There is no way we can get that information from other sources. Problem is rather that the use-case probably only applies in mass-merging scenarios and client-server serialization. Comment by Dave Keen [ 21/Sep/10 ] Added another failing test case - adding the same entity from different ends of a many to many bi-directional association to check that there isn't an integrity constraint violation caused by Doctrine trying to add the same row twice. Comment by Dave Keen [ 21/Sep/10 ] Attached a patch for this issue. Comment by Benjamin Eberlei [ 22/Sep/10 ] can you comment why all the additionall stuff is necessary compared to my patch? Comment by Dave Keen [ 22/Sep/10 ] It fixes the two additional test cases - testManyToManyPersistByReachability and testManyToManyDuplicatePersistByReachability. testManyToManyPersistByReachability was failing with your original patch because there are ManyToMany cases where an entity may have already been merged, but its still necessary to add it to an association and continue to cascade. Running the following with the original patch will miss out some of the associations. $m1 = new Movie();$m1->title = "Movie 1"; $m2 = new Movie();$m2->title = "Movie 2"; $a1 = new Artist();$a1->name = "Artist 1"; $a2 = new Artist();$a2->name = "Artist 2"; $m1->artists->add($a1); $a1->movies->add($m1); $m1->artists->add($a2); $a2->movies->add($m1); $m2->artists->add($a1); $a1->movies->add($m2); $m2->artists->add($a2); $a2->movies->add($m2); $em->merge($a1); $em->merge($a2); $em->flush();  The other change in my patch is to protect against this case. It ensures that the following code doesn't add the same entity twice to a collection. $em->merge($m1);$em->merge($m2);$em->merge($a2);$em->merge($a2);$em->flush();  Comment by Benjamin Eberlei [ 31/Oct/10 ] I am not sure if the issue here is rather multiple calls to merge that contain different parts of the same object-graph. There should be a very simple fix for this, call ->clear() after each merge. I am not sure if this patch drags us into a blackhole of issues with merging. Comment by Dave Keen [ 31/Oct/10 ] Calling ->clear() and ->flush() after each merge is a workaround for the simple case, but unless I am misunderstanding I don't think its a solution for cases where the merging is happening automatically in cascadeMerge. I've actually encountered this issue in another project and scenario to do with creating REST APIs and merging JSON objects into entities, and applying the patch fixed it so a) I think this issue might be a more common that we first thought and b) the patch basically seems to work (plus it doesn't introduce any failing cases in the existing test suite). I can actually still find one edge case to do with cascading merging interlinked many to many associations that this doesn't fix, but I was planning to open that as a new ticket after this My feeling is that the current merge already has issues and this definitely improves it. Comment by Benjamin Eberlei [ 01/Nov/10 ] It cannot happen inside a single merge, single merges use the $visited to avoid infinite recursions, each entity can only be merged once inside a single merge operation. Comment by Benjamin Eberlei [ 10/Nov/10 ] Added a note into the documentation about using EntityManager#clear between merging of entities which share subgraphs and cascade merge. Handling this issue in UnitOfwork will be declared an improvement, not a bug anymore and be scheduled for later releases. The required changes to the core are to dangerous and big. Comment by Dave Keen [ 11/Nov/10 ] Where in the docs is that? Just to summarize, the equivalent operation to having multiple merges and a single flush is to call merge followed by flush each time, with the whole thing surrounded by a transaction? Does this have a big impact on performance? Comment by Dave Keen [ 11/Nov/10 ] Ben - even given the decision not to implement this (and I do understand your thinking, as it is a major change), is there any reason not to implement the bit that ensures that the same entity isn't added to a collection twice during a merge? I can't think of a situation where this should be allowed, and I have a use case where I get 'DUPLICATE KEY' errors if this isn't there. Please see attached patch. Comment by Benjamin Eberlei [ 11/Nov/10 ] What bit of that huge patch is that? Can you extract it into another ticket if thats possible? Comment by Benjamin Eberlei [ 11/Nov/10 ] I added it to "Working with Objects" and the descripton of Merge. Its not yet live on the site. Using this current workaround has a performance impact, since more SELECT statements have to be issued against the database. Comment by Dave Keen [ 11/Nov/10 ] Apologies for not being clear - only the 3rd patch (multipleaddmerge.diff) is relevant to the 'DUPLICATE KEY' error I am now talking about, but I'll put it in a nother ticket if you prefer. Comment by Benjamin Eberlei [ 11/Nov/10 ] please add a new ticket, patch looks good. Comment by Dave Keen [ 11/Nov/10 ] Created as DDC-875 ### [DDC-717] Do not use files when using proxy autogeneration Created: 22/Jul/10 Updated: 04/Jul/11 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: Improvement Priority: Major Reporter: Jaka Jancar Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 2 Labels: None  Description  Proxy classes are generated in less than 1ms for me. I prefer to not have a "build" step to reducing loading time by a milisecond, so I use autogenerate. For users like me, wouldn't it be nicer if we wouldn't even have to configure a proxy dir and those files were never written (since they're not read more than once anyway)?  Comments  Comment by Jaka Jancar [ 22/Jul/10 ] This very minimal patch removes the use of these temporary files: --- library/Doctrine/ORM/Proxy/ProxyFactory.php (revision 2) +++ library/Doctrine/ORM/Proxy/ProxyFactory.php (working copy) @@ -78,9 +78,8 @@$fqn = $this->_proxyNamespace . '\\' .$proxyClassName; if ($this->_autoGenerate && ! class_exists($fqn, false)) { - $fileName =$this->_proxyDir . DIRECTORY_SEPARATOR . $proxyClassName . '.php'; -$this->_generateProxyClass($this->_em->getClassMetadata($className), $proxyClassName,$fileName, self::$_proxyClassTemplate); - require$fileName; + $file =$this->_generateProxyClass($this->_em->getClassMetadata($className), $proxyClassName, null, self::$_proxyClassTemplate); + eval('?>'.$file); } if ( !$this->_em->getMetadataFactory()->hasMetadataFor($fqn)) { @@ -144,6 +143,9 @@$file = str_replace($placeholders,$replacements, $file); + if ($fileName === null) + return $file; + file_put_contents($fileName, $file); }  Comment by Benjamin Eberlei [ 23/Jul/10 ] The proxy dir is used for the "doctrine orm:generate-proxies" command in the case of "autogenerate= false", so you need to define it anyways. You have to use proxies, the option is not for Proxy yes/no. If you have autogenerate=false and doctrine requires a proxy for a use case but can't find it you will get a fatal error. Comment by Benjamin Eberlei [ 23/Jul/10 ] I just saw the eval() keyword, ieeks It could maybe be a convenience option for those that don't want to use proxy direcotiries, however i am not sure. Comment by Jaka Jancar [ 23/Jul/10 ] eval() is no different than writing code to a file and using require(). When using runtime-generated proxies, there are no benefits (that I know of) from writing them to a file. The disadvantages are: slower because of write disk access has problems with high concurrency, unless special care is taken (DDC-716) potentially has permission problems if code is executed by different users (e.g. nobody for a daemon and www-data for http) requires setup of a writable directory This is a nicer patch, which makes _generateProxyClass() return a string, just like other _generate* methods: --- library/Doctrine/ORM/Proxy/ProxyFactory.php (revision 2) +++ library/Doctrine/ORM/Proxy/ProxyFactory.php (working copy) @@ -78,9 +78,8 @@$fqn = $this->_proxyNamespace . '\\' .$proxyClassName; if ($this->_autoGenerate && ! class_exists($fqn, false)) { - $fileName =$this->_proxyDir . DIRECTORY_SEPARATOR . $proxyClassName . '.php'; -$this->_generateProxyClass($this->_em->getClassMetadata($className), $proxyClassName,$fileName, self::$_proxyClassTemplate); - require$fileName; + $code =$this->_generateProxyClass($this->_em->getClassMetadata($className), $proxyClassName); + eval($code); } if ( ! $this->_em->getMetadataFactory()->hasMetadataFor($fqn)) { @@ -107,19 +106,19 @@ foreach ($classes as$class) { $proxyClassName = str_replace('\\', '',$class->name) . 'Proxy'; $proxyFileName =$proxyDir . $proxyClassName . '.php'; -$this->_generateProxyClass($class,$proxyClassName, $proxyFileName, self::$_proxyClassTemplate); + $code =$this->_generateProxyClass($class,$proxyClassName); + file_put_contents($proxyFileName, "_generateMethods($class); $sleepImpl =$this->_generateSleep($class); @@ -142,9 +141,9 @@$methods, $sleepImpl ); -$file = str_replace($placeholders,$replacements, $file); +$file = str_replace($placeholders,$replacements, self::$_proxyClassTemplate); - file_put_contents($fileName, $file); + return$file; } /** @@ -244,8 +243,7 @@ /** Proxy class code template */ private static $_proxyClassTemplate = -'; /**  Comment by Benjamin Eberlei [ 24/Jul/10 ] Scheduled usage of eval() for 2.1, if the following conditions exist: 1. Autogenerate is set to TRUE 2. No Proxy Directory is configured. Comment by Jaka Jancar [ 24/Jul/10 ] Great, this is even better. This way you can have 1) autogenerated in ram-only, 2) autogenerated in files and 3) pregenerated. And the minimal amount of config needed to get up and running is reduced, which is always nice. Comment by Benjamin Eberlei [ 24/Jul/10 ] you should know though, eval is dead slow. It generates the necessary proxies on EACH request and that cannot be cached in APC. Comment by Jaka Jancar [ 24/Jul/10 ] It's no slower than current autogeneration (file_put_contents+require). TBH, I don't know why anyone would want to use that over eval(), but I don't mind it being there. Pre-generation is, of course, a different thing. Seems like a valid tradeoff to offer: build/a bit of config/better perfomance vs. no build/no config/potentially slower. Comment by Benjamin Eberlei [ 24/Jul/10 ] Yes, that is because file_put_contents + require is a development only strategy. The manual clearly states that autogenerate has to be false in production. Comment by Roman S. Borschel [ 12/Aug/10 ] Using eval() instead of producing and requiring the file in the case of enabled auto-generation of proxy classes sounds like a good improvement for 2.1 to make proxies more transparent during deveopment and for anyone for whom performance is no issue. I'm increasing the priority as I think it is easy to implement for 2.1 and a good enhancement. Comment by Karsten Dambekalns [ 09/Feb/11 ] A note on why having the proxies written to a file can be useful even with autogenerate being on: it makes it really easy to check the proxy code being generated. I use that a lot currently. The solution suggested, giving three possibilities is cool, though. ### [DDC-676] Find a way to test serialize/unserialize of all ClassMetadata properties in isolation Created: 10/Jul/10 Updated: 29/Aug/10 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None  Description  We should find a way, using PHPUnit Data Providers or anything else, to check the serialize/unserialize of every property in the ClassMetadata instance, since errors here can be very subtle but dangerous. ### [DDC-667] Lock Timeout Query Hint for DQL Queries Created: 04/Jul/10 Updated: 16/Sep/10 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: 2.0-BETA2 Fix Version/s: 2.x Security Level: All  Type: New Feature Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None  Description  After the implementation of DDC-178 there is now only outstanding the support for locking queries based on a given timeout. This will be a DQL query feature only and be available via a query hint: $query->setHint(Query::LOCK_TIMEOUT, $timeoutMs);  It will be only working on Oracle.  Comments  Comment by Roman S. Borschel [ 30/Aug/10 ] If this is to be implemented for 2.0, it needs to happen for RC1, therefore rescheduling to RC1. Feel free to reschedule to 2.x if necessary. Comment by Benjamin Eberlei [ 16/Sep/10 ] Only oracle supports lock timeouts and no other vendor seems to plan to support it. I move to 2.x, but i guess this would rather be an issue of user extension. Allow @Id on @ManyToOne fields (DDC-117) ### [DDC-658] Reverse engineering with Oracle (DBDriver and Associations as Identifier) Created: 27/Jun/10 Updated: 11/Dec/11 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: Sub-task Priority: Major Reporter: Mickael Perraud Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 1 Labels: None Environment: Ubuntu 10.04 + Oracle 11g Entreprise + PHP 5.3.2 + Doctrine2 Git (up-to-date)  Description  I am playing with reverse engineering with Oracle and I have some problems: My schema: drop table PHONE_NUMBER; drop table CUSTOMER; create table CUSTOMER ( CUSTOMER_ID NUMBER(4) not null, CUSTOMER_LASTNAME VARCHAR2(50) not null, CUSTOMER_MODIFIED DATE, constraint PK_CUSTOMER primary key (CUSTOMER_ID) using index tablespace TBS_INDEX storage ( initial 100K next 100K ) ) storage ( initial 100K next 100K ) tablespace TBS_DATA; create table PHONE_NUMBER ( PHONE_NUMBER_ID NUMBER(4) not null, CUSTOMER_ID NUMBER(4) not null, PHONE_NUMBER VARCHAR2(50) not null, PHONE_NUMBERMODIFIED DATE, constraint PK_PHONE_NUMBER primary key (PHONE_NUMBER_ID, CUSTOMER_ID) using index tablespace TBS_INDEX storage ( initial 100K next 100K ) ) storage ( initial 100K next 100K ) tablespace TBS_DATA; alter table PHONE_NUMBER add constraint PHONE_NUMBER__CUSTOMER foreign key (CUSTOMER_ID) references CUSTOMER (CUSTOMER_ID);  I obtain "Fatal error: Uncaught exception 'Doctrine\ORM\Mapping\MappingException' with message 'Property "customerId" in "PhoneNumber" was already declared, but it must be declared only once'" It's because a foreign key is a component of the primary key.  Comments  Comment by Mickael Perraud [ 28/Jun/10 ] This is the continuation of http://www.doctrine-project.org/jira/browse/DDC-616. Only the schema is different. Comment by Benjamin Eberlei [ 28/Jun/10 ] just for understanding this scenario: Is this a One-To-One relation and the TABLE_TEST2 "inherits" the primary key from its parent TABLE_TEST1? If yes, this construct is not yet supported by Doctrine 2, we still need to include an ID-Generator that supports this kind of schema. Comment by Mickael Perraud [ 28/Jun/10 ] Change for a more understandable use case. Note that it's not my real use case and that I work on legacy database on which I can't change the structure. Comment by Benjamin Eberlei [ 01/Jan/11 ] updated the issue topic to get a better grasp of what needs to be done here. Comment by waldo [ 09/Jun/11 ] I have the same error with Mysql whit the same condition. Comment by Benjamin Eberlei [ 28/Nov/11 ] More details on the work to be done: The relevant code is in Doctrine/ORM/Mapping/Driver/DatabaseDriver.php only. The idea is currently many-to-many tables are detected by checking that the table has foreign keys on all the primary key columns (no additional columns!) Now with the 2.1 feature of foreign key/primary key entities this is not necessarily true anymore. You can have the primary keys being foreign keys BUT have additional columns that are not part of the primary key. This has to be detected. If a foreign key-primary-key entity is found that has additional columns a ClassMetadata has to be created and the associations have to be created with the "id" => true flag in mapManyToOne(). Comment by Scott Steffens [ 11/Dec/11 ] For what it's worth, I'm getting this error when I have a PK that is a single column and not a FK. PRIMARY KEY (id), UNIQUE KEY cycle_station_id (cycle,station_id), KEY station_id_idx (station_id), KEY readings (readings), KEY source (source), KEY temperature_min_max (temperature_max,temperature_min), KEY station_id_cycle (station_id,cycle,updated_at), CONSTRAINT compiled_1_station_id_stations_id FOREIGN KEY (station_id) REFERENCES stations (id), CONSTRAINT compiled_1_station_id_stations_id_1 FOREIGN KEY (station_id) REFERENCES stations (id) ON DELETE CASCADE ) ENGINE=InnoDB AUTO_INCREMENT=160833690 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci ### [DDC-624] Partial object query that leaves out an association to avoid loading it fetches the association anyway. Created: 03/Jun/10 Updated: 11/Nov/11 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: 2.0-BETA1 Fix Version/s: 2.x Security Level: All  Type: Bug Priority: Major Reporter: Roman S. Borschel Assignee: Roman S. Borschel Resolution: Unresolved Votes: 2 Labels: None Issue Links:  Duplicate is duplicated by DDC-1465 Fetching partial objects doesn't work... Open  Description  Assuming: Customer Cart where Cart is the owning side. Since the association from Customer to Cart can not be lazy, it would make sense to leave out the association in a query to avoid loading the carts like this: select partial c.{id,name, ... anything except cart} from Customer c"  But this is ignored and the carts of all customers are fetched anyway. Query::HINT_FORCE_PARTIAL_LOAD is an alternative solution, however it has the disadvantage that it disables lazy-loading for all queried objects. If partial querying would honor associations this would allow more fine-grained control.  Comments  Comment by Roman S. Borschel [ 26/Aug/10 ] Might need to be pushed back to a 2.0.x / 2.x.x bugfix release. Not clear yet. ### [DDC-668] add upsert support Created: 04/Jul/10 Updated: 20/Dec/11 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: New Feature Priority: Major Reporter: Lukas Kahwe Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 4 Labels: None  Description  Didnt find anything in the docs on this. Is D2 capable of doing an UPSERT [1] in case I am trying to persist an object that may or may not have been saved previously. Different RDBMS support different syntax for this case. Like MySQL has INSERT .. ON DUPLICATE KEY UPDATE (or even INSERT IGNORE) while the SQL standard defines a MERGE syntax which seems to be gaining support. Of course you can always fallback to a SELECT FOR UPDATE (or if you want to be hacky an INSERT which catches duplicate key violations .. but probably not a good idea since many RDBMS rollback on a failure inside a transaction). See also http://opensource.atlassian.com/projects/hibernate/browse/HHH-3011 asking for MERGE support Ideally there would be a way to define on a model or model instance level if merge logic should be applied.  Comments  Comment by Robert Burkhead [ 09/Jul/10 ] Doctrine_Record defines a replace() method. In the MySQL Doctrine implementation, however, it is not the same as INSERT .. ON DUPLICATE KEY UPDATE. The replace() method implemented in Doctrine_Connection_Mysql uses the REPLACE INTO syntax, which is a DELETE and then INSERT when the key exists. This is fine, except for tables that use auto-increment fields. The delete-then-insert operation yields a new auto-incremented value, whereas INSERT .. ON DUPLICTATE KEY UPDATE would not. Comment by Lukas Kahwe [ 09/Jul/10 ] MySQL (and SQLite) REPLACE is a no go. It causes way too much disc I/O and worse yet totally screws up the on disk data structures because of the deleting. Comment by Benjamin Eberlei [ 31/Jul/11 ] Scheduled for 2.2 Comment by Benjamin Eberlei [ 31/Jul/11 ] Evaluating this makes me sad, except MySQL support for this is rather non-existant, and the oracle merge is aiming at batch operations. Comment by Benjamin Eberlei [ 22/Oct/11 ] Should this be done with 1. Select first, then insert 2. Catch and evaluate exception then update I am leaning towards 1. Comment by Guilherme Blanco [ 20/Dec/11 ] Updating fix version ### [DDC-93] It would be nice if we could have support for ValueObjects Created: 01/Nov/09 Updated: 14/Apr/13 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: New Feature Priority: Major Reporter: Avi Block Assignee: Guilherme Blanco Resolution: Unresolved Votes: 37 Labels: None Issue Links:  Duplicate is duplicated by DDC-648 Custom mapping types for multiple DB ... Resolved Reference is referenced by DDC-2374 [GH-634] [WIP] Value objects Open  Description class User { /** * @Column(type="string") */ private$address;

/**
* @Column(type="string")
*/
private $city; /** * @Column(type="string") */ private$state;
}


We could have:

class User {
/**
*/

### [DDC-838] SchemaTool - ignores the attribute uniq in relations Created: 13/Oct/10  Updated: 29/Oct/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: Tools
Affects Version/s: 2.0-BETA4
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Minor Reporter: gektor Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None Environment: Ubuntu, PHP 5.3.2, MySQL

 Description
 Mapper   SQL CREATE TABLE test (id INT AUTO_INCREMENT NOT NULL, users_id INT DEFAULT NULL, blabla TINYINT(1) NOT NULL, UNIQUE INDEX test_users_id_uniq (users_id), PRIMARY KEY(id)) ENGINE = InnoDB; ALTER TABLE test ADD FOREIGN KEY (users_id) REFERENCES users(id) ON UPDATE CASCADE ON DELETE CASCADE;  Actual: UNIQUE INDEX test_users_id_uniq (users_id) Expected: INDEX test_users_id (users_id)

 Comment by Benjamin Eberlei [ 14/Oct/10 ] Verified, i just don't understand why you are using a one-to-one relation and then "deactivate" the database constraint for this. You could easily use Many-To-One Comment by gektor [ 14/Oct/10 ] You are right. It's not a bug, it's feature. Comment by Benjamin Eberlei [ 29/Oct/10 ] This might still be a good improvement to allow the flexibility, but its not a bug. Updating to "Minor Improvmenet for 2.x"

### [DDC-1373] Map file with specific class Created: 13/Sep/11  Updated: 14/Feb/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: Mapping Drivers
Affects Version/s: 2.1.1
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Minor Reporter: Thomas Tourlourat - Armetiz Assignee: Fabio B. Silva Resolution: Unresolved Votes: 0 Labels: None Environment: Debian LAMP - PHP5.3 - Apache 2

 Description
 Hi there, AbsractFileDriver is using the filename to know the managed class. It's a cool feature because it's allow loading on-demand. The problem is, that the filename must be the name of the Class. It should be great to be able to manually map XML/YAML File description to a Class, like : $drivers->addMappingFile ( array ( "filename" => "class", "filename2" => "class2") ); This feature is simple to implement, just add a new array inside AbsractFileDriver to know the mapping. When using the current method with addPaths, parse the folder to get traditional XML/YAML file where filename corresponding to classname and add it to the mapping array. AbsractFileDriver->getAllClassNames () just return value of mapping array. The mapping array is store inside cache. With this new feature, it allow developers to create a pretty folder that contains entities mapping. Armetiz.  Comments  Comment by Guilherme Blanco [ 20/Dec/11 ] Updating fix version ### [DDC-1370] preInsert, postInsert, prePersist, postPersist, preUpdate, postUpdate code and documentation of events Created: 09/Sep/11 Updated: 20/Dec/11 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: Improvement Priority: Minor Reporter: Guilherme Blanco Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 1 Labels: None  Description  Currently we have a set of Lifecycle events, but they seem to be misleading both in actual implementation and documentation. One good example is prePersist and postPersist, which is only fired when you're creating new entities. It should be renamed to preInsert and postInsert. As of preUpdate and postUpdate, they seem quite valid. But if we rename prePersist and postPersist to (pre|post)Insert, we may have a situation where you wanna cover both insert and update. For this, (pre|post)Persist should be reinstated, but acting differently from what it does currently.  Comments  Comment by Rafael Dohms [ 09/Sep/11 ] Also, documentation for post* methods is broken at the website: "Changes in here are not relevant to the persistence in the database, but you can use this events to" It cuts off in mid-sentence. Comment by Guilherme Blanco [ 09/Dec/11 ] RDohms, this paragraph was already sorted out. The actual ticket is still valid here. Comment by Guilherme Blanco [ 20/Dec/11 ] Updating fix version ### [DDC-17] Ability to skip the operation from a pre-operation event handler Created: 20/Sep/09 Updated: 26/Aug/10 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: New Feature Priority: Minor Reporter: Ismo Toijala Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None  Description  In Doctrine 1.1 it is possible to skip the operation in the event handlers in Doctrine_Record_Listener using Doctrine_Event::skipOperation. This no longer seems to be possible in Doctrine 2.0 Alpha 1, for example when handling a preRemove event to implement soft-delete behaviour. Perhaps a method could be added to \Doctrine\Common\EventArgs\LifecycleEventArgs to skip the operation, at least before the operation. Without this implementing soft-delete would require the user to update deleted_at and deleted_by himself and then save the record. It could no longer be done automatically when removing a record because the record is then removed.  Comments  Comment by Roman S. Borschel [ 20/Sep/09 ] The problem is, full support for soft-delete throughout the system is not feasible and very fragile. Simple soft-delete through skipping the delete operation is the easiest part. Then you will probably want to modify all DQL queries so that they adhere to it automatically and then there will always be still queries that do NOT go through DQL, like even internal lazy-load queries or native queries or others, which would need to be modified also. To sum it up, implementing soft-delete "inside" doctrine is absolutely not worth the effort and imho a bad idea and I'm certainly not willing to make lots of adjustments to the core that have a negative impact on performance just to make this soft-delete possible. I really recommend handling "soft" deletes yourself, the normal way, by simply abstracting entity retrieval and persistence through a DAO/repository layer. As a nice side-effect you get less magic and it still works when you swap out doctrine for another persistence provider. I am willing to add support for skipping deletes and maybe some other operations through events but I'm not willing to go any further, as explained above. ### [DDC-547] Consider allowing custom PersistentCollection implementations Created: 27/Apr/10 Updated: 24/Dec/10 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: 2.0-BETA1 Fix Version/s: 2.x Security Level: All  Type: New Feature Priority: Minor Reporter: Roman S. Borschel Assignee: Roman S. Borschel Resolution: Unresolved Votes: 6 Labels: None  Description  We should consider allowing the configuration of custom PersistentCollection implementations on a per-association basis. This could allow users to craft optimized (SQL) behavior for for some of their collections to improve performance without changing the domain model code. For this, PersistentCollection needs to be designed for inheritance.  Comments  Comment by Roman S. Borschel [ 26/Aug/10 ] Rescheduled for 2.1. Might be 2.x. Comment by Benjamin Eberlei [ 24/Dec/10 ] Reschedule for 2.x ### [DDC-445] Evaluate possible ways in which stored procedures can be used Created: 19/Mar/10 Updated: 24/Dec/10 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: None Fix Version/s: 2.x Security Level: All  Type: Improvement Priority: Minor Reporter: Roman S. Borschel Assignee: Roman S. Borschel Resolution: Unresolved Votes: 1 Labels: None Issue Links:  Reference relates to DDC-391 Allow to specifiy custom Entity and C... In Progress  Description  We should evaluate the current situation of stored procedure support as well as where we want to go with it / how far we want to support it, if at all.  Comments  Comment by Benjamin Eberlei [ 19/Mar/10 ] I think this relates to the usage of Custom Persisters ### [DDC-391] Allow to specifiy custom Entity and Collection Persister classes Created: 06/Mar/10 Updated: 24/Sep/12 Status: In Progress Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: 2.0-ALPHA4 Fix Version/s: 2.x Security Level: All  Type: New Feature Priority: Minor Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 5 Labels: None Issue Links:  Reference is referenced by DDC-445 Evaluate possible ways in which store... Open is referenced by DDC-699 ProxyFactory: allow to overwrite$_pr... Resolved

 Description
 It should be allowed to overwrite the default persisters for collections and entities. This should go along the lines of Hibernate which allows to set the custom implementations like: XML:   Annotation /** * @Entity(persister="persisterClass") * @OneToMany(persister="persisterClass") */ 

 Comment by Roman S. Borschel [ 19/May/10 ] Rescheduling for beta3. Comment by Roman S. Borschel [ 07/Jul/10 ] Pushing back to beta4. Comment by Roman S. Borschel [ 12/Jul/10 ] Moved to 2.1 due to lack of time for any larger new features for 2.0. Comment by Benjamin Eberlei [ 13/Oct/10 ] implemented this in a feature branch for now, it really doesnt touch any other runtime code so maybe we can still merge this before RC1 http://github.com/doctrine/doctrine2/tree/OverridePersisters Comment by Gediminas Morkevicius [ 25/Feb/11 ] Is this forgotten? you should merge it since it does not affect any other parts of ORM, this is a great feature Comment by Benjamin Eberlei [ 26/Feb/11 ] This has not been forgotten, but the Persister is due for a heavy refactoring for 2.2 probably, when we will make it use the SQL Query object that we are working on. So I cannot merge this, because the API will probably break big time. Comment by Jonas Wouters [ 16/Mar/11 ] Does that mean we will not see this feature before 2.2? Comment by Benjamin Eberlei [ 16/Mar/11 ] Yes, that is correct. I dont want to add it as experimental/undocumented feature because people will take it for granted and make us responsible for possible bc breaks. I will update the target version accordingly. Sorry for disappointing you, but this feature is fundamentally important at the core of the library. That means we have to get it right and not rush into it. Comment by Gediminas Morkevicius [ 17/Mar/11 ] Just as I thought that first you will want to make a query builder object for all persisters. since now they use plain sql. Thanks for all your work on this Comment by Adam Brodziak [ 11/Jan/12 ] I might be mistaken, but AFAICS mentioned Persister heavy refactoring did not made through to 2.2 version. Is there any plan to have it in 2.3 or at any later stage? Comment by Guilherme Blanco [ 13/Jan/12 ] @Adam I refactored all Persisters optimizing their code, but I could not complete the move from SQL string generation to Doctrine\DBAL\Query. We missed it, yes. I may reschedule for 2.3 Comment by Thomas Rothe [ 05/Sep/12 ] Why is it still missing in 2.3? I would require this for an extension that uses its own overridden entity persister and using a custom persister is the solution that you guys recomend for not overriding the entity manager. Comment by sebastiaan stok [ 23/Sep/12 ] Any change seeing this soon? I really need this for a security feature. What is making this so hard? just adding an setEntityPersister($entityName,$object) should do the trick. I don't need any fancy stuff, just a way to limit the fields in the SELECT list. Edit: OK, I'm shot I CAN NOT overwrite the entity manager as the UnitOfWork is private! Got any other idea? Comment by Stefan Kögel [ 24/Sep/12 ] Any chance you could add this quickly? I need this feature urgently to complete an extension using a custom persister. Thanks in advance.

### [DDC-4] Implement support for Concrete Table Inheritance Created: 09/Sep/09  Updated: 24/Dec/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.1
Fix Version/s: 2.x
Security Level: All

 Type: Improvement Priority: Minor Reporter: Roman S. Borschel Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None

 Description
 A first implementation could probably live without support for polymorphic queries (requires SQL UNIONs to be generated).

### [DDC-691] doctrine.readOnly query hint Created: 15/Jul/10  Updated: 31/May/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: DQL, ORM
Affects Version/s: None
Fix Version/s: 2.x
Security Level: All

 Type: Sub-task Priority: Minor Reporter: Roman S. Borschel Assignee: Roman S. Borschel Resolution: Unresolved Votes: 5 Labels: None

 Description
 Setting such a query hint to TRUE should result in all entities being retrieved by that query to be read-only for the purposes of change-tracking. Note that the entities themselves need not necessarily be read-only in general. This feature is a flush performance tweak that can be used to query for objects but not let the returned objects run through change-tracking on flush. Any other managed objects are tracked as usual so you can do a read-only query for 100 entities and persist a new entity in the same unit of work with optimal flushing performance.

 Comment by Konstantin [ 26/Dec/11 ] Any news? Why query hint? What about temporary switching like fetch mode changing via query object? Comment by Gigi Largeanus [ 31/May/12 ] Any news on this? I think this is a must have feature. Thanks for all your work.

### [DDC-2133] Issue with Query::iterate and query mixed results Created: 09/Nov/12  Updated: 01/May/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.2.1
Fix Version/s: 3.0
Security Level: All

 Type: Bug Priority: Major Reporter: Oleg Namaka Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Duplicate is duplicated by DDC-1314 DQL permits partial select using SQL Resolved

 Description
 Consider this code: $dql = " SELECT Page, Product.name FROM Dlayer\\Entity\\Page Page INNER JOIN Page.Product Product ";$q = ($em->createQuery($dql)); foreach ($q->iterate() as$entry) { $page =$entry[0][0]; $name =$entry[0]['name']; }  This results with undefined index: 'name' for the second entry. First result keys are (notice just one array element with index 0): 0 array(2) { [0] => int(0) [1] => string(4) "name" }  but all others are different (notice two array elements with index 0 and the other one that is incrementing): the second one: 0 array(1) { [0] => int(0) } 1 array(1) { [0] => string(4) "name" } the third one: 0 array(1) { [0] => int(0) } 2 array(1) { [0] => string(4) "name" }  What's wrong with this approach? Is it a bug or mixed results should not be used with the iterate method?

 Comment by Benjamin Eberlei [ 12/Nov/12 ] This is a known issue that we don't have found a BC fix for and as I understand Guilherme Blanco requires considerable refactoring.

### [DDC-2316] [GH-588] ClassMetadataInfo: use reflection for creating new instance (on PHP >=5.4) Created: 23/Feb/13  Updated: 04/May/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 This issue is created automatically through a Github pull request on behalf of Majkl578: Message: On PHP >=5.4, use proper way for instantiating classes without invoking constructor.

 Comment by Benjamin Eberlei [ 04/May/13 ] Scheduling this for 3.0, when we move to php 5.4 or higher requirement

### [DDC-1995] "Query Exception: Invalid parameter number: number of bound variables does not match number of tokens" when using an "Instance Of" expression Created: 22/Aug/12  Updated: 29/Aug/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: DQL
Affects Version/s: Git Master
Fix Version/s: Git Master
Security Level: All

 Type: Bug Priority: Major Reporter: Craig Marvelley Assignee: Guilherme Blanco Resolution: Unresolved Votes: 0 Labels: None

 Description
 Similar to this issue I think, but triggered when performing a query on entities modelled with Class Table Inheritance, e.g. $qb =$repository->createQueryBuilder('entity'); $metadata =$em->getClassMetadata($class);$qb->where('entity INSTANCE OF :type')->setParameter('type', $metadata);$qb->getQuery()->execute(); Seems that there isn't a corresponding entry in the parameter mapping array for this clause, which triggers the exception at line 254 of Doctrine\ORM\Query: if (count($paramMappings) != count($this->parameters)) { throw QueryException::invalidParameterNumber(); }

 Comment by Craig Marvelley [ 22/Aug/12 ] Pull request with a potential fix: https://github.com/doctrine/doctrine2/pull/429 Comment by Benjamin Eberlei [ 29/Aug/12 ] Assigned to Guilherme

### [DDC-1963] Remove by-ref access to changeset in lifecycle event args Created: 31/Jul/12  Updated: 31/Jul/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: Git Master
Security Level: All

 Type: Improvement Priority: Major Reporter: Marco Pivetta Assignee: Marco Pivetta Resolution: Unresolved Votes: 0 Labels: None

 Description
 UoW currently passes computed changesets to lifecycle event args byref. This has to be changed to force users to use UoW public API to modify changesets instead.

### [DDC-2061] Matching Criteria on a PersistentCollection only works on OneToMany associations Created: 08/Oct/12  Updated: 08/Oct/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: Git Master
Fix Version/s: Git Master
Security Level: All

 Type: Improvement Priority: Major Reporter: Terje Bråten Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 2 Labels: criteria, matching

 Description
 What is needed to make it also work for ManyToMany associations? May be a better fallback would be do an ArrayCollection->matching() instead of just giving a runtime exception? Is this something that is difficult to implement?

### [DDC-2332] [UnitOfWork::doPersist()] The spl_objact_hash() generate not unique hash! Created: 05/Mar/13  Updated: 01/Apr/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Bug Priority: Critical Reporter: Krisztián Ferenczi Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None Environment: Symfony 2.1.8, php 5.4.7 and php 5.4.12, Windows 7

 Attachments: hashlogs.txt

 Description
 I created fixtures and some data was inserted many times without calling the Task entity PrePersist event listener. I printed the used and generated hash and I saw a Proxies_CG_\Asitly\ProjectManagementBundle\Entity\User hash equal a Task entity hash!

 Comment by Marco Pivetta [ 05/Mar/13 ] Please provide either a code example or a test case. As it stands, this issue is incomplete Comment by Benjamin Eberlei [ 05/Mar/13 ] Are you calling EntityManager#clear() inbetween? Because PHP reuses the hashes. The ORM accounts for this. Comment by Benjamin Eberlei [ 05/Mar/13 ] This is not a reproduce case, i don't want to execute your whole project. I want to know, what is the actual bug that you see? Can you just print a list of all the hashes? Because the hashes dont differ at the end, bu tjust somewhere in the middle. Comment by Krisztián Ferenczi [ 05/Mar/13 ] I attached a hashlogs.txt file. The last Task class hash is 0000000050ab4aba0000000058e1cb12 ( line 3 129 ) This is not unique, view the line 2 760 . The Task is not being saved and the program don't call the prePersist listener. The "UnitOfWork" believe the entity has been saved because the isset($this->entityStates[$oid]) is true. But it is an other entity. Comment by Krisztián Ferenczi [ 06/Mar/13 ] The EntityManager::clear() fix the problem, but this is not "good" and "beautiful" solution. Shows no sign of that conflicts were and this is causing the problem. I was looking for the problem 7 hours.

### [DDC-2237] oracle IN statement with more than 1000 values Created: 11/Jan/13  Updated: 02/Apr/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.2.2
Fix Version/s: None
Security Level: All

 Type: Bug Priority: Critical Reporter: Marc Drolet Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 If I have a query with a IN statement with more tahn 1000 values I get an sql error. I've try IN with implode: select * from test where id IN(' . implode(',', $values) . ') and I've also try with executeQuery: select * from test where id IN(:test) executeQuery($sql, array($values), array(\Doctrine\DBAL\Connection::PARAM_INT_ARRAY))  Comments  Comment by Marc Drolet [ 11/Jan/13 ] Here is the way I've implement the solution on my side: (for oracle) into Doctrine/DBAL/Statement.php, I've add this method: /** * Binds a parameter value to the statement. * This is implemented this way for oracle only. Other drivers are redirected to bindValue method. * * The value will be bound with to the type provided (that required to be a table type). * * @param String$name The name or position of the parameter. * @param Array $value The value of the parameter. * @param String$type The name of the type to use to bind. * @return boolean TRUE on success, FALSE on failure. */ public function bindList($name, Array$value, $type) { if ('oracle' !==$this->platform->getName()) { $this->bindValue($name, $value,$type); } else { return $this->stmt->bindList($name, $value,$type); } }  into Doctrine/DBAL/Driver/Statement.php I've add: /** * @TODO: docs */ function bindList($param, Array$values, $type);  into Doctrine/DBAL/Driver/OCI8/OCI8Statement.php I've add this method: /** * {@inheritdoc} */ public function bindList($param, Array $value,$type) { if (!($list = oci_new_collection($this->_dbh, $type))) { //throw new OCI8Exception::fromErrorInfo($this->errorInfo()); } foreach ($value as$entry) { $list->append($entry); } if (!oci_bind_by_name($this->_sth,$param, $list, -1, OCI_B_NTY)) { //throw new OCI8Exception::fromErrorInfo($this->errorInfo()); } }  // NOTE: we should probably add the bindList to all driver Statement object. into your code you can use it this way: $sql = " SELECT * FROM test WHERE id IN ( SELECT * FROM ( CAST (: p_ids AS list_int_type) ) ) ";$stmt = connection->prepare($sql);$stmt->bindList(': p_ids', $ids, 'list_int_type');$stmt->execute(); $rs =$stmt->fetchAll(PDO::FETCH_ASSOC);  NOTE: list_int_type need to be a valid oracle data type. You can create one with the name you want. example: you can have 2 type of accepted array of values: integer and string let's say we create one for string named: list_str_type and one for integer list_int_type create or replace type list_str_type as table of varchar2(4000); create or replace type list_int_type as table of number; Comment by Benjamin Eberlei [ 01/Apr/13 ] Hey Marc Drolet thanks for the feedback and the solution, however i would like to have something generic that is working independent of the database driver. This code is very specific. Can you point me to some documentation why oci collection works with more than 1000 elements and how it works in PHP? Comment by Marc Drolet [ 02/Apr/13 ] Hi Benjamin, The limitation is not from the oci driver, it's an oracle limitation. There are a couple of possible solution/implementation that can be done but the one I've provide is the one that perform better for the test I've done and from what I can found over the blogs I've read. I can't find the exact documentation of oracle. oracle doc is so poor. Here is the best description link I can provide that describe some possible implementation. http://vsadilovskiy.wordpress.com/substituting-a-collection-for-in-list-performance-study/ I don't know if there is similar limitation with other database. With the implementation I've provided, It will be possible to implement the proper solution depending on the database limitation you face otherwise it will execute the generic IN. What's bad, we need to create the type into the database. NOTE: In my case, I can not perform a sub-query, I get the my collection from a web service call.

### [DDC-2441] Incorrect SQL Query being generated Created: 09/May/13  Updated: 09/May/13

Status: Open
Project: Doctrine 2 - ORM
Component/s: DQL
Affects Version/s: 2.4
Fix Version/s: None
Security Level: All

 Type: Bug Priority: Critical Reporter: Paul Mansell Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None Environment: Using Doctrine in Symfony 2.2.1 on Windows Platform

 Description

### [DDC-851] Automerge of detached entities passed to doctrine Created: 31/Oct/10  Updated: 30/Dec/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.0-BETA4
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Daniel Alvarez Arribas Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None

 Description
 This is a feature request. Currently it is not possible to assign a detached entity to a relationship. You have to manually "merge" it, and only then you are able to assign it to relationships of managed objects. This can become complicated to do. The way it is now, when assigning an entity to a relationship in a process using a large number of entities, the entity's state needs to be checked and the entity possibly merged - all in userland code. This adds a level of complexity and potential for errors, while it could be solved transparently and elegantly within the ORM. There are ways to implement it in userland code, too, with moderate effort (see below), but this does not change the fact that responsibility for implementing a purely technical feature is delegated to the user, who could be spending his time much better writing business code. And if the user actually implements it, it will clutter the application with non-problem-domain code. To keep things simple, I propose Doctrine be extended to simply auto-merge any detached entities passed to it. That would save the programmer the manual tracking of object states and merge() calls. This would be especially handy when using cascades, as keeping track of deep object graphs in userland code would duplicate substantial ORM functionality. In programs that work with massive amounts of data, it is practically impossible to keep all entities managed due to resource constraints (see e.g. the batch processing patterns documented in the Doctrine 2 reference at http://www.doctrine-project.org/projects/orm/2.0/docs/reference/batch-processing/en). In a situation like that, one would probably simply flush and clear the entity manager regularly. Doctrine 2 currently forces the user to manually "merge" all persistent objects he/she still holds references to and wants to assign e.g. to other newly created persistable objects. I can not think of any reason why Doctrine 2 should not be able to do it automatically. Below is another comment originally attached to the GitHub proposal, containing a userland implementation of the feature as a temporary fix, for whoever cares. Here is a userland implementation for the functionality I am proposing, though I feel it is technical clutter that belongs into the ORM. Changing doctrine to be able to auto-merge unmanaged entities would be ideal. I thought I'd share this, for use as long as Doctrine 2 does not provide equivalent functionality. The implementation assumes all entities inherit from a base class (named "YourEntityBaseClass here") and intercepts the assignment to ToOne-relationships in a __set() method provided in that base class. For ToMany-relationships we extend ArrayCollection to intercept calls to add() and set() to accomplish the same. As an alternative to defining a __set() method in a base class you could also implement the interception by changing any mutator methods you define in your entities. But that would bloat your code quickly as you define more and more relationship attributes on your entities. The following __set() method implementation relies on reflection to parse the DocBlock-Comment with the Annotation and determine whether or not the property to be set is a ToOne-relationship.  public function __set($name, &$value) { $reflectionClass = new ReflectionClass($this); $property =$reflectionClass->getProperty($name); if ( self::isToOneRelationship($property) && $value !== null) {$value = self::mergeIfDetached($value); }$this->$name =$value; }  The following is an implementation of mergeIfDetached(), that assumes there is a __get defined on the entity, to be able to access the protected mapped properties. public static function mergeIfDetached(YourEntityBaseClass $dataObject) {$doctrineEntityManager = DB::getDoctrineEntityManager(); if ($doctrineEntityManager->getUnitOfWork()->getEntityState($dataObject) == \Doctrine\ORM\UnitOfWork::STATE_DETACHED) { $dataObject =$doctrineEntityManager->merge($dataObject); } return$dataObject; }  For your purposes, consider DB to be just a class holding a reference to the Doctrine entity manager. Here are the helper methods for the reflection:  private static function isToOneRelationship(ReflectionProperty $property) { return self::matchDoctrineAnnotation($property, self::$doctrineToOneRelationshipAnnotation); } private static function matchDoctrineAnnotation(ReflectionProperty$property, $pattern) { return preg_match('/\@' .$pattern . '/', $property->getDocComment()) != 0; }  Here is the drop-in-replacement class for use with ToMany-Relationships. It uses the static reloadIfDetached method defined in the entity base class: use Doctrine\Common\Collections\ArrayCollection; class Collection extends ArrayCollection { public function set($key, $value) {$value = YourEntityBaseClass::mergeIfDetached($value); parent::set($key, $value); } public function add($value) { $value = YourEntityBaseClass::mergeIfDetached($value); return parent::add($value); } }  This approach keeps the amount of unnecessary code to a minimum, so that merges are not scattered throughout the problem-domain code.  Comments  Comment by Daniel Alvarez Arribas [ 29/Dec/10 ] I have to note that the code I listed above turned out to be broken. There is nothing that guarantees that a data object just merged will not become detached again after being merged on assignment, unless the object is immediately persisted afterwards. The correct solution would be to merge all data objects found through relationships for a given data object, right from the persistence manager, immediately before calling persist() on the data object. I am currently using this solution (save() saves a data object safely for use within long-running batch jobs):  public static function save(DataObject$dataObject) { self::mergeRelatedDataObjectsIfDetached($dataObject); self::$doctrineEntityManager->persist($dataObject); } public static function merge(DataObject$dataObject) { return self::$doctrineEntityManager->merge($dataObject); } protected static function mergeRelatedDataObjectsIfDetached(DataObject $dataObject) {$reflectionClass = new ReflectionClass($dataObject);$properties = $reflectionClass->getProperties(); foreach ($properties as $property) {$propertyName = $property->getName();$propertyValue = $dataObject->__get($propertyName); if (MetadataReader::isToOneRelationship($property)) { if ($propertyValue !== null && ! $propertyValue instanceof Proxy && self::isDetached($propertyValue)) { $relatedDataObject = self::merge($propertyValue); $dataObject->__set($propertyName, $relatedDataObject); } } else { if (MetadataReader::isToManyRelationship($property)) { $relatedDataObjects =$propertyValue->toArray(); foreach ($relatedDataObjects as$index => $relatedDataObject) { if ( !$relatedDataObject instanceof Proxy && self::isDetached($relatedDataObject)) {$relatedDataObject = self::merge($relatedDataObject); // Replace the entry in the collection with the merged copy.$propertyValue->set($index,$relatedDataObject); } } } } } } protected static function isDetached(DataObject $dataObject) { return self::$doctrineEntityManager->getUnitOfWork()->getEntityState($dataObject) == UnitOfWork::STATE_DETACHED; }  I still wish there would be an automerge feature, kind of Hibernate's "update". Comment by Daniel Alvarez Arribas [ 29/Dec/10 ] Wrapped the code sections into proper code blocks... ### [DDC-813] Validate Schema should complain on bi-directional relationships with mapped superclasses Created: 21/Sep/10 Updated: 29/Oct/12 Status: Open Project: Doctrine 2 - ORM Component/s: Tools Affects Version/s: 2.0-BETA4 Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None  Description  @ManyToOne and @OneToOne on mapped superclasses have to be unidirectional. The Schema Validator should verify this. ### [DDC-803] Create subselect queries within join statements Created: 14/Sep/10 Updated: 14/Sep/10 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: None Fix Version/s: None Security Level: All  Type: New Feature Priority: Major Reporter: Martijn Evers Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None ### [DDC-785] Post-Post-Persist event Created: 02/Sep/10 Updated: 14/Jan/11 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: 2.0-BETA4 Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: arnaud-lb Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None  Description  postPersist/postUpdate events are triggered in the middle of a unitOfWork, and querying the DB in such events causes infinite loops. Doctrine attempts to flush the entity manager before running any query, which triggers flushing of entities, and postPersist/postUpdate events are triggered again. I did not checked, but the flush() before each query may be a performance problem too, if doctrine has to determine what has changed, depending on the changetracking policy. Also, it would be great if postPersist / postUpdate events were triggered after all entities have been persisted. It looks like that entities are flushed by groups of same 'type', and that events for a type are triggered once all of the elements of that group have been flushed, potentially before entities of an other type have been flushed : postPersist / postUpdate events are triggered while some other entities are still not flushed.  Comments  Comment by Benjamin Eberlei [ 03/Sep/10 ] That is documented and for perfomance reasons we cannot move the preUpdate/postUpdate/prePersist/postPersist events to other locations inside the UnitOfWork. There is an onFlush event that allows for more flexibility and is triggered before any update/insert/delete is done by the UnitOfWork. Comment by arnaud-lb [ 04/Sep/10 ] Thanks. I understand that. Is there any chance of getting some onPostFlush or similar, which would be triggered like onFlush, but after all update/insert/delete ? Or just some post-something event which is allowed to issue db queries. Comment by Gediminas Morkevicius [ 24/Sep/10 ] onFlush you can store your entity for furher processing and on postPersist you can check if there are no more insertions and process the entity if it needs additional query I have faced all these issues and you can check http://github.com/l3pp4rd/DoctrineExtensions/tree/master/lib/DoctrineExtensions/Translatable/ for a solution to your problem Comment by Gediminas Morkevicius [ 14/Jan/11 ] I think this issue should be closed since the main reason of opening it was the possibility to execute additional queries when inserts were pending in unit of work. In current release it does not cause a flush during an additional query execution anymore. ### [DDC-779] Doctrine\ORM\Configuration should be immutable after construction of EntityManager Created: 30/Aug/10 Updated: 30/Aug/10 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: 2.0-BETA3 Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None  Description  Currently the Doctrine\ORM\Configuration instance is not immutable after construction of the EM, which can lead to funny behavior when changing essential dependencies such as caches or others. ### [DDC-769] Disabling discriminator column in WHERE clause Created: 26/Aug/10 Updated: 07/Sep/10 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: 2.0-BETA3 Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: Lars Strojny Assignee: Roman S. Borschel Resolution: Unresolved Votes: 1 Labels: None  Description  Per default Doctrine 2 adds an IN(...)-part to the query when hydrating an entity where a discriminator column is defined. While this makes sense as a default behavior, it would be pretty helpful if one could disable the WHERE-clause for discriminator columns alltogether for performance optimization.  Comments  Comment by Roman S. Borschel [ 26/Aug/10 ] That would obviously produce wrong results. Maybe you can elaborate more with an example. Comment by Lars Strojny [ 07/Sep/10 ] I use ENUM("foo","bar") as discriminator columns. That means, the column will contain the right values out of the box, no further result set limiting required with WHERE. ### [DDC-1270] Incorrect QueryBuilder example Created: 11/Jul/11 Updated: 11/Jul/11 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: 2.1 Fix Version/s: None Security Level: All  Type: Documentation Priority: Major Reporter: Alex Bogomazov Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None  Description  In the QueryBuilder section of the documentation (http://www.doctrine-project.org/docs/orm/2.1/en/reference/query-builder.html#the-expr-class) there's an example with statements like $qb->expr()->select('u')  But this doesn't work anymore.

 Comment by Michael Ridgway [ 11/Jul/11 ]

### [DDC-1269] Unexpected behavior while using association on a non primary key field Created: 11/Jul/11  Updated: 13/Jul/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: 2.1
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Alexandr Torchenko Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Reference is referenced by DDC-1114 Association on a non primary key fiel... Closed

 Description
 We have association on non primary key. Something like this: Entities\Payment: type: entity table: payments fields: id: id: true type: integer nullable: false generator: strategy: IDENTITY [-- skipped --] manyToOne: order: targetEntity: Entities\Order inversedBy: payments joinColumn: name: scode referencedColumnName: scode  Entities\Order: type: entity table: h_orders fields: id: id: true type: integer unsigned: false nullable: false generator: strategy: IDENTITY scode: type: integer unsigned: false nullable: false [-- skipped --] oneToMany: payments: targetEntity: Entities\Payment mappedBy: order  When I try to fetch Order from Payment with lazy loading I receive empty Order object with null properties. If I use eager fetching Order object is valid. SQL generated for lazy loading seems to be valid, so I suppose the problem is in mapping result to the object. At the same time lazy loading works fine with 2.0.6 version. Another problem appears while persisting new Payment. $payment = new \Entities\Payment(); ...$order = $this->em->getRepository('\Entities\Order')->find(46320);$payment->setOrder($order);$order->addPayments($payment);$this->em->persist($payment);$this->em->flush();  I get this error: Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'scode' cannot be null' in /usr/share/php/Doctrine/DBAL/Statement.php:131 I found issue which is still open and looks like mine – http://www.doctrine-project.org/jira/browse/DDC-1114. What do you think about this?

 Comment by Benjamin Eberlei [ 12/Jul/11 ] Formatting, please add a second ticket for the second issue. Comment by Benjamin Eberlei [ 12/Jul/11 ] I don't think its supported to use a non primary id for foreign key matching. I cant tell for sure though since i wasnt responsible to design this part of the Doctrine code. I would strongly suggest not to do this. Comment by Benjamin Eberlei [ 12/Jul/11 ] Marked as improvement. The problem is we cannot detect this invalid mapping, so no exception is thrown during compilation of the mappings, Comment by Benjamin Eberlei [ 12/Jul/11 ] This kind of mapping error is already acknowledged by the schema-validator console task. Comment by Alexandr Torchenko [ 13/Jul/11 ] Should I create second ticket? Please confirm that I understood correctly. Should we avoid such mapping as it is considered as invalid. Comment by Benjamin Eberlei [ 13/Jul/11 ] Yes, it will not work at all. You dont need to create the second ticket as that error steams from the mapping error. You will see an error message when calling ./doctrine orm:schema:validate with this mapping.

### [DDC-1263] @ManyToOne Arbitrary References Created: 09/Jul/11  Updated: 09/Jul/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: New Feature Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Could it be possible to allow for arbitrary many to one entities through a "class + id" construct as join columns?

### [DDC-1259] Atomic creation of Proxy files Created: 08/Jul/11  Updated: 09/Jul/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 From 265e5086ea51ebcafc73f91abc64334d17e2f416 Mon Sep 17 00:00:00 2001 From: Karsten Dambekalns Date: Wed, 25 May 2011 12:11:55 +0200 Subject: [PATCH 4/5] Use temporary file and rename for proxy class creation Instead of a simple file_put_contents() the proxy class code is written to a temporary file and renamed to the final filename. This allows file access even if only allowed by the directory permission. --- lib/Doctrine/ORM/Proxy/ProxyFactory.php | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/lib/Doctrine/ORM/Proxy/ProxyFactory.php b/lib/Doctrine/ORM/Proxy/ProxyFactory.php index f0cf19c..b2d42fb 100644 --- a/lib/Doctrine/ORM/Proxy/ProxyFactory.php +++ b/lib/Doctrine/ORM/Proxy/ProxyFactory.php @@ -152,7 +152,15 @@ class ProxyFactory $file = str_replace($placeholders, $replacements,$file); - file_put_contents($fileName,$file, LOCK_EX); + $temporaryFileName =$fileName . uniqid( ) . '.temp'; + $result = file_put_contents($temporaryFileName, $file ); + + if($result === FALSE) throw new \RuntimeException('The temporary proxy class file "' . $temporaryFileName . '" could not be written.'); +$i = 0; + while(!rename( $temporaryFileName,$fileName ) && $i < 5) { +$i++; + } + if($result === FALSE) throw new \RuntimeException('The proxy class file "' .$fileName . '" could not be written.'); } /** -- 1.7.4.1 

 Comment by Benjamin Eberlei [ 09/Jul/11 ] Nette Framework uses a safe stream: https://github.com/nette/nette/blob/master/Nette/Utils/SafeStream.php

### [DDC-1235] Provide fluent interfaces in stub methods Created: 28/Jun/11  Updated: 29/Oct/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Andreas Hörnicke Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Or maybe some template-files could be provided for all stubs. private static $_setMethodTemplate = '/** * * * @param$ */ public function ($) {$this-> = $; return$this; }'; 

 Comment by Christophe Coevoet [ 29/Oct/12 ] @beberlei this should be closed as it is the case since 2.2

### [DDC-1217] Use the DBAL ReservedKeywordsValidator in orm:validate-schema Created: 20/Jun/11  Updated: 20/Jun/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: Tools
Affects Version/s: 2.0.6, Git Master
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Christophe Coevoet Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 DBAL provides a ReservedKeywordsValidator to check whether a word is reserved. But this tool is not used by the ORM when validating the schema. It would be useful to use it to avoid WTF from users getting a PDOException when creating their schema because of this. The other solution if you don't want to add this in orm:validate-schema would be to create a dedicated command.

### [DDC-1201] DQL Example about count(*) related entity is wrong Created: 10/Jun/11  Updated: 10/Oct/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: Documentation
Affects Version/s: 2.1.1
Fix Version/s: None
Security Level: All

 Type: Documentation Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 1 Labels: None

 Description
 DQL Example about count related entity is wrong

 Comment by Aigars Gedroics [ 10/Oct/11 ] Also similar DQL in documentation URL http://www.doctrine-project.org/docs/orm/2.1/en/reference/dql-doctrine-query-language.html#pure-and-mixed-results fails parsing stage: $dql = "SELECT u, 'some scalar string', count(u.groups) AS num FROM User u JOIN u.groups g GROUP BY u.id";  with error  [Doctrine\ORM\Query\QueryException] [Semantical Error] line 0, col 40 near 'localizations)': Error: Invalid PathExpression. StateFieldPathExpression or SingleValuedAssociationField expected.  Should be "count(g.id)" instead of "count(u.groups)". ### [DDC-1197] Proxies should handle variable argument lists Created: 05/Jun/11 Updated: 05/Jun/11 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: None Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None  Description  This is a contingency issue for https://github.com/doctrine/doctrine2/pull/60 "Fix to allow for proxy generated classes to respect methods in parent which may use func_get_args internally. Previously they would be passed nothing and thus fail. Also reduces need to build up argumentString. " ### [DDC-1164] doctrine:schema:update --force == doctrine:schema:create Created: 20/May/11 Updated: 20/May/11 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: None Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: Geoff Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None  Description  Doctrine:schema:update --force is the same as doctrine:schema:create. Under the hood, this may not be true, but they basically accomplish the same task. Schema:create should be removed, as it is redundant. Just look at django, one command to update db: ./manage.py syncdb Not saying that django gets everything correct, but the one command to synchronize the database is consistent. doctrine:schema:update should be smart enough to do all of the work, instead of relying on the redundant doctrine:schema:create. ### [DDC-1154] Proxies should take convention while loading *ToOne associations to reduce 1 extra query Created: 17/May/11 Updated: 17/May/11 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: None Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: Guilherme Blanco Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None  Description  Read the IRC log: [2:38pm] guilhermeblanco: beberlei: ping [2:38pm] guilhermeblanco: I'm curious about a feature if Doctrine supports [2:38pm] guilhermeblanco: if we do this on a proxy: [2:38pm] guilhermeblanco:$proxy->getOneToOneAssoc() [2:39pm] guilhermeblanco: shouldn't Doctrine already populate the assoc entity? [2:39pm] guilhermeblanco: it would be an inner join [2:39pm] beberlei: how would doctrine know it needs it? [2:39pm] guilhermeblanco: beberlei: it always repass the ClassMetadata to Persister [2:40pm] guilhermeblanco: so all needed item is to also pass the fieldname/assocname [2:40pm] beberlei: but how would doctrine know getOneToOneASsoc() really returns this assoc [2:40pm] beberlei: it could contain any logic [2:40pm] guilhermeblanco: it wouldn't... but as soon as we trigger __load($fieldName) [2:40pm] guilhermeblanco: we know that we could populate not only the Proxy, but also assoc [2:40pm] beberlei: by convention? [2:40pm] guilhermeblanco: ya [2:41pm] beberlei: sounds good, can you open a ticket? [2:41pm] guilhermeblanco: getUser() would trigger __load('user') [2:41pm] guilhermeblanco: sure! [2:41pm] guilhermeblanco: I'll pastie this as content... it would be awesome to have [2:41pm] guilhermeblanco: I see a lot of queries here that could be optimized  ### [DDC-1143] deprecated or missing method,$cacheDriver->setManageCacheIds(true); Created: 10/May/11  Updated: 10/May/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: 2.0.4
Fix Version/s: None
Security Level: All

 Type: Documentation Priority: Major Reporter: raiz Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description

### [DDC-1137] SchemaTool#getUpdateSchemaSql() does not respect database identifier in table names Created: 05/May/11  Updated: 14/May/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM, Tools
Affects Version/s: 2.0.4
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Hugh Lomas Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None Environment: Linux 2.6.18-194.32.1.el5.centos.plus x86_64 GNU/Linux

 Description
 Given two databases, 'foo' and 'bar', with entities in /Entities/Foo/ annotated as follows: /** * Test * * @Table(name="foo.test") * @Entity */  Create an EntityManager instance with $connectionOptions = array( 'dbname' => 'Foo', 'driver' => 'pdo_mysql', <..etc..> ); Use EntityManager#getClassMetaData( "Entities\\FooTest" ) to pass to SchemaTool#createSchema() and Doctrine appropriately creates a database table foo.test Use EntityManager#getClassMetaData( "Entities\\FooTest" ) to pass to SchemaTool#updateSchema() and Doctrine fails with Exception -> SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'test' already exists Inserting die( print_r($fromSchema, 1 ) . print_r( $toSchema, 1 ) . print_r($schemaDiff, 1 ) ); into Doctrine/ORM/Tools/SchemaTool.php line 632 shows $fromSchema outputs [_tables:protected] => Array ( [test] but$toSchema outputs [_tables:protected] => Array ( [foo.test] which causes $schemaDiff to output [newTables] => Array ( [foo.test] In summary, Doctrine/DBAL/Schema/Comparator considers foo.test a new table, because Doctrine/DBAL/Schema/AbstractSchemaManager lists its table as "test" rather than "foo.test".  Comments  Comment by Hugh Lomas [ 05/May/11 ] It seems that changing AbstractSchemaManager.php to the following corrected the issue for me, however I am not sure of any repercussions that may arise as a result, being unfamiliar with the codebase. Doctrine/DBAL/Schema/AbstractSchemaManager.php line 228 return new Table($tableName, $columns,$indexes, $foreignKeys, false, array()); Doctrine/DBAL/Schema/AbstractSchemaManager.php line 228 return new Table($this->_conn->getDatabase() . "." . $tableName,$columns, $indexes,$foreignKeys, false, array()); Comment by Benjamin Eberlei [ 14/May/11 ] Multi databases are not supported by schema manager and schema tool yet.

### [DDC-1106] Wrong inversedBy in example Created: 07/Apr/11  Updated: 07/Apr/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Documentation Priority: Major Reporter: cristobal castro Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Attachments: screen-shot.zip

 Description
 on page http://www.doctrine-project.org/docs/orm/2.0/en/reference/working-with-objects.html section : 8.1. Association Example Entities, first example. Please see the .jpg in attachement(it explains clearly what I think is an error) Regards.

### [DDC-1038] there are tabs in the code base Created: 16/Feb/11  Updated: 16/Feb/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Task Priority: Major Reporter: Lukas Kahwe Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 a quick search through the ORM code base finds quite a few tabs. other doctrine projects there might also be some, though in common i only found some inside the LGPL license file.

MsSQL-Server DateTime microseconds issue (DDC-1028)

### [DDC-1032] ensure the dateformat Y-m-d gets used by the MsSQL-Server 2005 Created: 14/Feb/11  Updated: 14/Feb/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.0.1
Fix Version/s: None
Security Level: All

 Type: Sub-task Priority: Major Reporter: Martin Weise Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None Environment: php5.3.5; MsSQL-Server 2005; W2K8; Apache2; MS pdo_sqlsrv_ts_vc6 driver

 Description
 To ensure that the MsSQL-Server 2005 (and maybe higher) uses the format that is specified in the MsSqlPlatform class (Y-m-d) set it via 'SET DATEFORMAT ymd' . This should be done directly after the connection has be opened.

 Comment by Martin Weise [ 14/Feb/11 ] Issue created as wished from Juozas Kaziukenas.

### [DDC-1025] Please repalce 'Doctrine\XXX\YYY' with '\Doctrine\XXX\YYY' in code and document Created: 09/Feb/11  Updated: 13/Dec/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: Documentation, DQL, Mapping Drivers, ORM, Tools
Affects Version/s: 2.0.1
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: ben yan Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 7 Labels: None

 Description
 It will help us use the namespace and code autocomplete in some IDE.

### [DDC-948] incorrect link from the types page to known vendor issues Created: 25/Dec/10  Updated: 25/Dec/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: Documentation
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Documentation Priority: Major Reporter: Lukas Kahwe Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Also noticed that the documentation still says "Doctrine DBAL v2.0.0-BETA4 documentation"

 Comment by Lukas Kahwe [ 25/Dec/10 ] err sorry .. this is of course a DBAL doc issue not and ORM issue.

### [DDC-946] Evaluate optional use of igbinary for serialization Created: 22/Dec/10  Updated: 22/Dec/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Roman S. Borschel Resolution: Unresolved Votes: 1 Labels: None

 Description
 Igbinary is supposed to be faster and better than serialize/unserialize(). We should check if its relevant for us (metadata and query caching for example): https://github.com/phadej/igbinary

 Comment by Benjamin Eberlei [ 22/Dec/10 ] http://ilia.ws/archives/211-Igbinary,-The-great-serializer.html#extended

### [DDC-930] A table cannot have more than one many to many relationship with the same table when using reverse engineer Created: 13/Dec/10  Updated: 13/Dec/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: Mapping Drivers
Affects Version/s: 2.0-RC2
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Jiri Helmich Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None Environment: FreeBSD, PostgreSQL 8.4

 Description
 This is caused by taking the join column name as the identifier while generating a property name for annotation. The mapping driver detects that the same property is already defined and ends the convert process. A little bit smarter approach for me was to take the local table name. But this assumes a specific style of join table naming convention. Doctrine\ORM\Mapping\Driver\DatabaseDriver::loadMetadataForClass() Replace: $associationMapping['fieldName'] = Inflector::camelize(str_replace('_id', '', strtolower(current($otherFk->getColumns())))); With: $name = explode("_",$myFk->getLocalTableName()); if (count($name) > 1) { array_shift($name); } $name = implode("_",$name); $associationMapping['fieldName'] = Inflector::camelize(str_replace('_id', '', strtolower($name))); Maybe to switch to this behavior with an additional option?

### [DDC-923] Add note about DateTime Query Parameter Type Hint Created: 10/Dec/10  Updated: 10/Dec/10

Status: Open
Project: Doctrine 2 - ORM
Component/s: Documentation
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Documentation Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

### [DDC-919] subselect Created: 08/Dec/10  Updated: 20/Mar/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: Documentation
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Documentation Priority: Major Reporter: Mungiu Dragos Assignee: Roman S. Borschel Resolution: Unresolved Votes: 0 Labels: None

 Description
 i'd like to see more example in documentation with this subselects [23:08] can you open a tciket on jira? then i dont forget to do that when i have time

 Comment by Alberto [ 20/Mar/11 ] Subselect as columns or FROM clause should have mor examples.

### [DDC-1484] GH-162: ProxyFactory creates proxy's parent structure if it doesn't exist Created: 08/Nov/11  Updated: 26/Jun/12

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 Pull-Request was automatically synchronized: https://github.com/doctrine/doctrine2/pull/162 Wheeee, nested proxies can be generated without hassle!

 Comment by Benjamin Eberlei [ 13/Nov/11 ] Marked as improvement Comment by Benjamin Eberlei [ 16/Jun/12 ] A related Github Pull-Request [GH-162] was opened https://github.com/doctrine/dbal/pull/162 Comment by Benjamin Eberlei [ 26/Jun/12 ] A related Github Pull-Request [GH-162] was closed https://github.com/doctrine/dbal/pull/162

### [DDC-1475] Documentation for One-To-Many, Bidirectional Association does not have YAML example Created: 07/Nov/11  Updated: 07/Nov/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: Documentation
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Documentation Priority: Major Reporter: Christian Stoller Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 When you are looking for a config example for the bidirectional mapping of an one-to-many association you will just find an example with XML, but not with YAML or PHP. It would be nice if somebody could add an example or a link to the bidirectional one-to-one association, because it should be the same, right? Here the link to the example: http://www.doctrine-project.org/docs/orm/2.0/en/reference/association-mapping.html#one-to-many-bidirectional

### [DDC-1465] Fetching partial objects doesn't work if HINT_FORCE_PARTIAL_LOAD is not explicitly used Created: 02/Nov/11  Updated: 11/Nov/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: DQL
Affects Version/s: 2.1.2
Fix Version/s: None
Security Level: All

 Type: Bug Priority: Major Reporter: Julien Pauli Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 1 Labels: None

 Duplicate duplicates DDC-624 Partial object query that leaves out ... Open

 Description
 Using the DQL "partial" keyword is not enough to get a partial entity as a result. The DQL hint HINT_FORCE_PARTIAL_LOAD must be used as well. $q =$em->createQuery('SELECT partial r.{id,comment} FROM Entities\Rating r WHERE r.id=3'); $r =$q->getResult() /* HYDRATE_OBJECT is the default hydration mode */  Here, $r contains the full Entity, a SELECT * has been sent $q = $em->createQuery('SELECT partial r.{id,comment} FROM Entities\Rating r WHERE r.id=3');$q->setHint(Doctrine\ORM\Query::HINT_FORCE_PARTIAL_LOAD, 1); $r =$q->getResult() /* HYDRATE_OBJECT is the default hydration mode */  Here, $r contains only the selected fields, hence a true partial Entity ### [DDC-1459] Move DDC-331, DDC-448, DDC-493, DDC-513, DDC-698 Tests into SQLGeneration Testsuite Created: 29/Oct/11 Updated: 01/Aug/12 Status: Open Project: Doctrine 2 - ORM Component/s: None Affects Version/s: None Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None ### [DDC-1443] Subscribers reachs maximum nesting level when creating association on pre/postPersist with cascade persist Created: 20/Oct/11 Updated: 29/Oct/11 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: Git Master Fix Version/s: None Security Level: All  Type: Bug Priority: Major Reporter: Guilherme Blanco Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None  Attachments: DDC1443Test.php DDC1443Test.php  Description  Suppose a situation where: A -> B Where the OneToOne unidirectional association contains cascade persist. If I decide to save an entity B that should create an A instance, it goes into maximum nesting level no matter if I track prePersist or postPersist.  Comments  Comment by Guilherme Blanco [ 20/Oct/11 ] Failing test case Comment by Guilherme Blanco [ 20/Oct/11 ] Uploading a new version, now passing successfully, but consuming the onFlush event (which should not be ideal). Comment by Benjamin Eberlei [ 29/Oct/11 ] Ah yes, this never worked. The transaction stuff will fix that. You have to use scheduleForInsert() something inside prePersist. ### [DDC-1441] Metadata cannot be loaded for not registered proxy objects Created: 20/Oct/11 Updated: 05/Apr/12 Status: Open Project: Doctrine 2 - ORM Component/s: ORM Affects Version/s: 2.1.2 Fix Version/s: None Security Level: All  Type: Improvement Priority: Major Reporter: Aigars Gedroics Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None Environment: MySQL, Ubuntu, PHP 5.3.6  Attachments: DDC1441Test.php not-loaded-proxy-patch.diff  Description  We are using several Doctrine managers in our project with the same entity classes and different database tables. The problem appears when we are willing to merge entity with lazy associations from one manager to another. The second entity manager instance hasn't got the proxy object metadata defined yet so it fails with Doctrine\ORM\Mapping\MappingException exception "Class EntityProxy is not a valid entity or mapped super class.". If both entity managers share the proxy objects the problem can be fixed by calling $em->getProxyFactory()->getProxy('Entity', -1);  which will register the entity metadata for the proxy classname as well. Still if the proxy configuration differs, there is no fix found without changing the Doctrine ORM code. The fix inside the Doctrine would be to detect Proxy classes before loading the metadata and load the metadata for it's parent class instead. Please see the diff attached with proposed solution. Also I think this issue could arise when unserialized entity objects will be merged into the entity manager. I will try creating test case for this.

 Comment by Aigars Gedroics [ 24/Nov/11 ] Test case attached. Comment by Aigars Gedroics [ 05/Apr/12 ] See my pull request in https://github.com/doctrine/doctrine2/pull/332.

### [DDC-1438] Add test for DDC-1437 Created: 19/Oct/11  Updated: 19/Oct/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description

### [DDC-1429] Add a method to the unit of work that merges any detached entity into UoW without calling SQL Created: 17/Oct/11  Updated: 17/Oct/11

Status: Open
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: None
Fix Version/s: None
Security Level: All

 Type: Improvement Priority: Major Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None

 Description
 This is for those that know what they are doing

### [DDC-1390]  Lazy loading does not work for the relationships of an entity instance, whose class inherits from another entity class Created: 22/Sep/11  Updated: 06/Jan/13

Status: In Progress
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.1.1
Fix Version/s: None
Security Level: All

 Type: Bug Priority: Major Reporter: Daniel Alvarez Arribas Assignee: Benjamin Eberlei Resolution: Unresolved Votes: 0 Labels: None Environment: Debian Linux 6.0, MySQL 5.0.51a

 Attachments: CommissionNoteCreatorResult.php     ConsumerInvoiceExporterResult.php     DataObject.php     DataVersion.php     DDC1390Test.php     InvoiceCreatorResult.php     Result.php     Run.php

 Description
 Lazy loading does not work for the relationships of an instance of an entity, whose class inherits from another entity class. Assume there are two entity classes, A and B, where A inherits from B. Now let $a be an instance of A, e. g. the result of "SELECT a FROM \A WHERE a.id = 1". Outputting$a will confirm it is a valid instance of a proxy object inheriting from A. Assume that the database row corresponding to $a contains a non-null foreign key that actually links to an existing row in another table, corresponding to another entity instance of a different class. Now,$a->someRelationship will always returns null in this scenario. I assume this is unintended behaviour, because clearly, the other entity should be lazily loaded on accessing it, and there is a value in the database. The fetch annotation attribute on that relationship has not been explicitly set, so I assume it is set to the default value, which, according to the docs, should be "lazy". The loading only fails when accessing the relationships of an entity instance, whose class inherits from another entity class. For entity instances, whose classes do not inherit from another entity class, lazy loading of their relationships works as expected. I had a look at the proxy objects and verified that they are present and override the __get method with an implementation containing a call to the load() method. Still, the loading won't work for some reason. This could be related to Bug DDC-1389 (http://www.doctrine-project.org/jira/browse/DDC-1389) which also happens exclusively in an inheritance scenario. Maybe the current implementation of inheritance is generally wrong or incomplete.