[DBAL-276] MySQL schema manager should not make assumptions about non-DBAL types Created: 16/May/12 Updated: 27/May/12 Resolved: 27/May/12 |
|
| Status: | Resolved |
| Project: | Doctrine DBAL |
| Component/s: | Schema Managers |
| Affects Version/s: | 2.1.6 |
| Fix Version/s: | 2.1.7, 2.2.3 |
| Security Level: | All |
| Type: | Bug | Priority: | Major |
| Reporter: | Lachlan Pease | Assignee: | Benjamin Eberlei |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Macintosh OS X 10.7.2 |
||
| Description |
|
When using the DBAL MySQL schema manager to create migrations or update the schema directly, it can create conflicts with custom types due to the way it processes some non-DBAL types in _getPortableTableColumnDefinition. I recently implemented a binary-string type, using the MySQL BINARY/VARBINARY columns (as opposed to blob, which I see has been adopted in 2.2), due to the content for my application always being a 60 byte binary string. Doctrine has been working fine with it, but upon generating my next migration, I discovered that the schema manager wanted to re-set the column's length. It appears that this is caused by lines 138 & 139 of MySqlSchemaManager.php clearing the column's length. There doesn't seem to be any other code pertaining to MySQL and binary/varbinary, so removing these two lines should be safe and save trouble for future users, without causing issues for those who choose to implement it as a blob or similar. |
| Comments |
| Comment by Benjamin Eberlei [ 27/May/12 ] |
|
Fixed |
[DBAL-240] SQL Parser Utils trigger error when uing with Type instances Created: 24/Mar/12 Updated: 24/Mar/12 Resolved: 24/Mar/12 |
|
| Status: | Resolved |
| Project: | Doctrine DBAL |
| Component/s: | None |
| Affects Version/s: | 2.1.6, 2.2.1 |
| Fix Version/s: | 2.1.7, 2.2.2 |
| Security Level: | All |
| Type: | Bug | Priority: | Major |
| Reporter: | Benjamin Eberlei | Assignee: | Benjamin Eberlei |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
https://github.com/doctrine/dbal/pull/120 |
| Comments |
| Comment by Benjamin Eberlei [ 24/Mar/12 ] |
|
Fixed and merged into 2.1 and 2.2 |