This issue is created automatically through a Github pull request on behalf of

:

Url: https://github.com/doctrine/couchdb-odm/pull/22

Message:

In AnnotationDriver#loadMetadataForClass() it was incorrectly assumed that an array of annotations indexed by annotation name was returned; in fact a numerically indexed array is received. This patch fixes the identification of the annotations that are present.

Since only one Document realted annotation should be present the method now also throws an exception if more than one is found. (One could just use the first annotation, but this may cause confusion when debugging.)

Not sure if this was the only outstanding problem related to issue CODM-28 but I think it was related.

This issue is created automatically through a Github pull request on behalf of

:

Url: https://github.com/doctrine/couchdb-odm/pull/23

Message:

The UpdateAllDesignDocsCommand checks which design documents have changed and updates only those and also pushes new design docs to the db. A method for retrieving the registered design doc names was added to the Configuration class since this is needed when checking which docs have been modified.

It took me quite a while to figure out that I should be using the couchdb:odm:update-design-doc command to write the ODM design docs which are included in the config by default to the db. I think the presence of this command would make it clearer that it could be run to sort out any missing design docs.

I also reckon it may become a bit tedious to add each modified doc individually, now they can be updated in one go.

In UnitOfWork on line 656 the oid is used to index the identity map instead of the document id when detaching an object. This is probably due to an incomplete port from the ORM. The following change fixes the bug (I will make the change and request a merge):

Currently:
656: if (isset($this->identityMap[$oid])) {

Should be:
656: if (isset($this->identityMap[$this->documentIdentifiers[$oid]])) {

Further suggestion

Since the document id is guaranteed to be unique would it not be better to do away with the oid completely? It seems the following would be a relatively cheap substitute for the current getDocumentIdentifier() implementation (excluding the check that it is managed which is also currently done in this method):

public function getDocumentIdentifier($document)
{
$class = $this->dm->getClassMetadata(get_class($document));
return $class->getIdentifierValue($document);
}

Then all the arrays in the UnitOfWork can be indexed using the document id and the above method can be called to obtain that wherever spl_object_hash is currently used to obtain the $oid. (Of course, if running spl_object_hash is faster than retrieving the doc id as I suggest above then the current implementation is better.)

On the CouchDb ODM install instructions
(http://www.doctrine-project.org/projects/couchdb_odm/1.0/download/1.0.0ALPHA1)
you have the following line to clone the git repository which specifies a local folder "mongodb_odm" instead of "couchdb_odm".
Just a minor inconvenience when copy and pasting from the site.

Current:

$ git clone git://github.com/doctrine/couchdb-odm.git mongodb_odm

Should be:

$ git clone git://github.com/doctrine/couchdb-odm.git couchdb_odm

Removing a reference fails because _rev is not set.

Inverse collections are only supported when using the doctrine metadata resolver. ClassMetadataFactory should already throw an exception here if misused.

Support inheritance of objects.

As a first step to support inheritance we need support for mapped superclasses.

We need support for nested value objects through the @EmbedMany and @EmbedOne annotations.

The CouchDBClient should implement all important CouchDB API functionality in simple method calls.

Currently attachments are handled in memory if accessed through the attachment proxy. This can be rather expensive in cases and we should allow HTTP Clients to stream requests and use this functionality for the attachments.

Metadata is currently parsed on every request.

A caching layer for the ClassMetadata instances has to be implemented to work like in ORM or MongoDB ODM.

Implement Cascade Refresh

Implement Cascade Persist

Implement Cascade Detach

Implement Cascade Merge

Add Value Object Support:

Need an annotation that allows to specify value objects. Need mechanism to serialize/deserialize deeply nested value objects or arrays of value objects in UnitOfWork()

Add Cascade Operations to Associations

Add DocumentManager::merge() and DocumentManager::detach()

Couch-Lucene is a very nice tool to enhance CouchDB with lucence query api natively:

https://github.com/rnewson/couchdb-lucene

The Version field should be an instance of the CouchDB document revision on the document class. It should be updated on flushes and be usable on find by id methods to check for optimistic locking.

http://guide.couchdb.org/draft/validation.html

See CODM-7

http://guide.couchdb.org/draft/validation.html

See CODM-8

query view's, add limit/sort order/include_docs option etc.

In the ORM we have the Doctrine\DBAL\Types namespace that we have to mirror to Doctrine\ODM\CouchDB\Types. Methods would have to be "convertPhpToJsonValue()" and "convertJsonToPhpValue()" that need to be called during hydration and saving inside the Persister.

Possible Types for now:

• String (this is both VARCHAR + CLOB of DBs)
• Integer
• Array (uncasted values)
• Float/Double * Boolean