Doctrine Project

Doctrine Project http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us

5.2.7

850

21-02-2013

[PHPCR-42] sync the xml/yml mapping driver with the annotation driver http://www.doctrine-project.org/jira/browse/PHPCR-42 Doctrine PHPCR <p>especially the locale/version stuff is not yet supported. but also the reference mapping seems to look quite different.</p> PHPCR-42

sync the xml/yml mapping driver with the annotation driver

Bug Major Resolved Fixed Lukas Kahwe Lukas Kahwe Wed, 25 Jan 2012 16:37:55 +0000 Fri, 17 Aug 2012 08:17:16 +0000 Fri, 17 Aug 2012 08:17:16 +0000 0 2 <p>versioning is done now: <a href="https://github.com/doctrine/phpcr-odm/pull/96" class="external-link">https://github.com/doctrine/phpcr-odm/pull/96</a></p> <p>but we miss tests for the non-annotation mappings</p> <p>how to proceed:</p> <ul> <li>Refactor the tests about mapping to have abstract base tests to assert things, and one test for each annotation/yml/xml/php so we really test the same outcome <a href="https://github.com/doctrine/phpcr-odm/tree/master/tests/Doctrine/Tests/ODM/PHPCR/Mapping" class="external-link">https://github.com/doctrine/phpcr-odm/tree/master/tests/Doctrine/Tests/ODM/PHPCR/Mapping</a></li> <li>Check with code coverage of <a href="https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Mapping/Driver/AnnotationDriver.php" class="external-link">https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Mapping/Driver/AnnotationDriver.php</a> and <a href="https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Mapping/ClassMetadata.php" class="external-link">https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Mapping/ClassMetadata.php</a> if everything is covered</li> <li>Fix missing annotations</li> <li>Also test invalid metadata values or combinations - they should throw the same errors with all mappings</li> <li>Check the documentation for meta data in the readme. add some note about xml/yml/php format (but do not repeat the doc, just explain the differences)</li> </ul> <p>initial test for annotations is added here, please evolve from this<br/> <a href="https://github.com/doctrine/phpcr-odm/commit/38f8bbc8b655aafd099287e18401248c44b40492" class="external-link">https://github.com/doctrine/phpcr-odm/commit/38f8bbc8b655aafd099287e18401248c44b40492</a></p> <p>hi dbu, lsmith, i gave thought to this and did some corrections <a href="https://github.com/doctrine/phpcr-odm/pull/133" class="external-link">https://github.com/doctrine/phpcr-odm/pull/133</a></p> <p>however I am totally disoriented as i see two Mapping folders as follows:</p> <p>1. <a href="https://github.com/doctrine/phpcr-odm/tree/master/tests/Doctrine/Tests/ODM/PHPCR/Functional/Mapping" class="external-link">https://github.com/doctrine/phpcr-odm/tree/master/tests/Doctrine/Tests/ODM/PHPCR/Functional/Mapping</a><br/> There is only 1 class here with a TODO which i found not very clear about what to do next</p> <p>2. <a href="https://github.com/doctrine/phpcr-odm/tree/master/tests/Doctrine/Tests/ODM/PHPCR/Mapping" class="external-link">https://github.com/doctrine/phpcr-odm/tree/master/tests/Doctrine/Tests/ODM/PHPCR/Mapping</a><br/> These set of classes was already refactored by someone else before I came in and I guess the work is done</p> <p>I check the coverage as you said on the annotation driver class so it basically lacks the lifecycle callbacks usage, but where to put these tests in as i am confused</p> <blockquote> <p><font color="red"> <br/> 160 0 : if ($annot instanceof ODM\PrePersist) { 161 0 : $metadata->addLifecycleCallback($method->getName(), Event::prePersist); 162 0 : } elseif ($annot instanceof ODM\PostPersist) { 163 0 : $metadata->addLifecycleCallback($method->getName(), Event::postPersist); 164 0 : } elseif ($annot instanceof ODM\PreUpdate) { 165 0 : $metadata->addLifecycleCallback($method->getName(), Event::preUpdate); 166 0 : } elseif ($annot instanceof ODM\PostUpdate) { 167 0 : $metadata->addLifecycleCallback($method->getName(), Event::postUpdate); 168 0 : } elseif ($annot instanceof ODM\PreRemove) { 169 0 : $metadata->addLifecycleCallback($method->getName(), Event::preRemove); 170 0 : } elseif ($annot instanceof ODM\PostRemove) { 171 0 : $metadata->addLifecycleCallback($method->getName(), Event::postRemove); 172 0 : } elseif ($annot instanceof ODM\PostLoad) { 173 0 : $metadata->addLifecycleCallback($method->getName(), Event::postLoad); 174 0 : } </font></p></blockquote> <p>Also i am not very familiar with the schema of the annotation driver how to test so any explanation or help pointers would be great, thanks</p> <p>I am so not using jira sorry guys, ---> <a href="https://github.com/doctrine/phpcr-odm/pull/133" class="external-link">https://github.com/doctrine/phpcr-odm/pull/133</a></p> <p>@craigmarvelley started working on this, promised a pull request soon</p> <p>I've opened a PR here, there's still a bit left to be done that I'm hoping to add in the next few days.</p> <p><a href="https://github.com/doctrine/phpcr-odm/pull/144" class="external-link">https://github.com/doctrine/phpcr-odm/pull/144</a></p> <p>the pull request by craig has meanwhile been merged.</p> <p>there is still a bit of issues:</p> <p>the driver looks for the non-namespaced file. i.e. No mapping file found named '/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/routing-extra-bundle/Symfony/Cmf/Bundle/RoutingExtraBundle/Resources/config/doctrine/Route.phpcr.xml' for class 'Symfony\Cmf\Bundle\RoutingExtraBundle\Document\Route'.</p> <p>but if i put that file there and have an error, he tells me Invalid mapping file 'Symfony.Cmf.Bundle.RoutingExtraBundle.Document.Route.phpcr.xml'</p> <p>so the name determiner seems to be off a bit</p> <p>also, the mapped superclass feature makes no sense with phpcr-odm, we can simply inherit from document classes.</p> <p>actually mapped superclass seems to be relevant, but i did not yet understand it and the doc about it should be updated. see discussion in <a href="https://github.com/doctrine/phpcr-odm/pull/144#issuecomment-7095570" class="external-link">https://github.com/doctrine/phpcr-odm/pull/144#issuecomment-7095570</a></p> <p>seems to me like reference/referrer/translation/versioning is all done .. so if there is anything left .. please open a new ticket</p>